Commit Graph

9 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
nick darnell
bcaf4802ba SuperSearch - When iterating over properties to serialize for searching, we were ignoring EditInlineNew UObjects inside structs and arrays, leaving out precious search data. That is no longer the case, we now include those items in what we search.
#jira UE-144526
#preflight 621fcc99257fd6e09978c1f5
[REVIEW] [at]Michael.Noland

#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 19232364 in //UE5/Release-5.0/... via CL 19232504
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19234134 by nick darnell in ue5-main branch]
2022-03-02 19:26:17 -05:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
nick darnell
cb550a7185 Universal Search - Better search feedback in the window (throbber). Fixing all the versioning enums to not use explicit values for each entry, caused a bug where the database version didn't bump. This CL also bumps the database version, so will need to recreate the database for people, but also splitting out the file hashing database into its own database to avoid needing to rehash files in the future if the asset search database format changes.
#ROBOMERGE-SOURCE: CL 12149274 via CL 12153826 via CL 12153880
#ROBOMERGE-BOT: (v659-12123632)

[CL 12153981 by nick darnell in Main branch]
2020-03-12 16:16:22 -04:00
nick darnell
375872024a Universal Search now covers, Sound Cues, Dialogue Waves, Levels (including the Level Blueprint). Comments on blueprint nodes are now indexed.
Now hashing all assets that are indexed.  We now only generate a single DDC key.  AssetSearch_V{SerializerVersion}_{IndexersNamesAndVersions}_{ObjectPathHash}_{FileOnDiskHash}

The file hashes along with last modified are stored in the asset database to make quick lookup easy.

A project now has control over which directories to not index.



#ROBOMERGE-SOURCE: CL 12121509 via CL 12121510 via CL 12129837
#ROBOMERGE-BOT: (v659-12123632)

[CL 12129938 by nick darnell in Main branch]
2020-03-11 11:48:45 -04:00
nick darnell
eb83bb93df Re-enabling universal search, moving operations off the taskgraph and instead using its own low priority thread for handling feed/update/search requests through multiple buckets to permit prirotization and interrupting the queue. This should prevent the search module from hogging the task graph and preventing GC.
[FYI] Bob.Tellez


#ROBOMERGE-SOURCE: CL 11896304 via CL 11896307 via CL 11896309
#ROBOMERGE-BOT: (v656-11643781)

[CL 11896392 by nick darnell in Main branch]
2020-03-04 11:00:50 -05:00
nick darnell
5a0d464b1d Fixing some iwyu issues.
#ROBOMERGE-SOURCE: CL 11851027 via CL 11851028 via CL 11851031
#ROBOMERGE-BOT: (v656-11643781)

[CL 11883983 by nick darnell in Main branch]
2020-03-03 15:48:31 -05:00
nick darnell
b5c52e2bb4 Additional monolithic issues.
#ROBOMERGE-SOURCE: CL 11850652 via CL 11850665 via CL 11850666
#ROBOMERGE-BOT: (v656-11643781)

[CL 11883887 by nick darnell in Main branch]
2020-03-03 15:47:53 -05:00
nick darnell
408a67e108 Asset Search - Working on a new plugin to make it possible to index lots of differnet types of assets and search across a wide swath of them to find information such as text inside a data table.
Not done yet, still marking it as beta.  Not enabled by default.



#ROBOMERGE-SOURCE: CL 11850262 via CL 11850267 via CL 11850272
#ROBOMERGE-BOT: (v656-11643781)

[CL 11883741 by nick darnell in Main branch]
2020-03-03 15:46:42 -05:00