Commit Graph

21 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
nick darnell
6ab595d25a Super Search - Adding initial integrity checking right after opening the database, and changing the sychronization to full for the file and search databases, they were getting corrupted too often under "normal" mode.
#jira UE-142177
#preflight 62066864963efc0c28d91b56
#rb jeanmichel.dignard
#lockdown jeanmichel.dignard

#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 18951579 in //UE5/Release-5.0/... via CL 18951658 via CL 18951808
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18951829 by nick darnell in ue5-main branch]
2022-02-11 09:32:23 -05:00
Marc Audy
01b7c9f4f5 Merge UE5/RES @ 15958325 to UE5/Main
This represents UE4/Main @ 15913390 and Dev-PerfTest @ 15913304

[CL 15958515 by Marc Audy in ue5-main branch]
2021-04-08 14:32:07 -04:00
Marc Audy
50a3d7d368 Merge Release-Engine-Staging to Main @ CL# 14467590
This represents UE4/Main @ 14432125 + some cherrypick fixes

[CL 14468207 by Marc Audy in ue5-main branch]
2020-10-09 22:42:26 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
Matt Kuhlenschmidt
603a4119c5 Fix HAL/PlatformFileManager.h non-portable casing CIS issues
#rb none

[CL 13214257 by Matt Kuhlenschmidt in ue5-main branch]
2020-05-06 17:58:18 -04:00
nick darnell
66c883dd5f Search - Adding some additionall logging, and better stat reporting that takes into account things being downloaded that haven't been processed yet.
#ROBOMERGE-SOURCE: CL 12643361 via CL 12649213 via CL 12649219 via CL 12649230
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12649243 by nick darnell in Main branch]
2020-04-07 00:12:04 -04:00
nick darnell
daae5d8b82 Unversial Search - Allowing the asset names themselves to be searchable. Adding a view options button to allowing more options in the future for how we view the search results.
#ROBOMERGE-SOURCE: CL 12295970 via CL 12295975 via CL 12295977 via CL 12295985
#ROBOMERGE-BOT: (v668-12245121)

[CL 12295993 by nick darnell in Main branch]
2020-03-19 10:44:47 -04:00
nick darnell
57405ba23b Universal Search - Working on better search feedback, and handling being resized better. Removing several disable optimizations from when testing.
#ROBOMERGE-SOURCE: CL 12227462 via CL 12230153 via CL 12239003
#ROBOMERGE-BOT: (v664-12234175)

[CL 12239118 by nick darnell in Main branch]
2020-03-17 22:46:07 -04:00
nick darnell
cb550a7185 Universal Search - Better search feedback in the window (throbber). Fixing all the versioning enums to not use explicit values for each entry, caused a bug where the database version didn't bump. This CL also bumps the database version, so will need to recreate the database for people, but also splitting out the file hashing database into its own database to avoid needing to rehash files in the future if the asset search database format changes.
#ROBOMERGE-SOURCE: CL 12149274 via CL 12153826 via CL 12153880
#ROBOMERGE-BOT: (v659-12123632)

[CL 12153981 by nick darnell in Main branch]
2020-03-12 16:16:22 -04:00
nick darnell
b3ff19f38e Fixing IWYU issue.
#ROBOMERGE-SOURCE: CL 12146684 via CL 12146688 via CL 12146689
#ROBOMERGE-BOT: (v659-12123632)

[CL 12146693 by nick darnell in Main branch]
2020-03-11 23:27:51 -04:00
nick darnell
1dc940dbe0 Search - now waiting until we successfully open the database (retry every 30 seconds) before processing assets. Prevents a crash when one editor boots for the same project while another instance is still shutting down.
Blueprint Indexer - We now index user editable properties exposed to the details panel on nodes, so for example, Switch On Name nodes, the individual names for each name are now indexed.

Search - When searching we now attempt to find runs of tokens to generate additional search terms.  For example, searching for Get Health, will now also search for GetHealth, however "Get Health" will be left as is with no additional search.



#ROBOMERGE-SOURCE: CL 12146618 via CL 12146619 via CL 12146621
#ROBOMERGE-BOT: (v659-12123632)

[CL 12146622 by nick darnell in Main branch]
2020-03-11 23:11:23 -04:00
nick darnell
368c40b092 Fixing some nonunity build issues, iwyu.
#ROBOMERGE-SOURCE: CL 12121652 via CL 12121653 via CL 12129860
#ROBOMERGE-BOT: (v659-12123632)

[CL 12129953 by nick darnell in Main branch]
2020-03-11 11:48:54 -04:00
nick darnell
375872024a Universal Search now covers, Sound Cues, Dialogue Waves, Levels (including the Level Blueprint). Comments on blueprint nodes are now indexed.
Now hashing all assets that are indexed.  We now only generate a single DDC key.  AssetSearch_V{SerializerVersion}_{IndexersNamesAndVersions}_{ObjectPathHash}_{FileOnDiskHash}

The file hashes along with last modified are stored in the asset database to make quick lookup easy.

A project now has control over which directories to not index.



#ROBOMERGE-SOURCE: CL 12121509 via CL 12121510 via CL 12129837
#ROBOMERGE-BOT: (v659-12123632)

[CL 12129938 by nick darnell in Main branch]
2020-03-11 11:48:45 -04:00
nick darnell
c40a12e192 Universal Search - Now monitoring deletes that happen both while the editor is running, and deletes that happen outside the editor during editor boot after initial scan completes.
#ROBOMERGE-SOURCE: CL 12049563 via CL 12049565 via CL 12049566 via CL 12049567
#ROBOMERGE-BOT: (v656-11643781)

[CL 12055086 by nick darnell in Main branch]
2020-03-07 23:05:00 -05:00
nick darnell
e77eff6d9c Fixing a crash on exit waiting for the database operation thread to finish. Ignore assets in developer directories other than yours. Updating the database to have unique flag on asset_path, and including an index to speed up deletes for properties by indexing assetids. Adding a way to manually index missing assets.
#ROBOMERGE-SOURCE: CL 11931725 via CL 11931729 via CL 11931732
#ROBOMERGE-BOT: (v656-11643781)

[CL 11931734 by nick darnell in Main branch]
2020-03-04 23:20:29 -05:00
nick darnell
2cc5cb9bad Adding a way to get the number of total search records that gets polled occasionally.
#ROBOMERGE-SOURCE: CL 11867654 via CL 11873664 via CL 11873875
#ROBOMERGE-BOT: (v656-11643781)

[CL 11886421 by nick darnell in Main branch]
2020-03-03 16:28:16 -05:00
nick darnell
408a67e108 Asset Search - Working on a new plugin to make it possible to index lots of differnet types of assets and search across a wide swath of them to find information such as text inside a data table.
Not done yet, still marking it as beta.  Not enabled by default.



#ROBOMERGE-SOURCE: CL 11850262 via CL 11850267 via CL 11850272
#ROBOMERGE-BOT: (v656-11643781)

[CL 11883741 by nick darnell in Main branch]
2020-03-03 15:46:42 -05:00