Commit Graph

101 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
louise rasmussen
5ee1db73a0 Reference Viewer Asset Paths
- Adds option to show/hide asset path as a comment (Shortcut: P)
- Adds shortcut CTRL+ C to copy selected package paths

#JIRA UE-148312
#rb Lauren.Barnes
[FYI] Bob.Tellez
#preflight 62854b5ff239239af6a0f5ae

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20268012 via CL 20270726 via CL 20270961 via CL 20271066
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20272241 by louise rasmussen in ue5-main branch]
2022-05-18 20:18:08 -04:00
lauren barnes
d6162f7fbe Reference Viewer - Settings now get saved to project config
#JIRA UE-148312
#rb Lauren.Barnes
#preflight 6283b66b18591b86df909e90

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20246604 via CL 20260309 via CL 20260357 via CL 20260360
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20263031 by lauren barnes in ue5-main branch]
2022-05-18 12:56:28 -04:00
louise rasmussen
8428a1ac62 Reference Viewer UI
- Moved view options into toolbar
- Migrated Functions to Commands
- Added Keyboard Shortcuts for View Options
- Added Keyboard Shortcuts to adjust Depth & Breadth
- Added Keyboard Shortcut to edit the selected node

#JIRA UE-151731
#rb Lauren.Barnes
#preflight 627d9303a82f3adab8b65a08

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20175507 via CL 20177195 via CL 20177309 via CL 20177412
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20177907 by louise rasmussen in ue5-main branch]
2022-05-13 00:45:19 -04:00
louise rasmussen
20d32d02a5 ReferenceViewer - Fixes presentation for Management References (PrimaryAssetIds) and Searchable Names (GameplayTags)
#rb Lauren.Barnes
#preflight 6279833210766ef8c1ae74f9

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20113112 via CL 20117509 via CL 20117538 via CL 20117552
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20118370 by louise rasmussen in ue5-main branch]
2022-05-10 00:16:02 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
andrew grant
1805cd243b Fixed missing include
#preflight skip

#ROBOMERGE-OWNER: keaton.stewart
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 20054756 via CL 20054773 via CL 20054774 via CL 20054775
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20060955 by andrew grant in ue5-main branch]
2022-05-05 14:04:48 -04:00
louise rasmussen
fd51dd72b6 ReferenceViewer Enhancements Part 1
- Updates the header style (UE5, emphasizes type)
- Shows nodes that may show up in more than one place (duplicates)
- Separates Depth control into Referencer Depth and Dependency Depth
- Comments with Package Path have been removed entirely (the tooltip remains)
- Rewritten algorithms to generate graph nodes that remove code duplication and will make adding new features easier
- Consolidates filters within the GetSortedLinks function
- adds temporary CVar that enables the ability to toggle between the old and new reference node layout algorithms.  The depricated algorithms and CVar will be removed once the rest of phase one is completed and the new layout has undergone more testing.

#JIRA  UE-148313, UE-148316, UE-148318
#rb Lauren.Barnes
#preflight 6272eb29dc3613022751c308

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20051603 via CL 20054172 via CL 20054231 via CL 20054249
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20060933 by louise rasmussen in ue5-main branch]
2022-05-05 14:04:26 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
michael noland
7f06e4c9d5 Added a project setting to allow games to default bIsShowSearchableNames on for the Reference Viewer
#jira UE-144493
#rb lauren.barnes
#lockdown julien.marchand
#preflight 62215d41c57f5f14ed1c49a7

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 19258859 in //UE5/Release-5.0/... via CL 19259187
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263829 by michael noland in ue5-main branch]
2022-03-04 04:10:37 -05:00
michael noland
10185b5a57 Fixed the edit menu option not working when a primary asset ID was selected in the reference viewer
#jira UE-144495
#rb lauren.barnes
#lockdown julien.marchand
#preflight 62215f0da00412627d1b3bca

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 19258837 in //UE5/Release-5.0/... via CL 19259136
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263828 by michael noland in ue5-main branch]
2022-03-04 04:10:29 -05:00
matt peters
fff743092d ReferenceViewer: Fix display of packages with multiple assets to display the UAsset. This fixes redirector packages to Blueprints from displaying the redirector to the BPGC rather than the redirector to the Blueprint.
#jira UE-144579
#rb Dave.Belanger, Michael.Noland
#rnx
#preflight 6220b7b09e5408e133d3ff3d
#lockdown mark.lintott

#ROBOMERGE-AUTHOR: matt.peters
#ROBOMERGE-SOURCE: CL 19243315 in //UE5/Release-5.0/... via CL 19245972
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19262853 by matt peters in ue5-main branch]
2022-03-04 02:59:34 -05:00
dan thompson
3f5f780628 Fix for asset audit ui text moving the combo box off the edge of the window making it inaccessible.
#rb Ben.Zeigler
#jira UE-143759
#preflight 6217ed5ce27ba405e861aedf

#ROBOMERGE-AUTHOR: dan.thompson
#ROBOMERGE-SOURCE: CL 19127543 in //UE5/Release-5.0/... via CL 19127970
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19154655 by dan thompson in ue5-main branch]
2022-02-25 15:21:47 -05:00
sebastian nordgren
f49bb7e38f Uses of IPropertyHandle::GetMetadataProperty() have been switched to directly call GetMetadata(), which does it internally anyway. It's probably a mistake for GetMetadataProperty() to be exposed anyway, and it should be deprecated.
#review-19111929 @editor-ux
#preflight 6218f2f51d1c501799437761

[CL 19147685 by sebastian nordgren in ue5-main branch]
2022-02-25 10:32:40 -05:00
Dan Thompson
b34d35022f Fix for timestamp in asset auditor using month instead of minute.
Fix for timetamp getting incorrectly cleared when a custom audit is cancelled.
#rb trivial
#preflight 61fc1e84033a864b77f86279

[CL 18846182 by Dan Thompson in ue5-main branch]
2022-02-03 13:42:29 -05:00
dan thompson
6c381a39d2 Add a timestamp for the AssetRegistry.bin that's in use in the Asset Auditor. This is to help when people don't realize they have to re-cook to pick up changes.
#rb matt.peters ben.zeigler
#preflight 61e71b03b56c33b8ecf44c44

#ROBOMERGE-AUTHOR: dan.thompson
#ROBOMERGE-SOURCE: CL 18646043 in //UE5/Release-5.0/... via CL 18646073 via CL 18646099
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18648125 by dan thompson in ue5-main branch]
2022-01-18 16:38:34 -05:00
iniside
cfadf8f173 PR #8741: UE5 FPrimaryAssetId selector respects DisplayThumbnail metadata. (Contributed by iniside)
#rb sebastian.nordgren
#preflight 61def5aa484d866ec0154e42

[CL 18584707 by iniside in ue5-main branch]
2022-01-12 10:49:49 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
matt peters
208b83e781 DevelopmentAssetRegistry.bin: Reduce duplication by making a function to return this string.
#rb Per.Larsson
#rnx

#ROBOMERGE-AUTHOR: matt.peters
#ROBOMERGE-SOURCE: CL 17506665 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17506695 by matt peters in ue5-release-engine-test branch]
2021-09-14 13:31:59 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
Marc Audy
e80ea6b959 Merge from Release-Engine-Staging @ 16444985
This represents UE4/Main @ 16445039 and Dev-PerfTest @ 16444526

[CL 16445122 by Marc Audy in ue5-release-engine-test branch]
2021-05-25 02:43:26 -04:00
bob tellez
d6a27cf48d #UE Fix selected path processing in AssetManagerEditorModule, now that we are using virtual paths
[FYI] Rex.Hill


#ROBOMERGE-SOURCE: CL 16424087 via CL 16424096 via CL 16424107
#ROBOMERGE-BOT: (v811-16416015)

[CL 16424110 by bob tellez in ue5-release-engine-staging branch]
2021-05-21 16:09:11 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00