Commit Graph

1289 Commits

Author SHA1 Message Date
robert manuszewski
9bfc805d98 Fixing non-unity build
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20434539 via CL 20435531 via CL 20435614
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448541 by robert manuszewski in ue5-main branch]
2022-06-01 03:48:09 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
josh adams
46a830d6b4 - Replacing many uses of LoadGlobalIniFile and LoadExternalIniFile with FCOnfigContext
#rb matt.peters
#p4v-preflight-copy 20293528
#preflight 629665d15238916c514359ad

[CL 20441581 by josh adams in ue5-main branch]
2022-05-31 16:25:06 -04:00
jeanfrancois dube
d46895e760 World Partition: hide actor handle/references automatic conversions to make code more excplicit and avoid problems creating temporary references that results in destroying actors.
#jira UE-155179
#rb patrick.enfedaque
#preflight 6294b7026601713a4f7971b6
#rnx

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 20433457 via CL 20433458 via CL 20433462
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20434221 by jeanfrancois dube in ue5-main branch]
2022-05-31 01:23:14 -04:00
richard malo
0c83b01d32 Fixed changelist data validation to check if external dependencies are at latest revision. If not, triggers an error for now as it's difficult to say if the changelist is valid or not.
#rb jeanfrancois.dube
#preflight 62910bda936293d61a819291

#ROBOMERGE-AUTHOR: richard.malo
#ROBOMERGE-SOURCE: CL 20397413 via CL 20397523 via CL 20397546
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20401185 by richard malo in ue5-main branch]
2022-05-27 19:29:34 -04:00
Tim Smith
6f0b83eb19 Tagged PluginBrowser allocations
#rb matt.peters
#jira UE-153919
#preflight 629122b6a84d43e1a0bb0d13

[CL 20397342 by Tim Smith in ue5-main branch]
2022-05-27 15:26:04 -04:00
Jon Nabozny
127848635c Fix cases of engine classes not returning normalized INI paths.
#JIRA None
#review-20392531 @Ben.Marsh @Josh.Adams
#preflight None
#rb Trivial

[CL 20394955 by Jon Nabozny in ue5-main branch]
2022-05-27 12:44:56 -04:00
mike zyracki
27fda7b623 Sequencer: Pivot Tool need to handle moving out of non zero rotation and space and handle non zero parent space. Added rotations to the pivot tool late and didn't test rotations with the parent rotated.
#jira UE-151737
#preflight 627ed975631ab437051f53ae
#rb matt.hoffman
#lockdown laurent.delayen

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 20383050 in //UE5/Release-5.0/... via CL 20384107
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20386407 by mike zyracki in ue5-main branch]
2022-05-26 17:57:10 -04:00
mike zyracki
8794ef7b9e Sequencer: Anim Tools: Most new anim tools, pivot, motion trails, etc.. don't work in sub sequences, times could be wrong and even worse bindings not found since not using the root to local transform to calculate time correctly.
#jira UE-149316
#rb max.chen
#preflight 62827fc2734d065770304796
#lockdown laurent.delayen

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 20383029 in //UE5/Release-5.0/... via CL 20384102
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20386404 by mike zyracki in ue5-main branch]
2022-05-26 17:57:03 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
stanley hayes
43ee646399 #JIRA: FORT-477503
Script cannot be added to a project

There was an issue converting from a relative path to a full path if the directories were named similarly, the fix for this caused the later part of the directory to get missed

#rb YiLiang.Siew, Rex.Hill
#Preflight 628c1452576542980819f08b
#rnx

#ROBOMERGE-AUTHOR: stanley.hayes
#ROBOMERGE-SOURCE: CL 20343002 via CL 20343047 via CL 20343097 via CL 20343129
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20343711 by stanley hayes in ue5-main branch]
2022-05-23 22:55:58 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Mike Zyracki
23b4a73a8b Sequencer: Motion Trail: On reconstruct make sure we add channels for absolutes but still handle if we have a bad rig that has a control that doesn't have a parameter.
#jira UE-152903
#preflight 6287f0662c34da686af61663
#rb matt.hoffman

[CL 20304085 by Mike Zyracki in ue5-main branch]
2022-05-20 17:56:28 -04:00
Jared Therriault
a024b62cbe nDisplay Launch:
-MU flow changes

#jira UE-151224
#rb Jason.Walter

#preflight https://horde.devtools.epicgames.com/job/6286c06c9016c6dd89a29fa1

[CL 20289642 by Jared Therriault in ue5-main branch]
2022-05-19 20:46:21 -04:00
louise rasmussen
5ee1db73a0 Reference Viewer Asset Paths
- Adds option to show/hide asset path as a comment (Shortcut: P)
- Adds shortcut CTRL+ C to copy selected package paths

#JIRA UE-148312
#rb Lauren.Barnes
[FYI] Bob.Tellez
#preflight 62854b5ff239239af6a0f5ae

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20268012 via CL 20270726 via CL 20270961 via CL 20271066
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20272241 by louise rasmussen in ue5-main branch]
2022-05-18 20:18:08 -04:00
lauren barnes
d6162f7fbe Reference Viewer - Settings now get saved to project config
#JIRA UE-148312
#rb Lauren.Barnes
#preflight 6283b66b18591b86df909e90

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20246604 via CL 20260309 via CL 20260357 via CL 20260360
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20263031 by lauren barnes in ue5-main branch]
2022-05-18 12:56:28 -04:00
benjamin fox
06b55b3af2 Save asset picker config in the Header Preview
#jira UE-150228
#preflight 6282b22e6d51c29ec4207bbe
#rb phillip.kavan

[CL 20261267 by benjamin fox in ue5-main branch]
2022-05-18 10:57:10 -04:00
stanley hayes
e4969abf08 #JIRA: FORT-477503
#rb rex.hill,yiliang.siew

There was an issue converting from a relative path to a full path if the directories were named similarly

#ROBOMERGE-AUTHOR: stanley.hayes
#ROBOMERGE-SOURCE: CL 20250150 via CL 20250321 via CL 20250806 via CL 20250872 via CL 20250905
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20252549 by stanley hayes in ue5-main branch]
2022-05-17 18:16:52 -04:00
MothDoctor
0356217025 PR #9175: Fixed Asset Search indexing for FSoftObjectPtr representing references to non-assets (i.e. AActor instances) (Contributed by MothDoctor)
#rb brooke.hubert nick.darnell
#preflight 6283d0d6114e08fa2f2373f4

[CL 20245886 by MothDoctor in ue5-main branch]
2022-05-17 13:01:49 -04:00
emil kirichev
bc535cd460 glTF import of unlit material generates a default lit material
#jira UETOOL-5193
#rb JeanLuc.Corenthin
#preflight none

[CL 20240424 by emil kirichev in ue5-main branch]
2022-05-17 06:39:59 -04:00
Sebastien Lussier
99351103ae DataValidationChangelist could miss some first level asset dependencies
* If an asset was already added as a dependency, then a later call to GatherDependencies with that asset would not have it's dependencies added
* Added check for missing dependencies not in source control
* Exclude script/memory packages from the processing
#rb luc.eygasier, julien.lheureux
#jira none
#preflight 628272c3734d0657702dcfc3

[CL 20226341 by Sebastien Lussier in ue5-main branch]
2022-05-16 12:27:17 -04:00
louise rasmussen
8428a1ac62 Reference Viewer UI
- Moved view options into toolbar
- Migrated Functions to Commands
- Added Keyboard Shortcuts for View Options
- Added Keyboard Shortcuts to adjust Depth & Breadth
- Added Keyboard Shortcut to edit the selected node

#JIRA UE-151731
#rb Lauren.Barnes
#preflight 627d9303a82f3adab8b65a08

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20175507 via CL 20177195 via CL 20177309 via CL 20177412
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20177907 by louise rasmussen in ue5-main branch]
2022-05-13 00:45:19 -04:00
Jared Therriault
a4d4390a3c //UE5/Main - Cook QAVirtualProduction Win64 - Ensure condition failed: IPluginManager::Get().LoadModulesForEnabledPlugins(ELoadingPhase::PostEngineInit)
#rb None

#jira UE-151200

#preflight https://horde.devtools.epicgames.com/job/627c01eb332e182a58be0b69
#preflight https://horde.devtools.epicgames.com/job/627c02c1b60dee4a43b7dbbe

[CL 20149956 by Jared Therriault in ue5-main branch]
2022-05-11 16:56:57 -04:00
michael balzer
53f5900d62 MeshModelingToolset: Fall back to interactive save when creating an asset for an unsaved map in restrictive mode
#preflight 627af0bc0a5817c9d9185b95

#ROBOMERGE-AUTHOR: michael.balzer
#ROBOMERGE-SOURCE: CL 20132710 via CL 20143958 via CL 20145136 via CL 20145973
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20149270 by michael balzer in ue5-main branch]
2022-05-11 16:36:01 -04:00
kiaran ritchie
088adbe916 Fixing Content Browser not showing asterisk when asset dirtied after reload.
#rb jamie.dale
#JIRA https://jira.it.epicgames.com/browse/UE-146540
#preflight https://horde.devtools.epicgames.com/job/627be559a85e625d6f6d856b
#fyi halfdan.ingvarsson
#preflight 627bf9192d678960301b5c45

[CL 20145264 by kiaran ritchie in ue5-main branch]
2022-05-11 14:09:20 -04:00