Commit Graph

77 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Marc Audy
e5a303d119 Fix CIS issues
#codereview ahmed.rizwan, yujiang.wang, graham.wihlidal, Aidan.Possemiers, luke.thatcher, zach.bethel
#rnx
#preflight

[CL 20306971 by Marc Audy in ue5-main branch]
2022-05-20 20:25:42 -04:00
ahmed rizwan
d9a0fe67ca Quixel Bridge 2022.0.3 with Metahumans Beta support
#jira UE-150863
#preflight 6273c8209c6362142dc6dbe1
#rb Durra.Mohsin
#lockdown mitchell.wilson

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 20102353 in //UE5/Release-5.0/... via CL 20103550
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20108972 by ahmed rizwan in ue5-main branch]
2022-05-09 15:23:51 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
ahmed rizwan
23531f8907 Add proxy support in Bridge plugin
#jira UE-150461
#preflight none

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19947427 in //UE5/Release-5.0/... via CL 19948782
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19952563 by ahmed rizwan in ue5-main branch]
2022-04-28 02:04:13 -04:00
ahmed rizwan
8a1548953d Move Bridge Plugin login URL's to frontend source for easily switching between environments (prod/staging/gamedev)
#jira UE-150109
#preflight 6266c93e9337eeaec4f7ef4a
#rb Durra.Mohsin

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19925850 in //UE5/Release-5.0/... via CL 19926712
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19929150 by ahmed rizwan in ue5-main branch]
2022-04-26 17:20:23 -04:00
ahmed rizwan
52ea349b2b Make Bridge plugin only accept Content EULA
#jira UE-146760
#preflight none
#lockdown cristina.riveron

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19465970 in //UE5/Release-5.0/... via CL 19466451
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v935-19464907)

[CL 19467032 by ahmed rizwan in ue5-main branch]
2022-03-22 11:28:45 -04:00
benoit gadreau
50e864cb40 ensure the RigLogic plugin is enabled and loaded before we load ControlRigs using RigLogic nodes
#rb helge.mathee
#jira UE-144854
#preflight 622f43fd505788e09ffe994d

#ROBOMERGE-AUTHOR: benoit.gadreau
#ROBOMERGE-SOURCE: CL 19372869 in //UE5/Release-5.0/... via CL 19373254
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19374785 by benoit gadreau in ue5-main branch]
2022-03-14 13:33:06 -04:00
ahmed rizwan
e831f92e78 Fix editor getting resized on Bridge plugin launch if it was previously tabbed
#preflight 62212ad4bf662715a8cbbdaa
#jira UE-144696
#rb lauren.barnes
#lockdown simon.tourangeau

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19341180 in //UE5/Release-5.0/... via CL 19349205
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19350115 by ahmed rizwan in ue5-main branch]
2022-03-11 01:12:24 -05:00
ahmed rizwan
9747345981 Fix auth session invalidating on token refresh in Bridge plugin
#preflight none
#jira UE-144655
#rb none
#lockdown mitchell.wilson

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19285463 in //UE5/Release-5.0/... via CL 19286215
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19291643 by ahmed rizwan in ue5-main branch]
2022-03-07 15:54:14 -05:00
leon huang
0193ffe8d3 Fix for CIS warnings for localization duplicate keys. Fixes simply involve changing one of the colliding localization keys.
#rnx
	#rb: Vincent.Gauthier
	#jira: UE-143620
	#preflight: 6222489d2f7d78332e121416
	#lockdown Mitchell.Wilson

#ROBOMERGE-AUTHOR: leon.huang
#ROBOMERGE-SOURCE: CL 19272838 in //UE5/Release-5.0/... via CL 19273134
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19275063 by leon huang in ue5-main branch]
2022-03-04 16:10:23 -05:00
ahmed rizwan
e3925f7b90 Fix auth session not refreshing in Bridge plugin
This causes users to get logged out after a day - and they are required to log in again.

#preflight none
#jira UE-144655
#rb none
#lockdown cristina.riveron

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19252479 in //UE5/Release-5.0/... via CL 19253135
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263459 by ahmed rizwan in ue5-main branch]
2022-03-04 03:42:37 -05:00
ahmed rizwan
e6029605de Update Bridge plugin to 2021.0.7
Frontend & node service updates. Covers bug fixes - including a fix for downloading mhc without accepting eula.

#preflight none
#rb none
#jira none
#lockdown cristina.riveron

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19236740 in //UE5/Release-5.0/... via CL 19237025
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19237576 by ahmed rizwan in ue5-main branch]
2022-03-02 22:35:25 -05:00
ahmed rizwan
a162450ac0 Temp workaround for fixing crash on Bridge plugin launch (Mac OS)
Settled on showing a popup on Mac, that asks the users to enable Web Browser plugin for using Bridge.

#preflight 621ee367ca28c55634498c80
#jira UE-143609
#lockdown cristina.riveron
#rb alfred.reynolds

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 19216856 in //UE5/Release-5.0/... via CL 19217139
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19225483 by ahmed rizwan in ue5-main branch]
2022-03-02 14:08:04 -05:00
brandon schaefer
9e6dfa0047 Backing out CL 18984951 as its causing many issues, including no longer being able to report crashes for Linux/Mac
#jira UE-143223, UE-143543, UE-143343, UE-143477
#preflight 6216860fc15ec90be95d1da4
#rb Will.Damon
#lockdown cristina.riveron


#ROBOMERGE-AUTHOR: brandon.schaefer
#ROBOMERGE-SOURCE: CL 19098653 via CL 19099741 via CL 19100216 via CL 19100731 via CL 19109901
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147237 by brandon schaefer in ue5-main branch]
2022-02-25 10:10:12 -05:00
Ryan Durand
97c2bbabc5 Add support for per platform FilterPlugin inis for plugins which was originally in a code review for CL 18874143.
#rnx
#jira UE-125146
#rb ryan.hummer
#preflight 62169f2b104496cff8a2c4e8

[CL 19122049 by Ryan Durand in ue5-main branch]
2022-02-24 14:48:24 -05:00
christina tempelaarl
a1fc976a81 Fix Quick Add menu items disappearing when the Quixel Bridge plugin is not loaded.
#jira UE-14712
#preflight 620affdac11eeda3618eb3f1
#rb lauren.barnes, rex.hill
#lockdown jeanmichel.dignard

#ROBOMERGE-AUTHOR: christina.tempelaarl
#ROBOMERGE-SOURCE: CL 18995376 in //UE5/Release-5.0/... via CL 18995527 via CL 18995615
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 19001113 by christina tempelaarl in ue5-main branch]
2022-02-15 14:40:34 -05:00
ahmed rizwan
876f02ceb2 Fix MacOS crash on Bridge plugin launch when shaders are compiling
Added WebBrowserWidget as an explicit plugin dependency in Bridge

#preflight 6209f408062428dc5323fe36
#jira UE-142375
#lockdown mitchell.wilson
#rb alfred.reynolds

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18984951 in //UE5/Release-5.0/... via CL 18985792 via CL 18987660
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18988021 by ahmed rizwan in ue5-main branch]
2022-02-14 18:32:03 -05:00
ahmed rizwan
40d30319fc Fix crash on Bridge plugin launch (MacOS)
#preflight 6206ba9ef7376af79b4e537a
#jira UE-142375
#lockdown mitchell.wilson
#rb alfred.reynolds

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18973429 in //UE5/Release-5.0/... via CL 18973466 via CL 18973479
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18973484 by ahmed rizwan in ue5-main branch]
2022-02-12 17:05:17 -05:00
ahmed rizwan
d3817a6f52 Fix Bridge plugin downloader not invalidating temp folder & export crash fixes
#preflight none
#jira UE-142360
#lockdown

This CL fixes two critical issues:
1.  plugin was failing to invalidate the temp downloads folder - causing user disk space to run out very quickly
2.  crash when user tries to export assets that aren't properly downloaded

The changes only include updated node binaries, and frontend sources.

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18957348 in //UE5/Release-5.0/... via CL 18958087 via CL 18959034
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18959269 by ahmed rizwan in ue5-main branch]
2022-02-11 15:04:55 -05:00
ahmed rizwan
ca5ed48cb0 Update Bridge plugin frontend static sources
#preflight skip

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18809347 in //UE5/Release-5.0/... via CL 18809471 via CL 18822552
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823573 by ahmed rizwan in ue5-main branch]
2022-02-02 05:51:17 -05:00
ahmed rizwan
7c5622521e Fix NonUnity compilation errors generated from the Bridge plugin
#preflight 61f7a975114ec25fe090ad79

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18787971 in //UE5/Release-5.0/... via CL 18787981 via CL 18788060
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18788066 by ahmed rizwan in ue5-main branch]
2022-01-31 06:30:23 -05:00
ahmed rizwan
f69fb01133 Update Bridge plugin to 2021.0.6 (1 of 2)
#preflight 61f4cf5c74510448a6a2d3d2

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18783046 in //UE5/Release-5.0/... via CL 18783047 via CL 18783057
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18783060 by ahmed rizwan in ue5-main branch]
2022-01-29 00:50:56 -05:00
ahmed rizwan
05710032ef Update Bridge plugin to 2021.0.5 (3 of 3)
#preflight skip

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18666771 in //UE5/Release-5.0/... via CL 18666795 via CL 18668135
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v901-18665521)

[CL 18668297 by ahmed rizwan in ue5-main branch]
2022-01-19 18:26:55 -05:00
ahmed rizwan
a4211ecb64 Update Bridge plugin to 2021.0.5 (2 of 3)
#preflight 61e885481000e8c59a7fe1d1

#ROBOMERGE-AUTHOR: ahmed.rizwan
#ROBOMERGE-SOURCE: CL 18666589 in //UE5/Release-5.0/... via CL 18666608 via CL 18668108
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v901-18665521)

[CL 18668264 by ahmed rizwan in ue5-main branch]
2022-01-19 18:25:48 -05:00