Commit Graph

210 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
mikko mononen
66e1f36595 StateTree: Changed runtime data to contain only active tasks
- Commented and cleaned up the members of UStateTree a bit
- Changed StateTree Node storage to FInstancedStructArray (contiguous memory)
- Changed StateTree SharedData to FInstancedStructArray
- Changed StateTree instance data to use FInstancedStructArray
- StateTree statistics shows estimated mem usage per state and max for tree (heaviest linked chain)
- Added explicit bLinked state for UStateTree
- Cleaned up UStateTree::ResetCompiled()/ResetLinked()
- Changed StateTree execution context to allocate task instance data on Start() and EnterState()
- StateTree tick uses execution order counters to access the instance data instead of compile time specific index

#jira  UE-153269
#rb Stephen.Holmes Yoan.StAmant
#preflight 628df39faf7a2e956bb45dc5

[CL 20361823 by mikko mononen in ue5-main branch]
2022-05-25 05:34:50 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Mieszko Zielinski
76236ec52d Marked a number of Mass or Mass-used systems as save to be accessed off-game-thread.
Also added a dedicated traits template for shared fragments.

As part of implementation added a dedicated MassGameplay module for storing TMassExternalSubsystemTraits declared for subsystems external to Mass code that the MassGameplay plugin's modules are using.

#jira UE-152550
#review-20242604
#preflight 6283c6ed18591b86df9346e0
#preflight 6283f43f0a585259b1ac8e04

[CL 20249633 by Mieszko Zielinski in ue5-main branch]
2022-05-17 15:40:34 -04:00
Mieszko Zielinski
ae4776906b Marked up some queries and processors as requiring game-thread execution, also updated traits of some of the mass-used subsystems
#review-20221254
#preflight 628218f9046b81bf9393a52e

[CL 20221595 by Mieszko Zielinski in ue5-main branch]
2022-05-16 05:56:51 -04:00
mikko mononen
a841531c2b StateTree: moved evaluators global to tree
- Deprecated per state evaluators and moved them to global to the tree
- Tick evals once per Tick()
- Updated editor node customizations to work on UStateTreeEditorData
- Added separate detail customization for UStateTreeEditorData

#jira UE-147508
#rb Yoan.StAmant
#preflight 62820e55046b81bf93911605

[CL 20221385 by mikko mononen in ue5-main branch]
2022-05-16 05:13:27 -04:00
Mieszko Zielinski
606165b6d5 Added a way to mark up MassEntityQueries as owned by a processor and auto-registering such queries. Also added some verication code that ensures all queries run as part of processors are properly marked up as such.
This is a prerequisite step to support fetching processors' requirements.

Updated all the queries owned by processors at this moment.

#review-20178362
#preflight 627e2b2d9650a277336b85e1
#preflight 627e37860d2d1f6ed8be0d95

[CL 20179262 by Mieszko Zielinski in ue5-main branch]
2022-05-13 07:07:16 -04:00
mikko mononen
5a8abeff31 MassStateTreeProcesser fixed non-unity compilation.
#jira UE-151639
#rb trivial
#preflight 627ca92ace4192efbe1a82f7

[CL 20161373 by mikko mononen in ue5-main branch]
2022-05-12 02:42:53 -04:00
mikko mononen
b5c7974c28 Fix MassStateTreeProcessor compiling in shipping
#jira none
#rb Mieszko.Zielinski
#preflight 627a64ca937a047d6230a493

[CL 20122198 by mikko mononen in ue5-main branch]
2022-05-10 09:34:19 -04:00
mikko mononen
bf89452165 MassBehavior: Changed smart object eval into a task
- Removed MassStateTreeSmartObjectEvaluator and implemented it as a task
- changed slot claim to not set state on SmartObject user
- changed smart object use to have start/stop, and it's cached on the SmartObject user
- added filter options to find smart object
- made unnecessary properties hidden in editor

#jira UE-147508
#rb Yoan.StAmant
#preflight 627a21944b6e4b76c93b0690

[CL 20120024 by mikko mononen in ue5-main branch]
2022-05-10 05:06:33 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
Mieszko Zielinski
3654d50fb0 Renamed missed "system" occurences in the "subsystem requirements" code
#rb trivial
#preflight 626bf7d72660750c3ffd66ed

[CL 19979452 by Mieszko Zielinski in ue5-main branch]
2022-04-29 11:01:35 -04:00
Mieszko Zielinski
db36db1b79 Removed UMassLODProcessorBase due to it not serving an actual purpose
#review-19958544
#preflight 626b85245844306859468064

[CL 19975820 by Mieszko Zielinski in ue5-main branch]
2022-04-29 02:46:33 -04:00
Mieszko Zielinski
ac0cf7685f Uses of the new "system requirements"
The main point of the change is to get rid of processor-cached subsystem pointers and let queries declare their desired subsystem use so that we can arrange calculations accordingly and thread-safely for parallel processing (future work).

#review-19740043
#preflight 62691752487e11fc1d72b0cb

[CL 19936828 by Mieszko Zielinski in ue5-main branch]
2022-04-27 06:28:43 -04:00
mikko mononen
2790fb0f2d ZoneGraph: Fix crash in flee annotation
- fixed crash (lookup out of date) in flee fallback behavior
- fixe left overd issues from an older review 19243357

#jira UE-148343
#review
#preflight 6262502b4c7bb31da22101b4

[CL 19861852 by mikko mononen in ue5-main branch]
2022-04-22 02:55:21 -04:00
Matt Peters
41c7a0fc0b CoreRedirect duplicate struct redirect errors: CL 19809751 made duplicates unnecessary as the full-path redirects will now also apply to Object-Name-only redirect requests, and added an error for any duplicates. Error severity is not necessary; downgrade it to a warning.
Remove the now-unnecessary duplicates to remove the warning.
#jira UE-149739
#rb Francis.Hurteau
#rnx
#preflight 626186166119a1a496ac8c3d

[CL 19855349 by Matt Peters in ue5-main branch]
2022-04-21 16:32:53 -04:00
Yoan StAmant
b4f64a59e0 [StateTree] external data validation from schema supported types
- fixed external requirements set by StateTreeBrainComponent to find more specific actor classes first before defaulting on AActor
- added missing supported type FMassSharedFragment for MassStateTreeSchema
- moved StateTreeLinker to it own file and handle its potential failures
#rb mikko.mononen
#rnx
#preflight 624d98fd8e5ae00f0aca3123

[CL 19646871 by Yoan StAmant in ue5-main branch]
2022-04-06 10:04:05 -04:00
mikko mononen
ef8889a1c4 StateTree: Added functionality to call and reuse a subtree
- Removed unnecessary checks for specific transition (handled in enter state logic)
- Added state type to StateTreeState, State, Group, or Linked
- StateTreeState property customization hides properties based on type
- Allow a state to link to another state
- Changed baker binding validation to handle linked states
- Added linked state handling in execution context
- Updated UI deal with linked states
- Updated gameplay debugger to deal with linked states
- Moved automatic Root state adding from Editor data to editor open (tests were broken due to extra root state)
- Fixed tests and added simple test for linked state
- Added meta to tag to state link to allow to select only direct states (no next, etc)
- Added counter to track state changes (mainly for debugging)

#jira UE-147509
#review
#preflight 624beb69637925b5d306d8e7

[CL 19621621 by mikko mononen in ue5-main branch]
2022-04-05 03:20:57 -04:00
Yoan StAmant
55e9970a99 [StateTree] misc trivial changes
- removed dependencies on someplugins (GameplayBehaviors, GameplayAbilities and SmartObjects)
#rnx
#rb none
#preflight 624b28c03a5a4c1622fb45ca

[CL 19612244 by Yoan StAmant in ue5-main branch]
2022-04-04 13:53:17 -04:00
christopher waters
f8147b1889 Full set of fixes for non-unity non-pch builds after EngineTypes cleanup. This includes adjusting previous build fixes that introduced new includes that weren't actually necessary. Restored a few includes and wrapped them in UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_1 checks to maintain compatability.
Also includes fixes for other build issues as it's hard to separate them all.

#jira too many to list
#rb none
#preflight 6247d21073665f7d5e6c5a6c

[CL 19600818 by christopher waters in ue5-main branch]
2022-04-02 01:04:02 -04:00
Maxime Mercier
fe9f2be8a7 Constifying the world parameter for EntityTemplate Building
#jira none
#rb trivial
#rnx
#preflight 6245bad4292f228e09032c68

[CL 19572615 by Maxime Mercier in ue5-main branch]
2022-03-31 10:34:13 -04:00
Maxime Mercier
41239618ad Fixing fragment ownership and dependencies
#jira none
#review-19548373
#preflight 624464c7927e60e34152edcb

[CL 19556691 by Maxime Mercier in ue5-main branch]
2022-03-30 10:18:25 -04:00
Brendan Mulcahy
9ad019e427 MLAdapter: Add filepath & timestamp options to local data collection session
#jira UE-147224
#rb @Mieszko.Zielinski
#rnx
#preflight 6241d8314976f93c2beae25f

[CL 19528556 by Brendan Mulcahy in ue5-main branch]
2022-03-28 11:53:47 -04:00
mikko mononen
1e28b99891 StateTree: Condition expressions
#jira UE-146925
#review-19478890
- Added ability to combine conditions into expressions
- Added editor UI for the expressions
- Replaced condition description with a name (makes the expressions faster to skim)
#preflight 62417309361866e20ffa6320

[CL 19524558 by mikko mononen in ue5-main branch]
2022-03-28 04:48:50 -04:00