Commit Graph

20 Commits

Author SHA1 Message Date
paul chipchase
64efab556e Fix more compilation warnings in P4VUtils.
#rb Sebastian.Nordgren
#rnx
#preflight 628c85f58673efbf3c0a5e3f

- Added checks when parsing xml to make sure that expected nodes/lists were found and are not null.
- Response was assigned as null, but nothing was checking for this. The initial value has been changed to an empty string which wioll invoke the user cancelling the operation as the default behaviour.
- StreamReader.ReadToEnd is a blocking call in an async method. Replaced with await StreamReader.ReadToEndAsync.

[CL 20346208 by paul chipchase in ue5-main branch]
2022-05-24 07:14:12 -04:00
Josh Adams
6f60e61383 - Some p4vutils code changes to match the already checked ion binaries
#rb trivial
#preflight skip

[CL 20248689 by Josh Adams in ue5-main branch]
2022-05-17 15:02:27 -04:00
Josh Adams
a6c5a6ccd9 - Updated p4vutils to dotnet6, so we can use OperatingSystem nicely
- Will compile on Mac and Linux now
- Mac replaced the WinForms functionality with AppleScript
- Linux will compile be have reduced functionality
- Fixed up paths for p4v settings and dotnet location
- Added binaries and installer scripts for all 3 platforms - won't need UGS to install, will copy to user-library location (may need some adustment on Linux, will address after)
#rb will.damon
#preflight skip

[CL 20244727 by Josh Adams in ue5-main branch]
2022-05-17 12:00:08 -04:00
Ben Marsh
b900bab8d1 P4VUtils: Fix compile errors after recent changes to EpicGames.Perforce library.
#preflight none
#fyi Andrew.Firth

[CL 18643289 by Ben Marsh in ue5-main branch]
2022-01-18 13:28:42 -05:00
Ben Marsh
1f185de5a4 Combine interface for creating native and external Perforce client connections.
- PerforceEnvironment class now allows querying the state of Perforce environment variables in a client agnostic way. (Supports system environment variables on Mac/Linux, and registry on Win32. Also reads settings from any P4ENVIRO file, and P4CONFIG files when initialized with a directory.)
- Connection settings are now stored in a PerforceSettings object, with a read-only IPerforceSettings interface. Both clients can be initialized through the same parameter block.
- A connection can be created using the PerforceConnection.CreateAsync() method. Specifying the IPerforceSettings.PreferNativeClient will create a NativePerforceConnection implementation where possible.

[CL 18464429 by Ben Marsh in ue5-main branch]
2021-12-14 21:31:40 -05:00
Ben Marsh
78ca05b4ce P4VUtils: Enable static analysis.
[CL 18449401 by Ben Marsh in ue5-main branch]
2021-12-13 17:09:39 -05:00
andrew firth
a13ce99b3a [P4VUtils] - fix up FileSpecList usage when null is being passed in.
#review-17397028 @Ben.Marsh (post)

[CL 17397042 by andrew firth in ue5-main branch]
2021-09-01 22:55:09 -04:00
andrew firth
130a3f286a [P4VUtils] - improve messaging around preflight command when files remain checked out
#review @andrew.grant
#rb andrew.grant

[CL 17396499 by andrew firth in ue5-main branch]
2021-09-01 22:16:36 -04:00
andrew firth
f7aa3e000f [P4VUtils] - improving preflight warning message
#rb trivial

[CL 17243661 by andrew firth in ue5-main branch]
2021-08-20 00:00:34 -04:00
andrew firth
a6cc905abd [P4VUtils] - preflightandsubmit now provides options if the CL still has files within it.
#review-17243624 @ben.marsh (posthumous)
#rb ben.marsh

[CL 17243631 by andrew firth in ue5-main branch]
2021-08-19 23:56:21 -04:00
andrew firth
7bbcaddab3 [P4VUtils] - remove review triggers and stop preflight/snapshot from triggering secondary swarm reviews
#review-17131028 @ben.marsh
#rb ben.marsh

[CL 17210787 by andrew firth in ue5-main branch]
2021-08-17 23:30:19 -04:00
andrew firth
c2c94c5fa1 [P4VUtils] - preflightAndSubmit now warns the user if files are still checked out.
#review-17045971 @Dave.Barrett
#rb Dave.Barrett

[CL 17092894 by andrew firth in ue5-main branch]
2021-08-06 23:22:51 -04:00
andrew firth
cabe530066 [P4VUtils] - small feedback changes, addition of refresh and shortcut for all custom tools.
- snapshot now more descriptive
- backout now more descriptive
- preflightAndSubmit reverted to old behavior, new command to MoveWriteableFilesthenPreflightAndSubmit added
#review @Ben.Marsh

[CL 16596338 by andrew firth in ue5-main branch]
2021-06-08 19:06:41 -04:00
andrew firth
e7adc2af32 [P4VUtils] - add creation of a copy CL for preflightandSubmit to avoid change of ownership prolems that otherwise block horde from checking in the preflight CL
#review-16556662 @Ben.Marsh @Marc.Audy

#rb ben.Marsh

[CL 16565953 by andrew firth in ue5-main branch]
2021-06-06 12:02:43 -04:00
carl bystrom
cb1335571b P4VUtils: Use client name from P4CLIENT env var for preflights
Without it, P4 can fallback to inferring the client name from other places, causing a confusion of what name to use.
When P4V invokes a so called "custom tool", it will supply the necessary P4 configuration through the normal env vars.

[CL 16514329 by carl bystrom in ue5-main branch]
2021-06-01 10:58:13 -04:00
Ben Marsh
6ad701d372 P4VUtils: Handle invalid or missing arguments gracefully.
#rb none
#rnx

[CL 15277817 by Ben Marsh in ue5-main branch]
2021-02-01 22:18:19 -04:00
Ben Marsh
9e0682fb68 P4VUtils: Add debug info to launching preflight.
#rb none
#rnx

[CL 15255963 by Ben Marsh in ue5-main branch]
2021-01-28 20:51:20 -04:00
Ben Marsh
b785e84b4f P4VUtils: Check the change is non-empty and shelve files before submit
#rb none
#rnx

[CL 15254378 by Ben Marsh in ue5-main branch]
2021-01-28 19:49:52 -04:00
Ben Marsh
6783a4319f P4VUtils: Add a command to merge a changelist to the current stream.
#rb none
#rnx

[CL 15249891 by Ben Marsh in ue5-main branch]
2021-01-28 16:51:59 -04:00
Ben Marsh
b70807aa77 Add tool for P4V extensions. Currently supports edigrate, describe, and Horde preflight commands.
#rb none

[CL 15140536 by Ben Marsh in ue5-main branch]
2021-01-19 18:51:24 -04:00