Commit Graph

171305 Commits

Author SHA1 Message Date
carlmagnus nordin
341637ba37 IoStore: Changes to allow IoStore to run as part of UnrealPak instead of as a cmdlet
#rb per.larsson
#rnx

#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 17517167 via CL 17517189 via CL 17517191 via CL 17519703 via CL 17519714
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v870-17433530)

[CL 17519729 by carlmagnus nordin in ue5-main branch]
2021-09-15 10:40:05 -04:00
Zousar Shaker
255c8de4d7 Fix bug involving duplication of actor components not causing their TObjectPtr fields to be duplicated in a manner equivalent to raw pointers. Fixed by ensuring ithat the custom archive (not derived from FArchiveUObject) used during serialization in this actor component code path handles FObjectPtr fields in the standard manner.
#jira UE-110876
#rb devin.doucette
#preflight 61418bd69bba9a00017ef7c8

[CL 17519605 by Zousar Shaker in ue5-main branch]
2021-09-15 10:34:08 -04:00
Zousar Shaker
5c134e0c9c Further bug fixing for texture build flow for issues encountered when testing Reverb dataset in editor with -DDC=Cold:
-Fixed a bug where virtual textures were having their comparison key compared against the DDC2 expected comparison key even though they're still built with the legacy path.
-Fixed a bug with the cleanup of slow tasks when instigating blocking texture builds on the game thread.
-Fixed a bugs caused by late construction of comparison keys for texture derived data.  Comparison keys have been changed and will now always be computed serially at the time a task is constructed.

#rb devin.doucette
#preflight 61413573568b3a0001c3ad72

[CL 17519512 by Zousar Shaker in ue5-main branch]
2021-09-15 10:29:45 -04:00
mihnea balta
c2eb827caf Undo changes to transition vertex buffers each time they are bound (CL 17489558).
Unfortunately the state cache can contain dangling pointers to buffers which have been freed or renamed mid-frame, because nothing clears slots in the vertex buffer cache until the end of the frame. This was "fine" before, since we only touch the views in SetVertexBuffers, and as long as the shader doesn't use the bogus slots, nothing bad happens. However, the change made that function touch CurrentVertexBufferResources, which can contain pointers to freed memory.

This brings back the problem that the code can miss transitions. We'll have to revisit this and properly clear the cache when resources are deleted or renamed.

#rb trivial
#rnx
#jira UE-126601

[CL 17519494 by mihnea balta in ue5-main branch]
2021-09-15 10:29:20 -04:00
jeannoe morissette
d94996e016 VulkanRHI: Running out of bits in AllocatorIndex when running AncientGame from scratch in Editor (PIE).
#rb Rolando.Caloca

[CL 17519240 by jeannoe morissette in ue5-main branch]
2021-09-15 10:15:55 -04:00
Gines Hidalgo
d0b8fbc766 #jira UERES-7
NeuralNetworkInference (NNI) plugin:
- Popup + UE_LOG(Warning) if DX12 not selected.
#rb nebojsa.dragosavac
#codereview nebojsa.dragosavac
#preflight 6140fd233c7c6700016a2db7
#rnx

[CL 17519196 by Gines Hidalgo in ue5-main branch]
2021-09-15 10:13:58 -04:00
Ben Marsh
9ea2f9ff7e Horde: Prevent jobs being assigned to disabled agents.
[CL 17518571 by Ben Marsh in ue5-main branch]
2021-09-15 09:27:36 -04:00
Michael Galetzka
9e13a2a389 Fixed static analysis warning (C6239: (<non-zero constant> && <expression>) always evaluates to the result of <expression>)
#jira none
#rb stu.mckenna

[CL 17518232 by Michael Galetzka in ue5-main branch]
2021-09-15 08:36:14 -04:00
Charles deRousiers
c38c80a3a4 * Add jitter mode for hair voxel raster/sampling.
* Add voxel size feedback rounding to act as hystersis control.

This allows to have determinitistic hair shadow for rendering tests.

#rb none
#jira UE-125234
#preflight 6141d6c33c7c6700018a72c7

[CL 17518018 by Charles deRousiers in ue5-main branch]
2021-09-15 07:58:11 -04:00
Dominik Peacock
27dad22be0 Fix static analysis
#jira UE-126636
#fyi Jason.Walter

[CL 17517758 by Dominik Peacock in ue5-main branch]
2021-09-15 07:02:52 -04:00
sebastian nordgren
fc836b1589 Mobility is now a dropdown instead of a segmented control.
#fyi matt.kuhlenschmidt
#preflight 61405dd030c00d0001d0877f

[CL 17517452 by sebastian nordgren in ue5-main branch]
2021-09-15 06:08:08 -04:00
kriss gossart
9f08e85335 Chaos Cloth - Fix a couple of lines of wrong indentation missed out during the resolution of the last merge conflict.
#rb trivial

[CL 17517295 by kriss gossart in ue5-main branch]
2021-09-15 05:37:01 -04:00
Mateo Egey
1c4bfa9825 Niagara node localization fix for pin names in staticswitch & select node for enums
Also removed a function that wasn't being used

#jira UE-126582
#rb rob.krajcarski

[CL 17517207 by Mateo Egey in ue5-main branch]
2021-09-15 05:19:42 -04:00
PJ Kack
0a713412ff IoDispatcher: Fix non-unity compile error caused by cl 17516499
#rb none
#rnx

[CL 17516887 by PJ Kack in ue5-main branch]
2021-09-15 04:29:24 -04:00
Martin Ridgers
395151933b Moved some platform defines to their corresponding Core.Build.cs
#fyi martins.mozeiko
#rnx
#preflight 6141a3cf9bba9a0001818033

[CL 17516847 by Martin Ridgers in ue5-main branch]
2021-09-15 04:22:41 -04:00
mihnea balta
7ad8828a44 GMaxBufferDimensions is supposed to default to the D3D11 limit, which is 2 to the power of 27, not 2 shifted by 27.
The constant in the D3D spec is D3D11_REQ_BUFFER_RESOURCE_TEXEL_COUNT_2_TO_EXP , which has a value of 27, so the value is 1 << 27, not 2 << 27.

#rnx
#jira none
#rb Christopher.Waters, Kenzo.Terelst

[CL 17516607 by mihnea balta in ue5-main branch]
2021-09-15 03:19:39 -04:00
sebastian nordgren
566d2bd4a0 Removed unnecessary typename retrieval in EditConditionParser.
Added comment clarifying intent in EditConditionContext.

#rb paul.chipchase
#preflight 61406534b5a4fa0001f2e4ff

[CL 17516578 by sebastian nordgren in ue5-main branch]
2021-09-15 03:11:36 -04:00
PJ Kack
8f856144ca IoDispatcher: Extract a IPlatformFileIoStore interface for the file backend platform implementations.
Move private core header files to internal to allow engine platform implementations in modules outside of core.
Add -forcegenericio command line option to disable platform specific implementations and fall back to the generic platform implementation that works on all platforms.

#rb carlmagnus.nordin
#rnx
#preflight 6140a7aaeb6e63000189fdf4

[CL 17516499 by PJ Kack in ue5-main branch]
2021-09-15 02:52:38 -04:00
Jens Petersam
36da3e2342 ElectraPlayer: merged H.264 and H.265 decoder output structures into a common one
#rnx

[CL 17516256 by Jens Petersam in ue5-main branch]
2021-09-15 02:01:52 -04:00
christopher waters
61b34d8334 Filling in some gaps on RHIValidation context overloads.
#jira none
#rb dave.barrett
#preflight 61410903568b3a0001b90512

[CL 17515605 by christopher waters in ue5-main branch]
2021-09-14 23:59:47 -04:00
Ben Marsh
9f1449a084 Horde: Prevent multiple job leases executing at once.
[CL 17515107 by Ben Marsh in ue5-main branch]
2021-09-14 22:33:10 -04:00
Ben Marsh
16ea9a894c Horde: Add an LRU cache for CAS objects, backed by a memory-mapped file on disk. Cache reads are lock free. Writes require a lock but complete in constant time (and do not prohibit reads).
The cache is transactional, and is designed not to lose data if the process is terminated. The cache index and bulk store are kept separate, and blocks in the bulk store are not overwritten until the index has been flushed.

The age of items is tracked via "generations". An 8-bit generation counter is incremented once a certain size of items has been added to the cache, and older entries in the cache can be trimmed periodically by calling TrimAsync().

Since blocks of memory are allocated via memory mapped files and references are not visible to the garbage collector, clients can create locks over the cache which prevents trim operations from running.

[CL 17515095 by Ben Marsh in ue5-main branch]
2021-09-14 22:32:38 -04:00
halfdan ingvarsson
fc805cf34e Control Rig: Fix dereferencing before a nullptr check, reported by PVS.
#jira UE-126616
#rnx

[CL 17514932 by halfdan ingvarsson in ue5-main branch]
2021-09-14 22:18:07 -04:00
brett miller
b0f1cf9c12 Fracture Mode
-- Fixed math error in Relative Size calculation

#jira none
#rb none
#fyi jack.oakman

[CL 17514908 by brett miller in ue5-main branch]
2021-09-14 22:12:24 -04:00
jimmy smith
0c110f1bcb Fix for crash in PIE audio device removal/add logic
#rb phil.popp

#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 17513538 via CL 17514443 via CL 17514552 via CL 17514569 via CL 17514572
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v870-17433530)

[CL 17514580 by jimmy smith in ue5-main branch]
2021-09-14 21:24:54 -04:00