Commit Graph

167 Commits

Author SHA1 Message Date
Ben Marsh
cceb95f6e5 Merging non-unity fix.
#rb none
#jira
#rnx

[CL 6455342 by Ben Marsh in 4.22 branch]
2019-05-14 18:19:59 -04:00
Ben Marsh
7ad04edd54 Live Coding: Fix crashes when patching adaptive non-unity files in game modules containing static global variables.
Live++ reads object files at startup for game modules, and assigns unique ids to each compiland (used to disambiguate static variables). When compiling the patch, these compilands are modified to reference a unique id for the unity blob, causing the variables to be reconstructed.

Solution is to generate a JSON file to each output directory containing object files containing the mapping, and to use that to assign compiland ids at startup.

#rb none
#jira UE-74036

[CL 6455253 by Ben Marsh in 4.22 branch]
2019-05-14 18:11:40 -04:00
Ben Marsh
9fb2236941 LiveCoding: Fix asserts/crashes due to variables being reconstructed when files are split out of a unity blob.
These variables (and their dynamic initializers) were being treated as new, rather than being linked back to their original instances. UBT now outputs a mapping of object files to their original unity object file during a live coding compile, which allows Live++ to disambiguate between new and reconstructed instances.

#rb none
#jira UE-72002

[CL 6455178 by Ben Marsh in 4.22 branch]
2019-05-14 18:09:57 -04:00
Ben Marsh
035e70e10b Merging early Live++ 1.4.3 changes.
#rb none
#jira

[CL 6455128 by Ben Marsh in 4.22 branch]
2019-05-14 18:08:51 -04:00
Ben Marsh
4b7042f3f4 Integrating changes from Live++ 1.4.1.
#rb none
#rnx
#jira

[CL 6455074 by Ben Marsh in 4.22 branch]
2019-05-14 18:08:06 -04:00
Ben Marsh
1cd0d7119e LiveCoding: Fix unnecessary newlines on log messages.
#jira
#rb none

[CL 6455016 by Ben Marsh in 4.22 branch]
2019-05-14 18:06:53 -04:00
Ben Marsh
d2f0c98735 Fix missing include paths in generated project files in binary builds, due to exception while generating project files due to missing module.
#rb none
#jira UE-73075

[CL 6017285 by Ben Marsh in 4.22 branch]
2019-04-19 14:44:01 -04:00
Ben Marsh
1521e27eca LiveCoding: Prevent Live Coding starting automatically when in unattended mode.
#rb none
#jira UE-72524

[CL 5988868 by Ben Marsh in 4.22 branch]
2019-04-18 14:01:31 -04:00
Ben Marsh
0b8abb31d2 Live Coding: Fixes issue linking patch DLLs with Visual Studio Express, due to PATH environment variable not including path to mspdb140.dll.
Now stores the linker environment block in the live coding manifest, and adds it to the cache before executing the linker.

#rb none
#jira UE-72324

[CL 5740602 by Ben Marsh in 4.22 branch]
2019-04-04 11:55:49 -04:00
Ben Marsh
339de68518 LiveCoding: Add support for lazy loading modules. This lets us enable live coding for the entire engine without a large startup penalty. Project modules are still preloaded by default.
#rb none
#jira

[CL 5437980 by Ben Marsh in 4.22 branch]
2019-03-18 18:06:51 -04:00
Ben Marsh
098d10583d Fix issues related to hot-reload and LiveCoding co-existing.
* Removed code to invalidate makefiles when adding new source files. UBT should be reliable enough to make this determination itself nowadays, and ignored -invalidatemakefilesonly argument was causing modules to be recompiled.
* Fixed incorrect config section name when determining whether to allow hot reload from IDE. Now prevents hot reload from IDE when live coding is enabled.
* Added error message when trying to add a new class with Live Coding enabled.
* Added error messages when trying to start Live Coding after a hot reload has taken place.
* Added error messages when trying to hot reload with Live Coding enabled.

#jira UE-71253
#rb none

[CL 5403464 by Ben Marsh in 4.22 branch]
2019-03-14 17:51:49 -04:00
Ben Marsh
3a8d4dd9d6 LiveCoding: Fix determination of whether a module is part of a project plugin. Such modules report "false" for FModuleStatus.bIsGamePlugin.
#rb none
#jira UE-71399

[CL 5365389 by Ben Marsh in 4.22 branch]
2019-03-11 20:23:51 -04:00
Ben Marsh
0c4e906ca2 LiveCoding: Fix the "Show Console" button being disabled until the first compile.
#rb none
#jira UE-71379

[CL 5362145 by Ben Marsh in 4.22 branch]
2019-03-11 15:30:57 -04:00
Ben Marsh
7642cccb91 LiveCoding: Allow editor thread to keep running while server is processing modules.
#rb none
#jira UE-71269

[CL 5361379 by Ben Marsh in 4.22 branch]
2019-03-11 14:31:39 -04:00
Ben Marsh
2ef7a96902 LiveCoding: Explicitly batch all EnableModules() commands, to prevent user command thread preempting the editor thread before it's finished adding everything. Prevents "Live coding ready" messages being spammed in the console window.
#rb none
#jira UE-71270

[CL 5361279 by Ben Marsh in 4.22 branch]
2019-03-11 14:12:36 -04:00
Ben Marsh
09cfa1adff Fix "Compile" button in toolbar using legacy hot reload when live coding startup is set to manual.
#rb none
#jira UE-71359

[CL 5361201 by Ben Marsh in 4.22 branch]
2019-03-11 13:57:27 -04:00
Ben Marsh
6ad306d80c LiveCoding: Fix setting for enabling/disabling live coding not being saved when modified via the toolbar.
#rb none
#jira UE-71362

[CL 5360814 by Ben Marsh in 4.22 branch]
2019-03-11 13:38:48 -04:00
Ben Marsh
0da1e8572f LiveCoding: Make properties for toggling on/off for engine modules hidden in installed builds.
#rb none
#jira UE-71274

[CL 5353250 by Ben Marsh in 4.22 branch]
2019-03-08 17:03:57 -05:00
Ben Marsh
e48c69bf58 LiveCoding: Tweaks to live coding settings.
* Compile dropdown now just contains a checkbox for enabling live coding.
* Compile dropdown has a link to open the editor preferences window.
* Live coding can be enabled from the editor settings window.
* Option to show the console on startup is now folded into the startup mode.
* Options in the editor settings window are greyed out unless live coding is enabled.

#rb none
#jira

[CL 5352692 by Ben Marsh in 4.22 branch]
2019-03-08 16:02:27 -05:00
Ben Marsh
dc8826b233 LiveCoding: Tidy up console output.
#rb none
#jira

[CL 5350764 by Ben Marsh in 4.22 branch]
2019-03-08 13:05:17 -05:00
Ben Marsh
f37e65e262 LiveCoding: Suppress dev channel log messages from console. Add a new server log channel that they are written to instead.
#rb none
#jira UE-71257

[CL 5350628 by Ben Marsh in 4.22 branch]
2019-03-08 12:56:01 -05:00
Ben Marsh
fb09e8fd42 Move live coding settings back under the editor preferences window, since it's a user-specific thing.
#rb none
#jira UE-71126

[CL 5350227 by Ben Marsh in 4.22 branch]
2019-03-08 12:15:09 -05:00
Ben Marsh
cb5cc7340f LiveCoding: Disable the editor compile button while a compile is in progress.
#rb none
#jira UE-71077

[CL 5343160 by Ben Marsh in 4.22 branch]
2019-03-07 17:30:28 -05:00
Ben Marsh
fc966c05ea Restore code that was accidentally commented out while debugging.
#rb none
#jira
#rnx

[CL 5341380 by Ben Marsh in 4.22 branch]
2019-03-07 16:01:33 -05:00
Ben Marsh
504e281f9e LiveCoding: Expose a Tick() function so that systems that don't use fire EndFrame() callbacks can still tick the live coding module. Also add a -LiveCoding command line argument to force it on.
Also fix an issue where a compile is triggered before the system has been started.

#rb none
#jira

[CL 5340479 by Ben Marsh in 4.22 branch]
2019-03-07 15:20:57 -05:00