jeannoe morissette
75364b7008
VulkanRHI: Add VULKAN_SM6. Move features and requirements around to match what was done on d3d.
...
#rb arciel.rekman, carl.lloyd
#preflight 643996128901e5ef982dc887
[CL 25045731 by jeannoe morissette in ue5-main branch]
2023-04-14 14:26:06 -04:00
dan elksnitis
2971b65bc4
[shaders] deprecated FShaderPipelineCompileJob::bFailedRemovingUnused field; this is only used to append some dubiously useful information to a log message (the underlying error causing the failure is always reported as any other shader preprocess/compile error). opting to remove rather than dragging this along with forthcoming preprocessing refactoring.
...
#preflight 6435679c1d61ecec3b56c78d
#rb Jason.Nadro
[CL 24991496 by dan elksnitis in ue5-main branch]
2023-04-11 11:05:47 -04:00
christopher waters
7231cf0144
Changing vendor extensions code to use EGpuVendorId instead of hardcoded IDs.
...
#rb jeannoe.morissette
#preflight 64304facb4329f6f1a32206a
[CL 24978127 by christopher waters in ue5-main branch]
2023-04-10 11:32:55 -04:00
Laura Hermanns
239c88929d
Remove DXC rewriter invocation from D3D12 backend.
...
This was originally added to have parity between Vulkan and D3D12, but it only emitted a debug file and wasn't even feeding the rewritten HLSL back into the D3D compiler.
In an effort to be independent of the DXC rewriter, this is a first step as this rewriter invocation served solely a debugging purpose anyway.
#rb Dan.Elksnitis
#fyi Jason.Nadro, Rolando.Caloca
#jira none
#preflight 642ddad58f078cc7031925d3
[CL 24936708 by Laura Hermanns in ue5-main branch]
2023-04-05 17:06:22 -04:00
christopher waters
ae1bd451f9
Bindless Resources
...
- Adding correct handling for bindless uniform buffer parameters.
- Reworking RHITextureReference creation to allow the RHI to create them differently, especially with bindless views.
- Adding RHITextureReference bindless view updates to D3D12RHI.
#jira UE-162014
#rb mihnea.balta, jeannoe.morissette
#preflight 642dba03c6769c6082f592f6
[CL 24936647 by christopher waters in ue5-main branch]
2023-04-05 17:03:17 -04:00
Laura Hermanns
51be9a5038
Always use SM6 when compiling with DXC, even when FeatureLevelES31 is requested.
...
#rb Dmitriy.Dyomin
#fyi Arciel.Rekman
#jira UE-180840
#rnx
#preflight 642d77fa8f078cc703ecb34e
[CL 24926927 by Laura Hermanns in ue5-main branch]
2023-04-05 09:38:48 -04:00
dan elksnitis
49d7985a85
[shaders] Add "compile argument" functionality for generic parameters consumed by compile backends, along with helper to set both a compile arg AND define for cases which require both. The purpose of this is to move towards enforcing that preprocessor defines should _only_ be used during the preprocessing phase itself; the subset of defines that are currently used only as arguments to the compile backends (or used as both actual preprocessor defines and backend arguments) should use this mechanism instead. This allows us to explicitly identify and hash such parameters to be included in a stable key based primarily on a hash of preprocessed/deadstripped source; without it we would need to hash all defines which will defeat most of the deduplication benefit of doing this. A subsequent change will deprecate the GetDefinitions function on the shader compilation environment to enforce that defines cannot be read by anything outside of core shader system functionality.
...
#rb Massimo.Tristano
#rb Laura.Hermanns
#preflight 64258c2e5e52099fe3d03625
[CL 24854110 by dan elksnitis in ue5-main branch]
2023-03-30 10:47:09 -04:00
benjamin rouveyrol
083a8df6f3
StructuredBuffer stride validation: some platforms use the SRV's stride instead of the declared HLSL type to index in structured buffers. This should allow us to catch issues like UE-177214 or UE-178039 by running with -rhivalidation
...
#rb mihnea.balta
#preflight 6407abb7fb10f393c210ce82
#jira UE-178276
#rnx
[CL 24572578 by benjamin rouveyrol in ue5-main branch]
2023-03-09 03:03:11 -05:00
christopher waters
e27a32c90b
Disabling the ignored-attributes warning when compiling bindless resources. DXC is incorrect that the attribute is ignored, see github issue: https://github.com/microsoft/DirectXShaderCompiler/issues/4537
...
#rb mihnea.balta
#preflight 6407a0028832f48a4d48a69d
[CL 24547309 by christopher waters in ue5-main branch]
2023-03-07 15:59:11 -05:00
tim smith
ab2e98d398
Fixed issue where LiveCoding would fail with "unresolved external symbols" when used with Clang.
...
#rb self
#jira UE-144384
#preflight 640102d9a20ddf1bf4516998
[CL 24499732 by tim smith in ue5-main branch]
2023-03-03 11:23:15 -05:00
tim smith
a50d2794ac
Improve the out-of-date check for object files and the dlls. This is now required since object files can now be ignored. Once the dll for an ignored object file is loaded by the engine, any future live coding requests will link the previously ignored object files.
...
#rb joe.pribele
#rnx
#jira UE-161641
#preflight 6400e6963206d45d20b3abb5
[CL 24488112 by tim smith in ue5-main branch]
2023-03-02 14:41:00 -05:00
tim smith
faf69c88e5
Adding lazy load modules to the manifest. Unknown modules will generate error messages but not halt patch generation. This resolves an issue where changes to unloaded modules would prevent any type of patching.
...
[RN] matt.peters
#rnx
#jira UE-161641
#preflight 63fe5c72437ce3e7f3a6a394
[CL 24452472 by tim smith in ue5-main branch]
2023-02-28 16:58:21 -05:00
tim smith
4054a68024
LiveCoding no longer generates errors about object files being missing after a source file is removed from a unity file by live coding.
...
#rb matt.peters
#jira UE-178179
#preflight 63f76d53977ceed915b08cbe
[CL 24386202 by tim smith in ue5-main branch]
2023-02-23 14:27:56 -05:00
christopher waters
9528ba3b7a
Moving WindowsTargetPlatform headers to Public for even wider access.
...
[CL 24372050 by christopher waters in ue5-main branch]
2023-02-22 18:03:13 -05:00
christopher waters
aa19fcb984
Moving some headers to an Internal path.
...
Touching the build.cs to invalidate the old paths.
[CL 24371987 by christopher waters in ue5-main branch]
2023-02-22 18:01:27 -05:00
tim smith
20d5198a07
Fixed issue in LiveCoding preload module support where if a module name is known but not currently loaded, the engine would generate a check.
...
#rb devin.doucette
#jira UE-177805
#preflight 63f4f6f19b26c4957e0b8914
[CL 24345013 by tim smith in ue5-main branch]
2023-02-21 13:47:53 -05:00
Laura Hermanns
413c2d6795
Report SCW error code for E_OUTOFMEMORY in DXBC backend.
...
#rb Dan.Elksnitis
#fyi Jason.Nadro
#jira none
#preflight 63ed05b3956709374a0b604d
#rnx
[CL 24234442 by Laura Hermanns in ue5-main branch]
2023-02-15 13:08:05 -05:00
Tim Smith
63c7a8c63a
Fixed LiveCodingConsole to handle the patching of coroutines.
...
#rb self
#jira UE-176273
#preflight 63ea94adb91ae11c1ccaa001
[CL 24185562 by Tim Smith in ue5-main branch]
2023-02-13 15:08:14 -05:00
Laura Hermanns
168b1eda5f
Add compiler invocations to shader compilation stats.
...
Example output with D3D11 RHI: "Compiler invocations: DXC (72 pre-compile steps / 74), Legacy FXC (5736), Platform compiler (NO)"
#rb Jason.Nadro
#fyi Dan.Elksnitis, Arciel.Rekman, Carl.Lloyd, JeanNoe.Morissette
#jira none
#rnx
#preflight 63e68f03432f5b48694e5401
[CL 24124722 by Laura Hermanns in ue5-main branch]
2023-02-10 14:14:14 -05:00
dan elksnitis
7652723a90
[shaders] d3d (both dxc & fxc) compile backend multithreading fixes; stripping out vestigial path allowing FXC DLL to be overridden by a parameter.
...
#rb Jason.Nadro
#rb Laura.Hermanns
#preflight 63e273719910415ae2f9b47d
[CL 24049999 by dan elksnitis in ue5-main branch]
2023-02-07 11:09:42 -05:00
tim smith
a6a1bcf63b
Fixed issue with LiveCoding where large projects might not have enough memory reserved around libraries preventing patching.
...
#rb josh.adams, self
#preflight 63d9550fba4fadeef097c212
[CL 23935004 by tim smith in ue5-main branch]
2023-01-31 14:46:34 -05:00
tim smith
bcf0ae33a5
Fixed a message formatting issue
...
#rb self
#rnx
#preflight 63d9341ecf52968117ac2733
[CL 23929343 by tim smith in ue5-main branch]
2023-01-31 12:08:16 -05:00
tim smith
ad7274f76c
Fix compilation issue with VS2019
...
#rb self
#rnx
#preflight 63d82e52d21dbe1d296cf453
[CL 23923504 by tim smith in ue5-main branch]
2023-01-31 01:17:32 -05:00
tim smith
ccf1af206b
Added a new LiveCoding command that allows for a single command to add both types of modules and a list of reserved pages.
...
#rb self
#rnx
#preflight 63d80c8a1f0aa8a2895c9d22
[CL 23923296 by tim smith in ue5-main branch]
2023-01-31 01:12:06 -05:00
Yuriy ODonnell
1dfc32d42d
Enable r.Shaders.RemoveDeadCode by default for all back-ends except Metal and OpenGL
...
* Significantly reduces the size of shader debug data and improves shader compilation time (reducing parsing cost in the native shader compiler)
* Remove "experimental" label for the feature
#rb Jason.Nadro
#preflight 63d455d9be1970f8824c3f9b
[CL 23894592 by Yuriy ODonnell in ue5-main branch]
2023-01-27 18:24:18 -05:00
