Add test case for canceling request without calling ProcessRequest, make sure complete delegate will be invoked;
Add test case for canceling request which called ProcessRequest, but still in the queue, the complete delegate will be invoked immediately(Make sure canceled queued requests will complete immediately instead of waiting until they are popped from the queue).
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rob.cannaday [at]rafa.lecina
#rb michael.atchison, Rafa.Lecina, Rob.Cannaday
[CL 34082567 by lorry li in ue5-main branch]
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]rob.cannaday
#rb michael.atchison
#tests Tested through new test case in WebTests project.
[CL 34073981 by lorry li in ue5-main branch]
Clean the cvar to trigger header received callback before http request complete;
Move the url patterns for logging response into http manager.
#jira UE-210894
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
[CL 33687587 by lorry li in ue5-main branch]
[FYI] lorry.li
Original CL Desc
-----------------------------------------------------------------
Clean the cvar to trigger header received callback before http request complete;
Move the url patterns for logging response into http manager.
#jira UE-210894
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb michael.atchison, Michael.Kirzinger, Rafa.Lecina
[CL 33675691 by hilda cruz in ue5-main branch]
Move the url patterns for logging response into http manager.
#jira UE-210894
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb michael.atchison, Michael.Kirzinger, Rafa.Lecina
[CL 33672785 by lorry li in ue5-main branch]
Move response headers logging from CurlHttp into common http impl.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#jira UE-202804, UE-205793
#rb rafa.lecina
#tests Tried on pc when the command line -ini:Engine:[ConsoleVariables]:http.UrlPatternsToLogResponse=epicgames.net
[CL 32828807 by lorry li in ue5-main branch]
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jon.cook
#rb jon.cook, michael.atchison
#tests Passed WebTests test case
[CL 32409091 by lorry li in ue5-main branch]
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb michael.atchison, Michael.Kirzinger
[CL 32193587 by lorry li in ue5-main branch]
Only output log if request had completed when activity timeout, it can continue to run even if that happened.
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rafa.lecina
#rb Rafa.Lecina
[CL 31948912 by lorry li in ue5-main branch]
Reason: When FHttpRequestCommon::CancelRequest get called, it will set bCanceled as true and abort request which will in the end call FinishRequest. But in http thread it will also check IsThreadedRequestComplete to see if the request is complete and call FinishRequest, in that function we shouldn't check bCanceled or bTimedOut, because request has already been aborted when those flags changed.
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rafa.lecina [at]jens.petersam
#jira UE-206965
#rb Michael.Kirzinger, Rafa.Lecina
#tests Reproduced and fixed with a test case
[CL 31858760 by lorry li in ue5-main branch]
Add test cases to test that after canceling/shut down request, the response body receive delegate won't ever been called.
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jens.petersam
#jira UE-207423, FORT-706402
#rb michael.atchison, Rafa.Lecina
[CL 31820574 by lorry li in ue5-main branch]
Fix the test case the response in request is not cleared on some platforms when retrying.
#jira UE-202804
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina
#rb michael.atchison, Rafa.Lecina
[CL 31518978 by lorry li in ue5-main branch]
Stop total timeout timer after request completed in retry manager;
Move the virtual impls of FHttpRequestAdapter to cpp file.
[REVIEW] [at]michael.kirzinger [at]rafa.lecina [at]michael.atchison
#jira UE-197485
[FYI] [at]jens.petersam
#rb Jens.Petersam, Rafa.Lecina
#tests Repro and fixed in WebTests
[CL 31304925 by lorry li in ue5-main branch]
#jira UE-204044
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jens.petersam
#rb Rafa.Lecina
#tests Passed WebTests test case, launched the game to main menu.
[CL 31180593 by lorry li in ue5-main branch]
Deprecate HttpTimeout config, use HttpActivityTimeout or HttpTotalTimeout instead;
Deprecate HttpSendTimeout config, only use HttpActivityTimeout;
Make HttpActivityTimeout work on all platforms, not only CurlHttp;
Added corresponding http tests;
Now because timeout migrated, enable new flow by default in retry system to have non-game thread support.
#jira UE-197485, UE-202201
[REVIEW] [at]michael.atchison [at]michael.kirzinger [at]rafa.lecina
#rb michael.atchison, Michael.Kirzinger
#tests Tested through WebTests project on all platforms, also tried the game on PC.
[CL 30817277 by lorry li in ue5-main branch]
#jira UE-203992
[REVIEW] [at]michael.kirzinger [at]michael.atchison [at]rafa.lecina [at]jans.petersam
#rb michael.atchison, Rafa.Lecina
#tests Tested through new test cases in WebTests project
[CL 30726774 by lorry li in ue5-main branch]
- Move timeout related functions into FHttpRequestCommon, make sure those functions are not exposed to FHttpRequestAdapterBase;
- Rename PreCheck to PreProcess, also clear internal states in PreProcess to make sure the request is clean for retry.
[REVIEW] [at]rafa.lecina [at]michael.kirzinger [at]michael.atchison
#jira UE-197485
#rb Rafa.Lecina
[CL 30186509 by lorry li in ue5-main branch]
