Commit Graph

14306 Commits

Author SHA1 Message Date
jamie dale
af0d0c296c Updated more StringTable API to use FTextKey for its namespace and keys
[FYI] Leon.Huang

[CL 34540292 by jamie dale in ue5-main branch]
2024-06-20 15:02:15 -04:00
justin marcus
34ccf9bbe2 Forked Server support for IAD cache
[REVIEW] [at]Daniel.Lamb [at]Per.Larsson
#rb Per.Larsson

[CL 34532940 by justin marcus in ue5-main branch]
2024-06-20 12:20:37 -04:00
andrew phillips
aea06ad649 Fix for TestFrameworkTests due to UTF8 work.
Added null checking to the TestNotEquals for TCHAR* pairs.

UTF8 work added TestNotEquals for String views and TCHAR* for completeness.
This was then used instead of the templated TestNotEquals [at]2108 in AutomationTest.h
The templated version would have only done a pointer comparison, and would not have actually checked the values.
But it did handle the `null` pointer, which is a case from the AutomatedTestFrameworkTests.

[CL 34532269 by andrew phillips in ue5-main branch]
2024-06-20 12:09:50 -04:00
steve robb
dc7ece05f6 Added new UE_ preprocessor metaprogramming macros to replace the PREPROCESSOR_ macros, to aid discoverability.
#rb andrew.rodham

[CL 34528567 by steve robb in ue5-main branch]
2024-06-20 10:24:07 -04:00
marc audy
8c0f1da634 Repurpose UE5LWCRendering version for NaniteResearch
Delete Dev-Cooker version that was ultimately unused
Delete deprecated header
Add comment clarifying SystemGUIDs

[CL 34520444 by marc audy in ue5-main branch]
2024-06-19 22:45:23 -04:00
ben woodhouse
a93a546ab4 VeryLargePageAllocator page commit limits and general refactor/cleanup:
- Add cvars VeryLargePageAllocator.MaxCommittedPageCountDefault and VeryLargePageAllocator.MaxCommittedPageCountSmallPool to limit the number of large pages committed for each pool. Since VLPA very rarely releases pages, this avoids the situation where VLPA permanently holds too much memory, leaving less for other large allocations or rendering etc.

Cleanup/refactor:
- Strip out unused code paths and corresponding defines. UE_VERYLARGEPAGEALLOCATOR_TAKEONALL64KBALLOCATIONS, UE_USE_VERYLARGEPAGEALLOCATOR_FALLBACKPATH and LARGEPAGEALLOCATOR_SORT_OnAddress were always enabled.
- Add helper functions GetOrAllocLargePage and AllocNewLargePage to simplify allocation logic. This also avoids some duplication of code in preallocation and allocate()
- Strip the VeryLargePageAllocator prefix from various cvars and globals to improve readability (making sure they're all static scope)
- Rename the function IsPartOf to IsSmallBlockAllocation to be less misleading
- Replace the cvar VeryLargePageAllocator.LeavePageCachingEnabledWhenOOMHappened with VeryLargePageAllocator.DisablePageCachingOnOOM (which does the opposite) for clarity

#tests tested on a devkit before/after and compared VLPA page allocation stats
#rb mickael.gilabert

[CL 34510261 by ben woodhouse in ue5-main branch]
2024-06-19 15:32:20 -04:00
andrew phillips
7e357734e4 Build fix for issue 501491
[CL 34507639 by andrew phillips in ue5-main branch]
2024-06-19 14:12:07 -04:00
per larsson
129585ee43 Added option -CookSoftPackageReferences to save soft package references when cooking
#rb Matt.Peters, Paul.Chipchase
#rnx

[CL 34503130 by per larsson in ue5-main branch]
2024-06-19 12:16:51 -04:00
andrew phillips
b06b199c16 Adding utf8 strings to test suite
This allows SoftObjectPath.cpp to compile when subpath is changed from FString to FUtf8String


#jira UE-204742

#rb Steve.Robb

[CL 34502184 by andrew phillips in ue5-main branch]
2024-06-19 11:47:55 -04:00
johan torp
8e4ffe26d4 Fix std::is_default_constructible<TPair<K,V>>
#rb steve.robb
#rnx

[CL 34496602 by johan torp in ue5-main branch]
2024-06-19 08:52:00 -04:00
ALiwoto
97cbc3a160 PR #11262: Fix copy/paste mistake in code documentation.
#rb Paul.Chipchase
#jira UE-203303
#rnx

[CL 34492421 by ALiwoto in ue5-main branch]
2024-06-19 03:49:25 -04:00
michael nicolella
0f7b337225 autortfm: handle masked store intrinsics
- have the compiler send the pointer and mask to the runtime so we can accurately capture which bytes are being written and log the undo

#rb Brandon.Schaefer, neil.henning

[CL 34491551 by michael nicolella in ue5-main branch]
2024-06-19 02:28:56 -04:00
ben woodhouse
a3ce2a49de Refactor CsvProfiler begin/end capture - move capture start/end logic into dedicated functions to make the logic easier to maintain
- Add metadata for capture duration
#rb john.huelin

[CL 34484069 by ben woodhouse in ue5-main branch]
2024-06-18 18:47:02 -04:00
ben woodhouse
ca450cecc2 Fix IOS
[CL 34466235 by ben woodhouse in ue5-main branch]
2024-06-18 12:32:53 -04:00
ben woodhouse
d4460eb484 Add ProgramSizeMB metadata so we can capture this even when LLM isn't running
#rb mickael.gilabert

[CL 34462213 by ben woodhouse in ue5-main branch]
2024-06-18 11:15:43 -04:00
jamie dale
6e9d3680c9 Centralized the logic for forcing game localization data to load in an editor
This is now controlled by FTextLocalizationManager::ShouldForceLoadGameLocalization, which will return true in the following cases:
  * A cooked editor.
  * An uncooked editor with the game localization preview enabled, or with the CVar Localization.ForceLoadGameLocalizationInEditor set to true.

This is queried to add the ELocalizationLoadFlags::ForceLocalizedGame flag when loading localization data, and also by FLocalizationTargetDescriptor::ShouldLoadLocalizationTarget when deciding whether to load a game localization target for a plugin (which also allows plugins to work with the game localization preview).

#rb eric.boucher

[CL 34460891 by jamie dale in ue5-main branch]
2024-06-18 10:51:09 -04:00
neil henning
9a5abf74c4 Fix the FTraceFilter transactional bug by introducing a new transactionally safe critical section and scope lock for it to use.
I also worked out how to add a new AutoRTFMEngineTests target that lets us test a much greater surface area of the engine.

[CL 34452505 by neil henning in ue5-main branch]
2024-06-18 04:46:04 -04:00
andrew ladenberger
639ccfcc0c [CsvProfiler] Optimized overhead by using the 1/frame cached memory stats, and reducing platform API calls.
#rb ben.woodhouse, dmytro.vovk

[CL 34445047 by andrew ladenberger in ue5-main branch]
2024-06-17 18:37:57 -04:00
jamie dale
7a6b14fb6d CIS fix
[FYI] Eric.Boucher
#rnx

[CL 34438140 by jamie dale in ue5-main branch]
2024-06-17 15:43:22 -04:00
eric boucher
fb4b20cb9f Load game localization data in cooked editors, replacing the CookedLocalizationPaths setting
[RN] Game localization data is now loaded in cooked editors, replacing the CookedLocalizationPaths setting
#rb Jamie.Dale

[CL 34427241 by eric boucher in ue5-main branch]
2024-06-17 13:15:20 -04:00
alan abram
d5def5b8a1 Add an option to only use the platform tracker when using LLM.
This is useful when wanting to test low memory situations with an external memory profiler in constrained memory environments.
#rb David.Harvey, Wojciech.Krywult

[CL 34419885 by alan abram in ue5-main branch]
2024-06-17 09:52:29 -04:00
steve robb
f9d4319f2e Removed deprecated functions from FAutomationTestBase.
[CL 34416927 by steve robb in ue5-main branch]
2024-06-17 06:14:27 -04:00
danny couture
bb7019159f [TaskGraph]
- Fix FTaskEvent trigger not waking up workers by default

#rb roey.borsteinas

[CL 34393046 by danny couture in ue5-main branch]
2024-06-14 22:40:15 -04:00
ben woodhouse
2ea61ce0c6 Switch to CSV_PROFILER_STATS instead of CSV_PROFILER for various profiling subsystems. This allows them to be compiled out when CSV_PROFILER_MINIMAL is defined.
As part of this change we also promote dynamic resolution and IO/PackageQueueDepth stats to Minimal since they're important for high level performance reporting.
Also fix up a few places that were redundantly using #if CSV_PROFILER around CSV macros.

#rb mickael.gilabert

[CL 34386798 by ben woodhouse in ue5-main branch]
2024-06-14 18:16:47 -04:00
ben woodhouse
39d5c72b3f CsvProfiler: add float and int overloads for RecordCustomStatMinimal
[CL 34378844 by ben woodhouse in ue5-main branch]
2024-06-14 14:25:40 -04:00