Commit Graph

185 Commits

Author SHA1 Message Date
ben hoffman
d04b7303b3 [Backout] - CL34072992
Original CL Desc

This was originally backed out due to a compilation error on Mac. Preflihgts re-run to include mac targets and they passed.

-----------------------------------------------------------------
[Backout] - CL34072649
Original CL Desc
-----------------------------------------------------------------
PropertyEditor: Display the internal & display name of the property in the copy context action tooltip

#rb logan.buchy, robb.surridge
#jira none

#ushell-cherrypick of 33973047 by kristof.morva1

[CL 34368510 by ben hoffman in ue5-main branch]
2024-06-14 08:34:31 -04:00
ben hoffman
7f2f8d9199 [Backout] - CL34072649
#fyi ben.hoffman
Original CL Desc
-----------------------------------------------------------------
PropertyEditor: Display the internal & display name of the property in the copy context action tooltip

#rb logan.buchy, robb.surridge
#jira none

#ushell-cherrypick of 33973047 by kristof.morva1

[CL 34072992 by ben hoffman in ue5-main branch]
2024-06-03 14:53:43 -04:00
ben hoffman
4c05f9b2e1 PropertyEditor: Display the internal & display name of the property in the copy context action tooltip
#rb logan.buchy, robb.surridge
#jira none

#ushell-cherrypick of 33973047 by kristof.morva1

[CL 34072649 by ben hoffman in ue5-main branch]
2024-06-03 14:39:13 -04:00
george rolfe
9e09ad4ea1 [PropertyEditor] Category Copy/Paste accounts for EditConst flag
[FYI] adam.rosengren

[CL 33993692 by george rolfe in ue5-main branch]
2024-05-29 20:58:34 -04:00
george rolfe
f2bb54325d [PropertyEditor] Category Copy/Paste accounts for EditConst flag (but allows pasting to EditCondition properties)
#jira UE-209499
#rb logan.buchy

[CL 33859039 by george rolfe in ue5-main branch]
2024-05-23 08:38:07 -04:00
forest sharp
8546d6aaae Added null check in SDetailSingleItemRow::Construct.
review [at]editor-ui-systems, [at]chris.gagnon

[CL 32745210 by forest sharp in ue5-main branch]
2024-04-04 17:59:23 -04:00
logan buchy
4e5d7451a8 Pass through PropertyPath to the PropertyUpdatedWidgetBuilder instead of FEditPropertyChain
* PropertyPath allows for property traversal through nested array properties within an object - FEditPropertyChain would also require an FPropertyChangedEvent.
* Deprecated the GetPropertyUpdatedWidget API in favor of one that passes a struct of arguments to ease refactoring in future.
* All added public APIs deprecated preemptively as experimental.  Some refinements here to ensure this works generically for all property editor rows.

#rb brooke.hubert
#jira UE-208279

[CL 32330626 by logan buchy in ue5-main branch]
2024-03-19 13:17:26 -04:00
sebastian arleryd
341fbbc032 Fix pasting into the Mobility field of the Details panel
Pasting into the Mobility field of the Details panel was prevented because no property row was found for the Mobility field. With this change, we allow pastes when no property row is found and instead only use the property row when it is found to prevent pastes if the row says so.

* Share "can we paste" checks by having PasteProperty call CanPasteProperty instead of running its own slightly different checks.
* Make CanPasteProperty (via CanPasteFromText) return true if no property row can be found for the property, instead of returning false and failing the paste. The intent here seems to have been allowing an existing property row to prevent the paste, but if none exists that shouldn't fail the paste. Ancient Unreal code didn't prevent pastes when the property row didn't exist either.

#jira UE-205934
#rb logan.buchy

[CL 31556511 by sebastian arleryd in ue5-main branch]
2024-02-16 02:39:04 -05:00
helen yang
fadc3e2a45 Move single detail item row property extension widget population to before copy paste actions are setup so they can be overridden
#jira UE-200546
#rb logan.buchy

[CL 31493566 by helen yang in ue5-main branch]
2024-02-14 16:24:28 -05:00
jeanmichel dignard
53f98a0f88 Fixed paste on properties where the custom EditConditionValue isn't set. EditConditionValue would always return false and pasting wouldn't be possible. The fix is to return true if EditConditionValue has never been set.
#jira UE-206052
#rb brooke.hubert

#changelist validated
#virtualized

[CL 31232361 by jeanmichel dignard in ue5-main branch]
2024-02-06 17:06:21 -05:00
karen jirak
f745b1709d Details Panel - Add API to mutate just the property name customization for a specific property path for non-nested properties
- created FDetailsNameWidgetOverrideCustomization and function to get it on FDetailsViewPrivate, SDetailsView and FDetailsViewArgs to provide a customization that can override any Name widget
- FDetailsNameWidgetOverrideCustomization can override any non-nested property, using the CustomizeName function which takes a TSharedRef<SWidget> that is the name widget that would show without the new customization, and the FPropertyPath in order to be able to tell what properties to override.
- In SDetalsSingleItemRow added GetNameWidget to use the FDetailsNameWidgetOverrideCustomization to provide the name widget, if it has been provided

#jira UE-201379
#rb jordan.hoffmann, logan.buchy

[CL 31134537 by karen jirak in ue5-main branch]
2024-02-02 14:14:49 -05:00
helen yang
95bae02570 Check widget row edit condition in addition to details view enablement for paste action enablement on SDetailSingleItemRow
#rb brooke.hubert
#jira UE-200546

[CL 31112945 by helen yang in ue5-main branch]
2024-02-01 19:42:40 -05:00
helen yang
8489a581f9 [Backout] - CL31074105
[FYI] helen.yang
Original CL Desc
-----------------------------------------------------------------
Check widget row in addition to details view enablement for paste action enablement on SDetailSingleItemRow

#rb logan.buchy
#jira UE-200546

[CL 31106243 by helen yang in ue5-main branch]
2024-02-01 17:36:38 -05:00
jeanfrancois dube
5a313bdbf0 Property Coloration Revival:
- This functionality was lost at some point during UE4 and wasn't bound to anything in the engine since then.
- Removed all property coloration specific code and made it go through the new Actor Coloration Framework, and kept the original white color for non-matching objects and red for matching objects.
- In UE3, property coloration was bound to shift-click on a property, but this was replaced by copy/paste in UE4, so this is now bound to control-click instead.

#rb Sebastien.Lussier
[FYI] Brooke.Hubert, Aditya.RaviChandran

[CL 31084023 by jeanfrancois dube in ue5-main branch]
2024-02-01 08:04:34 -05:00
helen yang
b370f12c8c Check widget row in addition to details view enablement for paste action enablement on SDetailSingleItemRow
#rb logan.buchy
#jira UE-200546

[CL 31074130 by helen yang in ue5-main branch]
2024-01-31 19:22:10 -05:00
karen jirak
2fec708326 Overrides widget support phase 2
- enabled code in details single item row to show the overrides widget
- added code to the overrides style keys to provide the visibility based on overrides state of the edit property chain (for properties) and object inputs
- Updates to the details display managers to get the property update widgets by providing the edit property chain, needed for override state for properties
- updated the overrides combo button code to iterate through the style keys and show any the have been initialized to show for the current override state
- currently conntains API changes to provide the override state for properties

#jira UE-192054
#rb aditya.ravichandran

[CL 30678106 by karen jirak in ue5-main branch]
2024-01-17 23:35:33 -05:00
vincent gauthier
18cd69b474 PropertyEditor Truncation warning fixes
#jira UE-166271
#rb zahra.nikbakht

[CL 30624677 by vincent gauthier in ue5-main branch]
2024-01-15 17:05:29 -05:00
jared cotton
b6aa506f02 SOL-5617 - "The editor UI for [at]editable optionals does not respect property type customization"
- if we encounter a set option in `FDetailPropertyRow` we use its value instead. This allows for cusomizations to just 'work' without any special handling for options.
    - Note: There is some case-handling to ensure the display name is still the options rather than the values.

[CL 30214987 by jared cotton in ue5-main branch]
2023-12-08 13:18:12 -05:00
george rolfe
87489cdd8b [PropertyEditor] Added UToolMenu extensibility to PropertyEditor context menu
#jira UE-197415
#rb karen.jirak

[CL 29743000 by george rolfe in ue5-main branch]
2023-11-15 06:54:35 -05:00
marc audy
8aeacf4af9 Fix various static analysis warnings
#rnx

[CL 29706886 by marc audy in ue5-main branch]
2023-11-14 00:50:15 -05:00
karen jirak
4bef0b46fa Details Panel - Overrides widget support phase 1 - UI creation, styles support
* added style classes and keys for the overrides widget image brushes and the code to create them
* added a getter to DetailsViewStyle for the overrides widget combobutton style
* svgs for images
* slight modifications in pixels and alignments in and around the cateogory buttons


#jira UE-192046
#rb Brooke.Hubert

[CL 29169806 by karen jirak in ue5-main branch]
2023-10-26 23:52:11 -04:00
karen jirak
6f3c9ba9e8 Details Panel - Overrides widget support phase 1 - UI creation
* added an overrides combobutton builder
* added an overrides menu
* Updated the details single row and category renderers to use the overrides button and menu when an entity is selected, if the CVar UI.EnableOverrides is true
* Added some infrastructure in the display managers to start some property tracking, as the Category rows need to know if any of it's properties are currently overridable\resetable


#jira UE-192046
#rb Brooke.Hubert

[CL 28983128 by karen jirak in ue5-main branch]
2023-10-20 17:27:50 -04:00
karen jirak
0aef208815 Support showing components with no UProperties and add a disallowed types list.
~added isEmpty property to details categories for showing stub categories
~styling support to show them properly

#jira UE-195683
#rb ronald.koppers

[CL 28073151 by karen jirak in ue5-main branch]
2023-09-20 22:48:08 -04:00
karen jirak
02a8dc9818 Details Panel - Component card layout actions
The categories on the components for core entities now have an action menu. It has many things in it that will log.

#jira UE-194008
#rb  Brooke.Hubert

[CL 27717413 by karen jirak in ue5-main branch]
2023-09-08 13:15:51 -04:00
aditya ravichandran
a90d73d766 Asset Editors: Add support for opening cooked assets in a new "Read Only" mode for asset editors, starting with the Static Mesh Editor and Texture Editor.
#jira UE-187048
#rb jason.stasik

[CL 27595048 by aditya ravichandran in ue5-main branch]
2023-09-05 10:01:26 -04:00