- FFrontendFilter_Text is deprecated in favor of FAssetTextFilter.
- FAssetTextFilter can be compiled and then the compiled filter cloned for use in parallel.
- Change FFrontendFilter_CustomText to work by merging its query with FAssetTextFilter instead.
- Deprecate UTextFilter*Handler classes and replace with an explicitly registered interface for thread safety.
Refactor item storage in SAssetView:
- FAssetViewItemCollection stores items and handles threading/updates
- Items are stored linearly in an array with an external lookup for simpler filter progress handling
- FHashTable used for lookup can be built & deduplicated in parallel
Other changes and optimizations
- Move AssetViewTypes.h header to private directory as it was had no DLL exported members anyway.
- When SAsset view receives a new backend filter, check if it's different before requesting a full refresh.
#rb aditya.ravichandran, Julien.StJean
[CL 33396639 by robert millar in ue5-main branch]
The activated profile can be specified using the FAssetPickerConfig struct
#jira UE-207010
#rb aditya.ravichandran
[CL 32577714 by mateo egey in ue5-main branch]
- Move redirector filtering into backend
- Add a custom filter into SFilterBar to maintain old UI for redirector visibilty
[CL 32257795 by robert millar in ue5-main branch]
- Removed unused function
- Added 'FX' asset type category for Niagara purposes that maps to the FX asset category path for default expansion purposes
- Restored functionality for default filter category expansion. This code seemed abandoned. The category expansion could be specified in the asset picker config, but in the end was ignored and the Basic asset path was used instead. This uses a Convert function to go from AssetTypeCategory -> AssetCategoryPath. There is no 1:1 mapping, so it falls back to Basic if necessary. Changing the type in the asset picker config would be cleaner, but isn't straight forward due to FAssetCategoryPath needing to be exposed to all modules that include the content browser module
- Tweaked OnExtendAddFilterMenu delegate. It's now a global delegate, making it unnecessary to handle template shenanigans to access it.
AssetPickerConfig has a new option to provide this OnExtendAddFilterMenu externally. As the 'Common' category still shows up if we expand the FX category (since Niagara System is part of Basic & FX), we can use this to remove unwanted filters
The delegate is called on the dynamic menu section before the widget generation
- Added PinAllFrontendFilters argument. This is useful if you have a small amount of filters available so that you want to display them all by default
Big code cleanup:
- MakeAddFilterMenu is now marked as final to help with API consistency.
- Added new 'CreateAssetFilterBarContext` virtual function. This is now the unified way of configuring your menu.
- The context now contains the FOnFilterAssetType delegate, and the OnExtendAddFilterMenu delegate. This allows subclasses to keep their original functionality, while having a central place to tweak it
- Removed the old content browser context as it's no longer used
- Exposed the menu name. Kept old names consistent. This allows to reuse menus, or create new ones.
- Moved the right click context filter UI of the content browser into the SAssetFilterBar. Now all SAssetFilterBars can do this. Removed the OnGetContextMenu delegate that was only used in one place
- Removed various functions that are no longer needed
#rb rex.hill, aditya.ravichandran
#ushell-cherrypick of 28538117 by Mateo.Egey
[CL 28705843 by mateo egey in ue5-main branch]
- Filter UI combo button is now created using helper method. This fixes the lack of the red dot overlay when filters are active & unifies it
- Filter UI combo button placement is now configurable. Maintains old behavior of being placed on the right to the search bar, but can also be placed on the left like the content browser now
- Other code was moved, but not changed
#jira none
#rb aditya.chandran
[CL 28497391 by Mateo Egey in ue5-main branch]
SFilterBar: Update search saving to use an independant interface and move FFilterBarBase to SAssetFilterBar
#jira UE-157471
#rb lauren.barnes, julien.stjean
#preflight 62b5dd23466962cd9a12fa8d
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20812033 via CL 20863311 via CL 20866578 via CL 20866617
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)
[CL 20876840 by aditya ravichandran in ue5-main branch]
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485
[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail.
-> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip.
-> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc).
-> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker.
#rb francis.hurteau
#fyi matt.kuhlenschmidt
#jira UETOOL-2363
[CL 14673948 by geoff evans in ue5-main branch]
