Commit Graph

191 Commits

Author SHA1 Message Date
thomas sarkanen
6d3657cb9b Fix notifies not being displayed in context menus under certain circumstances
Notifies only on skeletons only showed up when not in 'context sensitive' mode
State machine notifies were not showing up due to keying off the asset rather than the generated class

#jira UE-208828
#rb Jurre.deBaare

[CL 32016401 by thomas sarkanen in ue5-main branch]
2024-03-05 07:14:44 -05:00
lucas dower
4d9b3aed5a Add missing nullptr check on animation blueprint editor preview instance
#rb Thomas.Sarkanen

[CL 31563061 by lucas dower in ue5-main branch]
2024-02-16 09:20:43 -05:00
thomas sarkanen
507ad255ba Anim notify and sync marker workflow changes
Skeletons are no longer dirtied when adding notifies and sync markers from animation timelines.
Skeletons can still hold sync markers and notifies, but they are not mandatory and they can all be held in animation assets if required.
'Find References' for notifies and sync markers now launches the find/replace dialog when selected from the animation timeline.
Removing notifies and sync markers from the skeleton now does only that. To remove from animations, use the find/replace tab.
Updated BP node spawning for anim notifies to use a custom spawner, correctly use the asset registry, apply filtering and context sensitivity and move some of the code out of BlueprintGraph.
Added icons to distinguish sync markers/notifies in the editing tab.
Updated notify editing tab filtering to allow users to filter items from 'this' skeleton, compatible skeletons or other assets.

Additionally fixed up icons for some Persona tabs that were incorrect.

#jira UE-204872
#rb jaime.cifuentes, Phillip.Kavan

[CL 31168417 by thomas sarkanen in ue5-main branch]
2024-02-05 05:30:20 -05:00
thomas sarkanen
4b3b8228fa Fix unfixable warnings when variables referenced in in anim graph node pin bindings are removed
Also fix copy-pasted code in AnimNext
Also fix crash when compiling a template anim BP without a preview instance (found while attempting repro)

#jira UE-192978
#rb jaime.cifuentes

[CL 30969455 by thomas sarkanen in ue5-main branch]
2024-01-29 10:38:51 -05:00
aris theophanidis
7192b9d0a2 Remove text.h from script.h (script.h is included by object.h)
#rb Yoan.StAmant

[CL 30776575 by aris theophanidis in ue5-main branch]
2024-01-22 11:52:48 -05:00
kiaran ritchie
848eb88580 Removing dependency on private Persona module in AnimationBlueprintEditor module.
#rb Thomas.Sarkanen
#JIRA UE-194129

[CL 30584514 by kiaran ritchie in ue5-main branch]
2024-01-11 20:46:51 -05:00
thomas sarkanen
0d48d5e7d1 Fix ensures and crashes when interacting with the Motion Matching node
Fixed crash when selecting "On Motion Matching State Updated" function
Fixed ensure when undoing actions on a node with a blend profile selected

#jira UE-200705
#rb jose.villarroel, Nicholas.Frechette

[CL 30563653 by thomas sarkanen in ue5-main branch]
2024-01-11 04:29:45 -05:00
euan carmichael
dc35d099de Support pose watch when debugging parent or linked anim blueprints. Also prevent toggling pose watch from child anim bps
#jira UE-199935
#rb lucas.dower, Thomas.Sarkanen

[CL 29727618 by euan carmichael in ue5-main branch]
2023-11-14 17:35:49 -05:00
euan carmichael
ffb1050b3e Fix for debug draw on blendspace player nodes when debugging parent anim bps
#jira UE-199032
#rb thomas.sarkanen

[CL 29185293 by euan carmichael in ue5-main branch]
2023-10-27 12:11:12 -04:00
keith yerex
cd47f305eb Improvements to anim node property tracing and display in the animation blueprint editor:
- Trace selected animation for ChooserPlayer node.
- Make debug bubbles in rewind debugger show all traced node properties, except Name.
- Make sequence player nodes display the current sequence in the debug bubble.
- Trace assets, such as Sequence or BlendSpace with the Key: Asset, and enable display of the Asset column in the AnimGraph rewind debugger details.
#rb Samuele.Rigamonti

[CL 28214450 by keith yerex in ue5-main branch]
2023-09-25 21:35:24 -04:00
helge mathee
308d55d9b9 RigVM / ControlRig: Fix direct manipulation during PIE
#rb jaime.cifuentes
#jira UE-192171

[CL 27371219 by helge mathee in ue5-main branch]
2023-08-25 05:02:24 -04:00
jose villarroel
710ad21f92 [Backout] - CL27251115
[FYI] jose.villarroel
Original CL Desc
-----------------------------------------------------------------
Added Anim Blueprint Editor preference to disable showing assets in the context menu of anim graph. This results in a significantly faster context menu in large projects.
[REVIEW] [at]Aaron.Cox, [at]Thomas.Sarkanen

[CL 27252044 by jose villarroel in ue5-main branch]
2023-08-21 16:14:50 -04:00
jose villarroel
a633cc5d56 Added Anim Blueprint Editor preference to disable showing assets in the context menu of anim graph. This results in a significantly faster context menu in large projects.
[REVIEW] [at]Aaron.Cox, [at]Thomas.Sarkanen

[CL 27251149 by jose villarroel in ue5-main branch]
2023-08-21 15:51:13 -04:00
robert manuszewski
d3991fec9b Fixing potential compile errors ahead of enabling TObjectPtr GC barrier
#rb trivial

[CL 26868625 by robert manuszewski in ue5-main branch]
2023-08-05 06:09:54 -04:00
thomas sarkanen
b0a0c4f126 Improve infinite loop handling in animation blueprints
Change early-out for exception handling to skip exceptions for all object types in preview worlds, not just actors. Also handle excpetions in this case when the debugger is attached to the object already (allows for break on exceptions to work).
Hook the BP exception delegate to disable ticking on the skeletal mesh component so we dont keep ticking runaway scripts
Tweaked thumbnail request to not submit the same asset multiple times - this happens multiple times on compilation and can cause longer hitches when the thumbnail is requested and ticked with an infinite loop in place.

#jira UE-188277
#rb dan.oconnor

[CL 26841618 by thomas sarkanen in ue5-main branch]
2023-08-04 04:35:00 -04:00
jaime cifuentes
2a50227a47 Fix for editor crash when closing one viewport while two viewports are open in persona
#jira UE-190703
#rb thomas.sarkanen

[CL 26771089 by jaime cifuentes in ue5-main branch]
2023-08-02 10:16:04 -04:00
jaime cifuentes
679292da88 Static analysis fix at SGraphNodeAnimTransition.cpp and AnimTransitionNodeDetails.cpp
#rb trivial

[CL 26677030 by jaime cifuentes in ue5-main branch]
2023-07-28 12:38:33 -04:00
jaime cifuentes
e71560bdff Added compiler note and visual warnings to state machine transitions if the transition rule has logic but the flag for automatic rule based condition is set
#jira UE-170338
#rb jose.villarroel

[CL 26665714 by jaime cifuentes in ue5-main branch]
2023-07-28 03:19:20 -04:00
thomas sarkanen
6cfb3173aa Fix preview instance not being re-selecteable after selecting an external anim instance to debug
#jira UE-190521
#rb jose.villarroel

[CL 26506645 by thomas sarkanen in ue5-main branch]
2023-07-21 04:59:49 -04:00
roland munguia
7dc3bb57a2 State machine entry, exit, fully blended in, and fully blended out anim node functions.
Additional changes:
- Added warnings for users using anim state events since we want to push towards using the state node functions.
- Added support for anim nodes to show any bound functions and not have them hardcoded.
- Added base context type for FAnimExecutionContext.
- Now users can specify the string for the default binding name of a function member reference in a BP by using the "DefaultBindingName" metadata tag. This will give the functionality to avoid having the default binding name be "NewFunction" and instead use the input string from the metadata tag.

#jira UE-184572
#rb Thomas.Sarkanen, jose.villarroel, aaron.cox
#preflight 646e6a836c2a2532b1f91efd

[CL 25631664 by roland munguia in ue5-main branch]
2023-05-25 18:06:26 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
bryan sefcik
d205101cc8 Removed unnecessary private include modules.
#preflight 645da640cf788a25581110bb

[CL 25451545 by bryan sefcik in ue5-main branch]
2023-05-12 12:13:52 -04:00
bryan sefcik
91c57d395e Removed redundant module includes.
#preflight 645d4bf3aa3c584c0b5b3a67

[CL 25435653 by bryan sefcik in ue5-main branch]
2023-05-11 16:48:21 -04:00
aaron cox
58ce496633 Fix for static analysis warning: "Parameter 'InactiveStateColor' is always rewritten in function body before being used"
[REVIEW] [at]Roland.Munguia
#preflight 6446fd897368de8c981a7d46

[CL 25175863 by aaron cox in ue5-main branch]
2023-04-24 23:45:13 -04:00
aaron cox
3ff8e0003f New colors to distinguish state aliases and conduits.
[REVIEW] [at]Roland.Munguia

[CL 25158043 by aaron cox in ue5-main branch]
2023-04-22 11:49:00 -04:00