Commit Graph

289 Commits

Author SHA1 Message Date
yoan stamant
f92989fb33 Fixed include paths following StructUtils being moved to CoreUObject
#jira UE-216472
#rb devin.doucette

[CL 34513428 by yoan stamant in ue5-main branch]
2024-06-19 16:42:16 -04:00
yoan stamant
dacfa4f383 Moved StructUtils types (InstancedStruct, StructView, PropertyBag, etc.) to CoreUObject
StructUtilsTestSuite has been moved to Developper
StructUtilsEditor has been moved to Engine/Editor
NetSerialization for FInstancedStruct not using native serialization has been moved to the engine module since FRepLayout is not available in CoreUObject module.
Old plugins and modules are kept temporarily and will be remove in a different CL
Temporary header files added to facilitate transition to the new include path
#jira UE-216472
#rb Devin.Doucette, Francis.Hurteau

[CL 34509881 by yoan stamant in ue5-main branch]
2024-06-19 15:22:25 -04:00
yoan stamant
938f456b05 Moved UserDefinedStruct to CoreUObject
#jira UE-216472
#rb Devin.Doucette

[CL 34495793 by yoan stamant in ue5-main branch]
2024-06-19 08:00:57 -04:00
gary yuan
f85b2347ba [Backout] - CL34482589
[FYI] Yoan.StAmant
Original CL Desc
-----------------------------------------------------------------
Moved UserDefinedStruct to CoreUObject
#jira UE-216472
#rb Devin.Doucette

[CL 34486763 by gary yuan in ue5-main branch]
2024-06-18 20:05:51 -04:00
yoan stamant
b9344fb62e Moved UserDefinedStruct to CoreUObject
#jira UE-216472
#rb Devin.Doucette

[CL 34482607 by yoan stamant in ue5-main branch]
2024-06-18 17:57:11 -04:00
jacob wang
0fa5fd8e36 [State Tree] Utility Selector Runtime First Pass
#rb mikko.mononen

[CL 34362979 by jacob wang in ue5-main branch]
2024-06-13 22:57:49 -04:00
juan portillo
87367fc63d State Tree: corrected lambda capture to be by copy not ref + fixed to check UScriptStruct instead of UStruct for struct pin type
[CL 34267033 by juan portillo in ue5-main branch]
2024-06-11 04:15:08 -04:00
juan portillo
8614487357 State Tree: Added comments in GetPropertyRefInternalTypesAsPins
[CL 34266656 by juan portillo in ue5-main branch]
2024-06-11 03:45:36 -04:00
juan portillo
c9897fb3e5 State Tree: Added binding creation support in Binding Extension
- this also considers property refs

#rb mikko.mononen

[CL 34266628 by juan portillo in ue5-main branch]
2024-06-11 03:39:06 -04:00
matthew barry
00324b3fb2 UE State tree
- Added transition recording functionality to enable snapshots for state tree transitional events
- Primary use case is for keeping client-side state trees in sync with their server counterpart


[REVIEW] [at]mikko.mononen

#rnx
#rb mikko.mononen

[CL 34250876 by matthew barry in ue5-main branch]
2024-06-10 15:59:27 -04:00
jacob wang
829a1915bf [State Tree Editor] Fix accessing nullptr crash when deleting blueprint task/condition assets while other ST assets are referencing them
#rb Yoan.StAmant

[CL 34212019 by jacob wang in ue5-main branch]
2024-06-07 15:32:24 -04:00
mikko mononen
4ca5b9bee9 StateTree: Fixed calculating unique states between frames.
[CL 34120503 by mikko mononen in ue5-main branch]
2024-06-05 07:40:52 -04:00
mikko mononen
54eb8e271f StateTree: Introduced PropertyFunctions (contributed) (take2)
- Added property functions which can be executed and chained during property binding to set values of properties

[CL 34087989 by mikko mononen in ue5-main branch]
2024-06-04 03:56:38 -04:00
yoan stamant
a5e3b02a0d StateTree: Fix crash entering a subtree without parameters.
#tests Juno: Imperial bunkers in the alpine biome
#rb mikko.mononen

[CL 33929650 by yoan stamant in ue5-main branch]
2024-05-27 15:15:55 -04:00
justin peterson
4b5e90f42a [Backout] - CL33856504 - CIS Cook Warning
[FYI] mikko.mononen
Original CL Desc
-----------------------------------------------------------------
StateTree: Introduced PropertyFunctions (contributed)
- Added property functions which can be executed and chained during property binding to set values of properties

[CL 33868630 by justin peterson in ue5-main branch]
2024-05-23 14:06:53 -04:00
mikko mononen
8fb0559486 StateTree: Introduced PropertyFunctions (contributed)
- Added property functions which can be executed and chained during property binding to set values of properties

[CL 33856515 by mikko mononen in ue5-main branch]
2024-05-23 04:48:59 -04:00
juan portillo
cc6661e0ff State Tree: added instance data mismatch auto-fix
#jira UE-215581
#rb mikko.mononen

[CL 33836195 by juan portillo in ue5-main branch]
2024-05-22 13:29:00 -04:00
jacob wang
1361be7d24 [StateTree] Fix LOCTEXT name conflict
#jira UE-215189
#rb Yoan.StAmant

[CL 33730063 by jacob wang in ue5-main branch]
2024-05-17 13:46:50 -04:00
jacob wang
a9e39192a4 [StateTree] Fix property not initialized properly
#jira UE-215193
#rb Yoan.StAmant

[CL 33729993 by jacob wang in ue5-main branch]
2024-05-17 13:45:28 -04:00
jacob wang
d0a9f7e6de [State Tree] Utility Selector Editor Representation First Pass
- Editor View and Operations(debugger support not yet)
- Basic Utility Consideration Base
- Built-in Float Parameter Consideration
- Basic Blueprint Support
#rb mikko.mononen

[CL 33665793 by jacob wang in ue5-main branch]
2024-05-15 14:50:35 -04:00
mikko mononen
ef8f978f83 StateTree: Various fixes how the binding sources are displayed.
- Added editor only StatePath to FStateTreeBindableStructDesc to help error reporting
- Friendlify user defined struct property names in FStateTreePropertyPath::ToString()
- Fixed FStateTreeEditorNode::GetName() to return the BP node name instead of the wrapper name
- Categorize binding sources based on state (including one section for global) in the binding popup

#jira UE-212418, UE-209016
#rb Yoan.StAmant

[CL 33623462 by mikko mononen in ue5-main branch]
2024-05-14 02:41:50 -04:00
jacob wang
c7a6fe6ffa [State Tree] Renaming common elements between Condition and the upcoming Utility Consideration
- Renamed EStateTreeConditionOperand and properties of that type.
- Renamed FStateTreeEditorNode::Indent Property.
- Corrected a few tooltips
#rb mikko.mononen, Yoan.StAmant

[CL 33614033 by jacob wang in ue5-main branch]
2024-05-13 20:48:39 -04:00
yoan stamant
08b5314641 [StateTreeDebugger] replaced WITH_STATETREE_DEBUGGER by WITH_STATETREE_TRACE and WITH_STATETREE_TRACE_DEBUGGER to allow different targets to use only one of the two functionalities. For example consoles can only output traces while Desktop targets can output traces and analyse them.
#rb Mieszko.Zielinski

[CL 33398309 by yoan stamant in ue5-main branch]
2024-05-02 11:47:26 -04:00
yoan stamant
db3b23de1c [StateTreeDebugger] enabled debugger on all desktop platforms
#jira UE-192305
#rb mikko.mononen

[CL 33371821 by yoan stamant in ue5-main branch]
2024-05-01 09:59:57 -04:00
logan buchy
7e550e71fc [Backout] - CL33242681
[FYI] marshall.beachy
Original CL Desc
-----------------------------------------------------------------
Performance improvement for nested FInstancedStruct in details panel
* Pathological performance issues occurred when viewing/editing USTRUCT objects that nested FInstancedStruct (either directly or in containers).  The PropertyNode system's implementation when handling FInstancedStructs would recurse up the property tree to discover the address of the owning objects and then recurse again up with the starting address.  The root cause of the performance issue is that the recursion would branch on the way up in the following functions: GetInstancesNum, GetMemoryOfInstance, GetOwnerPackages, HasValidStructData (by way of IsValid). On the way up again, branches would occur in GetValueBaseAddress, via duplicate calls in FItemPropertyNode::GetValueBaseAddress to ParentNode->GetValueAddress.
* The problem has been addressed by having the StructPropertyNode handle StructProviders that perform indirection differently than other providers.  When indirection is present, walk up to the parent node of the struct which will be an ItemPropertyNode - the address of this is retrieved and passed back down to the StructProvider.  In the current codebase, the FInstancedStructProvider is the only one that does this type of indirection - it can make the assumption that the passed in address is an FInstancedStruct and thus reinterpret it to get the StructMemory and UStruct* pointers.
* Added an InternalGetReadAddressUncached which public GetReadAddress** functions will call.  This new function will not resolve the Struct in the case of a Struct property indirection unlike GetReadAddressUncached.  It is intended as an internal function only to be called by the public APIs.
* Added a safeguard canary value to FInstancedStruct to debug/catch cases where the wrong raw void* is reinterpreted as an FInstancedStruct.  FInstancedStruct::CastFromVoid helper should be used over a naked reinterpret_cast
* Note that it isn't guarantees all paths where slow recursive behaviour occurs has been addressed in this CL. Specifically, the InstancedStructDetails implementations to get the dispaly values still go through the data enumeration though it should be better now that GetInstancesNum and GetMemoryOfInstance are not recursively calling the Enumerate pathways.  See GetDisplayValueString, GetTooltipText, GetDisplayValueIcon, GenerateStructPicker - this is the primary expense in Slate that is probably causing additional performance loss.

#rb mikko.mononen
#jira UE-207555

[CL 33319481 by logan buchy in ue5-main branch]
2024-04-30 01:05:58 -04:00