Commit Graph

103 Commits

Author SHA1 Message Date
phil popp
8846679f41 Recurse MetaSound Preset Graph Inflation as much as possible.
#rnx
#rb Rob.Gay

[CL 34465653 by phil popp in ue5-main branch]
2024-06-18 12:26:46 -04:00
danny couture
6345bd8b29 [TaskGraph/Misc]
- Replace BusyWait API calls to simple Wait

#rnx
#rb kevin.macaulayvacher

[CL 34315066 by danny couture in ue5-main branch]
2024-06-12 13:56:22 -04:00
phil popp
56737d13eb MetaSound Graph Render Cost
The main elements of this change are:
- Incorporation of "Relative Render Cost" to the AudioDevice in order to do more nuanced voice limiting
- Added a method for tracking a RenderCost in MetaSounds
- Live information on RenderCost is displayed in the MetaSound editor when a sound is previewed

There was some small cleanup as well
- Moved the GraphHierarhcy MetaSound environment variable
- Renamed the MetaSound Environment Variable  TransmissionID to InstanceID
- Put CPU cost and Render Cost into their own widget in the MS editor.

#jira UE-215467
#rb Rob.Gay, Jimmy.Smith

[CL 34020333 by phil popp in ue5-main branch]
2024-05-30 19:36:18 -04:00
helen yang
7e54e11452 MetaSound Array Random Get node fixes for passthrough inputs and node id for Same Node shared state behavior
- Make trigger inputs passthrough
- Use both node id and containing graph id to avoid shared state in duplicated assets when using Same Node shared state behavior
- Use asset class id instead of a newly generated id for FFrontendGraph graph id to guarantee ids are shared for a given asset, and clean up now unneeded id map in the Operator Cache

#jira UE-215243
#jira UE-215587
#rb phil.popp

[CL 33901385 by helen yang in ue5-main branch]
2024-05-24 14:33:22 -04:00
chris ritter
a495329bdf [Metasound] Re-bind vertex analyzers when their output data ref changes (e.g. dynamic graphs re-connecting things)
#rb phil.popp
#tests cooked client/server

[FYI] charlie.huguenard

[CL 33616022 by chris ritter in ue5-main branch]
2024-05-13 22:01:25 -04:00
chris ritter
c92ef085b9 Expose VertexInterface changes in OnGeneratorIOUpdated
#rb phil.popp
#tests PIE, MetasoundDynamicGenerator test suite
[FYI] charlie.huguenard

[CL 32873045 by chris ritter in ue5-main branch]
2024-04-11 02:17:22 -04:00
rob gay
446e58f9fd Move operator cache to use async build pipe instead of task graph (follow-up to listed bug fix per initial review feedback)
#rb Maxwell.Hayes
#jira UE-201787
#rnx

[CL 31918581 by rob gay in ue5-main branch]
2024-02-29 14:30:15 -05:00
nicholas howe
40c961c70e MetasoundMusicClockDriver thread safety fixes.
[REVIEW] [at]buzz.burrowes [at]charlie.huguenard [at]jake.burga [at]robert.rouhani
#rb charlie.huguenard

[CL 31582940 by nicholas howe in ue5-main branch]
2024-02-16 17:20:19 -05:00
rob gay
1e7eb6500f Minor pool clean-up & additional protections in light of review of last submission
#rb maxwell.hayes
#jira UE-201787
#rnx
#tests AudioUnitTests, ran bug repro

[CL 31457867 by rob gay in ue5-main branch]
2024-02-13 20:58:28 -05:00
rob gay
39b577b813 - Fix for shutdown crash in FWaveAsset construction due to IStreamingManager becoming invalid while operator cache is building proxies async
- Fix for shutdown stall caused by operator cache not canceling async build gracefully
#jira UE-201787
#rnx
#rb maxwell.hayes
#tests AudioUnitTests, ran bug repro

[CL 31456120 by rob gay in ue5-main branch]
2024-02-13 19:40:35 -05:00
maxwell hayes
bc39a66768 Cleaning up metasound experimental cvars
#rb Phil.Popp
#jira UE-205183
#rnx

[CL 31180968 by maxwell hayes in ue5-main branch]
2024-02-05 13:30:58 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
maxwell hayes
cb6bc25e3c Adding audio csv stats around tracking potential perf culprits.
#rb jimmy.smith

[FYI] Will.Widen

[CL 30402732 by maxwell hayes in ue5-main branch]
2023-12-19 16:07:38 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
charlie huguenard
0397d1e2b3 [Metasound] Notify listeners only once per render block when a dynamic generator's vertex interface changes.
[FYI] matthew.booth
#rb helen.yang

[CL 30128280 by charlie huguenard in ue5-main branch]
2023-12-05 14:13:33 -05:00
rob gay
c0a29efaed Add cvar to disable manual MetaSoundPrecache all together
#rb helen.yang
#rnx

[CL 30094958 by rob gay in ue5-main branch]
2023-12-04 16:22:01 -05:00
helen yang
3b8e0c7acf Retrieve MetaSound graph before building graph operator in async task (cvarable) and add nullptr checks
[REVIEW] [at]aaron.mcleran, [at]rob.gay
#rb Aaron.McLeran, hilda.cruz, Rob.Gay, ryan.mangin

#localization none
#tests preflight 656ceb1d8b7aa8578b8b235a
#preferred_allowlister derek.ehrman

[CL 30072616 by helen yang in ue5-main branch]
2023-12-03 21:31:16 -05:00
maxwell hayes
dd5caaaf58 Add cvar to allow resetting metasound operators on cache insertion to potentially deallocate memory.
[REVIEW] [at]rob.gay
#rnx

#localization none
#tests local LLM A/B in PIE to confirm regression fixed w/o affecting weapon audio functionality
[FYI] aaron.mcleran

[CL 29596933 by maxwell hayes in ue5-main branch]
2023-11-09 10:54:35 -05:00
phil popp
559eaa393f Fix default parameter values when skipping preset
#jira UE-199604
#rb Maxwell.Hayes
#rnx

[CL 29385950 by phil popp in ue5-main branch]
2023-11-02 18:41:29 -04:00
maxwell hayes
62beb18e59 [Metasound] Follow up changes to operator pooling behavior.
#jira UE-179996
#rb phil.popp

#swarm https://p4-swarm.epicgames.net/reviews/29255703

[CL 29295416 by maxwell hayes in ue5-main branch]
2023-10-31 18:35:37 -04:00
helen yang
6d393901a2 Add MetaSounds LLM tag to OnGenerateAudio
#rb phil.popp

[CL 29161461 by helen yang in ue5-main branch]
2023-10-26 21:13:44 -04:00
maxwell hayes
8e9187b0cf [Metasounds] Operator precaching mechanism.
#jira UE-185725, UE-179996,
#rb phil.popp
#swarm https://p4-swarm.epicgames.net/reviews/27703580

[CL 28775007 by maxwell hayes in ue5-main branch]
2023-10-13 17:49:56 -04:00
ionut matasaru
57769f8235 Fixed usage of TRACE_CPUPROFILER_EVENT_SCOPE macros in engine plugins.
* TRACE_CPUPROFILER_EVENT_SCOPE(ScopeName) --> to be used with a plain text as scope name (not a string!). If the parameter is a string ("abc" or TEXT("abc")), the quotes (and the TEXT prefix) will be included in the actual timer name.
* TRACE_CPUPROFILER_EVENT_SCOPE_STR("scope name") --> to be used with a static string (const ANSICHAR* or const TCHAR*); ex: when the scope name needs to include a space char
* TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(*MyScopeName) --> to be used with a dynamic string (const ANSICHAR* or const TCHAR*)
See also the comments for these macros in ProfilingDebugging\CpuProfilerTrace.h.

#rb Catalin.Dragoiu

[CL 28337738 by ionut matasaru in ue5-main branch]
2023-09-29 04:29:47 -04:00