Commit Graph

93 Commits

Author SHA1 Message Date
rob gay
e0f2527ac7 Editor-only fixes included: Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34541631 by rob gay in ue5-main branch]
2024-06-20 15:27:03 -04:00
rob gay
e0359d1db1 [Backout] - CL34535555
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34538285 by rob gay in ue5-main branch]
2024-06-20 14:26:46 -04:00
rob gay
94e46a67f9 Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34535569 by rob gay in ue5-main branch]
2024-06-20 13:33:47 -04:00
rob gay
92e413738d Fix for Clang compiler warning. Minor feedback for const declaration of default page ID.
#rnx
#rb rob.gay

[CL 34485679 by rob gay in ue5-main branch]
2024-06-18 19:17:25 -04:00
AdricEpic
0976464d97 #1 Pages Checkpoint: Update BuilderAPI, associated delegates to support providing Pages
#rb helen.yang, phil.popp
#rnx
#jira UE-194160

[CL 34477958 by AdricEpic in ue5-main branch]
2024-06-18 16:47:21 -04:00
miro salminen
5996025756 [MetaSound] 'hide unconnected pins' action to nodes
#rb Rob.Gay
#jira UE-171027
#rnx

[CL 34452339 by miro salminen in ue5-main branch]
2024-06-18 04:15:33 -04:00
rob gay
1b3382acee Guid collision fix-up follow-up renaming
#rb helen.yang, phil.popp
#rnx

[CL 34426347 by rob gay in ue5-main branch]
2024-06-17 12:51:18 -04:00
rob gay
81433d4d49 Versioning guid collision fixes
#jira UE-217835
#rb phil.popp
#rnx
[FYI] sondra.moyls
#tests local edits, audioQA automated tests, project fast cook

[CL 34376054 by rob gay in ue5-main branch]
2024-06-14 13:05:35 -04:00
rob gay
09f4a23362 - Protect against invalid builder or MetaSound object in MetaSound Asset Editor
- Clean-up multiple ways MetaSound is tracked in Asset Editor (ex. FGCObject in ToolKit overload, internal to ToolKit, StrongObjectPtr, etc.)
    - Now just uses EditingObject and GetMetasoundObject() wraps it safely
- Reordered & cleaned asset editor Init logic to accomidate condensing references
#jira UE-216533
#rb helen.yang
[FYI] sondra.moyls
#rnx

[CL 34245283 by rob gay in ue5-main branch]
2024-06-10 13:41:25 -04:00
rob gay
fb352f462e [Backout] - CL34086276
[FYI] miro.salminen
Original CL Desc
-----------------------------------------------------------------
[MetaSound]  'hide unconnected pins' action to nodes
#rb helen.yang
#jira UE-171027
#rnx

[CL 34148343 by rob gay in ue5-main branch]
2024-06-06 00:17:28 -04:00
miro salminen
6c98d2511a [MetaSound] 'hide unconnected pins' action to nodes
#rb helen.yang
#jira UE-171027
#rnx

[CL 34086303 by miro salminen in ue5-main branch]
2024-06-04 01:47:34 -04:00
alan abram
f64052f200 Metasound changes to reduce the number of FNames generated.
Previously the FNodeRegistryKey::ToString() function was the only user of the "FullName" FName and was used for logging. We now build these inline when used as not to pollute the FNamePool.
#rb emanuel.masciarelli, Rob.Gay

[CL 34032750 by alan abram in ue5-main branch]
2024-05-31 11:06:37 -04:00
rob gay
69725d945e - Checkpoint for Initial MetaSound Pages document model support
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160

[CL 33983705 by rob gay in ue5-main branch]
2024-05-29 15:33:29 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
rob gay
9d232be57e Fix for uninitialized members
#rb rob.gay
#jira UE-205618
#rnx

[CL 31096723 by rob gay in ue5-main branch]
2024-02-01 14:22:29 -05:00
rob gay
7dead04def Scaffolding for custom MetaSound comment nodes that serialize to Frontend Document as initial part of making ed graph data transient
#jira UE-194160
#rb helen.yang
#rnx

[CL 31060334 by rob gay in ue5-main branch]
2024-01-31 15:02:39 -05:00
rob gay
94048f43ca - Make FNodeRegistryKey an actual struct as opposed to a string alias
- Avoids string format/copies/conversions in most cases where its just used as a key
- Deprecate NodeRegistryKey namespace calls
#rb phil.popp
#rb helen.yang

[CL 28727626 by rob gay in ue5-main branch]
2023-10-12 16:37:45 -04:00
rob gay
a217018a86 - Make FMetasoundFrontendClassName GetTypeHash performant by removing string copy/format
- Add InvalidFrontendClassName to test validity against instance/if class name has been set
- Minor clean-up
#rb helen.yang
[FYI] phil.popp
#rnx

[CL 28629702 by rob gay in ue5-main branch]
2023-10-10 14:11:01 -04:00
phil popp
1c5f2a8cdd Update caching of input data to use TSortedMap
#jira UE-195472
#rb Rob.Gay

[CL 27886540 by phil popp in ue5-main branch]
2023-09-14 13:49:21 -04:00
phil popp
f25c1c60d4 Use MetaSound proxy cache to build metasounds
#jira UE-185834
#rb Helen.Yang

[CL 27841603 by phil popp in ue5-main branch]
2023-09-13 14:21:35 -04:00
Rob Gay
4b6ada027e - Fix for crash when transforming reroute template nodes
- Add more extensible API to transforms for opting in or out of applying access type dynamically for inputs/outputs to builder API
- Added debug cvar for viewing node data in MetaSound editor
#rb helen.yang
#jira UE-194634
#rnx

[CL 27674059 by Rob Gay in ue5-main branch]
2023-09-07 11:11:22 -04:00
helen yang
fa585989cf Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299244 by helen yang in ue5-main branch]
2023-06-28 17:08:29 -04:00
rob gay
efe5d3931c Add missing BPReadWrite mark-up to MetaSoundClassName so nodes can be added via builder in BP & LexToString for better error logging of MetaSound types to be used in subsequent CL for BP debugging. Minor formatting fix-ups.
#rnx
#rb trivial
#rnx

[CL 26158067 by rob gay in ue5-main branch]
2023-06-21 15:14:33 -04:00