Commit Graph

129 Commits

Author SHA1 Message Date
rob gay
1b3382acee Guid collision fix-up follow-up renaming
#rb helen.yang, phil.popp
#rnx

[CL 34426347 by rob gay in ue5-main branch]
2024-06-17 12:51:18 -04:00
rob gay
81433d4d49 Versioning guid collision fixes
#jira UE-217835
#rb phil.popp
#rnx
[FYI] sondra.moyls
#tests local edits, audioQA automated tests, project fast cook

[CL 34376054 by rob gay in ue5-main branch]
2024-06-14 13:05:35 -04:00
rob gay
496613928a Fixed cook issues ([Backout] - CL34114021)
- Fixed regression with referencing graphs not updating
#tests AudioQA -cook
[FYI] hilda.cruz

Original CL Desc
-----------------------------------------------------------------
[Backout] - CL34112568 due to autotest error.
#rnx
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls

[CL 34125321 by rob gay in ue5-main branch]
2024-06-05 11:00:21 -04:00
rob gay
064e244218 - Make Version call to generate MetaSound Builder async GC-safe
- Misc clean-up
#rb phil.popp
#rnx
[FYI] helen.yang
#jira UE-216029

[CL 34017798 by rob gay in ue5-main branch]
2024-05-30 18:56:24 -04:00
rob gay
69725d945e - Checkpoint for Initial MetaSound Pages document model support
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160

[CL 33983705 by rob gay in ue5-main branch]
2024-05-29 15:33:29 -04:00
rob gay
b411ae1cdf More MetaSound Asset/Builder registry clean-up
- Distinguish executing finish call from removal of register's weak pointer entry to avoid leaking stale builder registry entries
- Fix for removal calls to asset registry entries leaking during cook (due to cook package data being stripped when BeginDestroy is called)
- Fix for removing an asset manager entry that hasn't been registered with the node registry not getting removed due to the RegistryGraphKey referenced not being set on AssetBase
- Remove AssetRegistry MetaSoundEditor delegate handlers during cook that aren't used
- Add thread checks for safety to MetaSoundAssetManager
- Add better logging around AssetManager/BuilderRegistry destruction if applied prior to underlying respective entry/entries destruction
#jira UE-212969
#rb phil.popp

#rnx
#tests local AudioQA cook, loading all assets in editor, PIE, -game, automated tests, loading all assets in editor, PIE, -game

[CL 33641926 by rob gay in ue5-main branch]
2024-05-14 20:20:01 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
rob gay
e8e0c199a2 Remove dependency on MetaSound engine subsystems of any kind being required to register MetaSounds with frontend
#rb rob.gay
#rnx
[FYI] sondra.moyls, phil.popp, helen.yang

[CL 33199328 by rob gay in ue5-main branch]
2024-04-24 10:36:28 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
phil popp
29f9782306 Log error when failing to find interface for metasound
#rb Rob.Gay

[CL 32475660 by phil popp in ue5-main branch]
2024-03-25 13:35:20 -04:00
phil popp
89bea1a445 Fix clamping on metasound block rate override
#rnx
#jira UE-208569
#rb jimmy.smith

[CL 32003571 by phil popp in ue5-main branch]
2024-03-04 17:47:30 -05:00
phil popp
60e89663cd Fix race condition in metasound editor and async graph registration
#jira UE-204828, UE-199013
#rb Rob.Gay


#changelist validated
#virtualized

[CL 31218733 by phil popp in ue5-main branch]
2024-02-06 12:15:47 -05:00
maxwell hayes
bc39a66768 Cleaning up metasound experimental cvars
#rb Phil.Popp
#jira UE-205183
#rnx

[CL 31180968 by maxwell hayes in ue5-main branch]
2024-02-05 13:30:58 -05:00
rob gay
e5fa925482 Fix incorrect transient asset path being registered at times due to template node processing generating new transient object representing provided document interface object. (Added bonus with BuildRegistryDoc now actually living in RegistryImpl private implementation where it should've to begin with rather in asset base now that registration headers have been cleaned up).
#rb helen.yang
#jira UE-198785
#rnx

[CL 30424305 by rob gay in ue5-main branch]
2023-12-20 19:49:45 -05:00
rob gay
b7ecd11142 Remove and assert against registration/unregisteration calls of MetaSound graphs when cooking, and make all node unregistration calls synchronous when cooking
#rb helen.yang
#rnx
#tests AudioUnitTests, AudioQA -run=Cook -TargetPlatform=WindowsClient, rename asset, run Engine 'Audio' Automated Tests

[CL 30402526 by rob gay in ue5-main branch]
2023-12-19 15:55:04 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
helen yang
5c92e5dd0f Unregister graph on async task to prevent other MetaSounds being unable to find the node between unregistration and reregistration
#rb phil.popp

[CL 28863594 by helen yang in ue5-main branch]
2023-10-17 20:13:54 -04:00
rob gay
94048f43ca - Make FNodeRegistryKey an actual struct as opposed to a string alias
- Avoids string format/copies/conversions in most cases where its just used as a key
- Deprecate NodeRegistryKey namespace calls
#rb phil.popp
#rb helen.yang

[CL 28727626 by rob gay in ue5-main branch]
2023-10-12 16:37:45 -04:00
jimmy smith
f2080e3c96 [Resubmit] Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28627751 by jimmy smith in ue5-main branch]
2023-10-10 13:37:20 -04:00
phil popp
7e2c4e32d2 Fix deadlock in metasound node registration when updating assets
#rb Helen.Yang
#rnx
#jira UE-196443, UE-197063

[CL 28621450 by phil popp in ue5-main branch]
2023-10-10 11:32:28 -04:00
phil popp
eec8fd16a8 CIS fix crash in MetaSoundAssetBase.cpp check(IsInGameThread())
#rnx

[CL 28598801 by phil popp in ue5-main branch]
2023-10-09 16:58:25 -04:00