Commit Graph

95 Commits

Author SHA1 Message Date
phil popp
8846679f41 Recurse MetaSound Preset Graph Inflation as much as possible.
#rnx
#rb Rob.Gay

[CL 34465653 by phil popp in ue5-main branch]
2024-06-18 12:26:46 -04:00
rob gay
1b3382acee Guid collision fix-up follow-up renaming
#rb helen.yang, phil.popp
#rnx

[CL 34426347 by rob gay in ue5-main branch]
2024-06-17 12:51:18 -04:00
rob gay
be35f85305 - Move duplication to re-use registered builder at different points of duplication process as multiple builders per class name in the builder registry its now supported
- Give asset builders proper names based off the MetaSound asset being built for easier debugging
- Add log supression during duplication from spamming user as brief existence of multiple builders with shared class name is expected behavior (Leaving disabled until cook can be verified log is not being hit)
#rb helen.yang
#jira UE-216532
[FYI] sondra.moyls
#rnx

[CL 34245724 by rob gay in ue5-main branch]
2024-06-10 13:52:48 -04:00
rob gay
064e244218 - Make Version call to generate MetaSound Builder async GC-safe
- Misc clean-up
#rb phil.popp
#rnx
[FYI] helen.yang
#jira UE-216029

[CL 34017798 by rob gay in ue5-main branch]
2024-05-30 18:56:24 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
rob gay
e8e0c199a2 Remove dependency on MetaSound engine subsystems of any kind being required to register MetaSounds with frontend
#rb rob.gay
#rnx
[FYI] sondra.moyls, phil.popp, helen.yang

[CL 33199328 by rob gay in ue5-main branch]
2024-04-24 10:36:28 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
jimmy smith
0637da8f9e Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075

[CL 32370815 by jimmy smith in ue5-main branch]
2024-03-20 12:42:32 -04:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
jimmy smith
6726cb0e47 [Readd] Added better naming to new quality settings.
#jira UE-197606
#rb Rob.Gay

[CL 30138820 by jimmy smith in ue5-main branch]
2023-12-05 17:58:45 -05:00
rob gay
39b3a6f74c [MetaSounds] Report changes to transmitter and runtime input map when live edits are enabled during Builder audition
#rb charlie.huguenard
#rnx
#tests Audio Engine Tests including ConnectInputAfterAuditionAndThenSetParameter, Audio Unit Tests
#jira UE-201185
[FYI] sondra.moyls

[CL 30045928 by rob gay in ue5-main branch]
2023-12-01 12:57:59 -05:00
phil popp
af5147f91d Fix use of pooled metasounds using preset graph inflation and constructor inputs
#rnx
#rb Maxwell.Hayes

[CL 29431656 by phil popp in ue5-main branch]
2023-11-03 19:38:58 -04:00
phil popp
559eaa393f Fix default parameter values when skipping preset
#jira UE-199604
#rb Maxwell.Hayes
#rnx

[CL 29385950 by phil popp in ue5-main branch]
2023-11-02 18:41:29 -04:00
phil popp
427b14e23f Enable preset metasound sources to use their base graph instead of themselves.
#rb rob.gay

[CL 29320958 by phil popp in ue5-main branch]
2023-11-01 12:17:48 -04:00
maxwell hayes
da84c7b9a9 [CIS] fix for bad merge (multple definitions).
#rb none

[CL 28776454 by maxwell hayes in ue5-main branch]
2023-10-13 18:17:05 -04:00
maxwell hayes
8e9187b0cf [Metasounds] Operator precaching mechanism.
#jira UE-185725, UE-179996,
#rb phil.popp
#swarm https://p4-swarm.epicgames.net/reviews/27703580

[CL 28775007 by maxwell hayes in ue5-main branch]
2023-10-13 17:49:56 -04:00
jimmy smith
4cc08333b4 Fix for Metasounds not using device rate when Quality Settings are disabled
#jira UE-197723
#rb jake.burga

[CL 28692628 by jimmy smith in ue5-main branch]
2023-10-11 19:55:59 -04:00
jimmy smith
f2080e3c96 [Resubmit] Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28627751 by jimmy smith in ue5-main branch]
2023-10-10 13:37:20 -04:00
bob tellez
28443a5e59 [Backout] - CL28560665
[FYI] jimmy.smith
Original CL Desc
-----------------------------------------------------------------
Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28563662 by bob tellez in ue5-main branch]
2023-10-06 19:42:56 -04:00
jimmy smith
8eed59c6e9 Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28560930 by jimmy smith in ue5-main branch]
2023-10-06 18:51:06 -04:00
phil popp
a0366b7589 Fix deadlock when async building metasounds
Ensure MetaSound graphs are only registered on the game thread.
#rb Rob.Gay
#jira UE-196443, FORT-660159

[CL 28418467 by phil popp in ue5-main branch]
2023-10-03 12:17:13 -04:00