Commit Graph

63 Commits

Author SHA1 Message Date
lauri gurevicuis
1db7b04868 UE-146290 - [MetaSounds] - Dropdown menus do not support selection with arrow keys
#rb daren.cheng
#jira UE-146290

[CL 34452692 by lauri gurevicuis in ue5-main branch]
2024-06-18 04:56:33 -04:00
rob gay
2a101f5371 First pass at member display name code clean-up, misc bug fixes
#rb helen.yang
#rnx

[CL 34293732 by rob gay in ue5-main branch]
2024-06-11 18:27:11 -04:00
rob gay
69725d945e - Checkpoint for Initial MetaSound Pages document model support
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160

[CL 33983705 by rob gay in ue5-main branch]
2024-05-29 15:33:29 -04:00
miro salminen
63530f2a23 UE-171614
[MetaSounds] - Show input widgets for constructor pins while not playing
#rb helen.yang
#jira UE-171614
#rnx

[CL 33920580 by miro salminen in ue5-main branch]
2024-05-27 02:59:37 -04:00
ted percival
efa47e15c5 Fix error C4702: unreachable code in editor builds
[CL 33669559 by ted percival in ue5-main branch]
2024-05-15 16:38:38 -04:00
miro salminen
afc88d535b UE-213206 Bool Type has "button" widget option but no widget appears on the graph
#rb Aaron.McLeran
#jira UE-213206
#rnx

[CL 33324866 by miro salminen in ue5-main branch]
2024-04-30 02:33:39 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
miro salminen
e45d44728b Option to use AudioMaterialButton in Metasound Editor bool node
#rb Rob.Gay
#jira UE-210281
#rnx

[CL 32995345 by miro salminen in ue5-main branch]
2024-04-16 05:09:28 -04:00
miro salminen
c5547c3606 AudioMaterialSlider Label Unit text change and value processing depending on the selected Unit.
#rb helen.yang
#jira UE-209875
#rnx

[CL 32465402 by miro salminen in ue5-main branch]
2024-03-25 04:08:15 -04:00
helen yang
71c85d915f Enable pasting objects and object arrays from the content browser and BP into MetaSound default values
#jira UE-200546
#rb rob.gay

[CL 31660795 by helen yang in ue5-main branch]
2024-02-20 18:20:16 -05:00
helen yang
6482415575 Allow MetaSound member default literal values and read only member fields (name, display name, description) to be copy/pasted in the details panel
#jira UE-203252
#jira UE-200546
#rb rob.gay

[CL 31113424 by helen yang in ue5-main branch]
2024-02-01 19:54:26 -05:00
nicholas howe
1cff9d7ff8 MetaSound Frontend allows derived classes to attach to base class pins at runtime.
FDataTypeRegistry::GetDataTypeInfo walks up the class hierarchy searching for a registered class.
Adds FDataTypeRegistryInfo::bIsExplicit to replace the editor's IsExplicitProxyClass and enable the same functionality of requiring exact types at runtime.

#rb rob.gay
[REVIEW] [at]phil.popp
#preflight 6470afe55d3ca2dfd99ab6a1

[CL 25649438 by nicholas howe in ue5-main branch]
2023-05-26 13:55:21 -04:00
buzz burrowes
6a343186d8 MetasoundParameterPack V1
[REVIEW] [at]phil.popp [at]rob.gay [at]aaron.mcleran
#preflight 639b5db4012902cb8d76c448

[CL 23532613 by buzz burrowes in ue5-main branch]
2022-12-15 17:03:02 -05:00
helen yang
614fa56c85 Fix MetaSound input widget value not matching actual default value
#jira UE-168040
#rb rob.gay
#preflight 635547b40313c2497498ae78

#rnx

[CL 22779973 by helen yang in ue5-main branch]
2022-10-26 10:53:25 -04:00
helen yang
0f9445aed9 Fix undo/redo for MetaSound widgets and linear output for volume widgets
- Differentiate between normalized linear and audio linear value for volume output options

#jira UE-145790
#jira UE-155181
#rb phil.popp
#preflight 634f3778c569571da8a4ab2c
#rnx

[CL 22635724 by helen yang in ue5-main branch]
2022-10-19 15:34:44 -04:00
bryan sefcik
117472780d Fixed include paths.
#jira
#preflight 634ee62fe746026e48eb077e

[CL 22621687 by bryan sefcik in ue5-main branch]
2022-10-19 06:39:08 -04:00
rob gay
0a1401644a Remove AnalyzerAddress from MetaSound Editor UX/auto-node registration
#rb helen.yang
[REVIEW] helen.yang
#jira UE-165926
#rnx
#preflight 63445019e94bf5d35ebd356f

[CL 22436806 by rob gay in ue5-main branch]
2022-10-10 15:21:30 -04:00
rob gay
9dbc0c6693 [MetaSounds] Editor Graph Syncronization Upgrade
- Move synchronize/details panel flag to more generic ModifyContext
- Do not use MarkAsGarbage as means of enforcing not to show object in details panel to avoid leaving objects in invalid state if undo called. Check ed graph membership instead
- Get rid of leaky namechanged delegates
    - Allows for migration to isolated synchronization in the future
    - Removes conflation of having to synchronize and update views when modifying frontend document
    - Decouples concept of a specific view to update from generic frontend graph modifications
#rb helen.yang
#jira UE-151448
#preflight 632b7afdc7791417aa44126f

[CL 22142063 by rob gay in ue5-main branch]
2022-09-22 15:02:24 -04:00
helen yang
474b9a98b6 MetaSound constructor pin tooltip clarification
#rb trivial
#preflight skip
#rnx

[CL 21522872 by helen yang in ue5-main branch]
2022-08-23 18:22:57 -04:00
helen yang
e7764f0feb Remove cvar and unhide constructor pins from MetaSound editor
#rb trivial
#jira UE-151661
#preflight 62febf963c4417dcec218371

#rnx

[CL 21458268 by helen yang in ue5-main branch]
2022-08-19 11:39:24 -04:00
helen yang
abcf114f57 MetaSound Constructor pin editor-frontend integration checkpoint
- Both inputs and outputs can be constructor vertices, not just inputs
- Enforce connection and data type constraints for access types
- Prevent default value constructor value from being changed while playing
- Added cvar (default disabled) for enabling constructor pin option in editor

#jira UE-151661
#rb phil.popp
#preflight 62d59f4bf156340c79cfcbf5

[CL 21152841 by helen yang in ue5-main branch]
2022-07-18 17:14:25 -04:00
Rob Gay
d5645c2286 Split MetaSound DataType "IsArrayType()" function into bIsArrayParseable & bIsArrayType members, deprecating function in favor of caching booleans on DataType registration
Enforce single UObject class --> MetaSound Frontend class & fix-up callsites relying on ArrayObject type/literals using cached proxy type. This lead to confusion WRT what registered type is directly associated with a given UObject & possible bugs therein.
#rb phil.popp
#rnx
#jira none
#preflight 62c890fb2823f28cf281a8f1

[CL 21100292 by Rob Gay in ue5-main branch]
2022-07-14 17:51:07 -04:00
helen yang
730b1615b1 Various MetaSound Editor UX improvements for member defaults and selection
- Add Metasound editor setting for default input widget type
- Change member default type from bool to float
- Make widgets only available for inputs (no longer for variables)
- Automatically select/focus newly added/promoted nodes
- Selecting a single node selects the corresponding member in the graph member list if applicable

#jira UE-156767
#jira UE-156772
#rb rob.gay
#preflight 62aa1a77da0af39a474e8975

[CL 20688866 by helen yang in ue5-main branch]
2022-06-16 12:30:27 -04:00