Commit Graph

110 Commits

Author SHA1 Message Date
mathieu chamberland
91023592d5 Removing CVar "CommonInput.ResetCursorPositionOnTouchInput" that reset the virtual cursor position on input method changed to touch in cl 34163425 as it is causing regression when switching to touch input.
[REVIEW] [at]Maxime.Vaillancourt
[FYI] [at]Pierre.Ung
#rb daren.cheng, Maxime.Vaillancourt, velin.tchalakov

[CL 34339263 by mathieu chamberland in ue5-main branch]
2024-06-13 10:07:25 -04:00
liz barrett
610e75dbf6 Added new OnInputIconUpdated event to CommonActionWidget
This event is necessary for the blueprint to listen to icon changes in order to set the dark mode on every icon update

#tests
- Ran editor locally successfully


#rnx
[REVIEW] [at]michael.ekberg, [at]jay.thrash, [at]fernando.pereira, [at]jonathan.younger, [at]alex.battista,  [at]saad.nader
#rb stephen.sanders

[CL 34328837 by liz barrett in ue5-main branch]
2024-06-12 20:28:27 -04:00
pierre ung
d42c586559 Added a CVar "CommonInput.ResetCursorPositionOnTouchInput" (Disabled by default) that reset the virtual cursor position on input method changed to touch.
[REVIEW] [at]Maxime.Vaillancourt, [at]Daren.Cheng, [at]Velin.Tchalakov

#rb daren.cheng, Maxime.Vaillancourt, rodrigo.cordova, velin.tchalakov

[CL 34163506 by pierre ung in ue5-main branch]
2024-06-06 13:08:39 -04:00
liz barrett
2b845e7ca5 Updated CommonActionWidget to add new function for getting the Dynamic Material Instance of the icon
This change came as a result of a suggestion made by [at]saad.nader on this slack thread: https://epicgames.slack.com/archives/C044SQFRJ77/p1715606821365059

We willl need to test this change against in progress blueprint changes made be [at]alex.battista to see if it solves what he's looking to do. If this change is not successful in accomplishing what Alex needs, I will likely need to investigate having these stylized icons managed by CommonUI instead in a more data-driven way suggested by [at]daren.cheng: https://epicgames.slack.com/archives/C044QE26U4C/p1717103172767049

#tests
- Ran editor locally successfully

#rnx
[REVIEW] [at]michael.ekberg, [at]jay.thrash, [at]fernando.pereira, [at]jonathan.younger, [at]alex.battista,  [at]saad.nader, [at]daren.cheng
#rb daren.cheng, jonathan.younger, michael.ekberg

[CL 34075062 by liz barrett in ue5-main branch]
2024-06-03 16:04:16 -04:00
andrey protsenko
fe430d6f4e Add hold state query methods to CommonButtonBase.
[REVIEW] [at]daren.cheng [at]jc.authier
[FYI] oleksandr.osovskyi
#rnx
#rb daren.cheng, jc.authier

[CL 34062183 by andrey protsenko in ue5-main branch]
2024-06-03 06:48:54 -04:00
brandon schaefer
e64748d3de Disable the top modules that are not currently set to enable AutoRTFM
#rb neil.henning

[CL 34015003 by brandon schaefer in ue5-main branch]
2024-05-30 17:59:48 -04:00
alejandro aguilar
797c37e9b1 Implemented new type priority system for InputPreProcessors in SlateApplication, refactored callsites and removed re-registration hacks
#jira UE-211309
[REVIEW] [at]Chris.Varnsverry, [at]Michael.Atchison, [at]Ben.Hoffman, [at]Daren.Cheng
#rb ben.hoffman, daren.cheng, michael.atchison

[CL 33922813 by alejandro aguilar in ue5-main branch]
2024-05-27 08:44:21 -04:00
Pavel-Konarik
554fa41dcc PR #11900: Fixed unsafe pointer in CommonActionWidget (CommonUI)
#jira UE-215337
#rb daren.cheng
#tests Lyra PIE Gamepad Frontend

[CL 33904746 by Pavel-Konarik in ue5-main branch]
2024-05-24 16:15:00 -04:00
cody albert
c48b81fad5 Fix FCommonInputActionDataBase != operator
#rnx

[CL 33773942 by cody albert in ue5-main branch]
2024-05-20 14:24:42 -04:00
daren cheng
62fed1a46d Remove enum state functionality
#rb Patrick.Boutot
#tests PIE

[CL 33319006 by daren cheng in ue5-main branch]
2024-04-30 01:01:46 -04:00
DoubleDeez
e8462984b5 PR #11718: CommonUI: Fix not being able to remove widgets from a UCommonActivatableWidgetContainerBase after slate resources have been released
#jira UE-211424
#rb daren.cheng
#tests PIE

[CL 33313170 by DoubleDeez in ue5-main branch]
2024-04-29 16:35:52 -04:00
joe kirchoff
48c2357147 Remove unnecessary private include path to CommonUI
#rnx
#jira UE-193731

[CL 33252888 by joe kirchoff in ue5-main branch]
2024-04-25 20:04:48 -04:00
daren cheng
5cba84bfa7 Free widget list in ReleaseSlateResources for Activatable Containers, also clear pool and migrate widgets into inactive list so they can be reused.
#jira UE-203812
#tests PIE Lyra
#rb daren.cheng
[FYI] Saad.Nader, editor-ui-systems

[CL 32978440 by daren cheng in ue5-main branch]
2024-04-15 18:39:19 -04:00
pierre cudennec
e0d2074584 Exposing the OnLockClicked and OnLockDoubleClicked events for CommonButtonBase BP accessibility
#Reviewers [at]Maxime.Vaillancourt, [at]Ghislain.Theriault, [at]Pierre.Ung, [at]Mathieu.Chamberland
#rb daren.cheng, Maxime.Vaillancourt

[CL 32895673 by pierre cudennec in ue5-main branch]
2024-04-11 13:13:49 -04:00
robomerge
928b6e4571 [REVIEW-32890680] [at]stephan.delmer [at]francisco.scutaro [at]sebastian.sueldo [at]victor.portela [at]arturo.espinoza
#tests in Editor (PIE)

#reviewdoc https://docs.google.com/document/d/1j3uNhojPWC5xaj4wGmjCNiIXQsAzNndpYbXXuPk2F5M/edit?usp=sharing

[FYI] tomas.maierowicz
#rb christian.savoie, Saad.Nader, victor.portela


#changelist validated
#virtualized

[CL 32890674 by robomerge in ue5-main branch]
2024-04-11 10:54:21 -04:00
ben zeigler
12107abc07 Fix some world-bound UObjects that subclass FTickableGameObject to correctly disable tick on Deinitialize/BeginDestroy so they will not crash when trying to tick after GC starts.
These fixes are equivalent to the recent change 32555870 that fixed TickableWorldSubsystem.
#jira UE-204963
#rb jodon.karlik, Mieszko.Zielinski

[CL 32866852 by ben zeigler in ue5-main branch]
2024-04-10 18:43:25 -04:00
mathieu chamberland
c8b0c06b91 Pass down the FocusCause when redirecting the focus from the UUserWidget to the DesiredFocusWidget.
Make sure the UCommonButtonInternalBase is not focusable when a DesiredFocusWidget is set in the CommonButtonBase. This will prevent UCommonButtonInternalBase from stealing the focus of the DesiredFocusWidget.
[REVIEW] [at]maxime.vaillancourt, [at]ghislain.theriault, [at]vincent.gauthier, [at]daren.cheng
[RN] UUserWidget will now send the FocusCause received to the Desired Focus Widget when set. CommonButtonBase's UCommonButtonInternalBase RootButtonRaw will no longer be focusable when a DesiredFocusWidget is set, preventing it from stealing the focus to the DesiredFocusWidget.
#rb ghislain.theriault, Vincent.Gauthier

[CL 32791785 by mathieu chamberland in ue5-main branch]
2024-04-08 10:02:54 -04:00
devan england
655ff95263 [CommonUI] Adding transition fallback capability to CommonAnimatedSwitcher to handle cases when relevant slots are removed during a transition.
#rb daren.cheng, Saad.Nader

#changelist validated
#virtualized

[CL 32450138 by devan england in ue5-main branch]
2024-03-22 16:56:36 -04:00
daren cheng
2283587bfa Fix ensure firing on selection change during destruct.
#rb yohann.dossantos
#tests Lyra PIE tabbing

[CL 32412412 by daren cheng in ue5-main branch]
2024-03-21 16:07:40 -04:00
viktor chlumsky
5c681ff70f UMG: Update remaining UTextLayoutWidget properties to work with Style Sheets
[REVIEW] [at]Peter.Rockwell, [at]christian.savoie, [at]jc.authier, [at]Patrick.Boutot, [at]Vincent.Gauthier
#rb christian.savoie, daren.cheng, Peter.Rockwell

[CL 32410819 by viktor chlumsky in ue5-main branch]
2024-03-21 15:34:49 -04:00
viktor chlumsky
6595c614e2 UMG: Make sure that CommonUI button object remains consistent after changing sound override properties
[REVIEW] [at]Peter.Rockwell, [at]christian.savoie, [at]jc.authier
#rb daren.cheng

[CL 32410667 by viktor chlumsky in ue5-main branch]
2024-03-21 15:33:14 -04:00
steve robb
8517c776db Added UE_DEPRECATED_HEADER which acts like UE_DEPRECATED and should be placed in headers that should no longer be included.
#rb devin.doucette

[CL 32297380 by steve robb in ue5-main branch]
2024-03-18 07:05:59 -04:00
ben zeigler
7ab8cbe770 Fix log spam in CommonUI that was happening on every garbage collect
#rb daren.cheng

[CL 32061002 by ben zeigler in ue5-main branch]
2024-03-06 13:48:58 -05:00
MinusKube
b58b2ce44f PR #11449: Fix typo in log format string when a widget gets deactivated
#rb daren.cheng
#jira UE-206370

[CL 31404480 by MinusKube in ue5-main branch]
2024-02-12 17:58:09 -05:00
saad nader
d7cc8e33f0 CommonTabListWidgetBase
- Updated CommonTabListWidgetBase to use a widget pool for the case of recreating tabs in this widget.
- It should alleviate the need to call create widget any time we're trying to build a new set of tabs. It also improves performance for that case.
[REVIEW] [at]daren.cheng, [at]patrick.boutot, [at]ben.humphreys, [at]bruce.sutherland, [at]matthew.johnson3

[CL 31385896 by saad nader in ue5-main branch]
2024-02-12 11:50:15 -05:00