Commit Graph

22 Commits

Author SHA1 Message Date
ben hoffman
0c75ece16d Add LLM memory tags for EKeys and the FKeyManager to reduce the number of "untagged" allocations
#jira UE-154196
#rnx
#rb Phillip.Kavan

[CL 33307946 by ben hoffman in ue5-main branch]
2024-04-29 14:17:12 -04:00
robert manuszewski
d3991fec9b Fixing potential compile errors ahead of enabling TObjectPtr GC barrier
#rb trivial

[CL 26868625 by robert manuszewski in ue5-main branch]
2023-08-05 06:09:54 -04:00
ben hoffman
119aaac9f9 Specify what asset is using the mapping name if one exists already, making it much easier to track down in use mappings :)
Add in a cvar 'EnhancedInput.Editor.EnableMappingNameValidation' to toggle name validation, just to make sure that we can do sanity checks that the validation is actually accurate

#rb nate.strohmyer
#rnx
#preflight 643712e90c4277fc0bce6fdf

[CL 25018938 by ben hoffman in ue5-main branch]
2023-04-12 19:29:49 -04:00
ben hoffman
f180f2cf58 Add a name validator to player mappable setting names. This makes it easier to avoid mistakes and possibly stomping a key binding.
The "Name" here is the FName that will be used as a key to save each key mapping during serialization, so they should be unique for each key mapping that you want the player to be able to set.

#jira UE-177248
#preflight 63f4ef2290198dffba48f6ee
#rb benjamin.fox
#rb nate.strohmyer
#rnx

[CL 24344605 by ben hoffman in ue5-main branch]
2023-02-21 13:37:27 -05:00
ben hoffman
c7be5a35ea Deprecate the old FPlayerMappableOptions struct in favor of the more extensible PlayerMappableKeySettings.
Automatically populate the newer player mappable key settings based on any old data in the player mappable options.

Clean up call sites to the now deprecated stuff

#jira UE-175936
#rb benjamin.fox
#rnx
#preflight 63e54d307250a911fa85d9f7

[CL 24135344 by ben hoffman in ue5-main branch]
2023-02-11 11:38:39 -05:00
nate strohmyer
80a4c6d6b8 Combo trigger Improvements.
Fixing issues with combo triggers being overriden
Can specify events that progress/cancel combo
some smaller UX fixes

#Jira UE-170233, UE-169334
#rb ben.hoffman
#preflight 63bf4f87c543a64b7d7320f6

[CL 23747881 by nate strohmyer in ue5-main branch]
2023-01-17 18:37:06 -05:00
henrik karlsson
2f78497e67 [Engine/Plugins]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn

#preflight 63bf8d8b577437afe607dc72
#rb none

[CL 23659643 by henrik karlsson in ue5-main branch]
2023-01-12 01:48:34 -05:00
bryan sefcik
d68153a097 Moved some of the logic from GatherClassDetailsCDOs to CustomizeDetails so the expensive operations that could be shared were done once.
Before: 359ms
After: 181ms

#jira
#rb nate.strohmyer
#preflight 638652a133774509007479bc

[CL 23316931 by bryan sefcik in ue5-main branch]
2022-11-29 15:52:36 -05:00
nate strohmyer
0687afefe8 Updating Input Mapping Contexts when Input Action triggers/modifiers are modifiied
#Jira UE-169062, UE-169058
#rb ben.hoffman
#preflight 63699ba57c2b50519067e1e2

[CL 23159625 by nate strohmyer in ue5-main branch]
2022-11-16 14:44:56 -05:00
Zousar Shaker
0c39ca3ae9 Fix encountered instances of TObjectPtr<T> used with T that is not derived from UObject. A subsequent change will be disallowing this at compile time.
#rb none
#preflight 6362a7ae54471d10be04e7a9

[CL 22921150 by Zousar Shaker in ue5-main branch]
2022-11-02 13:45:42 -04:00
nate strohmyer
14f19c6143 Displaying Input Action Triggers/Modifiers in Input Mapping Contexts to improve clarity
#Jira UE-161060
#rb ben.hoffman
#preflight 63582216e9227c91a6b1d262

[CL 22890126 by nate strohmyer in ue5-main branch]
2022-11-01 16:01:14 -04:00
michel champoux
1e995ee48b - Created instanced mappable key settings that can be overridden to add per project functionality.
- Instanced mappable key settings are fetched based on a setting behavior enum.
    - InheritSettingsFromAction to use the setting defined by the action
    - OverrideSettings to override the settings defined in the action, and use the ones defined in the action key mapping.
    - IgnoreSettings to ignore settings completely for this action key mapping.
- Added blueprint facing helper functions to accessing mappable key settings.
- Shifted over data validation in to the Action Key Mapping.

#rb [at]Mic.Rooney, [at]Pamela.Figueroa, [at]Ben.Hoffman

[CL 22850406 by michel champoux in ue5-main branch]
2022-10-29 01:42:11 -04:00
nate strohmyer
e853e09d1b Renaming Combo Trigger Input Trigger to fix a compile error when opening Lyra
#Jira UE-165545
#rb ben.hoffman
#preflight 6337346fb34118b9b4b792c9
#rnx

[CL 22322193 by nate strohmyer in ue5-main branch]
2022-10-03 20:37:03 -04:00
nate strohmyer
fad5ae0c44 Enhanced Input: Add class picker for Input Action and Input Mapping Context factories (Contributed by aquanox)
#Jira UE-163457
#rb ben.hoffman
#preflight 6329ef49f87253e0211ce2e9
#9557

[CL 22098175 by nate strohmyer in ue5-main branch]
2022-09-20 14:16:40 -04:00
nate strohmyer
8dbfbf8d97 Make mapped key tooltip more helpful when disabled from a combo trigger
#Jira UE-163036
#rb ben.hoffman
#preflight 631a47ea2b7fe03eb6c064b9

[CL 21929870 by nate strohmyer in ue5-main branch]
2022-09-09 18:18:06 -04:00
nate strohmyer
652f6fc5d2 Making it clear that a key is not necessary/usable for Combo actions
#Jira UE-159662
#rb ben.hoffman
#preflight 63042600a45b007ea25c622f

[CL 21767915 by nate strohmyer in ue5-main branch]
2022-09-02 17:16:33 -04:00
Matt Peters
803e794b36 AssetRegistryModule: Add TryGet function that can return null instead of asserting during Engine shutdown.
#jira UE-157056
#rb PJ.Kack
#rnx
#preflight 62b1d7fd827ccccb2cdec5a3

[CL 20758071 by Matt Peters in ue5-main branch]
2022-06-21 11:07:36 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
ben hoffman
39f8ee0c4b Exclude blueprint assets that have been marked for deletion in the content browser when we are building the enhanced input trigger defaults panel.
#jira UE-93458
#rb trivial
#preflight 62967495db7419b82988fed0
#rnx

[CL 20443183 by ben hoffman in ue5-main branch]
2022-05-31 17:56:10 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
ben hoffman
0e0fe95da9 Refactor of the Enhanced Input Project Settings. This moves the Trigger and Modifier default value customizations to the "InputCustomizations" header file, and out of the InputEditorModule. This allows us to simply add a class customization for the Developer Settings, and combine the two setting panels.
#jira UE-144850
#rb andrew.davidson
#preflight 6245e42d8f066102242239d8

[CL 19577762 by ben hoffman in ue5-main branch]
2022-03-31 16:16:07 -04:00
ben hoffman
f67d3f3d13 Move the enhanced input plugin out of Experimental and into the normal /Engine/Plugins folder.
#jira UE-144847
#rb trivial
#preflight 62228bcf2f7d78332e1c4548

[CL 19277106 by ben hoffman in ue5-main branch]
2022-03-04 17:59:01 -05:00