#rb jack.porter
[FYI] Dmitriy.Dyomin
#rnx
[FYI] carl.lloyd
#ROBOMERGE-OWNER: allan.bentham
#ROBOMERGE-AUTHOR: allan.bentham
#ROBOMERGE-SOURCE: CL 12162757 via CL 12162758 via CL 12163188
#ROBOMERGE-BOT: (v661-12148976)
[CL 12163190 by allan bentham in Main branch]
#rnx
#rb none
#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870584 by ryan durand in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3944462 by Jack.Porter
Prevent TVOS packaging from PC from attempting to build an asset catalog
#jira UE-56114
Change 3943602 by Leslie.Nivison
Adding licenses for additional TPS
#jira none
Change 3943597 by Leslie.Nivison
Adding Enterprise licenses; licenses for additional TPS.
#jira none
Change 3941962 by Leslie.Nivison
Updating 4.19 credit list
#jira none
Change 3941865 by Mark.Satterthwaite
Fix the incorrect landscape rendering and the incorrect render-to-texture from blueprint bugs with MetalRHI.
- Track outstanding AsyncCopyBufferFromBufferToBuffer operations to identify attempts to modify overlapping ranges within the same prologue command-buffer. This doesn't work and requires that we break the current render-pass and issue on the current command-buffer. A log warning will be emitted when this occurs.
- Don't attempt to alias private memory buffers the moment they are released from the RHI resource because that can lead to incorrect sharing of the memory when used by AsyncCopyBufferFromBufferToBuffer.
#jira UE-56021
Change 3940993 by Marc.Audy
Do not return the last column if the specified column does not exist.
Allow display names to be used when looking for a property if the table is backed by a user defined struct.
Do not crash if a property with the given name is not found.
#jira UE-56017
Change 3939179 by Ben.Marsh
Revert change to not poison memory in development configuration. Making a tradeoff that editor stability and consistency is more important than performance.
#jira
Change 3938566 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Missed a case.
Change 3938533 by Dan.Oconnor
Fix uninitialized variable exposed by recent MallocTBB change
#jira UE-56013
Change 3938508 by Aaron.McLeran
Fixing CIS error, init order issues.
#jira UE-55940
Change 3938490 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Change 3938352 by josh.jensen
Show an error message for Windows iOS builds when packaging/launching and icons are present but no remote Mac is specified
#jira UE-55987
Change 3938345 by Peter.Sauerbrei
fix to Icons not being built on Mac
#jira UE-53492
Change 3938305 by Mark.Satterthwaite
For whatever reason moving the buffer initialisation into the prologue command buffer doesn't work - this make absolutely no sense to me. I suspect that this is *merely* moving a render pass boundary around somewhere and forcing raster-state to be reapplied.
#jira UE-56005
Change 3937968 by Ben.Marsh
Disable the boot DDC if we're not in the editor. Fixes access violations when multiple SCW instances attempt to read/write to the same file.
#jira UE-56003
Change 3937573 by Mitchell.Wilson
Saving asset to resolve empty asset warning.
#jira UE-56004
Change 3937561 by Max.Preussner
ImgMedia: Added support for single-threaded platforms
Copied from Dev-Sequencer CL# 3937516
#jira UE-55986
Change 3937305 by Mike.Beach
Resaving google VR model content with UGS build to fix the empty file version error.
#jira UE-55984
Change 3935595 by Arne.Schober
Fix missing UV precission on BSP surfaces
#jira UE-54014
Change 3935411 by josh.jensen
Fixed Windows iOS remote Mac build issue where the user icons were considered remote Mac compilation targets coming solely from the Engine directory
#jira UE-55899
Change 3934982 by Marc.Audy
Fix shadow variable issue
#jira UE-55957
Change 3934892 by Mark.Satterthwaite
In MetalRHI treat BUF_Volatile buffers as Shared or Managed memory in all circumstances so that multiple updates within a render pass are respected even though this will hurt CPU performance. This fixes GPU particles on macOS. Also push initialisation upload into the async. command buffer to avoid it overwriting a later Lock/Unlock! Only read-back and copy-buffer operations should be on the 'current' command buffer as they need to be inline with all outstanding commands.
#jira UE-55956
Change 3934421 by Arciel.Rekman
Fix lockup/OOM when setting audio sources to 2 (UE-53968).
#jira UE-53968
Change 3934156 by Peter.Sauerbrei
fix for backgrounding problems on iOS and tvOS
this will re-open UE-50979 as the fix for that was not correct and would have caused crashes when backgrounding during startup
#jira UE4-55609
Change 3933547 by Aaron.McLeran
#jira UE-55940 Fix for wavetable sample duration and seek
Change 3933544 by Aaron.McLeran
#jira UE-55939 Hiding channel format
Submix channel format is an experimental feature and shouldn't be exposed to the submix editor for 4.19.
Change 3933540 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3933280 by Ethan.Geller
[Release-4.19] #jira UE-55810 Ensure AudioComponent is created before we start using it. #rb Aaron.McLeran
Change 3933079 by Ryan.Vance
#jira UE-55936
Fixed missing referenced uniform bindings on AR pass-through camera shaders.
Change 3932319 by Ben.Zeigler
#jira UE-55885 Fix corruption of packages when starting and then cancelling an async load of a package that already exists, or attempting to async load a script package
It now keeps track of which packages were created by the async load system and will only throw those away on cancel
Copy of CL #3932312
Change 3932287 by Matt.Kuhlenschmidt
Updated substance texture
#jira UE-55081
Change 3931729 by josh.jensen
Ensure the tvOS and iOS Assets.car is always produced as part of a regular remote/local build
#jira UE-55899
Change 3929723 by josh.jensen
Removed packaging requirement on Windows of a remote Mac after setting an app icon to default
#jira UE-53495
Change 3929722 by josh.jensen
Fixed iOS asset catalog generation issues when swapping out/resetting to default app icons for both code- and BP-projects
#jira UE-53492, UE-51879
#robomerge
Change 3929350 by Mike.Erwin
"Save As" support for
#jira UE-55732
Change 3927829 by Steve.Robb
Out-of-memory handler for MallocStomp.
#jira UE-55550
Change 3926404 by Mike.Erwin
#jira UE-55732
Change 3926394 by Dan.Oconnor
Recompile bytecode dependencies when compiling an individual blueprint interface, this prevents crashes due to stale bytecode
#jira UE-55813
Change 3926098 by Guillaume.Abadie
Do not allow dynamic resolution to be enabled on unsupported platforms avoiding game breaker experience by security.
#jira UE-55697
Change 3925927 by Guillaume.Abadie
Enables TAA's AA_BORDER on all permutation for dynamic resolution.
#jira UE-55353
Change 3925882 by Matt.Kuhlenschmidt
Fix substance uri having one extra /
Fix substance menu option showing up for github (incompatible with plugin)
#jira UE-55766
Change 3925873 by Ben.Zeigler
#jira UE-55783 Fix issue introduced in 4.18 where user structs did not handle converting AssetPtrs to SoftObjectPtrs properly
Copy of CL #3925871
Change 3925163 by Guillaume.Abadie
Fixes DFAO's temporal AA passes that was handling FViewInfo::ViewRect.Min wrongly.
#jira UE-55788
Change 3924839 by Guillaume.Abadie
Fixes a crash of LDR android preview with OS DPI scale != 0.
#jira UE-43622
Change 3924542 by Cosmin.Sulea
Merged fixes:
UE-55299 - XGE Shader Compile Interferes with Remote Shader Compiling Causing Materials to Fail to Compile #7
UE-51086 - No clear editor activity during remote shader compiling
#jira UE-55299
Change 3922398 by Mark.Satterthwaite
Compile fix for 3922273.
#jira UE-53993
Change 3922273 by Mark.Satterthwaite
Fix validation error caused by the game updating its orientation before the drawable system catches up. We need to drop drawables that are incorrectly sized until we get one with the correct size.
#jira UE-53993
Change 3921127 by Ethan.Geller
[Release-4.19] #jira UE-55744: Add OnTick virtual to IAudioPluginListener, fix thread safety issue in Resonance Audio. #rb aaron.mcleran
Change 3920632 by Lina.Halper
Fix render thread crash when morphtarget is deleted or added
#jira: UE-55521
Change 3920557 by Lauren.Ridge
Fixing material editor resetting background to off
#jira UE-55267
Change 3920519 by Phillip.Kavan
Fix a regression in which elements would not be initialized when constructing the value assignment for UDS-typed container members in nativized Blueprint C++ code.
Change summary:
- Modified FEmitDefaultValueHelper::InnerGenerate() to remove UDS from the list of special cases that avoid calling InitializeStruct() as part of new element construction. Previously the conversion code assumed the compiler would perform value initialization of a nameless temporary, but that is no longer valid in 4.19, as UDS types have been changed to function more like native structs, and as such all converted UDS types will now emit an explicit default ctor which is now used to assign defaults that differ from the zero-initialized value.
#jira UE-55628
Change 3920476 by Michael.Trepka
Clean up Mac menu item cache at exit before SlateApplication is fully destroyed.
#jira UE-55599
Change 3920336 by Ben.Marsh
Ignore license warnings from PVS-Studio.
#jira UE-55729
Change 3920134 by Jurre.deBaare
Moving over:
"HLOD: Building HLOD for P map with sublevels requires HLODSetupAsset when it should not
#fix Ensure that we dynamically add HLOD level treeview items whenever they are required, rather than adding a static number of levels according to the worldsettings"
#jira UE-55619
Change 3920126 by Max.Preussner
MediaCompositing: Implemented media track for Sequencer
Copied from Dev-Sequencer
#jira UE-53974
Change 3920004 by Jack.Porter
Disable Manual Vertex Fetch SRV creation when MVF is disabled.
Made a single RHISupportsManualVertexFetch(EShaderPlatform) to control whether to use MVF. The Shader Platform (or alternatively, feature level) is the only thing that can decide whether or not to use MVF because we need to know when we compile the shaders if we're going to do MVF or not. Checking GSupportsResourceView at runtime is useless because the shaders can't change and so if GSupportsResourceView can ever be false for a platform, the shaders need to have been built without it.
Creating SRVs without using them on mobile is not harmless because several devices don't support formats that are needed.
#jira UE-54764
#jira UE-55622
Change 3919069 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3918942 by Graeme.Thornton
Added "ProjectBuildMutatorFeature" modular feature, allowing plugins to register said feature and dictate whether the current project requires a code build. CryptoKeys plugin uses this feature to force a code build when encryption or signing is enabled.
#jira UE-55686
Change 3918721 by Zak.Parrish
Lighter version map for Gremlin + new Engine.ini - result is 60Hz #jira none
Change 3918236 by Joe.Graf
Added a bFlipTrackedRotation to give a better result when mirroring the rotation of a tracked face
#jira: UE-55531
Change 3917970 by Martin.Wilson
Expose curve data in remap assets to blueprints
#jira UE-55585
Change 3917740 by Olaf.Piesche
Properly checking for presence of buffer SRV capability via GSupportsResourceView so ES3.1 and Metal devices don't crash using GPU particles (and possibly in other circumstances);
#jira UE-55591
Change 3917713 by Cody.Albert
Build fixes for Match3 on iOS
#jira UE-53742
Change 3917472 by zak.parrish
added mouthPressLeft and MouthPressRight back into debug screen #jira none
Change 3917244 by Michael.Dupuis
#jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsections and material containing grass spawning node
Change 3916775 by Ben.Marsh
Add missing files for packaging IOS on Windows.
#jira UE-53873
Change 3916293 by Joe.Graf
Removed the redundant GetTransform() from UARFaceGeometry since GetLocalToWorldTransform() is exposed on a base class
#jira: UE-55531
Change 3916011 by Joe.Graf
Added an accessor to get the transform of the face mesh or a face mesh component
#jira: UE-55531
Change 3915967 by Mark.Satterthwaite
Place buffer updates into the prologue command-buffer in MetalRHI to avoid breaking the current command-encoder. This improves performance, though the semantics of Metal now differ subtly to other RHI implementations as the buffer updates happen prior to the SetRenderTargets call in the GPU's view of the world.
#jira UE-54858
Change 3915751 by Nick.Atamas
Merging CL 3913931 from //UE/Partner-Google-VR/... to //UE4/Release-4.19/...
#jira UE-55639
Change 3915421 by Martin.Wilson
Fix crash from live link message bus heartbeat manager
#jira UE-55644
Change 3915326 by Dan.Oconnor
Make compilation manager's skeleton class layout better match the old compilation path's skeleton class layout, fixes a crash when renaming blueprint functions
#jira UE-55592
Change 3915250 by JeanLuc.Corenthin
Can't add C++ code to Enterprise projects (when enterprise is installed)
Root cause: When compiling a C++ project, Datasmith modules are included in the build process (with the wrong path)
Fix:
- Added two more Enterprise directories, Plugins and Intermediate, to the Enterprise directories to check against
- Build the correct path for the Datasmith modules and plugins in FindOrCreateModuleByName. Added check to see if module is under one of the Enterprise directories.
- Added modules to list of precompiled modeules in UEBuildTargets.AddPrecompiledModules if Engine and Enterprise are 'installed and the module is under Enterprise.
#jira UEENT-1032
Change 3915240 by Ben.Marsh
Reduce editor startup times by ~15s on Windows.
Platform loading code recursively scans every module for dependent DLL modules to load first. Change to make it early-out as soon as it encounters a module which is already in memory (via a call to GetModuleHandle() from ResolveMissingLibraryImportsRecursive). Also use a TSet<> to store set of visited modules rather than an Array.
Now spends <0.1s total in this function on editor startup.
(Change looks larger than it is due to moving functions out of WindowsPlatformProcess.h to avoid introducing TSet dependency into this header).
#jira UE-55642
Change 3914803 by Gil.Gribb
UE4 - Removed memory track from the lock free list links. This is not safe and will sometimes assert in debug.
#jira UE-49600
Change 3914616 by zak.parrish
Adding Calibrate button #jira none
Change 3914599 by Andrew.Rodham
Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified
- The following sequence of events exposes this issue:
- Create a master sequence with a single shot that spawns a cube
- Add this sequence to a level and set it to auto-play
- Save everything and restart
- Resave just the inner shot asset without opening it
- PIE
- The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template.
#jira UE-55626
Change 3914479 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3914347 by Martin.Wilson
Stop anim preview instance from ever running in parallel
#Jira UE-55577
Change 3914179 by Benn.Gallagher
Fixed clothing sections not displaying in LOD section list in skeletal mesh editor, due to no longer duplicating clothing sections in the model data.
#jira UE-55528
Change 3914122 by Steven.Barnett
Fix perf regression in BSP queries by changing suppression of PhysX mesh cleaning failure message.
#jira UE-54081
Change 3913950 by zak.parrish
Clamping my normalization math #jira none
Change 3913926 by Zak.Parrish
First pass at Gremlin Calibrate button. Also added shirt/backpack to boy so he's not a floating head. #jira none
Change 3913668 by Matt.Kuhlenschmidt
Adding missing substance styling info
#jira UE-55081
Change 3913667 by Nick.Atamas
Merging CL 3912976 from //UE4/Partner-Google-VR/... //UE4/Release-4.19/...
Upgrading to support ARCore 1.0 runtime.
#jira UE-55602
Change 3913645 by Aaron.McLeran
#jira UE-55618 fix for mono audio devices
Change 3913509 by Cody.Albert
Removing PhsX build exclusion from Match3
#jira UE-53742
Change 3913380 by Dan.Oconnor
Preload Sequence Bindings node at proper time
#jira UE-55412
Change 3913300 by Mitchell.Wilson
Updating iOS default startup movie to H.264, 1280x720, 30 fps.
#jira UE-55382
Change 3913291 by Cody.Albert
More iOS build fixes for Match3
#jira UE-53742
Change 3913169 by Cody.Albert
Fixed iOS build issues for UnrealMatch3
#jira UE-53742
Change 3913131 by Krzysztof.Narkowicz
Fixed remaining quad overdraw viewmode contents on screen after switching to certain other viewmodes (e.g. light overlap or complexity)
#jira UE-54580
Change 3912851 by Lina.Halper
Fixed issue with pose asset blending additively multiple poses suming up to 1 weight.
#jira: UE-55603
Change 3912629 by Guillaume.Abadie
Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera.
#jira UE-55353
Change 3912170 by Martin.Wilson
Add logging for UE-55511 (NaN crash)
#jira UE-55511
Change 3912161 by Phillip.Kavan
Fix editor-only default subobjects inherited from a native C++ parent class not being handled correctly during nativized Blueprint class ctor generation.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to skip editor-only checks for instanced default subobjects. These will have already been created by a native parent class.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert before creating a "dummy" component in place of an editor-only instance if we're not supposed to be creating it.
#jira UE-55474
Change 3912100 by Luke.Thatcher
[RELEASE] [^] Merging (as edit) fix for building pak patches (CL 3911754) from //UE4/Dev-Core to //UE4/Release-4.19
#jira UE-55340
Change 3912072 by Mike.Beach
Art cleanup pass on AR template icon.
#jira UE-55587
Change 3912057 by Michael.Trepka
Additional widget path validity check in FSlateUser::NotifyWindowDestroyed()
#jira UE-55580
Change 3911592 by Jurre.deBaare
Crash on merge actor when Use specific LOD Level
#fix make sure we use the correct array to determine the number of components being merged
#jira UE-55508
Change 3911466 by Cosmin.Sulea
Mega change list for the following related issues:
UEMOB-417 - Support Xcode automagical code signing
UE-49829 - Remote build fails to use / sign distribution provisions coming from PC
UE-39501 - Packaging for tvOS in Distribution fails to find valid provision
UE-55334 - XCode managed provisions donâ•žt operate gracefully with manual provisions
UE-55330 - Automatic signing doesn't work with tvOS
UE-10969 - Remote build fails if there is no development provision provided
#jira UEMOB-417
Change 3911454 by Luke.Thatcher
[RELEASE] [!] Fix rendering thread memory leak in FLandscapeComponentSceneProxy::InitViewCustomData
- FViewCustomDataLOD is allocated on a memstack, but contains a TArray, so is not trivially destructible.
- The SubSections array is leaked when the memstack is popped.
- Fix replaces the TArray with a TStaticArray of max size MAX_SUBSECTION_COUNT (which is 4).
(Merging as edit CL 3911422 from //Fortnite/Release-3.1/... to //UE4/Release-4.19/...)
#jira UE-54835
Change 3911370 by Dragan.Jerosimovic
changed browOuterLeft -> browOuterUpLeft, browOuterRight->browOuterUpRight
updated KiteBoyHead_JointsAndBlends.fbx
#jira none
Change 3910545 by Dan.Oconnor
PR #4512: Fix FNetNameMapping::GetUniqueName regression (Contributed by dfb)
#jira UE-55513
Change 3910449 by Michael.Trepka
Fix for crash on exit on Mac when closing the root editor window with Cmd+W
#jira UE-54973
Change 3909601 by Patrick.Boutot
Expose to Blueprint GetProjectDirectory functions.
#jira UE-55548, UEENT-999
Change 3909543 by Patrick.Boutot
Rename ECollisionResponse to CollisionResponseType in script to prevent collision with FCollisionResponse.
Python's help function now output the Python type instead of the cpp type.
Do not export hidden enum entry from Python.
#jira UE-55545, UEENT-961
Change 3909289 by Zak.Parrish
Adding shirt/chest to faceAR sample #jira none
Change 3908808 by Dragan.Jerosimovic
added combination shapes network
#jira none
Change 3908788 by Mitchell.Wilson
Updaing Match3Camera to resolve clipping issue on iPhone X
#jira UE-54723
Change 3908374 by Jack.Porter
Fix viewport offset problem for preview PIE window
#jira UE-52583
Change 3907108 by Shane.Caudle
#JIRA
Added DefaultDeviceProfiles.ini to set the [IOS DeviceProfile]
+CVars=r.ShadowQuality=4
Change 3907105 by Lauren.Ridge
Fix for thumbnails not resetting when layers/blends reset and for them being incorrectly scaled when null
#jira UETOOL-1303
Change 3907011 by Chris.Phillips
UE-52667 Unable to package an Android DLC Using "Android APK" and "Android DLC" profiles in Project Launcher.
#jira UE-52667
Change 3906792 by Lauren.Ridge
When constructing the material editor viewport, use the direct method to set the environment visibility.
#jira UE-55267
Change 3906734 by Chris.Babcock
Fix issue with vertex fetch disable
#jira UE-55475
Change 3906721 by Rolando.Caloca
UE4.19 - Check if the results file from SCW is corrupt
#jira UE-53124
Change 3906648 by Chris.Phillips
UE-53184 Assertion when running mobile PIE in iPhone 5S mode.
Updated the iPhone5s.json Metal settings.
#jira UE-53184
Change 3906474 by David.Hibbitts
Added default constructor for FLiveLinkWorldTime.
#jira UEENT-879 #rb none
Change 3906467 by Lauren.Ridge
Swapping sibling materials now correctly swaps the overridden parameters out
#jira nojira demobug
Change 3906156 by Michael.Trepka
Reverting CL 3728924 as it's causing problems with modal windows. A different, much more involved fix for UE-51711 will be needed.
#jira UE-52492
Change 3906144 by Michael.Dupuis
#jira UE-54547: Added guard to be sure that material is valid
Change 3905882 by Matt.Kuhlenschmidt
Enable substance buttons again
#jira UE-55081
Change 3905513 by Sorin.Gradinaru
UE-55394 iOS crash exiting app during startup movie: SPRINGBOARD, process-exit watchdog transgression
#jira UE-55394
#jira UE-52328
#iOS
#4.19
This is a particular case of UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
Found several issues on iOS if the game is forced closed when the startup movie is playing and "Wait for movies to complete" is enabled in Project Settings
- the game thread is waiting for the movie to complete on game shutdown - more that 5 sec
- crash on FDefaultGameMoviePlayer::Shutdown if the above is fixed
- HTTP module no longer has time to wait for the requests to complete.
Change 3905506 by Michael.Dupuis
Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable
Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0
#jira 0
Change 3905498 by Lina.Halper
Fix multiple pose asset issue - fallout from CL 3903509
- as for fullbody, went back to old mathod because in the fullbody, we want shortest path most of times and you don't blend more than 1 weight, so this is likely fine
- as for additive, change to use blend from identity.
#jira: UE-55439, UE-55448, UE-55250
Change 3905325 by Sorin.Gradinaru
UE-54764 UnrealMatch3 spams Kindle device log with "Unsupported EPixelFormat"
#jira UE-54764
#4.19
Also reproduced on Samsung Galaxy S5 Neo (SM-G903F, GPU Mali-T720).
Check GMaxRHIFeatureLevel > ERHIFeatureLevel::ES3_1 (not mobile) before creating RSV params used with SupportsManualVertexFetch: (Positions, Tangents, TextureCoordinates, Color buffers)
Change 3905307 by Jack.Porter
Removed iPhone5 PIE json file as it's not a supported device
#jira UE-53184
Change 3905132 by Shane.Caudle
#JIRA
Pushed it a little more out of the yellow.
Change 3905117 by Shane.Caudle
#JIRA
Got SSS working and made some tweaks.
Change 3904936 by Max.Chen
Fix editor only
#jira UE-55459
Change 3904269 by Chris.Babcock
Disable manual vertex fetch on mobile
#jira UE-55389
#ue4
#android
#ios
Change 3904186 by Lina.Halper
Pose asset crash when skeleton not existing during serialization
#jira: UE-55422
Change 3904063 by Max.Chen
Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register.
Copy from Dev-Sequencer
#jira UE-55314
Change 3904060 by Lauren.Ridge
Fix for saving a child out of a layer stack capturing the wrong parameters
#jira UETOOL-1280
Change 3904050 by Luke.Thatcher
[CONSOLE] [^] Added RHI Command List Enqueue Lambda method (merging as edit CL 3879722 from //Fortnite/Main to //UE4/Release-4.19)
- Can be used to enqueue arbitrary tasks on the RHI thread from the render thread (similar to how EURC works for GT -> RT tasks), without having to write lots of bolierplate FRHICommand functor classes.
- The first overload of EnqueueLambda method will check Bypass() to determine if it should run the lambda immediately or defer to the RHI thread.
- This can be overriden via the 2nd overload if you need to check additional things such as IsRunningRHIInSeparateThread.
- The function returns true if the lambda was enqueued and deferred to the RHI thread, otherwise false. This can be used to optionally add RHIThreadFences for unlock commands etc.
#jira UE-55437
Change 3904004 by Lauren.Ridge
Fix for material layer output nodes being able to be placed in other graphs
#jira UE-54867
Change 3903931 by Aaron.McLeran
#jira UE-55435 Crash in google resonance when toggling visualization
fix for issue described here -- https://github.com/resonance-audio/resonance-audio-unreal-sdk/issues/1
Change 3903722 by David.Hill
The ProxyLOD plugin is experimental: don't load it by default.
#jira: ue-55402
Change 3903583 by Ben.Marsh
Include .version and .modules files in manifest. Should fix missing version information in precompiled binaries.
#jira
Change 3903529 by Richard.Hinckley
#jira UEDOC-7180
4.19 API Documentation manual update.
Change 3903509 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: Fix issue with pose blending with shortest path - causing additive to blend linearly between pose if the rotation is same direction.
#jira: UE-55250
Change 3903501 by Michael.Dupuis
#jira UE-55122: Fixed bad neighbors updating for mobile
Change 3903387 by Will.Fissler
; r.XGEShaderCompile is now enabled by default in source. Uncomment to disable XGE shader compilation.
;r.XGEShaderCompile = 0
#jira UE-55286
Change 3903251 by Sungjin.Hong
#JIRA UE-55349
#loc added KO locallization for VR, Handheld AR templates
Change 3903219 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54738
removed redundant iOS warning when IOnlineIdentity::Login is called by FOnlineExternalUIIOS::ShowLoginUI
#jira UE-54738
#iOS
Change 3903130 by Cody.Albert
Updated build configuration to resolve iOS build error on UnrealMatch3
#jira UE-53742
Change 3903056 by Shane.Caudle
#JIRA
Latest tweaks to lighitng and rendering for boy.
Change 3903032 by Cody.Albert
Added missing include that was preventing iOS builds from succeeding on TopDown template
#jira UE-54341
Change 3902669 by Lauren.Ridge
Fix for thumbnail crash after saving material instances that contain layers
#jira crash
Change 3902581 by Mitchell.Wilson
Updating Samples and Template Min iOS Version to iOS 9.
#jira UE-55148
Change 3902448 by Lauren.Ridge
Fix for crash due to unparented material instance
#jira crash
Change 3902206 by Chris.Phillips
UE-52612 External textures only work in pixel shaders.
Sampling external textures are now only limited to pixel shaders when the shader model is < SM4.
#jira UE-52612
Change 3902120 by Peter.Sauerbrei
bvringing over the fix for backgrounding crash on iPhone X from Fortnite
#jira UE-54883
Change 3902097 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: CL 3901939
#jira: UE-55401
Change 3902082 by Mike.Beach
Fixing an issue with the fix from CL 3889470 - fully matching the old UEnum name check (checking both the value name and the typed name, for example: "Left" and "EControllerHand::Left").
#jira UE-55153
Change 3901963 by Peter.Sauerbrei
bring over the fix from Fortnite for Remote Shader Compilation not respecting settings in the passed in shader
#jira UE-52797
Change 3901959 by Ethan.Geller
[Release-4.19] #jira UE-55225: Stop RtAudio stream on StopRecording in sequence recorder. #rb Aaron.McLaren
Change 3901482 by Lauren.Ridge
Fix for crash on opening materials due to array out of bounds
#jira crash
Change 3901181 by Michael.Dupuis
#jira UE-55313: To enable tessellation we MUST have 2 materials in the list
Change 3900935 by Nick.Bullard
Updating Default_Startup.mp4 with more recent UE branding.
This still requires another update for final version with audio
#jira UE-55382
Change 3900660 by Aaron.McLeran
#jira UE-55381 crash in sound submix
Bringing fix from FN to 4.19 (CL 3890630)
Change 3900643 by Aaron.McLeran
#jira UE-55380 fixing synth envelopes
Change 3900617 by Aaron.McLeran
#jira UE-55151 Fixing crash w/ mic component
Change 3900544 by tim.gautier
QAGame: Submitting asset for AsNumber fix submitted with UE-10310
#jira UE-29618
Change 3900430 by Ryan.Brucks
KismetRenderingLibrary: Applied a fix from FN to make it possible to create textures from BP created RTs. Without the fix the assets would be created but invisible to the user due to missing RF_Public and RF_Standalone.
#JIRA none
Change 3900399 by Lauren.Ridge
Fixing global parameters not working
#jira UE-55242
Change 3900297 by Ben.Marsh
Speculative fix for hot reload causing version files to be updated with a locally made installed build.
#jira UE-55072
Change 3900116 by Chris.Bunner
Removing outdated tests and test assets.
#jira UETOOL-1298
Change 3900042 by Chris.Bunner
Deleted SharedInputCollection and associated material graph nodes.
#jira UETOOL-1298
Change 3899887 by Lauren.Ridge
Fix for background checkbox stomping profile info for material editor. Note that you may have to delete Saved/Config/Windows/Editor.ini to get this to work.
#jira UE-55267
Change 3899824 by Chris.Phillips
UE-52813 Editor's mobile preview doesn't serialize the landscape's cooked heightmap data.
Now only regenerating landscape pixel data when needed when using Mobile Preview Rendering Levels.
#jira UE-52813
Change 3899775 by Lauren.Ridge
Fix for crash on opening material layer material
#jira crash
Change 3899673 by Jamie.Dale
Fixed Functions sometimes being exposed to Python as if they were Structs
#jira none
Change 3899487 by Chris.Bunner
Duplicate [CL 3852020, 3896571] - Disabling non-performant code only required by experimental material layers feature. Users can opt-in per-project through experimental renderer settings, replacing the previous editor experimental flag.
#jira UETOOL-1298
Change 3899156 by Phillip.Kavan
Include address of object reference in persistent frame debug info.
#jira UE-51952
Change 3899146 by Rolando.Caloca
UE4.19 - hlslcc - Workaround for intrinsics with two output arguments
#jira UE-52477
Change 3899060 by Bart.Hawthorne
Add a null check for the game mode pointer in UWorld::SpawnPlayActor
#jira UE-54461
Change 3899015 by Krzysztof.Narkowicz
Fixed initialization of instancing random vertex stream.
#jira UE-53605
Change 3899008 by Michael.Dupuis
Fix issue with landscape mobile vertex factory accessing unbound LodTessellationParams when r.ShaderDevelopmentMode=1
#jira 0
Change 3898994 by Phillip.Kavan
More verbose debug logging if an invalid object reference is detected in the BP ubergraph frame during garbage collection.
#jira UE-51952
Change 3898962 by Guillaume.Abadie
Fixes wrong parameters about whether GPU timing may have CPU generated bubbles to the dynamic resolution heuristic.
#jira UE-55352
Change 3898826 by Sorin.Gradinaru
UE-54784 StrategyGame crashes entering game on KindleFire 7 - Assertion failed: ViewSize.GetMin
#4.19
#Android
#jira UE-54784
Wrong code to make an integer even + operator precedence
Change 3898822 by Sorin.Gradinaru
UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
FORT-70783 FHttpManager::Flush is immediately canceling all HTTP requests
#jira UE-52328
#jira FORT-70783
#iOS
#PC
#4.19
UE-52328 reopened because of FORT-70783
iOS only: Delay Request->CancelRequest() on Http module shutdown - wait for 2 sec on FHttpManager::Flush to allow pending requests to be sent to the server.
Change 3898705 by Max.Chen
Sequencer: Skip if the binding id's sequence can't be found.
#jira UE-55337
Change 3898108 by Michael.Dupuis
#jira UE-54547: Remove the FORCEINLINE so we get a proper callstack of what's happening
Change 3898076 by Max.Chen
Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated.
#jira UE-55328
Change 3897897 by Matt.Kuhlenschmidt
Disable substance buttons for now
#jira UE-55081
Change 3897742 by Aaron.McLeran
Merging fix for UE-55223 to 4.19
#jira UE-55223
Change 3897538 by Michael.Dupuis
#jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material
Change 3897406 by Phillip.Kavan
Back out local debug logs.
#jira UE-51952
Change 3897400 by Phillip.Kavan
Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage.
- Mirrored from //UE4/Dev-Core (3871863).
#jira UE-51952
Change 3897391 by Max.Chen
Sequencer: Don't update current time to be within the view range when stepping into a sequence.
#jira UE-55322
Change 3897274 by Krzysztof.Narkowicz
Fixed issues with loading shaders from DDC - hardcoded CustomAttributes initialization instead of filling them inside UObject costructors in order to properly initialize CustomAttributes before DDC key was created. Added an assert that CustomAttributes are initialized before the AttributeDDCString, so we won't run into this issue again in the future.
#jira UE-54683
Change 3897148 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-55147
#4.19
#iOS
#jira UE-55147
Change 3897138 by Max.Chen
Sequencer: Fix crash when an actor factory is not found.
Copy from Dev-Sequencer
#jira UE-55309
Change 3897045 by Jack.Porter
Fix for crash in ALandscapeProxy::UpdateGrass
#jira UE-54362
Change 3897036 by Jack.Porter
Fix InstancedStaticMesh crash with invalid lightmap coordinates
#jira UE-54423
Change 3896801 by Dmitriy.Dyomin
Fixed: Planar reflections does not handle origin rebasing
#jira UE-52351
Change 3896743 by Dmitriy.Dyomin
Discard CPU copy of vertex/index buffers in OpenGL RHI
#jira UE-52133
Change 3896619 by Guillaume.Abadie
Cherry-pick 3896598: Fixes after TAAU post process material that had wrong default buffer UV.
#jira UE-55317
Change 3895718 by Max.Chen
Sequencer: Null checks to prevent crash when saving the default state of a spawnable
#jira UE-55304
Change 3895426 by Rolando.Caloca
UE4.19 - Add an increased timeout for SCW to avoid OOM situations
#jira UE-55306
Change 3895245 by tim.gautier
QAGame: Submitting updated test assets. Broke ML_Base out into individual components
#jira UE-29618
Change 3895194 by Marc.Audy
Prevent crash due to a null entry in the linked to graph of the destination pin
#jira UE-54606
Change 3894913 by Arne.Schober
REL - Fix crash in Speedtree wind where Renderdata is unavailable
#jira UE-54544
Change 3894625 by Arne.Schober
REL - Fix assert not in RenderingThread from Triangle Renderer.
#jira UE-55247
Change 3894464 by Martin.Wilson
Extra debugging info for UE-54705 plus remove check so it is no longer fatal
#jira UE-54705
Change 3894450 by Martin.Wilson
Remove pinnable ness of retarget asset. Paves the way for exposing retarget asset properties on the node
#jira none
Change 3893948 by Jostin.Bilyeu
Adding default player start location to help with launch on testing within level TM-Materials_POM
#jira UE-55063
Change 3893495 by Robert.Manuszewski
Fixing a crash when running DDC commandlet
#jira UE-54646
Change 3893451 by Jurre.deBaare
Altered fix for actor merging with negative scaling to get correct normals
#jira UE-54996
#misc updated automated test to include this test-case
Change 3892913 by Ethan.Geller
[Release-4.19] #jira UE-55151 Fix for Mic Component crashing on re-init. #rb aaron.mcleran
Change 3892871 by Ryan.Vance
Multi-view requires the day dream compositor.
#jira UE-55253
Change 3892785 by Arciel.Rekman
Linux: fix inability to create a C++ project (UE-55222).
- NullSourceCodeAccessor will unconditionally allow C++ project creation in source builds.
- Installed build will check for more compilers in commonly found locations.
#jira UE-55222
Change 3892687 by Jostin.Bilyeu
Checking in replacement Built Data for map TM-Materials_POM
#jira UE-55063
Change 3892674 by Jostin.Bilyeu
Adding an invisible plane to TM-Materials_POM to help testing on mobile devices
#jira UE-55063
Change 3892622 by Aaron.McLeran
#jira none Fixing scope lock in phonon probe volume
Change 3892511 by Matt.Kuhlenschmidt
Fix zero engine version warning
#jira UE-55081
Change 3892211 by Yuriy.ODonnell
Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64.
NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime.
The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules.
The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput.
Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668).
#jira UE-53065
Change 3891732 by Brian.Zaugg
Re-adding iPhoneX launch images with correct case.
#JIRA UE-53541
Change 3891727 by Arne.Schober
REL - Do not recreate one Frame Resource for dynamic draws
#jira UE-55063
Change 3891716 by Ben.Marsh
Fix buffer overrun when generating callstack.
#jira
Change 3891697 by Brian.Zaugg
Deleting iPhoneX launch images that have incorrect case.
#jira UE-53541
Change 3891678 by Brian.Zaugg
IPP binaries for iPhoneX support.
#jira UE-53541
Change 3891525 by Lauren.Ridge
Thumbnails now update correctly w/parameters
#jira UETOOL-1333
Change 3891520 by Lauren.Ridge
Fixing SA error in material editor
#jira UE-55206
Change 3891495 by Jurre.deBaare
Normal are different after Merge Actor on scaled objects
#fix Make sure we do not apply scale when transform Normals/Tangents
#jira UE-54996
Change 3891352 by Guillaume.Abadie
Fixes ensure when visualizing HDR with TAAU.
#jira UE-55019
Change 3891323 by Matt.Kuhlenschmidt
Added substance buttons to content browser and material editor
#jira UE-55081
Change 3891033 by David.Hibbitts
#JIRA UE-55135
Moved Message Bus Source heartbeats to their own thread using a new FHeartbeatManager singleton. This prevents sources from incorrectly being removed during Slate UI operations.
Change 3890642 by Arne.Schober
REL - Better fix for Paper2d which honors batching
#jira UE-55063
Change 3890593 by Arne.Schober
REL - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead.
#jira UE-55063
Change 3890502 by Mike.Erwin
Fix reported VRAM size on Metal
We were getting correct value in MB from system but overflowing uint32 arithmetic when converting to bytes.
This led 4GB and 8GB configs to report 0 total VRAM, 0 dedicated tex mem, and GTexturePoolSize = 0.
Noticed the problem on my 6GB FirePro, which reported 2GB and set GTexturePoolSize to 70% of that.
Also fixed log of texture pool size to show MB. Other platforms' RHIs already report this in MB.
#jira none
Change 3890404 by Jostin.Bilyeu
Updating Demo Display names to remove redundant spaces
#jira UE-29618
Change 3890401 by Dan.Oconnor
Fix for property table performance regression
#jira UE-54984
Change 3890194 by Dan.Oconnor
Make sure a CDO's subobjects are preloaded when running in -game
#jira UE-54242
Change 3890182 by Krzysztof.Narkowicz
Moving CL3867594 from Dev-Rendering to fix missing shaders in cooked Binary Editor DCC. USE_EDITOR_ONLY_DEFAULT_MATERIAL_FALLBACK generated default material shaders had no cooking code path.
#jira UE-54683
Change 3890140 by Rob.Cannaday
Merging cacert.pem from //UE4/Dev-Online to //UE4/Release-4.19
Includes latest cacert.pem from https://curl.haxx.se/docs/caextract.html as of January 17, 2018
#jira none
Change 3889850 by Shaun.Kime
Now initializing Niagara scripts and emitters even if the config file isn't ready yet.
#jira UE-54168
#jira UE-54169
#tests can create a blank emitter and all script sub-types
Change 3889833 by Michael.Trepka
Disabled Clang's unused-lambda-capture warning added in Xcode 9.3
#jira none
Change 3889696 by Patrick.Boutot
Allow rename from AssetTool when there is no source control enabled.
Fix crash when you rename an asset without an enabled source control.
#jira UEENT-803
Change 3889470 by Mike.Beach
Switching the source-name to legacy hand enum lookup functions to use a static table instead of finding a UEnum object and iterating over reflection data (to prevent a GC lockup with the UObject query).
#jira UE-55153
Change 3889319 by Matt.Kuhlenschmidt
Disable hardware survey on build machines. They run windows server and lack the necessary win32 api functionality to execute it properly
#jira UE-55166
Change 3889087 by Jostin.Bilyeu
Minor adjustments TM-SceneTexture for better testing clarity. Minor adjustments to TM-MipLevels for test map clean up
#jira UE-29618
Change 3889073 by Sorin.Gradinaru
UE-55117 Android virtual keyboard can have text input hidden by software buttons
#jira UE-55117
#Android
#4.19
Adjusted x-coord and width for the native EditText
Change 3888841 by Jurre.deBaare
Make FSkeletalMeshRenderData::GetMaxBonesPerSection an ENGINE_API exported function
#jira none
Change 3888837 by Guillaume.Abadie
Fixes a crash in dynamic resolution when doing UE4Editor -server
#jira UE-55158
Change 3888831 by Dragan.Jerosimovic
added fbx files
#jira none
Change 3888340 by Ethan.Geller
[Release-4.19] #jira UE-54787 edit settings for Strategy Game to prevent stuttering in AudioMixer on low performance Android Devices #rb Aaron.McLeran #fyi Aaron.McLeran #lockdown Cristina.Riveron
Change 3888133 by Michael.Karambelas
QAGame: Adding a BP Actor to test the Mic component feature that AaronM implemented with UE-51471.
#jira UE-29618
Change 3887957 by Krzysztof.Narkowicz
"Fixed" Vulkan instancing in by doing Metal style set instance offset to 0 hack
#jira UE-54367
Change 3887912 by Jostin.Bilyeu
Adding content to TM-SceneTexture to verify Screen Positioning as well as Scene Color and Depth. Adding a new map (TM-MIPLevels) for testing custom mip levels
#jira UE-29618
Change 3887571 by Zak.Parrish
Adding FaceAR content and cleanup #jira none
Change 3887458 by Dan.Oconnor
Fix 'Step Out' functionality for macro and collapsed graphs
#jira UE-55000, UE-55002, UE-55022
Change 3886883 by zachary.wilson
Add testing content to QAGame: Texture and material for testing mip levels. Postprocess material for testing scene buffer sampling.
#jira UE-29618
Change 3886848 by Max.Preussner
Engine: Workaround for uninitialized external textures causing white flashes in media playback
Copied from Fortnite-Main and Dev-Sequencer
#jira UE-53357
Change 3886720 by Matt.Kuhlenschmidt
Guard against mac menus updating during slow tasks.
#jira UE-55068
Change 3886657 by Guillaume.Abadie
Cherry-pick 3886626: Cherry-pick 3886560: Fixes strong aliasing on TAAU's fast shader permutation.
This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation.
#jira FORT-69961
Change 3886653 by Matt.Kuhlenschmidt
Perforce Plugin: Removed all calls to methods that would update the P4PASSWD environment variable. Perforce stores this as plain text so it is not safe and we do not want the editor to be responsible for this being set. All users should be using ticket based p4 servers for the best security but if they are unable to then they can call p4 passwd on their own to set a slightly better hashed password directly. They may also log in each time to the editor which prevents any password from being stored
#jira UE-55111
Change 3886621 by Benn.Gallagher
Fixed crash closing clothing tab if workflow centric application puts the tab spawners in a bad state due to incorrect handling of tab context menus.
#JIRA UE-55067
Change 3886552 by Thomas.Sarkanen
Fixed crash loading an anim instance with a re-instanced class
Unable to repro, but in editor we dont need the optimization that this provides. Now we always re-initialize functions and properties in case the class has changed out from under us.
#jira UE-55065 - [CrashReport] UE4Editor_Engine!FExposedValueHandler::Initialize() [animnodebase.cpp:521]
Change 3886442 by Cosmin.Sulea
UE-53033 - Editor Rapidly Spawns Multiple Empty Windows Throughout Remote Shader Compiling
#jira UE-53033
Change 3886441 by Cosmin.Sulea
UE-54598 - Using an Invalid iOS Mobile Provision does not give descriptive error in Project Launcher, IPhonePackager
#jira UE-54598
Change 3886427 by Sorin.Gradinaru
UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled - from //Dev-Mobile@CL3843552
#4.19
#Android
#jira UE-54139
S8 on 7.0 is not hiding suggestions and disabling predictive input. There are cases with this that can cause a crash.
Fix: On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags)
Change 3886210 by Ethan.Geller
[Release-4.19] #jira UE-53867 Ensure we don't read off into garbage memory for uncompressed PCM.
Change 3886005 by Zak.Parrish
Checking in faceAR work on behalf of 3Lateral #jira none
Change 3885925 by Mike.Erwin
Material preview label off-center on HiDPI screen
#jira UE-52533
Change 3885778 by Dan.Oconnor
Fix stepping over collapsed graph and macro nodes
#jira UE-54950, UE-54955
Change 3885713 by Mike.Erwin
glTF: fix material using wrong textures
Imported material could plug the wrong textures into its inputs. The previous code tracked a material's textures based on image source index, corrected code uses texture (source + sampler) index. This is more general allowing an image to be referenced by multiple textures.
Bug reported yesterday via email, demonstrated using the Khronos TextureSettingsTest sample model.
#jira none
Change 3885603 by Ben.Marsh
Fixes for compiler errors in nightly builds of VS2017 in /permissive- mode.
#jira
Change 3885566 by Phillip.Kavan
Fix a scoping issue related to inaccessible property reference caching in nativized Blueprint code.
Change summary:
- Modified FDefaultSubobjectData::EmitPropertyInitialization() to utilize the FScopeBlock utility to manage the inaccessible property cache during code generation for instanced subobject initialization.
#jira UE-55061
Change 3885481 by Mark.Satterthwaite
Attempt to workaround an Intel shader compiler bug without reopening a related AMD bug. This may cost performance unless function constants are available and the runtime compiler actually bothers to perform optimisation (AMD's did not in 10.12.6 and earlier).
#jira UE-54333
Change 3885461 by Lauren.Ridge
Fix for slot not being initialized to null
#jira UE-55069
Change 3885455 by zak.parrish
Adding initial files for FaceAR scene lookdev #jira none
Change 3885446 by Zak.Parrish
Adding test assets for Gremlin look dev. May get removed later prior to release. #jira none
Change 3885424 by Krzysztof.Narkowicz
Fixed skeletal mesh LODs inside editor. If skeletal mesh wasn't recently visible, code was incorrectly changing LOD settings without updating LOD data on render thread.
#jira UE-53861
Change 3885406 by Zak.Parrish
Rollback //UE4/Release-4.19/Samples/FaceARSample/Content/UI/FaceARDebugUI.uasset to revision 1 #jira UE-54639
Change 3885340 by Arne.Schober
REL - Bitarray FindFromLast was masking incorrectly for the corner case where there is no slack
#jira none
Change 3885143 by Marc.Audy
Merge memory corruption fix in CL# 3884991 from Fortnite-Staging to Release-4.19
#jira UE-54977
#jira UE-54976
#jira UE-54898
Change 3885093 by Mark.Satterthwaite
Apple don't like testing for the validation layer in iOS App Store builds - it is unnecessary so we can disable this for shipping builds.
#JIRA N/A
Change 3884622 by Jurre.deBaare
Moving over missing file from changelist for UE-54508
#jira UE-54508
Change 3883391 by Nick.Atamas
Fix for UE-54622 : PIE in VR available when ARKit/ARCore plugins enabled.
Only create ARKit/ARCore tracking systems on iOS/Android.
#jira UE-54622
Change 3883257 by Phillip.Kavan
Fix a Blueprint compile error for the GetClassDefaults node Map value outputs introduced by stronger type checking in 4.19 between Map pin types.
#jira UE-55026
Change 3883024 by Lauren.Ridge
Fixing static analysis warning
#jira SA
Change 3882510 by Michael.Dupuis
#jira none : Fixed screen size calculation to take aspect ratio into account correctly
Change 3882502 by Lauren.Ridge
Fix for material layer parameters not rebuilding and adding save child button
#jira UETOOL-1275
Change 3882458 by Krzysztof.Narkowicz
Copying cached shadow map assert fix from Fortnite-Main (CL3802813)
#jira UE-54747
Change 3882366 by Michael.Karambelas
QAGame: made changes to QABP_Debugging, QABP_FunctionLib, and QA_TestHelper for Blueprint debugger tests.
#jira UE-29618
Change 3881971 by andrew.porter
QAGame: Removing actor from Shot_003
#jira UE-29618
Change 3881795 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3881550 by David.Hibbitts
#JIRA UEENT-879
Subject frames now store world time explictly as a double with optional scene timecode as MetaData. This allows for use cases such as posing a single frame in Maya where the world time would be changing but the scene timecode associated with the animation remains fixed.
THIS IS A BREAKING CHANGE: Sources from before this change will no longer compile.
Change 3881339 by Jurre.deBaare
Moving over:
"Editor crashed when attempting to bake out all the material channels
#jira UE-54508
#misc small UDN Merge actor / bake material fixes
Change 3879557 by Dan.Oconnor
Fix stepover behavior when no debug target is selected
#jira UE-54978
Change 3879485 by Mike.Beach
Limiting the number of stereo layers on Oculus android to 4 (otherwise, their lib crashes).
#jira UE-54999
Change 3879438 by David.Hibbitts
#JIRA UEENT-880 Added support for Subject level MetaData to LiveLink #rb martin.wilson #fyi james.golding, simon.tourangeau
Change 3879343 by Lina.Halper
Last min change that skiped compiling
#jira: none
Change 3879337 by Lina.Halper
Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes.
#jira: UE-54806
Change 3878968 by Phillip.Kavan
Fix deprecation warnings in compiled stub class wrapper codegen for Blueprint class dependencies excluded from nativization.
Change summary:
- Modified FBlueprintCompilerCppBackendBase::GenerateWrapperForClass() to const-correct the assignment of cached weak pointers to referenced properties.
#jira UE-54981
Change 3878962 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54831 (No error occurs accepting if Android SDK license file cannot be written, but user cannot accept license)
#4.19
#jira UE-54831
#android
- shows an error message box informing that the license file could not be written.
Change 3878821 by Andrew.Rodham
Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation
- The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field.
- The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field.
- The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges.
#jira UE-54922
Change 3878171 by Chris.Phillips
Android: Fixed crash after splash screen when using Vulkan.
#jira UE-54299
Change 3877950 by Ethan.Geller
Fix copyright information from previous CL #jira none #rb none #lockdown Cristina.Riveron
Change 3877859 by Nick.Shin
rebuilt lighting for TM-ShaderModels and resaved the level
#jira UE-53374 Client displays "lighting needs to be rebuilt (1 unbuilt object(s))" when launching TM-Shadermodels onto HTML5
Change 3877854 by tim.gautier
Adding additional (temp) ML Test asset
#jira UE-29318
Change 3877609 by Ethan.Geller
[4.19] Change FWhiteNoise generate function to use SRand, due to weird distribution in FRandRange #jira UE-54965 #rb aaron.mcleran #lockdown cristina.riveron
Change 3877474 by Lauren.Ridge
Adding WITH_EDITOR wrappers to editor-only section of code
#jira fixingcompiles
Change 3877271 by Arne.Schober
REL - Integrate 3872827 - The VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should not be neccessary
#jira none
Change 3877260 by Lina.Halper
If revision is too far away, ignore the request and send current buffer
- this is exactly how it used to do and it is still required, but this means motion vector will be ignored when this happens
#jira: UE-54398
Change 3876950 by Lauren.Ridge
Renaming layers in a material instance - from 4.19 preview feedback
#jira UETOOL-1296
Change 3876932 by Arciel.Rekman
Linux: updated the link to the cross-toolchain (UE-54597).
#jira UE-54597
Change 3876918 by Phillip.Kavan
Fix a regression that could cause packaging to fail and/or data loss with Blueprint nativization enabled.
Change summary:
- Removed logic that attempted to avoid redundant assignments of instanced default subobject references. This was not compatible with editinline characteristics that can allow certain object reference values to be overridden by the Blueprint class.
- Explicitly defer to ExportTextItem() when generating C++ code for UObjectProperty/UInterfaceProperty reference values in which the underlying object reference is NULL.
#jira UE-54870
Change 3876759 by tim.gautier
Updated Material Layer test assets to include Opacity and Emissive.
#jira UE-29318
Change 3876575 by Michael.Karambelas
Updating the QABP_Debugging asset in QAGame with a couple of interfaces and additional logic for testing purposes.
#jira UE-29618
Change 3876406 by Robert.Manuszewski
Fixed a crash when reporting linker errors
#jira UE-51037
Change 3875891 by Nick.Atamas
Fixed scenario where geometries were being updated once per pin, instead of just being updated once.
Also fixes a scenario where there are no pins and geometries fail to update.
#jira UE-54914
Change 3875880 by Aaron.McLeran
#jira UE-54916
Fixing up submix effect templates
Change 3875673 by Brandon.Schaefer
Fix Apex dependencies
Depend on static Apex libraries in Apex.Build.cs versus Physx.Build.cs
#jira UE-54861
Change 3875498 by Lauren.Ridge
PR #4477: 4.19 Fixed a crash caused by the layered material property widget of the material instance editor. (Contributed by mlaveaux)
#jira UE-54862
Change 3875322 by tim.gautier
Recreating Material Layer test assets (asset version has changed)
#jira UE-29318
Change 3875157 by Aaron.McLeran
#jira UE-54901 Synth components do not allow sends to buses
Change 3875103 by Brandon.Schaefer
Need to use our bundled libc++.so not libstdc++.so when building Apex/PhysX/NvCloth libraries
#jira UE-54815
Change 3875037 by Aaron.McLeran
#jira UE-54896 Fixing up audio capture component to parameterize the delay
Parameterize the jitter latency delay.
Change 3875026 by Aaron.McLeran
#jira UE-54895 Filter frequency values don't update live with EQ effects and 0-frequency cutoff causes pops
Change 3874927 by Ryan.Vance
#jira UE-54894
Ensure we don't delete aliased texture resources, they are managed externally.
Change 3874925 by Martin.Wilson
Remove XR post fix from live link code written during motion controller integration
#jira none
Change 3874354 by Ben.Marsh
Use the compiler matching the user's preferred IDE if they don't have a specific compiler selected in the project settings.
#jira UE-54272
Change 3877545 by Ben.Marsh
Replace FPlatformMisc::DebugBreak() with the UE_DEBUG_BREAK() macro. VS2017 is able to show force-inlined calls on the callstack, which makes debugging asserts and ensures annoying.
Use similar logic for expanding ensure() macros in place.
#jira UE-54961
[CL 3963579 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3805828 by Gil.Gribb
UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works.
Change 3806784 by Ben.Marsh
UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT.
Change 3807549 by Graeme.Thornton
Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it.
Change 3807727 by Graeme.Thornton
Unhide the text asset format experimental editor option
Change 3807746 by Josh.Engebretson
Remove WER from iOS platform
Change 3807928 by Robert.Manuszewski
When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet
Change 3808221 by Steve.Robb
GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule()
^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway.
Change 3809233 by Graeme.Thornton
TBA: Misc changes to text asset commandlet
- Rename mode to "loadsave"
- Add -outputFormat option which can be assigned "text" or "binary"
- When saving binary, use a differentiated filename so that source assets aren't overwritten
Change 3809518 by Ben.Marsh
Remove the outdated UnrealSync automation script.
Change 3809643 by Steve.Robb
GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value
#jira UE-53037
Change 3809862 by Steve.Robb
GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately
#jira UE-42593
Change 3811190 by Graeme.Thornton
Add support for writing specific log channels to their own files
Change 3811197 by Graeme.Thornton
Minor updates to output formatting and timing for the text asset commandlet
Change 3811257 by Robert.Manuszewski
Cluster creation will now be time-sliced
Change 3811565 by Steve.Robb
Define out non-monolithic module functions.
Change 3812561 by Steve.Robb
GitHub #3886 : Enable Brace-Initialization for Declaring Variables
Incorrect semi-colon search removed after discussion with author.
Test added.
#jira UE-48242
Change 3812864 by Steve.Robb
Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins.
See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html
#jira UE-53089
Change 3820358 by Ben.Marsh
PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist)
Change 3822594 by Ben.Marsh
UAT: Improvements to log file handling.
- Always create log files in the final location, rather than writing to a temp directory and copying in later.
- Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX.
- Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is.
- Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location.
Change 3823695 by Ben.Marsh
UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk).
Now always queries changes up to the last change for which zipped binaries are available.
Change 3823845 by Ben.Marsh
UBT: Exclude C# projects for unsupported platforms when generating project files.
Change 3824180 by Ben.Marsh
UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes).
#jira
Change 3825777 by Steve.Robb
Fix to return value of StringToBytes.
Change 3825810 by Ben.Marsh
UBT: Reduce length of include paths for MSVC toolchain.
Change 3825822 by Robert.Manuszewski
Optimized PIE lazy pointer fixup. Should be up to 8x faster now.
Change 3826734 by Ben.Marsh
Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency.
Change 3827730 by Steve.Robb
Try to avoid decltype(auto) if it's not supported.
See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html
Change 3827745 by Steve.Robb
Initializer list support for TMap.
Change 3827770 by Steve.Robb
GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType()
#jira UE-53813
Change 3829189 by Ben.Marsh
UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off.
Change 3830444 by Steve.Robb
BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library.
This should be revisited when Core has its own JSON library.
Change 3830718 by Ben.Marsh
Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups.
The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip.
For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it.
When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk.
#jira UE-53845
Change 3831064 by Ben.Marsh
Fix log file contention when spawning UBT recursively.
Change 3832654 by Ben.Marsh
UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it.
Change 3832680 by Ben.Marsh
UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade.
Change 3832695 by Ben.Marsh
UGS: Invert the options in the 'Show Changes' submenu for simplicity.
Change 3833528 by Ben.Marsh
UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write].
Change 3833543 by Ben.Marsh
UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules.
Change 3834354 by Robert.Manuszewski
Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks.
#jira UE-52035
Change 3834400 by Robert.Manuszewski
Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup.
#jira UE-52035
Change 3834947 by Steve.Robb
USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal.
Change 3835004 by Ben.Marsh
Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL.
Change 3835340 by Ben.Marsh
Fix errors making installed build from directories with spaces in the name.
Change 3835972 by Ben.Marsh
UBT: Improved diagnostic message for targets which don't need a version file.
Change 3836019 by Ben.Marsh
UBT: Fix warnings caused by defining linkage macros for third party libraries.
Change 3836269 by Ben.Marsh
Fix message box larger than the screen height being created when a large number of modules are incompatible on startup.
Change 3836543 by Ben.Marsh
Enable SoundMod plugin on Linux, since it's already supported through the editor.
Change 3836546 by Ben.Marsh
PR #4412: fix type mismatch (Contributed by nakapon)
Change 3836805 by Ben.Marsh
Fix commandlet to compile marketplace plugins.
Change 3836829 by Ben.Marsh
UBT: Fix ability to precompile plugins from installed engine builds.
Change 3837036 by Ben.Marsh
UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds.
Change 3837037 by Ben.Marsh
UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro).
Change 3837040 by Ben.Marsh
UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed.
Change 3837247 by Ben.Marsh
UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files).
Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor.
Change 3837262 by Ben.Marsh
UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module.
Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets.
Change 3837343 by Ben.Marsh
UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead.
Change 3837356 by Ben.Marsh
Fix invalid character encodings.
Change 3837727 by Graeme.Thornton
UnrealPak: KeyGenerator: Only generate prime table when required, not all the time
Change 3837823 by Ben.Marsh
UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window.
Change 3837831 by Graeme.Thornton
UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives
Change 3837857 by Robert.Manuszewski
PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch)
Change 3837943 by Robert.Manuszewski
PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch)
Change 3838451 by Ben.Marsh
UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread.
#jira UE-53996
Change 3839519 by Ben.Marsh
UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data.
Change 3843790 by Graeme.Thornton
UnrealPak: Log the size of all encrypted data
Change 3844258 by Ben.Marsh
Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace.
Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure.
#jira UE-54157
Change 3845796 by Ben.Marsh
Workaround for slow performance of String.EndsWith() on Mono.
Change 3845823 by Ben.Marsh
Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun.
#jira UE-54123
Change 3845901 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
(Edigrating 3819174 to Dev-Core)
Change 3846439 by Ben.Marsh
Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates.
Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main.
Change 3816608 by Ben.Marsh
UBT: Use DirectoryReference objects for all include paths.
Change 3816954 by Ben.Marsh
UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere.
Change 3816986 by Ben.Marsh
UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly.
Change 3816991 by Ben.Marsh
UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules.
Change 3823090 by Ben.Marsh
UAT: Improve logging for child UAT instances.
- Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder.
- Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway.
- Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read.
- Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output.
Change 3826082 by Ben.Marsh
UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target.
Change 3827025 by Ben.Marsh
UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling.
Change 3829927 by James.Hopkin
Made HTTP interface const correct
Change 3833533 by Ben.Marsh
Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules.
Change 3835826 by Ben.Marsh
UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced.
Change 3835969 by Ben.Marsh
UBT: Fix cases where text is being written directly to the console rather than via logging functions.
Change 3837777 by Steve.Robb
Format string type checking added to FOutputDevice::Logf.
Fixes for those.
Change 3838569 by Steve.Robb
Algo moved up a folder.
[CL 3847482 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3627858 by Sorin.Gradinaru
#jira UE-48948 Crash when pressing backspace on empty line
Fixed:
UE-48948 Backspace on empty line crashes app (virtual keyboard)
UE-49112 Virtual keyboard text field isn't visible after rotating from landscape to portrait
UE-49117 Chinese and Korean virtual keyboards don't allow native characters
UE-49120 Virtual keyboard number pad "kicks" user back to regular keyboard
UE-49121 Gboard and Swift swipe entry are not supported by Virtual keyboard
UE-49124 Cursor in virtual keyboard and UMG don't match
UE-49128 Virtual Keyboard text field doesn't appear if there is too much text
UE-49141 Virtual keyboard is unresponsive with repeated tapping in control (some devices)
UE-49139 Tapping in the same text box doesn't make the virtual keyboard disappear
Change 3630732 by Sorin.Gradinaru
#jira UE-43488 GitHub 3440 : Fixes exposure with planar reflections.
#3440
Cancelled the applied exposure scale for non-hdr mobile
Change 3631436 by Nick.Shin
HTML5
recommended fix for "RuntimeError: integer result unrepresentable" from the emscripten makers
#jira UE-49059 HTML5 - Unable to launch project onto HTML 5 from editor
Change 3632689 by Sorin.Gradinaru
#jira UE - 49301 Text in UMG controls flickers during update from Virtual Keyboard
Full refresh of the Slate control for Android experimental VK - the control has focus, but the cursor was removed
Change 3632769 by Adrian.Chelu
#jira UEMOB-403 Improvements to "Device Mobile Preview" feature
Change 3633305 by Allan.Bentham
Print out the callstack when a fatal error occurs.
Change 3633510 by Chris.Babcock
Remove unneeded logging
#jira none
Change 3634827 by Adrian.Chelu
#fixed build editor buildsystem linux
Change 3640610 by Adrian.Chelu
#fixed Cook Win64 warnings
#fixed UE4Editor Static Analysis Win64 warnings
Change 3663057 by Sorin.Gradinaru
UE-49301 Text in UMG controls flickers during update from Virtual Keyboard
#jira UE-49301
#ue4
#android
On some Android devices TextWatcher.onTextChanged gets called multiple times when typing/deleting the content of a EditText (internally, the first call resets the entire content, the second fills it with the new value)
The workaround is to delays sending "empty string" to the Slate, waiting for 100ms to see if there is a second call (the "real" string to update)
The CL contains a fix for a 5/5 crash : select some/all the text from the native edittext, press delete.
Change 3663630 by Jack.Porter
Fix shader compile error on Galaxy S6
Change 3663972 by Allan.Bentham
add ES3.1 framebuffer fetch.
#jira UE-46251
Change 3671843 by Nick.Shin
HTML5 - silence CIS warnings (changed to INFO message type)
#jira UE-50415 ( Pri:1 - 4.18 ) //UE4/Release-4.18: Step "Package ShooterClient HTML5" has completed with 1 Warning: "File packager is creating an asset bundle of 815 MB. This is very large"
Change 3677675 by Sorin.Gradinaru
Android Experimental Virtual Keyboard 4.18 issues
#jira UE-49124 Cursor in virtual keyboard and UMG don't match
#jira UE-49139 Tapping in the same text box doesn't make the virtual keyboard disappear
#jira UE-49141 Virtual keyboard is unresponsive with repeated tapping in control (some devices)
#ue4
#android
UE-49124 Cursor in virtual keyboard and UMG don't match - change in SlateTextLayout.cpp - OnPaint() don't display the cursor
Changed the show/hide vk routines (Game activity.java) to solve low-repro, Android O issues related to multiple click events.
Should also be tested with multiple text boxes (fast click in/out different types of TextBox controls)
Change 3681555 by Adrian.Chelu
UEMOB-403 Improvements to "Device Mobile Preview" feature
Change 3692020 by Sorin.Gradinaru
#jira UE-50645 Carriage returns can be pasted into single line UMG fields on Android
#ue4
#4.19
#android
Change 3692741 by Sorin.Gradinaru
Andoid 3D WebBrowser
#jira UE-32740 Web Browser on a Widget Component appears to be 2D when launching on to Android
#ue4
#android
Change 3695475 by Chris.Babcock
Per project Android NDK/SDK API settings
#jira UEMOB-394
#ue4
#android
Change 3701364 by Dmitriy.Dyomin
Fixed: WEX - Android - Log spammed with "LogRHI: Error: Unsupported EPixelFormat 28"
#jira UE-50714
Change 3701664 by Jack.Porter
Fix typo
Change 3702355 by Cosmin.Sulea
UEMOB-393 - Support "ETC 1.5" packaging
#jira UEMOB-393
Change 3704950 by Chris.Babcock
Add verification of support for cooked texture format(s) on device at runtime (optional with Validate texture formats checkbox in Android project settings) and skipped for cook on the fly
#jira UE-50837
#ue4
#android
Change 3709817 by Nick.Shin
HTML5 - silence CIS warnings (changed to INFO message type)
finally have a repo case to test this proper fix
#jira UE-50415 ( Pri:1 - 4.18 ) "Package ShooterClient HTML5" has completed with 1 Warning: "File packager is creating an asset bundle of 815 MB. This is very large"
Change 3717598 by Chris.Babcock
Fix Android icon paths
#jira UE-51585
#ue4
#android
Change 3718456 by Adrian.Chelu
#fixed spelling in category localized name
Change 3719643 by Nick.Shin
nuke PLATFORM_HTML5_WIN32
more "old" code to remove
#jira UEMOB-433 Remove Win32 SDL "HTML5 Simulator" code
Change 3720342 by Nick.Shin
HTML5 redirect logs to console window
#jira UE-50747 HTML5 log is not easily accessible to users
Change 3720652 by Sorin.Gradinaru
UE-50382 Xcode Address Sanitizer feature does not work on iOS
#jira 50382
#iOS
#ue4
Address sanitizer dylib loader depends on the default SDKROOT parameter (<scheme> => Build Settings => Base SDK => <Build Configuration>)
For macosx or missing (also translated as macosx), the path is incorrect for iphone/appletv.
Change 3720654 by Sorin.Gradinaru
UE-48499 Android Voice Module has a few issues
#jira 48499
#Android
#ue4
1.Circular Buffer: Does the engine already have an implementation? Do we want this into core libraries?
R: There is an generic template class TCircularBuffer, but it lacks functionality like write/read checks, reading/writing data chunks.
Plus the code from VoiceModuleAndroid is optimized for circular byte array. I suggest to keep it.
2. Possible memory leaks: void free_circular_buffer (circular_buffer *p) is implemented, but not used. Presumably a memory leak on the variable inrb. Does CreateAudioRecorder need to be paired with any kind of destroy on shutdown?
R: Fixed. Using an array ActiveVoiceCaptures to store VoiceCapture references (same as on Windows)
3. Init() There are 4 calls to setup/init things that store the result in "result" but only the last call is checked against success. Should more checks against the values be made at each stage with informative log messaging in the event of failure?
R: Fixed.
4. GetVoiceData()
// Workaround for dealing with noise after stand-by
while(bytes<InVoiceBufferSize)
{
OutVoiceBuffer[bytes++]=0;
}
Isn't this just a memzero?
R: Fixed.
5. Missing features. Need to implement GetBufferSize and DumpState
R: Added GetBufferSize. Can be used like in TestVoice.cpp
DumpState is never used (same on Mac, iOS), plus the OpenSL objects do not expose internal properties.
Change 3722554 by Cosmin.Sulea
UE-44224 - iOS - Remote Build - rsync error: files not transferred
#jira UE-44224
Change 3723265 by Allan.Bentham
Assign a texture format priority for ETC1a.
prevents launch on from using ETC1a all the time..
Change 3729764 by Dmitriy.Dyomin
Removed deprecated LightmapUVBias, ShadowmapUVBias from instanced static mesh component per-instance data (80 -> 64 bytes)
Change 3729899 by Dmitriy.Dyomin
Fixed tiled landcape re-import
Change 3730895 by Bogdan.Vasilache
UEMOB-442 --> [ Support texture streaming on Android ES 3.1 ]
#jira UEMOB-442
Change 3733463 by Chris.Babcock
Return error for external texture if not used in pixel shader
#jira UE-51763
#ue4
Change 3736226 by Chris.Babcock
Change ExposureScale to PreExposure
#jira UE-52007
#jira UE-51691
#ue4
#android
Change 3740509 by Allan.Bentham
Add LQ (direct lighting from stationary spot/point lights) to volumetric lightmaps.
#jira UE-50551
Change 3740586 by Cosmin.Sulea
UE-51747 - GitHub 4174 : [BUG-FIX] Invalid ASTC texture versioning is corrected.
#jira UE-51747
Change 3741110 by Chris.Babcock
Fix functional code in checks removed for shipping
#ue4
Change 3741117 by Chris.Babcock
Fix checkin error for check -> ensure fix
#ue4
Change 3741156 by Chris.Babcock
Swap order of SDK and NDK overrides in menu to match Android SDK settings
#jira UE-52019
#ue4
#android
Change 3741271 by Chris.Babcock
Use final NDK and SDK levels only in UEBuildSettings.txt and rename the overrides to be clearer
#jira UE-52058
#ue4
#android
Change 3741464 by Chris.Babcock
Add NDK and SDK platform validation (installed) for Android
#jira UE-52069
#ue4
#android
Change 3744602 by Josh.Adams
From Meerkat: - Added optional 0 or 1 param to showlayer that will set the visibility instead of toggling it for entire layer
Change 3744603 by Josh.Adams
From Meerkat: - Fixed a comment about debug view modes on consoles
Change 3744607 by Josh.Adams
From Meerkat: - Added HWInstances to the PrimitiveStats view in Statistics window
Change 3754890 by Chris.Babcock
Updated IntelISPCTexComp DLLs to fix crashes with some processors on Windows
#jira UE-52281
#ue4
Change 3755147 by Jack.Porter
Fixed Google Cardboard rendering upside down on iPhone 6S+
#jira UE-38555
Change 3755458 by Cosmin.Sulea
UE-47801 - RSync Error when Generating SSH Key for Remote Mac Building when Mac username contains a space
#jira UE-47801
Change 3755492 by Jack.Porter
Fix merge error
Change 3759140 by Bogdan.Vasilache
UE-52396 --> Assertion in FOpenGLDynamicRHI::CreateOpenGLTexture when launching on Mali Galaxy S III
#jira UE-52396
Change 3760536 by Sorin.Gradinaru
UE-51262 values for pinch input produce very different results for same area on android device
#jira 51262
#iOS
#Android
#ue4
1. When the pinch goes beyond the viewport boundaries (when zooming out), the touch that goes off-screen is "released" and the zooming effect is over.
Solved by remembering last pinch event values
2. "Hack" the initial distance for the pinch/ rotate, by touching the screen and moving the finger to another position before using the second finger.
Solved by using the correct values when the pinch event starts
Change 3761279 by Chris.Babcock
Flag vertex and fragment shaders belonging to materials with external textures
#jira UE-52398
#ue4
#android
Change 3761494 by Chris.Babcock
Fix access to FrameUpdateInfo in MediaPlayer14.java and CameraPlayer14.java with Proguard
#jira UE-52471
#ue4
#android
Change 3763146 by Jack.Porter
Default assets for web browser widget
#jira UE-51374
Change 3764242 by Chris.Babcock
Disable Niagara vertex factories for mobile and Switch
#jira UE-52425
#ue4
#mobile
#switch
Change 3766027 by Allan.Bentham
Fix crash when no LQ volumetric lightmap data exists
#jira UE-52508
Change 3766075 by Josh.Adams
- Updating UDKRemote. Still needs art updated, and some some unneeded assets removed
Change 3766141 by Allan.Bentham
Show unbuilt lightmap warning when LQ data is missing from volumetric lightmap in mobile shading mode.
Change 3766163 by Josh.Adams
- Updated icons and added a generator script when we get a new one
Change 3766560 by Allan.Bentham
Workaround for broken offsets with automation screenshots.
#jira UE-52491
Change 3767193 by Peter.Sauerbrei
remove Oculus shader from being cached
force a metal shader re-compile
#jira UE-52587
Change 3767604 by Peter.Sauerbrei
fix the Oculusshader the right way
#jira UE-52587
Change 3768543 by Sorin.Gradinaru
Android WebBrowser 3D - webbrowser plugin contins the assets, 2D behaviour restored
#Android
#UE4
#4.19
#jira UE-51374 Web Browser widget is not working on Android
#jira UE-52399 Android web browser does not accept input
Change 3663915 by Jack.Porter
Prevent FTcpListener from busy polling while waiting for connections
#jira UE-50125
Change 3709224 by Allan.Bentham
Add android target device to gauntlet.
Automation screenshot uses high res screenshot api for mobile.
#jira UEMOB-360
Change 3741453 by Chris.Babcock
Match the 4.18.1 fixes for shipping checks removing code (from CL3741091)
#ue4
Change 3769301 by Peter.Sauerbrei
fix for missing ue4_stdmetal.lib, courtesty of MarkS
#jira UE-52587
Change 3770597 by Sorin.Gradinaru
Android WebBrowser - remove the WebBrowser plugin reference from the Engine
Load the default material directly from the resources.
#Android
#UE4
#jira UE-51374 Web Browser widget is not working on Android
#jira UE-52399 Android web browser does not accept input
[CL 3771573 by Chris Babcock in Main branch]
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3372740 by Chris.Bunner
[Experimental] Partial compute post process pipeline (r.PostProcess.PreferCompute).
StencilSceneTexture added to deferred list.
A few known issues to be fixed in a follow-up CL.
Change 3374187 by Chris.Bunner
Volume texture support for CombineLUTs/Tonemap compute pass.
Refactored common param code to shared sub-class in CombineLUTs and Tonemap PS/CS.
Skip compute post process out-of-bounds writes.
Unsigned type conversion fixes.
Trimmed compute post process shader inputs.
Change 3441680 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3454636 by Uriel.Doyon
Fixed point light having an extra scale of 16 in mobile
#jira UE-45272
Change 3454844 by Uriel.Doyon
Fixed extra X16 on some point lights
#jira UE-45250
Change 3454934 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3461206 by Guillaume.Abadie
Adds possibility to scene captures and player controller to render no primitives at all.
Change 3461207 by Guillaume.Abadie
Exposes showflag details to USceneCaptureComponent. This gives the possibility to configure scene capture's showflags in blueprint encapsulated compositing pipeline.
#jira UE-6810
Change 3461233 by Chris.Bunner
Added Log10 material expression.
Added tooltip for Log2 and Log10.
Change 3461434 by Michael.Trepka
Copy of CL 3456118
In Metal RHI report texture streaming as immediately successful as on D3D to avoid a race-condition leading to deadlock between the Main, Game, Render & RHI threads.
#jira UE-44961
Change 3461770 by Benjamin.Hyder
Submitting TM-RayTracedDistanceField map
Change 3461929 by Marc.Olano
Add Sobol blueprint and material node test maps to RenderTest project
Change 3462249 by Uriel.Doyon
Translucency after DoF is now disabled when showflag postprocess is disabled.
Change 3462371 by Brian.Karis
VT addressing is now 64bit to support huge sparse virtualized volumes
16bit page tables working.
Change 3462936 by Marc.Olano
Extend Sobol testing map with comparision between Random Sobol and Next Sobol functions
Change 3464394 by Uriel.Doyon
Improved synchronization for texture streaming commands.
This fixes an issue when accessing FStreamingTexture for pending textures.
Change 3464743 by Guillaume.Abadie
Adds .usf file extension on all shader's source file names and adds checks to verify them at engine load time.
Change 3464818 by Guillaume.Abadie
Fixes compilation error in FindShaderRelativePath
Change 3465184 by Daniel.Wright
r.Shadow.PreShadowResolutionFactor 1.0 on Epic shadow settings
Change 3465283 by Marc.Olano
Update Sobol Gray code tables to match random order tables
Change 3465976 by Arne.Schober
DR - [UE-44393] - The Canvas is using the Globalshaders for clearing but compilation is done asynconously at load time. Unfortunately there could be Code that uses a canvas to draw and cause this issue in between. There might be some plugins that do this. For now we need to wait and block for the shaqders to be compiled until we can allo the use of the canvas.
#RB none
Change 3467513 by Guillaume.Abadie
Fixes an issue where primitives would no longer draw in gameplay.
#jira UE-45550
Change 3471116 by Richard.Wallis
Mac OpenGL Is No Longer Supported - Remove All Code & Shader Platforms. Merge of CL 3327784 dev-editor stream from Michael Trepka with some extra changes.
- Also removed Metal shader platforms from PlatformSupportsDebugViewShaders() otherwise we get a compiler error. HLSL register binds not implemented in metal backend.
#jira UE-39108
Change 3471117 by Richard.Wallis
Drop down menus clip on 27" Screen iMacs. Disable viewport HDR rendering on macOS 10.12.x when in editor.
#jira UE-43026
Change 3471130 by Richard.Wallis
Mac GPU hang causes editor output log to be written to the wrong file. Try to emulate windows behaviour when opening a file for reading or writing. Tested against behaviour of windows log file with multiple instances running.
- Only defined in for Mac and non shipping.
#jira UE-44934
Change 3471224 by Guillaume.Abadie
Lets the ProjectFileGenerator to look at Shaders/ directories in plugin and game projects.
Change 3471646 by Daniel.Wright
Fixed ensure opening UT system settings
Change 3471862 by Arne.Schober
DR - revert accidently checked in changes.
#RB Chris.Bunner
Change 3472249 by Guillaume.Abadie
Implements virtual shader source directory mapping.
- /Engine/... maps to Engine/Shaders/...
- /Plugin/FooBar/... maps to FooBar plugin's Shaders/ directory
- /Project/... maps to project's Shaders/ directory
Change 3472443 by Daniel.Wright
Moved the Rendering category for lights to be just below the Light category, so the bVisible property is easily accessible
Change 3474537 by Uriel.Doyon
Fixed lighting needs rebuild happening after blueprint rescript and a non symetrical Quaterion != ToQuaternion(ToRotator(Quaternion)
Change 3475192 by Guillaume.Abadie
Implements LensDistortion engine plugin.
This CL import a polished version of Raven's lens distortion and undistortion from OpenCV parameters:
- It is implemented as the first engine plugin with its own shaders and render thread commands;
- Has feature tests in EngineTest with gold images directly extracted from OpenCV itself (GenerateLensDistortionUndistortReferences.py)
Change 3475209 by Guillaume.Abadie
Back out changelist 3475192
Change 3475252 by Guillaume.Abadie
Reland: Implements LensDistortion engine plugin.
This CL import a polished version of Raven's lens distortion and undistortion from OpenCV parameters:
- It is implemented as the first engine plugin with its own shaders and render thread commands;
- Has feature tests in EngineTest with gold images directly extracted from OpenCV itself (GenerateLensDistortionUndistortReferences.py)
Change 3475389 by Guillaume.Abadie
Adds LensDistortion plugin's feature tests.
Change 3475538 by Guillaume.Abadie
Adds the /Engine/* prefix on all of the renderer's USF file references.
Change 3475568 by Guillaume.Abadie
Adds a check for virtual shader source file path format in FShaderType::FShaderType()
Change 3475871 by Guillaume.Abadie
Fixes a bug in shader compile worker, were an error in a relative #include USF file would trigger an check failure in CheckVirtualShaderFilePath
Change 3475997 by Yujiang.Wang
Workaround for a compiler optimization bug introduced in VS2015 Update 3.
* The bug causes TSHVector<2>::CalcDiffuseTransfer to go to infinity at certain spot, making movable objects with ILCQ_Volume indirect lighting cache interpolation get very dark.
* Debug builds don't exhibit this bug.
* Semantics are exactly the same as the original code.
Change 3476203 by David.Hill
Compute SSAO: problem wiht AmbientOcclusionLevels and with various viewporttest sizes. Only seen when Levels >=2
#jira UE-45741
Change 3476536 by Benjamin.Hyder
adding player start to Ray Traced Distance Field Shadows Map
Change 3478298 by Benjamin.Hyder
disabling mesh distance fields in Tm-Raytraced_DistanceField_Shadows map
Change 3478948 by Rolando.Caloca
DR - Nicer check
Change 3478949 by Rolando.Caloca
DR - Default GPU morphs to enabled
Change 3478950 by Rolando.Caloca
DR - By default -vulkan will launch SM5
Change 3478984 by Rolando.Caloca
DR - Pass down -vulkan
Change 3479655 by Richard.Wallis
Video track does not switch in AVF Media Player. Need to disable unused video tracks to allow AVPlayerItemVideoOutput to decode the required track.
- Minimal change to allow video track changes/selection.
- Audio samples are extracted using AVAssetReaderTrackOutput but video uses AVPlayerItemVideoOutput. Video could also use AVAssetReaderTrackOutput to access the video data unless there is an iOS reason not to...
- Flush the audio sink sample buffers so we get instant audio track changes
#jira UE-39750, UE-39749
Change 3479834 by Rolando.Caloca
DR - Fix issue with bad vertex colors (per licensee)
Change 3480376 by Guillaume.Abadie
Disables ComputeLightGrid() if no volumetric fog and no lighting.
#jira UE-45377
Change 3480596 by Yujiang.Wang
Fix for dynamic shadows and raytraced distance field shadows of directional lights not appearing in planar reflection
* Bug caused by incorrect shadow culling volumes for cascaded shadow map and backface culling mode for WholeSceneShadowProjection
* Fixed by taking View.bReverseCulling into account
#jira UE-34452
Change 3480600 by Yujiang.Wang
Fix for UE-42376
* The bug is caused by post-processing ambient cubemaps not being supported in forward shading currently.
* This fix replaces all the occurences of them in CalcSceneView with a skylight using the cubemap
* If a CalcSceneView is used solely for setting the PP ambient cubemap, it is removed.
#jira UE-42376
Change 3480784 by Rolando.Caloca
DR - hlslcc - Initial support for [RW]StructuredBuffer
Change 3481690 by Uriel.Doyon
Attempt to fix static analysis warning
Change 3482012 by Simon.Tovey
Fixed issue when building distribution lookup tables where the final sample fell short of the max input time.
As sampling is done only over this range, under constant interpolation the final value was never actually sampled and so cut from the final optimized LUT.
#tests constant interpolation now works.
#jira UE-45614
Change 3482965 by Yujiang.Wang
Some quality of life changes for UE-42757
* The UV overlay in static mesh editor now has a darker background
* Selected edges are getting highlighted and bolder
* When some edges are selected others turn grey
#jira UE-42757
Change 3483014 by David.Hill
Change labels on bloom boost from x,y,z to min, max, mult.
#jira UE-43904
a PropertyRedirect in BaseEngine.ini allows this to work with older version.
Change 3484573 by Yujiang.Wang
Fix for shadow color not updated after light build when a texture is changed and reimported
* Bug caused by counter-intuitive design of UMaterial::GetReferencedFunctionIds and UMaterial::GetReferencedParameterCollectionIds, both of which will reset the OutIds parameter
* Renamed to AppendReferencedFunctionIdsTo and AppendReferencedParameterCollectionIdsTo, the resets are removed
#jira UE-45647
Change 3484969 by Yujiang.Wang
Fix for UE-39929 inconsistent type between C++ and shader code
* MeshDistanceFieldCasterIndices is declared as Buffer<uint> in CapsuleShadowShaders.usf, while created as PF_R32_SINT in CapsuleShadowRendering.cpp
* Changed PF_R32_SINT to PF_R32_UINT in CapsuleShadowRendering.cpp
#jira UE-39929
Change 3485012 by Yujiang.Wang
Fix for UE-39929 #2: Changed int32 to uint32 to match PF_R32_UINT
#jira UE-39929
Change 3485146 by Guillaume.Abadie
Destroyes scene capture's view states on the UnRegister, to avoid large memory usage cause by the ViewState's render targets when moving blueprints arround.
#jira UE-43455
Change 3486602 by Joe.Conley
Adding "texcoord" keyword to UMaterialExpressionTextureCoordinate so you can search for the name that is displayed on the node in the graph.
Change 3487471 by Yujiang.Wang
Github #3659: Improved performance of DumpUnbuiltLightInteractions
* Replaced TArrays with TSets
#jira UE-45783
Change 3487641 by Guillaume.Abadie
Fixes some shader file name casing issues in LPV.
Change 3488014 by Uriel.Doyon
New AllowAsyncLoading flag for UTexture::CachePlatformData().
It allows to load the source texture data in the async task if the source bulk data was not yet loaded.
Data loaded that way is not sharable between tasks and will be discarded.
This is required because updating the source data is not thread safe.
#jira UERNDR-190
#jira UE-33401
Change 3488249 by Uriel.Doyon
Fixed long stall in UpdateResourceStreaming() caused by Actor.GetComponents() not resetting the number of actors anymore.
Fixed inconsistent results in ALODActor::HasValidSubActors() caused by the same change.
#jira UE-46004
Change 3490228 by Mark.Satterthwaite
Fix the Nvidia driver bug with the old reversebits fallback function - you need to use the native reverse_bits intrinsic or use some uint(ushort()) casts to get the compiler to do the right thing, which means injecting the reverse_bits function in MetalBackend not the HLSL (as it has no such type).
#jira UE-46067
Change 3490538 by Arne.Schober
Back out changelist 3488249
#RB none
Change 3490551 by Arne.Schober
Back out changelist 3488249
#RB none
Change 3491828 by Guillaume.Abadie
Fixes another USf file reference casing issue in C++.
Change 3491924 by Yujiang.Wang
Fix for UE-43302 Crash when entering the DebugCreatePlayer console command with planar reflections in the level
* Crash caused by check(Views.Num() <= 2); in SceneCaptureRendering.cpp
* We still want to support at most 2 views for performance, but now instead of crash the planar reflections in additional views will simply turn black
#jira UE-43302
Change 3492359 by Guillaume.Abadie
Fixes non editor launches, failing in FGenericPlatformProcess::AddShaderSourceDirectoryMapping().
Change 3492367 by Marc.Olano
Change Sobol texture size to 32x16, tweak distribution
Change 3492599 by Marcus.Wassmer
PR #3669: -Fix logmessages ParticleModules_Location.cpp (Contributed by UpwindSpring01)
Change 3493473 by Uriel.Doyon
Back out changelist 3490538
Change 3493590 by Uriel.Doyon
Back out changelist 3490551
Fixed missing #pragma once
Change 3493911 by Marcus.Wassmer
Fix potential GPU crash/hang caused by out of bound subresource updates.
Added checks at cross-platform level to catch any instance earlier.
Change 3494139 by Uriel.Doyon
Fixed shadow variable issue on UE4Editor Linux.
Change 3494364 by Richard.Wallis
Mac OpenGL Is No Longer Supported - Remove All Code & Shader Platforms - Part 2: Remove some more areas and fixes for previous attempt. Also removed OpenGL based GPU performance checks in EditorEngine.cpp - assuming that any GPU that can run Metal is currently OK for UE4.
OpenGL left in the following areas:
- OpenGLShaderCompiler
- StandaloneRenderer
The following files need to be reviewed in conjunction with CL 3471116 as there were some logic errors made:
- OpenGLTexture.cpp
#jira UE-39108
Change 3494413 by Guillaume.Abadie
Updates r.InvalidateCachedShader and bump ShaderVersion.ush.
Change 3494422 by Guillaume.Abadie
Adds LensDistortion plugin's Private shader directory.
Change 3494717 by Guillaume.Abadie
Strengthens shader compiler with checks on generated file names and shader type file names.
Change 3494763 by Guillaume.Abadie
Removes a nolonger standing TODO in GlobalBeginCompileShader() that was automatically adding /Engine/ prefix to all relative virtual shader source file path.
Change 3494985 by Rolando.Caloca
DR - Integrate Vulkan Rewrite
Change 3495031 by Rolando.Caloca
DR - Delete file as it moved
Change 3495032 by Rolando.Caloca
DR - Show Vulkan SM5 instead of SM4 on windows packaging
- Also added support for Vulkan SM5_UB
Change 3495202 by Uriel.Doyon
Fixed static analysis warning with pointer dereferencing.
Change 3495342 by Rolando.Caloca
DR - clang compile fix
Change 3495354 by Rolando.Caloca
DR - clang compile fixes
Change 3495420 by Marc.Olano
Use Sobol sampling for PCSS
Change 3495799 by Rolando.Caloca
DR - Delete old dev assets
Change 3496202 by Mark.Satterthwaite
Switch to using actual Vector*Matrix intrinsic for Metal to avoid a problem whereby the Metal compiler reorders operations in such a way that it loses precision and ends up being different between pre-pass and base-pass.
#jira UE-46070
Change 3496253 by Uriel.Doyon
Fixed static analysis warning for IncludeTool
Change 3496631 by Guillaume.Abadie
Makes AScreenshotFunctionalTest::ScreenshotOptions blueprint readable.
Change 3496851 by Guillaume.Abadie
Fixes back slash issues in Platform.usf.
Change 3496852 by Guillaume.Abadie
Fixes other back slashes includes in PS4 specific usf files.
Change 3496941 by Guillaume.Abadie
Adds a check() for no backslash in virtual shader file paths.
Change 3497661 by Guillaume.Abadie
Lets FLensDistortionCameraModel::GetUndistortOverscanFactor() early return 1.0 if the camera model is does an identity transform.
Change 3497969 by Richard.Wallis
Fix for start Up Movies Are not Playing for iOS Devices. Handle case when movie is loading aysnc in background - need to wait for state changes otherwise it skips intermediate movies.
- Tested on iOS and Mac.
#jira UE-39585
Change 3498035 by Guillaume.Abadie
Polishes //Engine/Plugins/Compositing/LensDistortion/Shaders/Private/UVGeneration.usf from debuging artifacts.
Change 3498101 by Rolando.Caloca
DR - Compile fix
Change 3498254 by Guillaume.Abadie
Exposes comparing FLensDistortionCameraModel to blueprint with == and != operator nodes for cross frame uv displacement map caching.
Change 3498264 by Guillaume.Abadie
Integrate 3267269: Implements SceneCaptureComponent2D::bCameraCutThisFrame
Change 3498371 by Yujiang.Wang
Fix for UE-46149 Planar Reflections display screenspace info when viewports are >2
* Prevent planar reflections being rendered when ViewIndex >= GMaxPlanarReflectionViews
* Now planar reflections in >2 viewports will fallback to other reflection methods (SSR, reflection captures)
#jira UE-46149
Change 3498409 by Rolando.Caloca
DR - Swap resolves
Change 3498410 by Guillaume.Abadie
Adds support for opacity output alpha for post process material when doing a draw material to render target.
Change 3498705 by Rolando.Caloca
DR - Add UID for debugging mem allocations
Change 3498759 by Marcus.Wassmer
No post processing in vertexcolor view mode
#jira UE-44704
Change 3498891 by Rolando.Caloca
DR - Minor Vulkan per frame allocator refactor in prep for changes
Change 3499206 by Rolando.Caloca
DR - Fix temp frame allocator OOM on Vulkan
#jira UE-45913
Change 3499319 by Rolando.Caloca
DR - Vulkan support for StorageBuffer
Change 3499339 by Rolando.Caloca
DR - Remove deprecated typedef
Change 3499400 by Rolando.Caloca
DR - Remove some RHICmdList deprecated functions
Change 3499422 by Rolando.Caloca
DR - Allow buffer transitions inside render passes
Change 3500370 by Rolando.Caloca
DR - Compile fix
Change 3500474 by Rolando.Caloca
DR - Fix static analysis
Change 3500517 by Guillaume.Abadie
Exposes r.PostProcessing.PropagateAlpha to the renderer settings.
Change 3500537 by Guillaume.Abadie
Fixes a bug where scene capture WorldToView matrix would get scale != 1 when scaling the scene capture actor in the world.
#jira UE-39389
Change 3501069 by Mark.Satterthwaite
Bring back temporary 4.16 fix for iOS 9 (CL #3425995) into Dev-Rendering for 4.17 as a real fix will need to wait for 4.18.
temporary fix for skewed textures on IOS 9
#jira UE-44468
Change 3501164 by Michael.Lentine
PR #3402: UE-43131: Format argument count not equal to actual arguments (Contributed by projectgheist)
Change 3501222 by Benjamin.Hyder
Checking in Tm_SobolNoise map
Change 3501612 by zachary.wilson
Adding testing content for RTDF shadows on planar reflections
Change 3501708 by Guillaume.Abadie
Break FPostProcessSettings into smallers structs.
Change 3501830 by Olaf.Piesche
#jira UE-39628; using fix proposed in UDN, will investigate further
Change 3501954 by Marcus.Wassmer
Duplicate 3480903
Light culling safety measures.
Change 3502032 by Mark.Satterthwaite
Fix generation of Metal precompiled headers for the bytecode compiler when using Xcode 9.
Change 3502118 by Uriel.Doyon
Fixed shader compilation issues.
Change 3502191 by Guillaume.Abadie
Implements Composure plugin to make compositing in UE4 easier.
Change 3502192 by Guillaume.Abadie
Implements Composure feature testing in EngineTests
Change 3502196 by Guillaume.Abadie
Creates a dependency of Composure plugin over LensDistortion plugin.
Change 3502213 by Arciel.Rekman
Fix for loading shaders on Linux (UE-46276).
Change 3502243 by Brian.Karis
Bent normal map support.
Multibounce AO.
Spherical Gaussian based specular occlusion.
Change 3502506 by Guillaume.Abadie
Fixes compilation failure in Composure with unity build.
Change 3502507 by Guillaume.Abadie
Fixes composure Set Pass with Render Target blueprint helper.
Change 3502510 by Guillaume.Abadie
Attempts to fix ComposureUtils.cpp compile errors.
Change 3502515 by Guillaume.Abadie
Some other composure failure fixes.
Change 3502545 by Guillaume.Abadie
Fixes some unity build related error in Composure.
Change 3502548 by Guillaume.Abadie
Fixes last missing includes in ComposurePostProcessPass.cpp
Change 3502672 by Guillaume.Abadie
Fixes linux warning in Composure.
Change 3502790 by Ryan.Brucks
float4 PseudoVolumeTexture: Fixed frame layout being a float instead of float2. Now works correctly with non-square frame layouts. Only called in custom nodes and calling with a float still functions properly so no old content will break.
Change 3502836 by Guillaume.Abadie
Propagates scene capture engine showflag changes from blueprint editor to the blueprint instances.
#jira UE-6810
Change 3503096 by Guillaume.Abadie
Resave a unversioned asset.
Change 3503228 by Yujiang.Wang
Fix for UE-45646 Dynamic Light placed inside of a Dynamic Static Mesh doesn't pass through the geometry
* Bug caused by bReflectiveShadowmap not being passed into SetViewFlagsForShadowPass
* Replaced the true with bReflectiveShadowmap
#jira UE-45646
Change 3503284 by Rolando.Caloca
DR - Fixed initial clear on rendertargets
- Added support for r.Vulkan.EnableValidation 1, 2, 3 & 4
- Dump the vulkan log into VS output log
- Added validation for layouts when using dump log
Change 3503545 by Arciel.Rekman
Fix black UI on Linux (UE-46333)
- Rebuilt hlslcc with clang 3.7.0. Whatever issues we're running in with newer clangs still seem to persist.
#jira UE-46333
Change 3503638 by Daniel.Wright
[Copy] Changed DynamicBentNormalAO back to fp16, as PF_FloatR11G11B10 was not enough precision and introduced banding
Change 3503787 by Marcus.Wassmer
Fix difference between gpu/cpu morph target application
Change 3503902 by Marcus.Wassmer
Roll back TAA refactor until we have time to look into the bad interaction with DOF.
Change 3503953 by Arne.Schober
DR - UE-46319 - borked Reflections: The resource transition needs to be in this weired place for PS4 and switch until we teach the interface to know about subresources.
#RB Marcus.Wassmer
Change 3504131 by Rolando.Caloca
DR - Maintain a cache of pipeline and descriptor set layouts
- Fix marker dump
Change 3504462 by Guillaume.Abadie
Fixes an assertion failure that was failing because compute light grid was not done, but the shader used where not necessarily using compute light grid results.
#jira UE-46277
Change 3504779 by Chris.Bunner
Potential static analysis fix.
#jira UE-46360
Change 3504950 by Marc.Olano
Allow Sobol material nodes & textures only if feature level is at least ES3.1
#jira UE-46334
#jira UE-46317
Change 3505035 by Daniel.Wright
Increased MaxSearchCount in GetShaderIncludes. The previous limit of 20 is now getting hit in BasePassPixelShader.usf, causing compiles to fail erroneously.
Change 3505386 by Daniel.Wright
GetShaderIncludes handles infinite recursion gracefully, needed by Metal causing BasePassTessellation.usf to include BasePassVertexShader.usf
Change 3505491 by Rolando.Caloca
DR - Fix crash on first frame of particles on modern APIs
Change 3505557 by Chris.Bunner
[Duplicate] Workaround for outdated shader map crash.
#jira UE-46061
Change 3506071 by Rolando.Caloca
DR - Vulkan fixes
- Fix copy out of bounds reading textures to CPU
- Defer event deletion
- Split validation for errors and warnings
- Skip validation error about attachment not used
Change 3506698 by Guillaume.Abadie
Fixes Composure alpha channel clobering and performance regression in bloom and tonemapper passes caused by scene capture API compatibility breakage brought by Fortnite merge.
Change 3506797 by Rolando.Caloca
DR - Fix static analysis
#jira UE-46428
Change 3506861 by Rolando.Caloca
DR - Fix crash due to layering violation
#jira UE-46424
#jira UE-46431
Change 3508098 by Rolando.Caloca
DR - Fix for Vulkan ES31 crash
- Fix for AMD ensure
Change 3508123 by Rolando.Caloca
DR - Disable occlusion queries on Vulkan to avoid flickering
- Fix for bad HZB & cube mips on Vulkan (now using RHIGenerateMips)
- Fix for decal blending
#jira UE-46376
Change 3509064 by Uriel.Doyon
Changing the logic arround generating an error when HasHadBulkDataCleared() so that it only triggers if the DDC are not found.
#jira UE-46427
Change 3509854 by Marc.Olano
Fix 2D Sobol gray code numbers.
Just changes some numbers in initialization tables, so no effect on existing tests or content.
Change 3509920 by Marcus.Wassmer
Fix LPV fastvram ensure
Change 3509937 by Rolando.Caloca
DR - Fix crash due to deleted viewport
#jira UE-46281
Change 3509988 by Marcus.Wassmer
Roll back part of Sobol fix to avoid full shader recompile for integration.
Change 3510255 by Rolando.Caloca
DR - Fix popup window ensure
#jira UE-46511
Change 3510646 by Marcus.Wassmer
fix ios compiles
Change 3511442 by Rolando.Caloca
DR - Change mesh simplification check to ensure/checkslow to unblock
#jira UE-46538
DONE!
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
CHANGES WITH MULTIPLE PLATFORMS!!! YOU MUST COPY THESE INTO THE OTHER ONES AS MAKES SENSE!!
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Change 3467095 by Guillaume.Abadie
Nukes all += TEXT(".usf")
#jira UE-45530
Change 3475084 by Guillaume.Abadie
Fixes compilation failure of the shader compiler on PS4 and XboxOne
Change 3477464 by Guillaume.Abadie
Fixes dumpshaderinfo that generate unecessary sub directory, breaking shell scripts.
Change 3494395 by Guillaume.Abadie
Moves all engine shader files into Public and Private directory, and introduce the .ush extensions for header file that do not contains entry points.
DONE!
[CL 3511602 by Marcus Wassmer in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3389969 on 2017/04/12 by Guillaume.Abadie
Implements FDebug::DumpStackTraceToLog() debugging utility.
Change 3391579 on 2017/04/12 by Joe.Barnes
Fix minor spacing issue.
Change 3402629 on 2017/04/20 by Ben.Marsh
Build: Remove job to populate the DDC. Trying out a new system for this.
Change 3417501 on 2017/05/01 by Joe.Barnes
IWYU - Missing #include files.
Change 3419927 on 2017/05/02 by Joe.Barnes
- Support custom LOD for shadow map generation only (r.ForceLODShadow)
- New #define to expose forceLOD and forceLODShadow also in Test/Ship builds (#define EXPOSE_FORCE_LOD 1 in RenderCore.cpp). Not exposed by default.
Change 3420964 on 2017/05/03 by Jonathan.Fitzpatrick
Fixed null dereference of LineBatcher when using DrawDebugSphere and DrawDebugAltCone
#jira UE-30213
Change 3423470 on 2017/05/04 by Luke.Thatcher
[CONSOLE] [STREAMS] [^] Merging //UE4/Dev-Main (CL 3391974) to Dev-Console (//UE4/Dev-Console)
- Compile errors in Switch, to be fixed after check-in.
Change 3430410 on 2017/05/09 by Ben.Woodhouse
Fix uninitialized local variable causing crashes in Test
#jira UE-44832
Change 3430506 on 2017/05/09 by Josh.Adams
- Fixed up the editor platforms' method of loading TargetSettings objects so that we don't need any manual parsing of .ini files to fill out the class defaults
Change 3434035 on 2017/05/10 by Ben.Woodhouse
Integrate updated FortGPUTestbed from Fortnite/Main
Change 3437046 on 2017/05/12 by Joe.Barnes
Fix for clang producing a warning when not all specializations of a templated function are marked FORCEINLINE.
Also, switch a specialization of BlendTransform() from a function with a check to just a declaration so compiler will catch error instead of a runtime catch.
Change 3437259 on 2017/05/12 by Joe.Barnes
Fix for clang producing a warning when not all specializations of a templated function are marked FORCEINLINE.
Also, switch a specialization of BlendTransform() from a function with a check to just a declaration so compiler will catch error instead of a runtime catch.
Change 3440758 on 2017/05/16 by Ben.Woodhouse
Simple threaded CSV Profiler
To capture:
- On the commandline, add -csvCaptureFrames=N to capture N frames from startup
- On the console, use csvprofile start, csvprofile stop or csvprofile frames=N to capture a fixed number of frames
- Instrument with CSV_SCOPED_STAT(statname), CSV_CUSTOM_STAT(statname,value).
CSV capture is enabled in all builds except shipping
- Please do not check in the instrumentation √ we don╞t want to pollute the engine with lots of additional instrumentation. We may add some minimal level of instrumentation at some point
Change 3440954 on 2017/05/16 by Josh.Adams
- Cleaned up some DeviceProfiles in BaseDP.ini
Change 3443778 on 2017/05/17 by Ben.Woodhouse
Aliasing for transient resources + new high level API
Changelists integrated:
3368830
3368887
3377762
3377763
3379513
3381840
3382046
3382138
3385390
3385391
3385531
3396613
3388752
3396756
3397007
3397059
3397780
3397883
3401716
3415179
Change 3451460 on 2017/05/22 by Ben.Woodhouse
Fix editor crash (NULL dereference of ScreenSpaceShadowTexture) when moving the camera around in tm-shadermodels, probably fallout from the VRAM aliasing merge. Not sure if this is the correct fix, but it prevents the crash for now
Change 3451601 on 2017/05/22 by Josh.Adams
- Track idle time from MaxTickRate, so that stat unit is accurate on Game: thread
Change 3452025 on 2017/05/22 by Ben.Woodhouse
Integrate (as edit) CL 3378734 (editor crash fix)
Also add a check for null in LightFunctionRendering.cpp
Change 3452389 on 2017/05/22 by Josh.Adams
- Replaced POCulturePluralForms with a static array, instead of TMapBuilder (was blowing stack or similar on Switch Debug). Code courtesy of Jamie Dale.
Change 3452758 on 2017/05/22 by Joe.Barnes
Add FindFirstClearBit() and FindFirstSetBit() to TStaticBitArray.
Change 3455889 on 2017/05/23 by Ben.Woodhouse
Integrate from //UE4/Main/...@3453436 to //UE4/Dev-Console/...
Change 3458654 on 2017/05/25 by Joe.Conley
Attempting to fix Static Analysis warning.
Change 3462710 on 2017/05/26 by Ben.Woodhouse
Integrate from //UE4/Main/...@3461688 to //UE4/Dev-Console/...
Change 3471711 on 2017/06/02 by Jonathan.Fitzpatrick
Updating MallocProfiler to use the accessor for OnOutOfMemory delegate to conform with change made in CL 3415996.
Change 3473813 on 2017/06/05 by Ben.Woodhouse
Fix streaming visibility logic bug reported on UDN
#jira UE-43892
Change 3475298 on 2017/06/06 by Luke.Thatcher
[CONSOLE] [!] Fix RHITransitionResources crash with more than 16 textures.
- Old command had a fixed sized array of 16 textures that would overflow.
- New command allocates an array of texture pointers inline in the command list, so any number is supported.
#jira UE-45625
Change 3476776 on 2017/06/06 by Ben.Woodhouse
Integrate from //UE4/Main/...@3475908
Change 3479083 on 2017/06/07 by Ben.Woodhouse
Integrate as edit CL 3467315 from dev-animphys:
From Alexis Matte.
Ensure SectionMap is fixed up for old entries that are no longer valid.
#JIRA UE-45438
#jira UE-45735
Change 3480576 on 2017/06/08 by Ben.Woodhouse
Integrate from //UE4/Main/...@3480024 to //UE4/Dev-Console/...
[CL 3483258 by Luke Thatcher in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3175510 on 2016/10/26 by Josh.Adams
- New Wolf SDK support (11).
- Added new input plugin now that extra NDA is lifted
Change 3176629 on 2016/10/27 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3177232 on 2016/10/27 by Josh.Adams
- Minor comment change
Change 3177348 on 2016/10/27 by Dmitry.Rekman
Linux: default to GL4.
Change 3177523 on 2016/10/27 by Dmitry.Rekman
Linux: update libc++ to 3.9 and add AArch64.
Change 3178208 on 2016/10/28 by Daniel.Lamb
Enable multithreaded lightmap encoding.
Change 3178273 on 2016/10/28 by Luke.Thatcher
[PLATFORM] [PS4] [!] Fix crash in PS4 packaging step.
- Parallel-for accessing the same log files, causing IOException.
Change 3178573 on 2016/10/28 by Dmitry.Rekman
Linux: fix for projects not having proper version associations (UE-5954).
- Fixed by CengizT.
Change 3180487 on 2016/10/31 by Josh.Adams
Moved new file to peoper spot
Change 3180508 on 2016/10/31 by Josh.Adams
- Fixed crash on audio free for Wolf
Change 3181821 on 2016/11/01 by Josh.Adams
- Fixed ShooterGame cooking after sync from main
Change 3182469 on 2016/11/01 by Josh.Adams
- test/shipping build wolf fixes
Change 3183078 on 2016/11/02 by Josh.Adams
- Added AllDesktop back in for Windows (File | Package)
Change 3183229 on 2016/11/02 by Josh.Adams
- Fixed wrong path in JunkManifest.txt
Change 3184245 on 2016/11/02 by Dmitry.Rekman
Linux: add AArch64 (ARM64) libs.
Change 3184326 on 2016/11/02 by Dmitry.Rekman
Linux: add more files for AArch64.
Change 3184353 on 2016/11/02 by Dmitry.Rekman
Linux: Add missed AArch64 libpng.
Change 3184871 on 2016/11/03 by Luke.Thatcher
[PLATFORM] [PS4] [!] Fix broken DownloadImage blueprint node on PS4.
- Node should return a UTexture2DDynamic, otherwise the RHI assumes the data has been pre-formatted for the GPU, and we get pitch/layout issues.
#jira UE-36365
Change 3185407 on 2016/11/03 by Dmitry.Rekman
Linux: fix PhysX on AArch64.
(Edigrating 3184484 from Wombat to Dev-Platform).
Change 3187488 on 2016/11/04 by Josh.Adams
Copying //Tasks/UE4/Private-Platform-Switch to Dev-Platform-Minimal (//UE4/Dev-Platform-Minimal)
Change 3187740 on 2016/11/04 by Josh.Adams
- Re-copying the Switch files, now with proper case in the directory names
Change 3188304 on 2016/11/07 by Dan.Mahashin
- Removed deprecated functions in NVN window creation
Change 3188865 on 2016/11/07 by Luke.Thatcher
[PLATFORM] [PS4] [~] Move PS4 console input handler into engine classes from OrionGame.
- Enables console input from Sony's "Console Output" tool for all games, in debug/development builds.
#jira UE-37672
Change 3189517 on 2016/11/07 by Jeff.Campeau
Fix incorrect local platform identification in device manager.
#jira UE-38312
Change 3189897 on 2016/11/08 by Luke.Thatcher
[PLATFORM] [!] Fix width/height mismatch in DownloadImage blueprint node.
Change 3190042 on 2016/11/08 by Josh.Adams
- Fixed default and Shooter App Ids for Switch
Change 3190181 on 2016/11/08 by Joe.Barnes
[UE-37275] Split reflection capture error message into two UE_LOG()s. Line length causes truncation and line wrap on some platforms.
Change 3190185 on 2016/11/08 by Joe.Barnes
Fix another instance of UE_LOG() where the string was being truncated on Switch platform.
Change 3190272 on 2016/11/08 by Daniel.Lamb
Add file hashes to depependency tracking info.
Moved partial gc controlling code outside of the cooker.
Store cooked file hashes in cooked asset registry.
Cooked asset registry is now part of the cooker instead of chunking manifest.
#test cook paragon
Change 3190332 on 2016/11/08 by Omar.Rodriguez
Fixing issues with iOS remote notifications
* Update UPlatformGameInstance::FPlatformRegisteredForRemoteNotificationsDelegate signature so the parameter is const& which will work with BlueprintAssignable
* Fix misspelling when doing respondsToSelector check
* Update generated Xcode project to use the generated entitlements file
* Add remote-notification as a background mode
* Update the generated entitlements file contents to include APS environment for push notifications
* Added bEnableRemoteNotificationsSupport ini parameter to control whether iOS push notifications code is compiled
Change 3190391 on 2016/11/08 by Brent.Pease
UE-31739 - Crash when Deploying to iPad Air with BC4 Texture Compression Setting
(Josh's suggestion worked out of the box)
Change 3190786 on 2016/11/08 by Bart.Hawthorne
Fix some missing PLATFORM_WOLF changes to PLATFORM_SWITCH in ShooterGame
Change 3190902 on 2016/11/08 by Alicia.Cano
Allow RTTI and exceptions to be enabled for Android
#jira UE-37845
#android
Change 3190973 on 2016/11/08 by Chris.Babcock
Add ability to set element value field with new text parameter for UPL
#jira UE-37390
#PR #2869
#ue4
#upl
Change 3191411 on 2016/11/09 by Josh.Stoddard
Warn when user tries to use a shared pak reader on the wrong thread
#jira UE-38049
Change 3191635 on 2016/11/09 by Josh.Stoddard
More useful message during cook when AT9 assets fail to encode using SCE's tool
#jira UE-38053
Change 3191663 on 2016/11/09 by Peter.Sauerbrei
fix for ios build from PC
Change 3191701 on 2016/11/09 by Brent.Pease
implement iOS device logs on windows
Change 3191794 on 2016/11/09 by Daniel.Lamb
Fixed up compile error missing header file.
#test Compile editor
#jira UE-38414
Change 3191807 on 2016/11/09 by Josh.Adams
- Fixed one chage that was missed in the WolfPlat->Switch rename
Change 3191867 on 2016/11/09 by Josh.Adams
- Enabled Switch for ShooterGame project
Change 3191958 on 2016/11/09 by Jeff.Campeau
Add warning for anyone still using XP
Change 3192185 on 2016/11/09 by Josh.Adams
- Updated to SDK 0.11.12
- Added TrackLotCheckItem API to track guidelines with limits (nothing using it yet)
Change 3192241 on 2016/11/09 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3192324 on 2016/11/09 by Josh.Adams
- Worked around an issue with RunOnTarget stripping quotes around paths with spaces
#jira UE-38388
Change 3192387 on 2016/11/09 by Josh.Adams
- Updating editor icon for Switch
#jira UE-38295
Change 3192476 on 2016/11/09 by Dmitry.Rekman
Linux: put correct OpenAL lib per architecture.
(Edigrating CL 3185947 from Wombat to Dev-Platform)
Change 3192527 on 2016/11/09 by Josh.Adams
- Fixed a shadow variable warning
#jira UE-38408
Change 3192606 on 2016/11/09 by Jeff.Campeau
XP option removed
#jira UEPLAT-1542
Change 3192644 on 2016/11/09 by Josh.Adams
- Fixed a CIS error (not sure why I don't get it, but hey)
Change 3192659 on 2016/11/09 by Josh.Adams
- Fixed a crash in DeploymentServer
Change 3192672 on 2016/11/09 by Jeff.Campeau
Fix WinXP message spamming
Change 3193252 on 2016/11/10 by Josh.Adams
- Remove assertion in SwitchTextureFormat when the SDK can't be found (if you are sharing DLLs)
Change 3193756 on 2016/11/10 by Dmitry.Rekman
Linux: add support for touch events.
(Edigrating CL 3188159 from Wombat to Dev-Platform).
Change 3194297 on 2016/11/10 by Jeff.Campeau
HarfBuzz implementation for Xbox One
#jira UE-28590
Change 3194299 on 2016/11/10 by Jeff.Campeau
Pump Xbox One messaging during slow startup tasks
#jira UEPLAT-1276
Change 3194300 on 2016/11/10 by Jeff.Campeau
Use response files when building for Xbox One
#jira UEPLAT-1296
Change 3194313 on 2016/11/11 by Jeff.Campeau
Stop uploading symbols on the first error
Show a more detailed error message if symbol uploading fails
Add a command line option to disable upload of symbols
#1852
#jira UE-24425
Change 3194327 on 2016/11/11 by Jeff.Campeau
Deduplicate Xbox One build.cs setup for several modules
#jira UE-37540
Change 3194402 on 2016/11/11 by Dmitry.Rekman
Linux: do not apply mouse workaround unnecessarily.
- Only matters when there is more than one window.
(Edigrating 3194399 from Wombat to Dev-Platform).
Change 3194434 on 2016/11/11 by Dan.Mahashin
- Ported fix CL 3193690: Add workaround to file I/O error about ResultInvalidCurrentMemory when reloading levels - remove uncached attribute during memory pool finalization
Change 3194569 on 2016/11/11 by Daniel.Lamb
Fixed issue with CreateLinker failing to return LinkerLoad but creating a UPackage which can't be cleaned up.
Change 3194570 on 2016/11/11 by Daniel.Lamb
Fix for DiffSerializeArchive not using the correct archive when saving packages.
#test Cook paragon
Change 3194571 on 2016/11/11 by Daniel.Lamb
Make sure dependent packages are valid before using them.
Added FastBuildCookRun bat file for paragon testing.
#test Cook Paragon
Change 3194575 on 2016/11/11 by Daniel.Lamb
Reworked a warning for the cooker.
Change 3194698 on 2016/11/11 by Daniel.Lamb
Skip skin verify only runs on build machines now.
Saves paragon cook time.
Change 3194699 on 2016/11/11 by Daniel.Lamb
Changed the wording of skip editor content setting so it's more clear.
#test none
Change 3194702 on 2016/11/11 by Daniel.Lamb
Potential fix for default materials not being in chunk zero.
#test run ps4 cooked build paragon
Change 3194711 on 2016/11/11 by Alicia.Cano
Allow RTTI and exceptions to be enabled for Android
Allow RTTI to be enabled for IOS, Mac
#jira UE-37845, UE-20314
#android
#ios
#mac
Change 3194956 on 2016/11/11 by Josh.Adams
- Removed the crash with unknown socket error code, left in the warning
Change 3195028 on 2016/11/11 by Dmitry.Rekman
Linux: repair launch on.
(Edigrating 3194384 from //UE4/Private-Wombat/... to //UE4/Dev-Platform/...)
Change 3195041 on 2016/11/11 by Dmitry.Rekman
Linux: support selecting architectures per project.
(Edigrating 3192783 from Wombat to Dev-Platform).
Change 3195058 on 2016/11/11 by Dmitry.Rekman
Linux: fix code to determine number of cores.
- ARM topology seems not to be in line with the assumptions made by x86-centric code.
(Merging 3184632 from Wombat to Dev-Platform).
Change 3195082 on 2016/11/11 by Josh.Adams
- Fixed name of packaged Switch builds to have the config in it (Shipping, etc)
#jira UE-38394
Change 3195151 on 2016/11/11 by Bart.Hawthorne
- Add game server settings to project settings to connect to the actual game server, instead of the debug login
- Use the system software dialog box to show error codes for login failures
Change 3195153 on 2016/11/11 by Josh.Adams
- Fixed copy and paste logs errors
Change 3195156 on 2016/11/11 by Josh.Adams
- Fixed some default values, especially for save games (uses their default of 4MB size)
- Added some LotCheck write tracking
Change 3195285 on 2016/11/11 by Jeff.Campeau
Fix HarfBuzz warning on Xbox One
Change 3195477 on 2016/11/11 by Josh.Adams
- Fixed up some IsGameOnly calls
#jira UE-37575
Change 3195490 on 2016/11/11 by Dmitry.Rekman
UAT: fix CIS (removed old variables).
Change 3195724 on 2016/11/11 by Josh.Adams
- Final fix for name of .nsp (content only projects in Shipping config, etc)
#jira UE-38394
Change 3195755 on 2016/11/11 by Josh.Adams
- Made translucent Switch icons
Change 3195771 on 2016/11/11 by Josh.Adams
- Fixed some Switch "space in path" issues
#jira UE-38393
Change 3195801 on 2016/11/11 by Josh.Adams
- Handle making sure the save is completed before we shutdown
#jira UE-38215
Change 3196593 on 2016/11/14 by Michael.Trepka
Implemented Info string in AvfMedia for display in Media Player Editor
#jira UE-35386
Change 3196782 on 2016/11/14 by Josh.Adams
- Added a comment for a workaround
Change 3196784 on 2016/11/14 by Michael.Trepka
Alembic importer for Mac
#jira UE-37708
Change 3196901 on 2016/11/14 by Alicia.Cano
ADB over wifi fails to deploy on Launch on.
#jira UE-37957
#android
Change 3197055 on 2016/11/14 by Josh.Adams
- Fixed BinnedAllocator crash that happened with PoisonProxy and large allocations with large alignment
Change 3197059 on 2016/11/14 by Josh.Adams
- Removed some stat code with no STATS
Change 3197066 on 2016/11/14 by Josh.Adams
- Fixed the generic growableallocator to not free metadata before it's used for stats, and cleaned up a couple minor things
Change 3197176 on 2016/11/14 by Josh.Adams
- Added some helper scripts to switch in and out of debug mode on Switch
Change 3197183 on 2016/11/14 by Bart.Hawthorne
Error dialog fixes based on peer review feedback from JoshA
Change 3197339 on 2016/11/14 by Josh.Adams
Allow -htcs on the commandline now to override disabling Htcs in packaged builds
Change 3197401 on 2016/11/14 by Josh.Adams
- Fixed the Switch package installation script to remove the path of the package, since it causes problems with spaces, and also it makes the script less portable!
#jira UE-38556
Change 3197691 on 2016/11/14 by Dmitry.Rekman
Linux: save added devices.
(Edigrating 3196529 from Wombat to Dev-Platform).
Change 3197854 on 2016/11/15 by Dan.Mahashin
- MemoryProfiler2: fixed Switch parser file path in the csproj
Change 3197960 on 2016/11/15 by Dan.Mahashin
- NVN RHITransitionResources() directly uses a barrier instead of relying on CopyToResolveTarget() side effect (UE-33834)
Change 3198488 on 2016/11/15 by Bart.Hawthorne
Submit missing NoRedist/DefaultEngine.ini file
Change 3198970 on 2016/11/15 by Michael.Trepka
Don't try to use installed Mono 4.6 on Mac as it's known to have issues on macOS 10.12 (for example building the editor with UBT often fails with Mono running out of file desriptors)
Change 3199050 on 2016/11/15 by Daniel.Lamb
Some more output to help track down iterative cooking scenarios
#test Cook paragon
Change 3199097 on 2016/11/15 by Josh.Adams
- Fixed up Switch packaging to re-generate the meta data in case it changed since compile time (esp with content only projects
- Fixed default Program Id in code
- Fixed a problem with Run with a space in the path
#jira UE-38608
Change 3199181 on 2016/11/15 by Dmitry.Rekman
Fix CIS (compiling LinuxTargetDevice without engine).
Change 3199253 on 2016/11/15 by Dmitry.Rekman
Hopeful fix for a static analysis warning.
Change 3199325 on 2016/11/15 by Joe.Barnes
Start a new CommandBuffer immediately upon ending one. Prevents fetching when there's no CommandBuffer. Needed for Loading Screen movie playback.
Change 3199814 on 2016/11/15 by Dmitry.Rekman
Linux: remove forced -windowed when launching.
(Merging CL 3199789 from Wombat to Dev-Platform)
Change 3200580 on 2016/11/16 by Josh.Adams
Updasted DeploymentServer
Change 3200595 on 2016/11/16 by Joe.Barnes
Removed inadvertent SleepThread() when starting movie playback.
Change 3200604 on 2016/11/16 by Josh.Adams
- Added NN_MIDDLEWARE macros to tag ths apps as using UE4 middleware
Change 3200632 on 2016/11/16 by Brent.Pease
Update PlatformShowcase with latest tests
Change 3200704 on 2016/11/16 by Dmitry.Rekman
Linux: fix native compilation.
Change 3200711 on 2016/11/16 by Brent.Pease
- Support ios audio streaming from disk
- Flushed out ADPCMAudioInfo to be more flexible with buffer management in addition to support streaming from disk. This should make more code platform independent.
+ Other platforms should work fine but will need to be updated to use the new buffer flexability (and hence simplify their own code and buffer management)
- IOS audio implementation simplified to use new ADPCMAudioInfo functionality
- Fixed adpcm seamless looping
NOTE: While everything works with my testing (admittedly simple tests) a little more code cleanup needs to happen...
Change 3201015 on 2016/11/16 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3201023 on 2016/11/16 by Josh.Stoddard
Fix splash screen assignment for iPad
#jira UE-38623
Change 3201215 on 2016/11/16 by Brent.Pease
Hopefully final fix for build breakage
Change 3201259 on 2016/11/16 by Josh.Adams
- Removed the clock rate settings from the Project Settings, and the cvars - it was just confusing
- Further improved the metadata recreation during packaging (can get rid of the temp meta/desc files now I believe)
- Reduced audio pool alignment to not waste massive memory from it
Change 3202332 on 2016/11/17 by Daniel.Lamb
Changed build scripts to support iterative cooking
#test Ran new build scripts
Change 3202371 on 2016/11/17 by Michael.Trepka
Changed FAppleHttpResponse::GetContentLength to return expected content size instead of payload size so it's consistent with other implementations
#jira UE-38392
Change 3202421 on 2016/11/17 by Michael.Trepka
Decrease the number of max open files for a thread on Apple platforms from 256 to 192 to leave more file descriptors to Cocoa
#jira UE-18343
Change 3202462 on 2016/11/17 by Michael.Trepka
Fixed HTTP If-None-Match response code on Mac and iOS
Fixed by iktomi, https://answers.unrealengine.com/questions/492514/http-if-none-match-logic-isnt-working-on-mac-due-t.html
#jira UE-36317
Change 3202620 on 2016/11/17 by Daniel.Lamb
Fixed issue with some objects being garbage collected which shouldn't be because the collection handler didn't get registered.
Commandlets now do not always have GIsRequestingExit true.
Made crash handler check for commandlets running and exit appropriately.
#test Rebuild lighting QAGame
Change 3202955 on 2016/11/17 by Daniel.Lamb
Add support for clearing all the cached cooked platform data for a platform when requested.
#test cook QA game
#jira UE-38361
Change 3202983 on 2016/11/17 by Daniel.Lamb
Added support to rebuild lightmaps commandlet for building lightmaps in seperate files.
#test rebuild lighting Custom QAGame maps.
#jira OR-31907
Change 3203128 on 2016/11/17 by Josh.Adams
- Fixed split screen user selection in ShooterGame (brought over some changes from NickD for it as well)
Change 3203537 on 2016/11/18 by Dmitry.Rekman
Fix ProjectWorldToScreen node for letterboxed viewports.
(Merging CL 3201546 from Wombat to Dev-Platform).
Change 3203540 on 2016/11/18 by Dmitry.Rekman
Linux: be more verbose when setting vblank sync.
(Merging CL 3199633 from Private-Wombat to Dev-Platform).
Change 3203599 on 2016/11/18 by Dmitry.Rekman
Speedup bForceCompilationAtStartup=True when nothing changed (UE-37067).
- PR #2849: Contributed by slonopotamus.
Change 3203610 on 2016/11/18 by Dmitry.Rekman
Add CEF support for Linux (UE-6743).
Change 3203615 on 2016/11/18 by Dmitry.Rekman
Linux: fix bootstrap script so it is independent of working dir (UE-37016).
- PR #2842 contributed by slonopotamus
Change 3203645 on 2016/11/18 by Dmitry.Rekman
Linux: fix UnrealCEFSubProcess.
Change 3203658 on 2016/11/18 by Dmitry.Rekman
Remove hard-coded paths to mono binary (UE-35228).
- Another way to implement pull request #2741.
Change 3203770 on 2016/11/18 by Josh.Adams
- Brought over some changes from Dev-Core to not crash in AsyncLoading with debug code
Change 3204244 on 2016/11/18 by Dmitry.Rekman
Unsuppress mistakenly suppressed warnings and fix one more (UE-38788).
Change 3204277 on 2016/11/18 by Brent.Pease
+ Fix seamless looping bug found on Dan's QAGame test
+ Fix static analyzer warning (which was a real bug with uncompressed streaming)
+ Code review feedback from Aaron
+ Small addition from channel sync ios bug fix
Change 3204576 on 2016/11/18 by Omar.Rodriguez
Expose the bEnableRemoteNotificationsSupport ini setting in the iOS project settings.
Change 3204629 on 2016/11/18 by Chris.Babcock
Fix case of VulkanSwapChain.h #include
#jira UE-38843
#ue4
#vulkan
Change 3204708 on 2016/11/18 by Josh.Adams
- Set SwitchMoviePlayer to include the libs from the proper directory
Change 3204730 on 2016/11/18 by Josh.Adams
- Changed a check to a checkf to narrow down why FMaterialUniformExpressionType::GetTypeMap().FindRef(TypeName) is returning nullptr on tvOS
Change 3204865 on 2016/11/18 by Brent.Pease
+ Turn off ios console logs on Windows to help sort through ios packaging and launch-on issues - This is NOT a fix but it should make it easier to track down the problem with it off.
Change 3204883 on 2016/11/18 by Dmitry.Rekman
Linux: fix native LaunchOn (UE-38616).
Change 3204914 on 2016/11/18 by Brent.Pease
+ Turn off the device check to prevent it from conflicting with remote packaging/launch-on
Change 3204940 on 2016/11/18 by Josh.Adams
Backing out changes to the profiler for Switch. Shouldn't have checked it in today during smoke
Change 3204952 on 2016/11/18 by Dmitry.Rekman
Linux: fix bootstrap script (UE-38851).
- Caused by UE-37016.
Change 3205630 on 2016/11/21 by Brent.Pease
+ Fix audio sound queuing bug by ensuring audio buffers are not reused by different sound source objects.
+ Cleaned up the locking mechanism around stopping sound sources to make its intent and function are clear
+ Cleaned up memory tracking and freeing.
#jira ue-38846
Change 3205787 on 2016/11/21 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
[CL 3206922 by Josh Adams in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2948319 on 2016/04/19 by Nick.Shin
update zlib to v1.2.8
part 1 of 4 - doing this in stages for tracking purposes
#jira UEPLAT-1246 - Update libWebsockets
#jira UEPLAT-1221 - update websocket library
Change 2948322 on 2016/04/19 by Nick.Shin
update libwebsockets to v1.7.4
part 4 of 4 - doing this in stages for tracking purposes
#jira UEPLAT-1246 - Update libWebsockets
#jira UEPLAT-1221 - update websocket library
#jira UEPLAT-1204 - Rebuild libwebsockets with SSL
Change 2948661 on 2016/04/19 by Nick.Shin
keep using old zlibs until they are recompiled with the newer version
Change 2948737 on 2016/04/19 by Nick.Shin
build warning fix
Change 2949334 on 2016/04/20 by Nick.Shin
fix library path
for some reason, NetworkFileSystem and HttpNetworkReplayStreaming on Mac platform needs full path - even though lib path was set...
Change 2951556 on 2016/04/21 by Nick.Shin
static libs double checked
#jira UE-29674 - Editor fails to open in Dev-Platform
Change 2951559 on 2016/04/21 by Nick.Shin
static libs double checked
forgot these files - they were in another changelist
#jira UE-29674 - Editor fails to open in Dev-Platform
Change 2952411 on 2016/04/22 by Nick.Shin
add win32 build targets for zlib openssl libcurl libwebsockets
part 1 of 2: these are the C# build scripts
Change 2970016 on 2016/05/07 by Nick.Shin
undo all of the following upgrades:
- zlib
- openssl
- libcurl
- libwebsockets
and reset webrtc
#jira UE-30298 - Fortnite and Orion crash on login
Change 3118163 on 2016/09/08 by Josh.Adams
perm test 2, not a useful file at all
Change 3121142 on 2016/09/12 by Daniel.Lamb
Attempt to fix deterministic cooking issue for particlelodlevel.
Ensure the spawn module has had postload called on it before using.
#test Paragon cook
Change 3121150 on 2016/09/12 by Daniel.Lamb
Added warning logs to help track down issue UE-33453.
Change 3121201 on 2016/09/12 by Keith.Judge
Xbox One - Replicate CL 3114357 from 4.13 branch. ESRAM clear on create fix.
Change 3121302 on 2016/09/12 by Joe.Graf
Fixed up the IMPLEMENT_MODULE macro usage to avoid the link errors
Change 3121379 on 2016/09/12 by Dmitry.Rekman
Linux: only link libraries that export needed symbols (UE-35720).
- Fixes very long startup times of modular builds.
- Includes PR #2778 by slonopotamus.
#jira UE-35720
Change 3121383 on 2016/09/12 by Dmitry.Rekman
Linux: added some missing _API declarations on symbols used externally.
- Compiling editor with -fvisibility=hidden works after this fix (although running still doesn't).
Change 3121456 on 2016/09/12 by Daniel.Lamb
Attempt to fix deterministic cooking issue for particlelodlevel.
Ensure the spawn module has had postload called on it before using.
#test Paragon cook
Change 3122939 on 2016/09/13 by Luke.Thatcher
[PLATFORM] [PS4] [!] Skip orbismemdmp files in the PS4 crash handler web service.
- Writing these files to disk causes orbis-tm.exe to take a file lock on them, which means we can't move the crash directory to the landing zone.
Change 3123040 on 2016/09/13 by Brent.Pease
+ Fix VS compile error by removing ENGINE_API from virtual method decls since ENGINE_API is defined for the entire class now.
Change 3123664 on 2016/09/13 by Nick.Shin
this was originally checked into: release 4.13.1
bringing here to dev-platform
-- original submit comments --
first, safari has a problem with firing off "window resized" events - causing an infinite loop of the window "resizing"
next, retina has "bigger" size calculations going off -- so y-delta checks greater than 2 are done to prevent resize event firing off in an infinite loop
jira UE-35363 - Huge game window when launching onto Safari 9.1.2
Change 3125282 on 2016/09/14 by Michael.Trepka
Fixed iOS and tvOS code indexing in Xcode project
Change 3126812 on 2016/09/15 by Josh.Adams
Merged Wolf support into Dev-Platform (hidden from almost all people still). Non-Wolf-specific changes:
- Added Parse function to JsonObject.cs to be able to parse a string
- Replaced some hacky post-reflection-capture functions with RHISubmitCommandsAndFlushGPU()
- Split PLATFORM_HAS_BSD_SOCKET_FEATURE_GETADDRINFO off from PLATFORM_HAS_BSD_SOCKET_FEATURE_GETHOSTNAME
- Converted the PS4MallocCrash class into a generic one (that Wolf is now also using)
- Added AddGenericToInQueueOnlineThread(), useful running a delegate on Online thread instead of game thread
- Refactored the GL shader compiler to allow Wolf to modify behavior without a lot of if WOLF checks everywhere
- Added ability in the cross compiler to convert the global uniform arrays into named uniform buffer objects
- Added ability for GL shader compiler to output original resources names ("VertColor" instead of "u_v[3]" or whatever)
- Added "FORCELODGROUP" console command that will apply a StaticMesh LODGroup to selected meshes in the editor. This can batch-Simplygonify all meshes in a level. Should maybe become an editor tool.
- Added ability for arrays of structs to specify a property to be the key. So, with LODGroups, the Name key inside the struct can be the unique key, so when you have multiple .ini files in the hierarchy overriding the same LODGroup by name, it will repalce the first with the second, instead of adding two entries with the same name. Set by @ArrayName=KeyPropertyName. Per Object Config sections need a little different handling, which uses * (see BaseDeviceProfiles.ini)
- Added ability to change DeviceProfiles at runtime. Use "dp.override <name>". If you do it again to another one, it will reset the settings to what they were originally, before applying the second new DP. This is because the second DP may not set all settings the first one did, but we want to undo the first settings that the second doesn't contain.
- Added FRHICommandListImmediate::IsStalled() - returns true while FRHICommandListImmediate::StallRHIThread is happening
- Changed runtime GetFeatureLevelMaxTextureSamplers() calls to the new GetMaxTextureSamplers() which can now be handled by the platform. Renamed GetFeatureLevelMaxTextureSamplers to GetExpectedFeatureLevelMaxTextureSamplers() (only used by the shader editor) to guess at what maybe the samplers count will be - but it's not guaranteed correct.
- Renamed a UT copy of a global function to not linker-conflict
- Changed the OOMBackupMemoryPool to allow each platform to set how much memory to allocate. See FPlatformMemory::GetBackMemoryPoolSize(). Defaults to 0, which was the previous behavior with the now removed FPlatformMemory::SupportBackupMemoryPool(), which was only true in Windows and PS4.
- Added an OOM delegate so other systems can get a callback after OOM occurs (after deleting the backup memory pool if it exists)
- Changed SetQualityLevels() (in Scalability.cpp) to no longer change the SetBy priority when setting CVars, and now keeps the SetBy the same as it was. Helps with conflicts between game settings and device profiles. See SetWithCurrentPriority()
- Added GetRenderingThreadPriority to FPlatformAffinity to allow a platform override priority. Not sure about this one, so may remove it, or maybe add more priorities for all the threads?
- Added a new file into the ini hierarchy to begin fixing the Engine/Base -> Project/Default -> Engine/Platform -> Project/Platform mess. We now have Engine/Base -> Engine/BasePlatform -> Project/Default -> Engine/Platform -> Project/Platform. However, Engine/Platform will soonm be deprecated as we move things over to Engine/BasePlatform, that are safe to move.
Change 3126842 on 2016/09/15 by Michael.Trepka
Make SAssertPicker's search box the default widget to focus on activate so that it doesn't get deactivated on Mac, where we get the window activation event in a tick after SAssertPicker creation.
Change 3126956 on 2016/09/15 by Michael.Trepka
Added support for compiling Vulkan shaders for Android on Mac
Change 3127206 on 2016/09/15 by Michael.Trepka
PR #2604: Remove some warnings. (Contributed by reapazor)
Change 3127324 on 2016/09/15 by Michael.Trepka
Allow third party dylibs on Mac to be loaded from plugin subfolders
Change 3127924 on 2016/09/16 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3128369 on 2016/09/16 by Nick.Shin
zlib 1.2.8
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128377 on 2016/09/16 by Nick.Shin
openssl 1_0_2h
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128383 on 2016/09/16 by Nick.Shin
libcurl 7_48_0
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128384 on 2016/09/16 by Nick.Shin
libwebsockets 1.7.4
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128464 on 2016/09/16 by Nick.Shin
webRTC rev.12643
NOTE: VS2015
- only Win64 is available
- Win32 versions is crashing (e.g. EpicGamesLauncher) at the moment
NOTE: VS2013
- not tested (i'm working on getting a VS2013 pro license) - so not checking in with this changelist
- also, VS2013 is no longer supported by webRTC build scripts, so it will be old anyways
FUTURE NOTE:
- will continue to try to get VS2015 Win32 functional
- and am working on trying to get VS2013 tested
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128500 on 2016/09/16 by Nick.Shin
zlib 1.2.8 - OSX
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128504 on 2016/09/16 by Nick.Shin
openssl 1_0_2h - OSX
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128506 on 2016/09/16 by Nick.Shin
libcurl 7_48_0 - OSX
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128508 on 2016/09/16 by Nick.Shin
libwebsockets 1.7.4 - OSX
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128513 on 2016/09/16 by Nick.Shin
webRTC rev.12643 - OSX
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128602 on 2016/09/16 by Nick.Shin
webRTC rev.9862 - Win64 VS2013
NOTE:
- not tested (i'm working on getting a VS2013 pro license)
- checking in for testing purposes
WARNING:
- VS2013 is no longer supported by webRTC latest
headers and lib updates
part of [ zlib openssl libcurl libwebsockets webrtc ] updates
Change 3128605 on 2016/09/16 by Nick.Shin
re-enabling updated ThirdParySoftware libs:
- zlib (v.1.2.8)
- openssl (1.0.2h)
- libcurl (7_48_0)
- libwebsocket (v.1.7.4)
- webRTC (rev.12643)
to the codereviewers, in my attempt to ensure the older libs are still used for console, mobile and linux -- please refer to this checkin if i broke the build...
Change 3128651 on 2016/09/16 by Nick.Shin
fix Win32 build error from CL: #3128605
Change 3128704 on 2016/09/16 by Nick.Shin
fix Win32 build error from CL: #3128605 - this time actually compiling it...
Change 3128825 on 2016/09/16 by Dmitry.Rekman
Linux: proper fix for too slow startup times (UE-35967).
- Pull request #2793 by slonopotamus.
- Now without stripping dependencies on libraries specified before.
- Contains a work around for ld bug <2.25.
Change 3128972 on 2016/09/16 by Nick.Shin
fix to local build error.
Change 3129283 on 2016/09/16 by Brent.Pease
+ Add Android local notification support based on existing system used for iOS
+ Initial API has been added for cancelling local notifications but the actual platform implementation will be done in the next release
Change 3129494 on 2016/09/17 by Nick.Shin
fix CIS build errors
Change 3129503 on 2016/09/17 by Dmitry.Rekman
Fix Linux build (case sensitivity issue).
Change 3129514 on 2016/09/17 by Nick.Shin
fix CIS build errors for consoles - missing zlib include path
special thanks to Dmitry.Rekman for pointing me in the right direction
Change 3129647 on 2016/09/17 by Dmitry.Rekman
Linux: fix non-unity build.
Change 3131043 on 2016/09/19 by Nick.Shin
archiving build instructions/steps when building:
- zlib (v.1.2.8)
win: #3128369
osx: #3128500
- openssl (1.0.2h)
win: #3128377
osx: #3128504
- libcurl (7_48_0)
win: #3128383
osx: #3128506
- libwebsocket (v.1.7.4)
win: #3128384
osx: #3128508
- webRTC
win: #3128464 (rev.12643 for vs2015) + 3128602 (rev:9862 for vs2013) -- NOTE: win32 is WiP
osx: #3128513
Change 3132801 on 2016/09/20 by Dmitry.Rekman
Linux: support specifying default OpenGL version via configs (UE-34777).
- The first targeted RHI is going to be used.
Change 3132905 on 2016/09/20 by Josh.Adams
- Fixed up some paths with the WolfPlat rename
Change 3133148 on 2016/09/20 by Josh.Adams
- Only show UT EULA if PLATFORM_DESKTOP
Change 3133152 on 2016/09/20 by Josh.Adams
- Beginning support for applets. Disabled unless you have a special SDK with applet support.
Change 3133169 on 2016/09/20 by Josh.Adams
- Fixed issue with Wolf access but no SDK installed
Change 3133344 on 2016/09/20 by Daniel.Lamb
Fixed issue with Iterative cooking not detecting changes to ini files which are loaded using LoadLocalFile.
Added new flag to limit number of concurrent shader compiles.
#test Cook QAGame, Cook Paragon
Change 3133345 on 2016/09/20 by Daniel.Lamb
FRedirectCollector collects string asset references all the time when running the editor.
#test Cook paragon cook QAGame.
Change 3133852 on 2016/09/21 by Luke.Thatcher
[PLATFORM] [PS4] [^] Performing merge between 3.508.201 LCUE files in CarefullyRedist and Dev-Platform to populate integration history. No files have actually changed in this CL, only Perforce metadata is updated.
Change 3133875 on 2016/09/21 by Luke.Thatcher
[PLATFORM] [PS4] [^] Performing merge between 3.508.201 LCUE files in CarefullyRedist and Dev-Platform to populate integration history. No files have actually changed in this CL, only Perforce metadata is updated. (Attempt 2)
Change 3134403 on 2016/09/21 by Jonathan.Fitzpatrick
Per PS4 documentation, app_type requires the alternate spelling of 'upgradeable', 'upgradable'.
Change 3134544 on 2016/09/21 by Josh.Adams
- Reduced UT textures for Wolf
Change 3134915 on 2016/09/21 by Jonathan.Fitzpatrick
FPS4Time::SystemTime now calculates the local machine time, instead of UTC.
#jira UE-35170
Change 3135036 on 2016/09/21 by Michael.Trepka
Quit the UE4EditorServices app when quitting the Launcher if it was the launcher that spawned the services process
Change 3135142 on 2016/09/21 by Jonathan.Fitzpatrick
GetBackMemoryPoolSize returned bool on PS4 by accident, should be uint32
Change 3135292 on 2016/09/21 by Jeff.Campeau
Change include order to favor the XDK edition specific headers where available.
Change 3136414 on 2016/09/22 by Josh.Adams
- Fixed a checkf() that had the case reversed
#jira ue-36311
Change 3137082 on 2016/09/22 by Dmitry.Rekman
Added support for Linux installed builds to 4.14
Change 3137220 on 2016/09/22 by Dmitry.Rekman
Linux: do not rebuild hlslcc on each setup.
- Now that hlslcc is set to use bundled libc++ there should be no STL binary compatibility conflicts between the engine and hlslcc binary.
Change 3137227 on 2016/09/22 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3137259 on 2016/09/22 by Dmitry.Rekman
Linux installed build: fix CIS (missed one .csproj)
Change 3137290 on 2016/09/22 by Dmitry.Rekman
Linux installed builds: fix for the resulting directory.
Change 3137291 on 2016/09/22 by Chris.Babcock
Restore texture filtering mode properly when movie played on Android
#jira UE-36342
#ue4
#android
Change 3137376 on 2016/09/22 by Dmitry.Rekman
Linux: re-enabled crash handler stack smash protection.
- Race condition in FRunnableThreadPThread has been previously fixed.
Change 3138498 on 2016/09/23 by Dmitry.Rekman
Linux: add missed package for installed builds.
- mono-devel package for resgen2.
Change 3138523 on 2016/09/23 by Dmitry.Rekman
Linux: Update hlslcc now that we're not rebuilding it each time.
Change 3138658 on 2016/09/23 by Josh.Adams
- Moved UT's Social Plugin into NotForLicensees
Change 3139042 on 2016/09/23 by Dmitry.Rekman
Linux: more robust check of installed packages.
- Also added mono-devel to the list of packages installed on 14.04.
Change 3139674 on 2016/09/26 by Dmitry.Rekman
Fix crash when editing widget blueprints (UE-35185).
- Caused by name collision due to copy/pasted code; aliased classes diverged and this resulted in all kinds of weird memory stomping.
- Renamed the class and also applied the same workaround (removing static) to prevent likely crashes on exit as happened with the original class (see UE-30795).
Change 3140203 on 2016/09/26 by Josh.Adams
- Wolf Fix for SHIPPING
Change 3140206 on 2016/09/26 by Josh.Adams
- NEX work, still in progress
Change 3140276 on 2016/09/26 by Josh.Adams
- Fixed Wolf compile error
Change 3140485 on 2016/09/26 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3140570 on 2016/09/26 by Dmitry.Rekman
SDL2: Delete obsolete files.
- We now have local changes to SDL2, so this tarball is no longer accurate and just takes unnecessary space.
Change 3140577 on 2016/09/26 by Dmitry.Rekman
Fix CudaTest monolithic build.
- Not the best fix, the better fix is to build against bundled libc++.
Change 3141184 on 2016/09/27 by Keith.Judge
Add FXboxOneApplication::GetXboxOneApplication to fix a save/load game assert.
#jira UE-35973
Change 3141623 on 2016/09/27 by Chris.Babcock
Support hiding virtual keyboard on Android
#jira UE-34201
#ue4
#android
Change 3141887 on 2016/09/27 by Joe.Graf
Added support for additional plugin directories that are specified by the .uproject file
New plugin wizard adds to the additional plugin directories if the user specifies a directory outside of Engine/Plugins or Game/Plugins
Change 3141916 on 2016/09/27 by Josh.Adams
- Worked around compile issues (at least with Wolf UT). This is well documented in a Jira (UE-29925)
Change 3141926 on 2016/09/27 by Josh.Adams
- Support for skipping Wolf user selector (-nologinui)
Change 3141938 on 2016/09/27 by Chris.Babcock
Allow Android media player to seek past 999ms (contributed by rcywongaa)
#jira UE-36453
#PR #2797
#ue4
#android
Change 3142207 on 2016/09/27 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3142219 on 2016/09/27 by Josh.Adams
- Wolf PhysX 3.4 libs and includes
Change 3142220 on 2016/09/27 by Josh.Adams
- File that had to be fixed up after main merge (missed adding it to the huge integrate CL)
Change 3142314 on 2016/09/27 by Chase.McAllister
#jira UE-35011 fixes to some assets to remove redundancies/output log spam
Change 3142510 on 2016/09/27 by Daniel.Lamb
Fixed up resave lightmaps commandlet so that world transforms don't get applied twice.
#jira UE-35942
Change 3142650 on 2016/09/27 by Chris.Babcock
Android support for Linux by yaakuro
- requires CodeWorks for Android Linux installed and OpenJDK 1.8
- need to set Android SDK paths manually in Project Settings
#jira UE-32752
#jira UE-32753
#PR #2564
#PR #2565
#ue4
#android
#linux
Change 3142802 on 2016/09/27 by Dmitry.Rekman
Upgrade to SDL 2.0.5-ish (still technically 2.0.4).
- Upstream revision 10374:dccf51aee79b.
- Merged all our changes hopefully.
Change 3143075 on 2016/09/28 by Luke.Thatcher
[RENDERING] [~] Add check to FBatchedElements::AddSprite to catch null textures. If the texture is null here, we will crash later in the RHI. At least now we'll get the callstack of the code adding the null textured sprite, since I don't have a repro.
#jira UE-33077
Change 3143219 on 2016/09/28 by Daniel.Lamb
Added new is compiling function which tells you if it's really compiling instead of lying.
If def out additional logging for debugging shader compilation issue for 4.14 release.
Change 3143428 on 2016/09/28 by Luke.Thatcher
[PLATFORM] [PS4] [+] Use PS4 SDK 4.008.061
Change 3143488 on 2016/09/28 by Daniel.Lamb
Changed defaults for skip cooking editor content to true.
Change 3143526 on 2016/09/28 by Daniel.Lamb
Increased the concurrent shader compile limit while in the cooker.
#test Cook paragon
Change 3143874 on 2016/09/28 by Chris.Babcock
Read Android environment variables from .bashrc on Linux
#jira UE-36565
#ue4
#android
#linux
Change 3143911 on 2016/09/28 by Dmitry.Rekman
Fix SDL EGL API binding (UE-18979).
- Contains PR #1398 by x414e54.
- Also fixes offscreen backend that needed to provide a global mouse state after the SDL upgrade.
Change 3143929 on 2016/09/28 by Daniel.Lamb
Removed some more temporary logging.
#test Cook paragon
Change 3143959 on 2016/09/28 by Jeff.Campeau
Media Player for Xbox One
Change 3143997 on 2016/09/28 by Dmitry.Rekman
Linux: faster linking in Debug.
- Do not apply --as-needed to Debug build since taking a hit of several tens of seconds on startup is better than linking for ~4 more minutes when iterating.
Change 3144004 on 2016/09/28 by Dmitry.Rekman
Linux: make SCW dump core on crash in debug builds.
- If the editor (not SCW itself) is built in Debug, make SCW dump cores if they ever crash. This makes it debug easier (at the risk of running of disk space).
Change 3144007 on 2016/09/28 by Dmitry.Rekman
Linux: Allow equals character in command line parameter value (UE-26406).
- PR #2019 by bozzaro.
- Allows passing parameters like -Switch=Key=Value.
Change 3144042 on 2016/09/28 by Jeff.Campeau
Add tag for DX12 support being experimental in target settings.
#jira UE-36150
Change 3144068 on 2016/09/28 by Dmitry.Rekman
Linux: enable using xgConsole in UAT (UE-28096).
- PR #2144 by bozzaro.
- Picks correct xgConsole binary.
- Allegedly fixes crash in CombineXGEItemFile on mono.
Change 3144120 on 2016/09/28 by Michael.Trepka
Copying //Tasks/UE4/Dev-HighDPI/... to //UE4/Dev-Platform/...
Change 3144172 on 2016/09/28 by Chris.Babcock
Add libpng 1.5.27 for Android
#jira UE-36573
#ue4
#android
Change 3144318 on 2016/09/28 by Chris.Babcock
Correct logic for checking .bashrc on Linux
#ue4
#android
Change 3144331 on 2016/09/28 by Dmitry.Rekman
Linux: repair ARM server builds.
- Also: print info about C++ library being used and allow the override via environment variable UE4_LINUX_USE_LIBCXX (either 0 or 1).
Change 3144354 on 2016/09/28 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
this is intermediate, not fully working
Change 3144368 on 2016/09/28 by Josh.Adams
- Moved the new Social files into NFL
Change 3144395 on 2016/09/28 by Chris.Babcock
Add missing functions for AndroidWebBrowserWindow
#ue4
#android
Change 3144417 on 2016/09/28 by Josh.Adams
- Probable fix for FWebBrowserWindow missing virtuals
Change 3144438 on 2016/09/28 by Jeff.Campeau
XDK updated to 160802
Change 3144569 on 2016/09/29 by Dmitry.Rekman
Linux: allow a selectable clock source (UE-36564).
- The engine will now select the best performing clock on start instead of hard-coding CLOCK_REALTIME. This will happen as part of global initialization before main() to prevent clock skew.
- Also fixes a problem of the engine not being able to start on Windows 10 since previously hard-coded clock id was not supported there.
#tests Compiled and ran a few targets (including non-monolithic). Tried bogus clock sources. Haven't actually tried on Win10 (don't have a machine atm).
Change 3145108 on 2016/09/29 by Joe.Graf
Fixed cases where path relative external plugin paths would generate the wrong path when running Unreal Header Tool (and probably other tools)
Change 3145245 on 2016/09/29 by Joe.Graf
#wolf
Checking in removal of plugin use on Win64 per Josh's request
Change 3145514 on 2016/09/29 by Will.Fissler
Updated Mac Info.plist files to disable high DPI on macOS 10.12
Change 3145538 on 2016/09/29 by Josh.Adams
- Worked around a physics task graph issue with using the new lock free stuff on Wolf, joining PS4 and XboxOne. Wolf was crashing on some boots.
Change 3145540 on 2016/09/29 by Josh.Adams
- Fix for checking some Wolf dev tool installation existence
- Fix for various Wolf build issues
- Fix for Wolf devices not showing up in Launch on
Change 3145542 on 2016/09/29 by Josh.Adams
- Pulled over Wolf changes from Wolf branch into Dev-Platform
Change 3145572 on 2016/09/29 by Josh.Adams
- Cleaned up Wolf SDK error logs which really messed up GenProjectFiles for some class of people.
#jira UE-36591
Change 3145769 on 2016/09/29 by Chris.Babcock
Remove duplicate platforms from deploy list in UFE
#jira UE-36636
#ue4
Change 3146061 on 2016/09/29 by Chris.Babcock
Linux: be less spammy in log when launching external procs
#jira UE-36638
#ue4
#linux
Change 3146208 on 2016/09/29 by Dmitry.Rekman
Linux: fix PhysX crash (UE-36613).
- PX_RESTRICT was unwarrantedly applied to memMove, allowing clang to replace the memmove() call to memcpy() at -O2 and above.
- This caused PxArray::remove() to duplicate the elements of its array (in POD case) and this opened doors to all kinds of fun.
#jira UE-36613
Change 3146476 on 2016/09/30 by Josh.Adams
- Moved a UBT log that could pollute QA logs with Wolf secrets to Verbose
Change 3146554 on 2016/09/30 by Josh.Adams
- Removed another wolf secret log
Change 3146626 on 2016/09/30 by Josh.Adams
Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform)
Change 3146712 on 2016/09/30 by Josh.Adams
- Fixed case for building Android on Linux
#jira #UE-36652
Change 3146844 on 2016/09/30 by Josh.Adams
- Removed ES2 shader compiling from TVOS, and force Metal compiling
#jira UE-36306
Change 3146865 on 2016/09/30 by Daniel.Lamb
Removed temp logging for materials
#test Launch on paragon
Change 3146874 on 2016/09/30 by Dmitry.Rekman
Linux: add rpath for libTextureConverter.so (UE-36620).
Change 3147030 on 2016/09/30 by Josh.Adams
- Version check workaround for IOS9.3/TVOS9.2 defining __IPHONE_10_0 which breaks our IOS10 code checks
#jira UE-36623
Change 3147151 on 2016/09/30 by Josh.Adams
- Fixed zlib.build.cs for XboxOne, which came in from another branch without an include path, yet somehow main is compiling?
Change 3147621 on 2016/09/30 by Michael.Trepka
Fix for setting up RPATHs for third party dylibs for packaged code-based games on Mac
Change 3147712 on 2016/09/30 by Josh.Adams
- Fixed metal crash StrategyGame crash. Recent code was checking IsES2Platform for HDR decoding in scene capture, and Metal hasn't been IsES2 since may. Changed to IsMobilePlatform.
#jira UE-36225
Change 3147725 on 2016/09/30 by Josh.Adams
- Fixed yet another Wolf log for people with Wolf access but no SDK
[CL 3147801 by Josh Adams in Main branch]
Marc Audy
allan bentham
Rolando Caloca
Juan Canada
ryan durand
Marcus Wassmer
Ben Marsh
projectgheist
Chris Babcock
Luke Thatcher
Josh Adams