izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fixed a divide by 0 crash from the slow task dialog.

Browse Source 
#TTP 338368 - EDITOR: CRASH: Div by zero in FFeedbackContextEditor::UpdateProgress() called from FSimplygonMeshReduction

#branch UE4

#proj Editor.UnrealEd

#change Defaulted the Saved and New Ratios to 0, then tested the divisors for > 0. Added an ensure onto the passed in devisors check, if the user is passing in 0 they should be notified as they are using the interface wrong.

#reviewedby Chris.Wood

[CL 2119580 by Barnabas McManners in Main branch]
This commit is contained in:
Barnabas McManners
2014-06-27 11:48:07 -04:00
committed by UnrealBot
parent d4529e29cb
commit fdd86b2ee6
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Engine/Source/Editor/UnrealEd/Private/FeedbackContextEditor.cpp
View File

@@ -439,8 +439,20 @@ void FFeedbackContextEditor::UpdateProgress( int32 Numerator, int32 Denominator
if( StatusMessageStack.Num() <= 1 || bCanCancelTask)
{
// calculate our previous percentage and our new one
float SavedRatio = (float)StatusMessage.SavedNumerator / (float)StatusMessage.SavedDenominator;
float NewRatio = (float)StatusMessage.ProgressNumerator / (float)StatusMessage.ProgressDenominator;
float SavedRatio = 0.0f;
float NewRatio = 0.0f;
// Check divisors to guard against divide by zeros
if ( StatusMessage.SavedDenominator > 0 )
{
SavedRatio = (float)StatusMessage.SavedNumerator / (float)StatusMessage.SavedDenominator;
}
if ( ensure(StatusMessage.ProgressDenominator > 0) )
{
NewRatio = (float)StatusMessage.ProgressNumerator / (float)StatusMessage.ProgressDenominator;
}
double Now = FPlatformTime::Seconds();
// update the progress bar if we've moved enough since last time, or we are going to start or end of bar,