izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

REL - reduce allocation pressure during local queue un/registration

Browse Source 
#preflight 61d36696af44b43628f4985a

#ROBOMERGE-AUTHOR: arne.schober
#ROBOMERGE-SOURCE: CL 18504017 in //UE5/Release-5.0/... via CL 18504091
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18504126 by arne schober in ue5-release-engine-test branch]
This commit is contained in:
arne schober
2022-01-03 17:27:09 -05:00
parent af6c63c403
commit 75a0127272
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Engine/Source/Runtime/Core/Public/Async/Fundamental/LocalQueue.h
+5 -10
View File
@@ -221,10 +221,6 @@ private:
TArray<TLocalQueue*, TInlineAllocator<32>> LocalQueues;
TLocalQueue* RemovedQueue = nullptr;
FLocalQueueCollection(FLocalQueueCollection* Previous) : LocalQueues(Previous->LocalQueues)
{
}
FLocalQueueCollection() = default;
~FLocalQueueCollection()
@@ -408,14 +404,14 @@ private:
NumActiveWorkers[QueueType == ELocalQueueType::EBackground].fetch_add(1, std::memory_order_relaxed);
}
FLocalQueueCollection* Copy = new FLocalQueueCollection();
while(true)
{
FLocalQueueCollection* Previous = Hazard.Get();
FLocalQueueCollection* Copy = new FLocalQueueCollection(Previous);
Copy->LocalQueues = Previous->LocalQueues;
Copy->LocalQueues.Add(QueueToAdd);
if (!QueueCollection.compare_exchange_strong(Previous, Copy, std::memory_order_release, std::memory_order_relaxed))
{
delete Copy;
continue;
}
HazardsCollection.Delete(Previous);
@@ -432,15 +428,14 @@ private:
NumActiveWorkers[QueueType == ELocalQueueType::EBackground].fetch_sub(1, std::memory_order_relaxed);
}
FLocalQueueCollection* Copy = new FLocalQueueCollection();
while(true)
{
FLocalQueueCollection* Previous = Hazard.Get();
FLocalQueueCollection* Copy = new FLocalQueueCollection(Previous);
int NumRemoved = Copy->LocalQueues.Remove(QueueToRemove);
checkSlow(NumRemoved == 1);
Copy->LocalQueues = Previous->LocalQueues;
verifySlow(Copy->LocalQueues.Remove(QueueToRemove) == 1);
if (!QueueCollection.compare_exchange_strong(Previous, Copy, std::memory_order_release, std::memory_order_relaxed))
{
delete Copy;
continue;
}
if (!WorkerOwned)