izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Gameplay Tag Manager: Adjusted the loop in "UGameplayTagsManager::StaticGetCategoriesMetaFromPropertyHandle" to break early if the outer base class of a child property and its parent are of a different type. This helps us avoid situations where a suboject's gameplay tag property may inherit meta categories from a different class it didn't expect and cause unintented restrictions on the child tag property.

Browse Source 
#rb ben.zeigler
[FYI] parker.linn, luciano.ferraro, natalia.miekina, bill.colby
#tests 28.20 editor

[CL 30595539 by gabriel pereyra in ue5-main branch]
This commit is contained in:
gabriel pereyra
2024-01-12 11:56:25 -05:00
parent d5bc7391ec
commit 672abfa17f
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Engine/Source/Runtime/GameplayTags/Private/GameplayTagsManager.cpp
View File

@@ -1584,7 +1584,20 @@ FString UGameplayTagsManager::StaticGetCategoriesMetaFromPropertyHandle(TSharedP
}
}
}
PropertyHandle = PropertyHandle->GetParentHandle();
TSharedPtr<IPropertyHandle> ParentHandle = PropertyHandle->GetParentHandle();
if (ParentHandle.IsValid())
{
/** Check if the parent handle's base class is of the same class. It's possible the current child property is from a subobject which in that case we probably want to ignore
* any meta category restrictions coming from any parent properties. A subobject's gameplay tag property without any declared meta categories should stay that way. */
if (PropertyHandle->GetOuterBaseClass() != ParentHandle->GetOuterBaseClass())
{
break;
}
}
PropertyHandle = ParentHandle;
}
return Categories;