izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Horde: Disable bisection in prod

Browse Source 
#jira none
#skipci
#rnx

[CL 28238935 by Josh Engebretson in ue5-main branch]
This commit is contained in:
Josh Engebretson
2023-09-26 14:23:12 -04:00
parent 34ab5bab28
commit 63997995a4
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Engine/Source/Programs/Horde/HordeDashboard/src/components/jobDetailsV2/JobOperationsBar.tsx
View File

@@ -17,6 +17,7 @@ import { BisectionCreateModal } from '../bisection/CreateModal';
import { AbortJobModal } from './AbortJobModal';
import { JobDetailsV2 } from './JobDetailsViewCommon';
import { RetryStepsModal, StepRetryModal, StepRetryType } from './StepRetryModal';
import { getSiteConfig } from '../../backend/Config';
enum ParameterState {
Hidden,
@@ -207,7 +208,7 @@ export const JobOperations: React.FC<{ jobDetails: JobDetailsV2 }> = observer(({
const StepArtifactsOperations: React.FC<{ jobDetails: JobDetailsV2, stepId: string }> = observer(({ jobDetails, stepId }) => {
const navigate = useNavigate();
const query = useQuery();
@@ -280,7 +281,7 @@ const StepArtifactsOperations: React.FC<{ jobDetails: JobDetailsV2, stepId: stri
];
return <Stack>
{!!artifactContext && <JobArtifactsModal stepId={step.id} jobId={jobDetails.jobId!} contextType={artifactContext} artifactPath={artifactPath} artifacts={stepArtifacts} onClose={() => { navigate(window.location.pathname + `?step=${stepId}`, { replace: true }) }} />}
{!!artifactContext && <JobArtifactsModal stepId={step.id} jobId={jobDetails.jobId!} contextType={artifactContext} artifactPath={artifactPath} artifacts={stepArtifacts} onClose={() => { navigate(window.location.pathname + `?step=${stepId}`, { replace: true }) }} />}
<Stack horizontal styles={{ root: { paddingLeft: 0 } }}>
<Stack grow />
<Stack horizontal>
@@ -299,7 +300,7 @@ const StepArtifactsOperations: React.FC<{ jobDetails: JobDetailsV2, stepId: stri
const StepOperations: React.FC<{ jobDetails: JobDetailsV2, stepId: string }> = observer(({ jobDetails, stepId }) => {
const [shown, setShown] = useState<{ abortShown?: boolean, retryShown?: boolean, pauseShown?: boolean, bisectShown?: boolean }>({});
const [runType, setRunType] = useState(StepRetryType.RunAgain);
const [runType, setRunType] = useState(StepRetryType.RunAgain);
// subscribe
if (dashboard.updated) { }
@@ -321,7 +322,11 @@ const StepOperations: React.FC<{ jobDetails: JobDetailsV2, stepId: string }> = o
const canRunDisabled = !node?.allowRetry || !!step.retriedByUserInfo;
const canTryFix = jobDetails.template?.allowPreflights;
const canBisect = (step.outcome === JobStepOutcome.Failure || step.outcome === JobStepOutcome.Warnings) && !!jobDetails.template?.allowPreflights;
let canBisect = (step.outcome === JobStepOutcome.Failure || step.outcome === JobStepOutcome.Warnings) && !!jobDetails.template?.allowPreflights;
if (getSiteConfig().environment === "production") {
canBisect = false;
}
const opsList: IContextualMenuItem[] = [];
@@ -425,7 +430,7 @@ const StepOperations: React.FC<{ jobDetails: JobDetailsV2, stepId: string }> = o
{!!shown.abortShown && <AbortJobModal stepId={stepId} jobDetails={jobDetails} show={true} onClose={() => { setShown({}); }} />}
{!!shown.bisectShown && <BisectionCreateModal jobId={jobId} nodeName={node?.name ?? "Unknown Node"} onClose={(response) => {
if (response) {
jobDetails.bisectionUpdated();
jobDetails.bisectionUpdated();
}
setShown({});