izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Only create named events for MetaSound trace macro when stat namedevents is enabled

Browse Source 
#jira UE-214646
#rb ben.woodhouse, jordan.cristiano

[CL 33566163 by helen yang in ue5-main branch]
This commit is contained in:
helen yang
2024-05-09 20:35:04 -04:00
parent d5e37c6e82
commit 4ab50fcc7a
2 changed files with 47 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Engine/Plugins/Runtime/Metasound/Source/MetasoundGraphCore/Public/MetasoundTrace.h
View File

@@ -19,15 +19,16 @@
// Copied from SCOPED_NAMED_EVENT but modified
// to accommodate event names containing ::
#define METASOUND_TRACE_CPUPROFILER_EVENT_SCOPE(Name)\
FScopedNamedEventStatic PREPROCESSOR_JOIN(MetaSound_NamedEvent_,__LINE__)(FColor::Green, NAMED_EVENT_STR(#Name));\
FScopedNamedEventConditionalStatic PREPROCESSOR_JOIN(MetaSound_NamedEvent_,__LINE__)(FColor::Green, NAMED_EVENT_STR(#Name), GCycleStatsShouldEmitNamedEvents > 0);\
TRACE_CPUPROFILER_EVENT_SCOPE(Name);
#define METASOUND_TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(Name) \
SCOPED_NAMED_EVENT_TCHAR(Name, FColor::Green)
FScopedNamedEventConditional ANONYMOUS_VARIABLE(NamedEvent_)(FColor::Green, Name, GCycleStatsShouldEmitNamedEvents > 0);\
TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(Name);
// Uses cached Insights SpecId to avoid string lookup
#define METASOUND_TRACE_CPUPROFILER_EVENT_SCOPE_FAST(TraceSpecId, Name) \
FScopedNamedEvent ANONYMOUS_VARIABLE(NamedEvent_)(FColor::Green, Name);\
FScopedNamedEventConditional ANONYMOUS_VARIABLE(NamedEvent_)(FColor::Green, Name, GCycleStatsShouldEmitNamedEvents > 0);\
TRACE_CPUPROFILER_EVENT_SCOPE_USE(TraceSpecId, Name, PREPROCESSOR_JOIN(MetaSound_NamedEventScope_, __LINE__), true)
#else

43
Engine/Source/Runtime/Core/Public/HAL/PlatformMisc.h
View File

@@ -129,6 +129,49 @@ public:
}
};
// Conditional version of FScopedNamedEventStatic
class FScopedNamedEventConditionalStatic
{
public:
FScopedNamedEventConditionalStatic(const struct FColor& Color, const TCHAR* Text, bool bCondition)
: bStarted(bCondition)
{
if (bCondition)
{
#if PLATFORM_IMPLEMENTS_BeginNamedEventStatic
FPlatformMisc::BeginNamedEventStatic(Color, Text);
#else
FPlatformMisc::BeginNamedEvent(Color, Text);
#endif
}
}
FScopedNamedEventConditionalStatic(const struct FColor& Color, const ANSICHAR* Text, bool bCondition)
: bStarted(bCondition)
{
if (bCondition)
{
#if PLATFORM_IMPLEMENTS_BeginNamedEventStatic
FPlatformMisc::BeginNamedEventStatic(Color, Text);
#else
FPlatformMisc::BeginNamedEvent(Color, Text);
#endif
}
}
~FScopedNamedEventConditionalStatic()
{
if (bStarted)
{
FPlatformMisc::EndNamedEvent();
}
}
private:
bool bStarted;
};
// Lightweight scoped named event separate from stats system. Will be available in test builds.
// Events cost profiling overhead so use them judiciously in final code.