Engine/Source/Editor/PropertyEditor/Private/DetailsViewConfig.cpp

// Copyright Epic Games, Inc. All Rights Reserved.

#include "DetailsViewConfig.h"

#include "UObject/ObjectPtr.h"

TObjectPtr<UDetailsConfig> UDetailsConfig::Instance = nullptr;

void UDetailsConfig::Initialize()
{
	if (Instance == nullptr)
	{
		Instance = NewObject<UDetailsConfig>();
		Instance->AddToRoot();
	}
}

UDetailsConfig* UDetailsConfig::Get()
{
	return Instance;
}
Editor configs now correctly diff against the CDO when serializing. Previously, I had assumed that FProperty::InitializeValue() would initialize a simple member (eg. a float) to the correct value, but this appears not to be the case, rather values are zero-initialized and the CDO stores the correct default values. In the case of structs, InitializeStruct() does in fact initialize correctly. However, this means that we can't use GetMutableDefault() to get an instance of the UObject, since then we're changing what we're diffing against and serialize no values. Changed the usages of this pattern to use singletons instead. #jira UE-141150 #review-19900014 @lauren.barnes, @aditya.ravichandran #preflight 6267fa44a021c91a50f26a65 [CL 19919719 by sebastian nordgren in ue5-main branch] 2022-04-26 10:20:56 -04:00			`// Copyright Epic Games, Inc. All Rights Reserved.`

			`#include "DetailsViewConfig.h"`

IWYU Pass 1 - Engine/Source/Editor/... #jira #preflight 6306736ac85b7fef22be7751 [CL 21558583 by bryan sefcik in ue5-main branch] 2022-08-24 22:45:13 -04:00			`#include "UObject/ObjectPtr.h"`

Editor configs now correctly diff against the CDO when serializing. Previously, I had assumed that FProperty::InitializeValue() would initialize a simple member (eg. a float) to the correct value, but this appears not to be the case, rather values are zero-initialized and the CDO stores the correct default values. In the case of structs, InitializeStruct() does in fact initialize correctly. However, this means that we can't use GetMutableDefault() to get an instance of the UObject, since then we're changing what we're diffing against and serialize no values. Changed the usages of this pattern to use singletons instead. #jira UE-141150 #review-19900014 @lauren.barnes, @aditya.ravichandran #preflight 6267fa44a021c91a50f26a65 [CL 19919719 by sebastian nordgren in ue5-main branch] 2022-04-26 10:20:56 -04:00			`TObjectPtr<UDetailsConfig> UDetailsConfig::Instance = nullptr;`

			`void UDetailsConfig::Initialize()`
			`{`
			`if (Instance == nullptr)`
			`{`
			`Instance = NewObject<UDetailsConfig>();`
			`Instance->AddToRoot();`
			`}`
			`}`

			`UDetailsConfig* UDetailsConfig::Get()`
			`{`
			`return Instance;`
			`}`