Files
UnrealEngineUWP/Engine/Source/Editor/DetailCustomizations/Private/SkeletalMeshComponentDetails.cpp

413 lines
14 KiB
C++
Raw Normal View History

// Copyright 1998-2017 Epic Games, Inc. All Rights Reserved.
#include "SkeletalMeshComponentDetails.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "Modules/ModuleManager.h"
#include "Widgets/SBoxPanel.h"
#include "Widgets/Layout/SBorder.h"
#include "Widgets/Text/STextBlock.h"
#include "Widgets/Layout/SBox.h"
#include "Widgets/Input/SComboButton.h"
#include "EditorStyleSet.h"
#include "Animation/AnimInstance.h"
#include "Animation/AnimBlueprint.h"
#include "Editor.h"
#include "DetailLayoutBuilder.h"
#include "IDetailPropertyRow.h"
#include "DetailCategoryBuilder.h"
#include "PropertyCustomizationHelpers.h"
#include "ClassViewerModule.h"
#include "ClassViewerFilter.h"
#include "Engine/Selection.h"
#include "Animation/AnimBlueprintGeneratedClass.h"
#define LOCTEXT_NAMESPACE "SkeletalMeshComponentDetails"
// Filter class for animation blueprint picker
class FAnimBlueprintFilter : public IClassViewerFilter
{
public:
virtual bool IsClassAllowed(const FClassViewerInitializationOptions& InInitOptions, const UClass* InClass, TSharedRef< class FClassViewerFilterFuncs > InFilterFuncs ) override
{
if(InFilterFuncs->IfInChildOfClassesSet(AllowedChildrenOfClasses, InClass) != EFilterReturn::Failed)
{
return true;
}
return false;
}
virtual bool IsUnloadedClassAllowed(const FClassViewerInitializationOptions& InInitOptions, const TSharedRef< const class IUnloadedBlueprintData > InUnloadedClassData, TSharedRef< class FClassViewerFilterFuncs > InFilterFuncs) override
{
return InFilterFuncs->IfInChildOfClassesSet(AllowedChildrenOfClasses, InUnloadedClassData) != EFilterReturn::Failed;
}
/** Only children of the classes in this set will be unfiltered */
TSet<const UClass*> AllowedChildrenOfClasses;
};
FSkeletalMeshComponentDetails::FSkeletalMeshComponentDetails()
: CurrentDetailBuilder(NULL)
{
}
FSkeletalMeshComponentDetails::~FSkeletalMeshComponentDetails()
{
UnregisterAllMeshPropertyChangedCallers();
}
TSharedRef<IDetailCustomization> FSkeletalMeshComponentDetails::MakeInstance()
{
return MakeShareable(new FSkeletalMeshComponentDetails);
}
void FSkeletalMeshComponentDetails::CustomizeDetails(IDetailLayoutBuilder& DetailBuilder)
{
if(!CurrentDetailBuilder)
{
CurrentDetailBuilder = &DetailBuilder;
}
DetailBuilder.EditCategory("SkeletalMesh", FText::GetEmpty(), ECategoryPriority::TypeSpecific);
DetailBuilder.EditCategory("Materials", FText::GetEmpty(), ECategoryPriority::TypeSpecific);
DetailBuilder.EditCategory("Physics", FText::GetEmpty(), ECategoryPriority::TypeSpecific);
DetailBuilder.HideProperty("bCastStaticShadow", UPrimitiveComponent::StaticClass());
DetailBuilder.HideProperty("bLightAsIfStatic", UPrimitiveComponent::StaticClass());
DetailBuilder.EditCategory("Animation", FText::GetEmpty(), ECategoryPriority::Important);
OnSkeletalMeshPropertyChanged = USkeletalMeshComponent::FOnSkeletalMeshPropertyChanged::CreateSP(this, &FSkeletalMeshComponentDetails::SkeletalMeshPropertyChanged);
UpdateAnimationCategory(DetailBuilder);
}
void FSkeletalMeshComponentDetails::UpdateAnimationCategory( IDetailLayoutBuilder& DetailBuilder )
{
// Grab the objects we're editing so we can filter the skeleton when we need to change the animation.
// Cache them for updates later if the mesh/skeleton changes
DetailBuilder.GetObjectsBeingCustomized(SelectedObjects);
check(SelectedObjects.Num() > 0);
// Check for incompatible (different) skeletons. This can happen when the user selects more than
// one object in the viewport. If this happens we disable and hide the anim selection picker
USkeleton* Skeleton = NULL;
for(auto ObjectIter = SelectedObjects.CreateIterator() ; ObjectIter ; ++ObjectIter)
{
if(USkeletalMeshComponent* Mesh = Cast<USkeletalMeshComponent>(ObjectIter->Get()))
{
RegisterSkeletalMeshPropertyChanged(Mesh);
if(Mesh->SkeletalMesh)
{
if(!Skeleton)
{
Skeleton = Mesh->SkeletalMesh->Skeleton;
}
else if(Mesh->SkeletalMesh->Skeleton != Skeleton)
{
// There's an incompatible skeleton in the selection, stop checking
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
bAnimPickerEnabled = false;
break;
}
}
}
}
if(!Skeleton)
{
// No valid skeleton in selection, treat as invalid
SelectedSkeletonName = "";
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
bAnimPickerEnabled = false;
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
if(bAnimPickerEnabled)
{
// If we're showing the animation asset then we have a valid skeleton
SelectedSkeletonName = FString::Printf(TEXT("%s'%s'"), *Skeleton->GetClass()->GetName(), *Skeleton->GetPathName());
}
IDetailCategoryBuilder& AnimationCategory = DetailBuilder.EditCategory("Animation", FText::GetEmpty(), ECategoryPriority::Important);
// Force the mode switcher to be first
AnimationModeHandle = DetailBuilder.GetProperty(GET_MEMBER_NAME_CHECKED(USkeletalMeshComponent, AnimationMode));
check (AnimationModeHandle->IsValidHandle());
Copying //UE4/Dev-Blueprints to Dev-Main (//UE4/Dev-Main) @ 2781164 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2716841 on 2015/10/05 by Mike.Beach (WIP) Cleaning up how we setup script assets for replacement on cook (aligning more with the Blueprint conversion tool). #codereview Maciej.Mroz Change 2719089 on 2015/10/07 by Maciej.Mroz ToValidCPPIdentifierChars handles propertly '?' char. #codereview Dan.Oconnor Change 2719361 on 2015/10/07 by Maciej.Mroz Generated native code for AnimBPGC - some preliminary changes. Refactor: UAnimBlueprintGeneratedClass is not accessed directly in runtime. It is accessed via UAnimClassInterface interface. Properties USkeletalMeshComponent::AnimBlueprintGeneratedClass and UInterpTrackFloatAnimBPParam::AnimBlueprintClass were changed into "TSubclassOf<UAnimInstance> AnimClass" The UDynamicClass also can deliver the IAnimClassInterface interface. See UAnimClassData, IAnimClassInterface::GetFromClass and UDynamicClass::AnimClassImplementation. #codereview Lina.Halper, Thomas.Sarkanen Change 2719383 on 2015/10/07 by Maciej.Mroz Debug-only code removed Change 2720528 on 2015/10/07 by Dan.Oconnor Fix for determinsitc cooking of async tasks and load asset nodes #codereview Mike.Beach, Maciej.Mroz Change 2721273 on 2015/10/08 by Maciej.Mroz Blueprint Compiler Cpp Backend - Anim Blueprints can be converted - Various fixes/improvements Change 2721310 on 2015/10/08 by Maciej.Mroz refactor (cl#2719361) - no "auto" keyword Change 2721727 on 2015/10/08 by Mike.Beach (WIP) Setup the cook commandlet so it handles converted assets, replacing them with generated classes. - Refactored the conversion manifest (using a map over an array) - Centralized destination paths into a helper struct (for the manifest) - Generating an Editor module that automatically hooks into the cook process when enabled - Loading and applying native replacments for the cook Change 2723276 on 2015/10/09 by Michael.Schoell Blueprints duplicated for PIE will no longer register as dependencies to other Blueprint. #jira UE-16695 - Editor freezes then crashes while attempting to save during PIE #jira UE-21614 - [CrashReport] Crash while saving during PIE - FKismetEditorUtilities::CompileBlueprint() kismet2.cpp:736 Change 2724345 on 2015/10/11 by Ben.Cosh Blueprint profiler at first pass, this includes the ability to instrument specific blueprints with realtime editor stat display. #UEBP-21 - Profiling data capture and storage #UEBP-13 - Performance capture landing page #Branch UE4 #Proj BlueprintProfiler, BlueprintGraph, EditorStyle, Kismet, UnrealEd, CoreUObject, Engine Change 2724613 on 2015/10/12 by Ben.Cosh Incremental update for blueprint profiler to fix the way some of the reported stats cascade through events and branches and additionally some missed bits of code are refactored/removed. #Branch UE4 #Proj BlueprintProfiler #info Whilst looking into this I spotted the reason why the stats seem so erratic, There appears to be an issue with FText's use of EXPERIMENTAL_TEXT_FAST_DECIMAL_FORMAT which I have reported, but ideally disable this locally until a fix is integrated. Change 2724723 on 2015/10/12 by Maciej.Mroz Constructor of a dynamic class creates CDO. #codereview Robert.Manuszewski Change 2725108 on 2015/10/12 by Mike.Beach [UE-21891] Minor fix to the array shuffle() function; now processes the last entry like all the others. Change 2726358 on 2015/10/13 by Maciej.Mroz UDataTable is properly saved even if its RowStruct is null. https://udn.unrealengine.com/questions/264064/crash-using-hotreload-in-custom-datatable-cdo-clas.html Change 2727395 on 2015/10/13 by Mike.Beach (WIP) Second pass on the Blueprint conversion pipeline; setting it up for more optimal (speedier) performance. * Using stubs for replacements (rather than loading dynamic replacement). * Giving the cook commandlet more control (so a conversion could be ran directly). * Now logging replacements by old object path (to account for UPackage replacement queries). * Fix for [UE-21947], unshelved from CL 2724944 (by Maciej.Mroz). #codereview Maciej.Mroz Change 2727484 on 2015/10/13 by Mike.Beach [UE-22008] Fixing up comment/tooltip typo for UActorComponent::bAutoActivate. Change 2727527 on 2015/10/13 by Mike.Beach Downgrading an inactionable EdGraph warning, while adding more info so we could possibly determine what's happening. Change 2727702 on 2015/10/13 by Dan.Oconnor Fix for crash in UDelegateProperty::GetCPPType when called on a function with no OwnerClass (events) Change 2727968 on 2015/10/14 by Maciej.Mroz Since ConstructorHelpers::FClassFinder is usually static, the loaded class should be in root set, to prevent the pointer stored in ConstructorHelpers::FClassFinder from being obsolete. FindOrLoadClass behaves now like FindOrLoadObject. #codereview Robert.Manuszewski, Nick.Whiting Change 2728139 on 2015/10/14 by Phillip.Kavan
2015-11-25 18:47:20 -05:00
AnimationBlueprintHandle = DetailBuilder.GetProperty(GET_MEMBER_NAME_CHECKED(USkeletalMeshComponent, AnimClass));
check(AnimationBlueprintHandle->IsValidHandle());
AnimationCategory.AddProperty(AnimationModeHandle);
// Place the blueprint property next (which may be hidden, depending on the mode)
TAttribute<EVisibility> BlueprintVisibility( this, &FSkeletalMeshComponentDetails::VisibilityForBlueprintMode );
DetailBuilder.HideProperty(AnimationBlueprintHandle);
AnimationCategory.AddCustomRow(AnimationBlueprintHandle->GetPropertyDisplayName())
.Visibility(BlueprintVisibility)
.NameContent()
[
AnimationBlueprintHandle->CreatePropertyNameWidget()
]
.ValueContent()
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3379190) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3342222 on 2017/03/10 by Nick.Darnell UMG - Adding a GetContent to the UContentWidget. Change 3342228 on 2017/03/10 by Nick.Darnell Project Launcher - Always consume mouse wheel vertically so it stops scrolling to the right. Change 3342310 on 2017/03/10 by Nick.Darnell UMG - Cleaning up some extra class references. Change 3343382 on 2017/03/13 by Jamie.Dale Applying optimization to FChunkManifestGenerator::ContainsMap Change 3343523 on 2017/03/13 by Mike.Fricker New details view option: "Show Hidden Properties while Playing" - Enabling this allows you to see every property on selected objects that belong to a simulating world, even non-visible and non-editable properties. Very useful for inspection and debugging. - Remember to change World Outliner to show you actors in the "Play World" if you want to select and inspect those objects first! - This setting is saved for your entire project, similar to "Show All Advanced" Change 3343573 on 2017/03/13 by Mike.Fricker New details view option: "Show Hidden Properties while Playing" (part 2) - Fixed missing include / unity issue Change 3343709 on 2017/03/13 by Jamie.Dale Some fixes for gathering cached dependency data - We no longer load dependency data that doesn't have the correct package name. - We no longer populate the dependency results when bGatherDependsData is false. Change 3343900 on 2017/03/13 by Alexis.Matte fix crash when creating too much LOD at import #jira UE-42785 Change 3344104 on 2017/03/13 by Alexis.Matte Add a boolean to the static mesh socket so we know if the socket was imported or created in UE4. This allow us to not impact editor socket when we re-import a fbx #jira UE-42736 Change 3344802 on 2017/03/14 by Michael.Dupuis #jira UE-42244 : added missing nullptr so render thread wont try to access global var when we're no longer in landscape mode Changed the sync method between graphic resource from render thread and game thread to prevent desync Change 3346061 on 2017/03/14 by Jamie.Dale Adding const& and && overloads of FText::Format Change 3346192 on 2017/03/14 by Arciel.Rekman Linux: fix VHACD to retain bincompat with the baseline (UE-42895). - It is now compiled against libc++ instead of libstdc++ in the toolchain. Change 3347083 on 2017/03/15 by Andrew.Rodham Fixed crash when changing anchors on a background blur widget Change 3347359 on 2017/03/15 by Michael.Dupuis #jira UE-38193: Added Rename, Delete, New Folder, Size Map, Show In Explorer for folder and asset in the path view and asset view Change 3347382 on 2017/03/15 by Michael.Dupuis missing include incremental Change 3347500 on 2017/03/15 by Alex.Delesky #jira UE-41231 - Selecting multiple text widgets in UMG will now allow you to set their value correctly, and the "Multiple Values" text will no longer be set in the widgets instead. Change 3347920 on 2017/03/15 by Jamie.Dale Fixing some places passing tooltips as FString rather than FText #jira UE-42603 Change 3347925 on 2017/03/15 by Jamie.Dale Re-saving some assets so their tooltips can be gathered #jira UE-42603 Change 3348788 on 2017/03/15 by Jamie.Dale Updated the Windows platform to use the newer Vista+ style browser dialogs, rather than the older XP style dialogs Change 3349187 on 2017/03/16 by Andrew.Rodham Sequencer: Added the ability to specify additional event receivers for level sequence actors - Such actors will receive events from event tracks Change 3349194 on 2017/03/16 by Andrew.Rodham Sequencer: Reset compiled templates on load in the editor, and ensure correct serialization of generation ledger - Resetting on load means that we guarantee up-to-date templates, even if underlying compilation logic changes. #jira UE-42198 #jira UE-40969 Change 3349210 on 2017/03/16 by Andrew.Rodham Sequencer: Event tracks can now be defined to trigger events at the start of evaluation, after objects are spawned, or at the end of evaluation Change 3349211 on 2017/03/16 by Andrew.Rodham Sequencer: Add ability to retrieve bound objects from blueprint Change 3349398 on 2017/03/16 by Nick.Darnell UMG - Fixing a flashing hierarchy view. Looks like assets continuing to stream in causing the object change notification to continue to fire, and the widget designer refreshed any time it happened. Now limit to only if widgets are changing. Change 3349420 on 2017/03/16 by Alex.Delesky #jira UE-40720 - Multiline editable text boxes can now be set to Read-Only. Change 3349548 on 2017/03/16 by Alexis.Matte Fbx importer, when importing a staticmesh with combine mesh option check and the fbx file contain some "MultiSub Material" the materialinstance are now always hook properly. Change 3349818 on 2017/03/16 by Cody.Albert Fixed constructor for FNavigationMetaData Change 3350047 on 2017/03/16 by Cody.Albert Removed unneeded check so that children actors are never orphaned when their parent is moved into a newly created folder in the world outliner Change 3350072 on 2017/03/16 by Arciel.Rekman ShaderCompiler: make sure strings are at least 4-byte aligned. - Can crash wcscpy() under Linux otherwise (reported by a licensee). Change 3350146 on 2017/03/16 by Arciel.Rekman Fix CodeLite project generation (UE-42921). - Reportedly causes a crash in CodeLite 10.x Change 3350235 on 2017/03/16 by Arciel.Rekman Fix memory leak in address symbolication on Linux. - Makes MallocProfiler work again. - Also add progress update in MallocProfiler since symbolication is still slow. Merging CL 3338764 from Fortnite to Dev-Editor. Change 3350382 on 2017/03/16 by Arciel.Rekman Linux: fix incorrect cast of rlimit in i686. Change 3350471 on 2017/03/16 by Jamie.Dale Enabling loc dashboard by default for new projects Change 3350516 on 2017/03/16 by Jamie.Dale Enabling content hot-reloading by default Change 3350582 on 2017/03/16 by Cody.Albert Corrected Widget Interaction Component to use current impact point instead of last impact point Change 3350945 on 2017/03/16 by Jamie.Dale Gave FConfigFile::FindOrAddSection API linkage Change 3351441 on 2017/03/17 by Michael.Dupuis #jira UE-42843: Fixed Transaction begin/end order issue happening with min slider passing max slider value Add support for multiple selection value display Change 3351558 on 2017/03/17 by Michael.Dupuis #jira UE-42845: Always refresh the detail panel to properly update for selection change, delete, etc. Change 3351657 on 2017/03/17 by Matt.Kuhlenschmidt Adding USD Third Party dependencies Change 3351665 on 2017/03/17 by Matt.Kuhlenschmidt Added experimental USD Importer Plugin This plugin supports basic static mesh importing and scene creation of actors using static meshes Change 3351682 on 2017/03/17 by Matt.Kuhlenschmidt Enabling USD importer in engine test project for automation tests Change 3351749 on 2017/03/17 by Alexis.Matte Make sure the selection proxy is off for the skeletal mesh component. UE4 use the selection outline instead #jira UE-41677 Change 3351831 on 2017/03/17 by Michael.Dupuis #jira UETOOL-1102: Added HSV controls to Color Grading Some look improvement for RGV/HSV Color Grading refactor Group Reset bug fix (relevant only to color grading) Change 3352041 on 2017/03/17 by Matt.Kuhlenschmidt Updated USD plugin whitelisting Change 3352093 on 2017/03/17 by Michael.Dupuis when FREEZERENDERING is called, stop the foliage culling too Change 3352211 on 2017/03/17 by Alexis.Matte Fix the physic asset missing skeleton warning #jira UE-43006 Change 3352336 on 2017/03/17 by Alexis.Matte We now allow a negative W value of the ScreenPoint vector in the ScreenToPixel function. In this case we simply reverse the W value to kept the manipulator direction on the good side. #jira UE-37458 Change 3352947 on 2017/03/17 by Phillip.Kavan #jira UE-42510 - Instanced static mesh transform edits are now reflected in the Blueprint editor's preview scene. Change summary: - Added IPropertyHandle::GetValueBaseAddress() (interface). - Modified IPropertyHandle::NotifyPostChange() to include EPropertyChangeType as an optional input. - Added FPropertyHandleBase::GetValueBaseAddress() (implementation). - Modified FPropertyHandleBase::NotifyPostChange() to include the optional input arg in the property change event. - Modified FPropertyHandleBase::CreatePropertyNameWidget() to clear the override text after temporarily replacing display name/tooltip text for the creation of the SPropertyNameWidget. This was done to allow for transactions to be named according to the property that's being modified. - Modified FMathStructProxyCustomization::OnValueCommitted() to only apply the input value while not interactively editing via spinbox as well as when not post-processing an undo/redo (which can trigger a focus loss). - Modified the FMathStructProxyCustomization::OnEndSliderMovement() delegate to include property handle and proxy value input parameters, as well as to call FlushValues() as part of the implementation. - Modified FlushValues() for each of FMatrixStructCustomization, FTransformStructCustomization and FQuatStructCustomization to explicitly handle both propagation and transaction processing. - Modified UInstancedStaticMeshComponent::UpdateInstanceTransform() to call Modify() prior to applying changes (so that the previous state is recorded when inside a transaction context). - Modified FInstanceStaticMeshSCSEditorCustomization::HandleViewportDrag() to propagate changes to all instances of the ISMC archetype. Known issues: - Using the spinbox to edit instanced mesh transform values in the Blueprint editor will not apply the change to instances in the level editor until after you release the mouse button (i.e. - it will not be shown as a "live" update). Change 3353678 on 2017/03/20 by Michael.Dupuis properly unfreeze the culling of foliage when toggling the freezerendering command Change 3353747 on 2017/03/20 by Matt.Kuhlenschmidt PR #3372: Git plugin: fix update status on directories hotfix (still) slightly broken in master (UE4.16) (Contributed by SRombauts) Change 3353749 on 2017/03/20 by Matt.Kuhlenschmidt PR #3373: Git Plugin: hotfix for regression off Visual Diffs with older version of Git in master (UE4.16) (Contributed by SRombauts) Change 3353754 on 2017/03/20 by Matt.Kuhlenschmidt PR #3390: Allow OBJ imports to change if materials and textures are also imported (Contributed by mmdanggg2) Change 3353909 on 2017/03/20 by Matt.Kuhlenschmidt Fixed actors showing thumbnails in details panel and made a few other tweeks to thumbnail displays in details panels - The color of the accepted type is now shown properly - All object based properties now have thumbnails on by default. Change 3353948 on 2017/03/20 by Nick.Darnell UMG - Updating the background blur widget's upgrade code to use the custom version, and handling older cases that were continuing to generate blur slots, even when already upgraded. Change 3354335 on 2017/03/20 by Nick.Darnell Paragon - Excluding Archetype objects from reporting references, which causes crashes in the fast template mode. Change 3354495 on 2017/03/20 by Nick.Darnell Core - Making it so order that outers are discovered does not matter, initializing the chain of outers if hasn't been created when instancing subobjects. Change 3354578 on 2017/03/20 by Nick.Darnell Slate - There's now a console variable option, Slate.VerifyHitTestVisibility (off by default) which enables additional visibility checks for widgets. Normally this isn't nessesary, but if you're changing the visibility of widgets during a frame, and several hit tests need to be performed that frame there's a chance that a button could be clicked twice in one frame. Enabling this mode will make all hit testing more expensive, so for now it's off by default, but available for licensees that need the extra testing. Change 3354737 on 2017/03/20 by Nick.Darnell Core - Adding a fix to Dev-Editor from that enables objects in the same package being requested to also be loaded. This came about during async streaming callbacks alerting that a requested class was done loading, but there were still other assets in the package 'not loaded' but were available, just needed post load called on them. Change 3355923 on 2017/03/21 by Yannick.Lange VR Editor: - Remove unnecessary cleanup functions. - Initialize with VR Mode and remove SetOwner function, since it shouldn't be possible to reset the VR Mode afterwards. Change 3355959 on 2017/03/21 by Yannick.Lange VR Editor: - Rename VREditorWorldInteraction to VREditorPlacement, to avoid confusion with ViewportWorldInteraction. VREditorPlacement will only handle placing objects from content browser in the VR Mode. - Removed SnapSelectedActorsToGround to VREditorMode. Change 3355965 on 2017/03/21 by Yannick.Lange VR Editor: Forgot to add files to previous submit 3355959. Change 3355977 on 2017/03/21 by Yannick.Lange VR Editor: Remove function to add a new extension with TSubclassOf<UEditorWorldExtension>. Change 3356017 on 2017/03/21 by Yannick.Lange VR Editor: - UI system check owner VRMode. - UI system fix check on VRMode on shutdown. Change 3356028 on 2017/03/21 by Nick.Darnell Slate - SButton now correctly releases mouse capture even if it becomes disabled while pressed, but before 'click' has been fired. #jira UE-42777 Change 3356071 on 2017/03/21 by Yannick.Lange VR Editor: Copy of change 3353663. - Fix having to press once on the landscape to see the visuals for landscape editing. - Fix when sculpting/painting the position wouldn't update. - Fix inverted action for brushes while holding down shift or modifier on motioncontroller. - Cleanup FLandscapeToolInteractorPosition. - Change from 3353663: Use TStrokeClass::UseContinuousApply and TimeSinceLastInteractorMove to decide when to apply ToolStroke on tick. Change 3356180 on 2017/03/21 by Michael.Dupuis Added ShowFlag Foliage Occlusion Bounds Fixed non initialized variable Expose changing Min Occlusion Bounds instead of assuming 6 #rn none Change 3356347 on 2017/03/21 by Nick.Darnell UMG - Introducing a faster CreateWidget. When cooking, the widget compiler now generates a widget template/archetype that is stored in the same package as the generated blueprint class. During compiling we generate a nearly fully initialized widget tree including all sub userwidgets and their trees, hookup all member variables, initialize named slots, setup any animations...etc. This nearly fully constructed widget can be instanced using it as an archetype in the NewObject call, and does not have to use the correspondingly slow StaticDuplicateObject path. There are restrictions on this method, part of the compiling step for widgets now inspects if the instancing would be successful, or if there would be GLEO references after instancing because a user forgot to setup Instanced on a subobject property. Luckily that should be few and far between, all UVisuals (Widgets & Slots) are now DefaultToInstanced, which takes care of the overwhelming cases that demand the instanced flag. Especially given the bulk of cases using BindWidget in native code. UMG - Removing a lot of deprecated functions from 4.8 on UUserWidget. Change 3356357 on 2017/03/21 by Nick.Darnell Build - Fixing some IWYU issues on the incremental build. Change 3356461 on 2017/03/21 by Nick.Darnell Build - Fixing linux build errors. Change 3356468 on 2017/03/21 by Jamie.Dale STextPropertyEditableTextBox now handles empty texts correctly Change 3356916 on 2017/03/21 by Matt.Kuhlenschmidt Fixed a crash when a material render proxy on a preview node is deleted when it is in flight on the render thread #jira UE-40556 Change 3357033 on 2017/03/21 by Alexis.Matte Fix crash when importing file with import commandlet Make sure path are combine properly to avoid crash Add some missing pointer check Make sure the asset are save when there is no source control #jira UE-42334 Change 3357176 on 2017/03/21 by Alex.Delesky #jira UE-42445 - TMaps now support editing the values of structs that act as map keys. TMaps with struct keys will now show the types of their elements in the details panel as well, and structs will now also display numbers next to set elements. Change 3357197 on 2017/03/21 by Alex.Delesky #jira none - Fixing build issue for TMap key struct change. Change 3357205 on 2017/03/21 by Michael.Dupuis Forgot to reset min granularity to 6 from testing Change 3357340 on 2017/03/21 by Arciel.Rekman Mark FMallocAnsi (standard libc malloc) thread-safe on Linux. Change 3357413 on 2017/03/21 by matt.kuhlenschmidt Added '/Game/Effects/Fort_Effects/Materials/Smoke/M_Main_Smoke_Puff.M_Main_Smoke_Puff' to collection 'MattKTest' Upgraded collection 'MattKTest' (was version 1, now version 2) Change 3357505 on 2017/03/21 by Alexis.Matte Fix to avoid changing the CDO of FbxAssetImportData. The UI was saving the Config which was saving the CDO. But already serialized data will be reload badly if the CDO change since we serialize only the diff. #jira UE-42947 Change 3357825 on 2017/03/21 by Arciel.Rekman Clean up the large thread pool on exit. - Seems like the destruction was missed in the original CL 2785131 (12/1/15). - Fixes problems when threads were allocated in memory that is being cleaned up in another place on exit. Change 3358086 on 2017/03/22 by Yannick.Lange VR Editor: - Fix gizmo scaling down when dragging the world. - Fix gizmo scaling down when dragging rotation handle. Change 3358175 on 2017/03/22 by Andrew.Rodham Sequencer: Made ALevelSequenceActor::AdditionalEventReceivers advanced display Change 3358367 on 2017/03/22 by tim.gautier Submitting resaved QAGame assets - Materials, Material Instances, Material Functions and Parameters Change 3358457 on 2017/03/22 by Yannick.Lange VR Editor: Deleting unused UI assets. Change 3358801 on 2017/03/22 by Matt.Kuhlenschmidt Guard against crash if the level editor is shut down when the object system has already been shut down #jira UE-35605 Change 3358897 on 2017/03/22 by matt.barnes Checking in WIP test content for UEQATC-1635 (UMG Navigation) Change 3358976 on 2017/03/22 by Alex.Delesky #jira none - Fixing an issue where ItemPropertyNode could potentially dereference a null property Change 3358987 on 2017/03/22 by Yannick.Lange VR Editor: Fix warning: Can't find file for asset '/Engine/VREditor/UI/VRButtonBackground' while loading ../../../Engine/Content/VREditor/Devices/Vive/VivePreControllerMaterial.uasset. Change 3359067 on 2017/03/22 by Yannick.Lange VR Editor: Fix Radial Menu remains on controller after exiting VR Preview #jira UE-42885 Change 3359179 on 2017/03/22 by Matt.Kuhlenschmidt Fixed "Multiple Values" in Body Setup when single bone has multiple bodies #jira UE-41546 Change 3359626 on 2017/03/22 by Arciel.Rekman Linux: pool OS allocations. - Add a TMemoryPool and TMemoryPoolArray classes that can be used with any type of OS allocator functions. - Add ability to bypass CachedOSPageAllocator for given sizes. Also, corrected the condition on AllocImpl to match one on FreeImpl. - Switch Linux to pool mmap()/munmap() by default (helps 32-bit Linux and also speeds up 64-bit one), except 64-bit servers. - Add a test to TestPAL to check performance and thread safety. - Misc. fixes. Change 3359989 on 2017/03/23 by Andrew.Rodham Sequencer: Binding overrides improvements - Added the ability to override spawnable bindings - Added the ability to override bindings in sub sequences - Deprecated "Get Sequence Bindings" node in favor of "Get Sequence Binding", which is more robust, and provides a better UI/UX for selecting single bindings #jira UE-42470 Change 3360369 on 2017/03/23 by Alexis.Matte Fix the staticmesh conversion from UE4 4.13 to earlier UE4 versions #jira UE-42731 Change 3360556 on 2017/03/23 by Andrew.Rodham Sequencer: Added drag/drop support for binding overrides - You can now drag and drop sequencer object binding nodes into blueprint graphs (to create 'Get Sequence Binding' nodes), and onto binding overrides specified on level sequence actors. Change 3360618 on 2017/03/23 by Arciel.Rekman Make Binned2 work on Mac. - Game/server will use Binned2 by default. Change 3360838 on 2017/03/23 by Nick.Darnell CommonUI - Making the SingleMaterialStyleMID property transient. It had been serialized mistakenly onto several widgets when it appears the intent is to dynamically allocate it upon demand. Change 3360841 on 2017/03/23 by Nick.Darnell UMG - Updating the editor to use DuplicateAndInitializeFromWidgetTree, so that Initialize is properly called when duplicating sub widget trees. Change 3362561 on 2017/03/24 by Matt.Kuhlenschmidt Fixed text outlines being cropped at large sizes #jira UE-42647 Change 3362565 on 2017/03/24 by Matt.Kuhlenschmidt Added automation test for font outlines Change 3362567 on 2017/03/24 by Matt.Kuhlenschmidt Resaved this file to fix 0 engine version warnings Change 3362582 on 2017/03/24 by Yannick.Lange VR Editor: - Fix log warnings when teleporting. - Fix undo/redo when using teleport scaling. - Improved teleport scaling and push/pull input. #jira UE-43214 Change 3362631 on 2017/03/24 by Jamie.Dale Split the monolithic culture concept in UE4 UE4 has historically only supported the concept of a single monolithic "culture" that applied to both text localization and internationalization, as well as all asset localization. Typically the "culture" was set to the "locale" of the OS, however that could be undesirable or incorrect on platforms (such as newer versions of Windows) that have a distinct concept of "language" (for localization) and "locale" (for internationalization). This change splits the concept of "culture" into "language" and "locale", and also adds the concept of "asset groups". The language is now used to work out which localization we should use, and the locale is used to control how numbers/dates/times/etc are formatted within our internationalization library. Asset groups expand on the language used by asset localization and allow you to create a group of asset classes that can be assigned a different culture than the main game language. A typical use-case of this would be creating an "audio" group that could, for example, be set to Japanese while the rest of the game runs in English. If your game doesn't care about the distinction between language and locale, and doesn't need to use asset groups, then you're able to continue to use "culture" as you always have. If, however, you do care about those things, then you'll likely want to avoid using the "culture" directly (as it's now a very aggressive setting that overrides all others), and instead favor using language/locale (games will typically treat these as the same) and asset groups as separate concepts (both in settings, and in your in-game UI). The language or locale for a game can be controlled by settings within the "Internationalization" section of your configs (this would typically be set in your GameUserSettings config, in the same way that "culture" works), eg) [Internationalization] language=fr locale=fr The asset groups for a game can be controlled by settings within the "Internationalization.AssetGroupClasses" and "Internationalization.AssetGroupCultures" sections of your configs (the asset group class definition would typically be set in your DefaultGame config, and the cultures the groups use would typically be set in your GameUserSettings config), eg) [Internationalization.AssetGroupClasses] +Audio=SoundWave +Audio=DialogueWave [Internationalization.AssetGroupCultures] +Audio=ja #jira UE-38418 #jira UE-43014 Change 3362798 on 2017/03/24 by Nick.Darnell UMG - Putting the finishing touches on the hardware cursor system. Can now load them from blueprints, and there are options for setting them up in the project settings. UMG - Deprecating the old properties for software widget cursors. They've been moved into a map that can handle any of the mouse cursors as the enum key, which was always the intent/desire but maps couldn't be used as UProperties then. Change 3362805 on 2017/03/24 by Jamie.Dale PR #3397: Allow empty source to override display string (Contributed by jorgenpt) Change 3363039 on 2017/03/24 by Jamie.Dale Use the pre-scaled font height where possible to avoid an extra multiply Change 3363188 on 2017/03/24 by Joe.Graf Added support for -iterate for content plugins that require path remapping during cook/packaging #CodeReview: matt.kuhlenschmidt #rb: matt.kuhlenschmidt Change 3363355 on 2017/03/24 by Nick.Darnell UMG - Removing the CookAdditionalFiles function in UserInterfaceSettings. Change 3363672 on 2017/03/24 by Matt.Kuhlenschmidt Material thumbnails now respect used particle system sprites flag and show a quad insead of a sphere by default. For this change I added the ability to have per asset type override for the default thumbnail shape and I added a way to reset thumbnails to default. All existinging particle system materials that have not had a custom thumbnail will have to be reloaded and resaved for this to work #jira UE-42410 Change 3363699 on 2017/03/24 by Mike.Fricker VR Editor: Improved extensibility (for mesh editor) - This was merged from CL 3352612 and re-opened for edit before commit - All mesh editor changes were stripped before merging Change 3363784 on 2017/03/24 by Matt.Barnes Adding content for tests following UEQATC-3548 Change 3363872 on 2017/03/24 by Arciel.Rekman Linux: require user to setup clang/clang++ for building hlslcc. - Earlier we tried to handle most common scenarios since libhlslcc needed to be built during the setup. Now that we supply a prebuilt version we don't need to be as user friendly, especially given that the attempts to second guess the compiler started to look complicated. Change 3364089 on 2017/03/24 by Matt.Kuhlenschmidt Fix CIS Change 3364381 on 2017/03/24 by JeanMichel.Dignard UV Packing optim - Use horizontal segments instead of checking texel by texel to fit source chart in layout. - Skip a couple of rasterize by flipping either the X texels or the Y texels when possible. - Keep the best chart raster so that we don't need to reraster when adding the chart to the layout. - Added a lightmap UV version in StaticMesh so that we don't invalidate the lighting cache. Only use the new lightmap UV generation when going through UStaticMesh::Build which invalidates the lighting. Change 3364587 on 2017/03/24 by Arciel.Rekman Fix ordered comparison warning from clang 4.0. Change 3364596 on 2017/03/24 by Arciel.Rekman Linux: fix editor being stuck (hack). - Rebuilt hlslcc in Debug. Change 3364863 on 2017/03/25 by Max.Chen Sequencer: Fixed crash when deactivating a section in sequencer #jira UE-39880 Change 3364864 on 2017/03/25 by Max.Chen Sequencer: Integrating fix from licensee to ensure FVirtualTrackArea::HitTestSection checks the row of the section Change 3364865 on 2017/03/25 by Max.Chen Cine Camera: Default post process depth of field method to CircleDOF and use that setting in UpdateCameraLens. #jira UE-40621 Change 3364866 on 2017/03/25 by Max.Chen GitHub #3183: Conversion to base class is inaccessible. Change 3364869 on 2017/03/25 by Max.Chen Sequencer: Changed the time snapping interval in the toolbar ui so that it no longer additionally updates the sequencer setting. The setting is only used to initialize the time snapping interval of the level sequence. Added translate keys with ctrl and left-right arrows. #jira UE-41009 #jira UE-41210 Change 3364870 on 2017/03/25 by Max.Chen Sequencer: Added translate keys with ctrl and left-right arrows. #jira UE-41210 Change 3364871 on 2017/03/25 by Max.Chen Sequencer: Add level sequence actor customization to open sequencer from the details panel. For matinee parity. #jira UE-41459 Change 3364879 on 2017/03/25 by Max.Chen Sequencer: Duplicate shot should put the duplicate on the next available row, keeping the start/end times the same. #jira UE-41289 Change 3364880 on 2017/03/25 by Max.Chen Sequencer: Opening the API for MovieSceneAudio-related classes along with some minor functionality additions: - Adding _API specifiers to MovieSceneAudioTrack, MovieSceneAudioSection, and FAudioTrackEditor so they can be subclassed in other modules. - Made GetSoundDuration function in MovieSceneAudioTrack.cpp a member function so it's functionaliy could be reused by subclasses. - Adding ability to specify delegates for OnQueueSubtitles, OnAudioFinished, and OnAudioPlaybackPercent in a MovieSceneAudioSection, and have them automatically assigned to any AudioComponents that are played by the MovieSceneAudioTemplate Change 3364884 on 2017/03/25 by Max.Chen Sequencer fbx import - Removed the PostRotation compensation as it was setuped for 3ds max. - On import, add a rotation to camera and light animation keys like we do on export. - Merge the component local transform with the ActorNode transform when exporting only one component that isn't the root component in fbx since we're not creating child nodes in that case. #jira UE-34692 Change 3364885 on 2017/03/25 by Max.Chen Sequence Recorder: Fix crash when clearing properties to record. #jira UE-41873 Change 3364886 on 2017/03/25 by Max.Chen Sequencer: Add error when attempting to add a circularly dependent level sequence #jira UE-22358 Change 3364890 on 2017/03/26 by Max.Chen Sequencer: Added ability to specify a 'notify' function to property instance bindings - When specified, the (parameterless) function will be called after a property is set Change 3364891 on 2017/03/26 by Max.Chen Sequencer: Various fixes to thumbnails - Fixed alpha blending being used when presenting the full screen quad for thumbnails Change 3364892 on 2017/03/26 by Max.Chen Sequencer: PreRoll and PostRoll is now exposed at the section level, for all sections - For the majority of sections this will be unimplemented, but it will allow for some tracks to set up their data ahead of time Change 3364896 on 2017/03/26 by Max.Chen Sequencer: Add segment flags to equality operator for movie scene evaluation segments - This prevents them from being accumulated into adjacent segments of the same index and forced time, but differing flags Change 3364897 on 2017/03/26 by Max.Chen Sequencer: Fixed "Evaluate in preroll" and "Evaluate in Postroll" options - Pre and postroll flags now come through on compiled segments, so the previous manual logic for sub sections is obsolete; we can just use the compiled segment data directly. Change 3364898 on 2017/03/26 by Max.Chen Sequencer: Moved track options to be accessible on all nodes, and operate on all selected tracks Change 3364902 on 2017/03/26 by Max.Chen Sequencer: Ensure evaluation flags are considered when compiling segments from external sequences - This ensures that preroll regions in sub sequences are correctly evaluated when their parent section has preroll - Changed high pass blending to always allow preroll Change 3364903 on 2017/03/26 by Max.Chen Engine: Moved proxy mesh transform update out of camera view computation code - GetCameraView can happen as part of end of frame updates, which will assert if any changes of transform happen during its processing Change 3364908 on 2017/03/26 by Max.Chen Sequencer: Added visualization of pre and postroll on sections Change 3364909 on 2017/03/26 by Max.Chen Sequencer: Prevent MovieSceneCompiler from removing preroll segments Change 3364910 on 2017/03/26 by Max.Chen Sequencer: MediaPlayer PreRoll/PostRoll fix - Handle PreRoll/PostRoll on sub scenes that have a start offset Change 3364922 on 2017/03/26 by Max.Chen Sequencer: Add check for valid property before dereferencing. #jira UE-40951 Change 3364923 on 2017/03/26 by Max.Chen Sequencer: Fix MovieScene preroll so that it seeks to the start correct frame before the preroll. Change 3364924 on 2017/03/26 by Max.Chen Sequencer - change default behavior for pre/post roll evaluation - MovieSceneTracks are NOT evaluated by default Change 3364925 on 2017/03/26 by Max.Chen Sequencer: Shot track rows now consider pre and post roll when being compiled Change 3364926 on 2017/03/26 by Max.Chen Sequencer: Added the ability to define shared execution tokens, identifyable with a unique identifier, and sortable based on a sort order (<=0: before standard tokens, >0: after other tokens) Change 3364927 on 2017/03/26 by Max.Chen Sequencer: Added the ability to selectively restore state for specific anim type IDs for a given object - This allows us to specifically restore one particular type of animation for a given object (ie, transform, skeletal animation control, or motion blur) Change 3364928 on 2017/03/26 by Max.Chen Sequencer: Fixed sub-sub tracks not being present in master sequences - In order to correctly handle preroll in inner-inner sequences, we need to have access to those tracks when compiling intermediate sub sections. By caching off all the inner templates, we can have access to these tracks to check whether they want to be evaluated in pre/post roll in the master sequence Change 3364937 on 2017/03/26 by Max.Chen Sequencer: Update cine camera component debug focus plane on tick, rather than in GetCameraView #jira UE-41332 Change 3364938 on 2017/03/26 by Max.Chen Sequencer: Fix crash inserting a level sequence with an invalid shot. #jira UE-41481 Change 3364940 on 2017/03/26 by Max.Chen Sequencer: Made handling of pre and post roll more consistent between explicit section pre/post roll and pre/post roll inherited from an outer sub section Change 3364942 on 2017/03/26 by Max.Chen Movie Scene Capture: Move EDL generation to setup instead of close to ensure it gets written out when capturing as a separate process. #jira UE-41703 Change 3364943 on 2017/03/26 by Max.Chen Sequencer: Prevent capturing movies in editor while a PIE session is running #jira UE-41399 Change 3364944 on 2017/03/26 by Max.Chen CIS fixes Change 3364951 on 2017/03/26 by Max.Chen Sequencer: Fix autokey not setting a keyframe for slate color with specified color. #jira UE-41645 Change 3364952 on 2017/03/26 by Max.Chen Sequencer: Level sequence frame snapshots now take account of fixed-frame interval offsets, and overlapping shot sections on the same row #jira UE-41684 Change 3364953 on 2017/03/26 by Max.Chen Sequencer: Fix edl so that it doesn't write out when a shot is out of range. Also fixed not writing the EDL with the correct frame rate when exporting from the track. Reworked the cmx EDL so that its encoded in the same edit time space, including a blank slug at the beginning of the edit. #jira UE-41925 Change 3364954 on 2017/03/26 by Max.Chen Sequencer - Allow animating parameters on cascade effect components which aren't owned by an AEmitter. Change 3364955 on 2017/03/26 by Max.Chen Sequencer: Fixed sequencer anim instance not being used in the case where one was requested, but a different anim instance was already set This fixes an issue when rendering in seaprate process, animations that were set up to use the sequencer instance would be controlled using montage animation instead. Change 3364963 on 2017/03/26 by Max.Chen Sequencer: Fix filtering to include child nodes. #jira UE-42068 Change 3364964 on 2017/03/26 by Max.Chen Sequencer: Enable UseCustomStartFrame and UseCustomEndFrame when rendering a single shot from the menu. #jira UE-42021 Change 3364965 on 2017/03/26 by Max.Chen Sequencer: Set the fade color in the track display Change 3364966 on 2017/03/26 by Max.Chen Sequencer: Show actor attached to label in attach section. Change 3364967 on 2017/03/26 by Max.Chen Sequencer: Fix static analysis warnings Change 3364968 on 2017/03/26 by Max.Chen Sequencer: Fix crash on converting to spawnable. The previous implementation purported to allow null objects to set up spawnable defaults but it actually needed to compare the spawned object to the supported type. This new mechanism now allows the spawner to indicate that it accepts null objects and doesn't crash. #jira UE-42069 Change 3364969 on 2017/03/26 by Max.Chen Sequencer: Fixed crash caused by holding onto stale properties through a raw ptr #jira UE-42072 Change 3364977 on 2017/03/26 by Max.Chen Sequencer: Convert FLinearColor to FColor for fade. #jira UE-41990 Change 3364978 on 2017/03/26 by Max.Chen Sequencer: Limit GetAllSections to the sections that actually correspond to the track #jira UE-42167 Change 3364979 on 2017/03/26 by Max.Chen Sequencer: Filter root nodes too #jira UE-42068 Change 3364980 on 2017/03/26 by Max.Chen Sequencer: Filter relevant material parameters #jira UE-40712 Change 3364982 on 2017/03/26 by Max.Chen Sequencer: Remove audio range bounds which clamps to the section bounds (needed for evaluating in pre and post roll) Change 3364983 on 2017/03/26 by Max.Chen Sequencer: Add socket name to attach track section. Change 3364984 on 2017/03/26 by Max.Chen Sequencer: Fix sub track node deletion so that all the sub tracks aren't deleted, only the row being requested. #jira UE-40955 Change 3364988 on 2017/03/26 by Max.Chen Sequencer: Invalidate expired objects when blueprints are compiled. Fix actor references now handles sections that need to have their guids updated (ie. attach tracks). Change 3364994 on 2017/03/26 by Max.Chen Sequencer: Audio waveforms now show peak samples with smoothed RMS in the center - Audio row heights are now also resizable by dragging on the bottom end of the track lane in the track area view Change 3364995 on 2017/03/26 by Max.Chen UMG: Fix crash on undo #jira UE-42210 Change 3365000 on 2017/03/26 by Max.Chen Sequencer: Fix crash from GetCurrentValue. Change 3365001 on 2017/03/26 by Max.Chen Sequencer: Split "Snap to the Dragged Key" option into two options, pressed key and dragged key. #jira UE-42382 Change 3365002 on 2017/03/26 by Max.Chen Sequencer: Downgraded check to ensure for FMovieSceneEvalTemplateBase::GetScriptStructImpl() Change 3365003 on 2017/03/26 by Max.Chen Sequencer: Fixed section template script struct - Because the cpp is not parsed by UHT, the empty template had its parent struct, rather than its own - We now just return null, and handle empty segments correctly in the segment remapper as part of the track compilation Change 3365013 on 2017/03/26 by Max.Chen Sequencer: Added data validation on compiled template loads, and extra guards against misuse of movie scene types Change 3365014 on 2017/03/26 by Max.Chen Sequencer: Sequencer now re-evaluates when starting PIE or Simulate - This can be disabled by disabling "Bind Sequencer to PIE" and "Bind Sequencer to Simulate" in PIE advanced settings Change 3365015 on 2017/03/26 by Max.Chen Sequencer: Fix edl files so that they don't write out empty range shots Change 3365017 on 2017/03/26 by Max.Chen Sequencer: Set max tick rate when in game. #jira UE-41078 Change 3365018 on 2017/03/26 by Max.Chen Sequencer: When finishing a scrub, playback status is now correctly set to stopped rather than stepping - This fixes a hack that was previously in place from the old PostTickRenderFixup that caused it to run that step after scrubbing bad finished. This is no longer necessary, and actually breaks clicking to set the scrub position, as it now means that we step across the entire range between the previous and current time. Change 3365022 on 2017/03/26 by Max.Chen Sequencer: Insert shot now creates a shot at the current time and puts it on the next available row. #jira UE-41480, UE-27699 Change 3365023 on 2017/03/26 by Max.Chen Sequencer: Add loop selection range. If there is no selection range, loop mode is restricted to loop or no loop. #jira UE-42285 Change 3365029 on 2017/03/26 by Max.Chen Sequencer: Add hotkeys to set the selection range to the next and previous shot (page up, page down). Also, added hotkey to set the playback range to all the shots (end) Change 3365030 on 2017/03/26 by Max.Chen Sequencer: Fix particle system restore state so that it gets the proper initial active state of the particle system. #jira UE-42861, UE-42859 Change 3365031 on 2017/03/26 by Max.Chen Sequencer: Snap time when changing time snapping intervals. #jira UE-42590 Change 3365032 on 2017/03/26 by Max.Chen Sequencer: Add When Finished state to sections. By default, sections now restore state. #jira UE-41991, UE-31569 Change 3365033 on 2017/03/26 by Max.Chen #jira UE-42028 "DialogueWave playback calls OnQueueSubtitles multiple times" Only queue subtitles once per wave instance playback Change 3365041 on 2017/03/26 by Max.Chen Sequencer: Subscene hierarchical bias Tracks can now be prioritized based on their subscene hierarhical bias value. Higher bias values take precedence. #jira UE-42078 Change 3365042 on 2017/03/26 by Max.Chen Sequencer: Generic paste menu for master (root) tracks. Change 3365043 on 2017/03/26 by Max.Chen Sequencer: Hierarchical bias for level visibility track #jira UE-43024 Change 3365044 on 2017/03/26 by Max.Chen Sequencer: Prevent throttling on editing keys/sections. Change 3365045 on 2017/03/26 by Max.Chen Sequencer: Set sequencer audio components bIsUISound to false so that they don't continue playing when the game is paused. #jira UE-39391 Change 3365046 on 2017/03/26 by Max.Chen Sequencer: Add missing BindLevelEditorCommands() Change 3365049 on 2017/03/26 by Max.Chen Sequencer: Set tick prerequites for spawnables when they are spawned. #jira UE-43009 Change 3365050 on 2017/03/26 by Max.Chen Sequencer: Jump to Start and End of playback shortcuts. Rewind renamed to Jump to Start. Shortcut - up arrow. Jump to End Shortcut - ctrl up arrow. #jira UE-43224 Change 3365051 on 2017/03/26 by Max.Chen Sequencer: Add last range to playback Change 3365057 on 2017/03/26 by Max.Chen Sequencer: Fix master sequence subscene generation times. Change 3365058 on 2017/03/26 by Max.Chen Sequencer: Fix paste so that it doesn't paste both onto object nodes and master tracks. Change 3365059 on 2017/03/26 by Max.Chen Sequencer: Fix crash pasting audio track. Change 3365060 on 2017/03/26 by Max.Chen Sequencer: Cache player fade state so that restore state will return the values to the pre animated state. #jira UE-43313 Change 3365061 on 2017/03/26 by Max.Chen Sequencer: Filter hidden functions. This fixes a bug where the field of view property for a cinematic camera appears to be animatable. It should be hidden just like it is in the property editor. #jira UE-41461 Change 3365065 on 2017/03/26 by Max.Chen Sequencer: Support component hierarchies when drawing animation paths #jira UE-39500 Change 3365066 on 2017/03/26 by Max.Chen Sequencer: Refine pause behaviour in sequencer to always evaluate the next frame - This ensures that we get a full frame's worth of evaluation so that the paused frame is of a good quality (and avoids us evaluating a tiny range) Change 3365075 on 2017/03/26 by Max.Chen Sequencer: Fix add shot not setting next row. Change 3365076 on 2017/03/26 by Max.Chen Sequencer: Export MovieSceneTrackEditor #jira UE-41641 Change 3365472 on 2017/03/27 by Yannick.Lange VR Editor landscape. Back out changelist 3356071 with new proper fixes. CL 3356071 introduced another bug and it wasn't correct because of removing FLandscapeToolInteractorPosition. This changelist fixes the same and additional bugs for VREditor Landscape mode. - Fix when sculpting/painting the position wouldn't update. - Fix inverted action for brushes while holding down shift or modifier on motioncontroller. - Fix VREditor Landscape Texture Painting does not paint continuously - Fix having to press once on the landscape to see the visuals for landscape editing. - Removed Interactor parameter from BeginTool. #jira UE-42780, UE-42779 Change 3365497 on 2017/03/27 by Matt.Kuhlenschmidt Fix texture importing when an FBX file incorrectly reports absolute path as relative. First we try absolute, then we try fbx reported relative, then we try relative to parent FBX file. Change 3365498 on 2017/03/27 by Matt.Kuhlenschmidt Fix attempting to load a package in FBX scene import when the import path is empty. This greatly reduces FBX scene import time Change 3365504 on 2017/03/27 by Yannick.Lange VR Editor landscape fix ensure in when starting to paint/sculpt. Mousemove on tool should only be called when the tool is actually active, not when hovering. Change 3365551 on 2017/03/27 by Matt.Kuhlenschmidt PR #3425: Added Scrollbar customization to SComboBox (Contributed by Altrue) #jira UE-43338 Change 3365580 on 2017/03/27 by Matt.Kuhlenschmidt PR #3409: Add support for per-Category filtering in Output Log (Contributed by thagberg) Change 3365672 on 2017/03/27 by Andrew.Rodham Sequencer: Preanimated state producers can now produce null tokens - Doing so implies no preanimated state should be saved Change 3365791 on 2017/03/27 by Andrew.Rodham Sequencer: Added Material Parameter Collection track Change 3365806 on 2017/03/27 by Max.Chen Sequencer: Add option to instance sub sequences. #jira UE-43307 Change 3365822 on 2017/03/27 by Matt.Kuhlenschmidt Subdue the output log font color a bit Change 3365846 on 2017/03/27 by Jamie.Dale Added package redirection on load/find Change 3365852 on 2017/03/27 by Jamie.Dale Adding a way to mark a package as no longer missing Change 3365896 on 2017/03/27 by Jamie.Dale Adding GlobalNotification to Slate This is the guts of the GlobalEditorNotification, so it can be used by code that doesn't link to UnrealEd. Change 3365900 on 2017/03/27 by Jamie.Dale Prevent the default cooked sandbox from trying to read non-cooked assets Change 3366550 on 2017/03/27 by Max.Chen Sequencer: Fix case Change 3367301 on 2017/03/28 by Andrew.Rodham Tests: Added test actor with a variety of properties for testing purposes Change 3367303 on 2017/03/28 by Andrew.Rodham Tests: Enabled ActorSequenceEditor plugin in EngineTest project Change 3367304 on 2017/03/28 by Andrew.Rodham Tests: Added several functional testing maps for sequencer - SequencerTest_Properties - tests animating various property types - SequencerTest_Events - tests basic event triggering functionality (including additional event receivers and event ordering) - SequencerTest_BindingOverrides - tests overriding possessable and spawnable bindings, along with bindings in sub sequences - SequencerTest_ActorSequence - tests basic actor sequence functionality Change 3367465 on 2017/03/28 by Max.Chen Sequencer: Set Bind Sequencer to PIE off by default, Bind Sequencer to Simulate remains on by default. Change 3367515 on 2017/03/28 by Matt.Kuhlenschmidt Guard against visual studio accessor crash #jira UE-43368 Change 3368118 on 2017/03/28 by Alexis.Matte Fix the staticmesh conversion from 4.13. There was a error in the LOD loop we where not remapping the LOD 0. #jira UE-42731 Change 3368485 on 2017/03/28 by Alex.Delesky #jira UE-42207 - Updated SVN Binaries for MacOSX 64-bit: - Subversion 1.9.4 -> 1.9.5 - OpenSSL 1.0.2h -> 1.0.2k - BerkeleyDB 5.3.15 -> 6.2.23 - Java 8u101 -> 8u121 - Sqlite 3.13.0 -> 3.17.0 - Serf 1.3.8 -> 1.3.9 - Swig 3.0.10 -> 3.0.12 - ZLib 1.2.9 -> 1.2.11 Change 3368495 on 2017/03/28 by Alex.Delesky #jira UE-42207 - Updated SVN Binaries for Windows 64-bit: - Subversion 1.9.4 -> 1.9.5 - OpenSSL 1.0.2h -> 1.0.2k - BerkeleyDB 5.3.15 -> 6.2.23 - Java 8u101 -> 8u121 - Sqlite 3.13.0 -> 3.17.0 - Serf 1.3.8 -> 1.3.9 - Swig 3.0.10 -> 3.0.12 - ZLib 1.2.9 -> 1.2.11 Change 3368501 on 2017/03/28 by Alex.Delesky #jira UE-42207 - SVN Build instructions for Windows and Mac 64-bit libraries, and license files for Mac libraries Change 3368782 on 2017/03/28 by Nick.Darnell UMG - Improving some logging for fast widget creation. Change 3368826 on 2017/03/28 by Nick.Darnell Slate - Slate Application now maintains seperate tracking for each pointer being utilized for drag drop, so now multiple fingers on multiple widgets can now simultaneously be attempting a drag, however once one of them becomes successful, we clear all state of all other tracking since only one Drag Drop operation is possible at a time. Slate - bFoldTick is now removed from the codebase, we haven't supported the other (non-folded) code path for awhile, so there was no point in maintaining the switch. Slate - Users have noticed issues where the cursor does not appear when changing visibility (through toggling the way the cursor appears). This was rooted in how the OS requested cursor changes, WM_SETCURSOR on Windows only asks for new cursors when the mouse moves, but often cursors change just because mouse capture changes. So now the path has been centralized in Slate Tick to only handle the cursor changes in one place, and several places that need to refresh the cursor state, now set a flag to handle it on next tick. #jira UE-40486 Change 3368917 on 2017/03/28 by Arciel.Rekman Linux: allow building with clang 4.0. Change 3369074 on 2017/03/28 by Nick.Darnell UMG - Fixing some spelling on the hardware cursor tip. UMG - Changed some checks to ensure now that users can input the wrong data from the editor. Adding some clamping to the editor interface so that users are not tempted to enter incorrect hotspot ranges for their cursors. #jira UE-43419 #jira UE-43425 Change 3369137 on 2017/03/28 by Max.Chen Sequencer: Add given master track sets the outer to the movie scene. Change 3369360 on 2017/03/29 by Andrew.Rodham Sequencer: Reconciled 3349194 and 3365041 with animphys merge Change 3369410 on 2017/03/29 by Alexis.Matte Fix the select filename in the FileDialog "Desktop window platform" #jira UE-43319 Change 3369475 on 2017/03/29 by Nick.Darnell PR #3413: UE-37710: Proper scaling of WebBrowserViewport (Contributed by projectgheist) Modified - you can't use the clip rect to decide on how large you should be. #jira UE-37710 Change 3369775 on 2017/03/29 by Max.Chen ControlRig: Fix crash on exit. #jira UE-43411 Change 3370466 on 2017/03/29 by Nick.Darnell AsyncLoading - Adding USoundBase to the set of CDOs that have a particular fixed boot order. StreamableManager - Only showing the duplicate load error in debug builds, it's not a real error. #jira UE-43409 Change 3370570 on 2017/03/29 by Nick.Darnell Slate - Fixing a bug with ZOrder being discarded on the SOverlay Slot. #jira UE-43431 Change 3370644 on 2017/03/29 by Andrew.Rodham Temporarily disabling sequencer functional test "Event Position" Change 3370713 on 2017/03/29 by Nick.Darnell PR #3399: UE-42831: Anchor text ignores scale (Contributed by projectgheist) #jira UE-43156 #jira UE-42831 Change 3371243 on 2017/03/30 by Arciel.Rekman Linux: scale OS allocation pool to match memory size. - Number of distinct VMAs (contiguous virtual memory areas, i.e. mappings done via mmap()) is rather low (~64k) and we can run out of VMAs earlier than we will run into available memory. Larger pool makes this less likely. Change 3371262 on 2017/03/30 by Arciel.Rekman Linux: fix custom present. - PR #3383 contributed by yaakuro. Change 3371301 on 2017/03/30 by Arciel.Rekman Linux: fix copying to a non-existent directory during Setup. Change 3371307 on 2017/03/30 by Andrew.Rodham Editor: Added "Resave All" functionality to content browser folders Change 3371364 on 2017/03/30 by Andrew.Rodham Sequencer: Level streaming improvements - Tick prerequisites are now set up when any object binding is resolved, not at the start of the sequence. This unifies code between spawnables and possessables, and allows tick prerequisites to still be set up when levels are streamed in - Actor references are no longer resolved when a PIEInstance is specified on the package, and it cannot be fixed up to a different ptr than the original. This stops us resolving actors from one world into another. - Fixed level visibility request getting cleared when the cumulative total was 0 (it should only do this if there are no requests left) #jira UE-43225 Change 3371365 on 2017/03/30 by Andrew.Rodham Tests: Sequencer level streaming tests Change 3371493 on 2017/03/30 by Nick.Darnell PR #3408: UE-19980: Added FCanExecuteAction to prevent keyboard shortcut. (Contributed by projectgheist) Change 3371524 on 2017/03/30 by Nick.Darnell PR #2938: Minor UMG code fixups (Contributed by projectgheist), accepted most of the changes. Change 3371545 on 2017/03/30 by Nick.Darnell UMG - Fixing some minor issues with WidgetComponents not properly limiting input depending on what is supported with reguard to hardware input. Change 3371576 on 2017/03/30 by Matt.Kuhlenschmidt PR #3433: Fix for the Standalone D3D Slate Shader using the wrong value for the. (Contributed by megasjay) Change 3371590 on 2017/03/30 by Nick.Darnell UMG - Fixing widget alignment in the viewport when using the widget component with screen space, with an aspect ratio lock on the player's camera. The widgets should now show up in the right locations. Change 3371625 on 2017/03/30 by Alexis.Matte Fix the merge tool material id assignment #jira UE-43246 Change 3371666 on 2017/03/30 by Nick.Darnell UMG - Reducing logging, don't need to tell everyone all the time we're using the fast widget path. Change 3371687 on 2017/03/30 by Arciel.Rekman Linux: switch to new managed filehandles. Change 3371778 on 2017/03/30 by Matt.Kuhlenschmidt Fixed the animation to play property on skeletal meshes being too small to read anything #jira UE-43327 Change 3372709 on 2017/03/30 by Matt.Kuhlenschmidt Made slate loading widget / movie play back more thread safe by eliminating Slate applicaiton or the main window from being ticked directly on another thread. We now have a separate virtual window for ticking and painting the loading screen widgets in isolation Change 3372757 on 2017/03/30 by Nick.Darnell Paragon - Fixing cases where people were using PostLoad() where really it should have done when the widget was constructed or created. This is a side effect of the FastWidget creation path 'PostLoad()' is not called on newly constructed widgets, though it did before because part of duplicating the WidgetTree, required serialization, which would have called it. Change 3372777 on 2017/03/30 by Nick.Darnell Fixing fast widget template cooking so that it does the same logic as Initialize did, centralizing the code to find the first widgetblueprintclass. Change 3372949 on 2017/03/30 by Nick.Darnell UMG - Fixing some cooking crashes for the super class. Change 3373139 on 2017/03/30 by Jeff.Farris Added TimingPolicy option to WidgetComponent, so widgets can optionally tick in game time rather than real time. (Copy of CL 3279699 from Robo Recall to Dev-Editor) Change 3373235 on 2017/03/30 by Nick.Darnell Fixing a cooking issue, accidentally removed code that was properly loading some needed assets. Change 3373266 on 2017/03/30 by Matt.Kuhlenschmidt Made GetMoviePlayer thread safe. Simply accessing GetMoviePlayer is safe now as is checking IsLoadingFinished. However, most of the functions on movie player are only safe from the game thread! Change 3374026 on 2017/03/31 by Andrew.Rodham Sequencer: Moved evaluation group registration to IMovieSceneModule #jira UE-43420 Change 3374060 on 2017/03/31 by Yannick.Lange VR Editor: Collision on motion controllers in simulate. Change 3374185 on 2017/03/31 by Nick.Darnell Attempting to fix the build. Change 3374232 on 2017/03/31 by Max.Chen Sequencer: Fix audio not playing in editor #jira UE-43514 Change 3374322 on 2017/03/31 by Nick.Darnell UMG - SafeZone widget now has comments, and useful tips. Using the debugging console commands now trigger the broadcast that will cause controls like the SSafeZone widget to resample the display metrics to learn the new safezone ratio. Change 3374424 on 2017/03/31 by Max.Chen Updated test content so that the door animation is now set to "Keep State" for the When Finished property. #jira UE-43519 Change 3374447 on 2017/03/31 by Max.Chen Sequencer: Notify streaming system prior to camera cuts By default, this does nothing. Users will need to enable the preroll section of camera cuts for the streaming system to activate prior to cutting to cameras. #jira UE-42406 Change 3374571 on 2017/03/31 by Andrew.Rodham Sequencer: Unified global and object-bound pre animated state, added InitializeObjectForAnimation method to state producers Change 3374578 on 2017/03/31 by Andrew.Rodham Sequencer: Added unit tests for pre-animated state Change 3374592 on 2017/03/31 by Max.Chen Color Customization: Set curve color names. #jira UE-43405 Change 3374596 on 2017/03/31 by Andrew.Rodham Corrected documentation comment Change 3374671 on 2017/03/31 by Matt.Kuhlenschmidt Fix movie scene audio track not compiling outside of editor Change 3374689 on 2017/03/31 by Matt.Kuhlenschmidt Remove the slate thread masquerading as the game thread in IsInGameThread Change 3374730 on 2017/03/31 by Max.Chen Sequencer: Add check for null loaded level. Change 3374732 on 2017/03/31 by Max.Chen Sequencer: Remove null tracks on postload. Change 3374737 on 2017/03/31 by tim.gautier - Updated UMG_Optimization: Adjusted Variable names to resolve compile errors due to Widget Components and Variables sharing names (cannot be done with new compile improvements) - Set Level Blueprint for TM-UMG back to AllPalettes Change 3374987 on 2017/03/31 by Nick.Darnell UMG - Introducing a way to inform the widgets more information about the designer. There's now a DesignerChanged event sent to all design time widgets letting them know things like the current screen size and DPI scale. UMG - The SafeZone widget will now show the correct safe zone amount if you use the safezone command line options, which are now documented in the comment for the USafeZone class. Change 3375599 on 2017/03/31 by Max.Chen Cine Camera: Update camera debug plane when property changes, rather rely soley on tick. This fixes a bug where sliding the value on the details panel doesn't update the debug plane in the viewport simultaneously. #jira UE-43543 Change 3375601 on 2017/03/31 by Arciel.Rekman Linux: switch to v9 cross-toolchain. Change 3375856 on 2017/04/01 by Andrew.Rodham Sequencer: Fixed 'formal parameter with requested alignment of 16 won't be aligned' Change 3375870 on 2017/04/01 by Andrew.Rodham Sequencer: Fixed explicit template instantiation ocurring before the complete definition of type's members - This resulted such members not being instantiated (and hence exported) when compiled with clang Change 3376114 on 2017/04/02 by Arciel.Rekman Linux: make source code accessor aware of clang 3.9 and 4.0. Change 3376138 on 2017/04/02 by Arciel.Rekman Linux: add clang to fedora deps (UE-42123). - PR #3273 submitted by cpyarger. Change 3376159 on 2017/04/02 by Arciel.Rekman Linux: some support for building on Debian Sid or Stretch (UE-35841). - Basd on PR #2790 by haimat. Change 3376163 on 2017/04/02 by Arciel.Rekman Linux: install latest clang on Arch (UE-42341). - This undoes PR #1905. - PR #2897 by SiebenCorgie. - PR #3302 by awesomeness872. - PR #3341 by patrickelectric. Change 3376167 on 2017/04/02 by Arciel.Rekman Add FreeBSD mem info (courtesy support for the out of tree build) (UE-42994). - PR #3378 by mdcasey. Change 3376168 on 2017/04/02 by Arciel.Rekman Linux: fixed VHACD Makefile on a case sensitive fs (UE-42905). - PR #3381 by slonopotamus. Change 3376177 on 2017/04/02 by Arciel.Rekman SlateDlg: case-insensitive comparison of filter extensions (UE-39477). - PR #3019 by aknarts. Change 3376178 on 2017/04/02 by Arciel.Rekman WebRTC: only x86_64 version exists for Linux. Change 3376245 on 2017/04/03 by Andrew.Rodham Sequencer: Re-enabled event order test Change 3376339 on 2017/04/03 by Matt.Kuhlenschmidt Fix crash during loading movie playback on DX12 due to not ever cleaning up old resources #jira UE-27026 Change 3376481 on 2017/04/03 by Alex.Delesky #jira UE-43495 - TMaps will now support customized key properties correctly. Change 3376741 on 2017/04/03 by Matt.Kuhlenschmidt Fix crash flushing font cache when loading a movie. This is no longer save on the slate movie thread #jira UE-43567 Change 3376763 on 2017/04/03 by Shaun.Kime Material Reroute nodes do not work for Texture Object Parameters as they return a base output type. Modified logic to now support this node type. #jira UE-43521 Change 3376836 on 2017/04/03 by Jamie.Dale Fixed text format history being clobbered by reference collection #jira UE-37513 Change 3376852 on 2017/04/03 by Nick.Darnell Paragon - Found a case where a user had marked a BindWidget property as Transient which prevents serializing the property binding now for widget fast mode. #jira UE-43564 Change 3377207 on 2017/04/03 by Jamie.Dale Desktop platform directory pickers are expected to return absolute paths File pickers return relative paths though, and we should make this consistent at some point. #jira UE-43588 Change 3377214 on 2017/04/03 by Matt.Kuhlenschmidt Fix movie player shutdown crash in non-editor builds #jira UE-43577 Change 3377299 on 2017/04/03 by Michael.Dupuis #jira UE-43586 : properties should be non transactional #jira UE-43559 Change 3378333 on 2017/04/04 by Michael.Dupuis #jira UE-43585 #jira UE-43586 Revert back to purple color Change 3378633 on 2017/04/04 by Matt.Kuhlenschmidt Resaved this asset to avoid zero engine version warnings Change 3378958 on 2017/04/04 by Nick.Darnell Automation - Fixing the race condition to finish compiling shaders on screenshots for UI. [CL 3379345 by Matt Kuhlenschmidt in Main branch]
2017-04-04 15:35:21 -04:00
.MinDesiredWidth(125.f)
.MaxDesiredWidth(250.f)
[
SNew(SHorizontalBox)
+ SHorizontalBox::Slot()
.FillWidth(1.0f)
[
SAssignNew(ClassPickerComboButton, SComboButton)
.OnGetMenuContent(this, &FSkeletalMeshComponentDetails::GetClassPickerMenuContent)
.ContentPadding(0)
.ButtonContent()
[
SNew(STextBlock)
.Font(IDetailLayoutBuilder::GetDetailFont())
.Text(this, &FSkeletalMeshComponentDetails::GetSelectedAnimBlueprintName)
.MinDesiredWidth(200.f)
]
]
+ SHorizontalBox::Slot()
.AutoWidth()
.HAlign(HAlign_Center)
.VAlign(VAlign_Center)
.Padding(2.0f, 1.0f)
[
PropertyCustomizationHelpers::MakeBrowseButton(FSimpleDelegate::CreateSP(this, &FSkeletalMeshComponentDetails::OnBrowseToAnimBlueprint))
]
+ SHorizontalBox::Slot()
.AutoWidth()
.HAlign(HAlign_Center)
.VAlign(VAlign_Center)
.Padding(2.0f, 1.0f)
[
PropertyCustomizationHelpers::MakeUseSelectedButton(FSimpleDelegate::CreateSP(this, &FSkeletalMeshComponentDetails::UseSelectedAnimBlueprint))
]
];
// Hide the parent AnimationData property, and inline the children with custom visibility delegates
const FName AnimationDataFName(GET_MEMBER_NAME_CHECKED(USkeletalMeshComponent, AnimationData));
TSharedPtr<IPropertyHandle> AnimationDataHandle = DetailBuilder.GetProperty(AnimationDataFName);
check(AnimationDataHandle->IsValidHandle());
TAttribute<EVisibility> SingleAnimVisibility(this, &FSkeletalMeshComponentDetails::VisibilityForSingleAnimMode);
DetailBuilder.HideProperty(AnimationDataFName);
// Process Animation asset selection
uint32 TotalChildren=0;
AnimationDataHandle->GetNumChildren(TotalChildren);
for (uint32 ChildIndex=0; ChildIndex < TotalChildren; ++ChildIndex)
{
TSharedPtr<IPropertyHandle> ChildHandle = AnimationDataHandle->GetChildHandle(ChildIndex);
if (ChildHandle->GetProperty()->GetFName() == GET_MEMBER_NAME_CHECKED(FSingleAnimationPlayData, AnimToPlay))
{
// Hide the property, as we're about to add it differently
DetailBuilder.HideProperty(ChildHandle);
// Add it differently
TSharedPtr<SWidget> NameWidget = ChildHandle->CreatePropertyNameWidget();
TSharedRef<SWidget> PropWidget = SNew(SObjectPropertyEntryBox)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
.ThumbnailPool(DetailBuilder.GetThumbnailPool())
.PropertyHandle(ChildHandle)
.AllowedClass(UAnimationAsset::StaticClass())
.AllowClear(true)
.OnShouldFilterAsset(FOnShouldFilterAsset::CreateSP(this, &FSkeletalMeshComponentDetails::OnShouldFilterAnimAsset));
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
TAttribute<bool> AnimPickerEnabledAttr(this, &FSkeletalMeshComponentDetails::AnimPickerIsEnabled);
AnimationCategory.AddCustomRow(ChildHandle->GetPropertyDisplayName())
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
.Visibility(SingleAnimVisibility)
.IsEnabled(AnimPickerEnabledAttr)
.NameContent()
[
NameWidget.ToSharedRef()
]
.ValueContent()
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
.MinDesiredWidth(600)
.MaxDesiredWidth(600)
[
PropWidget
];
}
else
{
AnimationCategory.AddProperty(ChildHandle).Visibility(SingleAnimVisibility);
}
}
}
EVisibility FSkeletalMeshComponentDetails::VisibilityForAnimationMode(EAnimationMode::Type AnimationMode) const
{
uint8 AnimationModeValue=0;
FPropertyAccess::Result Ret = AnimationModeHandle.Get()->GetValue(AnimationModeValue);
if (Ret == FPropertyAccess::Result::Success)
{
return (AnimationModeValue == AnimationMode) ? EVisibility::Visible : EVisibility::Hidden;
}
return EVisibility::Hidden; //Hidden if we get fail or MultipleValues from the property
}
bool FSkeletalMeshComponentDetails::OnShouldFilterAnimAsset( const FAssetData& AssetData )
{
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 2973866) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2937390 on 2016/04/07 by Cody.Albert #jira UE-29211 Fixed slider to properly bubble unhandled OnKeyDown events Change 2939672 on 2016/04/11 by Richard.TalbotWatkin Made a change to how file check out notifications work. Now the dirty package state is processed at the end of every tick, meaning that packages which are dirtied and then cleaned again are not processed. This fixes an issue where a number of child blueprints were flagged as needing checkout when a parent blueprint was compiled. This also allows multiple packages which are dirtied at the same time to be treated as one transaction. #jira UE-29193 - "Files need check-out" prompt spams Blueprint users Change 2939686 on 2016/04/11 by Richard.TalbotWatkin A number of further improvements to mesh vertex color painting: * Lower LODs are now automatically fixed up for instances which were created in a previous bugged version of the engine. * Since lower LODs cannot currently have their vertex colors edited, their vertex colors are always derived from LOD0. * Fixed a bug when building lower LODs so that vertices in neighboring octree nodes are considered when looking for the nearest vertex from LOD0 which corresponds. * Fixed issue where static meshes with imported LODs would not have the lower LODs' override colors set when "Copy instance vertex colors to source mesh" was used (static meshes with generated LODs were always getting correct override colors). #jira UE-28563 - Incorrectly displayed LOD VertexColor until paint mode is selected Change 2939906 on 2016/04/11 by Nick.Darnell Automation - Adding several enhancements to the automation framework and improving the UI. * Tests in the UI now have a link to the source and line where they orginate. * There's now a general purpose latent lambda command you can use to run arbitrary code latently. * Added Inlined AddCommand for regular and networked commands to the base automation class, to avoid the use of the macro, which prevents breakpoints from working in lambda code. * Front end now has better column displays offering more room to the test name * Changed several events to the automation controller to multicast delegates so that many could hook them. * The UI now refreshes the selection after tests finish so that the output log updates. Change 2939908 on 2016/04/11 by Nick.Darnell Automation - The editor import/export tests are now a complex test and actually sperate out all the tests that can be run, some trickiness was required on the filenames so that they didn't expand into more child tests in the UI. (replacing .'s with _'s) Change 2940028 on 2016/04/11 by Nick.Darnell Automation - Removing the search box from the toolbar. It's now inlined above the test tree. Tweaking the padding to make it look more other windows and make everything not look so squished. Recursive expansion now works on tests. Change 2940066 on 2016/04/11 by Nick.Darnell Automation - Moving the filter group dropdown out of the toolbar and onto the line with the search box above the treeview - additional tweaks to it. Change 2940092 on 2016/04/11 by Jamie.Dale PR #2248: Datatable select next row (Contributed by FineRedMist) Change 2940093 on 2016/04/11 by Jamie.Dale PR #2248: Datatable select next row (Contributed by FineRedMist) Change 2940157 on 2016/04/11 by Jamie.Dale Fixing FTextTest due to some changes made to how currency is formatted Change 2940694 on 2016/04/12 by Richard.TalbotWatkin Fixed issue where vertex override colors were not being propagated correctly for generated lower LODs. #jira UE-29360 - Override Colors not propagated correctly to generated lower LODs Change 2942379 on 2016/04/13 by Richard.TalbotWatkin Fixed issue where entering PIE while selecting an actor in Mesh Paint mode could lead to a MeshPaintStaticMeshAdapter holding onto an invalid pointer to an old mesh component, and causing a crash upon leaving the mode. This can happen because, when loading a new streaming level, the proxy actor can be selected when starting PIE, which will subsequently be added to the tool's internal lists. This needs to be added as a GC reference so that it can be NULLed when forcibly destroyed. #jira UE-29345 - Crash occurs exiting the editor after enabling mesh paint mode and PIEing Change 2942947 on 2016/04/13 by Richard.TalbotWatkin Fixed crash when pasting a material function call node from one project to another in which it is not defined. #jira UE-27087 - Crash when pasting MaterialFunctionCall expressions into the material editor between projects Change 2943452 on 2016/04/14 by Richard.TalbotWatkin Updated F4 debug key binding to match what's in ShowFlags.cpp PR #2197 (contributed by mfortin-bhvr) Change 2943824 on 2016/04/14 by Alexis.Matte #jira UE-29090 Make sure we cannot open the color picker when a property is edit const Change 2943841 on 2016/04/14 by Alexis.Matte #jira UE-28924 tooltip was add for every hierarchy import option Change 2943927 on 2016/04/14 by Alexis.Matte #jira UE-29423 Add Obj support for scene importer Github PR #2272 Change 2943967 on 2016/04/14 by Richard.TalbotWatkin Added relevant fields from FBodyInstance to the FoliageType customizations. #jira UE-20138 - FoliageType has a FBodyInstance but only shows Collision Presets and not other FBodyInstance properties Change 2948397 on 2016/04/19 by Andrew.Rodham Moved FSlateIcon definition to SlateCore It was previously declared as SLATE_API, despite its header residing inside SlateCore. Reviewed by Jamie Dale. Change 2948805 on 2016/04/19 by Andrew.Rodham Editor: Deprecated FName UEdGraphNode::GetPaletteIcon(FLinearColor&); in favor of FSlateIcon UEdGraphNode::GetIconAndTint(FLinearColor&); to allow for icons in external style sets to be used. - Previously, all icons were assumed to reside within FEditorStyle, which is not the case and would create broken icons in the graph editor. All relevant code has been updated to use FSlateIcon structures instead of a simple name. - This change required a significant overhaul to FClassIconFinder to support FSlateIcons. To keep the API clean, FSlateIconFinder now deals with FSlateIcon class icon finding operations, and FClassIconFinder for the most part just adds actor specific logic. #jira UE-26502 Change 2950658 on 2016/04/20 by Alexis.Matte #jira UE-24333 Skinxx workflow, we now output an error if there is mix of material with skinxx and some with no skinxx suffix Change 2950663 on 2016/04/20 by Alexis.Matte #jira UE-29582 When exporting to fbx we have to export each material instance as one fbx material Change 2951240 on 2016/04/21 by Alexis.Matte #jira UE-28473 Make sure light are render properly after importing a fbx scene Change 2951421 on 2016/04/21 by Alexis.Matte #jira UE-29773 fbx skeletalmesh import now support mesh hierarchy Change 2955873 on 2016/04/26 by Richard.TalbotWatkin PR #2225: Fix working package directory from the launch profiles (Contributed by projectgheist) Change 2955965 on 2016/04/26 by Nick.Darnell Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor) Change 2956717 on 2016/04/26 by Andrew.Rodham Editor: World Outliner now correctly calls ProcessEditDelete on editor modes that have asked to process delete operations #jira UE-26968 Change 2956822 on 2016/04/26 by Andrew.Rodham Editor: Fixed actors not being removed from the scene outliner when they are added and removed on the same frame #jira UE-7777 Change 2956931 on 2016/04/26 by Nick.Darnell New Module - UATHelper - Moving the UAT launching code from the MainFrame module into a reusable module other modules can trigger. Change 2956932 on 2016/04/26 by Nick.Darnell Plugins - Now allowing you to package a plugin from the plugin browsing view. Still work in progress. Change 2957164 on 2016/04/26 by Nick.Darnell Hot Reload - Fixing hot reload, it no longer creates a temporary copy of the module manager. Making the copy constructor private on the module manager to prevent this in the future. Change 2957165 on 2016/04/26 by Nick.Darnell Fixing the Editor Mode plugin sample, it no longer provides a bad starting example for where to create your widgets. #jira UE-28456 Change 2957510 on 2016/04/27 by Nick.Darnell PR #2198: Git Plugin implement the Sync operation to update local files using the git pull --rebase command (Contributed by SRombauts) #jira UE-28763 Change 2957511 on 2016/04/27 by Andrew.Rodham Editor: Make favorites button on details panel non-focusable - This was preventing users being able to tab between value fields on the details panel Change 2957610 on 2016/04/27 by Nick.Darnell PR #1836: Git plugin: make initial commit when initializing new project (Contributed by SRombauts) #jira UE-24190 Change 2957667 on 2016/04/27 by Jamie.Dale Fixed crash that could happen in FTextLayout::GetLineViewIndexForTextLocation if passed a bad location #jira OR-18634 Change 2958035 on 2016/04/27 by Nick.Darnell Fixing the DesignerRebuild flag detection so that we can just refresh the slate widget without recreating the preview UObject, which causes the destruction of the details panel, and the slate widget recreation was the only part that was required. Change 2958272 on 2016/04/27 by Jamie.Dale Added FAssetData::GetTagValue to handle getting asset tag values in a type-correct way This allows type-conversion using LexicalConversion, and also has specializations for FString, FText, and FName. #jira UE-12096 Change 2958348 on 2016/04/27 by Jamie.Dale PR #2282: Slate font shutdown order fix (Contributed by FineRedMist) Change 2958352 on 2016/04/27 by Jamie.Dale Fixed the subtitle manager updating the wrong list of subtitles #jira UE-29511 Change 2958390 on 2016/04/27 by Jamie.Dale Removed some old placement-new style array insertions Change 2959360 on 2016/04/28 by Richard.TalbotWatkin Fixed potential crash when mesh painting actors whose geometry adapters are no longer registered. #jira UE-29615 - [CrashReport] UE4Editor_MeshPaint!FEdModeMeshPaint::DoPaint() [meshpaintedmode.cpp:1127] Change 2959724 on 2016/04/28 by Cody.Albert Merging hardware survey gating logic from 4.10 #jira UE-28666 Change 2959807 on 2016/04/28 by Cody.Albert Removed deprecated function call #jira UE-28666 Change 2959894 on 2016/04/28 by Cody.Albert Fix for scroll offset being clamped by content size, not scroll max #jira UE-20676 Change 2960048 on 2016/04/28 by Jamie.Dale Added FAssetData::GetTagValueRef to go along with FAssetData::GetTagValue #jira UE-12096 Change 2960782 on 2016/04/29 by Jamie.Dale Updating code to use the new FText aware asset registry tag functions #jira UE-12096 Change 2960885 on 2016/04/29 by Jamie.Dale Updating code to use the new FText aware asset registry tag functions #jira UE-12096 Change 2961170 on 2016/04/29 by Jamie.Dale Updating code to use the new FText aware asset registry tag functions #jira UE-12096 Change 2961171 on 2016/04/29 by Jamie.Dale Updating code to use the new FText aware asset registry tag functions #jira UE-12096 Change 2961173 on 2016/04/29 by Jamie.Dale Removed some inline duplication on the specialized template functions #jira UE-12096 Change 2963124 on 2016/05/02 by Jamie.Dale FExternalDragOperation can now contain both text and file data at the same time This better mirrors what the OS level drag-and-drop operations are capable of, and some applications will actually give you both bits of data at the same time. #jira UE-26585 Change 2963175 on 2016/05/02 by Jamie.Dale Updated some font editor tooltips to be more descriptive #jira UE-17429 Change 2963290 on 2016/05/02 by Jamie.Dale The Localise UAT command can now be run with a null localisation provider Change 2963305 on 2016/05/02 by Jamie.Dale Fixed minor typo Change 2963402 on 2016/05/02 by Jamie.Dale Cleaned up all the current localization key conflicts and warnings from gathering Engine code #jira UE-25833 Change 2963415 on 2016/05/02 by Jamie.Dale Rephrased a message that could generate a CIS warning #jira UE-25833 Change 2964184 on 2016/05/03 by Jamie.Dale Fixed duplicate "Font" entry in asset picker menu This was caused by PropertyCustomizationHelpers::GetNewAssetFactoriesForClasses using CanCreateNew rather than ShouldShowInNewMenu, as UFont has two factories, but one is supposed to be hidden from the UI. We also now make sure the factories are sorted by display name before being shown in the UI. #jira UE-24903 Change 2966108 on 2016/05/04 by Nick.Darnell Engine - Rearranging the order of ELoadingPhase's enums so that they match the loading order of modules. Change 2966113 on 2016/05/04 by Nick.Darnell [Engine Loop Change] UEngine now defines a Start() function, that subclasses can use to start game related things after initialization of the engine. This is done so that after the Init() call on UEngine, we can then perform a module load for the ELoadingPhase::PostEngineInit phase of loading, then inform the UEngine that it's time to start the game. Therefore, UGameEngine now tells the GameInstance to Start during this phase now. Change 2966121 on 2016/05/04 by Jamie.Dale Config writing improvements when dealing with property values This updates FConfigFile::ShouldExportQuotedString to make sure that a property value containing any characters that FParse::LineExtended will consume when parsing back in the config file (such as { and }, or a trailing \) cause the string to be quoted. This also adds FConfigFile::GenerateExportedPropertyLine to generate the INI key->value lines in a consistent and correctly escaped way, and makes sure that everything that writes out lines to a config file uses it. FConfigCacheIni::SetString and FConfigCacheIni::SetText have been updated to update the value even if it only differs by case. UObject::SaveConfig and UObject::LoadConfig have had some code whitespace fix-up (from a bad merge). Change 2966122 on 2016/05/04 by Jamie.Dale Added a setting to control dialogue wave audio filenames Change 2966481 on 2016/05/04 by Jamie.Dale PR #2336: BUGFIX: Selection of objects in the Content browser from WorldSettings (Contributed by projectgheist) Change 2966887 on 2016/05/04 by Jamie.Dale PR #2336: BUGFIX: Selection of objects in the Content browser from WorldSettings (Contributed by projectgheist) Change 2967488 on 2016/05/05 by Ben.Marsh Changes to support packaging plugins from the editor. * UBT now has an option to explicitly disable hot-reloading in any circumstances. * When running with -module arguments for a monolithic target, UBT will no longer try to relink the executable in source builds (so it's possible to compile plugin libs outside of an installed engine build without having already built UE4Game). * When packaging, a temporary host project is always generated in the output directory to avoid invalidating intermediates in the source directory. * An empty Config\FilterPlugin.ini file is written out with instructions on how to list additional files to package if it is not already present. Change 2967947 on 2016/05/05 by Nick.Darnell PR #2358: Properly display Mip Level Count and Format for UTexture2DDynamic Textures (Contributed by Allegorithmic) #jira UE-30371 Change 2968333 on 2016/05/05 by Jamie.Dale Fixed MultiLine not working with arrays of string or text properties - The detail customizations for FString and FText properties now read the meta-data off the correct property. - The UDS editor now lets you set the "MultiLine" meta-data on arrays of FString and FText properties. - Fixed changing the "MultiLine" flag on a UDS property not rebuilding the default value editor. - Fixed the default values panel in the UDS editor having a title area. #jira UE-30392 Change 2968999 on 2016/05/06 by Jamie.Dale Fixed infinite loop in the editor if a directory that is being watched is deleted #jira UE-30172 Change 2969105 on 2016/05/06 by Richard.TalbotWatkin Fixed issue where opening a submenu while the parent menu had a text box focused would lead to a crash. The graph node comment text widget now only dismisses all menus if the text commit info implies that it was committed by some user action. #jira UE-29086 - Crash When Typing a Node Comment and Hovering Over the Alignment Option Change 2969440 on 2016/05/06 by Jamie.Dale Significant performance improvements when pasting a large amount of text #jira UE-19712 Change 2969619 on 2016/05/06 by Andrew.Rodham Auto-reimport is now disabled inside an editor running in unattended mode Change 2969621 on 2016/05/06 by Jamie.Dale Added the ability to override the subtitle used on a dialogue wave This is useful for effort sounds, plus some other cases, such as characters speaking in a foreign language not known to the player. #jira UETOOL-795 Change 2970588 on 2016/05/09 by Chris.Wood Fix typo in operator expression in UEndUserSettings::SetSendAnonymousUsageDataToEpic() [UE-26958] - GitHub 2056 : Fixing typo in the operator #2056 Change 2971151 on 2016/05/09 by Chris.Wood Logging ensure fails as errors. Automated tests with ensure fails will be unsuccessful. [UE-19579] - If an ensure() fails within an automated test, the test can still show a positive result. [UE-26575] - GitHub 2030 : Add error-severity message to log on ensure. PR #2030 Change 2971267 on 2016/05/09 by Alexis.Matte Wrong parameter when calling GetImportOptions #jira UE-30299 Change 2972073 on 2016/05/10 by Richard.TalbotWatkin Fixed UModel methods which make surfaces as modified. #jira UE-28831 - Unable to undo material placement on BSP Change 2972329 on 2016/05/10 by Nick.Darnell Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor) Change 2972887 on 2016/05/10 by Alexis.Matte #jira UE-30167 We now import the geometric transform also when we uncheck the absolute transform in the vertex. Change 2973664 on 2016/05/11 by Nick.Darnell Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor) Change 2973717 on 2016/05/11 by Nick.Darnell Fixing compiler issues from main merge. #jira UE-30590 Change 2973846 on 2016/05/11 by Jamie.Dale Exposed FConfigValue::ExpandValue and added FConfigValue::CollapseValue These are both static and can be used to expand or collapse the macros used in our config files (mostly when dealing with paths), in code that has to deal with the config system, but isn't internal to the config system (mostly things that deal with default configs outside of UObjects). The old non-static version of FConfigValue::ExpandValue is now FConfigValue::ExpandValueInternal, which just calls FConfigValue::ExpandValue on SavedValue and ExpandedValue. This also changes some code that was using FString.Replace to use FString.ReplaceInline. This reduces allocations, and also allows us to avoid another string comparison to see whether the strings are identical (as ReplaceInline returns the number of replacements that were made). Change 2973847 on 2016/05/11 by Jamie.Dale Changing the loading phase in the localization dashboard now writes to the default config #jira UE-30482 Change 2973866 on 2016/05/11 by Jamie.Dale Deprecated some functions that were taking an unused position. These unused parameters caused confusion and lead to UE-30276. The old versions have been deprecated, and new versions without those parameters have been added. Existing code has been updated to call the non-deprecated version. - FViewportFrame::ResizeFrame - FSceneViewport::ResizeFrame - FSceneViewport::ResizeViewport [CL 2973886 by Nick Darnell in Main branch]
2016-05-11 11:05:13 -04:00
const FString SkeletonName = AssetData.GetTagValueRef<FString>("Skeleton");
return SkeletonName != SelectedSkeletonName;
}
void FSkeletalMeshComponentDetails::SkeletalMeshPropertyChanged()
{
// Update the selected skeleton name and the picker visibility
USkeleton* Skeleton = NULL;
for(auto ObjectIter = SelectedObjects.CreateIterator() ; ObjectIter ; ++ObjectIter)
{
if(USkeletalMeshComponent* Mesh = Cast<USkeletalMeshComponent>(ObjectIter->Get()))
{
if(!Mesh->SkeletalMesh)
{
// One of the selected meshes has no skeletal mesh, stop checking
Skeleton = NULL;
break;
}
else if(!Skeleton)
{
Skeleton = Mesh->SkeletalMesh->Skeleton;
}
else if(Mesh->SkeletalMesh->Skeleton != Skeleton)
{
// There's an incompatible skeleton in the selection, stop checking
Skeleton = NULL;
break;
}
}
}
if(Skeleton)
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
bAnimPickerEnabled = true;
SelectedSkeletonName = FString::Printf(TEXT("%s'%s'"), *Skeleton->GetClass()->GetName(), *Skeleton->GetPathName());
}
else
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
bAnimPickerEnabled = false;
SelectedSkeletonName = "";
}
}
void FSkeletalMeshComponentDetails::RegisterSkeletalMeshPropertyChanged(TWeakObjectPtr<USkeletalMeshComponent> Mesh)
{
if(Mesh.IsValid() && OnSkeletalMeshPropertyChanged.IsBound())
{
OnSkeletalMeshPropertyChangedDelegateHandles.Add(Mesh.Get(), Mesh->RegisterOnSkeletalMeshPropertyChanged(OnSkeletalMeshPropertyChanged));
}
}
void FSkeletalMeshComponentDetails::UnregisterSkeletalMeshPropertyChanged(TWeakObjectPtr<USkeletalMeshComponent> Mesh)
{
if(Mesh.IsValid())
{
Mesh->UnregisterOnSkeletalMeshPropertyChanged(OnSkeletalMeshPropertyChangedDelegateHandles.FindRef(Mesh.Get()));
OnSkeletalMeshPropertyChangedDelegateHandles.Remove(Mesh.Get());
}
}
void FSkeletalMeshComponentDetails::UnregisterAllMeshPropertyChangedCallers()
{
for(auto MeshIter = SelectedObjects.CreateIterator() ; MeshIter ; ++MeshIter)
{
if(USkeletalMeshComponent* Mesh = Cast<USkeletalMeshComponent>(MeshIter->Get()))
{
Mesh->UnregisterOnSkeletalMeshPropertyChanged(OnSkeletalMeshPropertyChangedDelegateHandles.FindRef(Mesh));
OnSkeletalMeshPropertyChangedDelegateHandles.Remove(Mesh);
}
}
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
bool FSkeletalMeshComponentDetails::AnimPickerIsEnabled() const
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
return bAnimPickerEnabled;
}
TSharedRef<SWidget> FSkeletalMeshComponentDetails::GetClassPickerMenuContent()
{
TSharedPtr<FAnimBlueprintFilter> Filter = MakeShareable(new FAnimBlueprintFilter);
Filter->AllowedChildrenOfClasses.Add(UAnimInstance::StaticClass());
FClassViewerModule& ClassViewerModule = FModuleManager::LoadModuleChecked<FClassViewerModule>("ClassViewer");
FClassViewerInitializationOptions InitOptions;
InitOptions.Mode = EClassViewerMode::ClassPicker;
InitOptions.ClassFilter = Filter;
InitOptions.bShowNoneOption = true;
return SNew(SBorder)
.Padding(3)
.BorderImage(FEditorStyle::GetBrush("Menu.Background"))
.ForegroundColor(FEditorStyle::GetColor("DefaultForeground"))
[
SNew(SBox)
.WidthOverride(280)
[
ClassViewerModule.CreateClassViewer(InitOptions, FOnClassPicked::CreateSP(this, &FSkeletalMeshComponentDetails::OnClassPicked))
]
];
}
FText FSkeletalMeshComponentDetails::GetSelectedAnimBlueprintName() const
{
check(AnimationBlueprintHandle->IsValidHandle());
UObject* Object = NULL;
AnimationBlueprintHandle->GetValue(Object);
if(Object)
{
return FText::FromString(Object->GetName());
}
else
{
return LOCTEXT("None", "None");
}
}
void FSkeletalMeshComponentDetails::OnClassPicked( UClass* PickedClass )
{
check(AnimationBlueprintHandle->IsValidHandle());
ClassPickerComboButton->SetIsOpen(false);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
AnimationBlueprintHandle->SetValue(PickedClass);
}
void FSkeletalMeshComponentDetails::OnBrowseToAnimBlueprint()
{
check(AnimationBlueprintHandle->IsValidHandle());
UObject* Object = NULL;
AnimationBlueprintHandle->GetValue(Object);
TArray<UObject*> Objects;
Objects.Add(Object);
GEditor->SyncBrowserToObjects(Objects);
}
void FSkeletalMeshComponentDetails::UseSelectedAnimBlueprint()
{
FEditorDelegates::LoadSelectedAssetsIfNeeded.Broadcast();
USelection* AssetSelection = GEditor->GetSelectedObjects();
if (AssetSelection && AssetSelection->Num() == 1)
{
UAnimBlueprint* AnimBlueprintToAssign = AssetSelection->GetTop<UAnimBlueprint>();
if (AnimBlueprintToAssign)
{
if(USkeleton* AnimBlueprintSkeleton = AnimBlueprintToAssign->TargetSkeleton)
{
FString BlueprintSkeletonName = FString::Printf(TEXT("%s'%s'"), *AnimBlueprintSkeleton->GetClass()->GetName(), *AnimBlueprintSkeleton->GetPathName());
if (BlueprintSkeletonName == SelectedSkeletonName)
{
OnClassPicked(AnimBlueprintToAssign->GetAnimBlueprintGeneratedClass());
}
}
}
}
}
#undef LOCTEXT_NAMESPACE