Files
UnrealEngineUWP/Engine/Source/Editor/AnimGraph/Private/AnimationStateMachineSchema.cpp

448 lines
16 KiB
C++
Raw Normal View History

// Copyright 1998-2017 Epic Games, Inc. All Rights Reserved.
/*=============================================================================
AnimationStateMachineSchema.cpp
=============================================================================*/
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "AnimationStateMachineSchema.h"
#include "Layout/SlateRect.h"
#include "Animation/AnimationAsset.h"
#include "Framework/MultiBox/MultiBoxBuilder.h"
#include "EdGraph/EdGraph.h"
#include "Kismet2/BlueprintEditorUtils.h"
#include "EdGraphNode_Comment.h"
#include "AnimationStateMachineGraph.h"
#include "AnimationGraphSchema.h"
#include "AnimStateEntryNode.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "AnimStateNodeBase.h"
#include "AnimStateNode.h"
#include "AnimStateTransitionNode.h"
#include "AnimStateConduitNode.h"
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3050254 on 2016/07/14 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614 Change 3136629 on 2016/09/22 by Marc.Audy bye bye auto Change 3136631 on 2016/09/22 by Marc.Audy Allow objects to be marked as duplicate transient or non PIE duplicate transient ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient #jira UE-35680 Change 3136636 on 2016/09/22 by Marc.Audy ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints Component Activate/Deactivate events now provide component as a property #jira UE-35191 Change 3136640 on 2016/09/22 by Marc.Audy Expose bReplicates to blueprint component properties #jira UE-34433 Change 3136709 on 2016/09/22 by Ori.Cohen Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached. #JIRA UE-36234 Change 3136710 on 2016/09/22 by Ori.Cohen Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together. #JIRA UE-35899 Change 3136770 on 2016/09/22 by Marc.Audy Fix compile error Change 3136854 on 2016/09/22 by Marc.Audy Sprite components need to be text export transient #jira UE-36064 Change 3136926 on 2016/09/22 by Ori.Cohen Fix ensure when skeletal mesh bodies have no collision. Change 3137054 on 2016/09/22 by Aaron.McLeran PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes) Change 3137058 on 2016/09/22 by Aaron.McLeran PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet) Change 3137060 on 2016/09/22 by Aaron.McLeran UE-36336 Fixing A3D for mono/2D sounds - Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds - Fixing A3D mono sources from failing after a time Change 3137066 on 2016/09/22 by Aaron.McLeran Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0 Change 3137098 on 2016/09/22 by dan.reynolds AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process. Change 3137132 on 2016/09/22 by Aaron.McLeran PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge) Change 3137175 on 2016/09/22 by Aaron.McLeran Fixing compile error with PhysXCollision.cpp from CL 3136710 Change 3137540 on 2016/09/23 by Thomas.Sarkanen Fixed crash when generating LODs automatically for skeletal meshes Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification. #jira UE-36253 - Crash applying LOD changes in Persona Change 3137720 on 2016/09/23 by Thomas.Sarkanen Changed asset shortcut bar to display asset names & reworked padding #jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text Change 3137761 on 2016/09/23 by Martin.Wilson Fix typo in root motion from everything accumulation code Change 3137877 on 2016/09/23 by Thomas.Sarkanen Fixed undo/redo forcing skeletal meshes into t-pose Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent. #jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function Change 3137885 on 2016/09/23 by Benn.Gallagher Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect. #jira UE-35151 Change 3137888 on 2016/09/23 by Benn.Gallagher Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links #jira UE-24860 Change 3137889 on 2016/09/23 by Benn.Gallagher Fixed transform and widget inconsistencies in IK edit mode #jira UE-20628 Change 3137890 on 2016/09/23 by Jurre.deBaare Alembic Cached Geometry Does Not Display in Stand Alone Game #fix required to force load the GeometryCache module during runtime #jira UE-36187 Change 3137892 on 2016/09/23 by Jurre.deBaare Geometry cache playback should work in sequencer #fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway) #jira UE-35447 Change 3137893 on 2016/09/23 by Jurre.deBaare Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals #fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence #jira UE-35091 Change 3137894 on 2016/09/23 by Jurre.deBaare Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor #fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created #misc added a new check + message in case this occurs again #jira UE-36059 Change 3137938 on 2016/09/23 by Jurre.deBaare Alembic Importing with Incorrect UV's #fix adding option for flipping UVs on import #jira UE-36190 Alembic import axis not aligned correctly #fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max) #jira UE-35510 Change 3137949 on 2016/09/23 by Jurre.deBaare Frame range importing causes confusion during Alembic importing #fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames. #misc changed settings UI listview layout (extra columns and resized old ones) #jira UE-35498 Change 3137994 on 2016/09/23 by Martin.Wilson Fix for creating an empty state when dragging a montage into a state machine graph #jira UE-33371 Change 3138103 on 2016/09/23 by Aaron.McLeran UE-36312 Fixing sound node distance cross fade for case of looping sounds Change 3138104 on 2016/09/23 by Aaron.McLeran UE-35392 Copy pasting local node into separate project crashes the engine Change 3138224 on 2016/09/23 by Aaron.McLeran UE-36312 Fixing sound node distance cross fade for case of looping sounds - Adding a check for wave instance count to account for virtualized sounds (one-shots) Change 3138666 on 2016/09/23 by Ben.Zeigler #UEFW-204 Add more comprehensive gameplay tag tests Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon Change 3138779 on 2016/09/23 by Marc.Audy Get rid of pointless casts Change 3138782 on 2016/09/23 by Marc.Audy remove some GWorlds Change 3139701 on 2016/09/26 by Jurre.deBaare Assert failed on GemetryCache for PS4 package #fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files #jira UE-36392 Change 3139704 on 2016/09/26 by Jurre.deBaare Fix for -1 begin frame #fix do the max as an signed int, to make sure we don't wrap around Change 3139748 on 2016/09/26 by Benn.Gallagher PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri) Moved the definition of the boundary to a FPhysScene class static Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary #jira UE-35736 Change 3139903 on 2016/09/26 by Benn.Gallagher Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values #jira UE-34366 Change 3140409 on 2016/09/26 by Lukasz.Furman fixed uninitialized configs of gameplay debugger copy of CL# 3140399 Change 3140516 on 2016/09/26 by dan.reynolds AEOverview Map Update - Ambient Zone + Focus Test Change 3140526 on 2016/09/26 by Jon.Nabozny #rn Fixed CanJump inconsistencies with previous versions. Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how jump count and hold time were compared in CanJump. #jira UE-35524, UE-35582 Change 3140745 on 2016/09/26 by dan.reynolds AEOverview Test Map Update + Occlusion Test Change 3140839 on 2016/09/26 by dan.reynolds AEOverview - minor updates Change 3141101 on 2016/09/27 by Thomas.Sarkanen Preview scene worlds now render correctly Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index). In-game hidden flags now apply to GamePreview, but not EditorPreview worlds. Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose. Fixed up UT cases where this was being used. FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport). Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview. Fixed erroneous use of TEnumAsByte for non-uproperty WorldType. #jira UE-22883 - Using FPreviewScenes in-game for scene captures Change 3141106 on 2016/09/27 by Thomas.Sarkanen Column toggling improvements Column toggle menu now does not close when items are selected. This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection. Also allowed columns to be hidden by default for specific use cases (like the sequence browser). #jira UE-35818 - Anim asset browser column picker should stay up Change 3141131 on 2016/09/27 by Thomas.Sarkanen Fix CIS warnings Fallout from preview world changes Change 3141143 on 2016/09/27 by Jurre.deBaare Fix for CIS errors Change 3141235 on 2016/09/27 by Thomas.Sarkanen Fix offset of Persona floor mesh when auto-alignment is enabled When auto alignment was disabled, the offset wasnt getting taken into account. #jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled Change 3141327 on 2016/09/27 by Marc.Audy Ensure that the client side AttachChildren array remains accurate #jira UE-26025 Change 3141474 on 2016/09/27 by mason.seay Updating test map name and moving PlayerStart Change 3141501 on 2016/09/27 by Benn.Gallagher Loading time improvements for destructibles from Nvidia Updated to use new framework custom version instead of global object version Fixed usage of TArray to enable correct loading and saving of the cached data. #jira UE-29680 Change 3141889 on 2016/09/27 by Marc.Audy Fix DestructibleMesh when WITH_APEX is 0 #jira UE-36484 Change 3142034 on 2016/09/27 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971 Change 3142131 on 2016/09/27 by Ori.Cohen Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query. #JIRA UE-36381 Change 3142154 on 2016/09/27 by Ori.Cohen Fix build, ModuleCachedData instead of NxApexModuleCachedData Change 3142159 on 2016/09/27 by mason.seay Blueprint for testing Child Actor Templates Change 3142255 on 2016/09/27 by Jon.Nabozny Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument. #jira UE-35199, UE-35197, UE-35201 Change 3142717 on 2016/09/27 by dan.reynolds AEOverview Update + Sound Class Test Change 3142764 on 2016/09/27 by Marc.Audy Fix Ocean deprecation warnings Change 3142962 on 2016/09/28 by Thomas.Sarkanen Fixed bounds calculations for local camera animations Correctly calculated bounds as local to the initial transform in the track. Implemented suggested fixes from UDN user chhaddon (The Coalition). #jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true Change 3143007 on 2016/09/28 by Martin.Wilson Added virtual bones to USkeleton API Breaking change: -Added USkeleton pointer to RemoveBonesByName -FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead #jira UEFW-81 Change 3143040 on 2016/09/28 by James.Golding Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG Fix up game projects to compile in Shipping/Test after this change PR #2757: (Contributed by projectgheist) #jira UE-35488 Change 3143046 on 2016/09/28 by James.Golding Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file) Change 3143047 on 2016/09/28 by James.Golding PR #2731: Capsule primitive drawing fix (Contributed by kamrann) #jira UE-35142 Change 3143050 on 2016/09/28 by Martin.Wilson Update DDC key as some animation have stale data Change 3143088 on 2016/09/28 by Martin.Wilson CIS Fixes for Ocean after FReferenceSkeleton changes Change 3143090 on 2016/09/28 by Benn.Gallagher Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it. #jira UE-36482 Change 3143091 on 2016/09/28 by Thomas.Sarkanen Fix play/pause keyboard shortcut toggle in Persona based editors Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks). Added the ability for FEdModes to specify whether they can use a widget mode. Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now). #jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused Change 3143100 on 2016/09/28 by James.Golding UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown Change 3143107 on 2016/09/28 by Martin.Wilson Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us #jira UE-34431 Change 3143125 on 2016/09/28 by Jurre.deBaare PR #2749: Fix blend space triangulation (Contributed by tmiv) Change 3143225 on 2016/09/28 by Jurre.deBaare Mesh/material merging basic test files Change 3143235 on 2016/09/28 by Martin.Wilson Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section #jira UE-35929 Change 3143312 on 2016/09/28 by Marc.Audy Don't globally reregister components, globally recreate render state instead when force deleting assets Fixes crash force deleting a blueprint with a child actor component in it from the content browser Change 3143340 on 2016/09/28 by Mieszko.Zielinski Improved consistency of loudness usage in AISense_Hearing #UE4 Change 3143359 on 2016/09/28 by Marc.Audy Fix spelling error in comment Change 3143372 on 2016/09/28 by Jurre.deBaare HLOD meshes are causing degenerate triangles #fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers #jira UE-34336 Change 3143420 on 2016/09/28 by Mieszko.Zielinski Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4 Change 3143421 on 2016/09/28 by Martin.Wilson Allow reading on animation sequence length in blueprints #jira UE-34168 Change 3143455 on 2016/09/28 by James.Golding Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds. Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions Change 3143518 on 2016/09/28 by Jurre.deBaare Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material #fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material) #misc set texture sampling for HLOD proxy base material to clamp #jira UE-35221 Change 3143542 on 2016/09/28 by James.Golding Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if Fix comment Enable by default for FN Change 3143543 on 2016/09/28 by Benn.Gallagher Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton. Change 3143556 on 2016/09/28 by Aaron.McLeran UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE Change 3143566 on 2016/09/28 by Benn.Gallagher Readded early out alongside new ensure for catching bad preFilter shapes Change 3143568 on 2016/09/28 by Marc.Audy Fix deprecation warnings in UT Change 3143572 on 2016/09/28 by Jurre.deBaare More test content for mesh/material merging Change 3143581 on 2016/09/28 by Jurre.deBaare More content :D Change 3143585 on 2016/09/28 by Jurre.deBaare Geometry cache cleaning #misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump) #misc cleaning out unecessary code Change 3143594 on 2016/09/28 by Marc.Audy Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template #jira UE-36511 Change 3143658 on 2016/09/28 by Marc.Audy RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference #jira UE-36553 Change 3143776 on 2016/09/28 by Marc.Audy Properly reinstance child actor templates when using the fast reinstancing path #jira UE-36516 Change 3143896 on 2016/09/28 by Ori.Cohen Remove UPROPERTY on aggregate threshold which is always read from the physics settings. Change 3144022 on 2016/09/28 by Ben.Zeigler Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system Change 3144252 on 2016/09/28 by mason.seay More blueprints for child actor template testing Change 3144262 on 2016/09/28 by Mason.Seay Deleting assets Change 3144283 on 2016/09/28 by dan.reynolds AEOverview update + Sound Priority Test Change 3144411 on 2016/09/28 by dan.reynolds AEOverview end of day update and tweaks Change 3144679 on 2016/09/29 by Benn.Gallagher Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth. Change 3144856 on 2016/09/29 by Jurre.deBaare HLOD Outliner scrolls back to the top when generating proxy meshes #fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview #jira UE-30384 Change 3144864 on 2016/09/29 by Thomas.Sarkanen Preview mesh fixes Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen). Skeleton preview meshes are now shown as empty if none is set (but a default is chosen). #jira UE-36582 - Cannot set preview mesh per-animation Change 3144865 on 2016/09/29 by Jurre.deBaare More test content Change 3144885 on 2016/09/29 by James.Golding UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor Change scale clamping in UpdateBodyScale to catch cases like (1,0,1) Change 3144903 on 2016/09/29 by Thomas.Sarkanen Deprecating StaticMesh in UStaticMeshComponent Added GetStaticMesh to access the value as read-only. SetStaticMesh is now called in all locations that used to call "StaticMesh =". Lots of fixups. #jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent Change 3145020 on 2016/09/29 by Thomas.Sarkanen Fix bounds calculations that include bones to respect LOD (and other requried bones) Sometimes bones would not be updated if we LOD switched, extending the bounds. #jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD Change 3145041 on 2016/09/29 by Jurre.deBaare Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results #fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh #misc ignore the source lightmap uv channels to reduce data #jira UE-36595 Change 3145219 on 2016/09/29 by Benn.Gallagher Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time. #jira UE-36552 Change 3145222 on 2016/09/29 by Jurre.deBaare Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash #fix on import set _all_ bone influence to 0 #jira UE-36602 Change 3145267 on 2016/09/29 by Ori.Cohen Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults. #JIRA UE-36483 Change 3145306 on 2016/09/29 by Jon.Nabozny Fixed PhAT so multiple constraints can be selected and edited properly at the same time. #JIRA: UE-31493 Change 3145342 on 2016/09/29 by Marc.Audy Do not update cull distance volumes whenever any property changes * Any movement or property change of a cull distance volume still does a global update * Any movement of a component belong to any other Actor updates only the components of that Actor * Any property change of a primitive component only updates that component #jira UE-36399 Change 3145958 on 2016/09/29 by Marc.Audy In game worlds don't auto activate components until the actor is ready to process them #jira UE-35189 Change 3146110 on 2016/09/29 by dan.reynolds AEOverview update + Soundwave Procedural Test Map Change 3146375 on 2016/09/30 by Benn.Gallagher Fixed crash saving newly created destructible mesh after material refactor. #jira UE-36619 Change 3146378 on 2016/09/30 by James.Golding UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before) Also add stat for FBodyInstance::LineTrace Change 3146379 on 2016/09/30 by James.Golding Add test assets for creating procmesh collision in non-editor builds Change 3146386 on 2016/09/30 by Thomas.Sarkanen Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance. This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used. #jira UE-36251 - Ensures showing uncompressed animations in anim blueprints Change 3146464 on 2016/09/30 by Thomas.Sarkanen Fix layered blend per bone odd/even connection counts alternately working/not working Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName. #jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs Change 3146652 on 2016/09/30 by Benn.Gallagher Fixed subinstance properties appearing in the caller's details panel as oddly named properties. #jira UE-34141 Change 3146673 on 2016/09/30 by Martin.Wilson Make RawAnimationData (and associated anim sequence data) private #jira ue-25869 Change 3146680 on 2016/09/30 by Benn.Gallagher Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node #jira UE-29847 Change 3146681 on 2016/09/30 by Benn.Gallagher Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node #jira UE-30885 Change 3146711 on 2016/09/30 by Jon.Nabozny Fix PhAT SnapConstraintToBone. #jira UE-31491 Change 3146717 on 2016/09/30 by Danny.Bouimad Adding Jurres really useful merge actor test assets to somewhere QA can get em. Change 3146738 on 2016/09/30 by Martin.Wilson Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1 #tests Editor tests with mambo pose asset #jira UE-36189 Change 3146750 on 2016/09/30 by Jurre.deBaare Material baking issue #misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture) #misc Replaced incorrect masks with _way_ better approach thanks to Martin Change 3146755 on 2016/09/30 by Jurre.deBaare Need better progress bar for HLOD #fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback #jira UE-34334 Change 3147085 on 2016/09/30 by Marc.Audy PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay) #jira UE-36632 Change 3147224 on 2016/09/30 by Martin.Wilson CIS Fix Change 3147280 on 2016/09/30 by Marc.Audy Mouse smoothing should use application frame rate, not the dilated game frame rate #jira UE-31040 Change 3147446 on 2016/09/30 by Aaron.McLeran UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly Change 3147693 on 2016/09/30 by Ben.Zeigler #jira UE-36657 If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location Change 3147697 on 2016/09/30 by Jon.Nabozny Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX #jira UE-30486 Change 3147761 on 2016/09/30 by Jon.Nabozny Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage. Change 3148533 on 2016/10/03 by Thomas.Sarkanen Fix new deprecation warnings introduced by the pull from main Change 3148567 on 2016/10/03 by Marc.Audy Fix crash when exiting PIE while a panoramic screenshot is being taken Make stereo panorama tick with the world it is operating on #jira UE-36492 Change 3148571 on 2016/10/03 by Marc.Audy Allow modification of components that are EditAnywhere but don't exist in the CDO #jira UE-36694 Change 3148607 on 2016/10/03 by Martin.Wilson Properly end notify states when we clear the anim instance on a skeletal mesh. #jira UE-32488 Change 3148711 on 2016/10/03 by Martin.Wilson Fix type in virtual bone tooltip #jira UE-36703 Change 3148746 on 2016/10/03 by Benn.Gallagher Fixed a few cases where post process and sub instance anim calls weren't being made correctly. #jira UE-36529 Change 3148807 on 2016/10/03 by Martin.Wilson Fix mismatch skeleton error when undoing virtual bone changes #jira UE-36705 Change 3148812 on 2016/10/03 by Martin.Wilson Add undo support to removing virtual bones #jira UE-36706 Change 3148975 on 2016/10/03 by Jurre.deBaare Issue with combining meshes both with/without normal maps #fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect) #misc fixed issue in function to set texture rectangle to a single colour #misc spotted comparison error Change 3148976 on 2016/10/03 by Ori.Cohen Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs #JIRA UE-36639 Change 3148991 on 2016/10/03 by Jurre.deBaare Changing LOD materials on Merged Actors Crashes Editor #fix take into account LOD that is using the material when remapping (removing duplicate) materials #jira UE-35883 Change 3148997 on 2016/10/03 by Jurre.deBaare Make sure we remove matrix samples that fall outside of the import range and remap those that are in range Change 3149002 on 2016/10/03 by Jurre.deBaare Issues with importing Alembic caches using matrix transformations #fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from Change 3149030 on 2016/10/03 by Martin.Wilson Dont show save warning on animations when we have curve data #jira UE-34145 Change 3149115 on 2016/10/03 by Mieszko.Zielinski Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4 #jira UE-35153 Change 3149186 on 2016/10/03 by Ben.Zeigler #UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it. This code is weird but this solution is better than the old version and handles inconsistent results Change 3149235 on 2016/10/03 by Martin.Wilson Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself. #jira UE-20005 Change 3149245 on 2016/10/03 by Marc.Audy Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates. Change 3149397 on 2016/10/03 by Ori.Cohen Fix collision profile writing out response values to channels that don't exist. #JIRA UE-36359 Change 3149679 on 2016/10/03 by Zak.Middleton #ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category. Change 3149929 on 2016/10/04 by Jurre.deBaare Fix for CIS errors #fix Mac didn't like undefined struct Change 3149977 on 2016/10/04 by danny.bouimad Massive update to Merge Actor test files Change 3150014 on 2016/10/04 by James.Golding UE-36686 Fix crash when slicing and not creating other section Change 3150016 on 2016/10/04 by James.Golding UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging Change 3150019 on 2016/10/04 by James.Golding UE-36737 Fix LineTraceComponent not returning face index Change 3150020 on 2016/10/04 by James.Golding UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module Change 3150027 on 2016/10/04 by Ben.Marsh Add PhysX build option into Dev-Framework. Change 3150042 on 2016/10/04 by Benn.Gallagher Fixed clothing example 1.3 collision glitches Change 3150172 on 2016/10/04 by Benn.Gallagher Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them. #jira UE-36589 Change 3150319 on 2016/10/04 by Ori.Cohen Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future. #JIRA UE-36535, UE-36504 Change 3150355 on 2016/10/04 by Zak.Middleton #ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast. Change 3150370 on 2016/10/04 by Ori.Cohen Fix deferred actors not getting flushed. Change 3150386 on 2016/10/04 by Martin.Wilson Fix additive animation check failing in cooked builds when using virtual bones #jira UE-36743 Change 3150424 on 2016/10/04 by Ori.Cohen Exclude kinematic actors from active transforms generation. Change 3150613 on 2016/10/04 by Zak.Middleton #ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject. (Mirror CL 3138304 in Orion-DevGeneral) #jira UE-36810 #tests compiled Change 3150679 on 2016/10/04 by Ben.Zeigler Crash fix with no async scene Change 3150765 on 2016/10/04 by Ben.Zeigler Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing Change 3150796 on 2016/10/04 by Marc.Audy Fix LOCTEXT warnings related to blueprint class menu options Change 3150806 on 2016/10/04 by Ben.Zeigler Fix bad text format in import error message, lead to double error Change 3150891 on 2016/10/04 by Ben.Zeigler #jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global Change 3150914 on 2016/10/04 by Marc.Audy Don't try to recreate render state if it has already been recreated while the recreate context was active #jira UE-36590 Change 3151195 on 2016/10/04 by Dan.Reynolds Updates to QASoundWaveProcedural QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing. Change 3151233 on 2016/10/04 by Ben.Zeigler #jira UE-36836 Fix variable shadowing warnings Change 3151328 on 2016/10/04 by dan.reynolds AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP Change 3151461 on 2016/10/05 by Thomas.Sarkanen Fix localization warnings #jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings Change 3151546 on 2016/10/05 by Martin.Wilson Fix pose watch regression due to persona refactor changes. #jira UE-36851 Change 3151587 on 2016/10/05 by Jurre.deBaare Updating Simplygon to SDK version 8.0 #misc removed redundant files #misc fixed landscape culling in merge actor path #misc added support for volume culling using simplygon #misc fixed when or not to use mesh data for material baking #notes Change: 3137650 Date: 23/09/2016 07:57 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: -Renamed commandline variables for ZipUtils AutomationScript -Implemented Execute instead of ExecuteBuild -Updated commandline arguments in SimplygonSwarm JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4 //UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2 Change: 3137649 Date: 23/09/2016 07:56 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Moved file hash computation to ImportObject JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4 Change: 3137646 Date: 23/09/2016 07:55 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Fixes CL3099204 EditorPerProjectUserSetting Removed ConfigRestartRequired attribute from properties where it was not required MeshUtilities -Added FProxyFailedDelegate -Extended IMeshMerging to include FProxyFailed delegate -Added ProxyGenerationFailed method to FProxyGenerationProcessor class -Setup FailedDelegate for both MeshMerging and DistributedMeshMerging SimplygonMeshReduction -Added check for invalid texture id -Updated notes and removed commented code that is not required. -Setup failed delegate -Fixed issue where image data was never hooked into the texture. -Fixed issue where texture table was never passed into casters SimplygonSwarm -Setup failed delegate -Fixed RawMesh pointer usage. -Move helper method into SimplygonSwarmHelpers.h. -Added SimplygonSwarmHelpers -Removed redundant constant path to 7-zip -Removed GetSimplygonDirectory instead using inplace. -Removed commented code that is currently not required. -Fixed Typos JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3 Change: 3099204 Date: 24/08/2016 07:56 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Simplygon 8.0 Updates Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0 EditorPerProjectSettings *SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB *SwarmNumOfConcurrentJobs for executing number of concurrent jobs *Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK) SPL, SimplygonSwarm, RESTClient *Bumped up SPL Version to 8 *Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374 *Removed SPL Templates for version 7.0 *Added conditional logging to REST methods *Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid. *Updated method to take in texturepath SimplygonMeshReduction *Removed minimum version requirement. *Bumped up minimum version *Chagned license file name to refelect 8.0 changes *MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch. JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2 Change: 3099200 Date: 24/08/2016 07:48 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: #fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2 Change: 3099199 Date: 24/08/2016 07:47 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm. This will remove any dependency on external zip program and should work across platforms JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1 Change: 3099197 Date: 24/08/2016 07:40 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: *Speed improvements for FBX Scene Importer *Added a static method to compute Hash. JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2 Change 3151664 on 2016/10/05 by Richard.Hinckley Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member. Change 3151729 on 2016/10/05 by Thomas.Sarkanen Audit of remaining NaN checks Some checks remain on in shipping (generally those called from blueprint): - AActor::TeleportTo - AActor::SetActorRelativeScale3D #jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test Change 3151742 on 2016/10/05 by Ori.Cohen Make sure that if physical animation component doesn't find a body and bone it doesn't crash. #JIRA UE-36839 Change 3151756 on 2016/10/05 by Jurre.deBaare Fixing d3dcompiler_47.dll missing issue #fix added runtime dependency and dll name to build.cs file #fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL Change 3151761 on 2016/10/05 by Thomas.Sarkanen Fix deprecation warning from last integration Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd. #jira UE-36858 - Compile UE4Editor* completed with 1 warning Change 3151782 on 2016/10/05 by Jurre.deBaare Simplygon patch up #misc linker errors popping up from JSONCPP #misc incorporated emissive material property fix from other shelve #misc static analysis fix Change 3151804 on 2016/10/05 by Marc.Audy Clear need end of frame update when unregistering a component Change 3151928 on 2016/10/05 by Ori.Cohen Fix runtime DLLs not including all delay loaded physx dll files. #JIRA UE-36816 Change 3151977 on 2016/10/05 by Martin.Wilson Notifies can no longer occupy the same time on the same track. #jira UE-30658 Change 3151989 on 2016/10/05 by Jon.Nabozny Fix ArchVis character rotation pitch when looking up/down. #jira UE-35706 Change 3152083 on 2016/10/05 by Marc.Audy Ensure that pending kill components get their marked for end of frame state cleared. Change 3152086 on 2016/10/05 by Ben.Zeigler #jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid Change 3152093 on 2016/10/05 by Marc.Audy Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load). #jira UE-36146 #jira UE-24647 Change 3152100 on 2016/10/05 by Ben.Zeigler Remove pragma optmize Change 3152112 on 2016/10/05 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072 Change 3152134 on 2016/10/05 by Jurre.deBaare Simplygon/Merge actor issues #fix for emissive output on meshes that do not have emissive properties #fix for texture binning, not removing invalid split area causing overlapped textures Change 3152136 on 2016/10/05 by James.Golding UE-36859 Fix tooltip saying you can click to stop recording Change 3152169 on 2016/10/05 by James.Golding UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh Change 3152202 on 2016/10/05 by Jurre.deBaare Mac/Linux fix Change 3152303 on 2016/10/05 by Marc.Audy Fix deprecation warning post merge from main Change 3152320 on 2016/10/05 by Martin.Wilson Fix root motion from everything calculating incorrect root motion when animations haven't been ticking #jira UE-35364 Change 3152354 on 2016/10/05 by James.Golding PoseDriver should pass through if no poses activated Change 3152357 on 2016/10/05 by James.Golding UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim. Change 3152556 on 2016/10/05 by Marc.Audy Remove autos Change 3152560 on 2016/10/05 by Marc.Audy Don't allow child actor references to be dragged from the outliner to a level script #jira UE-16700 Change 3152568 on 2016/10/05 by Marc.Audy Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters Remove deprecated bNoCollisionFail #jira UE-35928 Change 3152575 on 2016/10/05 by Marc.Audy Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move Change 3153101 on 2016/10/06 by Thomas.Sarkanen Fix crash re-opening the viewport in Persona-based editors #jira UE-36775 - Editor crashes when re-opening viewport in Persona Change 3153139 on 2016/10/06 by James.Golding UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported Change 3153160 on 2016/10/06 by Thomas.Sarkanen Fix for crash when deleting additive layer track Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr). #jira UE-36740 - Crash when removing or disabling an additive layer track in Persona Change 3153175 on 2016/10/06 by Benn.Gallagher Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed. #jira UE-36900 Change 3153223 on 2016/10/06 by Thomas.Sarkanen Fixed crash when opening an asset from the blend space editor Code was still trying to open 'old' Persona when it was disabled. Also fix other call sites where this was being done outside of asset type actions. #jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona Change 3153324 on 2016/10/06 by Thomas.Sarkanen Prevented invalid GUIDs from being saved into smart name containers AddOrFindName now checks to see if existing GUIDs are valid before using them. AddName now requires a valid GUID to be passed in. Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved. Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068). #jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset Change 3153348 on 2016/10/06 by Martin.Wilson Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor) #jira UE-36751 Change 3153426 on 2016/10/06 by Mieszko.Zielinski Added missing elements of block comments support in BT editor #UE4 Change 3153454 on 2016/10/06 by Benn.Gallagher Fixed crash using anim debug with subinstances that are preceded by branching nodes. #jira UE-36935 [CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
#include "AnimGraphNode_AssetPlayerBase.h"
#include "ScopedTransaction.h"
#include "GraphEditorActions.h"
#include "EdGraphUtilities.h"
#include "Kismet2/KismetEditorUtilities.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "Framework/Commands/GenericCommands.h"
#define LOCTEXT_NAMESPACE "AnimationStateMachineSchema"
/////////////////////////////////////////////////////
TSharedPtr<FEdGraphSchemaAction_NewStateNode> AddNewStateNodeAction(FGraphContextMenuBuilder& ContextMenuBuilder, const FText& Category, const FText& MenuDesc, const FString& Tooltip, const int32 Grouping = 0)
{
TSharedPtr<FEdGraphSchemaAction_NewStateNode> NewStateNode( new FEdGraphSchemaAction_NewStateNode(Category, MenuDesc, Tooltip, Grouping) );
ContextMenuBuilder.AddAction( NewStateNode );
return NewStateNode;
}
/////////////////////////////////////////////////////
// FEdGraphSchemaAction_NewStateNode
UEdGraphNode* FEdGraphSchemaAction_NewStateNode::PerformAction(class UEdGraph* ParentGraph, UEdGraphPin* FromPin, const FVector2D Location, bool bSelectNewNode/* = true*/)
{
UEdGraphNode* ResultNode = NULL;
// If there is a template, we actually use it
if (NodeTemplate != NULL)
{
const FScopedTransaction Transaction( NSLOCTEXT("UnrealEd", "K2_AddNode", "Add Node") );
ParentGraph->Modify();
if (FromPin)
{
FromPin->Modify();
}
// set outer to be the graph so it doesn't go away
NodeTemplate->Rename(NULL, ParentGraph);
ParentGraph->AddNode(NodeTemplate, true, bSelectNewNode);
NodeTemplate->CreateNewGuid();
NodeTemplate->PostPlacedNewNode();
NodeTemplate->AllocateDefaultPins();
NodeTemplate->AutowireNewNode(FromPin);
NodeTemplate->NodePosX = Location.X;
NodeTemplate->NodePosY = Location.Y;
//@TODO: ANIM: SNAP_GRID isn't centralized or exposed - NodeTemplate->SnapToGrid(SNAP_GRID);
ResultNode = NodeTemplate;
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720406 on 2015/10/07 by Aaron.McLeran Audio optimization Don't search for nearest listener if there's only 1 listener. Change 2720411 on 2015/10/07 by Aaron.McLeran Fixing HRTF spatialization code with recent changes to stereo spatialization. HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates. Change 2723829 on 2015/10/09 by Mieszko.Zielinski Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4 UE-21880 Change 2723873 on 2015/10/09 by Mieszko.Zielinski Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4 UE-21977 Change 2724834 on 2015/10/12 by Ori.Cohen PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk) Change 2724850 on 2015/10/12 by Marc.Audy Fix sound not restarting in matinee preview when jumping back along timeline after reaching end #codereview Nick.Darnell Change 2726499 on 2015/10/13 by Ori.Cohen Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1 Change 2726689 on 2015/10/13 by Marc.Audy Make UPackage::PackageFlags private Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor #codereview Mike.Fricker Change 2726862 on 2015/10/13 by Lukasz.Furman removed unused code from DetourNavMeshQuery #ue4 UE-21988 Change 2726888 on 2015/10/13 by Lukasz.Furman fixed observer abort: both mode in behavior tree's cone check decorator #ue4 UE-19375 Change 2726913 on 2015/10/13 by Lukasz.Furman navmesh raycast will use nearest poly containing ray origin instead of just closest one #ue4 UE-19334 Change 2726920 on 2015/10/13 by Marc.Audy Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName #codereview Dmitriy.Dyomin, Bob.Tellez Change 2726931 on 2015/10/13 by Lukasz.Furman fixed missing Tick event in aborting behavior tree tasks from abandoned subtree #ue4 UE-21777 Change 2728093 on 2015/10/14 by Ori.Cohen Fix edge case of sphyl scale take two. The previous approach did double scaling Change 2728577 on 2015/10/14 by Mieszko.Zielinski Improved navmesh labeling condition #UE4 Change suggested by github user #rb Lukasz.Furman Change 2728587 on 2015/10/14 by Lukasz.Furman fixed crowd simulation for auto possessed pawns placed on level #ue4 #rb Mieszko.Zielinski Change 2728629 on 2015/10/14 by Lukasz.Furman fixed influence of navmesh edges on crowd simulation near end of path #ue4 UE-21380 #rb Mieszko.Zielinski Change 2728678 on 2015/10/14 by Lukasz.Furman added Z check to detour's crowd avoidance segment gathering #ue4 UE-20889 #rb Mieszko.Zielinski Change 2728745 on 2015/10/14 by Lukasz.Furman fixed copy&paste operation in behavior tree's composite decorators subgraphs #ue4 UE-18740 Change 2729276 on 2015/10/14 by Stan.Melax ensure all actors get recreated with new collision shape specification. this wasn't being done for a couple of editing methods. todo: this should be merged into 4.10 #UE-20961 #rb ori.cohen Change 2730709 on 2015/10/15 by Marc.Audy Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions #rb Lina.Halper Change 2733590 on 2015/10/19 by Benn.Gallagher Fixed various crashes when using undo and redo while manipulating state machines UE 22088 Change 2735143 on 2015/10/20 by Lukasz.Furman clearing behavior tree debugger's state when displayed subtree becomes inactive #ue4 #rb Mieszko.Zielinski Change 2735144 on 2015/10/20 by Lukasz.Furman rebuilding behavior tree graph node order when node is being moved #ue4 #rb Mieszko.Zielinski Change 2735403 on 2015/10/20 by sebastian.kowalczyk Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform). Change 2736406 on 2015/10/21 by sebastian.kowalczyk Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon. Change 2736436 on 2015/10/21 by sebastian.kowalczyk Fixed crash in gameplay debugger with player set as debug target. Change 2736437 on 2015/10/21 by sebastian.kowalczyk Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet). Change 2736489 on 2015/10/21 by sebastian.kowalczyk Hide internal and debug hud classes from drop down lists. Change 2736504 on 2015/10/21 by sebastian.kowalczyk Fix for UE-18548 "EnableGDT does not work correctly in PIE". Change 2736529 on 2015/10/21 by sebastian.kowalczyk Fixed UE-18548 "EnableGDT does not work correctly in PIE" Change 2736588 on 2015/10/21 by sebastian.kowalczyk Removed old log visualizer classes. Change 2736700 on 2015/10/21 by sebastian.kowalczyk Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module. Change 2737180 on 2015/10/21 by Zak.Middleton #ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits. #rb Aaron.Mcleran #jira UE-22436 Change 2738084 on 2015/10/22 by sebastian.kowalczyk Better indication of selected pawn for Gameplay Debugger. Change 2738413 on 2015/10/22 by Marc.Audy Disable duplication of worlds/maps via the content browser #jira UE-22200 #rb James.Golding Change 2739743 on 2015/10/23 by bruce.nesbit UE-18707 - Issue with drawing material triangle on canvas #1387 Added DrawTriangleUsingVertexColor Change 2739751 on 2015/10/23 by bruce.nesbit Revised bShowDebugForReticleTarget should not be static #1539 Change 2739788 on 2015/10/23 by bruce.nesbit Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor Fixed compile error Change 2739870 on 2015/10/23 by Marc.Audy Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself. #jira UE-22362 #rb Zak.Middleton Change 2739882 on 2015/10/23 by sebastian.kowalczyk Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue. Change 2740140 on 2015/10/23 by Marc.Audy Ensure that components reregister tick functions after seamless travel #jira UE-20892 #rb Zak.Middleton Change 2740614 on 2015/10/23 by Ori.Cohen Fix linker issues for people wanting to use physics lock lambdas Change 2740674 on 2015/10/23 by Aaron.McLeran Sound Focus Feature Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener - Define the min/max azimuth angle to establish in-focus and non-focus regions - Can scale the priority of a sound based on focus angle - Can attenuate the volume of a sound based on focus angle - Can scale the listener-emitter distance based on focus angle - Distance scale is applied when determining max audible distance for USoundBase - Can opt-out of focus effects for a sound at the USoundBase level #rb Ryan.Vance Change 2741542 on 2015/10/26 by Lukasz.Furman lowered min value clamping in navigation filter properties #ue4 #rb Mieszko.Zielinski Change 2743227 on 2015/10/27 by Marc.Audy Make ASceneCaptureCube subclassable outside of Engine module #jira UE-22609 Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module #jira UE-22610 #rb Jeff.Farris Change 2743255 on 2015/10/27 by Marc.Audy Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor #rb Jeff.Farris Change 2743729 on 2015/10/27 by Ori.Cohen Fix case where we spawn and adjust location which gives us implicit velocity. #codereview Stan.Melax Change 2746135 on 2015/10/29 by sebastian.kowalczyk Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work." Change 2746437 on 2015/10/29 by Lukasz.Furman pass on verifying behavior tree stack before accessing its elements #ue4 #rb Mieszko.Zielinski Change 2748028 on 2015/10/30 by sebastian.kowalczyk Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ. Change 2748184 on 2015/10/30 by Aaron.McLeran UE-22693 Fix for streaming bug - 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio. - Wasn't able to repro the 'cannot read chunk' part of the bug #rb ryan.vance Change 2749255 on 2015/10/31 by sebastian.kowalczyk Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD. Change 2749276 on 2015/10/31 by sebastian.kowalczyk Added switch to toggle highlight of selected actor to GameplayDebugger. Change 2749318 on 2015/10/31 by sebastian.kowalczyk New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project). Change 2749337 on 2015/10/31 by sebastian.kowalczyk Fixed GameplayDebugger compilation in shipping/test builds. Change 2749376 on 2015/10/31 by sebastian.kowalczyk Small clean-up in gameplay debugger class for BT. Change 2749931 on 2015/11/02 by James.Golding Add stats to ProcMeshComp Change 2749932 on 2015/11/02 by James.Golding Remove PhysicsThrusterComponent.h from Engine.h Change 2749960 on 2015/11/02 by James.Golding - Fix PS4 compile errors in ActiveSound.cpp - Constructor order of FActiveSound - Shadowed AudioComponent var in CheckOcclusion #RB thomas.sarkanen #codereview aaron.mcleran Change 2749961 on 2015/11/02 by James.Golding Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp - Shadowed DefaultContext function param, now just Context, which matches declaration #RB thomas.sarkanen #codereview sebastian.kowalczyk Change 2750026 on 2015/11/02 by Thomas.Sarkanen Anim Multithreading: thread-safety refactor Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways: - Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal. - Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access. - Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily). Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc. Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays). Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand. Many changes are due to substituting accessor functions for direct variable access. Removed 'service' tick group as we no longer need to segregate the running of our parallel update. Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this. Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private). #rb Martin.Wilson,Lina.Halper #codereview Michael.Noland Change 2750077 on 2015/11/02 by Marc.Audy Expose UInputComponent::BindAction that supports WithKey delegate signature Change 2751767 on 2015/11/03 by Thomas.Sarkanen Added extra support to Anim Blueprint 'fast-path' Added support for negated bools (value gets negated during copy). Added support for copying from struct members (via break struct) and split struct pins. Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often. #rb Martin.Wilson Change 2752158 on 2015/11/03 by Jeff.Farris Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns. #rb marc.audy Change 2752159 on 2015/11/03 by Jeff.Farris Improvements to camera lens effects to (EmitterCameraLensEffectBase) - can now specify a transform to align the emitter with the camera - exposed several key parameters to Blueprints - ENGINE_API now applies to the entire class #rb marc.audy Change 2753454 on 2015/11/04 by Thomas.Sarkanen Fixup deprecation warnings fallout from multithreaded update changes. Fixed up use of AnimInstance in Vicon plugin. Fixed up use of AnimInstance in slope warping node. Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right'). Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction. #rb Martin.Wilson Change 2754099 on 2015/11/04 by Ori.Cohen Fix for task threads dropping stats (from Gil) #rb Gil.Gribb Change 2754449 on 2015/11/04 by Marc.Audy Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks #jira UE-20853 Reorganize some booleans to get better bit packing #rb Jeff.Farris #codereview Mieszko.Zielinski Change 2754573 on 2015/11/04 by Aaron.McLeran Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f Change 2755345 on 2015/11/05 by Thomas.Sarkanen Added deprecated constructors for various animation contexts Allows existing code to compile if it creates its own contexts from UAnimInstance. #rb James.Golding Change 2755348 on 2015/11/05 by James.Golding Add BP-exposed SetBoundsScale function to PrimitiveComponent #RB thomas.sarkanen Change 2755437 on 2015/11/05 by Marc.Audy Fix compile errors #codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran Change 2755982 on 2015/11/05 by Marc.Audy Move HeaderParse changes for deprecation macro from Core Fix world settings warning Change 2756028 on 2015/11/05 by Marc.Audy Fix shadow variable issue Change 2756090 on 2015/11/05 by Ori.Cohen Improve budget tool so that task threads are computed automatically. #rb Gil.Gribb Change 2756120 on 2015/11/05 by Mieszko.Zielinski Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4 #rb Lukasz.Furman Change 2756243 on 2015/11/05 by Mieszko.Zielinski Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4 The old way was resulting in false positives when for example observer teleported somewhere far #rb Lukasz.Furman #codereview John.Abercrombie Change 2756280 on 2015/11/05 by Mieszko.Zielinski Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4 #rb Lukasz.Furman Change 2756500 on 2015/11/05 by Mieszko.Zielinski Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4 Also, refactored its parameters into references over pointers. #rb Lukasz.Furman Change 2757041 on 2015/11/06 by Thomas.Sarkanen Removed check() in UAnimInstance::GetProxyOnAnyThread() The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway. #rb James.Golding Change 2757207 on 2015/11/06 by Ori.Cohen Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation #rb Lina.Halper Change 2757238 on 2015/11/06 by Marc.Audy Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled. #rb Mike.Fricker Change 2757284 on 2015/11/06 by Stan.Melax tapered capsule drawing cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres. (this was already code reviewed before, but missed the check-in window before streamtime) #rb ori.cohen Change 2757743 on 2015/11/06 by Lukasz.Furman fixed node memory allocations for injected behavior tree decorators #ue4 UE-22783 #rb Mieszko.Zielinski Change 2757772 on 2015/11/06 by Lukasz.Furman added setters for crowd avoidance #ue4 UE-22785 #rb Mieszko.Zielinski Change 2758422 on 2015/11/07 by Lina.Halper Potential fix for invalid root bone index input #jira :/UE-23086 #code review: Ori.Cohen Change 2758429 on 2015/11/07 by Mieszko.Zielinski Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4 #jira UE-23089 Change 2758571 on 2015/11/08 by Mieszko.Zielinski Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4 #jira UE-23080 Change 2758821 on 2015/11/09 by Thomas.Sarkanen Fixed animations no longer playing when using a dedicated server. Uses correct logic to determine whether we are running as a server or not. #rb Martin.Wilson Change 2758920 on 2015/11/09 by Marc.Audy Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize #rb Lina.Halper Change 2758944 on 2015/11/09 by Ori.Cohen Fix crash when stats are only on one thread and budget mode is used Change 2758967 on 2015/11/09 by Benn.Gallagher Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence. #jira UE-22963 Change 2758973 on 2015/11/09 by Benn.Gallagher Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating. #rb Bruce.Nesbit Change 2759219 on 2015/11/09 by Ori.Cohen Character perf test is now looking at stats directly and sending to analytics #RB Ben.Salem Change 2759398 on 2015/11/09 by Lina.Halper Fix issue where placed montages are not playing. - the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage #code review: Thomas.Sarkanen #RB: Marc.Audy Change 2759491 on 2015/11/09 by Lina.Halper #Anim: Fix not getting input correctly for Copy Pose node #RB: Marc.Audy Change 2759602 on 2015/11/09 by Marc.Audy Fix imporperly named struct Change 2759795 on 2015/11/09 by Aaron.McLeran UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing. #rb zak.middleton Change 2760081 on 2015/11/09 by Aaron.McLeran UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio. OmniDirectional Math Explanation: For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0. So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map. If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity). The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF. Note: I do not think we need to square the OmniRadius in: Emitter.InnerRadius = OmniRadius*OmniRadius; But I am keeping it t here because of legacy content which depends on that behavior. #rb zak.middleton hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework Re-instated deleted protected functions in UAnimInstance. Fixed access of UAnimInstance in FAnimNode_StateMachine. #rb Martin.Wilson Change 2760407 on 2015/11/10 by Jurre.deBaare Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals) Change 2760468 on 2015/11/10 by Benn.Gallagher Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits. #rb Graeme.Thornton Change 2760613 on 2015/11/10 by Jeff.Farris Fixed async collision completion delegate potentially firing repeatedly. (UE-23149) #cr marc.audy #codereview lina.halper Change 2760795 on 2015/11/10 by Marc.Audy Don't compile in pointless AddReferencedObjects when with editoronly data not defined Minor coding standard cleanup (NULL and auto) Change 2760848 on 2015/11/10 by Benn.Gallagher Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code. #jira UE-23164 #rb Martin.Wilson Change 2760866 on 2015/11/10 by Marc.Audy Manage transient visualization components for camera component in the same way that sprite component for other actor components are #rb Mike.Beach Change 2760963 on 2015/11/10 by Marc.Audy Since construction script can cause actors to be spawned don't use a ranged for to iterate #jira UE-22639 #rb Jeff.Farris #codereview Dmitriy.Dyomin Change 2762297 on 2015/11/11 by James.Golding UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created) #rb martin.wilson #codereview ori.cohen, lina.halper Change 2763566 on 2015/11/11 by Lina.Halper FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint. #RB: Laurent.Delayen Change 2763926 on 2015/11/12 by Thomas.Sarkanen Fix anim notifies not firing from single anim instances UE-23248 - Anim Notifies are not working for Animation Sequences UE-23249 - Anim Notifies using Sound Cues do not work #rb James.Golding Change 2764039 on 2015/11/12 by Jurre.deBaare Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper Change 2764307 on 2015/11/12 by Jurre.deBaare VS2015 SSF library Change 2764314 on 2015/11/12 by Stan.Melax crashfix was putting bad bodies to sleep at start Fatal error! Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000 UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875] On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies. Added check to ensure physx body exists before trying to force it to sleep. not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road". #codereview ori.cohen Change 2764343 on 2015/11/12 by Jurre.deBaare - Fixed crash when building a LOD with SubActors.Num < 2 - Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build - LODActor tree view item now scrolls into view if selected in the world - Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default - Added 7zip files - Fixed issue with WinINet complaining about http-request without 'http://' prefix - Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions) - Override texture sizes and automatic texture bias - Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data. - Now incorporate static meshes with opague materials into HLOD merging - Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled - Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component) - Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD) - Added ENUM for texture scaling/resizing type that has to be applied while merging the materials - Added detail customization class for FMaterialProxySettings #rb James.Golding [CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
ResultNode->SetFlags(RF_Transactional);
UBlueprint* Blueprint = FBlueprintEditorUtils::FindBlueprintForGraphChecked(ParentGraph);
FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified(Blueprint);
}
return ResultNode;
}
void FEdGraphSchemaAction_NewStateNode::AddReferencedObjects( FReferenceCollector& Collector )
{
FEdGraphSchemaAction::AddReferencedObjects( Collector );
// These don't get saved to disk, but we want to make sure the objects don't get GC'd while the action array is around
Collector.AddReferencedObject( NodeTemplate );
}
/////////////////////////////////////////////////////
// FEdGraphSchemaAction_NewStateComment
UEdGraphNode* FEdGraphSchemaAction_NewStateComment::PerformAction(class UEdGraph* ParentGraph, UEdGraphPin* FromPin, const FVector2D Location, bool bSelectNewNode/* = true*/)
{
// Add menu item for creating comment boxes
UEdGraphNode_Comment* CommentTemplate = NewObject<UEdGraphNode_Comment>();
UBlueprint* Blueprint = FBlueprintEditorUtils::FindBlueprintForGraph(ParentGraph);
FVector2D SpawnLocation = Location;
FSlateRect Bounds;
if ((Blueprint != NULL) && FKismetEditorUtilities::GetBoundsForSelectedNodes(Blueprint, Bounds, 50.0f))
{
CommentTemplate->SetBounds(Bounds);
SpawnLocation.X = CommentTemplate->NodePosX;
SpawnLocation.Y = CommentTemplate->NodePosY;
}
return FEdGraphSchemaAction_NewNode::SpawnNodeFromTemplate<UEdGraphNode_Comment>(ParentGraph, CommentTemplate, SpawnLocation);
}
/////////////////////////////////////////////////////
// UAnimationStateMachineSchema
UAnimationStateMachineSchema::UAnimationStateMachineSchema(const FObjectInitializer& ObjectInitializer)
: Super(ObjectInitializer)
{
PC_Exec = TEXT("exec");
}
void UAnimationStateMachineSchema::CreateDefaultNodesForGraph(UEdGraph& Graph) const
{
// Create the entry/exit tunnels
FGraphNodeCreator<UAnimStateEntryNode> NodeCreator(Graph);
UAnimStateEntryNode* EntryNode = NodeCreator.CreateNode();
NodeCreator.Finalize();
SetNodeMetaData(EntryNode, FNodeMetadata::DefaultGraphNode);
if (UAnimationStateMachineGraph* StateMachineGraph = CastChecked<UAnimationStateMachineGraph>(&Graph))
{
StateMachineGraph->EntryNode = EntryNode;
}
}
const FPinConnectionResponse UAnimationStateMachineSchema::CanCreateConnection(const UEdGraphPin* PinA, const UEdGraphPin* PinB) const
{
// Make sure the pins are not on the same node
if (PinA->GetOwningNode() == PinB->GetOwningNode())
{
return FPinConnectionResponse(CONNECT_RESPONSE_DISALLOW, TEXT("Both are on the same node"));
}
// Connect entry node to a state is OK
const bool bPinAIsEntry = PinA->GetOwningNode()->IsA(UAnimStateEntryNode::StaticClass());
const bool bPinBIsEntry = PinB->GetOwningNode()->IsA(UAnimStateEntryNode::StaticClass());
const bool bPinAIsStateNode = PinA->GetOwningNode()->IsA(UAnimStateNodeBase::StaticClass());
const bool bPinBIsStateNode = PinB->GetOwningNode()->IsA(UAnimStateNodeBase::StaticClass());
if (bPinAIsEntry || bPinBIsEntry)
{
if (bPinAIsEntry && bPinBIsStateNode)
{
return FPinConnectionResponse(CONNECT_RESPONSE_BREAK_OTHERS_A, TEXT(""));
}
if (bPinBIsEntry && bPinAIsStateNode)
{
return FPinConnectionResponse(CONNECT_RESPONSE_BREAK_OTHERS_B, TEXT(""));
}
return FPinConnectionResponse(CONNECT_RESPONSE_DISALLOW, TEXT("Entry must connect to a state node"));
}
const bool bPinAIsTransition = PinA->GetOwningNode()->IsA(UAnimStateTransitionNode::StaticClass());
const bool bPinBIsTransition = PinB->GetOwningNode()->IsA(UAnimStateTransitionNode::StaticClass());
if (bPinAIsTransition && bPinBIsTransition)
{
return FPinConnectionResponse(CONNECT_RESPONSE_DISALLOW, TEXT("Cannot wire a transition to a transition"));
}
// Compare the directions
bool bDirectionsOK = false;
if ((PinA->Direction == EGPD_Input) && (PinB->Direction == EGPD_Output))
{
bDirectionsOK = true;
}
else if ((PinB->Direction == EGPD_Input) && (PinA->Direction == EGPD_Output))
{
bDirectionsOK = true;
}
/*
if (!bDirectionsOK)
{
return FPinConnectionResponse(CONNECT_RESPONSE_DISALLOW, TEXT("Directions are not compatible"));
}
*/
// Transitions are exclusive (both input and output), but states are not
if (bPinAIsTransition)
{
return FPinConnectionResponse(CONNECT_RESPONSE_BREAK_OTHERS_A, TEXT(""));
}
else if (bPinBIsTransition)
{
return FPinConnectionResponse(CONNECT_RESPONSE_BREAK_OTHERS_B, TEXT(""));
}
else if (!bPinAIsTransition && !bPinBIsTransition)
{
return FPinConnectionResponse(CONNECT_RESPONSE_MAKE_WITH_CONVERSION_NODE, TEXT("Create a transition"));
}
else
{
return FPinConnectionResponse(CONNECT_RESPONSE_MAKE, TEXT(""));
}
}
bool UAnimationStateMachineSchema::TryCreateConnection(UEdGraphPin* PinA, UEdGraphPin* PinB) const
{
if (PinB->Direction == PinA->Direction)
{
if (UAnimStateNodeBase* Node = Cast<UAnimStateNodeBase>(PinB->GetOwningNode()))
{
if (PinA->Direction == EGPD_Input)
{
PinB = Node->GetOutputPin();
}
else
{
PinB = Node->GetInputPin();
}
}
}
const bool bModified = UEdGraphSchema::TryCreateConnection(PinA, PinB);
if (bModified)
{
UBlueprint* Blueprint = FBlueprintEditorUtils::FindBlueprintForNodeChecked(PinA->GetOwningNode());
FBlueprintEditorUtils::MarkBlueprintAsModified(Blueprint);
}
return bModified;
}
bool UAnimationStateMachineSchema::CreateAutomaticConversionNodeAndConnections(UEdGraphPin* PinA, UEdGraphPin* PinB) const
{
UAnimStateNodeBase* NodeA = Cast<UAnimStateNodeBase>(PinA->GetOwningNode());
UAnimStateNodeBase* NodeB = Cast<UAnimStateNodeBase>(PinB->GetOwningNode());
if ((NodeA != NULL) && (NodeB != NULL)
&& (NodeA->GetInputPin() != NULL) && (NodeA->GetOutputPin() != NULL)
&& (NodeB->GetInputPin() != NULL) && (NodeB->GetOutputPin() != NULL))
{
UAnimStateTransitionNode* TransitionNode = FEdGraphSchemaAction_NewStateNode::SpawnNodeFromTemplate<UAnimStateTransitionNode>(NodeA->GetGraph(), NewObject<UAnimStateTransitionNode>(), FVector2D(0.0f, 0.0f), false);
if (PinA->Direction == EGPD_Output)
{
TransitionNode->CreateConnections(NodeA, NodeB);
}
else
{
TransitionNode->CreateConnections(NodeB, NodeA);
}
UBlueprint* Blueprint = FBlueprintEditorUtils::FindBlueprintForGraphChecked(TransitionNode->GetBoundGraph());
FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified(Blueprint);
return true;
}
return false;
}
void UAnimationStateMachineSchema::GetGraphContextActions(FGraphContextMenuBuilder& ContextMenuBuilder) const
{
// Add state node
{
TSharedPtr<FEdGraphSchemaAction_NewStateNode> Action = AddNewStateNodeAction(ContextMenuBuilder, FText::GetEmpty(), LOCTEXT("AddState", "Add State..."), TEXT("A new state"));
Action->NodeTemplate = NewObject<UAnimStateNode>(ContextMenuBuilder.OwnerOfTemporaries);
}
// Add conduit node
{
TSharedPtr<FEdGraphSchemaAction_NewStateNode> Action = AddNewStateNodeAction(ContextMenuBuilder, FText::GetEmpty(), LOCTEXT("AddConduit", "Add Conduit..."), TEXT("A new conduit state"));
Action->NodeTemplate = NewObject<UAnimStateConduitNode>(ContextMenuBuilder.OwnerOfTemporaries);
}
// Entry point (only if doesn't already exist)
{
bool bHasEntry = false;
for (auto NodeIt = ContextMenuBuilder.CurrentGraph->Nodes.CreateConstIterator(); NodeIt; ++NodeIt)
{
UEdGraphNode* Node = *NodeIt;
if (const UAnimStateEntryNode* StateNode = Cast<UAnimStateEntryNode>(Node))
{
bHasEntry = true;
break;
}
}
if (!bHasEntry)
{
TSharedPtr<FEdGraphSchemaAction_NewStateNode> Action = AddNewStateNodeAction(ContextMenuBuilder, FText::GetEmpty(), LOCTEXT("AddEntryPoint", "Add Entry Point..."), TEXT("Define State Machine's Entry Point"));
Action->NodeTemplate = NewObject<UAnimStateEntryNode>(ContextMenuBuilder.OwnerOfTemporaries);
}
}
// Add Comment
if (!ContextMenuBuilder.FromPin)
{
UBlueprint* OwnerBlueprint = FBlueprintEditorUtils::FindBlueprintForGraphChecked(ContextMenuBuilder.CurrentGraph);
const bool bIsManyNodesSelected = (FKismetEditorUtilities::GetNumberOfSelectedNodes(OwnerBlueprint) > 0);
const FText MenuDescription = bIsManyNodesSelected ? LOCTEXT("CreateCommentSelection", "Create Comment from Selection") : LOCTEXT("AddComment", "Add Comment...");
const FString ToolTip = TEXT("Create a resizeable comment box around selected nodes.");
TSharedPtr<FEdGraphSchemaAction_NewStateComment> NewComment( new FEdGraphSchemaAction_NewStateComment(FText::GetEmpty(), MenuDescription, ToolTip, 0) );
ContextMenuBuilder.AddAction( NewComment );
}
}
EGraphType UAnimationStateMachineSchema::GetGraphType(const UEdGraph* TestEdGraph) const
{
return GT_StateMachine;
}
void UAnimationStateMachineSchema::GetContextMenuActions(const UEdGraph* CurrentGraph, const UEdGraphNode* InGraphNode, const UEdGraphPin* InGraphPin, FMenuBuilder* MenuBuilder, bool bIsDebugging) const
{
check(CurrentGraph);
UBlueprint* OwnerBlueprint = FBlueprintEditorUtils::FindBlueprintForGraphChecked(CurrentGraph);
if (InGraphNode != NULL)
{
MenuBuilder->BeginSection("AnimationStateMachineNodeActions", LOCTEXT("NodeActionsMenuHeader", "Node Actions"));
{
if (!bIsDebugging)
{
// Node contextual actions
MenuBuilder->AddMenuEntry( FGenericCommands::Get().Delete );
MenuBuilder->AddMenuEntry( FGenericCommands::Get().Cut );
MenuBuilder->AddMenuEntry( FGenericCommands::Get().Copy );
MenuBuilder->AddMenuEntry( FGenericCommands::Get().Duplicate );
MenuBuilder->AddMenuEntry( FGraphEditorCommands::Get().ReconstructNodes );
MenuBuilder->AddMenuEntry( FGraphEditorCommands::Get().BreakNodeLinks );
if(InGraphNode->bCanRenameNode)
{
MenuBuilder->AddMenuEntry( FGenericCommands::Get().Rename );
}
}
}
MenuBuilder->EndSection();
}
Super::GetContextMenuActions(CurrentGraph, InGraphNode, InGraphPin, MenuBuilder, bIsDebugging);
}
FLinearColor UAnimationStateMachineSchema::GetPinTypeColor(const FEdGraphPinType& PinType) const
{
return FLinearColor::White;
}
void UAnimationStateMachineSchema::GetGraphDisplayInformation(const UEdGraph& Graph, /*out*/ FGraphDisplayInfo& DisplayInfo) const
{
DisplayInfo.PlainName = FText::FromString( Graph.GetName() );
DisplayInfo.DisplayName = DisplayInfo.PlainName;
}
void UAnimationStateMachineSchema::DroppedAssetsOnGraph(const TArray<FAssetData>& Assets, const FVector2D& GraphPosition, UEdGraph* Graph) const
{
UAnimationAsset* Asset = FAssetData::GetFirstAsset<UAnimationAsset>(Assets);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3050254 on 2016/07/14 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614 Change 3136629 on 2016/09/22 by Marc.Audy bye bye auto Change 3136631 on 2016/09/22 by Marc.Audy Allow objects to be marked as duplicate transient or non PIE duplicate transient ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient #jira UE-35680 Change 3136636 on 2016/09/22 by Marc.Audy ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints Component Activate/Deactivate events now provide component as a property #jira UE-35191 Change 3136640 on 2016/09/22 by Marc.Audy Expose bReplicates to blueprint component properties #jira UE-34433 Change 3136709 on 2016/09/22 by Ori.Cohen Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached. #JIRA UE-36234 Change 3136710 on 2016/09/22 by Ori.Cohen Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together. #JIRA UE-35899 Change 3136770 on 2016/09/22 by Marc.Audy Fix compile error Change 3136854 on 2016/09/22 by Marc.Audy Sprite components need to be text export transient #jira UE-36064 Change 3136926 on 2016/09/22 by Ori.Cohen Fix ensure when skeletal mesh bodies have no collision. Change 3137054 on 2016/09/22 by Aaron.McLeran PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes) Change 3137058 on 2016/09/22 by Aaron.McLeran PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet) Change 3137060 on 2016/09/22 by Aaron.McLeran UE-36336 Fixing A3D for mono/2D sounds - Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds - Fixing A3D mono sources from failing after a time Change 3137066 on 2016/09/22 by Aaron.McLeran Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0 Change 3137098 on 2016/09/22 by dan.reynolds AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process. Change 3137132 on 2016/09/22 by Aaron.McLeran PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge) Change 3137175 on 2016/09/22 by Aaron.McLeran Fixing compile error with PhysXCollision.cpp from CL 3136710 Change 3137540 on 2016/09/23 by Thomas.Sarkanen Fixed crash when generating LODs automatically for skeletal meshes Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification. #jira UE-36253 - Crash applying LOD changes in Persona Change 3137720 on 2016/09/23 by Thomas.Sarkanen Changed asset shortcut bar to display asset names & reworked padding #jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text Change 3137761 on 2016/09/23 by Martin.Wilson Fix typo in root motion from everything accumulation code Change 3137877 on 2016/09/23 by Thomas.Sarkanen Fixed undo/redo forcing skeletal meshes into t-pose Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent. #jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function Change 3137885 on 2016/09/23 by Benn.Gallagher Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect. #jira UE-35151 Change 3137888 on 2016/09/23 by Benn.Gallagher Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links #jira UE-24860 Change 3137889 on 2016/09/23 by Benn.Gallagher Fixed transform and widget inconsistencies in IK edit mode #jira UE-20628 Change 3137890 on 2016/09/23 by Jurre.deBaare Alembic Cached Geometry Does Not Display in Stand Alone Game #fix required to force load the GeometryCache module during runtime #jira UE-36187 Change 3137892 on 2016/09/23 by Jurre.deBaare Geometry cache playback should work in sequencer #fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway) #jira UE-35447 Change 3137893 on 2016/09/23 by Jurre.deBaare Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals #fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence #jira UE-35091 Change 3137894 on 2016/09/23 by Jurre.deBaare Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor #fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created #misc added a new check + message in case this occurs again #jira UE-36059 Change 3137938 on 2016/09/23 by Jurre.deBaare Alembic Importing with Incorrect UV's #fix adding option for flipping UVs on import #jira UE-36190 Alembic import axis not aligned correctly #fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max) #jira UE-35510 Change 3137949 on 2016/09/23 by Jurre.deBaare Frame range importing causes confusion during Alembic importing #fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames. #misc changed settings UI listview layout (extra columns and resized old ones) #jira UE-35498 Change 3137994 on 2016/09/23 by Martin.Wilson Fix for creating an empty state when dragging a montage into a state machine graph #jira UE-33371 Change 3138103 on 2016/09/23 by Aaron.McLeran UE-36312 Fixing sound node distance cross fade for case of looping sounds Change 3138104 on 2016/09/23 by Aaron.McLeran UE-35392 Copy pasting local node into separate project crashes the engine Change 3138224 on 2016/09/23 by Aaron.McLeran UE-36312 Fixing sound node distance cross fade for case of looping sounds - Adding a check for wave instance count to account for virtualized sounds (one-shots) Change 3138666 on 2016/09/23 by Ben.Zeigler #UEFW-204 Add more comprehensive gameplay tag tests Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon Change 3138779 on 2016/09/23 by Marc.Audy Get rid of pointless casts Change 3138782 on 2016/09/23 by Marc.Audy remove some GWorlds Change 3139701 on 2016/09/26 by Jurre.deBaare Assert failed on GemetryCache for PS4 package #fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files #jira UE-36392 Change 3139704 on 2016/09/26 by Jurre.deBaare Fix for -1 begin frame #fix do the max as an signed int, to make sure we don't wrap around Change 3139748 on 2016/09/26 by Benn.Gallagher PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri) Moved the definition of the boundary to a FPhysScene class static Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary #jira UE-35736 Change 3139903 on 2016/09/26 by Benn.Gallagher Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values #jira UE-34366 Change 3140409 on 2016/09/26 by Lukasz.Furman fixed uninitialized configs of gameplay debugger copy of CL# 3140399 Change 3140516 on 2016/09/26 by dan.reynolds AEOverview Map Update - Ambient Zone + Focus Test Change 3140526 on 2016/09/26 by Jon.Nabozny #rn Fixed CanJump inconsistencies with previous versions. Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how jump count and hold time were compared in CanJump. #jira UE-35524, UE-35582 Change 3140745 on 2016/09/26 by dan.reynolds AEOverview Test Map Update + Occlusion Test Change 3140839 on 2016/09/26 by dan.reynolds AEOverview - minor updates Change 3141101 on 2016/09/27 by Thomas.Sarkanen Preview scene worlds now render correctly Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index). In-game hidden flags now apply to GamePreview, but not EditorPreview worlds. Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose. Fixed up UT cases where this was being used. FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport). Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview. Fixed erroneous use of TEnumAsByte for non-uproperty WorldType. #jira UE-22883 - Using FPreviewScenes in-game for scene captures Change 3141106 on 2016/09/27 by Thomas.Sarkanen Column toggling improvements Column toggle menu now does not close when items are selected. This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection. Also allowed columns to be hidden by default for specific use cases (like the sequence browser). #jira UE-35818 - Anim asset browser column picker should stay up Change 3141131 on 2016/09/27 by Thomas.Sarkanen Fix CIS warnings Fallout from preview world changes Change 3141143 on 2016/09/27 by Jurre.deBaare Fix for CIS errors Change 3141235 on 2016/09/27 by Thomas.Sarkanen Fix offset of Persona floor mesh when auto-alignment is enabled When auto alignment was disabled, the offset wasnt getting taken into account. #jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled Change 3141327 on 2016/09/27 by Marc.Audy Ensure that the client side AttachChildren array remains accurate #jira UE-26025 Change 3141474 on 2016/09/27 by mason.seay Updating test map name and moving PlayerStart Change 3141501 on 2016/09/27 by Benn.Gallagher Loading time improvements for destructibles from Nvidia Updated to use new framework custom version instead of global object version Fixed usage of TArray to enable correct loading and saving of the cached data. #jira UE-29680 Change 3141889 on 2016/09/27 by Marc.Audy Fix DestructibleMesh when WITH_APEX is 0 #jira UE-36484 Change 3142034 on 2016/09/27 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971 Change 3142131 on 2016/09/27 by Ori.Cohen Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query. #JIRA UE-36381 Change 3142154 on 2016/09/27 by Ori.Cohen Fix build, ModuleCachedData instead of NxApexModuleCachedData Change 3142159 on 2016/09/27 by mason.seay Blueprint for testing Child Actor Templates Change 3142255 on 2016/09/27 by Jon.Nabozny Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument. #jira UE-35199, UE-35197, UE-35201 Change 3142717 on 2016/09/27 by dan.reynolds AEOverview Update + Sound Class Test Change 3142764 on 2016/09/27 by Marc.Audy Fix Ocean deprecation warnings Change 3142962 on 2016/09/28 by Thomas.Sarkanen Fixed bounds calculations for local camera animations Correctly calculated bounds as local to the initial transform in the track. Implemented suggested fixes from UDN user chhaddon (The Coalition). #jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true Change 3143007 on 2016/09/28 by Martin.Wilson Added virtual bones to USkeleton API Breaking change: -Added USkeleton pointer to RemoveBonesByName -FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead #jira UEFW-81 Change 3143040 on 2016/09/28 by James.Golding Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG Fix up game projects to compile in Shipping/Test after this change PR #2757: (Contributed by projectgheist) #jira UE-35488 Change 3143046 on 2016/09/28 by James.Golding Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file) Change 3143047 on 2016/09/28 by James.Golding PR #2731: Capsule primitive drawing fix (Contributed by kamrann) #jira UE-35142 Change 3143050 on 2016/09/28 by Martin.Wilson Update DDC key as some animation have stale data Change 3143088 on 2016/09/28 by Martin.Wilson CIS Fixes for Ocean after FReferenceSkeleton changes Change 3143090 on 2016/09/28 by Benn.Gallagher Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it. #jira UE-36482 Change 3143091 on 2016/09/28 by Thomas.Sarkanen Fix play/pause keyboard shortcut toggle in Persona based editors Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks). Added the ability for FEdModes to specify whether they can use a widget mode. Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now). #jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused Change 3143100 on 2016/09/28 by James.Golding UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown Change 3143107 on 2016/09/28 by Martin.Wilson Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us #jira UE-34431 Change 3143125 on 2016/09/28 by Jurre.deBaare PR #2749: Fix blend space triangulation (Contributed by tmiv) Change 3143225 on 2016/09/28 by Jurre.deBaare Mesh/material merging basic test files Change 3143235 on 2016/09/28 by Martin.Wilson Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section #jira UE-35929 Change 3143312 on 2016/09/28 by Marc.Audy Don't globally reregister components, globally recreate render state instead when force deleting assets Fixes crash force deleting a blueprint with a child actor component in it from the content browser Change 3143340 on 2016/09/28 by Mieszko.Zielinski Improved consistency of loudness usage in AISense_Hearing #UE4 Change 3143359 on 2016/09/28 by Marc.Audy Fix spelling error in comment Change 3143372 on 2016/09/28 by Jurre.deBaare HLOD meshes are causing degenerate triangles #fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers #jira UE-34336 Change 3143420 on 2016/09/28 by Mieszko.Zielinski Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4 Change 3143421 on 2016/09/28 by Martin.Wilson Allow reading on animation sequence length in blueprints #jira UE-34168 Change 3143455 on 2016/09/28 by James.Golding Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds. Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions Change 3143518 on 2016/09/28 by Jurre.deBaare Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material #fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material) #misc set texture sampling for HLOD proxy base material to clamp #jira UE-35221 Change 3143542 on 2016/09/28 by James.Golding Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if Fix comment Enable by default for FN Change 3143543 on 2016/09/28 by Benn.Gallagher Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton. Change 3143556 on 2016/09/28 by Aaron.McLeran UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE Change 3143566 on 2016/09/28 by Benn.Gallagher Readded early out alongside new ensure for catching bad preFilter shapes Change 3143568 on 2016/09/28 by Marc.Audy Fix deprecation warnings in UT Change 3143572 on 2016/09/28 by Jurre.deBaare More test content for mesh/material merging Change 3143581 on 2016/09/28 by Jurre.deBaare More content :D Change 3143585 on 2016/09/28 by Jurre.deBaare Geometry cache cleaning #misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump) #misc cleaning out unecessary code Change 3143594 on 2016/09/28 by Marc.Audy Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template #jira UE-36511 Change 3143658 on 2016/09/28 by Marc.Audy RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference #jira UE-36553 Change 3143776 on 2016/09/28 by Marc.Audy Properly reinstance child actor templates when using the fast reinstancing path #jira UE-36516 Change 3143896 on 2016/09/28 by Ori.Cohen Remove UPROPERTY on aggregate threshold which is always read from the physics settings. Change 3144022 on 2016/09/28 by Ben.Zeigler Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system Change 3144252 on 2016/09/28 by mason.seay More blueprints for child actor template testing Change 3144262 on 2016/09/28 by Mason.Seay Deleting assets Change 3144283 on 2016/09/28 by dan.reynolds AEOverview update + Sound Priority Test Change 3144411 on 2016/09/28 by dan.reynolds AEOverview end of day update and tweaks Change 3144679 on 2016/09/29 by Benn.Gallagher Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth. Change 3144856 on 2016/09/29 by Jurre.deBaare HLOD Outliner scrolls back to the top when generating proxy meshes #fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview #jira UE-30384 Change 3144864 on 2016/09/29 by Thomas.Sarkanen Preview mesh fixes Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen). Skeleton preview meshes are now shown as empty if none is set (but a default is chosen). #jira UE-36582 - Cannot set preview mesh per-animation Change 3144865 on 2016/09/29 by Jurre.deBaare More test content Change 3144885 on 2016/09/29 by James.Golding UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor Change scale clamping in UpdateBodyScale to catch cases like (1,0,1) Change 3144903 on 2016/09/29 by Thomas.Sarkanen Deprecating StaticMesh in UStaticMeshComponent Added GetStaticMesh to access the value as read-only. SetStaticMesh is now called in all locations that used to call "StaticMesh =". Lots of fixups. #jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent Change 3145020 on 2016/09/29 by Thomas.Sarkanen Fix bounds calculations that include bones to respect LOD (and other requried bones) Sometimes bones would not be updated if we LOD switched, extending the bounds. #jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD Change 3145041 on 2016/09/29 by Jurre.deBaare Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results #fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh #misc ignore the source lightmap uv channels to reduce data #jira UE-36595 Change 3145219 on 2016/09/29 by Benn.Gallagher Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time. #jira UE-36552 Change 3145222 on 2016/09/29 by Jurre.deBaare Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash #fix on import set _all_ bone influence to 0 #jira UE-36602 Change 3145267 on 2016/09/29 by Ori.Cohen Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults. #JIRA UE-36483 Change 3145306 on 2016/09/29 by Jon.Nabozny Fixed PhAT so multiple constraints can be selected and edited properly at the same time. #JIRA: UE-31493 Change 3145342 on 2016/09/29 by Marc.Audy Do not update cull distance volumes whenever any property changes * Any movement or property change of a cull distance volume still does a global update * Any movement of a component belong to any other Actor updates only the components of that Actor * Any property change of a primitive component only updates that component #jira UE-36399 Change 3145958 on 2016/09/29 by Marc.Audy In game worlds don't auto activate components until the actor is ready to process them #jira UE-35189 Change 3146110 on 2016/09/29 by dan.reynolds AEOverview update + Soundwave Procedural Test Map Change 3146375 on 2016/09/30 by Benn.Gallagher Fixed crash saving newly created destructible mesh after material refactor. #jira UE-36619 Change 3146378 on 2016/09/30 by James.Golding UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before) Also add stat for FBodyInstance::LineTrace Change 3146379 on 2016/09/30 by James.Golding Add test assets for creating procmesh collision in non-editor builds Change 3146386 on 2016/09/30 by Thomas.Sarkanen Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance. This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used. #jira UE-36251 - Ensures showing uncompressed animations in anim blueprints Change 3146464 on 2016/09/30 by Thomas.Sarkanen Fix layered blend per bone odd/even connection counts alternately working/not working Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName. #jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs Change 3146652 on 2016/09/30 by Benn.Gallagher Fixed subinstance properties appearing in the caller's details panel as oddly named properties. #jira UE-34141 Change 3146673 on 2016/09/30 by Martin.Wilson Make RawAnimationData (and associated anim sequence data) private #jira ue-25869 Change 3146680 on 2016/09/30 by Benn.Gallagher Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node #jira UE-29847 Change 3146681 on 2016/09/30 by Benn.Gallagher Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node #jira UE-30885 Change 3146711 on 2016/09/30 by Jon.Nabozny Fix PhAT SnapConstraintToBone. #jira UE-31491 Change 3146717 on 2016/09/30 by Danny.Bouimad Adding Jurres really useful merge actor test assets to somewhere QA can get em. Change 3146738 on 2016/09/30 by Martin.Wilson Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1 #tests Editor tests with mambo pose asset #jira UE-36189 Change 3146750 on 2016/09/30 by Jurre.deBaare Material baking issue #misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture) #misc Replaced incorrect masks with _way_ better approach thanks to Martin Change 3146755 on 2016/09/30 by Jurre.deBaare Need better progress bar for HLOD #fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback #jira UE-34334 Change 3147085 on 2016/09/30 by Marc.Audy PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay) #jira UE-36632 Change 3147224 on 2016/09/30 by Martin.Wilson CIS Fix Change 3147280 on 2016/09/30 by Marc.Audy Mouse smoothing should use application frame rate, not the dilated game frame rate #jira UE-31040 Change 3147446 on 2016/09/30 by Aaron.McLeran UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly Change 3147693 on 2016/09/30 by Ben.Zeigler #jira UE-36657 If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location Change 3147697 on 2016/09/30 by Jon.Nabozny Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX #jira UE-30486 Change 3147761 on 2016/09/30 by Jon.Nabozny Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage. Change 3148533 on 2016/10/03 by Thomas.Sarkanen Fix new deprecation warnings introduced by the pull from main Change 3148567 on 2016/10/03 by Marc.Audy Fix crash when exiting PIE while a panoramic screenshot is being taken Make stereo panorama tick with the world it is operating on #jira UE-36492 Change 3148571 on 2016/10/03 by Marc.Audy Allow modification of components that are EditAnywhere but don't exist in the CDO #jira UE-36694 Change 3148607 on 2016/10/03 by Martin.Wilson Properly end notify states when we clear the anim instance on a skeletal mesh. #jira UE-32488 Change 3148711 on 2016/10/03 by Martin.Wilson Fix type in virtual bone tooltip #jira UE-36703 Change 3148746 on 2016/10/03 by Benn.Gallagher Fixed a few cases where post process and sub instance anim calls weren't being made correctly. #jira UE-36529 Change 3148807 on 2016/10/03 by Martin.Wilson Fix mismatch skeleton error when undoing virtual bone changes #jira UE-36705 Change 3148812 on 2016/10/03 by Martin.Wilson Add undo support to removing virtual bones #jira UE-36706 Change 3148975 on 2016/10/03 by Jurre.deBaare Issue with combining meshes both with/without normal maps #fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect) #misc fixed issue in function to set texture rectangle to a single colour #misc spotted comparison error Change 3148976 on 2016/10/03 by Ori.Cohen Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs #JIRA UE-36639 Change 3148991 on 2016/10/03 by Jurre.deBaare Changing LOD materials on Merged Actors Crashes Editor #fix take into account LOD that is using the material when remapping (removing duplicate) materials #jira UE-35883 Change 3148997 on 2016/10/03 by Jurre.deBaare Make sure we remove matrix samples that fall outside of the import range and remap those that are in range Change 3149002 on 2016/10/03 by Jurre.deBaare Issues with importing Alembic caches using matrix transformations #fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from Change 3149030 on 2016/10/03 by Martin.Wilson Dont show save warning on animations when we have curve data #jira UE-34145 Change 3149115 on 2016/10/03 by Mieszko.Zielinski Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4 #jira UE-35153 Change 3149186 on 2016/10/03 by Ben.Zeigler #UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it. This code is weird but this solution is better than the old version and handles inconsistent results Change 3149235 on 2016/10/03 by Martin.Wilson Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself. #jira UE-20005 Change 3149245 on 2016/10/03 by Marc.Audy Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates. Change 3149397 on 2016/10/03 by Ori.Cohen Fix collision profile writing out response values to channels that don't exist. #JIRA UE-36359 Change 3149679 on 2016/10/03 by Zak.Middleton #ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category. Change 3149929 on 2016/10/04 by Jurre.deBaare Fix for CIS errors #fix Mac didn't like undefined struct Change 3149977 on 2016/10/04 by danny.bouimad Massive update to Merge Actor test files Change 3150014 on 2016/10/04 by James.Golding UE-36686 Fix crash when slicing and not creating other section Change 3150016 on 2016/10/04 by James.Golding UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging Change 3150019 on 2016/10/04 by James.Golding UE-36737 Fix LineTraceComponent not returning face index Change 3150020 on 2016/10/04 by James.Golding UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module Change 3150027 on 2016/10/04 by Ben.Marsh Add PhysX build option into Dev-Framework. Change 3150042 on 2016/10/04 by Benn.Gallagher Fixed clothing example 1.3 collision glitches Change 3150172 on 2016/10/04 by Benn.Gallagher Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them. #jira UE-36589 Change 3150319 on 2016/10/04 by Ori.Cohen Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future. #JIRA UE-36535, UE-36504 Change 3150355 on 2016/10/04 by Zak.Middleton #ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast. Change 3150370 on 2016/10/04 by Ori.Cohen Fix deferred actors not getting flushed. Change 3150386 on 2016/10/04 by Martin.Wilson Fix additive animation check failing in cooked builds when using virtual bones #jira UE-36743 Change 3150424 on 2016/10/04 by Ori.Cohen Exclude kinematic actors from active transforms generation. Change 3150613 on 2016/10/04 by Zak.Middleton #ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject. (Mirror CL 3138304 in Orion-DevGeneral) #jira UE-36810 #tests compiled Change 3150679 on 2016/10/04 by Ben.Zeigler Crash fix with no async scene Change 3150765 on 2016/10/04 by Ben.Zeigler Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing Change 3150796 on 2016/10/04 by Marc.Audy Fix LOCTEXT warnings related to blueprint class menu options Change 3150806 on 2016/10/04 by Ben.Zeigler Fix bad text format in import error message, lead to double error Change 3150891 on 2016/10/04 by Ben.Zeigler #jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global Change 3150914 on 2016/10/04 by Marc.Audy Don't try to recreate render state if it has already been recreated while the recreate context was active #jira UE-36590 Change 3151195 on 2016/10/04 by Dan.Reynolds Updates to QASoundWaveProcedural QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing. Change 3151233 on 2016/10/04 by Ben.Zeigler #jira UE-36836 Fix variable shadowing warnings Change 3151328 on 2016/10/04 by dan.reynolds AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP Change 3151461 on 2016/10/05 by Thomas.Sarkanen Fix localization warnings #jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings Change 3151546 on 2016/10/05 by Martin.Wilson Fix pose watch regression due to persona refactor changes. #jira UE-36851 Change 3151587 on 2016/10/05 by Jurre.deBaare Updating Simplygon to SDK version 8.0 #misc removed redundant files #misc fixed landscape culling in merge actor path #misc added support for volume culling using simplygon #misc fixed when or not to use mesh data for material baking #notes Change: 3137650 Date: 23/09/2016 07:57 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: -Renamed commandline variables for ZipUtils AutomationScript -Implemented Execute instead of ExecuteBuild -Updated commandline arguments in SimplygonSwarm JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4 //UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2 Change: 3137649 Date: 23/09/2016 07:56 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Moved file hash computation to ImportObject JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4 Change: 3137646 Date: 23/09/2016 07:55 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Fixes CL3099204 EditorPerProjectUserSetting Removed ConfigRestartRequired attribute from properties where it was not required MeshUtilities -Added FProxyFailedDelegate -Extended IMeshMerging to include FProxyFailed delegate -Added ProxyGenerationFailed method to FProxyGenerationProcessor class -Setup FailedDelegate for both MeshMerging and DistributedMeshMerging SimplygonMeshReduction -Added check for invalid texture id -Updated notes and removed commented code that is not required. -Setup failed delegate -Fixed issue where image data was never hooked into the texture. -Fixed issue where texture table was never passed into casters SimplygonSwarm -Setup failed delegate -Fixed RawMesh pointer usage. -Move helper method into SimplygonSwarmHelpers.h. -Added SimplygonSwarmHelpers -Removed redundant constant path to 7-zip -Removed GetSimplygonDirectory instead using inplace. -Removed commented code that is currently not required. -Fixed Typos JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3 Change: 3099204 Date: 24/08/2016 07:56 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Simplygon 8.0 Updates Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0 EditorPerProjectSettings *SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB *SwarmNumOfConcurrentJobs for executing number of concurrent jobs *Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK) SPL, SimplygonSwarm, RESTClient *Bumped up SPL Version to 8 *Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374 *Removed SPL Templates for version 7.0 *Added conditional logging to REST methods *Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid. *Updated method to take in texturepath SimplygonMeshReduction *Removed minimum version requirement. *Bumped up minimum version *Chagned license file name to refelect 8.0 changes *MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch. JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2 Change: 3099200 Date: 24/08/2016 07:48 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: #fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2 Change: 3099199 Date: 24/08/2016 07:47 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm. This will remove any dependency on external zip program and should work across platforms JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1 Change: 3099197 Date: 24/08/2016 07:40 Client: Mustafa.Tungekar_Dev-Partner-Simplygon User: Mustafa.Tungekar Status: submitted Type: restricted ImportedBy: Identity: Description: *Speed improvements for FBX Scene Importer *Added a static method to compute Hash. JobStatus: Jobs: Files: //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3 //UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2 //UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2 Change 3151664 on 2016/10/05 by Richard.Hinckley Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member. Change 3151729 on 2016/10/05 by Thomas.Sarkanen Audit of remaining NaN checks Some checks remain on in shipping (generally those called from blueprint): - AActor::TeleportTo - AActor::SetActorRelativeScale3D #jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test Change 3151742 on 2016/10/05 by Ori.Cohen Make sure that if physical animation component doesn't find a body and bone it doesn't crash. #JIRA UE-36839 Change 3151756 on 2016/10/05 by Jurre.deBaare Fixing d3dcompiler_47.dll missing issue #fix added runtime dependency and dll name to build.cs file #fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL Change 3151761 on 2016/10/05 by Thomas.Sarkanen Fix deprecation warning from last integration Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd. #jira UE-36858 - Compile UE4Editor* completed with 1 warning Change 3151782 on 2016/10/05 by Jurre.deBaare Simplygon patch up #misc linker errors popping up from JSONCPP #misc incorporated emissive material property fix from other shelve #misc static analysis fix Change 3151804 on 2016/10/05 by Marc.Audy Clear need end of frame update when unregistering a component Change 3151928 on 2016/10/05 by Ori.Cohen Fix runtime DLLs not including all delay loaded physx dll files. #JIRA UE-36816 Change 3151977 on 2016/10/05 by Martin.Wilson Notifies can no longer occupy the same time on the same track. #jira UE-30658 Change 3151989 on 2016/10/05 by Jon.Nabozny Fix ArchVis character rotation pitch when looking up/down. #jira UE-35706 Change 3152083 on 2016/10/05 by Marc.Audy Ensure that pending kill components get their marked for end of frame state cleared. Change 3152086 on 2016/10/05 by Ben.Zeigler #jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid Change 3152093 on 2016/10/05 by Marc.Audy Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load). #jira UE-36146 #jira UE-24647 Change 3152100 on 2016/10/05 by Ben.Zeigler Remove pragma optmize Change 3152112 on 2016/10/05 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072 Change 3152134 on 2016/10/05 by Jurre.deBaare Simplygon/Merge actor issues #fix for emissive output on meshes that do not have emissive properties #fix for texture binning, not removing invalid split area causing overlapped textures Change 3152136 on 2016/10/05 by James.Golding UE-36859 Fix tooltip saying you can click to stop recording Change 3152169 on 2016/10/05 by James.Golding UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh Change 3152202 on 2016/10/05 by Jurre.deBaare Mac/Linux fix Change 3152303 on 2016/10/05 by Marc.Audy Fix deprecation warning post merge from main Change 3152320 on 2016/10/05 by Martin.Wilson Fix root motion from everything calculating incorrect root motion when animations haven't been ticking #jira UE-35364 Change 3152354 on 2016/10/05 by James.Golding PoseDriver should pass through if no poses activated Change 3152357 on 2016/10/05 by James.Golding UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim. Change 3152556 on 2016/10/05 by Marc.Audy Remove autos Change 3152560 on 2016/10/05 by Marc.Audy Don't allow child actor references to be dragged from the outliner to a level script #jira UE-16700 Change 3152568 on 2016/10/05 by Marc.Audy Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters Remove deprecated bNoCollisionFail #jira UE-35928 Change 3152575 on 2016/10/05 by Marc.Audy Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move Change 3153101 on 2016/10/06 by Thomas.Sarkanen Fix crash re-opening the viewport in Persona-based editors #jira UE-36775 - Editor crashes when re-opening viewport in Persona Change 3153139 on 2016/10/06 by James.Golding UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported Change 3153160 on 2016/10/06 by Thomas.Sarkanen Fix for crash when deleting additive layer track Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr). #jira UE-36740 - Crash when removing or disabling an additive layer track in Persona Change 3153175 on 2016/10/06 by Benn.Gallagher Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed. #jira UE-36900 Change 3153223 on 2016/10/06 by Thomas.Sarkanen Fixed crash when opening an asset from the blend space editor Code was still trying to open 'old' Persona when it was disabled. Also fix other call sites where this was being done outside of asset type actions. #jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona Change 3153324 on 2016/10/06 by Thomas.Sarkanen Prevented invalid GUIDs from being saved into smart name containers AddOrFindName now checks to see if existing GUIDs are valid before using them. AddName now requires a valid GUID to be passed in. Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved. Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068). #jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset Change 3153348 on 2016/10/06 by Martin.Wilson Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor) #jira UE-36751 Change 3153426 on 2016/10/06 by Mieszko.Zielinski Added missing elements of block comments support in BT editor #UE4 Change 3153454 on 2016/10/06 by Benn.Gallagher Fixed crash using anim debug with subinstances that are preceded by branching nodes. #jira UE-36935 [CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
if(Asset != NULL && GetNodeClassForAsset(Asset->GetClass()))
{
// Spawn new state
UAnimStateNode* NewStateNode = FEdGraphSchemaAction_NewStateNode::SpawnNodeFromTemplate<UAnimStateNode>(Graph, NewObject<UAnimStateNode>(), GraphPosition);
// Try to name the state close to the asset
FEdGraphUtilities::RenameGraphToNameOrCloseToName(NewStateNode->BoundGraph, Asset->GetName());
// Change the current graph context to the inner graph, so that the rest of the drag drop happens inside it
FVector2D NewGraphPosition = FVector2D(-300.0f, 0.0f);
UAnimationGraphSchema::SpawnNodeFromAsset(Asset, NewGraphPosition, NewStateNode->BoundGraph, NewStateNode->GetPoseSinkPinInsideState());
}
}
void UAnimationStateMachineSchema::DroppedAssetsOnNode(const TArray<FAssetData>& Assets, const FVector2D& GraphPosition, UEdGraphNode* Node) const
{
UAnimationAsset* Asset = FAssetData::GetFirstAsset<UAnimationAsset>(Assets);
UAnimStateNode* StateNodeUnderCursor = Cast<UAnimStateNode>(Node);
if(Asset != NULL && StateNodeUnderCursor != NULL)
{
// Dropped onto a state machine state; try some user friendly resposnes
if (UEdGraphPin* PosePin = StateNodeUnderCursor->GetPoseSinkPinInsideState())
{
if (PosePin->LinkedTo.Num() > 0)
{
//@TODO: A2REMOVAL: This doesn't do anything
/*
// Try dropping in onto the node attached to the sink inside the state
check(PosePin->LinkedTo[0] != NULL);
UA2Node* A2Node = Cast<UA2Node>(PosePin->LinkedTo[0]->GetOwningNode());
if(A2Node != NULL)
{
UAnimationGraphSchema::UpdateNodeWithAsset(A2Node, Asset);
}
*/
}
else
{
// Try dropping onto the pose pin, since nothing is currently connected
const FVector2D NewGraphPosition(-300.0f, 0.0f);
UAnimationGraphSchema::SpawnNodeFromAsset(Asset, NewGraphPosition, StateNodeUnderCursor->BoundGraph, PosePin);
}
}
}
}
void UAnimationStateMachineSchema::DroppedAssetsOnPin(const TArray<FAssetData>& Assets, const FVector2D& GraphPosition, UEdGraphPin* Pin) const
{
// unused for state machines?
}
void UAnimationStateMachineSchema::GetAssetsNodeHoverMessage(const TArray<FAssetData>& Assets, const UEdGraphNode* HoverNode, FString& OutTooltipText, bool& OutOkIcon) const
{
UAnimationAsset* Asset = FAssetData::GetFirstAsset<UAnimationAsset>(Assets);
if ((Asset == NULL) || (HoverNode == NULL))
{
OutTooltipText = TEXT("");
OutOkIcon = false;
return;
}
const UAnimStateNode* StateNodeUnderCursor = Cast<const UAnimStateNode>(HoverNode);
if (StateNodeUnderCursor != NULL)
{
OutOkIcon = true;
OutTooltipText = FString::Printf(TEXT("Change node to play %s"), *(Asset->GetName()));
}
else
{
OutTooltipText = TEXT("");
OutOkIcon = false;
}
}
void UAnimationStateMachineSchema::GetAssetsPinHoverMessage(const TArray<FAssetData>& Assets, const UEdGraphPin* HoverPin, FString& OutTooltipText, bool& OutOkIcon) const
{
// unused for state machines?
OutTooltipText = TEXT("");
OutOkIcon = false;
}
#undef LOCTEXT_NAMESPACE