2019-12-26 14:45:42 -05:00
// Copyright Epic Games, Inc. All Rights Reserved.
2016-01-07 04:39:47 -05:00
2015-07-08 23:03:46 -04:00
# include "PacketHandler.h"
2019-10-10 20:04:46 -04:00
# include "Net/Core/Misc/PacketAudit.h"
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3596412)
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3497498 by John.Barrett
Added CVar for toggling NetConnection sequence randomization 'net.RandomizeSequence'.
Tweaked asserts related to sequence randomization, to remove some false positives.
Change 3520192 by John.Barrett
Added delegate hooks to the base netcode, new virtual functions, and made the UChannel classes overridable through UNetDriver, to allow netcode hooks without requiring a dependency on Online plugin packages - required to keep NetcodeUnitTest functionality, after Online packages were moved out of Engine.
Change 3520215 by John.Barrett
Second pass at big NetcodeUnitTest Minimal Client refactor, consolidating most of the client helper code into MinimalClient, and refactoring the ClientUnitTest API (touching all unit tests).
Also eliminated Online plugin dependencies (removing UnitTestNetDriver and UnitTestNetConnection), replacing them with low level netcode hooks.
Change 3526952 by John.Barrett
Fixed minimal client PackageMap override.
Change 3528488 by John.Barrett
Added actor channel hook, to disable NMT_ActorChannelFailure notification.
Change 3528491 by John.Barrett
Fixed unit test actor channel blocking from triggering disconnects, by using an Engine hook to block NMT_ActorChannelFailure, instead of using a more complex/unreliable method of blocking.
Change 3529906 by John.Barrett
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
Change 3550072 by John.Barrett
Added compile-time verification for unit test and minimal client configuration flags, and refactored how the flags are set - speeds up writing new unit tests, for games with excessive launch times.
Change 3565074 by Jon.Nabozny
Fix Replication Paused logic.
Change 3565093 by Jon.Nabozny
Add a 'UseDistanceBasedRelevancy' check in APawn::IsNetRelevantFor, to make it consistent with AActor.
Change 3565132 by Jon.Nabozny
Fix Actor's GetLevel to no longer assume the immediate outer is the level. Fix similar inconsistent usages of GetOuter on Actors.
Change 3573678 by Jake.Leonard
Update actor replication based stats even when we are currently saturated (their values will be 0 anyways)
#jira UE-46523
#RB: Ryan.Gerleve
Change 3574047 by John.Barrett
Added new '-FullStdOutLogOutput' commandline parameter, for capturing full log output through stdout.
Makes up for the shortcoming of '-AllowStdOutLogVerbosity', being limited to ELogVerbosity::Log.
Change 3575518 by Jon.Nabozny
Remove actors from UNetDriver::DestroyedStartupOrDormant actors when their level is unloaded.
#jira UE-47192
Change 3575911 by Jake.Leonard
Adding option for specifying an editor server port for PIE. This allows users to change the default port used when playing net games without interferring with other instances.
#jira UE-12093
Change 3575916 by Jake.Leonard
Fixing the UI so that it doesn't respond to the same input as the camera controls by making the playback button unfocusable.
#Jira UE-37831
Change 3578830 by Ryan.Gerleve
Merging new PlatformCrypto plugin for interfacing with encryption libraries, with a generic OpenSSL implementation and a BCrypt/CNG implementation for Xbox One.
Added EncryptionComponent interface so that engine code can talk to encryption components without knowing their concrete type.
New AESHandlerComponent packet handler component which uses PlatformCrypto to encrypt packets.
Change 3578855 by Ryan.Gerleve
Merging hooks for encryption in the network handshake flow. NMT_Hello messages may now send an EncryptionToken as a parameter, which can be used by games to derive an encryption key used by the PacketHandler's EncryptionComponent.
Change 3578864 by Ryan.Gerleve
Merged: Changed the net.UseEncryptionToken to be more useful and renamed it to net.AllowEncryption.
This cvar, if 0, will prevent the PacketHandler from adding the configured encryption component, and prevent UPendingNetGame and AOnlineBeaconClient from filling out the EncryptionToken parameter of NMT_Hello - which prevents the extra encryption handshake connection step.
Change 3588479 by Ryan.Gerleve
Merging: Encryption token/ack changes from josh.markiewicz
- moved encryption token request/ack to delegates
- moved FNetworkNotify to NetworkDelegates.h
- moved connection logic out of GameInstance and back into networking code
-- GameInstance sends an enum and the network code does the right thing based on that
#tests PC dedicated server connections golden path and forced failures
Change 3588830 by Jake.Leonard
New camera logic for playercontrollers so that we set the death cams correctly.
#jira UE-44307
Change 3588956 by Jake.Leonard
Quickfix for the character mesh position becoming offset due to movement smoothing being cached out.
#jira UE-45947
Change 3588974 by Ryan.Gerleve
Add a cvar and code to allow testing encryption functionality in ShooterGame, ShooterGame.TestEncryption (off by default). If enabled, attempts to use the PlatformCrypo and AESHandlerComponent to encrypt game traffic with a hardcoded key (for debugging/testing only, not secure!).
Change 3592922 by Jon.Nabozny
Call AActor::PreReplication before performing initial replication triggered from an RPC.
[CL 3596435 by Ryan Gerleve in Main branch]
2017-08-18 09:54:37 -04:00
# include "EncryptionComponent.h"
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
# include "Misc/ConfigCacheIni.h"
# include "Modules/ModuleManager.h"
# include "UObject/ObjectMacros.h"
# include "UObject/Package.h"
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3847469)
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3805828 by Gil.Gribb
UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works.
Change 3806784 by Ben.Marsh
UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT.
Change 3807549 by Graeme.Thornton
Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it.
Change 3807727 by Graeme.Thornton
Unhide the text asset format experimental editor option
Change 3807746 by Josh.Engebretson
Remove WER from iOS platform
Change 3807928 by Robert.Manuszewski
When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet
Change 3808221 by Steve.Robb
GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule()
^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway.
Change 3809233 by Graeme.Thornton
TBA: Misc changes to text asset commandlet
- Rename mode to "loadsave"
- Add -outputFormat option which can be assigned "text" or "binary"
- When saving binary, use a differentiated filename so that source assets aren't overwritten
Change 3809518 by Ben.Marsh
Remove the outdated UnrealSync automation script.
Change 3809643 by Steve.Robb
GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value
#jira UE-53037
Change 3809862 by Steve.Robb
GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately
#jira UE-42593
Change 3811190 by Graeme.Thornton
Add support for writing specific log channels to their own files
Change 3811197 by Graeme.Thornton
Minor updates to output formatting and timing for the text asset commandlet
Change 3811257 by Robert.Manuszewski
Cluster creation will now be time-sliced
Change 3811565 by Steve.Robb
Define out non-monolithic module functions.
Change 3812561 by Steve.Robb
GitHub #3886 : Enable Brace-Initialization for Declaring Variables
Incorrect semi-colon search removed after discussion with author.
Test added.
#jira UE-48242
Change 3812864 by Steve.Robb
Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins.
See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html
#jira UE-53089
Change 3820358 by Ben.Marsh
PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist)
Change 3822594 by Ben.Marsh
UAT: Improvements to log file handling.
- Always create log files in the final location, rather than writing to a temp directory and copying in later.
- Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX.
- Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is.
- Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location.
Change 3823695 by Ben.Marsh
UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk).
Now always queries changes up to the last change for which zipped binaries are available.
Change 3823845 by Ben.Marsh
UBT: Exclude C# projects for unsupported platforms when generating project files.
Change 3824180 by Ben.Marsh
UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes).
#jira
Change 3825777 by Steve.Robb
Fix to return value of StringToBytes.
Change 3825810 by Ben.Marsh
UBT: Reduce length of include paths for MSVC toolchain.
Change 3825822 by Robert.Manuszewski
Optimized PIE lazy pointer fixup. Should be up to 8x faster now.
Change 3826734 by Ben.Marsh
Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency.
Change 3827730 by Steve.Robb
Try to avoid decltype(auto) if it's not supported.
See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html
Change 3827745 by Steve.Robb
Initializer list support for TMap.
Change 3827770 by Steve.Robb
GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType()
#jira UE-53813
Change 3829189 by Ben.Marsh
UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off.
Change 3830444 by Steve.Robb
BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library.
This should be revisited when Core has its own JSON library.
Change 3830718 by Ben.Marsh
Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups.
The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip.
For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it.
When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk.
#jira UE-53845
Change 3831064 by Ben.Marsh
Fix log file contention when spawning UBT recursively.
Change 3832654 by Ben.Marsh
UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it.
Change 3832680 by Ben.Marsh
UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade.
Change 3832695 by Ben.Marsh
UGS: Invert the options in the 'Show Changes' submenu for simplicity.
Change 3833528 by Ben.Marsh
UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write].
Change 3833543 by Ben.Marsh
UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules.
Change 3834354 by Robert.Manuszewski
Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks.
#jira UE-52035
Change 3834400 by Robert.Manuszewski
Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup.
#jira UE-52035
Change 3834947 by Steve.Robb
USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal.
Change 3835004 by Ben.Marsh
Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL.
Change 3835340 by Ben.Marsh
Fix errors making installed build from directories with spaces in the name.
Change 3835972 by Ben.Marsh
UBT: Improved diagnostic message for targets which don't need a version file.
Change 3836019 by Ben.Marsh
UBT: Fix warnings caused by defining linkage macros for third party libraries.
Change 3836269 by Ben.Marsh
Fix message box larger than the screen height being created when a large number of modules are incompatible on startup.
Change 3836543 by Ben.Marsh
Enable SoundMod plugin on Linux, since it's already supported through the editor.
Change 3836546 by Ben.Marsh
PR #4412: fix type mismatch (Contributed by nakapon)
Change 3836805 by Ben.Marsh
Fix commandlet to compile marketplace plugins.
Change 3836829 by Ben.Marsh
UBT: Fix ability to precompile plugins from installed engine builds.
Change 3837036 by Ben.Marsh
UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds.
Change 3837037 by Ben.Marsh
UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro).
Change 3837040 by Ben.Marsh
UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed.
Change 3837247 by Ben.Marsh
UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files).
Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor.
Change 3837262 by Ben.Marsh
UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module.
Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets.
Change 3837343 by Ben.Marsh
UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead.
Change 3837356 by Ben.Marsh
Fix invalid character encodings.
Change 3837727 by Graeme.Thornton
UnrealPak: KeyGenerator: Only generate prime table when required, not all the time
Change 3837823 by Ben.Marsh
UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window.
Change 3837831 by Graeme.Thornton
UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives
Change 3837857 by Robert.Manuszewski
PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch)
Change 3837943 by Robert.Manuszewski
PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch)
Change 3838451 by Ben.Marsh
UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread.
#jira UE-53996
Change 3839519 by Ben.Marsh
UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data.
Change 3843790 by Graeme.Thornton
UnrealPak: Log the size of all encrypted data
Change 3844258 by Ben.Marsh
Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace.
Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure.
#jira UE-54157
Change 3845796 by Ben.Marsh
Workaround for slow performance of String.EndsWith() on Mono.
Change 3845823 by Ben.Marsh
Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun.
#jira UE-54123
Change 3845901 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
(Edigrating 3819174 to Dev-Core)
Change 3846439 by Ben.Marsh
Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates.
Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main.
Change 3816608 by Ben.Marsh
UBT: Use DirectoryReference objects for all include paths.
Change 3816954 by Ben.Marsh
UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere.
Change 3816986 by Ben.Marsh
UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly.
Change 3816991 by Ben.Marsh
UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules.
Change 3823090 by Ben.Marsh
UAT: Improve logging for child UAT instances.
- Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder.
- Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway.
- Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read.
- Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output.
Change 3826082 by Ben.Marsh
UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target.
Change 3827025 by Ben.Marsh
UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling.
Change 3829927 by James.Hopkin
Made HTTP interface const correct
Change 3833533 by Ben.Marsh
Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules.
Change 3835826 by Ben.Marsh
UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced.
Change 3835969 by Ben.Marsh
UBT: Fix cases where text is being written directly to the console rather than via logging functions.
Change 3837777 by Steve.Robb
Format string type checking added to FOutputDevice::Logf.
Fixes for those.
Change 3838569 by Steve.Robb
Algo moved up a folder.
[CL 3847482 by Ben Marsh in Main branch]
2018-01-20 11:19:29 -05:00
# include "HAL/ConsoleManager.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
2019-10-10 20:04:46 -04:00
# include "Net/Core/Misc/DDoSDetection.h"
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
# include "HandlerComponentFactory.h"
2015-07-08 23:03:46 -04:00
# include "ReliabilityHandlerComponent.h"
2018-12-13 00:41:17 -05:00
# include "PacketHandlerProfileConfig.h"
2015-07-08 23:03:46 -04:00
2019-02-01 20:55:06 -05:00
# include "SocketSubsystem.h"
2020-10-29 13:38:15 -04:00
# include "Misc/StringBuilder.h"
2019-02-01 20:55:06 -05:00
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
// @todo #JohnB: There is quite a lot of inefficient copying of packet data going on.
// Redo the whole packet parsing/modification pipeline.
2015-07-15 15:04:08 -04:00
IMPLEMENT_MODULE ( FPacketHandlerComponentModuleInterface , PacketHandler ) ;
2015-07-08 23:03:46 -04:00
DEFINE_LOG_CATEGORY ( PacketHandlerLog ) ;
2018-10-29 10:01:28 -04:00
DECLARE_CYCLE_STAT ( TEXT ( " PacketHandler Incoming_Internal " ) , Stat_PacketHandler_Incoming_Internal , STATGROUP_Net ) ;
DECLARE_CYCLE_STAT ( TEXT ( " PacketHandler Outgoing_Internal " ) , Stat_PacketHandler_Outgoing_Internal , STATGROUP_Net ) ;
2020-10-29 13:38:15 -04:00
// CVars
# if !UE_BUILD_SHIPPING
int32 GPacketHandlerCRCDump = 0 ;
FAutoConsoleVariableRef CVarNetPacketHandlerCRCDump (
TEXT ( " net.PacketHandlerCRCDump " ) ,
GPacketHandlerCRCDump ,
TEXT ( " Enables or disables dumping of packet CRC's for every HandlerComponent, Incoming and Outgoing, for debugging. " ) ) ;
# endif
2016-01-28 16:03:26 -05:00
/**
* PacketHandler
*/
2018-10-29 10:01:28 -04:00
PacketHandler : : PacketHandler ( FDDoSDetection * InDDoS /*=nullptr*/ )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
: Mode ( Handler : : Mode : : Client )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
, bConnectionlessHandler ( false )
2018-10-29 10:01:28 -04:00
, DDoS ( InDDoS )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
, LowLevelSendDel ( )
, HandshakeCompleteDel ( )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
, OutgoingPacket ( )
, IncomingPacket ( )
, HandlerComponents ( )
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
, MaxPacketBits ( 0 )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
, State ( Handler : : State : : Uninitialized )
, BufferedPackets ( )
, QueuedPackets ( )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
, QueuedRawPackets ( )
, QueuedHandlerPackets ( )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
, BufferedConnectionlessPackets ( )
, QueuedConnectionlessPackets ( )
, ReliabilityComponent ( nullptr )
, bRawSend ( false )
2018-10-29 10:01:28 -04:00
, Provider ( )
, Aggregator ( )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
, bBeganHandshaking ( false )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
2015-07-08 23:03:46 -04:00
OutgoingPacket . SetAllowResize ( true ) ;
OutgoingPacket . AllowAppend ( true ) ;
}
void PacketHandler : : Tick ( float DeltaTime )
{
2018-10-29 10:01:28 -04:00
for ( const TSharedPtr < HandlerComponent > & Component : HandlerComponents )
2015-07-08 23:03:46 -04:00
{
2018-10-29 10:01:28 -04:00
if ( Component . IsValid ( ) )
{
Component - > Tick ( DeltaTime ) ;
}
2015-07-08 23:03:46 -04:00
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
// Send off any queued handler packets
BufferedPacket * QueuedPacket = nullptr ;
while ( QueuedHandlerPackets . Dequeue ( QueuedPacket ) )
{
check ( QueuedPacket - > FromComponent ! = nullptr ) ;
FBitWriter OutPacket ;
OutPacket . SerializeBits ( QueuedPacket - > Data , QueuedPacket - > CountBits ) ;
2018-10-29 10:01:28 -04:00
SendHandlerPacket ( QueuedPacket - > FromComponent , OutPacket , QueuedPacket - > Traits ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
}
2015-07-08 23:03:46 -04:00
}
2021-01-21 16:22:06 -04:00
FPacketHandlerAddComponentByNameDelegate & PacketHandler : : GetAddComponentByNameDelegate ( )
{
static FPacketHandlerAddComponentByNameDelegate AddComponentByNameDelegate ;
return AddComponentByNameDelegate ;
}
FPacketHandlerAddComponentDelegate & PacketHandler : : GetAddComponentDelegate ( )
{
static FPacketHandlerAddComponentDelegate AddComponentDelegate ;
return AddComponentDelegate ;
}
2018-06-24 11:01:03 -04:00
void PacketHandler : : Initialize ( Handler : : Mode InMode , uint32 InMaxPacketBits , bool bConnectionlessOnly /*=false*/ ,
2018-12-13 00:41:17 -05:00
TSharedPtr < IAnalyticsProvider > InProvider /*=nullptr*/ , FDDoSDetection * InDDoS /*=nullptr*/ , FName InDriverProfile /*=NAME_None*/ )
2015-07-08 23:03:46 -04:00
{
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
Mode = InMode ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
MaxPacketBits = InMaxPacketBits ;
2018-06-24 11:01:03 -04:00
DDoS = InDDoS ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
2018-06-24 11:01:03 -04:00
bConnectionlessHandler = bConnectionlessOnly ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
// Only UNetConnection's will load the .ini components, for now.
2018-06-24 11:01:03 -04:00
if ( ! bConnectionlessHandler )
2015-07-15 15:04:08 -04:00
{
2015-10-30 17:41:13 -04:00
TArray < FString > Components ;
2018-12-20 23:37:53 -05:00
FString DriverProfileCategory = FString : : Printf ( TEXT ( " %s PacketHandlerProfileConfig " ) , * InDriverProfile . GetPlainNameString ( ) ) ;
GConfig - > GetArray ( * DriverProfileCategory , TEXT ( " Components " ) , Components , GEngineIni ) ;
2018-12-13 00:41:17 -05:00
// If we didn't get any matches, push in the regular components.
if ( Components . Num ( ) = = 0 )
{
GConfig - > GetArray ( TEXT ( " PacketHandlerComponents " ) , TEXT ( " Components " ) , Components , GEngineIni ) ;
}
2015-10-30 17:41:13 -04:00
2021-01-21 16:22:06 -04:00
// Users of this delegate can add components to the list by name and if necessary reorder them
GetAddComponentByNameDelegate ( ) . ExecuteIfBound ( Components ) ;
2018-10-29 10:01:28 -04:00
for ( const FString & CurComponent : Components )
2015-07-08 23:03:46 -04:00
{
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
AddHandler ( CurComponent , true ) ;
2015-07-15 15:04:08 -04:00
}
2021-01-21 16:22:06 -04:00
// Users of this delegate can supply constructed additional components to be added after the named components
TArray < TSharedPtr < HandlerComponent > > AdditionalComponents ;
GetAddComponentDelegate ( ) . ExecuteIfBound ( AdditionalComponents ) ;
for ( TSharedPtr < HandlerComponent > AdditionalComponent : AdditionalComponents )
{
AddHandler ( AdditionalComponent , true ) ;
}
2015-07-08 23:03:46 -04:00
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3596412)
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3497498 by John.Barrett
Added CVar for toggling NetConnection sequence randomization 'net.RandomizeSequence'.
Tweaked asserts related to sequence randomization, to remove some false positives.
Change 3520192 by John.Barrett
Added delegate hooks to the base netcode, new virtual functions, and made the UChannel classes overridable through UNetDriver, to allow netcode hooks without requiring a dependency on Online plugin packages - required to keep NetcodeUnitTest functionality, after Online packages were moved out of Engine.
Change 3520215 by John.Barrett
Second pass at big NetcodeUnitTest Minimal Client refactor, consolidating most of the client helper code into MinimalClient, and refactoring the ClientUnitTest API (touching all unit tests).
Also eliminated Online plugin dependencies (removing UnitTestNetDriver and UnitTestNetConnection), replacing them with low level netcode hooks.
Change 3526952 by John.Barrett
Fixed minimal client PackageMap override.
Change 3528488 by John.Barrett
Added actor channel hook, to disable NMT_ActorChannelFailure notification.
Change 3528491 by John.Barrett
Fixed unit test actor channel blocking from triggering disconnects, by using an Engine hook to block NMT_ActorChannelFailure, instead of using a more complex/unreliable method of blocking.
Change 3529906 by John.Barrett
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
Change 3550072 by John.Barrett
Added compile-time verification for unit test and minimal client configuration flags, and refactored how the flags are set - speeds up writing new unit tests, for games with excessive launch times.
Change 3565074 by Jon.Nabozny
Fix Replication Paused logic.
Change 3565093 by Jon.Nabozny
Add a 'UseDistanceBasedRelevancy' check in APawn::IsNetRelevantFor, to make it consistent with AActor.
Change 3565132 by Jon.Nabozny
Fix Actor's GetLevel to no longer assume the immediate outer is the level. Fix similar inconsistent usages of GetOuter on Actors.
Change 3573678 by Jake.Leonard
Update actor replication based stats even when we are currently saturated (their values will be 0 anyways)
#jira UE-46523
#RB: Ryan.Gerleve
Change 3574047 by John.Barrett
Added new '-FullStdOutLogOutput' commandline parameter, for capturing full log output through stdout.
Makes up for the shortcoming of '-AllowStdOutLogVerbosity', being limited to ELogVerbosity::Log.
Change 3575518 by Jon.Nabozny
Remove actors from UNetDriver::DestroyedStartupOrDormant actors when their level is unloaded.
#jira UE-47192
Change 3575911 by Jake.Leonard
Adding option for specifying an editor server port for PIE. This allows users to change the default port used when playing net games without interferring with other instances.
#jira UE-12093
Change 3575916 by Jake.Leonard
Fixing the UI so that it doesn't respond to the same input as the camera controls by making the playback button unfocusable.
#Jira UE-37831
Change 3578830 by Ryan.Gerleve
Merging new PlatformCrypto plugin for interfacing with encryption libraries, with a generic OpenSSL implementation and a BCrypt/CNG implementation for Xbox One.
Added EncryptionComponent interface so that engine code can talk to encryption components without knowing their concrete type.
New AESHandlerComponent packet handler component which uses PlatformCrypto to encrypt packets.
Change 3578855 by Ryan.Gerleve
Merging hooks for encryption in the network handshake flow. NMT_Hello messages may now send an EncryptionToken as a parameter, which can be used by games to derive an encryption key used by the PacketHandler's EncryptionComponent.
Change 3578864 by Ryan.Gerleve
Merged: Changed the net.UseEncryptionToken to be more useful and renamed it to net.AllowEncryption.
This cvar, if 0, will prevent the PacketHandler from adding the configured encryption component, and prevent UPendingNetGame and AOnlineBeaconClient from filling out the EncryptionToken parameter of NMT_Hello - which prevents the extra encryption handshake connection step.
Change 3588479 by Ryan.Gerleve
Merging: Encryption token/ack changes from josh.markiewicz
- moved encryption token request/ack to delegates
- moved FNetworkNotify to NetworkDelegates.h
- moved connection logic out of GameInstance and back into networking code
-- GameInstance sends an enum and the network code does the right thing based on that
#tests PC dedicated server connections golden path and forced failures
Change 3588830 by Jake.Leonard
New camera logic for playercontrollers so that we set the death cams correctly.
#jira UE-44307
Change 3588956 by Jake.Leonard
Quickfix for the character mesh position becoming offset due to movement smoothing being cached out.
#jira UE-45947
Change 3588974 by Ryan.Gerleve
Add a cvar and code to allow testing encryption functionality in ShooterGame, ShooterGame.TestEncryption (off by default). If enabled, attempts to use the PlatformCrypo and AESHandlerComponent to encrypt game traffic with a hardcoded key (for debugging/testing only, not secure!).
Change 3592922 by Jon.Nabozny
Call AActor::PreReplication before performing initial replication triggered from an RPC.
[CL 3596435 by Ryan Gerleve in Main branch]
2017-08-18 09:54:37 -04:00
// Add encryption component, if configured.
FString EncryptionComponentName ;
2018-02-22 11:25:06 -05:00
if ( GConfig - > GetString ( TEXT ( " PacketHandlerComponents " ) , TEXT ( " EncryptionComponent " ) , EncryptionComponentName , GEngineIni ) & & ! EncryptionComponentName . IsEmpty ( ) )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3596412)
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3497498 by John.Barrett
Added CVar for toggling NetConnection sequence randomization 'net.RandomizeSequence'.
Tweaked asserts related to sequence randomization, to remove some false positives.
Change 3520192 by John.Barrett
Added delegate hooks to the base netcode, new virtual functions, and made the UChannel classes overridable through UNetDriver, to allow netcode hooks without requiring a dependency on Online plugin packages - required to keep NetcodeUnitTest functionality, after Online packages were moved out of Engine.
Change 3520215 by John.Barrett
Second pass at big NetcodeUnitTest Minimal Client refactor, consolidating most of the client helper code into MinimalClient, and refactoring the ClientUnitTest API (touching all unit tests).
Also eliminated Online plugin dependencies (removing UnitTestNetDriver and UnitTestNetConnection), replacing them with low level netcode hooks.
Change 3526952 by John.Barrett
Fixed minimal client PackageMap override.
Change 3528488 by John.Barrett
Added actor channel hook, to disable NMT_ActorChannelFailure notification.
Change 3528491 by John.Barrett
Fixed unit test actor channel blocking from triggering disconnects, by using an Engine hook to block NMT_ActorChannelFailure, instead of using a more complex/unreliable method of blocking.
Change 3529906 by John.Barrett
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
Change 3550072 by John.Barrett
Added compile-time verification for unit test and minimal client configuration flags, and refactored how the flags are set - speeds up writing new unit tests, for games with excessive launch times.
Change 3565074 by Jon.Nabozny
Fix Replication Paused logic.
Change 3565093 by Jon.Nabozny
Add a 'UseDistanceBasedRelevancy' check in APawn::IsNetRelevantFor, to make it consistent with AActor.
Change 3565132 by Jon.Nabozny
Fix Actor's GetLevel to no longer assume the immediate outer is the level. Fix similar inconsistent usages of GetOuter on Actors.
Change 3573678 by Jake.Leonard
Update actor replication based stats even when we are currently saturated (their values will be 0 anyways)
#jira UE-46523
#RB: Ryan.Gerleve
Change 3574047 by John.Barrett
Added new '-FullStdOutLogOutput' commandline parameter, for capturing full log output through stdout.
Makes up for the shortcoming of '-AllowStdOutLogVerbosity', being limited to ELogVerbosity::Log.
Change 3575518 by Jon.Nabozny
Remove actors from UNetDriver::DestroyedStartupOrDormant actors when their level is unloaded.
#jira UE-47192
Change 3575911 by Jake.Leonard
Adding option for specifying an editor server port for PIE. This allows users to change the default port used when playing net games without interferring with other instances.
#jira UE-12093
Change 3575916 by Jake.Leonard
Fixing the UI so that it doesn't respond to the same input as the camera controls by making the playback button unfocusable.
#Jira UE-37831
Change 3578830 by Ryan.Gerleve
Merging new PlatformCrypto plugin for interfacing with encryption libraries, with a generic OpenSSL implementation and a BCrypt/CNG implementation for Xbox One.
Added EncryptionComponent interface so that engine code can talk to encryption components without knowing their concrete type.
New AESHandlerComponent packet handler component which uses PlatformCrypto to encrypt packets.
Change 3578855 by Ryan.Gerleve
Merging hooks for encryption in the network handshake flow. NMT_Hello messages may now send an EncryptionToken as a parameter, which can be used by games to derive an encryption key used by the PacketHandler's EncryptionComponent.
Change 3578864 by Ryan.Gerleve
Merged: Changed the net.UseEncryptionToken to be more useful and renamed it to net.AllowEncryption.
This cvar, if 0, will prevent the PacketHandler from adding the configured encryption component, and prevent UPendingNetGame and AOnlineBeaconClient from filling out the EncryptionToken parameter of NMT_Hello - which prevents the extra encryption handshake connection step.
Change 3588479 by Ryan.Gerleve
Merging: Encryption token/ack changes from josh.markiewicz
- moved encryption token request/ack to delegates
- moved FNetworkNotify to NetworkDelegates.h
- moved connection logic out of GameInstance and back into networking code
-- GameInstance sends an enum and the network code does the right thing based on that
#tests PC dedicated server connections golden path and forced failures
Change 3588830 by Jake.Leonard
New camera logic for playercontrollers so that we set the death cams correctly.
#jira UE-44307
Change 3588956 by Jake.Leonard
Quickfix for the character mesh position becoming offset due to movement smoothing being cached out.
#jira UE-45947
Change 3588974 by Ryan.Gerleve
Add a cvar and code to allow testing encryption functionality in ShooterGame, ShooterGame.TestEncryption (off by default). If enabled, attempts to use the PlatformCrypo and AESHandlerComponent to encrypt game traffic with a hardcoded key (for debugging/testing only, not secure!).
Change 3592922 by Jon.Nabozny
Call AActor::PreReplication before performing initial replication triggered from an RPC.
[CL 3596435 by Ryan Gerleve in Main branch]
2017-08-18 09:54:37 -04:00
{
static IConsoleVariable * const AllowEncryptionCVar = IConsoleManager : : Get ( ) . FindConsoleVariable ( TEXT ( " net.AllowEncryption " ) ) ;
if ( AllowEncryptionCVar = = nullptr | | AllowEncryptionCVar - > GetInt ( ) ! = 0 )
{
EncryptionComponent = StaticCastSharedPtr < FEncryptionComponent > ( AddHandler ( EncryptionComponentName , true ) ) ;
}
else
{
UE_LOG ( PacketHandlerLog , Warning , TEXT ( " PacketHandler encryption component is configured as %s, but it won't be used because the cvar net.AllowEncryption is false. " ) , * EncryptionComponentName ) ;
}
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
bool bEnableReliability = false ;
GConfig - > GetBool ( TEXT ( " PacketHandlerComponents " ) , TEXT ( " bEnableReliability " ) , bEnableReliability , GEngineIni ) ;
if ( bEnableReliability & & ! ReliabilityComponent . IsValid ( ) )
{
2018-10-29 10:01:28 -04:00
TSharedPtr < HandlerComponent > NewComponent = MakeShareable ( new ReliabilityHandlerComponent ) ;
ReliabilityComponent = StaticCastSharedPtr < ReliabilityHandlerComponent > ( NewComponent ) ;
AddHandler ( NewComponent , true ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
}
2018-10-29 10:01:28 -04:00
}
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main
#lockdown Nick.Penwarden
#rb none
Change 3720210 on 2017/10/25 by Olaf.Piesche
Fixing dynamic material params for ribbons
#!codereview scott.kennedy
#!rb none
#!tests scott's test ribbon
Change 3720073 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: frank.fella
Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it.
#!Tests Minion automated tests no longer crash randomly.
#!rb SimonT
#!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3719233 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: philip.buuck
[OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead).
#!rb Matt.Schembari
#!tests PIE
[QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death
#!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3718474 on 2017/10/25 by Yannick.Lange
Niagara: Only show isolate menu items on track context menu if it is a system.
Rename "Isolate toggle" to "Isolated".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718095 on 2017/10/25 by Yannick.Lange
Niagara: Fix crash when not having dynamic parameter in material.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718069 on 2017/10/25 by Yannick.Lange
Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3717545 on 2017/10/24 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Removed read / write locks from PipelineStateCache.
#!rb Andrew.Grant, Gil.Gribb
#!test paragon ps4.
#!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3716928 on 2017/10/24 by Shaun.Kime
The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime.
#!rb olaf.piesche, simon.tovey
#!fyi olaf.piesche, simon.tovey, frank.fella
#!tests am now able to run Test_minionWave on PS4
Change 3715712 on 2017/10/24 by Yannick.Lange
Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3715430 on 2017/10/23 by Shaun.Kime
Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it.
#!rb none
#!fyi simon.tovey
#!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime
Change 3715368 on 2017/10/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main)
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3715226 on 2017/10/23 by Shaun.Kime
Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's.
#!rb none
#!fyi simon.tovey, olaf.piesche, frank.fella
#!tests ran in PIE
Change 3714645 on 2017/10/23 by Yannick.Lange
Niagara: Add ability to create particle system from this emitter in content browser.
#!rb Shaun.Kime
#!tests n/a
Change 3714200 on 2017/10/23 by Olaf.Piesche
Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target
#!codereview simon
#!rb none
#!tests Orion Niagara assets
Change 3713341 on 2017/10/23 by Yannick.Lange
Niagara: Fix NiagaraNodeIF output pins cannot be deleted.
Fix NiagaraNodeIF output pins cannot be renamed.
#!jira UE-50193
#!jira UE-50193
#!rb Shaun.Kime
#!tests n/a
Change 3713133 on 2017/10/23 by Yannick.Lange
Niagara: Isolate emitters in sequencer UI.
- Added being able to extend the sequencer track context menu with a delegate.
- Added entry in track context menu to toggle the selected emitters isolation state.
- Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters.
#!rb Shaun.Kime
#!tests n/a
Change 3712445 on 2017/10/22 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
UVScale, UniformAorBFloat, and LinearColorAlongVector added.
#!rb none
#!tests new autotest added
#!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3712420 on 2017/10/21 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1.
#!rb none
[CODEREVIEW] frank.fella
[FYI] simon.tovey, olaf.piesche, wyeth.johnson
#!tests created an emitter, disabled Acceleration Force.. still compiled.
#!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711602 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like:
LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData
#!jira UE-51511
#!rb Simon.Tovey
#!tests n/a
#!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711288 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: eric.ketchum
[Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work
#!rb: None
#!tests: PIE
[CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime
#!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711197 on 2017/10/20 by Olaf.Piesche
Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly
#!rb none
#!tests minion projectile ribbon trail
Change 3710634 on 2017/10/20 by Mic.Rooney
Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing.
#!RB: none
#!Test: tested/built locally ran preflight Editor/Monolithics build.
#!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3709686 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Added some more timerguards for slow timer manager tick objects.
Commented out for now.
#!rb Trivial
#!test Paragon Cooked ps4.
#!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708958 on 2017/10/19 by Shaun.Kime
Back out changelist 3708456 .. this was an unintentional change
#!rb none
#!tests n/a
Change 3708839 on 2017/10/19 by Shaun.Kime
Merging CL 3708835
Fixing Scott's common crash with adding an emitter with autocompile off
#!rb frank.fella
#!tests n/a
Change 3708784 on 2017/10/19 by Shaun.Kime
Merging CL 3708782
//Orion/Main/... to //Orion/DevGeneral/...
#!rb none
#!tests n/a
Change 3708600 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion
#!rb none
#!test golden path
#!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708473 on 2017/10/19 by Shaun.Kime
Merging Frank's changes for team color support from Main to Dev-General
#!rb Frank.Fella
#!tests test_minionwave worked
Change 3708456 on 2017/10/19 by Shaun.Kime
Particles.Random set to 0.0
#!rb none
#!tests n/a
Change 3708455 on 2017/10/19 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests passed minion fx autotest
Change 3707648 on 2017/10/19 by Shaun.Kime
Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made.
Defer deletion of dataset to RT.
Ensure resets don't mess with data inflight RT commands are using.
Checkin on behalf of Simon Tovey
#!jira OR-45423
#!rb Simon.Tovey
#!tests ran through the LaneMinionFXTests successfully on PC
Change 3707096 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago.
#!rb none
#!tests automated tests pass
#!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3706726 on 2017/10/19 by Rob.Cannaday
Merge XMPP resource version to use version 2 instead of version 3
#!rb trivial
#!tests compile
#!ROBOMERGE: Main, 44, Tencent
Change 3706349 on 2017/10/19 by Josh.Markiewicz
#!UE4 - Cross Voice code review feedback
- fixed up broken stack vs queue
- fixed GetRoomId returning int32 instead of uint64
- fixed switch room logic
- more/better logging
- more comments
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
#!rb none
#!tests local cheat codes
Change 3705453 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array)
#!RB Daniel.Wright
#!Tests LaunchOnPs4
#!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3705399 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: scott.kennedy
Default Niagara emitter changed color property to better default value.
Updated basic glow emitter
Added energy bubble base emitter
put a little more polish into siege minion impact FX.
#!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3704426 on 2017/10/18 by Shaun.Kime
Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423
#!rb simon.tovey
#!fyi hunter.kent
#!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure
Change 3703288 on 2017/10/18 by Olaf.Piesche
Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash
#!rb olaf.piesche, simon.tovey
#!tests minion test map PC and PS4
Change 3701373 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader.
#!rb Olaf.Piesche
#!tests test_minionwave runs
#!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3701108 on 2017/10/17 by Hunter.Kent
Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily.
#!RNX
#!Test PS4
#!rb @tim.elek
#!review-3701110 @andrew.grant, @daniel.lamb
Change 3701044 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: jon.lietz
- white space fixes
- added in more detail to logging
- fixed dragon GC to not hide when the mesh is hidden
#!rb none
#!tests complies and logging is updated
[FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen
#!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3700900 on 2017/10/17 by Shaun.Kime
Integrating possible crash fix from Dev-Niagara to Dev-Gen
#!rb none
#!tests n/a
#!fyi Olaf.Piesche
Change 3700492 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests done in branch
Change 3700217 on 2017/10/17 by Olaf.Piesche
Fix for potential crash in sprite renderer
#!rb none
#!tests minion test map
Change 3700216 on 2017/10/17 by Benn.Gallagher
Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master.
#!rb Lina.Halper
#!jira OR-45226
#!tests PIE + Standalone games hitting Rampage with Ghosts E
Change 3699660 on 2017/10/17 by Jason.Bestimt
#!ORION_DG - Fixes to UnrealHitchParser edge cases
#!RB:none
#!Tests: Ran on Logs from QA
#!CodeReview: ben.salem
Change 3699462 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!tests preflight ok
#!rb none
Change 3699010 on 2017/10/17 by Jeff.Williams
Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920
#!rb none
#!tests none
Change 3698519 on 2017/10/16 by Olaf.Piesche
Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts
#!rb none
#!tests minion wave test map
Change 3698380 on 2017/10/16 by Shaun.Kime
Updating logic to now support the autoattachment
#!rb none
#!tests autotests pass..
Change 3698263 on 2017/10/16 by Olaf.Piesche
Assume degrees for sprite rotation
#!rb none
#!codereview shaun.kime
#!tests test sprite emitter
Change 3697652 on 2017/10/16 by Olaf.Piesche
Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion
#!rb none
#!tests minion test map
Change 3696906 on 2017/10/15 by Shaun.Kime
Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers.
#!rb none
#!tests now no longer generates invalid errors
#!fyi frank.fella, olaf.piesche, simon.tovey
Change 3695456 on 2017/10/13 by Olaf.Piesche
Fix for potential ribbon crash and end-of-ribbon rendering artifacts
#!rb none
#!codereview scott.kennedy
#!tests minion wave test map
Change 3694545 on 2017/10/13 by Andrew.Grant
Fix for low frequency async loading crash (OR-42535)
#!rb gil.gribb
#!tests comppiled
Change 3694176 on 2017/10/13 by Jeff.Williams
Plugin manifest name changed to DLCFile name
#!rb none
#!tests compile, stage
Change 3693582 on 2017/10/12 by Don.Eubanks
Fixing PS4 Compile warning (constructor init order not matching member define order)
#!rb none
#!tests Compile Shipping Client PS4
#!fyi olaf.piesche
Change 3693516 on 2017/10/12 by Olaf.Piesche
Niagara: Remove mesh renderer assert, replace with early out
#!rb none
#!tests niagara mesh test asset
Merging
//Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
Change 3693051 on 2017/10/12 by Ben.Salem
Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log.
#!rb Clayton.Langford
#!tests Parsed a 5mb log with dumphitches down to 23k of hitch data.
Change 3692912 on 2017/10/12 by Olaf.Piesche
Merging: Niagara ribbon tiling distance
#!rb none
#!tests ribbon test asset
Change 3692835 on 2017/10/12 by Shaun.Kime
Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags.
#!rb none
#!fyi scott.kennedy, wyeth.johnson
#!tests n/a
Change 3692751 on 2017/10/12 by Shaun.Kime
Removing script that shouldn't have come over.
#!rb none
#!tests n/a
Change 3692746 on 2017/10/12 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests opened test level and created new emitter/system
Change 3692616 on 2017/10/12 by Don.Eubanks
OR-45131
Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking.
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
#!codereview nick.darnell
Change 3691912 on 2017/10/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none
#!tests compile, editor
#!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3690944 on 2017/10/11 by Jeff.Williams
Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC.
#!rb Daniel.Lamb
#!tests Compile, build
Change 3688989 on 2017/10/10 by Lina.Halper
LOD sync of attached/parent
#!rb: Laurent.Delayen
#!tests: price with shotgun skin/PIE/editor
Change 3687592 on 2017/10/09 by Ben.Salem
Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test.
#!rb clayton.langford
#!tests Ran sparrow shallow tests.
Change 3686560 on 2017/10/09 by Shaun.Kime
Flipping the min/max values to be standard
#!rb none
#!tests n/a
Change 3686046 on 2017/10/09 by Shaun.Kime
Merging latest from Dev-Niagara in preparation for Effects team work on Monday
#!rb none
#!tests successful preflight
#!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek
Change 3685613 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: simon.tovey
Implementing vector field matrix inverse fix from CL3675167 to 43.3.
#!rb none
#!tests none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685603 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
RotationalContent Improvements
- Fixed potential bug where tags could be updated when not intended on RotationalContentManager
- Fix for PIE assert
- Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option.
- Removing config tag from RotationalContentOverrides in OrionGlobals.
New Halloween Gauntlet Test
- Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box.
#!rb none
#!tests local builds / editor / PIE
#!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685408 on 2017/10/07 by ben.salem
Fixing robomerge error in DevGen
#!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. ben.salem, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml
--------------------------------------
Merging using DevGen->Release43.3
Repairing mailer for nightly Perf tests, fixing email headers.
#!tests run in devgen
#!rb none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685073 on 2017/10/06 by Andrew.Grant
Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3684717 on 2017/10/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where GT & RT times in profile info were reversed :(
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3684512 on 2017/10/06 by Laurent.Delayen
Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code.
#!rb lina.halper
#!tests minion AnimBP nativization
Change 3684059 on 2017/10/06 by Max.Preussner
Orion: Fixed ability videos not loading on PS4 and/or not looping
#!fyi stephan.jiang
#!jira OR-44682
#!rb none
#!rnx
#!tests none
Change 3683538 on 2017/10/06 by David.Ratti
batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions.
-Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players.
-Fixes case where killing minions with badass was not displaying pops (prediction key issue)
#!rb none
#!tests editor, pie
#!review-3683539 @Matt.Schembari
Change 3683364 on 2017/10/06 by Andrew.Grant
Changed warning to info
#!tests #!rb na
Change 3681999 on 2017/10/05 by Bart.Hawthorne
Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion.
#!rb cody.haskell
#!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore
#!jira OR-44111
#!tests Golden path, live spectated numerous matches.
Change 3681403 on 2017/10/04 by Josh.Markiewicz
#!UE4 - base pass for Tencent Cross SDK
- basic testing done with enter/exit/switch room
- basic testing of ShowUI
- checked in disabled
#!rb duck
#!tests see above
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
Change 3680623 on 2017/10/04 by David.Ratti
Rework for how max movement speed is calculated.
The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow.
Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored.
Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow.
GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc).
Suggested methods for inspection:
AbilitySystem debug hud (Home/End)
p.VisualizeMovement (displays final calculated movement speed)
Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar)
Technical information:
1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool.
2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows.
3. Added a notification for attribute sets when an aggregator is created for one of their attributes.
4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod)
5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension.
#!tests pie
#!rb FrankG
#!codereview Fred.Kimberley, Billy.Bramer
#!fyi colin.fogle
#!QAReview
#!RN
#!designchange
Change 3680580 on 2017/10/04 by Ben.Salem
Repair email titles for various reports.
#!rb none
#!tests Reran tests.
Change 3680438 on 2017/10/04 by Dan.Hertzka
GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect
- Fixes the HUD status effect feed not showing sources for a lot of itemization abilities
Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip
#!rb Dave.Ratti
#!tests OrionEntry PIE - equipped Sand Speeder
#!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on
Change 3680344 on 2017/10/04 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Speculative disable of defragging on volumetric lightmap textures.
#!rb andrew.grant
#!test monolith2 ps4
#!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3680302 on 2017/10/04 by Shaun.Kime
Integration from DevNiagara.
Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array.
#!rb none
#!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek
#!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass.
Change 3679946 on 2017/10/04 by Laurent.Delayen
Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches.
#!rb lina.halper
#!FYI andrew.grant
#!tests monolith2 old minions
Change 3679938 on 2017/10/04 by Daniel.Lamb
Allowed foliage cullall option to be modified by scalability options.
#!rb Trivial
#!test Compile paragon editor
Change 3679563 on 2017/10/04 by Jon.Lietz
OR-43599
- added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it.
#!rb Dave.Ratti
#!review-3679564 @John.Nielson
#!tests added these waits to hot pursuit and they worked as expected
Change 3679006 on 2017/10/03 by Ben.Salem
Try to fix broken nightly mailer issues for FX tests.
#!rb none
#!tests Preflighted a shallow fx pass successfully in EC.
Change 3677845 on 2017/10/03 by Andrew.Grant
Added an ensure to guard against OR-44826 while further investigations occur
#!tests compiled
#!rb none
Change 3677443 on 2017/10/03 by John.Nielson
Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase.
Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify).
#!RB: None
#!Test: Pie, Uncooked
#!review-3677445: @David.Ratti
Change 3676748 on 2017/10/02 by Laurent.Delayen
Minions: split body layer is now done in mesh space, to maintain upper body orientation.
#!FYI ray.arnett, lina.halper
#!rb none
#!test lane minion test map
Change 3675950 on 2017/10/02 by Don.Eubanks
Added several new supported tags / status effects to the Floating Status Effect Text system.
Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player.
Added ScaleOverDistance curve support for floating numbers / text.
Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out.
#!rb matt.schembari
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4
Change 3675186 on 2017/10/02 by Mic.Rooney
Support for other anim curve driving audio types (right now specifically DialogueWave)
#!RB: none
#!Test: compiled editor/monolithics/withoutunity and tested locally.
#!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3675167 on 2017/10/02 by Shaun.Kime
Changed unsafe InverseFast() to an Inverse()
#!jira OR-44671
#!rb Simon.Tovey
#!tests n/a
Change 3674888 on 2017/10/02 by David.Ratti
GGP V2
* Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration.
Item System:
* Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords.
* Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup).
Ability System:
* SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE)
#!rb none
#!tests editor pie cooked
#!review-3674889 @Jon.Lietz
Change 3674170 on 2017/09/30 by Mieszko.Zielinski
Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion
Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load.
#!rb none
#!test golden path
#!OR-44738
Change 3672937 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files
#!tests 3compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672867 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored previous behaviour of integer numbers being formatted as "1" and not "1.00"
#!tests ran game, checked playlist analytic
#!rb nikdel
#!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672575 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Remove warning that can happens normally with backwards compat replays
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672548 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Andrew.Grant
#!test Editor building hlods
#!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672542 on 2017/09/29 by Andrew.Grant
Merging
#!rb #!tests na
Change 3672390 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed memreport settings for frontend tests
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672385 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Reworked and pretty much final PipelineState cache code
- various comments incorporated
- namespaced functions
- removed redundant class and replaced with ref pointer
#!tests soaked a lot
[at daniel.lamb,] [at arne.schober] #!rb none
#!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672281 on 2017/09/29 by Rob.Cannaday
Add user ID to OnNetworkCheatDetected
#!jira TEN-272
#!jira TEN-273
#!jira TEN-274
#!rb rob.cannaday
#!tests Win64 AI match, simulate cheat detected by cheat command
#!review-3672282 @ian.fox @sam.zamani
Change 3671688 on 2017/09/29 by Frank.Gigliotti
Added ability to set developer comment when adding native tags.
#!RB David.Ratti
#!Tests None
Change 3670409 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for dump type made while doing cleanup
#!tests compiled Win64, PS4, ran PS4
#!rb none
#!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3670399 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed race condition in pipeline state cache
Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon
(Couple of extra tweaks planned, but this should be GTG for a v43 release)
#!rb codereviewed
#!tests soaked locally, lots
#!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669802 on 2017/09/28 by Andrew.Grant
From Dev-Framework
#!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed
#!rb michael.noland
#!codereview andrew.grant
#!tests na
Change 3669709 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669177 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Reflection Captures support Lighting Scenarios without recapturing
* Reflection Captures are now part of the Map Build
* Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message)
* Reflection Capture build data moved to the BuildData package
* Building lighting / reflection captures no longer dirties ULevels
* Sky lights which capture the scene now work correctly with Lighting Scenarios
* Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded)
#!rb Marcus.Wassmer
#!TESTS Paragon editor Monolith02
#!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669124 on 2017/09/28 by Daniel.Lamb
Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush
to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush
Fix cook in devgeneral
Bumped shader version to invalidate stale uniform buffer name.
#!rb none
#!TESTS none
#!fyi Daniel.Wright
Change 3667906 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667899 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Remove unused SM4 reflection capture cubemap
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667894 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] SM4 fallback for reflection captures.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667859 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] Removed old rasterized deferred reflection env path.
Removed reflection compute shader. Replaced with PS. Small perf gain.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667852 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed missing include
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667807 on 2017/09/27 by Daniel.Lamb
Tencent DLC can now remap the plugin content to the game root directory.
#!rb Ben.Marsh
#!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test
Change 3667753 on 2017/09/27 by Clayton.Langford
Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer.
#!RB Ben.Salem, Adric.Worley
#!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat
Change 3667408 on 2017/09/27 by Jordan.Walker
Optimization to bakedNormal layer blend on Low end material quality
-uses simple multiply and add normal map blend
Change 3667388 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times.
#!rb none
#!TESTS QAGame on console
#!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667383 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667265 on 2017/09/27 by Daniel.Lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Uriel.Doyon
#!test Editor building hlods
Change 3667159 on 2017/09/27 by Mieszko.Zielinski
Added simple logging to BT loading allowing us to identify missing BB keys #!Orion
#!test golden path
#!rb Lukasz.Furman
Change 3665944 on 2017/09/26 by Dan.Hertzka
Fix PS4 compile
#!rb none
#!tests compile PS4
Change 3665590 on 2017/09/26 by Daniel.Lamb
Fix for DLC cooking everything when it should only cook the DLC.
#!rb None
#!test None
Change 3665569 on 2017/09/26 by Dan.Hertzka
New status effect feed for the new HUD:
- Now placed in the mid-upper-left side of the HUD
- Biggest difference from before is that there are now names associated with each effect
- If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet.
Cleaning:
- Deleted all of the old buff widget classes & codepaths
- Removed redundant properties from StatusEffectDisplayInfo
- Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData
Also:
- Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events
- Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed)
@todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.)
#!rb Don.Eubanks
#!tests OrionEntry PIE with some cards and hero abilities
#!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial.
#!lockdown Billy.Rivers
Change 3665555 on 2017/09/26 by Daniel.Lamb
AudioStreaming mpsc queue fix up.
#!rb Andrew.Grant
#!test Compile paragon client / editor.
Change 3665517 on 2017/09/26 by Daniel.Lamb
Suspect fix for OR-44619
#!jira OR-44619
#!test Paragon editor compile
#!rb Trivial
Change 3664346 on 2017/09/26 by Jon.Lietz
- making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out.
- Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired.
- Updated all GC's data to use the new decal class
- removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent
#!rb Dave.Ratti
#!reivew Dave.Ratti
#!tests used characters that had decal comps in the GC and they recylce as expected.
#!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed.
Change 3664099 on 2017/09/26 by Jon.Lietz
OR-44510
- bringing over engine fixes for the Enum Redirector from Dev-Framework
#!rb none
#!tests compiles and warnings are gone
Change 3663019 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Gil: fixed race condition in the PipelineStateCache
#!rb Daniel.Lamb
#!test paragon ps4 with higher repro modified build
#!lockdown Andrew.Grant
#!jira OR-44441
#!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663014 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready.
#!tests ran locally
#!rb [at daniel.lamb] [at arne.schober]
#!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663004 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed dev check for extra commandline args from /data to /temp0
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662999 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Fixed DateTime used for folders not being set
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662255 on 2017/09/25 by Sam.Zamani
#!tencent
- fix for link error due to missing define of static OnNetworkCheatDetected delegate
#!rb none
#!tests none
Change 3662073 on 2017/09/25 by Sam.Zamani
#!tencent
Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server
Possible options
#!jira TEN-275 TSS detect and expose punish user callbacks
KickClient - User should be booted from the current game session via disconnect
KickMatch - User received info about being punished (eg. ban type etc)
PunishInfo - User received info about being punished (eg. ban type etc)
#!rb rob.cannaday
#!tests none
Change 3659487 on 2017/09/22 by Josh.Markiewicz
#!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin
#!review-3659190 john.barrett, ryan.gerleve
Change 3659485 on 2017/09/22 by Josh.Markiewicz
#!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins
#!fyi john.barrett, ryan.gerleve
Change 3659184 on 2017/09/22 by Josh.Markiewicz
#!UE4 - delete EpicSurvey module
#!fyi justin.sargent, nick.darnell
#!rb none
Change 3658697 on 2017/09/22 by Ryan.Gerleve
Fixes for server-side Tencent anti-cheat library integration:
-Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows
-Add getter for the TssSdkAntiInterf object
-Enable server anti-cheat in editor builds
#!codereview sam.zamani
#!rb none
#!tests enabled Tencent OSS, built & ran server
Change 3658200 on 2017/09/22 by Graeme.Thornton
Manual copy of CL 3587584 from Dev-Core
Logging improvements for pak signature check failures
- Added "PakCorrupt" console command which corrupts the master signature table
- Added some extra log information about which block failed
- Re-hash the master signature table and to make sure that it hasn't changed since startup
- Moved the ensure around so that some extra logging messages can make it out before the ensure is hit
- Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again
#!rb none
#!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General
Change 3657970 on 2017/09/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition.
We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game,
[at marcus.wassmer,] [at arne.schober] #!rb none
#!tests cycled 6-7 levels of Paragon
#!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657914 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing...
#!tests stepped through in non-pkg build
#!rb none
#!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657906 on 2017/09/21 by Andrew.Grant
Improved some logging
#!tests used locally
#!rb none
Change 3657891 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing
Fixed issue with -dev mode on PS4 not updating symbols
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657867 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Re-locked network CL to 3652780
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657857 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444
#!RB:arciel.rekman
#!Tests:Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf
#!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657852 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for case-insensitivity causing title.json not to be staged
#!rb daniel.lamb, bob.tellez
#!tests ran packaging script, verified contents match v42
#!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657831 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors
We can worry about a more permanent solution after we get this live.
#!RB:none
#!Tests: Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer
#!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657824 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb
--------------------------------------
Built new UnrealCEFSubprocess client
Changed OrionBuild.xml to build the shipping version of the above.
The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this.
[at justin.sargent,[at benjamin.crocker,[at wes.fudala]]]
#!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657488 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: anton.migulko
LIGHTING AND assets update
#!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3656388 on 2017/09/21 by Laurent.Delayen
Added default GetAxisVector static function to EAxisOption
#!rb none
#!FYI thomas.sarkanen
#!tests lane minions test map
Change 3656387 on 2017/09/21 by Laurent.Delayen
Initialize FAnimInstanceProxy with default constructor.
#!rb none
#!fyi lina.halper, thomas.sarkanen
#!tests lane minion test map
Change 3656003 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3650578 for patching
benjamin.crocker
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654403 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Merge DevCore -> Orion Release-43 CL 3641450
UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers.
#!rb Daniel.Lamb
#!test Compile
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654356 on 2017/09/20 by Andrew.Grant
Merging 3653658 from Dev-Rendering
#!tests compiled, ran editor
#!rb marcus.wassmer
Change 3653914 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access).
#!rb none
#!tests ran locally
#!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3652495 on 2017/09/19 by Andrew.Grant
Editgration of VR fix in 3643776 from Release-4.17
#!tests #!rb na
Change 3652244 on 2017/09/19 by Sam.Zamani
#!tencent
Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher
Added "-q" to whitelist of command line params for shipping builds
Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher
#!rb rob.cannaday
#!tests none
Change 3651493 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651490 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651489 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651445 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag
#!RB:none
#!Tests:none
[CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant
#!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651059 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed code to archive load-order during tests
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651043 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed error parsing from tests to put cause ahead of file info
#!tests ran self-test
#!rb none
#!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649683 on 2017/09/18 by Andrew.Grant
Bulk-merge of oustanding changes in Main to DG
#!tests #!rb na
Change 3649345 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Integrate fix for eidtor crash when switching between low and high scaleability options.
#!rb Olaf.Piesche
#!test Paragon editor
#!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649335 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - OR-44257 - Fix for hair not working
It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion.
#!RB:daniel.lamb
#!Tests:Re-tested in cooked build
[CODEREVIEW] daniel.lamb
#!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649231 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM
#!RB:none
#!Tests:none
[CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy
#!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649211 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix 'lowest' shadow settings (simple forward rendering)
#!rb arne.schober
[FYI] Daniel.Wright
#!tests monolith
#!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649141 on 2017/09/18 by Stephan.Jiang
Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source.
-- These are hacks for ability videos to work before we have the new Sequencer updates
-- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748
#!fyi Andrew.Grant, Max.Preussner
#!rb none
#!test compile
Change 3649087 on 2017/09/18 by Thomas.Ross
Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General
#!rb none
#!tests none
#!fyi Andrew.Grant,Jeff.Williams,dan.oconnor
Change 3649066 on 2017/09/18 by Max.Preussner
WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources
#!rb stephan.jiang
#!rnx
#!tests none
Change 3649049 on 2017/09/18 by Max.Preussner
Media: Changed audio sample rate warning to verbose log
#!fyi stephan.jiang
#!rb none
#!rnx
#!tests none
Change 3648752 on 2017/09/18 by Max.Preussner
WmfMedia: Fixed race condition in media sound wave
#!rb none
#!rnx
#!tests none
Change 3648748 on 2017/09/18 by Max.Preussner
WmfMedia: Hack for preventing flicker between media source switching
Do not merge to Dev-Main!
#!rb stephan.jiang
#!rnx
#!tests none
Change 3648596 on 2017/09/18 by Bart.Hawthorne
More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough.
Change 3648575 on 2017/09/18 by Sam.Zamani
#!tencent
Fix for missing library calls when initializing TSS anti cheat SDK
#!rb none
#!tests compiles win64 server
Change 3648556 on 2017/09/18 by Jeff.Williams
Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084
Clearing up robomerge
#!rb none
#!tests none
Change 3648533 on 2017/09/18 by clayton.langford
Unblocking RM.
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly.
#!RB Adric.Worley
#!tests none
#!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3648219 on 2017/09/18 by Sam.Zamani
#!tencent
fixed Tencent module thirdparty dll runtime dependency paths
fixed DLLHandle not being set
#!rb none
#!tests none
Change 3647998 on 2017/09/18 by Clayton.Langford
Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763.
#!tests compiled
#!rb Adric.Worley
Change 3647817 on 2017/09/18 by James.Golding
Mirror fix from 4.18 release stream (CL 3647799) to Dev-General
Fix out-of-bounds access of cloth mapping data during CPU skinning
#!rb benn.gallagher
#!jira UE-49628
#!fyi benn.gallagher
#!tests convert RiftMage to static mesh
Change 3647749 on 2017/09/18 by Benn.Gallagher
Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope.
This caused matrix transposition to fail after the data was copied in using memcpy
BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs.
#!rb none
#!tests Editor reimport of clothing assets
Change 3646242 on 2017/09/15 by Tyler.Cole
Revert shared engine LocalMCP scripts.
Change 3646153 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds
#!RB:daniel.lamb
#!Tests: Ran cooked Client
[CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy
#!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3646125 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews.
#!RB Marcus.Wassmer
#!tests automated performance tests
#!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3645861 on 2017/09/15 by clayton.langford
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW.
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added.
To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards
Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated.
#!tests ran local client/server, preflighted
#!rb Ben.Salem
#!rnx
[FYI] Sean.Tobin, Hunter.Kent, Edward.King
#!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3644062 on 2017/09/14 by Aaron.McLeran
#!jira OR-44171 Some looping sounds are extremely loud
#!rb Ethan.Geller
#!tests run paragon, run near water river, don't observe looping sound being very loud
Change 3643901 on 2017/09/14 by Laurent.Delayen
Integrated CL #!3604725 to fix bug with opening state machines from anim graph.
#!rb none
#!tests fixes bug
#!FYI lina.halper
Change 3643641 on 2017/09/14 by Rob.Cannaday
Fix unreachable code detected
#!rb rob.cannaday
#!tests Win64 compile
Change 3643326 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TerSafe.dll loading until staging issues can be resolved
#!rb none
#!tests none
Change 3643039 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TSS on servers due to linux build issues
#!rb none
#!tests none
Change 3642438 on 2017/09/13 by Rob.Cannaday
Handle new analytics param types (number, string, etc)
Stub implementation of FAnalyticsProviderETTencent DefaultAttrs
#!rb rob.cannaday
#!tests Win64 vs AI match
Change 3641655 on 2017/09/13 by Sam.Zamani
#!tencent
WIP added tss_sdk.dll (server) and TerSafe.dll (client)
JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client
JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers
#!rb none
#!tests PC run with RegionCN.pak enabling tencent mode
Change 3641559 on 2017/09/13 by Bart.Hawthorne
Fix up oodle dictionary generation scripts
#!rb none
#!jira none
Change 3641550 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3641393 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev.
Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled
- Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false)
- Added PGOInput option to TargetRules and passed through to compile environment
- Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for
- Updated PS4 toolchain to use both LTO and PGO depending on what was set
#!tests soaked locally, preflighted
#!rb codereviewed
FWIW here are before/after results for LTCG.
Orion Performance report from 3 games and 1441.51 seconds
MVP: 2.83 (Min: 2.05, Max: 3.22)
HPM: 4.29 (Min: 4.24, Max: 4.37)
AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms)
GT: 12.88ms (Min: 12.68ms, Max: 13.25ms)
RT: 13.71ms (Min: 13.48ms, Max: 14.08ms)
GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms)
Orion Performance report from 3 games and 1440.49 seconds
MVP: 1.42 (Min: 1.02, Max: 1.94)
HPM: 3.25 (Min: 2.75, Max: 3.62)
AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms)
GT: 11.93ms (Min: 11.64ms, Max: 12.47ms)
RT: 12.80ms (Min: 12.54ms, Max: 13.24ms)
GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms)
#!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640885 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Limited warning to once every 10 secs.
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640875 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed shipping config issue
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640870 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Fixing CIS builds #!Orion
The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors.
[CODEREVIEW] John.Nielson
#!rb none
#!test compilation
#!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640783 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
More temporary logging for finding the missing FX issue.
#!rb: none
#!Test: Pie
#!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639910 on 2017/09/12 by Rob.Cannaday
Build fix for AnalyticsETTencent
#!rb rob.cannaday
#!tests compile Win64 DebugGame Editor
Change 3639565 on 2017/09/12 by Laurent.Delayen
SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0.
#!rb lina.halper
#!FYI lina.halper
#!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime.
Change 3639228 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Tools - Added ability to postmortem a PS4 devkit for last crash
#!rb run locally
#!tests none
#!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639075 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Specifically requesting 'all' configuration, to avoid missing manifest in jar.
#!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639022 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
Remove dependency on the editor style set in the WidgetReflector
- Fixes a crash when trying to use the reflector in a client cooked build
- Also updated Focusable column name to shared var
#!rb none
#!tests Widget Reflected in a cooked build
#!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638984 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638696 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Swapped problematic ensure to LogError, made draft obey notimeouts.
#!tests compiled
#!rb none
[at daniel.lamb]
#!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638644 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Third time's the charm
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638628 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure in a PS4 friendly way
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638583 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure to get a cook
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638545 on 2017/09/12 by Bart.Hawthorne
Add analytics for oodle compression percentages
#!rb ryan.gerleve, wes.hunt
#!tests ran a 2 person game with dedicated server and verified analytics were reported
#!jira OR-26386
Change 3638172 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Duplicate 3620803
Partial Fix for Dither Opacity Mask
#!rb none
#!tests PC monolith
#!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637643 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Fixing version stream to Main
#!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637524 on 2017/09/11 by Andrew.Grant
Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests build Win64 editor, ran tests locally
#!rb none
Change 3637402 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Restored logging of runoptions when not verbose
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637357 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Made 'none' test specify Attended
#!rb Daniel.Lamb
#!tests compiled
#!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637305 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added temporary debug logging cmd line option for finding Jira OrionOR-43600
#!RB: none
#!Test: Pie
[at David.Ratti]
#!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636549 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues
#!RB:none
#!Tests:none
[CODEREVIEW] uriel.doyon
#!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636507 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
[OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG.
Also:
- Added distance formatting type for simple ability description values (will automatically append u to the value)
- SimpleAbility description values can now go up to two decimal places
Engine:
- Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName
#!rb Matt.Schembari
#!tests PIE OrionEntry & FrontEndScene - various bug repros
#!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636372 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Implement fast particle pool memory.
Default is 2mb, automatically cleans up oldest used pool slots.
Estimated 1/4 time for STAT_PARTALLOC.
#!rb Jason.Bestimt
#!test paragon ps4 cooked
#!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636319 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue with fatal error message not being shown in reports.
Fixed issue where some cancelled tests reported as succeeded
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636264 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance
#!RB:none
#!Tests: Ran client cooked build
[CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon
[QAREVIEW]
#!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635288 on 2017/09/10 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices
Fixed missing - in SoloSmoke args that were causing trailing params to be lost
#!tests preflighted, ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635145 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to pick up SDK change for patch packages
#!rb none
#!tests none
#!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635097 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added cleardevices option to Gauntlet that removes all devices after running.
Added to Orion build scripts
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634985 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Cleaned up some logging around device failures
Attempt to handle "Too Many Connections" error at a lower level
Added removeall command to PS4DevkitUtil (not yet used)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634897 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Checking in change to timeouts to test theory
#!tests ran test locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634765 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Scrape another .05ms out of GPU particle simulation.
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634422 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for Gauntlet shutdown issue on builders
Fix for BP editing crash from Dev-Framework
#!tests ran locally
#!rb none!
#!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634139 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running
#!tests ran locally with single and file-based devices
#!rb none
#!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633799 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only.
#!rb none
#!tests monolith02 turrets
[CODEREVIEW] lina.halper
#!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633647 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Possible fix for OR-43926 from Arne
#!tests ran locally, observed no ensures or negative side-effects in UI or HUD
#!rb none
#!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633637 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Upped timeout for editorbased tests
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632565 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed some test code...
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632385 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device handling.
Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems.
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632177 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43
#!rb none
#!test local commandlet
#!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632131 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix a bug with new local vector-field only project setting
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632034 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where problem devices were reset each attempt
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631812 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device management in Gauntlet
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631787 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes.
#!rb none
[CODEREVIEW] martin.wilson
#!test bot game
#!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631251 on 2017/09/07 by Andrew.Grant
Additional device selection improvements
#!tests #!rb na
Change 3630861 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3630620 on 2017/09/07 by Laurent.Delayen
RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions.
#!rb Ori.Cohen
#!codereview benn.gallagher
#!tests lane minions test map
Change 3629990 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fix for gpu hang on ps4.
#!rb Marcus.Wassmer
#!test Paragon cooked ps4
#!jira OR-43835
#!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629980 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Moved some missed code to FDebug::HasAsserted()
#!tests na
#!rb none
#!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629975 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Project optimization to only support local vector fields.
separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost.
#!rb olaf.piesche
#!tests monolith ps4/pc
#!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629917 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix for sizebyspeed on ps4
#!rb Simon.Tovey
#!tests pc
#!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629620 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629554 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored screenshot support to gauntlet (now driven externally)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629495 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: don.eubanks
Stat panel will only show stat changes or improvements that come from Item sources (cards / gems)
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
[RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base!
#!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629468 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring()
Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread.
#!tests ran locally
#!rb none
[at marcus.wassmer]
#!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629410 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs
--------------------------------------
Fix for generating project files
#!tests GPF
#!rb none
#!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629369 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests)
#!rb none
#!tests verified signing is disabled and game gets to main menu with -fileopenlog
[at graeme.thornton]
#!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629254 on 2017/09/06 by Laurent.Delayen
URO: ensure we don't skip more frames than desired when switching LODs.
#!rb lina.halper
#!codereview martin.wilson, benn.gallagher
#!test lane minions test map
Change 3629191 on 2017/09/06 by Laurent.Delayen
Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions.
#!rb lina.halper
#!codereview martin.wilson
#!test lane minions test map
Change 3629130 on 2017/09/06 by Laurent.Delayen
AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug.
#!rb none
#!tests lane minion test map
Change 3628300 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed exception that could occur during tests if all devices were in use
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627915 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Undoing Oodle check for the time being
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627875 on 2017/09/06 by Jason.Bestimt
#!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables)
#!RB:none
#!Tests:none
#!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker
#!ROBOMERGE: MAIN, 43
Change 3627694 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Improved warnings
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627642 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
More logging for OR-43892 and OR-43779
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627247 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed check that turns out to be bogus
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627240 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures
#!tests compiled OrionClient
[at daniel.lamb] #!rb none
#!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627211 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added ensure for OR-43777
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626839 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added wait to PS4DevkitUtil before trying to postmortem crashdump
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626755 on 2017/09/05 by Rob.Cannaday
Merge //Orion/Release-Tencent to //Orion/Dev-General
Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT
TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded
#!rb sam.zamani
#!lockdown andrew.grant
#!tests Win64 vs AI match, QA smoke test
#!fyi sam.zamani
Change 3626285 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed BaseDir argument not being correctly applied in tests
Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626221 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame.
Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement
#!rb none
#!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz
[at Laurent.Delayen] [FYI] [at Andrew.Grant]
#!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3625925 on 2017/09/05 by Laurent.Delayen
If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want.
#!rb benn.gallagher
#!codereview martin.wilson, lina.halper
#!tests lane minion map
Change 3624051 on 2017/09/02 by Andrew.Grant
Fixed issue with test params not being set.
Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability.
#!tests preflighted
#!rb none
#!review-3624052 @ben.salem
Change 3623907 on 2017/09/02 by Andrew.Grant
Fixed usesyncedbuild option being broken in Gauntlet
#!codereview @daniel.lamb
#!tests compiled
#!rb none
Change 3623906 on 2017/09/02 by David.Ratti
Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides
#!rb none
#!test future wukong pie
Change 3623766 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box
#!rb none
#!Tests PC QAGame
Change 3623518 on 2017/09/01 by Don.Eubanks
Fix for Shipping Client PS4
#!rb none
#!tests Compile Shipping Client PS4
#!fyi daniel.lamb andrew.grant
Change 3623515 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials applied to static meshes operate on the object's bounding sphere
#!rb none
#!TESTS QAGame PC
Change 3623503 on 2017/09/01 by Daniel.Wright
[Copy] Fixed ObjectRadius in Volume domain materials
#!rb none
#!TESTS none
Change 3623102 on 2017/09/01 by Marcus.Wassmer
Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand
#!rb none
#!tests monolith on PS4
#!fyi olaf.piesche,tim.elek
Change 3623096 on 2017/09/01 by Marcus.Wassmer
checkslow -> check to find issues with ILC
#!rb none
#!tests ran monolith on ps4
Change 3622744 on 2017/09/01 by Laurent.Delayen
RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now).
Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies.
Take gravity from movement component if present, to inherit custom gravity scaling.
Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used.
If LOD enables new bodies, they are now initialized during simulation.
Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default.
Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change.
Added AnimStats for PreUpdate, Update and Eval.
#!rb ori.cohen
#!codereview ori.cohen, lina.halper, benn.ghallager
#!tests lane minion test map
Change 3622743 on 2017/09/01 by Laurent.Delayen
Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes.
#!rb lina.halper
#!tests lane minion test map
Change 3622742 on 2017/09/01 by Laurent.Delayen
'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings.
Renamed DisplayDebugCustom to DisplayDebugInstance.
#!rb lina.halper
#!tests lane minion test map
Change 3622738 on 2017/09/01 by Laurent.Delayen
Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams
#!rb lina.halper
#!tests lane minion test map
Change 3622666 on 2017/09/01 by Jian.Ru
Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements
#!jira UE-48972, OR-43455
#!rb Chris.Bunner
#!tests editor
Change 3622579 on 2017/09/01 by Andrew.Grant
Fixed shutdown issues with some tests being detected as errors
Simplied and cleanup some things in state management of tests.
#!tests ShortSOloGame test locally
#!rb none
Change 3622322 on 2017/09/01 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-40366 from v43
#!tests compiled
#!rb Aaron.McLeran
#!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3621054 on 2017/08/31 by Andrew.Grant
Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests preflighted
#!rb none
Change 3620755 on 2017/08/31 by Daniel.Lamb
Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations.
#!rb Jason.Bestimt
#!test Cooked paragon ps4
Change 3620541 on 2017/08/31 by Ben.Salem
Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting.
#!rb none
#!tests compiled.
Change 3620443 on 2017/08/31 by Mieszko.Zielinski
Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4
#!rb none
#!test golden path
Change 3620428 on 2017/08/31 by Aaron.McLeran
#!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General
#!rb Ethan.Geller
#!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports.
Change 3620411 on 2017/08/31 by Mieszko.Zielinski
Fix to removal of simuli sources from the AISense_Sight #!UE4
Made sure given source gets removed from ObservedTargets.
#!rb none
#!test golden path
Change 3620343 on 2017/08/31 by Ben.Salem
Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on.
#!rb clayton.langford
#!tests ran shallow and normal FX tests, generated hitches to display.
Change 3620050 on 2017/08/31 by Luke.Thatcher
[ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/...
- USE_DEFRAG_ALLOCATOR was not always defined in all cases.
#!rb Daniel.Lamb
#!tests none
Change 3619836 on 2017/08/31 by Andrew.Grant
Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team)
#!tests preflighted, ran locally
#!rb none
Change 3618597 on 2017/08/30 by Dan.Hertzka
Fixed Additive UI materials not being affected by the widget opacity
- We needed to multiply the sampled color by the alpha of the vertex color
Also added fade in anim for scoreboard when showing after the endgame cinematic
#!rb Nick.Darnell
#!tests Widget alpha affects additive materials
Change 3618441 on 2017/08/30 by Laurent.Delayen
Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display.
#!rb lina.halper
#!tests lane minions
Change 3618404 on 2017/08/30 by Paul.Moore
- Update to new MMS client API from Fortnite.
- Add MMS API plugin.
#!rb none
#!tests matchmaking, v2 MMS matchmaking, draft lobby.
#!lockdown andrew.grant
Change 3618167 on 2017/08/30 by Marcus.Wassmer
Fix fog on PS4, also volume texture clears.
#!rb luke.thatcher
#!fyi Jordan.Walker
#!tests ran monolith on ps4
Change 3617911 on 2017/08/30 by Andrew.Grant
Fix for OR-43401, lighting remaining unbuilt
#!tests ran cook, verified that lighting for bp components is now correctly found.
#!rb marc.audy
Change 3617765 on 2017/08/30 by Andrew.Grant
Fix for lighting always being unbuilt on some blueprints
#!tests cooked data and verified BP components have the correct transform and receive cached lighting data
#!rb marc.audy, bp-team
Change 3617757 on 2017/08/30 by Laurent.Delayen
clang fix
#!rb none
#!tests none
Change 3617700 on 2017/08/30 by Laurent.Delayen
Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated.
#!rb lina.halper
#!tests lane minions map
Change 3617695 on 2017/08/30 by Laurent.Delayen
Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays.
#!rb lina.halper
#!tests test lane minions map
Change 3616757 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-43459 from Laurent
#!tests na
#!rb Lina.Halper, Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616745 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3609966 in anticipation of patch
#!rb #!tests na
#!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616551 on 2017/08/29 by Daniel.Lamb
Fix memory leak in paragon.
#!rb Andrew.Grant
#!test Paragon ps4
Change 3613700 on 2017/08/28 by Andrew.Grant
Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion
Renabled r.Cache.UpdatePrimsTaskEnabled
#!tests ran locally
#!rb none
Change 3613694 on 2017/08/28 by Andrew.Grant
Added -teamsize argument to Orion none test.
#!tests ran None test :)
#!rb none
Change 3613638 on 2017/08/28 by Ben.Salem
Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created.
#!rb clayton.langford
#!tests Ran shallow and deep test for multiple characters.
Change 3612731 on 2017/08/28 by Chris.Bunner
[DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook.
#!rb
#!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb
#!tests Cooking/running simple scene with grass foliage
#!jira UE-48698, OR-42612
Change 3612695 on 2017/08/28 by Andrew.Grant
Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading
Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things.
#!tests ran NoneTest with -nomcp
#!rb none
Change 3612002 on 2017/08/27 by Andrew.Grant
Fix for crash seen during nightly tests
#!tests baseline perf didn't crast 3/3
#!rb none
Change 3611980 on 2017/08/27 by Andrew.Grant
PS4DevkitUtil post-mortem improvements to logging
#!tests run ShortSoloGame
#!rb none
Change 3611758 on 2017/08/26 by Andrew.Grant
Fix for warning
#!tests #!rb na
Change 3611737 on 2017/08/26 by Andrew.Grant
Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering
3517039 -
GitHub #!2655: Optimization for shadow map resolution selection for spot lights
* Use the radius of the inscribed sphere at the cone end as the spot light's screen radius
Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly
3545241 -
Fixed spotlight whole scene shadows using a radius 2x too long
3545347 -
Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame.
#!rb none
#!tests compiled
Change 3611718 on 2017/08/26 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs
--------------------------------------
Improved parsing of callstacks and errors in test logs
Added unit test for error parsing
#!tests ran locally, unit tests
#!rb none
#!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611704 on 2017/08/26 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Test fixes - addresses issue with memory report failing
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611683 on 2017/08/26 by Andrew.Grant
Upgraded PS4 SDK to 4.508.111
#!tests SoloGames locally
#!rb none
Change 3611466 on 2017/08/25 by Andrew.Grant
Changed none test to use monolith02 by default
#!tests compiled
#!rb none
Change 3611167 on 2017/08/25 by Laurent.Delayen
Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated.
#!rb none
#!tests lane minions
#!codereview martin.wilson
Change 3610850 on 2017/08/25 by dan.hertzka
Unclog Robomerge
#!rb none
#!tests none
Change 3610325 on 2017/08/25 by Andrew.Grant
Compile fix for PS4
#!tests compiled
#!rb none
Change 3610018 on 2017/08/25 by Laurent.Delayen
UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later.
#!rb lina.halper
#!tests venus ult on minion lane test map
Change 3609967 on 2017/08/25 by Daniel.Lamb
Merging using //Fortnite/Main/->//Orion/Dev-General/
Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4.
CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping.
- The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out.
- Added an extra flag to reset mip bias values when texture memory budget is increased.
#!rb Uriel.Doyon
#!jira FORT-45385
#!jira FORT-47739
CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4.
- Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled.
- Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted.
- Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps.
#!jira FORT-45229
#!rb Ben.Woodhouse
CL 3564368
LLM Changes
Summary:
LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead.
Changes where LLM hooks into the various allocation functions and pools.
Added more LLM tracking scopes.
Changed the way LLM gets its internal memory.
Writing stats out to csv
Fixed a few bugs with the tracker code
Details:
* re-enabled LLM by default in Dev builds for XB1 and PS4
* Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update)
* track allocations made from the defrag pool (PS4)
* track non-drfrag pool garlic allocations (PS4)
* track allocations made from PS4 malloc
* combined the RHI and Malloc trackers into the Default tracker
* changed stat groups to LLM, LLMPlatform and LLMOverhead
* OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set
* XMemAlloc now uses AllocationType if no LLM scope has been set
* renamed VirtualMap to LLMMap
* added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled.
* support for tracking allocations that move in memory (for the PS4 defrag allocator)
* support for tracking explicit memory without pausing the tracker
* LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg
* fixed check in FNameToTag. It was checking the wrong value when verifying the name index
* show a warning on screen if LLM has been enabled without debug memory enabled (on consoles)
* fixed program size tracking
* fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope.
* optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times)
* fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them.
* fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled
* changed default alloc size for LLMMap to 16K
* Added lots more LLM scopes renamed some of the existing ones
* made FMemBlock::Allocators private and added accessor functions, which include LLM tracking.
* fixed LLM alignment tracking in CustomVirtualAlloc
* implemented LLM on XB1 so that it properly tracks D3D12Allocations
* added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator
* tracking of render targets
* fixed LLM pool total column value.
#!rb luke.thatcher
CL 3565905
[ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/...
3458941 - Initial submission of new PS4 memory allocator.
3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible.
3498440 - Flexible and framebuffer memory fallbacks
3515704 - Add stats to new PS4 memory system.
UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly.
#!rb Ben.Woodhouse
CL 3580934
[FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo.
- Neo has 512 MB more direct memory than a base kit.
- Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB.
#!rb Marcus.Wassmer
#!jira FORT-50206
CL 3590180
[FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted.
- Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB.
- Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool.
- Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails.
#!jira FORT-49700
#!rb Aaron.McLeran
CL 3593920
[FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system.
- Incorrect bitmask usage was truncating the available memory value to 32 bits.
- Also includes some minor refactoring to make parts more readable.
- Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile.
#!rb Jonathan.Fitzpatrick
#!jira FORT-50918
CL 3597577
[FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU.
- Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack.
- With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is.
#!rb Stewart.Lynch
#!jira FORT-50825
#!jira FORT-49688
#!jira FORT-49695
#!jira FORT-50054
CL 3601951
[FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system
- Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0.
- Added garlic, onion and defrag stats to the platform memory stats struct.
- Added fixed pool sizes to platform memory stats.
- Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools.
#!rb Stewart.Lynch
#!jira FORT-52910
#!test preflight with baseline performance memory report tests, local tests on neo
#!rb Luke.Thatcher
Change 3608480 on 2017/08/24 by Uriel.Doyon
Instanced static mesh lightmaps are now updated correctly after lighting scenario changes
#!jira UE-48522
#!tests Build lighting, loaded maps
#!rb michel.dupuis
Change 3608407 on 2017/08/24 by Andrew.Grant
Reintegrated ROlando's cloth optimizations
#!tests #!rb none
Change 3608349 on 2017/08/24 by Rolando.Caloca
O - Cloth vertex buffers no longer generate dummy vertices
#!rb Lina.Halper
#!fyi James.Golding
#!tests Check obj list memory with multiple characters, tested animations
Change 3607815 on 2017/08/24 by Laurent.Delayen
Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha.
https://jira.it.epicgames.net/browse/OR-43186
#!rb none
#!tests Price hand two bone IK
#!codereview lina.halper, thomas.sarkanen
Change 3607770 on 2017/08/24 by Andrew.Grant
Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong
#!tests ran locally, updated parser test
#!rb none
Change 3607546 on 2017/08/24 by Jian.Ru
Add more control to chromatic aberration effect
#!jira UE-47138
#!rb Brian.Karis
#!tests editor
Change 3607270 on 2017/08/24 by Andrew.Grant
Mirroring 3605735 from FN to address bug with MIC deduplication
#!tests compiled
#!rb none
Change 3607082 on 2017/08/24 by Laurent.Delayen
Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands.
List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph).
Current debug Target is highlighted in a green bounding box.
Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player.
Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors.
Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation.
#!rb dave.ratti
#!tests lane minion test map, debugging individual minions
#!codereview jon.lietz
Change 3606772 on 2017/08/24 by David.Ratti
Spot edigrate CL 3606417 for accurate CurveTable memory tracking
#!rb none
#!tests none
[CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
2021-09-29 17:45:16 -04:00
void PacketHandler : : InitializeDelegates ( FPacketHandlerLowLevelSendTraits InLowLevelSendDel ,
FPacketHandlerNotifyAddHandler InAddHandlerDel /*=FPacketHandlerNotifyAddHandler()*/ )
{
LowLevelSendDel = InLowLevelSendDel ;
AddHandlerDel = InAddHandlerDel ;
}
void PacketHandler : : InitFaultRecovery ( UE : : Net : : FNetConnectionFaultRecoveryBase * InFaultRecovery )
{
for ( TSharedPtr < HandlerComponent > & CurComponent : HandlerComponents )
{
CurComponent - > InitFaultRecovery ( InFaultRecovery ) ;
}
}
2018-10-29 10:01:28 -04:00
void PacketHandler : : NotifyAnalyticsProvider ( TSharedPtr < IAnalyticsProvider > InProvider , TSharedPtr < FNetAnalyticsAggregator > InAggregator )
{
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main
#lockdown Nick.Penwarden
#rb none
Change 3720210 on 2017/10/25 by Olaf.Piesche
Fixing dynamic material params for ribbons
#!codereview scott.kennedy
#!rb none
#!tests scott's test ribbon
Change 3720073 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: frank.fella
Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it.
#!Tests Minion automated tests no longer crash randomly.
#!rb SimonT
#!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3719233 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: philip.buuck
[OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead).
#!rb Matt.Schembari
#!tests PIE
[QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death
#!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3718474 on 2017/10/25 by Yannick.Lange
Niagara: Only show isolate menu items on track context menu if it is a system.
Rename "Isolate toggle" to "Isolated".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718095 on 2017/10/25 by Yannick.Lange
Niagara: Fix crash when not having dynamic parameter in material.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718069 on 2017/10/25 by Yannick.Lange
Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3717545 on 2017/10/24 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Removed read / write locks from PipelineStateCache.
#!rb Andrew.Grant, Gil.Gribb
#!test paragon ps4.
#!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3716928 on 2017/10/24 by Shaun.Kime
The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime.
#!rb olaf.piesche, simon.tovey
#!fyi olaf.piesche, simon.tovey, frank.fella
#!tests am now able to run Test_minionWave on PS4
Change 3715712 on 2017/10/24 by Yannick.Lange
Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3715430 on 2017/10/23 by Shaun.Kime
Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it.
#!rb none
#!fyi simon.tovey
#!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime
Change 3715368 on 2017/10/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main)
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3715226 on 2017/10/23 by Shaun.Kime
Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's.
#!rb none
#!fyi simon.tovey, olaf.piesche, frank.fella
#!tests ran in PIE
Change 3714645 on 2017/10/23 by Yannick.Lange
Niagara: Add ability to create particle system from this emitter in content browser.
#!rb Shaun.Kime
#!tests n/a
Change 3714200 on 2017/10/23 by Olaf.Piesche
Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target
#!codereview simon
#!rb none
#!tests Orion Niagara assets
Change 3713341 on 2017/10/23 by Yannick.Lange
Niagara: Fix NiagaraNodeIF output pins cannot be deleted.
Fix NiagaraNodeIF output pins cannot be renamed.
#!jira UE-50193
#!jira UE-50193
#!rb Shaun.Kime
#!tests n/a
Change 3713133 on 2017/10/23 by Yannick.Lange
Niagara: Isolate emitters in sequencer UI.
- Added being able to extend the sequencer track context menu with a delegate.
- Added entry in track context menu to toggle the selected emitters isolation state.
- Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters.
#!rb Shaun.Kime
#!tests n/a
Change 3712445 on 2017/10/22 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
UVScale, UniformAorBFloat, and LinearColorAlongVector added.
#!rb none
#!tests new autotest added
#!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3712420 on 2017/10/21 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1.
#!rb none
[CODEREVIEW] frank.fella
[FYI] simon.tovey, olaf.piesche, wyeth.johnson
#!tests created an emitter, disabled Acceleration Force.. still compiled.
#!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711602 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like:
LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData
#!jira UE-51511
#!rb Simon.Tovey
#!tests n/a
#!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711288 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: eric.ketchum
[Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work
#!rb: None
#!tests: PIE
[CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime
#!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711197 on 2017/10/20 by Olaf.Piesche
Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly
#!rb none
#!tests minion projectile ribbon trail
Change 3710634 on 2017/10/20 by Mic.Rooney
Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing.
#!RB: none
#!Test: tested/built locally ran preflight Editor/Monolithics build.
#!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3709686 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Added some more timerguards for slow timer manager tick objects.
Commented out for now.
#!rb Trivial
#!test Paragon Cooked ps4.
#!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708958 on 2017/10/19 by Shaun.Kime
Back out changelist 3708456 .. this was an unintentional change
#!rb none
#!tests n/a
Change 3708839 on 2017/10/19 by Shaun.Kime
Merging CL 3708835
Fixing Scott's common crash with adding an emitter with autocompile off
#!rb frank.fella
#!tests n/a
Change 3708784 on 2017/10/19 by Shaun.Kime
Merging CL 3708782
//Orion/Main/... to //Orion/DevGeneral/...
#!rb none
#!tests n/a
Change 3708600 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion
#!rb none
#!test golden path
#!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708473 on 2017/10/19 by Shaun.Kime
Merging Frank's changes for team color support from Main to Dev-General
#!rb Frank.Fella
#!tests test_minionwave worked
Change 3708456 on 2017/10/19 by Shaun.Kime
Particles.Random set to 0.0
#!rb none
#!tests n/a
Change 3708455 on 2017/10/19 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests passed minion fx autotest
Change 3707648 on 2017/10/19 by Shaun.Kime
Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made.
Defer deletion of dataset to RT.
Ensure resets don't mess with data inflight RT commands are using.
Checkin on behalf of Simon Tovey
#!jira OR-45423
#!rb Simon.Tovey
#!tests ran through the LaneMinionFXTests successfully on PC
Change 3707096 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago.
#!rb none
#!tests automated tests pass
#!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3706726 on 2017/10/19 by Rob.Cannaday
Merge XMPP resource version to use version 2 instead of version 3
#!rb trivial
#!tests compile
#!ROBOMERGE: Main, 44, Tencent
Change 3706349 on 2017/10/19 by Josh.Markiewicz
#!UE4 - Cross Voice code review feedback
- fixed up broken stack vs queue
- fixed GetRoomId returning int32 instead of uint64
- fixed switch room logic
- more/better logging
- more comments
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
#!rb none
#!tests local cheat codes
Change 3705453 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array)
#!RB Daniel.Wright
#!Tests LaunchOnPs4
#!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3705399 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: scott.kennedy
Default Niagara emitter changed color property to better default value.
Updated basic glow emitter
Added energy bubble base emitter
put a little more polish into siege minion impact FX.
#!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3704426 on 2017/10/18 by Shaun.Kime
Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423
#!rb simon.tovey
#!fyi hunter.kent
#!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure
Change 3703288 on 2017/10/18 by Olaf.Piesche
Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash
#!rb olaf.piesche, simon.tovey
#!tests minion test map PC and PS4
Change 3701373 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader.
#!rb Olaf.Piesche
#!tests test_minionwave runs
#!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3701108 on 2017/10/17 by Hunter.Kent
Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily.
#!RNX
#!Test PS4
#!rb @tim.elek
#!review-3701110 @andrew.grant, @daniel.lamb
Change 3701044 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: jon.lietz
- white space fixes
- added in more detail to logging
- fixed dragon GC to not hide when the mesh is hidden
#!rb none
#!tests complies and logging is updated
[FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen
#!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3700900 on 2017/10/17 by Shaun.Kime
Integrating possible crash fix from Dev-Niagara to Dev-Gen
#!rb none
#!tests n/a
#!fyi Olaf.Piesche
Change 3700492 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests done in branch
Change 3700217 on 2017/10/17 by Olaf.Piesche
Fix for potential crash in sprite renderer
#!rb none
#!tests minion test map
Change 3700216 on 2017/10/17 by Benn.Gallagher
Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master.
#!rb Lina.Halper
#!jira OR-45226
#!tests PIE + Standalone games hitting Rampage with Ghosts E
Change 3699660 on 2017/10/17 by Jason.Bestimt
#!ORION_DG - Fixes to UnrealHitchParser edge cases
#!RB:none
#!Tests: Ran on Logs from QA
#!CodeReview: ben.salem
Change 3699462 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!tests preflight ok
#!rb none
Change 3699010 on 2017/10/17 by Jeff.Williams
Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920
#!rb none
#!tests none
Change 3698519 on 2017/10/16 by Olaf.Piesche
Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts
#!rb none
#!tests minion wave test map
Change 3698380 on 2017/10/16 by Shaun.Kime
Updating logic to now support the autoattachment
#!rb none
#!tests autotests pass..
Change 3698263 on 2017/10/16 by Olaf.Piesche
Assume degrees for sprite rotation
#!rb none
#!codereview shaun.kime
#!tests test sprite emitter
Change 3697652 on 2017/10/16 by Olaf.Piesche
Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion
#!rb none
#!tests minion test map
Change 3696906 on 2017/10/15 by Shaun.Kime
Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers.
#!rb none
#!tests now no longer generates invalid errors
#!fyi frank.fella, olaf.piesche, simon.tovey
Change 3695456 on 2017/10/13 by Olaf.Piesche
Fix for potential ribbon crash and end-of-ribbon rendering artifacts
#!rb none
#!codereview scott.kennedy
#!tests minion wave test map
Change 3694545 on 2017/10/13 by Andrew.Grant
Fix for low frequency async loading crash (OR-42535)
#!rb gil.gribb
#!tests comppiled
Change 3694176 on 2017/10/13 by Jeff.Williams
Plugin manifest name changed to DLCFile name
#!rb none
#!tests compile, stage
Change 3693582 on 2017/10/12 by Don.Eubanks
Fixing PS4 Compile warning (constructor init order not matching member define order)
#!rb none
#!tests Compile Shipping Client PS4
#!fyi olaf.piesche
Change 3693516 on 2017/10/12 by Olaf.Piesche
Niagara: Remove mesh renderer assert, replace with early out
#!rb none
#!tests niagara mesh test asset
Merging
//Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
Change 3693051 on 2017/10/12 by Ben.Salem
Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log.
#!rb Clayton.Langford
#!tests Parsed a 5mb log with dumphitches down to 23k of hitch data.
Change 3692912 on 2017/10/12 by Olaf.Piesche
Merging: Niagara ribbon tiling distance
#!rb none
#!tests ribbon test asset
Change 3692835 on 2017/10/12 by Shaun.Kime
Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags.
#!rb none
#!fyi scott.kennedy, wyeth.johnson
#!tests n/a
Change 3692751 on 2017/10/12 by Shaun.Kime
Removing script that shouldn't have come over.
#!rb none
#!tests n/a
Change 3692746 on 2017/10/12 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests opened test level and created new emitter/system
Change 3692616 on 2017/10/12 by Don.Eubanks
OR-45131
Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking.
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
#!codereview nick.darnell
Change 3691912 on 2017/10/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none
#!tests compile, editor
#!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3690944 on 2017/10/11 by Jeff.Williams
Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC.
#!rb Daniel.Lamb
#!tests Compile, build
Change 3688989 on 2017/10/10 by Lina.Halper
LOD sync of attached/parent
#!rb: Laurent.Delayen
#!tests: price with shotgun skin/PIE/editor
Change 3687592 on 2017/10/09 by Ben.Salem
Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test.
#!rb clayton.langford
#!tests Ran sparrow shallow tests.
Change 3686560 on 2017/10/09 by Shaun.Kime
Flipping the min/max values to be standard
#!rb none
#!tests n/a
Change 3686046 on 2017/10/09 by Shaun.Kime
Merging latest from Dev-Niagara in preparation for Effects team work on Monday
#!rb none
#!tests successful preflight
#!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek
Change 3685613 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: simon.tovey
Implementing vector field matrix inverse fix from CL3675167 to 43.3.
#!rb none
#!tests none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685603 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
RotationalContent Improvements
- Fixed potential bug where tags could be updated when not intended on RotationalContentManager
- Fix for PIE assert
- Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option.
- Removing config tag from RotationalContentOverrides in OrionGlobals.
New Halloween Gauntlet Test
- Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box.
#!rb none
#!tests local builds / editor / PIE
#!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685408 on 2017/10/07 by ben.salem
Fixing robomerge error in DevGen
#!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. ben.salem, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml
--------------------------------------
Merging using DevGen->Release43.3
Repairing mailer for nightly Perf tests, fixing email headers.
#!tests run in devgen
#!rb none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685073 on 2017/10/06 by Andrew.Grant
Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3684717 on 2017/10/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where GT & RT times in profile info were reversed :(
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3684512 on 2017/10/06 by Laurent.Delayen
Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code.
#!rb lina.halper
#!tests minion AnimBP nativization
Change 3684059 on 2017/10/06 by Max.Preussner
Orion: Fixed ability videos not loading on PS4 and/or not looping
#!fyi stephan.jiang
#!jira OR-44682
#!rb none
#!rnx
#!tests none
Change 3683538 on 2017/10/06 by David.Ratti
batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions.
-Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players.
-Fixes case where killing minions with badass was not displaying pops (prediction key issue)
#!rb none
#!tests editor, pie
#!review-3683539 @Matt.Schembari
Change 3683364 on 2017/10/06 by Andrew.Grant
Changed warning to info
#!tests #!rb na
Change 3681999 on 2017/10/05 by Bart.Hawthorne
Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion.
#!rb cody.haskell
#!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore
#!jira OR-44111
#!tests Golden path, live spectated numerous matches.
Change 3681403 on 2017/10/04 by Josh.Markiewicz
#!UE4 - base pass for Tencent Cross SDK
- basic testing done with enter/exit/switch room
- basic testing of ShowUI
- checked in disabled
#!rb duck
#!tests see above
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
Change 3680623 on 2017/10/04 by David.Ratti
Rework for how max movement speed is calculated.
The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow.
Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored.
Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow.
GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc).
Suggested methods for inspection:
AbilitySystem debug hud (Home/End)
p.VisualizeMovement (displays final calculated movement speed)
Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar)
Technical information:
1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool.
2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows.
3. Added a notification for attribute sets when an aggregator is created for one of their attributes.
4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod)
5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension.
#!tests pie
#!rb FrankG
#!codereview Fred.Kimberley, Billy.Bramer
#!fyi colin.fogle
#!QAReview
#!RN
#!designchange
Change 3680580 on 2017/10/04 by Ben.Salem
Repair email titles for various reports.
#!rb none
#!tests Reran tests.
Change 3680438 on 2017/10/04 by Dan.Hertzka
GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect
- Fixes the HUD status effect feed not showing sources for a lot of itemization abilities
Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip
#!rb Dave.Ratti
#!tests OrionEntry PIE - equipped Sand Speeder
#!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on
Change 3680344 on 2017/10/04 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Speculative disable of defragging on volumetric lightmap textures.
#!rb andrew.grant
#!test monolith2 ps4
#!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3680302 on 2017/10/04 by Shaun.Kime
Integration from DevNiagara.
Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array.
#!rb none
#!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek
#!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass.
Change 3679946 on 2017/10/04 by Laurent.Delayen
Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches.
#!rb lina.halper
#!FYI andrew.grant
#!tests monolith2 old minions
Change 3679938 on 2017/10/04 by Daniel.Lamb
Allowed foliage cullall option to be modified by scalability options.
#!rb Trivial
#!test Compile paragon editor
Change 3679563 on 2017/10/04 by Jon.Lietz
OR-43599
- added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it.
#!rb Dave.Ratti
#!review-3679564 @John.Nielson
#!tests added these waits to hot pursuit and they worked as expected
Change 3679006 on 2017/10/03 by Ben.Salem
Try to fix broken nightly mailer issues for FX tests.
#!rb none
#!tests Preflighted a shallow fx pass successfully in EC.
Change 3677845 on 2017/10/03 by Andrew.Grant
Added an ensure to guard against OR-44826 while further investigations occur
#!tests compiled
#!rb none
Change 3677443 on 2017/10/03 by John.Nielson
Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase.
Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify).
#!RB: None
#!Test: Pie, Uncooked
#!review-3677445: @David.Ratti
Change 3676748 on 2017/10/02 by Laurent.Delayen
Minions: split body layer is now done in mesh space, to maintain upper body orientation.
#!FYI ray.arnett, lina.halper
#!rb none
#!test lane minion test map
Change 3675950 on 2017/10/02 by Don.Eubanks
Added several new supported tags / status effects to the Floating Status Effect Text system.
Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player.
Added ScaleOverDistance curve support for floating numbers / text.
Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out.
#!rb matt.schembari
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4
Change 3675186 on 2017/10/02 by Mic.Rooney
Support for other anim curve driving audio types (right now specifically DialogueWave)
#!RB: none
#!Test: compiled editor/monolithics/withoutunity and tested locally.
#!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3675167 on 2017/10/02 by Shaun.Kime
Changed unsafe InverseFast() to an Inverse()
#!jira OR-44671
#!rb Simon.Tovey
#!tests n/a
Change 3674888 on 2017/10/02 by David.Ratti
GGP V2
* Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration.
Item System:
* Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords.
* Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup).
Ability System:
* SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE)
#!rb none
#!tests editor pie cooked
#!review-3674889 @Jon.Lietz
Change 3674170 on 2017/09/30 by Mieszko.Zielinski
Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion
Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load.
#!rb none
#!test golden path
#!OR-44738
Change 3672937 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files
#!tests 3compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672867 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored previous behaviour of integer numbers being formatted as "1" and not "1.00"
#!tests ran game, checked playlist analytic
#!rb nikdel
#!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672575 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Remove warning that can happens normally with backwards compat replays
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672548 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Andrew.Grant
#!test Editor building hlods
#!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672542 on 2017/09/29 by Andrew.Grant
Merging
#!rb #!tests na
Change 3672390 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed memreport settings for frontend tests
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672385 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Reworked and pretty much final PipelineState cache code
- various comments incorporated
- namespaced functions
- removed redundant class and replaced with ref pointer
#!tests soaked a lot
[at daniel.lamb,] [at arne.schober] #!rb none
#!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672281 on 2017/09/29 by Rob.Cannaday
Add user ID to OnNetworkCheatDetected
#!jira TEN-272
#!jira TEN-273
#!jira TEN-274
#!rb rob.cannaday
#!tests Win64 AI match, simulate cheat detected by cheat command
#!review-3672282 @ian.fox @sam.zamani
Change 3671688 on 2017/09/29 by Frank.Gigliotti
Added ability to set developer comment when adding native tags.
#!RB David.Ratti
#!Tests None
Change 3670409 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for dump type made while doing cleanup
#!tests compiled Win64, PS4, ran PS4
#!rb none
#!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3670399 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed race condition in pipeline state cache
Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon
(Couple of extra tweaks planned, but this should be GTG for a v43 release)
#!rb codereviewed
#!tests soaked locally, lots
#!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669802 on 2017/09/28 by Andrew.Grant
From Dev-Framework
#!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed
#!rb michael.noland
#!codereview andrew.grant
#!tests na
Change 3669709 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669177 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Reflection Captures support Lighting Scenarios without recapturing
* Reflection Captures are now part of the Map Build
* Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message)
* Reflection Capture build data moved to the BuildData package
* Building lighting / reflection captures no longer dirties ULevels
* Sky lights which capture the scene now work correctly with Lighting Scenarios
* Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded)
#!rb Marcus.Wassmer
#!TESTS Paragon editor Monolith02
#!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669124 on 2017/09/28 by Daniel.Lamb
Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush
to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush
Fix cook in devgeneral
Bumped shader version to invalidate stale uniform buffer name.
#!rb none
#!TESTS none
#!fyi Daniel.Wright
Change 3667906 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667899 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Remove unused SM4 reflection capture cubemap
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667894 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] SM4 fallback for reflection captures.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667859 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] Removed old rasterized deferred reflection env path.
Removed reflection compute shader. Replaced with PS. Small perf gain.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667852 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed missing include
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667807 on 2017/09/27 by Daniel.Lamb
Tencent DLC can now remap the plugin content to the game root directory.
#!rb Ben.Marsh
#!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test
Change 3667753 on 2017/09/27 by Clayton.Langford
Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer.
#!RB Ben.Salem, Adric.Worley
#!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat
Change 3667408 on 2017/09/27 by Jordan.Walker
Optimization to bakedNormal layer blend on Low end material quality
-uses simple multiply and add normal map blend
Change 3667388 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times.
#!rb none
#!TESTS QAGame on console
#!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667383 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667265 on 2017/09/27 by Daniel.Lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Uriel.Doyon
#!test Editor building hlods
Change 3667159 on 2017/09/27 by Mieszko.Zielinski
Added simple logging to BT loading allowing us to identify missing BB keys #!Orion
#!test golden path
#!rb Lukasz.Furman
Change 3665944 on 2017/09/26 by Dan.Hertzka
Fix PS4 compile
#!rb none
#!tests compile PS4
Change 3665590 on 2017/09/26 by Daniel.Lamb
Fix for DLC cooking everything when it should only cook the DLC.
#!rb None
#!test None
Change 3665569 on 2017/09/26 by Dan.Hertzka
New status effect feed for the new HUD:
- Now placed in the mid-upper-left side of the HUD
- Biggest difference from before is that there are now names associated with each effect
- If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet.
Cleaning:
- Deleted all of the old buff widget classes & codepaths
- Removed redundant properties from StatusEffectDisplayInfo
- Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData
Also:
- Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events
- Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed)
@todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.)
#!rb Don.Eubanks
#!tests OrionEntry PIE with some cards and hero abilities
#!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial.
#!lockdown Billy.Rivers
Change 3665555 on 2017/09/26 by Daniel.Lamb
AudioStreaming mpsc queue fix up.
#!rb Andrew.Grant
#!test Compile paragon client / editor.
Change 3665517 on 2017/09/26 by Daniel.Lamb
Suspect fix for OR-44619
#!jira OR-44619
#!test Paragon editor compile
#!rb Trivial
Change 3664346 on 2017/09/26 by Jon.Lietz
- making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out.
- Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired.
- Updated all GC's data to use the new decal class
- removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent
#!rb Dave.Ratti
#!reivew Dave.Ratti
#!tests used characters that had decal comps in the GC and they recylce as expected.
#!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed.
Change 3664099 on 2017/09/26 by Jon.Lietz
OR-44510
- bringing over engine fixes for the Enum Redirector from Dev-Framework
#!rb none
#!tests compiles and warnings are gone
Change 3663019 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Gil: fixed race condition in the PipelineStateCache
#!rb Daniel.Lamb
#!test paragon ps4 with higher repro modified build
#!lockdown Andrew.Grant
#!jira OR-44441
#!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663014 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready.
#!tests ran locally
#!rb [at daniel.lamb] [at arne.schober]
#!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663004 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed dev check for extra commandline args from /data to /temp0
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662999 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Fixed DateTime used for folders not being set
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662255 on 2017/09/25 by Sam.Zamani
#!tencent
- fix for link error due to missing define of static OnNetworkCheatDetected delegate
#!rb none
#!tests none
Change 3662073 on 2017/09/25 by Sam.Zamani
#!tencent
Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server
Possible options
#!jira TEN-275 TSS detect and expose punish user callbacks
KickClient - User should be booted from the current game session via disconnect
KickMatch - User received info about being punished (eg. ban type etc)
PunishInfo - User received info about being punished (eg. ban type etc)
#!rb rob.cannaday
#!tests none
Change 3659487 on 2017/09/22 by Josh.Markiewicz
#!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin
#!review-3659190 john.barrett, ryan.gerleve
Change 3659485 on 2017/09/22 by Josh.Markiewicz
#!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins
#!fyi john.barrett, ryan.gerleve
Change 3659184 on 2017/09/22 by Josh.Markiewicz
#!UE4 - delete EpicSurvey module
#!fyi justin.sargent, nick.darnell
#!rb none
Change 3658697 on 2017/09/22 by Ryan.Gerleve
Fixes for server-side Tencent anti-cheat library integration:
-Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows
-Add getter for the TssSdkAntiInterf object
-Enable server anti-cheat in editor builds
#!codereview sam.zamani
#!rb none
#!tests enabled Tencent OSS, built & ran server
Change 3658200 on 2017/09/22 by Graeme.Thornton
Manual copy of CL 3587584 from Dev-Core
Logging improvements for pak signature check failures
- Added "PakCorrupt" console command which corrupts the master signature table
- Added some extra log information about which block failed
- Re-hash the master signature table and to make sure that it hasn't changed since startup
- Moved the ensure around so that some extra logging messages can make it out before the ensure is hit
- Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again
#!rb none
#!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General
Change 3657970 on 2017/09/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition.
We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game,
[at marcus.wassmer,] [at arne.schober] #!rb none
#!tests cycled 6-7 levels of Paragon
#!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657914 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing...
#!tests stepped through in non-pkg build
#!rb none
#!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657906 on 2017/09/21 by Andrew.Grant
Improved some logging
#!tests used locally
#!rb none
Change 3657891 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing
Fixed issue with -dev mode on PS4 not updating symbols
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657867 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Re-locked network CL to 3652780
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657857 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444
#!RB:arciel.rekman
#!Tests:Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf
#!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657852 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for case-insensitivity causing title.json not to be staged
#!rb daniel.lamb, bob.tellez
#!tests ran packaging script, verified contents match v42
#!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657831 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors
We can worry about a more permanent solution after we get this live.
#!RB:none
#!Tests: Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer
#!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657824 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb
--------------------------------------
Built new UnrealCEFSubprocess client
Changed OrionBuild.xml to build the shipping version of the above.
The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this.
[at justin.sargent,[at benjamin.crocker,[at wes.fudala]]]
#!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657488 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: anton.migulko
LIGHTING AND assets update
#!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3656388 on 2017/09/21 by Laurent.Delayen
Added default GetAxisVector static function to EAxisOption
#!rb none
#!FYI thomas.sarkanen
#!tests lane minions test map
Change 3656387 on 2017/09/21 by Laurent.Delayen
Initialize FAnimInstanceProxy with default constructor.
#!rb none
#!fyi lina.halper, thomas.sarkanen
#!tests lane minion test map
Change 3656003 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3650578 for patching
benjamin.crocker
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654403 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Merge DevCore -> Orion Release-43 CL 3641450
UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers.
#!rb Daniel.Lamb
#!test Compile
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654356 on 2017/09/20 by Andrew.Grant
Merging 3653658 from Dev-Rendering
#!tests compiled, ran editor
#!rb marcus.wassmer
Change 3653914 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access).
#!rb none
#!tests ran locally
#!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3652495 on 2017/09/19 by Andrew.Grant
Editgration of VR fix in 3643776 from Release-4.17
#!tests #!rb na
Change 3652244 on 2017/09/19 by Sam.Zamani
#!tencent
Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher
Added "-q" to whitelist of command line params for shipping builds
Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher
#!rb rob.cannaday
#!tests none
Change 3651493 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651490 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651489 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651445 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag
#!RB:none
#!Tests:none
[CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant
#!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651059 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed code to archive load-order during tests
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651043 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed error parsing from tests to put cause ahead of file info
#!tests ran self-test
#!rb none
#!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649683 on 2017/09/18 by Andrew.Grant
Bulk-merge of oustanding changes in Main to DG
#!tests #!rb na
Change 3649345 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Integrate fix for eidtor crash when switching between low and high scaleability options.
#!rb Olaf.Piesche
#!test Paragon editor
#!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649335 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - OR-44257 - Fix for hair not working
It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion.
#!RB:daniel.lamb
#!Tests:Re-tested in cooked build
[CODEREVIEW] daniel.lamb
#!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649231 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM
#!RB:none
#!Tests:none
[CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy
#!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649211 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix 'lowest' shadow settings (simple forward rendering)
#!rb arne.schober
[FYI] Daniel.Wright
#!tests monolith
#!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649141 on 2017/09/18 by Stephan.Jiang
Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source.
-- These are hacks for ability videos to work before we have the new Sequencer updates
-- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748
#!fyi Andrew.Grant, Max.Preussner
#!rb none
#!test compile
Change 3649087 on 2017/09/18 by Thomas.Ross
Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General
#!rb none
#!tests none
#!fyi Andrew.Grant,Jeff.Williams,dan.oconnor
Change 3649066 on 2017/09/18 by Max.Preussner
WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources
#!rb stephan.jiang
#!rnx
#!tests none
Change 3649049 on 2017/09/18 by Max.Preussner
Media: Changed audio sample rate warning to verbose log
#!fyi stephan.jiang
#!rb none
#!rnx
#!tests none
Change 3648752 on 2017/09/18 by Max.Preussner
WmfMedia: Fixed race condition in media sound wave
#!rb none
#!rnx
#!tests none
Change 3648748 on 2017/09/18 by Max.Preussner
WmfMedia: Hack for preventing flicker between media source switching
Do not merge to Dev-Main!
#!rb stephan.jiang
#!rnx
#!tests none
Change 3648596 on 2017/09/18 by Bart.Hawthorne
More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough.
Change 3648575 on 2017/09/18 by Sam.Zamani
#!tencent
Fix for missing library calls when initializing TSS anti cheat SDK
#!rb none
#!tests compiles win64 server
Change 3648556 on 2017/09/18 by Jeff.Williams
Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084
Clearing up robomerge
#!rb none
#!tests none
Change 3648533 on 2017/09/18 by clayton.langford
Unblocking RM.
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly.
#!RB Adric.Worley
#!tests none
#!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3648219 on 2017/09/18 by Sam.Zamani
#!tencent
fixed Tencent module thirdparty dll runtime dependency paths
fixed DLLHandle not being set
#!rb none
#!tests none
Change 3647998 on 2017/09/18 by Clayton.Langford
Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763.
#!tests compiled
#!rb Adric.Worley
Change 3647817 on 2017/09/18 by James.Golding
Mirror fix from 4.18 release stream (CL 3647799) to Dev-General
Fix out-of-bounds access of cloth mapping data during CPU skinning
#!rb benn.gallagher
#!jira UE-49628
#!fyi benn.gallagher
#!tests convert RiftMage to static mesh
Change 3647749 on 2017/09/18 by Benn.Gallagher
Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope.
This caused matrix transposition to fail after the data was copied in using memcpy
BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs.
#!rb none
#!tests Editor reimport of clothing assets
Change 3646242 on 2017/09/15 by Tyler.Cole
Revert shared engine LocalMCP scripts.
Change 3646153 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds
#!RB:daniel.lamb
#!Tests: Ran cooked Client
[CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy
#!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3646125 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews.
#!RB Marcus.Wassmer
#!tests automated performance tests
#!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3645861 on 2017/09/15 by clayton.langford
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW.
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added.
To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards
Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated.
#!tests ran local client/server, preflighted
#!rb Ben.Salem
#!rnx
[FYI] Sean.Tobin, Hunter.Kent, Edward.King
#!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3644062 on 2017/09/14 by Aaron.McLeran
#!jira OR-44171 Some looping sounds are extremely loud
#!rb Ethan.Geller
#!tests run paragon, run near water river, don't observe looping sound being very loud
Change 3643901 on 2017/09/14 by Laurent.Delayen
Integrated CL #!3604725 to fix bug with opening state machines from anim graph.
#!rb none
#!tests fixes bug
#!FYI lina.halper
Change 3643641 on 2017/09/14 by Rob.Cannaday
Fix unreachable code detected
#!rb rob.cannaday
#!tests Win64 compile
Change 3643326 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TerSafe.dll loading until staging issues can be resolved
#!rb none
#!tests none
Change 3643039 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TSS on servers due to linux build issues
#!rb none
#!tests none
Change 3642438 on 2017/09/13 by Rob.Cannaday
Handle new analytics param types (number, string, etc)
Stub implementation of FAnalyticsProviderETTencent DefaultAttrs
#!rb rob.cannaday
#!tests Win64 vs AI match
Change 3641655 on 2017/09/13 by Sam.Zamani
#!tencent
WIP added tss_sdk.dll (server) and TerSafe.dll (client)
JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client
JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers
#!rb none
#!tests PC run with RegionCN.pak enabling tencent mode
Change 3641559 on 2017/09/13 by Bart.Hawthorne
Fix up oodle dictionary generation scripts
#!rb none
#!jira none
Change 3641550 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3641393 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev.
Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled
- Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false)
- Added PGOInput option to TargetRules and passed through to compile environment
- Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for
- Updated PS4 toolchain to use both LTO and PGO depending on what was set
#!tests soaked locally, preflighted
#!rb codereviewed
FWIW here are before/after results for LTCG.
Orion Performance report from 3 games and 1441.51 seconds
MVP: 2.83 (Min: 2.05, Max: 3.22)
HPM: 4.29 (Min: 4.24, Max: 4.37)
AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms)
GT: 12.88ms (Min: 12.68ms, Max: 13.25ms)
RT: 13.71ms (Min: 13.48ms, Max: 14.08ms)
GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms)
Orion Performance report from 3 games and 1440.49 seconds
MVP: 1.42 (Min: 1.02, Max: 1.94)
HPM: 3.25 (Min: 2.75, Max: 3.62)
AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms)
GT: 11.93ms (Min: 11.64ms, Max: 12.47ms)
RT: 12.80ms (Min: 12.54ms, Max: 13.24ms)
GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms)
#!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640885 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Limited warning to once every 10 secs.
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640875 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed shipping config issue
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640870 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Fixing CIS builds #!Orion
The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors.
[CODEREVIEW] John.Nielson
#!rb none
#!test compilation
#!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640783 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
More temporary logging for finding the missing FX issue.
#!rb: none
#!Test: Pie
#!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639910 on 2017/09/12 by Rob.Cannaday
Build fix for AnalyticsETTencent
#!rb rob.cannaday
#!tests compile Win64 DebugGame Editor
Change 3639565 on 2017/09/12 by Laurent.Delayen
SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0.
#!rb lina.halper
#!FYI lina.halper
#!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime.
Change 3639228 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Tools - Added ability to postmortem a PS4 devkit for last crash
#!rb run locally
#!tests none
#!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639075 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Specifically requesting 'all' configuration, to avoid missing manifest in jar.
#!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639022 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
Remove dependency on the editor style set in the WidgetReflector
- Fixes a crash when trying to use the reflector in a client cooked build
- Also updated Focusable column name to shared var
#!rb none
#!tests Widget Reflected in a cooked build
#!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638984 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638696 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Swapped problematic ensure to LogError, made draft obey notimeouts.
#!tests compiled
#!rb none
[at daniel.lamb]
#!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638644 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Third time's the charm
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638628 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure in a PS4 friendly way
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638583 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure to get a cook
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638545 on 2017/09/12 by Bart.Hawthorne
Add analytics for oodle compression percentages
#!rb ryan.gerleve, wes.hunt
#!tests ran a 2 person game with dedicated server and verified analytics were reported
#!jira OR-26386
Change 3638172 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Duplicate 3620803
Partial Fix for Dither Opacity Mask
#!rb none
#!tests PC monolith
#!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637643 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Fixing version stream to Main
#!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637524 on 2017/09/11 by Andrew.Grant
Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests build Win64 editor, ran tests locally
#!rb none
Change 3637402 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Restored logging of runoptions when not verbose
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637357 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Made 'none' test specify Attended
#!rb Daniel.Lamb
#!tests compiled
#!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637305 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added temporary debug logging cmd line option for finding Jira OrionOR-43600
#!RB: none
#!Test: Pie
[at David.Ratti]
#!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636549 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues
#!RB:none
#!Tests:none
[CODEREVIEW] uriel.doyon
#!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636507 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
[OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG.
Also:
- Added distance formatting type for simple ability description values (will automatically append u to the value)
- SimpleAbility description values can now go up to two decimal places
Engine:
- Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName
#!rb Matt.Schembari
#!tests PIE OrionEntry & FrontEndScene - various bug repros
#!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636372 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Implement fast particle pool memory.
Default is 2mb, automatically cleans up oldest used pool slots.
Estimated 1/4 time for STAT_PARTALLOC.
#!rb Jason.Bestimt
#!test paragon ps4 cooked
#!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636319 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue with fatal error message not being shown in reports.
Fixed issue where some cancelled tests reported as succeeded
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636264 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance
#!RB:none
#!Tests: Ran client cooked build
[CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon
[QAREVIEW]
#!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635288 on 2017/09/10 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices
Fixed missing - in SoloSmoke args that were causing trailing params to be lost
#!tests preflighted, ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635145 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to pick up SDK change for patch packages
#!rb none
#!tests none
#!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635097 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added cleardevices option to Gauntlet that removes all devices after running.
Added to Orion build scripts
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634985 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Cleaned up some logging around device failures
Attempt to handle "Too Many Connections" error at a lower level
Added removeall command to PS4DevkitUtil (not yet used)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634897 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Checking in change to timeouts to test theory
#!tests ran test locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634765 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Scrape another .05ms out of GPU particle simulation.
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634422 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for Gauntlet shutdown issue on builders
Fix for BP editing crash from Dev-Framework
#!tests ran locally
#!rb none!
#!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634139 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running
#!tests ran locally with single and file-based devices
#!rb none
#!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633799 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only.
#!rb none
#!tests monolith02 turrets
[CODEREVIEW] lina.halper
#!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633647 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Possible fix for OR-43926 from Arne
#!tests ran locally, observed no ensures or negative side-effects in UI or HUD
#!rb none
#!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633637 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Upped timeout for editorbased tests
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632565 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed some test code...
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632385 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device handling.
Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems.
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632177 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43
#!rb none
#!test local commandlet
#!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632131 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix a bug with new local vector-field only project setting
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632034 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where problem devices were reset each attempt
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631812 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device management in Gauntlet
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631787 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes.
#!rb none
[CODEREVIEW] martin.wilson
#!test bot game
#!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631251 on 2017/09/07 by Andrew.Grant
Additional device selection improvements
#!tests #!rb na
Change 3630861 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3630620 on 2017/09/07 by Laurent.Delayen
RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions.
#!rb Ori.Cohen
#!codereview benn.gallagher
#!tests lane minions test map
Change 3629990 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fix for gpu hang on ps4.
#!rb Marcus.Wassmer
#!test Paragon cooked ps4
#!jira OR-43835
#!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629980 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Moved some missed code to FDebug::HasAsserted()
#!tests na
#!rb none
#!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629975 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Project optimization to only support local vector fields.
separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost.
#!rb olaf.piesche
#!tests monolith ps4/pc
#!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629917 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix for sizebyspeed on ps4
#!rb Simon.Tovey
#!tests pc
#!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629620 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629554 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored screenshot support to gauntlet (now driven externally)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629495 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: don.eubanks
Stat panel will only show stat changes or improvements that come from Item sources (cards / gems)
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
[RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base!
#!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629468 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring()
Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread.
#!tests ran locally
#!rb none
[at marcus.wassmer]
#!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629410 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs
--------------------------------------
Fix for generating project files
#!tests GPF
#!rb none
#!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629369 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests)
#!rb none
#!tests verified signing is disabled and game gets to main menu with -fileopenlog
[at graeme.thornton]
#!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629254 on 2017/09/06 by Laurent.Delayen
URO: ensure we don't skip more frames than desired when switching LODs.
#!rb lina.halper
#!codereview martin.wilson, benn.gallagher
#!test lane minions test map
Change 3629191 on 2017/09/06 by Laurent.Delayen
Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions.
#!rb lina.halper
#!codereview martin.wilson
#!test lane minions test map
Change 3629130 on 2017/09/06 by Laurent.Delayen
AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug.
#!rb none
#!tests lane minion test map
Change 3628300 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed exception that could occur during tests if all devices were in use
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627915 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Undoing Oodle check for the time being
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627875 on 2017/09/06 by Jason.Bestimt
#!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables)
#!RB:none
#!Tests:none
#!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker
#!ROBOMERGE: MAIN, 43
Change 3627694 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Improved warnings
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627642 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
More logging for OR-43892 and OR-43779
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627247 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed check that turns out to be bogus
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627240 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures
#!tests compiled OrionClient
[at daniel.lamb] #!rb none
#!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627211 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added ensure for OR-43777
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626839 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added wait to PS4DevkitUtil before trying to postmortem crashdump
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626755 on 2017/09/05 by Rob.Cannaday
Merge //Orion/Release-Tencent to //Orion/Dev-General
Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT
TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded
#!rb sam.zamani
#!lockdown andrew.grant
#!tests Win64 vs AI match, QA smoke test
#!fyi sam.zamani
Change 3626285 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed BaseDir argument not being correctly applied in tests
Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626221 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame.
Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement
#!rb none
#!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz
[at Laurent.Delayen] [FYI] [at Andrew.Grant]
#!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3625925 on 2017/09/05 by Laurent.Delayen
If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want.
#!rb benn.gallagher
#!codereview martin.wilson, lina.halper
#!tests lane minion map
Change 3624051 on 2017/09/02 by Andrew.Grant
Fixed issue with test params not being set.
Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability.
#!tests preflighted
#!rb none
#!review-3624052 @ben.salem
Change 3623907 on 2017/09/02 by Andrew.Grant
Fixed usesyncedbuild option being broken in Gauntlet
#!codereview @daniel.lamb
#!tests compiled
#!rb none
Change 3623906 on 2017/09/02 by David.Ratti
Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides
#!rb none
#!test future wukong pie
Change 3623766 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box
#!rb none
#!Tests PC QAGame
Change 3623518 on 2017/09/01 by Don.Eubanks
Fix for Shipping Client PS4
#!rb none
#!tests Compile Shipping Client PS4
#!fyi daniel.lamb andrew.grant
Change 3623515 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials applied to static meshes operate on the object's bounding sphere
#!rb none
#!TESTS QAGame PC
Change 3623503 on 2017/09/01 by Daniel.Wright
[Copy] Fixed ObjectRadius in Volume domain materials
#!rb none
#!TESTS none
Change 3623102 on 2017/09/01 by Marcus.Wassmer
Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand
#!rb none
#!tests monolith on PS4
#!fyi olaf.piesche,tim.elek
Change 3623096 on 2017/09/01 by Marcus.Wassmer
checkslow -> check to find issues with ILC
#!rb none
#!tests ran monolith on ps4
Change 3622744 on 2017/09/01 by Laurent.Delayen
RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now).
Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies.
Take gravity from movement component if present, to inherit custom gravity scaling.
Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used.
If LOD enables new bodies, they are now initialized during simulation.
Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default.
Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change.
Added AnimStats for PreUpdate, Update and Eval.
#!rb ori.cohen
#!codereview ori.cohen, lina.halper, benn.ghallager
#!tests lane minion test map
Change 3622743 on 2017/09/01 by Laurent.Delayen
Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes.
#!rb lina.halper
#!tests lane minion test map
Change 3622742 on 2017/09/01 by Laurent.Delayen
'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings.
Renamed DisplayDebugCustom to DisplayDebugInstance.
#!rb lina.halper
#!tests lane minion test map
Change 3622738 on 2017/09/01 by Laurent.Delayen
Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams
#!rb lina.halper
#!tests lane minion test map
Change 3622666 on 2017/09/01 by Jian.Ru
Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements
#!jira UE-48972, OR-43455
#!rb Chris.Bunner
#!tests editor
Change 3622579 on 2017/09/01 by Andrew.Grant
Fixed shutdown issues with some tests being detected as errors
Simplied and cleanup some things in state management of tests.
#!tests ShortSOloGame test locally
#!rb none
Change 3622322 on 2017/09/01 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-40366 from v43
#!tests compiled
#!rb Aaron.McLeran
#!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3621054 on 2017/08/31 by Andrew.Grant
Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests preflighted
#!rb none
Change 3620755 on 2017/08/31 by Daniel.Lamb
Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations.
#!rb Jason.Bestimt
#!test Cooked paragon ps4
Change 3620541 on 2017/08/31 by Ben.Salem
Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting.
#!rb none
#!tests compiled.
Change 3620443 on 2017/08/31 by Mieszko.Zielinski
Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4
#!rb none
#!test golden path
Change 3620428 on 2017/08/31 by Aaron.McLeran
#!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General
#!rb Ethan.Geller
#!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports.
Change 3620411 on 2017/08/31 by Mieszko.Zielinski
Fix to removal of simuli sources from the AISense_Sight #!UE4
Made sure given source gets removed from ObservedTargets.
#!rb none
#!test golden path
Change 3620343 on 2017/08/31 by Ben.Salem
Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on.
#!rb clayton.langford
#!tests ran shallow and normal FX tests, generated hitches to display.
Change 3620050 on 2017/08/31 by Luke.Thatcher
[ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/...
- USE_DEFRAG_ALLOCATOR was not always defined in all cases.
#!rb Daniel.Lamb
#!tests none
Change 3619836 on 2017/08/31 by Andrew.Grant
Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team)
#!tests preflighted, ran locally
#!rb none
Change 3618597 on 2017/08/30 by Dan.Hertzka
Fixed Additive UI materials not being affected by the widget opacity
- We needed to multiply the sampled color by the alpha of the vertex color
Also added fade in anim for scoreboard when showing after the endgame cinematic
#!rb Nick.Darnell
#!tests Widget alpha affects additive materials
Change 3618441 on 2017/08/30 by Laurent.Delayen
Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display.
#!rb lina.halper
#!tests lane minions
Change 3618404 on 2017/08/30 by Paul.Moore
- Update to new MMS client API from Fortnite.
- Add MMS API plugin.
#!rb none
#!tests matchmaking, v2 MMS matchmaking, draft lobby.
#!lockdown andrew.grant
Change 3618167 on 2017/08/30 by Marcus.Wassmer
Fix fog on PS4, also volume texture clears.
#!rb luke.thatcher
#!fyi Jordan.Walker
#!tests ran monolith on ps4
Change 3617911 on 2017/08/30 by Andrew.Grant
Fix for OR-43401, lighting remaining unbuilt
#!tests ran cook, verified that lighting for bp components is now correctly found.
#!rb marc.audy
Change 3617765 on 2017/08/30 by Andrew.Grant
Fix for lighting always being unbuilt on some blueprints
#!tests cooked data and verified BP components have the correct transform and receive cached lighting data
#!rb marc.audy, bp-team
Change 3617757 on 2017/08/30 by Laurent.Delayen
clang fix
#!rb none
#!tests none
Change 3617700 on 2017/08/30 by Laurent.Delayen
Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated.
#!rb lina.halper
#!tests lane minions map
Change 3617695 on 2017/08/30 by Laurent.Delayen
Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays.
#!rb lina.halper
#!tests test lane minions map
Change 3616757 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-43459 from Laurent
#!tests na
#!rb Lina.Halper, Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616745 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3609966 in anticipation of patch
#!rb #!tests na
#!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616551 on 2017/08/29 by Daniel.Lamb
Fix memory leak in paragon.
#!rb Andrew.Grant
#!test Paragon ps4
Change 3613700 on 2017/08/28 by Andrew.Grant
Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion
Renabled r.Cache.UpdatePrimsTaskEnabled
#!tests ran locally
#!rb none
Change 3613694 on 2017/08/28 by Andrew.Grant
Added -teamsize argument to Orion none test.
#!tests ran None test :)
#!rb none
Change 3613638 on 2017/08/28 by Ben.Salem
Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created.
#!rb clayton.langford
#!tests Ran shallow and deep test for multiple characters.
Change 3612731 on 2017/08/28 by Chris.Bunner
[DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook.
#!rb
#!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb
#!tests Cooking/running simple scene with grass foliage
#!jira UE-48698, OR-42612
Change 3612695 on 2017/08/28 by Andrew.Grant
Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading
Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things.
#!tests ran NoneTest with -nomcp
#!rb none
Change 3612002 on 2017/08/27 by Andrew.Grant
Fix for crash seen during nightly tests
#!tests baseline perf didn't crast 3/3
#!rb none
Change 3611980 on 2017/08/27 by Andrew.Grant
PS4DevkitUtil post-mortem improvements to logging
#!tests run ShortSoloGame
#!rb none
Change 3611758 on 2017/08/26 by Andrew.Grant
Fix for warning
#!tests #!rb na
Change 3611737 on 2017/08/26 by Andrew.Grant
Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering
3517039 -
GitHub #!2655: Optimization for shadow map resolution selection for spot lights
* Use the radius of the inscribed sphere at the cone end as the spot light's screen radius
Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly
3545241 -
Fixed spotlight whole scene shadows using a radius 2x too long
3545347 -
Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame.
#!rb none
#!tests compiled
Change 3611718 on 2017/08/26 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs
--------------------------------------
Improved parsing of callstacks and errors in test logs
Added unit test for error parsing
#!tests ran locally, unit tests
#!rb none
#!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611704 on 2017/08/26 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Test fixes - addresses issue with memory report failing
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611683 on 2017/08/26 by Andrew.Grant
Upgraded PS4 SDK to 4.508.111
#!tests SoloGames locally
#!rb none
Change 3611466 on 2017/08/25 by Andrew.Grant
Changed none test to use monolith02 by default
#!tests compiled
#!rb none
Change 3611167 on 2017/08/25 by Laurent.Delayen
Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated.
#!rb none
#!tests lane minions
#!codereview martin.wilson
Change 3610850 on 2017/08/25 by dan.hertzka
Unclog Robomerge
#!rb none
#!tests none
Change 3610325 on 2017/08/25 by Andrew.Grant
Compile fix for PS4
#!tests compiled
#!rb none
Change 3610018 on 2017/08/25 by Laurent.Delayen
UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later.
#!rb lina.halper
#!tests venus ult on minion lane test map
Change 3609967 on 2017/08/25 by Daniel.Lamb
Merging using //Fortnite/Main/->//Orion/Dev-General/
Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4.
CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping.
- The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out.
- Added an extra flag to reset mip bias values when texture memory budget is increased.
#!rb Uriel.Doyon
#!jira FORT-45385
#!jira FORT-47739
CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4.
- Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled.
- Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted.
- Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps.
#!jira FORT-45229
#!rb Ben.Woodhouse
CL 3564368
LLM Changes
Summary:
LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead.
Changes where LLM hooks into the various allocation functions and pools.
Added more LLM tracking scopes.
Changed the way LLM gets its internal memory.
Writing stats out to csv
Fixed a few bugs with the tracker code
Details:
* re-enabled LLM by default in Dev builds for XB1 and PS4
* Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update)
* track allocations made from the defrag pool (PS4)
* track non-drfrag pool garlic allocations (PS4)
* track allocations made from PS4 malloc
* combined the RHI and Malloc trackers into the Default tracker
* changed stat groups to LLM, LLMPlatform and LLMOverhead
* OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set
* XMemAlloc now uses AllocationType if no LLM scope has been set
* renamed VirtualMap to LLMMap
* added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled.
* support for tracking allocations that move in memory (for the PS4 defrag allocator)
* support for tracking explicit memory without pausing the tracker
* LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg
* fixed check in FNameToTag. It was checking the wrong value when verifying the name index
* show a warning on screen if LLM has been enabled without debug memory enabled (on consoles)
* fixed program size tracking
* fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope.
* optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times)
* fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them.
* fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled
* changed default alloc size for LLMMap to 16K
* Added lots more LLM scopes renamed some of the existing ones
* made FMemBlock::Allocators private and added accessor functions, which include LLM tracking.
* fixed LLM alignment tracking in CustomVirtualAlloc
* implemented LLM on XB1 so that it properly tracks D3D12Allocations
* added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator
* tracking of render targets
* fixed LLM pool total column value.
#!rb luke.thatcher
CL 3565905
[ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/...
3458941 - Initial submission of new PS4 memory allocator.
3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible.
3498440 - Flexible and framebuffer memory fallbacks
3515704 - Add stats to new PS4 memory system.
UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly.
#!rb Ben.Woodhouse
CL 3580934
[FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo.
- Neo has 512 MB more direct memory than a base kit.
- Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB.
#!rb Marcus.Wassmer
#!jira FORT-50206
CL 3590180
[FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted.
- Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB.
- Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool.
- Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails.
#!jira FORT-49700
#!rb Aaron.McLeran
CL 3593920
[FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system.
- Incorrect bitmask usage was truncating the available memory value to 32 bits.
- Also includes some minor refactoring to make parts more readable.
- Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile.
#!rb Jonathan.Fitzpatrick
#!jira FORT-50918
CL 3597577
[FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU.
- Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack.
- With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is.
#!rb Stewart.Lynch
#!jira FORT-50825
#!jira FORT-49688
#!jira FORT-49695
#!jira FORT-50054
CL 3601951
[FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system
- Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0.
- Added garlic, onion and defrag stats to the platform memory stats struct.
- Added fixed pool sizes to platform memory stats.
- Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools.
#!rb Stewart.Lynch
#!jira FORT-52910
#!test preflight with baseline performance memory report tests, local tests on neo
#!rb Luke.Thatcher
Change 3608480 on 2017/08/24 by Uriel.Doyon
Instanced static mesh lightmaps are now updated correctly after lighting scenario changes
#!jira UE-48522
#!tests Build lighting, loaded maps
#!rb michel.dupuis
Change 3608407 on 2017/08/24 by Andrew.Grant
Reintegrated ROlando's cloth optimizations
#!tests #!rb none
Change 3608349 on 2017/08/24 by Rolando.Caloca
O - Cloth vertex buffers no longer generate dummy vertices
#!rb Lina.Halper
#!fyi James.Golding
#!tests Check obj list memory with multiple characters, tested animations
Change 3607815 on 2017/08/24 by Laurent.Delayen
Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha.
https://jira.it.epicgames.net/browse/OR-43186
#!rb none
#!tests Price hand two bone IK
#!codereview lina.halper, thomas.sarkanen
Change 3607770 on 2017/08/24 by Andrew.Grant
Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong
#!tests ran locally, updated parser test
#!rb none
Change 3607546 on 2017/08/24 by Jian.Ru
Add more control to chromatic aberration effect
#!jira UE-47138
#!rb Brian.Karis
#!tests editor
Change 3607270 on 2017/08/24 by Andrew.Grant
Mirroring 3605735 from FN to address bug with MIC deduplication
#!tests compiled
#!rb none
Change 3607082 on 2017/08/24 by Laurent.Delayen
Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands.
List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph).
Current debug Target is highlighted in a green bounding box.
Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player.
Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors.
Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation.
#!rb dave.ratti
#!tests lane minion test map, debugging individual minions
#!codereview jon.lietz
Change 3606772 on 2017/08/24 by David.Ratti
Spot edigrate CL 3606417 for accurate CurveTable memory tracking
#!rb none
#!tests none
[CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
Provider = InProvider ;
2018-10-29 10:01:28 -04:00
Aggregator = InAggregator ;
if ( State ! = Handler : : State : : Uninitialized )
{
for ( const TSharedPtr < HandlerComponent > & CurComponent : HandlerComponents )
{
if ( CurComponent - > IsInitialized ( ) )
{
CurComponent - > NotifyAnalyticsProvider ( ) ;
}
}
}
2015-07-08 23:03:46 -04:00
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
void PacketHandler : : InitializeComponents ( )
{
if ( State = = Handler : : State : : Uninitialized )
{
if ( HandlerComponents . Num ( ) > 0 )
{
SetState ( Handler : : State : : InitializingComponents ) ;
}
else
{
HandlerInitialized ( ) ;
}
}
// Trigger delayed-initialization for HandlerComponents
2018-10-29 10:01:28 -04:00
for ( TSharedPtr < HandlerComponent > & Component : HandlerComponents )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
2018-10-29 10:01:28 -04:00
if ( Component . IsValid ( ) & & ! Component - > IsInitialized ( ) )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
2018-10-29 10:01:28 -04:00
Component - > Initialize ( ) ;
Component - > NotifyAnalyticsProvider ( ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
// Called early, to ensure that all handlers report a valid reserved packet bits value (triggers an assert if not)
GetTotalReservedPacketBits ( ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
void PacketHandler : : BeginHandshaking ( FPacketHandlerHandshakeComplete InHandshakeDel /*=FPacketHandlerHandshakeComplete()*/ )
{
check ( ! bBeganHandshaking ) ;
bBeganHandshaking = true ;
HandshakeCompleteDel = InHandshakeDel ;
for ( int32 i = HandlerComponents . Num ( ) - 1 ; i > = 0 ; - - i )
{
HandlerComponent & CurComponent = * HandlerComponents [ i ] ;
2018-10-29 10:01:28 -04:00
if ( CurComponent . RequiresHandshake ( ) & & ! CurComponent . IsInitialized ( ) )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
{
CurComponent . NotifyHandshakeBegin ( ) ;
break ;
}
}
}
2018-10-29 10:01:28 -04:00
void PacketHandler : : AddHandler ( TSharedPtr < HandlerComponent > & NewHandler , bool bDeferInitialize /*=false*/ )
2015-07-08 23:03:46 -04:00
{
2016-01-28 16:03:26 -05:00
// This is never valid. Can end up silently changing maximum allow packet size, which could cause failure to send packets.
2015-07-08 23:03:46 -04:00
if ( State ! = Handler : : State : : Uninitialized )
{
LowLevelFatalError ( TEXT ( " Handler added during runtime. " ) ) ;
2015-09-30 16:14:25 -04:00
return ;
}
// This should always be fatal, as an unexpectedly missing handler, may break net compatibility with the remote server/client
if ( ! NewHandler . IsValid ( ) )
{
LowLevelFatalError ( TEXT ( " Failed to add handler - invalid instance. " ) ) ;
return ;
2015-07-08 23:03:46 -04:00
}
Copying //UE4/Fortnite-Staging to //UE4/Dev-Main (Source: //Fortnite/Main/Engine @ 3780923)
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3780878 by Nick.Darnell
UMG - Providing more information when the compile fails to find a bindable widget.
Change 3780855 by Gil.Gribb
UE4 - Fixed a linear search in EDL that caused performance problems for very large maps. Saves half the load time in FN-BR.
Change 3780803 by Thomas.Sarkanen
Dont create animation tasks for skeletal meshes that have no anim instance
This avoids some wasted work for non-animated attachments, such as pickaxes
#jira FORT-61523 - Don't create anim worker tasks if no AnimBP
Change 3780741 by Yenal.Kal
#jira FORT-60177
Fixed the bug where the anim branching points (begin and end) may be triggered twice incorrectly.
Change 3780663 by Gil.Gribb
UE4 - Batching for audio thread commands.
Change 3780466 by Ben.Marsh
Add error matcher for generic Microsoft errors (eg. 'cl : Command line error D8049 : command line too long to fit in debug record')
Change 3779937 by Nick.Darnell
UMG - Adding an accessor on UUserWidget to get the owning player state easier, since it's a common operation.
Change 3779858 by Sam.Zamani
#http
use separate "-multihomehttp" instead of "-multihome" for routing http socket
#jira FORT-61666
#tests none
Change 3779288 by Michael.Trepka
Changed FMacConsoleOutputDevice::Serialize to use FString's GetNSString() instead of converting the string using FPlatformString::TCHARToCFString to make it safer in case of garbage text passed in Data
#jira FORT-59762
Change 3779062 by Mike.Fricker
Merged CL 3731188 and CL 3733311 from //UE4/Dev-Editor.
----
Improve responsiveness of Open Asset dialog.
On large projects, there's a noticeable delay when opening and searching/filtering assets.
Stopwatch measurements on my machine (seconds for ~122,000 assets):
before with this CL
ctrl-P 1.4 0.45
search 1.8 0.55
CollectionManagerModule was the main culprit for search/filter slowness.
Open Asset delay was due to filtering out plugin content. We were doing a lot of redundant work for what is essentially a read-only operation.
Change 3778954 by Nick.Darnell
Slate - Making the Horizontal and Vertical analog keys configurable in the navigation config. Tweaking how fast the navigation is with the analog stick, trying to tune the feeling.
Change 3778896 by Ben.Marsh
Separate FNameEntrySerialized from FNameEntry, rather than deriving from it. It has to be allocated differently, and many fields cannot be shared between the two.
#jira
Change 3778807 by Ben.Marsh
Fix Tencent include paths not registering if workspace directory contains a space.
Tencent include paths currently have a trailing backslash, and this is surrounded by quotes if the root directory contains a space. The backslash is interpreted as escaping the trailing double quote.
#jira
Change 3778686 by Luke.Thatcher
Reduced impact of dynamic vertex buffer RHI stall in D3D12
- In most cases we can avoid the stall if the vertex buffer has never been used before.
- Only when a buffer has an existing SRV do we need to stall.
- Also, delete copy and move constructors of FD3D12ResourceLocation. Moving or copying an instance of this class leads to double free crashes, so this is now a compile error rather than a runtime crash.
This saves an average of 2ms frame time in a StW lastperftest replay, with r.screenpercentage 10.
#jira FORT-61390
Change 3778679 by Thomas.Sarkanen
Fix Linux server crash - dont attempt to run threaded work in a single-threaded environment
We dont attempt to run animation update work multi-threaded in the same conditions that we didnt attempt to run animation eval work previously.
#jira FORT-61548
Change 3778591 by Ben.Woodhouse
Add build config to FPSChart HTML output
#jira FORT-56478
Change 3778175 by ben.marsh
Remove code to trigger an ensure on Arxan guards. We already send analytics for this, and don't need this legacy path. There is a large number of incoming ensures with this callstack that are clogging up crash reporter.
Will remove all the surrounding code in a later update to a development branch.
#jira
Change 3777750 by Chris.Gagnon
- Slate now supports a CustomBoundary Navigation type wich allows a custom handler if the boundary is hit.
- This provides the ability to have normal navigation while within the boundary and the custom function only on the boundary.
- This differs from Custom which is a full override of the navigation behavior.
Change 3777678 by Bob.Tellez
#UE4 Fix a bug that was causing fastpath nodes in non-nativized BPs to not be fastpath
Change 3776962 by Bob.Tellez
#UE4 Fix warning about missing virtual destructor by making a struct final (like other RHICommands)
Change 3776656 by Thomas.Sarkanen
Fix notifies not getting fired in cases where AlwaysTickPose was set on skeletal mesh components
This was causing AIs to get stuck in montage playback in some circumstances
#jira FORT-61324, FORT-60558
Change 3776655 by Bob.Tellez
#UE4 CIS fix after 3776629
Change 3776650 by Bob.Tellez
Counting uplugin and uproject files as code changes so UGS will trigger code builds on checkins containing these files
Change 3776649 by Nick.Darnell
UMG - Fixing a rare crash when destructing a widget in the designer. It's trying to remove widgets from a half garbage collected panel.
Change 3776629 by Bob.Tellez
#UE4 Using a more efficient data structure for keeping track of visited nodes when verifying EDL.
Change 3776328 by James.Golding
Add command line option (-statnamedevents) for enabling named events
Change 3776024 by Nick.Darnell
Slate - Adding an accessor to SSafeZone to get the amount of padding that will be added, given some scale.
Change 3775569 by Gil.Gribb
UE4 - Fixed bugs with r.DelaySceneRenderCompletion
Change 3775543 by Luke.Thatcher
[XBOXONE] [~] Remove stall in D3D12 CreateRHIBuffer
- Buffer update is enqueued as a task on the RHI thread instead of stalling the RHI thread for the duration of the update.
Change 3775488 by Thomas.Sarkanen
Prevented skeletal meshes that are not being ticked due to URO from dispatching tick tasks
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3775219 by Bob.Tellez
#UE4 Dont SerializeThumbnails when calling savepackage while editoronly data is excluded (cooking). This saves a lot of memory while cooking
Change 3774886 by Mike.Fricker
Fixed occasional crash when backing out to lobby
- Don't force DF data to be updated when the mesh isn't in the world or has no scene interface
#jira FORT-60863
Change 3774767 by Ori.Cohen
Fix race condition for creating statid in test configs
Change 3774682 by Bob.Tellez
#UE4 Don't bother clearing cached platform data during shutdown purge since there may be a lot of it and it takes a while to destroy it.
Change 3774621 by Bob.Tellez
#UE4 Move Tree rebuilding during cook from Serialize to PreSave to avoid building the tree multiple times for a single platform. Also properly clear out CacheMeshExtendedBounds.
Change 3774201 by Gil.Gribb
UE4 - Fixed rare crash caused by unmounting pak files.
Change 3773920 by Gil.Gribb
UE4 - Added experimental option r.StartPrepassParallelTranslatesImmediately which allows the parallel translate tasks from the prepass to start before we init shadows. Disabled by default.
Change 3773896 by Thomas.Sarkanen
Push non-rendered anim updates back onto the worker thread
Now when meshes are set to EMeshComponentUpdateFlag::AlwaysTickPose, we optionally kick of a task to perform parallel update only (no evaluation).
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3773886 by Gil.Gribb
UE4 - Reduced r.RHICmdMinCmdlistForParallelSubmit from 2 to 1.
Change 3773882 by Gil.Gribb
UE4 - Improved profiler markers when they are used without stats to cover the task graph and some things related to the parallel renderer.
Change 3773461 by Gil.Gribb
UE4 - Increased the granularity of the ParallelFor blocks for greater load balancing.
Change 3773459 by Gil.Gribb
UE4 - Adds TLS caches for MallocBinned2 to the Audio thread.
Change 3773458 by Gil.Gribb
UE4 - Added an experimental option to do the slate render before waiting for the rendering tasks.
Change 3773011 by Robert.Manuszewski
Header (uasset) and export (uexp) files will now be compared seperately when running cook commandlet with -diffonly to avoid situations where a mismatch in size of the header produces more differences between exports.
+ Renamed ini setting to ignore header differences from SkipHeaderDiff to IgnoreHeaderDiff
Change 3772867 by Thomas.Sarkanen
Nativization now correctly generates and builds code for "Client" builds
Overall this is a bunch of hacks, but necessary for nativization to work at present. Once the cooker and UAT both have a concept of "Client" targets, this can be implemented properly.
Instead of building to a "Client" directory, we build to "Game" for client-only platforms (like PS4, XboxOne)
Also we need to add "Client" targets to the whitelist for the nativized assets plugin, as UBT still thinks it is building for "Client"
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3772408 by Robert.Manuszewski
Cook commandlet will now report full property name when running a diff against the existing cook (-diffonly)
Change 3772359 by Thomas.Sarkanen
Improvements to the Cpp backend to allow VC++ to compile nativized code more effectively
Added a new scoped helper to wrap areas of the code in PRAGMA_DISABLE_OPTIMIZATION. This helps with functions that are large tables or long lists of initializations.
Split anim node initialization up into functions, called from a seperate function dedicated to initializing anim nodes. This splits the 5k+ line constructor into mutiple smaller functions, which the compiler has no problems with.
Overall (along with splitting up the anim BP into functions in the asset) this reduces compilation time for the worst-case compilation unit from ~11m 40s to ~2m 32s.
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3771975 by Zak.Middleton
Fix character proxies doing up to two floor check when only rotation changes. Add some optional verbose logging to FindFloor() and ComputeFloorDist().
#jira FORT-61134
Change 3771421 by Ori.Cohen
Fix CIS
Change 3771052 by Robert.Manuszewski
Package diff improvements (-diffonly mode for cooker). Exposed max diffs to report to ini and added the ability to suppress header differences reporting as they are usually a result of differences in exports anyway.
Change 3771039 by Bob.Tellez
#UE4 Allowing use of -FPS in PGO profile builds
Change 3770747 by Ori.Cohen
Added missing stat named events for anim bp
Change 3769616 by Arciel.Rekman
UBT: Use response files for compiler when compiling for Linux.
- Some command lines are too long when cross-compiling on Windows, which is a problem for non-unity builds (or local changes that result in exclusion of checked out files from the lumped units).
Change 3769457 by Gil.Gribb
UE4 - Added eviction to r.DoLazyStaticMeshUpdate. It just removes 10 prims a frame in a rolling fashion.
Change 3769136 by Michael.Noland
Engine: Improve IsServerDelegateForOSS to allow it to use the play world during PIE even if no context was passed in
Change 3768736 by Robert.Manuszewski
More debug info for ensure in FLinkerSave when a name that has not yet been mapped is being serialized
#jira FORT-60943
Change 3768634 by Robert.Manuszewski
Small optimization to FEDLCookChecker::Verify function
Change 3768603 by Robert.Manuszewski
Merging CL #3766740 by Steve.Robb
TMultiMap::Append added.
Change 3768586 by Ben.Woodhouse
csv profiler screen message
Change 3768506 by Thomas.Sarkanen
Duplicating CL 3764661 from Paragon:
Only update Children attached to Sockets in USkeletalMeshComponent::PostBlendPhysics().
Saves ~20% of STAT_UpdateChildTransforms and ~10% of STAT_UpdateLocalToWorldAndOverlaps in 5ofEach_Dusk_vs_Dusk automation test.
#jira OR-46341
#tests LaneMinionFXTests, monolith w/ full teams.
Change 3768504 by Thomas.Sarkanen
Duplicating CL 3758315 from Paragon:
Optimized PostAnimEvaluation when URO is skipping a frame with no interpolation. Skip unnecessary work.
PreEvaluateAnimation() is now only called if we're about to evaluate anims. PostEvaluateAnimation() is also called only if we have evaluated animations.
Therefore PostEvaluateAnimation() has been pulled inside of PostAnimEvaluation() instead of FinalizeTransforms.
Added a call to ConditionallyDispatchQueuedAnimEvents() in the event that we're not calling PostBlendPhysics because we have not evaluated or interpolated anims.
Added missing call to PostEvaluateAnimation() for PostProcessAnimInstance.
#jira OR-46341
#tests minion FX perf map, lane minion test map, monolith match with 2 full teams.
Change 3768097 by Bob.Tellez
#UE4 Fix non-editor CIS
Change 3767957 by Bob.Tellez
#UE4 Fix an issue that was causing FullLoadAndSave to fail to cache platform data for textures that were created by landscape on mobile and another issue that caused parallel saving to fail in landscape (when cooking for mobile targets)
Change 3767906 by Mike.Fricker
Add Blueprint functions to query parameters from MIC
- GetScalarParameterValue
- GetTextureParameterValue
- GetVectorParameterValue
MIDs already had these functions, but MICs did not.
Change 3767737 by Max.Preussner
Engine: Fix for external textures referenced by a material before being associated with a media player never having their uniform expressions recached
#author jack.porter
#jira FORT-59777
Change 3767735 by Bob.Tellez
#UE4 Setting Opened to false in FOutputDeviceFile::TearDown so if the device file gets initialized again it will do the same initialization logic as the first time.
#jira FORT-60918
Change 3767244 by Ethan.Geller
#jira FORT-60885 Merge in fix for memory leak from 4.18.1.
Change 3766567 by Marc.Audy
Fix initialization ordering warnings
Change 3766443 by Jian.Ru
Submit PSO locking fix again as it has passed local tests
Change 3766362 by Ori.Cohen
Added the ability to get concurrent captures in Test configurations without having to turn full stats on
Change 3766277 by Marc.Audy
Shrink Skinned and Skeletal Mesh Component, FBodyInstance, and UBodySetup
Change 3766275 by Marc.Audy
Better pack UTexture* classes
Change 3766272 by Thomas.Sarkanen
Fixes to enable auto-nativization for animation blueprints
For blend profiles in particular, I've added subobject support to the fake import table building for nativized assets:
- In FEmitterLocalContext::FindGloballyMappedObject, if we dont find the referenced asset then we traverse the object's outer chain if it is a subobject. We add it to UsedObjectInCurrentClass if we find its outer.
- Updated the structure used to build the fake import table to include a specified outer. Beforehand we assumed that all objects referenced by the import table were 'top-level'.
- Updated the fake import table building code in FLinkerLoad::CreateDynamicTypeLoader() to use the new specified outer if found. This asserts if it couldnt find the outer in the already-parsed dependencies (as it reverse-iterates). If in the general case thius turns out to be a problem we can move this to a two-pass system.
Disabled fast-path optimization when running a native anim BP, as native code is faster!
#jira FORT-52823 - Nativizing Player Animation Blueprints
#jira FORT-57378 - Perf optimization: animation blueprint improvements
Change 3766215 by Marc.Audy
Shink FFromatContainer from 88 bytes to 24 by storing in TSortedMap instead of TMap
Change 3765664 by Michael.Noland
Engine: Add support for sets to FJsonObjectConverter::JsonValueToUProperty
Change 3765624 by Marc.Audy
Create helper macro in Archive.h for encapsulating needed steps for serializing a bitpacked boolean
Change 3765200 by Nick.Darnell
Slate - Fixing a memory leak in the invalidation panel. It never cleared out the cached textures and materials it kept alive during retention.
Change 3764881 by Wes.Hunt
Fix FApp::Get/SetIdleTimeOvershoot. It was overwriting IdleTime, which made FrameTimeWithoutSleep look like FrameTimeWithSleep.
#jira FORT-60585
#review-3764882 @arciel.rekman
Change 3763872 by Max.Chen
Sequencer: Set default completion mode for all sections to project default.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763871 by Max.Chen
Sequencer: Add config for default completion mode for movie scene sequences. The default for level sequences is RestoreState. All others, such as UMG are set to KeepState.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763810 by Gil.Gribb
UE4 - remove some init timing spew in programs (i.e. UHT)
Change 3762939 by Robert.Manuszewski
Removing all locks from FEDLCookChecker to improve SavePackage performance
Change 3762851 by Bob.Tellez
Duplicating CL#3740778 from //UE4/Dev-Editor
Fixed issue with content browser column sorting
#jira UE-49460
Change 3762660 by Bob.Tellez
#UE4 Fix a few parallelsave threading problems.
Change 3761861 by Marc.Audy
Fix archive complaints about bitfield
Change 3761802 by Marc.Audy
Pack FTimeline, FHitResult, FAnimUpdateRateParameters, FMeshBuildSettings
Change 3761299 by Matt.Kuhlenschmidt
Fix levels not being lockable/unlockable if they are not checked out
#jira FORT-60086
Change 3760422 by Bob.Tellez
#UE4 Stop caching or clearing platform data when saving concurrently. This was causing threading problems in materials.
Change 3760113 by Jian.Ru
Back out changelist 3759715 as it causes a crash on UGS autotest
Change 3759761 by Jian.Ru
Clean up some debug comments
Change 3759715 by Jian.Ru
Removing excessive locking when accessing PSO caches.
Change 3759285 by Nick.Darnell
Editor - Fixing the length of the datatable row dropdown in the editor.
Change 3758334 by Alexis.Matte
Fix a crash when importing morph target there was a unsync between some buffer depending on the import options
#jira UE-52319
Change 3758332 by Ben.Marsh
Fix output subfolder being appended twice when generating project files. Causes incorrect command line when launching from Visual Studio.
#jira
Change 3758215 by Brian.Bekich
Make Tint property of FSlateBrush NotReplicated now that it is WITH_EDITORONLY_DATA so that cooked clients can connect to uncooked servers
Change 3757702 by Bob.Tellez
#UE4 Fix -NoConcurrentSave cook option in FullLoadAndSave
Change 3757545 by ben.marsh
Suppress Arxan warning about being unable to install a default guard at it's default location.
Change 3757452 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Fixing build error on linux.
Change 3757389 by Hongyi.Yu
Fixed the crash in UEditorEngine::CheckForWorldGCLeaks() when load a level (level A), PIE, load a sublevel of level A and then load another level.
#jira FORT-58283
Change 3757229 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Change 3757077 by Max.Preussner
MediaAssets: Fix for media texture crashing if media player is generated from GC clustered blueprint
#jira FORT-59774
#jira UE-51943
#tests none
Change 3756854 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Backed out unintentional network checksum change!
Change 3756790 by Bob.Tellez
#UE4 Fix inconsistency with how FSoftObjectPtr case is managed between FLinkerSave and FArchiveSaveTagImports, which would cause a cook ensure under some circumstances
Change 3756639 by Arciel.Rekman
Pool memory (only 64KB allocations) on servers (FORT-60342).
- Has a fixed cost of 1GB virtual memory usage.
#jira FORT-60342
Change 3755995 by Alexis.Matte
Fix crash when importing morph target with "built in" tangent option
#jira UE-52319
Change 3755896 by Arciel.Rekman
Remove unnecessary switch for profiling (part of FORT-58878).
- -fno-omit-stack-pointer is only needed when getting callstacks for perf.
#jira FORT-58878
Change 3755711 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Initialize network GuidCache entries as soon as Guids are registered on the server so that we can fill them out with valid information before the object is destroyed. Fixes issues when a guid is exported for the first time to send a destroy to clients. (from RyanG)
Change 3755701 by David.Ratti
FObjectReplicator no longer a GCObject since adding/removing from the global GCObject list is too slow. Managing FObjectReplciators's object references at the NetDriver level now.
#jira FORT-60317
#review-3755702 @Ryan.Gerleve
Change 3754928 by Arciel.Rekman
Linux: add LTO support and more.
- Adds ability to use link-time opitimization (reusing current target property bAllowLTCG).
- Supports using llvm-ar and lld instead of ar/ranlib and ld.
- More build information printed (and in a better organized way).
- Native scripts updated to install packages with the appropriate tools on supported systems
- AutoSDKs updated to require a new toolchain (already checked in).
- Required disabling OpenAL due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219089
#jira FORT-58878
Change 3753986 by Ben.Zeigler
#jira UE-45505 Fix issue where FCoreUObjectDelegates::OnAssetLoaded was being called from an inner loop inside EndLoad. Maps would register components from that callback, and if those registers started their own loads, those objects would be returned in a partially loaded state. We now defer the asset loaded callback to the very end of the loop so recursive loads work properly
Change 3753274 by Ben.Marsh
Fix blank lines in errors and warnings being omitted from notification emails.
#jira
Change 3753175 by Thomas.Sarkanen
Fix hang in animation editor menus
Sound waves were being loaded by the visibility delegate for the 'play' button overlay. This caused major hangs as the ogg compressed data was built on the fly. Handled the unloaded asset case in the various delegates.
Also made the menu larger, as picking a sound wave was all but impossible when you couldnt even see one in the list.
#jira UE-52271 - Persona menu option locks up editor
Change 3752887 by Nick.Darnell
Slate - Adding automatic invalidation to a few more widgets that were found lacking when adding or removing children.
Change 3752785 by Marc.Audy
Avoid doing any work to evaluate streaming volumes if there are no player controllers using streaming volumes
Change 3752185 by Ben.Marsh
Reduce cook time regression caused by correcting package names to match case on disk (to fix deterministic cooking problems). Switched to use IPlatformFile::GetFilenameOnDisk(), and improved performance of FWindowsPlatformFile::GetFilenameOnDisk() by using GetFinalPathNameByHandle() instead of recursively searching up the directory tree.
#jira
Change 3751813 by Ben.Marsh
Improve parsing of diagnostics for deterministic cooking test. Now allows multiple lines in the generic EC error/warning matcher if indented more than the first line, and skips over empty lines.
#jira
Change 3750413 by Ben.Zeigler
Fixes for cook save performance regressions. Add GetAllMarks to object and use that to dramatically reduce contention for the object mark annotation. Implement ShouldLoadForServer/Client directly on some core classes to stop it from calling the slow generic one
Fix issue where refreshing tags for asset registry would do a very slow array delete/add
Improve speed of redirectcollector, there's no need to force-rehash the soft object path list as the remove handles it conditionally
Change 3750014 by Lina.Halper
- duplicate change from following changelists
CL 3669273 - delete all tracks option
- allow to opt out on bone track importing
- fixed pose preview for fullbody to select weights that has pose from asset.
CL 3672170 Remove track support for Animation Blueprint Library
This is required for facial pose retargeting
Change 3749714 by Brian.Bekich
Back out changelist 3748287
#jira FORT-60125
Change 3749377 by Robert.Manuszewski
Improved log formatting for reporting deterministic cook issues.
#jira FORT-59919
Change 3749360 by Robert.Manuszewski
Improved performance of -diffonly mode for cook commandlet for assets with hundreds of thousands of differences.
#jira FORT-59919
Change 3748746 by Hongyi.Yu
Fixed compiling error in Automation project
#jira FORT-59621
Change 3748530 by Mike.Fricker
Fixed non-determinism of landscape grass across platforms/compilers
This causes bushes to be located in different places depending on what platform you were playing on.
1) Random number reseeds were happening as part of function arguments to FVector(), but function argument evaluation order is unspecified, and behaved differently on Consoles/Mac/Windows. Fixed this bug.
2) Strings used for foliage CRCs could use different character sizes on different platforms. Now we always use ANSI.
3) Strings used for CRCs could have possibly have different case. Now forced lowercase.
#jira FORT-60109
Change 3748471 by Zak.Middleton
Added stats to NetDriver TickFlush and stats gathering within that function.
Change 3748287 by Brian.Bekich
Adding net.MaxStringSerializationSize to cap maximum string read from network, default to 4096, used by FNetBitReader
Deprecating MAX_STRING_SERIALIZE_SIZE in favor of the cvar
FInBunch defaults to prior behavior if cvar is 0
UPackageMap::SerializeName and UPackageMapClient::SerializeNameAsString will always cap at NAME_SIZE
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3747980 by Bart.Hawthorne
In Oodle, only generate and write dictionaries on Windows, Mac, and Linux
Change 3747642 by Gil.Gribb
Fix CIS
Change 3747635 by Zak.Middleton
Avoid string alloc on every ServerMove() call on the server.
Change 3747560 by Gil.Gribb
UE4 - Fixed XBox and Windows thread priorities. Only 2 though -2 seem usable and some of the old values were being ignored.
Change 3747548 by Gil.Gribb
UE4 - Changed thread pool to be TPri_SlightlyBelowNormal so that they will not preempt HP task graph tasks.
Change 3747544 by Bart.Hawthorne
When detecting if Oodle is installed, use the newest version instad of the oldest one.
Change 3746440 by Robert.Manuszewski
Dterministic cook issues reporting improvements
- Huge performance improvements
- Added new metric to the summary: NumberOfDifferencesInPackages
- Diff stats have their own section now (Package.Diff)
- When running with -diffonly there commandlet will not log the Warning/Error summary anymore
- Callstacks are no longer logged with instruction addresses
- Because callstacks are no longer logged with addresses I can collapse them for structures that otherwise would be split into multiple separate callstacks
- Callstacks, Serialized Object and Serialized Property are now indented
- Each asset is capped at 5 entries. If there's more differences, they'll be logged as single warning.
- Replaced \r\n with \n in the callstack log to make it work better with EC
#jira FORT-59919
Change 3746426 by Gil.Gribb
UE4 - Tuned dispatch in the deferred renderer. Added r.DoPrepareDistanceFieldSceneAfterRHIFlush and defaulted it to on.
Change 3746348 by Mike.Fricker
Added new CVars to toggle level streaming behavior
- No effective change to engine yet. The defaults values enable the same default behavior.
- New CVar: "s.ForceGCAfterLevelStreamedOut" (Whether to force a GC after levels are streamed out to instantly reclaim the memory at the expensive of a hitch.)
- New CVar: "s.ContinuouslyIncrementalGCWhileLevelsPendingPurge" (Whether to repeatedly kick off incremental GC when there are levels still waiting to be purged.)
- New CVar: "s.AllowLevelRequestsWhileAsyncLoadingInMatch" (Enables level streaming requests while async loading (of anything) while the match is already in progress and no loading screen is up)
Change 3746127 by Gil.Gribb
UE4 - Slight tweak to more agressively batch occlusion queries.
Change 3746111 by Cecil.McRae
Change 3745681 by Bob.Tellez
#UE4 Prevent attempting to execute a remote process to get the metal shader compiler version if no remove process machine has been configured. (Fixes a warning)
Change 3745631 by Matt.Kuhlenschmidt
Fix details panel crash after compiling blueprints that have edit conditon properties
Change 3744544 by Gil.Gribb
UE4 - Downgraded a fatal error to a warning. Example: Found package without a linker, could find SceneComp in /Game/AIDirector/AIDirector_Fortnite, but somehow wasn't finished loading. This is a sort of cook mismatched caused by the fact that all PS4 cooks have server-only data in them.
#jira FORT-59879
Change 3744419 by Matt.Kuhlenschmidt
Fix opening color picker causing values to change. Was due to conversion between srgb and linear color.
Change 3744270 by Ben.Marsh
Merging change to include deterministic cooking summary from Dev-Core (CL 3743182).
#jira FORT-59919
Change 3743621 by Guillaume.Abadie
Fixes subsurface profile fallback to lit shading model when Opacity == 0, introduced by 3447144.
#jira UE-51569
Change 3743403 by Gil.Gribb
UE4 - Merged lockfree / taskgraph fix from //UE4 (CL 3732262)
Change 3743392 by Gil.Gribb
Merged IO fixed from //UE4 (CL 3641155)
Change 3743376 by Gil.Gribb
UE4 - Added r.WarningOnRedundantTransformUpdate to produce warnings on redundant transform updates.
Change 3743372 by Gil.Gribb
UE4 - Added a stat for distance field verification...which takes a very long time, but does not affect test or shipping config.
Change 3743030 by Bob.Tellez
#UE4 Revert some code the was accidentally merged to UE4Main
#jira UE-52032
Change 3742611 by Josh.Markiewicz
#UE4 - fix for crash in destructor probably related to the freeing of memory via default destructors AFTER CefShutdown() has been called
#tests crashes before, no crash after (not sure if it was a 100% crash but this seems better regardless)
Change 3742187 by Nick.Darnell
Slate - Adding a new optional parameter to direct routing for the widgets under the cursor in Slate Application. Essentially ProcessReply occasionally needs to know the widgets under the cursor, the previous implementation, just used the routing path, this results in missing sending mouse leave messages to widgets under the cursor when dragging begins, which often left things with hover effects in bad states.
Change 3742053 by Michael.Trepka
Copy of CL 3713881
Added -buildscw to Mac Build.sh script to build ShaderCompileWorker in addition to the requested target. Xcode passes it to the script when building non-program targets.
#jira UE-31093
Change 3742050 by Michael.Trepka
Copy of CL 3711085
Reenabled UBT makefiles on Mac
Change 3741924 by Josh.Markiewicz
#UE4 - delete EpicSurvey module
- working toward engine/plugins/online removal from game branch
Change 3741865 by Nick.Darnell
UMG - Fixing a High DPI bug that wasn't scaling the offset for DragDrop widgets when using In-Window rendering that games depend on for DragDrop effects.
Change 3741442 by Ryan.Gerleve
Fix initialization order warnings
Change 3741370 by Ryan.Gerleve
Back out changelist 3689397. The memcpy in one of the FInBunch constructors is not portable and causes this change to break networking on Android.
Change 3740914 by Peter.Knepley
Restore player name obsfuscation
Change 3740828 by Marc.Audy
Dynamically create FKey if the char code is unknown
#jira FORT-59735
Change 3740811 by Ben.Marsh
UAT: Fix double-spacing of lines output by Utils.RunLocalProcess, and use a non-local function to output them for more readable logs.
#jira
Change 3740328 by Bob.Tellez
#UE4 Fix FullLoadAndSave cook method
Change 3740327 by Bob.Tellez
#UE4 Minor movie scene cooking improvements
Change 3740280 by Bob.Tellez
#UE4 Fix shipping config CIS
Change 3740232 by Bob.Tellez
#UE4 Gave OodleHandlerComponent a short name so it doesnt hit maxpath length issues on build machines.
Change 3740209 by Nick.Darnell
UMG - Finishing the ability to add a "Custom" method for Navigation. Currently the editor implementation leaves me wanting, but it works for now. You can put the name of a function to call (needs to match a signature that returns a UWidget).
Change 3740207 by Nick.Darnell
Slate - Navigation attempts when the user claims they are doing custom or explicit, if those methods don't return a valid widget, we don't treat it like the attempt failed and fallback to default navigation methods. Instead we use it as a trigger to indicate that no navigation should occur and treat it like a stop.
Change 3740189 by Bob.Tellez
#UE4 Fix mouse cursor position being set when hovering over the viewport in windowed mode despite not having focus
Change 3740171 by Marc.Audy
Fix merge issue causing compile error for AutomationTool
Change 3739270 by Ben.Woodhouse
Use background task graph affinity on platforms that implement it (e.g. XB1). Saves 8ms on GC spikes and ~0.5ms on the renderthread
#jira FORT-56961
Change 3739244 by Ben.Woodhouse
-statunit commandline option
Change 3738920 by peter.knepley
Fix issue where simulated proxies had bad crouch state when re-entering relevancy
Change 3738904 by Gil.Gribb
UE4 - Moved audio decompression tasks to the background thread pool. Controlled by a cvar AudioThread.UseBackgroundThreadPool, which defaults to 1.
Change 3738378 by Ori.Cohen
Added better profiling for scene query hitches
Change 3736984 by Ben.Woodhouse
Dummy merge: Accept main version of windowsrunnablethread.h, so Windows gets the new priorities
#jira FORT-56700
Change 3736754 by Zak.Middleton
Remove engine hacks of K2_SetActorLocation etc for pending engine merge. Will replace with delegates on transform updates for relevant classes.
Change 3736282 by Hongyi.Yu
Don't check target file while doing iterative shared prebuild cooking.
#jira FORT-58911
Change 3736109 by Michael.Trepka
Updated FMallocLeakDetectionProxy to not use a critical section internally on top of thread safety measures performed by FMallocLeakDetection and the underlying FMalloc implementation. The improvements are biggest on Mac, in particular in low framerate situations, as Metal RHI uses malloc heavily on multiple threads, but it's also a nice 10% improvement on a high end PC.
#jira FORT-55309
Change 3735765 by Ben.Woodhouse
Fix GTSynctype logic when vsync is disabled. This was breaking profiling
Change 3734436 by Marcus.Wassmer
More reliable Aftermath data.
#jira FORT-45518
Change 3734103 by Bob.Tellez
#UE4 Exposing GetRefPosePosition on SkinnedMeshComponent to BPs
Change 3733985 by Saul.Abreu
#jira FORT-58816
"Special case zero-width space in the text shaper to avoid fonts rendering the fallback glyph" - Jamie Dale
Needed to workaround an issue with guillemets (weird arrow quotes).
Change 3733922 by Brian.Bekich
Setting max serialization size in FNetBitReader to prevent runaway string reads from replicated object paths
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3733850 by Max.Chen
Sequencer: Return unhandled only if not dragged. This fixes a bug where dragging in the track area would sometimes leave the handled state with the time slider controller and not allow you to pop up a menu with the movement tool.
#jira FORT-56092
Change 3733299 by Ethan.Geller
#jira FORT-58943 Handle corner cases for repeated calls to precache buffers.
Change 3732907 by Gil.Gribb
UE4 - Removed slow HLOD code from frustum cull loop and set things up at AddPrim time instead. Saves 1-3ms.
Change 3732728 by Robert.Manuszewski
Fixing a crash when dumping stats with massive callstacks
#jira FORT-58901
Change 3732438 by Marc.Audy
When a client informs the server that it has loaded a streaming level force a net update on all dormant actors that have at one point replicated data to relevant clients and ensure that the connection's destroyed startup/dormant actors list is properly populated.
#jira FORT-56997
Change 3730413 by Lukasz.Furman
fixed PlayerName encryption key
#jira FORT-59066
Change 3729588 by Bob.Tellez
#UE4 Only calling FixupData on load. Fixes crash during parallel saving.
Change 3729475 by Marc.Audy
Fix missing ;
Change 3729444 by Marc.Audy
Fix cases where GetWorld() being called multiple times per function
Change 3729143 by Hongyi.Yu
Added support to extract pak files to mount point.
- Extract with "-ExtractToMountPoint" when extracting pak in DiffCookedContent()
#jira FORT-58635
Change 3728981 by Nick.Darnell
Slate - Fixing a bug with Slate turning on statid tracking even when the slate verbose stats are not being used.
Change 3728838 by Zak.Middleton
Compile out GetWorld() call in check() in Test and Shipping builds, to avoid skewing profiling.
Change 3728604 by Jian.Ru
Submit one render command rather than many in FScene::UpdateParameterCollections
Change 3728434 by Marc.Audy
PostSignificance should always fire when unregistering regardless of whether this is the last object in the tag.
Change 3728427 by Gil.Gribb
UE4 - reduce stat overhead when not collecting stats.
Change 3728197 by Marc.Audy
Properly call post significance on initial registration if the post significance type is sequential
Change 3726266 by Gil.Gribb
UE4 - Force HISMC trees to rebuild during cook. This allow us to change parameters without resaving maps.
Change 3724501 by Marc.Audy
Fix initialization order
Change 3724411 by Ben.Woodhouse
Point light shadow rendering optimization - Made per-triangle culling take Z into account.
In FortGPUTestbed (with grass shadow casting enabled), GSVerticesOut reduced from 464k to 234k.
On xbox one, a pointlight GPU cost reduced from 6.7 to 4.1ms.
On PS4, GPU cost went from 2.3 to 1.9ms.
#jira FORT-58921
Change 3724367 by Chad.Garyet
Downgrading lock warning about still waiting to a message instead of a warning.
Change 3723903 by Max.Preussner
MediaAssets: Merged workaround for uninitialized media sound waves from 4.17
#jira FORT-57260
Change 3723134 by Lukasz.Furman
added deprecation for PlayerState.PlayerName, it should remain accessible only through Get/Set functions to control obfuscation
Change 3722955 by Jian.Ru
Fix a compilation warning
#jira FORT-58749
Change 3722667 by Luke.Thatcher
[BUILD] [!] Fix PGO failures on build machines.
- The strings "Failed" and "error" are always treated as build failures, even if the build task returns a success code.
- Failure to reserve a device should not be fatal.
#jira FORT-58001
Change 3722291 by Lukasz.Furman
restored public access to PlayerName for now, current code will be going through accessor
Change 3721012 by Alicia.Cano
chunk title file generation
#jira FORT-53605
Change 3720961 by Marcus.Wassmer
Fix bad UVDensities on objects causing texture streaming to fail. Better fix will come with the engine merge.
#jira FORT-58240
Change 3719318 by Lukasz.Furman
replaced old branch name assertions
Change 3719047 by Lukasz.Furman
added branch name assertion to core headers to avoid duplicating it
Change 3718499 by peter.knepley
Fix for a crash when calling FSlateApplication::Get().FindPathToWidget in response to a widget destructing. Widget must be invalidated before the reference is cleared or else someone else might assign a shared reference to it during destruction.
Change 3716965 by Alicia.Cano
No sound was playing for Android.
#jira FORT-58302
#android
Change 3715746 by Ben.Marsh
Hide Arxan warnings about PDB files not being present.
#jira
Change 3715172 by Bob.Tellez
#UE4 FullLoadAndSave now does SavePackage in parallel.
Change 3715055 by Bob.Tellez
#UE4 Fix to actually use the precached streaming audio DDC data when cooking.
Change 3714130 by Bob.Tellez
#UE4 Core changes to allow SavePackage to be done concurrently
Change 3714099 by Bob.Tellez
#UE4 Pull the logic to initialize and uninitialize the physics scene for a world out into separate functions
Change 3713145 by Ben.Marsh
Disable an Arxan warning in EC.
#jira FORT-56926
Change 3712904 by Ben.Woodhouse
Fix for gpu profiler crash on pre-maxwell nvidia (or when r.gpuprofiler is set to false)
Change 3712693 by Ben.Woodhouse
Workaround for PS4 flip thread crash in dev builds. Caused by the flip thread/offset threads being shutdown before being initialized. The high level logic is now robust to that. We should fix the PS4 RHI ideally, but this is simpler for now.
#jira FORT-58409
Change 3712544 by Ben.Woodhouse
add missing skylight diffuse gpu stat
Change 3712515 by Ben.Woodhouse
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3712297 by Mike.Fricker
Fixed huge client hitch when applying changes to in-game options
- Every component was being re-registered when r.SimpleForwardShading was updated by the scalability system, even if the value hadn't changed. Now, it only re-registers components if the value changes on the fly. (e.g. when turning Shadows off or on PC)
#jira FORT-57661
Change 3711501 by Ben.Marsh
Fix build failure on Linux.
#jira
Change 3710962 by David.Ratti
Add SCOPE_CYCLE_UOBJECT for SourceObject of GE - this will tell us what weaponw as applying the GE
Change 3710602 by Marc.Audy
Only create MIDs as a child of the calling object if construction script is running
Change 3710421 by Ben.Woodhouse
Bring over a couple of XB1 rendering fixes from 4.18
3692692: Integrate XB1 translucent lighting fix
3674543: D3D12 : Fix bug with non-CS version of UpdateTexture3D caused by bad depthstride. This was causing corruption in the indirect lighting cache
#jira UE-49416
Change 3710338 by Marc.Audy
Fix Json <-> Property converter to handle maps with struct keys
Merged from CL# 3521195
#jira UE-46616
Change 3710226 by Bob.Tellez
#UE4 Increase TaskGraph stack size in editor builds since. SavePackage uses a deep callstack which exceeds the 384 memory limit
Change 3709046 by andrew.grant
Added ALLOW_CONSOLE_IN_SHIPPING define that Target.cs files can set to turn on console in shipping builds
#jira FORT-57180
Change 3709040 by andrew.grant
Fixed issue where this could fail if a messagebox was spawned early during initialization
Change 3708830 by Bob.Tellez
#UE4 Commandline switches/options are no longer detected when found between quote characters. This causes options from not being incorrectly detected when passed in as a value from another options. i.e. -Option="-log" no longer causes -log to be picked up. This removes the syntax of specifying parameters like "Option=Value", which should now be replaced with -Option="Value"
#jira FORT-57833
Change 3708826 by Bob.Tellez
#UE4 Removed needless calls to RegisterSerializedShaders in the saving codepath of material serialization. This function is only relevant when loading shaders.
Change 3707905 by Ori.Cohen
Fix attached skinned mesh never being unhidden due to scale 0 and render tick optimization
#jira UE-51485
Change 3706450 by Chris.Bunner
Removing illegal material set on decal component in GameplayStatics.
Set a related JIRA, this doesn't actually fix the issue but contributes.
#jira FORT-51597
Change 3706223 by Marc.Audy
Shrink UPackage class size substantially
Change 3706221 by Marc.Audy
Store CustomVersions in array rather than set
Change 3705798 by Bob.Tellez
#UE4 ShadowDepthVertexShader.usf fix to fix Mac cook.
Change 3705613 by Uriel.Doyon
Texture streaming integration from Main.
#jira FORT-57376
Change 3705137 by Michael.Trepka
Fixed MetalRHI warning when compiling without MALLOC_LEAKDETECTION defined
#jira FORT-55309
Change 3704310 by Marcus.Wassmer
fix d3ddebug error with shadowcasting pointlights
also suppress spammy d3ddebug data about texture debug names
#jira FORT-58063
Change 3703477 by Marc.Audy
Minor tweak to keep Padding on one cache line.
Change 3703449 by Michael.Trepka
Don't use parallel RHI execute on Mac if MALLOC_LEAKDETECTION is enabled as this combination affects performance significantly due to mutex locking in FMallocLeakDetectionProxy
#jira FORT-55309
Change 3703217 by Marcus.Wassmer
Update PS signatures to match VS. Fixes crashes when running witih -d3ddebug which we need to catch real problems
#jira FORT-58021
Change 3702926 by Aaron.Eady
#JIRA na
Engine Code Improvements (that this project doesn't have yet);
Added engine code for drawing a debug 2D box.
Added engine code that allows for Keyboard Shortcuts to be special characters like backslash \.
-- Code --
DrawDebugHelpers:
DrawDebugCanvas2DBox() - Added this to allow us to draw debug 2D boxes.
RemoteConfigIni:
SpecialCharMap - Updated this TCHAR* property to be in the right order so you can use special characters like backslash as keyboard shortcuts.
Change 3701976 by Michael.Noland
Editor: Rewrote CallInEditor support and promoted it so it can be used on functions in any class, not just blueprints derived from AActor:
- CallInEditor used on native UFUNCTION() declarations will now show up without having to make a BP subclass
- CallInEditor can now be used as a top-level keyword in the UFUNCTION() declaration (e.g., UFUNCTION(Category=CoolCommands, CallInEditor))
- Now shows each function as a separate button, placed in the category associated with the function
- The button strip entry is now searchable by function name or tooltip
- Prevented operating on functions that have parameters or return values, which would crash before
- Removed the duplicate copies of properties placed in the Blutility section
- Added a scoped transaction around CallInEditor execution
- Allowed functions to be marked as CallInEditor in addition to custom events (currently we don't allow editing category or tooltip on custom events...)
Editor: Moved Experimental/EarlyAccessPreview details customizations up to UObject so it can be used on any class, not just actors/components
Edigrating CL# 3374995, 3375121, and 3375308 from Dev-Framework to FN main
Change 3700836 by Bob.Tellez
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
#jira FORT-57833
Change 3700821 by Bob.Tellez
Merging CL#3461205 from //UE4/Dev-Core
Fixed parameter parsing so that arguments are not parsed if not preceeded by a whitespace (for example "-Log" was parsed in "TM-Log")
#jira UE-33790
Change 3699584 by Chad.Garyet
Upping the timeout on symstore to half an hour instead of 15 minutes. Symstore on xbox takes about ~22 minutes and if two builds are going simultaneously it can cause a job to fail due to the timeout being hit.
#jira FORT-0
Change 3698692 by Aaron.McLeran
#jira FORT-57582 crash in sound mix state code
- Removed the assert as it looks like that state is now possible.
Change 3698411 by Bob.Tellez
#UE4 One last correctness fix for when to not save generated base ini files.
#jira FORT-57315
Change 3698390 by Bob.Tellez
#UE4 Slightly more accurate logic to prevent writing of base ini files (old logic may have prevented writing of non-base ini files)
#JIRA FORT-57315
Change 3698369 by Bob.Tellez
#UE4 Ensure that Tcp/Udp messaging plugins are disabled in shipping config
Change 3698352 by Bob.Tellez
#UE4 Minor additional fix to make sure DISABLE_GENERATED_INI_WHEN_COOKED only affects cooked builds
#jira FORT-57315
Change 3698341 by Bob.Tellez
#UE4 DISABLE_GENERATED_INI_WHEN_COOKED now properly prevents all base ini file loads from happening from a generated folder. It also prevents writing generated ini files completely.
#JIRA FORT-57315
Change 3697553 by Nick.Darnell
Slate - When setting the content of an SBox it should always invalidate.
Change 3697330 by Bart.Hawthorne
APlayerController::ServerShortTimeout_Implementation now only iterates over the active object list instead of uisng an actor iterator, since non-replicated actors wont have a network object info to update.
#jira FORT-57099
#tests ran 100 player bot match
Change 3695578 by Bob.Tellez
#UE4 Fix Win32
Change 3695508 by Eric.Newman
Tweaked LogInit logging to clarify when the command line is being filtered
* Encountered this red herring when evaluating crash logs
#jira FORT-55839
#tests ran shipping & debug client builds, and editor game build
Change 3694898 by Michael.Trepka
Fixed Vorbis audio not playing on non-Windows platforms due to changes in CL 3668361
#jira FORT-57121
Change 3694655 by David.Ratti
Reimplement TweakObjetPtr optimizations with FObjectReplicator as an FGCObject instead of the owning channel being responsible for adding the replciator's ObjectPtr to the reference collection. (There are cases where object replicator ownership is transferred).
#JIRA FORT-57298
Change 3694491 by Ben.Woodhouse
Change courtesy of Gil: Drop the priority of the texture streamer using a new low-priority thread pool. This saves a 1-2ms in heavy combat in PVE (XB1 Test)
#jira FORT-57376
Change 3693609 by Ryan.Gerleve
Back out CL 3689050 since it was likely causing a crash.
#jira FORT-57298
Change 3693327 by Aaron.McLeran
#jira FORT-57416 Fixing PS4 cook.
Making sure zero pad bytes stays positive without a check.
Change 3693136 by David.Ratti
fix clang warning
Change 3692703 by Thomas.Sarkanen
Fix CIS warning on PS4/Linux
Change 3692589 by Thomas.Sarkanen
Moved exposed value handler bound function initialization to CDO postload
This means that FindPropertyByName and FindFunctionChecked dont incur any overhead when spawning in new anim instances
#jira FORT-56968 - Hitch - SkeletalMeshComponent initialization (110ms)
#tests PIE PvE, 20-bot BR game on PC/PS4.
Change 3692552 by Alex.Delesky
Change 3692495 by Bart.Hawthorne
Fix build
Change 3692488 by Bart.Hawthorne
Check for actor relevancy and level initialization when there's no channel first when prioritizing actors for replication. Dormancy checks in this case are useless because ShouldActorGoDormant will always be false, and if IsActorDormant is also true, then the result of skipping the actor is the same.
#jira FORT-57104
#tests played 100 player bot match
Change 3691819 by Bob.Tellez
#UE4 No longer conditionally including SlateDebug fonts in the cook based on configuraiton. When builds are produced that contain more than one configuration it changes what is cooked in unexpected ways so now we just always cook this font.
Change 3691805 by Bob.Tellez
#UE4 CIS fix
Change 3691784 by Bob.Tellez
#UE4 Optimization for exiting PIE. Texture streaming managers have an optimization for game worlds but were not using them for PIE worlds
Change 3691273 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3691268 by Aaron.McLeran
#jira FORT-56228 LogAudio:Warning: spam causes severe performance drop on the Mac Platform
Reducing log level
Change 3690547 by Ryan.Gerleve
Speculative fix #2 for a server crash/assert. If the timing is right, it's possible for the server to try to re-load a placed-in-map actor that was previously garbage collected. This was happening because CanClientLoadObject was always returning true for these (null) objects, even if the NetGUID corresponded to a map actor that shouldn't be loaded. Also added/improved some logging that will help in case this doesn't fix the issue.
#jira FORT-55763
Change 3690451 by Lukasz.Furman
changed branch name testing in engine hacks to use case insensitive match
Change 3690270 by David.Ratti
Cache weak object ptr in FNetworkObjectInfo to avoid reconstructing one every time we need to lookup its actor channel.
#jira FORT-57156
Change 3690227 by David.Ratti
Added optional TWeakObjectPtr parameter to packagemap functions GetOrAssignNetGUID, SUpportsObject. This allows you to pass in a weak ptr for an object if its already created. If you pass in null, the functions will create them internally.
This fixes some common cases where we were converting the same object into weak ptr multiple times in a frame.
#jira FORT-57156
Change 3690184 by David.Ratti
Cache net connection weakobjectptr when building consider list instead of constructing it again for every actor.
#jira FORT-57156
Change 3689805 by Peter.Knepley
Make ConditionalInitAxisProperties protected instead of private
#jira FORT-56414
Change 3689789 by Marcus.Wassmer
Hack workaround for missing shadowdepthps for XB1 until we get a handle on why things are exploding
#jira FORT-56792
Change 3689702 by Peter.Knepley
Allow games to have a custom MassageAxisInput function
#jira FORT-56414
Change 3689687 by Bob.Tellez
#UE4 Avoid copying the shaders array to avoid changing refcounts of shaders while serializing
Change 3689655 by Peter.Knepley
Make SmoothMouse virtual so games can have their own smoothing
#jira FORT-56417
Change 3689499 by Bart.Hawthorne
Fix Linux CIS warnings
Change 3689397 by Bart.Hawthorne
Changed FOutBunch and FInBunch uint8 entries to use bitfields instead of bytes which knocked 86% off of our net tick time
Change 3689056 by Lukasz.Furman
3rd attempt for branch name checking in engine code hacks
Change 3689050 by David.Ratti
First pass at removing use of TWeakObjectPtr from core replication classes. This should reduce FWeakObjectPtr::Get usage.
Still expecting to see FWeakObjectPtr::operator= come up a lot. Going to tackle this in a second pass which will require some deeper refactors.
#jira FORT-57156
Change 3688972 by Bob.Tellez
#UE4 Add build target flag to control DISABLE_GENERATED_INI_WHEN_COOKED
Change 3688864 by Ryan.Gerleve
Fix broken logic to find the "best" replay sample for character movement when we don't find two samples to interpolate between. Now uses the sample closest to the current time. Also added some debug drawing.
#jira FORT-56553
Change 3687654 by Bob.Tellez
#UE4 Added compile time option to disable reading generated ini files other than GameUserSettings in cooked builds.
Change 3686615 by Lukasz.Furman
Back out changelist 3686610
Change 3686592 by Matt.Kuhlenschmidt
Gave the CL description in the source control submit window more room
Change 3686020 by Ben.Marsh
Remove debug code that prints to logs while building.
#jira FORT-56923
Change 3684414 by Peter.Knepley
Back out changelist 3678336
#jira FORT-56512
Change 3683894 by Gil.Gribb
UE4 - By default, do not check for illegal calls to MarkPendingKill in the garbage collector in test and shipping configuations. This was slow.
Change 3683686 by peter.knepley
Raise MTU from 512 to 1024
#jira FORT-56756
Change 3683343 by Rob.Cannaday
Fixes insert disk popup
#jira FORT-56500
Change 3683156 by Peter.Knepley
Network optimizations to reduce alloc/free & memcpy churn saving about 10% of net tick time
Change 3682234 by Guillaume.Abadie
Cherrypick TAA refactor 3512696 and TAA fix 3668108
#jira FORT-56303
Change 3681494 by Bob.Tellez
#UE4 IsLoadedByEditorPropertiesOnly is not working properly so I removed it from FullLoadAndSave
Change 3681342 by Bob.Tellez
#UE4 Added a FullLoadAndSave option to cooking, which simply loads all content then saves it to avoid the overhead of managing which packages need to be cooked. Large perf improvement for those who cook by the book and can fit the entire game in memory
Change 3681014 by Yenal.Kal
#jira FORT-56209
#jira FORT-56272
Fixed a bug in the ability system where the ability ended callbacks could cause the ability end to be called again in the same call stack even though the ability is activated only once.
This was happening because we were broadcasting the event before we decrement the active count.
Change 3680739 by Michael.Trepka
Warn about NaN float literal values when translating HLSL to Metal instead of failing, plus added more detailed warning/error messages for NaN and unhandled values
#jira FORT-56425
Change 3679237 by Bob.Tellez
#UE4 Remove some debug logging
Change 3679187 by Bob.Tellez
#UE4 Dramatically imrpove speed of writing cookloadorder log file
Change 3678926 by Bob.Tellez
#UE4 Minor savepackage speed improvements
Change 3678336 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3676998 by Ben.Woodhouse
Fix XGE shader compilation so it doesn't crash randomly
Change 3676606 by Ori.Cohen
Update GC to be 61.1 to avoid heartbeat collision
Change 3676447 by Ori.Cohen
Fix CIS warning
Change 3676286 by Max.Preussner
Fixed client Crash UMediaSoundWave::GeneratePCMData (FORT-56107)
#jira FORT-56107
Change 3674591 by Ryan.Gerleve
Don't filter out PendingKillPending actors from FNetworkObjectList::Find. This was causing actors that get destroyed while dormant on the server to never be destroyed on clients.
#jira FORT-55802
Change 3674181 by Michael.Noland
Framework: DLL export LogGameplayTags
Change 3674138 by Billy.Bramer
#jira FORT-56138, FORT-56139
- Duplicate CL 3396590 from //Orion/Main re: ranged-base for iteration ensure from montage changes
Change 3672464 by Lukasz.Furman
removed recast layers crash tracking code
Change 3672153 by Daniel.Lamb
Added some debugging code to help track down why shaders are hashing poorly.
Change 3671498 by Luke.Thatcher
[~] Modify new frame syncing to reduce performance regression seen when the game is running over budget.
- Rather than forcing a flip sync after we kick off one frame early, we just continue to kick frames if we time out. This allows the game thread to get ahead when we're over budget.
- The game thread will naturally resync with the vsync when we return to being in budget.
#jira FORT-55842
Change 3671079 by Ryan.Gerleve
Fix an edge case where the PackageMap on the server would try to resolve objects from default NetGUIDs even if their outer has already been garbage collected. This could lead to a completely unrelated object being returned instead of null, leading to asserts and potentially other issues.
#jira FORT-55763
Change 3670487 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3670351 by Zak.Middleton
Back out changelist 3669817 (networking optimizations). Would rather have more testing before it goes to Release-Next. Will resub just for main and RP.
#jira FORT-55999
Change 3670344 by Josh.Markiewicz
#UE4 - more verbose logging for SetExpectedClientLoginMsgType
Change 3670323 by Wes.Hunt
Fix for dedicated servers not flushing events in a timely manner.
#jira FORT-56015
Doh, using GFrameNumber was NOT a good idea on servers... :-/
Change 3669817 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3668416 by Michael.Noland
Core: Changed FString::ParseIntoArray to use Reset instead of Empty on the passed in array, allowing it to be approximately resized
#jira FORT-55887
Change 3668411 by Olaf.Piesche
Always cache depth collision particle shader
#jira FORT-51307
Change 3668361 by Aaron.McLeran
#jira FORT-55628 Attempt to bypass crash and log an error if libvorbisdll fails to load.
Change 3667892 by Rob.Cannaday
libwebsocket libs to handle getprotobyname("TCP") failing the libwebsockets connection
#jira FORT-55917
Touch LwsWebSocket.cpp to ensure the module gets built with the new libs
Change 3667308 by Uriel.Doyon
Postponed the release of IO requests when canceling mip updates to prevent threading issue.
#jira FORT-54491
Change 3666835 by Lukasz.Furman
fixed overlapping index buffers when static mesh exports both convex and simple collisions for navigation
#jira UE-50370
Change 3665374 by Mike.Fricker
Fixed server crashing after hotfixes have re-imported curve table data
- The hotfix system is capable of replacing the content of a UCurveTable on the fly
- If any systems had references to inner curves on that curve table, they would become invalid
- This needs to be fixed in 1.6.4 (tonight) and also in 1.7
#jira FORT-55792
Change 3665063 by Daniel.Broder
Fixed crash in GameplayTagQueryCustomization when choosing "Save and Close" on GameplayTagQuery after setting a query due to nullptr NotifyHook in CloseWidgetWindow.
Added additional if (StructPropertyHandle.IsValid()) wrappers and one check(StructPropertyHandle.IsValid()); the former to be consistent with other code and prevent possible crashes, the latter to at least catch the cause of a possible crash properly without having to change the code more significantly to handle it gracefully.
Also changed some if( X ) to if (X) to match coding standards and provide consistency within the file.
Michael, I'm Reviewing you on this fix since you brought this change over from Framework. And Marc because you reviewed him on that change.
#UE4 #NoReleaseNotes #RNX
Change 3664948 by Lukasz.Furman
reduced number of allocations in StorePathfindingDebugData, optimized path length calculations to avoid recursion
#jira FORT-51111
Change 3664916 by John.Abercrombie
Copy CLs 3383318 & 3388506 from //Orion/Main/Engine/Source/Runtime/Engine/...
- Been testing with this for a while now
- This change makes particle effects show up on the current frame's pose for skel meshes as well
Removed my StopAllMontagesByGroupName temp hack
CL 3383318
Delay dispatching of AnimEvents (Notifies and Montage Events) until after we receive an updated animation pose (if applicable).
This fixes AnimNotifies playing particle effects using a socket location using last frame's pose. Now they use the current frame's pose.
CL 3388506
Delay clearing of MontageInstances and triggering 'OnAllMontageInstancesEnded' until all Montage Events have been dispatched.
Also fix SkelMeshComponent ticking on dedicated servers when rejoining in progress.
#jira FORT-55102 - Server Crash UAnimInstance::StopAllMontagesByGroupName
Change 3780616 by Gil.Gribb
Fixed and reenabled r.DelaySceneRenderCompletion
Change 3778979 by Gil.Gribb
UE4 - Improved the performance of grass updates and added the ability to not do all of them every frame.
Change 3778200 by Nick.Darnell
UMG - Making it possible to cancel delays and all animations on widgets. Useful when destroying a widget and needing to stop any async state.
Change 3777612 by Zak.Middleton
Perf: Added option to CharacterMovementComponent to skip immediate forward prediction for proxies on the frame they receive a network update (bNetworkSkipProxyPredictionOnNetUpdate). This avoids all forward prediction sweeps and floor checks on those updates. Intermediate frames will interpolate with prediction. This can also be disabled globally with the CVar "p.NetEnableSkipProxyPredictionOnNetUpdate 0".
Added NetworkSmoothingDisableProxyPredictionForPawnLOD to force disabling full simulation for LOD >= this value (currently 3, so bottom 75 pawns). This takes precedence over current distance and view angle checks for prediction (mesh interpolation is untouched).
Change 3774338 by Ben.Woodhouse
Convert the D3D12 PSO caches to use RwScopeLocks. This change is courtesy of a shelf from Gil, plus a couple of minor fixes.
Saves up to a millsecond of frame time in CPU-bound scenarios
Change 3773462 by Gil.Gribb
UE4 - Add particle batching. This is disabled by default but can improve thread scheduling when there are lots of very fast particle systems.
Change 3771375 by Hongyi.Yu
Fixed the crash where ability components are unregistered and then re-registered, which usually happens in PIE.
Change 3771368 by Ben.Zeigler
#jira UE-52670 Add project setting bValidateUnloadedSoftActorReferences that is true by default to match current behavior. If you set it to false it will no longer load packages to look for soft actor references when deleting/renaming actors.
Change 3771173 by Seth.Weedin
Auto manage attachment support for AudioComponent- An opt-in feature that allows AudioComponents to cache their AttachParent/AttachSocket and only attach themselves when playing audio, detaching after playback is completed. Set to false by default.
Change 3768811 by Ori.Cohen
Change animation scale collision code so that it uses the physics asset.
Change 3768148 by Brian.Bekich
Fix muting being unable to find remote player controller
Change 3768117 by Ori.Cohen
Prevent pawn collision from updating during animation
Change 3766554 by Gil.Gribb
UE4 - Added a new option to add and remove from static draw lists on demand. This is off by default.
Change 3766427 by Nick.Darnell
Slate - Finally adding Opacity to SWidget. Any widget can now be alpha animated at will, no more need to waste overhead by wrapping things with SBorder or making them userwidgets just to be able to animate a fade.
Change 3761682 by nick.darnell
Athena - Introducing a way to interrupt the request to scroll and item into view. In cases where you're animating, quickly showing and hiding, with the item widgets unavailable for a few frames, you enter cases where the deferred navigation is resolved after you've canceled showing a dialog stealing focus.
Change 3761416 by Ben.Zeigler
#jira UE-52287 Prevent cook metadata like DevelopmentAssetRegistry.bin from being packed into a shipping game, by moving it into a Metadata subdirectory and updating deployment scripts to avoid that directory.
Right now it doesn't package them at all, we could change it to package them as Debug Non-UFS if desired
Change it so the asset audit UI will only load DevelopmentAssetRegistry.bin files, the cooked registry files don't have enough information any more to be useful
Remove ability for runtime game to load DevelopmentAssetRegistry.bin, this ended up not being useful
Change 3750998 by Ethan.Geller
#jira FORT-60191 Allow -audiomixer command line arg to work on all platforms.
Change 3749540 by Marc.Audy
SignificanceManager now takes viewpoints in as TArrayView instead of const TArray&
Change 3748102 by Marc.Audy
Allow cheat cvars to work in Test builds by default
Can be overriden by defining ALLOW_CHEAT_CVARS_IN_TEST as 0 in Target.cs files
Change 3744756 by Bart.Hawthorne
Upgrade Oodle to version 2.5.5. Also, iOS, Android, and Switch platforms have been added. The new dictionary has been generated with old and local captures.
Change 3741168 by Max.Preussner
MediaUtils: Fixed movies not playing properly in Shipping builds
Change 3739256 by Jian.Ru
Set distance field self-shadow bias without recreating all render states
Change 3730756 by Ben.Woodhouse
HISM optimization:
Gil's change to skip trees with only one level of hierarchy (working around badly tuned content issues)
Change vert threshold to 2K.
1-2ms renderthread win without impacting GPU when rendering point lights
Change 3724029 by Zak.Middleton
Increase allowed time for movement substep duration. Don't want to lower between 2 iterations, as this is not used much in practice other than deflection and movement mode changes, and that will change behavior (lose momentum). This new setting will absorb longer hitches in the common case (moving without collision or falling).
Change 3723985 by Marc.Audy
SignificanceManager PostSignificanceUpdate functions can now be executed sequentially on the game thread as well as concurrently in the parallel for (old behavior)
Change 3722910 by Jian.Ru
Amortize shadow cache update caused by resolution change
Changed to use view distance vs. view space z when calculating whole scene shadow resolution which is less sensitive to camera rotation
Change 3718247 by Yenal.Kal
Fixed the bug where the gameplay effect durations can show incorrect values after rejoin or after server time drifting away from the client.
Change 3716343 by Jamie.Dale
Adding Korean and Turkish to the localization automation
Change 3710534 by Uriel.Doyon
Texture streaming optimization where a maximum texture resolution for each level streaming data is computed per view.
This is used to cull irrelevant levels and reduce the async task number of iterations.
The culled size is defined by the new r.Streaming.MinLevelTextureScreenSize.
This requires to remove primitives with big UV density from the level data.
Those primitives get moved to the dynamic lists.
This is controlled by r.Streaming.MaxTextureUVDensity
Change 3707207 by David.Ratti
Remove look ahead-vectors prediction in FNetViewer. This (requires) a line trace which is not desirable or really accurate anymore. This saves us a line trace per connection per multicast rpc.
unify reliable multicast rpc handling: these now do relevancy checks and are not sent to non relevant clients
Change 3706272 by Thomas.Sarkanen
Added utility/math functions to aid in optimizing anim blueprints
Added VectorLengthXY to get the 2D length of a 3D vector. Avoids unecessary conversions.
Added polar->cartesian->polar conversion helper functions for expensive frequently-used anim graph functionality.
Change 3706159 by David.Ratti
PlayerState/ASC replication optimizations from Polge: this puts the net update frequnecy on player state back to 1hz while forcing netupdates on the player state actor when the ability system component needs to update
Change 3692891 by David.Ratti
Optimizations for UNetConnection::ClientHasInitializedLevelFor: build acceleration map of actor outer's (ULevels) -> Visibility bool. Existing logic stays the same.
Change 3691392 by Aaron.McLeran
#jira UE-50628 Fix audio trying to sync load bulk data with EDL enabled
- Fix log error in BulkData.cpp
- Make the first stream chunk be force inline payload in bulk data flags so it loads immediately vs in async IO system
- Make audio stream chunks get as close to 256 k chunks as it can, zero-pad rest to be 256 k aligned
- Fix up DDC key, serialize AudioDataSize separately from chunk DataSize
Change 3682683 by Zak.Middleton
Add bOnlyTickMontageOnDedicatedServer variable to AnimInstance, to avoid anim bp updates on dedicated server. Turn on to fix hitching from queued ServerMove() calls, and some free perf during all montages on the server.
Change 3678771 by Ori.Cohen
Added the ability to turn on stack walk during hitching vs lightweight stats
Change 3676363 by Ori.Cohen
Added the ability to get callstacks as part of hitch detection
Change 3674877 by Keith.Judge
Move definition of GFailedToFindParamCollectionBufferQueue to ShaderBaseClasses.cpp so that all targets can successfully compile.
Change 3672515 by Bob.Tellez
Added code to play wind particle effects
Change 3670909 by Zak.Middleton
Fixed ForcePositionUpdate() not calling CheckJumpInput(). Added "p.NetForceClientServerMoveLossPercent" cvar to simulate loss of client->server movement RPCs (without hosing the rest of networking).
[CL 3791033 by Marc Audy in Main branch]
2017-12-05 21:57:41 -05:00
// Warn if a component already exists with the same name.
const bool bNameAlreadyExists = HandlerComponents . ContainsByPredicate ( [ NewHandler ] ( const TSharedPtr < HandlerComponent > & Component )
{
return Component - > GetName ( ) = = NewHandler - > GetName ( ) ;
} ) ;
if ( bNameAlreadyExists )
{
UE_LOG ( PacketHandlerLog , Warning , TEXT ( " Packet handler already contains a component with name %s. " ) , * NewHandler - > GetName ( ) . ToString ( ) ) ;
return ;
}
2015-07-08 23:03:46 -04:00
HandlerComponents . Add ( NewHandler ) ;
NewHandler - > Handler = this ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
2021-09-29 17:45:16 -04:00
AddHandlerDel . ExecuteIfBound ( NewHandler ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
if ( ! bDeferInitialize )
{
NewHandler - > Initialize ( ) ;
}
2015-07-08 23:03:46 -04:00
}
2018-10-29 10:01:28 -04:00
TSharedPtr < HandlerComponent > PacketHandler : : AddHandler ( const FString & ComponentStr , bool bDeferInitialize /*=false*/ )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
TSharedPtr < HandlerComponent > ReturnVal = nullptr ;
if ( ! ComponentStr . IsEmpty ( ) )
{
FString ComponentName ;
FString ComponentOptions ;
for ( int32 i = 0 ; i < ComponentStr . Len ( ) ; i + + )
{
TCHAR c = ComponentStr [ i ] ;
// Parsing Options
if ( c = = ' ( ' )
{
// Skip '('
+ + i ;
// Parse until end of options
for ( ; i < ComponentStr . Len ( ) ; i + + )
{
c = ComponentStr [ i ] ;
// End of options
if ( c = = ' ) ' )
{
break ;
}
// Append char to options
else
{
ComponentOptions . AppendChar ( c ) ;
}
}
}
// Append char to component name if not whitespace
else if ( c ! = ' ' )
{
ComponentName . AppendChar ( c ) ;
}
}
if ( ComponentName ! = TEXT ( " ReliabilityHandlerComponent " ) )
{
int32 FactoryComponentDelim = ComponentName . Find ( TEXT ( " . " ) ) ;
if ( FactoryComponentDelim ! = INDEX_NONE )
{
// Every HandlerComponentFactory type has one instance, loaded as a named singleton
FString SingletonName = ComponentName . Mid ( FactoryComponentDelim + 1 ) + TEXT ( " _Singleton " ) ;
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UHandlerComponentFactory * Factory = FindFirstObject < UHandlerComponentFactory > ( * SingletonName , EFindFirstObjectOptions : : NativeFirst | EFindFirstObjectOptions : : EnsureIfAmbiguous ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
if ( Factory = = nullptr )
{
UClass * FactoryClass = StaticLoadClass ( UHandlerComponentFactory : : StaticClass ( ) , nullptr , * ComponentName ) ;
if ( FactoryClass ! = nullptr )
{
Factory = NewObject < UHandlerComponentFactory > ( GetTransientPackage ( ) , FactoryClass , * SingletonName ) ;
}
}
if ( Factory ! = nullptr )
{
ReturnVal = Factory - > CreateComponentInstance ( ComponentOptions ) ;
}
else
{
UE_LOG ( PacketHandlerLog , Warning , TEXT ( " Unable to load HandlerComponent factory: %s " ) , * ComponentName ) ;
}
}
// @todo #JohnB: Deprecate non-factory components eventually
else
{
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3497164)
#lockdown Nick.Penwarden
#rb none
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3433074 by Matt.Kuhlenschmidt
Fix crash when clicking on certian tutorial blueprints.
#jira UE-44593
Change 3433075 by Matt.Kuhlenschmidt
Remove hittest grid log spam. The underlying problem causing this has been fixed
Change 3433077 by Matt.Kuhlenschmidt
Fix lighting becoming unbuilt when mesh painting
#jira UE-44837
Change 3433081 by Matt.Kuhlenschmidt
PR #3553: Crashfix for static array properties (Contributed by Pierdek)
Change 3433104 by Alexis.Matte
Make sure re-import skeletal mesh follow the import morph option
#jira UE-42846
Change 3434825 by Matt.Kuhlenschmidt
Fix crash when GC happens while the vr editor radial menu is open.
Change 3434831 by Matt.Kuhlenschmidt
Added missing file
Change 3434868 by Shaun.Kime
If you have a reroute node between a Material Function texture input and its usage, the parent material will fail to resolve the reroute node.
#jira ue-44670
Change 3434998 by Alexis.Matte
Meshes editors material/section panel are now fully transactional
- Staticmesh editor: section material slot, section cast shadow, section collision, material slot instance, material slot name
- Skeletal mesh editor: material slot instance, material slot name
Also fix some transaction description
#jira UE-44462
Change 3435195 by Jamie.Dale
Fixed incorrect handling of some LTR scripts that require shaping
These scripts need to go through HarfBuzz, and this also fixes a case where HarfBuzz wasn't applying font scale correctly.
#jira UE-44767
Change 3435199 by Jamie.Dale
Fixed some crashes/artifacts with bidirectional text
It was possible for a line to compute an incorrect range, which could cause crashes or other highlighting issues. The highlighting logic has also been updated as the old code didn't handle all bidirectional cases correctly.
Change 3435200 by Jamie.Dale
Fixed a grapheme cluster metrics issue in the font editor viewport
The viewport also now respects the default shaping method CVar.
Change 3435771 by Alexis.Matte
Fix degenerated bounds calculation for skeletalmesh when the skeleton is remove from a re-import
(PhysicAsset API change, adding 1 function)
#jira UE-44609
Change 3436856 by Jamie.Dale
Added some missing Unicode block ranges
Change 3436914 by Jamie.Dale
Adding some missing combining character ranges to the text shaper
Change 3436923 by Alexis.Matte
PR #3463: Get bounds for all triangles, not just the first one. WedgeIndex was . (Contributed by DaveC79)
#jira UE-43764
Change 3436948 by Jamie.Dale
Updated the Portal to use the predefined Unicode block ranges
Change 3436961 by Max.Chen
Sequencer: Show camera shake/anim track menus even if there aren't any assets.
Change 3437244 by Max.Chen
Sequencer: Clear locked cameras when releasing Sequencer.
#jira UE-44967
Change 3437515 by Arciel.Rekman
UBT: improvements for LocalExecutor.
- Larger number of parallel jobs on 16GB+ machines.
- Use WaitForExit() instead of polling.
- Tested on Linux and Mac.
Change 3437629 by Matt.Kuhlenschmidt
Improve asset import data display in static and skeletal meshes
Change 3438047 by Arciel.Rekman
Fix overlapping ranges being passed to memcpy().
Change 3438822 by Yannick.Lange
ViewportInteraction: Move gizmo handle files to make them private.
Change 3438906 by Matt.Kuhlenschmidt
PR #3556: Git Plugin: fix new option "init Git LFS" that make assets read-only (master/UE4.17) (Contributed by SRombauts)
Change 3438907 by Matt.Kuhlenschmidt
PR #3565: add -quality option to buildlighing commandlet (Contributed by kayama-shift)
Change 3438908 by Matt.Kuhlenschmidt
PR #3558: UE-44862: Always update SColorPicker color on OK button (Contributed by projectgheist)
Change 3439393 by Matt.Kuhlenschmidt
Force highest LOD for highres screenshots
Change 3439819 by Matt.Kuhlenschmidt
Turned FAssetData into a struct for some upcoming script exposure of FAssetData
Change 3439949 by Arciel.Rekman
Fixed selection logic for the UE4_LINUX_USE_LIBCXX environment variable.
- Allows disabling libc++ by setting the variable to 0.
- Pull request #3576 contributed by jared-improbable.
Change 3441078 by Jamie.Dale
The culture/language/locale console commands are now available in all build configs
Change 3441109 by Jamie.Dale
Text containing surrogate pairs now runs through HarfBuzz when shaping in Auto mode
This is needed as the kerning-only shaping code assumes that everything is within the BMP
Change 3441275 by Matt.Kuhlenschmidt
Disable spinning on location and scale. These dont work because we have no notion of infinite spinning
Change 3442748 by Yannick.Lange
ViewportInteraction: Remove unused console variables.
Change 3442775 by James.Golding
Add support for editing MaterialFunctions to MaterialEditingLibrary
Pull Material recompile/update code into UMaterialEditingLibrary::RecompileMaterial
Pull MaterialFunction update code into UMaterialEditingLibrary::UpdateMaterialFunction util
Move RebuildMaterialInstanceEditors to UMaterialEditingLibrary
Added test content for Material/MaterialFunction editing
Add needed BlueprintReadWrite to expressions (constants, function input/output)
Expose UMaterialExpressionMaterialFunctionCall::SetMaterialFunction to BP, rename old func (which takes old function) to SetMaterialFunctionEx, also expose GetInputNameWithType
Change 3442779 by James.Golding
Fix header order
Change 3442817 by Yannick.Lange
ViewportInteraction: Add can execute checks for level editor commands.
Change 3443038 by Michael.Dupuis
#jira UE-43377: When you select a foliage actor we will move all instance contained in it to the new level as we can't move a foliage actor
Only permit moving foliage instance if there is some selected
Change 3443855 by Michael.Dupuis
#jira UE-44885: Unregister from PerModuleDataObjects when the object is destroyed
Change 3446096 by Max.Chen
Sequencer: Add OnFinished() event when a level sequence completes playback
#jira UE-45173
Change 3446097 by Max.Chen
Sequencer: Evaluate one last time before the sequence is torn down and reset
#jira UE-45174
Change 3446242 by Jamie.Dale
Fixed caret not appearing in empty text layouts
Caret selections have no range, and therefore have no width
Change 3446361 by Matt.Kuhlenschmidt
Fix WITH_EDITOR only functions causing generated code compile errors when the all functions on the class are WITH_EDITOR
Change 3446457 by Alexis.Matte
Polish the speed tree import dialog
#jira UE-44963
Change 3446946 by Michael.Trepka
Modified FWindowsWindow::GetRestoredDimensions to return correct window position for normal windows for which GetWindowPlacement returns position in workspace coordinates
#jira UE-37934
Change 3447543 by Arciel.Rekman
Reduce VMAs on Linux.
- Trades off increased address space (VIRT in terms of ps/htop) for smaller number of distinct mappings (VMAs, virtual memory areas).
This decreases possibility to run into vm.max_map_count limit on Linux.
- Tested on Linux and Mac.
Change 3448468 by Arciel.Rekman
Fix race condition during creation of GMalloc.
- On Mac GMalloc can be created on two different thread that are racing with each other - app's main thread and a system thread.
Change 3449012 by Max.Chen
Sequencer: Add time to transform, color and vector key structs so that key times are editable from the key editors.
#jira UE-45089
Change 3449018 by Max.Chen
Sequencer: Add OnCameraCut event that fires when there is a camera cut.
#jira UE-45137
Change 3449195 by Max.Chen
Sequencer: Add setting for limit scrubbing to playback range.
#jira UE-43502
Change 3449198 by Max.Chen
Sequencer: Reorder hierarchical bias so that group priority takes precedence.
Change 3449217 by Max.Chen
Sequencer: Add setting to activate realtime viewports when in sequencer.
Change 3449219 by Max.Chen
Sequencer: Focus on search boxes when opened.
Change 3449238 by Max.Chen
Sequencer: Assign actor should replace the actor itself after it has updated all the components. Also, replace components be fullname rather than by class.
Change 3449239 by Max.Chen
Sequencer: Fix offsets when moving multiple sections. Dragging should be clamped to the bounds that any of the selected sections hits against the unselected sections.
Change 3449241 by Max.Chen
Sequencer: Restore section selection after full tree rebuild.
Change 3449279 by Max.Chen
Sequencer: Set movie scene capture frames only when not using custom frames. This allows the user entered frame numbers to persist in config, rather than overwriting them when doing a "Render Shot"
Change 3449280 by Max.Chen
Sequencer: Spawn in the persistent level. Otherwise, they get spawned into whatever sublevel is current.
#jira UE-44552
Change 3449294 by Max.Chen
Sequencer: Null check for sequencer ed mode crash.
Change 3449297 by Max.Chen
Sequencer: Fix delay in sliding values. Mark changed when sliding values. Mark refresh immediately when committing values since OnValueChanged will be called and needs to have the correct value that was refreshed immediately.
#jira UE-42866
Change 3449542 by Max.Chen
Sequencer: Fix scrubber hit testing so that the time scrubber is really favored over the playback ranges.
#jira UE-44569
Change 3451507 by Matt.Kuhlenschmidt
Fix extra slate uv coords not functioning on ES2
Change 3451510 by Matt.Kuhlenschmidt
PR #3595: Fixed wrong colour for level status (Contributed by ronve)
Change 3451529 by Alexis.Matte
fbx scene importer: Make sure we set INVALID_UNIQUE_ID to node that has no attribute.
#jira UE-34410
Change 3451611 by Yannick.Lange
ViewportInteraction: Dragging gizmo without second pass for snapped calculations.
Change 3452134 by Jamie.Dale
Fixed constant font cache flushing if a widget had no font set
Change 3452239 by Jamie.Dale
Fixed constant font measure flushing if a widget had no font set
Change 3452243 by Jamie.Dale
Removed deprecated code for creating fonts from bulk data
Change 3452277 by Jamie.Dale
The concept of "stale" composite fonts is now editor-only
Change 3452358 by Alexis.Matte
Fbx scene importer: Do not remove existing attribute reference from the blueprint if the reimport of the associate mesh attribute is not tick.
#jira UE-45232
Change 3452678 by Max.Chen
Sequencer: Fix crash on export if there's no shot data.
Change 3453057 by Matt.Kuhlenschmidt
Exposed asset exporting to script
Change 3453782 by Andrew.Rodham
Sequencer: Fixed deterministic cooking issues with movie scene data
- Movie scene signatures are now initialized in PostInitProperties
- A warning is now presented when attempting to cook old data that was never serialized with a signature.
- Removed redundant legacy data upgrade logic that could dirty level sequences on load.
#jira UE-44912
Change 3453788 by Yannick.Lange
ViewportInteraction: Custom scene proxy for gizmo handles.
Change 3453938 by Max.Chen
Sequencer: Hotkeys (shift , and shift .) to step to next/previous shot
#jira UE-45119
Change 3454058 by Michael.Dupuis
Fixed StaticAnalysis
Change 3454077 by Max.Chen
Sequencer: Fix not saving the pre-animated track value when creating a track/key.
On pre object change, broadcast property change so that a track or key can be created. That track/key needs to be evaluated immediately so that the pre-animated state can be saved properly. This is done now with RefreshAllImmediately and is only called when a track has been created. Also, added a return value for OnKeyProperty, so that it's known what changed in particular (ie. track created, track modified, etc)
Also, fixed transform keying so that if a transform track already exists for the object or the scene component, the existing track is used.
#jira UE-45130
Change 3454108 by Nick.Darnell
UMG - Fixing the WIC to properly record cursor delta so that scrollbars work.
Change 3454109 by Jamie.Dale
Cache the text layout source info in non-shipping builds so you can inspect it in the debugger
Change 3454202 by Matt.Kuhlenschmidt
Fix bogus error message about the number of usable texture coordinates on ES2 when compiling a UI domain material
Change 3454390 by Yannick.Lange
Fix creating a plugin in a C++ project opens a second instance of Visual Studio. Use SourceCodeAccessor to open solution when necessary.
#jira UE-45035
Change 3454564 by Matt.Kuhlenschmidt
#rnx Fix deprecation warnings
Change 3455471 by Yannick.Lange
ViewportInteraction: Fix entering and exiting VR Mode disables gizmo in desktop editor viewport.
#jira UE-44965
Change 3456183 by Max.Chen
Sequencer: Auto key, auto track refactor.
Auto key - create a key when the property changes and there's an existing track.
Auto track - create a track when the property changes. This is only exposed in the level sequence editor.
All - create a key and a track when the property changes. This is only exposed in VR Editor.
None - do nothing.
#jira UE-43469
Change 3456349 by Andrew.Rodham
Sequencer: Only perform legacy signature checks on instances, and only where signatures match the CDO
Change 3456678 by Alexis.Matte
Allow to add null level instance override material via the advance material array. But still limit the override material number to the mesh material number.
#jira UE-45306
Change 3456945 by Max.Chen
UMG: Add restore state to 2d transform section.
#jira UE-45372
Change 3457196 by Arciel.Rekman
Linux: serialize allocations from the memory pool.
Change 3458434 by Max.Chen
Sequencer: Remove obsolete set tick prerequites functions.
Change 3458671 by James.Golding
Added MIC editing support to MaterialEditingLibrary
Fix static analysis warning
Change 3458888 by Matt.Kuhlenschmidt
PR #3615: More detailed log messages for debugging warnings/errors (Contributed by projectgheist)
Change 3458893 by Matt.Kuhlenschmidt
PR #3583: UE-44960: Delta value wasn't being used (Contributed by projectgheist)
Change 3458895 by Matt.Kuhlenschmidt
Fix typo
Change 3458902 by Matt.Kuhlenschmidt
PR #3607: Improved InputKeySelector functionality (Contributed by projectgheist)
Change 3458917 by Matt.Kuhlenschmidt
Fix crash with invalid object properties in the class picker
#jira UE-39000
Change 3458939 by Matt.Kuhlenschmidt
Fix compile error
Change 3458984 by andrew.porter
QAGame: Initial check in of sequencer smoke test map
Change 3459510 by Matt.Kuhlenschmidt
Fixed ensure when deleting a map that contains build data which also happens to be the currently loaded map.
#jira UE-45052
Change 3460985 by Max.Chen
Sequencer: Snap play time to keys now allows scrubbing between keys and snaps to key times within a certain screenspace tolerance.
#jira UE-45090
Change 3461698 by Arciel.Rekman
Avoid using ARRAY_COUNT in Vulkan.
- Sometimes those arrays can have no extensions whatsoever, and it is illegal to declare a 0 element C array.
Change 3462053 by Max.Chen
Sequencer: Show sequencer spawnables in the world outliner and add the icon overlay for spawnables.
#jira UE-43470
Change 3462139 by Max.Chen
Property Editor: Add objects to FPropertyAndParent
Change 3462202 by Arciel.Rekman
Fix FSocket::Recv() blocking with Peek when there's no data.
Change 3462253 by Nick.Darnell
Slate - New Clipping System
Clipping is now a stateful choice made during composition of the slate hierarchy. Previously every widget got to respect or modify the clipping rect on an as needed basis. The problem was that clipping was only allowed in the layout space of the widget, and it wasn't possible to properly clip elements with render transforms. The new system permits all kinds of transforms on any widget, and they will all be clipped correctly. It tries to use Scissor Rects as they are much cheaper, but will switch over to stenciling if need be to represent a complicated masking structure with several rotated clipping rects all needed to be combined together.
Here are the new clipping states a widget can have, almost all widgets are set to No. Only change it from No if your widget actually needs to clip, generally speaking most widgets don't need to clip.
/**
* This widget does not clip children, it and all children inherit the clipping area of the last widget that clipped.
*/
Inherit,
/**
* This widget clips content the bounds of this widget. It intersects those bounds with any previous clipping area.
*/
ClipToBounds,
/**
* This widget clips to its bounds. It does NOT intersect with any existing clipping geometry, it pushes a new clipping
* state. Effectively allowing it to render outside the bounds of hierarchy that does clip.
*
* NOTE: This will NOT allow you ignore the clipping zone that is set to [Yes - Always].
*/
ClipToBoundsWithoutIntersecting UMETA(DisplayName = "Yes - Without Intersecting (Advanced)"),
/**
* This widget clips to its bounds. It intersects those bounds with any previous clipping area.
*
* NOTE: This clipping area can NOT be ignored, it will always clip children. Useful for hard barriers
* in the UI where you never want animations or other effects to break this region.
*/
ClipToBoundsAlways UMETA(DisplayName = "Yes - Always (Advanced)"),
/**
* This widget clips to its bounds when it's Desired Size is larger than the allocated geometry
* the widget is given. If that occurs, it behaves like [Yes].
*
* NOTE: This mode was primarily added for Text, which is often placed into containers that eventually
* are resized to not be able to support the length of the text. So rather than needing to tag every
* container that could contain text with [Yes], which would result in almost no batching, this mode
* was added to dynamically adjust the clipping if needed. The reason not every panel is set to OnDemand,
* is because not every panel returns a Desired Size that matches what it plans to render at.
*/
OnDemand UMETA(DisplayName = "On Demand (Advanced)")
- Large API Change -
All FSlateDrawElement::Make_____ calls have been deprecated that involved passing in a clipping rect. You no longer should are passed a Clipping rect via OnPaint. You are still passed a rect, but this rect represents a Culling Rect, which is valuable if you need to just out right not paint things the user can't possibly see.
If you were previously trying to determine if you should cull widgets, by doing something like this,
if ( FSlateRect::DoRectanglesIntersect(MyClippingRect, CurWidget.Geometry.GetRenderBoundingRect()) )
That's no longer a good option since there are ways for widgets to ignore the culling bounds. You should convert anything like above to the one below,
if (!SWidget::IsWidgetCulled(MyCullingRect, CurWidget))
To assist in debugging efforts, there are several new debugging console flags in Slate,
Slate.ShowClipping 1 - Controls whether we should render a clipping zone outline. Yellow = Axis Scissor Rect Clipping (cheap). Red = Stencil Clipping (expensive).
Slate.DebugCulling 1 - Disables pushing clipping or stencil rects to the GPU, but continues to intersect culling rects, so that you can tell if a widget is properly culling children it can't possibly draw.
Slate.ShowTextDebugging 1 - Show debugging painting for text rendering.
I've added a new Experimental Feathering Option, it adds AA geometry around the outside of Box and Image brushes.
Slate.Feathering 1
If you're using RenderDoc or something similar, you can now enable render events for slate, so that you can better grok how we're batching and changing states for each UI render pass.
Slate.EnableDrawEvents 1
#jira UE-4659
#rn
Change 3462714 by Nick.Darnell
Fixing a few more compiler issues with the clipping changes.
Change 3462726 by Max.Chen
Switch OnEditStructChildContentsChanged to use FObjectWriter instead of FMemoryWriter which supports serializeing UObjects. This fixes a crash when adding actor array elements to a user defined event struct.
#jira UE-45431
Change 3462801 by Nick.Darnell
Adding a UMG dependency to EngineTestBuild.
Change 3462914 by Max.Chen
Sequencer: Fix regression where spawnables aren't getting saved. Caused by 3407138
#jira UE-30007
#jira UE-39003
Change 3462946 by Nick.Darnell
Automation - Tweaking the UI automation tests converting them over to use the new UI Screenshot automation test.
Automation - Adding a blur widget test.
Change 3462987 by Matt.Kuhlenschmidt
Back out changelist 3458893
Change 3464774 by Matt.Kuhlenschmidt
PR #3629: Bugfix: Missing small icon in Project Launcher profile editor (Contributed by aarmbruster)
Change 3464785 by Nick.Darnell
Fixing some clipping stuff in the editor.
Change 3464830 by andrew.porter
QAGame: Second pass on sequencer smoke test map
Change 3464902 by Nick.Darnell
Loading - Adding some additional checks to the the loading code to ensure we're on the main thread. Additionally adding a fix from UDN that prevents deadlocks in the rare case a user hits Alt+Tab in a fullscreen game while in a hard loading screen.
Change 3464988 by Max.Chen
Sequencer: Add attenuation settings for attached audio components.
#jira UE-33080
Change 3465024 by Nick.Darnell
MoviePlayer - Impoving the playback mode displaynames.
Change 3465074 by Arciel.Rekman
Fix shadowing issues of GraphicsPSOInit.
Change 3465097 by Matt.Kuhlenschmidt
Some refactoring of the details panel
Exposed new methods of adding a struct on scope to a details panel and have it work properly with customizations. The scruct on scope has a "fake" ustructproperty that allows the details panel to show the whole struct not just an individual property.
Refactored the API for adding rows to details panels to make it more consistent\
AddChildCustomBuilder->AddCustomBuilder
AddChildGroup->AddGroup
AddChildContent->AddCustomRow
AddChildPropert->AddProperty
AddChildStructure->AddExternalStructureProperty
AddStructure->AddAllExternalStructureProperties
AddExternalProperty->AddExternalObjectProperty or AddExternalStructureProperty
Change 3465186 by Max.Chen
Sequencer: Save the BindingID in the pre animated token producer so that it can be destroyed properly. This fixes a bug where the default state of a spawnable isn't saved.
#jira UE-43780
Change 3465315 by Matt.Kuhlenschmidt
Fix Fortnite and Orion details panel customization warnings
Change 3465424 by Nick.Darnell
Automation - Moving the step for setting the link to the automation reports to be set before we start the engine.
Change 3465488 by Nick.Darnell
Automation - Forcing textures to load before taking screenshot, so that the scene gets another opportunity to render before we render with Slate. This should fix the Blur UI Test.
Change 3466277 by Arciel.Rekman
Linux: fix window drift when dragging (UE-40380).
- Change by Cengiz Terzibas.
Change 3466370 by Nick.Darnell
UMG - Fixing the colors for the resize handle in the designer.
Change 3466372 by Nick.Darnell
UMG - Fixing the ruler ticks sometimes not being drawn.
Change 3466374 by Nick.Darnell
UMG - Fixing the designer showing multiple options for sequencer.
Change 3466377 by Nick.Darnell
UMG - Cleaning up some clipping bits.
Change 3467025 by Andrew.Rodham
Re-saving assets that contain legacy (<4.15) movie scene data to remove deterministic cook warning.
If conflicts arise during merging of these assets, please ignore the changes made in dev-editor, and accept game-side changes.
(CIS step 62283298, jobId 7773146)
(CIS step 62283297, jobId 7773146)
Change 3467099 by Max.Chen
Fix GetObjectPropertyClass ensure logic. This was returning UObject::StaticClass when valid.
Change 3467172 by Max.Chen
Sequencer: Evaluation optimizations. Also, fixes subsequences not getting expired, leaving dangling spawnables.
#jira UE-43690
Change 3467192 by Matt.Kuhlenschmidt
Fix transactions getting stuck in the color grading controls. This prevents PIE from working properly and causes shutdown crashes
#jira UE-45527
Change 3467251 by Yannick.Lange
ViewportInteraction: Fix scale and rotation snap while dragging with two lasers.
#jira UE-43489
Change 3467331 by Matt.Kuhlenschmidt
Fix D3D shader compiler hard coding shader path and not giving proper warnings when it cannot find the shaders
Change 3467335 by Matt.Kuhlenschmidt
Remove DarkStyle attribute from SNumericEntryBox and allow a spin box style to be passed to it.
Change 3467558 by Max.Chen
Scene Outliner: Generic support to add default columns to a scene outliner.
Change 3467565 by Jamie.Dale
Removing old screenshot data for test
Change 3467589 by Nick.Darnell
Editor - Random cleanup.
Change 3467596 by Nick.Darnell
Progress Bar - Exposing Border Padding to UMG.
Change 3467600 by Nick.Darnell
Slate - Adjusting the rendering of the splitter, previously it could be off by a pixel or two, which becomes more apparent now with the clipping changes.
Change 3467601 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467662 by Nick.Darnell
Automation - Fixing a bug with the screenshot comparison tool not replacing (removing) the old screenshot data.
Change 3467674 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467737 by Max.Chen
Sequencer: Added OnMovieSceneBindingsChanged delegate
Change 3468053 by tim.gautier
QAGame: Updating Editor Smoke Map
- Updated landscapes into Stations for testing
- Added Foliage Sublevel
Change 3468194 by Arciel.Rekman
Linux: fix problems communicating with various STL-using libs.
- Stop hiding global new/delete signatures.
- Disable CEF3 since this change uncovers the problem with libcef.so not built to use bundled libpng.
Change 3468678 by Max.Chen
Sequencer: Set "Sequencer Actor" tag before setting the actor label so that the outliner refreshes after the actor has the tag.
Change 3469314 by tim.gautier
QAGame: Added Painted Foliage / Spline section to EditorSmoke map
Change 3469377 by Nick.Darnell
Slate - Fixing some warnings in a couple of sample games due to the clipping changes.
#rnx
Change 3469767 by Max.Chen
Sequencer: Outliner column and sequencer binding data
#jira UE-43470
Change 3469974 by Arciel.Rekman
Fix code projects not working in Linux installed build.
Change 3470082 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470174 by Nick.Darnell
Slate - Get the last widget in a widget path utility.
Change 3470176 by Nick.Darnell
UMG - User Widgets now have an easy way to know if they're part of or have been removed from the focused widget path, which is handy for doing effects.
Change 3470261 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470286 by Max.Chen
Sequencer: Scene Component's HiddenInGame now goes through the VisibilityTrack and the visibility template.
Change 3470366 by Nick.Darnell
Slate - We now version focus per user, that way during focus events, we can safely abort focus events and state transitions if someone interrrupts the active focus event with something new.
Change 3470649 by Matt.Kuhlenschmidt
Fix deprecation warnings
Change 3470695 by Matt.Kuhlenschmidt
Fixed typo
#jira UE-45580
Change 3470721 by Matt.Kuhlenschmidt
Fix static analysis
Change 3471254 by Michael.Dupuis
#jira UE-42952: Keep occlusion result per view
Change 3471287 by Nick.Darnell
UMG - Render Focus Rule now defaults to never.
Change 3471291 by Nick.Darnell
Slate - Fixing FSlateRenderer* change fallout.
Change 3471299 by Nick.Darnell
Slate - Fixing FSlateRenderer* change.
Change 3471323 by Nick.Darnell
Automation - Fixing automation and Static Analysis warning.
Change 3471413 by andrew.porter
QAGame: Added test content for anim blending and material parameteres to sequencer smoke level
Change 3471649 by Max.Chen
Sequencer: Modify the track when adding animation
#jira UE-45618
Change 3471659 by Matt.Kuhlenschmidt
Added a way to check if a movie is playing from the engine.
Prevented viewport redraws for canvas loading screens if a slate based loading movie is playing
Change 3471734 by Matt.Kuhlenschmidt
Added basic material hookup to USD. Similar to FBX it will find materials based on rules specified by the user in the import settings
Change 3472176 by Nick.Darnell
UMG - Improving the display of the +Track menu in sequencer for UMG. Renamed it from +Add, which is repetitve to +Track. Additionally, the dropdown now shows the currently selected widgets, as well as a submenu containing all the 'important' widgets, so we no longer populate that list with a ton of irrelevant widgets that are just Buton_1 - N, which is pointless in showing people, they'll never guess which is the right button.
Change 3472740 by Max.Chen
Sequencer: Add GetThisFrameMetaData accessor
Change 3472748 by Max.Chen
Sequencer: Added OnBeginScrubbing and OnEndScrubbing event delegates
Change 3472753 by Max.Chen
Sequencer: Add EMovieSceneDataChangeType parameter to OnMovieSceneDataChanged delegate
Change 3472870 by Nick.Darnell
Clipping - Fixing the deprecated tip for scissor rect boxes to be correct. Removing it's usage from UT.
Change 3473340 by Max.Chen
Scene Outliner: Add ability to register additional filters
Change 3473348 by Max.Chen
Details View: Make ForceRefresh virtual. Added accessors to delegates (ie. GetIsPropertyReadOnlyDelegate)
Change 3473441 by Max.Chen
Sequencer: Autokey Refactor Part 2.
Autokey is now a single toggleable state.
Allow Edits Mode has 3 states:
Allow All Edits - Allow any edits to occur, some of which may produce tracks/keys or modify default properties.
Allow Sequencer Edits Only - All edits will produce either a track or a key.
Allow Level Edits Only - Properties in the details panel will be disabled if they have a track.
#jira UE-45229
Change 3473670 by Nick.Darnell
Modules - The module manager no longer returns sharedptrs to IModuleInterfaces, this was the source of rare hard to track down crashes due to a shared ptr reference leak when GetModule was called on non-main threads. We now store a TUniquePtr internally, and only lease out raw pointers.
#rn
Change 3473711 by Nick.Darnell
Disabling the ensure in the module manager.
Change 3473747 by Max.Chen
Sequencer: Fix tooltip
Change 3474091 by Jamie.Dale
Added a warning when cooking a UFontFace that is outered to a UFont asset
These cause issues with iterative COTF, and should be split off into their own assets (as the UI has been asking people to do for several versions)
Change 3475052 by Yannick.Lange
VR Editor: Fix Crash when quitting the editor with VR Mode enabled. VR Editor was being enabled when saving the map on closing the editor.
#jira UE-45415
Change 3475054 by Yannick.Lange
Fix crash when adding a camera to the world in VR Mode the second time. The slate application did not reset when stop dragging in VR Mode, so the second time when starting to drag a camera out of the UI it would already by in a dragging state.
#jira UE-45574
Change 3475263 by Nick.Darnell
Fixing some additional cases of IModuleInteface SharedPtr usage.
Change 3475268 by Max.Chen
Sequencer: Set jumped state when looping playback. This fixes an issue where audio doesn't stop and restart when looped.
#jira UE-45654
Change 3475269 by Max.Chen
Scene Outliner: Additional filters should only apply to actor browsing mode
Change 3475407 by Nick.Darnell
Fixing some clipping / module shared ptr changes in the launcher code.
Change 3475542 by Max.Chen
Sequencer: Update thumbnail and section highlighting to use new clipping behavior.
#jira UE-45692
#jira UE-45689
Change 3475743 by Michael.Dupuis
#jira UE-45183: When updating phyx region take into account simple collision mip
Change 3475949 by Arciel.Rekman
Remove PhysX deoptimization (no longer needed).
- OR-24947 has been closed three months ago.
Change 3476022 by Michael.Dupuis
#jira UE-45560: Make sure we're not going out of range
Change 3476063 by Michael.Dupuis
#jira UE-45562: Do not try to unregister from static mesh if no static mesh is specified for the component
Change 3476168 by Michael.Trepka
Added handling of directory symlinks to FApplePlatformFile::IterateDirectory
#jira UE-43704
Change 3476172 by Nick.Darnell
Fixing a Imoduleinterface change.
Change 3476183 by Jamie.Dale
Exposing GoTo/ScrollTo to single-line editable text for API parity with multi-line editable text
Change 3476385 by Arciel.Rekman
Linux: handle symlinks when iterating directories.
Change 3476522 by Michael.Trepka
Solved a problem with Mac FMallocTBB::Malloc() returning nullptr for 0 bytes allocations, which is inconsistent with other platforms. On Mac we always scalable_aligned_malloc, which behaves differently than scalable_malloc, so for 0 bytes requests we allocate sizeof(size_t), which is exactly what scalable_malloc does internally in such case.
Change 3476806 by Nick.Darnell
UMG - Focus the designer after dropping a widget onto the surface.
Change 3476809 by Nick.Darnell
Curve Editor - Enable Clipping on the curve editor.
Change 3477475 by Nick.Darnell
Fixing a module interface shared ptr usage in UT.
Change 3477553 by Yannick.Lange
VR Editor: Removed AssetEditorPanelID and replaced it with TabManagerPanelID. A panel for AssetEditorPanelID was never created making it impossible to open an asset editor.
Change 3477734 by Yannick.Lange
VR Editor: Fix Warning: SetRelativeScale3D : Invalid Scale entered (X=inf Y=inf Z=inf). Resetting to 1.f. warning when adding CineCameraActor to World from Modes Panel. Make sure to not divide by zero when there is no boundary scale.
#jira UE-44933
Change 3477761 by Jamie.Dale
Some improvements to avoid loading the native .locres files twice when we don't need to
Change 3477780 by Nick.Darnell
PR #3250: Return correct VirtualUserIndex (Contributed by projectgheist)
Change 3477786 by Nick.Darnell
PR #3650: Changed TestNull to accept const pointers. (Contributed by e-agaubatz)
Change 3477795 by Nick.Darnell
PR #2844: UE-36936: Don't stretch container for Plugin Image (Contributed by projectgheist)
Change 3478092 by Nick.Darnell
PR #2341: Optional Middle Mouse Button panning in Graph Editor (Contributed by flipswitchingmonkey)
Engine Edit - Made some small changes to the enum type, and some naming.
Change 3478450 by Nick.Darnell
Fixing some uninitialized variable errors.
Change 3479827 by Andrew.Rodham
Sequencer: Addressed serialization issues with some struct types
Change 3479874 by Jamie.Dale
Fixed "NativeGameLanguage" not being used correctly during localization initialization
Change 3480012 by Andrew.Rodham
Sequencer: Fixed loading tagged properties as native for track identifiers
#jira UE-45823
Change 3480337 by Alexis.Matte
Fix morph target crash missing some valid index check
Change 3480804 by Alexis.Matte
Fix crash with ColorGradingMode custom detail
#jira UE-45638
Change 3480892 by Andrew.Rodham
Sequencer: Ensure that movie scene sequences know about the editor object version
#jira UE-45842
Change 3481073 by Nick.Darnell
Fix the shader compiler error from main in Slate.
Change 3481303 by Nick.Darnell
UMG - Fixing a bug with the drag handle not working correctly in HDPI mode.
Change 3481308 by Nick.Darnell
Slate - Tweaking the IsWidgetCulled logic to consider both the layout and rendering bounds. If we do this, we get a much more desireable outcome for people that want to animate widgets and such and plan to have temporary animations to move the widget offscreen, but want the layout bounds to anchor that widget in the visible frame so that it animates even when normally it would be culled b/c the render transform and therefore the renderbounds moved it completely outside the culling rect.
Change 3481629 by Max.Chen
Sequencer: Add Level Sequence Actor as an output for CreateLevelSequencePlayer()
#jira UE-45785
Change 3481899 by Yannick.Lange
VR Editor: Added debug modetoggle command with an event that is broadcasted whenever this happens. Currently this is used to show all the floating UIs of the UI system to debug without HMD using VREd.ForceVRMode.
Change 3481984 by Michael.Dupuis
#jira UE-45845: always validate if we have a static mesh before trying to access it as user can decide to not assign one and use the tools
Change 3482047 by Nick.Darnell
Slate - Adding some comments to IsWidgetCulled.
Change 3482110 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482136 by Jamie.Dale
The CamelCase break iterator now treats digits around character tokens as part of the identifier
Change 3482138 by Michael.Dupuis
#jira UE-45854: Properly unregister during undo operation
Change 3482150 by Michael.Dupuis
#jira UE-45845 : Add missing nullcheck for GetStaticMesh
Change 3482153 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482180 by Nick.Darnell
UMG - Widget Components do not need to define a widget class to be rendererd, they can have native slate widgets only. This was a regression from main.
Change 3482273 by Nick.Darnell
UMG - Tweaking some more things about the widget component box outline.
Change 3482308 by Alexis.Matte
Fixing morph target smooth group support. Do not call FillSkeletalMeshImportData more then once on FbxNode since this fonction is doing some conversion and change the FbxNode, applying those conversion twice do not return the same faces smooth group.
#jira UE-45696
Change 3482327 by Nick.Darnell
UMG - More tweaks to the WidgetComponent so both shows the box outline, but works in game and VR editor.
Change 3482705 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484245 by Max.Chen
Sequencer: Evaluate on end scrub. This fixes a bug where audio doesn't evaluate in a stopped position at the end of scrubbing, causing it to not stop all sounds. This fixes a bug introduced from 3365018 where evaluate on end scrub was removed.
#jira UE-45905
Change 3484263 by Max.Chen
Sequencer: Fix crash on forcing refresh of details panel on release.
#jira UE-45911
Change 3484431 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484474 by Alexis.Matte
Fix the morph target animation curve name matching.
#jira UE-20294
Change 3484475 by Alexis.Matte
When removing a LOD, make sure we remove all morph target data associate to the LOD.
Change 3484489 by Nick.Darnell
PR #3668: UE-45908: Cache debug line locations when performing a LineTraceMulti (Contributed by projectgheist)
#jira UE-45908
Change 3484692 by Nick.Darnell
Slate - Reverting a change from a game stream. All Arranged Children don't need to allocated 42 to begin with. Do need to initialize WidgetPaths better.
Change 3484703 by Nick.Darnell
Player Input - Making the input event loop for players obey EKeys::NUM_TOUCH_KEYS, rather than being set to Touch10, as the maximum touch input amount, to make supporting greater than 10 touches easier. Also making the seeding of keys use EKeys::NUM_TOUCH_KEYS.
#jira UE-43213
Change 3484918 by Jamie.Dale
Fixed font measuring regression with RTL text
RTL applies the character count to the next glyph, so it shouldn't process the end of the loop (this was how the older code used to work).
Change 3485718 by Nick.Darnell
Editor - Removing Super Search & User Feedback button.
Change 3485719 by Nick.Darnell
Portal - Removing SuperSearch.
Change 3485751 by Matt.Kuhlenschmidt
Fix crash accessing platformer game menu if the menu is open during a console based load
#jira UE-45950
Change 3486047 by Arciel.Rekman
Linux: add OpenEXR implementation (UE-40270).
#jira UE-40270
Change 3486467 by Max.Chen
Sequencer: Reset max tick rate when destroyed.
#jira UE-45956
Change 3486477 by Max.Chen
Sequencer: Refresh outliner when column is removed.
#jira UE-45891
Change 3486667 by Andrew.Rodham
Added missing include
Change 3486724 by Andrew.Rodham
Sequencer: Fixed curves with no default value, and no keys being evaluated and applied to properties
- Also fixed an edge case where a zero (but non-animated) channel could be applied to a final transform
Change 3486730 by Alexis.Matte
In the Auto-Reimport options, hide the mout point only for the default /Game/ folder
#UE-45684
Change 3486749 by Alexis.Matte
Make sure the parent window of the monitor directory browse folder is set properly
#jira UE-45682
Change 3486805 by Matt.Kuhlenschmidt
Additional safety against invalid objects being accessed by slate
Change 3486848 by Alexis.Matte
Make sure Monitor folder feature support root mount point map folder
During auto import, give priority to asset import factory over the scene import factory
#jira UE-45691
Change 3486879 by Andrew.Rodham
Removing obsolete QA assets
Change 3486950 by Nick.Darnell
PR #2281: Scrollbar missing features and SScrollbar fixes (Contributed by SNikon)
Review - made some adjustments from the original.
Change 3486954 by Nick.Darnell
Slate - Moving the STableViewBase over to the FOverscroll class, rather than it's own clone.
Change 3486967 by Nick.Darnell
Slate - Fixing some HDPI calculations for fitting new windows on screen, it was using the unscaled size of the widgets for fitting, when it needed to scale them up.
Change 3486970 by Andrew.Rodham
Sequencer: Delay mouse capture until drag for sequencer time slider
- Fixes context menus not opening as a result of mouse capture being taken on mouse down
#jira UE-45937
Change 3486984 by Andrew.Rodham
Sequencer: Improved blending type iconography
Change 3486996 by Nick.Darnell
UMG - Adding a way for games to opt-out of the slow widget path, to completely prevent them from being cooked.
UMG - The movie data is no longer cloned for each new instance that inhabits. It now keeps a reference to the now publically accessible movie scene data on the class instead.
Change 3487070 by Andrew.Rodham
Sequencer: Added graphics for key areas that represent empty space
Change 3487195 by Andrew.Rodham
Sequencer: Changed evaluation groups to always flush implicitly
- Due to the latent nature of blended token types, it's no longer safe to rely solely on execution token order between tracks
- This fixes an issue where events set in the PostEvaluation stage were executed before blended token actuation
Change 3487322 by Nick.Darnell
PR #2457: Add .gitdeps.xml-files for plugins support (Contributed by bozaro)
Change 3487363 by Nick.Darnell
PR #2481: Fix for packing of a project with users plugins (Contributed by yatagarasu25)
Change 3487439 by Nick.Darnell
PR #2642: Changed private to protected in SVirtualJoystick.h (Contributed by Skylonxe)
Change 3487500 by Arciel.Rekman
Removed LinuxNativeDialogs.
- No longer used; has been superceded by SlateDialogs since UE 4.8 (2 years ago).
Change 3487630 by Lauren.Ridge
Don't create Landscape Info Maps for Editor Preview Worlds or thumbnail worlds
#jira UE-44885
Change 3487864 by Matt.Kuhlenschmidt
Exposed the asset registry to blueprints and script. Works in editor scripts and runtime scripts
AssetRegistry is now a UInterface object.
Blueprint users can access various asset registry methods using the asset registry interface (via GetAssetRegistry) and various static helpers in the AssetRegistryHelpers object
C++ users should still continue to use IAssetRegistry.
Change 3487879 by Matt.Kuhlenschmidt
Renamed asset tools uobject helper to UAssetToolsHelpers
Change 3487926 by Lauren.Ridge
Fixing reset to default not showing up for custom widgets
#jira UE-44164
Change 3488184 by Matt.Kuhlenschmidt
PR #3656: Make References/Referencers List copyable (Contributed by user37337)
#jira UE-45763
Change 3488240 by Matt.Kuhlenschmidt
Fix compiler issue
Change 3488350 by Lauren.Ridge
Landscape info map transactional state is based on its world's transactional state
#jira UE-44885
#jira UE-46019
Change 3488412 by Matt.Kuhlenschmidt
Fix reset to default showing up in two different places for some customizations
Change 3488413 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488414 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488415 by Matt.Kuhlenschmidt
Missed file
Change 3488565 by Arciel.Rekman
Add pretty printers for gdb (UETOOL-1171).
- Committing shelf by Cengiz.Terzibas, with some modifications.
#jira UETOOL-1171
Change 3489094 by Nick.Darnell
Slate - The Slate RHI Renderer now caches the TextureLODGroups so that it can properly lookup the filtering of different texture groups that are set to Default, instead of a particular filter override on a texture.
Engine/Rendering - Simplifying some of the setup logic in TextureLODSettings so that code is shared for setting them up properly after loading from a config file.
Change 3489095 by Nick.Darnell
PR #2699: GameViewportClient - Added a method to allow setting the viewport cur. (Contributed by rfenner)
Review - Fixed spacing.
Change 3489108 by Matt.Kuhlenschmidt
Fix deprecation warning
Change 3489120 by Nick.Darnell
PR #3478: Fix possible UComboBoxString crash (Contributed by nakosung)
Change 3489147 by Andrew.Rodham
Sequencer: Adding return value to function to appease static analysis
- This function is never compiled, and if it is, it won't compile, but static analysis doesn't know that
Change 3489264 by Nick.Darnell
Testing - Finishing the thought behind an enum comment.
Change 3489265 by Nick.Darnell
PR #2750: UE-35164: Button padding (Contributed by projectgheist)
Change 3489267 by Nick.Darnell
PR #3645: UE-45464: Handle SSlider mouse interaction more accurately (Contributed by projectgheist)
Change 3489632 by Arciel.Rekman
Correctness changes to MallocPoisonProxy.
- Missing forwarding functions added. Incorrect comment removed.
- Change by Steve.Robb, doing here so it is in 4.17.
Change 3489689 by Arciel.Rekman
More MallocPoisonProxy changes I missed in previous CL.
Change 3489751 by Matt.Kuhlenschmidt
Moved editor performance settings out of per-project settings so they can be shared across projects
Change 3489837 by Lauren.Ridge
Keyboard shortcut for entering/leaving VR Mode is now Alt+V
Change 3491082 by Arciel.Rekman
Linux: better fix for the crash due to name collision (UE-46040).
- Put classes in Sequencer module into Sequencer namespace instead of SceneOutliner namespace.
- Undid change in the SceneOutliner module.
#jira UE-46040
Change 3491096 by Arciel.Rekman
Fix UAT compilation on the newest mono.
Change 3491240 by Max.Chen
Sequencer: Disable key button when allow level edits only is on.
#jira UE-46060
Change 3491406 by Yannick.Lange
Fix editor crashes when opening a project that includes a plugin with more than two custom Volume classes. This issue was caused because registering show volume commands is based on finding volume classes. Finding these classes at multiple times resulted in a mismatch of the returned array of volume classes because modules/plugins were still being loaded.
#jira UE-45806
Change 3491559 by Alexis.Matte
Make sure we use the good preview mesh when doing a preview
#jira UE-45963
Change 3491563 by Alexis.Matte
Fix crash with staticmesh editor LodLevel selection
Change 3491564 by Nick.Darnell
UMG - Fixing an offset with the grab handles in HDPI mode.
Change 3491595 by Nick.Darnell
Editor - Fixing a clipping artifact in the pin type dropdown in the blueprint editor.
Change 3491604 by Nick.Darnell
Back out changelist 3489265
Change 3491615 by Arciel.Rekman
Added malloc replay proxy (Linux only for now).
- Allows to dump malloc callstream (without regard to threads) and replay later to study the behavior of different mallocs and/or repro problems.
Change 3491684 by Arciel.Rekman
Added FMalloc functions I missed.
- Also moved function bodies into the .cpp file, this does not make a difference in performance in this case.
Change 3491692 by Matt.Kuhlenschmidt
Some minor fixes to the static mesh editor
- Fix UV combo button looking non-standard on the toolbar
- Fix a few combo buttons in the details panel looking too big.
Change 3491702 by Arciel.Rekman
Do not compile replay proxy-specific code when not used.
Change 3491717 by Michael.Dupuis
#jira UE-35083:
The component is now the owner of the PerInstanceRenderData instead of the proxy
Add an Update path to only update specified instances range
Always call BuildTreeIfOutdated so we have a standard code path to make sure static mesh are fully loaded before trying to build the tree
Moved the Instance Buffer aysnc to the base class, as it's not related to UHierarchicalInstancedStaticMeshComponent
Expose a new property to decide if we require dynamic instance buffer
Change 3491758 by Matt.Kuhlenschmidt
Fix crash on static mesh editor shutdown
Change 3491873 by Cody.Albert
Fixed clipping issue in Sequencer curve editor
#rnx
Change 3491956 by Matt.Kuhlenschmidt
Fix crash opening the Previewing sub-menu in the level editor settings menu
#jira UE-46095
Change 3492046 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492076 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492165 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492222 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492274 by Michael.Dupuis
#jira UE-46105: Fixed Clang warning
Change 3492338 by andrew.porter
QAGame: Testing ensure when submitting
Change 3492371 by Nick.Darnell
UMG - Reverting the animation sharing, cossed GLEO regressions in cooking. Will look for a better solution.
Change 3492462 by Matt.Kuhlenschmidt
Fix ensure checking in files through perforce
Change 3492491 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492505 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492517 by Jamie.Dale
The package localization ID is no longer used at all at runtime, and is now truly editor-only
This should have always been the case, but it was leaked into manifest/archives/PO files in 4.14, and while 4.15 removed it from PO files it was still present in the manifest/archives. This change removes it entirely (unless gathering editor-only data, and even then the PO file will still collapse the entries together for translation), and the deprecated 4.14 export behavior will now produce an error if you attempt to use it.
After taking this change you'll need to run a gather, import, and compile of your LocRes files to update your game localization to use the new localization IDs.
Change 3492630 by Nick.Darnell
UMG - Removing some extra cleanup code that's probably overkill and is causing a crash for uses of "Within" in class meta.
#jira UE-46124
Change 3492692 by Matt.Kuhlenschmidt
Fix drop shadows inheriting the outline color of the font. The outline should still appear but not have a different outline color from fill color
Change 3492714 by Matt.Kuhlenschmidt
Added outline with drop shadow to font automation test
Change 3492737 by Matt.Kuhlenschmidt
Fix linux
Change 3492992 by tim.gautier
Resaving Ocean Widget Blueprints / Sequences to resolve Legacy Sequence Data warnings
#jira UE-46132
Change 3493089 by Jamie.Dale
Ensure that the composite font of a font asset is flushed when the font object is GC'd
Change 3493322 by Jamie.Dale
Fixing null crash
#jira UE-45758
Change 3494467 by Andrew.Rodham
Fix Xbox warning
Change 3494852 by tim.gautier
QAGame: Changed streaming method of QA-EditorSmoke-Landscape to Always Loaded
Change 3494853 by Nick.Darnell
Another attempt at fixing the automation blueprint SA warning.
Change 3494896 by Arciel.Rekman
Fix possible null pointer access during Vulkan init.
- May fix static analysis warnings in UE-46142, although warnings seem to be referring to something else.
#jira UE-46142
Change 3494987 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495010 by Matt.Kuhlenschmidt
Adding additional logging to track down html5 issue
Change 3495212 by Michael.Dupuis
#jira UE-46143: Properly init the InstanceRenderData during the cooking phase (required by fortnite)
Change 3495536 by Jamie.Dale
Updating UGameEngine to call its Super::PreExit after performing its own teardown
This prevents UEngine cleaning up resources that UGameEngine still needs.
#jira UE-46159
Change 3495551 by Arciel.Rekman
Another attempt to fix analyzer problem (UE-46142).
Change 3495794 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495905 by Matt.Kuhlenschmidt
Fix USD crash when importing a meshwith no material
[CL 3499771 by Matt Kuhlenschmidt in Main branch]
2017-06-19 20:27:30 -04:00
FPacketHandlerComponentModuleInterface * PacketHandlerInterface = FModuleManager : : Get ( ) . LoadModulePtr < FPacketHandlerComponentModuleInterface > ( FName ( * ComponentName ) ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
2019-07-24 22:32:26 -04:00
if ( PacketHandlerInterface ! = nullptr )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3497164)
#lockdown Nick.Penwarden
#rb none
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3433074 by Matt.Kuhlenschmidt
Fix crash when clicking on certian tutorial blueprints.
#jira UE-44593
Change 3433075 by Matt.Kuhlenschmidt
Remove hittest grid log spam. The underlying problem causing this has been fixed
Change 3433077 by Matt.Kuhlenschmidt
Fix lighting becoming unbuilt when mesh painting
#jira UE-44837
Change 3433081 by Matt.Kuhlenschmidt
PR #3553: Crashfix for static array properties (Contributed by Pierdek)
Change 3433104 by Alexis.Matte
Make sure re-import skeletal mesh follow the import morph option
#jira UE-42846
Change 3434825 by Matt.Kuhlenschmidt
Fix crash when GC happens while the vr editor radial menu is open.
Change 3434831 by Matt.Kuhlenschmidt
Added missing file
Change 3434868 by Shaun.Kime
If you have a reroute node between a Material Function texture input and its usage, the parent material will fail to resolve the reroute node.
#jira ue-44670
Change 3434998 by Alexis.Matte
Meshes editors material/section panel are now fully transactional
- Staticmesh editor: section material slot, section cast shadow, section collision, material slot instance, material slot name
- Skeletal mesh editor: material slot instance, material slot name
Also fix some transaction description
#jira UE-44462
Change 3435195 by Jamie.Dale
Fixed incorrect handling of some LTR scripts that require shaping
These scripts need to go through HarfBuzz, and this also fixes a case where HarfBuzz wasn't applying font scale correctly.
#jira UE-44767
Change 3435199 by Jamie.Dale
Fixed some crashes/artifacts with bidirectional text
It was possible for a line to compute an incorrect range, which could cause crashes or other highlighting issues. The highlighting logic has also been updated as the old code didn't handle all bidirectional cases correctly.
Change 3435200 by Jamie.Dale
Fixed a grapheme cluster metrics issue in the font editor viewport
The viewport also now respects the default shaping method CVar.
Change 3435771 by Alexis.Matte
Fix degenerated bounds calculation for skeletalmesh when the skeleton is remove from a re-import
(PhysicAsset API change, adding 1 function)
#jira UE-44609
Change 3436856 by Jamie.Dale
Added some missing Unicode block ranges
Change 3436914 by Jamie.Dale
Adding some missing combining character ranges to the text shaper
Change 3436923 by Alexis.Matte
PR #3463: Get bounds for all triangles, not just the first one. WedgeIndex was . (Contributed by DaveC79)
#jira UE-43764
Change 3436948 by Jamie.Dale
Updated the Portal to use the predefined Unicode block ranges
Change 3436961 by Max.Chen
Sequencer: Show camera shake/anim track menus even if there aren't any assets.
Change 3437244 by Max.Chen
Sequencer: Clear locked cameras when releasing Sequencer.
#jira UE-44967
Change 3437515 by Arciel.Rekman
UBT: improvements for LocalExecutor.
- Larger number of parallel jobs on 16GB+ machines.
- Use WaitForExit() instead of polling.
- Tested on Linux and Mac.
Change 3437629 by Matt.Kuhlenschmidt
Improve asset import data display in static and skeletal meshes
Change 3438047 by Arciel.Rekman
Fix overlapping ranges being passed to memcpy().
Change 3438822 by Yannick.Lange
ViewportInteraction: Move gizmo handle files to make them private.
Change 3438906 by Matt.Kuhlenschmidt
PR #3556: Git Plugin: fix new option "init Git LFS" that make assets read-only (master/UE4.17) (Contributed by SRombauts)
Change 3438907 by Matt.Kuhlenschmidt
PR #3565: add -quality option to buildlighing commandlet (Contributed by kayama-shift)
Change 3438908 by Matt.Kuhlenschmidt
PR #3558: UE-44862: Always update SColorPicker color on OK button (Contributed by projectgheist)
Change 3439393 by Matt.Kuhlenschmidt
Force highest LOD for highres screenshots
Change 3439819 by Matt.Kuhlenschmidt
Turned FAssetData into a struct for some upcoming script exposure of FAssetData
Change 3439949 by Arciel.Rekman
Fixed selection logic for the UE4_LINUX_USE_LIBCXX environment variable.
- Allows disabling libc++ by setting the variable to 0.
- Pull request #3576 contributed by jared-improbable.
Change 3441078 by Jamie.Dale
The culture/language/locale console commands are now available in all build configs
Change 3441109 by Jamie.Dale
Text containing surrogate pairs now runs through HarfBuzz when shaping in Auto mode
This is needed as the kerning-only shaping code assumes that everything is within the BMP
Change 3441275 by Matt.Kuhlenschmidt
Disable spinning on location and scale. These dont work because we have no notion of infinite spinning
Change 3442748 by Yannick.Lange
ViewportInteraction: Remove unused console variables.
Change 3442775 by James.Golding
Add support for editing MaterialFunctions to MaterialEditingLibrary
Pull Material recompile/update code into UMaterialEditingLibrary::RecompileMaterial
Pull MaterialFunction update code into UMaterialEditingLibrary::UpdateMaterialFunction util
Move RebuildMaterialInstanceEditors to UMaterialEditingLibrary
Added test content for Material/MaterialFunction editing
Add needed BlueprintReadWrite to expressions (constants, function input/output)
Expose UMaterialExpressionMaterialFunctionCall::SetMaterialFunction to BP, rename old func (which takes old function) to SetMaterialFunctionEx, also expose GetInputNameWithType
Change 3442779 by James.Golding
Fix header order
Change 3442817 by Yannick.Lange
ViewportInteraction: Add can execute checks for level editor commands.
Change 3443038 by Michael.Dupuis
#jira UE-43377: When you select a foliage actor we will move all instance contained in it to the new level as we can't move a foliage actor
Only permit moving foliage instance if there is some selected
Change 3443855 by Michael.Dupuis
#jira UE-44885: Unregister from PerModuleDataObjects when the object is destroyed
Change 3446096 by Max.Chen
Sequencer: Add OnFinished() event when a level sequence completes playback
#jira UE-45173
Change 3446097 by Max.Chen
Sequencer: Evaluate one last time before the sequence is torn down and reset
#jira UE-45174
Change 3446242 by Jamie.Dale
Fixed caret not appearing in empty text layouts
Caret selections have no range, and therefore have no width
Change 3446361 by Matt.Kuhlenschmidt
Fix WITH_EDITOR only functions causing generated code compile errors when the all functions on the class are WITH_EDITOR
Change 3446457 by Alexis.Matte
Polish the speed tree import dialog
#jira UE-44963
Change 3446946 by Michael.Trepka
Modified FWindowsWindow::GetRestoredDimensions to return correct window position for normal windows for which GetWindowPlacement returns position in workspace coordinates
#jira UE-37934
Change 3447543 by Arciel.Rekman
Reduce VMAs on Linux.
- Trades off increased address space (VIRT in terms of ps/htop) for smaller number of distinct mappings (VMAs, virtual memory areas).
This decreases possibility to run into vm.max_map_count limit on Linux.
- Tested on Linux and Mac.
Change 3448468 by Arciel.Rekman
Fix race condition during creation of GMalloc.
- On Mac GMalloc can be created on two different thread that are racing with each other - app's main thread and a system thread.
Change 3449012 by Max.Chen
Sequencer: Add time to transform, color and vector key structs so that key times are editable from the key editors.
#jira UE-45089
Change 3449018 by Max.Chen
Sequencer: Add OnCameraCut event that fires when there is a camera cut.
#jira UE-45137
Change 3449195 by Max.Chen
Sequencer: Add setting for limit scrubbing to playback range.
#jira UE-43502
Change 3449198 by Max.Chen
Sequencer: Reorder hierarchical bias so that group priority takes precedence.
Change 3449217 by Max.Chen
Sequencer: Add setting to activate realtime viewports when in sequencer.
Change 3449219 by Max.Chen
Sequencer: Focus on search boxes when opened.
Change 3449238 by Max.Chen
Sequencer: Assign actor should replace the actor itself after it has updated all the components. Also, replace components be fullname rather than by class.
Change 3449239 by Max.Chen
Sequencer: Fix offsets when moving multiple sections. Dragging should be clamped to the bounds that any of the selected sections hits against the unselected sections.
Change 3449241 by Max.Chen
Sequencer: Restore section selection after full tree rebuild.
Change 3449279 by Max.Chen
Sequencer: Set movie scene capture frames only when not using custom frames. This allows the user entered frame numbers to persist in config, rather than overwriting them when doing a "Render Shot"
Change 3449280 by Max.Chen
Sequencer: Spawn in the persistent level. Otherwise, they get spawned into whatever sublevel is current.
#jira UE-44552
Change 3449294 by Max.Chen
Sequencer: Null check for sequencer ed mode crash.
Change 3449297 by Max.Chen
Sequencer: Fix delay in sliding values. Mark changed when sliding values. Mark refresh immediately when committing values since OnValueChanged will be called and needs to have the correct value that was refreshed immediately.
#jira UE-42866
Change 3449542 by Max.Chen
Sequencer: Fix scrubber hit testing so that the time scrubber is really favored over the playback ranges.
#jira UE-44569
Change 3451507 by Matt.Kuhlenschmidt
Fix extra slate uv coords not functioning on ES2
Change 3451510 by Matt.Kuhlenschmidt
PR #3595: Fixed wrong colour for level status (Contributed by ronve)
Change 3451529 by Alexis.Matte
fbx scene importer: Make sure we set INVALID_UNIQUE_ID to node that has no attribute.
#jira UE-34410
Change 3451611 by Yannick.Lange
ViewportInteraction: Dragging gizmo without second pass for snapped calculations.
Change 3452134 by Jamie.Dale
Fixed constant font cache flushing if a widget had no font set
Change 3452239 by Jamie.Dale
Fixed constant font measure flushing if a widget had no font set
Change 3452243 by Jamie.Dale
Removed deprecated code for creating fonts from bulk data
Change 3452277 by Jamie.Dale
The concept of "stale" composite fonts is now editor-only
Change 3452358 by Alexis.Matte
Fbx scene importer: Do not remove existing attribute reference from the blueprint if the reimport of the associate mesh attribute is not tick.
#jira UE-45232
Change 3452678 by Max.Chen
Sequencer: Fix crash on export if there's no shot data.
Change 3453057 by Matt.Kuhlenschmidt
Exposed asset exporting to script
Change 3453782 by Andrew.Rodham
Sequencer: Fixed deterministic cooking issues with movie scene data
- Movie scene signatures are now initialized in PostInitProperties
- A warning is now presented when attempting to cook old data that was never serialized with a signature.
- Removed redundant legacy data upgrade logic that could dirty level sequences on load.
#jira UE-44912
Change 3453788 by Yannick.Lange
ViewportInteraction: Custom scene proxy for gizmo handles.
Change 3453938 by Max.Chen
Sequencer: Hotkeys (shift , and shift .) to step to next/previous shot
#jira UE-45119
Change 3454058 by Michael.Dupuis
Fixed StaticAnalysis
Change 3454077 by Max.Chen
Sequencer: Fix not saving the pre-animated track value when creating a track/key.
On pre object change, broadcast property change so that a track or key can be created. That track/key needs to be evaluated immediately so that the pre-animated state can be saved properly. This is done now with RefreshAllImmediately and is only called when a track has been created. Also, added a return value for OnKeyProperty, so that it's known what changed in particular (ie. track created, track modified, etc)
Also, fixed transform keying so that if a transform track already exists for the object or the scene component, the existing track is used.
#jira UE-45130
Change 3454108 by Nick.Darnell
UMG - Fixing the WIC to properly record cursor delta so that scrollbars work.
Change 3454109 by Jamie.Dale
Cache the text layout source info in non-shipping builds so you can inspect it in the debugger
Change 3454202 by Matt.Kuhlenschmidt
Fix bogus error message about the number of usable texture coordinates on ES2 when compiling a UI domain material
Change 3454390 by Yannick.Lange
Fix creating a plugin in a C++ project opens a second instance of Visual Studio. Use SourceCodeAccessor to open solution when necessary.
#jira UE-45035
Change 3454564 by Matt.Kuhlenschmidt
#rnx Fix deprecation warnings
Change 3455471 by Yannick.Lange
ViewportInteraction: Fix entering and exiting VR Mode disables gizmo in desktop editor viewport.
#jira UE-44965
Change 3456183 by Max.Chen
Sequencer: Auto key, auto track refactor.
Auto key - create a key when the property changes and there's an existing track.
Auto track - create a track when the property changes. This is only exposed in the level sequence editor.
All - create a key and a track when the property changes. This is only exposed in VR Editor.
None - do nothing.
#jira UE-43469
Change 3456349 by Andrew.Rodham
Sequencer: Only perform legacy signature checks on instances, and only where signatures match the CDO
Change 3456678 by Alexis.Matte
Allow to add null level instance override material via the advance material array. But still limit the override material number to the mesh material number.
#jira UE-45306
Change 3456945 by Max.Chen
UMG: Add restore state to 2d transform section.
#jira UE-45372
Change 3457196 by Arciel.Rekman
Linux: serialize allocations from the memory pool.
Change 3458434 by Max.Chen
Sequencer: Remove obsolete set tick prerequites functions.
Change 3458671 by James.Golding
Added MIC editing support to MaterialEditingLibrary
Fix static analysis warning
Change 3458888 by Matt.Kuhlenschmidt
PR #3615: More detailed log messages for debugging warnings/errors (Contributed by projectgheist)
Change 3458893 by Matt.Kuhlenschmidt
PR #3583: UE-44960: Delta value wasn't being used (Contributed by projectgheist)
Change 3458895 by Matt.Kuhlenschmidt
Fix typo
Change 3458902 by Matt.Kuhlenschmidt
PR #3607: Improved InputKeySelector functionality (Contributed by projectgheist)
Change 3458917 by Matt.Kuhlenschmidt
Fix crash with invalid object properties in the class picker
#jira UE-39000
Change 3458939 by Matt.Kuhlenschmidt
Fix compile error
Change 3458984 by andrew.porter
QAGame: Initial check in of sequencer smoke test map
Change 3459510 by Matt.Kuhlenschmidt
Fixed ensure when deleting a map that contains build data which also happens to be the currently loaded map.
#jira UE-45052
Change 3460985 by Max.Chen
Sequencer: Snap play time to keys now allows scrubbing between keys and snaps to key times within a certain screenspace tolerance.
#jira UE-45090
Change 3461698 by Arciel.Rekman
Avoid using ARRAY_COUNT in Vulkan.
- Sometimes those arrays can have no extensions whatsoever, and it is illegal to declare a 0 element C array.
Change 3462053 by Max.Chen
Sequencer: Show sequencer spawnables in the world outliner and add the icon overlay for spawnables.
#jira UE-43470
Change 3462139 by Max.Chen
Property Editor: Add objects to FPropertyAndParent
Change 3462202 by Arciel.Rekman
Fix FSocket::Recv() blocking with Peek when there's no data.
Change 3462253 by Nick.Darnell
Slate - New Clipping System
Clipping is now a stateful choice made during composition of the slate hierarchy. Previously every widget got to respect or modify the clipping rect on an as needed basis. The problem was that clipping was only allowed in the layout space of the widget, and it wasn't possible to properly clip elements with render transforms. The new system permits all kinds of transforms on any widget, and they will all be clipped correctly. It tries to use Scissor Rects as they are much cheaper, but will switch over to stenciling if need be to represent a complicated masking structure with several rotated clipping rects all needed to be combined together.
Here are the new clipping states a widget can have, almost all widgets are set to No. Only change it from No if your widget actually needs to clip, generally speaking most widgets don't need to clip.
/**
* This widget does not clip children, it and all children inherit the clipping area of the last widget that clipped.
*/
Inherit,
/**
* This widget clips content the bounds of this widget. It intersects those bounds with any previous clipping area.
*/
ClipToBounds,
/**
* This widget clips to its bounds. It does NOT intersect with any existing clipping geometry, it pushes a new clipping
* state. Effectively allowing it to render outside the bounds of hierarchy that does clip.
*
* NOTE: This will NOT allow you ignore the clipping zone that is set to [Yes - Always].
*/
ClipToBoundsWithoutIntersecting UMETA(DisplayName = "Yes - Without Intersecting (Advanced)"),
/**
* This widget clips to its bounds. It intersects those bounds with any previous clipping area.
*
* NOTE: This clipping area can NOT be ignored, it will always clip children. Useful for hard barriers
* in the UI where you never want animations or other effects to break this region.
*/
ClipToBoundsAlways UMETA(DisplayName = "Yes - Always (Advanced)"),
/**
* This widget clips to its bounds when it's Desired Size is larger than the allocated geometry
* the widget is given. If that occurs, it behaves like [Yes].
*
* NOTE: This mode was primarily added for Text, which is often placed into containers that eventually
* are resized to not be able to support the length of the text. So rather than needing to tag every
* container that could contain text with [Yes], which would result in almost no batching, this mode
* was added to dynamically adjust the clipping if needed. The reason not every panel is set to OnDemand,
* is because not every panel returns a Desired Size that matches what it plans to render at.
*/
OnDemand UMETA(DisplayName = "On Demand (Advanced)")
- Large API Change -
All FSlateDrawElement::Make_____ calls have been deprecated that involved passing in a clipping rect. You no longer should are passed a Clipping rect via OnPaint. You are still passed a rect, but this rect represents a Culling Rect, which is valuable if you need to just out right not paint things the user can't possibly see.
If you were previously trying to determine if you should cull widgets, by doing something like this,
if ( FSlateRect::DoRectanglesIntersect(MyClippingRect, CurWidget.Geometry.GetRenderBoundingRect()) )
That's no longer a good option since there are ways for widgets to ignore the culling bounds. You should convert anything like above to the one below,
if (!SWidget::IsWidgetCulled(MyCullingRect, CurWidget))
To assist in debugging efforts, there are several new debugging console flags in Slate,
Slate.ShowClipping 1 - Controls whether we should render a clipping zone outline. Yellow = Axis Scissor Rect Clipping (cheap). Red = Stencil Clipping (expensive).
Slate.DebugCulling 1 - Disables pushing clipping or stencil rects to the GPU, but continues to intersect culling rects, so that you can tell if a widget is properly culling children it can't possibly draw.
Slate.ShowTextDebugging 1 - Show debugging painting for text rendering.
I've added a new Experimental Feathering Option, it adds AA geometry around the outside of Box and Image brushes.
Slate.Feathering 1
If you're using RenderDoc or something similar, you can now enable render events for slate, so that you can better grok how we're batching and changing states for each UI render pass.
Slate.EnableDrawEvents 1
#jira UE-4659
#rn
Change 3462714 by Nick.Darnell
Fixing a few more compiler issues with the clipping changes.
Change 3462726 by Max.Chen
Switch OnEditStructChildContentsChanged to use FObjectWriter instead of FMemoryWriter which supports serializeing UObjects. This fixes a crash when adding actor array elements to a user defined event struct.
#jira UE-45431
Change 3462801 by Nick.Darnell
Adding a UMG dependency to EngineTestBuild.
Change 3462914 by Max.Chen
Sequencer: Fix regression where spawnables aren't getting saved. Caused by 3407138
#jira UE-30007
#jira UE-39003
Change 3462946 by Nick.Darnell
Automation - Tweaking the UI automation tests converting them over to use the new UI Screenshot automation test.
Automation - Adding a blur widget test.
Change 3462987 by Matt.Kuhlenschmidt
Back out changelist 3458893
Change 3464774 by Matt.Kuhlenschmidt
PR #3629: Bugfix: Missing small icon in Project Launcher profile editor (Contributed by aarmbruster)
Change 3464785 by Nick.Darnell
Fixing some clipping stuff in the editor.
Change 3464830 by andrew.porter
QAGame: Second pass on sequencer smoke test map
Change 3464902 by Nick.Darnell
Loading - Adding some additional checks to the the loading code to ensure we're on the main thread. Additionally adding a fix from UDN that prevents deadlocks in the rare case a user hits Alt+Tab in a fullscreen game while in a hard loading screen.
Change 3464988 by Max.Chen
Sequencer: Add attenuation settings for attached audio components.
#jira UE-33080
Change 3465024 by Nick.Darnell
MoviePlayer - Impoving the playback mode displaynames.
Change 3465074 by Arciel.Rekman
Fix shadowing issues of GraphicsPSOInit.
Change 3465097 by Matt.Kuhlenschmidt
Some refactoring of the details panel
Exposed new methods of adding a struct on scope to a details panel and have it work properly with customizations. The scruct on scope has a "fake" ustructproperty that allows the details panel to show the whole struct not just an individual property.
Refactored the API for adding rows to details panels to make it more consistent\
AddChildCustomBuilder->AddCustomBuilder
AddChildGroup->AddGroup
AddChildContent->AddCustomRow
AddChildPropert->AddProperty
AddChildStructure->AddExternalStructureProperty
AddStructure->AddAllExternalStructureProperties
AddExternalProperty->AddExternalObjectProperty or AddExternalStructureProperty
Change 3465186 by Max.Chen
Sequencer: Save the BindingID in the pre animated token producer so that it can be destroyed properly. This fixes a bug where the default state of a spawnable isn't saved.
#jira UE-43780
Change 3465315 by Matt.Kuhlenschmidt
Fix Fortnite and Orion details panel customization warnings
Change 3465424 by Nick.Darnell
Automation - Moving the step for setting the link to the automation reports to be set before we start the engine.
Change 3465488 by Nick.Darnell
Automation - Forcing textures to load before taking screenshot, so that the scene gets another opportunity to render before we render with Slate. This should fix the Blur UI Test.
Change 3466277 by Arciel.Rekman
Linux: fix window drift when dragging (UE-40380).
- Change by Cengiz Terzibas.
Change 3466370 by Nick.Darnell
UMG - Fixing the colors for the resize handle in the designer.
Change 3466372 by Nick.Darnell
UMG - Fixing the ruler ticks sometimes not being drawn.
Change 3466374 by Nick.Darnell
UMG - Fixing the designer showing multiple options for sequencer.
Change 3466377 by Nick.Darnell
UMG - Cleaning up some clipping bits.
Change 3467025 by Andrew.Rodham
Re-saving assets that contain legacy (<4.15) movie scene data to remove deterministic cook warning.
If conflicts arise during merging of these assets, please ignore the changes made in dev-editor, and accept game-side changes.
(CIS step 62283298, jobId 7773146)
(CIS step 62283297, jobId 7773146)
Change 3467099 by Max.Chen
Fix GetObjectPropertyClass ensure logic. This was returning UObject::StaticClass when valid.
Change 3467172 by Max.Chen
Sequencer: Evaluation optimizations. Also, fixes subsequences not getting expired, leaving dangling spawnables.
#jira UE-43690
Change 3467192 by Matt.Kuhlenschmidt
Fix transactions getting stuck in the color grading controls. This prevents PIE from working properly and causes shutdown crashes
#jira UE-45527
Change 3467251 by Yannick.Lange
ViewportInteraction: Fix scale and rotation snap while dragging with two lasers.
#jira UE-43489
Change 3467331 by Matt.Kuhlenschmidt
Fix D3D shader compiler hard coding shader path and not giving proper warnings when it cannot find the shaders
Change 3467335 by Matt.Kuhlenschmidt
Remove DarkStyle attribute from SNumericEntryBox and allow a spin box style to be passed to it.
Change 3467558 by Max.Chen
Scene Outliner: Generic support to add default columns to a scene outliner.
Change 3467565 by Jamie.Dale
Removing old screenshot data for test
Change 3467589 by Nick.Darnell
Editor - Random cleanup.
Change 3467596 by Nick.Darnell
Progress Bar - Exposing Border Padding to UMG.
Change 3467600 by Nick.Darnell
Slate - Adjusting the rendering of the splitter, previously it could be off by a pixel or two, which becomes more apparent now with the clipping changes.
Change 3467601 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467662 by Nick.Darnell
Automation - Fixing a bug with the screenshot comparison tool not replacing (removing) the old screenshot data.
Change 3467674 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467737 by Max.Chen
Sequencer: Added OnMovieSceneBindingsChanged delegate
Change 3468053 by tim.gautier
QAGame: Updating Editor Smoke Map
- Updated landscapes into Stations for testing
- Added Foliage Sublevel
Change 3468194 by Arciel.Rekman
Linux: fix problems communicating with various STL-using libs.
- Stop hiding global new/delete signatures.
- Disable CEF3 since this change uncovers the problem with libcef.so not built to use bundled libpng.
Change 3468678 by Max.Chen
Sequencer: Set "Sequencer Actor" tag before setting the actor label so that the outliner refreshes after the actor has the tag.
Change 3469314 by tim.gautier
QAGame: Added Painted Foliage / Spline section to EditorSmoke map
Change 3469377 by Nick.Darnell
Slate - Fixing some warnings in a couple of sample games due to the clipping changes.
#rnx
Change 3469767 by Max.Chen
Sequencer: Outliner column and sequencer binding data
#jira UE-43470
Change 3469974 by Arciel.Rekman
Fix code projects not working in Linux installed build.
Change 3470082 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470174 by Nick.Darnell
Slate - Get the last widget in a widget path utility.
Change 3470176 by Nick.Darnell
UMG - User Widgets now have an easy way to know if they're part of or have been removed from the focused widget path, which is handy for doing effects.
Change 3470261 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470286 by Max.Chen
Sequencer: Scene Component's HiddenInGame now goes through the VisibilityTrack and the visibility template.
Change 3470366 by Nick.Darnell
Slate - We now version focus per user, that way during focus events, we can safely abort focus events and state transitions if someone interrrupts the active focus event with something new.
Change 3470649 by Matt.Kuhlenschmidt
Fix deprecation warnings
Change 3470695 by Matt.Kuhlenschmidt
Fixed typo
#jira UE-45580
Change 3470721 by Matt.Kuhlenschmidt
Fix static analysis
Change 3471254 by Michael.Dupuis
#jira UE-42952: Keep occlusion result per view
Change 3471287 by Nick.Darnell
UMG - Render Focus Rule now defaults to never.
Change 3471291 by Nick.Darnell
Slate - Fixing FSlateRenderer* change fallout.
Change 3471299 by Nick.Darnell
Slate - Fixing FSlateRenderer* change.
Change 3471323 by Nick.Darnell
Automation - Fixing automation and Static Analysis warning.
Change 3471413 by andrew.porter
QAGame: Added test content for anim blending and material parameteres to sequencer smoke level
Change 3471649 by Max.Chen
Sequencer: Modify the track when adding animation
#jira UE-45618
Change 3471659 by Matt.Kuhlenschmidt
Added a way to check if a movie is playing from the engine.
Prevented viewport redraws for canvas loading screens if a slate based loading movie is playing
Change 3471734 by Matt.Kuhlenschmidt
Added basic material hookup to USD. Similar to FBX it will find materials based on rules specified by the user in the import settings
Change 3472176 by Nick.Darnell
UMG - Improving the display of the +Track menu in sequencer for UMG. Renamed it from +Add, which is repetitve to +Track. Additionally, the dropdown now shows the currently selected widgets, as well as a submenu containing all the 'important' widgets, so we no longer populate that list with a ton of irrelevant widgets that are just Buton_1 - N, which is pointless in showing people, they'll never guess which is the right button.
Change 3472740 by Max.Chen
Sequencer: Add GetThisFrameMetaData accessor
Change 3472748 by Max.Chen
Sequencer: Added OnBeginScrubbing and OnEndScrubbing event delegates
Change 3472753 by Max.Chen
Sequencer: Add EMovieSceneDataChangeType parameter to OnMovieSceneDataChanged delegate
Change 3472870 by Nick.Darnell
Clipping - Fixing the deprecated tip for scissor rect boxes to be correct. Removing it's usage from UT.
Change 3473340 by Max.Chen
Scene Outliner: Add ability to register additional filters
Change 3473348 by Max.Chen
Details View: Make ForceRefresh virtual. Added accessors to delegates (ie. GetIsPropertyReadOnlyDelegate)
Change 3473441 by Max.Chen
Sequencer: Autokey Refactor Part 2.
Autokey is now a single toggleable state.
Allow Edits Mode has 3 states:
Allow All Edits - Allow any edits to occur, some of which may produce tracks/keys or modify default properties.
Allow Sequencer Edits Only - All edits will produce either a track or a key.
Allow Level Edits Only - Properties in the details panel will be disabled if they have a track.
#jira UE-45229
Change 3473670 by Nick.Darnell
Modules - The module manager no longer returns sharedptrs to IModuleInterfaces, this was the source of rare hard to track down crashes due to a shared ptr reference leak when GetModule was called on non-main threads. We now store a TUniquePtr internally, and only lease out raw pointers.
#rn
Change 3473711 by Nick.Darnell
Disabling the ensure in the module manager.
Change 3473747 by Max.Chen
Sequencer: Fix tooltip
Change 3474091 by Jamie.Dale
Added a warning when cooking a UFontFace that is outered to a UFont asset
These cause issues with iterative COTF, and should be split off into their own assets (as the UI has been asking people to do for several versions)
Change 3475052 by Yannick.Lange
VR Editor: Fix Crash when quitting the editor with VR Mode enabled. VR Editor was being enabled when saving the map on closing the editor.
#jira UE-45415
Change 3475054 by Yannick.Lange
Fix crash when adding a camera to the world in VR Mode the second time. The slate application did not reset when stop dragging in VR Mode, so the second time when starting to drag a camera out of the UI it would already by in a dragging state.
#jira UE-45574
Change 3475263 by Nick.Darnell
Fixing some additional cases of IModuleInteface SharedPtr usage.
Change 3475268 by Max.Chen
Sequencer: Set jumped state when looping playback. This fixes an issue where audio doesn't stop and restart when looped.
#jira UE-45654
Change 3475269 by Max.Chen
Scene Outliner: Additional filters should only apply to actor browsing mode
Change 3475407 by Nick.Darnell
Fixing some clipping / module shared ptr changes in the launcher code.
Change 3475542 by Max.Chen
Sequencer: Update thumbnail and section highlighting to use new clipping behavior.
#jira UE-45692
#jira UE-45689
Change 3475743 by Michael.Dupuis
#jira UE-45183: When updating phyx region take into account simple collision mip
Change 3475949 by Arciel.Rekman
Remove PhysX deoptimization (no longer needed).
- OR-24947 has been closed three months ago.
Change 3476022 by Michael.Dupuis
#jira UE-45560: Make sure we're not going out of range
Change 3476063 by Michael.Dupuis
#jira UE-45562: Do not try to unregister from static mesh if no static mesh is specified for the component
Change 3476168 by Michael.Trepka
Added handling of directory symlinks to FApplePlatformFile::IterateDirectory
#jira UE-43704
Change 3476172 by Nick.Darnell
Fixing a Imoduleinterface change.
Change 3476183 by Jamie.Dale
Exposing GoTo/ScrollTo to single-line editable text for API parity with multi-line editable text
Change 3476385 by Arciel.Rekman
Linux: handle symlinks when iterating directories.
Change 3476522 by Michael.Trepka
Solved a problem with Mac FMallocTBB::Malloc() returning nullptr for 0 bytes allocations, which is inconsistent with other platforms. On Mac we always scalable_aligned_malloc, which behaves differently than scalable_malloc, so for 0 bytes requests we allocate sizeof(size_t), which is exactly what scalable_malloc does internally in such case.
Change 3476806 by Nick.Darnell
UMG - Focus the designer after dropping a widget onto the surface.
Change 3476809 by Nick.Darnell
Curve Editor - Enable Clipping on the curve editor.
Change 3477475 by Nick.Darnell
Fixing a module interface shared ptr usage in UT.
Change 3477553 by Yannick.Lange
VR Editor: Removed AssetEditorPanelID and replaced it with TabManagerPanelID. A panel for AssetEditorPanelID was never created making it impossible to open an asset editor.
Change 3477734 by Yannick.Lange
VR Editor: Fix Warning: SetRelativeScale3D : Invalid Scale entered (X=inf Y=inf Z=inf). Resetting to 1.f. warning when adding CineCameraActor to World from Modes Panel. Make sure to not divide by zero when there is no boundary scale.
#jira UE-44933
Change 3477761 by Jamie.Dale
Some improvements to avoid loading the native .locres files twice when we don't need to
Change 3477780 by Nick.Darnell
PR #3250: Return correct VirtualUserIndex (Contributed by projectgheist)
Change 3477786 by Nick.Darnell
PR #3650: Changed TestNull to accept const pointers. (Contributed by e-agaubatz)
Change 3477795 by Nick.Darnell
PR #2844: UE-36936: Don't stretch container for Plugin Image (Contributed by projectgheist)
Change 3478092 by Nick.Darnell
PR #2341: Optional Middle Mouse Button panning in Graph Editor (Contributed by flipswitchingmonkey)
Engine Edit - Made some small changes to the enum type, and some naming.
Change 3478450 by Nick.Darnell
Fixing some uninitialized variable errors.
Change 3479827 by Andrew.Rodham
Sequencer: Addressed serialization issues with some struct types
Change 3479874 by Jamie.Dale
Fixed "NativeGameLanguage" not being used correctly during localization initialization
Change 3480012 by Andrew.Rodham
Sequencer: Fixed loading tagged properties as native for track identifiers
#jira UE-45823
Change 3480337 by Alexis.Matte
Fix morph target crash missing some valid index check
Change 3480804 by Alexis.Matte
Fix crash with ColorGradingMode custom detail
#jira UE-45638
Change 3480892 by Andrew.Rodham
Sequencer: Ensure that movie scene sequences know about the editor object version
#jira UE-45842
Change 3481073 by Nick.Darnell
Fix the shader compiler error from main in Slate.
Change 3481303 by Nick.Darnell
UMG - Fixing a bug with the drag handle not working correctly in HDPI mode.
Change 3481308 by Nick.Darnell
Slate - Tweaking the IsWidgetCulled logic to consider both the layout and rendering bounds. If we do this, we get a much more desireable outcome for people that want to animate widgets and such and plan to have temporary animations to move the widget offscreen, but want the layout bounds to anchor that widget in the visible frame so that it animates even when normally it would be culled b/c the render transform and therefore the renderbounds moved it completely outside the culling rect.
Change 3481629 by Max.Chen
Sequencer: Add Level Sequence Actor as an output for CreateLevelSequencePlayer()
#jira UE-45785
Change 3481899 by Yannick.Lange
VR Editor: Added debug modetoggle command with an event that is broadcasted whenever this happens. Currently this is used to show all the floating UIs of the UI system to debug without HMD using VREd.ForceVRMode.
Change 3481984 by Michael.Dupuis
#jira UE-45845: always validate if we have a static mesh before trying to access it as user can decide to not assign one and use the tools
Change 3482047 by Nick.Darnell
Slate - Adding some comments to IsWidgetCulled.
Change 3482110 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482136 by Jamie.Dale
The CamelCase break iterator now treats digits around character tokens as part of the identifier
Change 3482138 by Michael.Dupuis
#jira UE-45854: Properly unregister during undo operation
Change 3482150 by Michael.Dupuis
#jira UE-45845 : Add missing nullcheck for GetStaticMesh
Change 3482153 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482180 by Nick.Darnell
UMG - Widget Components do not need to define a widget class to be rendererd, they can have native slate widgets only. This was a regression from main.
Change 3482273 by Nick.Darnell
UMG - Tweaking some more things about the widget component box outline.
Change 3482308 by Alexis.Matte
Fixing morph target smooth group support. Do not call FillSkeletalMeshImportData more then once on FbxNode since this fonction is doing some conversion and change the FbxNode, applying those conversion twice do not return the same faces smooth group.
#jira UE-45696
Change 3482327 by Nick.Darnell
UMG - More tweaks to the WidgetComponent so both shows the box outline, but works in game and VR editor.
Change 3482705 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484245 by Max.Chen
Sequencer: Evaluate on end scrub. This fixes a bug where audio doesn't evaluate in a stopped position at the end of scrubbing, causing it to not stop all sounds. This fixes a bug introduced from 3365018 where evaluate on end scrub was removed.
#jira UE-45905
Change 3484263 by Max.Chen
Sequencer: Fix crash on forcing refresh of details panel on release.
#jira UE-45911
Change 3484431 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484474 by Alexis.Matte
Fix the morph target animation curve name matching.
#jira UE-20294
Change 3484475 by Alexis.Matte
When removing a LOD, make sure we remove all morph target data associate to the LOD.
Change 3484489 by Nick.Darnell
PR #3668: UE-45908: Cache debug line locations when performing a LineTraceMulti (Contributed by projectgheist)
#jira UE-45908
Change 3484692 by Nick.Darnell
Slate - Reverting a change from a game stream. All Arranged Children don't need to allocated 42 to begin with. Do need to initialize WidgetPaths better.
Change 3484703 by Nick.Darnell
Player Input - Making the input event loop for players obey EKeys::NUM_TOUCH_KEYS, rather than being set to Touch10, as the maximum touch input amount, to make supporting greater than 10 touches easier. Also making the seeding of keys use EKeys::NUM_TOUCH_KEYS.
#jira UE-43213
Change 3484918 by Jamie.Dale
Fixed font measuring regression with RTL text
RTL applies the character count to the next glyph, so it shouldn't process the end of the loop (this was how the older code used to work).
Change 3485718 by Nick.Darnell
Editor - Removing Super Search & User Feedback button.
Change 3485719 by Nick.Darnell
Portal - Removing SuperSearch.
Change 3485751 by Matt.Kuhlenschmidt
Fix crash accessing platformer game menu if the menu is open during a console based load
#jira UE-45950
Change 3486047 by Arciel.Rekman
Linux: add OpenEXR implementation (UE-40270).
#jira UE-40270
Change 3486467 by Max.Chen
Sequencer: Reset max tick rate when destroyed.
#jira UE-45956
Change 3486477 by Max.Chen
Sequencer: Refresh outliner when column is removed.
#jira UE-45891
Change 3486667 by Andrew.Rodham
Added missing include
Change 3486724 by Andrew.Rodham
Sequencer: Fixed curves with no default value, and no keys being evaluated and applied to properties
- Also fixed an edge case where a zero (but non-animated) channel could be applied to a final transform
Change 3486730 by Alexis.Matte
In the Auto-Reimport options, hide the mout point only for the default /Game/ folder
#UE-45684
Change 3486749 by Alexis.Matte
Make sure the parent window of the monitor directory browse folder is set properly
#jira UE-45682
Change 3486805 by Matt.Kuhlenschmidt
Additional safety against invalid objects being accessed by slate
Change 3486848 by Alexis.Matte
Make sure Monitor folder feature support root mount point map folder
During auto import, give priority to asset import factory over the scene import factory
#jira UE-45691
Change 3486879 by Andrew.Rodham
Removing obsolete QA assets
Change 3486950 by Nick.Darnell
PR #2281: Scrollbar missing features and SScrollbar fixes (Contributed by SNikon)
Review - made some adjustments from the original.
Change 3486954 by Nick.Darnell
Slate - Moving the STableViewBase over to the FOverscroll class, rather than it's own clone.
Change 3486967 by Nick.Darnell
Slate - Fixing some HDPI calculations for fitting new windows on screen, it was using the unscaled size of the widgets for fitting, when it needed to scale them up.
Change 3486970 by Andrew.Rodham
Sequencer: Delay mouse capture until drag for sequencer time slider
- Fixes context menus not opening as a result of mouse capture being taken on mouse down
#jira UE-45937
Change 3486984 by Andrew.Rodham
Sequencer: Improved blending type iconography
Change 3486996 by Nick.Darnell
UMG - Adding a way for games to opt-out of the slow widget path, to completely prevent them from being cooked.
UMG - The movie data is no longer cloned for each new instance that inhabits. It now keeps a reference to the now publically accessible movie scene data on the class instead.
Change 3487070 by Andrew.Rodham
Sequencer: Added graphics for key areas that represent empty space
Change 3487195 by Andrew.Rodham
Sequencer: Changed evaluation groups to always flush implicitly
- Due to the latent nature of blended token types, it's no longer safe to rely solely on execution token order between tracks
- This fixes an issue where events set in the PostEvaluation stage were executed before blended token actuation
Change 3487322 by Nick.Darnell
PR #2457: Add .gitdeps.xml-files for plugins support (Contributed by bozaro)
Change 3487363 by Nick.Darnell
PR #2481: Fix for packing of a project with users plugins (Contributed by yatagarasu25)
Change 3487439 by Nick.Darnell
PR #2642: Changed private to protected in SVirtualJoystick.h (Contributed by Skylonxe)
Change 3487500 by Arciel.Rekman
Removed LinuxNativeDialogs.
- No longer used; has been superceded by SlateDialogs since UE 4.8 (2 years ago).
Change 3487630 by Lauren.Ridge
Don't create Landscape Info Maps for Editor Preview Worlds or thumbnail worlds
#jira UE-44885
Change 3487864 by Matt.Kuhlenschmidt
Exposed the asset registry to blueprints and script. Works in editor scripts and runtime scripts
AssetRegistry is now a UInterface object.
Blueprint users can access various asset registry methods using the asset registry interface (via GetAssetRegistry) and various static helpers in the AssetRegistryHelpers object
C++ users should still continue to use IAssetRegistry.
Change 3487879 by Matt.Kuhlenschmidt
Renamed asset tools uobject helper to UAssetToolsHelpers
Change 3487926 by Lauren.Ridge
Fixing reset to default not showing up for custom widgets
#jira UE-44164
Change 3488184 by Matt.Kuhlenschmidt
PR #3656: Make References/Referencers List copyable (Contributed by user37337)
#jira UE-45763
Change 3488240 by Matt.Kuhlenschmidt
Fix compiler issue
Change 3488350 by Lauren.Ridge
Landscape info map transactional state is based on its world's transactional state
#jira UE-44885
#jira UE-46019
Change 3488412 by Matt.Kuhlenschmidt
Fix reset to default showing up in two different places for some customizations
Change 3488413 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488414 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488415 by Matt.Kuhlenschmidt
Missed file
Change 3488565 by Arciel.Rekman
Add pretty printers for gdb (UETOOL-1171).
- Committing shelf by Cengiz.Terzibas, with some modifications.
#jira UETOOL-1171
Change 3489094 by Nick.Darnell
Slate - The Slate RHI Renderer now caches the TextureLODGroups so that it can properly lookup the filtering of different texture groups that are set to Default, instead of a particular filter override on a texture.
Engine/Rendering - Simplifying some of the setup logic in TextureLODSettings so that code is shared for setting them up properly after loading from a config file.
Change 3489095 by Nick.Darnell
PR #2699: GameViewportClient - Added a method to allow setting the viewport cur. (Contributed by rfenner)
Review - Fixed spacing.
Change 3489108 by Matt.Kuhlenschmidt
Fix deprecation warning
Change 3489120 by Nick.Darnell
PR #3478: Fix possible UComboBoxString crash (Contributed by nakosung)
Change 3489147 by Andrew.Rodham
Sequencer: Adding return value to function to appease static analysis
- This function is never compiled, and if it is, it won't compile, but static analysis doesn't know that
Change 3489264 by Nick.Darnell
Testing - Finishing the thought behind an enum comment.
Change 3489265 by Nick.Darnell
PR #2750: UE-35164: Button padding (Contributed by projectgheist)
Change 3489267 by Nick.Darnell
PR #3645: UE-45464: Handle SSlider mouse interaction more accurately (Contributed by projectgheist)
Change 3489632 by Arciel.Rekman
Correctness changes to MallocPoisonProxy.
- Missing forwarding functions added. Incorrect comment removed.
- Change by Steve.Robb, doing here so it is in 4.17.
Change 3489689 by Arciel.Rekman
More MallocPoisonProxy changes I missed in previous CL.
Change 3489751 by Matt.Kuhlenschmidt
Moved editor performance settings out of per-project settings so they can be shared across projects
Change 3489837 by Lauren.Ridge
Keyboard shortcut for entering/leaving VR Mode is now Alt+V
Change 3491082 by Arciel.Rekman
Linux: better fix for the crash due to name collision (UE-46040).
- Put classes in Sequencer module into Sequencer namespace instead of SceneOutliner namespace.
- Undid change in the SceneOutliner module.
#jira UE-46040
Change 3491096 by Arciel.Rekman
Fix UAT compilation on the newest mono.
Change 3491240 by Max.Chen
Sequencer: Disable key button when allow level edits only is on.
#jira UE-46060
Change 3491406 by Yannick.Lange
Fix editor crashes when opening a project that includes a plugin with more than two custom Volume classes. This issue was caused because registering show volume commands is based on finding volume classes. Finding these classes at multiple times resulted in a mismatch of the returned array of volume classes because modules/plugins were still being loaded.
#jira UE-45806
Change 3491559 by Alexis.Matte
Make sure we use the good preview mesh when doing a preview
#jira UE-45963
Change 3491563 by Alexis.Matte
Fix crash with staticmesh editor LodLevel selection
Change 3491564 by Nick.Darnell
UMG - Fixing an offset with the grab handles in HDPI mode.
Change 3491595 by Nick.Darnell
Editor - Fixing a clipping artifact in the pin type dropdown in the blueprint editor.
Change 3491604 by Nick.Darnell
Back out changelist 3489265
Change 3491615 by Arciel.Rekman
Added malloc replay proxy (Linux only for now).
- Allows to dump malloc callstream (without regard to threads) and replay later to study the behavior of different mallocs and/or repro problems.
Change 3491684 by Arciel.Rekman
Added FMalloc functions I missed.
- Also moved function bodies into the .cpp file, this does not make a difference in performance in this case.
Change 3491692 by Matt.Kuhlenschmidt
Some minor fixes to the static mesh editor
- Fix UV combo button looking non-standard on the toolbar
- Fix a few combo buttons in the details panel looking too big.
Change 3491702 by Arciel.Rekman
Do not compile replay proxy-specific code when not used.
Change 3491717 by Michael.Dupuis
#jira UE-35083:
The component is now the owner of the PerInstanceRenderData instead of the proxy
Add an Update path to only update specified instances range
Always call BuildTreeIfOutdated so we have a standard code path to make sure static mesh are fully loaded before trying to build the tree
Moved the Instance Buffer aysnc to the base class, as it's not related to UHierarchicalInstancedStaticMeshComponent
Expose a new property to decide if we require dynamic instance buffer
Change 3491758 by Matt.Kuhlenschmidt
Fix crash on static mesh editor shutdown
Change 3491873 by Cody.Albert
Fixed clipping issue in Sequencer curve editor
#rnx
Change 3491956 by Matt.Kuhlenschmidt
Fix crash opening the Previewing sub-menu in the level editor settings menu
#jira UE-46095
Change 3492046 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492076 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492165 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492222 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492274 by Michael.Dupuis
#jira UE-46105: Fixed Clang warning
Change 3492338 by andrew.porter
QAGame: Testing ensure when submitting
Change 3492371 by Nick.Darnell
UMG - Reverting the animation sharing, cossed GLEO regressions in cooking. Will look for a better solution.
Change 3492462 by Matt.Kuhlenschmidt
Fix ensure checking in files through perforce
Change 3492491 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492505 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492517 by Jamie.Dale
The package localization ID is no longer used at all at runtime, and is now truly editor-only
This should have always been the case, but it was leaked into manifest/archives/PO files in 4.14, and while 4.15 removed it from PO files it was still present in the manifest/archives. This change removes it entirely (unless gathering editor-only data, and even then the PO file will still collapse the entries together for translation), and the deprecated 4.14 export behavior will now produce an error if you attempt to use it.
After taking this change you'll need to run a gather, import, and compile of your LocRes files to update your game localization to use the new localization IDs.
Change 3492630 by Nick.Darnell
UMG - Removing some extra cleanup code that's probably overkill and is causing a crash for uses of "Within" in class meta.
#jira UE-46124
Change 3492692 by Matt.Kuhlenschmidt
Fix drop shadows inheriting the outline color of the font. The outline should still appear but not have a different outline color from fill color
Change 3492714 by Matt.Kuhlenschmidt
Added outline with drop shadow to font automation test
Change 3492737 by Matt.Kuhlenschmidt
Fix linux
Change 3492992 by tim.gautier
Resaving Ocean Widget Blueprints / Sequences to resolve Legacy Sequence Data warnings
#jira UE-46132
Change 3493089 by Jamie.Dale
Ensure that the composite font of a font asset is flushed when the font object is GC'd
Change 3493322 by Jamie.Dale
Fixing null crash
#jira UE-45758
Change 3494467 by Andrew.Rodham
Fix Xbox warning
Change 3494852 by tim.gautier
QAGame: Changed streaming method of QA-EditorSmoke-Landscape to Always Loaded
Change 3494853 by Nick.Darnell
Another attempt at fixing the automation blueprint SA warning.
Change 3494896 by Arciel.Rekman
Fix possible null pointer access during Vulkan init.
- May fix static analysis warnings in UE-46142, although warnings seem to be referring to something else.
#jira UE-46142
Change 3494987 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495010 by Matt.Kuhlenschmidt
Adding additional logging to track down html5 issue
Change 3495212 by Michael.Dupuis
#jira UE-46143: Properly init the InstanceRenderData during the cooking phase (required by fortnite)
Change 3495536 by Jamie.Dale
Updating UGameEngine to call its Super::PreExit after performing its own teardown
This prevents UEngine cleaning up resources that UGameEngine still needs.
#jira UE-46159
Change 3495551 by Arciel.Rekman
Another attempt to fix analyzer problem (UE-46142).
Change 3495794 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495905 by Matt.Kuhlenschmidt
Fix USD crash when importing a meshwith no material
[CL 3499771 by Matt Kuhlenschmidt in Main branch]
2017-06-19 20:27:30 -04:00
ReturnVal = PacketHandlerInterface - > CreateComponentInstance ( ComponentOptions ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
2019-07-24 22:32:26 -04:00
if ( ! ReturnVal . IsValid ( ) )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
UE_LOG ( PacketHandlerLog , Warning , TEXT ( " Unable to Load Module: %s " ) , * ComponentName ) ;
}
}
if ( ReturnVal . IsValid ( ) )
{
UE_LOG ( PacketHandlerLog , Log , TEXT ( " Loaded PacketHandler component: %s (%s) " ) , * ComponentName ,
* ComponentOptions ) ;
AddHandler ( ReturnVal , bDeferInitialize ) ;
}
}
else
{
UE_LOG ( PacketHandlerLog , Warning , TEXT ( " PacketHandlerComponent 'ReliabilityHandlerComponent' is internal-only. " ) ) ;
}
}
return ReturnVal ;
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
void PacketHandler : : IncomingHigh ( FBitReader & Reader )
{
// @todo #JohnB
}
void PacketHandler : : OutgoingHigh ( FBitWriter & Writer )
{
// @todo #JohnB
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3596412)
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3497498 by John.Barrett
Added CVar for toggling NetConnection sequence randomization 'net.RandomizeSequence'.
Tweaked asserts related to sequence randomization, to remove some false positives.
Change 3520192 by John.Barrett
Added delegate hooks to the base netcode, new virtual functions, and made the UChannel classes overridable through UNetDriver, to allow netcode hooks without requiring a dependency on Online plugin packages - required to keep NetcodeUnitTest functionality, after Online packages were moved out of Engine.
Change 3520215 by John.Barrett
Second pass at big NetcodeUnitTest Minimal Client refactor, consolidating most of the client helper code into MinimalClient, and refactoring the ClientUnitTest API (touching all unit tests).
Also eliminated Online plugin dependencies (removing UnitTestNetDriver and UnitTestNetConnection), replacing them with low level netcode hooks.
Change 3526952 by John.Barrett
Fixed minimal client PackageMap override.
Change 3528488 by John.Barrett
Added actor channel hook, to disable NMT_ActorChannelFailure notification.
Change 3528491 by John.Barrett
Fixed unit test actor channel blocking from triggering disconnects, by using an Engine hook to block NMT_ActorChannelFailure, instead of using a more complex/unreliable method of blocking.
Change 3529906 by John.Barrett
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
Change 3550072 by John.Barrett
Added compile-time verification for unit test and minimal client configuration flags, and refactored how the flags are set - speeds up writing new unit tests, for games with excessive launch times.
Change 3565074 by Jon.Nabozny
Fix Replication Paused logic.
Change 3565093 by Jon.Nabozny
Add a 'UseDistanceBasedRelevancy' check in APawn::IsNetRelevantFor, to make it consistent with AActor.
Change 3565132 by Jon.Nabozny
Fix Actor's GetLevel to no longer assume the immediate outer is the level. Fix similar inconsistent usages of GetOuter on Actors.
Change 3573678 by Jake.Leonard
Update actor replication based stats even when we are currently saturated (their values will be 0 anyways)
#jira UE-46523
#RB: Ryan.Gerleve
Change 3574047 by John.Barrett
Added new '-FullStdOutLogOutput' commandline parameter, for capturing full log output through stdout.
Makes up for the shortcoming of '-AllowStdOutLogVerbosity', being limited to ELogVerbosity::Log.
Change 3575518 by Jon.Nabozny
Remove actors from UNetDriver::DestroyedStartupOrDormant actors when their level is unloaded.
#jira UE-47192
Change 3575911 by Jake.Leonard
Adding option for specifying an editor server port for PIE. This allows users to change the default port used when playing net games without interferring with other instances.
#jira UE-12093
Change 3575916 by Jake.Leonard
Fixing the UI so that it doesn't respond to the same input as the camera controls by making the playback button unfocusable.
#Jira UE-37831
Change 3578830 by Ryan.Gerleve
Merging new PlatformCrypto plugin for interfacing with encryption libraries, with a generic OpenSSL implementation and a BCrypt/CNG implementation for Xbox One.
Added EncryptionComponent interface so that engine code can talk to encryption components without knowing their concrete type.
New AESHandlerComponent packet handler component which uses PlatformCrypto to encrypt packets.
Change 3578855 by Ryan.Gerleve
Merging hooks for encryption in the network handshake flow. NMT_Hello messages may now send an EncryptionToken as a parameter, which can be used by games to derive an encryption key used by the PacketHandler's EncryptionComponent.
Change 3578864 by Ryan.Gerleve
Merged: Changed the net.UseEncryptionToken to be more useful and renamed it to net.AllowEncryption.
This cvar, if 0, will prevent the PacketHandler from adding the configured encryption component, and prevent UPendingNetGame and AOnlineBeaconClient from filling out the EncryptionToken parameter of NMT_Hello - which prevents the extra encryption handshake connection step.
Change 3588479 by Ryan.Gerleve
Merging: Encryption token/ack changes from josh.markiewicz
- moved encryption token request/ack to delegates
- moved FNetworkNotify to NetworkDelegates.h
- moved connection logic out of GameInstance and back into networking code
-- GameInstance sends an enum and the network code does the right thing based on that
#tests PC dedicated server connections golden path and forced failures
Change 3588830 by Jake.Leonard
New camera logic for playercontrollers so that we set the death cams correctly.
#jira UE-44307
Change 3588956 by Jake.Leonard
Quickfix for the character mesh position becoming offset due to movement smoothing being cached out.
#jira UE-45947
Change 3588974 by Ryan.Gerleve
Add a cvar and code to allow testing encryption functionality in ShooterGame, ShooterGame.TestEncryption (off by default). If enabled, attempts to use the PlatformCrypo and AESHandlerComponent to encrypt game traffic with a hardcoded key (for debugging/testing only, not secure!).
Change 3592922 by Jon.Nabozny
Call AActor::PreReplication before performing initial replication triggered from an RPC.
[CL 3596435 by Ryan Gerleve in Main branch]
2017-08-18 09:54:37 -04:00
TSharedPtr < FEncryptionComponent > PacketHandler : : GetEncryptionComponent ( )
{
return EncryptionComponent ;
}
Copying //UE4/Fortnite-Staging to //UE4/Dev-Main (Source: //Fortnite/Main/Engine @ 3780923)
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3780878 by Nick.Darnell
UMG - Providing more information when the compile fails to find a bindable widget.
Change 3780855 by Gil.Gribb
UE4 - Fixed a linear search in EDL that caused performance problems for very large maps. Saves half the load time in FN-BR.
Change 3780803 by Thomas.Sarkanen
Dont create animation tasks for skeletal meshes that have no anim instance
This avoids some wasted work for non-animated attachments, such as pickaxes
#jira FORT-61523 - Don't create anim worker tasks if no AnimBP
Change 3780741 by Yenal.Kal
#jira FORT-60177
Fixed the bug where the anim branching points (begin and end) may be triggered twice incorrectly.
Change 3780663 by Gil.Gribb
UE4 - Batching for audio thread commands.
Change 3780466 by Ben.Marsh
Add error matcher for generic Microsoft errors (eg. 'cl : Command line error D8049 : command line too long to fit in debug record')
Change 3779937 by Nick.Darnell
UMG - Adding an accessor on UUserWidget to get the owning player state easier, since it's a common operation.
Change 3779858 by Sam.Zamani
#http
use separate "-multihomehttp" instead of "-multihome" for routing http socket
#jira FORT-61666
#tests none
Change 3779288 by Michael.Trepka
Changed FMacConsoleOutputDevice::Serialize to use FString's GetNSString() instead of converting the string using FPlatformString::TCHARToCFString to make it safer in case of garbage text passed in Data
#jira FORT-59762
Change 3779062 by Mike.Fricker
Merged CL 3731188 and CL 3733311 from //UE4/Dev-Editor.
----
Improve responsiveness of Open Asset dialog.
On large projects, there's a noticeable delay when opening and searching/filtering assets.
Stopwatch measurements on my machine (seconds for ~122,000 assets):
before with this CL
ctrl-P 1.4 0.45
search 1.8 0.55
CollectionManagerModule was the main culprit for search/filter slowness.
Open Asset delay was due to filtering out plugin content. We were doing a lot of redundant work for what is essentially a read-only operation.
Change 3778954 by Nick.Darnell
Slate - Making the Horizontal and Vertical analog keys configurable in the navigation config. Tweaking how fast the navigation is with the analog stick, trying to tune the feeling.
Change 3778896 by Ben.Marsh
Separate FNameEntrySerialized from FNameEntry, rather than deriving from it. It has to be allocated differently, and many fields cannot be shared between the two.
#jira
Change 3778807 by Ben.Marsh
Fix Tencent include paths not registering if workspace directory contains a space.
Tencent include paths currently have a trailing backslash, and this is surrounded by quotes if the root directory contains a space. The backslash is interpreted as escaping the trailing double quote.
#jira
Change 3778686 by Luke.Thatcher
Reduced impact of dynamic vertex buffer RHI stall in D3D12
- In most cases we can avoid the stall if the vertex buffer has never been used before.
- Only when a buffer has an existing SRV do we need to stall.
- Also, delete copy and move constructors of FD3D12ResourceLocation. Moving or copying an instance of this class leads to double free crashes, so this is now a compile error rather than a runtime crash.
This saves an average of 2ms frame time in a StW lastperftest replay, with r.screenpercentage 10.
#jira FORT-61390
Change 3778679 by Thomas.Sarkanen
Fix Linux server crash - dont attempt to run threaded work in a single-threaded environment
We dont attempt to run animation update work multi-threaded in the same conditions that we didnt attempt to run animation eval work previously.
#jira FORT-61548
Change 3778591 by Ben.Woodhouse
Add build config to FPSChart HTML output
#jira FORT-56478
Change 3778175 by ben.marsh
Remove code to trigger an ensure on Arxan guards. We already send analytics for this, and don't need this legacy path. There is a large number of incoming ensures with this callstack that are clogging up crash reporter.
Will remove all the surrounding code in a later update to a development branch.
#jira
Change 3777750 by Chris.Gagnon
- Slate now supports a CustomBoundary Navigation type wich allows a custom handler if the boundary is hit.
- This provides the ability to have normal navigation while within the boundary and the custom function only on the boundary.
- This differs from Custom which is a full override of the navigation behavior.
Change 3777678 by Bob.Tellez
#UE4 Fix a bug that was causing fastpath nodes in non-nativized BPs to not be fastpath
Change 3776962 by Bob.Tellez
#UE4 Fix warning about missing virtual destructor by making a struct final (like other RHICommands)
Change 3776656 by Thomas.Sarkanen
Fix notifies not getting fired in cases where AlwaysTickPose was set on skeletal mesh components
This was causing AIs to get stuck in montage playback in some circumstances
#jira FORT-61324, FORT-60558
Change 3776655 by Bob.Tellez
#UE4 CIS fix after 3776629
Change 3776650 by Bob.Tellez
Counting uplugin and uproject files as code changes so UGS will trigger code builds on checkins containing these files
Change 3776649 by Nick.Darnell
UMG - Fixing a rare crash when destructing a widget in the designer. It's trying to remove widgets from a half garbage collected panel.
Change 3776629 by Bob.Tellez
#UE4 Using a more efficient data structure for keeping track of visited nodes when verifying EDL.
Change 3776328 by James.Golding
Add command line option (-statnamedevents) for enabling named events
Change 3776024 by Nick.Darnell
Slate - Adding an accessor to SSafeZone to get the amount of padding that will be added, given some scale.
Change 3775569 by Gil.Gribb
UE4 - Fixed bugs with r.DelaySceneRenderCompletion
Change 3775543 by Luke.Thatcher
[XBOXONE] [~] Remove stall in D3D12 CreateRHIBuffer
- Buffer update is enqueued as a task on the RHI thread instead of stalling the RHI thread for the duration of the update.
Change 3775488 by Thomas.Sarkanen
Prevented skeletal meshes that are not being ticked due to URO from dispatching tick tasks
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3775219 by Bob.Tellez
#UE4 Dont SerializeThumbnails when calling savepackage while editoronly data is excluded (cooking). This saves a lot of memory while cooking
Change 3774886 by Mike.Fricker
Fixed occasional crash when backing out to lobby
- Don't force DF data to be updated when the mesh isn't in the world or has no scene interface
#jira FORT-60863
Change 3774767 by Ori.Cohen
Fix race condition for creating statid in test configs
Change 3774682 by Bob.Tellez
#UE4 Don't bother clearing cached platform data during shutdown purge since there may be a lot of it and it takes a while to destroy it.
Change 3774621 by Bob.Tellez
#UE4 Move Tree rebuilding during cook from Serialize to PreSave to avoid building the tree multiple times for a single platform. Also properly clear out CacheMeshExtendedBounds.
Change 3774201 by Gil.Gribb
UE4 - Fixed rare crash caused by unmounting pak files.
Change 3773920 by Gil.Gribb
UE4 - Added experimental option r.StartPrepassParallelTranslatesImmediately which allows the parallel translate tasks from the prepass to start before we init shadows. Disabled by default.
Change 3773896 by Thomas.Sarkanen
Push non-rendered anim updates back onto the worker thread
Now when meshes are set to EMeshComponentUpdateFlag::AlwaysTickPose, we optionally kick of a task to perform parallel update only (no evaluation).
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3773886 by Gil.Gribb
UE4 - Reduced r.RHICmdMinCmdlistForParallelSubmit from 2 to 1.
Change 3773882 by Gil.Gribb
UE4 - Improved profiler markers when they are used without stats to cover the task graph and some things related to the parallel renderer.
Change 3773461 by Gil.Gribb
UE4 - Increased the granularity of the ParallelFor blocks for greater load balancing.
Change 3773459 by Gil.Gribb
UE4 - Adds TLS caches for MallocBinned2 to the Audio thread.
Change 3773458 by Gil.Gribb
UE4 - Added an experimental option to do the slate render before waiting for the rendering tasks.
Change 3773011 by Robert.Manuszewski
Header (uasset) and export (uexp) files will now be compared seperately when running cook commandlet with -diffonly to avoid situations where a mismatch in size of the header produces more differences between exports.
+ Renamed ini setting to ignore header differences from SkipHeaderDiff to IgnoreHeaderDiff
Change 3772867 by Thomas.Sarkanen
Nativization now correctly generates and builds code for "Client" builds
Overall this is a bunch of hacks, but necessary for nativization to work at present. Once the cooker and UAT both have a concept of "Client" targets, this can be implemented properly.
Instead of building to a "Client" directory, we build to "Game" for client-only platforms (like PS4, XboxOne)
Also we need to add "Client" targets to the whitelist for the nativized assets plugin, as UBT still thinks it is building for "Client"
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3772408 by Robert.Manuszewski
Cook commandlet will now report full property name when running a diff against the existing cook (-diffonly)
Change 3772359 by Thomas.Sarkanen
Improvements to the Cpp backend to allow VC++ to compile nativized code more effectively
Added a new scoped helper to wrap areas of the code in PRAGMA_DISABLE_OPTIMIZATION. This helps with functions that are large tables or long lists of initializations.
Split anim node initialization up into functions, called from a seperate function dedicated to initializing anim nodes. This splits the 5k+ line constructor into mutiple smaller functions, which the compiler has no problems with.
Overall (along with splitting up the anim BP into functions in the asset) this reduces compilation time for the worst-case compilation unit from ~11m 40s to ~2m 32s.
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3771975 by Zak.Middleton
Fix character proxies doing up to two floor check when only rotation changes. Add some optional verbose logging to FindFloor() and ComputeFloorDist().
#jira FORT-61134
Change 3771421 by Ori.Cohen
Fix CIS
Change 3771052 by Robert.Manuszewski
Package diff improvements (-diffonly mode for cooker). Exposed max diffs to report to ini and added the ability to suppress header differences reporting as they are usually a result of differences in exports anyway.
Change 3771039 by Bob.Tellez
#UE4 Allowing use of -FPS in PGO profile builds
Change 3770747 by Ori.Cohen
Added missing stat named events for anim bp
Change 3769616 by Arciel.Rekman
UBT: Use response files for compiler when compiling for Linux.
- Some command lines are too long when cross-compiling on Windows, which is a problem for non-unity builds (or local changes that result in exclusion of checked out files from the lumped units).
Change 3769457 by Gil.Gribb
UE4 - Added eviction to r.DoLazyStaticMeshUpdate. It just removes 10 prims a frame in a rolling fashion.
Change 3769136 by Michael.Noland
Engine: Improve IsServerDelegateForOSS to allow it to use the play world during PIE even if no context was passed in
Change 3768736 by Robert.Manuszewski
More debug info for ensure in FLinkerSave when a name that has not yet been mapped is being serialized
#jira FORT-60943
Change 3768634 by Robert.Manuszewski
Small optimization to FEDLCookChecker::Verify function
Change 3768603 by Robert.Manuszewski
Merging CL #3766740 by Steve.Robb
TMultiMap::Append added.
Change 3768586 by Ben.Woodhouse
csv profiler screen message
Change 3768506 by Thomas.Sarkanen
Duplicating CL 3764661 from Paragon:
Only update Children attached to Sockets in USkeletalMeshComponent::PostBlendPhysics().
Saves ~20% of STAT_UpdateChildTransforms and ~10% of STAT_UpdateLocalToWorldAndOverlaps in 5ofEach_Dusk_vs_Dusk automation test.
#jira OR-46341
#tests LaneMinionFXTests, monolith w/ full teams.
Change 3768504 by Thomas.Sarkanen
Duplicating CL 3758315 from Paragon:
Optimized PostAnimEvaluation when URO is skipping a frame with no interpolation. Skip unnecessary work.
PreEvaluateAnimation() is now only called if we're about to evaluate anims. PostEvaluateAnimation() is also called only if we have evaluated animations.
Therefore PostEvaluateAnimation() has been pulled inside of PostAnimEvaluation() instead of FinalizeTransforms.
Added a call to ConditionallyDispatchQueuedAnimEvents() in the event that we're not calling PostBlendPhysics because we have not evaluated or interpolated anims.
Added missing call to PostEvaluateAnimation() for PostProcessAnimInstance.
#jira OR-46341
#tests minion FX perf map, lane minion test map, monolith match with 2 full teams.
Change 3768097 by Bob.Tellez
#UE4 Fix non-editor CIS
Change 3767957 by Bob.Tellez
#UE4 Fix an issue that was causing FullLoadAndSave to fail to cache platform data for textures that were created by landscape on mobile and another issue that caused parallel saving to fail in landscape (when cooking for mobile targets)
Change 3767906 by Mike.Fricker
Add Blueprint functions to query parameters from MIC
- GetScalarParameterValue
- GetTextureParameterValue
- GetVectorParameterValue
MIDs already had these functions, but MICs did not.
Change 3767737 by Max.Preussner
Engine: Fix for external textures referenced by a material before being associated with a media player never having their uniform expressions recached
#author jack.porter
#jira FORT-59777
Change 3767735 by Bob.Tellez
#UE4 Setting Opened to false in FOutputDeviceFile::TearDown so if the device file gets initialized again it will do the same initialization logic as the first time.
#jira FORT-60918
Change 3767244 by Ethan.Geller
#jira FORT-60885 Merge in fix for memory leak from 4.18.1.
Change 3766567 by Marc.Audy
Fix initialization ordering warnings
Change 3766443 by Jian.Ru
Submit PSO locking fix again as it has passed local tests
Change 3766362 by Ori.Cohen
Added the ability to get concurrent captures in Test configurations without having to turn full stats on
Change 3766277 by Marc.Audy
Shrink Skinned and Skeletal Mesh Component, FBodyInstance, and UBodySetup
Change 3766275 by Marc.Audy
Better pack UTexture* classes
Change 3766272 by Thomas.Sarkanen
Fixes to enable auto-nativization for animation blueprints
For blend profiles in particular, I've added subobject support to the fake import table building for nativized assets:
- In FEmitterLocalContext::FindGloballyMappedObject, if we dont find the referenced asset then we traverse the object's outer chain if it is a subobject. We add it to UsedObjectInCurrentClass if we find its outer.
- Updated the structure used to build the fake import table to include a specified outer. Beforehand we assumed that all objects referenced by the import table were 'top-level'.
- Updated the fake import table building code in FLinkerLoad::CreateDynamicTypeLoader() to use the new specified outer if found. This asserts if it couldnt find the outer in the already-parsed dependencies (as it reverse-iterates). If in the general case thius turns out to be a problem we can move this to a two-pass system.
Disabled fast-path optimization when running a native anim BP, as native code is faster!
#jira FORT-52823 - Nativizing Player Animation Blueprints
#jira FORT-57378 - Perf optimization: animation blueprint improvements
Change 3766215 by Marc.Audy
Shink FFromatContainer from 88 bytes to 24 by storing in TSortedMap instead of TMap
Change 3765664 by Michael.Noland
Engine: Add support for sets to FJsonObjectConverter::JsonValueToUProperty
Change 3765624 by Marc.Audy
Create helper macro in Archive.h for encapsulating needed steps for serializing a bitpacked boolean
Change 3765200 by Nick.Darnell
Slate - Fixing a memory leak in the invalidation panel. It never cleared out the cached textures and materials it kept alive during retention.
Change 3764881 by Wes.Hunt
Fix FApp::Get/SetIdleTimeOvershoot. It was overwriting IdleTime, which made FrameTimeWithoutSleep look like FrameTimeWithSleep.
#jira FORT-60585
#review-3764882 @arciel.rekman
Change 3763872 by Max.Chen
Sequencer: Set default completion mode for all sections to project default.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763871 by Max.Chen
Sequencer: Add config for default completion mode for movie scene sequences. The default for level sequences is RestoreState. All others, such as UMG are set to KeepState.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763810 by Gil.Gribb
UE4 - remove some init timing spew in programs (i.e. UHT)
Change 3762939 by Robert.Manuszewski
Removing all locks from FEDLCookChecker to improve SavePackage performance
Change 3762851 by Bob.Tellez
Duplicating CL#3740778 from //UE4/Dev-Editor
Fixed issue with content browser column sorting
#jira UE-49460
Change 3762660 by Bob.Tellez
#UE4 Fix a few parallelsave threading problems.
Change 3761861 by Marc.Audy
Fix archive complaints about bitfield
Change 3761802 by Marc.Audy
Pack FTimeline, FHitResult, FAnimUpdateRateParameters, FMeshBuildSettings
Change 3761299 by Matt.Kuhlenschmidt
Fix levels not being lockable/unlockable if they are not checked out
#jira FORT-60086
Change 3760422 by Bob.Tellez
#UE4 Stop caching or clearing platform data when saving concurrently. This was causing threading problems in materials.
Change 3760113 by Jian.Ru
Back out changelist 3759715 as it causes a crash on UGS autotest
Change 3759761 by Jian.Ru
Clean up some debug comments
Change 3759715 by Jian.Ru
Removing excessive locking when accessing PSO caches.
Change 3759285 by Nick.Darnell
Editor - Fixing the length of the datatable row dropdown in the editor.
Change 3758334 by Alexis.Matte
Fix a crash when importing morph target there was a unsync between some buffer depending on the import options
#jira UE-52319
Change 3758332 by Ben.Marsh
Fix output subfolder being appended twice when generating project files. Causes incorrect command line when launching from Visual Studio.
#jira
Change 3758215 by Brian.Bekich
Make Tint property of FSlateBrush NotReplicated now that it is WITH_EDITORONLY_DATA so that cooked clients can connect to uncooked servers
Change 3757702 by Bob.Tellez
#UE4 Fix -NoConcurrentSave cook option in FullLoadAndSave
Change 3757545 by ben.marsh
Suppress Arxan warning about being unable to install a default guard at it's default location.
Change 3757452 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Fixing build error on linux.
Change 3757389 by Hongyi.Yu
Fixed the crash in UEditorEngine::CheckForWorldGCLeaks() when load a level (level A), PIE, load a sublevel of level A and then load another level.
#jira FORT-58283
Change 3757229 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Change 3757077 by Max.Preussner
MediaAssets: Fix for media texture crashing if media player is generated from GC clustered blueprint
#jira FORT-59774
#jira UE-51943
#tests none
Change 3756854 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Backed out unintentional network checksum change!
Change 3756790 by Bob.Tellez
#UE4 Fix inconsistency with how FSoftObjectPtr case is managed between FLinkerSave and FArchiveSaveTagImports, which would cause a cook ensure under some circumstances
Change 3756639 by Arciel.Rekman
Pool memory (only 64KB allocations) on servers (FORT-60342).
- Has a fixed cost of 1GB virtual memory usage.
#jira FORT-60342
Change 3755995 by Alexis.Matte
Fix crash when importing morph target with "built in" tangent option
#jira UE-52319
Change 3755896 by Arciel.Rekman
Remove unnecessary switch for profiling (part of FORT-58878).
- -fno-omit-stack-pointer is only needed when getting callstacks for perf.
#jira FORT-58878
Change 3755711 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Initialize network GuidCache entries as soon as Guids are registered on the server so that we can fill them out with valid information before the object is destroyed. Fixes issues when a guid is exported for the first time to send a destroy to clients. (from RyanG)
Change 3755701 by David.Ratti
FObjectReplicator no longer a GCObject since adding/removing from the global GCObject list is too slow. Managing FObjectReplciators's object references at the NetDriver level now.
#jira FORT-60317
#review-3755702 @Ryan.Gerleve
Change 3754928 by Arciel.Rekman
Linux: add LTO support and more.
- Adds ability to use link-time opitimization (reusing current target property bAllowLTCG).
- Supports using llvm-ar and lld instead of ar/ranlib and ld.
- More build information printed (and in a better organized way).
- Native scripts updated to install packages with the appropriate tools on supported systems
- AutoSDKs updated to require a new toolchain (already checked in).
- Required disabling OpenAL due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219089
#jira FORT-58878
Change 3753986 by Ben.Zeigler
#jira UE-45505 Fix issue where FCoreUObjectDelegates::OnAssetLoaded was being called from an inner loop inside EndLoad. Maps would register components from that callback, and if those registers started their own loads, those objects would be returned in a partially loaded state. We now defer the asset loaded callback to the very end of the loop so recursive loads work properly
Change 3753274 by Ben.Marsh
Fix blank lines in errors and warnings being omitted from notification emails.
#jira
Change 3753175 by Thomas.Sarkanen
Fix hang in animation editor menus
Sound waves were being loaded by the visibility delegate for the 'play' button overlay. This caused major hangs as the ogg compressed data was built on the fly. Handled the unloaded asset case in the various delegates.
Also made the menu larger, as picking a sound wave was all but impossible when you couldnt even see one in the list.
#jira UE-52271 - Persona menu option locks up editor
Change 3752887 by Nick.Darnell
Slate - Adding automatic invalidation to a few more widgets that were found lacking when adding or removing children.
Change 3752785 by Marc.Audy
Avoid doing any work to evaluate streaming volumes if there are no player controllers using streaming volumes
Change 3752185 by Ben.Marsh
Reduce cook time regression caused by correcting package names to match case on disk (to fix deterministic cooking problems). Switched to use IPlatformFile::GetFilenameOnDisk(), and improved performance of FWindowsPlatformFile::GetFilenameOnDisk() by using GetFinalPathNameByHandle() instead of recursively searching up the directory tree.
#jira
Change 3751813 by Ben.Marsh
Improve parsing of diagnostics for deterministic cooking test. Now allows multiple lines in the generic EC error/warning matcher if indented more than the first line, and skips over empty lines.
#jira
Change 3750413 by Ben.Zeigler
Fixes for cook save performance regressions. Add GetAllMarks to object and use that to dramatically reduce contention for the object mark annotation. Implement ShouldLoadForServer/Client directly on some core classes to stop it from calling the slow generic one
Fix issue where refreshing tags for asset registry would do a very slow array delete/add
Improve speed of redirectcollector, there's no need to force-rehash the soft object path list as the remove handles it conditionally
Change 3750014 by Lina.Halper
- duplicate change from following changelists
CL 3669273 - delete all tracks option
- allow to opt out on bone track importing
- fixed pose preview for fullbody to select weights that has pose from asset.
CL 3672170 Remove track support for Animation Blueprint Library
This is required for facial pose retargeting
Change 3749714 by Brian.Bekich
Back out changelist 3748287
#jira FORT-60125
Change 3749377 by Robert.Manuszewski
Improved log formatting for reporting deterministic cook issues.
#jira FORT-59919
Change 3749360 by Robert.Manuszewski
Improved performance of -diffonly mode for cook commandlet for assets with hundreds of thousands of differences.
#jira FORT-59919
Change 3748746 by Hongyi.Yu
Fixed compiling error in Automation project
#jira FORT-59621
Change 3748530 by Mike.Fricker
Fixed non-determinism of landscape grass across platforms/compilers
This causes bushes to be located in different places depending on what platform you were playing on.
1) Random number reseeds were happening as part of function arguments to FVector(), but function argument evaluation order is unspecified, and behaved differently on Consoles/Mac/Windows. Fixed this bug.
2) Strings used for foliage CRCs could use different character sizes on different platforms. Now we always use ANSI.
3) Strings used for CRCs could have possibly have different case. Now forced lowercase.
#jira FORT-60109
Change 3748471 by Zak.Middleton
Added stats to NetDriver TickFlush and stats gathering within that function.
Change 3748287 by Brian.Bekich
Adding net.MaxStringSerializationSize to cap maximum string read from network, default to 4096, used by FNetBitReader
Deprecating MAX_STRING_SERIALIZE_SIZE in favor of the cvar
FInBunch defaults to prior behavior if cvar is 0
UPackageMap::SerializeName and UPackageMapClient::SerializeNameAsString will always cap at NAME_SIZE
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3747980 by Bart.Hawthorne
In Oodle, only generate and write dictionaries on Windows, Mac, and Linux
Change 3747642 by Gil.Gribb
Fix CIS
Change 3747635 by Zak.Middleton
Avoid string alloc on every ServerMove() call on the server.
Change 3747560 by Gil.Gribb
UE4 - Fixed XBox and Windows thread priorities. Only 2 though -2 seem usable and some of the old values were being ignored.
Change 3747548 by Gil.Gribb
UE4 - Changed thread pool to be TPri_SlightlyBelowNormal so that they will not preempt HP task graph tasks.
Change 3747544 by Bart.Hawthorne
When detecting if Oodle is installed, use the newest version instad of the oldest one.
Change 3746440 by Robert.Manuszewski
Dterministic cook issues reporting improvements
- Huge performance improvements
- Added new metric to the summary: NumberOfDifferencesInPackages
- Diff stats have their own section now (Package.Diff)
- When running with -diffonly there commandlet will not log the Warning/Error summary anymore
- Callstacks are no longer logged with instruction addresses
- Because callstacks are no longer logged with addresses I can collapse them for structures that otherwise would be split into multiple separate callstacks
- Callstacks, Serialized Object and Serialized Property are now indented
- Each asset is capped at 5 entries. If there's more differences, they'll be logged as single warning.
- Replaced \r\n with \n in the callstack log to make it work better with EC
#jira FORT-59919
Change 3746426 by Gil.Gribb
UE4 - Tuned dispatch in the deferred renderer. Added r.DoPrepareDistanceFieldSceneAfterRHIFlush and defaulted it to on.
Change 3746348 by Mike.Fricker
Added new CVars to toggle level streaming behavior
- No effective change to engine yet. The defaults values enable the same default behavior.
- New CVar: "s.ForceGCAfterLevelStreamedOut" (Whether to force a GC after levels are streamed out to instantly reclaim the memory at the expensive of a hitch.)
- New CVar: "s.ContinuouslyIncrementalGCWhileLevelsPendingPurge" (Whether to repeatedly kick off incremental GC when there are levels still waiting to be purged.)
- New CVar: "s.AllowLevelRequestsWhileAsyncLoadingInMatch" (Enables level streaming requests while async loading (of anything) while the match is already in progress and no loading screen is up)
Change 3746127 by Gil.Gribb
UE4 - Slight tweak to more agressively batch occlusion queries.
Change 3746111 by Cecil.McRae
Change 3745681 by Bob.Tellez
#UE4 Prevent attempting to execute a remote process to get the metal shader compiler version if no remove process machine has been configured. (Fixes a warning)
Change 3745631 by Matt.Kuhlenschmidt
Fix details panel crash after compiling blueprints that have edit conditon properties
Change 3744544 by Gil.Gribb
UE4 - Downgraded a fatal error to a warning. Example: Found package without a linker, could find SceneComp in /Game/AIDirector/AIDirector_Fortnite, but somehow wasn't finished loading. This is a sort of cook mismatched caused by the fact that all PS4 cooks have server-only data in them.
#jira FORT-59879
Change 3744419 by Matt.Kuhlenschmidt
Fix opening color picker causing values to change. Was due to conversion between srgb and linear color.
Change 3744270 by Ben.Marsh
Merging change to include deterministic cooking summary from Dev-Core (CL 3743182).
#jira FORT-59919
Change 3743621 by Guillaume.Abadie
Fixes subsurface profile fallback to lit shading model when Opacity == 0, introduced by 3447144.
#jira UE-51569
Change 3743403 by Gil.Gribb
UE4 - Merged lockfree / taskgraph fix from //UE4 (CL 3732262)
Change 3743392 by Gil.Gribb
Merged IO fixed from //UE4 (CL 3641155)
Change 3743376 by Gil.Gribb
UE4 - Added r.WarningOnRedundantTransformUpdate to produce warnings on redundant transform updates.
Change 3743372 by Gil.Gribb
UE4 - Added a stat for distance field verification...which takes a very long time, but does not affect test or shipping config.
Change 3743030 by Bob.Tellez
#UE4 Revert some code the was accidentally merged to UE4Main
#jira UE-52032
Change 3742611 by Josh.Markiewicz
#UE4 - fix for crash in destructor probably related to the freeing of memory via default destructors AFTER CefShutdown() has been called
#tests crashes before, no crash after (not sure if it was a 100% crash but this seems better regardless)
Change 3742187 by Nick.Darnell
Slate - Adding a new optional parameter to direct routing for the widgets under the cursor in Slate Application. Essentially ProcessReply occasionally needs to know the widgets under the cursor, the previous implementation, just used the routing path, this results in missing sending mouse leave messages to widgets under the cursor when dragging begins, which often left things with hover effects in bad states.
Change 3742053 by Michael.Trepka
Copy of CL 3713881
Added -buildscw to Mac Build.sh script to build ShaderCompileWorker in addition to the requested target. Xcode passes it to the script when building non-program targets.
#jira UE-31093
Change 3742050 by Michael.Trepka
Copy of CL 3711085
Reenabled UBT makefiles on Mac
Change 3741924 by Josh.Markiewicz
#UE4 - delete EpicSurvey module
- working toward engine/plugins/online removal from game branch
Change 3741865 by Nick.Darnell
UMG - Fixing a High DPI bug that wasn't scaling the offset for DragDrop widgets when using In-Window rendering that games depend on for DragDrop effects.
Change 3741442 by Ryan.Gerleve
Fix initialization order warnings
Change 3741370 by Ryan.Gerleve
Back out changelist 3689397. The memcpy in one of the FInBunch constructors is not portable and causes this change to break networking on Android.
Change 3740914 by Peter.Knepley
Restore player name obsfuscation
Change 3740828 by Marc.Audy
Dynamically create FKey if the char code is unknown
#jira FORT-59735
Change 3740811 by Ben.Marsh
UAT: Fix double-spacing of lines output by Utils.RunLocalProcess, and use a non-local function to output them for more readable logs.
#jira
Change 3740328 by Bob.Tellez
#UE4 Fix FullLoadAndSave cook method
Change 3740327 by Bob.Tellez
#UE4 Minor movie scene cooking improvements
Change 3740280 by Bob.Tellez
#UE4 Fix shipping config CIS
Change 3740232 by Bob.Tellez
#UE4 Gave OodleHandlerComponent a short name so it doesnt hit maxpath length issues on build machines.
Change 3740209 by Nick.Darnell
UMG - Finishing the ability to add a "Custom" method for Navigation. Currently the editor implementation leaves me wanting, but it works for now. You can put the name of a function to call (needs to match a signature that returns a UWidget).
Change 3740207 by Nick.Darnell
Slate - Navigation attempts when the user claims they are doing custom or explicit, if those methods don't return a valid widget, we don't treat it like the attempt failed and fallback to default navigation methods. Instead we use it as a trigger to indicate that no navigation should occur and treat it like a stop.
Change 3740189 by Bob.Tellez
#UE4 Fix mouse cursor position being set when hovering over the viewport in windowed mode despite not having focus
Change 3740171 by Marc.Audy
Fix merge issue causing compile error for AutomationTool
Change 3739270 by Ben.Woodhouse
Use background task graph affinity on platforms that implement it (e.g. XB1). Saves 8ms on GC spikes and ~0.5ms on the renderthread
#jira FORT-56961
Change 3739244 by Ben.Woodhouse
-statunit commandline option
Change 3738920 by peter.knepley
Fix issue where simulated proxies had bad crouch state when re-entering relevancy
Change 3738904 by Gil.Gribb
UE4 - Moved audio decompression tasks to the background thread pool. Controlled by a cvar AudioThread.UseBackgroundThreadPool, which defaults to 1.
Change 3738378 by Ori.Cohen
Added better profiling for scene query hitches
Change 3736984 by Ben.Woodhouse
Dummy merge: Accept main version of windowsrunnablethread.h, so Windows gets the new priorities
#jira FORT-56700
Change 3736754 by Zak.Middleton
Remove engine hacks of K2_SetActorLocation etc for pending engine merge. Will replace with delegates on transform updates for relevant classes.
Change 3736282 by Hongyi.Yu
Don't check target file while doing iterative shared prebuild cooking.
#jira FORT-58911
Change 3736109 by Michael.Trepka
Updated FMallocLeakDetectionProxy to not use a critical section internally on top of thread safety measures performed by FMallocLeakDetection and the underlying FMalloc implementation. The improvements are biggest on Mac, in particular in low framerate situations, as Metal RHI uses malloc heavily on multiple threads, but it's also a nice 10% improvement on a high end PC.
#jira FORT-55309
Change 3735765 by Ben.Woodhouse
Fix GTSynctype logic when vsync is disabled. This was breaking profiling
Change 3734436 by Marcus.Wassmer
More reliable Aftermath data.
#jira FORT-45518
Change 3734103 by Bob.Tellez
#UE4 Exposing GetRefPosePosition on SkinnedMeshComponent to BPs
Change 3733985 by Saul.Abreu
#jira FORT-58816
"Special case zero-width space in the text shaper to avoid fonts rendering the fallback glyph" - Jamie Dale
Needed to workaround an issue with guillemets (weird arrow quotes).
Change 3733922 by Brian.Bekich
Setting max serialization size in FNetBitReader to prevent runaway string reads from replicated object paths
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3733850 by Max.Chen
Sequencer: Return unhandled only if not dragged. This fixes a bug where dragging in the track area would sometimes leave the handled state with the time slider controller and not allow you to pop up a menu with the movement tool.
#jira FORT-56092
Change 3733299 by Ethan.Geller
#jira FORT-58943 Handle corner cases for repeated calls to precache buffers.
Change 3732907 by Gil.Gribb
UE4 - Removed slow HLOD code from frustum cull loop and set things up at AddPrim time instead. Saves 1-3ms.
Change 3732728 by Robert.Manuszewski
Fixing a crash when dumping stats with massive callstacks
#jira FORT-58901
Change 3732438 by Marc.Audy
When a client informs the server that it has loaded a streaming level force a net update on all dormant actors that have at one point replicated data to relevant clients and ensure that the connection's destroyed startup/dormant actors list is properly populated.
#jira FORT-56997
Change 3730413 by Lukasz.Furman
fixed PlayerName encryption key
#jira FORT-59066
Change 3729588 by Bob.Tellez
#UE4 Only calling FixupData on load. Fixes crash during parallel saving.
Change 3729475 by Marc.Audy
Fix missing ;
Change 3729444 by Marc.Audy
Fix cases where GetWorld() being called multiple times per function
Change 3729143 by Hongyi.Yu
Added support to extract pak files to mount point.
- Extract with "-ExtractToMountPoint" when extracting pak in DiffCookedContent()
#jira FORT-58635
Change 3728981 by Nick.Darnell
Slate - Fixing a bug with Slate turning on statid tracking even when the slate verbose stats are not being used.
Change 3728838 by Zak.Middleton
Compile out GetWorld() call in check() in Test and Shipping builds, to avoid skewing profiling.
Change 3728604 by Jian.Ru
Submit one render command rather than many in FScene::UpdateParameterCollections
Change 3728434 by Marc.Audy
PostSignificance should always fire when unregistering regardless of whether this is the last object in the tag.
Change 3728427 by Gil.Gribb
UE4 - reduce stat overhead when not collecting stats.
Change 3728197 by Marc.Audy
Properly call post significance on initial registration if the post significance type is sequential
Change 3726266 by Gil.Gribb
UE4 - Force HISMC trees to rebuild during cook. This allow us to change parameters without resaving maps.
Change 3724501 by Marc.Audy
Fix initialization order
Change 3724411 by Ben.Woodhouse
Point light shadow rendering optimization - Made per-triangle culling take Z into account.
In FortGPUTestbed (with grass shadow casting enabled), GSVerticesOut reduced from 464k to 234k.
On xbox one, a pointlight GPU cost reduced from 6.7 to 4.1ms.
On PS4, GPU cost went from 2.3 to 1.9ms.
#jira FORT-58921
Change 3724367 by Chad.Garyet
Downgrading lock warning about still waiting to a message instead of a warning.
Change 3723903 by Max.Preussner
MediaAssets: Merged workaround for uninitialized media sound waves from 4.17
#jira FORT-57260
Change 3723134 by Lukasz.Furman
added deprecation for PlayerState.PlayerName, it should remain accessible only through Get/Set functions to control obfuscation
Change 3722955 by Jian.Ru
Fix a compilation warning
#jira FORT-58749
Change 3722667 by Luke.Thatcher
[BUILD] [!] Fix PGO failures on build machines.
- The strings "Failed" and "error" are always treated as build failures, even if the build task returns a success code.
- Failure to reserve a device should not be fatal.
#jira FORT-58001
Change 3722291 by Lukasz.Furman
restored public access to PlayerName for now, current code will be going through accessor
Change 3721012 by Alicia.Cano
chunk title file generation
#jira FORT-53605
Change 3720961 by Marcus.Wassmer
Fix bad UVDensities on objects causing texture streaming to fail. Better fix will come with the engine merge.
#jira FORT-58240
Change 3719318 by Lukasz.Furman
replaced old branch name assertions
Change 3719047 by Lukasz.Furman
added branch name assertion to core headers to avoid duplicating it
Change 3718499 by peter.knepley
Fix for a crash when calling FSlateApplication::Get().FindPathToWidget in response to a widget destructing. Widget must be invalidated before the reference is cleared or else someone else might assign a shared reference to it during destruction.
Change 3716965 by Alicia.Cano
No sound was playing for Android.
#jira FORT-58302
#android
Change 3715746 by Ben.Marsh
Hide Arxan warnings about PDB files not being present.
#jira
Change 3715172 by Bob.Tellez
#UE4 FullLoadAndSave now does SavePackage in parallel.
Change 3715055 by Bob.Tellez
#UE4 Fix to actually use the precached streaming audio DDC data when cooking.
Change 3714130 by Bob.Tellez
#UE4 Core changes to allow SavePackage to be done concurrently
Change 3714099 by Bob.Tellez
#UE4 Pull the logic to initialize and uninitialize the physics scene for a world out into separate functions
Change 3713145 by Ben.Marsh
Disable an Arxan warning in EC.
#jira FORT-56926
Change 3712904 by Ben.Woodhouse
Fix for gpu profiler crash on pre-maxwell nvidia (or when r.gpuprofiler is set to false)
Change 3712693 by Ben.Woodhouse
Workaround for PS4 flip thread crash in dev builds. Caused by the flip thread/offset threads being shutdown before being initialized. The high level logic is now robust to that. We should fix the PS4 RHI ideally, but this is simpler for now.
#jira FORT-58409
Change 3712544 by Ben.Woodhouse
add missing skylight diffuse gpu stat
Change 3712515 by Ben.Woodhouse
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3712297 by Mike.Fricker
Fixed huge client hitch when applying changes to in-game options
- Every component was being re-registered when r.SimpleForwardShading was updated by the scalability system, even if the value hadn't changed. Now, it only re-registers components if the value changes on the fly. (e.g. when turning Shadows off or on PC)
#jira FORT-57661
Change 3711501 by Ben.Marsh
Fix build failure on Linux.
#jira
Change 3710962 by David.Ratti
Add SCOPE_CYCLE_UOBJECT for SourceObject of GE - this will tell us what weaponw as applying the GE
Change 3710602 by Marc.Audy
Only create MIDs as a child of the calling object if construction script is running
Change 3710421 by Ben.Woodhouse
Bring over a couple of XB1 rendering fixes from 4.18
3692692: Integrate XB1 translucent lighting fix
3674543: D3D12 : Fix bug with non-CS version of UpdateTexture3D caused by bad depthstride. This was causing corruption in the indirect lighting cache
#jira UE-49416
Change 3710338 by Marc.Audy
Fix Json <-> Property converter to handle maps with struct keys
Merged from CL# 3521195
#jira UE-46616
Change 3710226 by Bob.Tellez
#UE4 Increase TaskGraph stack size in editor builds since. SavePackage uses a deep callstack which exceeds the 384 memory limit
Change 3709046 by andrew.grant
Added ALLOW_CONSOLE_IN_SHIPPING define that Target.cs files can set to turn on console in shipping builds
#jira FORT-57180
Change 3709040 by andrew.grant
Fixed issue where this could fail if a messagebox was spawned early during initialization
Change 3708830 by Bob.Tellez
#UE4 Commandline switches/options are no longer detected when found between quote characters. This causes options from not being incorrectly detected when passed in as a value from another options. i.e. -Option="-log" no longer causes -log to be picked up. This removes the syntax of specifying parameters like "Option=Value", which should now be replaced with -Option="Value"
#jira FORT-57833
Change 3708826 by Bob.Tellez
#UE4 Removed needless calls to RegisterSerializedShaders in the saving codepath of material serialization. This function is only relevant when loading shaders.
Change 3707905 by Ori.Cohen
Fix attached skinned mesh never being unhidden due to scale 0 and render tick optimization
#jira UE-51485
Change 3706450 by Chris.Bunner
Removing illegal material set on decal component in GameplayStatics.
Set a related JIRA, this doesn't actually fix the issue but contributes.
#jira FORT-51597
Change 3706223 by Marc.Audy
Shrink UPackage class size substantially
Change 3706221 by Marc.Audy
Store CustomVersions in array rather than set
Change 3705798 by Bob.Tellez
#UE4 ShadowDepthVertexShader.usf fix to fix Mac cook.
Change 3705613 by Uriel.Doyon
Texture streaming integration from Main.
#jira FORT-57376
Change 3705137 by Michael.Trepka
Fixed MetalRHI warning when compiling without MALLOC_LEAKDETECTION defined
#jira FORT-55309
Change 3704310 by Marcus.Wassmer
fix d3ddebug error with shadowcasting pointlights
also suppress spammy d3ddebug data about texture debug names
#jira FORT-58063
Change 3703477 by Marc.Audy
Minor tweak to keep Padding on one cache line.
Change 3703449 by Michael.Trepka
Don't use parallel RHI execute on Mac if MALLOC_LEAKDETECTION is enabled as this combination affects performance significantly due to mutex locking in FMallocLeakDetectionProxy
#jira FORT-55309
Change 3703217 by Marcus.Wassmer
Update PS signatures to match VS. Fixes crashes when running witih -d3ddebug which we need to catch real problems
#jira FORT-58021
Change 3702926 by Aaron.Eady
#JIRA na
Engine Code Improvements (that this project doesn't have yet);
Added engine code for drawing a debug 2D box.
Added engine code that allows for Keyboard Shortcuts to be special characters like backslash \.
-- Code --
DrawDebugHelpers:
DrawDebugCanvas2DBox() - Added this to allow us to draw debug 2D boxes.
RemoteConfigIni:
SpecialCharMap - Updated this TCHAR* property to be in the right order so you can use special characters like backslash as keyboard shortcuts.
Change 3701976 by Michael.Noland
Editor: Rewrote CallInEditor support and promoted it so it can be used on functions in any class, not just blueprints derived from AActor:
- CallInEditor used on native UFUNCTION() declarations will now show up without having to make a BP subclass
- CallInEditor can now be used as a top-level keyword in the UFUNCTION() declaration (e.g., UFUNCTION(Category=CoolCommands, CallInEditor))
- Now shows each function as a separate button, placed in the category associated with the function
- The button strip entry is now searchable by function name or tooltip
- Prevented operating on functions that have parameters or return values, which would crash before
- Removed the duplicate copies of properties placed in the Blutility section
- Added a scoped transaction around CallInEditor execution
- Allowed functions to be marked as CallInEditor in addition to custom events (currently we don't allow editing category or tooltip on custom events...)
Editor: Moved Experimental/EarlyAccessPreview details customizations up to UObject so it can be used on any class, not just actors/components
Edigrating CL# 3374995, 3375121, and 3375308 from Dev-Framework to FN main
Change 3700836 by Bob.Tellez
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
#jira FORT-57833
Change 3700821 by Bob.Tellez
Merging CL#3461205 from //UE4/Dev-Core
Fixed parameter parsing so that arguments are not parsed if not preceeded by a whitespace (for example "-Log" was parsed in "TM-Log")
#jira UE-33790
Change 3699584 by Chad.Garyet
Upping the timeout on symstore to half an hour instead of 15 minutes. Symstore on xbox takes about ~22 minutes and if two builds are going simultaneously it can cause a job to fail due to the timeout being hit.
#jira FORT-0
Change 3698692 by Aaron.McLeran
#jira FORT-57582 crash in sound mix state code
- Removed the assert as it looks like that state is now possible.
Change 3698411 by Bob.Tellez
#UE4 One last correctness fix for when to not save generated base ini files.
#jira FORT-57315
Change 3698390 by Bob.Tellez
#UE4 Slightly more accurate logic to prevent writing of base ini files (old logic may have prevented writing of non-base ini files)
#JIRA FORT-57315
Change 3698369 by Bob.Tellez
#UE4 Ensure that Tcp/Udp messaging plugins are disabled in shipping config
Change 3698352 by Bob.Tellez
#UE4 Minor additional fix to make sure DISABLE_GENERATED_INI_WHEN_COOKED only affects cooked builds
#jira FORT-57315
Change 3698341 by Bob.Tellez
#UE4 DISABLE_GENERATED_INI_WHEN_COOKED now properly prevents all base ini file loads from happening from a generated folder. It also prevents writing generated ini files completely.
#JIRA FORT-57315
Change 3697553 by Nick.Darnell
Slate - When setting the content of an SBox it should always invalidate.
Change 3697330 by Bart.Hawthorne
APlayerController::ServerShortTimeout_Implementation now only iterates over the active object list instead of uisng an actor iterator, since non-replicated actors wont have a network object info to update.
#jira FORT-57099
#tests ran 100 player bot match
Change 3695578 by Bob.Tellez
#UE4 Fix Win32
Change 3695508 by Eric.Newman
Tweaked LogInit logging to clarify when the command line is being filtered
* Encountered this red herring when evaluating crash logs
#jira FORT-55839
#tests ran shipping & debug client builds, and editor game build
Change 3694898 by Michael.Trepka
Fixed Vorbis audio not playing on non-Windows platforms due to changes in CL 3668361
#jira FORT-57121
Change 3694655 by David.Ratti
Reimplement TweakObjetPtr optimizations with FObjectReplicator as an FGCObject instead of the owning channel being responsible for adding the replciator's ObjectPtr to the reference collection. (There are cases where object replicator ownership is transferred).
#JIRA FORT-57298
Change 3694491 by Ben.Woodhouse
Change courtesy of Gil: Drop the priority of the texture streamer using a new low-priority thread pool. This saves a 1-2ms in heavy combat in PVE (XB1 Test)
#jira FORT-57376
Change 3693609 by Ryan.Gerleve
Back out CL 3689050 since it was likely causing a crash.
#jira FORT-57298
Change 3693327 by Aaron.McLeran
#jira FORT-57416 Fixing PS4 cook.
Making sure zero pad bytes stays positive without a check.
Change 3693136 by David.Ratti
fix clang warning
Change 3692703 by Thomas.Sarkanen
Fix CIS warning on PS4/Linux
Change 3692589 by Thomas.Sarkanen
Moved exposed value handler bound function initialization to CDO postload
This means that FindPropertyByName and FindFunctionChecked dont incur any overhead when spawning in new anim instances
#jira FORT-56968 - Hitch - SkeletalMeshComponent initialization (110ms)
#tests PIE PvE, 20-bot BR game on PC/PS4.
Change 3692552 by Alex.Delesky
Change 3692495 by Bart.Hawthorne
Fix build
Change 3692488 by Bart.Hawthorne
Check for actor relevancy and level initialization when there's no channel first when prioritizing actors for replication. Dormancy checks in this case are useless because ShouldActorGoDormant will always be false, and if IsActorDormant is also true, then the result of skipping the actor is the same.
#jira FORT-57104
#tests played 100 player bot match
Change 3691819 by Bob.Tellez
#UE4 No longer conditionally including SlateDebug fonts in the cook based on configuraiton. When builds are produced that contain more than one configuration it changes what is cooked in unexpected ways so now we just always cook this font.
Change 3691805 by Bob.Tellez
#UE4 CIS fix
Change 3691784 by Bob.Tellez
#UE4 Optimization for exiting PIE. Texture streaming managers have an optimization for game worlds but were not using them for PIE worlds
Change 3691273 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3691268 by Aaron.McLeran
#jira FORT-56228 LogAudio:Warning: spam causes severe performance drop on the Mac Platform
Reducing log level
Change 3690547 by Ryan.Gerleve
Speculative fix #2 for a server crash/assert. If the timing is right, it's possible for the server to try to re-load a placed-in-map actor that was previously garbage collected. This was happening because CanClientLoadObject was always returning true for these (null) objects, even if the NetGUID corresponded to a map actor that shouldn't be loaded. Also added/improved some logging that will help in case this doesn't fix the issue.
#jira FORT-55763
Change 3690451 by Lukasz.Furman
changed branch name testing in engine hacks to use case insensitive match
Change 3690270 by David.Ratti
Cache weak object ptr in FNetworkObjectInfo to avoid reconstructing one every time we need to lookup its actor channel.
#jira FORT-57156
Change 3690227 by David.Ratti
Added optional TWeakObjectPtr parameter to packagemap functions GetOrAssignNetGUID, SUpportsObject. This allows you to pass in a weak ptr for an object if its already created. If you pass in null, the functions will create them internally.
This fixes some common cases where we were converting the same object into weak ptr multiple times in a frame.
#jira FORT-57156
Change 3690184 by David.Ratti
Cache net connection weakobjectptr when building consider list instead of constructing it again for every actor.
#jira FORT-57156
Change 3689805 by Peter.Knepley
Make ConditionalInitAxisProperties protected instead of private
#jira FORT-56414
Change 3689789 by Marcus.Wassmer
Hack workaround for missing shadowdepthps for XB1 until we get a handle on why things are exploding
#jira FORT-56792
Change 3689702 by Peter.Knepley
Allow games to have a custom MassageAxisInput function
#jira FORT-56414
Change 3689687 by Bob.Tellez
#UE4 Avoid copying the shaders array to avoid changing refcounts of shaders while serializing
Change 3689655 by Peter.Knepley
Make SmoothMouse virtual so games can have their own smoothing
#jira FORT-56417
Change 3689499 by Bart.Hawthorne
Fix Linux CIS warnings
Change 3689397 by Bart.Hawthorne
Changed FOutBunch and FInBunch uint8 entries to use bitfields instead of bytes which knocked 86% off of our net tick time
Change 3689056 by Lukasz.Furman
3rd attempt for branch name checking in engine code hacks
Change 3689050 by David.Ratti
First pass at removing use of TWeakObjectPtr from core replication classes. This should reduce FWeakObjectPtr::Get usage.
Still expecting to see FWeakObjectPtr::operator= come up a lot. Going to tackle this in a second pass which will require some deeper refactors.
#jira FORT-57156
Change 3688972 by Bob.Tellez
#UE4 Add build target flag to control DISABLE_GENERATED_INI_WHEN_COOKED
Change 3688864 by Ryan.Gerleve
Fix broken logic to find the "best" replay sample for character movement when we don't find two samples to interpolate between. Now uses the sample closest to the current time. Also added some debug drawing.
#jira FORT-56553
Change 3687654 by Bob.Tellez
#UE4 Added compile time option to disable reading generated ini files other than GameUserSettings in cooked builds.
Change 3686615 by Lukasz.Furman
Back out changelist 3686610
Change 3686592 by Matt.Kuhlenschmidt
Gave the CL description in the source control submit window more room
Change 3686020 by Ben.Marsh
Remove debug code that prints to logs while building.
#jira FORT-56923
Change 3684414 by Peter.Knepley
Back out changelist 3678336
#jira FORT-56512
Change 3683894 by Gil.Gribb
UE4 - By default, do not check for illegal calls to MarkPendingKill in the garbage collector in test and shipping configuations. This was slow.
Change 3683686 by peter.knepley
Raise MTU from 512 to 1024
#jira FORT-56756
Change 3683343 by Rob.Cannaday
Fixes insert disk popup
#jira FORT-56500
Change 3683156 by Peter.Knepley
Network optimizations to reduce alloc/free & memcpy churn saving about 10% of net tick time
Change 3682234 by Guillaume.Abadie
Cherrypick TAA refactor 3512696 and TAA fix 3668108
#jira FORT-56303
Change 3681494 by Bob.Tellez
#UE4 IsLoadedByEditorPropertiesOnly is not working properly so I removed it from FullLoadAndSave
Change 3681342 by Bob.Tellez
#UE4 Added a FullLoadAndSave option to cooking, which simply loads all content then saves it to avoid the overhead of managing which packages need to be cooked. Large perf improvement for those who cook by the book and can fit the entire game in memory
Change 3681014 by Yenal.Kal
#jira FORT-56209
#jira FORT-56272
Fixed a bug in the ability system where the ability ended callbacks could cause the ability end to be called again in the same call stack even though the ability is activated only once.
This was happening because we were broadcasting the event before we decrement the active count.
Change 3680739 by Michael.Trepka
Warn about NaN float literal values when translating HLSL to Metal instead of failing, plus added more detailed warning/error messages for NaN and unhandled values
#jira FORT-56425
Change 3679237 by Bob.Tellez
#UE4 Remove some debug logging
Change 3679187 by Bob.Tellez
#UE4 Dramatically imrpove speed of writing cookloadorder log file
Change 3678926 by Bob.Tellez
#UE4 Minor savepackage speed improvements
Change 3678336 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3676998 by Ben.Woodhouse
Fix XGE shader compilation so it doesn't crash randomly
Change 3676606 by Ori.Cohen
Update GC to be 61.1 to avoid heartbeat collision
Change 3676447 by Ori.Cohen
Fix CIS warning
Change 3676286 by Max.Preussner
Fixed client Crash UMediaSoundWave::GeneratePCMData (FORT-56107)
#jira FORT-56107
Change 3674591 by Ryan.Gerleve
Don't filter out PendingKillPending actors from FNetworkObjectList::Find. This was causing actors that get destroyed while dormant on the server to never be destroyed on clients.
#jira FORT-55802
Change 3674181 by Michael.Noland
Framework: DLL export LogGameplayTags
Change 3674138 by Billy.Bramer
#jira FORT-56138, FORT-56139
- Duplicate CL 3396590 from //Orion/Main re: ranged-base for iteration ensure from montage changes
Change 3672464 by Lukasz.Furman
removed recast layers crash tracking code
Change 3672153 by Daniel.Lamb
Added some debugging code to help track down why shaders are hashing poorly.
Change 3671498 by Luke.Thatcher
[~] Modify new frame syncing to reduce performance regression seen when the game is running over budget.
- Rather than forcing a flip sync after we kick off one frame early, we just continue to kick frames if we time out. This allows the game thread to get ahead when we're over budget.
- The game thread will naturally resync with the vsync when we return to being in budget.
#jira FORT-55842
Change 3671079 by Ryan.Gerleve
Fix an edge case where the PackageMap on the server would try to resolve objects from default NetGUIDs even if their outer has already been garbage collected. This could lead to a completely unrelated object being returned instead of null, leading to asserts and potentially other issues.
#jira FORT-55763
Change 3670487 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3670351 by Zak.Middleton
Back out changelist 3669817 (networking optimizations). Would rather have more testing before it goes to Release-Next. Will resub just for main and RP.
#jira FORT-55999
Change 3670344 by Josh.Markiewicz
#UE4 - more verbose logging for SetExpectedClientLoginMsgType
Change 3670323 by Wes.Hunt
Fix for dedicated servers not flushing events in a timely manner.
#jira FORT-56015
Doh, using GFrameNumber was NOT a good idea on servers... :-/
Change 3669817 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3668416 by Michael.Noland
Core: Changed FString::ParseIntoArray to use Reset instead of Empty on the passed in array, allowing it to be approximately resized
#jira FORT-55887
Change 3668411 by Olaf.Piesche
Always cache depth collision particle shader
#jira FORT-51307
Change 3668361 by Aaron.McLeran
#jira FORT-55628 Attempt to bypass crash and log an error if libvorbisdll fails to load.
Change 3667892 by Rob.Cannaday
libwebsocket libs to handle getprotobyname("TCP") failing the libwebsockets connection
#jira FORT-55917
Touch LwsWebSocket.cpp to ensure the module gets built with the new libs
Change 3667308 by Uriel.Doyon
Postponed the release of IO requests when canceling mip updates to prevent threading issue.
#jira FORT-54491
Change 3666835 by Lukasz.Furman
fixed overlapping index buffers when static mesh exports both convex and simple collisions for navigation
#jira UE-50370
Change 3665374 by Mike.Fricker
Fixed server crashing after hotfixes have re-imported curve table data
- The hotfix system is capable of replacing the content of a UCurveTable on the fly
- If any systems had references to inner curves on that curve table, they would become invalid
- This needs to be fixed in 1.6.4 (tonight) and also in 1.7
#jira FORT-55792
Change 3665063 by Daniel.Broder
Fixed crash in GameplayTagQueryCustomization when choosing "Save and Close" on GameplayTagQuery after setting a query due to nullptr NotifyHook in CloseWidgetWindow.
Added additional if (StructPropertyHandle.IsValid()) wrappers and one check(StructPropertyHandle.IsValid()); the former to be consistent with other code and prevent possible crashes, the latter to at least catch the cause of a possible crash properly without having to change the code more significantly to handle it gracefully.
Also changed some if( X ) to if (X) to match coding standards and provide consistency within the file.
Michael, I'm Reviewing you on this fix since you brought this change over from Framework. And Marc because you reviewed him on that change.
#UE4 #NoReleaseNotes #RNX
Change 3664948 by Lukasz.Furman
reduced number of allocations in StorePathfindingDebugData, optimized path length calculations to avoid recursion
#jira FORT-51111
Change 3664916 by John.Abercrombie
Copy CLs 3383318 & 3388506 from //Orion/Main/Engine/Source/Runtime/Engine/...
- Been testing with this for a while now
- This change makes particle effects show up on the current frame's pose for skel meshes as well
Removed my StopAllMontagesByGroupName temp hack
CL 3383318
Delay dispatching of AnimEvents (Notifies and Montage Events) until after we receive an updated animation pose (if applicable).
This fixes AnimNotifies playing particle effects using a socket location using last frame's pose. Now they use the current frame's pose.
CL 3388506
Delay clearing of MontageInstances and triggering 'OnAllMontageInstancesEnded' until all Montage Events have been dispatched.
Also fix SkelMeshComponent ticking on dedicated servers when rejoining in progress.
#jira FORT-55102 - Server Crash UAnimInstance::StopAllMontagesByGroupName
Change 3780616 by Gil.Gribb
Fixed and reenabled r.DelaySceneRenderCompletion
Change 3778979 by Gil.Gribb
UE4 - Improved the performance of grass updates and added the ability to not do all of them every frame.
Change 3778200 by Nick.Darnell
UMG - Making it possible to cancel delays and all animations on widgets. Useful when destroying a widget and needing to stop any async state.
Change 3777612 by Zak.Middleton
Perf: Added option to CharacterMovementComponent to skip immediate forward prediction for proxies on the frame they receive a network update (bNetworkSkipProxyPredictionOnNetUpdate). This avoids all forward prediction sweeps and floor checks on those updates. Intermediate frames will interpolate with prediction. This can also be disabled globally with the CVar "p.NetEnableSkipProxyPredictionOnNetUpdate 0".
Added NetworkSmoothingDisableProxyPredictionForPawnLOD to force disabling full simulation for LOD >= this value (currently 3, so bottom 75 pawns). This takes precedence over current distance and view angle checks for prediction (mesh interpolation is untouched).
Change 3774338 by Ben.Woodhouse
Convert the D3D12 PSO caches to use RwScopeLocks. This change is courtesy of a shelf from Gil, plus a couple of minor fixes.
Saves up to a millsecond of frame time in CPU-bound scenarios
Change 3773462 by Gil.Gribb
UE4 - Add particle batching. This is disabled by default but can improve thread scheduling when there are lots of very fast particle systems.
Change 3771375 by Hongyi.Yu
Fixed the crash where ability components are unregistered and then re-registered, which usually happens in PIE.
Change 3771368 by Ben.Zeigler
#jira UE-52670 Add project setting bValidateUnloadedSoftActorReferences that is true by default to match current behavior. If you set it to false it will no longer load packages to look for soft actor references when deleting/renaming actors.
Change 3771173 by Seth.Weedin
Auto manage attachment support for AudioComponent- An opt-in feature that allows AudioComponents to cache their AttachParent/AttachSocket and only attach themselves when playing audio, detaching after playback is completed. Set to false by default.
Change 3768811 by Ori.Cohen
Change animation scale collision code so that it uses the physics asset.
Change 3768148 by Brian.Bekich
Fix muting being unable to find remote player controller
Change 3768117 by Ori.Cohen
Prevent pawn collision from updating during animation
Change 3766554 by Gil.Gribb
UE4 - Added a new option to add and remove from static draw lists on demand. This is off by default.
Change 3766427 by Nick.Darnell
Slate - Finally adding Opacity to SWidget. Any widget can now be alpha animated at will, no more need to waste overhead by wrapping things with SBorder or making them userwidgets just to be able to animate a fade.
Change 3761682 by nick.darnell
Athena - Introducing a way to interrupt the request to scroll and item into view. In cases where you're animating, quickly showing and hiding, with the item widgets unavailable for a few frames, you enter cases where the deferred navigation is resolved after you've canceled showing a dialog stealing focus.
Change 3761416 by Ben.Zeigler
#jira UE-52287 Prevent cook metadata like DevelopmentAssetRegistry.bin from being packed into a shipping game, by moving it into a Metadata subdirectory and updating deployment scripts to avoid that directory.
Right now it doesn't package them at all, we could change it to package them as Debug Non-UFS if desired
Change it so the asset audit UI will only load DevelopmentAssetRegistry.bin files, the cooked registry files don't have enough information any more to be useful
Remove ability for runtime game to load DevelopmentAssetRegistry.bin, this ended up not being useful
Change 3750998 by Ethan.Geller
#jira FORT-60191 Allow -audiomixer command line arg to work on all platforms.
Change 3749540 by Marc.Audy
SignificanceManager now takes viewpoints in as TArrayView instead of const TArray&
Change 3748102 by Marc.Audy
Allow cheat cvars to work in Test builds by default
Can be overriden by defining ALLOW_CHEAT_CVARS_IN_TEST as 0 in Target.cs files
Change 3744756 by Bart.Hawthorne
Upgrade Oodle to version 2.5.5. Also, iOS, Android, and Switch platforms have been added. The new dictionary has been generated with old and local captures.
Change 3741168 by Max.Preussner
MediaUtils: Fixed movies not playing properly in Shipping builds
Change 3739256 by Jian.Ru
Set distance field self-shadow bias without recreating all render states
Change 3730756 by Ben.Woodhouse
HISM optimization:
Gil's change to skip trees with only one level of hierarchy (working around badly tuned content issues)
Change vert threshold to 2K.
1-2ms renderthread win without impacting GPU when rendering point lights
Change 3724029 by Zak.Middleton
Increase allowed time for movement substep duration. Don't want to lower between 2 iterations, as this is not used much in practice other than deflection and movement mode changes, and that will change behavior (lose momentum). This new setting will absorb longer hitches in the common case (moving without collision or falling).
Change 3723985 by Marc.Audy
SignificanceManager PostSignificanceUpdate functions can now be executed sequentially on the game thread as well as concurrently in the parallel for (old behavior)
Change 3722910 by Jian.Ru
Amortize shadow cache update caused by resolution change
Changed to use view distance vs. view space z when calculating whole scene shadow resolution which is less sensitive to camera rotation
Change 3718247 by Yenal.Kal
Fixed the bug where the gameplay effect durations can show incorrect values after rejoin or after server time drifting away from the client.
Change 3716343 by Jamie.Dale
Adding Korean and Turkish to the localization automation
Change 3710534 by Uriel.Doyon
Texture streaming optimization where a maximum texture resolution for each level streaming data is computed per view.
This is used to cull irrelevant levels and reduce the async task number of iterations.
The culled size is defined by the new r.Streaming.MinLevelTextureScreenSize.
This requires to remove primitives with big UV density from the level data.
Those primitives get moved to the dynamic lists.
This is controlled by r.Streaming.MaxTextureUVDensity
Change 3707207 by David.Ratti
Remove look ahead-vectors prediction in FNetViewer. This (requires) a line trace which is not desirable or really accurate anymore. This saves us a line trace per connection per multicast rpc.
unify reliable multicast rpc handling: these now do relevancy checks and are not sent to non relevant clients
Change 3706272 by Thomas.Sarkanen
Added utility/math functions to aid in optimizing anim blueprints
Added VectorLengthXY to get the 2D length of a 3D vector. Avoids unecessary conversions.
Added polar->cartesian->polar conversion helper functions for expensive frequently-used anim graph functionality.
Change 3706159 by David.Ratti
PlayerState/ASC replication optimizations from Polge: this puts the net update frequnecy on player state back to 1hz while forcing netupdates on the player state actor when the ability system component needs to update
Change 3692891 by David.Ratti
Optimizations for UNetConnection::ClientHasInitializedLevelFor: build acceleration map of actor outer's (ULevels) -> Visibility bool. Existing logic stays the same.
Change 3691392 by Aaron.McLeran
#jira UE-50628 Fix audio trying to sync load bulk data with EDL enabled
- Fix log error in BulkData.cpp
- Make the first stream chunk be force inline payload in bulk data flags so it loads immediately vs in async IO system
- Make audio stream chunks get as close to 256 k chunks as it can, zero-pad rest to be 256 k aligned
- Fix up DDC key, serialize AudioDataSize separately from chunk DataSize
Change 3682683 by Zak.Middleton
Add bOnlyTickMontageOnDedicatedServer variable to AnimInstance, to avoid anim bp updates on dedicated server. Turn on to fix hitching from queued ServerMove() calls, and some free perf during all montages on the server.
Change 3678771 by Ori.Cohen
Added the ability to turn on stack walk during hitching vs lightweight stats
Change 3676363 by Ori.Cohen
Added the ability to get callstacks as part of hitch detection
Change 3674877 by Keith.Judge
Move definition of GFailedToFindParamCollectionBufferQueue to ShaderBaseClasses.cpp so that all targets can successfully compile.
Change 3672515 by Bob.Tellez
Added code to play wind particle effects
Change 3670909 by Zak.Middleton
Fixed ForcePositionUpdate() not calling CheckJumpInput(). Added "p.NetForceClientServerMoveLossPercent" cvar to simulate loss of client->server movement RPCs (without hosing the rest of networking).
[CL 3791033 by Marc Audy in Main branch]
2017-12-05 21:57:41 -05:00
TSharedPtr < HandlerComponent > PacketHandler : : GetComponentByName ( FName ComponentName ) const
{
for ( const TSharedPtr < HandlerComponent > & Component : HandlerComponents )
{
if ( Component . IsValid ( ) & & Component - > GetName ( ) = = ComponentName )
{
return Component ;
}
}
return nullptr ;
}
2019-01-31 12:44:18 -05:00
void PacketHandler : : CountBytes ( FArchive & Ar ) const
{
Ar . CountBytes ( sizeof ( * this ) , sizeof ( * this ) ) ;
OutgoingPacket . CountMemory ( Ar ) ;
IncomingPacket . CountMemory ( Ar ) ;
HandlerComponents . CountBytes ( Ar ) ;
for ( const TSharedPtr < HandlerComponent > & Component : HandlerComponents )
{
if ( HandlerComponent const * const LocalComponent = Component . Get ( ) )
{
LocalComponent - > CountBytes ( Ar ) ;
}
}
// Don't handle EncryptionComponent, as it should be in our components array.
BufferedPackets . CountBytes ( Ar ) ;
for ( BufferedPacket const * const LocalPacket : BufferedPackets )
{
if ( LocalPacket )
{
LocalPacket - > CountBytes ( Ar ) ;
}
}
// Unfortunately, there's currently no way to safely calculate memory usage for TQueues.
// so QueuedPackets, QueuedRawPackets, QueuedHandlerPackets, and QueuedConnectionlessPackets
// can't be tracked without a rework.
BufferedConnectionlessPackets . CountBytes ( Ar ) ;
for ( BufferedPacket const * const LocalPacket : BufferedConnectionlessPackets )
{
if ( LocalPacket )
{
LocalPacket - > CountBytes ( Ar ) ;
}
}
// Don't handle ReliabilityComponent, since it should be in our components array.
// Don't track AnalyticsProvider as that should be handled elsewhere.
}
void HandlerComponent : : CountBytes ( FArchive & Ar ) const
{
Ar . CountBytes ( sizeof ( * this ) , sizeof ( * this ) ) ;
}
2020-09-01 14:07:48 -04:00
EIncomingResult PacketHandler : : Incoming_Internal ( FReceivedPacketView & PacketView )
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
{
2018-10-29 10:01:28 -04:00
SCOPE_CYCLE_COUNTER ( Stat_PacketHandler_Incoming_Internal ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
2020-09-01 14:07:48 -04:00
EIncomingResult ReturnVal = EIncomingResult : : Success ;
FPacketDataView & DataView = PacketView . DataView ;
int32 CountBits = DataView . NumBits ( ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
uint32 SocketCRC = 0 ;
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
SocketCRC = FCrc : : MemCrc32 ( DataView . GetData ( ) , DataView . NumBytes ( ) ) ;
}
# endif
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
if ( HandlerComponents . Num ( ) > 0 )
{
2020-09-01 14:07:48 -04:00
const uint8 * DataPtr = DataView . GetData ( ) ;
uint8 LastByte = ( UNLIKELY ( DataPtr = = nullptr ) ) ? 0 : DataPtr [ DataView . NumBytes ( ) - 1 ] ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
if ( LastByte ! = 0 )
{
CountBits - - ;
while ( ! ( LastByte & 0x80 ) )
{
LastByte * = 2 ;
CountBits - - ;
}
}
else
{
2020-09-01 14:07:48 -04:00
PacketView . DataView = { nullptr , 0 , ECountUnits : : Bits } ;
ReturnVal = EIncomingResult : : Error ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
# if !UE_BUILD_SHIPPING
2018-05-25 20:27:41 -04:00
UE_CLOG ( ( DDoS = = nullptr | | ! DDoS - > CheckLogRestrictions ( ) ) , PacketHandlerLog , Error ,
TEXT ( " PacketHandler parsing packet with zero's in last byte. " ) ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
# endif
}
}
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
struct FHandlerCRC
{
uint32 CRC ;
bool bHasAlignedCRC ;
bool bError ;
} ;
TArray < FHandlerCRC > HandlerCRCs ;
uint32 NetConnectionCRC = 0 ;
# endif
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
2020-09-01 14:07:48 -04:00
if ( ReturnVal = = EIncomingResult : : Success )
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
{
2020-09-01 14:07:48 -04:00
FBitReader ProcessedPacketReader ( DataView . GetMutableData ( ) , CountBits ) ;
FIncomingPacketRef PacketRef = { ProcessedPacketReader , PacketView . Address , PacketView . Traits } ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
FPacketAudit : : CheckStage ( TEXT ( " PostPacketHandler " ) , ProcessedPacketReader ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
if ( State = = Handler : : State : : Uninitialized )
{
UpdateInitialState ( ) ;
}
for ( int32 i = HandlerComponents . Num ( ) - 1 ; i > = 0 ; - - i )
{
HandlerComponent & CurComponent = * HandlerComponents [ i ] ;
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
if ( ProcessedPacketReader . IsError ( ) )
{
HandlerCRCs . Add ( { 0 , false , true } ) ;
}
else if ( ProcessedPacketReader . GetPosBits ( ) = = 0 )
{
HandlerCRCs . Add ( { FCrc : : MemCrc32 ( ProcessedPacketReader . GetData ( ) , ProcessedPacketReader . GetNumBytes ( ) ) , true , false } ) ;
}
else
{
HandlerCRCs . Add ( { 0 , false , false } ) ;
}
}
# endif
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
if ( CurComponent . IsActive ( ) & & ! ProcessedPacketReader . IsError ( ) & & ProcessedPacketReader . GetBitsLeft ( ) > 0 )
{
// Realign the packet, so the packet data starts at position 0, if necessary
if ( ProcessedPacketReader . GetPosBits ( ) ! = 0 & & ! CurComponent . CanReadUnaligned ( ) )
{
RealignPacket ( ProcessedPacketReader ) ;
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
FHandlerCRC & CurCRC = HandlerCRCs [ HandlerCRCs . Num ( ) - 1 ] ;
CurCRC . CRC = FCrc : : MemCrc32 ( ProcessedPacketReader . GetData ( ) , ProcessedPacketReader . GetNumBytes ( ) ) ;
CurCRC . bHasAlignedCRC = true ;
}
# endif
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
2020-09-01 14:07:48 -04:00
if ( PacketView . Traits . bConnectionlessPacket )
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
{
2020-09-01 14:07:48 -04:00
CurComponent . IncomingConnectionless ( PacketRef ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
else
{
2021-09-29 17:45:16 -04:00
CurComponent . Incoming ( PacketRef ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
}
}
if ( ! ProcessedPacketReader . IsError ( ) )
{
ReplaceIncomingPacket ( ProcessedPacketReader ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
if ( IncomingPacket . GetBitsLeft ( ) > 0 )
{
FPacketAudit : : CheckStage ( TEXT ( " PrePacketHandler " ) , IncomingPacket , true ) ;
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
NetConnectionCRC = FCrc : : MemCrc32 ( IncomingPacket . GetData ( ) , IncomingPacket . GetBytesLeft ( ) ) ;
}
# endif
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
}
2020-09-01 14:07:48 -04:00
PacketView . DataView = { IncomingPacket . GetData ( ) , ( int32 ) IncomingPacket . GetBitsLeft ( ) , ECountUnits : : Bits } ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
else
{
2020-09-01 14:07:48 -04:00
PacketView . DataView = { nullptr , 0 , ECountUnits : : Bits } ;
ReturnVal = EIncomingResult : : Error ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
}
2020-09-01 14:07:48 -04:00
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
TStringBuilder < 2048 > HandlerCRCStr ;
for ( int32 i = HandlerCRCs . Num ( ) - 1 ; i > = 0 ; i - - )
{
FHandlerCRC & CurCRC = HandlerCRCs [ i ] ;
HandlerCRCStr . Appendf ( TEXT ( " %s%i: " ) , ( i ! = HandlerCRCs . Num ( ) - 1 ? TEXT ( " , " ) : TEXT ( " " ) ) , ( HandlerCRCs . Num ( ) - 1 ) - i ) ;
if ( CurCRC . bError )
{
HandlerCRCStr < < TEXT ( " Error " ) ;
}
else if ( ! CurCRC . bHasAlignedCRC )
{
HandlerCRCStr < < TEXT ( " Unaligned " ) ;
}
else
{
HandlerCRCStr < < FString : : Printf ( TEXT ( " %08X " ) , CurCRC . CRC ) ;
}
}
UE_LOG ( PacketHandlerLog , Log , TEXT ( " PacketHandler::Incoming: CRC Dump: NetConnection: %s, Component: %s, Socket: %08X " ) ,
( ReturnVal = = EIncomingResult : : Success ? * FString : : Printf ( TEXT ( " %08X " ) , NetConnectionCRC ) : TEXT ( " Error " ) ) ,
* HandlerCRCStr , SocketCRC ) ;
}
# endif
2020-09-01 14:07:48 -04:00
return ReturnVal ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
2019-02-01 20:55:06 -05:00
const ProcessedPacket PacketHandler : : Outgoing_Internal ( uint8 * Packet , int32 CountBits , FOutPacketTraits & Traits , bool bConnectionless , const TSharedPtr < const FInternetAddr > & Address )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
2018-10-29 10:01:28 -04:00
SCOPE_CYCLE_COUNTER ( Stat_PacketHandler_Outgoing_Internal ) ;
2020-10-29 13:38:15 -04:00
ProcessedPacket ReturnVal ;
# if !UE_BUILD_SHIPPING
uint32 NetConnectionCRC = 0 ;
struct FHandlerCRC
{
uint32 CRC ;
bool bError ;
} ;
TArray < FHandlerCRC > HandlerCRCs ;
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
NetConnectionCRC = FCrc : : MemCrc32 ( Packet , FMath : : DivideAndRoundUp ( CountBits , 8 ) ) ;
}
# endif
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
if ( ! bRawSend )
{
OutgoingPacket . Reset ( ) ;
if ( State = = Handler : : State : : Uninitialized )
{
UpdateInitialState ( ) ;
}
if ( State = = Handler : : State : : Initialized )
{
OutgoingPacket . SerializeBits ( Packet , CountBits ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
FPacketAudit : : AddStage ( TEXT ( " PrePacketHandler " ) , OutgoingPacket , true ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
for ( int32 i = 0 ; i < HandlerComponents . Num ( ) & & ! OutgoingPacket . IsError ( ) ; + + i )
{
HandlerComponent & CurComponent = * HandlerComponents [ i ] ;
if ( CurComponent . IsActive ( ) )
{
if ( OutgoingPacket . GetNumBits ( ) < = CurComponent . MaxOutgoingBits )
{
if ( bConnectionless )
{
2018-10-29 10:01:28 -04:00
CurComponent . OutgoingConnectionless ( Address , OutgoingPacket , Traits ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
else
{
2018-10-29 10:01:28 -04:00
CurComponent . Outgoing ( OutgoingPacket , Traits ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
}
else
{
OutgoingPacket . SetError ( ) ;
UE_LOG ( PacketHandlerLog , Error , TEXT ( " Packet exceeded HandlerComponents 'MaxOutgoingBits' value: %i vs %i " ) ,
OutgoingPacket . GetNumBits ( ) , CurComponent . MaxOutgoingBits ) ;
break ;
}
}
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
if ( OutgoingPacket . IsError ( ) )
{
HandlerCRCs . Add ( { 0 , true } ) ;
}
else
{
HandlerCRCs . Add ( { FCrc : : MemCrc32 ( OutgoingPacket . GetData ( ) , OutgoingPacket . GetNumBytes ( ) ) , false } ) ;
}
}
# endif
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
// Add a termination bit, the same as the UNetConnection code does, if appropriate
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
if ( HandlerComponents . Num ( ) > 0 & & OutgoingPacket . GetNumBits ( ) > 0 )
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
{
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
FPacketAudit : : AddStage ( TEXT ( " PostPacketHandler " ) , OutgoingPacket ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
OutgoingPacket . WriteBit ( 1 ) ;
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
if ( ! bConnectionless & & ReliabilityComponent . IsValid ( ) & & OutgoingPacket . GetNumBits ( ) > 0 )
{
// Let the reliability handler know about all processed packets, so it can record them for resending if needed
2018-10-29 10:01:28 -04:00
ReliabilityComponent - > QueuePacketForResending ( OutgoingPacket . GetData ( ) , OutgoingPacket . GetNumBits ( ) , Traits ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
// Buffer any packets being sent from game code until processors are initialized
else if ( State = = Handler : : State : : InitializingComponents & & CountBits > 0 )
{
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
if ( bConnectionless )
{
2018-10-29 10:01:28 -04:00
BufferedConnectionlessPackets . Add ( new BufferedPacket ( Address , Packet , CountBits , Traits ) ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
else
{
2018-10-29 10:01:28 -04:00
BufferedPackets . Add ( new BufferedPacket ( Packet , CountBits , Traits ) ) ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
Packet = nullptr ;
CountBits = 0 ;
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
if ( ! OutgoingPacket . IsError ( ) )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
2020-10-29 13:38:15 -04:00
ReturnVal = { OutgoingPacket . GetData ( ) , ( int32 ) OutgoingPacket . GetNumBits ( ) } ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
else
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
{
2020-10-29 13:38:15 -04:00
ReturnVal = { nullptr , 0 , true } ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
}
else
{
2020-10-29 13:38:15 -04:00
ReturnVal = { Packet , CountBits } ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
2020-10-29 13:38:15 -04:00
# if !UE_BUILD_SHIPPING
if ( UNLIKELY ( ! ! GPacketHandlerCRCDump ) )
{
TStringBuilder < 2048 > HandlerCRCStr ;
for ( int32 i = 0 ; i < HandlerCRCs . Num ( ) ; i + + )
{
FHandlerCRC & CurCRC = HandlerCRCs [ i ] ;
HandlerCRCStr . Appendf ( TEXT ( " %s%i: " ) , ( i > 0 ? TEXT ( " , " ) : TEXT ( " " ) ) , i ) ;
if ( CurCRC . bError )
{
HandlerCRCStr < < TEXT ( " Error " ) ;
}
else
{
HandlerCRCStr . Appendf ( TEXT ( " %08X " ) , CurCRC . CRC ) ;
}
}
TStringBuilder < 32 > SocketCRCStr ;
if ( ReturnVal . bError )
{
SocketCRCStr < < TEXT ( " Error " ) ;
}
else
{
SocketCRCStr . Appendf ( TEXT ( " %08X " ) , FCrc : : MemCrc32 ( ReturnVal . Data , FMath : : DivideAndRoundUp ( ReturnVal . CountBits , 8 ) ) ) ;
}
UE_LOG ( PacketHandlerLog , Log , TEXT ( " PacketHandler::Outgoing: CRC Dump: NetConnection: %08X, Component: %s, Socket: %s " ) ,
NetConnectionCRC , * HandlerCRCStr , * SocketCRCStr ) ;
}
# endif
return ReturnVal ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
void PacketHandler : : ReplaceIncomingPacket ( FBitReader & ReplacementPacket )
2015-07-08 23:03:46 -04:00
{
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
if ( ReplacementPacket . GetPosBits ( ) = = 0 | | ReplacementPacket . GetBitsLeft ( ) = = 0 )
2015-07-08 23:03:46 -04:00
{
2018-10-29 10:01:28 -04:00
IncomingPacket = MoveTemp ( ReplacementPacket ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
else
{
// @todo #JohnB: Make this directly adjust and write into IncomingPacket's buffer, instead of copying - very inefficient
2018-10-29 10:01:28 -04:00
TArray < uint8 > TempPacketData ;
TempPacketData . AddUninitialized ( ReplacementPacket . GetBytesLeft ( ) ) ;
TempPacketData [ TempPacketData . Num ( ) - 1 ] = 0 ;
2015-07-08 23:03:46 -04:00
2018-10-29 10:01:28 -04:00
int64 NewPacketSizeBits = ReplacementPacket . GetBitsLeft ( ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
2018-10-29 10:01:28 -04:00
ReplacementPacket . SerializeBits ( TempPacketData . GetData ( ) , NewPacketSizeBits ) ;
IncomingPacket . SetData ( MoveTemp ( TempPacketData ) , NewPacketSizeBits ) ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
}
}
void PacketHandler : : RealignPacket ( FBitReader & Packet )
{
if ( Packet . GetPosBits ( ) ! = 0 )
{
uint32 BitsLeft = Packet . GetBitsLeft ( ) ;
if ( BitsLeft > 0 )
2015-07-08 23:03:46 -04:00
{
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
// @todo #JohnB: Based on above - when you optimize above, optimize this too
2018-10-29 10:01:28 -04:00
TArray < uint8 > TempPacketData ;
TempPacketData . AddUninitialized ( Packet . GetBytesLeft ( ) ) ;
TempPacketData [ TempPacketData . Num ( ) - 1 ] = 0 ;
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
2018-10-29 10:01:28 -04:00
Packet . SerializeBits ( TempPacketData . GetData ( ) , BitsLeft ) ;
Packet . SetData ( MoveTemp ( TempPacketData ) , BitsLeft ) ;
2015-07-08 23:03:46 -04:00
}
}
}
2018-10-29 10:01:28 -04:00
void PacketHandler : : SendHandlerPacket ( HandlerComponent * InComponent , FBitWriter & Writer , FOutPacketTraits & Traits )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
{
// @todo #JohnB: There is duplication between this function and others, it would be nice to reduce this.
2018-07-11 17:30:22 -04:00
// Prevent any cases where a send happens before the handler is ready.
check ( State ! = Handler : : State : : Uninitialized ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
2020-12-11 14:21:20 -04:00
if ( LowLevelSendDel . IsBound ( ) )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
{
bool bEncounteredComponent = false ;
for ( int32 i = 0 ; i < HandlerComponents . Num ( ) & & ! Writer . IsError ( ) ; + + i )
{
HandlerComponent & CurComponent = * HandlerComponents [ i ] ;
// Only process the packet through components coming after the specified one
if ( ! bEncounteredComponent )
{
if ( & CurComponent = = InComponent )
{
bEncounteredComponent = true ;
}
continue ;
}
if ( CurComponent . IsActive ( ) )
{
if ( Writer . GetNumBits ( ) < = CurComponent . MaxOutgoingBits )
{
2018-10-29 10:01:28 -04:00
CurComponent . Outgoing ( Writer , Traits ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
}
else
{
Writer . SetError ( ) ;
UE_LOG ( PacketHandlerLog , Error , TEXT ( " Handler packet exceeded HandlerComponents 'MaxOutgoingBits' value: %i vs %i " ) ,
Writer . GetNumBits ( ) , CurComponent . MaxOutgoingBits ) ;
break ;
}
}
}
if ( ! Writer . IsError ( ) & & Writer . GetNumBits ( ) > 0 )
{
FPacketAudit : : AddStage ( TEXT ( " PostPacketHandler " ) , Writer ) ;
// Add a termination bit, the same as the UNetConnection code does, if appropriate
Writer . WriteBit ( 1 ) ;
if ( ReliabilityComponent . IsValid ( ) )
{
// Let the reliability handler know about all processed packets, so it can record them for resending if needed
2018-10-29 10:01:28 -04:00
ReliabilityComponent - > QueueHandlerPacketForResending ( InComponent , Writer . GetData ( ) , Writer . GetNumBits ( ) , Traits ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
}
// Now finish off with a raw send (as we don't want to go through the PacketHandler chain again)
bool bOldRawSend = bRawSend ;
bRawSend = true ;
2018-11-01 14:26:34 -04:00
LowLevelSendDel . ExecuteIfBound ( Writer . GetData ( ) , Writer . GetNumBits ( ) , Traits ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
bRawSend = bOldRawSend ;
}
}
else
{
LowLevelFatalError ( TEXT ( " Called SendHandlerPacket when no LowLevelSend delegate is bound " ) ) ;
}
}
2015-07-08 23:03:46 -04:00
void PacketHandler : : SetState ( Handler : : State InState )
{
if ( InState = = State )
{
LowLevelFatalError ( TEXT ( " Set new Packet Processor State to the state it is currently in. " ) ) ;
}
else
{
State = InState ;
}
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
void PacketHandler : : UpdateInitialState ( )
{
if ( State = = Handler : : State : : Uninitialized )
{
if ( HandlerComponents . Num ( ) > 0 )
{
InitializeComponents ( ) ;
}
else
{
HandlerInitialized ( ) ;
}
}
}
2015-07-08 23:03:46 -04:00
void PacketHandler : : HandlerInitialized ( )
{
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
// Quickly verify that, if reliability is required, that it is enabled
if ( ! ReliabilityComponent . IsValid ( ) )
{
2018-10-29 10:01:28 -04:00
for ( const TSharedPtr < HandlerComponent > & Component : HandlerComponents )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
{
2018-10-29 10:01:28 -04:00
if ( Component . IsValid ( ) & & Component - > RequiresReliability ( ) )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
{
// Don't allow this to be missed in shipping - but allow it during development,
// as this is valid when developing new HandlerComponent's
# if UE_BUILD_SHIPPING
UE_LOG ( PacketHandlerLog , Fatal , TEXT ( " Some HandlerComponents require bEnableReliability!!! " ) ) ;
# else
UE_LOG ( PacketHandlerLog , Warning , TEXT ( " Some HandlerComponents require bEnableReliability!!! " ) ) ;
# endif
break ;
}
}
}
2015-07-08 23:03:46 -04:00
// If any buffered packets, add to queue
2016-01-28 16:03:26 -05:00
for ( int32 i = 0 ; i < BufferedPackets . Num ( ) ; + + i )
2015-07-08 23:03:46 -04:00
{
QueuedPackets . Enqueue ( BufferedPackets [ i ] ) ;
BufferedPackets [ i ] = nullptr ;
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
BufferedPackets . Empty ( ) ;
for ( int32 i = 0 ; i < BufferedConnectionlessPackets . Num ( ) ; + + i )
{
QueuedConnectionlessPackets . Enqueue ( BufferedConnectionlessPackets [ i ] ) ;
BufferedConnectionlessPackets [ i ] = nullptr ;
}
BufferedConnectionlessPackets . Empty ( ) ;
2015-07-08 23:03:46 -04:00
SetState ( Handler : : State : : Initialized ) ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
if ( bBeganHandshaking )
{
HandshakeCompleteDel . ExecuteIfBound ( ) ;
}
2015-07-08 23:03:46 -04:00
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
void PacketHandler : : HandlerComponentInitialized ( HandlerComponent * InComponent )
2015-07-08 23:03:46 -04:00
{
// Check if all handlers are initialized
if ( State ! = Handler : : State : : Initialized )
{
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
bool bAllInitialized = true ;
bool bEncounteredComponent = false ;
bool bPassedHandshakeNotify = false ;
for ( int32 i = HandlerComponents . Num ( ) - 1 ; i > = 0 ; - - i )
2015-07-08 23:03:46 -04:00
{
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
HandlerComponent & CurComponent = * HandlerComponents [ i ] ;
if ( ! CurComponent . IsInitialized ( ) )
2015-07-08 23:03:46 -04:00
{
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
bAllInitialized = false ;
}
if ( bEncounteredComponent )
{
// If the initialized component required a handshake, pass on notification to the next handshaking component
// (components closer to the Socket, perform their handshake first)
2018-10-29 10:01:28 -04:00
if ( bBeganHandshaking & & ! CurComponent . IsInitialized ( ) & & InComponent - > RequiresHandshake ( ) & & ! bPassedHandshakeNotify & &
CurComponent . RequiresHandshake ( ) )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
{
CurComponent . NotifyHandshakeBegin ( ) ;
bPassedHandshakeNotify = true ;
}
}
else
{
bEncounteredComponent = & CurComponent = = InComponent ;
2015-07-08 23:03:46 -04:00
}
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
if ( bAllInitialized )
{
HandlerInitialized ( ) ;
}
2015-07-08 23:03:46 -04:00
}
}
2018-12-13 00:41:17 -05:00
bool PacketHandler : : DoesAnyProfileHaveComponent ( const FString & InComponentName )
{
TArray < FString > ProfileSectionNames ;
if ( GConfig - > GetPerObjectConfigSections ( GEngineIni , TEXT ( " PacketHandlerProfileConfig " ) , ProfileSectionNames ) )
{
for ( const FString & CurProfileSection : ProfileSectionNames )
{
FName CurNetDriver ( * CurProfileSection . Left ( CurProfileSection . Find ( TEXT ( " " ) ) ) ) ;
if ( DoesProfileHaveComponent ( CurNetDriver , InComponentName ) )
{
return true ;
}
}
}
return false ;
}
bool PacketHandler : : DoesProfileHaveComponent ( const FName InNetDriverName , const FString & InComponentName )
{
TArray < FString > Components ;
2018-12-20 23:37:53 -05:00
FString DriverProfileCategory = FString : : Printf ( TEXT ( " %s PacketHandlerProfileConfig " ) , * InNetDriverName . GetPlainNameString ( ) ) ;
GConfig - > GetArray ( * DriverProfileCategory , TEXT ( " Components " ) , Components , GEngineIni ) ;
2018-12-13 00:41:17 -05:00
for ( const FString & Component : Components )
{
if ( Component . Contains ( InComponentName , ESearchCase : : CaseSensitive ) )
{
return true ;
}
}
return false ;
}
2015-07-08 23:03:46 -04:00
BufferedPacket * PacketHandler : : GetQueuedPacket ( )
{
BufferedPacket * QueuedPacket = nullptr ;
2016-01-28 16:03:26 -05:00
2015-07-08 23:03:46 -04:00
QueuedPackets . Dequeue ( QueuedPacket ) ;
2016-01-28 16:03:26 -05:00
2015-07-08 23:03:46 -04:00
return QueuedPacket ;
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
BufferedPacket * PacketHandler : : GetQueuedRawPacket ( )
{
BufferedPacket * QueuedPacket = nullptr ;
QueuedRawPackets . Dequeue ( QueuedPacket ) ;
return QueuedPacket ;
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
BufferedPacket * PacketHandler : : GetQueuedConnectionlessPacket ( )
{
BufferedPacket * QueuedConnectionlessPacket = nullptr ;
QueuedConnectionlessPackets . Dequeue ( QueuedConnectionlessPacket ) ;
return QueuedConnectionlessPacket ;
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
int32 PacketHandler : : GetTotalReservedPacketBits ( )
2015-07-08 23:03:46 -04:00
{
2016-01-28 16:03:26 -05:00
int32 ReturnVal = 0 ;
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
uint32 CurMaxOutgoingBits = MaxPacketBits ;
2015-07-08 23:03:46 -04:00
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
for ( int32 i = HandlerComponents . Num ( ) - 1 ; i > = 0 ; i - - )
2016-01-28 16:03:26 -05:00
{
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
HandlerComponent * CurComponent = HandlerComponents [ i ] . Get ( ) ;
int32 CurReservedBits = CurComponent - > GetReservedPacketBits ( ) ;
2016-01-28 16:03:26 -05:00
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
// Specifying the reserved packet bits is mandatory, even if zero (as accidentally forgetting, leads to hard to trace issues).
if ( CurReservedBits = = - 1 )
2016-01-28 16:03:26 -05:00
{
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
LowLevelFatalError ( TEXT ( " Handler returned invalid 'GetReservedPacketBits' value. " ) ) ;
2016-01-28 16:03:26 -05:00
continue ;
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
// Set the maximum Outgoing packet size for the HandlerComponent
CurComponent - > MaxOutgoingBits = CurMaxOutgoingBits ;
CurMaxOutgoingBits - = CurReservedBits ;
ReturnVal + = CurReservedBits ;
2016-01-28 16:03:26 -05:00
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
// Reserve space for the termination bit
if ( HandlerComponents . Num ( ) > 0 )
{
ReturnVal + + ;
}
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
2016-01-28 16:03:26 -05:00
return ReturnVal ;
}
/**
* HandlerComponent
*/
HandlerComponent : : HandlerComponent ( )
Copying //UE4/Dev-Networking to Dev-Main (//UE4/Dev-Main)
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2814968 on 2016/01/04 by John.Pollard
Remove warning per connection when same warning happens at net driver level
Change 2815271 on 2016/01/04 by John.Pollard
Fix header uploads in replays showing wrong size
#rb none
#tests Compiled, confirmed correct size
Change 2830613 on 2016/01/15 by John.Barrett
Added better ability for unit tests to test socket-level netcode
Full changes:
- Added flag for auto-reconnecting on connection close
- Added hook for socket level sends
- Added ability to block socket-level sends and pre-PacketHandler LowLevelSend's
- Added ability for net connections to force-enable packet handlers, even if presently off in the engine
#rb none
Change 2830617 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Enabled NetcodeUnitTest in Linux, and other minor updates.
#rb none
Change 2830621 on 2016/01/15 by John.Barrett@JC2Q-LT_UE4
Added 'PacketLimitTest' and 'PacketLimitTest_Oodle' unit tests, for testing/verifying that MaxPacket limits are respected, through testing with Bunches and with raw sends passed through PacketHandlers (such as Oodle).
#rb none
Change 2832402 on 2016/01/18 by Bart.Bressler@bart.bressler_Dev_Networking
Always use the physical platform file when writing out steam_appid.txt, because it has to live next to executable that's being run (CotF builds will output it to the wrong location).
#rb josh.markiewicz
#tests checked that steam_appid.txt was written to the correct place with both CotF and cooked builds
Change 2833728 on 2016/01/19 by Joe.Conley@Joe.Conley_EGJWD5708_Dev-Networking-Minimal
Fix for UE-20017 - "Http server headers implemented as TMaps and are overridden". Just changing TMaps to TMultiMaps. Haven't modified the behavior of GetHeader(), which will still return the first header that matches.
Change 2844880 on 2016/01/26 by Joe.Conley
Fix for UE-20017 Http server headers implemented as TMaps and are overridden
Previously had submitted a fix that changes the request and response headers TMap into a MultiMap, but the consensus was that it would be better to leave them as TMaps, but allow appending onto the existing entry for a given request header with an "AppendToHeader" function, and to concatenate entries for the same header name in the response headers. In both cases, entries for the same header name are concatenated with ", ".
Mac and iOS already had the desired behavior for responses, just added the AppendToHeader function to their request classes.
HTML5 still has no implementation of response headers, filed as separate JIRA issue UE-26047.
#platformnotify josh.adams
Change 2859343 on 2016/02/08 by Bart.Bressler
Default MaxSearchResults in FOnlineSessionSearch objects to 1 instead of 0 - otherwise, the FOnlineAsyncTaskSteamFindServerBase tasks will complete right away without searching for sessions. Also print a warning in the task if this will happen.
#codereview josh.markiewicz
Change 2862352 on 2016/02/10 by Bart.Bressler
Fix demo.SkipTime cvar to work with negative values
#rb john.pollard
Change 2866624 on 2016/02/14 by John.Barrett
Fix plugin commandlet crash.
#rb none
Change 2866627 on 2016/02/14 by John.Barrett
Added NetDriver/PacketHandler ability to send/receive connectionless packets - i.e. packets not associated with a UNetConnection.
Removed 'bEnabled' from PacketHandler - PacketHandler is now a default always-on part of the Engine.
Added 'CountBits' to LowLevelSend, to support bit-level additions to packets from PacketHandler's, and refactored related code.
#codereview John.Pollard
Change 2866628 on 2016/02/14 by John.Barrett
Added an HMAC (Hash-based Message Authentication Code) generating function, to the SHA-1 code - for use with performing secure net connection handshakes.
#rb none
Change 2866629 on 2016/02/14 by John.Barrett
Added 'stateless handshake' to UE4, allowing a handshake to be performed without any open UNetConnection - making it more difficult for DoS attacks to consume memory resources.
#codereview John.Pollard
Change 2866630 on 2016/02/14 by John.Barrett
Updated Oodle to support new stateless handshake.
#rb none
Change 2866631 on 2016/02/14 by John.Barrett
Updated NetcodeUnitTest to work with new connectionless/stateless handshake changes. Compiles, but netcode presently needs fixing.
#rb none
Change 2868367 on 2016/02/16 by John.Barrett
Updated NetcodeUnitTest to work with stateless handshakes (now fixed connecting).
Also fixed further commandlet problems.
#rb none
Change 2878025 on 2016/02/23 by John.Barrett
Immediately stop processing zero-size packets, to prevent CPU utilization during DDoS.
Log IP of new connections, post-stateless-challenge (first time we know IP is verified).
#codereview john.pollard
Change 2883776 on 2016/02/26 by John.Barrett
Fixed beacons to work with stateless handshake.
Change 2886773 on 2016/02/29 by John.Barrett
Made PacketHandler bit overhead align upwards to the next byte - this wastes more bits than necessary, but is required as a temporary fix.
Change 2887801 on 2016/03/01 by John.Pollard
Use correct default values when initializing shadow state for replication.
Fixes issues with certain components and actors that have default values that differ from CDO.
[CL 2901490 by John Pollard in Main branch]
2016-03-09 13:54:33 -05:00
: Handler ( nullptr )
, State ( Handler : : Component : : State : : UnInitialized )
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2976484 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: nick.atamas
Added queueing to HUD Alerts so they don't clobber each other.
Added input visualization so that keys show up in game.
SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth
#test PIE
#ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2976256 on 2016/05/12 by Zak.Middleton
#ue4 - Fix for shipping build.
#tests compiled
Change 2976205 on 2016/05/12 by Zak.Middleton
#ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns.
#tests MP PIE PlayGo
(Merging CL 2957866 using Framework->DevGeneral)
Change 2976166 on 2016/05/12 by Daniel.Lamb
Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time.
#test Cook paragon
Change 2976161 on 2016/05/12 by Zak.Middleton
#ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects).
#tests PIE MP w/ real-world networking
Change 2976092 on 2016/05/12 by Mieszko.Zielinski
Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4
#test golden path
Change 2976001 on 2016/05/12 by Robert.Manuszewski
Don't log to memory on dedicated servers
#jira UE-30693
#test Cooked dedicated server and client
Change 2975855 on 2016/05/12 by Lukasz.Furman
fixed behavior tree serialization spawning duplicates of task services
#tests BT editor
Change 2975706 on 2016/05/12 by Daniel.Lamb
Fixed redirect collector stats.
#test Compile
Change 2975636 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 2975557
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank
#ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975592 on 2016/05/12 by Zak.Middleton
#ue4 - Add stat for SetHitResultFromShapeAndFaceIndex().
#tests PIE
Change 2975589 on 2016/05/12 by Zak.Middleton
#ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds.
#tests PIE
Change 2975588 on 2016/05/12 by Zak.Middleton
#ue4 - Minor tweak to avoid array read each loop iteration.
#tests PIE
Change 2975587 on 2016/05/12 by Zak.Middleton
#ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed.
#tests PIE
Change 2975504 on 2016/05/12 by Daniel.Lamb
Remove new stats system because it broke build.
#test cook paragon
Change 2975500 on 2016/05/12 by Daniel.Lamb
Enable redirect timers so I can get stats from build machines.
#test cook paragon.
Change 2975367 on 2016/05/12 by Jason.Bestimt
#ROBOMERGE-AUTHOR: david.nikdel
#OGF #CatalogService #OSS #Localization
- Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text
- Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text
- Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup)
[CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt
#RB: Sam.Zamani
#TESTS: storefront w/ language change
#ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2975209 on 2016/05/12 by Simon.Tovey
Fixed initialization order warning.
#tests none
Change 2975200 on 2016/05/12 by Simon.Tovey
Translucency GPU time stats for automation.
Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency.
Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation.
There are occasional spikes when the GPU is starved but overall the data out seems good.
#tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data.
Change 2974984 on 2016/05/11 by Mieszko.Zielinski
Fixed a bug in graph-a-star heuristics' calculation #UE4
#test golden path
Change 2974916 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2974578
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974869 on 2016/05/11 by Ben.Marsh
BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names.
#tests none
Change 2974673 on 2016/05/11 by Mieszko.Zielinski
Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4
(change by ?ukasz.Furman)
#test golden path
Change 2974581 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
Merged CL 2974565 from Release-.26 -> Main:
Fixed loc region not saving in shipping builds
Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes
#ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974444 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Reimplement support for specifying BuildPatchTool version used in chunking
This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407.
#tests none
#ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974408 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: ben.marsh
BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio.
#tests none
[CodeReviewed] Richard.Fawcett
#ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974392 on 2016/05/11 by Daniel.Lamb
Optimizing resolve string asset reference resolution.
Added timing stats (disabled by default).
#test Cook paragon.
Change 2974349 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm.
#tests none
#ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974299 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: richard.fawcett
Add support for chunking builds with the pre-release version of BuildPatchTool.
#tests None. This code will be tested by creating a build on the build farm immediately after submission.
#ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2974277 on 2016/05/11 by Lina.Halper
Fix up of retargeting when it skips replacing nested reference
#tests: retargeting anim BP
Change 2974210 on 2016/05/11 by Bart.Bressler
Merging Oodle changes from Dev-Networking
Change 2939167 on 2016/04/10 by John.Barrett
Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size).
Added new 'stat packet' stats group, for tracking reserved packet bits.
Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state.
Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable).
Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes.
Change 2939168 on 2016/04/10 by John.Barrett
Updated Oodle to support new packet bit-termination code.
Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases).
Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage.
Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code.
Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API
Added 'stat oodle' stats for tracking failed attempts at compressing packets.
Change 2942964 on 2016/04/10 by Ryan.Gerleve
Fix broken indentation/formatting
Change 2958260 on 2016/04/27 by Bart.bRessler
Add branch name and changelist to oodle packet capture filenames.
Change 2964360 on 2016/05/03 by John.Barrett
Updated Oodle to support using a dictionary and capturing packets at the same time.
The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary.
Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server):
"Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets)
"Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary.
"Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline.
"Oodle ResetStats" - resets the 'stat oodle' stat counters.
The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed.
Change 2964553 on 2016/05/03 by Bart.Bressler
Add process ID to oodle capture filenames
Change 2966247 on 2016/05/04 by John.Pollard
Oodle 2.1.5 SDK
Change 2968761 on 2016/05/06 by Bart.Bressler
- Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything)
- Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options
- When looking for capture files, we will now recursively search subdirectories
Change 2970529 on 2016/05/09 by Bart.Bressler
Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection
Change 2970874 on 2016/05/09 by Bart.Bressler
- Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds
- Link to version 215 of oodle
Change 2971233 on 2016/05/09 by Bart.Bressler
Update Oodle DLLs in Orion
Change 2971362 on 2016/05/09 by Bart.Bressler
Create script for building an oodle dictionary out of capture files in an arbitrary location
Change 2972176 on 2016/05/10 by Bart.Bressler
Update oodle references to version 215 in OodleHandlerComponent.Build.cs
#tests used solo vs. ai to test oodle captures and using them
Change 2974035 on 2016/05/11 by Simon.Tovey
Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time.
This is the time a PSC needs to be invisible for to have all it's collisions ignored.
This is potentially the cause of a bug Tim et al are seeing.
#tests Editor, Can be used to repro/fix the issue.
Change 2973985 on 2016/05/11 by Lina.Halper
Retargeting fix with editor saving issue
#tests: retargeting
Change 2973695 on 2016/05/11 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2973469
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2973679 on 2016/05/11 by Graeme.Thornton
UAT parameter -signedpak now no longer implies -pak
#tests win64 cooked client. checked that pak generation works as expected through project launcher
Change 2973588 on 2016/05/11 by Simon.Tovey
OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint
Particles can now receive collision events selectively based upon the phyisics material of the hit.
Physics material is passed through the event and can be accessed in BPs.
The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials.
#tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here.
Change 2973394 on 2016/05/11 by bruce.nesbit
Fixed couple of shadow vars
#tests compiled
Change 2973335 on 2016/05/11 by Andrew.Grant
Warning fix
#tests compiled
Change 2973308 on 2016/05/10 by Dmitry.Rekman
Add "unplayable condition" reporting.
- The server will report an unplayable condition by creating a local file (under Saved).
- An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine.
- Report file is to be deleted by an external script.
#tests Compiled and ran Linux server, subjected it to various hitches.
Change 2973235 on 2016/05/10 by Zak.Middleton
#ue4 - Removed allocs after initial spawn from client saved move processing in character movement.
#tests PIE multiplayer w/ Bots
Change 2973157 on 2016/05/10 by Olaf.Piesche
Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General
Providing particle source and target for beam emitters
#tests editor game PC
Change 2972715 on 2016/05/10 by Jason.Bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 26 @ CL 2972681
#RB: none
#Tests:none
#ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2972678 on 2016/05/10 by Mieszko.Zielinski
Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion
#jira OR-18590
#test golden path
Change 2972595 on 2016/05/10 by Lina.Halper
Animation Retargeting fix for blendspaces
#code review: Benn.Gallagher, Martin.Wilson
#tests: retargeting anim BP
Change 2972282 on 2016/05/10 by Daniel.Lamb
Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook.
#test cook paragon.
Change 2972260 on 2016/05/10 by Laurent.Delayen
Fixed crash in UCharacterMovementComponent::HasRootMotionSources().
#tests Chains pull not crashing anymore.
Change 2972241 on 2016/05/10 by Frank.Fella
UMG - Fixes for material animation copied from 4.12.
#RB Matt K.
#TESTS Struct materials can now be animated and animated materials are named nicely.
Change 2971643 on 2016/05/09 by Dmitry.Rekman
Add reporting of "zero load" frame times (OR-21035).
- Added a thread that does nothing but sleeps and counts how often it missed the target FPS.
- Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match.
- Server only.
#tests Compiled and ran Linux server on a compatible content, played few matches in a row.
Change 2971544 on 2016/05/09 by Ben.Marsh
EC: Use a full path to the telemetry file, to account for UAT switching directories.
Change 2971532 on 2016/05/09 by Wes.Hunt
Alter the cook stats hierarchical profile data to reflect the latest cook changes.
#tests none
Change 2971527 on 2016/05/09 by Ben.Marsh
UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere.
#tests none
Change 2971461 on 2016/05/09 by David.Ratti
Fix issues with mesh swap skins:
-Front end intro animations not playing
-In game spawn animations not playing
-Some attachment weirdness (twinblast)
#tests golden path
Change 2971460 on 2016/05/09 by David.Ratti
Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects
#tests pie
Change 2971364 on 2016/05/09 by Ben.Marsh
EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC.
#tests none
Change 2971245 on 2016/05/09 by Dmitry.Rekman
Add a "hitchhunter" log message to catch hitches while sleeping.
#tests Compiled and ran Linux server on a compatible content.
Change 2971196 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2971139
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened
#CodeReview: david.nikdel, jason.bestimt
Change 2971113 on 2016/05/09 by Dmitry.Rekman
UdpMessaging: Fixed broken filters for when to enable UDP transport.
- Redoing MaxP's change from Dev-Sequencer (CL 2963357).
- Reduces number of threads spawned by the server.
#tests Compiled Linux server, ran it on a compatible content.
Change 2971040 on 2016/05/09 by jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2970990
#RB:none
#Tests:none
[CodeReviewed]: jon.lietz
#ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
#ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#CodeReview: david.nikdel, jason.bestimt
Change 2970555 on 2016/05/09 by Ben.Marsh
BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log.
#tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796
Change 2970507 on 2016/05/09 by David.Ratti
Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability.
Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component
#tests pie
Change 2970414 on 2016/05/09 by Graeme.Thornton
Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const&
#tests win64 client golden path
Change 2969729 on 2016/05/06 by Mieszko.Zielinski
Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4
#test golden path
Change 2969675 on 2016/05/06 by Mieszko.Zielinski
Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4
Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController
Reverted hack-feature that supplied same functionality to EQS
#test golden path
Change 2969652 on 2016/05/06 by Michael.Noland
HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs)
- Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used
#tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated
Change 2969651 on 2016/05/06 by Michael.Noland
Simplygon: Added time taken for simplygon mesh reduction to the log message
#tests Simplified a LOD cluster and inspected the log
Change 2969604 on 2016/05/06 by Uriel.Doyon
Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT.
#tests confirmed that default value has changed for old assets, while allowing override.
Change 2969418 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
Fixed unconverted char string being passed as part of build info
#tests ran & verified patch check passes
#ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968817 on 2016/05/06 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2968572
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2968383 on 2016/05/05 by Mieszko.Zielinski
Added "default navigation filter" to AIController #UE4
Also, made EQS take advantage of that
#test golden path
Change 2968225 on 2016/05/05 by John.Pollard
Add sanity checks and more info to help track down possible memory corruption
#tests Networking, replication
Change 2967903 on 2016/05/05 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2967827
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2967899 on 2016/05/05 by Lina.Halper
Merged change of 2956152
Remove invalid ensure - this didn't work if you have composite inside.
#tests: none
Change 2967870 on 2016/05/05 by Andrew.Grant
Fix for OR-20731 (gamever crashes client)
#tests gamever at console with -game
Change 2967606 on 2016/05/05 by Wes.Hunt
Tweaked output log message for HTTP module shutdown.
#tests none
Change 2967359 on 2016/05/05 by Wes.Hunt
HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level.
#tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete.
Change 2966987 on 2016/05/05 by Dmitry.Rekman
Fix editor build.
#tests Compiled Win64 editor.
Change 2966977 on 2016/05/05 by Dmitry.Rekman
Added collecting and reporting periodic server frame time distribution.
- Added generic FHistogram class and necessary analytic events.
- Also added reporting hostname (OR-20842).
#tests Built Linux server and ran a few matches on a compatible content.
Change 2966920 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2966805
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2966778 on 2016/05/04 by Michael.Noland
Rendering: Fixed shadow variable warning in GPUProfiler
#tests Compiled and tested GPUProfiler command
Change 2966769 on 2016/05/04 by Mieszko.Zielinski
Fixed GraphAStar not resetting the output path before fillinf it with results #UE4
#test golden path
Change 2966704 on 2016/05/04 by Michael.Noland
Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material
- This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture
- It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName")
#tests Used ProfileGPU a number of times
Change 2966696 on 2016/05/04 by Michael.Noland
Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes
#tests Tested FPS charts in an uncooked and cooked build
#jira OR-19713
Change 2966336 on 2016/05/04 by Lukasz.Furman
fixed jungle minions unable to reach spawn locations when camp resets
#jira OR-20700
#tests jungle camp POC
Change 2965948 on 2016/05/04 by David.Ratti
Changes to how passive abilities activate
-Passives now continually try to activate by default rather than only on spawn
Support for Status.Immortal
-Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens.
-Clamps health to 1.
Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died.
Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match
#tests multi pie
Change 2965870 on 2016/05/04 by Ryan.Gerleve
Duplicated fix from Release-4.12 by marc.audy, CL 2960819:
Owned components are once again referenced by their Owning actor for GC purposes
#jira UE-29131
#tests golden path
Change 2965798 on 2016/05/04 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2965789
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2965220 on 2016/05/03 by Dmitry.Rekman
Log instance id and system id (OR-20782).
- These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file.
#tests Compiled Linux server, ran on compatible client.
Change 2964907 on 2016/05/03 by Jason.Bestimt
#ORION_DG - Merge MAIN @ CL 2964858
#RB:none
#Tests:none
Change 2964530 on 2016/05/03 by Laurent.Delayen
Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime.
Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered).
Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered)
Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice.
#tests Chains full feature system in PIE.
Change 2964498 on 2016/05/03 by Frank.Fella
DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags.
#RB Andrew Rodham
#TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer.
Change 2964428 on 2016/05/03 by Benn.Gallagher
Fixed stale clothing chunk/section references after container realloc in editor
#tests editor
Change 2964316 on 2016/05/03 by bruce.nesbit
Banner revisions
Banners now use components for various banner items
Banners can now be enabled when killing a hero.
#tests PIE+Game
Change 2964187 on 2016/05/03 by Jon.Lietz
Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent()
- Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent
- Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer
#RB DanY
#tests JIP shadow pad still works.
Change 2964136 on 2016/05/03 by Laurent.Delayen
Fix crash while switching tabs using Persona.
#tests not crashing anymore.
Change 2964083 on 2016/05/03 by jason.bestimt
#ROBOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 25.2 @ CL 2963929
[CodeReviewed]: andrew.grant
HTTP Manager has larger stack size (1024)
#RB:none
#Tests:none
#ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/...
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2963771 on 2016/05/02 by Nick.Atamas
Setting a desired size scale invalidates layout and volatility.
#test none
Change 2963555 on 2016/05/02 by Rob.Cannaday
Fix PS4 Orion players being able to whisper chat with non-Orion players
#jira OR-20626
#tests chat with launcher, fortnite
Change 2963387 on 2016/05/02 by Laurent.Delayen
Added GatherDebugData to FABRIK node.
#tests showdebug animation works on Chains now.
Change 2963331 on 2016/05/02 by Jon.Lietz
fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1.
#RB none
#tests compiles
Change 2963106 on 2016/05/02 by Rob.Cannaday
Increase HTTP thread's stack size to 128k
We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion)
#tests log in
Change 2963047 on 2016/05/02 by Jon.Lietz
OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect.
- adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate.
#RB Dave.Ratti
#test shadow pad, slow, stun and root still trigger and trigger for JIP players.
Change 2962836 on 2016/05/02 by jason.bestimt
#ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files
[CodeReviewed] Ben.Marsh
#ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835
#ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 2962570 on 2016/05/02 by Jason.Bestimt
#ORION_MAIN - Merge MAIN @ CL 2962544
#RB:none
#Tests:none
Change 2962552 on 2016/05/02 by Ben.Marsh
Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version.
#tests none
Change 2962506 on 2016/05/02 by Ben.Marsh
Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task.
#tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables.
Change 2962228 on 2016/04/30 by Dmitry.Rekman
Move processing HTTP requests into separate thread (OR-20723).
- First iteration of the implementation, pending implementing feedback.
- Adds a separate thread for CurlHttp where actual processing is performed.
- Coded by RobC, post-processed by me.
#tests Compiled Linux server and Windows client, ran them on compatible content, played a match.
Change 2961899 on 2016/04/29 by Ben.Marsh
BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries.
#tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603)
Change 2961587 on 2016/04/29 by Daniel.Lamb
Redirector doesn't fire callback if it fails to be loaded.
#test Cook orion.
Change 2961458 on 2016/04/29 by Wes.Hunt
Cooker Stats improvements. Also removed some old UBT telemetry that was not being used.
#tests many cooks of orion
Change 2961136 on 2016/04/29 by Daniel.Lamb
Readded caching of platform data into postload of materials.
#test Cook paragon.
[CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
, MaxOutgoingBits ( 0 )
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
, bRequiresHandshake ( false )
, bRequiresReliability ( false )
2016-01-28 16:03:26 -05:00
, bActive ( false )
, bInitialized ( false )
{
2015-07-08 23:03:46 -04:00
}
Copying //UE4/Fortnite-Staging to //UE4/Dev-Main (Source: //Fortnite/Main/Engine @ 3780923)
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3780878 by Nick.Darnell
UMG - Providing more information when the compile fails to find a bindable widget.
Change 3780855 by Gil.Gribb
UE4 - Fixed a linear search in EDL that caused performance problems for very large maps. Saves half the load time in FN-BR.
Change 3780803 by Thomas.Sarkanen
Dont create animation tasks for skeletal meshes that have no anim instance
This avoids some wasted work for non-animated attachments, such as pickaxes
#jira FORT-61523 - Don't create anim worker tasks if no AnimBP
Change 3780741 by Yenal.Kal
#jira FORT-60177
Fixed the bug where the anim branching points (begin and end) may be triggered twice incorrectly.
Change 3780663 by Gil.Gribb
UE4 - Batching for audio thread commands.
Change 3780466 by Ben.Marsh
Add error matcher for generic Microsoft errors (eg. 'cl : Command line error D8049 : command line too long to fit in debug record')
Change 3779937 by Nick.Darnell
UMG - Adding an accessor on UUserWidget to get the owning player state easier, since it's a common operation.
Change 3779858 by Sam.Zamani
#http
use separate "-multihomehttp" instead of "-multihome" for routing http socket
#jira FORT-61666
#tests none
Change 3779288 by Michael.Trepka
Changed FMacConsoleOutputDevice::Serialize to use FString's GetNSString() instead of converting the string using FPlatformString::TCHARToCFString to make it safer in case of garbage text passed in Data
#jira FORT-59762
Change 3779062 by Mike.Fricker
Merged CL 3731188 and CL 3733311 from //UE4/Dev-Editor.
----
Improve responsiveness of Open Asset dialog.
On large projects, there's a noticeable delay when opening and searching/filtering assets.
Stopwatch measurements on my machine (seconds for ~122,000 assets):
before with this CL
ctrl-P 1.4 0.45
search 1.8 0.55
CollectionManagerModule was the main culprit for search/filter slowness.
Open Asset delay was due to filtering out plugin content. We were doing a lot of redundant work for what is essentially a read-only operation.
Change 3778954 by Nick.Darnell
Slate - Making the Horizontal and Vertical analog keys configurable in the navigation config. Tweaking how fast the navigation is with the analog stick, trying to tune the feeling.
Change 3778896 by Ben.Marsh
Separate FNameEntrySerialized from FNameEntry, rather than deriving from it. It has to be allocated differently, and many fields cannot be shared between the two.
#jira
Change 3778807 by Ben.Marsh
Fix Tencent include paths not registering if workspace directory contains a space.
Tencent include paths currently have a trailing backslash, and this is surrounded by quotes if the root directory contains a space. The backslash is interpreted as escaping the trailing double quote.
#jira
Change 3778686 by Luke.Thatcher
Reduced impact of dynamic vertex buffer RHI stall in D3D12
- In most cases we can avoid the stall if the vertex buffer has never been used before.
- Only when a buffer has an existing SRV do we need to stall.
- Also, delete copy and move constructors of FD3D12ResourceLocation. Moving or copying an instance of this class leads to double free crashes, so this is now a compile error rather than a runtime crash.
This saves an average of 2ms frame time in a StW lastperftest replay, with r.screenpercentage 10.
#jira FORT-61390
Change 3778679 by Thomas.Sarkanen
Fix Linux server crash - dont attempt to run threaded work in a single-threaded environment
We dont attempt to run animation update work multi-threaded in the same conditions that we didnt attempt to run animation eval work previously.
#jira FORT-61548
Change 3778591 by Ben.Woodhouse
Add build config to FPSChart HTML output
#jira FORT-56478
Change 3778175 by ben.marsh
Remove code to trigger an ensure on Arxan guards. We already send analytics for this, and don't need this legacy path. There is a large number of incoming ensures with this callstack that are clogging up crash reporter.
Will remove all the surrounding code in a later update to a development branch.
#jira
Change 3777750 by Chris.Gagnon
- Slate now supports a CustomBoundary Navigation type wich allows a custom handler if the boundary is hit.
- This provides the ability to have normal navigation while within the boundary and the custom function only on the boundary.
- This differs from Custom which is a full override of the navigation behavior.
Change 3777678 by Bob.Tellez
#UE4 Fix a bug that was causing fastpath nodes in non-nativized BPs to not be fastpath
Change 3776962 by Bob.Tellez
#UE4 Fix warning about missing virtual destructor by making a struct final (like other RHICommands)
Change 3776656 by Thomas.Sarkanen
Fix notifies not getting fired in cases where AlwaysTickPose was set on skeletal mesh components
This was causing AIs to get stuck in montage playback in some circumstances
#jira FORT-61324, FORT-60558
Change 3776655 by Bob.Tellez
#UE4 CIS fix after 3776629
Change 3776650 by Bob.Tellez
Counting uplugin and uproject files as code changes so UGS will trigger code builds on checkins containing these files
Change 3776649 by Nick.Darnell
UMG - Fixing a rare crash when destructing a widget in the designer. It's trying to remove widgets from a half garbage collected panel.
Change 3776629 by Bob.Tellez
#UE4 Using a more efficient data structure for keeping track of visited nodes when verifying EDL.
Change 3776328 by James.Golding
Add command line option (-statnamedevents) for enabling named events
Change 3776024 by Nick.Darnell
Slate - Adding an accessor to SSafeZone to get the amount of padding that will be added, given some scale.
Change 3775569 by Gil.Gribb
UE4 - Fixed bugs with r.DelaySceneRenderCompletion
Change 3775543 by Luke.Thatcher
[XBOXONE] [~] Remove stall in D3D12 CreateRHIBuffer
- Buffer update is enqueued as a task on the RHI thread instead of stalling the RHI thread for the duration of the update.
Change 3775488 by Thomas.Sarkanen
Prevented skeletal meshes that are not being ticked due to URO from dispatching tick tasks
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3775219 by Bob.Tellez
#UE4 Dont SerializeThumbnails when calling savepackage while editoronly data is excluded (cooking). This saves a lot of memory while cooking
Change 3774886 by Mike.Fricker
Fixed occasional crash when backing out to lobby
- Don't force DF data to be updated when the mesh isn't in the world or has no scene interface
#jira FORT-60863
Change 3774767 by Ori.Cohen
Fix race condition for creating statid in test configs
Change 3774682 by Bob.Tellez
#UE4 Don't bother clearing cached platform data during shutdown purge since there may be a lot of it and it takes a while to destroy it.
Change 3774621 by Bob.Tellez
#UE4 Move Tree rebuilding during cook from Serialize to PreSave to avoid building the tree multiple times for a single platform. Also properly clear out CacheMeshExtendedBounds.
Change 3774201 by Gil.Gribb
UE4 - Fixed rare crash caused by unmounting pak files.
Change 3773920 by Gil.Gribb
UE4 - Added experimental option r.StartPrepassParallelTranslatesImmediately which allows the parallel translate tasks from the prepass to start before we init shadows. Disabled by default.
Change 3773896 by Thomas.Sarkanen
Push non-rendered anim updates back onto the worker thread
Now when meshes are set to EMeshComponentUpdateFlag::AlwaysTickPose, we optionally kick of a task to perform parallel update only (no evaluation).
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3773886 by Gil.Gribb
UE4 - Reduced r.RHICmdMinCmdlistForParallelSubmit from 2 to 1.
Change 3773882 by Gil.Gribb
UE4 - Improved profiler markers when they are used without stats to cover the task graph and some things related to the parallel renderer.
Change 3773461 by Gil.Gribb
UE4 - Increased the granularity of the ParallelFor blocks for greater load balancing.
Change 3773459 by Gil.Gribb
UE4 - Adds TLS caches for MallocBinned2 to the Audio thread.
Change 3773458 by Gil.Gribb
UE4 - Added an experimental option to do the slate render before waiting for the rendering tasks.
Change 3773011 by Robert.Manuszewski
Header (uasset) and export (uexp) files will now be compared seperately when running cook commandlet with -diffonly to avoid situations where a mismatch in size of the header produces more differences between exports.
+ Renamed ini setting to ignore header differences from SkipHeaderDiff to IgnoreHeaderDiff
Change 3772867 by Thomas.Sarkanen
Nativization now correctly generates and builds code for "Client" builds
Overall this is a bunch of hacks, but necessary for nativization to work at present. Once the cooker and UAT both have a concept of "Client" targets, this can be implemented properly.
Instead of building to a "Client" directory, we build to "Game" for client-only platforms (like PS4, XboxOne)
Also we need to add "Client" targets to the whitelist for the nativized assets plugin, as UBT still thinks it is building for "Client"
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3772408 by Robert.Manuszewski
Cook commandlet will now report full property name when running a diff against the existing cook (-diffonly)
Change 3772359 by Thomas.Sarkanen
Improvements to the Cpp backend to allow VC++ to compile nativized code more effectively
Added a new scoped helper to wrap areas of the code in PRAGMA_DISABLE_OPTIMIZATION. This helps with functions that are large tables or long lists of initializations.
Split anim node initialization up into functions, called from a seperate function dedicated to initializing anim nodes. This splits the 5k+ line constructor into mutiple smaller functions, which the compiler has no problems with.
Overall (along with splitting up the anim BP into functions in the asset) this reduces compilation time for the worst-case compilation unit from ~11m 40s to ~2m 32s.
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3771975 by Zak.Middleton
Fix character proxies doing up to two floor check when only rotation changes. Add some optional verbose logging to FindFloor() and ComputeFloorDist().
#jira FORT-61134
Change 3771421 by Ori.Cohen
Fix CIS
Change 3771052 by Robert.Manuszewski
Package diff improvements (-diffonly mode for cooker). Exposed max diffs to report to ini and added the ability to suppress header differences reporting as they are usually a result of differences in exports anyway.
Change 3771039 by Bob.Tellez
#UE4 Allowing use of -FPS in PGO profile builds
Change 3770747 by Ori.Cohen
Added missing stat named events for anim bp
Change 3769616 by Arciel.Rekman
UBT: Use response files for compiler when compiling for Linux.
- Some command lines are too long when cross-compiling on Windows, which is a problem for non-unity builds (or local changes that result in exclusion of checked out files from the lumped units).
Change 3769457 by Gil.Gribb
UE4 - Added eviction to r.DoLazyStaticMeshUpdate. It just removes 10 prims a frame in a rolling fashion.
Change 3769136 by Michael.Noland
Engine: Improve IsServerDelegateForOSS to allow it to use the play world during PIE even if no context was passed in
Change 3768736 by Robert.Manuszewski
More debug info for ensure in FLinkerSave when a name that has not yet been mapped is being serialized
#jira FORT-60943
Change 3768634 by Robert.Manuszewski
Small optimization to FEDLCookChecker::Verify function
Change 3768603 by Robert.Manuszewski
Merging CL #3766740 by Steve.Robb
TMultiMap::Append added.
Change 3768586 by Ben.Woodhouse
csv profiler screen message
Change 3768506 by Thomas.Sarkanen
Duplicating CL 3764661 from Paragon:
Only update Children attached to Sockets in USkeletalMeshComponent::PostBlendPhysics().
Saves ~20% of STAT_UpdateChildTransforms and ~10% of STAT_UpdateLocalToWorldAndOverlaps in 5ofEach_Dusk_vs_Dusk automation test.
#jira OR-46341
#tests LaneMinionFXTests, monolith w/ full teams.
Change 3768504 by Thomas.Sarkanen
Duplicating CL 3758315 from Paragon:
Optimized PostAnimEvaluation when URO is skipping a frame with no interpolation. Skip unnecessary work.
PreEvaluateAnimation() is now only called if we're about to evaluate anims. PostEvaluateAnimation() is also called only if we have evaluated animations.
Therefore PostEvaluateAnimation() has been pulled inside of PostAnimEvaluation() instead of FinalizeTransforms.
Added a call to ConditionallyDispatchQueuedAnimEvents() in the event that we're not calling PostBlendPhysics because we have not evaluated or interpolated anims.
Added missing call to PostEvaluateAnimation() for PostProcessAnimInstance.
#jira OR-46341
#tests minion FX perf map, lane minion test map, monolith match with 2 full teams.
Change 3768097 by Bob.Tellez
#UE4 Fix non-editor CIS
Change 3767957 by Bob.Tellez
#UE4 Fix an issue that was causing FullLoadAndSave to fail to cache platform data for textures that were created by landscape on mobile and another issue that caused parallel saving to fail in landscape (when cooking for mobile targets)
Change 3767906 by Mike.Fricker
Add Blueprint functions to query parameters from MIC
- GetScalarParameterValue
- GetTextureParameterValue
- GetVectorParameterValue
MIDs already had these functions, but MICs did not.
Change 3767737 by Max.Preussner
Engine: Fix for external textures referenced by a material before being associated with a media player never having their uniform expressions recached
#author jack.porter
#jira FORT-59777
Change 3767735 by Bob.Tellez
#UE4 Setting Opened to false in FOutputDeviceFile::TearDown so if the device file gets initialized again it will do the same initialization logic as the first time.
#jira FORT-60918
Change 3767244 by Ethan.Geller
#jira FORT-60885 Merge in fix for memory leak from 4.18.1.
Change 3766567 by Marc.Audy
Fix initialization ordering warnings
Change 3766443 by Jian.Ru
Submit PSO locking fix again as it has passed local tests
Change 3766362 by Ori.Cohen
Added the ability to get concurrent captures in Test configurations without having to turn full stats on
Change 3766277 by Marc.Audy
Shrink Skinned and Skeletal Mesh Component, FBodyInstance, and UBodySetup
Change 3766275 by Marc.Audy
Better pack UTexture* classes
Change 3766272 by Thomas.Sarkanen
Fixes to enable auto-nativization for animation blueprints
For blend profiles in particular, I've added subobject support to the fake import table building for nativized assets:
- In FEmitterLocalContext::FindGloballyMappedObject, if we dont find the referenced asset then we traverse the object's outer chain if it is a subobject. We add it to UsedObjectInCurrentClass if we find its outer.
- Updated the structure used to build the fake import table to include a specified outer. Beforehand we assumed that all objects referenced by the import table were 'top-level'.
- Updated the fake import table building code in FLinkerLoad::CreateDynamicTypeLoader() to use the new specified outer if found. This asserts if it couldnt find the outer in the already-parsed dependencies (as it reverse-iterates). If in the general case thius turns out to be a problem we can move this to a two-pass system.
Disabled fast-path optimization when running a native anim BP, as native code is faster!
#jira FORT-52823 - Nativizing Player Animation Blueprints
#jira FORT-57378 - Perf optimization: animation blueprint improvements
Change 3766215 by Marc.Audy
Shink FFromatContainer from 88 bytes to 24 by storing in TSortedMap instead of TMap
Change 3765664 by Michael.Noland
Engine: Add support for sets to FJsonObjectConverter::JsonValueToUProperty
Change 3765624 by Marc.Audy
Create helper macro in Archive.h for encapsulating needed steps for serializing a bitpacked boolean
Change 3765200 by Nick.Darnell
Slate - Fixing a memory leak in the invalidation panel. It never cleared out the cached textures and materials it kept alive during retention.
Change 3764881 by Wes.Hunt
Fix FApp::Get/SetIdleTimeOvershoot. It was overwriting IdleTime, which made FrameTimeWithoutSleep look like FrameTimeWithSleep.
#jira FORT-60585
#review-3764882 @arciel.rekman
Change 3763872 by Max.Chen
Sequencer: Set default completion mode for all sections to project default.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763871 by Max.Chen
Sequencer: Add config for default completion mode for movie scene sequences. The default for level sequences is RestoreState. All others, such as UMG are set to KeepState.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763810 by Gil.Gribb
UE4 - remove some init timing spew in programs (i.e. UHT)
Change 3762939 by Robert.Manuszewski
Removing all locks from FEDLCookChecker to improve SavePackage performance
Change 3762851 by Bob.Tellez
Duplicating CL#3740778 from //UE4/Dev-Editor
Fixed issue with content browser column sorting
#jira UE-49460
Change 3762660 by Bob.Tellez
#UE4 Fix a few parallelsave threading problems.
Change 3761861 by Marc.Audy
Fix archive complaints about bitfield
Change 3761802 by Marc.Audy
Pack FTimeline, FHitResult, FAnimUpdateRateParameters, FMeshBuildSettings
Change 3761299 by Matt.Kuhlenschmidt
Fix levels not being lockable/unlockable if they are not checked out
#jira FORT-60086
Change 3760422 by Bob.Tellez
#UE4 Stop caching or clearing platform data when saving concurrently. This was causing threading problems in materials.
Change 3760113 by Jian.Ru
Back out changelist 3759715 as it causes a crash on UGS autotest
Change 3759761 by Jian.Ru
Clean up some debug comments
Change 3759715 by Jian.Ru
Removing excessive locking when accessing PSO caches.
Change 3759285 by Nick.Darnell
Editor - Fixing the length of the datatable row dropdown in the editor.
Change 3758334 by Alexis.Matte
Fix a crash when importing morph target there was a unsync between some buffer depending on the import options
#jira UE-52319
Change 3758332 by Ben.Marsh
Fix output subfolder being appended twice when generating project files. Causes incorrect command line when launching from Visual Studio.
#jira
Change 3758215 by Brian.Bekich
Make Tint property of FSlateBrush NotReplicated now that it is WITH_EDITORONLY_DATA so that cooked clients can connect to uncooked servers
Change 3757702 by Bob.Tellez
#UE4 Fix -NoConcurrentSave cook option in FullLoadAndSave
Change 3757545 by ben.marsh
Suppress Arxan warning about being unable to install a default guard at it's default location.
Change 3757452 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Fixing build error on linux.
Change 3757389 by Hongyi.Yu
Fixed the crash in UEditorEngine::CheckForWorldGCLeaks() when load a level (level A), PIE, load a sublevel of level A and then load another level.
#jira FORT-58283
Change 3757229 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Change 3757077 by Max.Preussner
MediaAssets: Fix for media texture crashing if media player is generated from GC clustered blueprint
#jira FORT-59774
#jira UE-51943
#tests none
Change 3756854 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Backed out unintentional network checksum change!
Change 3756790 by Bob.Tellez
#UE4 Fix inconsistency with how FSoftObjectPtr case is managed between FLinkerSave and FArchiveSaveTagImports, which would cause a cook ensure under some circumstances
Change 3756639 by Arciel.Rekman
Pool memory (only 64KB allocations) on servers (FORT-60342).
- Has a fixed cost of 1GB virtual memory usage.
#jira FORT-60342
Change 3755995 by Alexis.Matte
Fix crash when importing morph target with "built in" tangent option
#jira UE-52319
Change 3755896 by Arciel.Rekman
Remove unnecessary switch for profiling (part of FORT-58878).
- -fno-omit-stack-pointer is only needed when getting callstacks for perf.
#jira FORT-58878
Change 3755711 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Initialize network GuidCache entries as soon as Guids are registered on the server so that we can fill them out with valid information before the object is destroyed. Fixes issues when a guid is exported for the first time to send a destroy to clients. (from RyanG)
Change 3755701 by David.Ratti
FObjectReplicator no longer a GCObject since adding/removing from the global GCObject list is too slow. Managing FObjectReplciators's object references at the NetDriver level now.
#jira FORT-60317
#review-3755702 @Ryan.Gerleve
Change 3754928 by Arciel.Rekman
Linux: add LTO support and more.
- Adds ability to use link-time opitimization (reusing current target property bAllowLTCG).
- Supports using llvm-ar and lld instead of ar/ranlib and ld.
- More build information printed (and in a better organized way).
- Native scripts updated to install packages with the appropriate tools on supported systems
- AutoSDKs updated to require a new toolchain (already checked in).
- Required disabling OpenAL due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219089
#jira FORT-58878
Change 3753986 by Ben.Zeigler
#jira UE-45505 Fix issue where FCoreUObjectDelegates::OnAssetLoaded was being called from an inner loop inside EndLoad. Maps would register components from that callback, and if those registers started their own loads, those objects would be returned in a partially loaded state. We now defer the asset loaded callback to the very end of the loop so recursive loads work properly
Change 3753274 by Ben.Marsh
Fix blank lines in errors and warnings being omitted from notification emails.
#jira
Change 3753175 by Thomas.Sarkanen
Fix hang in animation editor menus
Sound waves were being loaded by the visibility delegate for the 'play' button overlay. This caused major hangs as the ogg compressed data was built on the fly. Handled the unloaded asset case in the various delegates.
Also made the menu larger, as picking a sound wave was all but impossible when you couldnt even see one in the list.
#jira UE-52271 - Persona menu option locks up editor
Change 3752887 by Nick.Darnell
Slate - Adding automatic invalidation to a few more widgets that were found lacking when adding or removing children.
Change 3752785 by Marc.Audy
Avoid doing any work to evaluate streaming volumes if there are no player controllers using streaming volumes
Change 3752185 by Ben.Marsh
Reduce cook time regression caused by correcting package names to match case on disk (to fix deterministic cooking problems). Switched to use IPlatformFile::GetFilenameOnDisk(), and improved performance of FWindowsPlatformFile::GetFilenameOnDisk() by using GetFinalPathNameByHandle() instead of recursively searching up the directory tree.
#jira
Change 3751813 by Ben.Marsh
Improve parsing of diagnostics for deterministic cooking test. Now allows multiple lines in the generic EC error/warning matcher if indented more than the first line, and skips over empty lines.
#jira
Change 3750413 by Ben.Zeigler
Fixes for cook save performance regressions. Add GetAllMarks to object and use that to dramatically reduce contention for the object mark annotation. Implement ShouldLoadForServer/Client directly on some core classes to stop it from calling the slow generic one
Fix issue where refreshing tags for asset registry would do a very slow array delete/add
Improve speed of redirectcollector, there's no need to force-rehash the soft object path list as the remove handles it conditionally
Change 3750014 by Lina.Halper
- duplicate change from following changelists
CL 3669273 - delete all tracks option
- allow to opt out on bone track importing
- fixed pose preview for fullbody to select weights that has pose from asset.
CL 3672170 Remove track support for Animation Blueprint Library
This is required for facial pose retargeting
Change 3749714 by Brian.Bekich
Back out changelist 3748287
#jira FORT-60125
Change 3749377 by Robert.Manuszewski
Improved log formatting for reporting deterministic cook issues.
#jira FORT-59919
Change 3749360 by Robert.Manuszewski
Improved performance of -diffonly mode for cook commandlet for assets with hundreds of thousands of differences.
#jira FORT-59919
Change 3748746 by Hongyi.Yu
Fixed compiling error in Automation project
#jira FORT-59621
Change 3748530 by Mike.Fricker
Fixed non-determinism of landscape grass across platforms/compilers
This causes bushes to be located in different places depending on what platform you were playing on.
1) Random number reseeds were happening as part of function arguments to FVector(), but function argument evaluation order is unspecified, and behaved differently on Consoles/Mac/Windows. Fixed this bug.
2) Strings used for foliage CRCs could use different character sizes on different platforms. Now we always use ANSI.
3) Strings used for CRCs could have possibly have different case. Now forced lowercase.
#jira FORT-60109
Change 3748471 by Zak.Middleton
Added stats to NetDriver TickFlush and stats gathering within that function.
Change 3748287 by Brian.Bekich
Adding net.MaxStringSerializationSize to cap maximum string read from network, default to 4096, used by FNetBitReader
Deprecating MAX_STRING_SERIALIZE_SIZE in favor of the cvar
FInBunch defaults to prior behavior if cvar is 0
UPackageMap::SerializeName and UPackageMapClient::SerializeNameAsString will always cap at NAME_SIZE
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3747980 by Bart.Hawthorne
In Oodle, only generate and write dictionaries on Windows, Mac, and Linux
Change 3747642 by Gil.Gribb
Fix CIS
Change 3747635 by Zak.Middleton
Avoid string alloc on every ServerMove() call on the server.
Change 3747560 by Gil.Gribb
UE4 - Fixed XBox and Windows thread priorities. Only 2 though -2 seem usable and some of the old values were being ignored.
Change 3747548 by Gil.Gribb
UE4 - Changed thread pool to be TPri_SlightlyBelowNormal so that they will not preempt HP task graph tasks.
Change 3747544 by Bart.Hawthorne
When detecting if Oodle is installed, use the newest version instad of the oldest one.
Change 3746440 by Robert.Manuszewski
Dterministic cook issues reporting improvements
- Huge performance improvements
- Added new metric to the summary: NumberOfDifferencesInPackages
- Diff stats have their own section now (Package.Diff)
- When running with -diffonly there commandlet will not log the Warning/Error summary anymore
- Callstacks are no longer logged with instruction addresses
- Because callstacks are no longer logged with addresses I can collapse them for structures that otherwise would be split into multiple separate callstacks
- Callstacks, Serialized Object and Serialized Property are now indented
- Each asset is capped at 5 entries. If there's more differences, they'll be logged as single warning.
- Replaced \r\n with \n in the callstack log to make it work better with EC
#jira FORT-59919
Change 3746426 by Gil.Gribb
UE4 - Tuned dispatch in the deferred renderer. Added r.DoPrepareDistanceFieldSceneAfterRHIFlush and defaulted it to on.
Change 3746348 by Mike.Fricker
Added new CVars to toggle level streaming behavior
- No effective change to engine yet. The defaults values enable the same default behavior.
- New CVar: "s.ForceGCAfterLevelStreamedOut" (Whether to force a GC after levels are streamed out to instantly reclaim the memory at the expensive of a hitch.)
- New CVar: "s.ContinuouslyIncrementalGCWhileLevelsPendingPurge" (Whether to repeatedly kick off incremental GC when there are levels still waiting to be purged.)
- New CVar: "s.AllowLevelRequestsWhileAsyncLoadingInMatch" (Enables level streaming requests while async loading (of anything) while the match is already in progress and no loading screen is up)
Change 3746127 by Gil.Gribb
UE4 - Slight tweak to more agressively batch occlusion queries.
Change 3746111 by Cecil.McRae
Change 3745681 by Bob.Tellez
#UE4 Prevent attempting to execute a remote process to get the metal shader compiler version if no remove process machine has been configured. (Fixes a warning)
Change 3745631 by Matt.Kuhlenschmidt
Fix details panel crash after compiling blueprints that have edit conditon properties
Change 3744544 by Gil.Gribb
UE4 - Downgraded a fatal error to a warning. Example: Found package without a linker, could find SceneComp in /Game/AIDirector/AIDirector_Fortnite, but somehow wasn't finished loading. This is a sort of cook mismatched caused by the fact that all PS4 cooks have server-only data in them.
#jira FORT-59879
Change 3744419 by Matt.Kuhlenschmidt
Fix opening color picker causing values to change. Was due to conversion between srgb and linear color.
Change 3744270 by Ben.Marsh
Merging change to include deterministic cooking summary from Dev-Core (CL 3743182).
#jira FORT-59919
Change 3743621 by Guillaume.Abadie
Fixes subsurface profile fallback to lit shading model when Opacity == 0, introduced by 3447144.
#jira UE-51569
Change 3743403 by Gil.Gribb
UE4 - Merged lockfree / taskgraph fix from //UE4 (CL 3732262)
Change 3743392 by Gil.Gribb
Merged IO fixed from //UE4 (CL 3641155)
Change 3743376 by Gil.Gribb
UE4 - Added r.WarningOnRedundantTransformUpdate to produce warnings on redundant transform updates.
Change 3743372 by Gil.Gribb
UE4 - Added a stat for distance field verification...which takes a very long time, but does not affect test or shipping config.
Change 3743030 by Bob.Tellez
#UE4 Revert some code the was accidentally merged to UE4Main
#jira UE-52032
Change 3742611 by Josh.Markiewicz
#UE4 - fix for crash in destructor probably related to the freeing of memory via default destructors AFTER CefShutdown() has been called
#tests crashes before, no crash after (not sure if it was a 100% crash but this seems better regardless)
Change 3742187 by Nick.Darnell
Slate - Adding a new optional parameter to direct routing for the widgets under the cursor in Slate Application. Essentially ProcessReply occasionally needs to know the widgets under the cursor, the previous implementation, just used the routing path, this results in missing sending mouse leave messages to widgets under the cursor when dragging begins, which often left things with hover effects in bad states.
Change 3742053 by Michael.Trepka
Copy of CL 3713881
Added -buildscw to Mac Build.sh script to build ShaderCompileWorker in addition to the requested target. Xcode passes it to the script when building non-program targets.
#jira UE-31093
Change 3742050 by Michael.Trepka
Copy of CL 3711085
Reenabled UBT makefiles on Mac
Change 3741924 by Josh.Markiewicz
#UE4 - delete EpicSurvey module
- working toward engine/plugins/online removal from game branch
Change 3741865 by Nick.Darnell
UMG - Fixing a High DPI bug that wasn't scaling the offset for DragDrop widgets when using In-Window rendering that games depend on for DragDrop effects.
Change 3741442 by Ryan.Gerleve
Fix initialization order warnings
Change 3741370 by Ryan.Gerleve
Back out changelist 3689397. The memcpy in one of the FInBunch constructors is not portable and causes this change to break networking on Android.
Change 3740914 by Peter.Knepley
Restore player name obsfuscation
Change 3740828 by Marc.Audy
Dynamically create FKey if the char code is unknown
#jira FORT-59735
Change 3740811 by Ben.Marsh
UAT: Fix double-spacing of lines output by Utils.RunLocalProcess, and use a non-local function to output them for more readable logs.
#jira
Change 3740328 by Bob.Tellez
#UE4 Fix FullLoadAndSave cook method
Change 3740327 by Bob.Tellez
#UE4 Minor movie scene cooking improvements
Change 3740280 by Bob.Tellez
#UE4 Fix shipping config CIS
Change 3740232 by Bob.Tellez
#UE4 Gave OodleHandlerComponent a short name so it doesnt hit maxpath length issues on build machines.
Change 3740209 by Nick.Darnell
UMG - Finishing the ability to add a "Custom" method for Navigation. Currently the editor implementation leaves me wanting, but it works for now. You can put the name of a function to call (needs to match a signature that returns a UWidget).
Change 3740207 by Nick.Darnell
Slate - Navigation attempts when the user claims they are doing custom or explicit, if those methods don't return a valid widget, we don't treat it like the attempt failed and fallback to default navigation methods. Instead we use it as a trigger to indicate that no navigation should occur and treat it like a stop.
Change 3740189 by Bob.Tellez
#UE4 Fix mouse cursor position being set when hovering over the viewport in windowed mode despite not having focus
Change 3740171 by Marc.Audy
Fix merge issue causing compile error for AutomationTool
Change 3739270 by Ben.Woodhouse
Use background task graph affinity on platforms that implement it (e.g. XB1). Saves 8ms on GC spikes and ~0.5ms on the renderthread
#jira FORT-56961
Change 3739244 by Ben.Woodhouse
-statunit commandline option
Change 3738920 by peter.knepley
Fix issue where simulated proxies had bad crouch state when re-entering relevancy
Change 3738904 by Gil.Gribb
UE4 - Moved audio decompression tasks to the background thread pool. Controlled by a cvar AudioThread.UseBackgroundThreadPool, which defaults to 1.
Change 3738378 by Ori.Cohen
Added better profiling for scene query hitches
Change 3736984 by Ben.Woodhouse
Dummy merge: Accept main version of windowsrunnablethread.h, so Windows gets the new priorities
#jira FORT-56700
Change 3736754 by Zak.Middleton
Remove engine hacks of K2_SetActorLocation etc for pending engine merge. Will replace with delegates on transform updates for relevant classes.
Change 3736282 by Hongyi.Yu
Don't check target file while doing iterative shared prebuild cooking.
#jira FORT-58911
Change 3736109 by Michael.Trepka
Updated FMallocLeakDetectionProxy to not use a critical section internally on top of thread safety measures performed by FMallocLeakDetection and the underlying FMalloc implementation. The improvements are biggest on Mac, in particular in low framerate situations, as Metal RHI uses malloc heavily on multiple threads, but it's also a nice 10% improvement on a high end PC.
#jira FORT-55309
Change 3735765 by Ben.Woodhouse
Fix GTSynctype logic when vsync is disabled. This was breaking profiling
Change 3734436 by Marcus.Wassmer
More reliable Aftermath data.
#jira FORT-45518
Change 3734103 by Bob.Tellez
#UE4 Exposing GetRefPosePosition on SkinnedMeshComponent to BPs
Change 3733985 by Saul.Abreu
#jira FORT-58816
"Special case zero-width space in the text shaper to avoid fonts rendering the fallback glyph" - Jamie Dale
Needed to workaround an issue with guillemets (weird arrow quotes).
Change 3733922 by Brian.Bekich
Setting max serialization size in FNetBitReader to prevent runaway string reads from replicated object paths
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3733850 by Max.Chen
Sequencer: Return unhandled only if not dragged. This fixes a bug where dragging in the track area would sometimes leave the handled state with the time slider controller and not allow you to pop up a menu with the movement tool.
#jira FORT-56092
Change 3733299 by Ethan.Geller
#jira FORT-58943 Handle corner cases for repeated calls to precache buffers.
Change 3732907 by Gil.Gribb
UE4 - Removed slow HLOD code from frustum cull loop and set things up at AddPrim time instead. Saves 1-3ms.
Change 3732728 by Robert.Manuszewski
Fixing a crash when dumping stats with massive callstacks
#jira FORT-58901
Change 3732438 by Marc.Audy
When a client informs the server that it has loaded a streaming level force a net update on all dormant actors that have at one point replicated data to relevant clients and ensure that the connection's destroyed startup/dormant actors list is properly populated.
#jira FORT-56997
Change 3730413 by Lukasz.Furman
fixed PlayerName encryption key
#jira FORT-59066
Change 3729588 by Bob.Tellez
#UE4 Only calling FixupData on load. Fixes crash during parallel saving.
Change 3729475 by Marc.Audy
Fix missing ;
Change 3729444 by Marc.Audy
Fix cases where GetWorld() being called multiple times per function
Change 3729143 by Hongyi.Yu
Added support to extract pak files to mount point.
- Extract with "-ExtractToMountPoint" when extracting pak in DiffCookedContent()
#jira FORT-58635
Change 3728981 by Nick.Darnell
Slate - Fixing a bug with Slate turning on statid tracking even when the slate verbose stats are not being used.
Change 3728838 by Zak.Middleton
Compile out GetWorld() call in check() in Test and Shipping builds, to avoid skewing profiling.
Change 3728604 by Jian.Ru
Submit one render command rather than many in FScene::UpdateParameterCollections
Change 3728434 by Marc.Audy
PostSignificance should always fire when unregistering regardless of whether this is the last object in the tag.
Change 3728427 by Gil.Gribb
UE4 - reduce stat overhead when not collecting stats.
Change 3728197 by Marc.Audy
Properly call post significance on initial registration if the post significance type is sequential
Change 3726266 by Gil.Gribb
UE4 - Force HISMC trees to rebuild during cook. This allow us to change parameters without resaving maps.
Change 3724501 by Marc.Audy
Fix initialization order
Change 3724411 by Ben.Woodhouse
Point light shadow rendering optimization - Made per-triangle culling take Z into account.
In FortGPUTestbed (with grass shadow casting enabled), GSVerticesOut reduced from 464k to 234k.
On xbox one, a pointlight GPU cost reduced from 6.7 to 4.1ms.
On PS4, GPU cost went from 2.3 to 1.9ms.
#jira FORT-58921
Change 3724367 by Chad.Garyet
Downgrading lock warning about still waiting to a message instead of a warning.
Change 3723903 by Max.Preussner
MediaAssets: Merged workaround for uninitialized media sound waves from 4.17
#jira FORT-57260
Change 3723134 by Lukasz.Furman
added deprecation for PlayerState.PlayerName, it should remain accessible only through Get/Set functions to control obfuscation
Change 3722955 by Jian.Ru
Fix a compilation warning
#jira FORT-58749
Change 3722667 by Luke.Thatcher
[BUILD] [!] Fix PGO failures on build machines.
- The strings "Failed" and "error" are always treated as build failures, even if the build task returns a success code.
- Failure to reserve a device should not be fatal.
#jira FORT-58001
Change 3722291 by Lukasz.Furman
restored public access to PlayerName for now, current code will be going through accessor
Change 3721012 by Alicia.Cano
chunk title file generation
#jira FORT-53605
Change 3720961 by Marcus.Wassmer
Fix bad UVDensities on objects causing texture streaming to fail. Better fix will come with the engine merge.
#jira FORT-58240
Change 3719318 by Lukasz.Furman
replaced old branch name assertions
Change 3719047 by Lukasz.Furman
added branch name assertion to core headers to avoid duplicating it
Change 3718499 by peter.knepley
Fix for a crash when calling FSlateApplication::Get().FindPathToWidget in response to a widget destructing. Widget must be invalidated before the reference is cleared or else someone else might assign a shared reference to it during destruction.
Change 3716965 by Alicia.Cano
No sound was playing for Android.
#jira FORT-58302
#android
Change 3715746 by Ben.Marsh
Hide Arxan warnings about PDB files not being present.
#jira
Change 3715172 by Bob.Tellez
#UE4 FullLoadAndSave now does SavePackage in parallel.
Change 3715055 by Bob.Tellez
#UE4 Fix to actually use the precached streaming audio DDC data when cooking.
Change 3714130 by Bob.Tellez
#UE4 Core changes to allow SavePackage to be done concurrently
Change 3714099 by Bob.Tellez
#UE4 Pull the logic to initialize and uninitialize the physics scene for a world out into separate functions
Change 3713145 by Ben.Marsh
Disable an Arxan warning in EC.
#jira FORT-56926
Change 3712904 by Ben.Woodhouse
Fix for gpu profiler crash on pre-maxwell nvidia (or when r.gpuprofiler is set to false)
Change 3712693 by Ben.Woodhouse
Workaround for PS4 flip thread crash in dev builds. Caused by the flip thread/offset threads being shutdown before being initialized. The high level logic is now robust to that. We should fix the PS4 RHI ideally, but this is simpler for now.
#jira FORT-58409
Change 3712544 by Ben.Woodhouse
add missing skylight diffuse gpu stat
Change 3712515 by Ben.Woodhouse
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3712297 by Mike.Fricker
Fixed huge client hitch when applying changes to in-game options
- Every component was being re-registered when r.SimpleForwardShading was updated by the scalability system, even if the value hadn't changed. Now, it only re-registers components if the value changes on the fly. (e.g. when turning Shadows off or on PC)
#jira FORT-57661
Change 3711501 by Ben.Marsh
Fix build failure on Linux.
#jira
Change 3710962 by David.Ratti
Add SCOPE_CYCLE_UOBJECT for SourceObject of GE - this will tell us what weaponw as applying the GE
Change 3710602 by Marc.Audy
Only create MIDs as a child of the calling object if construction script is running
Change 3710421 by Ben.Woodhouse
Bring over a couple of XB1 rendering fixes from 4.18
3692692: Integrate XB1 translucent lighting fix
3674543: D3D12 : Fix bug with non-CS version of UpdateTexture3D caused by bad depthstride. This was causing corruption in the indirect lighting cache
#jira UE-49416
Change 3710338 by Marc.Audy
Fix Json <-> Property converter to handle maps with struct keys
Merged from CL# 3521195
#jira UE-46616
Change 3710226 by Bob.Tellez
#UE4 Increase TaskGraph stack size in editor builds since. SavePackage uses a deep callstack which exceeds the 384 memory limit
Change 3709046 by andrew.grant
Added ALLOW_CONSOLE_IN_SHIPPING define that Target.cs files can set to turn on console in shipping builds
#jira FORT-57180
Change 3709040 by andrew.grant
Fixed issue where this could fail if a messagebox was spawned early during initialization
Change 3708830 by Bob.Tellez
#UE4 Commandline switches/options are no longer detected when found between quote characters. This causes options from not being incorrectly detected when passed in as a value from another options. i.e. -Option="-log" no longer causes -log to be picked up. This removes the syntax of specifying parameters like "Option=Value", which should now be replaced with -Option="Value"
#jira FORT-57833
Change 3708826 by Bob.Tellez
#UE4 Removed needless calls to RegisterSerializedShaders in the saving codepath of material serialization. This function is only relevant when loading shaders.
Change 3707905 by Ori.Cohen
Fix attached skinned mesh never being unhidden due to scale 0 and render tick optimization
#jira UE-51485
Change 3706450 by Chris.Bunner
Removing illegal material set on decal component in GameplayStatics.
Set a related JIRA, this doesn't actually fix the issue but contributes.
#jira FORT-51597
Change 3706223 by Marc.Audy
Shrink UPackage class size substantially
Change 3706221 by Marc.Audy
Store CustomVersions in array rather than set
Change 3705798 by Bob.Tellez
#UE4 ShadowDepthVertexShader.usf fix to fix Mac cook.
Change 3705613 by Uriel.Doyon
Texture streaming integration from Main.
#jira FORT-57376
Change 3705137 by Michael.Trepka
Fixed MetalRHI warning when compiling without MALLOC_LEAKDETECTION defined
#jira FORT-55309
Change 3704310 by Marcus.Wassmer
fix d3ddebug error with shadowcasting pointlights
also suppress spammy d3ddebug data about texture debug names
#jira FORT-58063
Change 3703477 by Marc.Audy
Minor tweak to keep Padding on one cache line.
Change 3703449 by Michael.Trepka
Don't use parallel RHI execute on Mac if MALLOC_LEAKDETECTION is enabled as this combination affects performance significantly due to mutex locking in FMallocLeakDetectionProxy
#jira FORT-55309
Change 3703217 by Marcus.Wassmer
Update PS signatures to match VS. Fixes crashes when running witih -d3ddebug which we need to catch real problems
#jira FORT-58021
Change 3702926 by Aaron.Eady
#JIRA na
Engine Code Improvements (that this project doesn't have yet);
Added engine code for drawing a debug 2D box.
Added engine code that allows for Keyboard Shortcuts to be special characters like backslash \.
-- Code --
DrawDebugHelpers:
DrawDebugCanvas2DBox() - Added this to allow us to draw debug 2D boxes.
RemoteConfigIni:
SpecialCharMap - Updated this TCHAR* property to be in the right order so you can use special characters like backslash as keyboard shortcuts.
Change 3701976 by Michael.Noland
Editor: Rewrote CallInEditor support and promoted it so it can be used on functions in any class, not just blueprints derived from AActor:
- CallInEditor used on native UFUNCTION() declarations will now show up without having to make a BP subclass
- CallInEditor can now be used as a top-level keyword in the UFUNCTION() declaration (e.g., UFUNCTION(Category=CoolCommands, CallInEditor))
- Now shows each function as a separate button, placed in the category associated with the function
- The button strip entry is now searchable by function name or tooltip
- Prevented operating on functions that have parameters or return values, which would crash before
- Removed the duplicate copies of properties placed in the Blutility section
- Added a scoped transaction around CallInEditor execution
- Allowed functions to be marked as CallInEditor in addition to custom events (currently we don't allow editing category or tooltip on custom events...)
Editor: Moved Experimental/EarlyAccessPreview details customizations up to UObject so it can be used on any class, not just actors/components
Edigrating CL# 3374995, 3375121, and 3375308 from Dev-Framework to FN main
Change 3700836 by Bob.Tellez
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
#jira FORT-57833
Change 3700821 by Bob.Tellez
Merging CL#3461205 from //UE4/Dev-Core
Fixed parameter parsing so that arguments are not parsed if not preceeded by a whitespace (for example "-Log" was parsed in "TM-Log")
#jira UE-33790
Change 3699584 by Chad.Garyet
Upping the timeout on symstore to half an hour instead of 15 minutes. Symstore on xbox takes about ~22 minutes and if two builds are going simultaneously it can cause a job to fail due to the timeout being hit.
#jira FORT-0
Change 3698692 by Aaron.McLeran
#jira FORT-57582 crash in sound mix state code
- Removed the assert as it looks like that state is now possible.
Change 3698411 by Bob.Tellez
#UE4 One last correctness fix for when to not save generated base ini files.
#jira FORT-57315
Change 3698390 by Bob.Tellez
#UE4 Slightly more accurate logic to prevent writing of base ini files (old logic may have prevented writing of non-base ini files)
#JIRA FORT-57315
Change 3698369 by Bob.Tellez
#UE4 Ensure that Tcp/Udp messaging plugins are disabled in shipping config
Change 3698352 by Bob.Tellez
#UE4 Minor additional fix to make sure DISABLE_GENERATED_INI_WHEN_COOKED only affects cooked builds
#jira FORT-57315
Change 3698341 by Bob.Tellez
#UE4 DISABLE_GENERATED_INI_WHEN_COOKED now properly prevents all base ini file loads from happening from a generated folder. It also prevents writing generated ini files completely.
#JIRA FORT-57315
Change 3697553 by Nick.Darnell
Slate - When setting the content of an SBox it should always invalidate.
Change 3697330 by Bart.Hawthorne
APlayerController::ServerShortTimeout_Implementation now only iterates over the active object list instead of uisng an actor iterator, since non-replicated actors wont have a network object info to update.
#jira FORT-57099
#tests ran 100 player bot match
Change 3695578 by Bob.Tellez
#UE4 Fix Win32
Change 3695508 by Eric.Newman
Tweaked LogInit logging to clarify when the command line is being filtered
* Encountered this red herring when evaluating crash logs
#jira FORT-55839
#tests ran shipping & debug client builds, and editor game build
Change 3694898 by Michael.Trepka
Fixed Vorbis audio not playing on non-Windows platforms due to changes in CL 3668361
#jira FORT-57121
Change 3694655 by David.Ratti
Reimplement TweakObjetPtr optimizations with FObjectReplicator as an FGCObject instead of the owning channel being responsible for adding the replciator's ObjectPtr to the reference collection. (There are cases where object replicator ownership is transferred).
#JIRA FORT-57298
Change 3694491 by Ben.Woodhouse
Change courtesy of Gil: Drop the priority of the texture streamer using a new low-priority thread pool. This saves a 1-2ms in heavy combat in PVE (XB1 Test)
#jira FORT-57376
Change 3693609 by Ryan.Gerleve
Back out CL 3689050 since it was likely causing a crash.
#jira FORT-57298
Change 3693327 by Aaron.McLeran
#jira FORT-57416 Fixing PS4 cook.
Making sure zero pad bytes stays positive without a check.
Change 3693136 by David.Ratti
fix clang warning
Change 3692703 by Thomas.Sarkanen
Fix CIS warning on PS4/Linux
Change 3692589 by Thomas.Sarkanen
Moved exposed value handler bound function initialization to CDO postload
This means that FindPropertyByName and FindFunctionChecked dont incur any overhead when spawning in new anim instances
#jira FORT-56968 - Hitch - SkeletalMeshComponent initialization (110ms)
#tests PIE PvE, 20-bot BR game on PC/PS4.
Change 3692552 by Alex.Delesky
Change 3692495 by Bart.Hawthorne
Fix build
Change 3692488 by Bart.Hawthorne
Check for actor relevancy and level initialization when there's no channel first when prioritizing actors for replication. Dormancy checks in this case are useless because ShouldActorGoDormant will always be false, and if IsActorDormant is also true, then the result of skipping the actor is the same.
#jira FORT-57104
#tests played 100 player bot match
Change 3691819 by Bob.Tellez
#UE4 No longer conditionally including SlateDebug fonts in the cook based on configuraiton. When builds are produced that contain more than one configuration it changes what is cooked in unexpected ways so now we just always cook this font.
Change 3691805 by Bob.Tellez
#UE4 CIS fix
Change 3691784 by Bob.Tellez
#UE4 Optimization for exiting PIE. Texture streaming managers have an optimization for game worlds but were not using them for PIE worlds
Change 3691273 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3691268 by Aaron.McLeran
#jira FORT-56228 LogAudio:Warning: spam causes severe performance drop on the Mac Platform
Reducing log level
Change 3690547 by Ryan.Gerleve
Speculative fix #2 for a server crash/assert. If the timing is right, it's possible for the server to try to re-load a placed-in-map actor that was previously garbage collected. This was happening because CanClientLoadObject was always returning true for these (null) objects, even if the NetGUID corresponded to a map actor that shouldn't be loaded. Also added/improved some logging that will help in case this doesn't fix the issue.
#jira FORT-55763
Change 3690451 by Lukasz.Furman
changed branch name testing in engine hacks to use case insensitive match
Change 3690270 by David.Ratti
Cache weak object ptr in FNetworkObjectInfo to avoid reconstructing one every time we need to lookup its actor channel.
#jira FORT-57156
Change 3690227 by David.Ratti
Added optional TWeakObjectPtr parameter to packagemap functions GetOrAssignNetGUID, SUpportsObject. This allows you to pass in a weak ptr for an object if its already created. If you pass in null, the functions will create them internally.
This fixes some common cases where we were converting the same object into weak ptr multiple times in a frame.
#jira FORT-57156
Change 3690184 by David.Ratti
Cache net connection weakobjectptr when building consider list instead of constructing it again for every actor.
#jira FORT-57156
Change 3689805 by Peter.Knepley
Make ConditionalInitAxisProperties protected instead of private
#jira FORT-56414
Change 3689789 by Marcus.Wassmer
Hack workaround for missing shadowdepthps for XB1 until we get a handle on why things are exploding
#jira FORT-56792
Change 3689702 by Peter.Knepley
Allow games to have a custom MassageAxisInput function
#jira FORT-56414
Change 3689687 by Bob.Tellez
#UE4 Avoid copying the shaders array to avoid changing refcounts of shaders while serializing
Change 3689655 by Peter.Knepley
Make SmoothMouse virtual so games can have their own smoothing
#jira FORT-56417
Change 3689499 by Bart.Hawthorne
Fix Linux CIS warnings
Change 3689397 by Bart.Hawthorne
Changed FOutBunch and FInBunch uint8 entries to use bitfields instead of bytes which knocked 86% off of our net tick time
Change 3689056 by Lukasz.Furman
3rd attempt for branch name checking in engine code hacks
Change 3689050 by David.Ratti
First pass at removing use of TWeakObjectPtr from core replication classes. This should reduce FWeakObjectPtr::Get usage.
Still expecting to see FWeakObjectPtr::operator= come up a lot. Going to tackle this in a second pass which will require some deeper refactors.
#jira FORT-57156
Change 3688972 by Bob.Tellez
#UE4 Add build target flag to control DISABLE_GENERATED_INI_WHEN_COOKED
Change 3688864 by Ryan.Gerleve
Fix broken logic to find the "best" replay sample for character movement when we don't find two samples to interpolate between. Now uses the sample closest to the current time. Also added some debug drawing.
#jira FORT-56553
Change 3687654 by Bob.Tellez
#UE4 Added compile time option to disable reading generated ini files other than GameUserSettings in cooked builds.
Change 3686615 by Lukasz.Furman
Back out changelist 3686610
Change 3686592 by Matt.Kuhlenschmidt
Gave the CL description in the source control submit window more room
Change 3686020 by Ben.Marsh
Remove debug code that prints to logs while building.
#jira FORT-56923
Change 3684414 by Peter.Knepley
Back out changelist 3678336
#jira FORT-56512
Change 3683894 by Gil.Gribb
UE4 - By default, do not check for illegal calls to MarkPendingKill in the garbage collector in test and shipping configuations. This was slow.
Change 3683686 by peter.knepley
Raise MTU from 512 to 1024
#jira FORT-56756
Change 3683343 by Rob.Cannaday
Fixes insert disk popup
#jira FORT-56500
Change 3683156 by Peter.Knepley
Network optimizations to reduce alloc/free & memcpy churn saving about 10% of net tick time
Change 3682234 by Guillaume.Abadie
Cherrypick TAA refactor 3512696 and TAA fix 3668108
#jira FORT-56303
Change 3681494 by Bob.Tellez
#UE4 IsLoadedByEditorPropertiesOnly is not working properly so I removed it from FullLoadAndSave
Change 3681342 by Bob.Tellez
#UE4 Added a FullLoadAndSave option to cooking, which simply loads all content then saves it to avoid the overhead of managing which packages need to be cooked. Large perf improvement for those who cook by the book and can fit the entire game in memory
Change 3681014 by Yenal.Kal
#jira FORT-56209
#jira FORT-56272
Fixed a bug in the ability system where the ability ended callbacks could cause the ability end to be called again in the same call stack even though the ability is activated only once.
This was happening because we were broadcasting the event before we decrement the active count.
Change 3680739 by Michael.Trepka
Warn about NaN float literal values when translating HLSL to Metal instead of failing, plus added more detailed warning/error messages for NaN and unhandled values
#jira FORT-56425
Change 3679237 by Bob.Tellez
#UE4 Remove some debug logging
Change 3679187 by Bob.Tellez
#UE4 Dramatically imrpove speed of writing cookloadorder log file
Change 3678926 by Bob.Tellez
#UE4 Minor savepackage speed improvements
Change 3678336 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3676998 by Ben.Woodhouse
Fix XGE shader compilation so it doesn't crash randomly
Change 3676606 by Ori.Cohen
Update GC to be 61.1 to avoid heartbeat collision
Change 3676447 by Ori.Cohen
Fix CIS warning
Change 3676286 by Max.Preussner
Fixed client Crash UMediaSoundWave::GeneratePCMData (FORT-56107)
#jira FORT-56107
Change 3674591 by Ryan.Gerleve
Don't filter out PendingKillPending actors from FNetworkObjectList::Find. This was causing actors that get destroyed while dormant on the server to never be destroyed on clients.
#jira FORT-55802
Change 3674181 by Michael.Noland
Framework: DLL export LogGameplayTags
Change 3674138 by Billy.Bramer
#jira FORT-56138, FORT-56139
- Duplicate CL 3396590 from //Orion/Main re: ranged-base for iteration ensure from montage changes
Change 3672464 by Lukasz.Furman
removed recast layers crash tracking code
Change 3672153 by Daniel.Lamb
Added some debugging code to help track down why shaders are hashing poorly.
Change 3671498 by Luke.Thatcher
[~] Modify new frame syncing to reduce performance regression seen when the game is running over budget.
- Rather than forcing a flip sync after we kick off one frame early, we just continue to kick frames if we time out. This allows the game thread to get ahead when we're over budget.
- The game thread will naturally resync with the vsync when we return to being in budget.
#jira FORT-55842
Change 3671079 by Ryan.Gerleve
Fix an edge case where the PackageMap on the server would try to resolve objects from default NetGUIDs even if their outer has already been garbage collected. This could lead to a completely unrelated object being returned instead of null, leading to asserts and potentially other issues.
#jira FORT-55763
Change 3670487 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3670351 by Zak.Middleton
Back out changelist 3669817 (networking optimizations). Would rather have more testing before it goes to Release-Next. Will resub just for main and RP.
#jira FORT-55999
Change 3670344 by Josh.Markiewicz
#UE4 - more verbose logging for SetExpectedClientLoginMsgType
Change 3670323 by Wes.Hunt
Fix for dedicated servers not flushing events in a timely manner.
#jira FORT-56015
Doh, using GFrameNumber was NOT a good idea on servers... :-/
Change 3669817 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3668416 by Michael.Noland
Core: Changed FString::ParseIntoArray to use Reset instead of Empty on the passed in array, allowing it to be approximately resized
#jira FORT-55887
Change 3668411 by Olaf.Piesche
Always cache depth collision particle shader
#jira FORT-51307
Change 3668361 by Aaron.McLeran
#jira FORT-55628 Attempt to bypass crash and log an error if libvorbisdll fails to load.
Change 3667892 by Rob.Cannaday
libwebsocket libs to handle getprotobyname("TCP") failing the libwebsockets connection
#jira FORT-55917
Touch LwsWebSocket.cpp to ensure the module gets built with the new libs
Change 3667308 by Uriel.Doyon
Postponed the release of IO requests when canceling mip updates to prevent threading issue.
#jira FORT-54491
Change 3666835 by Lukasz.Furman
fixed overlapping index buffers when static mesh exports both convex and simple collisions for navigation
#jira UE-50370
Change 3665374 by Mike.Fricker
Fixed server crashing after hotfixes have re-imported curve table data
- The hotfix system is capable of replacing the content of a UCurveTable on the fly
- If any systems had references to inner curves on that curve table, they would become invalid
- This needs to be fixed in 1.6.4 (tonight) and also in 1.7
#jira FORT-55792
Change 3665063 by Daniel.Broder
Fixed crash in GameplayTagQueryCustomization when choosing "Save and Close" on GameplayTagQuery after setting a query due to nullptr NotifyHook in CloseWidgetWindow.
Added additional if (StructPropertyHandle.IsValid()) wrappers and one check(StructPropertyHandle.IsValid()); the former to be consistent with other code and prevent possible crashes, the latter to at least catch the cause of a possible crash properly without having to change the code more significantly to handle it gracefully.
Also changed some if( X ) to if (X) to match coding standards and provide consistency within the file.
Michael, I'm Reviewing you on this fix since you brought this change over from Framework. And Marc because you reviewed him on that change.
#UE4 #NoReleaseNotes #RNX
Change 3664948 by Lukasz.Furman
reduced number of allocations in StorePathfindingDebugData, optimized path length calculations to avoid recursion
#jira FORT-51111
Change 3664916 by John.Abercrombie
Copy CLs 3383318 & 3388506 from //Orion/Main/Engine/Source/Runtime/Engine/...
- Been testing with this for a while now
- This change makes particle effects show up on the current frame's pose for skel meshes as well
Removed my StopAllMontagesByGroupName temp hack
CL 3383318
Delay dispatching of AnimEvents (Notifies and Montage Events) until after we receive an updated animation pose (if applicable).
This fixes AnimNotifies playing particle effects using a socket location using last frame's pose. Now they use the current frame's pose.
CL 3388506
Delay clearing of MontageInstances and triggering 'OnAllMontageInstancesEnded' until all Montage Events have been dispatched.
Also fix SkelMeshComponent ticking on dedicated servers when rejoining in progress.
#jira FORT-55102 - Server Crash UAnimInstance::StopAllMontagesByGroupName
Change 3780616 by Gil.Gribb
Fixed and reenabled r.DelaySceneRenderCompletion
Change 3778979 by Gil.Gribb
UE4 - Improved the performance of grass updates and added the ability to not do all of them every frame.
Change 3778200 by Nick.Darnell
UMG - Making it possible to cancel delays and all animations on widgets. Useful when destroying a widget and needing to stop any async state.
Change 3777612 by Zak.Middleton
Perf: Added option to CharacterMovementComponent to skip immediate forward prediction for proxies on the frame they receive a network update (bNetworkSkipProxyPredictionOnNetUpdate). This avoids all forward prediction sweeps and floor checks on those updates. Intermediate frames will interpolate with prediction. This can also be disabled globally with the CVar "p.NetEnableSkipProxyPredictionOnNetUpdate 0".
Added NetworkSmoothingDisableProxyPredictionForPawnLOD to force disabling full simulation for LOD >= this value (currently 3, so bottom 75 pawns). This takes precedence over current distance and view angle checks for prediction (mesh interpolation is untouched).
Change 3774338 by Ben.Woodhouse
Convert the D3D12 PSO caches to use RwScopeLocks. This change is courtesy of a shelf from Gil, plus a couple of minor fixes.
Saves up to a millsecond of frame time in CPU-bound scenarios
Change 3773462 by Gil.Gribb
UE4 - Add particle batching. This is disabled by default but can improve thread scheduling when there are lots of very fast particle systems.
Change 3771375 by Hongyi.Yu
Fixed the crash where ability components are unregistered and then re-registered, which usually happens in PIE.
Change 3771368 by Ben.Zeigler
#jira UE-52670 Add project setting bValidateUnloadedSoftActorReferences that is true by default to match current behavior. If you set it to false it will no longer load packages to look for soft actor references when deleting/renaming actors.
Change 3771173 by Seth.Weedin
Auto manage attachment support for AudioComponent- An opt-in feature that allows AudioComponents to cache their AttachParent/AttachSocket and only attach themselves when playing audio, detaching after playback is completed. Set to false by default.
Change 3768811 by Ori.Cohen
Change animation scale collision code so that it uses the physics asset.
Change 3768148 by Brian.Bekich
Fix muting being unable to find remote player controller
Change 3768117 by Ori.Cohen
Prevent pawn collision from updating during animation
Change 3766554 by Gil.Gribb
UE4 - Added a new option to add and remove from static draw lists on demand. This is off by default.
Change 3766427 by Nick.Darnell
Slate - Finally adding Opacity to SWidget. Any widget can now be alpha animated at will, no more need to waste overhead by wrapping things with SBorder or making them userwidgets just to be able to animate a fade.
Change 3761682 by nick.darnell
Athena - Introducing a way to interrupt the request to scroll and item into view. In cases where you're animating, quickly showing and hiding, with the item widgets unavailable for a few frames, you enter cases where the deferred navigation is resolved after you've canceled showing a dialog stealing focus.
Change 3761416 by Ben.Zeigler
#jira UE-52287 Prevent cook metadata like DevelopmentAssetRegistry.bin from being packed into a shipping game, by moving it into a Metadata subdirectory and updating deployment scripts to avoid that directory.
Right now it doesn't package them at all, we could change it to package them as Debug Non-UFS if desired
Change it so the asset audit UI will only load DevelopmentAssetRegistry.bin files, the cooked registry files don't have enough information any more to be useful
Remove ability for runtime game to load DevelopmentAssetRegistry.bin, this ended up not being useful
Change 3750998 by Ethan.Geller
#jira FORT-60191 Allow -audiomixer command line arg to work on all platforms.
Change 3749540 by Marc.Audy
SignificanceManager now takes viewpoints in as TArrayView instead of const TArray&
Change 3748102 by Marc.Audy
Allow cheat cvars to work in Test builds by default
Can be overriden by defining ALLOW_CHEAT_CVARS_IN_TEST as 0 in Target.cs files
Change 3744756 by Bart.Hawthorne
Upgrade Oodle to version 2.5.5. Also, iOS, Android, and Switch platforms have been added. The new dictionary has been generated with old and local captures.
Change 3741168 by Max.Preussner
MediaUtils: Fixed movies not playing properly in Shipping builds
Change 3739256 by Jian.Ru
Set distance field self-shadow bias without recreating all render states
Change 3730756 by Ben.Woodhouse
HISM optimization:
Gil's change to skip trees with only one level of hierarchy (working around badly tuned content issues)
Change vert threshold to 2K.
1-2ms renderthread win without impacting GPU when rendering point lights
Change 3724029 by Zak.Middleton
Increase allowed time for movement substep duration. Don't want to lower between 2 iterations, as this is not used much in practice other than deflection and movement mode changes, and that will change behavior (lose momentum). This new setting will absorb longer hitches in the common case (moving without collision or falling).
Change 3723985 by Marc.Audy
SignificanceManager PostSignificanceUpdate functions can now be executed sequentially on the game thread as well as concurrently in the parallel for (old behavior)
Change 3722910 by Jian.Ru
Amortize shadow cache update caused by resolution change
Changed to use view distance vs. view space z when calculating whole scene shadow resolution which is less sensitive to camera rotation
Change 3718247 by Yenal.Kal
Fixed the bug where the gameplay effect durations can show incorrect values after rejoin or after server time drifting away from the client.
Change 3716343 by Jamie.Dale
Adding Korean and Turkish to the localization automation
Change 3710534 by Uriel.Doyon
Texture streaming optimization where a maximum texture resolution for each level streaming data is computed per view.
This is used to cull irrelevant levels and reduce the async task number of iterations.
The culled size is defined by the new r.Streaming.MinLevelTextureScreenSize.
This requires to remove primitives with big UV density from the level data.
Those primitives get moved to the dynamic lists.
This is controlled by r.Streaming.MaxTextureUVDensity
Change 3707207 by David.Ratti
Remove look ahead-vectors prediction in FNetViewer. This (requires) a line trace which is not desirable or really accurate anymore. This saves us a line trace per connection per multicast rpc.
unify reliable multicast rpc handling: these now do relevancy checks and are not sent to non relevant clients
Change 3706272 by Thomas.Sarkanen
Added utility/math functions to aid in optimizing anim blueprints
Added VectorLengthXY to get the 2D length of a 3D vector. Avoids unecessary conversions.
Added polar->cartesian->polar conversion helper functions for expensive frequently-used anim graph functionality.
Change 3706159 by David.Ratti
PlayerState/ASC replication optimizations from Polge: this puts the net update frequnecy on player state back to 1hz while forcing netupdates on the player state actor when the ability system component needs to update
Change 3692891 by David.Ratti
Optimizations for UNetConnection::ClientHasInitializedLevelFor: build acceleration map of actor outer's (ULevels) -> Visibility bool. Existing logic stays the same.
Change 3691392 by Aaron.McLeran
#jira UE-50628 Fix audio trying to sync load bulk data with EDL enabled
- Fix log error in BulkData.cpp
- Make the first stream chunk be force inline payload in bulk data flags so it loads immediately vs in async IO system
- Make audio stream chunks get as close to 256 k chunks as it can, zero-pad rest to be 256 k aligned
- Fix up DDC key, serialize AudioDataSize separately from chunk DataSize
Change 3682683 by Zak.Middleton
Add bOnlyTickMontageOnDedicatedServer variable to AnimInstance, to avoid anim bp updates on dedicated server. Turn on to fix hitching from queued ServerMove() calls, and some free perf during all montages on the server.
Change 3678771 by Ori.Cohen
Added the ability to turn on stack walk during hitching vs lightweight stats
Change 3676363 by Ori.Cohen
Added the ability to get callstacks as part of hitch detection
Change 3674877 by Keith.Judge
Move definition of GFailedToFindParamCollectionBufferQueue to ShaderBaseClasses.cpp so that all targets can successfully compile.
Change 3672515 by Bob.Tellez
Added code to play wind particle effects
Change 3670909 by Zak.Middleton
Fixed ForcePositionUpdate() not calling CheckJumpInput(). Added "p.NetForceClientServerMoveLossPercent" cvar to simulate loss of client->server movement RPCs (without hosing the rest of networking).
[CL 3791033 by Marc Audy in Main branch]
2017-12-05 21:57:41 -05:00
HandlerComponent : : HandlerComponent ( FName InName )
: Handler ( nullptr )
, State ( Handler : : Component : : State : : UnInitialized )
, MaxOutgoingBits ( 0 )
, bRequiresHandshake ( false )
, bRequiresReliability ( false )
, bActive ( false )
, bInitialized ( false )
, Name ( InName )
{
}
2015-07-08 23:03:46 -04:00
bool HandlerComponent : : IsActive ( ) const
{
return bActive ;
}
void HandlerComponent : : SetActive ( bool Active )
{
bActive = Active ;
}
void HandlerComponent : : SetState ( Handler : : Component : : State InState )
{
State = InState ;
}
void HandlerComponent : : Initialized ( )
{
bInitialized = true ;
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
Handler - > HandlerComponentInitialized ( this ) ;
2015-07-08 23:03:46 -04:00
}
bool HandlerComponent : : IsInitialized ( ) const
{
return bInitialized ;
}
Copying //UE4/Dev-Networking to //UE4/Dev-Main (Source: //UE4/Dev-Networking @ 3495493)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3302759 on 2017/02/14 by John.Pollard
Remove invalid replay samples that can occur due to oversampling (sampling at higher rate than physics is being ticked)
Change 3306072 on 2017/02/16 by John.Barrett
Minor NetcodeUnitTest updates/fixes.
Improved assignment for some types, using FVMReflection - added assignment to enum by name.
Change 3322165 on 2017/02/24 by John.Barrett
Fixed issue where Steam would block unit tests. #JIRA UENET-537
Change 3323917 on 2017/02/27 by John.Barrett
Added better unit test log file management. #JIRA UENET-535
Unit test logs are now stored in subfolders in the game log folder, with one main folder for the current UE4 session, and one subfolder for every unit test run during that session.
Logs are purged occasionally, in line with how the main game logs are purged.
Change 3326307 on 2017/02/28 by John.Pollard
Remove unused cvar
Change 3327907 on 2017/03/01 by John.Barrett
Merged some old NetcodeUnitTest debug features:
- Added command for bit-based log dumping of data (for debugging bit-based netcode)
- Added exported function, for allowing access to console commands, in modules which don't import Engine
Change 3332710 on 2017/03/05 by John.Barrett
Updated unit test flags to expect a disconnect when expecting a server crash.
Change 3332715 on 2017/03/05 by John.Barrett
Wrapped all CreateChannelBunch pointers with a nullptr check (used to not be required).
Replaced old/duplicate unit test code (using CreateChannelBunch) for marking 'exploit failure', with the current centralized function calls.
#JIRA UENET-539
Change 3336258 on 2017/03/07 by John.Pollard
Add more info to history overflow logging
Change 3336259 on 2017/03/07 by John.Pollard
Don't pause replication for replay connections
Change 3341288 on 2017/03/10 by John.Barrett
Fixed invalid access to GLog during game shutdown. #JIRA UE-42394
Change 3341736 on 2017/03/10 by John.Pollard
Get reliability packet handler working again (but still disabled by default)
Change 3349298 on 2017/03/16 by John.Barrett
Fixed issues/potential-issues with the timing of global variable destruction, based on Graeme Thornton's fix. #JIRA UE-42394
Change 3349393 on 2017/03/16 by John.Pollard
Reliability handler cleanup
Change 3350029 on 2017/03/16 by John.Barrett
Updated PacketHandler to support an optional handshaking stage for HandlerComponents, where each handshake must execute sequentially starting at the component closest to the socket.
Change 3350030 on 2017/03/16 by John.Barrett
Updated Asymetric Encryption to support updated PacketHandler system, to perform a key handshake that is compatible with other HandlerComponent's, and fixed some serialization security issues by setting proper limits on values.
Change 3350032 on 2017/03/16 by John.Barrett
Minor corrections to variable types and constructor initializer lists, for the rest of the encryption code.
Change 3355536 on 2017/03/20 by John.Barrett
Added new PacketAudit debug feature, which uses inter-process-communication, to audit the integrity of incoming/outgoing packets at various stages of serialization, between a client and server.
This is critically useful for low level netcode development, particularly with the PacketHandler.
See PacketAudit.h for more information.
Change 3355570 on 2017/03/20 by John.Barrett
Added a small number packet auditing checks to key areas of low level netcode.
Change 3355584 on 2017/03/20 by John.Barrett
Updated ReliabilityHandlerComponent, to support packet reliability during the PacketHandler handshaking stage, and fixed ReliabilityHandlerComponent serializing based on a packets byte size, rather than bit size.
Change 3373389 on 2017/03/30 by John.Barrett
Added check for HandlerComponent's that require reliability.
Change 3373390 on 2017/03/30 by John.Barrett
Added TLS-like encryption handler component, which exchanges a secret key using asymmetric encryption (RSA), and implements symmetric encryption using that key (AES).
Based on RSA encryption component, and John Pollard's AES changes.
Enable in *Engine.ini, using:
[PacketHandlerComponents]
Components=RSAKeyAESEncryption
bEnableReliability=true
Change 3394518 on 2017/04/14 by Ryan.Gerleve
Fix memory leak in FRepChangelistState: added destructor that properly destroys the properties in the shadow state buffer.
Change 3432955 on 2017/05/10 by John.Barrett
Randomized the initial packet sequence numbers for UNetConnection's and for reliable packets - using the stateless handshake cookie.
Also added hooks to determine when PacketHandler level handshaking has completed, so that the initial connection packets can be delayed until this stage (required now, in order to exchange the sequence numbers first).
Change 3464528 on 2017/05/29 by John.Barrett
Fixed connection failure during unreliable network conditions, caused by a bad interaction between the stateless handshake and sequence initialization code.
Added a new 'ack' stage to the stateless handshake, to ensure the client/server sequence is properly synchronised.
Expanded the timeout/retry handling for the stateless handshake, so it is more robust, and fixed some bugs in this code.
Change 3464537 on 2017/05/29 by John.Barrett
Fixed an incompatibility between the asymmetric encryption, and the new PacketHandler handshake code.
Change 3464543 on 2017/05/29 by John.Barrett
Updated CryptoPP to 5.6.5.
Change 3467529 on 2017/05/31 by Jon.Nabozny
Add comments to FPacketSimulationSettings vars.
Change 3469584 on 2017/06/01 by Ryan.Gerleve
Log bunch ChSequence on reliable channel open along with other info.
Change 3471329 on 2017/06/02 by John.Barrett
Fixed PacketHandlerLog type not being exported.
Change 3471875 on 2017/06/02 by John.Barrett
Fixed code that was trying to send NetConnection packets from the server to the client, too early - and tidied up related checks.
#JIRA UE-45637
Change 3473030 on 2017/06/04 by John.Barrett
Fixed replay incomaptibility with recent sequence/handshake changes.
Change 3476313 on 2017/06/06 by Ryan.Gerleve
Add initial reliable sequence numbers to the log in UNetConnection::InitSequence.
Change 3478649 on 2017/06/07 by Ryan.Gerleve
Add additional logging for the case where a channel open command is received by a channel that's already opened locally.
Change 3482926 on 2017/06/09 by John.Barrett
First pass at Minimal Client refactor for NetcodeUnitTest - split basic/minimal client code out of ClientUnitTest, into its own class - while preserving existing ClientUnitTest interface.
This will allow multiple minimal clients per unit test, where only one could be used before (necessary for games that require a beacon + game connection).
Added reflection support for weak UObject properties.
Added MCP requirements flag for unit tests.
Process pipe reading tweaks, to avoid UI freezes.
Change 3485179 on 2017/06/12 by Ryan.Gerleve
Add backwards-compatibility macros for random initial packet sequence changes so that game plugins can check them.
Change 3489040 on 2017/06/14 by John.Barrett
Removed OnlineSubsystem dependencies.
[CL 3495525 by Ryan Gerleve in Main branch]
2017-06-16 14:10:35 -04:00
/**
* FPacketHandlerComponentModuleInterface
*/
void FPacketHandlerComponentModuleInterface : : StartupModule ( )
{
FPacketAudit : : Init ( ) ;
}
void FPacketHandlerComponentModuleInterface : : ShutdownModule ( )
{
FPacketAudit : : Destruct ( ) ;
2020-12-11 14:21:20 -04:00
}