Files
UnrealEngineUWP/Engine/Source/Runtime/Messaging/Private/Bus/MessageRouter.cpp

458 lines
12 KiB
C++
Raw Normal View History

// Copyright Epic Games, Inc. All Rights Reserved.
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "Bus/MessageRouter.h"
#include "IMessagingModule.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "HAL/PlatformProcess.h"
#include "Bus/MessageDispatchTask.h"
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
#include "IMessageBus.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "IMessageSubscription.h"
#include "IMessageReceiver.h"
#include "IMessageInterceptor.h"
#include "IMessageBusListener.h"
#include "Misc/ConfigCacheIni.h"
/* FMessageRouter structors
*****************************************************************************/
FMessageRouter::FMessageRouter()
: DelayedMessagesSequence(0)
, Stopping(false)
, Tracer(MakeShared<FMessageTracer, ESPMode::ThreadSafe>())
, bAllowDelayedMessaging(false)
{
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
ActiveSubscriptions.FindOrAdd(IMessageBus::PATHNAME_All);
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 4044339) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3947021 by Max.Chen Sequencer: Don't preserve root component when copying object properties. A spawnable empty actor, has a root component that is generated by the empty actor factory. If the object template's root component is preserved when copying from the spawnable empty actor, the root component will not be copied over. Therefore, we need to NOT preserve the root component when copying object properties. #jira UE-55825 Change 3947366 by Max.Preussner WmfMedia: Better log output Change 3947367 by Max.Preussner MfMedia: Better detection of compressed format properties on Windows Change 3949102 by Max.Chen Sequencer: Remove SequenceActorTag when converting to possessable. #jira UE-56206 Change 3949207 by andrew.porter EngineTest: Set the screenshot nodes resolution to 1280x720 Change 3949404 by Max.Chen Sequencer: More informative tooltip for "Rerun Construction Scripts" option. It now says "Rerun construction scripts every frame on actors that have 'Rerun Construction Script in Sequencer' enabled in their class settings". Change 3950067 by Matt.Hoffman Renamed UAutomatedLevelSequenceCapture's StartFrame and EndFrame to CustomStartFrame/CustomEndFrame to reflect that it is user-overriden. This will also resolve upgrade issues due to the variable datatype changing. #jira UE-56189 Change 3950193 by JohnHenry.Carawon Updating my latest MovieRendering test content. Change 3950757 by JohnHenry.Carawon More updates to MovieRendering test content Change 3952059 by Max.Chen Resave LevelVisibility_SubLevels to fix data loss conversion warning of OpacityMaskConstant #jira UE-56086 Change 3952283 by Max.Chen Sequencer: Disable dropping level sequence assets as spawnables. #jira UE-56120 Change 3952422 by Max.Chen Sequence Recorder: Add button to record from the current player. #jira UE-55942 Change 3952987 by JohnHenry.Carawon MovieRendering Test Content - Fixing camera bindings and changing the override binding actor Change 3953823 by Mike.Zyracki Fix for Bad FBX Import Tangents not scaled by frame rate. After looking at this again it seems that a set of MovieScene:: overiddes for the channel traits wasn't set correctly, so use the ADL idiom to use MovieScene, which can then call Optimize in the correct namespace. With this we can now correctly use the passed in tolerance. There was also a redundant set of Optimize calls so that it could happen twice so removed them, and needed an extra check in the float channel Optimize. Also since we need to set auto tangents no matter if we optimize we don't set that parameter(though leave it since it's used by context menu key reduction). Finally fixed speed issue with trajectories caused by calculating way too many substeps. Reverted back to a time based step size for consistency. #jira UE-56193 Change 3954317 by Matt.Hoffman Adding a key to the last frame of a section no longer causes a crash. Keys can already be moved to be on the last frame of a section so now you can just add a key there directly. #jira UE-56255 Change 3954326 by Matt.Hoffman Dilating a section that is only infinite on one side no longer causes a crash. #jira UE-56260 Change 3954486 by Max.Chen PR #4580: Exposes IsReversed() from UMovieSceneSequencePlayer (Contributed by alanedwardes) Change 3955238 by Max.Preussner Messaging: Enabled delayed message routing https://github.com/EpicGames/UnrealEngine/pull/4574 #jira UE-56247 Change 3955901 by Max.Preussner MediaFrameworkTest: Added developer test for overriding desired media player plug-in at runtime. Change 3955922 by Andrew.Porter QAGame: Updating movie rendering content in dev folder Change 3956004 by andrew.porter QAGame: Adding MPC track to movie rendering test content Change 3956510 by Max.Chen Sequencer: Fix fbx camera import of static properties so that they are imported before default tracks are created. Otherwise, the default tracks inherit the default properties of the camera, rather than the values from the fbx. #jira UE-56311 Change 3957613 by Max.Preussner MediaUtils: Added code documentation to media player facade Change 3958005 by Max.Preussner MediaUtils: Added method to get number of sinks Change 3958934 by Max.Chen Sequencer: Fix keys getting added and sequence getting erroneously re-evaluated when auto key is off. Only apply defaults if there are no keys. Only modify the movie scene section before creating keys or setting defaults. #jira UE-55903 Change 3959687 by Andrew.Rodham Sequencer: Fixed visibility track external values being inverted #jira UE-56324 Change 3960507 by Max.Preussner Core: Fixed incorrect rounding in FMath::DivideAndRoundNearest Change 3962047 by JohnHenry.Carawon MovieRendering Test Content Changes: - Add Lightmass Importance Volumes to sublevel to fix warnings - Rebuilt Lighting - Add a third sequence for Gamut testing - Resaved the sound master.uasset to fix warning Change 3962211 by Mike.Zyracki Add Frame Numbers to selected animation sections. Added MapTimeToAnimation to MovieSceneSkeletalAnimation so that we could get it from the Skeleton Animation track Editor. Since the thickness of the frame line can change based upon frame rate and zoom we need to calculate it similarly to how the time slider controller does it. Those calculations were private so we had to expose FScrubRangeToScreen and GetScubberPixelRange from the TimeSliderController. Also needed to know if the section itself was selected so added a bIsSelected flag to the section Painter. Also fixed a bug where you couldn't add a section if other sections existed at different times in MovieScenePropertyTrack and could crash due to the check(). #jira UESEQ-395 Change 3962497 by Max.Preussner Core: Added new string formatting argument to FTimespan Change 3963662 by Max.Chen CineCamera: Flip VistaVision width and height. Change 3963731 by Max.Preussner MediaCompositing: Implemented sequence recording support for media track Change 3964195 by Andrew.Rodham Sequencer: Set inverted property correctly for newly created visibility track sections - Also clamp evaluation for key editors to the bounds of the section so we're not displaying values outside of the section bounds when the cursor is not on the bounds #jira UE-56324 #coderevew Max.Chen Change 3964196 by Andrew.Rodham Sequencer: Fixed crash when attempting to render sections that resulted in a negative intersection with the view range Change 3964275 by Andrew.Rodham Sequencer: Fixed MovieScene::ClampToDiscreteRange for infinite range bounds Change 3964364 by Andrew.Rodham Curve Editor: Reduce minimum vertical view range when zooming to fit Change 3965091 by Max.Chen Sequencer Recorder: Refresh next sequence if empty when starting a recording, otherwise, use existing name. #jira UE-56469 Change 3965148 by Max.Chen Sequence Recorder: Move Record to Possessable to "Actor Recording" group Change 3965162 by Max.Chen Sequence Recorder: Always break out of immersive mode when done recording, even when stopping recording during countdown. #jira UE-56407 Change 3965214 by Max.Preussner QAGame: Enabled ImagePlate plug-in Change 3965574 by Max.Preussner SimpleComposure: Reorganized & upgraded content to work with new Media Track #jira UE-56488 Change 3965651 by Max.Preussner MediaCompositing: Ignoring seek-on-open if media not seekable Change 3966075 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Export functionality #jira UESEQ-358 Change 3966087 by Matt.Hoffman Adding a single key to the Particle Toggle track now makes an infinite range section that is displayed in the UI. #jira UE-56295 Change 3966547 by Andrew.Rodham Sequencer: Fixed rounding errors when drawing the section background on boolean sections - Logic was using time in sectonds which caused rounding errors on evaluation and flickering red/green stripes when dragging keys around #jira UE-56324 Change 3966563 by Andrew.Rodham Curve Editor: Key editor interface improvements - SKeyEditInterface has a few problems - it does not update in real time when editing properties, and does not support multi-edit which makes it unsuitable for use with the curve editor - We now take a different approach for editing keys by gathering a set of proxy UObjects for each key that is currently selected. These objects are added as top level objects to the details panel which means they support multi edit as you'd expect from any other details panel in the editor. - Proxy objects are updated every tick for the curve editor if they implement the ICurveEditorKeyProxy interface, which allows them to refresh their current value. - Ideally, the same mechanisms would be used in the main sequence interface, and we would be generating the proxy classes at runtime based on the key value type, but that work remains a separate task from this initial offering. #jira UE-56165 Change 3966564 by Andrew.Rodham Curve Editor: Expand to frame when adding or moving keys in the curve editor Change 3967051 by andrew.porter MediaFrameworkTest: Set the CameraPlayer_Video texture to auto clear Change 3967141 by Andrew.Rodham Sequencer: Keep track of spawned objects that have been modified and only re-save such object's default spawnable state on destruction - Now that we're taking this approach, I've remove serveral redundant bits of functionality in the spawn register such as making some spawnables read-only, and the PreSave binding for Sequencer. - We now hook into all object pre-saves to make sure we handle the case where the sequences are saved through the content browser or elsewhere. #jira UE-47686 Change 3967170 by Andrew.Rodham Sequencer: Added the ability to possess anim instances as object bindings - This allows full and direct animation of properties on UAnimInstance, and animation blueprints - Object Bindings are made by first possessing a skeletal mesh component, then choosing the + Add button where its anim instance will be listed - Added a new function to UMovieSceneSequence to gather previously cached objects that should now be invalidated. Anim instances will be re-resolved if a new UAnimInstance is assigned to USkeletalMeshComponent::GetAnimInstance. - ObjectBindingIDs for anim instances are just represented by an entry in a set of GUIDs. We only ever resolve such bindings through USkeletalMeshComponent::GetAnimInstance. - Only currently supported on LevelSequences #jira UE-56132 Change 3967195 by Max.Preussner Core: Updated TRangeSet to use TCallTraits Change 3967345 by JohnHenry.Carawon Test Content Changes - first iteration of spacing out the examples in the shots. Change 3967572 by Max.Chen Sequencer: Fix setting PreviousPlayEvalPosition until after we've tested whether it's set. #jira UE-56518 Change 3967750 by Max.Chen Audio: Set duration based on number of input channels, rather than number of channels to serialize. This fixes an issue where audio split into 2 channels is set to a duration that's twice as long. #jira UE-56430 Change 3967836 by Max.Chen Sequencer: Allow for animating array elements within ustruct properties #jira UE-55887 Change 3968506 by Matt.Hoffman Fixed ambiguous conversions for seconds and frames being overriden by ambiguous conversion to Timecode (in frames). Change 3968748 by Max.Chen Sequencer: Make the event properties submenu widget larger. #jira UE-55557 Change 3968862 by Max.Chen Sequencer: Recursive expansion when shift is down #jira UE-52139 #pr 4194 Change 3968863 by Max.Chen Sequencer: Bind rename command to selected track so that F2 shortcut start renaming #jira UE-52139 #pr 4194 Change 3968872 by Max.Chen Sequencer: Rekey the selected key at the current time. #jira UESEQ-396 Change 3968938 by Max.Chen Cine Camera: Add option to toggle the behavior of locking the rail mount to the orientation of the spline. By default, the option is off, no change in behavior. #jira UE-55815 Change 3968958 by Andrew.Rodham Sequencer: Consider vertical position when hittesting keys #jira UE-56256 Change 3969643 by Max.Preussner Core: Rounding timespans created from double values towards nearest ticks Change 3969646 by Max.Preussner MediaUtils: Implemented timeout mechanism for block-on-fetch feature Change 3969776 by Mike.Zyracki Added Skip Anim Notifiers Toggle per what was in Matinee. Investigated the Enable Root Motion toggle as also discussed but it's implementation is directly contained by the animation asset and unlike animation notifies there seems to be no exposure to interactively disable it during a playback tick. Note if we are generating thumbnails we still automtically disable notifies in the editor to avoid annoying noise playback. Note that if Enable Root Motion/Root locked is specified in the animation asset it does correctly effect the Sequencer. #jira UESEQ-399 Change 3969835 by Matt.Hoffman Playback Range and Selection Range use unified logic for adding themselves as potential snap locations which properly handles inclusive/exclusive bounds. This resolves an issue where having an unset selection range caused a potential snap location to be added on frame 0 and 1 (internal resolution) which caused a misalignment when placing objects near frame 0. This also removes the one frame offset on setting Selection Range to bring behavior inline with other ranges. #jira UE-55420 Change 3969885 by Max.Preussner MediaAssets: Don't register media player CDO with media ticker Change 3971129 by Andrew.Rodham Sequencer: Fixed UMovieSceneSequencePlayer::GotToEndAndStop() not taking into account for start time This is a remnant from when the times were always specified in 0-duration space, rather than actual sequence times. Change 3972056 by JohnHenry.Carawon More updates to Test Content. I continued spacing out the examples in the sequence so that they have a consistent number of frames between each example and during the start/end of the example. Also removed the Marcie sublevel. Change 3972066 by Andrew.Porter MediaFrameworkTest: Setting Marcie folder to be never cooked in package settings Change 3972675 by Matt.Hoffman Splitting Subsequence Sections no longer sets an incorrect playback range on the subsequence when the subsequence has a different internal resolution than the owning sequence. #jira UE-55453 Change 3973376 by Max.Preussner ImgMedia: Zero is the only valid video track for image sequences Change 3973489 by Max.Preussner Launch: Build rules cleanup pass - don't use Media, MediaUtils on server apps - don't link against Media (include-only dependency) - don't include from MediaAssets (dynamic load only) Change 3973760 by Max.Preussner MediaUtils: Moved AppMediaTimeSource implementation into its own file; added logging Change 3973765 by Max.Preussner ImgMedia: Disallowing seek beyond media length Change 3973855 by Max.Preussner MediaFrameworkTest: Updated developer test content Change 3973858 by Max.Preussner MediaCompositing: Blocking on media player time instead of media sample time (the former may not be hit in the current frame) Change 3974988 by Max.Chen Sequencer: Fix trim left so that it also sets the start offset for audio and skeletal animation sections. #jira UE-57015 Change 3976101 by Matt.Hoffman Sequencer will now focus the scroll view on newly created items. #jira UE-56492 Change 3976203 by Max.Chen Property Editor: Add DetailsViewArgs for ColumnWidth. Defaults to 0.65f, no change in existing behavior. Change 3976205 by Max.Chen Sequencer: Set better column widths for sequencer. #jira UE-55557 Change 3976206 by Max.Chen Sequencer: Added menu category for import/export Change 3976265 by Matt.Hoffman Tracks within Object Binding Nodes will now sort using the old behavior so that components are added above other track types. #jira UE-56473 Change 3976901 by Max.Chen Sequencer: Add event names to event track section #jira UESEQ-353 Change 3977878 by Max.Preussner Media: Moved media framework ticking stats into Media module Change 3977982 by Max.Chen Sequencer: Add Edit->Reset section length to duration of source (ie. audio, skeletal animation, shot length) Added MovieSceneSection::GetDefaultDuration and MovieScene::HasDefaultDuration #jira UESEQ-392 Change 3977994 by Max.Preussner Media: Fetching and rendering media samples before viewports are rendered (to ensure frame sync for in-level media playback) #jira UE-53975 Change 3978188 by Matt.Hoffman Easing Curves are now clipped by the sequence's PlayRange when testing against an infinite section. This causes blended sequences to finish their blend when the section starts/ends instead of always using 25% of the total section length to determine default blend range. #jira UE-56362 Change 3978676 by Max.Preussner MediaCompositing: Fixed first frame of rendered out media track missing #jira UE-53975 Change 3978684 by Max.Preussner MediaCompositing: Enabled media track frame sync feature #jira UE-53975 Change 3980026 by Matt.Hoffman Keys can be selected on folded out sections (such as an audio track expanded to show volume and pitch) again. #jira UE-57169 Change 3981614 by Max.Preussner MediaUtils: Added missing subtitle sample queue flush Change 3982311 by Max.Preussner MediaCompositing: Added safeguard for zero length media sources Change 3982389 by andrew.porter QAGame: Adding media track test content into FrameAccuracySubscene Change 3983661 by Max.Chen Sequencer: Add level name to spawn a spawnable into. Add sublevel menu option to set the level #jira UESEQ-390 Change 3983712 by Andrew.Rodham Sequencer: Purge legacy blueprint spawnables from LevelSequence packages #tests Ran a preflight for cooking fortnite, ocean and Orion. Only orion shows up this edge case, and will require a re-save of the EndCines level #jira UE-39173 Change 3983787 by Max.Preussner MediaCompositing: Moved compile time switch for block-on-fetch into media player facade Change 3983812 by Andrew.Rodham Sequencer: Exposed default level sequence instance data to blueprints Change 3984373 by Max.Preussner Media: Added API for quering whether player plug-in supports block on fetch Block on fetch allows Sequencer and other systems to block the game thread until a desired video frame has been decoded. Change 3984670 by JohnHenry.Carawon Movie Rendering Test Content progress. Saving the state of the content. There is a bug where things got replaced with particle emitters and I think it was because I tried to copy paste an animation track into a separate skeletal mesh track. Change 3985097 by Max.Chen Sequencer: Rename Reset to AutoSize Change GetAutoSizeDuration to return TOptional<FFrameTime> #jira UESEQ-392 Change 3986043 by Max.Chen Sequencer: Fix crash when attach/path duration is less than 0. #jira UE-57310 Change 3986373 by Max.Chen Sequencer: Add support for deleting tracks and channels which equates to setting the channel mask. #jira UE-52951 Change 3986375 by Max.Chen Sequencer: Add Create Pose Asset to skeletal animation section. This allows animators to blend animations in sequencer and create new pose assets from them. #jira UESEQ-408 Change 3986796 by Andrew.Rodham Sequencer: Fixed stale object references remaining in ULevelSequence::BindingReferences when using convert to spawnable/possessable - We used to convert objects by creating a new binding, then re-assigning its GUID, which meant we didn't have to do any further object fixup, but the code to achieve this was confusing and led to a vulnerability where object references would not be cleaned up correctly due to the newly created possessable essentially being a temporary object that's immediately thrown away. - To address this, there is now a function for porting all the contents of one object binding to another, and handles the correct fixup required for parent/child object bindings for both spawnables and possessables. - Also added codepath to remove any stale object references from the level sequence reference map on PostLoad (this piggy-backs off the PurgeLegacyBlueprints object version which is close close enough to this change to be identical) #tests Verified that existing sequences with stale references get cleaned up on load. Verified that repreatedly converting from spawnable<->possessable cleans up references correctly. Change 3987807 by JohnHenry.Carawon Updates to the MovieRendering Test Content. - Fixed the spawnable actors that were overwritten - Shortend the Lighting example and combined the Intensity and Color tracks - Organized the Sequence and WorldOutliner to group the examples. Change 3988151 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. Change 3988880 by Max.Chen Sequencer: Support enter to add asset for all sequencer track editors that have asset pickers. #jira UE-57367 Change 3988953 by Max.Chen Sequencer: Make the track color picker focusable so that it will close when you click away or lose focus. #jira UE-57210 Change 3988962 by Max.Chen MovieSceneCapture: Fix EDL export so that it takes into account movie scene frame resolution and desired frame rate. #jira UE-57365 Change 3988964 by Max.Chen Movie Scene Capture: Clarified tooltip for bRelativeFrameNumbers. If you specify custom start/end frames for the recording, they will be relative to the playback range. #jira UE-57308 Change 3989442 by Max.Chen Fix CIS Change 3991548 by Matt.Hoffman Dragging the time slider no longer causes the time slider to ignore snap-to-interval with "Snap to Keys While Scrubbing" when no keys are in range. #jira UE-57417 Change 3991598 by Matt.Hoffman Snap to Key while scrubbing now mirrors the behavior of "jump to next key". When there are no tracks selected it snaps to all keys and when there are tracks selected it snaps to only keys from that track. This also resolves an issue where deleting an object did not remove it from the Sequencer's selection. Undoing a delete already doesn't seem to restore your selection, so removing it from your selection shouldn't change that behavior. #jira UE-57417 Change 3991603 by Max.Chen Sequencer: Disable EditAnywhere for some section properties #jira UE-53530 Change 3992240 by Max.Preussner MediaAssets: Implemented dynamic audio sample rate adjustment based on audio/media clock drift #jira FORT-70638 Change 3992911 by Andrew.Rodham Sequencer: Fixed saving spawnable state using the wrong spawned object - We now track the object binding ID so that we can apply the spawned object to the correct spawnable when the asset is saved #jira UE-57353 Change 3992914 by Max.Chen Movie Scene Capture: Fix compression quality not being set. The compression interface wasn't being found through query interface, so no compression was being set. Reworked finding it through the output pins. Tested running various compression values. #jira-UE-55488 Change 3992919 by Max.Chen Sequencer: Convert to possessable now uses object template instead of copying properties (ie. see LevelSequenceActorSpawner). This fixes MIDs getting lost when converting to spawnable and back to possessable. #jira UE-52400 Change 3993184 by Max.Chen Sequencer: Don't show +Transform/+Path/+Attach track if the actor has the "Mobility" property hidden. Set the Landscape, LandscapeProxy and InstancedFoliage "Mobility" property to be hidden since it is static is not supposed to be dynamically movable. #jira UE-56347 Change 3993238 by Max.Chen Sequencer: Test for hidden mobility in creating keys as well. Refactored to HasHiddenMobility() #jira UE-56347 Change 3993978 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. #jira UE-57489 Change 3994039 by Max.Chen Landscape: Add Mobility to hidecategories on landscape component #jira UE-56347 Change 3994626 by JohnHenry.Carawon Updated Movie Rendering Test Content. - Fixed the overridden spawnables to their proper object types. Change 3994653 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Import functionality, improved Export functionality #jira UESEQ-358 Change 3995609 by Max.Chen UMG: Add support for 2d transform mask (translation, rotation, scale, shear) #jira UE-52951 Change 3995778 by JohnHenry.Carawon Movie Rendering Test Content Updates - Adjusted Lights example - Adjusted Camera example - Added Marcie sublevel back in Change 3995942 by JohnHenry.Carawon QAGame: Moving Movie Rendering test content from Developer folder to Sequencer folder Also adjusted level visibility, lights and camera example. Change 3995993 by Christina.TempelaarL Sequencer: FCPXML Export updates - only export sections if in playback range and media exists, warn if media does not exist. Other updates - removed unused methods and variables, fixed message context naming to be more accurate #jira UESEQ-358 Change 3996595 by andrew.porter QAGame: Updating Marcie content in TrackEvaluation level to use Image Plate Change 3996614 by andrew.porter QAGame: Adding color test sequence to the sublevel Change 3996643 by Max.Chen Sequencer: Fix fbx animation export - rotation and scale channels were flipped. #jira UE-57509 #jira UE-57512 #jira UE-57514 Change 3996652 by Max.Preussner Messaging: Fixed delayed messaging using incorrect current time after message router sleep Based on https://github.com/EpicGames/UnrealEngine/pull/4601 Change 3996801 by Max.Chen Sequencer: Fix folder active state for non key area sections. Look at track node sections as well as key areas. #jira UE-57550 Change 3997098 by Matt.Hoffman Cleaned up some remaining ToDo's in STimeRange. Change 3998339 by Max.Preussner Sockets: Added documentation for socket receive functions Change 3998359 by Max.Preussner MediaUtils: Started to implement media recorder helper class Currently only supports BGRA frames in CPU memory. Supporting other formats and buffer types will require conversions on render-thread. I recommend refactoring out the existing conversion code in FMediaTextureResource into a reusable helper class in the MediaUtils module. This should be a good starting point though. Change 3998417 by Matt.Hoffman Keys and Sections can now be moved at the same time inside of Sequencer. Keys can now snap to Sections (and vice versa) instead of just to other Keys. Sections can now be duplicated like keys can. #jira UE-56995 Change 3998427 by JohnHenry.Carawon QAGame: Updating test content for the Movie Rendering feature. - Added an auto activate particle to the beginning of the sequence (it's not part of the sequence at all) - Added an event receiver blueprint to the Events example - Added a particle emitter to both sublevels - Added a camera cut to the end that switches to a separate camera - The camera zoom in, focus and Look At sections are all separate (not overlapping in the sequence) - Added a second actor for the camera Look At - Added a Visibility section for the Actor Hidden In Game track that has possessable and spawnable cube and light Change 3998537 by Max.Chen Sequence Recorder: Restore immersive mode when stopping the sequence even if not in PIE. #jira UE-56407 Change 3999809 by Matt.Hoffman Removed the "Go To" box from Sequencer and instead placed the current time as an always visible control. The previous shortcut (Ctrl + G) now focuses the new widget directly. #jira UESEQ-376 Change 4000543 by Christina.TempelaarL Sequencer: Moving editor-only code from runtime module MovieSceneCapture to editor module MovieSceneTools. Moved EDL and FCP XML exporters as well as Automated Level Scene Capture. #jira UESEQ-358 Change 4000706 by Matt.Hoffman Entering multiple time strings without a number no longer crashes Sequencer. #jira UE-57672 Change 4001051 by andrew.porter MediaFrameworkTest: Fixing up some image sources pointing to the wrong location Change 4001191 by andrew.porter QAGame: Adding some quick EDL/XML test content to dev folder Change 4001243 by Max.Chen Sequencer: Fix import EDL out of range. #jira UE-57665 Change 4001856 by Matt.Hoffman Selecting keys and sections at the same time now also works with animation and audio sections. #jira UE-57716 Change 4002021 by Max.Chen Sequence Recorder: Fix sequence name incrementing. If external recording sets the sequence name, use it. Otherwise, use the recording name from the recording group or the recording settings. #jira UE-57712 Change 4002618 by Max.Chen Viewport: Update the look at location when updating to a locked actor. This fixes an issue so that popping the view out of a locked actor and manipulating the view will not jump to the previous look at location. #jira UE-57725 Change 4002979 by Matt.Hoffman Fixes several edge cases with the end time range that was causing confusion about what the last frame of the sequence was. Dragging the End Frame slider will no longer be off by one tick and jumping to the end via the UI controls now properly respects snapping and stays inside the play range instead of falling outside of it. Overall behavior does not change though and End Frame should be considered an exclusive frame so that frames 0-150 results in a 150 frame long animation (which is frames 0-149). #jira UE-56367 Change 4003185 by Matt.Hoffman Fixed a regression that prevented a section from being dragged upwards past row 0 which normally resulted in all other rows moving down. #jira UE-57717 Change 4003193 by JohnHenry.Carawon QAGame: Updates to test content - Shortened frames between the examples from 95 to 30 - Separated camera setting tracks - Lighting example now switches directly from constant red - green - blue Change 4003369 by Max.Chen Sequence Recorder: Refresh next sequence regardless of internally stored sequence name. #jira UE-55757 Change 4003586 by JohnHenry.Carawon QAGame: Test Content Updates - Level Visibility track now ends to that the levels are not visible when we move to the next example - Shortened camera section, removed Z tranform so that we just move left to right and shortened the overall length Change 4004414 by Max.Chen Movie Scene Capture: Fix regression where rendering with shot handles would only render the first shot. 3972166 addressed an issue where an extra frame would be rendered by finalizing right when the end frame was reached. This was hit on the first shot end frame, so instead, do this only for when the last shot is being rendered. #jira UE-57314 Change 4004765 by Christina.TempelaarL Sequencer: Fixed bugs in FCP XML import/export. - Export: fixed sequence default resolution. - Export: fixed XML files with no shots. - Export: all sections clipped to playback range. - Export: fixed incorrect section start/end times due to precision issues. - Import: fixed incorrectly adding cinematic tracks. - Import: fixed bugs creating new sections. #jira UE-57660 #jira UE-57662 #jira UE-57655 #jira UE-57761 Change 4005119 by Max.Chen Sequencer: Export/import at play rate Change 4005195 by Max.Chen UMG: Finish UMG evaluation on stop. Added object version so that existing UMG assets do not change. #tests - Newly created UMG animation with sections set to restore state now return to their original state. Existing UMG animations with sections set to restore state do not return to their original state. #jira UE-52285 Change 4005377 by Michael.Karambelas QAGame: Moving TM-SequenceRecorder and related content out of my developer folder and into /Content/Sequencer/SequencerRecorder/* Change 4005417 by Michael.Karambelas QAGame: Fixed a BP compiler in the Level Blueprint of TM-SequencerRecorder. Change 4005634 by Michael.Karambelas QAGame: Fix up missing content and broken level sequence in TM-SequenceRecorder after move Change 4006324 by Max.Chen Sequencer: Reset if the focused movie scene is null. This fixes a crash if the user is focused in on a shot and undo takes the user past the point of where the shot was created. #jira UE-57752 #jira UE-47661 Change 4007006 by Max.Chen Sequencer: Fix FindAvailableRowIndex so that it returns the max row index (and not +1) since it doesn't find any conflicting rows. #jira UE-57717 Change 4007907 by Max.Chen Sequencer: Fix crash if there's no animation Change 4007948 by andrew.porter QAGame: added test content to dev folder for Record World Space Change 4008636 by Max.Chen Sequencer: Fix import fbx not setting values properly and creating additional cameras unncessarily. #jira UE-57864 Change 4008759 by Max.Chen Sequencer: Follow up fix for import cameras #jira UE-57864 Change 4009994 by Matt.Hoffman Dragging the left or right handles of the Time Range slider in Sequencer will now zoom your view in on the current center of the screen. This prevents the view from being translating as you tried to zoom in which caused issues at high zoom levels. #jira UESEQ-407 Change 4010169 by Christina.TempelaarL Sequencer: FCP XML fixes. - FCP XML export - no longer clips to playback range - FCP XML and EDL export - fixed missing last frame of some sections after exporting to Premiere. - Automated level capture, EDL export - use RoundToFrame instead of FloorToFrame for computing section start/end frames after frame rate conversion. #jira UE-57802 - partial fix, movie scene capture still needs to render full section rather than clip against playback. Change 4010287 by Mike.Zyracki Add quaternion interpolation option to UMovieScene3DTransformSection. This mimics how Matinee used to work by bascially finding the keys between a time and interpolating the angles as quat's between them. As noted in the code the algorithm needs to handle the case when the x,y,z Rotation keys all aren't at the same time which was not handled by Matinee. Also like Matinee, when in quaternion interoplation mode, we need to not display the function cuves since the interpolated and key values are now all different. (Would like to show them but that's a bigger refactor for perhaps just a one off needed by quaternions). I added a virtual function UMovieSceneSection::ShowCurveForChannel for this since it needs to be dynamic, not on construction of IKeyArea's, and could be useful for other sections. I could though move the method to just UMovieScene3DTransformSection and do a cast instead. Looked into doing a unit test for this but after talking with Andrew P we will work on doign an automated test in EngineQA since that will provide more coverage. Will also add a video the jira. #jira UESEQ-403 Change 4010713 by Mike.Zyracki Added option to key a group of transform channels instead of just the changed channel, or all of them. This is useful for quaternion interpolations where you want rotation keys to be aligned but also useful for other workflows like animating FK Pose to Pose. Change 4010715 by Andrew.Porter MediaFrameworkTest: Setting LogMediaUtils logging from VeryVerbose to Verbose to cut back on the spam Change 4013048 by Max.Chen Sequencer: Fix play/jump status. Update the player status for all position methods (Scrub, Jump, Play). Jump means Stopped. Correctly use PlayTo or JumpTo based on position method. In PlayInternal, JumpTo with the Stopped state (rather than playing state). #jira UE-57844 Change 4013479 by andrew.porter QAGame: Added content in TM-SequenceRecorder to test recording a property on a Cine Camera Component; Press 3 to trigger manual focus distance to increment on a timer Change 4014323 by Max.Chen Sequencer: Fix SetPlaybackPosition so that it jumps or plays based on playback status. #jira UE-57844 Change 4015888 by Max.Chen Sequencer: Fix crash on paste. UMovieSceneSections were gathered from the track node's track. For sub track mode, we want to gather only those sections on that track node row. #jira UE-57951 Change 4015943 by Max.Chen Sequencer: Fix moving shots up when the mouse pos goes outside of the virtual track area. #jira UE-57717 Change 4016293 by Max.Chen Sequencer: Fix relative frame playback end frame calculation so that custom start/end frames remain in the space of the sequence and are not relative. #jira UE-57308 Change 4017075 by Andrew.Rodham Sequencer: Corrected initial evaluation range used when calling UMovieSceneSequencPlayer::Play() Change 4017270 by Christina.TempelaarL Sequencer: FCPXML importer and movie scene capture - Use CeilToFrame when converting section start/end frame times to frame numbers in FCPXML and movie scene capture. - Added support for clip metadata in FCPXML. - Got rid of redundant TokenizedError message class, no longer needed now that FCPXML is in editor directory. - Added log messages currently commented out due to exception, still testing. #UESEQ-358 Change 4018370 by Christina.TempelaarL Sequencer: fixed FCPXML log messages regarding sections with start/end not divisible by display rate. #UESEQ-358 Change 4018378 by Christina.TempelaarL Sequencer: fixed error in previous changelist. #UESEQ-358 Change 4019457 by Max.Chen Sequencer: Show event names only when the event track is selected #jira UE-57897 Change 4022806 by Max.Chen Sequencer: Fix crash on movie scene capture dialog shutdown if movie capture wasn't even started. #jira UE-58106 Change 4022894 by Max.Chen Sequence Recorder: Wrap OpenEditorForAssets after sequence recording within GIsEditor #jira UE-58084 Change 4024487 by Max.Chen Sequencer: Add tooltip for quat interpolation #jira UE-58113 Change 4024562 by Max.Chen Sequencer: Change path/attach track sequence binding id to currently focused sequence id so that bindings can be created in subsequences Change 4027414 by JohnHenry.Carawon QAGame: Checking in content that shows a bug with using particles systems and Delay Before Shot Warm Up. Change 4028990 by Max.Chen Sequencer: Fix evaluate sub sequences in isolation. This check was added with the compile on the fly logic. Not sure why it was necessary but it seems like the sub sequence data needs to be updated in order to evaluate sub sequences in isolation. #jira UE-58184 Change 4029004 by Max.Chen Sequencer: Ensure that old binding references are removed when re-assigning actors in sequencer #jira UE-57898 Change 4030997 by JohnHenry.Carawon QAGame: Fixing name of the master sequence Change 4031785 by Michael.Karambelas QAGame: Added an instance of ThirdPerson Run to TM-SequenceRecorder for Record to Possessable test. Change 4035548 by Andrew.Rodham Sequencer: Changed FMovieSceneEvaluationTemplate::TemplateSignature to be a serial number to address non-deterministic cooking issues - This commit is related to the repro steps found in 3914599 and 3934307, both of which have been verified with this new change. - Copy of 4031684 from //Fortnite/Main/... #jira FORT-84852 Change 4036312 by Max.Chen Sequencer: Fix zoom view range so that it uses the passed in InZoomDelta Change 4036318 by Max.Chen Sequencer: Auto size now returns a range and defaults to the channel proxy range so that keyed regions can also be autosized. Change 4036322 by Max.Chen Forgot missing change Change 4036360 by Max.Chen Sequencer: Fix play rate calculation when skeletal animation section play rate changes. Change 4037163 by Mike.Zyracki Weighted Tangent Implementation Tricky thing is that you need to solve a cubic in order to get the bezier weights for the time part of the curve. See https://www.gamedev.net/forums/topic/474094-help-function-curves-for-animation-interpolation/ Maya provides an implementation in it's dev kit but I didn't use it since it was horribly slow and uses an iterative solution to solve the cubic needed. Instead I use an old algorithm (Cardano's method), to solve the cubic which should be much faster. Though relative simple to code from principles I just went ahead and used a version from Graphics Gems 1. I put this cubic solver directly in MovieSceneFloatChannel.cpp, but will need to move it when we support Rich Curve, maybe to FMath:: (which would probalby require some other functions for solving quartics, etc.. for completeness.). Also note we resolve this on every evaluation but dont' need to if the interval the time is evaluating hasn't had any change in values or tangents. So again when we support FRichCurve we can create a Weighted Evaluating class that can hold the cache. Also with the tangent drags I got rid of the Cardinal position that was used to calculate non-weight tangents from the key point and just quickly getting a direction. With weighted tangents we need to use the delta instead (otherwise when moving multiple they would all get the same weight based upon distance to the cardinal point. ) For mixed tangents types what I'm defaulting to non weighted if the interval doesn't match. May need to do weighted instead, not sure. What's left is just FBX import, for tomorrow. #jira UESEQ-76 Change 4037435 by Mike.Zyracki Fix fo build warnings from weighted tangent submission. #trivial Change 4038091 by Michael.Karambelas QAGame: Updated a Sequence Recorder group in TM-SequenceRecorder that had an actor missing the animation. Change 4038374 by Andrew.Rodham Sequencer: Refined scrubber styling for level sequences and actor sequences - Scrubber now shows a block the width of a dsplay rate frame, plus a line for the actual evaluated time. UMG reverts back to the previous styling (no block) - Keys that are outside of the playback range are now drawn with a subdued effect - Tick labels are no longer drawn when directly underneath the scrubber Change 4038490 by Max.Chen Sequencer: Expose tangent weight values in details panel. Change 4038620 by Andrew.Rodham Sequencer: Advanced time panel polish #jira UESEQ-426 Change 4038677 by Max.Chen Movie Scene Capture: Redirector for MovieSceneTools.AutomatedLevelSequenceCapture #jira UE-58248 Change 4039739 by Max.Chen Sequencer: Media track should only be supported by Level Sequence Change 4040024 by JohnHenry.Carawon QAGame: Fix EventReciever and OverrideBinding example The level sequence was set to none so the fix was to set it back to TrackEvaluation_Master. Change 4040610 by Andrew.Rodham Curve Editor: Moved weighted tangent switchers to a single toggle command (CTRL+W) and added an icon #jira 58383 Change 4040882 by Mike.Zyracki Keep broken when turning on weighted #jira UE-58435 Change 4041089 by andrew.porter QAGame: Sequence for Long Tangents bug Change 4041498 by Mike.Zyracki Turn off weighted when going auto to prevent large tangents. Do it both in UI and when doing AutoSetTangents() to really make sure it doesn't happen. #jira UE-58452 Change 4041752 by andrew.porter MediaFrameworkTest: Adding some better logging for setting rates when not supported. Also ignoring commiting URL when there is no text Change 4041896 by Matt.Hoffman The transform dialog box now transforms selected keys and sections, instead of just keys. #jira UE-58265 [CL 4044405 by Max Chen in Main branch]
2018-05-02 10:10:00 -04:00
WorkEvent = FPlatformProcess::GetSynchEventFromPool();
GConfig->GetBool(TEXT("Messaging"), TEXT("bAllowDelayedMessaging"), bAllowDelayedMessaging, GEngineIni);
}
FMessageRouter::~FMessageRouter()
{
FPlatformProcess::ReturnSynchEventToPool(WorkEvent);
WorkEvent = nullptr;
}
/* FRunnable interface
*****************************************************************************/
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3946692) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3801826 by Max.Chen PR #4304: Level Sequence crash fix - Guarded against dereferencing null componen. (Contributed by DSDambuster) Change 3801828 by Max.Chen PR #4302: Movie Scene Visibility Template unitialised variable, causing random . (Contributed by DSDambuster) Change 3801837 by Max.Chen Sequencer: Delay spawning/construction for convert to possessable. This fixes a bug where property values would be lost when converting back and forth from possessable to spawnable. #jira UE-52400 Change 3801841 by Max.Chen Sequencer: Make spacer nodes not selectable. PR #4194: Improvements to Sequencer (Contributed by projectgheist) #jira UE-53117 #jira UE-52139 Change 3804183 by Max.Preussner MediaAssets: Added missing lock in media sound component Change 3805414 by Max.Preussner MediaAssets: Setting valid GUID when initializing media texture resource Change 3819578 by Max.Chen PR #4370: When enabling the "MovieCapture", do not turn off the Stereo-3D display. (Contributed by yehaike) #jira UE-53647 Change 3823414 by Max.Chen Curve Editor: Lock down the first and last keys in the redundant keys removal range so that they're unaffected. #jira UE-53591 Change 3826406 by Max.Chen Sequencer: Move OnStartedPlaying() to within first update in UpdateTimeCursorPosition(). This fixes an issue where setting the hud/player visibility was getting stomped on later. #jira UE-52772 Change 3827044 by Max.Preussner MediaAssets: Added sprite visualization to media sound component #jira UE-53594 Change 3827988 by Max.Preussner MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together #jira UE-53532 Change 3828506 by Max.Preussner MediaPlayerEditor: Added attenuation visualizer for media sound components #jira UE-53594 Change 3832590 by andrew.porter EngineTest: Added a keep state check in Property Animation sequencer test Change 3833053 by andrew.porter EngineTest: Adding Hierarchical Bias test Change 3835683 by andrew.porter EngineTest: Adding UMG Animation screenshot test Change 3836076 by Max.Chen Sequencer: Fix audio volume and pitch multiplier deprecation. Change 3836230 by andrew.porter EngineTest: Adding Sequence Bone Position automation test Change 3836347 by Max.Chen Sequencer: Fixes to shot name parsing. When a shot doesn't contain a shot number, assume, [ShotName]_[TakeNumber]. When duplicating a shot, put the new shot in the same path of the original shot, so that the take numbers will increment properly. #jira UE-51868 Change 3836552 by Max.Chen Sequencer: Sub section now has a takes menu Change 3838094 by Max.Chen UMG: Fix template finish not getting called on stop. This fixes a bug where sections aren't restored when finished. #jira UE-52285 Change 3838708 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3840295 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840957 by Mike.Zyracki Added Show Only Keyable and Show Only Animated to the filter list in the property editor. Added IsPropertyAnimated to IDetailKeyframe Interface which already had support for showing properties which are keyable (which is used for the key icon next to the properties.). Could have created another interface but then would have had to mimic the sequencer binding, releasing also, so this seemed best way. One issue still left is that custom built detail items currently don't store associated properties(usually) and so certain properties, in particulalry transforms, won't show up as keyable or animated. Note this also shows up with the keyable icon not showing up next to transform tracks, and other filters like Show Only Modified not working with transforms/customs. Not sure best way to tackle this. #jira UESEQ-328 Change 3841756 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3843950 by andrew.porter EngineTest: Renaming LevelStreaming tests/content to LevelVisibility Change 3844082 by Mike.Zyracki Missing file for animated filter in property editor. When finding if a track is animated we need to find it but we can't easily induce the MovieTrack class for any particular property. So we don't set a class for it and just search by it's ID and name. #jira UESEQ-328 Change 3846902 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed #jira UE-54247 Change 3849820 by Mike.Zyracki Reassigning deleted widgets didn't work since the menu extender mechanism needs a valid UObject in order to perform an operation on it. So to fix we replaced GetObjectBindingContextMenuExtender in WidgetBlueprint with new delegate mechanism (OnBuildCustomContextMenuForGuid) that supports FGuid in addition to UObjects which is needed to handle re-binding deleted widgets. Note that the default sequencer hacks this for replacing deleted actors in SequencerObjectBindingNode to check to see if a LevelSequence is active. We could move to this mechanism there also. #jira UE-53163 Change 3852211 by Max.Chen UMG: Indicate name of the property that is not bound. #jira UE-54350 Change 3854120 by Max.Chen Sequencer: Fix sibling folders being allowed to have the same folder name. #jira UE-54363 Change 3854627 by Max.Chen Sequencer: Step to next/previous key should work for all tracks if there aren't any selected. #jira UESEQ-391 Change 3855825 by andrew.porter EngineTest: Adding animation blending automation test Change 3855950 by andrew.porter EngineTest: Adding correct expected valuues to animation blending test Change 3856237 by Matt.Hoffman UESEQ-336 - Sequencer Track Reordering Adds the ability to re-order Master Tracks, Folders and Object Bindings within sequencer hierarchies (including UMG). Adds the ability to do a one-off sorting of the content under the old sorting behavior if the user wants to reset their layout to how it was under legacy behavior. Modifies SequencerTrackNodes, SequencerFolderNodes and SequencerObjectBindingNodes to handle CanDrop/OnDrop for above, below and ontop of. Fixes a Slate Issue that forcibly expanded a TreeviewRow if an item handled OnDrop. Slate will now only forcibly expand the row if the item says the drop happened ontop of the item, and not above or below it like it previously did. Change 3856503 by andrew.porter EngineTest: Adding automation test for using animation blueprint with blend multi node in sequencer Change 3857875 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. #jira UE-54462 Change 3858344 by Max.Chen Sequencer: Prevent Goto and Transform boxes from overlapping by allowing them to be visible at the same time in an autosized horizontal box. Also, added close button to the goto box. PR #4425: Prevent Goto and Transform boxes from overlapping in Sequencer ... (Contributed by projectgheist) #jira UE-54210 Change 3860566 by andrew.porter MediaFrameworkTest: Set the option to index 0 for the audio and video track list by default Change 3860654 by andrew.porter EngineTest: Enabling Camera Cut + FOV test Change 3860981 by andrew.porter EngineTest: Updating skeletal mesh tests with a delay after set playback position Change 3861256 by Max.Chen Sequencer: Add all bindings if none selected. #jira-54440 Change 3862154 by Andrew.Rodham Added TimeManagement module Change 3862424 by andrew.porter EngineTest: Turned on the test Bone Positions with Blend Multi Node Change 3862573 by andrew.porter EngineTest: Adding test to compare bone positions in a sequence that is blending an animation that is using an AnimBP Change 3865117 by Max.Chen Sequencer: Stop auto scroll on mouse release of movement. #jira UE-31212 Change 3865303 by Max.Chen Sequencer: Add drag and drop transactions #jira UE-54662 Change 3865304 by Max.Chen Sequencer: Fix crash when an actor factory is not found. Change 3865361 by Max.Chen Sequencer: Don't change the camera/shot lock button when popping out of a sequence. #jira UE-54665 Change 3865412 by Max.Chen Sequencer: Determine whether a transform track is for a camera by using the spawned object or template #jira UE-54666 Change 3865685 by Max.Chen Sequencer: Clear autoscrub offset when stopping autoscroll #jira UE-31212 Change 3865886 by Max.Chen Sequence Recorder: Log an error if the number of frames changes while recording. This can happen if the skeleton changes while recording. #jira UE-48715 Change 3866925 by Andrew.Porter MediaFrameworkTest: Changing the current PNG test video image sequence to 1024 x 576 Change 3867705 by andrew.porter QAGame: Adding Audio Sort Sequence to dev folder Change 3867890 by andrew.porter QAGame: Adding a sequence for testing a sorting crash to my dev folder Change 3872628 by Max.Chen Movie Scene Capture: Split delay before warmup into split delay before shot warmup so that there's separate controls for when the movie scene capture warmups up vs. shot boundaries. Change 3873131 by Matt.Hoffman UE-54732 - Crash reordering a folder with a track. This was caused by folders being the only type of track to check if someone was putting a parent track into a child track. Object Binding tracks and Tracks now check as well so that you can't use the above/below drop targets to add parents as children. This also fixed a typo in the localization keys. #jira UE-54732 Change 3873301 by Mike.Zyracki Added ability to support continous euler angle changes when changing rotations, in particularly with the rotation gizmo's. To do this we effectively added a form an of 'euler filter'(https://en.wikipedia.org/wiki/Euler_filter) to find the closest euler angle to the current euler angle. Three functions were added to FRotator to make this possible, one to get the euler angle that's has the same rotation as it, one to get the difference between two euler angles via Manhattan distance and a third using the previous two to choose a Rotator value that's closest to it. We then use these functions before calling UComponent::SetRelativeRotation to make sure we use the correct Euler after the Quat conversion. We also no longer limit(bound) the euler angles to -180,180, which is obviously necessary to avoid flips. I also changed how we caluclate yaw and roll when pitch is -90 or 90 to make it the standard approach of zeroing out roll and just setting yaw. Main reasons are the previous implementation had precision issues so things like 180, 90, -180 would show up due to numbers being nearly zero but negative,(this would break any smooth interpolations), and this facilitates having a 'gimbal' rotation mode (like Maya, Blender etc..) if we ever want that also. If needed we could keep the previous implementation but would need to add some FMath::IsNearlyZero checks, with less performance. Note we only do this special filtering when applying delta's to actors or components in the editors, which then call UComponent::SetRelativeRotationExact, which is a new function to foces the RelativeRotation to be equal to the new rotation. This allows us to store un-nomalized Rotators at the cost that the RotationCache may be broken. We didn't change any of the other UComponent functions that set rotations (via Quats or Transforms) so they will still be bounded and unwound. In SetInternalWorldLocationAndRotation we only set the rotation if the rotation has changed, which fixes the rotation getting changed and re-normalized if just translate happens. In TransformTrackEditor, we correclty use the bUndwing flag and in MovieScene3DTransformSection there was an un-needed winding check there, it will be unwound earlier if needed, which happens if Sequence Recording is happening. Max we should talk about what to do about this . Note the euler angle drag via the widget is still bound to 0-360. I think we should just unbound that now since the rotations value are now unbound. This review now includes fixes suggested by Zak. #jira UE-UE-22228 Change 3873483 by Matt.Hoffman Sequencer Tracks can now be inserted above the spacer at the bottom of the tree. #jira UE-54706 Change 3873899 by Max.Chen Sequencer: Add section selection throbbing Change 3873908 by Max.Chen Movie Scene Capture: Added logging per frame Change 3873924 by Matt.Hoffman Adds the ability to store Sequence Recorder setups into profiles that stay with the map and can be re-loaded later. Profiles store the Actor Recordings so the settings for each actor should carry with them. #jira UESEQ-339 Change 3874726 by Matt.Hoffman Disable drag-and-drop targets on spacers that come between rows in Sequencer. This prevents extra drag/drop targets showing up between each row. #jira UE-54706 Change 3874862 by Matt.Hoffman Audio Track no longer gets reordered when adding sub-audio tracks, as sub-tracks are no longer counted towards the sorting order index when normalizing indexes. #jira UE-54727 Change 3875905 by Matt.Hoffman Disable Fade Track UI if a fade track already exists in the sequence. #jira UESEQ-393 Change 3876163 by Max.Chen Sequencer: Swap the camera object to the camera component's owner if it's not the same. #jira UE-54874 Change 3876971 by Andrew.Porter EngineTest: Moved Media Player Seek test to new folder. Also enabled the test with new ground truth image. Change 3877040 by Max.Chen Cine Camera: Split camera properties to two groups, "Camera Options" and "Camera Settings". The cine camera now hides properties in the "Camera Settings" group so that properties like bConstrainAspectRatio (in the "Camera Options" group) can be visible. #jira UE-54192 Change 3877763 by Max.Chen Curve Editor: Fix curve changed on end drag so that only curves that had keys/tangents that were changed receive notification, otherwise all loaded curves were getting notified that they were changed. #jira UE-54951 Change 3878234 by Matt.Hoffman Disable "Drop Below" targets for Sequencer Tree nodes to prevent a confusing UX issue where dropping underneath a Object Binding Node puts it after the object binding node but the UI looks like it's inserting it inside the Object Binding node. #jira UE-54743 Change 3879359 by Mike.Zyracki If a track is inactive we dim it a bit which seems to be the UE4 way to show inactive or disabled state. We changed the active logic so that all subtracks need to be inactive for the track to also be inactive(instead of all active for active). This conforms to how the active state actually works, e.g if you have two sections and only one is active the track is still active above it. #jira UESEQ-388 Change 3879462 by Max.Chen Sequencer: Allow dragging onto a particular row which would move out any overlapping sections to make space for the newly created section. Newly created sections are now selected and throbbed to draw attention to themselves. #jira UE-54664 Change 3879464 by Max.Chen Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field. - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field. - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges. #jira UE-54922 Change 3879590 by Matt.Hoffman Items that are now added to the Sequencer via the "+Track" menu will be selected after being added. Items can now be added inside of folders instead of just to the root level. #jira UE-27397 Change 3879612 by Mike.Zyracki Display Nodes with no children are always active. #jira UESEQ-388 Change 3879730 by Matt.Hoffman Sequence Recorder's actor recording groups now remove items from the group when removed via the UI. #jira UESEQ-339 Change 3880256 by Mike.Zyracki Fix issue with inactive display with folders and other track nodes. #jira UESEQ-388 Change 3883491 by Max.Chen Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes. Copy from Release-4.19 #jira UE-51323 Change 3883603 by Max.Chen Movie Scene Capture: Add option toggle disable screen percentage. By default this is on (no change in current behavior). #jira UE-51898 Change 3885074 by Max.Preussner MediaCompositing: Resetting media texture & freeing resource on section end; removed dead code Change 3887220 by Max.Preussner MediaCompositing: Defaulted media section duration to 1 sec (since we do not know the actual duration in most cases) Change 3887478 by Matt.Hoffman Sequences now show [Inactive] in their title bars when they're disabled. This helps communicate why a sequence isn't being evaluated. #jira UE-51469 Change 3888985 by Max.Chen Movie Scene Capture: Clamp HDR Compression Quality between 0 and 1. #jira UE-55136 Change 3893519 by Max.Chen Sequence Recorder: Clarified tooltip for bRecordNearbySpawnedActors - spawned actors will still be recorded if they match the ActorFilter. #jira UE-55238 Change 3893546 by Max.Chen Sequence Recorder: If a selected actor already has a recording, add a blank recording. #jira UE-55239 Change 3894044 by Max.Preussner MediaCompositing: Added support for seeking into a media section Change 3894310 by andrew.porter MediaFrameworkTest: Adding Img media sources for 1080 and 2160 ravent test content Change 3894426 by Max.Preussner MediaAssets: Letting media textures with AutoClear retain their clear color when player is reset Change 3895717 by Max.Chen Sequencer: Null checks to prevent crash when saving the default state of a spawnable #jira UE-55304 Change 3897388 by Max.Chen Sequencer: Don't update current time to be within the view range when stepping into a sequence. #jira UE-55322 Change 3897452 by Max.Chen Audio: Fix crash when trying to record audio without any active capture devices. Log warning if the number of input channels is not 1 or 2. #jira UE-55223 Change 3897619 by Max.Preussner MediaCompositing: Removed commented out code Change 3898072 by Max.Chen Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated. #jira UE-55328 Change 3898272 by Max.Preussner MediaPlayerEditor: Made slate brush constants static Change 3898704 by Max.Chen Sequencer: Skip if the binding id's sequence can't be found. #jira UE-55337 Change 3899855 by Max.Preussner MediaCompositingEditor: Added cache state visualization to media track Change 3900300 by Max.Preussner MediaCompositingEditor: Added loop indicators to media sections Change 3900694 by Max.Preussner ImfMedia: Looping cache only when player is looping Change 3900892 by Max.Preussner Stats: Added stats category for media framework Change 3900954 by Max.Preussner MediaCompositing: Don't evaluate at the end of media section Change 3901348 by Max.Preussner Core: Replaced TLruCache autos for better readability Change 3901655 by Max.Preussner ImgMedia: Added more perf stats to EXR reader Change 3901972 by Max.Preussner MediaAssets: Added getter for media player in media sound components Change 3902233 by Max.Preussner MediaAssets: Enabling media textures to receive samples right after player is assigned Change 3902238 by Max.Preussner MediaCompositing: Working around init/shutdown idiosyncracies in sequencer Change 3904045 by Max.Chen Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register. #jira UE-55314 Change 3905605 by Max.Chen Sequencer: Restrict spawnables from being created if they have a ClassWithin that UMovieScene is not a child of. #jira UE-55429 Change 3906550 by Max.Chen Sequencer: Add media track icon #jira UE-55480 Change 3907101 by Max.Chen Sequence Recorder: Fix bugs related to not recording a level sequence. There were certain assumptions that creating a level sequence meant that sequence recording was in progress. This is not always the case - the recorders can record animation assets and not create a level sequence. Changed the notion of IsRecording() to having at least one actor recording that is recording. Countdown timer, recording displays, etc should function if IsRecording() and not based on whether a level sequence is created. #jira UE-55485 Change 3907247 by Max.Chen Sequence Recorder: Fix crash not removing PrepareToCleanseEditorObject delegate. Repros when opening sequence recorder, closing it, and then opening or creating a level. Change 3910343 by Max.Preussner Core: Added async helper for executing functions on a given thread pool Change 3910346 by Max.Preussner ImgMedia: Added separate thread pools for loading/decoding and deleting image frames Change 3910829 by Max.Preussner Profiler: Increased visible range of profiler graph Change 3910841 by Max.Preussner MediaCompositing: Displaying asset name instead of full media source path in media section Change 3910870 by Max.Preussner ImgMedia: Using deallocation thread pool only in debug builds Change 3919642 by Max.Chen Sequence Recorder: Clarify active tooltip #jira UE-55661 Change 3919660 by Max.Chen Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified - The following sequence of events exposes this issue: - Create a master sequence with a single shot that spawns a cube - Add this sequence to a level and set it to auto-play - Save everything and restart - Resave just the inner shot asset without opening it - PIE - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template. #jira UE-55626 #jira UE-55490 Change 3921825 by Max.Chen Sequencer: "Run Construction Script in Sequencer" is off by default for blueprints but on for Sequencer. This allows the content author to switch it on for specific blueprints and sequencer will be default, run those with construction scripts enabled. Change 3922232 by Max.Chen Sequence Recorder: Reset countdelay on stop. #jira UE-55755 Change 3922306 by Max.Chen Sequence Recorder: Don't automatically mark transforms to be recorded by sequence recorder. Instead, log a warning if the user toggled it off to warn that the resulting animation might not match gameplay. #jira UE-55758 Change 3922912 by Max.Chen Sequence Recorder: Fix refresh next sequence name #jira UE-55757 Change 3927654 by Max.Chen Movie Scene Capture: Added format mapping for the name of the current camera #jira UE-55769 PR #4537 Change 3927658 by Max.Chen Sequencer: Added fbx property mapping for "FocusDistance" to "FocusSettings.ManualFocusDistance" #jira UE-55782 Change 3932022 by Max.Chen Sequencer: Add import animation track section to next available row index. #jira UE-55892 Change 3933919 by Max.Chen Sequencer: Jump to playback start frame and not 0 to start playback for recording. #jira UE-55933 Change 3934307 by Andrew.Rodham Sequencer: Add template signature that is re-generated every time the base template is regenerated, which invalidates evaluation fields This fixes an issue where the same sequence is instantiated multiple times in a sequence. If the source sequence was saved, its template would be wiped, which would invalidate the template ID When an instance tries to evaluate the master template, it would only invalidate a range in the evaluation field that was the hull of any invalid sub sequences overlapping the current time, potentially leaving invalid data in the evaluation field at positions later (or earlier) on in the sequence When the sub template was re-generated, it receives the same SequenceSignature as it had before (because the sequence hasn't actually changed), which causes the stale evaluation field data to fail the IsDirty check (because the sequence is the same as it thought, but the *template* has changed) This has been addressed be adding a signature to templates themselves, and checking both the template signature and sequence signature as a part of the IsDirty check. This ensures that we regenerate if either the template, or the sequence have changed. #jira UE-55934 Change 3936327 by Andrew.Rodham Sequencer: Removed increment when trimming right UMovieSceneSection::TrimSection already explicity assigns an exclusive bound to the time passed in. The new behavior means we can trim a section to the right, and insert another section without changing the time to create adjacent sections. #jira UE-42652 Change 3936328 by Andrew.Rodham Fixed KeyFrameManipulator assignment operators and copy/move constructors - These types are potentially self-referential so cannot use default constructors/assignment Change 3936330 by Andrew.Rodham Converted UMGSequencePlayer to use frames internally #jira UE-54878 Change 3936726 by Max.Chen Sequencer: Set track node as the parent of the key area node. The key area switcher needs the object binding id from the parent object binding node. Without this, the binding to the external value fails. #jira UE-55931 Change 3936775 by Max.Chen Sequencer: Should stop or loop should compare DurationFrames with Current Time from StartTime. The bug is that if you set 30 warmup frames in movie rendering for a range of 0-100, the FrameRange will be starting at -30 and have a duration of 130. Without this fix, the playback will continue until frame 130, rather than 100. #jira UE-55933 Change 3936935 by Matt.Hoffman Easing Curves are now represented in Play Rate resolution instead of internal resolution. #jira UE-55937 Change 3937069 by Matt.Hoffman Users can toggle if the is infinite on each side, limited by which tracks support infinite ranges. #jira UE-55891 Change 3937516 by Max.Preussner ImgMedia: Added support for single-threaded platforms #jira UE-55986 Change 3937826 by Max.Preussner MediaAssets: Disabling media sound components on HTML5 if AudioMixer is not enabled Change 3937997 by Max.Chen Curve Editor: Add Zoom to Fit Curves so that selected curves from Sequencer can be focused on. Tested that undo doesn't re-zoom. #jira UE-55935 Change 3938000 by Max.Chen Sequencer: Stop all sounds before generating audio waveforms. #jira UE-55951 Change 3938376 by Max.Preussner XGEController: Disabled XGE Controller in single-threaded apps to prevent crash Change 3938444 by Max.Preussner Core: Added async support for single-threaded applications Change 3938445 by Max.Preussner Networking: Added support for single-threaded applications in UDP socket sender/receiver Change 3938447 by Max.Preussner Messaging: Added support for single-threaded applications Change 3939432 by Max.Chen Sequence Recorder: Append command list to global level editor actions so that shortcuts are accessible in level editor. #jira UE-55798 Change 3940229 by Andrew.Rodham Added prospective display rate upgrade to UMovieScene::PostLoad - There was previously some very odd behaviour that would assign the fixed frame interval only when a sub sequence was focused in SSequencer. This meant that many sequences could have a frame interval of 0 set in the data. - Under the old method of snap interval display this would have fallen back to getting the display interval from the sequencer settings, but we no longer look at these. - The USequencerSettings properties have been removed and in their place, a prospective data upgrade for sequences that have a fixed frame interval old 0fps that sets the play rate to the previous defaults based off the old USequencerSettings defaults. - This could end up 'changing' the display rate for sequences where the user has changed the snap interval in the settings for a particular sequence editor, but there's not much we can do about that given we don't have access to the USequencerSettings classes in UMovieScene #jira UE-55919 Change 3940277 by Andrew.Rodham Sequencer: Added ability to default frame resolutions and play rates for newly created actor sequences Change 3940378 by Andrew.Rodham Sequencer: Post move import dialog now defaults to the playback framerate of the sequence, and floors to frame numbers Change 3940559 by Andrew.Rodham Reinstated primed or recording sequence color Change 3940642 by Max.Preussner ImagePlate: Removed image plate media playback functionality Change 3940843 by Max.Preussner Core: Made TCircularQueue actually thread-safe; improved code comments Change 3940860 by Max.Chen Sequencer: Changed StructNameToKey to StructPathToKey Previously, keying a PropertyPath of [RenderTransform][Shear][X] would get trimmed to X, which doesn't map to a channel name as considered by Sequencer2dTransformTrackEditor. Instead, trim the resulting property path to [Shear][X] so that track editors can determine the desired struct path and channels to key. #jira UE-52966 Change 3941292 by Mike.Zyracki Fix for trajectories out of range not showing up. 1) If we had no key data we would pop the time, so wouldn't get the section ranges. 2) Calculating of upper bound was wrong, checking against -1 and not key == num of keys when doing algo::lower_bound. 3) No need to do the Bck-- for the bakward iterators since we fixed #2. We start now from the upper bound correctly. 4) If we had no keys (at section start,end) we would incorrectly say we were any key type, so since we draw constant keys as dashed we would do so incorrectly around section end points. #jira UE-55929 Change 3941424 by Max.Chen Curve Editor: Change Zoom to Fit to use TArrayView Change 3941498 by Max.Preussner Core: Added FMath::DivideAndRoundNearest function Change 3942097 by Matt.Hoffman Drop Frame Timecode Support for NTSC rates. Change 3942104 by Matt.Hoffman Sequence Recorder Group is no longer visible inside the World Outliner after using one. #jira 55266 Change 3942107 by Max.Chen Sequencer: Resurrect logic to find or extend an existing section when adding keys. Change 3942330 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942339 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942507 by Andrew.Rodham Sequencer: We no longer pad the time overlap threshold with a small number that is not scaled by the current zoom level - The presence of this pad was causing keys that were far apart to be grouped when zoomed in a long way Change 3942509 by Andrew.Rodham Sequencer: Only pad total view range, rather than section range as well when retrieving keys to render - This stops us from rendering keys that are within the view range, but outside the section range Change 3942512 by Andrew.Rodham Added transactions to some sequencer details customizations Change 3942513 by Andrew.Rodham Sequencer: Reinstated validation checks to UMovieSceneSection::SetStartFrame and SetEndFrame, changed erroneous uses to use SetRange Change 3942560 by Andrew.Rodham Pass by rvalue reference to appease error C2719 on Win32 ('InChannels': formal parameter with requested alignment of 8 won't be aligned) Change 3942697 by Andrew.Rodham Newly Created Level Sequences and Actor Sequences now default to 24000 fps frame resolution (+/- ~24hrs range, supporting all integer rates + 23.976) Change 3942700 by Andrew.Rodham Sequencer: Added legacy out-of-bounds errors for times that are not supported by the current legacy upgrade frame resolution Change 3942989 by Max.Preussner Core: Fixed circular queue count calculation Change 3943538 by Max.Preussner MediaAssets: Reverted workaround for procedural audio log spam in HTML5 (Actor component initialization cannot be skipped if the component is used in a level) Change 3944071 by Max.Preussner QAGame: Fixed Media Texture keeps last frame of Media when PIE ends #jira UE-53360 Change 3944292 by Max.Chen Sequencer: Added extra flags to ensure that asset initialization does not occur on template actor sequences #jira UE-56113 Change 3944364 by Max.Chen Sequencer: Prevent circular shot/master tracks. Tested adding master -> child -> master as drag and drop cinematic shot tracks and sub tracks as well as through the + button. #jira UE-56091 Change 3944422 by Max.Chen Sequence Recorder: Disable transform recording if off. #jira UE-56061 Change 3944745 by Andrew.Rodham Sequencer: Key rendering fixes - Fixed assert that occured when keys happened to reside on some times due to KeyTime + TimeOverlapThreshold - KeyTime being slightly larger TimeOverlapThreshold - Fixed keys sometimes being clipped when zoomed right in due to lack of half-frame offset - Added missing documentation to MovieSceneTimeHelpers.h #jira UE-56107 Change 3945231 by Andrew.Rodham Sequencer: Reconstruct channel proxy on Serialize to catch all cases of undo/redo, PostLoad and duplication #jira UE-56089 Change 3945301 by Andrew.Rodham Sequencer: Added safety checks during initial sequence recording to guard against applying negative or 0-sized sequence ranges #jira UE-56125 Change 3946627 by Max.Preussner Fortnite: Fixed game crashes closing editor while in PIE - Pure virtual function being called #jira UE-56144 [CL 3946896 by Max Chen in Main branch]
2018-03-14 22:09:33 -04:00
FSingleThreadRunnable* FMessageRouter::GetSingleThreadInterface()
{
return this;
}
bool FMessageRouter::Init()
{
return true;
}
uint32 FMessageRouter::Run()
{
while (!Stopping)
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 4044339) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3947021 by Max.Chen Sequencer: Don't preserve root component when copying object properties. A spawnable empty actor, has a root component that is generated by the empty actor factory. If the object template's root component is preserved when copying from the spawnable empty actor, the root component will not be copied over. Therefore, we need to NOT preserve the root component when copying object properties. #jira UE-55825 Change 3947366 by Max.Preussner WmfMedia: Better log output Change 3947367 by Max.Preussner MfMedia: Better detection of compressed format properties on Windows Change 3949102 by Max.Chen Sequencer: Remove SequenceActorTag when converting to possessable. #jira UE-56206 Change 3949207 by andrew.porter EngineTest: Set the screenshot nodes resolution to 1280x720 Change 3949404 by Max.Chen Sequencer: More informative tooltip for "Rerun Construction Scripts" option. It now says "Rerun construction scripts every frame on actors that have 'Rerun Construction Script in Sequencer' enabled in their class settings". Change 3950067 by Matt.Hoffman Renamed UAutomatedLevelSequenceCapture's StartFrame and EndFrame to CustomStartFrame/CustomEndFrame to reflect that it is user-overriden. This will also resolve upgrade issues due to the variable datatype changing. #jira UE-56189 Change 3950193 by JohnHenry.Carawon Updating my latest MovieRendering test content. Change 3950757 by JohnHenry.Carawon More updates to MovieRendering test content Change 3952059 by Max.Chen Resave LevelVisibility_SubLevels to fix data loss conversion warning of OpacityMaskConstant #jira UE-56086 Change 3952283 by Max.Chen Sequencer: Disable dropping level sequence assets as spawnables. #jira UE-56120 Change 3952422 by Max.Chen Sequence Recorder: Add button to record from the current player. #jira UE-55942 Change 3952987 by JohnHenry.Carawon MovieRendering Test Content - Fixing camera bindings and changing the override binding actor Change 3953823 by Mike.Zyracki Fix for Bad FBX Import Tangents not scaled by frame rate. After looking at this again it seems that a set of MovieScene:: overiddes for the channel traits wasn't set correctly, so use the ADL idiom to use MovieScene, which can then call Optimize in the correct namespace. With this we can now correctly use the passed in tolerance. There was also a redundant set of Optimize calls so that it could happen twice so removed them, and needed an extra check in the float channel Optimize. Also since we need to set auto tangents no matter if we optimize we don't set that parameter(though leave it since it's used by context menu key reduction). Finally fixed speed issue with trajectories caused by calculating way too many substeps. Reverted back to a time based step size for consistency. #jira UE-56193 Change 3954317 by Matt.Hoffman Adding a key to the last frame of a section no longer causes a crash. Keys can already be moved to be on the last frame of a section so now you can just add a key there directly. #jira UE-56255 Change 3954326 by Matt.Hoffman Dilating a section that is only infinite on one side no longer causes a crash. #jira UE-56260 Change 3954486 by Max.Chen PR #4580: Exposes IsReversed() from UMovieSceneSequencePlayer (Contributed by alanedwardes) Change 3955238 by Max.Preussner Messaging: Enabled delayed message routing https://github.com/EpicGames/UnrealEngine/pull/4574 #jira UE-56247 Change 3955901 by Max.Preussner MediaFrameworkTest: Added developer test for overriding desired media player plug-in at runtime. Change 3955922 by Andrew.Porter QAGame: Updating movie rendering content in dev folder Change 3956004 by andrew.porter QAGame: Adding MPC track to movie rendering test content Change 3956510 by Max.Chen Sequencer: Fix fbx camera import of static properties so that they are imported before default tracks are created. Otherwise, the default tracks inherit the default properties of the camera, rather than the values from the fbx. #jira UE-56311 Change 3957613 by Max.Preussner MediaUtils: Added code documentation to media player facade Change 3958005 by Max.Preussner MediaUtils: Added method to get number of sinks Change 3958934 by Max.Chen Sequencer: Fix keys getting added and sequence getting erroneously re-evaluated when auto key is off. Only apply defaults if there are no keys. Only modify the movie scene section before creating keys or setting defaults. #jira UE-55903 Change 3959687 by Andrew.Rodham Sequencer: Fixed visibility track external values being inverted #jira UE-56324 Change 3960507 by Max.Preussner Core: Fixed incorrect rounding in FMath::DivideAndRoundNearest Change 3962047 by JohnHenry.Carawon MovieRendering Test Content Changes: - Add Lightmass Importance Volumes to sublevel to fix warnings - Rebuilt Lighting - Add a third sequence for Gamut testing - Resaved the sound master.uasset to fix warning Change 3962211 by Mike.Zyracki Add Frame Numbers to selected animation sections. Added MapTimeToAnimation to MovieSceneSkeletalAnimation so that we could get it from the Skeleton Animation track Editor. Since the thickness of the frame line can change based upon frame rate and zoom we need to calculate it similarly to how the time slider controller does it. Those calculations were private so we had to expose FScrubRangeToScreen and GetScubberPixelRange from the TimeSliderController. Also needed to know if the section itself was selected so added a bIsSelected flag to the section Painter. Also fixed a bug where you couldn't add a section if other sections existed at different times in MovieScenePropertyTrack and could crash due to the check(). #jira UESEQ-395 Change 3962497 by Max.Preussner Core: Added new string formatting argument to FTimespan Change 3963662 by Max.Chen CineCamera: Flip VistaVision width and height. Change 3963731 by Max.Preussner MediaCompositing: Implemented sequence recording support for media track Change 3964195 by Andrew.Rodham Sequencer: Set inverted property correctly for newly created visibility track sections - Also clamp evaluation for key editors to the bounds of the section so we're not displaying values outside of the section bounds when the cursor is not on the bounds #jira UE-56324 #coderevew Max.Chen Change 3964196 by Andrew.Rodham Sequencer: Fixed crash when attempting to render sections that resulted in a negative intersection with the view range Change 3964275 by Andrew.Rodham Sequencer: Fixed MovieScene::ClampToDiscreteRange for infinite range bounds Change 3964364 by Andrew.Rodham Curve Editor: Reduce minimum vertical view range when zooming to fit Change 3965091 by Max.Chen Sequencer Recorder: Refresh next sequence if empty when starting a recording, otherwise, use existing name. #jira UE-56469 Change 3965148 by Max.Chen Sequence Recorder: Move Record to Possessable to "Actor Recording" group Change 3965162 by Max.Chen Sequence Recorder: Always break out of immersive mode when done recording, even when stopping recording during countdown. #jira UE-56407 Change 3965214 by Max.Preussner QAGame: Enabled ImagePlate plug-in Change 3965574 by Max.Preussner SimpleComposure: Reorganized & upgraded content to work with new Media Track #jira UE-56488 Change 3965651 by Max.Preussner MediaCompositing: Ignoring seek-on-open if media not seekable Change 3966075 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Export functionality #jira UESEQ-358 Change 3966087 by Matt.Hoffman Adding a single key to the Particle Toggle track now makes an infinite range section that is displayed in the UI. #jira UE-56295 Change 3966547 by Andrew.Rodham Sequencer: Fixed rounding errors when drawing the section background on boolean sections - Logic was using time in sectonds which caused rounding errors on evaluation and flickering red/green stripes when dragging keys around #jira UE-56324 Change 3966563 by Andrew.Rodham Curve Editor: Key editor interface improvements - SKeyEditInterface has a few problems - it does not update in real time when editing properties, and does not support multi-edit which makes it unsuitable for use with the curve editor - We now take a different approach for editing keys by gathering a set of proxy UObjects for each key that is currently selected. These objects are added as top level objects to the details panel which means they support multi edit as you'd expect from any other details panel in the editor. - Proxy objects are updated every tick for the curve editor if they implement the ICurveEditorKeyProxy interface, which allows them to refresh their current value. - Ideally, the same mechanisms would be used in the main sequence interface, and we would be generating the proxy classes at runtime based on the key value type, but that work remains a separate task from this initial offering. #jira UE-56165 Change 3966564 by Andrew.Rodham Curve Editor: Expand to frame when adding or moving keys in the curve editor Change 3967051 by andrew.porter MediaFrameworkTest: Set the CameraPlayer_Video texture to auto clear Change 3967141 by Andrew.Rodham Sequencer: Keep track of spawned objects that have been modified and only re-save such object's default spawnable state on destruction - Now that we're taking this approach, I've remove serveral redundant bits of functionality in the spawn register such as making some spawnables read-only, and the PreSave binding for Sequencer. - We now hook into all object pre-saves to make sure we handle the case where the sequences are saved through the content browser or elsewhere. #jira UE-47686 Change 3967170 by Andrew.Rodham Sequencer: Added the ability to possess anim instances as object bindings - This allows full and direct animation of properties on UAnimInstance, and animation blueprints - Object Bindings are made by first possessing a skeletal mesh component, then choosing the + Add button where its anim instance will be listed - Added a new function to UMovieSceneSequence to gather previously cached objects that should now be invalidated. Anim instances will be re-resolved if a new UAnimInstance is assigned to USkeletalMeshComponent::GetAnimInstance. - ObjectBindingIDs for anim instances are just represented by an entry in a set of GUIDs. We only ever resolve such bindings through USkeletalMeshComponent::GetAnimInstance. - Only currently supported on LevelSequences #jira UE-56132 Change 3967195 by Max.Preussner Core: Updated TRangeSet to use TCallTraits Change 3967345 by JohnHenry.Carawon Test Content Changes - first iteration of spacing out the examples in the shots. Change 3967572 by Max.Chen Sequencer: Fix setting PreviousPlayEvalPosition until after we've tested whether it's set. #jira UE-56518 Change 3967750 by Max.Chen Audio: Set duration based on number of input channels, rather than number of channels to serialize. This fixes an issue where audio split into 2 channels is set to a duration that's twice as long. #jira UE-56430 Change 3967836 by Max.Chen Sequencer: Allow for animating array elements within ustruct properties #jira UE-55887 Change 3968506 by Matt.Hoffman Fixed ambiguous conversions for seconds and frames being overriden by ambiguous conversion to Timecode (in frames). Change 3968748 by Max.Chen Sequencer: Make the event properties submenu widget larger. #jira UE-55557 Change 3968862 by Max.Chen Sequencer: Recursive expansion when shift is down #jira UE-52139 #pr 4194 Change 3968863 by Max.Chen Sequencer: Bind rename command to selected track so that F2 shortcut start renaming #jira UE-52139 #pr 4194 Change 3968872 by Max.Chen Sequencer: Rekey the selected key at the current time. #jira UESEQ-396 Change 3968938 by Max.Chen Cine Camera: Add option to toggle the behavior of locking the rail mount to the orientation of the spline. By default, the option is off, no change in behavior. #jira UE-55815 Change 3968958 by Andrew.Rodham Sequencer: Consider vertical position when hittesting keys #jira UE-56256 Change 3969643 by Max.Preussner Core: Rounding timespans created from double values towards nearest ticks Change 3969646 by Max.Preussner MediaUtils: Implemented timeout mechanism for block-on-fetch feature Change 3969776 by Mike.Zyracki Added Skip Anim Notifiers Toggle per what was in Matinee. Investigated the Enable Root Motion toggle as also discussed but it's implementation is directly contained by the animation asset and unlike animation notifies there seems to be no exposure to interactively disable it during a playback tick. Note if we are generating thumbnails we still automtically disable notifies in the editor to avoid annoying noise playback. Note that if Enable Root Motion/Root locked is specified in the animation asset it does correctly effect the Sequencer. #jira UESEQ-399 Change 3969835 by Matt.Hoffman Playback Range and Selection Range use unified logic for adding themselves as potential snap locations which properly handles inclusive/exclusive bounds. This resolves an issue where having an unset selection range caused a potential snap location to be added on frame 0 and 1 (internal resolution) which caused a misalignment when placing objects near frame 0. This also removes the one frame offset on setting Selection Range to bring behavior inline with other ranges. #jira UE-55420 Change 3969885 by Max.Preussner MediaAssets: Don't register media player CDO with media ticker Change 3971129 by Andrew.Rodham Sequencer: Fixed UMovieSceneSequencePlayer::GotToEndAndStop() not taking into account for start time This is a remnant from when the times were always specified in 0-duration space, rather than actual sequence times. Change 3972056 by JohnHenry.Carawon More updates to Test Content. I continued spacing out the examples in the sequence so that they have a consistent number of frames between each example and during the start/end of the example. Also removed the Marcie sublevel. Change 3972066 by Andrew.Porter MediaFrameworkTest: Setting Marcie folder to be never cooked in package settings Change 3972675 by Matt.Hoffman Splitting Subsequence Sections no longer sets an incorrect playback range on the subsequence when the subsequence has a different internal resolution than the owning sequence. #jira UE-55453 Change 3973376 by Max.Preussner ImgMedia: Zero is the only valid video track for image sequences Change 3973489 by Max.Preussner Launch: Build rules cleanup pass - don't use Media, MediaUtils on server apps - don't link against Media (include-only dependency) - don't include from MediaAssets (dynamic load only) Change 3973760 by Max.Preussner MediaUtils: Moved AppMediaTimeSource implementation into its own file; added logging Change 3973765 by Max.Preussner ImgMedia: Disallowing seek beyond media length Change 3973855 by Max.Preussner MediaFrameworkTest: Updated developer test content Change 3973858 by Max.Preussner MediaCompositing: Blocking on media player time instead of media sample time (the former may not be hit in the current frame) Change 3974988 by Max.Chen Sequencer: Fix trim left so that it also sets the start offset for audio and skeletal animation sections. #jira UE-57015 Change 3976101 by Matt.Hoffman Sequencer will now focus the scroll view on newly created items. #jira UE-56492 Change 3976203 by Max.Chen Property Editor: Add DetailsViewArgs for ColumnWidth. Defaults to 0.65f, no change in existing behavior. Change 3976205 by Max.Chen Sequencer: Set better column widths for sequencer. #jira UE-55557 Change 3976206 by Max.Chen Sequencer: Added menu category for import/export Change 3976265 by Matt.Hoffman Tracks within Object Binding Nodes will now sort using the old behavior so that components are added above other track types. #jira UE-56473 Change 3976901 by Max.Chen Sequencer: Add event names to event track section #jira UESEQ-353 Change 3977878 by Max.Preussner Media: Moved media framework ticking stats into Media module Change 3977982 by Max.Chen Sequencer: Add Edit->Reset section length to duration of source (ie. audio, skeletal animation, shot length) Added MovieSceneSection::GetDefaultDuration and MovieScene::HasDefaultDuration #jira UESEQ-392 Change 3977994 by Max.Preussner Media: Fetching and rendering media samples before viewports are rendered (to ensure frame sync for in-level media playback) #jira UE-53975 Change 3978188 by Matt.Hoffman Easing Curves are now clipped by the sequence's PlayRange when testing against an infinite section. This causes blended sequences to finish their blend when the section starts/ends instead of always using 25% of the total section length to determine default blend range. #jira UE-56362 Change 3978676 by Max.Preussner MediaCompositing: Fixed first frame of rendered out media track missing #jira UE-53975 Change 3978684 by Max.Preussner MediaCompositing: Enabled media track frame sync feature #jira UE-53975 Change 3980026 by Matt.Hoffman Keys can be selected on folded out sections (such as an audio track expanded to show volume and pitch) again. #jira UE-57169 Change 3981614 by Max.Preussner MediaUtils: Added missing subtitle sample queue flush Change 3982311 by Max.Preussner MediaCompositing: Added safeguard for zero length media sources Change 3982389 by andrew.porter QAGame: Adding media track test content into FrameAccuracySubscene Change 3983661 by Max.Chen Sequencer: Add level name to spawn a spawnable into. Add sublevel menu option to set the level #jira UESEQ-390 Change 3983712 by Andrew.Rodham Sequencer: Purge legacy blueprint spawnables from LevelSequence packages #tests Ran a preflight for cooking fortnite, ocean and Orion. Only orion shows up this edge case, and will require a re-save of the EndCines level #jira UE-39173 Change 3983787 by Max.Preussner MediaCompositing: Moved compile time switch for block-on-fetch into media player facade Change 3983812 by Andrew.Rodham Sequencer: Exposed default level sequence instance data to blueprints Change 3984373 by Max.Preussner Media: Added API for quering whether player plug-in supports block on fetch Block on fetch allows Sequencer and other systems to block the game thread until a desired video frame has been decoded. Change 3984670 by JohnHenry.Carawon Movie Rendering Test Content progress. Saving the state of the content. There is a bug where things got replaced with particle emitters and I think it was because I tried to copy paste an animation track into a separate skeletal mesh track. Change 3985097 by Max.Chen Sequencer: Rename Reset to AutoSize Change GetAutoSizeDuration to return TOptional<FFrameTime> #jira UESEQ-392 Change 3986043 by Max.Chen Sequencer: Fix crash when attach/path duration is less than 0. #jira UE-57310 Change 3986373 by Max.Chen Sequencer: Add support for deleting tracks and channels which equates to setting the channel mask. #jira UE-52951 Change 3986375 by Max.Chen Sequencer: Add Create Pose Asset to skeletal animation section. This allows animators to blend animations in sequencer and create new pose assets from them. #jira UESEQ-408 Change 3986796 by Andrew.Rodham Sequencer: Fixed stale object references remaining in ULevelSequence::BindingReferences when using convert to spawnable/possessable - We used to convert objects by creating a new binding, then re-assigning its GUID, which meant we didn't have to do any further object fixup, but the code to achieve this was confusing and led to a vulnerability where object references would not be cleaned up correctly due to the newly created possessable essentially being a temporary object that's immediately thrown away. - To address this, there is now a function for porting all the contents of one object binding to another, and handles the correct fixup required for parent/child object bindings for both spawnables and possessables. - Also added codepath to remove any stale object references from the level sequence reference map on PostLoad (this piggy-backs off the PurgeLegacyBlueprints object version which is close close enough to this change to be identical) #tests Verified that existing sequences with stale references get cleaned up on load. Verified that repreatedly converting from spawnable<->possessable cleans up references correctly. Change 3987807 by JohnHenry.Carawon Updates to the MovieRendering Test Content. - Fixed the spawnable actors that were overwritten - Shortend the Lighting example and combined the Intensity and Color tracks - Organized the Sequence and WorldOutliner to group the examples. Change 3988151 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. Change 3988880 by Max.Chen Sequencer: Support enter to add asset for all sequencer track editors that have asset pickers. #jira UE-57367 Change 3988953 by Max.Chen Sequencer: Make the track color picker focusable so that it will close when you click away or lose focus. #jira UE-57210 Change 3988962 by Max.Chen MovieSceneCapture: Fix EDL export so that it takes into account movie scene frame resolution and desired frame rate. #jira UE-57365 Change 3988964 by Max.Chen Movie Scene Capture: Clarified tooltip for bRelativeFrameNumbers. If you specify custom start/end frames for the recording, they will be relative to the playback range. #jira UE-57308 Change 3989442 by Max.Chen Fix CIS Change 3991548 by Matt.Hoffman Dragging the time slider no longer causes the time slider to ignore snap-to-interval with "Snap to Keys While Scrubbing" when no keys are in range. #jira UE-57417 Change 3991598 by Matt.Hoffman Snap to Key while scrubbing now mirrors the behavior of "jump to next key". When there are no tracks selected it snaps to all keys and when there are tracks selected it snaps to only keys from that track. This also resolves an issue where deleting an object did not remove it from the Sequencer's selection. Undoing a delete already doesn't seem to restore your selection, so removing it from your selection shouldn't change that behavior. #jira UE-57417 Change 3991603 by Max.Chen Sequencer: Disable EditAnywhere for some section properties #jira UE-53530 Change 3992240 by Max.Preussner MediaAssets: Implemented dynamic audio sample rate adjustment based on audio/media clock drift #jira FORT-70638 Change 3992911 by Andrew.Rodham Sequencer: Fixed saving spawnable state using the wrong spawned object - We now track the object binding ID so that we can apply the spawned object to the correct spawnable when the asset is saved #jira UE-57353 Change 3992914 by Max.Chen Movie Scene Capture: Fix compression quality not being set. The compression interface wasn't being found through query interface, so no compression was being set. Reworked finding it through the output pins. Tested running various compression values. #jira-UE-55488 Change 3992919 by Max.Chen Sequencer: Convert to possessable now uses object template instead of copying properties (ie. see LevelSequenceActorSpawner). This fixes MIDs getting lost when converting to spawnable and back to possessable. #jira UE-52400 Change 3993184 by Max.Chen Sequencer: Don't show +Transform/+Path/+Attach track if the actor has the "Mobility" property hidden. Set the Landscape, LandscapeProxy and InstancedFoliage "Mobility" property to be hidden since it is static is not supposed to be dynamically movable. #jira UE-56347 Change 3993238 by Max.Chen Sequencer: Test for hidden mobility in creating keys as well. Refactored to HasHiddenMobility() #jira UE-56347 Change 3993978 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. #jira UE-57489 Change 3994039 by Max.Chen Landscape: Add Mobility to hidecategories on landscape component #jira UE-56347 Change 3994626 by JohnHenry.Carawon Updated Movie Rendering Test Content. - Fixed the overridden spawnables to their proper object types. Change 3994653 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Import functionality, improved Export functionality #jira UESEQ-358 Change 3995609 by Max.Chen UMG: Add support for 2d transform mask (translation, rotation, scale, shear) #jira UE-52951 Change 3995778 by JohnHenry.Carawon Movie Rendering Test Content Updates - Adjusted Lights example - Adjusted Camera example - Added Marcie sublevel back in Change 3995942 by JohnHenry.Carawon QAGame: Moving Movie Rendering test content from Developer folder to Sequencer folder Also adjusted level visibility, lights and camera example. Change 3995993 by Christina.TempelaarL Sequencer: FCPXML Export updates - only export sections if in playback range and media exists, warn if media does not exist. Other updates - removed unused methods and variables, fixed message context naming to be more accurate #jira UESEQ-358 Change 3996595 by andrew.porter QAGame: Updating Marcie content in TrackEvaluation level to use Image Plate Change 3996614 by andrew.porter QAGame: Adding color test sequence to the sublevel Change 3996643 by Max.Chen Sequencer: Fix fbx animation export - rotation and scale channels were flipped. #jira UE-57509 #jira UE-57512 #jira UE-57514 Change 3996652 by Max.Preussner Messaging: Fixed delayed messaging using incorrect current time after message router sleep Based on https://github.com/EpicGames/UnrealEngine/pull/4601 Change 3996801 by Max.Chen Sequencer: Fix folder active state for non key area sections. Look at track node sections as well as key areas. #jira UE-57550 Change 3997098 by Matt.Hoffman Cleaned up some remaining ToDo's in STimeRange. Change 3998339 by Max.Preussner Sockets: Added documentation for socket receive functions Change 3998359 by Max.Preussner MediaUtils: Started to implement media recorder helper class Currently only supports BGRA frames in CPU memory. Supporting other formats and buffer types will require conversions on render-thread. I recommend refactoring out the existing conversion code in FMediaTextureResource into a reusable helper class in the MediaUtils module. This should be a good starting point though. Change 3998417 by Matt.Hoffman Keys and Sections can now be moved at the same time inside of Sequencer. Keys can now snap to Sections (and vice versa) instead of just to other Keys. Sections can now be duplicated like keys can. #jira UE-56995 Change 3998427 by JohnHenry.Carawon QAGame: Updating test content for the Movie Rendering feature. - Added an auto activate particle to the beginning of the sequence (it's not part of the sequence at all) - Added an event receiver blueprint to the Events example - Added a particle emitter to both sublevels - Added a camera cut to the end that switches to a separate camera - The camera zoom in, focus and Look At sections are all separate (not overlapping in the sequence) - Added a second actor for the camera Look At - Added a Visibility section for the Actor Hidden In Game track that has possessable and spawnable cube and light Change 3998537 by Max.Chen Sequence Recorder: Restore immersive mode when stopping the sequence even if not in PIE. #jira UE-56407 Change 3999809 by Matt.Hoffman Removed the "Go To" box from Sequencer and instead placed the current time as an always visible control. The previous shortcut (Ctrl + G) now focuses the new widget directly. #jira UESEQ-376 Change 4000543 by Christina.TempelaarL Sequencer: Moving editor-only code from runtime module MovieSceneCapture to editor module MovieSceneTools. Moved EDL and FCP XML exporters as well as Automated Level Scene Capture. #jira UESEQ-358 Change 4000706 by Matt.Hoffman Entering multiple time strings without a number no longer crashes Sequencer. #jira UE-57672 Change 4001051 by andrew.porter MediaFrameworkTest: Fixing up some image sources pointing to the wrong location Change 4001191 by andrew.porter QAGame: Adding some quick EDL/XML test content to dev folder Change 4001243 by Max.Chen Sequencer: Fix import EDL out of range. #jira UE-57665 Change 4001856 by Matt.Hoffman Selecting keys and sections at the same time now also works with animation and audio sections. #jira UE-57716 Change 4002021 by Max.Chen Sequence Recorder: Fix sequence name incrementing. If external recording sets the sequence name, use it. Otherwise, use the recording name from the recording group or the recording settings. #jira UE-57712 Change 4002618 by Max.Chen Viewport: Update the look at location when updating to a locked actor. This fixes an issue so that popping the view out of a locked actor and manipulating the view will not jump to the previous look at location. #jira UE-57725 Change 4002979 by Matt.Hoffman Fixes several edge cases with the end time range that was causing confusion about what the last frame of the sequence was. Dragging the End Frame slider will no longer be off by one tick and jumping to the end via the UI controls now properly respects snapping and stays inside the play range instead of falling outside of it. Overall behavior does not change though and End Frame should be considered an exclusive frame so that frames 0-150 results in a 150 frame long animation (which is frames 0-149). #jira UE-56367 Change 4003185 by Matt.Hoffman Fixed a regression that prevented a section from being dragged upwards past row 0 which normally resulted in all other rows moving down. #jira UE-57717 Change 4003193 by JohnHenry.Carawon QAGame: Updates to test content - Shortened frames between the examples from 95 to 30 - Separated camera setting tracks - Lighting example now switches directly from constant red - green - blue Change 4003369 by Max.Chen Sequence Recorder: Refresh next sequence regardless of internally stored sequence name. #jira UE-55757 Change 4003586 by JohnHenry.Carawon QAGame: Test Content Updates - Level Visibility track now ends to that the levels are not visible when we move to the next example - Shortened camera section, removed Z tranform so that we just move left to right and shortened the overall length Change 4004414 by Max.Chen Movie Scene Capture: Fix regression where rendering with shot handles would only render the first shot. 3972166 addressed an issue where an extra frame would be rendered by finalizing right when the end frame was reached. This was hit on the first shot end frame, so instead, do this only for when the last shot is being rendered. #jira UE-57314 Change 4004765 by Christina.TempelaarL Sequencer: Fixed bugs in FCP XML import/export. - Export: fixed sequence default resolution. - Export: fixed XML files with no shots. - Export: all sections clipped to playback range. - Export: fixed incorrect section start/end times due to precision issues. - Import: fixed incorrectly adding cinematic tracks. - Import: fixed bugs creating new sections. #jira UE-57660 #jira UE-57662 #jira UE-57655 #jira UE-57761 Change 4005119 by Max.Chen Sequencer: Export/import at play rate Change 4005195 by Max.Chen UMG: Finish UMG evaluation on stop. Added object version so that existing UMG assets do not change. #tests - Newly created UMG animation with sections set to restore state now return to their original state. Existing UMG animations with sections set to restore state do not return to their original state. #jira UE-52285 Change 4005377 by Michael.Karambelas QAGame: Moving TM-SequenceRecorder and related content out of my developer folder and into /Content/Sequencer/SequencerRecorder/* Change 4005417 by Michael.Karambelas QAGame: Fixed a BP compiler in the Level Blueprint of TM-SequencerRecorder. Change 4005634 by Michael.Karambelas QAGame: Fix up missing content and broken level sequence in TM-SequenceRecorder after move Change 4006324 by Max.Chen Sequencer: Reset if the focused movie scene is null. This fixes a crash if the user is focused in on a shot and undo takes the user past the point of where the shot was created. #jira UE-57752 #jira UE-47661 Change 4007006 by Max.Chen Sequencer: Fix FindAvailableRowIndex so that it returns the max row index (and not +1) since it doesn't find any conflicting rows. #jira UE-57717 Change 4007907 by Max.Chen Sequencer: Fix crash if there's no animation Change 4007948 by andrew.porter QAGame: added test content to dev folder for Record World Space Change 4008636 by Max.Chen Sequencer: Fix import fbx not setting values properly and creating additional cameras unncessarily. #jira UE-57864 Change 4008759 by Max.Chen Sequencer: Follow up fix for import cameras #jira UE-57864 Change 4009994 by Matt.Hoffman Dragging the left or right handles of the Time Range slider in Sequencer will now zoom your view in on the current center of the screen. This prevents the view from being translating as you tried to zoom in which caused issues at high zoom levels. #jira UESEQ-407 Change 4010169 by Christina.TempelaarL Sequencer: FCP XML fixes. - FCP XML export - no longer clips to playback range - FCP XML and EDL export - fixed missing last frame of some sections after exporting to Premiere. - Automated level capture, EDL export - use RoundToFrame instead of FloorToFrame for computing section start/end frames after frame rate conversion. #jira UE-57802 - partial fix, movie scene capture still needs to render full section rather than clip against playback. Change 4010287 by Mike.Zyracki Add quaternion interpolation option to UMovieScene3DTransformSection. This mimics how Matinee used to work by bascially finding the keys between a time and interpolating the angles as quat's between them. As noted in the code the algorithm needs to handle the case when the x,y,z Rotation keys all aren't at the same time which was not handled by Matinee. Also like Matinee, when in quaternion interoplation mode, we need to not display the function cuves since the interpolated and key values are now all different. (Would like to show them but that's a bigger refactor for perhaps just a one off needed by quaternions). I added a virtual function UMovieSceneSection::ShowCurveForChannel for this since it needs to be dynamic, not on construction of IKeyArea's, and could be useful for other sections. I could though move the method to just UMovieScene3DTransformSection and do a cast instead. Looked into doing a unit test for this but after talking with Andrew P we will work on doign an automated test in EngineQA since that will provide more coverage. Will also add a video the jira. #jira UESEQ-403 Change 4010713 by Mike.Zyracki Added option to key a group of transform channels instead of just the changed channel, or all of them. This is useful for quaternion interpolations where you want rotation keys to be aligned but also useful for other workflows like animating FK Pose to Pose. Change 4010715 by Andrew.Porter MediaFrameworkTest: Setting LogMediaUtils logging from VeryVerbose to Verbose to cut back on the spam Change 4013048 by Max.Chen Sequencer: Fix play/jump status. Update the player status for all position methods (Scrub, Jump, Play). Jump means Stopped. Correctly use PlayTo or JumpTo based on position method. In PlayInternal, JumpTo with the Stopped state (rather than playing state). #jira UE-57844 Change 4013479 by andrew.porter QAGame: Added content in TM-SequenceRecorder to test recording a property on a Cine Camera Component; Press 3 to trigger manual focus distance to increment on a timer Change 4014323 by Max.Chen Sequencer: Fix SetPlaybackPosition so that it jumps or plays based on playback status. #jira UE-57844 Change 4015888 by Max.Chen Sequencer: Fix crash on paste. UMovieSceneSections were gathered from the track node's track. For sub track mode, we want to gather only those sections on that track node row. #jira UE-57951 Change 4015943 by Max.Chen Sequencer: Fix moving shots up when the mouse pos goes outside of the virtual track area. #jira UE-57717 Change 4016293 by Max.Chen Sequencer: Fix relative frame playback end frame calculation so that custom start/end frames remain in the space of the sequence and are not relative. #jira UE-57308 Change 4017075 by Andrew.Rodham Sequencer: Corrected initial evaluation range used when calling UMovieSceneSequencPlayer::Play() Change 4017270 by Christina.TempelaarL Sequencer: FCPXML importer and movie scene capture - Use CeilToFrame when converting section start/end frame times to frame numbers in FCPXML and movie scene capture. - Added support for clip metadata in FCPXML. - Got rid of redundant TokenizedError message class, no longer needed now that FCPXML is in editor directory. - Added log messages currently commented out due to exception, still testing. #UESEQ-358 Change 4018370 by Christina.TempelaarL Sequencer: fixed FCPXML log messages regarding sections with start/end not divisible by display rate. #UESEQ-358 Change 4018378 by Christina.TempelaarL Sequencer: fixed error in previous changelist. #UESEQ-358 Change 4019457 by Max.Chen Sequencer: Show event names only when the event track is selected #jira UE-57897 Change 4022806 by Max.Chen Sequencer: Fix crash on movie scene capture dialog shutdown if movie capture wasn't even started. #jira UE-58106 Change 4022894 by Max.Chen Sequence Recorder: Wrap OpenEditorForAssets after sequence recording within GIsEditor #jira UE-58084 Change 4024487 by Max.Chen Sequencer: Add tooltip for quat interpolation #jira UE-58113 Change 4024562 by Max.Chen Sequencer: Change path/attach track sequence binding id to currently focused sequence id so that bindings can be created in subsequences Change 4027414 by JohnHenry.Carawon QAGame: Checking in content that shows a bug with using particles systems and Delay Before Shot Warm Up. Change 4028990 by Max.Chen Sequencer: Fix evaluate sub sequences in isolation. This check was added with the compile on the fly logic. Not sure why it was necessary but it seems like the sub sequence data needs to be updated in order to evaluate sub sequences in isolation. #jira UE-58184 Change 4029004 by Max.Chen Sequencer: Ensure that old binding references are removed when re-assigning actors in sequencer #jira UE-57898 Change 4030997 by JohnHenry.Carawon QAGame: Fixing name of the master sequence Change 4031785 by Michael.Karambelas QAGame: Added an instance of ThirdPerson Run to TM-SequenceRecorder for Record to Possessable test. Change 4035548 by Andrew.Rodham Sequencer: Changed FMovieSceneEvaluationTemplate::TemplateSignature to be a serial number to address non-deterministic cooking issues - This commit is related to the repro steps found in 3914599 and 3934307, both of which have been verified with this new change. - Copy of 4031684 from //Fortnite/Main/... #jira FORT-84852 Change 4036312 by Max.Chen Sequencer: Fix zoom view range so that it uses the passed in InZoomDelta Change 4036318 by Max.Chen Sequencer: Auto size now returns a range and defaults to the channel proxy range so that keyed regions can also be autosized. Change 4036322 by Max.Chen Forgot missing change Change 4036360 by Max.Chen Sequencer: Fix play rate calculation when skeletal animation section play rate changes. Change 4037163 by Mike.Zyracki Weighted Tangent Implementation Tricky thing is that you need to solve a cubic in order to get the bezier weights for the time part of the curve. See https://www.gamedev.net/forums/topic/474094-help-function-curves-for-animation-interpolation/ Maya provides an implementation in it's dev kit but I didn't use it since it was horribly slow and uses an iterative solution to solve the cubic needed. Instead I use an old algorithm (Cardano's method), to solve the cubic which should be much faster. Though relative simple to code from principles I just went ahead and used a version from Graphics Gems 1. I put this cubic solver directly in MovieSceneFloatChannel.cpp, but will need to move it when we support Rich Curve, maybe to FMath:: (which would probalby require some other functions for solving quartics, etc.. for completeness.). Also note we resolve this on every evaluation but dont' need to if the interval the time is evaluating hasn't had any change in values or tangents. So again when we support FRichCurve we can create a Weighted Evaluating class that can hold the cache. Also with the tangent drags I got rid of the Cardinal position that was used to calculate non-weight tangents from the key point and just quickly getting a direction. With weighted tangents we need to use the delta instead (otherwise when moving multiple they would all get the same weight based upon distance to the cardinal point. ) For mixed tangents types what I'm defaulting to non weighted if the interval doesn't match. May need to do weighted instead, not sure. What's left is just FBX import, for tomorrow. #jira UESEQ-76 Change 4037435 by Mike.Zyracki Fix fo build warnings from weighted tangent submission. #trivial Change 4038091 by Michael.Karambelas QAGame: Updated a Sequence Recorder group in TM-SequenceRecorder that had an actor missing the animation. Change 4038374 by Andrew.Rodham Sequencer: Refined scrubber styling for level sequences and actor sequences - Scrubber now shows a block the width of a dsplay rate frame, plus a line for the actual evaluated time. UMG reverts back to the previous styling (no block) - Keys that are outside of the playback range are now drawn with a subdued effect - Tick labels are no longer drawn when directly underneath the scrubber Change 4038490 by Max.Chen Sequencer: Expose tangent weight values in details panel. Change 4038620 by Andrew.Rodham Sequencer: Advanced time panel polish #jira UESEQ-426 Change 4038677 by Max.Chen Movie Scene Capture: Redirector for MovieSceneTools.AutomatedLevelSequenceCapture #jira UE-58248 Change 4039739 by Max.Chen Sequencer: Media track should only be supported by Level Sequence Change 4040024 by JohnHenry.Carawon QAGame: Fix EventReciever and OverrideBinding example The level sequence was set to none so the fix was to set it back to TrackEvaluation_Master. Change 4040610 by Andrew.Rodham Curve Editor: Moved weighted tangent switchers to a single toggle command (CTRL+W) and added an icon #jira 58383 Change 4040882 by Mike.Zyracki Keep broken when turning on weighted #jira UE-58435 Change 4041089 by andrew.porter QAGame: Sequence for Long Tangents bug Change 4041498 by Mike.Zyracki Turn off weighted when going auto to prevent large tangents. Do it both in UI and when doing AutoSetTangents() to really make sure it doesn't happen. #jira UE-58452 Change 4041752 by andrew.porter MediaFrameworkTest: Adding some better logging for setting rates when not supported. Also ignoring commiting URL when there is no text Change 4041896 by Matt.Hoffman The transform dialog box now transforms selected keys and sections, instead of just keys. #jira UE-58265 [CL 4044405 by Max Chen in Main branch]
2018-05-02 10:10:00 -04:00
CurrentTime = FDateTime::UtcNow();
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 4044339) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3947021 by Max.Chen Sequencer: Don't preserve root component when copying object properties. A spawnable empty actor, has a root component that is generated by the empty actor factory. If the object template's root component is preserved when copying from the spawnable empty actor, the root component will not be copied over. Therefore, we need to NOT preserve the root component when copying object properties. #jira UE-55825 Change 3947366 by Max.Preussner WmfMedia: Better log output Change 3947367 by Max.Preussner MfMedia: Better detection of compressed format properties on Windows Change 3949102 by Max.Chen Sequencer: Remove SequenceActorTag when converting to possessable. #jira UE-56206 Change 3949207 by andrew.porter EngineTest: Set the screenshot nodes resolution to 1280x720 Change 3949404 by Max.Chen Sequencer: More informative tooltip for "Rerun Construction Scripts" option. It now says "Rerun construction scripts every frame on actors that have 'Rerun Construction Script in Sequencer' enabled in their class settings". Change 3950067 by Matt.Hoffman Renamed UAutomatedLevelSequenceCapture's StartFrame and EndFrame to CustomStartFrame/CustomEndFrame to reflect that it is user-overriden. This will also resolve upgrade issues due to the variable datatype changing. #jira UE-56189 Change 3950193 by JohnHenry.Carawon Updating my latest MovieRendering test content. Change 3950757 by JohnHenry.Carawon More updates to MovieRendering test content Change 3952059 by Max.Chen Resave LevelVisibility_SubLevels to fix data loss conversion warning of OpacityMaskConstant #jira UE-56086 Change 3952283 by Max.Chen Sequencer: Disable dropping level sequence assets as spawnables. #jira UE-56120 Change 3952422 by Max.Chen Sequence Recorder: Add button to record from the current player. #jira UE-55942 Change 3952987 by JohnHenry.Carawon MovieRendering Test Content - Fixing camera bindings and changing the override binding actor Change 3953823 by Mike.Zyracki Fix for Bad FBX Import Tangents not scaled by frame rate. After looking at this again it seems that a set of MovieScene:: overiddes for the channel traits wasn't set correctly, so use the ADL idiom to use MovieScene, which can then call Optimize in the correct namespace. With this we can now correctly use the passed in tolerance. There was also a redundant set of Optimize calls so that it could happen twice so removed them, and needed an extra check in the float channel Optimize. Also since we need to set auto tangents no matter if we optimize we don't set that parameter(though leave it since it's used by context menu key reduction). Finally fixed speed issue with trajectories caused by calculating way too many substeps. Reverted back to a time based step size for consistency. #jira UE-56193 Change 3954317 by Matt.Hoffman Adding a key to the last frame of a section no longer causes a crash. Keys can already be moved to be on the last frame of a section so now you can just add a key there directly. #jira UE-56255 Change 3954326 by Matt.Hoffman Dilating a section that is only infinite on one side no longer causes a crash. #jira UE-56260 Change 3954486 by Max.Chen PR #4580: Exposes IsReversed() from UMovieSceneSequencePlayer (Contributed by alanedwardes) Change 3955238 by Max.Preussner Messaging: Enabled delayed message routing https://github.com/EpicGames/UnrealEngine/pull/4574 #jira UE-56247 Change 3955901 by Max.Preussner MediaFrameworkTest: Added developer test for overriding desired media player plug-in at runtime. Change 3955922 by Andrew.Porter QAGame: Updating movie rendering content in dev folder Change 3956004 by andrew.porter QAGame: Adding MPC track to movie rendering test content Change 3956510 by Max.Chen Sequencer: Fix fbx camera import of static properties so that they are imported before default tracks are created. Otherwise, the default tracks inherit the default properties of the camera, rather than the values from the fbx. #jira UE-56311 Change 3957613 by Max.Preussner MediaUtils: Added code documentation to media player facade Change 3958005 by Max.Preussner MediaUtils: Added method to get number of sinks Change 3958934 by Max.Chen Sequencer: Fix keys getting added and sequence getting erroneously re-evaluated when auto key is off. Only apply defaults if there are no keys. Only modify the movie scene section before creating keys or setting defaults. #jira UE-55903 Change 3959687 by Andrew.Rodham Sequencer: Fixed visibility track external values being inverted #jira UE-56324 Change 3960507 by Max.Preussner Core: Fixed incorrect rounding in FMath::DivideAndRoundNearest Change 3962047 by JohnHenry.Carawon MovieRendering Test Content Changes: - Add Lightmass Importance Volumes to sublevel to fix warnings - Rebuilt Lighting - Add a third sequence for Gamut testing - Resaved the sound master.uasset to fix warning Change 3962211 by Mike.Zyracki Add Frame Numbers to selected animation sections. Added MapTimeToAnimation to MovieSceneSkeletalAnimation so that we could get it from the Skeleton Animation track Editor. Since the thickness of the frame line can change based upon frame rate and zoom we need to calculate it similarly to how the time slider controller does it. Those calculations were private so we had to expose FScrubRangeToScreen and GetScubberPixelRange from the TimeSliderController. Also needed to know if the section itself was selected so added a bIsSelected flag to the section Painter. Also fixed a bug where you couldn't add a section if other sections existed at different times in MovieScenePropertyTrack and could crash due to the check(). #jira UESEQ-395 Change 3962497 by Max.Preussner Core: Added new string formatting argument to FTimespan Change 3963662 by Max.Chen CineCamera: Flip VistaVision width and height. Change 3963731 by Max.Preussner MediaCompositing: Implemented sequence recording support for media track Change 3964195 by Andrew.Rodham Sequencer: Set inverted property correctly for newly created visibility track sections - Also clamp evaluation for key editors to the bounds of the section so we're not displaying values outside of the section bounds when the cursor is not on the bounds #jira UE-56324 #coderevew Max.Chen Change 3964196 by Andrew.Rodham Sequencer: Fixed crash when attempting to render sections that resulted in a negative intersection with the view range Change 3964275 by Andrew.Rodham Sequencer: Fixed MovieScene::ClampToDiscreteRange for infinite range bounds Change 3964364 by Andrew.Rodham Curve Editor: Reduce minimum vertical view range when zooming to fit Change 3965091 by Max.Chen Sequencer Recorder: Refresh next sequence if empty when starting a recording, otherwise, use existing name. #jira UE-56469 Change 3965148 by Max.Chen Sequence Recorder: Move Record to Possessable to "Actor Recording" group Change 3965162 by Max.Chen Sequence Recorder: Always break out of immersive mode when done recording, even when stopping recording during countdown. #jira UE-56407 Change 3965214 by Max.Preussner QAGame: Enabled ImagePlate plug-in Change 3965574 by Max.Preussner SimpleComposure: Reorganized & upgraded content to work with new Media Track #jira UE-56488 Change 3965651 by Max.Preussner MediaCompositing: Ignoring seek-on-open if media not seekable Change 3966075 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Export functionality #jira UESEQ-358 Change 3966087 by Matt.Hoffman Adding a single key to the Particle Toggle track now makes an infinite range section that is displayed in the UI. #jira UE-56295 Change 3966547 by Andrew.Rodham Sequencer: Fixed rounding errors when drawing the section background on boolean sections - Logic was using time in sectonds which caused rounding errors on evaluation and flickering red/green stripes when dragging keys around #jira UE-56324 Change 3966563 by Andrew.Rodham Curve Editor: Key editor interface improvements - SKeyEditInterface has a few problems - it does not update in real time when editing properties, and does not support multi-edit which makes it unsuitable for use with the curve editor - We now take a different approach for editing keys by gathering a set of proxy UObjects for each key that is currently selected. These objects are added as top level objects to the details panel which means they support multi edit as you'd expect from any other details panel in the editor. - Proxy objects are updated every tick for the curve editor if they implement the ICurveEditorKeyProxy interface, which allows them to refresh their current value. - Ideally, the same mechanisms would be used in the main sequence interface, and we would be generating the proxy classes at runtime based on the key value type, but that work remains a separate task from this initial offering. #jira UE-56165 Change 3966564 by Andrew.Rodham Curve Editor: Expand to frame when adding or moving keys in the curve editor Change 3967051 by andrew.porter MediaFrameworkTest: Set the CameraPlayer_Video texture to auto clear Change 3967141 by Andrew.Rodham Sequencer: Keep track of spawned objects that have been modified and only re-save such object's default spawnable state on destruction - Now that we're taking this approach, I've remove serveral redundant bits of functionality in the spawn register such as making some spawnables read-only, and the PreSave binding for Sequencer. - We now hook into all object pre-saves to make sure we handle the case where the sequences are saved through the content browser or elsewhere. #jira UE-47686 Change 3967170 by Andrew.Rodham Sequencer: Added the ability to possess anim instances as object bindings - This allows full and direct animation of properties on UAnimInstance, and animation blueprints - Object Bindings are made by first possessing a skeletal mesh component, then choosing the + Add button where its anim instance will be listed - Added a new function to UMovieSceneSequence to gather previously cached objects that should now be invalidated. Anim instances will be re-resolved if a new UAnimInstance is assigned to USkeletalMeshComponent::GetAnimInstance. - ObjectBindingIDs for anim instances are just represented by an entry in a set of GUIDs. We only ever resolve such bindings through USkeletalMeshComponent::GetAnimInstance. - Only currently supported on LevelSequences #jira UE-56132 Change 3967195 by Max.Preussner Core: Updated TRangeSet to use TCallTraits Change 3967345 by JohnHenry.Carawon Test Content Changes - first iteration of spacing out the examples in the shots. Change 3967572 by Max.Chen Sequencer: Fix setting PreviousPlayEvalPosition until after we've tested whether it's set. #jira UE-56518 Change 3967750 by Max.Chen Audio: Set duration based on number of input channels, rather than number of channels to serialize. This fixes an issue where audio split into 2 channels is set to a duration that's twice as long. #jira UE-56430 Change 3967836 by Max.Chen Sequencer: Allow for animating array elements within ustruct properties #jira UE-55887 Change 3968506 by Matt.Hoffman Fixed ambiguous conversions for seconds and frames being overriden by ambiguous conversion to Timecode (in frames). Change 3968748 by Max.Chen Sequencer: Make the event properties submenu widget larger. #jira UE-55557 Change 3968862 by Max.Chen Sequencer: Recursive expansion when shift is down #jira UE-52139 #pr 4194 Change 3968863 by Max.Chen Sequencer: Bind rename command to selected track so that F2 shortcut start renaming #jira UE-52139 #pr 4194 Change 3968872 by Max.Chen Sequencer: Rekey the selected key at the current time. #jira UESEQ-396 Change 3968938 by Max.Chen Cine Camera: Add option to toggle the behavior of locking the rail mount to the orientation of the spline. By default, the option is off, no change in behavior. #jira UE-55815 Change 3968958 by Andrew.Rodham Sequencer: Consider vertical position when hittesting keys #jira UE-56256 Change 3969643 by Max.Preussner Core: Rounding timespans created from double values towards nearest ticks Change 3969646 by Max.Preussner MediaUtils: Implemented timeout mechanism for block-on-fetch feature Change 3969776 by Mike.Zyracki Added Skip Anim Notifiers Toggle per what was in Matinee. Investigated the Enable Root Motion toggle as also discussed but it's implementation is directly contained by the animation asset and unlike animation notifies there seems to be no exposure to interactively disable it during a playback tick. Note if we are generating thumbnails we still automtically disable notifies in the editor to avoid annoying noise playback. Note that if Enable Root Motion/Root locked is specified in the animation asset it does correctly effect the Sequencer. #jira UESEQ-399 Change 3969835 by Matt.Hoffman Playback Range and Selection Range use unified logic for adding themselves as potential snap locations which properly handles inclusive/exclusive bounds. This resolves an issue where having an unset selection range caused a potential snap location to be added on frame 0 and 1 (internal resolution) which caused a misalignment when placing objects near frame 0. This also removes the one frame offset on setting Selection Range to bring behavior inline with other ranges. #jira UE-55420 Change 3969885 by Max.Preussner MediaAssets: Don't register media player CDO with media ticker Change 3971129 by Andrew.Rodham Sequencer: Fixed UMovieSceneSequencePlayer::GotToEndAndStop() not taking into account for start time This is a remnant from when the times were always specified in 0-duration space, rather than actual sequence times. Change 3972056 by JohnHenry.Carawon More updates to Test Content. I continued spacing out the examples in the sequence so that they have a consistent number of frames between each example and during the start/end of the example. Also removed the Marcie sublevel. Change 3972066 by Andrew.Porter MediaFrameworkTest: Setting Marcie folder to be never cooked in package settings Change 3972675 by Matt.Hoffman Splitting Subsequence Sections no longer sets an incorrect playback range on the subsequence when the subsequence has a different internal resolution than the owning sequence. #jira UE-55453 Change 3973376 by Max.Preussner ImgMedia: Zero is the only valid video track for image sequences Change 3973489 by Max.Preussner Launch: Build rules cleanup pass - don't use Media, MediaUtils on server apps - don't link against Media (include-only dependency) - don't include from MediaAssets (dynamic load only) Change 3973760 by Max.Preussner MediaUtils: Moved AppMediaTimeSource implementation into its own file; added logging Change 3973765 by Max.Preussner ImgMedia: Disallowing seek beyond media length Change 3973855 by Max.Preussner MediaFrameworkTest: Updated developer test content Change 3973858 by Max.Preussner MediaCompositing: Blocking on media player time instead of media sample time (the former may not be hit in the current frame) Change 3974988 by Max.Chen Sequencer: Fix trim left so that it also sets the start offset for audio and skeletal animation sections. #jira UE-57015 Change 3976101 by Matt.Hoffman Sequencer will now focus the scroll view on newly created items. #jira UE-56492 Change 3976203 by Max.Chen Property Editor: Add DetailsViewArgs for ColumnWidth. Defaults to 0.65f, no change in existing behavior. Change 3976205 by Max.Chen Sequencer: Set better column widths for sequencer. #jira UE-55557 Change 3976206 by Max.Chen Sequencer: Added menu category for import/export Change 3976265 by Matt.Hoffman Tracks within Object Binding Nodes will now sort using the old behavior so that components are added above other track types. #jira UE-56473 Change 3976901 by Max.Chen Sequencer: Add event names to event track section #jira UESEQ-353 Change 3977878 by Max.Preussner Media: Moved media framework ticking stats into Media module Change 3977982 by Max.Chen Sequencer: Add Edit->Reset section length to duration of source (ie. audio, skeletal animation, shot length) Added MovieSceneSection::GetDefaultDuration and MovieScene::HasDefaultDuration #jira UESEQ-392 Change 3977994 by Max.Preussner Media: Fetching and rendering media samples before viewports are rendered (to ensure frame sync for in-level media playback) #jira UE-53975 Change 3978188 by Matt.Hoffman Easing Curves are now clipped by the sequence's PlayRange when testing against an infinite section. This causes blended sequences to finish their blend when the section starts/ends instead of always using 25% of the total section length to determine default blend range. #jira UE-56362 Change 3978676 by Max.Preussner MediaCompositing: Fixed first frame of rendered out media track missing #jira UE-53975 Change 3978684 by Max.Preussner MediaCompositing: Enabled media track frame sync feature #jira UE-53975 Change 3980026 by Matt.Hoffman Keys can be selected on folded out sections (such as an audio track expanded to show volume and pitch) again. #jira UE-57169 Change 3981614 by Max.Preussner MediaUtils: Added missing subtitle sample queue flush Change 3982311 by Max.Preussner MediaCompositing: Added safeguard for zero length media sources Change 3982389 by andrew.porter QAGame: Adding media track test content into FrameAccuracySubscene Change 3983661 by Max.Chen Sequencer: Add level name to spawn a spawnable into. Add sublevel menu option to set the level #jira UESEQ-390 Change 3983712 by Andrew.Rodham Sequencer: Purge legacy blueprint spawnables from LevelSequence packages #tests Ran a preflight for cooking fortnite, ocean and Orion. Only orion shows up this edge case, and will require a re-save of the EndCines level #jira UE-39173 Change 3983787 by Max.Preussner MediaCompositing: Moved compile time switch for block-on-fetch into media player facade Change 3983812 by Andrew.Rodham Sequencer: Exposed default level sequence instance data to blueprints Change 3984373 by Max.Preussner Media: Added API for quering whether player plug-in supports block on fetch Block on fetch allows Sequencer and other systems to block the game thread until a desired video frame has been decoded. Change 3984670 by JohnHenry.Carawon Movie Rendering Test Content progress. Saving the state of the content. There is a bug where things got replaced with particle emitters and I think it was because I tried to copy paste an animation track into a separate skeletal mesh track. Change 3985097 by Max.Chen Sequencer: Rename Reset to AutoSize Change GetAutoSizeDuration to return TOptional<FFrameTime> #jira UESEQ-392 Change 3986043 by Max.Chen Sequencer: Fix crash when attach/path duration is less than 0. #jira UE-57310 Change 3986373 by Max.Chen Sequencer: Add support for deleting tracks and channels which equates to setting the channel mask. #jira UE-52951 Change 3986375 by Max.Chen Sequencer: Add Create Pose Asset to skeletal animation section. This allows animators to blend animations in sequencer and create new pose assets from them. #jira UESEQ-408 Change 3986796 by Andrew.Rodham Sequencer: Fixed stale object references remaining in ULevelSequence::BindingReferences when using convert to spawnable/possessable - We used to convert objects by creating a new binding, then re-assigning its GUID, which meant we didn't have to do any further object fixup, but the code to achieve this was confusing and led to a vulnerability where object references would not be cleaned up correctly due to the newly created possessable essentially being a temporary object that's immediately thrown away. - To address this, there is now a function for porting all the contents of one object binding to another, and handles the correct fixup required for parent/child object bindings for both spawnables and possessables. - Also added codepath to remove any stale object references from the level sequence reference map on PostLoad (this piggy-backs off the PurgeLegacyBlueprints object version which is close close enough to this change to be identical) #tests Verified that existing sequences with stale references get cleaned up on load. Verified that repreatedly converting from spawnable<->possessable cleans up references correctly. Change 3987807 by JohnHenry.Carawon Updates to the MovieRendering Test Content. - Fixed the spawnable actors that were overwritten - Shortend the Lighting example and combined the Intensity and Color tracks - Organized the Sequence and WorldOutliner to group the examples. Change 3988151 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. Change 3988880 by Max.Chen Sequencer: Support enter to add asset for all sequencer track editors that have asset pickers. #jira UE-57367 Change 3988953 by Max.Chen Sequencer: Make the track color picker focusable so that it will close when you click away or lose focus. #jira UE-57210 Change 3988962 by Max.Chen MovieSceneCapture: Fix EDL export so that it takes into account movie scene frame resolution and desired frame rate. #jira UE-57365 Change 3988964 by Max.Chen Movie Scene Capture: Clarified tooltip for bRelativeFrameNumbers. If you specify custom start/end frames for the recording, they will be relative to the playback range. #jira UE-57308 Change 3989442 by Max.Chen Fix CIS Change 3991548 by Matt.Hoffman Dragging the time slider no longer causes the time slider to ignore snap-to-interval with "Snap to Keys While Scrubbing" when no keys are in range. #jira UE-57417 Change 3991598 by Matt.Hoffman Snap to Key while scrubbing now mirrors the behavior of "jump to next key". When there are no tracks selected it snaps to all keys and when there are tracks selected it snaps to only keys from that track. This also resolves an issue where deleting an object did not remove it from the Sequencer's selection. Undoing a delete already doesn't seem to restore your selection, so removing it from your selection shouldn't change that behavior. #jira UE-57417 Change 3991603 by Max.Chen Sequencer: Disable EditAnywhere for some section properties #jira UE-53530 Change 3992240 by Max.Preussner MediaAssets: Implemented dynamic audio sample rate adjustment based on audio/media clock drift #jira FORT-70638 Change 3992911 by Andrew.Rodham Sequencer: Fixed saving spawnable state using the wrong spawned object - We now track the object binding ID so that we can apply the spawned object to the correct spawnable when the asset is saved #jira UE-57353 Change 3992914 by Max.Chen Movie Scene Capture: Fix compression quality not being set. The compression interface wasn't being found through query interface, so no compression was being set. Reworked finding it through the output pins. Tested running various compression values. #jira-UE-55488 Change 3992919 by Max.Chen Sequencer: Convert to possessable now uses object template instead of copying properties (ie. see LevelSequenceActorSpawner). This fixes MIDs getting lost when converting to spawnable and back to possessable. #jira UE-52400 Change 3993184 by Max.Chen Sequencer: Don't show +Transform/+Path/+Attach track if the actor has the "Mobility" property hidden. Set the Landscape, LandscapeProxy and InstancedFoliage "Mobility" property to be hidden since it is static is not supposed to be dynamically movable. #jira UE-56347 Change 3993238 by Max.Chen Sequencer: Test for hidden mobility in creating keys as well. Refactored to HasHiddenMobility() #jira UE-56347 Change 3993978 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. #jira UE-57489 Change 3994039 by Max.Chen Landscape: Add Mobility to hidecategories on landscape component #jira UE-56347 Change 3994626 by JohnHenry.Carawon Updated Movie Rendering Test Content. - Fixed the overridden spawnables to their proper object types. Change 3994653 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Import functionality, improved Export functionality #jira UESEQ-358 Change 3995609 by Max.Chen UMG: Add support for 2d transform mask (translation, rotation, scale, shear) #jira UE-52951 Change 3995778 by JohnHenry.Carawon Movie Rendering Test Content Updates - Adjusted Lights example - Adjusted Camera example - Added Marcie sublevel back in Change 3995942 by JohnHenry.Carawon QAGame: Moving Movie Rendering test content from Developer folder to Sequencer folder Also adjusted level visibility, lights and camera example. Change 3995993 by Christina.TempelaarL Sequencer: FCPXML Export updates - only export sections if in playback range and media exists, warn if media does not exist. Other updates - removed unused methods and variables, fixed message context naming to be more accurate #jira UESEQ-358 Change 3996595 by andrew.porter QAGame: Updating Marcie content in TrackEvaluation level to use Image Plate Change 3996614 by andrew.porter QAGame: Adding color test sequence to the sublevel Change 3996643 by Max.Chen Sequencer: Fix fbx animation export - rotation and scale channels were flipped. #jira UE-57509 #jira UE-57512 #jira UE-57514 Change 3996652 by Max.Preussner Messaging: Fixed delayed messaging using incorrect current time after message router sleep Based on https://github.com/EpicGames/UnrealEngine/pull/4601 Change 3996801 by Max.Chen Sequencer: Fix folder active state for non key area sections. Look at track node sections as well as key areas. #jira UE-57550 Change 3997098 by Matt.Hoffman Cleaned up some remaining ToDo's in STimeRange. Change 3998339 by Max.Preussner Sockets: Added documentation for socket receive functions Change 3998359 by Max.Preussner MediaUtils: Started to implement media recorder helper class Currently only supports BGRA frames in CPU memory. Supporting other formats and buffer types will require conversions on render-thread. I recommend refactoring out the existing conversion code in FMediaTextureResource into a reusable helper class in the MediaUtils module. This should be a good starting point though. Change 3998417 by Matt.Hoffman Keys and Sections can now be moved at the same time inside of Sequencer. Keys can now snap to Sections (and vice versa) instead of just to other Keys. Sections can now be duplicated like keys can. #jira UE-56995 Change 3998427 by JohnHenry.Carawon QAGame: Updating test content for the Movie Rendering feature. - Added an auto activate particle to the beginning of the sequence (it's not part of the sequence at all) - Added an event receiver blueprint to the Events example - Added a particle emitter to both sublevels - Added a camera cut to the end that switches to a separate camera - The camera zoom in, focus and Look At sections are all separate (not overlapping in the sequence) - Added a second actor for the camera Look At - Added a Visibility section for the Actor Hidden In Game track that has possessable and spawnable cube and light Change 3998537 by Max.Chen Sequence Recorder: Restore immersive mode when stopping the sequence even if not in PIE. #jira UE-56407 Change 3999809 by Matt.Hoffman Removed the "Go To" box from Sequencer and instead placed the current time as an always visible control. The previous shortcut (Ctrl + G) now focuses the new widget directly. #jira UESEQ-376 Change 4000543 by Christina.TempelaarL Sequencer: Moving editor-only code from runtime module MovieSceneCapture to editor module MovieSceneTools. Moved EDL and FCP XML exporters as well as Automated Level Scene Capture. #jira UESEQ-358 Change 4000706 by Matt.Hoffman Entering multiple time strings without a number no longer crashes Sequencer. #jira UE-57672 Change 4001051 by andrew.porter MediaFrameworkTest: Fixing up some image sources pointing to the wrong location Change 4001191 by andrew.porter QAGame: Adding some quick EDL/XML test content to dev folder Change 4001243 by Max.Chen Sequencer: Fix import EDL out of range. #jira UE-57665 Change 4001856 by Matt.Hoffman Selecting keys and sections at the same time now also works with animation and audio sections. #jira UE-57716 Change 4002021 by Max.Chen Sequence Recorder: Fix sequence name incrementing. If external recording sets the sequence name, use it. Otherwise, use the recording name from the recording group or the recording settings. #jira UE-57712 Change 4002618 by Max.Chen Viewport: Update the look at location when updating to a locked actor. This fixes an issue so that popping the view out of a locked actor and manipulating the view will not jump to the previous look at location. #jira UE-57725 Change 4002979 by Matt.Hoffman Fixes several edge cases with the end time range that was causing confusion about what the last frame of the sequence was. Dragging the End Frame slider will no longer be off by one tick and jumping to the end via the UI controls now properly respects snapping and stays inside the play range instead of falling outside of it. Overall behavior does not change though and End Frame should be considered an exclusive frame so that frames 0-150 results in a 150 frame long animation (which is frames 0-149). #jira UE-56367 Change 4003185 by Matt.Hoffman Fixed a regression that prevented a section from being dragged upwards past row 0 which normally resulted in all other rows moving down. #jira UE-57717 Change 4003193 by JohnHenry.Carawon QAGame: Updates to test content - Shortened frames between the examples from 95 to 30 - Separated camera setting tracks - Lighting example now switches directly from constant red - green - blue Change 4003369 by Max.Chen Sequence Recorder: Refresh next sequence regardless of internally stored sequence name. #jira UE-55757 Change 4003586 by JohnHenry.Carawon QAGame: Test Content Updates - Level Visibility track now ends to that the levels are not visible when we move to the next example - Shortened camera section, removed Z tranform so that we just move left to right and shortened the overall length Change 4004414 by Max.Chen Movie Scene Capture: Fix regression where rendering with shot handles would only render the first shot. 3972166 addressed an issue where an extra frame would be rendered by finalizing right when the end frame was reached. This was hit on the first shot end frame, so instead, do this only for when the last shot is being rendered. #jira UE-57314 Change 4004765 by Christina.TempelaarL Sequencer: Fixed bugs in FCP XML import/export. - Export: fixed sequence default resolution. - Export: fixed XML files with no shots. - Export: all sections clipped to playback range. - Export: fixed incorrect section start/end times due to precision issues. - Import: fixed incorrectly adding cinematic tracks. - Import: fixed bugs creating new sections. #jira UE-57660 #jira UE-57662 #jira UE-57655 #jira UE-57761 Change 4005119 by Max.Chen Sequencer: Export/import at play rate Change 4005195 by Max.Chen UMG: Finish UMG evaluation on stop. Added object version so that existing UMG assets do not change. #tests - Newly created UMG animation with sections set to restore state now return to their original state. Existing UMG animations with sections set to restore state do not return to their original state. #jira UE-52285 Change 4005377 by Michael.Karambelas QAGame: Moving TM-SequenceRecorder and related content out of my developer folder and into /Content/Sequencer/SequencerRecorder/* Change 4005417 by Michael.Karambelas QAGame: Fixed a BP compiler in the Level Blueprint of TM-SequencerRecorder. Change 4005634 by Michael.Karambelas QAGame: Fix up missing content and broken level sequence in TM-SequenceRecorder after move Change 4006324 by Max.Chen Sequencer: Reset if the focused movie scene is null. This fixes a crash if the user is focused in on a shot and undo takes the user past the point of where the shot was created. #jira UE-57752 #jira UE-47661 Change 4007006 by Max.Chen Sequencer: Fix FindAvailableRowIndex so that it returns the max row index (and not +1) since it doesn't find any conflicting rows. #jira UE-57717 Change 4007907 by Max.Chen Sequencer: Fix crash if there's no animation Change 4007948 by andrew.porter QAGame: added test content to dev folder for Record World Space Change 4008636 by Max.Chen Sequencer: Fix import fbx not setting values properly and creating additional cameras unncessarily. #jira UE-57864 Change 4008759 by Max.Chen Sequencer: Follow up fix for import cameras #jira UE-57864 Change 4009994 by Matt.Hoffman Dragging the left or right handles of the Time Range slider in Sequencer will now zoom your view in on the current center of the screen. This prevents the view from being translating as you tried to zoom in which caused issues at high zoom levels. #jira UESEQ-407 Change 4010169 by Christina.TempelaarL Sequencer: FCP XML fixes. - FCP XML export - no longer clips to playback range - FCP XML and EDL export - fixed missing last frame of some sections after exporting to Premiere. - Automated level capture, EDL export - use RoundToFrame instead of FloorToFrame for computing section start/end frames after frame rate conversion. #jira UE-57802 - partial fix, movie scene capture still needs to render full section rather than clip against playback. Change 4010287 by Mike.Zyracki Add quaternion interpolation option to UMovieScene3DTransformSection. This mimics how Matinee used to work by bascially finding the keys between a time and interpolating the angles as quat's between them. As noted in the code the algorithm needs to handle the case when the x,y,z Rotation keys all aren't at the same time which was not handled by Matinee. Also like Matinee, when in quaternion interoplation mode, we need to not display the function cuves since the interpolated and key values are now all different. (Would like to show them but that's a bigger refactor for perhaps just a one off needed by quaternions). I added a virtual function UMovieSceneSection::ShowCurveForChannel for this since it needs to be dynamic, not on construction of IKeyArea's, and could be useful for other sections. I could though move the method to just UMovieScene3DTransformSection and do a cast instead. Looked into doing a unit test for this but after talking with Andrew P we will work on doign an automated test in EngineQA since that will provide more coverage. Will also add a video the jira. #jira UESEQ-403 Change 4010713 by Mike.Zyracki Added option to key a group of transform channels instead of just the changed channel, or all of them. This is useful for quaternion interpolations where you want rotation keys to be aligned but also useful for other workflows like animating FK Pose to Pose. Change 4010715 by Andrew.Porter MediaFrameworkTest: Setting LogMediaUtils logging from VeryVerbose to Verbose to cut back on the spam Change 4013048 by Max.Chen Sequencer: Fix play/jump status. Update the player status for all position methods (Scrub, Jump, Play). Jump means Stopped. Correctly use PlayTo or JumpTo based on position method. In PlayInternal, JumpTo with the Stopped state (rather than playing state). #jira UE-57844 Change 4013479 by andrew.porter QAGame: Added content in TM-SequenceRecorder to test recording a property on a Cine Camera Component; Press 3 to trigger manual focus distance to increment on a timer Change 4014323 by Max.Chen Sequencer: Fix SetPlaybackPosition so that it jumps or plays based on playback status. #jira UE-57844 Change 4015888 by Max.Chen Sequencer: Fix crash on paste. UMovieSceneSections were gathered from the track node's track. For sub track mode, we want to gather only those sections on that track node row. #jira UE-57951 Change 4015943 by Max.Chen Sequencer: Fix moving shots up when the mouse pos goes outside of the virtual track area. #jira UE-57717 Change 4016293 by Max.Chen Sequencer: Fix relative frame playback end frame calculation so that custom start/end frames remain in the space of the sequence and are not relative. #jira UE-57308 Change 4017075 by Andrew.Rodham Sequencer: Corrected initial evaluation range used when calling UMovieSceneSequencPlayer::Play() Change 4017270 by Christina.TempelaarL Sequencer: FCPXML importer and movie scene capture - Use CeilToFrame when converting section start/end frame times to frame numbers in FCPXML and movie scene capture. - Added support for clip metadata in FCPXML. - Got rid of redundant TokenizedError message class, no longer needed now that FCPXML is in editor directory. - Added log messages currently commented out due to exception, still testing. #UESEQ-358 Change 4018370 by Christina.TempelaarL Sequencer: fixed FCPXML log messages regarding sections with start/end not divisible by display rate. #UESEQ-358 Change 4018378 by Christina.TempelaarL Sequencer: fixed error in previous changelist. #UESEQ-358 Change 4019457 by Max.Chen Sequencer: Show event names only when the event track is selected #jira UE-57897 Change 4022806 by Max.Chen Sequencer: Fix crash on movie scene capture dialog shutdown if movie capture wasn't even started. #jira UE-58106 Change 4022894 by Max.Chen Sequence Recorder: Wrap OpenEditorForAssets after sequence recording within GIsEditor #jira UE-58084 Change 4024487 by Max.Chen Sequencer: Add tooltip for quat interpolation #jira UE-58113 Change 4024562 by Max.Chen Sequencer: Change path/attach track sequence binding id to currently focused sequence id so that bindings can be created in subsequences Change 4027414 by JohnHenry.Carawon QAGame: Checking in content that shows a bug with using particles systems and Delay Before Shot Warm Up. Change 4028990 by Max.Chen Sequencer: Fix evaluate sub sequences in isolation. This check was added with the compile on the fly logic. Not sure why it was necessary but it seems like the sub sequence data needs to be updated in order to evaluate sub sequences in isolation. #jira UE-58184 Change 4029004 by Max.Chen Sequencer: Ensure that old binding references are removed when re-assigning actors in sequencer #jira UE-57898 Change 4030997 by JohnHenry.Carawon QAGame: Fixing name of the master sequence Change 4031785 by Michael.Karambelas QAGame: Added an instance of ThirdPerson Run to TM-SequenceRecorder for Record to Possessable test. Change 4035548 by Andrew.Rodham Sequencer: Changed FMovieSceneEvaluationTemplate::TemplateSignature to be a serial number to address non-deterministic cooking issues - This commit is related to the repro steps found in 3914599 and 3934307, both of which have been verified with this new change. - Copy of 4031684 from //Fortnite/Main/... #jira FORT-84852 Change 4036312 by Max.Chen Sequencer: Fix zoom view range so that it uses the passed in InZoomDelta Change 4036318 by Max.Chen Sequencer: Auto size now returns a range and defaults to the channel proxy range so that keyed regions can also be autosized. Change 4036322 by Max.Chen Forgot missing change Change 4036360 by Max.Chen Sequencer: Fix play rate calculation when skeletal animation section play rate changes. Change 4037163 by Mike.Zyracki Weighted Tangent Implementation Tricky thing is that you need to solve a cubic in order to get the bezier weights for the time part of the curve. See https://www.gamedev.net/forums/topic/474094-help-function-curves-for-animation-interpolation/ Maya provides an implementation in it's dev kit but I didn't use it since it was horribly slow and uses an iterative solution to solve the cubic needed. Instead I use an old algorithm (Cardano's method), to solve the cubic which should be much faster. Though relative simple to code from principles I just went ahead and used a version from Graphics Gems 1. I put this cubic solver directly in MovieSceneFloatChannel.cpp, but will need to move it when we support Rich Curve, maybe to FMath:: (which would probalby require some other functions for solving quartics, etc.. for completeness.). Also note we resolve this on every evaluation but dont' need to if the interval the time is evaluating hasn't had any change in values or tangents. So again when we support FRichCurve we can create a Weighted Evaluating class that can hold the cache. Also with the tangent drags I got rid of the Cardinal position that was used to calculate non-weight tangents from the key point and just quickly getting a direction. With weighted tangents we need to use the delta instead (otherwise when moving multiple they would all get the same weight based upon distance to the cardinal point. ) For mixed tangents types what I'm defaulting to non weighted if the interval doesn't match. May need to do weighted instead, not sure. What's left is just FBX import, for tomorrow. #jira UESEQ-76 Change 4037435 by Mike.Zyracki Fix fo build warnings from weighted tangent submission. #trivial Change 4038091 by Michael.Karambelas QAGame: Updated a Sequence Recorder group in TM-SequenceRecorder that had an actor missing the animation. Change 4038374 by Andrew.Rodham Sequencer: Refined scrubber styling for level sequences and actor sequences - Scrubber now shows a block the width of a dsplay rate frame, plus a line for the actual evaluated time. UMG reverts back to the previous styling (no block) - Keys that are outside of the playback range are now drawn with a subdued effect - Tick labels are no longer drawn when directly underneath the scrubber Change 4038490 by Max.Chen Sequencer: Expose tangent weight values in details panel. Change 4038620 by Andrew.Rodham Sequencer: Advanced time panel polish #jira UESEQ-426 Change 4038677 by Max.Chen Movie Scene Capture: Redirector for MovieSceneTools.AutomatedLevelSequenceCapture #jira UE-58248 Change 4039739 by Max.Chen Sequencer: Media track should only be supported by Level Sequence Change 4040024 by JohnHenry.Carawon QAGame: Fix EventReciever and OverrideBinding example The level sequence was set to none so the fix was to set it back to TrackEvaluation_Master. Change 4040610 by Andrew.Rodham Curve Editor: Moved weighted tangent switchers to a single toggle command (CTRL+W) and added an icon #jira 58383 Change 4040882 by Mike.Zyracki Keep broken when turning on weighted #jira UE-58435 Change 4041089 by andrew.porter QAGame: Sequence for Long Tangents bug Change 4041498 by Mike.Zyracki Turn off weighted when going auto to prevent large tangents. Do it both in UI and when doing AutoSetTangents() to really make sure it doesn't happen. #jira UE-58452 Change 4041752 by andrew.porter MediaFrameworkTest: Adding some better logging for setting rates when not supported. Also ignoring commiting URL when there is no text Change 4041896 by Matt.Hoffman The transform dialog box now transforms selected keys and sections, instead of just keys. #jira UE-58265 [CL 4044405 by Max Chen in Main branch]
2018-05-02 10:10:00 -04:00
ProcessCommands();
ProcessDelayedMessages();
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 4044339) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3947021 by Max.Chen Sequencer: Don't preserve root component when copying object properties. A spawnable empty actor, has a root component that is generated by the empty actor factory. If the object template's root component is preserved when copying from the spawnable empty actor, the root component will not be copied over. Therefore, we need to NOT preserve the root component when copying object properties. #jira UE-55825 Change 3947366 by Max.Preussner WmfMedia: Better log output Change 3947367 by Max.Preussner MfMedia: Better detection of compressed format properties on Windows Change 3949102 by Max.Chen Sequencer: Remove SequenceActorTag when converting to possessable. #jira UE-56206 Change 3949207 by andrew.porter EngineTest: Set the screenshot nodes resolution to 1280x720 Change 3949404 by Max.Chen Sequencer: More informative tooltip for "Rerun Construction Scripts" option. It now says "Rerun construction scripts every frame on actors that have 'Rerun Construction Script in Sequencer' enabled in their class settings". Change 3950067 by Matt.Hoffman Renamed UAutomatedLevelSequenceCapture's StartFrame and EndFrame to CustomStartFrame/CustomEndFrame to reflect that it is user-overriden. This will also resolve upgrade issues due to the variable datatype changing. #jira UE-56189 Change 3950193 by JohnHenry.Carawon Updating my latest MovieRendering test content. Change 3950757 by JohnHenry.Carawon More updates to MovieRendering test content Change 3952059 by Max.Chen Resave LevelVisibility_SubLevels to fix data loss conversion warning of OpacityMaskConstant #jira UE-56086 Change 3952283 by Max.Chen Sequencer: Disable dropping level sequence assets as spawnables. #jira UE-56120 Change 3952422 by Max.Chen Sequence Recorder: Add button to record from the current player. #jira UE-55942 Change 3952987 by JohnHenry.Carawon MovieRendering Test Content - Fixing camera bindings and changing the override binding actor Change 3953823 by Mike.Zyracki Fix for Bad FBX Import Tangents not scaled by frame rate. After looking at this again it seems that a set of MovieScene:: overiddes for the channel traits wasn't set correctly, so use the ADL idiom to use MovieScene, which can then call Optimize in the correct namespace. With this we can now correctly use the passed in tolerance. There was also a redundant set of Optimize calls so that it could happen twice so removed them, and needed an extra check in the float channel Optimize. Also since we need to set auto tangents no matter if we optimize we don't set that parameter(though leave it since it's used by context menu key reduction). Finally fixed speed issue with trajectories caused by calculating way too many substeps. Reverted back to a time based step size for consistency. #jira UE-56193 Change 3954317 by Matt.Hoffman Adding a key to the last frame of a section no longer causes a crash. Keys can already be moved to be on the last frame of a section so now you can just add a key there directly. #jira UE-56255 Change 3954326 by Matt.Hoffman Dilating a section that is only infinite on one side no longer causes a crash. #jira UE-56260 Change 3954486 by Max.Chen PR #4580: Exposes IsReversed() from UMovieSceneSequencePlayer (Contributed by alanedwardes) Change 3955238 by Max.Preussner Messaging: Enabled delayed message routing https://github.com/EpicGames/UnrealEngine/pull/4574 #jira UE-56247 Change 3955901 by Max.Preussner MediaFrameworkTest: Added developer test for overriding desired media player plug-in at runtime. Change 3955922 by Andrew.Porter QAGame: Updating movie rendering content in dev folder Change 3956004 by andrew.porter QAGame: Adding MPC track to movie rendering test content Change 3956510 by Max.Chen Sequencer: Fix fbx camera import of static properties so that they are imported before default tracks are created. Otherwise, the default tracks inherit the default properties of the camera, rather than the values from the fbx. #jira UE-56311 Change 3957613 by Max.Preussner MediaUtils: Added code documentation to media player facade Change 3958005 by Max.Preussner MediaUtils: Added method to get number of sinks Change 3958934 by Max.Chen Sequencer: Fix keys getting added and sequence getting erroneously re-evaluated when auto key is off. Only apply defaults if there are no keys. Only modify the movie scene section before creating keys or setting defaults. #jira UE-55903 Change 3959687 by Andrew.Rodham Sequencer: Fixed visibility track external values being inverted #jira UE-56324 Change 3960507 by Max.Preussner Core: Fixed incorrect rounding in FMath::DivideAndRoundNearest Change 3962047 by JohnHenry.Carawon MovieRendering Test Content Changes: - Add Lightmass Importance Volumes to sublevel to fix warnings - Rebuilt Lighting - Add a third sequence for Gamut testing - Resaved the sound master.uasset to fix warning Change 3962211 by Mike.Zyracki Add Frame Numbers to selected animation sections. Added MapTimeToAnimation to MovieSceneSkeletalAnimation so that we could get it from the Skeleton Animation track Editor. Since the thickness of the frame line can change based upon frame rate and zoom we need to calculate it similarly to how the time slider controller does it. Those calculations were private so we had to expose FScrubRangeToScreen and GetScubberPixelRange from the TimeSliderController. Also needed to know if the section itself was selected so added a bIsSelected flag to the section Painter. Also fixed a bug where you couldn't add a section if other sections existed at different times in MovieScenePropertyTrack and could crash due to the check(). #jira UESEQ-395 Change 3962497 by Max.Preussner Core: Added new string formatting argument to FTimespan Change 3963662 by Max.Chen CineCamera: Flip VistaVision width and height. Change 3963731 by Max.Preussner MediaCompositing: Implemented sequence recording support for media track Change 3964195 by Andrew.Rodham Sequencer: Set inverted property correctly for newly created visibility track sections - Also clamp evaluation for key editors to the bounds of the section so we're not displaying values outside of the section bounds when the cursor is not on the bounds #jira UE-56324 #coderevew Max.Chen Change 3964196 by Andrew.Rodham Sequencer: Fixed crash when attempting to render sections that resulted in a negative intersection with the view range Change 3964275 by Andrew.Rodham Sequencer: Fixed MovieScene::ClampToDiscreteRange for infinite range bounds Change 3964364 by Andrew.Rodham Curve Editor: Reduce minimum vertical view range when zooming to fit Change 3965091 by Max.Chen Sequencer Recorder: Refresh next sequence if empty when starting a recording, otherwise, use existing name. #jira UE-56469 Change 3965148 by Max.Chen Sequence Recorder: Move Record to Possessable to "Actor Recording" group Change 3965162 by Max.Chen Sequence Recorder: Always break out of immersive mode when done recording, even when stopping recording during countdown. #jira UE-56407 Change 3965214 by Max.Preussner QAGame: Enabled ImagePlate plug-in Change 3965574 by Max.Preussner SimpleComposure: Reorganized & upgraded content to work with new Media Track #jira UE-56488 Change 3965651 by Max.Preussner MediaCompositing: Ignoring seek-on-open if media not seekable Change 3966075 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Export functionality #jira UESEQ-358 Change 3966087 by Matt.Hoffman Adding a single key to the Particle Toggle track now makes an infinite range section that is displayed in the UI. #jira UE-56295 Change 3966547 by Andrew.Rodham Sequencer: Fixed rounding errors when drawing the section background on boolean sections - Logic was using time in sectonds which caused rounding errors on evaluation and flickering red/green stripes when dragging keys around #jira UE-56324 Change 3966563 by Andrew.Rodham Curve Editor: Key editor interface improvements - SKeyEditInterface has a few problems - it does not update in real time when editing properties, and does not support multi-edit which makes it unsuitable for use with the curve editor - We now take a different approach for editing keys by gathering a set of proxy UObjects for each key that is currently selected. These objects are added as top level objects to the details panel which means they support multi edit as you'd expect from any other details panel in the editor. - Proxy objects are updated every tick for the curve editor if they implement the ICurveEditorKeyProxy interface, which allows them to refresh their current value. - Ideally, the same mechanisms would be used in the main sequence interface, and we would be generating the proxy classes at runtime based on the key value type, but that work remains a separate task from this initial offering. #jira UE-56165 Change 3966564 by Andrew.Rodham Curve Editor: Expand to frame when adding or moving keys in the curve editor Change 3967051 by andrew.porter MediaFrameworkTest: Set the CameraPlayer_Video texture to auto clear Change 3967141 by Andrew.Rodham Sequencer: Keep track of spawned objects that have been modified and only re-save such object's default spawnable state on destruction - Now that we're taking this approach, I've remove serveral redundant bits of functionality in the spawn register such as making some spawnables read-only, and the PreSave binding for Sequencer. - We now hook into all object pre-saves to make sure we handle the case where the sequences are saved through the content browser or elsewhere. #jira UE-47686 Change 3967170 by Andrew.Rodham Sequencer: Added the ability to possess anim instances as object bindings - This allows full and direct animation of properties on UAnimInstance, and animation blueprints - Object Bindings are made by first possessing a skeletal mesh component, then choosing the + Add button where its anim instance will be listed - Added a new function to UMovieSceneSequence to gather previously cached objects that should now be invalidated. Anim instances will be re-resolved if a new UAnimInstance is assigned to USkeletalMeshComponent::GetAnimInstance. - ObjectBindingIDs for anim instances are just represented by an entry in a set of GUIDs. We only ever resolve such bindings through USkeletalMeshComponent::GetAnimInstance. - Only currently supported on LevelSequences #jira UE-56132 Change 3967195 by Max.Preussner Core: Updated TRangeSet to use TCallTraits Change 3967345 by JohnHenry.Carawon Test Content Changes - first iteration of spacing out the examples in the shots. Change 3967572 by Max.Chen Sequencer: Fix setting PreviousPlayEvalPosition until after we've tested whether it's set. #jira UE-56518 Change 3967750 by Max.Chen Audio: Set duration based on number of input channels, rather than number of channels to serialize. This fixes an issue where audio split into 2 channels is set to a duration that's twice as long. #jira UE-56430 Change 3967836 by Max.Chen Sequencer: Allow for animating array elements within ustruct properties #jira UE-55887 Change 3968506 by Matt.Hoffman Fixed ambiguous conversions for seconds and frames being overriden by ambiguous conversion to Timecode (in frames). Change 3968748 by Max.Chen Sequencer: Make the event properties submenu widget larger. #jira UE-55557 Change 3968862 by Max.Chen Sequencer: Recursive expansion when shift is down #jira UE-52139 #pr 4194 Change 3968863 by Max.Chen Sequencer: Bind rename command to selected track so that F2 shortcut start renaming #jira UE-52139 #pr 4194 Change 3968872 by Max.Chen Sequencer: Rekey the selected key at the current time. #jira UESEQ-396 Change 3968938 by Max.Chen Cine Camera: Add option to toggle the behavior of locking the rail mount to the orientation of the spline. By default, the option is off, no change in behavior. #jira UE-55815 Change 3968958 by Andrew.Rodham Sequencer: Consider vertical position when hittesting keys #jira UE-56256 Change 3969643 by Max.Preussner Core: Rounding timespans created from double values towards nearest ticks Change 3969646 by Max.Preussner MediaUtils: Implemented timeout mechanism for block-on-fetch feature Change 3969776 by Mike.Zyracki Added Skip Anim Notifiers Toggle per what was in Matinee. Investigated the Enable Root Motion toggle as also discussed but it's implementation is directly contained by the animation asset and unlike animation notifies there seems to be no exposure to interactively disable it during a playback tick. Note if we are generating thumbnails we still automtically disable notifies in the editor to avoid annoying noise playback. Note that if Enable Root Motion/Root locked is specified in the animation asset it does correctly effect the Sequencer. #jira UESEQ-399 Change 3969835 by Matt.Hoffman Playback Range and Selection Range use unified logic for adding themselves as potential snap locations which properly handles inclusive/exclusive bounds. This resolves an issue where having an unset selection range caused a potential snap location to be added on frame 0 and 1 (internal resolution) which caused a misalignment when placing objects near frame 0. This also removes the one frame offset on setting Selection Range to bring behavior inline with other ranges. #jira UE-55420 Change 3969885 by Max.Preussner MediaAssets: Don't register media player CDO with media ticker Change 3971129 by Andrew.Rodham Sequencer: Fixed UMovieSceneSequencePlayer::GotToEndAndStop() not taking into account for start time This is a remnant from when the times were always specified in 0-duration space, rather than actual sequence times. Change 3972056 by JohnHenry.Carawon More updates to Test Content. I continued spacing out the examples in the sequence so that they have a consistent number of frames between each example and during the start/end of the example. Also removed the Marcie sublevel. Change 3972066 by Andrew.Porter MediaFrameworkTest: Setting Marcie folder to be never cooked in package settings Change 3972675 by Matt.Hoffman Splitting Subsequence Sections no longer sets an incorrect playback range on the subsequence when the subsequence has a different internal resolution than the owning sequence. #jira UE-55453 Change 3973376 by Max.Preussner ImgMedia: Zero is the only valid video track for image sequences Change 3973489 by Max.Preussner Launch: Build rules cleanup pass - don't use Media, MediaUtils on server apps - don't link against Media (include-only dependency) - don't include from MediaAssets (dynamic load only) Change 3973760 by Max.Preussner MediaUtils: Moved AppMediaTimeSource implementation into its own file; added logging Change 3973765 by Max.Preussner ImgMedia: Disallowing seek beyond media length Change 3973855 by Max.Preussner MediaFrameworkTest: Updated developer test content Change 3973858 by Max.Preussner MediaCompositing: Blocking on media player time instead of media sample time (the former may not be hit in the current frame) Change 3974988 by Max.Chen Sequencer: Fix trim left so that it also sets the start offset for audio and skeletal animation sections. #jira UE-57015 Change 3976101 by Matt.Hoffman Sequencer will now focus the scroll view on newly created items. #jira UE-56492 Change 3976203 by Max.Chen Property Editor: Add DetailsViewArgs for ColumnWidth. Defaults to 0.65f, no change in existing behavior. Change 3976205 by Max.Chen Sequencer: Set better column widths for sequencer. #jira UE-55557 Change 3976206 by Max.Chen Sequencer: Added menu category for import/export Change 3976265 by Matt.Hoffman Tracks within Object Binding Nodes will now sort using the old behavior so that components are added above other track types. #jira UE-56473 Change 3976901 by Max.Chen Sequencer: Add event names to event track section #jira UESEQ-353 Change 3977878 by Max.Preussner Media: Moved media framework ticking stats into Media module Change 3977982 by Max.Chen Sequencer: Add Edit->Reset section length to duration of source (ie. audio, skeletal animation, shot length) Added MovieSceneSection::GetDefaultDuration and MovieScene::HasDefaultDuration #jira UESEQ-392 Change 3977994 by Max.Preussner Media: Fetching and rendering media samples before viewports are rendered (to ensure frame sync for in-level media playback) #jira UE-53975 Change 3978188 by Matt.Hoffman Easing Curves are now clipped by the sequence's PlayRange when testing against an infinite section. This causes blended sequences to finish their blend when the section starts/ends instead of always using 25% of the total section length to determine default blend range. #jira UE-56362 Change 3978676 by Max.Preussner MediaCompositing: Fixed first frame of rendered out media track missing #jira UE-53975 Change 3978684 by Max.Preussner MediaCompositing: Enabled media track frame sync feature #jira UE-53975 Change 3980026 by Matt.Hoffman Keys can be selected on folded out sections (such as an audio track expanded to show volume and pitch) again. #jira UE-57169 Change 3981614 by Max.Preussner MediaUtils: Added missing subtitle sample queue flush Change 3982311 by Max.Preussner MediaCompositing: Added safeguard for zero length media sources Change 3982389 by andrew.porter QAGame: Adding media track test content into FrameAccuracySubscene Change 3983661 by Max.Chen Sequencer: Add level name to spawn a spawnable into. Add sublevel menu option to set the level #jira UESEQ-390 Change 3983712 by Andrew.Rodham Sequencer: Purge legacy blueprint spawnables from LevelSequence packages #tests Ran a preflight for cooking fortnite, ocean and Orion. Only orion shows up this edge case, and will require a re-save of the EndCines level #jira UE-39173 Change 3983787 by Max.Preussner MediaCompositing: Moved compile time switch for block-on-fetch into media player facade Change 3983812 by Andrew.Rodham Sequencer: Exposed default level sequence instance data to blueprints Change 3984373 by Max.Preussner Media: Added API for quering whether player plug-in supports block on fetch Block on fetch allows Sequencer and other systems to block the game thread until a desired video frame has been decoded. Change 3984670 by JohnHenry.Carawon Movie Rendering Test Content progress. Saving the state of the content. There is a bug where things got replaced with particle emitters and I think it was because I tried to copy paste an animation track into a separate skeletal mesh track. Change 3985097 by Max.Chen Sequencer: Rename Reset to AutoSize Change GetAutoSizeDuration to return TOptional<FFrameTime> #jira UESEQ-392 Change 3986043 by Max.Chen Sequencer: Fix crash when attach/path duration is less than 0. #jira UE-57310 Change 3986373 by Max.Chen Sequencer: Add support for deleting tracks and channels which equates to setting the channel mask. #jira UE-52951 Change 3986375 by Max.Chen Sequencer: Add Create Pose Asset to skeletal animation section. This allows animators to blend animations in sequencer and create new pose assets from them. #jira UESEQ-408 Change 3986796 by Andrew.Rodham Sequencer: Fixed stale object references remaining in ULevelSequence::BindingReferences when using convert to spawnable/possessable - We used to convert objects by creating a new binding, then re-assigning its GUID, which meant we didn't have to do any further object fixup, but the code to achieve this was confusing and led to a vulnerability where object references would not be cleaned up correctly due to the newly created possessable essentially being a temporary object that's immediately thrown away. - To address this, there is now a function for porting all the contents of one object binding to another, and handles the correct fixup required for parent/child object bindings for both spawnables and possessables. - Also added codepath to remove any stale object references from the level sequence reference map on PostLoad (this piggy-backs off the PurgeLegacyBlueprints object version which is close close enough to this change to be identical) #tests Verified that existing sequences with stale references get cleaned up on load. Verified that repreatedly converting from spawnable<->possessable cleans up references correctly. Change 3987807 by JohnHenry.Carawon Updates to the MovieRendering Test Content. - Fixed the spawnable actors that were overwritten - Shortend the Lighting example and combined the Intensity and Color tracks - Organized the Sequence and WorldOutliner to group the examples. Change 3988151 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. Change 3988880 by Max.Chen Sequencer: Support enter to add asset for all sequencer track editors that have asset pickers. #jira UE-57367 Change 3988953 by Max.Chen Sequencer: Make the track color picker focusable so that it will close when you click away or lose focus. #jira UE-57210 Change 3988962 by Max.Chen MovieSceneCapture: Fix EDL export so that it takes into account movie scene frame resolution and desired frame rate. #jira UE-57365 Change 3988964 by Max.Chen Movie Scene Capture: Clarified tooltip for bRelativeFrameNumbers. If you specify custom start/end frames for the recording, they will be relative to the playback range. #jira UE-57308 Change 3989442 by Max.Chen Fix CIS Change 3991548 by Matt.Hoffman Dragging the time slider no longer causes the time slider to ignore snap-to-interval with "Snap to Keys While Scrubbing" when no keys are in range. #jira UE-57417 Change 3991598 by Matt.Hoffman Snap to Key while scrubbing now mirrors the behavior of "jump to next key". When there are no tracks selected it snaps to all keys and when there are tracks selected it snaps to only keys from that track. This also resolves an issue where deleting an object did not remove it from the Sequencer's selection. Undoing a delete already doesn't seem to restore your selection, so removing it from your selection shouldn't change that behavior. #jira UE-57417 Change 3991603 by Max.Chen Sequencer: Disable EditAnywhere for some section properties #jira UE-53530 Change 3992240 by Max.Preussner MediaAssets: Implemented dynamic audio sample rate adjustment based on audio/media clock drift #jira FORT-70638 Change 3992911 by Andrew.Rodham Sequencer: Fixed saving spawnable state using the wrong spawned object - We now track the object binding ID so that we can apply the spawned object to the correct spawnable when the asset is saved #jira UE-57353 Change 3992914 by Max.Chen Movie Scene Capture: Fix compression quality not being set. The compression interface wasn't being found through query interface, so no compression was being set. Reworked finding it through the output pins. Tested running various compression values. #jira-UE-55488 Change 3992919 by Max.Chen Sequencer: Convert to possessable now uses object template instead of copying properties (ie. see LevelSequenceActorSpawner). This fixes MIDs getting lost when converting to spawnable and back to possessable. #jira UE-52400 Change 3993184 by Max.Chen Sequencer: Don't show +Transform/+Path/+Attach track if the actor has the "Mobility" property hidden. Set the Landscape, LandscapeProxy and InstancedFoliage "Mobility" property to be hidden since it is static is not supposed to be dynamically movable. #jira UE-56347 Change 3993238 by Max.Chen Sequencer: Test for hidden mobility in creating keys as well. Refactored to HasHiddenMobility() #jira UE-56347 Change 3993978 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. #jira UE-57489 Change 3994039 by Max.Chen Landscape: Add Mobility to hidecategories on landscape component #jira UE-56347 Change 3994626 by JohnHenry.Carawon Updated Movie Rendering Test Content. - Fixed the overridden spawnables to their proper object types. Change 3994653 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Import functionality, improved Export functionality #jira UESEQ-358 Change 3995609 by Max.Chen UMG: Add support for 2d transform mask (translation, rotation, scale, shear) #jira UE-52951 Change 3995778 by JohnHenry.Carawon Movie Rendering Test Content Updates - Adjusted Lights example - Adjusted Camera example - Added Marcie sublevel back in Change 3995942 by JohnHenry.Carawon QAGame: Moving Movie Rendering test content from Developer folder to Sequencer folder Also adjusted level visibility, lights and camera example. Change 3995993 by Christina.TempelaarL Sequencer: FCPXML Export updates - only export sections if in playback range and media exists, warn if media does not exist. Other updates - removed unused methods and variables, fixed message context naming to be more accurate #jira UESEQ-358 Change 3996595 by andrew.porter QAGame: Updating Marcie content in TrackEvaluation level to use Image Plate Change 3996614 by andrew.porter QAGame: Adding color test sequence to the sublevel Change 3996643 by Max.Chen Sequencer: Fix fbx animation export - rotation and scale channels were flipped. #jira UE-57509 #jira UE-57512 #jira UE-57514 Change 3996652 by Max.Preussner Messaging: Fixed delayed messaging using incorrect current time after message router sleep Based on https://github.com/EpicGames/UnrealEngine/pull/4601 Change 3996801 by Max.Chen Sequencer: Fix folder active state for non key area sections. Look at track node sections as well as key areas. #jira UE-57550 Change 3997098 by Matt.Hoffman Cleaned up some remaining ToDo's in STimeRange. Change 3998339 by Max.Preussner Sockets: Added documentation for socket receive functions Change 3998359 by Max.Preussner MediaUtils: Started to implement media recorder helper class Currently only supports BGRA frames in CPU memory. Supporting other formats and buffer types will require conversions on render-thread. I recommend refactoring out the existing conversion code in FMediaTextureResource into a reusable helper class in the MediaUtils module. This should be a good starting point though. Change 3998417 by Matt.Hoffman Keys and Sections can now be moved at the same time inside of Sequencer. Keys can now snap to Sections (and vice versa) instead of just to other Keys. Sections can now be duplicated like keys can. #jira UE-56995 Change 3998427 by JohnHenry.Carawon QAGame: Updating test content for the Movie Rendering feature. - Added an auto activate particle to the beginning of the sequence (it's not part of the sequence at all) - Added an event receiver blueprint to the Events example - Added a particle emitter to both sublevels - Added a camera cut to the end that switches to a separate camera - The camera zoom in, focus and Look At sections are all separate (not overlapping in the sequence) - Added a second actor for the camera Look At - Added a Visibility section for the Actor Hidden In Game track that has possessable and spawnable cube and light Change 3998537 by Max.Chen Sequence Recorder: Restore immersive mode when stopping the sequence even if not in PIE. #jira UE-56407 Change 3999809 by Matt.Hoffman Removed the "Go To" box from Sequencer and instead placed the current time as an always visible control. The previous shortcut (Ctrl + G) now focuses the new widget directly. #jira UESEQ-376 Change 4000543 by Christina.TempelaarL Sequencer: Moving editor-only code from runtime module MovieSceneCapture to editor module MovieSceneTools. Moved EDL and FCP XML exporters as well as Automated Level Scene Capture. #jira UESEQ-358 Change 4000706 by Matt.Hoffman Entering multiple time strings without a number no longer crashes Sequencer. #jira UE-57672 Change 4001051 by andrew.porter MediaFrameworkTest: Fixing up some image sources pointing to the wrong location Change 4001191 by andrew.porter QAGame: Adding some quick EDL/XML test content to dev folder Change 4001243 by Max.Chen Sequencer: Fix import EDL out of range. #jira UE-57665 Change 4001856 by Matt.Hoffman Selecting keys and sections at the same time now also works with animation and audio sections. #jira UE-57716 Change 4002021 by Max.Chen Sequence Recorder: Fix sequence name incrementing. If external recording sets the sequence name, use it. Otherwise, use the recording name from the recording group or the recording settings. #jira UE-57712 Change 4002618 by Max.Chen Viewport: Update the look at location when updating to a locked actor. This fixes an issue so that popping the view out of a locked actor and manipulating the view will not jump to the previous look at location. #jira UE-57725 Change 4002979 by Matt.Hoffman Fixes several edge cases with the end time range that was causing confusion about what the last frame of the sequence was. Dragging the End Frame slider will no longer be off by one tick and jumping to the end via the UI controls now properly respects snapping and stays inside the play range instead of falling outside of it. Overall behavior does not change though and End Frame should be considered an exclusive frame so that frames 0-150 results in a 150 frame long animation (which is frames 0-149). #jira UE-56367 Change 4003185 by Matt.Hoffman Fixed a regression that prevented a section from being dragged upwards past row 0 which normally resulted in all other rows moving down. #jira UE-57717 Change 4003193 by JohnHenry.Carawon QAGame: Updates to test content - Shortened frames between the examples from 95 to 30 - Separated camera setting tracks - Lighting example now switches directly from constant red - green - blue Change 4003369 by Max.Chen Sequence Recorder: Refresh next sequence regardless of internally stored sequence name. #jira UE-55757 Change 4003586 by JohnHenry.Carawon QAGame: Test Content Updates - Level Visibility track now ends to that the levels are not visible when we move to the next example - Shortened camera section, removed Z tranform so that we just move left to right and shortened the overall length Change 4004414 by Max.Chen Movie Scene Capture: Fix regression where rendering with shot handles would only render the first shot. 3972166 addressed an issue where an extra frame would be rendered by finalizing right when the end frame was reached. This was hit on the first shot end frame, so instead, do this only for when the last shot is being rendered. #jira UE-57314 Change 4004765 by Christina.TempelaarL Sequencer: Fixed bugs in FCP XML import/export. - Export: fixed sequence default resolution. - Export: fixed XML files with no shots. - Export: all sections clipped to playback range. - Export: fixed incorrect section start/end times due to precision issues. - Import: fixed incorrectly adding cinematic tracks. - Import: fixed bugs creating new sections. #jira UE-57660 #jira UE-57662 #jira UE-57655 #jira UE-57761 Change 4005119 by Max.Chen Sequencer: Export/import at play rate Change 4005195 by Max.Chen UMG: Finish UMG evaluation on stop. Added object version so that existing UMG assets do not change. #tests - Newly created UMG animation with sections set to restore state now return to their original state. Existing UMG animations with sections set to restore state do not return to their original state. #jira UE-52285 Change 4005377 by Michael.Karambelas QAGame: Moving TM-SequenceRecorder and related content out of my developer folder and into /Content/Sequencer/SequencerRecorder/* Change 4005417 by Michael.Karambelas QAGame: Fixed a BP compiler in the Level Blueprint of TM-SequencerRecorder. Change 4005634 by Michael.Karambelas QAGame: Fix up missing content and broken level sequence in TM-SequenceRecorder after move Change 4006324 by Max.Chen Sequencer: Reset if the focused movie scene is null. This fixes a crash if the user is focused in on a shot and undo takes the user past the point of where the shot was created. #jira UE-57752 #jira UE-47661 Change 4007006 by Max.Chen Sequencer: Fix FindAvailableRowIndex so that it returns the max row index (and not +1) since it doesn't find any conflicting rows. #jira UE-57717 Change 4007907 by Max.Chen Sequencer: Fix crash if there's no animation Change 4007948 by andrew.porter QAGame: added test content to dev folder for Record World Space Change 4008636 by Max.Chen Sequencer: Fix import fbx not setting values properly and creating additional cameras unncessarily. #jira UE-57864 Change 4008759 by Max.Chen Sequencer: Follow up fix for import cameras #jira UE-57864 Change 4009994 by Matt.Hoffman Dragging the left or right handles of the Time Range slider in Sequencer will now zoom your view in on the current center of the screen. This prevents the view from being translating as you tried to zoom in which caused issues at high zoom levels. #jira UESEQ-407 Change 4010169 by Christina.TempelaarL Sequencer: FCP XML fixes. - FCP XML export - no longer clips to playback range - FCP XML and EDL export - fixed missing last frame of some sections after exporting to Premiere. - Automated level capture, EDL export - use RoundToFrame instead of FloorToFrame for computing section start/end frames after frame rate conversion. #jira UE-57802 - partial fix, movie scene capture still needs to render full section rather than clip against playback. Change 4010287 by Mike.Zyracki Add quaternion interpolation option to UMovieScene3DTransformSection. This mimics how Matinee used to work by bascially finding the keys between a time and interpolating the angles as quat's between them. As noted in the code the algorithm needs to handle the case when the x,y,z Rotation keys all aren't at the same time which was not handled by Matinee. Also like Matinee, when in quaternion interoplation mode, we need to not display the function cuves since the interpolated and key values are now all different. (Would like to show them but that's a bigger refactor for perhaps just a one off needed by quaternions). I added a virtual function UMovieSceneSection::ShowCurveForChannel for this since it needs to be dynamic, not on construction of IKeyArea's, and could be useful for other sections. I could though move the method to just UMovieScene3DTransformSection and do a cast instead. Looked into doing a unit test for this but after talking with Andrew P we will work on doign an automated test in EngineQA since that will provide more coverage. Will also add a video the jira. #jira UESEQ-403 Change 4010713 by Mike.Zyracki Added option to key a group of transform channels instead of just the changed channel, or all of them. This is useful for quaternion interpolations where you want rotation keys to be aligned but also useful for other workflows like animating FK Pose to Pose. Change 4010715 by Andrew.Porter MediaFrameworkTest: Setting LogMediaUtils logging from VeryVerbose to Verbose to cut back on the spam Change 4013048 by Max.Chen Sequencer: Fix play/jump status. Update the player status for all position methods (Scrub, Jump, Play). Jump means Stopped. Correctly use PlayTo or JumpTo based on position method. In PlayInternal, JumpTo with the Stopped state (rather than playing state). #jira UE-57844 Change 4013479 by andrew.porter QAGame: Added content in TM-SequenceRecorder to test recording a property on a Cine Camera Component; Press 3 to trigger manual focus distance to increment on a timer Change 4014323 by Max.Chen Sequencer: Fix SetPlaybackPosition so that it jumps or plays based on playback status. #jira UE-57844 Change 4015888 by Max.Chen Sequencer: Fix crash on paste. UMovieSceneSections were gathered from the track node's track. For sub track mode, we want to gather only those sections on that track node row. #jira UE-57951 Change 4015943 by Max.Chen Sequencer: Fix moving shots up when the mouse pos goes outside of the virtual track area. #jira UE-57717 Change 4016293 by Max.Chen Sequencer: Fix relative frame playback end frame calculation so that custom start/end frames remain in the space of the sequence and are not relative. #jira UE-57308 Change 4017075 by Andrew.Rodham Sequencer: Corrected initial evaluation range used when calling UMovieSceneSequencPlayer::Play() Change 4017270 by Christina.TempelaarL Sequencer: FCPXML importer and movie scene capture - Use CeilToFrame when converting section start/end frame times to frame numbers in FCPXML and movie scene capture. - Added support for clip metadata in FCPXML. - Got rid of redundant TokenizedError message class, no longer needed now that FCPXML is in editor directory. - Added log messages currently commented out due to exception, still testing. #UESEQ-358 Change 4018370 by Christina.TempelaarL Sequencer: fixed FCPXML log messages regarding sections with start/end not divisible by display rate. #UESEQ-358 Change 4018378 by Christina.TempelaarL Sequencer: fixed error in previous changelist. #UESEQ-358 Change 4019457 by Max.Chen Sequencer: Show event names only when the event track is selected #jira UE-57897 Change 4022806 by Max.Chen Sequencer: Fix crash on movie scene capture dialog shutdown if movie capture wasn't even started. #jira UE-58106 Change 4022894 by Max.Chen Sequence Recorder: Wrap OpenEditorForAssets after sequence recording within GIsEditor #jira UE-58084 Change 4024487 by Max.Chen Sequencer: Add tooltip for quat interpolation #jira UE-58113 Change 4024562 by Max.Chen Sequencer: Change path/attach track sequence binding id to currently focused sequence id so that bindings can be created in subsequences Change 4027414 by JohnHenry.Carawon QAGame: Checking in content that shows a bug with using particles systems and Delay Before Shot Warm Up. Change 4028990 by Max.Chen Sequencer: Fix evaluate sub sequences in isolation. This check was added with the compile on the fly logic. Not sure why it was necessary but it seems like the sub sequence data needs to be updated in order to evaluate sub sequences in isolation. #jira UE-58184 Change 4029004 by Max.Chen Sequencer: Ensure that old binding references are removed when re-assigning actors in sequencer #jira UE-57898 Change 4030997 by JohnHenry.Carawon QAGame: Fixing name of the master sequence Change 4031785 by Michael.Karambelas QAGame: Added an instance of ThirdPerson Run to TM-SequenceRecorder for Record to Possessable test. Change 4035548 by Andrew.Rodham Sequencer: Changed FMovieSceneEvaluationTemplate::TemplateSignature to be a serial number to address non-deterministic cooking issues - This commit is related to the repro steps found in 3914599 and 3934307, both of which have been verified with this new change. - Copy of 4031684 from //Fortnite/Main/... #jira FORT-84852 Change 4036312 by Max.Chen Sequencer: Fix zoom view range so that it uses the passed in InZoomDelta Change 4036318 by Max.Chen Sequencer: Auto size now returns a range and defaults to the channel proxy range so that keyed regions can also be autosized. Change 4036322 by Max.Chen Forgot missing change Change 4036360 by Max.Chen Sequencer: Fix play rate calculation when skeletal animation section play rate changes. Change 4037163 by Mike.Zyracki Weighted Tangent Implementation Tricky thing is that you need to solve a cubic in order to get the bezier weights for the time part of the curve. See https://www.gamedev.net/forums/topic/474094-help-function-curves-for-animation-interpolation/ Maya provides an implementation in it's dev kit but I didn't use it since it was horribly slow and uses an iterative solution to solve the cubic needed. Instead I use an old algorithm (Cardano's method), to solve the cubic which should be much faster. Though relative simple to code from principles I just went ahead and used a version from Graphics Gems 1. I put this cubic solver directly in MovieSceneFloatChannel.cpp, but will need to move it when we support Rich Curve, maybe to FMath:: (which would probalby require some other functions for solving quartics, etc.. for completeness.). Also note we resolve this on every evaluation but dont' need to if the interval the time is evaluating hasn't had any change in values or tangents. So again when we support FRichCurve we can create a Weighted Evaluating class that can hold the cache. Also with the tangent drags I got rid of the Cardinal position that was used to calculate non-weight tangents from the key point and just quickly getting a direction. With weighted tangents we need to use the delta instead (otherwise when moving multiple they would all get the same weight based upon distance to the cardinal point. ) For mixed tangents types what I'm defaulting to non weighted if the interval doesn't match. May need to do weighted instead, not sure. What's left is just FBX import, for tomorrow. #jira UESEQ-76 Change 4037435 by Mike.Zyracki Fix fo build warnings from weighted tangent submission. #trivial Change 4038091 by Michael.Karambelas QAGame: Updated a Sequence Recorder group in TM-SequenceRecorder that had an actor missing the animation. Change 4038374 by Andrew.Rodham Sequencer: Refined scrubber styling for level sequences and actor sequences - Scrubber now shows a block the width of a dsplay rate frame, plus a line for the actual evaluated time. UMG reverts back to the previous styling (no block) - Keys that are outside of the playback range are now drawn with a subdued effect - Tick labels are no longer drawn when directly underneath the scrubber Change 4038490 by Max.Chen Sequencer: Expose tangent weight values in details panel. Change 4038620 by Andrew.Rodham Sequencer: Advanced time panel polish #jira UESEQ-426 Change 4038677 by Max.Chen Movie Scene Capture: Redirector for MovieSceneTools.AutomatedLevelSequenceCapture #jira UE-58248 Change 4039739 by Max.Chen Sequencer: Media track should only be supported by Level Sequence Change 4040024 by JohnHenry.Carawon QAGame: Fix EventReciever and OverrideBinding example The level sequence was set to none so the fix was to set it back to TrackEvaluation_Master. Change 4040610 by Andrew.Rodham Curve Editor: Moved weighted tangent switchers to a single toggle command (CTRL+W) and added an icon #jira 58383 Change 4040882 by Mike.Zyracki Keep broken when turning on weighted #jira UE-58435 Change 4041089 by andrew.porter QAGame: Sequence for Long Tangents bug Change 4041498 by Mike.Zyracki Turn off weighted when going auto to prevent large tangents. Do it both in UI and when doing AutoSetTangents() to really make sure it doesn't happen. #jira UE-58452 Change 4041752 by andrew.porter MediaFrameworkTest: Adding some better logging for setting rates when not supported. Also ignoring commiting URL when there is no text Change 4041896 by Matt.Hoffman The transform dialog box now transforms selected keys and sections, instead of just keys. #jira UE-58265 [CL 4044405 by Max Chen in Main branch]
2018-05-02 10:10:00 -04:00
WorkEvent->Wait(CalculateWaitTime());
}
return 0;
}
void FMessageRouter::Stop()
{
Tracer->Stop();
Stopping = true;
Copying //UE4/Dev-Sequencer to //UE4/Main (Source: //UE4/Dev-Sequencer @ 3617642) #lockdown nick.penwarden #rb none Change 3235667 on 2016/12/14 by Max.Preussner Media: Moved enums into separate header file, so they can be shared Change 3259266 on 2017/01/16 by Max.Preussner Core: Added timespan ratio Change 3267229 on 2017/01/21 by Max.Preussner Editor: Fixed texture samplers in materials not getting notified when sRGB mode changed Change 3274773 on 2017/01/27 by Max.Preussner Core: Added TLruCache template Change 3281579 on 2017/02/01 by Max.Preussner Core: Added scalar division to FTimespan Change 3289522 on 2017/02/07 by Max.Preussner MediaAssets: Added looping for play lists Change 3290664 on 2017/02/07 by Max.Preussner Engine: Moved UTexture material notification code into separate function, so it can be used by derived classes. Change 3290688 on 2017/02/07 by Max.Preussner MediaAssets: Notifying materials when media texture properties changed. Change 3291171 on 2017/02/07 by Max.Preussner MediaAssets: Filtering unused UTexture properties Change 3291229 on 2017/02/07 by Max.Preussner ImgMedia: Use displayWindow instead of dataWindow due to bug in OpenEXR with data window min < 0 Change 3298520 on 2017/02/11 by Max.Preussner Sequencer: Fixed skylight and reflection components off by one frame in PIE Change 3298778 on 2017/02/12 by Max.Preussner MediaUtils: Experimenting with dynamic pitch adjustment Change 3298987 on 2017/02/13 by Max.Chen Editor: Add matrix and transform properties to property editor test object Change 3298997 on 2017/02/13 by Max.Chen Editor: It's now possible to specify Units and ForceUnits meta-data on struct properties - Doing so will cause any child numeric and struct properties to use these units by default (unless another unit was specified) - Added percentage unit type - Multiplier unit types can now be converted between Change 3298998 on 2017/02/13 by Max.Chen Editor: Conversion between multiplier (1.5x) and percentage (150%) units is now possible Change 3348678 on 2017/03/15 by Max.Preussner Media: Added Buffering media event Change 3355268 on 2017/03/20 by Max.Preussner Core: TQueue documentation updates Change 3359055 on 2017/03/22 by Max.Preussner Portal: Removed dependency to Messaging.h Change 3359060 on 2017/03/22 by Max.Preussner Messaging: Modernization pass - added missing includes & forward declarations - include what you use - deprecated shared pointer typedefs - replaced some delegates with callback interfaces - documentation fixes Change 3359189 on 2017/03/22 by Max.Preussner Automation: Modernization pass - include what you use - removed molothic header - documentation fixes #upgradenotes: IAutomationWorkerModule.h is now in the module's public root directory Change 3359718 on 2017/03/22 by Max.Preussner Messaging: Moved common helper classes into MessagingCommon module #upgradenotes: If you use the common helper classes, replace "Messaging" with "MessagingCommon" in your Build.cs files and remove the "Helpers/" subdirectory from your include statements (unless you actually include header files from "Messaging", in which case you need to keep "Messaging" and add "MessagingCommon"). Change 3359793 on 2017/03/23 by Max.Preussner TargetDeviceServices: Modernization pass - include what you use - removed boilerplate header - deprecated selected shared pointer typedefs - reorganized files - documentation fixes Change 3361028 on 2017/03/23 by Max.Preussner DeviceManager: Modernization pass - include what you use - reduced shared pointer typedef usage - documentation fixes Change 3361197 on 2017/03/23 by Max.Preussner Messaging: Waking up message router thread on shutdown Change 3361246 on 2017/03/23 by Max.Preussner AutomationWindow: Removed boilerplate header #upgradenotes: Replace includes of AutomationWindow.h with IAutomationWindowModule.h Change 3361428 on 2017/03/23 by Max.Preussner AutomationController: Removed boilerplate header #upgradenotes: Instead of AutomationController.h, include the individual interface headers that you actually use. Remove the "Interfaces/" subdirectory from existing interface inclusions. Change 3363206 on 2017/03/24 by Max.Preussner ProfileLauncher: Modernization pass - include what you use (selected files) - reduced shared pointer typedef usages - removed dead code - cleaned up file organization - documentation fixes Change 3363290 on 2017/03/24 by Max.Preussner LauncherServices: Removed boilerplate header #upgradenotes: Instead of including LauncherServices.h, include the ILauncherXXX.h files that you actually use. Remove the "Interfaces/" subdirectory from existing ILauncherXXX.h includes Change 3363305 on 2017/03/24 by Max.Preussner LauncherCheck: Removed boilerplate header #upgradenotes: Include ILauncherCheckModule.h instead of LauncherCheck.h. Remove "Interfaces/" subdirectory from existing ILauncherCheckModule.h inclusions Change 3363708 on 2017/03/24 by Max.Preussner ImageWrapper: Removed boilerplate header #upgradenotes: Instead of including ImageWrapper.h, include the actual IImageWrapperXXX.h files that you use. Remove the "Interfaces/" subdirectory from existing IImageWrapperXXX.h includes Change 3363966 on 2017/03/24 by Max.Preussner ImageWrapper: Modernization pass - include what you use - reorganized internal files - documentation fixes Change 3364579 on 2017/03/24 by Max.Preussner ImageWrapper: Deprecated shared pointer typedef and removed usages #upgradenotes: Please use TSharedPtr<IImageWrapper> instead of IImageWrapperPtr Change 3364582 on 2017/03/24 by Max.Preussner NetworkFileSystem: Removed monolithic boilerplate header #upgradenotes: Instead of including NetworkFileServer.h, include the INetworkFileXXX.h headers that you actually use. Remove the "Interfaces/" subdirectory from existing INetworkFileXXX.h includes Change 3381440 on 2017/04/05 by Max.Preussner Oculus: Removed illegal pragmas Change 3391731 on 2017/04/12 by Max.Preussner ImgMedia: Added support for BMP, JPG and PNG image sequences Change 3401146 on 2017/04/19 by Max.Preussner Core: Cleanup pass for FTimespan usages; updated documentation When initializing time span values from single components, consider using the FromHours, FromMinutes, FromSeconds, Zero, MinValue and related methods instead of calling the overloaded constructors as they will make your code easier to read and understand. Change 3401504 on 2017/04/20 by Max.Preussner MCP: Fixed incorrect FTimespan usage of GetMilliseconds instead of GetTotalMilliseconds Change 3401833 on 2017/04/20 by Max.Preussner Core: Various improvements to FTimespan - added proper serialization - updated documentation - access fractions as milli-, micro- or nanoseconds - removed the following string formatters as they were not useful: %D %H %M %S %F - updated documentation #upgradenotes: The %D string formatter (previously total number of days) is now the zero-padded days component of the time span. Time spans are now always exported and stringified with a leading plus or minus sign. #jira UE-43990 #jira UE-44163 Change 3437543 on 2017/05/12 by Max.Preussner PS4Media: Added audio error codes conversion Change 3446564 on 2017/05/18 by Max.Preussner Networking: Fixed nullpointer crash if socket initialization fails Change 3459978 on 2017/05/25 by Max.Preussner ImgMedia: Renamed frame cache to frame loader Change 3463311 on 2017/05/26 by Max.Preussner Core: Added iterators & predicate based methods to LRU Cache Change 3464452 on 2017/05/29 by Max.Preussner ImgMedia: Added video sample output Change 3464468 on 2017/05/29 by Max.Preussner Media: Added separate cache visualization for loaded and cached samples Change 3464592 on 2017/05/29 by Max.Preussner Core: Added TLruCache::FindAndTouch Change 3464607 on 2017/05/29 by Max.Preussner Core: Added TRange::Inclusive / ::Exclusive Change 3464608 on 2017/05/29 by Max.Preussner Media: Fixed incorrect upper bound in support play rates of various players Change 3466732 on 2017/05/30 by Max.Preussner ImgMedia: Added image compression type to info string Change 3466871 on 2017/05/31 by Max.Preussner WmfMedia: Fixed session capabilities not showing up; added initialization logging Change 3467785 on 2017/05/31 by Max.Preussner MfMedia: Fixed sample stride calculated from media input instead of output Change 3467963 on 2017/05/31 by Max.Preussner WmfMedia: Reordered media sub-type string conversion to fix some tracks being reported incorrectly Change 3468110 on 2017/05/31 by Max.Preussner WmfMedia: Added MPEG-2 media sub types to utils Change 3468516 on 2017/05/31 by Max.Preussner AndroidMedia: Allow mediaplayer audio to be disable on Android (UE-45570) Change 3468554 on 2017/05/31 by Max.Preussner MediaAssets: Added AutoClear option to automatically clear media texture when media is unloaded Change 3468627 on 2017/05/31 by Max.Preussner ImgMedia: Allowing for auto-selection of EXR decoder thread count Change 3468648 on 2017/05/31 by Max.Preussner ImgMedia: Reorganized OpenExrWrapper files Change 3471789 on 2017/06/02 by Max.Preussner WmfMedia: Fixed potential concurrency issue in session state management Change 3472918 on 2017/06/03 by Max.Preussner Core: Allowing zero sized LRU cache; added default constructor Change 3472919 on 2017/06/03 by Max.Preussner Media: Added pre-Slate tick stage; renamed some functions; continued to implement sample caching Change 3473704 on 2017/06/05 by Max.Preussner AndroidMedia: Added settings class Change 3474407 on 2017/06/05 by Max.Preussner AndroidMedia: Implemented video sample processing Change 3474934 on 2017/06/05 by Max.Preussner ImgMedia: Fixed crash due to deleting loader work items twice (UE-45705) #jira UE-45705 Change 3476925 on 2017/06/06 by Max.Preussner Media: Added return values to media view interface; documentation fixes Change 3477158 on 2017/06/06 by Max.Preussner SwitchMedia: Implemented sample pooling Change 3477201 on 2017/06/07 by Max.Preussner PS4Media: Implemented video sample pooling Change 3481470 on 2017/06/08 by Max.Preussner Media: Fixed time stamps not set in recycled texture samples Change 3481472 on 2017/06/08 by Max.Preussner MediaAssets: Fixed no video samples fetched while player is in buffering state Change 3481473 on 2017/06/08 by Max.Preussner MediaUtils: Added default constructor to MediaSampleQueue Change 3481584 on 2017/06/08 by Max.Preussner MediaUtils: Paused state is considered forward for sample lookup as this is the common case. Change 3481588 on 2017/06/08 by Max.Preussner PS4Media: Redesigned the PS4 media player to support async file loading & track switching Change 3481627 on 2017/06/08 by Max.Preussner PS4Media: Opening media sources in thread pool if not precaching Change 3481666 on 2017/06/08 by Max.Preussner ImgMedia: Fixed SequencePath property file picker always opening default path Change 3481669 on 2017/06/08 by Max.Preussner ImgMedia: Fixed crash when quering cache state of empty image sequence Change 3481685 on 2017/06/08 by Max.Preussner ImgMedia: Fixed EXR reader failing to play slow loading sequences (UE-45719) #jira UE-45719 Change 3483623 on 2017/06/10 by Max.Preussner Media: Added getters for 360 view settings; added support for relative view updates Change 3483624 on 2017/06/10 by Max.Preussner Media: Added Blueprint support for 360 videos Change 3483626 on 2017/06/10 by Max.Preussner MediaPlayerEditor: Added 360 video mouse controls; broke out viewport widget into separate class. Change 3483627 on 2017/06/10 by Max.Preussner Core: Using system start time instead of current time for renamed log file names Change 3483630 on 2017/06/10 by Max.Preussner Core: Grouping log files by log name and processing each group separately when deleting old log files Change 3483816 on 2017/06/10 by Max.Preussner WmfMedia: Detecting audio device availability to prevent lockup of audio tracks Change 3483939 on 2017/06/11 by Max.Preussner AvfMedia: Finished Media Framework 3.0 upgrade - overhauled track switching - removed render thread flushes - reduced nesting - code cleanup pass Change 3483940 on 2017/06/11 by Max.Preussner Media: Consistent track switching behavior across platforms Change 3484172 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Removed obsolete asset type actions Change 3484180 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Fixed media player info overlays not visible during mouse capture Change 3484248 on 2017/06/11 by Max.Preussner MediaAssets: Media players now always have a playlist Change 3484249 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Added UI controls to Playlist tab Change 3484250 on 2017/06/11 by Max.Preussner Media: Implemented overlay sample caching Change 3484252 on 2017/06/11 by Max.Preussner WmfMedia: Enabled support for .smi and .sami subtitle files Change 3485433 on 2017/06/12 by Max.Preussner ImgMedia: Enabled plug-in on all platforms; enabled EXR only on platforms that support it Change 3485720 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Added ability to save playlists Change 3485828 on 2017/06/12 by Max.Preussner AvfMedia: Thread-safe ticking of video sampler; ticking audio processing on high frequency thread Change 3485926 on 2017/06/12 by Max.Preussner MediaUtils: Draining all unconsumed samples at the end of a frame Change 3486043 on 2017/06/12 by Max.Preussner Media: Consistent behavior for playlist navigation (UE-45964) #jira UE-45964 Change 3486104 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Implemented simple overlay text positioning Change 3486145 on 2017/06/12 by Max.Preussner AndroidMediaPlayer: Moved video sample handling into render thread Change 3486147 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Moved overlay texts into separate layer Change 3486188 on 2017/06/12 by Max.Preussner Media: Enabling media factory modules in Editor for all players Change 3486223 on 2017/06/12 by Max.Preussner Media: Defaulting players to select first audio and video tracks by default Change 3486473 on 2017/06/13 by Max.Preussner Media: Buffering is no longer a media player state, but handled separately (for players that can buffer while playing) Change 3486475 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing busy bar when buffering or preparing Change 3487237 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed video sample not getting processed on render thread Change 3487507 on 2017/06/13 by Michael.Trepka AvfMedia - small cleanup of the code for passing video frame rate to the video sampler Change 3487719 on 2017/06/13 by Michael.Trepka Disable shared PCH in OpenExrWrapper to solve a problem with bUseRTTI mismatch between the module and the PCH Change 3487842 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed texture swizzle disabled on non-Engine builds Change 3488006 on 2017/06/13 by Michael.Trepka AvfMedia - Moved some logic from FAvfMediaPlayer::TickTickable() to FAvfMediaTracks::ProcessAudio() to make it thread safe, plus fixed a bug with the player not setting the current status to Stopped after opening a file Change 3488308 on 2017/06/13 by Chris.Babcock AndroidMedia: Fixed flicker issue #jira UE-45736 Change 3488335 on 2017/06/13 by Max.Preussner MediaAssets: Made UFileMediaSource::GetFullPath public Change 3488338 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Fixed "Show file in Explorer" not working for file media sources Change 3488339 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing a throbber when buffering player Change 3488768 on 2017/06/14 by Max.Preussner Core: Inlined FTimespan static functions hange 3490203 on 2017/06/14 by Max.Preussner Core: Force inlined TComPtr operators Change 3494083 on 2017/06/15 by Chris.Babcock AndroidMedia: Fix playlist looping (send PlaybackEndReached event) #jira UE-46086 Change 3497017 on 2017/06/16 by Max.Preussner MediaAssets: Playlists now auto advance with PlayOnOpen off Change 3497075 on 2017/06/17 by Chris.Babcock MediaPlayer Sampler node and external texture support for Android MediaPlayer - enable with USE_EXTERNALTEXTURE in AndroidMediaPlayer.cpp (disabled in this CL) - supports MediaSample node in material editor with scale/bias handled if above flag enabled - fixed looping problems, including eventual crashes - track switching fixed (lockups and missing video) - corrected resource leaks and crash switching maps #jira UE-46055 #jira UE-45744 #jira UE-46086 Change 3497163 on 2017/06/17 by Max.Preussner MediaUtils: Processing media events immediately if on game thread Change 3497170 on 2017/06/17 by Max.Preussner Media: All Media Framework interfaces are pure virtual Change 3498603 on 2017/06/19 by Ben.Marsh UBT: Prevent plugins which list modules multiple times from adding them twice. Change 3500870 on 2017/06/20 by Max.Preussner WmfMedia: Rewrote WMF state machine; now with track switching #jira UE-20209 #jira UE-35385 #jira UE-38337 #jira UE-45676 Change 3502181 on 2017/06/20 by Chris.Babcock MediaSampler node updates - fixed issue with ExternalTexture singleton for DLL compatiblity - now works for all players (registers texture samples with ExternalTexture by player GUID) - enabled OES in AndroidMediaPlayer now that materials can universally use the MediaSampler Change 3503182 on 2017/06/21 by Max.Preussner Media: Refactored status flags into an enum; exposed connecting status Change 3503724 on 2017/06/21 by Chris.Babcock Improvement in MediaPlayer Sampler node - RGB, R, G, B, A output pins like normal texture sampler - allow preview in material editor - fix OES detection for Android Change 3509088 on 2017/06/26 by Max.Preussner MediaAssets: Added AddFile and AddUrl to UMediaPlaylist Change 3510256 on 2017/06/26 by Max.Preussner WmfMedia: Fixed play rate not set to zero when end reached Change 3510273 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Removed obsolete Slate culling rectangle code Change 3510413 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Showing frame rate if available Change 3510533 on 2017/06/26 by Max.Preussner MediaUtils: Preventing media cache filling up when scrubbing Change 3510859 on 2017/06/26 by Max.Preussner PS4Media: Fixed track switching crashes (UE-45960) #jira UE-45960 Change 3514173 on 2017/06/28 by Max.Preussner WmfMedia: Optimized player capabilities check Change 3514174 on 2017/06/28 by Max.Preussner WmfMedia: Moved media source resolver code into utility class Change 3514714 on 2017/06/28 by Max.Preussner Core: Added TComPointer.IsValid; code cleanup pass Change 3517912 on 2017/06/30 by Max.Preussner MediaUtils: Added GetVideoAspectRatio to player facade Change 3524957 on 2017/07/06 by Max.Preussner ImgMedia: Decoding image frames only when video track is selected Change 3525252 on 2017/07/06 by Max.Preussner ImgMedia: Async image sequence initialization Change 3525266 on 2017/07/06 by Max.Preussner ImgMedia: Enabled reverse playback Change 3525722 on 2017/07/06 by Max.Preussner WmfMedia: Workaround for occasional WMF internal deadlock in IMFRateSupport Change 3525800 on 2017/07/07 by Max.Preussner WmfMedia: Fixed another WMF deadlock issue & some rate change glitches; improved logging. Change 3525801 on 2017/07/07 by Max.Preussner MediaPlayerEditor: Made scrubbing more responsive Change 3526500 on 2017/07/07 by Max.Preussner WmfMedia: Using NULL for Windows pointers Change 3527323 on 2017/07/07 by Max.Preussner WmfMedia: Added support for audio and video capture media sources Change 3530197 on 2017/07/10 by Max.Preussner WmfMedia: Added utility functions for enumerating audio and video capture devices Change 3533465 on 2017/07/12 by Max.Preussner Media: Added media capture device support API & implementation for WMF Change 3533469 on 2017/07/12 by Max.Preussner MediaPlayerEditor: Added source selection menu w/ capture device menu to navigation bar Change 3533540 on 2017/07/12 by Max.Preussner MediaAssets: Blueprint support for media capture device discovery Change 3533574 on 2017/07/12 by Max.Preussner WmfMedia: Using cached supported play rates; more strict pausing support check Change 3533924 on 2017/07/12 by Max.Preussner WmfMedia: Added global LowLatency setting (UEVR-859) Note that this setting is only supported when compiling for Windows 8 or newer. Change 3534027 on 2017/07/12 by Max.Preussner WmfMedia: Compile time support for low latency session attribute on < Windows8 #jira UEVR-859 Change 3538744 on 2017/07/14 by Max.Preussner MediaUtils: Renamed FDefaultMediaTimeSource to FAppMediaTimeSource Change 3542818 on 2017/07/18 by Max.Preussner WmfMedia: Fixed race condition on session shutdown Change 3543082 on 2017/07/18 by Max.Preussner WmfMedia: Fixed track selection in media that doesn't support seeking Change 3543092 on 2017/07/18 by Max.Preussner Media: Implemented media track format API Enables multiple formats per media track. By default, the first usable format is selected. This feature is currently only implemented for WmfMedia. All other players assume a single format per track. Change 3543794 on 2017/07/19 by Max.Preussner WmfMedia: Added string conversion for null GUIDs Change 3543796 on 2017/07/19 by Max.Preussner MfMedia: Copied GUID string conversion updates from WmfMedia Change 3543797 on 2017/07/19 by Max.Preussner WmfMedia: Preventing duplicate track formats in capture devices with legacy DirectX support Change 3544390 on 2017/07/19 by Max.Preussner Media: Allowing INDEX_NONE as 'current selection' index in track format related functions Change 3545368 on 2017/07/19 by Max.Preussner WmfMedia: Fixed session error with some media sources when attempting to seek to current position without ever starting Change 3545388 on 2017/07/19 by Max.Preussner MediaAssets: Fixed RGB input sources rendered upside down Change 3545430 on 2017/07/19 by Max.Preussner MediaAssets: Fixed incorrect sRGB conversion on BMP inputs Change 3547362 on 2017/07/20 by Max.Preussner Core: Added IsGraph and IsPrint to TCHAR utilities Change 3547376 on 2017/07/20 by Max.Preussner WmfMedia: Better log messages for non-standard video types (UE-47533) #jira UE-47533 Change 3547404 on 2017/07/20 by Max.Preussner QAGame: Enabled PlayOnOpen and Looping on MediaPlayerSwitch BP (UE-47542) #jira UE-47542 Change 3547466 on 2017/07/20 by Max.Preussner WmfMedia: Fixed edge case for detecting whether pause is available Change 3548742 on 2017/07/21 by Max.Preussner Media: Added API for changing the input frame rate Change 3548743 on 2017/07/21 by Max.Preussner WmfMedia: Implemented ability to change input frame rate Change 3554411 on 2017/07/25 by Max.Preussner AudioMixer: Broke out SynthComponent initialization code; added bIsUISound property Change 3554818 on 2017/07/25 by Max.Preussner Media: Added per track-type cache queries Change 3557284 on 2017/07/26 by Max.Preussner WmfMedia: Added buffer size check in texture sample as well Change 3560530 on 2017/07/27 by Max.Preussner WmfMedia: Made COM object destructors private and added assertions Change 3560580 on 2017/07/27 by Max.Preussner MediaUtils: Added method for querying number of objects in pool Change 3562572 on 2017/07/28 by Max.Preussner WmfMedia: Properly handling topology status errors when opening media Change 3576710 on 2017/08/08 by Chris.Babcock bug fixes for mediaplayer - rare cases in Android media tracks - make FMediaCaptureDevice members available in blueprints Change 3577736 on 2017/08/08 by Chris.Babcock Extend ExternalTexture to support 2x3 transform (scale/rotation + offset) Change 3578831 on 2017/08/09 by Max.Preussner MediaAssets: Made media sound component BP spawnable Change 3579210 on 2017/08/09 by Max.Preussner UdpMessaging: Not showing warning message if tunnel settings left empty to use defaults Change 3579547 on 2017/08/09 by Chris.Babcock Better support for Android external texture detection Change 3579567 on 2017/08/09 by Chris.Babcock Android camera plugin #jira UEMOB-215 Change 3580035 on 2017/08/10 by Andrew.Rodham Media Texture: External textures are now fully supported and enforced when attempting to sample external texture types in materials. - Textures can now dynamically provide an external texture GUID at runtime, which is queried by the uniform expression. Statically defined GUIDs remain supported. - Added necessary ExternalTexture(Parameter) methods to the material compiler and HLSL translator - Made UTexture::GetMaterialType const-correct #tests Test map that contains TextureObject, TextureObjectParameter, TextureSample and TextureSampleParameter nodes with media textures works on both a Nexus 10 (non-image-external), and a Pixel (image-external), and on desktop PC. Change 3581552 on 2017/08/10 by Chris.Babcock Use bilinear sampling instead of point for external texture (Android media and camera) Change 3581628 on 2017/08/10 by Max.Preussner Core: Fixed FTimespan import/export/copypaste (UE-43990) #jira UE-43990 #jira UE-44163 Change 3581909 on 2017/08/11 by Andrew.Rodham Media: Only cache material proxy pointers if they have been initialized (and thus, will be removed from the cache on release) - This prevents destroyed proxies from remaining in the texture registry #jira UE-48307 Change 3582451 on 2017/08/11 by Max.Preussner AudioMixer: Fixed initialization order of synth components This ensures that the Synth is initialized before OnRegister in the super class initializes and activates the AudioComponents. Previously, the AudioComponent would fail to activate, because Synth was nullptr. #jira UE-48055 Change 3582453 on 2017/08/11 by Max.Preussner MediaAssets: Enabling ticking in media sound component (UE-48055) #jira UE-48055 Change 3583101 on 2017/08/11 by Chris.Babcock Android camera improvements - return correct capture device type (webcamfront/rear) - remove seek (not supported) - support track formats - better framerate selection Change 3590109 on 2017/08/16 by Chris.Babcock Move external texture coordinate update to improve accuracy and save a uniform in final shader Change 3590530 on 2017/08/16 by Max.Preussner MediaAssets: Changed capture device enumeration BP function signatures to allow filter bit masks #jira UE-48166 Change 3590547 on 2017/08/16 by Max.Preussner MediaPlayerEditor: Ticking sound component directly Change 3590628 on 2017/08/16 by Max.Preussner Switch: Fixed media decoder asserting when attempting to pause without having started Change 3591816 on 2017/08/16 by Aaron.McLeran #jira UE-48470 Disabling async processing for procedural sound waves on mac. Change 3592266 on 2017/08/16 by Max.Preussner Media: Replaced media cache with the new sample processing pipeline; continued to implement MfMedia This change fixes stuttering issues with audio and video. However, proper pipeline flushing is not fully implemented yet, so the playback will break after the first playthrough, which might result in freeze frames or out of memory assertions depending on the platform. This will be addressed in an upcoming change. #jira UE-48474 #jira UE-45677 Change 3592355 on 2017/08/17 by Max.Preussner MediaUtils: Added sample sink collection to remove code duplication Change 3592739 on 2017/08/17 by Max.Preussner ImgMedia: Fetching only one video sample per frame Change 3592741 on 2017/08/17 by Max.Preussner MediaUtils: Better sample fetching when paused Change 3592761 on 2017/08/17 by Max.Preussner MediaUtils: Fixed overflow detection in sample sinks Change 3592762 on 2017/08/17 by Max.Preussner ImgMedia: Sending end reached event when looping Change 3592885 on 2017/08/17 by Max.Preussner ImgMedia: Fixed reverse play Change 3592887 on 2017/08/17 by Max.Preussner MediaUtils: Better sample range calculation for audio samples Change 3593010 on 2017/08/17 by Max.Preussner ImgMedia: Fixed async loading of non-EXR image sequences Change 3593193 on 2017/08/17 by Max.Preussner AndroidMedia: Fixed typo Change 3593230 on 2017/08/17 by Max.Preussner Media: Implemented flushing for player sample queues Change 3593346 on 2017/08/17 by Max.Preussner Media: Proper sample processing for reverse playback Change 3593482 on 2017/08/17 by Max.Preussner Switch: Fixed sample range check for reverse playback Change 3594428 on 2017/08/17 by Max.Preussner PS4Media: Fixed video not playing/crashing #jira UE-48547 #jira UE-48549 Change 3595404 on 2017/08/17 by Max.Preussner MediaAssets: Not requesting audio samples if not playing #jira UE-48557 Change 3595624 on 2017/08/17 by Max.Preussner PS4Media: Fixed no looping after track switching #jira UE-46524 #jira UE-48557 Change 3595704 on 2017/08/17 by Max.Preussner MediaUtils: Improved sample queue flushing Eventually this needs to be event-driven. #jira UE-48557 Change 3595706 on 2017/08/17 by Max.Preussner PS4Media: Flushing queues when track switching #jira UE-48557 Change 3595909 on 2017/08/17 by Max.Preussner Matinee: Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) https://github.com/EpicGames/UnrealEngine/pull/3382 #jira UE-42906 #rn Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) Change 3597480 on 2017/08/18 by Max.Preussner ImgMediaPlayer: Fixed presentation time calculation for very large delta times Change 3597669 on 2017/08/18 by Max.Preussner ImgMedia: Setting player stopped instead of paused when end reached Change 3597709 on 2017/08/18 by Max.Preussner SwitchMedia: Fixed audio sample duration calculation Change 3598479 on 2017/08/18 by Max.Preussner ImgMedia: Ensuring that first/last frame is played when starting playback forward/reverse; improved state checking; user logging Change 3598629 on 2017/08/18 by Max.Preussner MediaUtils: Properly handling pending flushes when peeking sample queues Change 3598633 on 2017/08/18 by Max.Preussner WmfMedia: Fixed occasional WMF deadlock when scrubbing Change 3598653 on 2017/08/18 by Max.Preussner MediaUtils: Fixed audio resampling in reverse playback Change 3598659 on 2017/08/18 by Max.Preussner MediaPlayerEditor: Creating sound output only if audio device available Change 3598688 on 2017/08/18 by Max.Preussner MediaUtils: Flushing sample queues on direction change regardless of paused state Change 3599444 on 2017/08/20 by Max.Preussner WmfMedia: Added missing check for rate control when quering supported rates Change 3603661 on 2017/08/22 by Max.Preussner WmfMedia: Fixed NV12 output Change 3604345 on 2017/08/23 by Max.Preussner MediaUtils: Added subtitle samples to media sample collection; fixed documentation Change 3604987 on 2017/08/23 by Max.Preussner PS4Media: Setting correct track format types Change 3605117 on 2017/08/23 by Joe.Barnes Fix issue where presentation time was being treated as milliseconds instead of microseconds. Change 3605128 on 2017/08/23 by Joe.Barnes Fix potential issue calculating total (looped) play time after seek or reset. Track last video presentation time Change 3605139 on 2017/08/23 by Joe.Barnes Support audio type DType_Setup. Fix issue with procedural sounds popping. Consume more samples if necessary. #jira ue-48544 Change 3605197 on 2017/08/23 by Max.Preussner Media: Fixed track display name formatting (UE-48767) #jira UE-48767 Change 3605817 on 2017/08/23 by Max.Chen Auto set sampler type on drop on actor. #jira UE-48769 Change 3605999 on 2017/08/23 by Max.Preussner MfMedia: Restarting source reader when switching tracks #jira UE-48766 Change 3606416 on 2017/08/23 by Max.Preussner PS4Media: Various player improvements #jira UE-48586 Change 3607656 on 2017/08/24 by Max.Preussner WmfMedia: Improved logging for Seek and SetRate Change 3607855 on 2017/08/24 by Max.Preussner MfMedia: Better verbose logging; validating seeks; reduced nesting; fixed track switching\ #jira UE-48766 Change 3608029 on 2017/08/24 by Max.Preussner PS4Media: Fixed streaming media not playing; improved result checks & logging #jira UE-48610 Change 3608473 on 2017/08/24 by Max.Preussner MfMedia: Fixed audio sample duration calculation #jira UE-48756 Change 3609316 on 2017/08/24 by Chris.Babcock Provide external texture RotationScale and Offset from sample Change 3610067 on 2017/08/25 by Richard.Wallis Mac: Editor locks up when Track switching and Mac: Media Audio continues to play after closing player. - Fix for creating extra OS AV media playback objects so audio playback not stopping due to over retained objects. - Trying to access OS AV Media Playback object (esp. the currentTime value) across mutliple threads at once seems to cause deadlock in the Apple libraries - moved location of currentTime acess point to Media Ticker - this sets the current time and is then just returned in the getter when on game main. - Trying to playback audio via OS media playback and through the engine at the same time when enabling the selected audio track. Engine version via sample buffers via AVAssetReaderTrackOutput doesn't seem to be working as intended with the new audio frame work audio sinks - so reverting to OS AV media playback for Mac at the moment until better fix for this can be put in. #jira UE-48590, UE-48604 Change 3610267 on 2017/08/25 by Max.Preussner PS4Media: Added missing track selection validation #jira UE-48765 Change 3610399 on 2017/08/25 by Max.Preussner PS4Media: Fixed infinite player re-initialization loop if track selection failed Change 3610809 on 2017/08/25 by Chris.Babcock Fixes for Android media player and camera player - buffer samples copy proper bytecount - realloc sets new buffer ptr - refcount of Java buffers fixed Change 3610953 on 2017/08/25 by Chris.Babcock Fix audio disable before play on Android media player Change 3611405 on 2017/08/25 by Max.Preussner WmfMedia: Resetting supported rates if RateSupport unavailable Change 3611406 on 2017/08/25 by Max.Preussner MfMedia: Resetting supported rates if RateSupport unavailable Change 3611453 on 2017/08/25 by Chris.Babcock Android external texture extension updates for compatibility Change 3611719 on 2017/08/26 by Max.Preussner Media: Added media event for completed seek operations; flushing sinks on seek Change 3611764 on 2017/08/26 by Max.Preussner AvfMedia: Setting player to preparing state prior to initializing tracks asynchronously Change 3611802 on 2017/08/26 by Max.Preussner Media: Exposed error state in media player Change 3611803 on 2017/08/26 by Max.Preussner MediaPlayerEditor: Showing error state in UI Change 3611887 on 2017/08/26 by Max.Preussner MediaUtils: Corrected media sample sink overflow check Change 3611892 on 2017/08/27 by Max.Preussner WmfMedia: Leaving session in error state after error Change 3611929 on 2017/08/27 by Max.Preussner MediaPlayerEditor: Fixed sound stopping on looping Change 3611930 on 2017/08/27 by Max.Preussner MfMedia: Rewrote async sample processing to fix various playback issues Change 3611942 on 2017/08/27 by Max.Preussner Media: Sending suspension event when playback ended Change 3611957 on 2017/08/27 by Max.Preussner UnrealEd: Allowed transient assets to be resaved to disk Change 3611981 on 2017/08/27 by Max.Preussner PS4Media: Rewrote sample processing to fix various playback issues #jira UE-48596 #jira UE-48793 Change 3612035 on 2017/08/27 by Max.Preussner UnrealEd: Picking standard default names when resaving transient packages Change 3612045 on 2017/08/27 by Max.Preussner Media: Fixed playlists not getting saved correctly from Editor (UE-35382) #jira UE-35382 Change 3612212 on 2017/08/28 by Richard.Wallis Fix for Multitrack Video samples continue to Play on Open after Play on Open is toggled off. Current Rate was not getting reset back to 0.0 on media close. #jira UE-47602 Change 3613531 on 2017/08/28 by Max.Preussner MediaAssets: Fixed external texture related crash on shutdown (UE-48918) Also no longer creating clock sink for media player CDO #jira UE-48918 Change 3613677 on 2017/08/28 by Andrew.Porter Fixed crash at exit in Mac editor caused by double release of AVPlayerItem object #jira UE-48937 Change 3615917 on 2017/08/29 by Max.Preussner MfMedia: Added compile options for DXVA and falling back to synchronous sample reading [CL 3617655 by Max Chen in Main branch]
2017-08-30 09:37:09 -04:00
WorkEvent->Trigger();
}
void FMessageRouter::Exit()
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
TArray<TWeakPtr<IMessageReceiver, ESPMode::ThreadSafe>> Recipients;
// gather all subscribed and registered recipients
for (const auto& RecipientPair : ActiveRecipients)
{
Recipients.AddUnique(RecipientPair.Value);
}
for (const auto& SubscriptionsPair : ActiveSubscriptions)
{
for (const auto& Subscription : SubscriptionsPair.Value)
{
Recipients.AddUnique(Subscription->GetSubscriber());
}
}
}
/* FMessageRouter implementation
*****************************************************************************/
FTimespan FMessageRouter::CalculateWaitTime()
{
FTimespan WaitTime = FTimespan::FromMilliseconds(100);
if (DelayedMessages.Num() > 0)
{
FTimespan DelayedTime = DelayedMessages.HeapTop().Context->GetTimeSent() - CurrentTime;
if (DelayedTime < WaitTime)
{
return DelayedTime;
}
}
return WaitTime;
}
Copying //UE4/Dev-Sequencer to //UE4/Main (Source: //UE4/Dev-Sequencer @ 3617642) #lockdown nick.penwarden #rb none Change 3235667 on 2016/12/14 by Max.Preussner Media: Moved enums into separate header file, so they can be shared Change 3259266 on 2017/01/16 by Max.Preussner Core: Added timespan ratio Change 3267229 on 2017/01/21 by Max.Preussner Editor: Fixed texture samplers in materials not getting notified when sRGB mode changed Change 3274773 on 2017/01/27 by Max.Preussner Core: Added TLruCache template Change 3281579 on 2017/02/01 by Max.Preussner Core: Added scalar division to FTimespan Change 3289522 on 2017/02/07 by Max.Preussner MediaAssets: Added looping for play lists Change 3290664 on 2017/02/07 by Max.Preussner Engine: Moved UTexture material notification code into separate function, so it can be used by derived classes. Change 3290688 on 2017/02/07 by Max.Preussner MediaAssets: Notifying materials when media texture properties changed. Change 3291171 on 2017/02/07 by Max.Preussner MediaAssets: Filtering unused UTexture properties Change 3291229 on 2017/02/07 by Max.Preussner ImgMedia: Use displayWindow instead of dataWindow due to bug in OpenEXR with data window min < 0 Change 3298520 on 2017/02/11 by Max.Preussner Sequencer: Fixed skylight and reflection components off by one frame in PIE Change 3298778 on 2017/02/12 by Max.Preussner MediaUtils: Experimenting with dynamic pitch adjustment Change 3298987 on 2017/02/13 by Max.Chen Editor: Add matrix and transform properties to property editor test object Change 3298997 on 2017/02/13 by Max.Chen Editor: It's now possible to specify Units and ForceUnits meta-data on struct properties - Doing so will cause any child numeric and struct properties to use these units by default (unless another unit was specified) - Added percentage unit type - Multiplier unit types can now be converted between Change 3298998 on 2017/02/13 by Max.Chen Editor: Conversion between multiplier (1.5x) and percentage (150%) units is now possible Change 3348678 on 2017/03/15 by Max.Preussner Media: Added Buffering media event Change 3355268 on 2017/03/20 by Max.Preussner Core: TQueue documentation updates Change 3359055 on 2017/03/22 by Max.Preussner Portal: Removed dependency to Messaging.h Change 3359060 on 2017/03/22 by Max.Preussner Messaging: Modernization pass - added missing includes & forward declarations - include what you use - deprecated shared pointer typedefs - replaced some delegates with callback interfaces - documentation fixes Change 3359189 on 2017/03/22 by Max.Preussner Automation: Modernization pass - include what you use - removed molothic header - documentation fixes #upgradenotes: IAutomationWorkerModule.h is now in the module's public root directory Change 3359718 on 2017/03/22 by Max.Preussner Messaging: Moved common helper classes into MessagingCommon module #upgradenotes: If you use the common helper classes, replace "Messaging" with "MessagingCommon" in your Build.cs files and remove the "Helpers/" subdirectory from your include statements (unless you actually include header files from "Messaging", in which case you need to keep "Messaging" and add "MessagingCommon"). Change 3359793 on 2017/03/23 by Max.Preussner TargetDeviceServices: Modernization pass - include what you use - removed boilerplate header - deprecated selected shared pointer typedefs - reorganized files - documentation fixes Change 3361028 on 2017/03/23 by Max.Preussner DeviceManager: Modernization pass - include what you use - reduced shared pointer typedef usage - documentation fixes Change 3361197 on 2017/03/23 by Max.Preussner Messaging: Waking up message router thread on shutdown Change 3361246 on 2017/03/23 by Max.Preussner AutomationWindow: Removed boilerplate header #upgradenotes: Replace includes of AutomationWindow.h with IAutomationWindowModule.h Change 3361428 on 2017/03/23 by Max.Preussner AutomationController: Removed boilerplate header #upgradenotes: Instead of AutomationController.h, include the individual interface headers that you actually use. Remove the "Interfaces/" subdirectory from existing interface inclusions. Change 3363206 on 2017/03/24 by Max.Preussner ProfileLauncher: Modernization pass - include what you use (selected files) - reduced shared pointer typedef usages - removed dead code - cleaned up file organization - documentation fixes Change 3363290 on 2017/03/24 by Max.Preussner LauncherServices: Removed boilerplate header #upgradenotes: Instead of including LauncherServices.h, include the ILauncherXXX.h files that you actually use. Remove the "Interfaces/" subdirectory from existing ILauncherXXX.h includes Change 3363305 on 2017/03/24 by Max.Preussner LauncherCheck: Removed boilerplate header #upgradenotes: Include ILauncherCheckModule.h instead of LauncherCheck.h. Remove "Interfaces/" subdirectory from existing ILauncherCheckModule.h inclusions Change 3363708 on 2017/03/24 by Max.Preussner ImageWrapper: Removed boilerplate header #upgradenotes: Instead of including ImageWrapper.h, include the actual IImageWrapperXXX.h files that you use. Remove the "Interfaces/" subdirectory from existing IImageWrapperXXX.h includes Change 3363966 on 2017/03/24 by Max.Preussner ImageWrapper: Modernization pass - include what you use - reorganized internal files - documentation fixes Change 3364579 on 2017/03/24 by Max.Preussner ImageWrapper: Deprecated shared pointer typedef and removed usages #upgradenotes: Please use TSharedPtr<IImageWrapper> instead of IImageWrapperPtr Change 3364582 on 2017/03/24 by Max.Preussner NetworkFileSystem: Removed monolithic boilerplate header #upgradenotes: Instead of including NetworkFileServer.h, include the INetworkFileXXX.h headers that you actually use. Remove the "Interfaces/" subdirectory from existing INetworkFileXXX.h includes Change 3381440 on 2017/04/05 by Max.Preussner Oculus: Removed illegal pragmas Change 3391731 on 2017/04/12 by Max.Preussner ImgMedia: Added support for BMP, JPG and PNG image sequences Change 3401146 on 2017/04/19 by Max.Preussner Core: Cleanup pass for FTimespan usages; updated documentation When initializing time span values from single components, consider using the FromHours, FromMinutes, FromSeconds, Zero, MinValue and related methods instead of calling the overloaded constructors as they will make your code easier to read and understand. Change 3401504 on 2017/04/20 by Max.Preussner MCP: Fixed incorrect FTimespan usage of GetMilliseconds instead of GetTotalMilliseconds Change 3401833 on 2017/04/20 by Max.Preussner Core: Various improvements to FTimespan - added proper serialization - updated documentation - access fractions as milli-, micro- or nanoseconds - removed the following string formatters as they were not useful: %D %H %M %S %F - updated documentation #upgradenotes: The %D string formatter (previously total number of days) is now the zero-padded days component of the time span. Time spans are now always exported and stringified with a leading plus or minus sign. #jira UE-43990 #jira UE-44163 Change 3437543 on 2017/05/12 by Max.Preussner PS4Media: Added audio error codes conversion Change 3446564 on 2017/05/18 by Max.Preussner Networking: Fixed nullpointer crash if socket initialization fails Change 3459978 on 2017/05/25 by Max.Preussner ImgMedia: Renamed frame cache to frame loader Change 3463311 on 2017/05/26 by Max.Preussner Core: Added iterators & predicate based methods to LRU Cache Change 3464452 on 2017/05/29 by Max.Preussner ImgMedia: Added video sample output Change 3464468 on 2017/05/29 by Max.Preussner Media: Added separate cache visualization for loaded and cached samples Change 3464592 on 2017/05/29 by Max.Preussner Core: Added TLruCache::FindAndTouch Change 3464607 on 2017/05/29 by Max.Preussner Core: Added TRange::Inclusive / ::Exclusive Change 3464608 on 2017/05/29 by Max.Preussner Media: Fixed incorrect upper bound in support play rates of various players Change 3466732 on 2017/05/30 by Max.Preussner ImgMedia: Added image compression type to info string Change 3466871 on 2017/05/31 by Max.Preussner WmfMedia: Fixed session capabilities not showing up; added initialization logging Change 3467785 on 2017/05/31 by Max.Preussner MfMedia: Fixed sample stride calculated from media input instead of output Change 3467963 on 2017/05/31 by Max.Preussner WmfMedia: Reordered media sub-type string conversion to fix some tracks being reported incorrectly Change 3468110 on 2017/05/31 by Max.Preussner WmfMedia: Added MPEG-2 media sub types to utils Change 3468516 on 2017/05/31 by Max.Preussner AndroidMedia: Allow mediaplayer audio to be disable on Android (UE-45570) Change 3468554 on 2017/05/31 by Max.Preussner MediaAssets: Added AutoClear option to automatically clear media texture when media is unloaded Change 3468627 on 2017/05/31 by Max.Preussner ImgMedia: Allowing for auto-selection of EXR decoder thread count Change 3468648 on 2017/05/31 by Max.Preussner ImgMedia: Reorganized OpenExrWrapper files Change 3471789 on 2017/06/02 by Max.Preussner WmfMedia: Fixed potential concurrency issue in session state management Change 3472918 on 2017/06/03 by Max.Preussner Core: Allowing zero sized LRU cache; added default constructor Change 3472919 on 2017/06/03 by Max.Preussner Media: Added pre-Slate tick stage; renamed some functions; continued to implement sample caching Change 3473704 on 2017/06/05 by Max.Preussner AndroidMedia: Added settings class Change 3474407 on 2017/06/05 by Max.Preussner AndroidMedia: Implemented video sample processing Change 3474934 on 2017/06/05 by Max.Preussner ImgMedia: Fixed crash due to deleting loader work items twice (UE-45705) #jira UE-45705 Change 3476925 on 2017/06/06 by Max.Preussner Media: Added return values to media view interface; documentation fixes Change 3477158 on 2017/06/06 by Max.Preussner SwitchMedia: Implemented sample pooling Change 3477201 on 2017/06/07 by Max.Preussner PS4Media: Implemented video sample pooling Change 3481470 on 2017/06/08 by Max.Preussner Media: Fixed time stamps not set in recycled texture samples Change 3481472 on 2017/06/08 by Max.Preussner MediaAssets: Fixed no video samples fetched while player is in buffering state Change 3481473 on 2017/06/08 by Max.Preussner MediaUtils: Added default constructor to MediaSampleQueue Change 3481584 on 2017/06/08 by Max.Preussner MediaUtils: Paused state is considered forward for sample lookup as this is the common case. Change 3481588 on 2017/06/08 by Max.Preussner PS4Media: Redesigned the PS4 media player to support async file loading & track switching Change 3481627 on 2017/06/08 by Max.Preussner PS4Media: Opening media sources in thread pool if not precaching Change 3481666 on 2017/06/08 by Max.Preussner ImgMedia: Fixed SequencePath property file picker always opening default path Change 3481669 on 2017/06/08 by Max.Preussner ImgMedia: Fixed crash when quering cache state of empty image sequence Change 3481685 on 2017/06/08 by Max.Preussner ImgMedia: Fixed EXR reader failing to play slow loading sequences (UE-45719) #jira UE-45719 Change 3483623 on 2017/06/10 by Max.Preussner Media: Added getters for 360 view settings; added support for relative view updates Change 3483624 on 2017/06/10 by Max.Preussner Media: Added Blueprint support for 360 videos Change 3483626 on 2017/06/10 by Max.Preussner MediaPlayerEditor: Added 360 video mouse controls; broke out viewport widget into separate class. Change 3483627 on 2017/06/10 by Max.Preussner Core: Using system start time instead of current time for renamed log file names Change 3483630 on 2017/06/10 by Max.Preussner Core: Grouping log files by log name and processing each group separately when deleting old log files Change 3483816 on 2017/06/10 by Max.Preussner WmfMedia: Detecting audio device availability to prevent lockup of audio tracks Change 3483939 on 2017/06/11 by Max.Preussner AvfMedia: Finished Media Framework 3.0 upgrade - overhauled track switching - removed render thread flushes - reduced nesting - code cleanup pass Change 3483940 on 2017/06/11 by Max.Preussner Media: Consistent track switching behavior across platforms Change 3484172 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Removed obsolete asset type actions Change 3484180 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Fixed media player info overlays not visible during mouse capture Change 3484248 on 2017/06/11 by Max.Preussner MediaAssets: Media players now always have a playlist Change 3484249 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Added UI controls to Playlist tab Change 3484250 on 2017/06/11 by Max.Preussner Media: Implemented overlay sample caching Change 3484252 on 2017/06/11 by Max.Preussner WmfMedia: Enabled support for .smi and .sami subtitle files Change 3485433 on 2017/06/12 by Max.Preussner ImgMedia: Enabled plug-in on all platforms; enabled EXR only on platforms that support it Change 3485720 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Added ability to save playlists Change 3485828 on 2017/06/12 by Max.Preussner AvfMedia: Thread-safe ticking of video sampler; ticking audio processing on high frequency thread Change 3485926 on 2017/06/12 by Max.Preussner MediaUtils: Draining all unconsumed samples at the end of a frame Change 3486043 on 2017/06/12 by Max.Preussner Media: Consistent behavior for playlist navigation (UE-45964) #jira UE-45964 Change 3486104 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Implemented simple overlay text positioning Change 3486145 on 2017/06/12 by Max.Preussner AndroidMediaPlayer: Moved video sample handling into render thread Change 3486147 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Moved overlay texts into separate layer Change 3486188 on 2017/06/12 by Max.Preussner Media: Enabling media factory modules in Editor for all players Change 3486223 on 2017/06/12 by Max.Preussner Media: Defaulting players to select first audio and video tracks by default Change 3486473 on 2017/06/13 by Max.Preussner Media: Buffering is no longer a media player state, but handled separately (for players that can buffer while playing) Change 3486475 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing busy bar when buffering or preparing Change 3487237 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed video sample not getting processed on render thread Change 3487507 on 2017/06/13 by Michael.Trepka AvfMedia - small cleanup of the code for passing video frame rate to the video sampler Change 3487719 on 2017/06/13 by Michael.Trepka Disable shared PCH in OpenExrWrapper to solve a problem with bUseRTTI mismatch between the module and the PCH Change 3487842 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed texture swizzle disabled on non-Engine builds Change 3488006 on 2017/06/13 by Michael.Trepka AvfMedia - Moved some logic from FAvfMediaPlayer::TickTickable() to FAvfMediaTracks::ProcessAudio() to make it thread safe, plus fixed a bug with the player not setting the current status to Stopped after opening a file Change 3488308 on 2017/06/13 by Chris.Babcock AndroidMedia: Fixed flicker issue #jira UE-45736 Change 3488335 on 2017/06/13 by Max.Preussner MediaAssets: Made UFileMediaSource::GetFullPath public Change 3488338 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Fixed "Show file in Explorer" not working for file media sources Change 3488339 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing a throbber when buffering player Change 3488768 on 2017/06/14 by Max.Preussner Core: Inlined FTimespan static functions hange 3490203 on 2017/06/14 by Max.Preussner Core: Force inlined TComPtr operators Change 3494083 on 2017/06/15 by Chris.Babcock AndroidMedia: Fix playlist looping (send PlaybackEndReached event) #jira UE-46086 Change 3497017 on 2017/06/16 by Max.Preussner MediaAssets: Playlists now auto advance with PlayOnOpen off Change 3497075 on 2017/06/17 by Chris.Babcock MediaPlayer Sampler node and external texture support for Android MediaPlayer - enable with USE_EXTERNALTEXTURE in AndroidMediaPlayer.cpp (disabled in this CL) - supports MediaSample node in material editor with scale/bias handled if above flag enabled - fixed looping problems, including eventual crashes - track switching fixed (lockups and missing video) - corrected resource leaks and crash switching maps #jira UE-46055 #jira UE-45744 #jira UE-46086 Change 3497163 on 2017/06/17 by Max.Preussner MediaUtils: Processing media events immediately if on game thread Change 3497170 on 2017/06/17 by Max.Preussner Media: All Media Framework interfaces are pure virtual Change 3498603 on 2017/06/19 by Ben.Marsh UBT: Prevent plugins which list modules multiple times from adding them twice. Change 3500870 on 2017/06/20 by Max.Preussner WmfMedia: Rewrote WMF state machine; now with track switching #jira UE-20209 #jira UE-35385 #jira UE-38337 #jira UE-45676 Change 3502181 on 2017/06/20 by Chris.Babcock MediaSampler node updates - fixed issue with ExternalTexture singleton for DLL compatiblity - now works for all players (registers texture samples with ExternalTexture by player GUID) - enabled OES in AndroidMediaPlayer now that materials can universally use the MediaSampler Change 3503182 on 2017/06/21 by Max.Preussner Media: Refactored status flags into an enum; exposed connecting status Change 3503724 on 2017/06/21 by Chris.Babcock Improvement in MediaPlayer Sampler node - RGB, R, G, B, A output pins like normal texture sampler - allow preview in material editor - fix OES detection for Android Change 3509088 on 2017/06/26 by Max.Preussner MediaAssets: Added AddFile and AddUrl to UMediaPlaylist Change 3510256 on 2017/06/26 by Max.Preussner WmfMedia: Fixed play rate not set to zero when end reached Change 3510273 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Removed obsolete Slate culling rectangle code Change 3510413 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Showing frame rate if available Change 3510533 on 2017/06/26 by Max.Preussner MediaUtils: Preventing media cache filling up when scrubbing Change 3510859 on 2017/06/26 by Max.Preussner PS4Media: Fixed track switching crashes (UE-45960) #jira UE-45960 Change 3514173 on 2017/06/28 by Max.Preussner WmfMedia: Optimized player capabilities check Change 3514174 on 2017/06/28 by Max.Preussner WmfMedia: Moved media source resolver code into utility class Change 3514714 on 2017/06/28 by Max.Preussner Core: Added TComPointer.IsValid; code cleanup pass Change 3517912 on 2017/06/30 by Max.Preussner MediaUtils: Added GetVideoAspectRatio to player facade Change 3524957 on 2017/07/06 by Max.Preussner ImgMedia: Decoding image frames only when video track is selected Change 3525252 on 2017/07/06 by Max.Preussner ImgMedia: Async image sequence initialization Change 3525266 on 2017/07/06 by Max.Preussner ImgMedia: Enabled reverse playback Change 3525722 on 2017/07/06 by Max.Preussner WmfMedia: Workaround for occasional WMF internal deadlock in IMFRateSupport Change 3525800 on 2017/07/07 by Max.Preussner WmfMedia: Fixed another WMF deadlock issue & some rate change glitches; improved logging. Change 3525801 on 2017/07/07 by Max.Preussner MediaPlayerEditor: Made scrubbing more responsive Change 3526500 on 2017/07/07 by Max.Preussner WmfMedia: Using NULL for Windows pointers Change 3527323 on 2017/07/07 by Max.Preussner WmfMedia: Added support for audio and video capture media sources Change 3530197 on 2017/07/10 by Max.Preussner WmfMedia: Added utility functions for enumerating audio and video capture devices Change 3533465 on 2017/07/12 by Max.Preussner Media: Added media capture device support API & implementation for WMF Change 3533469 on 2017/07/12 by Max.Preussner MediaPlayerEditor: Added source selection menu w/ capture device menu to navigation bar Change 3533540 on 2017/07/12 by Max.Preussner MediaAssets: Blueprint support for media capture device discovery Change 3533574 on 2017/07/12 by Max.Preussner WmfMedia: Using cached supported play rates; more strict pausing support check Change 3533924 on 2017/07/12 by Max.Preussner WmfMedia: Added global LowLatency setting (UEVR-859) Note that this setting is only supported when compiling for Windows 8 or newer. Change 3534027 on 2017/07/12 by Max.Preussner WmfMedia: Compile time support for low latency session attribute on < Windows8 #jira UEVR-859 Change 3538744 on 2017/07/14 by Max.Preussner MediaUtils: Renamed FDefaultMediaTimeSource to FAppMediaTimeSource Change 3542818 on 2017/07/18 by Max.Preussner WmfMedia: Fixed race condition on session shutdown Change 3543082 on 2017/07/18 by Max.Preussner WmfMedia: Fixed track selection in media that doesn't support seeking Change 3543092 on 2017/07/18 by Max.Preussner Media: Implemented media track format API Enables multiple formats per media track. By default, the first usable format is selected. This feature is currently only implemented for WmfMedia. All other players assume a single format per track. Change 3543794 on 2017/07/19 by Max.Preussner WmfMedia: Added string conversion for null GUIDs Change 3543796 on 2017/07/19 by Max.Preussner MfMedia: Copied GUID string conversion updates from WmfMedia Change 3543797 on 2017/07/19 by Max.Preussner WmfMedia: Preventing duplicate track formats in capture devices with legacy DirectX support Change 3544390 on 2017/07/19 by Max.Preussner Media: Allowing INDEX_NONE as 'current selection' index in track format related functions Change 3545368 on 2017/07/19 by Max.Preussner WmfMedia: Fixed session error with some media sources when attempting to seek to current position without ever starting Change 3545388 on 2017/07/19 by Max.Preussner MediaAssets: Fixed RGB input sources rendered upside down Change 3545430 on 2017/07/19 by Max.Preussner MediaAssets: Fixed incorrect sRGB conversion on BMP inputs Change 3547362 on 2017/07/20 by Max.Preussner Core: Added IsGraph and IsPrint to TCHAR utilities Change 3547376 on 2017/07/20 by Max.Preussner WmfMedia: Better log messages for non-standard video types (UE-47533) #jira UE-47533 Change 3547404 on 2017/07/20 by Max.Preussner QAGame: Enabled PlayOnOpen and Looping on MediaPlayerSwitch BP (UE-47542) #jira UE-47542 Change 3547466 on 2017/07/20 by Max.Preussner WmfMedia: Fixed edge case for detecting whether pause is available Change 3548742 on 2017/07/21 by Max.Preussner Media: Added API for changing the input frame rate Change 3548743 on 2017/07/21 by Max.Preussner WmfMedia: Implemented ability to change input frame rate Change 3554411 on 2017/07/25 by Max.Preussner AudioMixer: Broke out SynthComponent initialization code; added bIsUISound property Change 3554818 on 2017/07/25 by Max.Preussner Media: Added per track-type cache queries Change 3557284 on 2017/07/26 by Max.Preussner WmfMedia: Added buffer size check in texture sample as well Change 3560530 on 2017/07/27 by Max.Preussner WmfMedia: Made COM object destructors private and added assertions Change 3560580 on 2017/07/27 by Max.Preussner MediaUtils: Added method for querying number of objects in pool Change 3562572 on 2017/07/28 by Max.Preussner WmfMedia: Properly handling topology status errors when opening media Change 3576710 on 2017/08/08 by Chris.Babcock bug fixes for mediaplayer - rare cases in Android media tracks - make FMediaCaptureDevice members available in blueprints Change 3577736 on 2017/08/08 by Chris.Babcock Extend ExternalTexture to support 2x3 transform (scale/rotation + offset) Change 3578831 on 2017/08/09 by Max.Preussner MediaAssets: Made media sound component BP spawnable Change 3579210 on 2017/08/09 by Max.Preussner UdpMessaging: Not showing warning message if tunnel settings left empty to use defaults Change 3579547 on 2017/08/09 by Chris.Babcock Better support for Android external texture detection Change 3579567 on 2017/08/09 by Chris.Babcock Android camera plugin #jira UEMOB-215 Change 3580035 on 2017/08/10 by Andrew.Rodham Media Texture: External textures are now fully supported and enforced when attempting to sample external texture types in materials. - Textures can now dynamically provide an external texture GUID at runtime, which is queried by the uniform expression. Statically defined GUIDs remain supported. - Added necessary ExternalTexture(Parameter) methods to the material compiler and HLSL translator - Made UTexture::GetMaterialType const-correct #tests Test map that contains TextureObject, TextureObjectParameter, TextureSample and TextureSampleParameter nodes with media textures works on both a Nexus 10 (non-image-external), and a Pixel (image-external), and on desktop PC. Change 3581552 on 2017/08/10 by Chris.Babcock Use bilinear sampling instead of point for external texture (Android media and camera) Change 3581628 on 2017/08/10 by Max.Preussner Core: Fixed FTimespan import/export/copypaste (UE-43990) #jira UE-43990 #jira UE-44163 Change 3581909 on 2017/08/11 by Andrew.Rodham Media: Only cache material proxy pointers if they have been initialized (and thus, will be removed from the cache on release) - This prevents destroyed proxies from remaining in the texture registry #jira UE-48307 Change 3582451 on 2017/08/11 by Max.Preussner AudioMixer: Fixed initialization order of synth components This ensures that the Synth is initialized before OnRegister in the super class initializes and activates the AudioComponents. Previously, the AudioComponent would fail to activate, because Synth was nullptr. #jira UE-48055 Change 3582453 on 2017/08/11 by Max.Preussner MediaAssets: Enabling ticking in media sound component (UE-48055) #jira UE-48055 Change 3583101 on 2017/08/11 by Chris.Babcock Android camera improvements - return correct capture device type (webcamfront/rear) - remove seek (not supported) - support track formats - better framerate selection Change 3590109 on 2017/08/16 by Chris.Babcock Move external texture coordinate update to improve accuracy and save a uniform in final shader Change 3590530 on 2017/08/16 by Max.Preussner MediaAssets: Changed capture device enumeration BP function signatures to allow filter bit masks #jira UE-48166 Change 3590547 on 2017/08/16 by Max.Preussner MediaPlayerEditor: Ticking sound component directly Change 3590628 on 2017/08/16 by Max.Preussner Switch: Fixed media decoder asserting when attempting to pause without having started Change 3591816 on 2017/08/16 by Aaron.McLeran #jira UE-48470 Disabling async processing for procedural sound waves on mac. Change 3592266 on 2017/08/16 by Max.Preussner Media: Replaced media cache with the new sample processing pipeline; continued to implement MfMedia This change fixes stuttering issues with audio and video. However, proper pipeline flushing is not fully implemented yet, so the playback will break after the first playthrough, which might result in freeze frames or out of memory assertions depending on the platform. This will be addressed in an upcoming change. #jira UE-48474 #jira UE-45677 Change 3592355 on 2017/08/17 by Max.Preussner MediaUtils: Added sample sink collection to remove code duplication Change 3592739 on 2017/08/17 by Max.Preussner ImgMedia: Fetching only one video sample per frame Change 3592741 on 2017/08/17 by Max.Preussner MediaUtils: Better sample fetching when paused Change 3592761 on 2017/08/17 by Max.Preussner MediaUtils: Fixed overflow detection in sample sinks Change 3592762 on 2017/08/17 by Max.Preussner ImgMedia: Sending end reached event when looping Change 3592885 on 2017/08/17 by Max.Preussner ImgMedia: Fixed reverse play Change 3592887 on 2017/08/17 by Max.Preussner MediaUtils: Better sample range calculation for audio samples Change 3593010 on 2017/08/17 by Max.Preussner ImgMedia: Fixed async loading of non-EXR image sequences Change 3593193 on 2017/08/17 by Max.Preussner AndroidMedia: Fixed typo Change 3593230 on 2017/08/17 by Max.Preussner Media: Implemented flushing for player sample queues Change 3593346 on 2017/08/17 by Max.Preussner Media: Proper sample processing for reverse playback Change 3593482 on 2017/08/17 by Max.Preussner Switch: Fixed sample range check for reverse playback Change 3594428 on 2017/08/17 by Max.Preussner PS4Media: Fixed video not playing/crashing #jira UE-48547 #jira UE-48549 Change 3595404 on 2017/08/17 by Max.Preussner MediaAssets: Not requesting audio samples if not playing #jira UE-48557 Change 3595624 on 2017/08/17 by Max.Preussner PS4Media: Fixed no looping after track switching #jira UE-46524 #jira UE-48557 Change 3595704 on 2017/08/17 by Max.Preussner MediaUtils: Improved sample queue flushing Eventually this needs to be event-driven. #jira UE-48557 Change 3595706 on 2017/08/17 by Max.Preussner PS4Media: Flushing queues when track switching #jira UE-48557 Change 3595909 on 2017/08/17 by Max.Preussner Matinee: Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) https://github.com/EpicGames/UnrealEngine/pull/3382 #jira UE-42906 #rn Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) Change 3597480 on 2017/08/18 by Max.Preussner ImgMediaPlayer: Fixed presentation time calculation for very large delta times Change 3597669 on 2017/08/18 by Max.Preussner ImgMedia: Setting player stopped instead of paused when end reached Change 3597709 on 2017/08/18 by Max.Preussner SwitchMedia: Fixed audio sample duration calculation Change 3598479 on 2017/08/18 by Max.Preussner ImgMedia: Ensuring that first/last frame is played when starting playback forward/reverse; improved state checking; user logging Change 3598629 on 2017/08/18 by Max.Preussner MediaUtils: Properly handling pending flushes when peeking sample queues Change 3598633 on 2017/08/18 by Max.Preussner WmfMedia: Fixed occasional WMF deadlock when scrubbing Change 3598653 on 2017/08/18 by Max.Preussner MediaUtils: Fixed audio resampling in reverse playback Change 3598659 on 2017/08/18 by Max.Preussner MediaPlayerEditor: Creating sound output only if audio device available Change 3598688 on 2017/08/18 by Max.Preussner MediaUtils: Flushing sample queues on direction change regardless of paused state Change 3599444 on 2017/08/20 by Max.Preussner WmfMedia: Added missing check for rate control when quering supported rates Change 3603661 on 2017/08/22 by Max.Preussner WmfMedia: Fixed NV12 output Change 3604345 on 2017/08/23 by Max.Preussner MediaUtils: Added subtitle samples to media sample collection; fixed documentation Change 3604987 on 2017/08/23 by Max.Preussner PS4Media: Setting correct track format types Change 3605117 on 2017/08/23 by Joe.Barnes Fix issue where presentation time was being treated as milliseconds instead of microseconds. Change 3605128 on 2017/08/23 by Joe.Barnes Fix potential issue calculating total (looped) play time after seek or reset. Track last video presentation time Change 3605139 on 2017/08/23 by Joe.Barnes Support audio type DType_Setup. Fix issue with procedural sounds popping. Consume more samples if necessary. #jira ue-48544 Change 3605197 on 2017/08/23 by Max.Preussner Media: Fixed track display name formatting (UE-48767) #jira UE-48767 Change 3605817 on 2017/08/23 by Max.Chen Auto set sampler type on drop on actor. #jira UE-48769 Change 3605999 on 2017/08/23 by Max.Preussner MfMedia: Restarting source reader when switching tracks #jira UE-48766 Change 3606416 on 2017/08/23 by Max.Preussner PS4Media: Various player improvements #jira UE-48586 Change 3607656 on 2017/08/24 by Max.Preussner WmfMedia: Improved logging for Seek and SetRate Change 3607855 on 2017/08/24 by Max.Preussner MfMedia: Better verbose logging; validating seeks; reduced nesting; fixed track switching\ #jira UE-48766 Change 3608029 on 2017/08/24 by Max.Preussner PS4Media: Fixed streaming media not playing; improved result checks & logging #jira UE-48610 Change 3608473 on 2017/08/24 by Max.Preussner MfMedia: Fixed audio sample duration calculation #jira UE-48756 Change 3609316 on 2017/08/24 by Chris.Babcock Provide external texture RotationScale and Offset from sample Change 3610067 on 2017/08/25 by Richard.Wallis Mac: Editor locks up when Track switching and Mac: Media Audio continues to play after closing player. - Fix for creating extra OS AV media playback objects so audio playback not stopping due to over retained objects. - Trying to access OS AV Media Playback object (esp. the currentTime value) across mutliple threads at once seems to cause deadlock in the Apple libraries - moved location of currentTime acess point to Media Ticker - this sets the current time and is then just returned in the getter when on game main. - Trying to playback audio via OS media playback and through the engine at the same time when enabling the selected audio track. Engine version via sample buffers via AVAssetReaderTrackOutput doesn't seem to be working as intended with the new audio frame work audio sinks - so reverting to OS AV media playback for Mac at the moment until better fix for this can be put in. #jira UE-48590, UE-48604 Change 3610267 on 2017/08/25 by Max.Preussner PS4Media: Added missing track selection validation #jira UE-48765 Change 3610399 on 2017/08/25 by Max.Preussner PS4Media: Fixed infinite player re-initialization loop if track selection failed Change 3610809 on 2017/08/25 by Chris.Babcock Fixes for Android media player and camera player - buffer samples copy proper bytecount - realloc sets new buffer ptr - refcount of Java buffers fixed Change 3610953 on 2017/08/25 by Chris.Babcock Fix audio disable before play on Android media player Change 3611405 on 2017/08/25 by Max.Preussner WmfMedia: Resetting supported rates if RateSupport unavailable Change 3611406 on 2017/08/25 by Max.Preussner MfMedia: Resetting supported rates if RateSupport unavailable Change 3611453 on 2017/08/25 by Chris.Babcock Android external texture extension updates for compatibility Change 3611719 on 2017/08/26 by Max.Preussner Media: Added media event for completed seek operations; flushing sinks on seek Change 3611764 on 2017/08/26 by Max.Preussner AvfMedia: Setting player to preparing state prior to initializing tracks asynchronously Change 3611802 on 2017/08/26 by Max.Preussner Media: Exposed error state in media player Change 3611803 on 2017/08/26 by Max.Preussner MediaPlayerEditor: Showing error state in UI Change 3611887 on 2017/08/26 by Max.Preussner MediaUtils: Corrected media sample sink overflow check Change 3611892 on 2017/08/27 by Max.Preussner WmfMedia: Leaving session in error state after error Change 3611929 on 2017/08/27 by Max.Preussner MediaPlayerEditor: Fixed sound stopping on looping Change 3611930 on 2017/08/27 by Max.Preussner MfMedia: Rewrote async sample processing to fix various playback issues Change 3611942 on 2017/08/27 by Max.Preussner Media: Sending suspension event when playback ended Change 3611957 on 2017/08/27 by Max.Preussner UnrealEd: Allowed transient assets to be resaved to disk Change 3611981 on 2017/08/27 by Max.Preussner PS4Media: Rewrote sample processing to fix various playback issues #jira UE-48596 #jira UE-48793 Change 3612035 on 2017/08/27 by Max.Preussner UnrealEd: Picking standard default names when resaving transient packages Change 3612045 on 2017/08/27 by Max.Preussner Media: Fixed playlists not getting saved correctly from Editor (UE-35382) #jira UE-35382 Change 3612212 on 2017/08/28 by Richard.Wallis Fix for Multitrack Video samples continue to Play on Open after Play on Open is toggled off. Current Rate was not getting reset back to 0.0 on media close. #jira UE-47602 Change 3613531 on 2017/08/28 by Max.Preussner MediaAssets: Fixed external texture related crash on shutdown (UE-48918) Also no longer creating clock sink for media player CDO #jira UE-48918 Change 3613677 on 2017/08/28 by Andrew.Porter Fixed crash at exit in Mac editor caused by double release of AVPlayerItem object #jira UE-48937 Change 3615917 on 2017/08/29 by Max.Preussner MfMedia: Added compile options for DXVA and falling back to synchronous sample reading [CL 3617655 by Max Chen in Main branch]
2017-08-30 09:37:09 -04:00
void FMessageRouter::DispatchMessage(const TSharedRef<IMessageContext, ESPMode::ThreadSafe>& Context)
{
if (Context->IsValid())
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
TArray<TSharedPtr<IMessageReceiver, ESPMode::ThreadSafe>> Recipients;
int32 RecipientCount = Context->GetRecipients().Num();
// get recipients, either from the context...
if (RecipientCount > 0)
{
if (UE_GET_LOG_VERBOSITY(LogMessaging) >= ELogVerbosity::Verbose)
{
FString RecipientStr = FString::JoinBy(Context->GetRecipients(), TEXT("+"), &FMessageAddress::ToString);
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UE_LOG(LogMessaging, Verbose, TEXT("Dispatching %s from %s to %s"), *Context->GetMessageTypePathName().ToString(), *Context->GetSender().ToString(), *RecipientStr);
}
FilterRecipients(Context, Recipients);
if (Recipients.Num() < RecipientCount)
{
UE_LOG(LogMessaging, Verbose, TEXT("%d recipients were filtered out"), RecipientCount - Recipients.Num());
}
}
// ... or from subscriptions
else
{
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
FilterSubscriptions(ActiveSubscriptions.FindOrAdd(Context->GetMessageTypePathName()), Context, Recipients);
FilterSubscriptions(ActiveSubscriptions.FindOrAdd(IMessageBus::PATHNAME_All), Context, Recipients);
if (UE_GET_LOG_VERBOSITY(LogMessaging) >= ELogVerbosity::Verbose)
{
FString RecipientStr = FString::JoinBy(Context->GetRecipients(), TEXT("+"), &FMessageAddress::ToString);
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UE_LOG(LogMessaging, Verbose, TEXT("Dispatching %s from %s to %s subscribers"), *Context->GetMessageTypePathName().ToString(), *Context->GetSender().ToString(), *RecipientStr);
}
}
// dispatch the message
for (auto& Recipient : Recipients)
{
ENamedThreads::Type RecipientThread = Recipient->GetRecipientThread();
if (RecipientThread == ENamedThreads::AnyThread)
{
Tracer->TraceDispatchedMessage(Context, Recipient.ToSharedRef(), false);
Recipient->ReceiveMessage(Context);
Tracer->TraceHandledMessage(Context, Recipient.ToSharedRef());
}
else
{
TGraphTask<FMessageDispatchTask>::CreateTask().ConstructAndDispatchWhenReady(RecipientThread, Context, Recipient, Tracer);
}
}
}
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
void FMessageRouter::FilterSubscriptions(
TArray<TSharedPtr<IMessageSubscription, ESPMode::ThreadSafe>>& Subscriptions,
Copying //UE4/Dev-Sequencer to //UE4/Main (Source: //UE4/Dev-Sequencer @ 3617642) #lockdown nick.penwarden #rb none Change 3235667 on 2016/12/14 by Max.Preussner Media: Moved enums into separate header file, so they can be shared Change 3259266 on 2017/01/16 by Max.Preussner Core: Added timespan ratio Change 3267229 on 2017/01/21 by Max.Preussner Editor: Fixed texture samplers in materials not getting notified when sRGB mode changed Change 3274773 on 2017/01/27 by Max.Preussner Core: Added TLruCache template Change 3281579 on 2017/02/01 by Max.Preussner Core: Added scalar division to FTimespan Change 3289522 on 2017/02/07 by Max.Preussner MediaAssets: Added looping for play lists Change 3290664 on 2017/02/07 by Max.Preussner Engine: Moved UTexture material notification code into separate function, so it can be used by derived classes. Change 3290688 on 2017/02/07 by Max.Preussner MediaAssets: Notifying materials when media texture properties changed. Change 3291171 on 2017/02/07 by Max.Preussner MediaAssets: Filtering unused UTexture properties Change 3291229 on 2017/02/07 by Max.Preussner ImgMedia: Use displayWindow instead of dataWindow due to bug in OpenEXR with data window min < 0 Change 3298520 on 2017/02/11 by Max.Preussner Sequencer: Fixed skylight and reflection components off by one frame in PIE Change 3298778 on 2017/02/12 by Max.Preussner MediaUtils: Experimenting with dynamic pitch adjustment Change 3298987 on 2017/02/13 by Max.Chen Editor: Add matrix and transform properties to property editor test object Change 3298997 on 2017/02/13 by Max.Chen Editor: It's now possible to specify Units and ForceUnits meta-data on struct properties - Doing so will cause any child numeric and struct properties to use these units by default (unless another unit was specified) - Added percentage unit type - Multiplier unit types can now be converted between Change 3298998 on 2017/02/13 by Max.Chen Editor: Conversion between multiplier (1.5x) and percentage (150%) units is now possible Change 3348678 on 2017/03/15 by Max.Preussner Media: Added Buffering media event Change 3355268 on 2017/03/20 by Max.Preussner Core: TQueue documentation updates Change 3359055 on 2017/03/22 by Max.Preussner Portal: Removed dependency to Messaging.h Change 3359060 on 2017/03/22 by Max.Preussner Messaging: Modernization pass - added missing includes & forward declarations - include what you use - deprecated shared pointer typedefs - replaced some delegates with callback interfaces - documentation fixes Change 3359189 on 2017/03/22 by Max.Preussner Automation: Modernization pass - include what you use - removed molothic header - documentation fixes #upgradenotes: IAutomationWorkerModule.h is now in the module's public root directory Change 3359718 on 2017/03/22 by Max.Preussner Messaging: Moved common helper classes into MessagingCommon module #upgradenotes: If you use the common helper classes, replace "Messaging" with "MessagingCommon" in your Build.cs files and remove the "Helpers/" subdirectory from your include statements (unless you actually include header files from "Messaging", in which case you need to keep "Messaging" and add "MessagingCommon"). Change 3359793 on 2017/03/23 by Max.Preussner TargetDeviceServices: Modernization pass - include what you use - removed boilerplate header - deprecated selected shared pointer typedefs - reorganized files - documentation fixes Change 3361028 on 2017/03/23 by Max.Preussner DeviceManager: Modernization pass - include what you use - reduced shared pointer typedef usage - documentation fixes Change 3361197 on 2017/03/23 by Max.Preussner Messaging: Waking up message router thread on shutdown Change 3361246 on 2017/03/23 by Max.Preussner AutomationWindow: Removed boilerplate header #upgradenotes: Replace includes of AutomationWindow.h with IAutomationWindowModule.h Change 3361428 on 2017/03/23 by Max.Preussner AutomationController: Removed boilerplate header #upgradenotes: Instead of AutomationController.h, include the individual interface headers that you actually use. Remove the "Interfaces/" subdirectory from existing interface inclusions. Change 3363206 on 2017/03/24 by Max.Preussner ProfileLauncher: Modernization pass - include what you use (selected files) - reduced shared pointer typedef usages - removed dead code - cleaned up file organization - documentation fixes Change 3363290 on 2017/03/24 by Max.Preussner LauncherServices: Removed boilerplate header #upgradenotes: Instead of including LauncherServices.h, include the ILauncherXXX.h files that you actually use. Remove the "Interfaces/" subdirectory from existing ILauncherXXX.h includes Change 3363305 on 2017/03/24 by Max.Preussner LauncherCheck: Removed boilerplate header #upgradenotes: Include ILauncherCheckModule.h instead of LauncherCheck.h. Remove "Interfaces/" subdirectory from existing ILauncherCheckModule.h inclusions Change 3363708 on 2017/03/24 by Max.Preussner ImageWrapper: Removed boilerplate header #upgradenotes: Instead of including ImageWrapper.h, include the actual IImageWrapperXXX.h files that you use. Remove the "Interfaces/" subdirectory from existing IImageWrapperXXX.h includes Change 3363966 on 2017/03/24 by Max.Preussner ImageWrapper: Modernization pass - include what you use - reorganized internal files - documentation fixes Change 3364579 on 2017/03/24 by Max.Preussner ImageWrapper: Deprecated shared pointer typedef and removed usages #upgradenotes: Please use TSharedPtr<IImageWrapper> instead of IImageWrapperPtr Change 3364582 on 2017/03/24 by Max.Preussner NetworkFileSystem: Removed monolithic boilerplate header #upgradenotes: Instead of including NetworkFileServer.h, include the INetworkFileXXX.h headers that you actually use. Remove the "Interfaces/" subdirectory from existing INetworkFileXXX.h includes Change 3381440 on 2017/04/05 by Max.Preussner Oculus: Removed illegal pragmas Change 3391731 on 2017/04/12 by Max.Preussner ImgMedia: Added support for BMP, JPG and PNG image sequences Change 3401146 on 2017/04/19 by Max.Preussner Core: Cleanup pass for FTimespan usages; updated documentation When initializing time span values from single components, consider using the FromHours, FromMinutes, FromSeconds, Zero, MinValue and related methods instead of calling the overloaded constructors as they will make your code easier to read and understand. Change 3401504 on 2017/04/20 by Max.Preussner MCP: Fixed incorrect FTimespan usage of GetMilliseconds instead of GetTotalMilliseconds Change 3401833 on 2017/04/20 by Max.Preussner Core: Various improvements to FTimespan - added proper serialization - updated documentation - access fractions as milli-, micro- or nanoseconds - removed the following string formatters as they were not useful: %D %H %M %S %F - updated documentation #upgradenotes: The %D string formatter (previously total number of days) is now the zero-padded days component of the time span. Time spans are now always exported and stringified with a leading plus or minus sign. #jira UE-43990 #jira UE-44163 Change 3437543 on 2017/05/12 by Max.Preussner PS4Media: Added audio error codes conversion Change 3446564 on 2017/05/18 by Max.Preussner Networking: Fixed nullpointer crash if socket initialization fails Change 3459978 on 2017/05/25 by Max.Preussner ImgMedia: Renamed frame cache to frame loader Change 3463311 on 2017/05/26 by Max.Preussner Core: Added iterators & predicate based methods to LRU Cache Change 3464452 on 2017/05/29 by Max.Preussner ImgMedia: Added video sample output Change 3464468 on 2017/05/29 by Max.Preussner Media: Added separate cache visualization for loaded and cached samples Change 3464592 on 2017/05/29 by Max.Preussner Core: Added TLruCache::FindAndTouch Change 3464607 on 2017/05/29 by Max.Preussner Core: Added TRange::Inclusive / ::Exclusive Change 3464608 on 2017/05/29 by Max.Preussner Media: Fixed incorrect upper bound in support play rates of various players Change 3466732 on 2017/05/30 by Max.Preussner ImgMedia: Added image compression type to info string Change 3466871 on 2017/05/31 by Max.Preussner WmfMedia: Fixed session capabilities not showing up; added initialization logging Change 3467785 on 2017/05/31 by Max.Preussner MfMedia: Fixed sample stride calculated from media input instead of output Change 3467963 on 2017/05/31 by Max.Preussner WmfMedia: Reordered media sub-type string conversion to fix some tracks being reported incorrectly Change 3468110 on 2017/05/31 by Max.Preussner WmfMedia: Added MPEG-2 media sub types to utils Change 3468516 on 2017/05/31 by Max.Preussner AndroidMedia: Allow mediaplayer audio to be disable on Android (UE-45570) Change 3468554 on 2017/05/31 by Max.Preussner MediaAssets: Added AutoClear option to automatically clear media texture when media is unloaded Change 3468627 on 2017/05/31 by Max.Preussner ImgMedia: Allowing for auto-selection of EXR decoder thread count Change 3468648 on 2017/05/31 by Max.Preussner ImgMedia: Reorganized OpenExrWrapper files Change 3471789 on 2017/06/02 by Max.Preussner WmfMedia: Fixed potential concurrency issue in session state management Change 3472918 on 2017/06/03 by Max.Preussner Core: Allowing zero sized LRU cache; added default constructor Change 3472919 on 2017/06/03 by Max.Preussner Media: Added pre-Slate tick stage; renamed some functions; continued to implement sample caching Change 3473704 on 2017/06/05 by Max.Preussner AndroidMedia: Added settings class Change 3474407 on 2017/06/05 by Max.Preussner AndroidMedia: Implemented video sample processing Change 3474934 on 2017/06/05 by Max.Preussner ImgMedia: Fixed crash due to deleting loader work items twice (UE-45705) #jira UE-45705 Change 3476925 on 2017/06/06 by Max.Preussner Media: Added return values to media view interface; documentation fixes Change 3477158 on 2017/06/06 by Max.Preussner SwitchMedia: Implemented sample pooling Change 3477201 on 2017/06/07 by Max.Preussner PS4Media: Implemented video sample pooling Change 3481470 on 2017/06/08 by Max.Preussner Media: Fixed time stamps not set in recycled texture samples Change 3481472 on 2017/06/08 by Max.Preussner MediaAssets: Fixed no video samples fetched while player is in buffering state Change 3481473 on 2017/06/08 by Max.Preussner MediaUtils: Added default constructor to MediaSampleQueue Change 3481584 on 2017/06/08 by Max.Preussner MediaUtils: Paused state is considered forward for sample lookup as this is the common case. Change 3481588 on 2017/06/08 by Max.Preussner PS4Media: Redesigned the PS4 media player to support async file loading & track switching Change 3481627 on 2017/06/08 by Max.Preussner PS4Media: Opening media sources in thread pool if not precaching Change 3481666 on 2017/06/08 by Max.Preussner ImgMedia: Fixed SequencePath property file picker always opening default path Change 3481669 on 2017/06/08 by Max.Preussner ImgMedia: Fixed crash when quering cache state of empty image sequence Change 3481685 on 2017/06/08 by Max.Preussner ImgMedia: Fixed EXR reader failing to play slow loading sequences (UE-45719) #jira UE-45719 Change 3483623 on 2017/06/10 by Max.Preussner Media: Added getters for 360 view settings; added support for relative view updates Change 3483624 on 2017/06/10 by Max.Preussner Media: Added Blueprint support for 360 videos Change 3483626 on 2017/06/10 by Max.Preussner MediaPlayerEditor: Added 360 video mouse controls; broke out viewport widget into separate class. Change 3483627 on 2017/06/10 by Max.Preussner Core: Using system start time instead of current time for renamed log file names Change 3483630 on 2017/06/10 by Max.Preussner Core: Grouping log files by log name and processing each group separately when deleting old log files Change 3483816 on 2017/06/10 by Max.Preussner WmfMedia: Detecting audio device availability to prevent lockup of audio tracks Change 3483939 on 2017/06/11 by Max.Preussner AvfMedia: Finished Media Framework 3.0 upgrade - overhauled track switching - removed render thread flushes - reduced nesting - code cleanup pass Change 3483940 on 2017/06/11 by Max.Preussner Media: Consistent track switching behavior across platforms Change 3484172 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Removed obsolete asset type actions Change 3484180 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Fixed media player info overlays not visible during mouse capture Change 3484248 on 2017/06/11 by Max.Preussner MediaAssets: Media players now always have a playlist Change 3484249 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Added UI controls to Playlist tab Change 3484250 on 2017/06/11 by Max.Preussner Media: Implemented overlay sample caching Change 3484252 on 2017/06/11 by Max.Preussner WmfMedia: Enabled support for .smi and .sami subtitle files Change 3485433 on 2017/06/12 by Max.Preussner ImgMedia: Enabled plug-in on all platforms; enabled EXR only on platforms that support it Change 3485720 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Added ability to save playlists Change 3485828 on 2017/06/12 by Max.Preussner AvfMedia: Thread-safe ticking of video sampler; ticking audio processing on high frequency thread Change 3485926 on 2017/06/12 by Max.Preussner MediaUtils: Draining all unconsumed samples at the end of a frame Change 3486043 on 2017/06/12 by Max.Preussner Media: Consistent behavior for playlist navigation (UE-45964) #jira UE-45964 Change 3486104 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Implemented simple overlay text positioning Change 3486145 on 2017/06/12 by Max.Preussner AndroidMediaPlayer: Moved video sample handling into render thread Change 3486147 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Moved overlay texts into separate layer Change 3486188 on 2017/06/12 by Max.Preussner Media: Enabling media factory modules in Editor for all players Change 3486223 on 2017/06/12 by Max.Preussner Media: Defaulting players to select first audio and video tracks by default Change 3486473 on 2017/06/13 by Max.Preussner Media: Buffering is no longer a media player state, but handled separately (for players that can buffer while playing) Change 3486475 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing busy bar when buffering or preparing Change 3487237 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed video sample not getting processed on render thread Change 3487507 on 2017/06/13 by Michael.Trepka AvfMedia - small cleanup of the code for passing video frame rate to the video sampler Change 3487719 on 2017/06/13 by Michael.Trepka Disable shared PCH in OpenExrWrapper to solve a problem with bUseRTTI mismatch between the module and the PCH Change 3487842 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed texture swizzle disabled on non-Engine builds Change 3488006 on 2017/06/13 by Michael.Trepka AvfMedia - Moved some logic from FAvfMediaPlayer::TickTickable() to FAvfMediaTracks::ProcessAudio() to make it thread safe, plus fixed a bug with the player not setting the current status to Stopped after opening a file Change 3488308 on 2017/06/13 by Chris.Babcock AndroidMedia: Fixed flicker issue #jira UE-45736 Change 3488335 on 2017/06/13 by Max.Preussner MediaAssets: Made UFileMediaSource::GetFullPath public Change 3488338 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Fixed "Show file in Explorer" not working for file media sources Change 3488339 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing a throbber when buffering player Change 3488768 on 2017/06/14 by Max.Preussner Core: Inlined FTimespan static functions hange 3490203 on 2017/06/14 by Max.Preussner Core: Force inlined TComPtr operators Change 3494083 on 2017/06/15 by Chris.Babcock AndroidMedia: Fix playlist looping (send PlaybackEndReached event) #jira UE-46086 Change 3497017 on 2017/06/16 by Max.Preussner MediaAssets: Playlists now auto advance with PlayOnOpen off Change 3497075 on 2017/06/17 by Chris.Babcock MediaPlayer Sampler node and external texture support for Android MediaPlayer - enable with USE_EXTERNALTEXTURE in AndroidMediaPlayer.cpp (disabled in this CL) - supports MediaSample node in material editor with scale/bias handled if above flag enabled - fixed looping problems, including eventual crashes - track switching fixed (lockups and missing video) - corrected resource leaks and crash switching maps #jira UE-46055 #jira UE-45744 #jira UE-46086 Change 3497163 on 2017/06/17 by Max.Preussner MediaUtils: Processing media events immediately if on game thread Change 3497170 on 2017/06/17 by Max.Preussner Media: All Media Framework interfaces are pure virtual Change 3498603 on 2017/06/19 by Ben.Marsh UBT: Prevent plugins which list modules multiple times from adding them twice. Change 3500870 on 2017/06/20 by Max.Preussner WmfMedia: Rewrote WMF state machine; now with track switching #jira UE-20209 #jira UE-35385 #jira UE-38337 #jira UE-45676 Change 3502181 on 2017/06/20 by Chris.Babcock MediaSampler node updates - fixed issue with ExternalTexture singleton for DLL compatiblity - now works for all players (registers texture samples with ExternalTexture by player GUID) - enabled OES in AndroidMediaPlayer now that materials can universally use the MediaSampler Change 3503182 on 2017/06/21 by Max.Preussner Media: Refactored status flags into an enum; exposed connecting status Change 3503724 on 2017/06/21 by Chris.Babcock Improvement in MediaPlayer Sampler node - RGB, R, G, B, A output pins like normal texture sampler - allow preview in material editor - fix OES detection for Android Change 3509088 on 2017/06/26 by Max.Preussner MediaAssets: Added AddFile and AddUrl to UMediaPlaylist Change 3510256 on 2017/06/26 by Max.Preussner WmfMedia: Fixed play rate not set to zero when end reached Change 3510273 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Removed obsolete Slate culling rectangle code Change 3510413 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Showing frame rate if available Change 3510533 on 2017/06/26 by Max.Preussner MediaUtils: Preventing media cache filling up when scrubbing Change 3510859 on 2017/06/26 by Max.Preussner PS4Media: Fixed track switching crashes (UE-45960) #jira UE-45960 Change 3514173 on 2017/06/28 by Max.Preussner WmfMedia: Optimized player capabilities check Change 3514174 on 2017/06/28 by Max.Preussner WmfMedia: Moved media source resolver code into utility class Change 3514714 on 2017/06/28 by Max.Preussner Core: Added TComPointer.IsValid; code cleanup pass Change 3517912 on 2017/06/30 by Max.Preussner MediaUtils: Added GetVideoAspectRatio to player facade Change 3524957 on 2017/07/06 by Max.Preussner ImgMedia: Decoding image frames only when video track is selected Change 3525252 on 2017/07/06 by Max.Preussner ImgMedia: Async image sequence initialization Change 3525266 on 2017/07/06 by Max.Preussner ImgMedia: Enabled reverse playback Change 3525722 on 2017/07/06 by Max.Preussner WmfMedia: Workaround for occasional WMF internal deadlock in IMFRateSupport Change 3525800 on 2017/07/07 by Max.Preussner WmfMedia: Fixed another WMF deadlock issue & some rate change glitches; improved logging. Change 3525801 on 2017/07/07 by Max.Preussner MediaPlayerEditor: Made scrubbing more responsive Change 3526500 on 2017/07/07 by Max.Preussner WmfMedia: Using NULL for Windows pointers Change 3527323 on 2017/07/07 by Max.Preussner WmfMedia: Added support for audio and video capture media sources Change 3530197 on 2017/07/10 by Max.Preussner WmfMedia: Added utility functions for enumerating audio and video capture devices Change 3533465 on 2017/07/12 by Max.Preussner Media: Added media capture device support API & implementation for WMF Change 3533469 on 2017/07/12 by Max.Preussner MediaPlayerEditor: Added source selection menu w/ capture device menu to navigation bar Change 3533540 on 2017/07/12 by Max.Preussner MediaAssets: Blueprint support for media capture device discovery Change 3533574 on 2017/07/12 by Max.Preussner WmfMedia: Using cached supported play rates; more strict pausing support check Change 3533924 on 2017/07/12 by Max.Preussner WmfMedia: Added global LowLatency setting (UEVR-859) Note that this setting is only supported when compiling for Windows 8 or newer. Change 3534027 on 2017/07/12 by Max.Preussner WmfMedia: Compile time support for low latency session attribute on < Windows8 #jira UEVR-859 Change 3538744 on 2017/07/14 by Max.Preussner MediaUtils: Renamed FDefaultMediaTimeSource to FAppMediaTimeSource Change 3542818 on 2017/07/18 by Max.Preussner WmfMedia: Fixed race condition on session shutdown Change 3543082 on 2017/07/18 by Max.Preussner WmfMedia: Fixed track selection in media that doesn't support seeking Change 3543092 on 2017/07/18 by Max.Preussner Media: Implemented media track format API Enables multiple formats per media track. By default, the first usable format is selected. This feature is currently only implemented for WmfMedia. All other players assume a single format per track. Change 3543794 on 2017/07/19 by Max.Preussner WmfMedia: Added string conversion for null GUIDs Change 3543796 on 2017/07/19 by Max.Preussner MfMedia: Copied GUID string conversion updates from WmfMedia Change 3543797 on 2017/07/19 by Max.Preussner WmfMedia: Preventing duplicate track formats in capture devices with legacy DirectX support Change 3544390 on 2017/07/19 by Max.Preussner Media: Allowing INDEX_NONE as 'current selection' index in track format related functions Change 3545368 on 2017/07/19 by Max.Preussner WmfMedia: Fixed session error with some media sources when attempting to seek to current position without ever starting Change 3545388 on 2017/07/19 by Max.Preussner MediaAssets: Fixed RGB input sources rendered upside down Change 3545430 on 2017/07/19 by Max.Preussner MediaAssets: Fixed incorrect sRGB conversion on BMP inputs Change 3547362 on 2017/07/20 by Max.Preussner Core: Added IsGraph and IsPrint to TCHAR utilities Change 3547376 on 2017/07/20 by Max.Preussner WmfMedia: Better log messages for non-standard video types (UE-47533) #jira UE-47533 Change 3547404 on 2017/07/20 by Max.Preussner QAGame: Enabled PlayOnOpen and Looping on MediaPlayerSwitch BP (UE-47542) #jira UE-47542 Change 3547466 on 2017/07/20 by Max.Preussner WmfMedia: Fixed edge case for detecting whether pause is available Change 3548742 on 2017/07/21 by Max.Preussner Media: Added API for changing the input frame rate Change 3548743 on 2017/07/21 by Max.Preussner WmfMedia: Implemented ability to change input frame rate Change 3554411 on 2017/07/25 by Max.Preussner AudioMixer: Broke out SynthComponent initialization code; added bIsUISound property Change 3554818 on 2017/07/25 by Max.Preussner Media: Added per track-type cache queries Change 3557284 on 2017/07/26 by Max.Preussner WmfMedia: Added buffer size check in texture sample as well Change 3560530 on 2017/07/27 by Max.Preussner WmfMedia: Made COM object destructors private and added assertions Change 3560580 on 2017/07/27 by Max.Preussner MediaUtils: Added method for querying number of objects in pool Change 3562572 on 2017/07/28 by Max.Preussner WmfMedia: Properly handling topology status errors when opening media Change 3576710 on 2017/08/08 by Chris.Babcock bug fixes for mediaplayer - rare cases in Android media tracks - make FMediaCaptureDevice members available in blueprints Change 3577736 on 2017/08/08 by Chris.Babcock Extend ExternalTexture to support 2x3 transform (scale/rotation + offset) Change 3578831 on 2017/08/09 by Max.Preussner MediaAssets: Made media sound component BP spawnable Change 3579210 on 2017/08/09 by Max.Preussner UdpMessaging: Not showing warning message if tunnel settings left empty to use defaults Change 3579547 on 2017/08/09 by Chris.Babcock Better support for Android external texture detection Change 3579567 on 2017/08/09 by Chris.Babcock Android camera plugin #jira UEMOB-215 Change 3580035 on 2017/08/10 by Andrew.Rodham Media Texture: External textures are now fully supported and enforced when attempting to sample external texture types in materials. - Textures can now dynamically provide an external texture GUID at runtime, which is queried by the uniform expression. Statically defined GUIDs remain supported. - Added necessary ExternalTexture(Parameter) methods to the material compiler and HLSL translator - Made UTexture::GetMaterialType const-correct #tests Test map that contains TextureObject, TextureObjectParameter, TextureSample and TextureSampleParameter nodes with media textures works on both a Nexus 10 (non-image-external), and a Pixel (image-external), and on desktop PC. Change 3581552 on 2017/08/10 by Chris.Babcock Use bilinear sampling instead of point for external texture (Android media and camera) Change 3581628 on 2017/08/10 by Max.Preussner Core: Fixed FTimespan import/export/copypaste (UE-43990) #jira UE-43990 #jira UE-44163 Change 3581909 on 2017/08/11 by Andrew.Rodham Media: Only cache material proxy pointers if they have been initialized (and thus, will be removed from the cache on release) - This prevents destroyed proxies from remaining in the texture registry #jira UE-48307 Change 3582451 on 2017/08/11 by Max.Preussner AudioMixer: Fixed initialization order of synth components This ensures that the Synth is initialized before OnRegister in the super class initializes and activates the AudioComponents. Previously, the AudioComponent would fail to activate, because Synth was nullptr. #jira UE-48055 Change 3582453 on 2017/08/11 by Max.Preussner MediaAssets: Enabling ticking in media sound component (UE-48055) #jira UE-48055 Change 3583101 on 2017/08/11 by Chris.Babcock Android camera improvements - return correct capture device type (webcamfront/rear) - remove seek (not supported) - support track formats - better framerate selection Change 3590109 on 2017/08/16 by Chris.Babcock Move external texture coordinate update to improve accuracy and save a uniform in final shader Change 3590530 on 2017/08/16 by Max.Preussner MediaAssets: Changed capture device enumeration BP function signatures to allow filter bit masks #jira UE-48166 Change 3590547 on 2017/08/16 by Max.Preussner MediaPlayerEditor: Ticking sound component directly Change 3590628 on 2017/08/16 by Max.Preussner Switch: Fixed media decoder asserting when attempting to pause without having started Change 3591816 on 2017/08/16 by Aaron.McLeran #jira UE-48470 Disabling async processing for procedural sound waves on mac. Change 3592266 on 2017/08/16 by Max.Preussner Media: Replaced media cache with the new sample processing pipeline; continued to implement MfMedia This change fixes stuttering issues with audio and video. However, proper pipeline flushing is not fully implemented yet, so the playback will break after the first playthrough, which might result in freeze frames or out of memory assertions depending on the platform. This will be addressed in an upcoming change. #jira UE-48474 #jira UE-45677 Change 3592355 on 2017/08/17 by Max.Preussner MediaUtils: Added sample sink collection to remove code duplication Change 3592739 on 2017/08/17 by Max.Preussner ImgMedia: Fetching only one video sample per frame Change 3592741 on 2017/08/17 by Max.Preussner MediaUtils: Better sample fetching when paused Change 3592761 on 2017/08/17 by Max.Preussner MediaUtils: Fixed overflow detection in sample sinks Change 3592762 on 2017/08/17 by Max.Preussner ImgMedia: Sending end reached event when looping Change 3592885 on 2017/08/17 by Max.Preussner ImgMedia: Fixed reverse play Change 3592887 on 2017/08/17 by Max.Preussner MediaUtils: Better sample range calculation for audio samples Change 3593010 on 2017/08/17 by Max.Preussner ImgMedia: Fixed async loading of non-EXR image sequences Change 3593193 on 2017/08/17 by Max.Preussner AndroidMedia: Fixed typo Change 3593230 on 2017/08/17 by Max.Preussner Media: Implemented flushing for player sample queues Change 3593346 on 2017/08/17 by Max.Preussner Media: Proper sample processing for reverse playback Change 3593482 on 2017/08/17 by Max.Preussner Switch: Fixed sample range check for reverse playback Change 3594428 on 2017/08/17 by Max.Preussner PS4Media: Fixed video not playing/crashing #jira UE-48547 #jira UE-48549 Change 3595404 on 2017/08/17 by Max.Preussner MediaAssets: Not requesting audio samples if not playing #jira UE-48557 Change 3595624 on 2017/08/17 by Max.Preussner PS4Media: Fixed no looping after track switching #jira UE-46524 #jira UE-48557 Change 3595704 on 2017/08/17 by Max.Preussner MediaUtils: Improved sample queue flushing Eventually this needs to be event-driven. #jira UE-48557 Change 3595706 on 2017/08/17 by Max.Preussner PS4Media: Flushing queues when track switching #jira UE-48557 Change 3595909 on 2017/08/17 by Max.Preussner Matinee: Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) https://github.com/EpicGames/UnrealEngine/pull/3382 #jira UE-42906 #rn Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) Change 3597480 on 2017/08/18 by Max.Preussner ImgMediaPlayer: Fixed presentation time calculation for very large delta times Change 3597669 on 2017/08/18 by Max.Preussner ImgMedia: Setting player stopped instead of paused when end reached Change 3597709 on 2017/08/18 by Max.Preussner SwitchMedia: Fixed audio sample duration calculation Change 3598479 on 2017/08/18 by Max.Preussner ImgMedia: Ensuring that first/last frame is played when starting playback forward/reverse; improved state checking; user logging Change 3598629 on 2017/08/18 by Max.Preussner MediaUtils: Properly handling pending flushes when peeking sample queues Change 3598633 on 2017/08/18 by Max.Preussner WmfMedia: Fixed occasional WMF deadlock when scrubbing Change 3598653 on 2017/08/18 by Max.Preussner MediaUtils: Fixed audio resampling in reverse playback Change 3598659 on 2017/08/18 by Max.Preussner MediaPlayerEditor: Creating sound output only if audio device available Change 3598688 on 2017/08/18 by Max.Preussner MediaUtils: Flushing sample queues on direction change regardless of paused state Change 3599444 on 2017/08/20 by Max.Preussner WmfMedia: Added missing check for rate control when quering supported rates Change 3603661 on 2017/08/22 by Max.Preussner WmfMedia: Fixed NV12 output Change 3604345 on 2017/08/23 by Max.Preussner MediaUtils: Added subtitle samples to media sample collection; fixed documentation Change 3604987 on 2017/08/23 by Max.Preussner PS4Media: Setting correct track format types Change 3605117 on 2017/08/23 by Joe.Barnes Fix issue where presentation time was being treated as milliseconds instead of microseconds. Change 3605128 on 2017/08/23 by Joe.Barnes Fix potential issue calculating total (looped) play time after seek or reset. Track last video presentation time Change 3605139 on 2017/08/23 by Joe.Barnes Support audio type DType_Setup. Fix issue with procedural sounds popping. Consume more samples if necessary. #jira ue-48544 Change 3605197 on 2017/08/23 by Max.Preussner Media: Fixed track display name formatting (UE-48767) #jira UE-48767 Change 3605817 on 2017/08/23 by Max.Chen Auto set sampler type on drop on actor. #jira UE-48769 Change 3605999 on 2017/08/23 by Max.Preussner MfMedia: Restarting source reader when switching tracks #jira UE-48766 Change 3606416 on 2017/08/23 by Max.Preussner PS4Media: Various player improvements #jira UE-48586 Change 3607656 on 2017/08/24 by Max.Preussner WmfMedia: Improved logging for Seek and SetRate Change 3607855 on 2017/08/24 by Max.Preussner MfMedia: Better verbose logging; validating seeks; reduced nesting; fixed track switching\ #jira UE-48766 Change 3608029 on 2017/08/24 by Max.Preussner PS4Media: Fixed streaming media not playing; improved result checks & logging #jira UE-48610 Change 3608473 on 2017/08/24 by Max.Preussner MfMedia: Fixed audio sample duration calculation #jira UE-48756 Change 3609316 on 2017/08/24 by Chris.Babcock Provide external texture RotationScale and Offset from sample Change 3610067 on 2017/08/25 by Richard.Wallis Mac: Editor locks up when Track switching and Mac: Media Audio continues to play after closing player. - Fix for creating extra OS AV media playback objects so audio playback not stopping due to over retained objects. - Trying to access OS AV Media Playback object (esp. the currentTime value) across mutliple threads at once seems to cause deadlock in the Apple libraries - moved location of currentTime acess point to Media Ticker - this sets the current time and is then just returned in the getter when on game main. - Trying to playback audio via OS media playback and through the engine at the same time when enabling the selected audio track. Engine version via sample buffers via AVAssetReaderTrackOutput doesn't seem to be working as intended with the new audio frame work audio sinks - so reverting to OS AV media playback for Mac at the moment until better fix for this can be put in. #jira UE-48590, UE-48604 Change 3610267 on 2017/08/25 by Max.Preussner PS4Media: Added missing track selection validation #jira UE-48765 Change 3610399 on 2017/08/25 by Max.Preussner PS4Media: Fixed infinite player re-initialization loop if track selection failed Change 3610809 on 2017/08/25 by Chris.Babcock Fixes for Android media player and camera player - buffer samples copy proper bytecount - realloc sets new buffer ptr - refcount of Java buffers fixed Change 3610953 on 2017/08/25 by Chris.Babcock Fix audio disable before play on Android media player Change 3611405 on 2017/08/25 by Max.Preussner WmfMedia: Resetting supported rates if RateSupport unavailable Change 3611406 on 2017/08/25 by Max.Preussner MfMedia: Resetting supported rates if RateSupport unavailable Change 3611453 on 2017/08/25 by Chris.Babcock Android external texture extension updates for compatibility Change 3611719 on 2017/08/26 by Max.Preussner Media: Added media event for completed seek operations; flushing sinks on seek Change 3611764 on 2017/08/26 by Max.Preussner AvfMedia: Setting player to preparing state prior to initializing tracks asynchronously Change 3611802 on 2017/08/26 by Max.Preussner Media: Exposed error state in media player Change 3611803 on 2017/08/26 by Max.Preussner MediaPlayerEditor: Showing error state in UI Change 3611887 on 2017/08/26 by Max.Preussner MediaUtils: Corrected media sample sink overflow check Change 3611892 on 2017/08/27 by Max.Preussner WmfMedia: Leaving session in error state after error Change 3611929 on 2017/08/27 by Max.Preussner MediaPlayerEditor: Fixed sound stopping on looping Change 3611930 on 2017/08/27 by Max.Preussner MfMedia: Rewrote async sample processing to fix various playback issues Change 3611942 on 2017/08/27 by Max.Preussner Media: Sending suspension event when playback ended Change 3611957 on 2017/08/27 by Max.Preussner UnrealEd: Allowed transient assets to be resaved to disk Change 3611981 on 2017/08/27 by Max.Preussner PS4Media: Rewrote sample processing to fix various playback issues #jira UE-48596 #jira UE-48793 Change 3612035 on 2017/08/27 by Max.Preussner UnrealEd: Picking standard default names when resaving transient packages Change 3612045 on 2017/08/27 by Max.Preussner Media: Fixed playlists not getting saved correctly from Editor (UE-35382) #jira UE-35382 Change 3612212 on 2017/08/28 by Richard.Wallis Fix for Multitrack Video samples continue to Play on Open after Play on Open is toggled off. Current Rate was not getting reset back to 0.0 on media close. #jira UE-47602 Change 3613531 on 2017/08/28 by Max.Preussner MediaAssets: Fixed external texture related crash on shutdown (UE-48918) Also no longer creating clock sink for media player CDO #jira UE-48918 Change 3613677 on 2017/08/28 by Andrew.Porter Fixed crash at exit in Mac editor caused by double release of AVPlayerItem object #jira UE-48937 Change 3615917 on 2017/08/29 by Max.Preussner MfMedia: Added compile options for DXVA and falling back to synchronous sample reading [CL 3617655 by Max Chen in Main branch]
2017-08-30 09:37:09 -04:00
const TSharedRef<IMessageContext, ESPMode::ThreadSafe>& Context,
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
TArray<TSharedPtr<IMessageReceiver, ESPMode::ThreadSafe>>& OutRecipients
)
{
EMessageScope MessageScope = Context->GetScope();
for (int32 SubscriptionIndex = 0; SubscriptionIndex < Subscriptions.Num(); ++SubscriptionIndex)
{
const auto Subscription = Subscriptions[SubscriptionIndex];
if (!Subscription->IsEnabled() || !Subscription->GetScopeRange().Contains(MessageScope))
{
continue;
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
auto Subscriber = Subscription->GetSubscriber().Pin();
if (Subscriber.IsValid())
{
if (MessageScope == EMessageScope::Thread)
{
ENamedThreads::Type RecipientThread = Subscriber->GetRecipientThread();
ENamedThreads::Type SenderThread = Context->GetSenderThread();
if (RecipientThread != SenderThread)
{
continue;
}
}
OutRecipients.AddUnique(Subscriber);
}
else
{
Subscriptions.RemoveAtSwap(SubscriptionIndex);
--SubscriptionIndex;
}
}
}
void FMessageRouter::FilterRecipients(
const TSharedRef<IMessageContext, ESPMode::ThreadSafe>& Context,
TArray<TSharedPtr<IMessageReceiver, ESPMode::ThreadSafe>>& OutRecipients)
{
FMessageScopeRange IncludeNetwork = FMessageScopeRange::AtLeast(EMessageScope::Network);
const TArray<FMessageAddress>& RecipientList = Context->GetRecipients();
for (const auto& RecipientAddress : RecipientList)
{
auto Recipient = ActiveRecipients.FindRef(RecipientAddress).Pin();
if (Recipient.IsValid())
{
// if the recipient is not local and the scope does not include network, filter it out of the recipient list
if (Recipient->IsLocal() || IncludeNetwork.Contains(Context->GetScope()))
{
OutRecipients.AddUnique(Recipient);
}
}
else
{
ActiveRecipients.Remove(RecipientAddress);
}
}
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3946692) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3801826 by Max.Chen PR #4304: Level Sequence crash fix - Guarded against dereferencing null componen. (Contributed by DSDambuster) Change 3801828 by Max.Chen PR #4302: Movie Scene Visibility Template unitialised variable, causing random . (Contributed by DSDambuster) Change 3801837 by Max.Chen Sequencer: Delay spawning/construction for convert to possessable. This fixes a bug where property values would be lost when converting back and forth from possessable to spawnable. #jira UE-52400 Change 3801841 by Max.Chen Sequencer: Make spacer nodes not selectable. PR #4194: Improvements to Sequencer (Contributed by projectgheist) #jira UE-53117 #jira UE-52139 Change 3804183 by Max.Preussner MediaAssets: Added missing lock in media sound component Change 3805414 by Max.Preussner MediaAssets: Setting valid GUID when initializing media texture resource Change 3819578 by Max.Chen PR #4370: When enabling the "MovieCapture", do not turn off the Stereo-3D display. (Contributed by yehaike) #jira UE-53647 Change 3823414 by Max.Chen Curve Editor: Lock down the first and last keys in the redundant keys removal range so that they're unaffected. #jira UE-53591 Change 3826406 by Max.Chen Sequencer: Move OnStartedPlaying() to within first update in UpdateTimeCursorPosition(). This fixes an issue where setting the hud/player visibility was getting stomped on later. #jira UE-52772 Change 3827044 by Max.Preussner MediaAssets: Added sprite visualization to media sound component #jira UE-53594 Change 3827988 by Max.Preussner MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together #jira UE-53532 Change 3828506 by Max.Preussner MediaPlayerEditor: Added attenuation visualizer for media sound components #jira UE-53594 Change 3832590 by andrew.porter EngineTest: Added a keep state check in Property Animation sequencer test Change 3833053 by andrew.porter EngineTest: Adding Hierarchical Bias test Change 3835683 by andrew.porter EngineTest: Adding UMG Animation screenshot test Change 3836076 by Max.Chen Sequencer: Fix audio volume and pitch multiplier deprecation. Change 3836230 by andrew.porter EngineTest: Adding Sequence Bone Position automation test Change 3836347 by Max.Chen Sequencer: Fixes to shot name parsing. When a shot doesn't contain a shot number, assume, [ShotName]_[TakeNumber]. When duplicating a shot, put the new shot in the same path of the original shot, so that the take numbers will increment properly. #jira UE-51868 Change 3836552 by Max.Chen Sequencer: Sub section now has a takes menu Change 3838094 by Max.Chen UMG: Fix template finish not getting called on stop. This fixes a bug where sections aren't restored when finished. #jira UE-52285 Change 3838708 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3840295 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840957 by Mike.Zyracki Added Show Only Keyable and Show Only Animated to the filter list in the property editor. Added IsPropertyAnimated to IDetailKeyframe Interface which already had support for showing properties which are keyable (which is used for the key icon next to the properties.). Could have created another interface but then would have had to mimic the sequencer binding, releasing also, so this seemed best way. One issue still left is that custom built detail items currently don't store associated properties(usually) and so certain properties, in particulalry transforms, won't show up as keyable or animated. Note this also shows up with the keyable icon not showing up next to transform tracks, and other filters like Show Only Modified not working with transforms/customs. Not sure best way to tackle this. #jira UESEQ-328 Change 3841756 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3843950 by andrew.porter EngineTest: Renaming LevelStreaming tests/content to LevelVisibility Change 3844082 by Mike.Zyracki Missing file for animated filter in property editor. When finding if a track is animated we need to find it but we can't easily induce the MovieTrack class for any particular property. So we don't set a class for it and just search by it's ID and name. #jira UESEQ-328 Change 3846902 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed #jira UE-54247 Change 3849820 by Mike.Zyracki Reassigning deleted widgets didn't work since the menu extender mechanism needs a valid UObject in order to perform an operation on it. So to fix we replaced GetObjectBindingContextMenuExtender in WidgetBlueprint with new delegate mechanism (OnBuildCustomContextMenuForGuid) that supports FGuid in addition to UObjects which is needed to handle re-binding deleted widgets. Note that the default sequencer hacks this for replacing deleted actors in SequencerObjectBindingNode to check to see if a LevelSequence is active. We could move to this mechanism there also. #jira UE-53163 Change 3852211 by Max.Chen UMG: Indicate name of the property that is not bound. #jira UE-54350 Change 3854120 by Max.Chen Sequencer: Fix sibling folders being allowed to have the same folder name. #jira UE-54363 Change 3854627 by Max.Chen Sequencer: Step to next/previous key should work for all tracks if there aren't any selected. #jira UESEQ-391 Change 3855825 by andrew.porter EngineTest: Adding animation blending automation test Change 3855950 by andrew.porter EngineTest: Adding correct expected valuues to animation blending test Change 3856237 by Matt.Hoffman UESEQ-336 - Sequencer Track Reordering Adds the ability to re-order Master Tracks, Folders and Object Bindings within sequencer hierarchies (including UMG). Adds the ability to do a one-off sorting of the content under the old sorting behavior if the user wants to reset their layout to how it was under legacy behavior. Modifies SequencerTrackNodes, SequencerFolderNodes and SequencerObjectBindingNodes to handle CanDrop/OnDrop for above, below and ontop of. Fixes a Slate Issue that forcibly expanded a TreeviewRow if an item handled OnDrop. Slate will now only forcibly expand the row if the item says the drop happened ontop of the item, and not above or below it like it previously did. Change 3856503 by andrew.porter EngineTest: Adding automation test for using animation blueprint with blend multi node in sequencer Change 3857875 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. #jira UE-54462 Change 3858344 by Max.Chen Sequencer: Prevent Goto and Transform boxes from overlapping by allowing them to be visible at the same time in an autosized horizontal box. Also, added close button to the goto box. PR #4425: Prevent Goto and Transform boxes from overlapping in Sequencer ... (Contributed by projectgheist) #jira UE-54210 Change 3860566 by andrew.porter MediaFrameworkTest: Set the option to index 0 for the audio and video track list by default Change 3860654 by andrew.porter EngineTest: Enabling Camera Cut + FOV test Change 3860981 by andrew.porter EngineTest: Updating skeletal mesh tests with a delay after set playback position Change 3861256 by Max.Chen Sequencer: Add all bindings if none selected. #jira-54440 Change 3862154 by Andrew.Rodham Added TimeManagement module Change 3862424 by andrew.porter EngineTest: Turned on the test Bone Positions with Blend Multi Node Change 3862573 by andrew.porter EngineTest: Adding test to compare bone positions in a sequence that is blending an animation that is using an AnimBP Change 3865117 by Max.Chen Sequencer: Stop auto scroll on mouse release of movement. #jira UE-31212 Change 3865303 by Max.Chen Sequencer: Add drag and drop transactions #jira UE-54662 Change 3865304 by Max.Chen Sequencer: Fix crash when an actor factory is not found. Change 3865361 by Max.Chen Sequencer: Don't change the camera/shot lock button when popping out of a sequence. #jira UE-54665 Change 3865412 by Max.Chen Sequencer: Determine whether a transform track is for a camera by using the spawned object or template #jira UE-54666 Change 3865685 by Max.Chen Sequencer: Clear autoscrub offset when stopping autoscroll #jira UE-31212 Change 3865886 by Max.Chen Sequence Recorder: Log an error if the number of frames changes while recording. This can happen if the skeleton changes while recording. #jira UE-48715 Change 3866925 by Andrew.Porter MediaFrameworkTest: Changing the current PNG test video image sequence to 1024 x 576 Change 3867705 by andrew.porter QAGame: Adding Audio Sort Sequence to dev folder Change 3867890 by andrew.porter QAGame: Adding a sequence for testing a sorting crash to my dev folder Change 3872628 by Max.Chen Movie Scene Capture: Split delay before warmup into split delay before shot warmup so that there's separate controls for when the movie scene capture warmups up vs. shot boundaries. Change 3873131 by Matt.Hoffman UE-54732 - Crash reordering a folder with a track. This was caused by folders being the only type of track to check if someone was putting a parent track into a child track. Object Binding tracks and Tracks now check as well so that you can't use the above/below drop targets to add parents as children. This also fixed a typo in the localization keys. #jira UE-54732 Change 3873301 by Mike.Zyracki Added ability to support continous euler angle changes when changing rotations, in particularly with the rotation gizmo's. To do this we effectively added a form an of 'euler filter'(https://en.wikipedia.org/wiki/Euler_filter) to find the closest euler angle to the current euler angle. Three functions were added to FRotator to make this possible, one to get the euler angle that's has the same rotation as it, one to get the difference between two euler angles via Manhattan distance and a third using the previous two to choose a Rotator value that's closest to it. We then use these functions before calling UComponent::SetRelativeRotation to make sure we use the correct Euler after the Quat conversion. We also no longer limit(bound) the euler angles to -180,180, which is obviously necessary to avoid flips. I also changed how we caluclate yaw and roll when pitch is -90 or 90 to make it the standard approach of zeroing out roll and just setting yaw. Main reasons are the previous implementation had precision issues so things like 180, 90, -180 would show up due to numbers being nearly zero but negative,(this would break any smooth interpolations), and this facilitates having a 'gimbal' rotation mode (like Maya, Blender etc..) if we ever want that also. If needed we could keep the previous implementation but would need to add some FMath::IsNearlyZero checks, with less performance. Note we only do this special filtering when applying delta's to actors or components in the editors, which then call UComponent::SetRelativeRotationExact, which is a new function to foces the RelativeRotation to be equal to the new rotation. This allows us to store un-nomalized Rotators at the cost that the RotationCache may be broken. We didn't change any of the other UComponent functions that set rotations (via Quats or Transforms) so they will still be bounded and unwound. In SetInternalWorldLocationAndRotation we only set the rotation if the rotation has changed, which fixes the rotation getting changed and re-normalized if just translate happens. In TransformTrackEditor, we correclty use the bUndwing flag and in MovieScene3DTransformSection there was an un-needed winding check there, it will be unwound earlier if needed, which happens if Sequence Recording is happening. Max we should talk about what to do about this . Note the euler angle drag via the widget is still bound to 0-360. I think we should just unbound that now since the rotations value are now unbound. This review now includes fixes suggested by Zak. #jira UE-UE-22228 Change 3873483 by Matt.Hoffman Sequencer Tracks can now be inserted above the spacer at the bottom of the tree. #jira UE-54706 Change 3873899 by Max.Chen Sequencer: Add section selection throbbing Change 3873908 by Max.Chen Movie Scene Capture: Added logging per frame Change 3873924 by Matt.Hoffman Adds the ability to store Sequence Recorder setups into profiles that stay with the map and can be re-loaded later. Profiles store the Actor Recordings so the settings for each actor should carry with them. #jira UESEQ-339 Change 3874726 by Matt.Hoffman Disable drag-and-drop targets on spacers that come between rows in Sequencer. This prevents extra drag/drop targets showing up between each row. #jira UE-54706 Change 3874862 by Matt.Hoffman Audio Track no longer gets reordered when adding sub-audio tracks, as sub-tracks are no longer counted towards the sorting order index when normalizing indexes. #jira UE-54727 Change 3875905 by Matt.Hoffman Disable Fade Track UI if a fade track already exists in the sequence. #jira UESEQ-393 Change 3876163 by Max.Chen Sequencer: Swap the camera object to the camera component's owner if it's not the same. #jira UE-54874 Change 3876971 by Andrew.Porter EngineTest: Moved Media Player Seek test to new folder. Also enabled the test with new ground truth image. Change 3877040 by Max.Chen Cine Camera: Split camera properties to two groups, "Camera Options" and "Camera Settings". The cine camera now hides properties in the "Camera Settings" group so that properties like bConstrainAspectRatio (in the "Camera Options" group) can be visible. #jira UE-54192 Change 3877763 by Max.Chen Curve Editor: Fix curve changed on end drag so that only curves that had keys/tangents that were changed receive notification, otherwise all loaded curves were getting notified that they were changed. #jira UE-54951 Change 3878234 by Matt.Hoffman Disable "Drop Below" targets for Sequencer Tree nodes to prevent a confusing UX issue where dropping underneath a Object Binding Node puts it after the object binding node but the UI looks like it's inserting it inside the Object Binding node. #jira UE-54743 Change 3879359 by Mike.Zyracki If a track is inactive we dim it a bit which seems to be the UE4 way to show inactive or disabled state. We changed the active logic so that all subtracks need to be inactive for the track to also be inactive(instead of all active for active). This conforms to how the active state actually works, e.g if you have two sections and only one is active the track is still active above it. #jira UESEQ-388 Change 3879462 by Max.Chen Sequencer: Allow dragging onto a particular row which would move out any overlapping sections to make space for the newly created section. Newly created sections are now selected and throbbed to draw attention to themselves. #jira UE-54664 Change 3879464 by Max.Chen Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field. - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field. - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges. #jira UE-54922 Change 3879590 by Matt.Hoffman Items that are now added to the Sequencer via the "+Track" menu will be selected after being added. Items can now be added inside of folders instead of just to the root level. #jira UE-27397 Change 3879612 by Mike.Zyracki Display Nodes with no children are always active. #jira UESEQ-388 Change 3879730 by Matt.Hoffman Sequence Recorder's actor recording groups now remove items from the group when removed via the UI. #jira UESEQ-339 Change 3880256 by Mike.Zyracki Fix issue with inactive display with folders and other track nodes. #jira UESEQ-388 Change 3883491 by Max.Chen Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes. Copy from Release-4.19 #jira UE-51323 Change 3883603 by Max.Chen Movie Scene Capture: Add option toggle disable screen percentage. By default this is on (no change in current behavior). #jira UE-51898 Change 3885074 by Max.Preussner MediaCompositing: Resetting media texture & freeing resource on section end; removed dead code Change 3887220 by Max.Preussner MediaCompositing: Defaulted media section duration to 1 sec (since we do not know the actual duration in most cases) Change 3887478 by Matt.Hoffman Sequences now show [Inactive] in their title bars when they're disabled. This helps communicate why a sequence isn't being evaluated. #jira UE-51469 Change 3888985 by Max.Chen Movie Scene Capture: Clamp HDR Compression Quality between 0 and 1. #jira UE-55136 Change 3893519 by Max.Chen Sequence Recorder: Clarified tooltip for bRecordNearbySpawnedActors - spawned actors will still be recorded if they match the ActorFilter. #jira UE-55238 Change 3893546 by Max.Chen Sequence Recorder: If a selected actor already has a recording, add a blank recording. #jira UE-55239 Change 3894044 by Max.Preussner MediaCompositing: Added support for seeking into a media section Change 3894310 by andrew.porter MediaFrameworkTest: Adding Img media sources for 1080 and 2160 ravent test content Change 3894426 by Max.Preussner MediaAssets: Letting media textures with AutoClear retain their clear color when player is reset Change 3895717 by Max.Chen Sequencer: Null checks to prevent crash when saving the default state of a spawnable #jira UE-55304 Change 3897388 by Max.Chen Sequencer: Don't update current time to be within the view range when stepping into a sequence. #jira UE-55322 Change 3897452 by Max.Chen Audio: Fix crash when trying to record audio without any active capture devices. Log warning if the number of input channels is not 1 or 2. #jira UE-55223 Change 3897619 by Max.Preussner MediaCompositing: Removed commented out code Change 3898072 by Max.Chen Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated. #jira UE-55328 Change 3898272 by Max.Preussner MediaPlayerEditor: Made slate brush constants static Change 3898704 by Max.Chen Sequencer: Skip if the binding id's sequence can't be found. #jira UE-55337 Change 3899855 by Max.Preussner MediaCompositingEditor: Added cache state visualization to media track Change 3900300 by Max.Preussner MediaCompositingEditor: Added loop indicators to media sections Change 3900694 by Max.Preussner ImfMedia: Looping cache only when player is looping Change 3900892 by Max.Preussner Stats: Added stats category for media framework Change 3900954 by Max.Preussner MediaCompositing: Don't evaluate at the end of media section Change 3901348 by Max.Preussner Core: Replaced TLruCache autos for better readability Change 3901655 by Max.Preussner ImgMedia: Added more perf stats to EXR reader Change 3901972 by Max.Preussner MediaAssets: Added getter for media player in media sound components Change 3902233 by Max.Preussner MediaAssets: Enabling media textures to receive samples right after player is assigned Change 3902238 by Max.Preussner MediaCompositing: Working around init/shutdown idiosyncracies in sequencer Change 3904045 by Max.Chen Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register. #jira UE-55314 Change 3905605 by Max.Chen Sequencer: Restrict spawnables from being created if they have a ClassWithin that UMovieScene is not a child of. #jira UE-55429 Change 3906550 by Max.Chen Sequencer: Add media track icon #jira UE-55480 Change 3907101 by Max.Chen Sequence Recorder: Fix bugs related to not recording a level sequence. There were certain assumptions that creating a level sequence meant that sequence recording was in progress. This is not always the case - the recorders can record animation assets and not create a level sequence. Changed the notion of IsRecording() to having at least one actor recording that is recording. Countdown timer, recording displays, etc should function if IsRecording() and not based on whether a level sequence is created. #jira UE-55485 Change 3907247 by Max.Chen Sequence Recorder: Fix crash not removing PrepareToCleanseEditorObject delegate. Repros when opening sequence recorder, closing it, and then opening or creating a level. Change 3910343 by Max.Preussner Core: Added async helper for executing functions on a given thread pool Change 3910346 by Max.Preussner ImgMedia: Added separate thread pools for loading/decoding and deleting image frames Change 3910829 by Max.Preussner Profiler: Increased visible range of profiler graph Change 3910841 by Max.Preussner MediaCompositing: Displaying asset name instead of full media source path in media section Change 3910870 by Max.Preussner ImgMedia: Using deallocation thread pool only in debug builds Change 3919642 by Max.Chen Sequence Recorder: Clarify active tooltip #jira UE-55661 Change 3919660 by Max.Chen Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified - The following sequence of events exposes this issue: - Create a master sequence with a single shot that spawns a cube - Add this sequence to a level and set it to auto-play - Save everything and restart - Resave just the inner shot asset without opening it - PIE - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template. #jira UE-55626 #jira UE-55490 Change 3921825 by Max.Chen Sequencer: "Run Construction Script in Sequencer" is off by default for blueprints but on for Sequencer. This allows the content author to switch it on for specific blueprints and sequencer will be default, run those with construction scripts enabled. Change 3922232 by Max.Chen Sequence Recorder: Reset countdelay on stop. #jira UE-55755 Change 3922306 by Max.Chen Sequence Recorder: Don't automatically mark transforms to be recorded by sequence recorder. Instead, log a warning if the user toggled it off to warn that the resulting animation might not match gameplay. #jira UE-55758 Change 3922912 by Max.Chen Sequence Recorder: Fix refresh next sequence name #jira UE-55757 Change 3927654 by Max.Chen Movie Scene Capture: Added format mapping for the name of the current camera #jira UE-55769 PR #4537 Change 3927658 by Max.Chen Sequencer: Added fbx property mapping for "FocusDistance" to "FocusSettings.ManualFocusDistance" #jira UE-55782 Change 3932022 by Max.Chen Sequencer: Add import animation track section to next available row index. #jira UE-55892 Change 3933919 by Max.Chen Sequencer: Jump to playback start frame and not 0 to start playback for recording. #jira UE-55933 Change 3934307 by Andrew.Rodham Sequencer: Add template signature that is re-generated every time the base template is regenerated, which invalidates evaluation fields This fixes an issue where the same sequence is instantiated multiple times in a sequence. If the source sequence was saved, its template would be wiped, which would invalidate the template ID When an instance tries to evaluate the master template, it would only invalidate a range in the evaluation field that was the hull of any invalid sub sequences overlapping the current time, potentially leaving invalid data in the evaluation field at positions later (or earlier) on in the sequence When the sub template was re-generated, it receives the same SequenceSignature as it had before (because the sequence hasn't actually changed), which causes the stale evaluation field data to fail the IsDirty check (because the sequence is the same as it thought, but the *template* has changed) This has been addressed be adding a signature to templates themselves, and checking both the template signature and sequence signature as a part of the IsDirty check. This ensures that we regenerate if either the template, or the sequence have changed. #jira UE-55934 Change 3936327 by Andrew.Rodham Sequencer: Removed increment when trimming right UMovieSceneSection::TrimSection already explicity assigns an exclusive bound to the time passed in. The new behavior means we can trim a section to the right, and insert another section without changing the time to create adjacent sections. #jira UE-42652 Change 3936328 by Andrew.Rodham Fixed KeyFrameManipulator assignment operators and copy/move constructors - These types are potentially self-referential so cannot use default constructors/assignment Change 3936330 by Andrew.Rodham Converted UMGSequencePlayer to use frames internally #jira UE-54878 Change 3936726 by Max.Chen Sequencer: Set track node as the parent of the key area node. The key area switcher needs the object binding id from the parent object binding node. Without this, the binding to the external value fails. #jira UE-55931 Change 3936775 by Max.Chen Sequencer: Should stop or loop should compare DurationFrames with Current Time from StartTime. The bug is that if you set 30 warmup frames in movie rendering for a range of 0-100, the FrameRange will be starting at -30 and have a duration of 130. Without this fix, the playback will continue until frame 130, rather than 100. #jira UE-55933 Change 3936935 by Matt.Hoffman Easing Curves are now represented in Play Rate resolution instead of internal resolution. #jira UE-55937 Change 3937069 by Matt.Hoffman Users can toggle if the is infinite on each side, limited by which tracks support infinite ranges. #jira UE-55891 Change 3937516 by Max.Preussner ImgMedia: Added support for single-threaded platforms #jira UE-55986 Change 3937826 by Max.Preussner MediaAssets: Disabling media sound components on HTML5 if AudioMixer is not enabled Change 3937997 by Max.Chen Curve Editor: Add Zoom to Fit Curves so that selected curves from Sequencer can be focused on. Tested that undo doesn't re-zoom. #jira UE-55935 Change 3938000 by Max.Chen Sequencer: Stop all sounds before generating audio waveforms. #jira UE-55951 Change 3938376 by Max.Preussner XGEController: Disabled XGE Controller in single-threaded apps to prevent crash Change 3938444 by Max.Preussner Core: Added async support for single-threaded applications Change 3938445 by Max.Preussner Networking: Added support for single-threaded applications in UDP socket sender/receiver Change 3938447 by Max.Preussner Messaging: Added support for single-threaded applications Change 3939432 by Max.Chen Sequence Recorder: Append command list to global level editor actions so that shortcuts are accessible in level editor. #jira UE-55798 Change 3940229 by Andrew.Rodham Added prospective display rate upgrade to UMovieScene::PostLoad - There was previously some very odd behaviour that would assign the fixed frame interval only when a sub sequence was focused in SSequencer. This meant that many sequences could have a frame interval of 0 set in the data. - Under the old method of snap interval display this would have fallen back to getting the display interval from the sequencer settings, but we no longer look at these. - The USequencerSettings properties have been removed and in their place, a prospective data upgrade for sequences that have a fixed frame interval old 0fps that sets the play rate to the previous defaults based off the old USequencerSettings defaults. - This could end up 'changing' the display rate for sequences where the user has changed the snap interval in the settings for a particular sequence editor, but there's not much we can do about that given we don't have access to the USequencerSettings classes in UMovieScene #jira UE-55919 Change 3940277 by Andrew.Rodham Sequencer: Added ability to default frame resolutions and play rates for newly created actor sequences Change 3940378 by Andrew.Rodham Sequencer: Post move import dialog now defaults to the playback framerate of the sequence, and floors to frame numbers Change 3940559 by Andrew.Rodham Reinstated primed or recording sequence color Change 3940642 by Max.Preussner ImagePlate: Removed image plate media playback functionality Change 3940843 by Max.Preussner Core: Made TCircularQueue actually thread-safe; improved code comments Change 3940860 by Max.Chen Sequencer: Changed StructNameToKey to StructPathToKey Previously, keying a PropertyPath of [RenderTransform][Shear][X] would get trimmed to X, which doesn't map to a channel name as considered by Sequencer2dTransformTrackEditor. Instead, trim the resulting property path to [Shear][X] so that track editors can determine the desired struct path and channels to key. #jira UE-52966 Change 3941292 by Mike.Zyracki Fix for trajectories out of range not showing up. 1) If we had no key data we would pop the time, so wouldn't get the section ranges. 2) Calculating of upper bound was wrong, checking against -1 and not key == num of keys when doing algo::lower_bound. 3) No need to do the Bck-- for the bakward iterators since we fixed #2. We start now from the upper bound correctly. 4) If we had no keys (at section start,end) we would incorrectly say we were any key type, so since we draw constant keys as dashed we would do so incorrectly around section end points. #jira UE-55929 Change 3941424 by Max.Chen Curve Editor: Change Zoom to Fit to use TArrayView Change 3941498 by Max.Preussner Core: Added FMath::DivideAndRoundNearest function Change 3942097 by Matt.Hoffman Drop Frame Timecode Support for NTSC rates. Change 3942104 by Matt.Hoffman Sequence Recorder Group is no longer visible inside the World Outliner after using one. #jira 55266 Change 3942107 by Max.Chen Sequencer: Resurrect logic to find or extend an existing section when adding keys. Change 3942330 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942339 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942507 by Andrew.Rodham Sequencer: We no longer pad the time overlap threshold with a small number that is not scaled by the current zoom level - The presence of this pad was causing keys that were far apart to be grouped when zoomed in a long way Change 3942509 by Andrew.Rodham Sequencer: Only pad total view range, rather than section range as well when retrieving keys to render - This stops us from rendering keys that are within the view range, but outside the section range Change 3942512 by Andrew.Rodham Added transactions to some sequencer details customizations Change 3942513 by Andrew.Rodham Sequencer: Reinstated validation checks to UMovieSceneSection::SetStartFrame and SetEndFrame, changed erroneous uses to use SetRange Change 3942560 by Andrew.Rodham Pass by rvalue reference to appease error C2719 on Win32 ('InChannels': formal parameter with requested alignment of 8 won't be aligned) Change 3942697 by Andrew.Rodham Newly Created Level Sequences and Actor Sequences now default to 24000 fps frame resolution (+/- ~24hrs range, supporting all integer rates + 23.976) Change 3942700 by Andrew.Rodham Sequencer: Added legacy out-of-bounds errors for times that are not supported by the current legacy upgrade frame resolution Change 3942989 by Max.Preussner Core: Fixed circular queue count calculation Change 3943538 by Max.Preussner MediaAssets: Reverted workaround for procedural audio log spam in HTML5 (Actor component initialization cannot be skipped if the component is used in a level) Change 3944071 by Max.Preussner QAGame: Fixed Media Texture keeps last frame of Media when PIE ends #jira UE-53360 Change 3944292 by Max.Chen Sequencer: Added extra flags to ensure that asset initialization does not occur on template actor sequences #jira UE-56113 Change 3944364 by Max.Chen Sequencer: Prevent circular shot/master tracks. Tested adding master -> child -> master as drag and drop cinematic shot tracks and sub tracks as well as through the + button. #jira UE-56091 Change 3944422 by Max.Chen Sequence Recorder: Disable transform recording if off. #jira UE-56061 Change 3944745 by Andrew.Rodham Sequencer: Key rendering fixes - Fixed assert that occured when keys happened to reside on some times due to KeyTime + TimeOverlapThreshold - KeyTime being slightly larger TimeOverlapThreshold - Fixed keys sometimes being clipped when zoomed right in due to lack of half-frame offset - Added missing documentation to MovieSceneTimeHelpers.h #jira UE-56107 Change 3945231 by Andrew.Rodham Sequencer: Reconstruct channel proxy on Serialize to catch all cases of undo/redo, PostLoad and duplication #jira UE-56089 Change 3945301 by Andrew.Rodham Sequencer: Added safety checks during initial sequence recording to guard against applying negative or 0-sized sequence ranges #jira UE-56125 Change 3946627 by Max.Preussner Fortnite: Fixed game crashes closing editor while in PIE - Pure virtual function being called #jira UE-56144 [CL 3946896 by Max Chen in Main branch]
2018-03-14 22:09:33 -04:00
void FMessageRouter::ProcessCommands()
{
CommandDelegate Command;
while (Commands.Dequeue(Command))
{
Command.Execute();
}
}
void FMessageRouter::ProcessDelayedMessages()
{
FDelayedMessage DelayedMessage;
while ((DelayedMessages.Num() > 0) && (DelayedMessages.HeapTop().Context->GetTimeSent() <= CurrentTime))
{
DelayedMessages.HeapPop(DelayedMessage);
DispatchMessage(DelayedMessage.Context.ToSharedRef());
}
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3946692) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3801826 by Max.Chen PR #4304: Level Sequence crash fix - Guarded against dereferencing null componen. (Contributed by DSDambuster) Change 3801828 by Max.Chen PR #4302: Movie Scene Visibility Template unitialised variable, causing random . (Contributed by DSDambuster) Change 3801837 by Max.Chen Sequencer: Delay spawning/construction for convert to possessable. This fixes a bug where property values would be lost when converting back and forth from possessable to spawnable. #jira UE-52400 Change 3801841 by Max.Chen Sequencer: Make spacer nodes not selectable. PR #4194: Improvements to Sequencer (Contributed by projectgheist) #jira UE-53117 #jira UE-52139 Change 3804183 by Max.Preussner MediaAssets: Added missing lock in media sound component Change 3805414 by Max.Preussner MediaAssets: Setting valid GUID when initializing media texture resource Change 3819578 by Max.Chen PR #4370: When enabling the "MovieCapture", do not turn off the Stereo-3D display. (Contributed by yehaike) #jira UE-53647 Change 3823414 by Max.Chen Curve Editor: Lock down the first and last keys in the redundant keys removal range so that they're unaffected. #jira UE-53591 Change 3826406 by Max.Chen Sequencer: Move OnStartedPlaying() to within first update in UpdateTimeCursorPosition(). This fixes an issue where setting the hud/player visibility was getting stomped on later. #jira UE-52772 Change 3827044 by Max.Preussner MediaAssets: Added sprite visualization to media sound component #jira UE-53594 Change 3827988 by Max.Preussner MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together #jira UE-53532 Change 3828506 by Max.Preussner MediaPlayerEditor: Added attenuation visualizer for media sound components #jira UE-53594 Change 3832590 by andrew.porter EngineTest: Added a keep state check in Property Animation sequencer test Change 3833053 by andrew.porter EngineTest: Adding Hierarchical Bias test Change 3835683 by andrew.porter EngineTest: Adding UMG Animation screenshot test Change 3836076 by Max.Chen Sequencer: Fix audio volume and pitch multiplier deprecation. Change 3836230 by andrew.porter EngineTest: Adding Sequence Bone Position automation test Change 3836347 by Max.Chen Sequencer: Fixes to shot name parsing. When a shot doesn't contain a shot number, assume, [ShotName]_[TakeNumber]. When duplicating a shot, put the new shot in the same path of the original shot, so that the take numbers will increment properly. #jira UE-51868 Change 3836552 by Max.Chen Sequencer: Sub section now has a takes menu Change 3838094 by Max.Chen UMG: Fix template finish not getting called on stop. This fixes a bug where sections aren't restored when finished. #jira UE-52285 Change 3838708 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3840295 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840957 by Mike.Zyracki Added Show Only Keyable and Show Only Animated to the filter list in the property editor. Added IsPropertyAnimated to IDetailKeyframe Interface which already had support for showing properties which are keyable (which is used for the key icon next to the properties.). Could have created another interface but then would have had to mimic the sequencer binding, releasing also, so this seemed best way. One issue still left is that custom built detail items currently don't store associated properties(usually) and so certain properties, in particulalry transforms, won't show up as keyable or animated. Note this also shows up with the keyable icon not showing up next to transform tracks, and other filters like Show Only Modified not working with transforms/customs. Not sure best way to tackle this. #jira UESEQ-328 Change 3841756 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3843950 by andrew.porter EngineTest: Renaming LevelStreaming tests/content to LevelVisibility Change 3844082 by Mike.Zyracki Missing file for animated filter in property editor. When finding if a track is animated we need to find it but we can't easily induce the MovieTrack class for any particular property. So we don't set a class for it and just search by it's ID and name. #jira UESEQ-328 Change 3846902 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed #jira UE-54247 Change 3849820 by Mike.Zyracki Reassigning deleted widgets didn't work since the menu extender mechanism needs a valid UObject in order to perform an operation on it. So to fix we replaced GetObjectBindingContextMenuExtender in WidgetBlueprint with new delegate mechanism (OnBuildCustomContextMenuForGuid) that supports FGuid in addition to UObjects which is needed to handle re-binding deleted widgets. Note that the default sequencer hacks this for replacing deleted actors in SequencerObjectBindingNode to check to see if a LevelSequence is active. We could move to this mechanism there also. #jira UE-53163 Change 3852211 by Max.Chen UMG: Indicate name of the property that is not bound. #jira UE-54350 Change 3854120 by Max.Chen Sequencer: Fix sibling folders being allowed to have the same folder name. #jira UE-54363 Change 3854627 by Max.Chen Sequencer: Step to next/previous key should work for all tracks if there aren't any selected. #jira UESEQ-391 Change 3855825 by andrew.porter EngineTest: Adding animation blending automation test Change 3855950 by andrew.porter EngineTest: Adding correct expected valuues to animation blending test Change 3856237 by Matt.Hoffman UESEQ-336 - Sequencer Track Reordering Adds the ability to re-order Master Tracks, Folders and Object Bindings within sequencer hierarchies (including UMG). Adds the ability to do a one-off sorting of the content under the old sorting behavior if the user wants to reset their layout to how it was under legacy behavior. Modifies SequencerTrackNodes, SequencerFolderNodes and SequencerObjectBindingNodes to handle CanDrop/OnDrop for above, below and ontop of. Fixes a Slate Issue that forcibly expanded a TreeviewRow if an item handled OnDrop. Slate will now only forcibly expand the row if the item says the drop happened ontop of the item, and not above or below it like it previously did. Change 3856503 by andrew.porter EngineTest: Adding automation test for using animation blueprint with blend multi node in sequencer Change 3857875 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. #jira UE-54462 Change 3858344 by Max.Chen Sequencer: Prevent Goto and Transform boxes from overlapping by allowing them to be visible at the same time in an autosized horizontal box. Also, added close button to the goto box. PR #4425: Prevent Goto and Transform boxes from overlapping in Sequencer ... (Contributed by projectgheist) #jira UE-54210 Change 3860566 by andrew.porter MediaFrameworkTest: Set the option to index 0 for the audio and video track list by default Change 3860654 by andrew.porter EngineTest: Enabling Camera Cut + FOV test Change 3860981 by andrew.porter EngineTest: Updating skeletal mesh tests with a delay after set playback position Change 3861256 by Max.Chen Sequencer: Add all bindings if none selected. #jira-54440 Change 3862154 by Andrew.Rodham Added TimeManagement module Change 3862424 by andrew.porter EngineTest: Turned on the test Bone Positions with Blend Multi Node Change 3862573 by andrew.porter EngineTest: Adding test to compare bone positions in a sequence that is blending an animation that is using an AnimBP Change 3865117 by Max.Chen Sequencer: Stop auto scroll on mouse release of movement. #jira UE-31212 Change 3865303 by Max.Chen Sequencer: Add drag and drop transactions #jira UE-54662 Change 3865304 by Max.Chen Sequencer: Fix crash when an actor factory is not found. Change 3865361 by Max.Chen Sequencer: Don't change the camera/shot lock button when popping out of a sequence. #jira UE-54665 Change 3865412 by Max.Chen Sequencer: Determine whether a transform track is for a camera by using the spawned object or template #jira UE-54666 Change 3865685 by Max.Chen Sequencer: Clear autoscrub offset when stopping autoscroll #jira UE-31212 Change 3865886 by Max.Chen Sequence Recorder: Log an error if the number of frames changes while recording. This can happen if the skeleton changes while recording. #jira UE-48715 Change 3866925 by Andrew.Porter MediaFrameworkTest: Changing the current PNG test video image sequence to 1024 x 576 Change 3867705 by andrew.porter QAGame: Adding Audio Sort Sequence to dev folder Change 3867890 by andrew.porter QAGame: Adding a sequence for testing a sorting crash to my dev folder Change 3872628 by Max.Chen Movie Scene Capture: Split delay before warmup into split delay before shot warmup so that there's separate controls for when the movie scene capture warmups up vs. shot boundaries. Change 3873131 by Matt.Hoffman UE-54732 - Crash reordering a folder with a track. This was caused by folders being the only type of track to check if someone was putting a parent track into a child track. Object Binding tracks and Tracks now check as well so that you can't use the above/below drop targets to add parents as children. This also fixed a typo in the localization keys. #jira UE-54732 Change 3873301 by Mike.Zyracki Added ability to support continous euler angle changes when changing rotations, in particularly with the rotation gizmo's. To do this we effectively added a form an of 'euler filter'(https://en.wikipedia.org/wiki/Euler_filter) to find the closest euler angle to the current euler angle. Three functions were added to FRotator to make this possible, one to get the euler angle that's has the same rotation as it, one to get the difference between two euler angles via Manhattan distance and a third using the previous two to choose a Rotator value that's closest to it. We then use these functions before calling UComponent::SetRelativeRotation to make sure we use the correct Euler after the Quat conversion. We also no longer limit(bound) the euler angles to -180,180, which is obviously necessary to avoid flips. I also changed how we caluclate yaw and roll when pitch is -90 or 90 to make it the standard approach of zeroing out roll and just setting yaw. Main reasons are the previous implementation had precision issues so things like 180, 90, -180 would show up due to numbers being nearly zero but negative,(this would break any smooth interpolations), and this facilitates having a 'gimbal' rotation mode (like Maya, Blender etc..) if we ever want that also. If needed we could keep the previous implementation but would need to add some FMath::IsNearlyZero checks, with less performance. Note we only do this special filtering when applying delta's to actors or components in the editors, which then call UComponent::SetRelativeRotationExact, which is a new function to foces the RelativeRotation to be equal to the new rotation. This allows us to store un-nomalized Rotators at the cost that the RotationCache may be broken. We didn't change any of the other UComponent functions that set rotations (via Quats or Transforms) so they will still be bounded and unwound. In SetInternalWorldLocationAndRotation we only set the rotation if the rotation has changed, which fixes the rotation getting changed and re-normalized if just translate happens. In TransformTrackEditor, we correclty use the bUndwing flag and in MovieScene3DTransformSection there was an un-needed winding check there, it will be unwound earlier if needed, which happens if Sequence Recording is happening. Max we should talk about what to do about this . Note the euler angle drag via the widget is still bound to 0-360. I think we should just unbound that now since the rotations value are now unbound. This review now includes fixes suggested by Zak. #jira UE-UE-22228 Change 3873483 by Matt.Hoffman Sequencer Tracks can now be inserted above the spacer at the bottom of the tree. #jira UE-54706 Change 3873899 by Max.Chen Sequencer: Add section selection throbbing Change 3873908 by Max.Chen Movie Scene Capture: Added logging per frame Change 3873924 by Matt.Hoffman Adds the ability to store Sequence Recorder setups into profiles that stay with the map and can be re-loaded later. Profiles store the Actor Recordings so the settings for each actor should carry with them. #jira UESEQ-339 Change 3874726 by Matt.Hoffman Disable drag-and-drop targets on spacers that come between rows in Sequencer. This prevents extra drag/drop targets showing up between each row. #jira UE-54706 Change 3874862 by Matt.Hoffman Audio Track no longer gets reordered when adding sub-audio tracks, as sub-tracks are no longer counted towards the sorting order index when normalizing indexes. #jira UE-54727 Change 3875905 by Matt.Hoffman Disable Fade Track UI if a fade track already exists in the sequence. #jira UESEQ-393 Change 3876163 by Max.Chen Sequencer: Swap the camera object to the camera component's owner if it's not the same. #jira UE-54874 Change 3876971 by Andrew.Porter EngineTest: Moved Media Player Seek test to new folder. Also enabled the test with new ground truth image. Change 3877040 by Max.Chen Cine Camera: Split camera properties to two groups, "Camera Options" and "Camera Settings". The cine camera now hides properties in the "Camera Settings" group so that properties like bConstrainAspectRatio (in the "Camera Options" group) can be visible. #jira UE-54192 Change 3877763 by Max.Chen Curve Editor: Fix curve changed on end drag so that only curves that had keys/tangents that were changed receive notification, otherwise all loaded curves were getting notified that they were changed. #jira UE-54951 Change 3878234 by Matt.Hoffman Disable "Drop Below" targets for Sequencer Tree nodes to prevent a confusing UX issue where dropping underneath a Object Binding Node puts it after the object binding node but the UI looks like it's inserting it inside the Object Binding node. #jira UE-54743 Change 3879359 by Mike.Zyracki If a track is inactive we dim it a bit which seems to be the UE4 way to show inactive or disabled state. We changed the active logic so that all subtracks need to be inactive for the track to also be inactive(instead of all active for active). This conforms to how the active state actually works, e.g if you have two sections and only one is active the track is still active above it. #jira UESEQ-388 Change 3879462 by Max.Chen Sequencer: Allow dragging onto a particular row which would move out any overlapping sections to make space for the newly created section. Newly created sections are now selected and throbbed to draw attention to themselves. #jira UE-54664 Change 3879464 by Max.Chen Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field. - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field. - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges. #jira UE-54922 Change 3879590 by Matt.Hoffman Items that are now added to the Sequencer via the "+Track" menu will be selected after being added. Items can now be added inside of folders instead of just to the root level. #jira UE-27397 Change 3879612 by Mike.Zyracki Display Nodes with no children are always active. #jira UESEQ-388 Change 3879730 by Matt.Hoffman Sequence Recorder's actor recording groups now remove items from the group when removed via the UI. #jira UESEQ-339 Change 3880256 by Mike.Zyracki Fix issue with inactive display with folders and other track nodes. #jira UESEQ-388 Change 3883491 by Max.Chen Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes. Copy from Release-4.19 #jira UE-51323 Change 3883603 by Max.Chen Movie Scene Capture: Add option toggle disable screen percentage. By default this is on (no change in current behavior). #jira UE-51898 Change 3885074 by Max.Preussner MediaCompositing: Resetting media texture & freeing resource on section end; removed dead code Change 3887220 by Max.Preussner MediaCompositing: Defaulted media section duration to 1 sec (since we do not know the actual duration in most cases) Change 3887478 by Matt.Hoffman Sequences now show [Inactive] in their title bars when they're disabled. This helps communicate why a sequence isn't being evaluated. #jira UE-51469 Change 3888985 by Max.Chen Movie Scene Capture: Clamp HDR Compression Quality between 0 and 1. #jira UE-55136 Change 3893519 by Max.Chen Sequence Recorder: Clarified tooltip for bRecordNearbySpawnedActors - spawned actors will still be recorded if they match the ActorFilter. #jira UE-55238 Change 3893546 by Max.Chen Sequence Recorder: If a selected actor already has a recording, add a blank recording. #jira UE-55239 Change 3894044 by Max.Preussner MediaCompositing: Added support for seeking into a media section Change 3894310 by andrew.porter MediaFrameworkTest: Adding Img media sources for 1080 and 2160 ravent test content Change 3894426 by Max.Preussner MediaAssets: Letting media textures with AutoClear retain their clear color when player is reset Change 3895717 by Max.Chen Sequencer: Null checks to prevent crash when saving the default state of a spawnable #jira UE-55304 Change 3897388 by Max.Chen Sequencer: Don't update current time to be within the view range when stepping into a sequence. #jira UE-55322 Change 3897452 by Max.Chen Audio: Fix crash when trying to record audio without any active capture devices. Log warning if the number of input channels is not 1 or 2. #jira UE-55223 Change 3897619 by Max.Preussner MediaCompositing: Removed commented out code Change 3898072 by Max.Chen Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated. #jira UE-55328 Change 3898272 by Max.Preussner MediaPlayerEditor: Made slate brush constants static Change 3898704 by Max.Chen Sequencer: Skip if the binding id's sequence can't be found. #jira UE-55337 Change 3899855 by Max.Preussner MediaCompositingEditor: Added cache state visualization to media track Change 3900300 by Max.Preussner MediaCompositingEditor: Added loop indicators to media sections Change 3900694 by Max.Preussner ImfMedia: Looping cache only when player is looping Change 3900892 by Max.Preussner Stats: Added stats category for media framework Change 3900954 by Max.Preussner MediaCompositing: Don't evaluate at the end of media section Change 3901348 by Max.Preussner Core: Replaced TLruCache autos for better readability Change 3901655 by Max.Preussner ImgMedia: Added more perf stats to EXR reader Change 3901972 by Max.Preussner MediaAssets: Added getter for media player in media sound components Change 3902233 by Max.Preussner MediaAssets: Enabling media textures to receive samples right after player is assigned Change 3902238 by Max.Preussner MediaCompositing: Working around init/shutdown idiosyncracies in sequencer Change 3904045 by Max.Chen Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register. #jira UE-55314 Change 3905605 by Max.Chen Sequencer: Restrict spawnables from being created if they have a ClassWithin that UMovieScene is not a child of. #jira UE-55429 Change 3906550 by Max.Chen Sequencer: Add media track icon #jira UE-55480 Change 3907101 by Max.Chen Sequence Recorder: Fix bugs related to not recording a level sequence. There were certain assumptions that creating a level sequence meant that sequence recording was in progress. This is not always the case - the recorders can record animation assets and not create a level sequence. Changed the notion of IsRecording() to having at least one actor recording that is recording. Countdown timer, recording displays, etc should function if IsRecording() and not based on whether a level sequence is created. #jira UE-55485 Change 3907247 by Max.Chen Sequence Recorder: Fix crash not removing PrepareToCleanseEditorObject delegate. Repros when opening sequence recorder, closing it, and then opening or creating a level. Change 3910343 by Max.Preussner Core: Added async helper for executing functions on a given thread pool Change 3910346 by Max.Preussner ImgMedia: Added separate thread pools for loading/decoding and deleting image frames Change 3910829 by Max.Preussner Profiler: Increased visible range of profiler graph Change 3910841 by Max.Preussner MediaCompositing: Displaying asset name instead of full media source path in media section Change 3910870 by Max.Preussner ImgMedia: Using deallocation thread pool only in debug builds Change 3919642 by Max.Chen Sequence Recorder: Clarify active tooltip #jira UE-55661 Change 3919660 by Max.Chen Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified - The following sequence of events exposes this issue: - Create a master sequence with a single shot that spawns a cube - Add this sequence to a level and set it to auto-play - Save everything and restart - Resave just the inner shot asset without opening it - PIE - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template. #jira UE-55626 #jira UE-55490 Change 3921825 by Max.Chen Sequencer: "Run Construction Script in Sequencer" is off by default for blueprints but on for Sequencer. This allows the content author to switch it on for specific blueprints and sequencer will be default, run those with construction scripts enabled. Change 3922232 by Max.Chen Sequence Recorder: Reset countdelay on stop. #jira UE-55755 Change 3922306 by Max.Chen Sequence Recorder: Don't automatically mark transforms to be recorded by sequence recorder. Instead, log a warning if the user toggled it off to warn that the resulting animation might not match gameplay. #jira UE-55758 Change 3922912 by Max.Chen Sequence Recorder: Fix refresh next sequence name #jira UE-55757 Change 3927654 by Max.Chen Movie Scene Capture: Added format mapping for the name of the current camera #jira UE-55769 PR #4537 Change 3927658 by Max.Chen Sequencer: Added fbx property mapping for "FocusDistance" to "FocusSettings.ManualFocusDistance" #jira UE-55782 Change 3932022 by Max.Chen Sequencer: Add import animation track section to next available row index. #jira UE-55892 Change 3933919 by Max.Chen Sequencer: Jump to playback start frame and not 0 to start playback for recording. #jira UE-55933 Change 3934307 by Andrew.Rodham Sequencer: Add template signature that is re-generated every time the base template is regenerated, which invalidates evaluation fields This fixes an issue where the same sequence is instantiated multiple times in a sequence. If the source sequence was saved, its template would be wiped, which would invalidate the template ID When an instance tries to evaluate the master template, it would only invalidate a range in the evaluation field that was the hull of any invalid sub sequences overlapping the current time, potentially leaving invalid data in the evaluation field at positions later (or earlier) on in the sequence When the sub template was re-generated, it receives the same SequenceSignature as it had before (because the sequence hasn't actually changed), which causes the stale evaluation field data to fail the IsDirty check (because the sequence is the same as it thought, but the *template* has changed) This has been addressed be adding a signature to templates themselves, and checking both the template signature and sequence signature as a part of the IsDirty check. This ensures that we regenerate if either the template, or the sequence have changed. #jira UE-55934 Change 3936327 by Andrew.Rodham Sequencer: Removed increment when trimming right UMovieSceneSection::TrimSection already explicity assigns an exclusive bound to the time passed in. The new behavior means we can trim a section to the right, and insert another section without changing the time to create adjacent sections. #jira UE-42652 Change 3936328 by Andrew.Rodham Fixed KeyFrameManipulator assignment operators and copy/move constructors - These types are potentially self-referential so cannot use default constructors/assignment Change 3936330 by Andrew.Rodham Converted UMGSequencePlayer to use frames internally #jira UE-54878 Change 3936726 by Max.Chen Sequencer: Set track node as the parent of the key area node. The key area switcher needs the object binding id from the parent object binding node. Without this, the binding to the external value fails. #jira UE-55931 Change 3936775 by Max.Chen Sequencer: Should stop or loop should compare DurationFrames with Current Time from StartTime. The bug is that if you set 30 warmup frames in movie rendering for a range of 0-100, the FrameRange will be starting at -30 and have a duration of 130. Without this fix, the playback will continue until frame 130, rather than 100. #jira UE-55933 Change 3936935 by Matt.Hoffman Easing Curves are now represented in Play Rate resolution instead of internal resolution. #jira UE-55937 Change 3937069 by Matt.Hoffman Users can toggle if the is infinite on each side, limited by which tracks support infinite ranges. #jira UE-55891 Change 3937516 by Max.Preussner ImgMedia: Added support for single-threaded platforms #jira UE-55986 Change 3937826 by Max.Preussner MediaAssets: Disabling media sound components on HTML5 if AudioMixer is not enabled Change 3937997 by Max.Chen Curve Editor: Add Zoom to Fit Curves so that selected curves from Sequencer can be focused on. Tested that undo doesn't re-zoom. #jira UE-55935 Change 3938000 by Max.Chen Sequencer: Stop all sounds before generating audio waveforms. #jira UE-55951 Change 3938376 by Max.Preussner XGEController: Disabled XGE Controller in single-threaded apps to prevent crash Change 3938444 by Max.Preussner Core: Added async support for single-threaded applications Change 3938445 by Max.Preussner Networking: Added support for single-threaded applications in UDP socket sender/receiver Change 3938447 by Max.Preussner Messaging: Added support for single-threaded applications Change 3939432 by Max.Chen Sequence Recorder: Append command list to global level editor actions so that shortcuts are accessible in level editor. #jira UE-55798 Change 3940229 by Andrew.Rodham Added prospective display rate upgrade to UMovieScene::PostLoad - There was previously some very odd behaviour that would assign the fixed frame interval only when a sub sequence was focused in SSequencer. This meant that many sequences could have a frame interval of 0 set in the data. - Under the old method of snap interval display this would have fallen back to getting the display interval from the sequencer settings, but we no longer look at these. - The USequencerSettings properties have been removed and in their place, a prospective data upgrade for sequences that have a fixed frame interval old 0fps that sets the play rate to the previous defaults based off the old USequencerSettings defaults. - This could end up 'changing' the display rate for sequences where the user has changed the snap interval in the settings for a particular sequence editor, but there's not much we can do about that given we don't have access to the USequencerSettings classes in UMovieScene #jira UE-55919 Change 3940277 by Andrew.Rodham Sequencer: Added ability to default frame resolutions and play rates for newly created actor sequences Change 3940378 by Andrew.Rodham Sequencer: Post move import dialog now defaults to the playback framerate of the sequence, and floors to frame numbers Change 3940559 by Andrew.Rodham Reinstated primed or recording sequence color Change 3940642 by Max.Preussner ImagePlate: Removed image plate media playback functionality Change 3940843 by Max.Preussner Core: Made TCircularQueue actually thread-safe; improved code comments Change 3940860 by Max.Chen Sequencer: Changed StructNameToKey to StructPathToKey Previously, keying a PropertyPath of [RenderTransform][Shear][X] would get trimmed to X, which doesn't map to a channel name as considered by Sequencer2dTransformTrackEditor. Instead, trim the resulting property path to [Shear][X] so that track editors can determine the desired struct path and channels to key. #jira UE-52966 Change 3941292 by Mike.Zyracki Fix for trajectories out of range not showing up. 1) If we had no key data we would pop the time, so wouldn't get the section ranges. 2) Calculating of upper bound was wrong, checking against -1 and not key == num of keys when doing algo::lower_bound. 3) No need to do the Bck-- for the bakward iterators since we fixed #2. We start now from the upper bound correctly. 4) If we had no keys (at section start,end) we would incorrectly say we were any key type, so since we draw constant keys as dashed we would do so incorrectly around section end points. #jira UE-55929 Change 3941424 by Max.Chen Curve Editor: Change Zoom to Fit to use TArrayView Change 3941498 by Max.Preussner Core: Added FMath::DivideAndRoundNearest function Change 3942097 by Matt.Hoffman Drop Frame Timecode Support for NTSC rates. Change 3942104 by Matt.Hoffman Sequence Recorder Group is no longer visible inside the World Outliner after using one. #jira 55266 Change 3942107 by Max.Chen Sequencer: Resurrect logic to find or extend an existing section when adding keys. Change 3942330 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942339 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942507 by Andrew.Rodham Sequencer: We no longer pad the time overlap threshold with a small number that is not scaled by the current zoom level - The presence of this pad was causing keys that were far apart to be grouped when zoomed in a long way Change 3942509 by Andrew.Rodham Sequencer: Only pad total view range, rather than section range as well when retrieving keys to render - This stops us from rendering keys that are within the view range, but outside the section range Change 3942512 by Andrew.Rodham Added transactions to some sequencer details customizations Change 3942513 by Andrew.Rodham Sequencer: Reinstated validation checks to UMovieSceneSection::SetStartFrame and SetEndFrame, changed erroneous uses to use SetRange Change 3942560 by Andrew.Rodham Pass by rvalue reference to appease error C2719 on Win32 ('InChannels': formal parameter with requested alignment of 8 won't be aligned) Change 3942697 by Andrew.Rodham Newly Created Level Sequences and Actor Sequences now default to 24000 fps frame resolution (+/- ~24hrs range, supporting all integer rates + 23.976) Change 3942700 by Andrew.Rodham Sequencer: Added legacy out-of-bounds errors for times that are not supported by the current legacy upgrade frame resolution Change 3942989 by Max.Preussner Core: Fixed circular queue count calculation Change 3943538 by Max.Preussner MediaAssets: Reverted workaround for procedural audio log spam in HTML5 (Actor component initialization cannot be skipped if the component is used in a level) Change 3944071 by Max.Preussner QAGame: Fixed Media Texture keeps last frame of Media when PIE ends #jira UE-53360 Change 3944292 by Max.Chen Sequencer: Added extra flags to ensure that asset initialization does not occur on template actor sequences #jira UE-56113 Change 3944364 by Max.Chen Sequencer: Prevent circular shot/master tracks. Tested adding master -> child -> master as drag and drop cinematic shot tracks and sub tracks as well as through the + button. #jira UE-56091 Change 3944422 by Max.Chen Sequence Recorder: Disable transform recording if off. #jira UE-56061 Change 3944745 by Andrew.Rodham Sequencer: Key rendering fixes - Fixed assert that occured when keys happened to reside on some times due to KeyTime + TimeOverlapThreshold - KeyTime being slightly larger TimeOverlapThreshold - Fixed keys sometimes being clipped when zoomed right in due to lack of half-frame offset - Added missing documentation to MovieSceneTimeHelpers.h #jira UE-56107 Change 3945231 by Andrew.Rodham Sequencer: Reconstruct channel proxy on Serialize to catch all cases of undo/redo, PostLoad and duplication #jira UE-56089 Change 3945301 by Andrew.Rodham Sequencer: Added safety checks during initial sequence recording to guard against applying negative or 0-sized sequence ranges #jira UE-56125 Change 3946627 by Max.Preussner Fortnite: Fixed game crashes closing editor while in PIE - Pure virtual function being called #jira UE-56144 [CL 3946896 by Max Chen in Main branch]
2018-03-14 22:09:33 -04:00
/* FSingleThreadRunnable interface
*****************************************************************************/
void FMessageRouter::Tick()
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 4044339) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3947021 by Max.Chen Sequencer: Don't preserve root component when copying object properties. A spawnable empty actor, has a root component that is generated by the empty actor factory. If the object template's root component is preserved when copying from the spawnable empty actor, the root component will not be copied over. Therefore, we need to NOT preserve the root component when copying object properties. #jira UE-55825 Change 3947366 by Max.Preussner WmfMedia: Better log output Change 3947367 by Max.Preussner MfMedia: Better detection of compressed format properties on Windows Change 3949102 by Max.Chen Sequencer: Remove SequenceActorTag when converting to possessable. #jira UE-56206 Change 3949207 by andrew.porter EngineTest: Set the screenshot nodes resolution to 1280x720 Change 3949404 by Max.Chen Sequencer: More informative tooltip for "Rerun Construction Scripts" option. It now says "Rerun construction scripts every frame on actors that have 'Rerun Construction Script in Sequencer' enabled in their class settings". Change 3950067 by Matt.Hoffman Renamed UAutomatedLevelSequenceCapture's StartFrame and EndFrame to CustomStartFrame/CustomEndFrame to reflect that it is user-overriden. This will also resolve upgrade issues due to the variable datatype changing. #jira UE-56189 Change 3950193 by JohnHenry.Carawon Updating my latest MovieRendering test content. Change 3950757 by JohnHenry.Carawon More updates to MovieRendering test content Change 3952059 by Max.Chen Resave LevelVisibility_SubLevels to fix data loss conversion warning of OpacityMaskConstant #jira UE-56086 Change 3952283 by Max.Chen Sequencer: Disable dropping level sequence assets as spawnables. #jira UE-56120 Change 3952422 by Max.Chen Sequence Recorder: Add button to record from the current player. #jira UE-55942 Change 3952987 by JohnHenry.Carawon MovieRendering Test Content - Fixing camera bindings and changing the override binding actor Change 3953823 by Mike.Zyracki Fix for Bad FBX Import Tangents not scaled by frame rate. After looking at this again it seems that a set of MovieScene:: overiddes for the channel traits wasn't set correctly, so use the ADL idiom to use MovieScene, which can then call Optimize in the correct namespace. With this we can now correctly use the passed in tolerance. There was also a redundant set of Optimize calls so that it could happen twice so removed them, and needed an extra check in the float channel Optimize. Also since we need to set auto tangents no matter if we optimize we don't set that parameter(though leave it since it's used by context menu key reduction). Finally fixed speed issue with trajectories caused by calculating way too many substeps. Reverted back to a time based step size for consistency. #jira UE-56193 Change 3954317 by Matt.Hoffman Adding a key to the last frame of a section no longer causes a crash. Keys can already be moved to be on the last frame of a section so now you can just add a key there directly. #jira UE-56255 Change 3954326 by Matt.Hoffman Dilating a section that is only infinite on one side no longer causes a crash. #jira UE-56260 Change 3954486 by Max.Chen PR #4580: Exposes IsReversed() from UMovieSceneSequencePlayer (Contributed by alanedwardes) Change 3955238 by Max.Preussner Messaging: Enabled delayed message routing https://github.com/EpicGames/UnrealEngine/pull/4574 #jira UE-56247 Change 3955901 by Max.Preussner MediaFrameworkTest: Added developer test for overriding desired media player plug-in at runtime. Change 3955922 by Andrew.Porter QAGame: Updating movie rendering content in dev folder Change 3956004 by andrew.porter QAGame: Adding MPC track to movie rendering test content Change 3956510 by Max.Chen Sequencer: Fix fbx camera import of static properties so that they are imported before default tracks are created. Otherwise, the default tracks inherit the default properties of the camera, rather than the values from the fbx. #jira UE-56311 Change 3957613 by Max.Preussner MediaUtils: Added code documentation to media player facade Change 3958005 by Max.Preussner MediaUtils: Added method to get number of sinks Change 3958934 by Max.Chen Sequencer: Fix keys getting added and sequence getting erroneously re-evaluated when auto key is off. Only apply defaults if there are no keys. Only modify the movie scene section before creating keys or setting defaults. #jira UE-55903 Change 3959687 by Andrew.Rodham Sequencer: Fixed visibility track external values being inverted #jira UE-56324 Change 3960507 by Max.Preussner Core: Fixed incorrect rounding in FMath::DivideAndRoundNearest Change 3962047 by JohnHenry.Carawon MovieRendering Test Content Changes: - Add Lightmass Importance Volumes to sublevel to fix warnings - Rebuilt Lighting - Add a third sequence for Gamut testing - Resaved the sound master.uasset to fix warning Change 3962211 by Mike.Zyracki Add Frame Numbers to selected animation sections. Added MapTimeToAnimation to MovieSceneSkeletalAnimation so that we could get it from the Skeleton Animation track Editor. Since the thickness of the frame line can change based upon frame rate and zoom we need to calculate it similarly to how the time slider controller does it. Those calculations were private so we had to expose FScrubRangeToScreen and GetScubberPixelRange from the TimeSliderController. Also needed to know if the section itself was selected so added a bIsSelected flag to the section Painter. Also fixed a bug where you couldn't add a section if other sections existed at different times in MovieScenePropertyTrack and could crash due to the check(). #jira UESEQ-395 Change 3962497 by Max.Preussner Core: Added new string formatting argument to FTimespan Change 3963662 by Max.Chen CineCamera: Flip VistaVision width and height. Change 3963731 by Max.Preussner MediaCompositing: Implemented sequence recording support for media track Change 3964195 by Andrew.Rodham Sequencer: Set inverted property correctly for newly created visibility track sections - Also clamp evaluation for key editors to the bounds of the section so we're not displaying values outside of the section bounds when the cursor is not on the bounds #jira UE-56324 #coderevew Max.Chen Change 3964196 by Andrew.Rodham Sequencer: Fixed crash when attempting to render sections that resulted in a negative intersection with the view range Change 3964275 by Andrew.Rodham Sequencer: Fixed MovieScene::ClampToDiscreteRange for infinite range bounds Change 3964364 by Andrew.Rodham Curve Editor: Reduce minimum vertical view range when zooming to fit Change 3965091 by Max.Chen Sequencer Recorder: Refresh next sequence if empty when starting a recording, otherwise, use existing name. #jira UE-56469 Change 3965148 by Max.Chen Sequence Recorder: Move Record to Possessable to "Actor Recording" group Change 3965162 by Max.Chen Sequence Recorder: Always break out of immersive mode when done recording, even when stopping recording during countdown. #jira UE-56407 Change 3965214 by Max.Preussner QAGame: Enabled ImagePlate plug-in Change 3965574 by Max.Preussner SimpleComposure: Reorganized & upgraded content to work with new Media Track #jira UE-56488 Change 3965651 by Max.Preussner MediaCompositing: Ignoring seek-on-open if media not seekable Change 3966075 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Export functionality #jira UESEQ-358 Change 3966087 by Matt.Hoffman Adding a single key to the Particle Toggle track now makes an infinite range section that is displayed in the UI. #jira UE-56295 Change 3966547 by Andrew.Rodham Sequencer: Fixed rounding errors when drawing the section background on boolean sections - Logic was using time in sectonds which caused rounding errors on evaluation and flickering red/green stripes when dragging keys around #jira UE-56324 Change 3966563 by Andrew.Rodham Curve Editor: Key editor interface improvements - SKeyEditInterface has a few problems - it does not update in real time when editing properties, and does not support multi-edit which makes it unsuitable for use with the curve editor - We now take a different approach for editing keys by gathering a set of proxy UObjects for each key that is currently selected. These objects are added as top level objects to the details panel which means they support multi edit as you'd expect from any other details panel in the editor. - Proxy objects are updated every tick for the curve editor if they implement the ICurveEditorKeyProxy interface, which allows them to refresh their current value. - Ideally, the same mechanisms would be used in the main sequence interface, and we would be generating the proxy classes at runtime based on the key value type, but that work remains a separate task from this initial offering. #jira UE-56165 Change 3966564 by Andrew.Rodham Curve Editor: Expand to frame when adding or moving keys in the curve editor Change 3967051 by andrew.porter MediaFrameworkTest: Set the CameraPlayer_Video texture to auto clear Change 3967141 by Andrew.Rodham Sequencer: Keep track of spawned objects that have been modified and only re-save such object's default spawnable state on destruction - Now that we're taking this approach, I've remove serveral redundant bits of functionality in the spawn register such as making some spawnables read-only, and the PreSave binding for Sequencer. - We now hook into all object pre-saves to make sure we handle the case where the sequences are saved through the content browser or elsewhere. #jira UE-47686 Change 3967170 by Andrew.Rodham Sequencer: Added the ability to possess anim instances as object bindings - This allows full and direct animation of properties on UAnimInstance, and animation blueprints - Object Bindings are made by first possessing a skeletal mesh component, then choosing the + Add button where its anim instance will be listed - Added a new function to UMovieSceneSequence to gather previously cached objects that should now be invalidated. Anim instances will be re-resolved if a new UAnimInstance is assigned to USkeletalMeshComponent::GetAnimInstance. - ObjectBindingIDs for anim instances are just represented by an entry in a set of GUIDs. We only ever resolve such bindings through USkeletalMeshComponent::GetAnimInstance. - Only currently supported on LevelSequences #jira UE-56132 Change 3967195 by Max.Preussner Core: Updated TRangeSet to use TCallTraits Change 3967345 by JohnHenry.Carawon Test Content Changes - first iteration of spacing out the examples in the shots. Change 3967572 by Max.Chen Sequencer: Fix setting PreviousPlayEvalPosition until after we've tested whether it's set. #jira UE-56518 Change 3967750 by Max.Chen Audio: Set duration based on number of input channels, rather than number of channels to serialize. This fixes an issue where audio split into 2 channels is set to a duration that's twice as long. #jira UE-56430 Change 3967836 by Max.Chen Sequencer: Allow for animating array elements within ustruct properties #jira UE-55887 Change 3968506 by Matt.Hoffman Fixed ambiguous conversions for seconds and frames being overriden by ambiguous conversion to Timecode (in frames). Change 3968748 by Max.Chen Sequencer: Make the event properties submenu widget larger. #jira UE-55557 Change 3968862 by Max.Chen Sequencer: Recursive expansion when shift is down #jira UE-52139 #pr 4194 Change 3968863 by Max.Chen Sequencer: Bind rename command to selected track so that F2 shortcut start renaming #jira UE-52139 #pr 4194 Change 3968872 by Max.Chen Sequencer: Rekey the selected key at the current time. #jira UESEQ-396 Change 3968938 by Max.Chen Cine Camera: Add option to toggle the behavior of locking the rail mount to the orientation of the spline. By default, the option is off, no change in behavior. #jira UE-55815 Change 3968958 by Andrew.Rodham Sequencer: Consider vertical position when hittesting keys #jira UE-56256 Change 3969643 by Max.Preussner Core: Rounding timespans created from double values towards nearest ticks Change 3969646 by Max.Preussner MediaUtils: Implemented timeout mechanism for block-on-fetch feature Change 3969776 by Mike.Zyracki Added Skip Anim Notifiers Toggle per what was in Matinee. Investigated the Enable Root Motion toggle as also discussed but it's implementation is directly contained by the animation asset and unlike animation notifies there seems to be no exposure to interactively disable it during a playback tick. Note if we are generating thumbnails we still automtically disable notifies in the editor to avoid annoying noise playback. Note that if Enable Root Motion/Root locked is specified in the animation asset it does correctly effect the Sequencer. #jira UESEQ-399 Change 3969835 by Matt.Hoffman Playback Range and Selection Range use unified logic for adding themselves as potential snap locations which properly handles inclusive/exclusive bounds. This resolves an issue where having an unset selection range caused a potential snap location to be added on frame 0 and 1 (internal resolution) which caused a misalignment when placing objects near frame 0. This also removes the one frame offset on setting Selection Range to bring behavior inline with other ranges. #jira UE-55420 Change 3969885 by Max.Preussner MediaAssets: Don't register media player CDO with media ticker Change 3971129 by Andrew.Rodham Sequencer: Fixed UMovieSceneSequencePlayer::GotToEndAndStop() not taking into account for start time This is a remnant from when the times were always specified in 0-duration space, rather than actual sequence times. Change 3972056 by JohnHenry.Carawon More updates to Test Content. I continued spacing out the examples in the sequence so that they have a consistent number of frames between each example and during the start/end of the example. Also removed the Marcie sublevel. Change 3972066 by Andrew.Porter MediaFrameworkTest: Setting Marcie folder to be never cooked in package settings Change 3972675 by Matt.Hoffman Splitting Subsequence Sections no longer sets an incorrect playback range on the subsequence when the subsequence has a different internal resolution than the owning sequence. #jira UE-55453 Change 3973376 by Max.Preussner ImgMedia: Zero is the only valid video track for image sequences Change 3973489 by Max.Preussner Launch: Build rules cleanup pass - don't use Media, MediaUtils on server apps - don't link against Media (include-only dependency) - don't include from MediaAssets (dynamic load only) Change 3973760 by Max.Preussner MediaUtils: Moved AppMediaTimeSource implementation into its own file; added logging Change 3973765 by Max.Preussner ImgMedia: Disallowing seek beyond media length Change 3973855 by Max.Preussner MediaFrameworkTest: Updated developer test content Change 3973858 by Max.Preussner MediaCompositing: Blocking on media player time instead of media sample time (the former may not be hit in the current frame) Change 3974988 by Max.Chen Sequencer: Fix trim left so that it also sets the start offset for audio and skeletal animation sections. #jira UE-57015 Change 3976101 by Matt.Hoffman Sequencer will now focus the scroll view on newly created items. #jira UE-56492 Change 3976203 by Max.Chen Property Editor: Add DetailsViewArgs for ColumnWidth. Defaults to 0.65f, no change in existing behavior. Change 3976205 by Max.Chen Sequencer: Set better column widths for sequencer. #jira UE-55557 Change 3976206 by Max.Chen Sequencer: Added menu category for import/export Change 3976265 by Matt.Hoffman Tracks within Object Binding Nodes will now sort using the old behavior so that components are added above other track types. #jira UE-56473 Change 3976901 by Max.Chen Sequencer: Add event names to event track section #jira UESEQ-353 Change 3977878 by Max.Preussner Media: Moved media framework ticking stats into Media module Change 3977982 by Max.Chen Sequencer: Add Edit->Reset section length to duration of source (ie. audio, skeletal animation, shot length) Added MovieSceneSection::GetDefaultDuration and MovieScene::HasDefaultDuration #jira UESEQ-392 Change 3977994 by Max.Preussner Media: Fetching and rendering media samples before viewports are rendered (to ensure frame sync for in-level media playback) #jira UE-53975 Change 3978188 by Matt.Hoffman Easing Curves are now clipped by the sequence's PlayRange when testing against an infinite section. This causes blended sequences to finish their blend when the section starts/ends instead of always using 25% of the total section length to determine default blend range. #jira UE-56362 Change 3978676 by Max.Preussner MediaCompositing: Fixed first frame of rendered out media track missing #jira UE-53975 Change 3978684 by Max.Preussner MediaCompositing: Enabled media track frame sync feature #jira UE-53975 Change 3980026 by Matt.Hoffman Keys can be selected on folded out sections (such as an audio track expanded to show volume and pitch) again. #jira UE-57169 Change 3981614 by Max.Preussner MediaUtils: Added missing subtitle sample queue flush Change 3982311 by Max.Preussner MediaCompositing: Added safeguard for zero length media sources Change 3982389 by andrew.porter QAGame: Adding media track test content into FrameAccuracySubscene Change 3983661 by Max.Chen Sequencer: Add level name to spawn a spawnable into. Add sublevel menu option to set the level #jira UESEQ-390 Change 3983712 by Andrew.Rodham Sequencer: Purge legacy blueprint spawnables from LevelSequence packages #tests Ran a preflight for cooking fortnite, ocean and Orion. Only orion shows up this edge case, and will require a re-save of the EndCines level #jira UE-39173 Change 3983787 by Max.Preussner MediaCompositing: Moved compile time switch for block-on-fetch into media player facade Change 3983812 by Andrew.Rodham Sequencer: Exposed default level sequence instance data to blueprints Change 3984373 by Max.Preussner Media: Added API for quering whether player plug-in supports block on fetch Block on fetch allows Sequencer and other systems to block the game thread until a desired video frame has been decoded. Change 3984670 by JohnHenry.Carawon Movie Rendering Test Content progress. Saving the state of the content. There is a bug where things got replaced with particle emitters and I think it was because I tried to copy paste an animation track into a separate skeletal mesh track. Change 3985097 by Max.Chen Sequencer: Rename Reset to AutoSize Change GetAutoSizeDuration to return TOptional<FFrameTime> #jira UESEQ-392 Change 3986043 by Max.Chen Sequencer: Fix crash when attach/path duration is less than 0. #jira UE-57310 Change 3986373 by Max.Chen Sequencer: Add support for deleting tracks and channels which equates to setting the channel mask. #jira UE-52951 Change 3986375 by Max.Chen Sequencer: Add Create Pose Asset to skeletal animation section. This allows animators to blend animations in sequencer and create new pose assets from them. #jira UESEQ-408 Change 3986796 by Andrew.Rodham Sequencer: Fixed stale object references remaining in ULevelSequence::BindingReferences when using convert to spawnable/possessable - We used to convert objects by creating a new binding, then re-assigning its GUID, which meant we didn't have to do any further object fixup, but the code to achieve this was confusing and led to a vulnerability where object references would not be cleaned up correctly due to the newly created possessable essentially being a temporary object that's immediately thrown away. - To address this, there is now a function for porting all the contents of one object binding to another, and handles the correct fixup required for parent/child object bindings for both spawnables and possessables. - Also added codepath to remove any stale object references from the level sequence reference map on PostLoad (this piggy-backs off the PurgeLegacyBlueprints object version which is close close enough to this change to be identical) #tests Verified that existing sequences with stale references get cleaned up on load. Verified that repreatedly converting from spawnable<->possessable cleans up references correctly. Change 3987807 by JohnHenry.Carawon Updates to the MovieRendering Test Content. - Fixed the spawnable actors that were overwritten - Shortend the Lighting example and combined the Intensity and Color tracks - Organized the Sequence and WorldOutliner to group the examples. Change 3988151 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. Change 3988880 by Max.Chen Sequencer: Support enter to add asset for all sequencer track editors that have asset pickers. #jira UE-57367 Change 3988953 by Max.Chen Sequencer: Make the track color picker focusable so that it will close when you click away or lose focus. #jira UE-57210 Change 3988962 by Max.Chen MovieSceneCapture: Fix EDL export so that it takes into account movie scene frame resolution and desired frame rate. #jira UE-57365 Change 3988964 by Max.Chen Movie Scene Capture: Clarified tooltip for bRelativeFrameNumbers. If you specify custom start/end frames for the recording, they will be relative to the playback range. #jira UE-57308 Change 3989442 by Max.Chen Fix CIS Change 3991548 by Matt.Hoffman Dragging the time slider no longer causes the time slider to ignore snap-to-interval with "Snap to Keys While Scrubbing" when no keys are in range. #jira UE-57417 Change 3991598 by Matt.Hoffman Snap to Key while scrubbing now mirrors the behavior of "jump to next key". When there are no tracks selected it snaps to all keys and when there are tracks selected it snaps to only keys from that track. This also resolves an issue where deleting an object did not remove it from the Sequencer's selection. Undoing a delete already doesn't seem to restore your selection, so removing it from your selection shouldn't change that behavior. #jira UE-57417 Change 3991603 by Max.Chen Sequencer: Disable EditAnywhere for some section properties #jira UE-53530 Change 3992240 by Max.Preussner MediaAssets: Implemented dynamic audio sample rate adjustment based on audio/media clock drift #jira FORT-70638 Change 3992911 by Andrew.Rodham Sequencer: Fixed saving spawnable state using the wrong spawned object - We now track the object binding ID so that we can apply the spawned object to the correct spawnable when the asset is saved #jira UE-57353 Change 3992914 by Max.Chen Movie Scene Capture: Fix compression quality not being set. The compression interface wasn't being found through query interface, so no compression was being set. Reworked finding it through the output pins. Tested running various compression values. #jira-UE-55488 Change 3992919 by Max.Chen Sequencer: Convert to possessable now uses object template instead of copying properties (ie. see LevelSequenceActorSpawner). This fixes MIDs getting lost when converting to spawnable and back to possessable. #jira UE-52400 Change 3993184 by Max.Chen Sequencer: Don't show +Transform/+Path/+Attach track if the actor has the "Mobility" property hidden. Set the Landscape, LandscapeProxy and InstancedFoliage "Mobility" property to be hidden since it is static is not supposed to be dynamically movable. #jira UE-56347 Change 3993238 by Max.Chen Sequencer: Test for hidden mobility in creating keys as well. Refactored to HasHiddenMobility() #jira UE-56347 Change 3993978 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. #jira UE-57489 Change 3994039 by Max.Chen Landscape: Add Mobility to hidecategories on landscape component #jira UE-56347 Change 3994626 by JohnHenry.Carawon Updated Movie Rendering Test Content. - Fixed the overridden spawnables to their proper object types. Change 3994653 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Import functionality, improved Export functionality #jira UESEQ-358 Change 3995609 by Max.Chen UMG: Add support for 2d transform mask (translation, rotation, scale, shear) #jira UE-52951 Change 3995778 by JohnHenry.Carawon Movie Rendering Test Content Updates - Adjusted Lights example - Adjusted Camera example - Added Marcie sublevel back in Change 3995942 by JohnHenry.Carawon QAGame: Moving Movie Rendering test content from Developer folder to Sequencer folder Also adjusted level visibility, lights and camera example. Change 3995993 by Christina.TempelaarL Sequencer: FCPXML Export updates - only export sections if in playback range and media exists, warn if media does not exist. Other updates - removed unused methods and variables, fixed message context naming to be more accurate #jira UESEQ-358 Change 3996595 by andrew.porter QAGame: Updating Marcie content in TrackEvaluation level to use Image Plate Change 3996614 by andrew.porter QAGame: Adding color test sequence to the sublevel Change 3996643 by Max.Chen Sequencer: Fix fbx animation export - rotation and scale channels were flipped. #jira UE-57509 #jira UE-57512 #jira UE-57514 Change 3996652 by Max.Preussner Messaging: Fixed delayed messaging using incorrect current time after message router sleep Based on https://github.com/EpicGames/UnrealEngine/pull/4601 Change 3996801 by Max.Chen Sequencer: Fix folder active state for non key area sections. Look at track node sections as well as key areas. #jira UE-57550 Change 3997098 by Matt.Hoffman Cleaned up some remaining ToDo's in STimeRange. Change 3998339 by Max.Preussner Sockets: Added documentation for socket receive functions Change 3998359 by Max.Preussner MediaUtils: Started to implement media recorder helper class Currently only supports BGRA frames in CPU memory. Supporting other formats and buffer types will require conversions on render-thread. I recommend refactoring out the existing conversion code in FMediaTextureResource into a reusable helper class in the MediaUtils module. This should be a good starting point though. Change 3998417 by Matt.Hoffman Keys and Sections can now be moved at the same time inside of Sequencer. Keys can now snap to Sections (and vice versa) instead of just to other Keys. Sections can now be duplicated like keys can. #jira UE-56995 Change 3998427 by JohnHenry.Carawon QAGame: Updating test content for the Movie Rendering feature. - Added an auto activate particle to the beginning of the sequence (it's not part of the sequence at all) - Added an event receiver blueprint to the Events example - Added a particle emitter to both sublevels - Added a camera cut to the end that switches to a separate camera - The camera zoom in, focus and Look At sections are all separate (not overlapping in the sequence) - Added a second actor for the camera Look At - Added a Visibility section for the Actor Hidden In Game track that has possessable and spawnable cube and light Change 3998537 by Max.Chen Sequence Recorder: Restore immersive mode when stopping the sequence even if not in PIE. #jira UE-56407 Change 3999809 by Matt.Hoffman Removed the "Go To" box from Sequencer and instead placed the current time as an always visible control. The previous shortcut (Ctrl + G) now focuses the new widget directly. #jira UESEQ-376 Change 4000543 by Christina.TempelaarL Sequencer: Moving editor-only code from runtime module MovieSceneCapture to editor module MovieSceneTools. Moved EDL and FCP XML exporters as well as Automated Level Scene Capture. #jira UESEQ-358 Change 4000706 by Matt.Hoffman Entering multiple time strings without a number no longer crashes Sequencer. #jira UE-57672 Change 4001051 by andrew.porter MediaFrameworkTest: Fixing up some image sources pointing to the wrong location Change 4001191 by andrew.porter QAGame: Adding some quick EDL/XML test content to dev folder Change 4001243 by Max.Chen Sequencer: Fix import EDL out of range. #jira UE-57665 Change 4001856 by Matt.Hoffman Selecting keys and sections at the same time now also works with animation and audio sections. #jira UE-57716 Change 4002021 by Max.Chen Sequence Recorder: Fix sequence name incrementing. If external recording sets the sequence name, use it. Otherwise, use the recording name from the recording group or the recording settings. #jira UE-57712 Change 4002618 by Max.Chen Viewport: Update the look at location when updating to a locked actor. This fixes an issue so that popping the view out of a locked actor and manipulating the view will not jump to the previous look at location. #jira UE-57725 Change 4002979 by Matt.Hoffman Fixes several edge cases with the end time range that was causing confusion about what the last frame of the sequence was. Dragging the End Frame slider will no longer be off by one tick and jumping to the end via the UI controls now properly respects snapping and stays inside the play range instead of falling outside of it. Overall behavior does not change though and End Frame should be considered an exclusive frame so that frames 0-150 results in a 150 frame long animation (which is frames 0-149). #jira UE-56367 Change 4003185 by Matt.Hoffman Fixed a regression that prevented a section from being dragged upwards past row 0 which normally resulted in all other rows moving down. #jira UE-57717 Change 4003193 by JohnHenry.Carawon QAGame: Updates to test content - Shortened frames between the examples from 95 to 30 - Separated camera setting tracks - Lighting example now switches directly from constant red - green - blue Change 4003369 by Max.Chen Sequence Recorder: Refresh next sequence regardless of internally stored sequence name. #jira UE-55757 Change 4003586 by JohnHenry.Carawon QAGame: Test Content Updates - Level Visibility track now ends to that the levels are not visible when we move to the next example - Shortened camera section, removed Z tranform so that we just move left to right and shortened the overall length Change 4004414 by Max.Chen Movie Scene Capture: Fix regression where rendering with shot handles would only render the first shot. 3972166 addressed an issue where an extra frame would be rendered by finalizing right when the end frame was reached. This was hit on the first shot end frame, so instead, do this only for when the last shot is being rendered. #jira UE-57314 Change 4004765 by Christina.TempelaarL Sequencer: Fixed bugs in FCP XML import/export. - Export: fixed sequence default resolution. - Export: fixed XML files with no shots. - Export: all sections clipped to playback range. - Export: fixed incorrect section start/end times due to precision issues. - Import: fixed incorrectly adding cinematic tracks. - Import: fixed bugs creating new sections. #jira UE-57660 #jira UE-57662 #jira UE-57655 #jira UE-57761 Change 4005119 by Max.Chen Sequencer: Export/import at play rate Change 4005195 by Max.Chen UMG: Finish UMG evaluation on stop. Added object version so that existing UMG assets do not change. #tests - Newly created UMG animation with sections set to restore state now return to their original state. Existing UMG animations with sections set to restore state do not return to their original state. #jira UE-52285 Change 4005377 by Michael.Karambelas QAGame: Moving TM-SequenceRecorder and related content out of my developer folder and into /Content/Sequencer/SequencerRecorder/* Change 4005417 by Michael.Karambelas QAGame: Fixed a BP compiler in the Level Blueprint of TM-SequencerRecorder. Change 4005634 by Michael.Karambelas QAGame: Fix up missing content and broken level sequence in TM-SequenceRecorder after move Change 4006324 by Max.Chen Sequencer: Reset if the focused movie scene is null. This fixes a crash if the user is focused in on a shot and undo takes the user past the point of where the shot was created. #jira UE-57752 #jira UE-47661 Change 4007006 by Max.Chen Sequencer: Fix FindAvailableRowIndex so that it returns the max row index (and not +1) since it doesn't find any conflicting rows. #jira UE-57717 Change 4007907 by Max.Chen Sequencer: Fix crash if there's no animation Change 4007948 by andrew.porter QAGame: added test content to dev folder for Record World Space Change 4008636 by Max.Chen Sequencer: Fix import fbx not setting values properly and creating additional cameras unncessarily. #jira UE-57864 Change 4008759 by Max.Chen Sequencer: Follow up fix for import cameras #jira UE-57864 Change 4009994 by Matt.Hoffman Dragging the left or right handles of the Time Range slider in Sequencer will now zoom your view in on the current center of the screen. This prevents the view from being translating as you tried to zoom in which caused issues at high zoom levels. #jira UESEQ-407 Change 4010169 by Christina.TempelaarL Sequencer: FCP XML fixes. - FCP XML export - no longer clips to playback range - FCP XML and EDL export - fixed missing last frame of some sections after exporting to Premiere. - Automated level capture, EDL export - use RoundToFrame instead of FloorToFrame for computing section start/end frames after frame rate conversion. #jira UE-57802 - partial fix, movie scene capture still needs to render full section rather than clip against playback. Change 4010287 by Mike.Zyracki Add quaternion interpolation option to UMovieScene3DTransformSection. This mimics how Matinee used to work by bascially finding the keys between a time and interpolating the angles as quat's between them. As noted in the code the algorithm needs to handle the case when the x,y,z Rotation keys all aren't at the same time which was not handled by Matinee. Also like Matinee, when in quaternion interoplation mode, we need to not display the function cuves since the interpolated and key values are now all different. (Would like to show them but that's a bigger refactor for perhaps just a one off needed by quaternions). I added a virtual function UMovieSceneSection::ShowCurveForChannel for this since it needs to be dynamic, not on construction of IKeyArea's, and could be useful for other sections. I could though move the method to just UMovieScene3DTransformSection and do a cast instead. Looked into doing a unit test for this but after talking with Andrew P we will work on doign an automated test in EngineQA since that will provide more coverage. Will also add a video the jira. #jira UESEQ-403 Change 4010713 by Mike.Zyracki Added option to key a group of transform channels instead of just the changed channel, or all of them. This is useful for quaternion interpolations where you want rotation keys to be aligned but also useful for other workflows like animating FK Pose to Pose. Change 4010715 by Andrew.Porter MediaFrameworkTest: Setting LogMediaUtils logging from VeryVerbose to Verbose to cut back on the spam Change 4013048 by Max.Chen Sequencer: Fix play/jump status. Update the player status for all position methods (Scrub, Jump, Play). Jump means Stopped. Correctly use PlayTo or JumpTo based on position method. In PlayInternal, JumpTo with the Stopped state (rather than playing state). #jira UE-57844 Change 4013479 by andrew.porter QAGame: Added content in TM-SequenceRecorder to test recording a property on a Cine Camera Component; Press 3 to trigger manual focus distance to increment on a timer Change 4014323 by Max.Chen Sequencer: Fix SetPlaybackPosition so that it jumps or plays based on playback status. #jira UE-57844 Change 4015888 by Max.Chen Sequencer: Fix crash on paste. UMovieSceneSections were gathered from the track node's track. For sub track mode, we want to gather only those sections on that track node row. #jira UE-57951 Change 4015943 by Max.Chen Sequencer: Fix moving shots up when the mouse pos goes outside of the virtual track area. #jira UE-57717 Change 4016293 by Max.Chen Sequencer: Fix relative frame playback end frame calculation so that custom start/end frames remain in the space of the sequence and are not relative. #jira UE-57308 Change 4017075 by Andrew.Rodham Sequencer: Corrected initial evaluation range used when calling UMovieSceneSequencPlayer::Play() Change 4017270 by Christina.TempelaarL Sequencer: FCPXML importer and movie scene capture - Use CeilToFrame when converting section start/end frame times to frame numbers in FCPXML and movie scene capture. - Added support for clip metadata in FCPXML. - Got rid of redundant TokenizedError message class, no longer needed now that FCPXML is in editor directory. - Added log messages currently commented out due to exception, still testing. #UESEQ-358 Change 4018370 by Christina.TempelaarL Sequencer: fixed FCPXML log messages regarding sections with start/end not divisible by display rate. #UESEQ-358 Change 4018378 by Christina.TempelaarL Sequencer: fixed error in previous changelist. #UESEQ-358 Change 4019457 by Max.Chen Sequencer: Show event names only when the event track is selected #jira UE-57897 Change 4022806 by Max.Chen Sequencer: Fix crash on movie scene capture dialog shutdown if movie capture wasn't even started. #jira UE-58106 Change 4022894 by Max.Chen Sequence Recorder: Wrap OpenEditorForAssets after sequence recording within GIsEditor #jira UE-58084 Change 4024487 by Max.Chen Sequencer: Add tooltip for quat interpolation #jira UE-58113 Change 4024562 by Max.Chen Sequencer: Change path/attach track sequence binding id to currently focused sequence id so that bindings can be created in subsequences Change 4027414 by JohnHenry.Carawon QAGame: Checking in content that shows a bug with using particles systems and Delay Before Shot Warm Up. Change 4028990 by Max.Chen Sequencer: Fix evaluate sub sequences in isolation. This check was added with the compile on the fly logic. Not sure why it was necessary but it seems like the sub sequence data needs to be updated in order to evaluate sub sequences in isolation. #jira UE-58184 Change 4029004 by Max.Chen Sequencer: Ensure that old binding references are removed when re-assigning actors in sequencer #jira UE-57898 Change 4030997 by JohnHenry.Carawon QAGame: Fixing name of the master sequence Change 4031785 by Michael.Karambelas QAGame: Added an instance of ThirdPerson Run to TM-SequenceRecorder for Record to Possessable test. Change 4035548 by Andrew.Rodham Sequencer: Changed FMovieSceneEvaluationTemplate::TemplateSignature to be a serial number to address non-deterministic cooking issues - This commit is related to the repro steps found in 3914599 and 3934307, both of which have been verified with this new change. - Copy of 4031684 from //Fortnite/Main/... #jira FORT-84852 Change 4036312 by Max.Chen Sequencer: Fix zoom view range so that it uses the passed in InZoomDelta Change 4036318 by Max.Chen Sequencer: Auto size now returns a range and defaults to the channel proxy range so that keyed regions can also be autosized. Change 4036322 by Max.Chen Forgot missing change Change 4036360 by Max.Chen Sequencer: Fix play rate calculation when skeletal animation section play rate changes. Change 4037163 by Mike.Zyracki Weighted Tangent Implementation Tricky thing is that you need to solve a cubic in order to get the bezier weights for the time part of the curve. See https://www.gamedev.net/forums/topic/474094-help-function-curves-for-animation-interpolation/ Maya provides an implementation in it's dev kit but I didn't use it since it was horribly slow and uses an iterative solution to solve the cubic needed. Instead I use an old algorithm (Cardano's method), to solve the cubic which should be much faster. Though relative simple to code from principles I just went ahead and used a version from Graphics Gems 1. I put this cubic solver directly in MovieSceneFloatChannel.cpp, but will need to move it when we support Rich Curve, maybe to FMath:: (which would probalby require some other functions for solving quartics, etc.. for completeness.). Also note we resolve this on every evaluation but dont' need to if the interval the time is evaluating hasn't had any change in values or tangents. So again when we support FRichCurve we can create a Weighted Evaluating class that can hold the cache. Also with the tangent drags I got rid of the Cardinal position that was used to calculate non-weight tangents from the key point and just quickly getting a direction. With weighted tangents we need to use the delta instead (otherwise when moving multiple they would all get the same weight based upon distance to the cardinal point. ) For mixed tangents types what I'm defaulting to non weighted if the interval doesn't match. May need to do weighted instead, not sure. What's left is just FBX import, for tomorrow. #jira UESEQ-76 Change 4037435 by Mike.Zyracki Fix fo build warnings from weighted tangent submission. #trivial Change 4038091 by Michael.Karambelas QAGame: Updated a Sequence Recorder group in TM-SequenceRecorder that had an actor missing the animation. Change 4038374 by Andrew.Rodham Sequencer: Refined scrubber styling for level sequences and actor sequences - Scrubber now shows a block the width of a dsplay rate frame, plus a line for the actual evaluated time. UMG reverts back to the previous styling (no block) - Keys that are outside of the playback range are now drawn with a subdued effect - Tick labels are no longer drawn when directly underneath the scrubber Change 4038490 by Max.Chen Sequencer: Expose tangent weight values in details panel. Change 4038620 by Andrew.Rodham Sequencer: Advanced time panel polish #jira UESEQ-426 Change 4038677 by Max.Chen Movie Scene Capture: Redirector for MovieSceneTools.AutomatedLevelSequenceCapture #jira UE-58248 Change 4039739 by Max.Chen Sequencer: Media track should only be supported by Level Sequence Change 4040024 by JohnHenry.Carawon QAGame: Fix EventReciever and OverrideBinding example The level sequence was set to none so the fix was to set it back to TrackEvaluation_Master. Change 4040610 by Andrew.Rodham Curve Editor: Moved weighted tangent switchers to a single toggle command (CTRL+W) and added an icon #jira 58383 Change 4040882 by Mike.Zyracki Keep broken when turning on weighted #jira UE-58435 Change 4041089 by andrew.porter QAGame: Sequence for Long Tangents bug Change 4041498 by Mike.Zyracki Turn off weighted when going auto to prevent large tangents. Do it both in UI and when doing AutoSetTangents() to really make sure it doesn't happen. #jira UE-58452 Change 4041752 by andrew.porter MediaFrameworkTest: Adding some better logging for setting rates when not supported. Also ignoring commiting URL when there is no text Change 4041896 by Matt.Hoffman The transform dialog box now transforms selected keys and sections, instead of just keys. #jira UE-58265 [CL 4044405 by Max Chen in Main branch]
2018-05-02 10:10:00 -04:00
CurrentTime = FDateTime::UtcNow();
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3946692) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3801826 by Max.Chen PR #4304: Level Sequence crash fix - Guarded against dereferencing null componen. (Contributed by DSDambuster) Change 3801828 by Max.Chen PR #4302: Movie Scene Visibility Template unitialised variable, causing random . (Contributed by DSDambuster) Change 3801837 by Max.Chen Sequencer: Delay spawning/construction for convert to possessable. This fixes a bug where property values would be lost when converting back and forth from possessable to spawnable. #jira UE-52400 Change 3801841 by Max.Chen Sequencer: Make spacer nodes not selectable. PR #4194: Improvements to Sequencer (Contributed by projectgheist) #jira UE-53117 #jira UE-52139 Change 3804183 by Max.Preussner MediaAssets: Added missing lock in media sound component Change 3805414 by Max.Preussner MediaAssets: Setting valid GUID when initializing media texture resource Change 3819578 by Max.Chen PR #4370: When enabling the "MovieCapture", do not turn off the Stereo-3D display. (Contributed by yehaike) #jira UE-53647 Change 3823414 by Max.Chen Curve Editor: Lock down the first and last keys in the redundant keys removal range so that they're unaffected. #jira UE-53591 Change 3826406 by Max.Chen Sequencer: Move OnStartedPlaying() to within first update in UpdateTimeCursorPosition(). This fixes an issue where setting the hud/player visibility was getting stomped on later. #jira UE-52772 Change 3827044 by Max.Preussner MediaAssets: Added sprite visualization to media sound component #jira UE-53594 Change 3827988 by Max.Preussner MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together #jira UE-53532 Change 3828506 by Max.Preussner MediaPlayerEditor: Added attenuation visualizer for media sound components #jira UE-53594 Change 3832590 by andrew.porter EngineTest: Added a keep state check in Property Animation sequencer test Change 3833053 by andrew.porter EngineTest: Adding Hierarchical Bias test Change 3835683 by andrew.porter EngineTest: Adding UMG Animation screenshot test Change 3836076 by Max.Chen Sequencer: Fix audio volume and pitch multiplier deprecation. Change 3836230 by andrew.porter EngineTest: Adding Sequence Bone Position automation test Change 3836347 by Max.Chen Sequencer: Fixes to shot name parsing. When a shot doesn't contain a shot number, assume, [ShotName]_[TakeNumber]. When duplicating a shot, put the new shot in the same path of the original shot, so that the take numbers will increment properly. #jira UE-51868 Change 3836552 by Max.Chen Sequencer: Sub section now has a takes menu Change 3838094 by Max.Chen UMG: Fix template finish not getting called on stop. This fixes a bug where sections aren't restored when finished. #jira UE-52285 Change 3838708 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3840295 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840957 by Mike.Zyracki Added Show Only Keyable and Show Only Animated to the filter list in the property editor. Added IsPropertyAnimated to IDetailKeyframe Interface which already had support for showing properties which are keyable (which is used for the key icon next to the properties.). Could have created another interface but then would have had to mimic the sequencer binding, releasing also, so this seemed best way. One issue still left is that custom built detail items currently don't store associated properties(usually) and so certain properties, in particulalry transforms, won't show up as keyable or animated. Note this also shows up with the keyable icon not showing up next to transform tracks, and other filters like Show Only Modified not working with transforms/customs. Not sure best way to tackle this. #jira UESEQ-328 Change 3841756 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3843950 by andrew.porter EngineTest: Renaming LevelStreaming tests/content to LevelVisibility Change 3844082 by Mike.Zyracki Missing file for animated filter in property editor. When finding if a track is animated we need to find it but we can't easily induce the MovieTrack class for any particular property. So we don't set a class for it and just search by it's ID and name. #jira UESEQ-328 Change 3846902 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed #jira UE-54247 Change 3849820 by Mike.Zyracki Reassigning deleted widgets didn't work since the menu extender mechanism needs a valid UObject in order to perform an operation on it. So to fix we replaced GetObjectBindingContextMenuExtender in WidgetBlueprint with new delegate mechanism (OnBuildCustomContextMenuForGuid) that supports FGuid in addition to UObjects which is needed to handle re-binding deleted widgets. Note that the default sequencer hacks this for replacing deleted actors in SequencerObjectBindingNode to check to see if a LevelSequence is active. We could move to this mechanism there also. #jira UE-53163 Change 3852211 by Max.Chen UMG: Indicate name of the property that is not bound. #jira UE-54350 Change 3854120 by Max.Chen Sequencer: Fix sibling folders being allowed to have the same folder name. #jira UE-54363 Change 3854627 by Max.Chen Sequencer: Step to next/previous key should work for all tracks if there aren't any selected. #jira UESEQ-391 Change 3855825 by andrew.porter EngineTest: Adding animation blending automation test Change 3855950 by andrew.porter EngineTest: Adding correct expected valuues to animation blending test Change 3856237 by Matt.Hoffman UESEQ-336 - Sequencer Track Reordering Adds the ability to re-order Master Tracks, Folders and Object Bindings within sequencer hierarchies (including UMG). Adds the ability to do a one-off sorting of the content under the old sorting behavior if the user wants to reset their layout to how it was under legacy behavior. Modifies SequencerTrackNodes, SequencerFolderNodes and SequencerObjectBindingNodes to handle CanDrop/OnDrop for above, below and ontop of. Fixes a Slate Issue that forcibly expanded a TreeviewRow if an item handled OnDrop. Slate will now only forcibly expand the row if the item says the drop happened ontop of the item, and not above or below it like it previously did. Change 3856503 by andrew.porter EngineTest: Adding automation test for using animation blueprint with blend multi node in sequencer Change 3857875 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. #jira UE-54462 Change 3858344 by Max.Chen Sequencer: Prevent Goto and Transform boxes from overlapping by allowing them to be visible at the same time in an autosized horizontal box. Also, added close button to the goto box. PR #4425: Prevent Goto and Transform boxes from overlapping in Sequencer ... (Contributed by projectgheist) #jira UE-54210 Change 3860566 by andrew.porter MediaFrameworkTest: Set the option to index 0 for the audio and video track list by default Change 3860654 by andrew.porter EngineTest: Enabling Camera Cut + FOV test Change 3860981 by andrew.porter EngineTest: Updating skeletal mesh tests with a delay after set playback position Change 3861256 by Max.Chen Sequencer: Add all bindings if none selected. #jira-54440 Change 3862154 by Andrew.Rodham Added TimeManagement module Change 3862424 by andrew.porter EngineTest: Turned on the test Bone Positions with Blend Multi Node Change 3862573 by andrew.porter EngineTest: Adding test to compare bone positions in a sequence that is blending an animation that is using an AnimBP Change 3865117 by Max.Chen Sequencer: Stop auto scroll on mouse release of movement. #jira UE-31212 Change 3865303 by Max.Chen Sequencer: Add drag and drop transactions #jira UE-54662 Change 3865304 by Max.Chen Sequencer: Fix crash when an actor factory is not found. Change 3865361 by Max.Chen Sequencer: Don't change the camera/shot lock button when popping out of a sequence. #jira UE-54665 Change 3865412 by Max.Chen Sequencer: Determine whether a transform track is for a camera by using the spawned object or template #jira UE-54666 Change 3865685 by Max.Chen Sequencer: Clear autoscrub offset when stopping autoscroll #jira UE-31212 Change 3865886 by Max.Chen Sequence Recorder: Log an error if the number of frames changes while recording. This can happen if the skeleton changes while recording. #jira UE-48715 Change 3866925 by Andrew.Porter MediaFrameworkTest: Changing the current PNG test video image sequence to 1024 x 576 Change 3867705 by andrew.porter QAGame: Adding Audio Sort Sequence to dev folder Change 3867890 by andrew.porter QAGame: Adding a sequence for testing a sorting crash to my dev folder Change 3872628 by Max.Chen Movie Scene Capture: Split delay before warmup into split delay before shot warmup so that there's separate controls for when the movie scene capture warmups up vs. shot boundaries. Change 3873131 by Matt.Hoffman UE-54732 - Crash reordering a folder with a track. This was caused by folders being the only type of track to check if someone was putting a parent track into a child track. Object Binding tracks and Tracks now check as well so that you can't use the above/below drop targets to add parents as children. This also fixed a typo in the localization keys. #jira UE-54732 Change 3873301 by Mike.Zyracki Added ability to support continous euler angle changes when changing rotations, in particularly with the rotation gizmo's. To do this we effectively added a form an of 'euler filter'(https://en.wikipedia.org/wiki/Euler_filter) to find the closest euler angle to the current euler angle. Three functions were added to FRotator to make this possible, one to get the euler angle that's has the same rotation as it, one to get the difference between two euler angles via Manhattan distance and a third using the previous two to choose a Rotator value that's closest to it. We then use these functions before calling UComponent::SetRelativeRotation to make sure we use the correct Euler after the Quat conversion. We also no longer limit(bound) the euler angles to -180,180, which is obviously necessary to avoid flips. I also changed how we caluclate yaw and roll when pitch is -90 or 90 to make it the standard approach of zeroing out roll and just setting yaw. Main reasons are the previous implementation had precision issues so things like 180, 90, -180 would show up due to numbers being nearly zero but negative,(this would break any smooth interpolations), and this facilitates having a 'gimbal' rotation mode (like Maya, Blender etc..) if we ever want that also. If needed we could keep the previous implementation but would need to add some FMath::IsNearlyZero checks, with less performance. Note we only do this special filtering when applying delta's to actors or components in the editors, which then call UComponent::SetRelativeRotationExact, which is a new function to foces the RelativeRotation to be equal to the new rotation. This allows us to store un-nomalized Rotators at the cost that the RotationCache may be broken. We didn't change any of the other UComponent functions that set rotations (via Quats or Transforms) so they will still be bounded and unwound. In SetInternalWorldLocationAndRotation we only set the rotation if the rotation has changed, which fixes the rotation getting changed and re-normalized if just translate happens. In TransformTrackEditor, we correclty use the bUndwing flag and in MovieScene3DTransformSection there was an un-needed winding check there, it will be unwound earlier if needed, which happens if Sequence Recording is happening. Max we should talk about what to do about this . Note the euler angle drag via the widget is still bound to 0-360. I think we should just unbound that now since the rotations value are now unbound. This review now includes fixes suggested by Zak. #jira UE-UE-22228 Change 3873483 by Matt.Hoffman Sequencer Tracks can now be inserted above the spacer at the bottom of the tree. #jira UE-54706 Change 3873899 by Max.Chen Sequencer: Add section selection throbbing Change 3873908 by Max.Chen Movie Scene Capture: Added logging per frame Change 3873924 by Matt.Hoffman Adds the ability to store Sequence Recorder setups into profiles that stay with the map and can be re-loaded later. Profiles store the Actor Recordings so the settings for each actor should carry with them. #jira UESEQ-339 Change 3874726 by Matt.Hoffman Disable drag-and-drop targets on spacers that come between rows in Sequencer. This prevents extra drag/drop targets showing up between each row. #jira UE-54706 Change 3874862 by Matt.Hoffman Audio Track no longer gets reordered when adding sub-audio tracks, as sub-tracks are no longer counted towards the sorting order index when normalizing indexes. #jira UE-54727 Change 3875905 by Matt.Hoffman Disable Fade Track UI if a fade track already exists in the sequence. #jira UESEQ-393 Change 3876163 by Max.Chen Sequencer: Swap the camera object to the camera component's owner if it's not the same. #jira UE-54874 Change 3876971 by Andrew.Porter EngineTest: Moved Media Player Seek test to new folder. Also enabled the test with new ground truth image. Change 3877040 by Max.Chen Cine Camera: Split camera properties to two groups, "Camera Options" and "Camera Settings". The cine camera now hides properties in the "Camera Settings" group so that properties like bConstrainAspectRatio (in the "Camera Options" group) can be visible. #jira UE-54192 Change 3877763 by Max.Chen Curve Editor: Fix curve changed on end drag so that only curves that had keys/tangents that were changed receive notification, otherwise all loaded curves were getting notified that they were changed. #jira UE-54951 Change 3878234 by Matt.Hoffman Disable "Drop Below" targets for Sequencer Tree nodes to prevent a confusing UX issue where dropping underneath a Object Binding Node puts it after the object binding node but the UI looks like it's inserting it inside the Object Binding node. #jira UE-54743 Change 3879359 by Mike.Zyracki If a track is inactive we dim it a bit which seems to be the UE4 way to show inactive or disabled state. We changed the active logic so that all subtracks need to be inactive for the track to also be inactive(instead of all active for active). This conforms to how the active state actually works, e.g if you have two sections and only one is active the track is still active above it. #jira UESEQ-388 Change 3879462 by Max.Chen Sequencer: Allow dragging onto a particular row which would move out any overlapping sections to make space for the newly created section. Newly created sections are now selected and throbbed to draw attention to themselves. #jira UE-54664 Change 3879464 by Max.Chen Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field. - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field. - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges. #jira UE-54922 Change 3879590 by Matt.Hoffman Items that are now added to the Sequencer via the "+Track" menu will be selected after being added. Items can now be added inside of folders instead of just to the root level. #jira UE-27397 Change 3879612 by Mike.Zyracki Display Nodes with no children are always active. #jira UESEQ-388 Change 3879730 by Matt.Hoffman Sequence Recorder's actor recording groups now remove items from the group when removed via the UI. #jira UESEQ-339 Change 3880256 by Mike.Zyracki Fix issue with inactive display with folders and other track nodes. #jira UESEQ-388 Change 3883491 by Max.Chen Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes. Copy from Release-4.19 #jira UE-51323 Change 3883603 by Max.Chen Movie Scene Capture: Add option toggle disable screen percentage. By default this is on (no change in current behavior). #jira UE-51898 Change 3885074 by Max.Preussner MediaCompositing: Resetting media texture & freeing resource on section end; removed dead code Change 3887220 by Max.Preussner MediaCompositing: Defaulted media section duration to 1 sec (since we do not know the actual duration in most cases) Change 3887478 by Matt.Hoffman Sequences now show [Inactive] in their title bars when they're disabled. This helps communicate why a sequence isn't being evaluated. #jira UE-51469 Change 3888985 by Max.Chen Movie Scene Capture: Clamp HDR Compression Quality between 0 and 1. #jira UE-55136 Change 3893519 by Max.Chen Sequence Recorder: Clarified tooltip for bRecordNearbySpawnedActors - spawned actors will still be recorded if they match the ActorFilter. #jira UE-55238 Change 3893546 by Max.Chen Sequence Recorder: If a selected actor already has a recording, add a blank recording. #jira UE-55239 Change 3894044 by Max.Preussner MediaCompositing: Added support for seeking into a media section Change 3894310 by andrew.porter MediaFrameworkTest: Adding Img media sources for 1080 and 2160 ravent test content Change 3894426 by Max.Preussner MediaAssets: Letting media textures with AutoClear retain their clear color when player is reset Change 3895717 by Max.Chen Sequencer: Null checks to prevent crash when saving the default state of a spawnable #jira UE-55304 Change 3897388 by Max.Chen Sequencer: Don't update current time to be within the view range when stepping into a sequence. #jira UE-55322 Change 3897452 by Max.Chen Audio: Fix crash when trying to record audio without any active capture devices. Log warning if the number of input channels is not 1 or 2. #jira UE-55223 Change 3897619 by Max.Preussner MediaCompositing: Removed commented out code Change 3898072 by Max.Chen Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated. #jira UE-55328 Change 3898272 by Max.Preussner MediaPlayerEditor: Made slate brush constants static Change 3898704 by Max.Chen Sequencer: Skip if the binding id's sequence can't be found. #jira UE-55337 Change 3899855 by Max.Preussner MediaCompositingEditor: Added cache state visualization to media track Change 3900300 by Max.Preussner MediaCompositingEditor: Added loop indicators to media sections Change 3900694 by Max.Preussner ImfMedia: Looping cache only when player is looping Change 3900892 by Max.Preussner Stats: Added stats category for media framework Change 3900954 by Max.Preussner MediaCompositing: Don't evaluate at the end of media section Change 3901348 by Max.Preussner Core: Replaced TLruCache autos for better readability Change 3901655 by Max.Preussner ImgMedia: Added more perf stats to EXR reader Change 3901972 by Max.Preussner MediaAssets: Added getter for media player in media sound components Change 3902233 by Max.Preussner MediaAssets: Enabling media textures to receive samples right after player is assigned Change 3902238 by Max.Preussner MediaCompositing: Working around init/shutdown idiosyncracies in sequencer Change 3904045 by Max.Chen Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register. #jira UE-55314 Change 3905605 by Max.Chen Sequencer: Restrict spawnables from being created if they have a ClassWithin that UMovieScene is not a child of. #jira UE-55429 Change 3906550 by Max.Chen Sequencer: Add media track icon #jira UE-55480 Change 3907101 by Max.Chen Sequence Recorder: Fix bugs related to not recording a level sequence. There were certain assumptions that creating a level sequence meant that sequence recording was in progress. This is not always the case - the recorders can record animation assets and not create a level sequence. Changed the notion of IsRecording() to having at least one actor recording that is recording. Countdown timer, recording displays, etc should function if IsRecording() and not based on whether a level sequence is created. #jira UE-55485 Change 3907247 by Max.Chen Sequence Recorder: Fix crash not removing PrepareToCleanseEditorObject delegate. Repros when opening sequence recorder, closing it, and then opening or creating a level. Change 3910343 by Max.Preussner Core: Added async helper for executing functions on a given thread pool Change 3910346 by Max.Preussner ImgMedia: Added separate thread pools for loading/decoding and deleting image frames Change 3910829 by Max.Preussner Profiler: Increased visible range of profiler graph Change 3910841 by Max.Preussner MediaCompositing: Displaying asset name instead of full media source path in media section Change 3910870 by Max.Preussner ImgMedia: Using deallocation thread pool only in debug builds Change 3919642 by Max.Chen Sequence Recorder: Clarify active tooltip #jira UE-55661 Change 3919660 by Max.Chen Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified - The following sequence of events exposes this issue: - Create a master sequence with a single shot that spawns a cube - Add this sequence to a level and set it to auto-play - Save everything and restart - Resave just the inner shot asset without opening it - PIE - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template. #jira UE-55626 #jira UE-55490 Change 3921825 by Max.Chen Sequencer: "Run Construction Script in Sequencer" is off by default for blueprints but on for Sequencer. This allows the content author to switch it on for specific blueprints and sequencer will be default, run those with construction scripts enabled. Change 3922232 by Max.Chen Sequence Recorder: Reset countdelay on stop. #jira UE-55755 Change 3922306 by Max.Chen Sequence Recorder: Don't automatically mark transforms to be recorded by sequence recorder. Instead, log a warning if the user toggled it off to warn that the resulting animation might not match gameplay. #jira UE-55758 Change 3922912 by Max.Chen Sequence Recorder: Fix refresh next sequence name #jira UE-55757 Change 3927654 by Max.Chen Movie Scene Capture: Added format mapping for the name of the current camera #jira UE-55769 PR #4537 Change 3927658 by Max.Chen Sequencer: Added fbx property mapping for "FocusDistance" to "FocusSettings.ManualFocusDistance" #jira UE-55782 Change 3932022 by Max.Chen Sequencer: Add import animation track section to next available row index. #jira UE-55892 Change 3933919 by Max.Chen Sequencer: Jump to playback start frame and not 0 to start playback for recording. #jira UE-55933 Change 3934307 by Andrew.Rodham Sequencer: Add template signature that is re-generated every time the base template is regenerated, which invalidates evaluation fields This fixes an issue where the same sequence is instantiated multiple times in a sequence. If the source sequence was saved, its template would be wiped, which would invalidate the template ID When an instance tries to evaluate the master template, it would only invalidate a range in the evaluation field that was the hull of any invalid sub sequences overlapping the current time, potentially leaving invalid data in the evaluation field at positions later (or earlier) on in the sequence When the sub template was re-generated, it receives the same SequenceSignature as it had before (because the sequence hasn't actually changed), which causes the stale evaluation field data to fail the IsDirty check (because the sequence is the same as it thought, but the *template* has changed) This has been addressed be adding a signature to templates themselves, and checking both the template signature and sequence signature as a part of the IsDirty check. This ensures that we regenerate if either the template, or the sequence have changed. #jira UE-55934 Change 3936327 by Andrew.Rodham Sequencer: Removed increment when trimming right UMovieSceneSection::TrimSection already explicity assigns an exclusive bound to the time passed in. The new behavior means we can trim a section to the right, and insert another section without changing the time to create adjacent sections. #jira UE-42652 Change 3936328 by Andrew.Rodham Fixed KeyFrameManipulator assignment operators and copy/move constructors - These types are potentially self-referential so cannot use default constructors/assignment Change 3936330 by Andrew.Rodham Converted UMGSequencePlayer to use frames internally #jira UE-54878 Change 3936726 by Max.Chen Sequencer: Set track node as the parent of the key area node. The key area switcher needs the object binding id from the parent object binding node. Without this, the binding to the external value fails. #jira UE-55931 Change 3936775 by Max.Chen Sequencer: Should stop or loop should compare DurationFrames with Current Time from StartTime. The bug is that if you set 30 warmup frames in movie rendering for a range of 0-100, the FrameRange will be starting at -30 and have a duration of 130. Without this fix, the playback will continue until frame 130, rather than 100. #jira UE-55933 Change 3936935 by Matt.Hoffman Easing Curves are now represented in Play Rate resolution instead of internal resolution. #jira UE-55937 Change 3937069 by Matt.Hoffman Users can toggle if the is infinite on each side, limited by which tracks support infinite ranges. #jira UE-55891 Change 3937516 by Max.Preussner ImgMedia: Added support for single-threaded platforms #jira UE-55986 Change 3937826 by Max.Preussner MediaAssets: Disabling media sound components on HTML5 if AudioMixer is not enabled Change 3937997 by Max.Chen Curve Editor: Add Zoom to Fit Curves so that selected curves from Sequencer can be focused on. Tested that undo doesn't re-zoom. #jira UE-55935 Change 3938000 by Max.Chen Sequencer: Stop all sounds before generating audio waveforms. #jira UE-55951 Change 3938376 by Max.Preussner XGEController: Disabled XGE Controller in single-threaded apps to prevent crash Change 3938444 by Max.Preussner Core: Added async support for single-threaded applications Change 3938445 by Max.Preussner Networking: Added support for single-threaded applications in UDP socket sender/receiver Change 3938447 by Max.Preussner Messaging: Added support for single-threaded applications Change 3939432 by Max.Chen Sequence Recorder: Append command list to global level editor actions so that shortcuts are accessible in level editor. #jira UE-55798 Change 3940229 by Andrew.Rodham Added prospective display rate upgrade to UMovieScene::PostLoad - There was previously some very odd behaviour that would assign the fixed frame interval only when a sub sequence was focused in SSequencer. This meant that many sequences could have a frame interval of 0 set in the data. - Under the old method of snap interval display this would have fallen back to getting the display interval from the sequencer settings, but we no longer look at these. - The USequencerSettings properties have been removed and in their place, a prospective data upgrade for sequences that have a fixed frame interval old 0fps that sets the play rate to the previous defaults based off the old USequencerSettings defaults. - This could end up 'changing' the display rate for sequences where the user has changed the snap interval in the settings for a particular sequence editor, but there's not much we can do about that given we don't have access to the USequencerSettings classes in UMovieScene #jira UE-55919 Change 3940277 by Andrew.Rodham Sequencer: Added ability to default frame resolutions and play rates for newly created actor sequences Change 3940378 by Andrew.Rodham Sequencer: Post move import dialog now defaults to the playback framerate of the sequence, and floors to frame numbers Change 3940559 by Andrew.Rodham Reinstated primed or recording sequence color Change 3940642 by Max.Preussner ImagePlate: Removed image plate media playback functionality Change 3940843 by Max.Preussner Core: Made TCircularQueue actually thread-safe; improved code comments Change 3940860 by Max.Chen Sequencer: Changed StructNameToKey to StructPathToKey Previously, keying a PropertyPath of [RenderTransform][Shear][X] would get trimmed to X, which doesn't map to a channel name as considered by Sequencer2dTransformTrackEditor. Instead, trim the resulting property path to [Shear][X] so that track editors can determine the desired struct path and channels to key. #jira UE-52966 Change 3941292 by Mike.Zyracki Fix for trajectories out of range not showing up. 1) If we had no key data we would pop the time, so wouldn't get the section ranges. 2) Calculating of upper bound was wrong, checking against -1 and not key == num of keys when doing algo::lower_bound. 3) No need to do the Bck-- for the bakward iterators since we fixed #2. We start now from the upper bound correctly. 4) If we had no keys (at section start,end) we would incorrectly say we were any key type, so since we draw constant keys as dashed we would do so incorrectly around section end points. #jira UE-55929 Change 3941424 by Max.Chen Curve Editor: Change Zoom to Fit to use TArrayView Change 3941498 by Max.Preussner Core: Added FMath::DivideAndRoundNearest function Change 3942097 by Matt.Hoffman Drop Frame Timecode Support for NTSC rates. Change 3942104 by Matt.Hoffman Sequence Recorder Group is no longer visible inside the World Outliner after using one. #jira 55266 Change 3942107 by Max.Chen Sequencer: Resurrect logic to find or extend an existing section when adding keys. Change 3942330 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942339 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942507 by Andrew.Rodham Sequencer: We no longer pad the time overlap threshold with a small number that is not scaled by the current zoom level - The presence of this pad was causing keys that were far apart to be grouped when zoomed in a long way Change 3942509 by Andrew.Rodham Sequencer: Only pad total view range, rather than section range as well when retrieving keys to render - This stops us from rendering keys that are within the view range, but outside the section range Change 3942512 by Andrew.Rodham Added transactions to some sequencer details customizations Change 3942513 by Andrew.Rodham Sequencer: Reinstated validation checks to UMovieSceneSection::SetStartFrame and SetEndFrame, changed erroneous uses to use SetRange Change 3942560 by Andrew.Rodham Pass by rvalue reference to appease error C2719 on Win32 ('InChannels': formal parameter with requested alignment of 8 won't be aligned) Change 3942697 by Andrew.Rodham Newly Created Level Sequences and Actor Sequences now default to 24000 fps frame resolution (+/- ~24hrs range, supporting all integer rates + 23.976) Change 3942700 by Andrew.Rodham Sequencer: Added legacy out-of-bounds errors for times that are not supported by the current legacy upgrade frame resolution Change 3942989 by Max.Preussner Core: Fixed circular queue count calculation Change 3943538 by Max.Preussner MediaAssets: Reverted workaround for procedural audio log spam in HTML5 (Actor component initialization cannot be skipped if the component is used in a level) Change 3944071 by Max.Preussner QAGame: Fixed Media Texture keeps last frame of Media when PIE ends #jira UE-53360 Change 3944292 by Max.Chen Sequencer: Added extra flags to ensure that asset initialization does not occur on template actor sequences #jira UE-56113 Change 3944364 by Max.Chen Sequencer: Prevent circular shot/master tracks. Tested adding master -> child -> master as drag and drop cinematic shot tracks and sub tracks as well as through the + button. #jira UE-56091 Change 3944422 by Max.Chen Sequence Recorder: Disable transform recording if off. #jira UE-56061 Change 3944745 by Andrew.Rodham Sequencer: Key rendering fixes - Fixed assert that occured when keys happened to reside on some times due to KeyTime + TimeOverlapThreshold - KeyTime being slightly larger TimeOverlapThreshold - Fixed keys sometimes being clipped when zoomed right in due to lack of half-frame offset - Added missing documentation to MovieSceneTimeHelpers.h #jira UE-56107 Change 3945231 by Andrew.Rodham Sequencer: Reconstruct channel proxy on Serialize to catch all cases of undo/redo, PostLoad and duplication #jira UE-56089 Change 3945301 by Andrew.Rodham Sequencer: Added safety checks during initial sequence recording to guard against applying negative or 0-sized sequence ranges #jira UE-56125 Change 3946627 by Max.Preussner Fortnite: Fixed game crashes closing editor while in PIE - Pure virtual function being called #jira UE-56144 [CL 3946896 by Max Chen in Main branch]
2018-03-14 22:09:33 -04:00
ProcessDelayedMessages();
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 4044339) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3947021 by Max.Chen Sequencer: Don't preserve root component when copying object properties. A spawnable empty actor, has a root component that is generated by the empty actor factory. If the object template's root component is preserved when copying from the spawnable empty actor, the root component will not be copied over. Therefore, we need to NOT preserve the root component when copying object properties. #jira UE-55825 Change 3947366 by Max.Preussner WmfMedia: Better log output Change 3947367 by Max.Preussner MfMedia: Better detection of compressed format properties on Windows Change 3949102 by Max.Chen Sequencer: Remove SequenceActorTag when converting to possessable. #jira UE-56206 Change 3949207 by andrew.porter EngineTest: Set the screenshot nodes resolution to 1280x720 Change 3949404 by Max.Chen Sequencer: More informative tooltip for "Rerun Construction Scripts" option. It now says "Rerun construction scripts every frame on actors that have 'Rerun Construction Script in Sequencer' enabled in their class settings". Change 3950067 by Matt.Hoffman Renamed UAutomatedLevelSequenceCapture's StartFrame and EndFrame to CustomStartFrame/CustomEndFrame to reflect that it is user-overriden. This will also resolve upgrade issues due to the variable datatype changing. #jira UE-56189 Change 3950193 by JohnHenry.Carawon Updating my latest MovieRendering test content. Change 3950757 by JohnHenry.Carawon More updates to MovieRendering test content Change 3952059 by Max.Chen Resave LevelVisibility_SubLevels to fix data loss conversion warning of OpacityMaskConstant #jira UE-56086 Change 3952283 by Max.Chen Sequencer: Disable dropping level sequence assets as spawnables. #jira UE-56120 Change 3952422 by Max.Chen Sequence Recorder: Add button to record from the current player. #jira UE-55942 Change 3952987 by JohnHenry.Carawon MovieRendering Test Content - Fixing camera bindings and changing the override binding actor Change 3953823 by Mike.Zyracki Fix for Bad FBX Import Tangents not scaled by frame rate. After looking at this again it seems that a set of MovieScene:: overiddes for the channel traits wasn't set correctly, so use the ADL idiom to use MovieScene, which can then call Optimize in the correct namespace. With this we can now correctly use the passed in tolerance. There was also a redundant set of Optimize calls so that it could happen twice so removed them, and needed an extra check in the float channel Optimize. Also since we need to set auto tangents no matter if we optimize we don't set that parameter(though leave it since it's used by context menu key reduction). Finally fixed speed issue with trajectories caused by calculating way too many substeps. Reverted back to a time based step size for consistency. #jira UE-56193 Change 3954317 by Matt.Hoffman Adding a key to the last frame of a section no longer causes a crash. Keys can already be moved to be on the last frame of a section so now you can just add a key there directly. #jira UE-56255 Change 3954326 by Matt.Hoffman Dilating a section that is only infinite on one side no longer causes a crash. #jira UE-56260 Change 3954486 by Max.Chen PR #4580: Exposes IsReversed() from UMovieSceneSequencePlayer (Contributed by alanedwardes) Change 3955238 by Max.Preussner Messaging: Enabled delayed message routing https://github.com/EpicGames/UnrealEngine/pull/4574 #jira UE-56247 Change 3955901 by Max.Preussner MediaFrameworkTest: Added developer test for overriding desired media player plug-in at runtime. Change 3955922 by Andrew.Porter QAGame: Updating movie rendering content in dev folder Change 3956004 by andrew.porter QAGame: Adding MPC track to movie rendering test content Change 3956510 by Max.Chen Sequencer: Fix fbx camera import of static properties so that they are imported before default tracks are created. Otherwise, the default tracks inherit the default properties of the camera, rather than the values from the fbx. #jira UE-56311 Change 3957613 by Max.Preussner MediaUtils: Added code documentation to media player facade Change 3958005 by Max.Preussner MediaUtils: Added method to get number of sinks Change 3958934 by Max.Chen Sequencer: Fix keys getting added and sequence getting erroneously re-evaluated when auto key is off. Only apply defaults if there are no keys. Only modify the movie scene section before creating keys or setting defaults. #jira UE-55903 Change 3959687 by Andrew.Rodham Sequencer: Fixed visibility track external values being inverted #jira UE-56324 Change 3960507 by Max.Preussner Core: Fixed incorrect rounding in FMath::DivideAndRoundNearest Change 3962047 by JohnHenry.Carawon MovieRendering Test Content Changes: - Add Lightmass Importance Volumes to sublevel to fix warnings - Rebuilt Lighting - Add a third sequence for Gamut testing - Resaved the sound master.uasset to fix warning Change 3962211 by Mike.Zyracki Add Frame Numbers to selected animation sections. Added MapTimeToAnimation to MovieSceneSkeletalAnimation so that we could get it from the Skeleton Animation track Editor. Since the thickness of the frame line can change based upon frame rate and zoom we need to calculate it similarly to how the time slider controller does it. Those calculations were private so we had to expose FScrubRangeToScreen and GetScubberPixelRange from the TimeSliderController. Also needed to know if the section itself was selected so added a bIsSelected flag to the section Painter. Also fixed a bug where you couldn't add a section if other sections existed at different times in MovieScenePropertyTrack and could crash due to the check(). #jira UESEQ-395 Change 3962497 by Max.Preussner Core: Added new string formatting argument to FTimespan Change 3963662 by Max.Chen CineCamera: Flip VistaVision width and height. Change 3963731 by Max.Preussner MediaCompositing: Implemented sequence recording support for media track Change 3964195 by Andrew.Rodham Sequencer: Set inverted property correctly for newly created visibility track sections - Also clamp evaluation for key editors to the bounds of the section so we're not displaying values outside of the section bounds when the cursor is not on the bounds #jira UE-56324 #coderevew Max.Chen Change 3964196 by Andrew.Rodham Sequencer: Fixed crash when attempting to render sections that resulted in a negative intersection with the view range Change 3964275 by Andrew.Rodham Sequencer: Fixed MovieScene::ClampToDiscreteRange for infinite range bounds Change 3964364 by Andrew.Rodham Curve Editor: Reduce minimum vertical view range when zooming to fit Change 3965091 by Max.Chen Sequencer Recorder: Refresh next sequence if empty when starting a recording, otherwise, use existing name. #jira UE-56469 Change 3965148 by Max.Chen Sequence Recorder: Move Record to Possessable to "Actor Recording" group Change 3965162 by Max.Chen Sequence Recorder: Always break out of immersive mode when done recording, even when stopping recording during countdown. #jira UE-56407 Change 3965214 by Max.Preussner QAGame: Enabled ImagePlate plug-in Change 3965574 by Max.Preussner SimpleComposure: Reorganized & upgraded content to work with new Media Track #jira UE-56488 Change 3965651 by Max.Preussner MediaCompositing: Ignoring seek-on-open if media not seekable Change 3966075 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Export functionality #jira UESEQ-358 Change 3966087 by Matt.Hoffman Adding a single key to the Particle Toggle track now makes an infinite range section that is displayed in the UI. #jira UE-56295 Change 3966547 by Andrew.Rodham Sequencer: Fixed rounding errors when drawing the section background on boolean sections - Logic was using time in sectonds which caused rounding errors on evaluation and flickering red/green stripes when dragging keys around #jira UE-56324 Change 3966563 by Andrew.Rodham Curve Editor: Key editor interface improvements - SKeyEditInterface has a few problems - it does not update in real time when editing properties, and does not support multi-edit which makes it unsuitable for use with the curve editor - We now take a different approach for editing keys by gathering a set of proxy UObjects for each key that is currently selected. These objects are added as top level objects to the details panel which means they support multi edit as you'd expect from any other details panel in the editor. - Proxy objects are updated every tick for the curve editor if they implement the ICurveEditorKeyProxy interface, which allows them to refresh their current value. - Ideally, the same mechanisms would be used in the main sequence interface, and we would be generating the proxy classes at runtime based on the key value type, but that work remains a separate task from this initial offering. #jira UE-56165 Change 3966564 by Andrew.Rodham Curve Editor: Expand to frame when adding or moving keys in the curve editor Change 3967051 by andrew.porter MediaFrameworkTest: Set the CameraPlayer_Video texture to auto clear Change 3967141 by Andrew.Rodham Sequencer: Keep track of spawned objects that have been modified and only re-save such object's default spawnable state on destruction - Now that we're taking this approach, I've remove serveral redundant bits of functionality in the spawn register such as making some spawnables read-only, and the PreSave binding for Sequencer. - We now hook into all object pre-saves to make sure we handle the case where the sequences are saved through the content browser or elsewhere. #jira UE-47686 Change 3967170 by Andrew.Rodham Sequencer: Added the ability to possess anim instances as object bindings - This allows full and direct animation of properties on UAnimInstance, and animation blueprints - Object Bindings are made by first possessing a skeletal mesh component, then choosing the + Add button where its anim instance will be listed - Added a new function to UMovieSceneSequence to gather previously cached objects that should now be invalidated. Anim instances will be re-resolved if a new UAnimInstance is assigned to USkeletalMeshComponent::GetAnimInstance. - ObjectBindingIDs for anim instances are just represented by an entry in a set of GUIDs. We only ever resolve such bindings through USkeletalMeshComponent::GetAnimInstance. - Only currently supported on LevelSequences #jira UE-56132 Change 3967195 by Max.Preussner Core: Updated TRangeSet to use TCallTraits Change 3967345 by JohnHenry.Carawon Test Content Changes - first iteration of spacing out the examples in the shots. Change 3967572 by Max.Chen Sequencer: Fix setting PreviousPlayEvalPosition until after we've tested whether it's set. #jira UE-56518 Change 3967750 by Max.Chen Audio: Set duration based on number of input channels, rather than number of channels to serialize. This fixes an issue where audio split into 2 channels is set to a duration that's twice as long. #jira UE-56430 Change 3967836 by Max.Chen Sequencer: Allow for animating array elements within ustruct properties #jira UE-55887 Change 3968506 by Matt.Hoffman Fixed ambiguous conversions for seconds and frames being overriden by ambiguous conversion to Timecode (in frames). Change 3968748 by Max.Chen Sequencer: Make the event properties submenu widget larger. #jira UE-55557 Change 3968862 by Max.Chen Sequencer: Recursive expansion when shift is down #jira UE-52139 #pr 4194 Change 3968863 by Max.Chen Sequencer: Bind rename command to selected track so that F2 shortcut start renaming #jira UE-52139 #pr 4194 Change 3968872 by Max.Chen Sequencer: Rekey the selected key at the current time. #jira UESEQ-396 Change 3968938 by Max.Chen Cine Camera: Add option to toggle the behavior of locking the rail mount to the orientation of the spline. By default, the option is off, no change in behavior. #jira UE-55815 Change 3968958 by Andrew.Rodham Sequencer: Consider vertical position when hittesting keys #jira UE-56256 Change 3969643 by Max.Preussner Core: Rounding timespans created from double values towards nearest ticks Change 3969646 by Max.Preussner MediaUtils: Implemented timeout mechanism for block-on-fetch feature Change 3969776 by Mike.Zyracki Added Skip Anim Notifiers Toggle per what was in Matinee. Investigated the Enable Root Motion toggle as also discussed but it's implementation is directly contained by the animation asset and unlike animation notifies there seems to be no exposure to interactively disable it during a playback tick. Note if we are generating thumbnails we still automtically disable notifies in the editor to avoid annoying noise playback. Note that if Enable Root Motion/Root locked is specified in the animation asset it does correctly effect the Sequencer. #jira UESEQ-399 Change 3969835 by Matt.Hoffman Playback Range and Selection Range use unified logic for adding themselves as potential snap locations which properly handles inclusive/exclusive bounds. This resolves an issue where having an unset selection range caused a potential snap location to be added on frame 0 and 1 (internal resolution) which caused a misalignment when placing objects near frame 0. This also removes the one frame offset on setting Selection Range to bring behavior inline with other ranges. #jira UE-55420 Change 3969885 by Max.Preussner MediaAssets: Don't register media player CDO with media ticker Change 3971129 by Andrew.Rodham Sequencer: Fixed UMovieSceneSequencePlayer::GotToEndAndStop() not taking into account for start time This is a remnant from when the times were always specified in 0-duration space, rather than actual sequence times. Change 3972056 by JohnHenry.Carawon More updates to Test Content. I continued spacing out the examples in the sequence so that they have a consistent number of frames between each example and during the start/end of the example. Also removed the Marcie sublevel. Change 3972066 by Andrew.Porter MediaFrameworkTest: Setting Marcie folder to be never cooked in package settings Change 3972675 by Matt.Hoffman Splitting Subsequence Sections no longer sets an incorrect playback range on the subsequence when the subsequence has a different internal resolution than the owning sequence. #jira UE-55453 Change 3973376 by Max.Preussner ImgMedia: Zero is the only valid video track for image sequences Change 3973489 by Max.Preussner Launch: Build rules cleanup pass - don't use Media, MediaUtils on server apps - don't link against Media (include-only dependency) - don't include from MediaAssets (dynamic load only) Change 3973760 by Max.Preussner MediaUtils: Moved AppMediaTimeSource implementation into its own file; added logging Change 3973765 by Max.Preussner ImgMedia: Disallowing seek beyond media length Change 3973855 by Max.Preussner MediaFrameworkTest: Updated developer test content Change 3973858 by Max.Preussner MediaCompositing: Blocking on media player time instead of media sample time (the former may not be hit in the current frame) Change 3974988 by Max.Chen Sequencer: Fix trim left so that it also sets the start offset for audio and skeletal animation sections. #jira UE-57015 Change 3976101 by Matt.Hoffman Sequencer will now focus the scroll view on newly created items. #jira UE-56492 Change 3976203 by Max.Chen Property Editor: Add DetailsViewArgs for ColumnWidth. Defaults to 0.65f, no change in existing behavior. Change 3976205 by Max.Chen Sequencer: Set better column widths for sequencer. #jira UE-55557 Change 3976206 by Max.Chen Sequencer: Added menu category for import/export Change 3976265 by Matt.Hoffman Tracks within Object Binding Nodes will now sort using the old behavior so that components are added above other track types. #jira UE-56473 Change 3976901 by Max.Chen Sequencer: Add event names to event track section #jira UESEQ-353 Change 3977878 by Max.Preussner Media: Moved media framework ticking stats into Media module Change 3977982 by Max.Chen Sequencer: Add Edit->Reset section length to duration of source (ie. audio, skeletal animation, shot length) Added MovieSceneSection::GetDefaultDuration and MovieScene::HasDefaultDuration #jira UESEQ-392 Change 3977994 by Max.Preussner Media: Fetching and rendering media samples before viewports are rendered (to ensure frame sync for in-level media playback) #jira UE-53975 Change 3978188 by Matt.Hoffman Easing Curves are now clipped by the sequence's PlayRange when testing against an infinite section. This causes blended sequences to finish their blend when the section starts/ends instead of always using 25% of the total section length to determine default blend range. #jira UE-56362 Change 3978676 by Max.Preussner MediaCompositing: Fixed first frame of rendered out media track missing #jira UE-53975 Change 3978684 by Max.Preussner MediaCompositing: Enabled media track frame sync feature #jira UE-53975 Change 3980026 by Matt.Hoffman Keys can be selected on folded out sections (such as an audio track expanded to show volume and pitch) again. #jira UE-57169 Change 3981614 by Max.Preussner MediaUtils: Added missing subtitle sample queue flush Change 3982311 by Max.Preussner MediaCompositing: Added safeguard for zero length media sources Change 3982389 by andrew.porter QAGame: Adding media track test content into FrameAccuracySubscene Change 3983661 by Max.Chen Sequencer: Add level name to spawn a spawnable into. Add sublevel menu option to set the level #jira UESEQ-390 Change 3983712 by Andrew.Rodham Sequencer: Purge legacy blueprint spawnables from LevelSequence packages #tests Ran a preflight for cooking fortnite, ocean and Orion. Only orion shows up this edge case, and will require a re-save of the EndCines level #jira UE-39173 Change 3983787 by Max.Preussner MediaCompositing: Moved compile time switch for block-on-fetch into media player facade Change 3983812 by Andrew.Rodham Sequencer: Exposed default level sequence instance data to blueprints Change 3984373 by Max.Preussner Media: Added API for quering whether player plug-in supports block on fetch Block on fetch allows Sequencer and other systems to block the game thread until a desired video frame has been decoded. Change 3984670 by JohnHenry.Carawon Movie Rendering Test Content progress. Saving the state of the content. There is a bug where things got replaced with particle emitters and I think it was because I tried to copy paste an animation track into a separate skeletal mesh track. Change 3985097 by Max.Chen Sequencer: Rename Reset to AutoSize Change GetAutoSizeDuration to return TOptional<FFrameTime> #jira UESEQ-392 Change 3986043 by Max.Chen Sequencer: Fix crash when attach/path duration is less than 0. #jira UE-57310 Change 3986373 by Max.Chen Sequencer: Add support for deleting tracks and channels which equates to setting the channel mask. #jira UE-52951 Change 3986375 by Max.Chen Sequencer: Add Create Pose Asset to skeletal animation section. This allows animators to blend animations in sequencer and create new pose assets from them. #jira UESEQ-408 Change 3986796 by Andrew.Rodham Sequencer: Fixed stale object references remaining in ULevelSequence::BindingReferences when using convert to spawnable/possessable - We used to convert objects by creating a new binding, then re-assigning its GUID, which meant we didn't have to do any further object fixup, but the code to achieve this was confusing and led to a vulnerability where object references would not be cleaned up correctly due to the newly created possessable essentially being a temporary object that's immediately thrown away. - To address this, there is now a function for porting all the contents of one object binding to another, and handles the correct fixup required for parent/child object bindings for both spawnables and possessables. - Also added codepath to remove any stale object references from the level sequence reference map on PostLoad (this piggy-backs off the PurgeLegacyBlueprints object version which is close close enough to this change to be identical) #tests Verified that existing sequences with stale references get cleaned up on load. Verified that repreatedly converting from spawnable<->possessable cleans up references correctly. Change 3987807 by JohnHenry.Carawon Updates to the MovieRendering Test Content. - Fixed the spawnable actors that were overwritten - Shortend the Lighting example and combined the Intensity and Color tracks - Organized the Sequence and WorldOutliner to group the examples. Change 3988151 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. Change 3988880 by Max.Chen Sequencer: Support enter to add asset for all sequencer track editors that have asset pickers. #jira UE-57367 Change 3988953 by Max.Chen Sequencer: Make the track color picker focusable so that it will close when you click away or lose focus. #jira UE-57210 Change 3988962 by Max.Chen MovieSceneCapture: Fix EDL export so that it takes into account movie scene frame resolution and desired frame rate. #jira UE-57365 Change 3988964 by Max.Chen Movie Scene Capture: Clarified tooltip for bRelativeFrameNumbers. If you specify custom start/end frames for the recording, they will be relative to the playback range. #jira UE-57308 Change 3989442 by Max.Chen Fix CIS Change 3991548 by Matt.Hoffman Dragging the time slider no longer causes the time slider to ignore snap-to-interval with "Snap to Keys While Scrubbing" when no keys are in range. #jira UE-57417 Change 3991598 by Matt.Hoffman Snap to Key while scrubbing now mirrors the behavior of "jump to next key". When there are no tracks selected it snaps to all keys and when there are tracks selected it snaps to only keys from that track. This also resolves an issue where deleting an object did not remove it from the Sequencer's selection. Undoing a delete already doesn't seem to restore your selection, so removing it from your selection shouldn't change that behavior. #jira UE-57417 Change 3991603 by Max.Chen Sequencer: Disable EditAnywhere for some section properties #jira UE-53530 Change 3992240 by Max.Preussner MediaAssets: Implemented dynamic audio sample rate adjustment based on audio/media clock drift #jira FORT-70638 Change 3992911 by Andrew.Rodham Sequencer: Fixed saving spawnable state using the wrong spawned object - We now track the object binding ID so that we can apply the spawned object to the correct spawnable when the asset is saved #jira UE-57353 Change 3992914 by Max.Chen Movie Scene Capture: Fix compression quality not being set. The compression interface wasn't being found through query interface, so no compression was being set. Reworked finding it through the output pins. Tested running various compression values. #jira-UE-55488 Change 3992919 by Max.Chen Sequencer: Convert to possessable now uses object template instead of copying properties (ie. see LevelSequenceActorSpawner). This fixes MIDs getting lost when converting to spawnable and back to possessable. #jira UE-52400 Change 3993184 by Max.Chen Sequencer: Don't show +Transform/+Path/+Attach track if the actor has the "Mobility" property hidden. Set the Landscape, LandscapeProxy and InstancedFoliage "Mobility" property to be hidden since it is static is not supposed to be dynamically movable. #jira UE-56347 Change 3993238 by Max.Chen Sequencer: Test for hidden mobility in creating keys as well. Refactored to HasHiddenMobility() #jira UE-56347 Change 3993978 by Max.Chen Cine Camera: Enable keying the "Enable Look at Tracking" toggle. #jira UE-57489 Change 3994039 by Max.Chen Landscape: Add Mobility to hidecategories on landscape component #jira UE-56347 Change 3994626 by JohnHenry.Carawon Updated Movie Rendering Test Content. - Fixed the overridden spawnables to their proper object types. Change 3994653 by Christina.TempelaarL Sequencer: Added Final Cut Pro 7 XML Import functionality, improved Export functionality #jira UESEQ-358 Change 3995609 by Max.Chen UMG: Add support for 2d transform mask (translation, rotation, scale, shear) #jira UE-52951 Change 3995778 by JohnHenry.Carawon Movie Rendering Test Content Updates - Adjusted Lights example - Adjusted Camera example - Added Marcie sublevel back in Change 3995942 by JohnHenry.Carawon QAGame: Moving Movie Rendering test content from Developer folder to Sequencer folder Also adjusted level visibility, lights and camera example. Change 3995993 by Christina.TempelaarL Sequencer: FCPXML Export updates - only export sections if in playback range and media exists, warn if media does not exist. Other updates - removed unused methods and variables, fixed message context naming to be more accurate #jira UESEQ-358 Change 3996595 by andrew.porter QAGame: Updating Marcie content in TrackEvaluation level to use Image Plate Change 3996614 by andrew.porter QAGame: Adding color test sequence to the sublevel Change 3996643 by Max.Chen Sequencer: Fix fbx animation export - rotation and scale channels were flipped. #jira UE-57509 #jira UE-57512 #jira UE-57514 Change 3996652 by Max.Preussner Messaging: Fixed delayed messaging using incorrect current time after message router sleep Based on https://github.com/EpicGames/UnrealEngine/pull/4601 Change 3996801 by Max.Chen Sequencer: Fix folder active state for non key area sections. Look at track node sections as well as key areas. #jira UE-57550 Change 3997098 by Matt.Hoffman Cleaned up some remaining ToDo's in STimeRange. Change 3998339 by Max.Preussner Sockets: Added documentation for socket receive functions Change 3998359 by Max.Preussner MediaUtils: Started to implement media recorder helper class Currently only supports BGRA frames in CPU memory. Supporting other formats and buffer types will require conversions on render-thread. I recommend refactoring out the existing conversion code in FMediaTextureResource into a reusable helper class in the MediaUtils module. This should be a good starting point though. Change 3998417 by Matt.Hoffman Keys and Sections can now be moved at the same time inside of Sequencer. Keys can now snap to Sections (and vice versa) instead of just to other Keys. Sections can now be duplicated like keys can. #jira UE-56995 Change 3998427 by JohnHenry.Carawon QAGame: Updating test content for the Movie Rendering feature. - Added an auto activate particle to the beginning of the sequence (it's not part of the sequence at all) - Added an event receiver blueprint to the Events example - Added a particle emitter to both sublevels - Added a camera cut to the end that switches to a separate camera - The camera zoom in, focus and Look At sections are all separate (not overlapping in the sequence) - Added a second actor for the camera Look At - Added a Visibility section for the Actor Hidden In Game track that has possessable and spawnable cube and light Change 3998537 by Max.Chen Sequence Recorder: Restore immersive mode when stopping the sequence even if not in PIE. #jira UE-56407 Change 3999809 by Matt.Hoffman Removed the "Go To" box from Sequencer and instead placed the current time as an always visible control. The previous shortcut (Ctrl + G) now focuses the new widget directly. #jira UESEQ-376 Change 4000543 by Christina.TempelaarL Sequencer: Moving editor-only code from runtime module MovieSceneCapture to editor module MovieSceneTools. Moved EDL and FCP XML exporters as well as Automated Level Scene Capture. #jira UESEQ-358 Change 4000706 by Matt.Hoffman Entering multiple time strings without a number no longer crashes Sequencer. #jira UE-57672 Change 4001051 by andrew.porter MediaFrameworkTest: Fixing up some image sources pointing to the wrong location Change 4001191 by andrew.porter QAGame: Adding some quick EDL/XML test content to dev folder Change 4001243 by Max.Chen Sequencer: Fix import EDL out of range. #jira UE-57665 Change 4001856 by Matt.Hoffman Selecting keys and sections at the same time now also works with animation and audio sections. #jira UE-57716 Change 4002021 by Max.Chen Sequence Recorder: Fix sequence name incrementing. If external recording sets the sequence name, use it. Otherwise, use the recording name from the recording group or the recording settings. #jira UE-57712 Change 4002618 by Max.Chen Viewport: Update the look at location when updating to a locked actor. This fixes an issue so that popping the view out of a locked actor and manipulating the view will not jump to the previous look at location. #jira UE-57725 Change 4002979 by Matt.Hoffman Fixes several edge cases with the end time range that was causing confusion about what the last frame of the sequence was. Dragging the End Frame slider will no longer be off by one tick and jumping to the end via the UI controls now properly respects snapping and stays inside the play range instead of falling outside of it. Overall behavior does not change though and End Frame should be considered an exclusive frame so that frames 0-150 results in a 150 frame long animation (which is frames 0-149). #jira UE-56367 Change 4003185 by Matt.Hoffman Fixed a regression that prevented a section from being dragged upwards past row 0 which normally resulted in all other rows moving down. #jira UE-57717 Change 4003193 by JohnHenry.Carawon QAGame: Updates to test content - Shortened frames between the examples from 95 to 30 - Separated camera setting tracks - Lighting example now switches directly from constant red - green - blue Change 4003369 by Max.Chen Sequence Recorder: Refresh next sequence regardless of internally stored sequence name. #jira UE-55757 Change 4003586 by JohnHenry.Carawon QAGame: Test Content Updates - Level Visibility track now ends to that the levels are not visible when we move to the next example - Shortened camera section, removed Z tranform so that we just move left to right and shortened the overall length Change 4004414 by Max.Chen Movie Scene Capture: Fix regression where rendering with shot handles would only render the first shot. 3972166 addressed an issue where an extra frame would be rendered by finalizing right when the end frame was reached. This was hit on the first shot end frame, so instead, do this only for when the last shot is being rendered. #jira UE-57314 Change 4004765 by Christina.TempelaarL Sequencer: Fixed bugs in FCP XML import/export. - Export: fixed sequence default resolution. - Export: fixed XML files with no shots. - Export: all sections clipped to playback range. - Export: fixed incorrect section start/end times due to precision issues. - Import: fixed incorrectly adding cinematic tracks. - Import: fixed bugs creating new sections. #jira UE-57660 #jira UE-57662 #jira UE-57655 #jira UE-57761 Change 4005119 by Max.Chen Sequencer: Export/import at play rate Change 4005195 by Max.Chen UMG: Finish UMG evaluation on stop. Added object version so that existing UMG assets do not change. #tests - Newly created UMG animation with sections set to restore state now return to their original state. Existing UMG animations with sections set to restore state do not return to their original state. #jira UE-52285 Change 4005377 by Michael.Karambelas QAGame: Moving TM-SequenceRecorder and related content out of my developer folder and into /Content/Sequencer/SequencerRecorder/* Change 4005417 by Michael.Karambelas QAGame: Fixed a BP compiler in the Level Blueprint of TM-SequencerRecorder. Change 4005634 by Michael.Karambelas QAGame: Fix up missing content and broken level sequence in TM-SequenceRecorder after move Change 4006324 by Max.Chen Sequencer: Reset if the focused movie scene is null. This fixes a crash if the user is focused in on a shot and undo takes the user past the point of where the shot was created. #jira UE-57752 #jira UE-47661 Change 4007006 by Max.Chen Sequencer: Fix FindAvailableRowIndex so that it returns the max row index (and not +1) since it doesn't find any conflicting rows. #jira UE-57717 Change 4007907 by Max.Chen Sequencer: Fix crash if there's no animation Change 4007948 by andrew.porter QAGame: added test content to dev folder for Record World Space Change 4008636 by Max.Chen Sequencer: Fix import fbx not setting values properly and creating additional cameras unncessarily. #jira UE-57864 Change 4008759 by Max.Chen Sequencer: Follow up fix for import cameras #jira UE-57864 Change 4009994 by Matt.Hoffman Dragging the left or right handles of the Time Range slider in Sequencer will now zoom your view in on the current center of the screen. This prevents the view from being translating as you tried to zoom in which caused issues at high zoom levels. #jira UESEQ-407 Change 4010169 by Christina.TempelaarL Sequencer: FCP XML fixes. - FCP XML export - no longer clips to playback range - FCP XML and EDL export - fixed missing last frame of some sections after exporting to Premiere. - Automated level capture, EDL export - use RoundToFrame instead of FloorToFrame for computing section start/end frames after frame rate conversion. #jira UE-57802 - partial fix, movie scene capture still needs to render full section rather than clip against playback. Change 4010287 by Mike.Zyracki Add quaternion interpolation option to UMovieScene3DTransformSection. This mimics how Matinee used to work by bascially finding the keys between a time and interpolating the angles as quat's between them. As noted in the code the algorithm needs to handle the case when the x,y,z Rotation keys all aren't at the same time which was not handled by Matinee. Also like Matinee, when in quaternion interoplation mode, we need to not display the function cuves since the interpolated and key values are now all different. (Would like to show them but that's a bigger refactor for perhaps just a one off needed by quaternions). I added a virtual function UMovieSceneSection::ShowCurveForChannel for this since it needs to be dynamic, not on construction of IKeyArea's, and could be useful for other sections. I could though move the method to just UMovieScene3DTransformSection and do a cast instead. Looked into doing a unit test for this but after talking with Andrew P we will work on doign an automated test in EngineQA since that will provide more coverage. Will also add a video the jira. #jira UESEQ-403 Change 4010713 by Mike.Zyracki Added option to key a group of transform channels instead of just the changed channel, or all of them. This is useful for quaternion interpolations where you want rotation keys to be aligned but also useful for other workflows like animating FK Pose to Pose. Change 4010715 by Andrew.Porter MediaFrameworkTest: Setting LogMediaUtils logging from VeryVerbose to Verbose to cut back on the spam Change 4013048 by Max.Chen Sequencer: Fix play/jump status. Update the player status for all position methods (Scrub, Jump, Play). Jump means Stopped. Correctly use PlayTo or JumpTo based on position method. In PlayInternal, JumpTo with the Stopped state (rather than playing state). #jira UE-57844 Change 4013479 by andrew.porter QAGame: Added content in TM-SequenceRecorder to test recording a property on a Cine Camera Component; Press 3 to trigger manual focus distance to increment on a timer Change 4014323 by Max.Chen Sequencer: Fix SetPlaybackPosition so that it jumps or plays based on playback status. #jira UE-57844 Change 4015888 by Max.Chen Sequencer: Fix crash on paste. UMovieSceneSections were gathered from the track node's track. For sub track mode, we want to gather only those sections on that track node row. #jira UE-57951 Change 4015943 by Max.Chen Sequencer: Fix moving shots up when the mouse pos goes outside of the virtual track area. #jira UE-57717 Change 4016293 by Max.Chen Sequencer: Fix relative frame playback end frame calculation so that custom start/end frames remain in the space of the sequence and are not relative. #jira UE-57308 Change 4017075 by Andrew.Rodham Sequencer: Corrected initial evaluation range used when calling UMovieSceneSequencPlayer::Play() Change 4017270 by Christina.TempelaarL Sequencer: FCPXML importer and movie scene capture - Use CeilToFrame when converting section start/end frame times to frame numbers in FCPXML and movie scene capture. - Added support for clip metadata in FCPXML. - Got rid of redundant TokenizedError message class, no longer needed now that FCPXML is in editor directory. - Added log messages currently commented out due to exception, still testing. #UESEQ-358 Change 4018370 by Christina.TempelaarL Sequencer: fixed FCPXML log messages regarding sections with start/end not divisible by display rate. #UESEQ-358 Change 4018378 by Christina.TempelaarL Sequencer: fixed error in previous changelist. #UESEQ-358 Change 4019457 by Max.Chen Sequencer: Show event names only when the event track is selected #jira UE-57897 Change 4022806 by Max.Chen Sequencer: Fix crash on movie scene capture dialog shutdown if movie capture wasn't even started. #jira UE-58106 Change 4022894 by Max.Chen Sequence Recorder: Wrap OpenEditorForAssets after sequence recording within GIsEditor #jira UE-58084 Change 4024487 by Max.Chen Sequencer: Add tooltip for quat interpolation #jira UE-58113 Change 4024562 by Max.Chen Sequencer: Change path/attach track sequence binding id to currently focused sequence id so that bindings can be created in subsequences Change 4027414 by JohnHenry.Carawon QAGame: Checking in content that shows a bug with using particles systems and Delay Before Shot Warm Up. Change 4028990 by Max.Chen Sequencer: Fix evaluate sub sequences in isolation. This check was added with the compile on the fly logic. Not sure why it was necessary but it seems like the sub sequence data needs to be updated in order to evaluate sub sequences in isolation. #jira UE-58184 Change 4029004 by Max.Chen Sequencer: Ensure that old binding references are removed when re-assigning actors in sequencer #jira UE-57898 Change 4030997 by JohnHenry.Carawon QAGame: Fixing name of the master sequence Change 4031785 by Michael.Karambelas QAGame: Added an instance of ThirdPerson Run to TM-SequenceRecorder for Record to Possessable test. Change 4035548 by Andrew.Rodham Sequencer: Changed FMovieSceneEvaluationTemplate::TemplateSignature to be a serial number to address non-deterministic cooking issues - This commit is related to the repro steps found in 3914599 and 3934307, both of which have been verified with this new change. - Copy of 4031684 from //Fortnite/Main/... #jira FORT-84852 Change 4036312 by Max.Chen Sequencer: Fix zoom view range so that it uses the passed in InZoomDelta Change 4036318 by Max.Chen Sequencer: Auto size now returns a range and defaults to the channel proxy range so that keyed regions can also be autosized. Change 4036322 by Max.Chen Forgot missing change Change 4036360 by Max.Chen Sequencer: Fix play rate calculation when skeletal animation section play rate changes. Change 4037163 by Mike.Zyracki Weighted Tangent Implementation Tricky thing is that you need to solve a cubic in order to get the bezier weights for the time part of the curve. See https://www.gamedev.net/forums/topic/474094-help-function-curves-for-animation-interpolation/ Maya provides an implementation in it's dev kit but I didn't use it since it was horribly slow and uses an iterative solution to solve the cubic needed. Instead I use an old algorithm (Cardano's method), to solve the cubic which should be much faster. Though relative simple to code from principles I just went ahead and used a version from Graphics Gems 1. I put this cubic solver directly in MovieSceneFloatChannel.cpp, but will need to move it when we support Rich Curve, maybe to FMath:: (which would probalby require some other functions for solving quartics, etc.. for completeness.). Also note we resolve this on every evaluation but dont' need to if the interval the time is evaluating hasn't had any change in values or tangents. So again when we support FRichCurve we can create a Weighted Evaluating class that can hold the cache. Also with the tangent drags I got rid of the Cardinal position that was used to calculate non-weight tangents from the key point and just quickly getting a direction. With weighted tangents we need to use the delta instead (otherwise when moving multiple they would all get the same weight based upon distance to the cardinal point. ) For mixed tangents types what I'm defaulting to non weighted if the interval doesn't match. May need to do weighted instead, not sure. What's left is just FBX import, for tomorrow. #jira UESEQ-76 Change 4037435 by Mike.Zyracki Fix fo build warnings from weighted tangent submission. #trivial Change 4038091 by Michael.Karambelas QAGame: Updated a Sequence Recorder group in TM-SequenceRecorder that had an actor missing the animation. Change 4038374 by Andrew.Rodham Sequencer: Refined scrubber styling for level sequences and actor sequences - Scrubber now shows a block the width of a dsplay rate frame, plus a line for the actual evaluated time. UMG reverts back to the previous styling (no block) - Keys that are outside of the playback range are now drawn with a subdued effect - Tick labels are no longer drawn when directly underneath the scrubber Change 4038490 by Max.Chen Sequencer: Expose tangent weight values in details panel. Change 4038620 by Andrew.Rodham Sequencer: Advanced time panel polish #jira UESEQ-426 Change 4038677 by Max.Chen Movie Scene Capture: Redirector for MovieSceneTools.AutomatedLevelSequenceCapture #jira UE-58248 Change 4039739 by Max.Chen Sequencer: Media track should only be supported by Level Sequence Change 4040024 by JohnHenry.Carawon QAGame: Fix EventReciever and OverrideBinding example The level sequence was set to none so the fix was to set it back to TrackEvaluation_Master. Change 4040610 by Andrew.Rodham Curve Editor: Moved weighted tangent switchers to a single toggle command (CTRL+W) and added an icon #jira 58383 Change 4040882 by Mike.Zyracki Keep broken when turning on weighted #jira UE-58435 Change 4041089 by andrew.porter QAGame: Sequence for Long Tangents bug Change 4041498 by Mike.Zyracki Turn off weighted when going auto to prevent large tangents. Do it both in UI and when doing AutoSetTangents() to really make sure it doesn't happen. #jira UE-58452 Change 4041752 by andrew.porter MediaFrameworkTest: Adding some better logging for setting rates when not supported. Also ignoring commiting URL when there is no text Change 4041896 by Matt.Hoffman The transform dialog box now transforms selected keys and sections, instead of just keys. #jira UE-58265 [CL 4044405 by Max Chen in Main branch]
2018-05-02 10:10:00 -04:00
ProcessCommands();
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3946692) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3801826 by Max.Chen PR #4304: Level Sequence crash fix - Guarded against dereferencing null componen. (Contributed by DSDambuster) Change 3801828 by Max.Chen PR #4302: Movie Scene Visibility Template unitialised variable, causing random . (Contributed by DSDambuster) Change 3801837 by Max.Chen Sequencer: Delay spawning/construction for convert to possessable. This fixes a bug where property values would be lost when converting back and forth from possessable to spawnable. #jira UE-52400 Change 3801841 by Max.Chen Sequencer: Make spacer nodes not selectable. PR #4194: Improvements to Sequencer (Contributed by projectgheist) #jira UE-53117 #jira UE-52139 Change 3804183 by Max.Preussner MediaAssets: Added missing lock in media sound component Change 3805414 by Max.Preussner MediaAssets: Setting valid GUID when initializing media texture resource Change 3819578 by Max.Chen PR #4370: When enabling the "MovieCapture", do not turn off the Stereo-3D display. (Contributed by yehaike) #jira UE-53647 Change 3823414 by Max.Chen Curve Editor: Lock down the first and last keys in the redundant keys removal range so that they're unaffected. #jira UE-53591 Change 3826406 by Max.Chen Sequencer: Move OnStartedPlaying() to within first update in UpdateTimeCursorPosition(). This fixes an issue where setting the hud/player visibility was getting stomped on later. #jira UE-52772 Change 3827044 by Max.Preussner MediaAssets: Added sprite visualization to media sound component #jira UE-53594 Change 3827988 by Max.Preussner MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together #jira UE-53532 Change 3828506 by Max.Preussner MediaPlayerEditor: Added attenuation visualizer for media sound components #jira UE-53594 Change 3832590 by andrew.porter EngineTest: Added a keep state check in Property Animation sequencer test Change 3833053 by andrew.porter EngineTest: Adding Hierarchical Bias test Change 3835683 by andrew.porter EngineTest: Adding UMG Animation screenshot test Change 3836076 by Max.Chen Sequencer: Fix audio volume and pitch multiplier deprecation. Change 3836230 by andrew.porter EngineTest: Adding Sequence Bone Position automation test Change 3836347 by Max.Chen Sequencer: Fixes to shot name parsing. When a shot doesn't contain a shot number, assume, [ShotName]_[TakeNumber]. When duplicating a shot, put the new shot in the same path of the original shot, so that the take numbers will increment properly. #jira UE-51868 Change 3836552 by Max.Chen Sequencer: Sub section now has a takes menu Change 3838094 by Max.Chen UMG: Fix template finish not getting called on stop. This fixes a bug where sections aren't restored when finished. #jira UE-52285 Change 3838708 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3840295 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840957 by Mike.Zyracki Added Show Only Keyable and Show Only Animated to the filter list in the property editor. Added IsPropertyAnimated to IDetailKeyframe Interface which already had support for showing properties which are keyable (which is used for the key icon next to the properties.). Could have created another interface but then would have had to mimic the sequencer binding, releasing also, so this seemed best way. One issue still left is that custom built detail items currently don't store associated properties(usually) and so certain properties, in particulalry transforms, won't show up as keyable or animated. Note this also shows up with the keyable icon not showing up next to transform tracks, and other filters like Show Only Modified not working with transforms/customs. Not sure best way to tackle this. #jira UESEQ-328 Change 3841756 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3843950 by andrew.porter EngineTest: Renaming LevelStreaming tests/content to LevelVisibility Change 3844082 by Mike.Zyracki Missing file for animated filter in property editor. When finding if a track is animated we need to find it but we can't easily induce the MovieTrack class for any particular property. So we don't set a class for it and just search by it's ID and name. #jira UESEQ-328 Change 3846902 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed #jira UE-54247 Change 3849820 by Mike.Zyracki Reassigning deleted widgets didn't work since the menu extender mechanism needs a valid UObject in order to perform an operation on it. So to fix we replaced GetObjectBindingContextMenuExtender in WidgetBlueprint with new delegate mechanism (OnBuildCustomContextMenuForGuid) that supports FGuid in addition to UObjects which is needed to handle re-binding deleted widgets. Note that the default sequencer hacks this for replacing deleted actors in SequencerObjectBindingNode to check to see if a LevelSequence is active. We could move to this mechanism there also. #jira UE-53163 Change 3852211 by Max.Chen UMG: Indicate name of the property that is not bound. #jira UE-54350 Change 3854120 by Max.Chen Sequencer: Fix sibling folders being allowed to have the same folder name. #jira UE-54363 Change 3854627 by Max.Chen Sequencer: Step to next/previous key should work for all tracks if there aren't any selected. #jira UESEQ-391 Change 3855825 by andrew.porter EngineTest: Adding animation blending automation test Change 3855950 by andrew.porter EngineTest: Adding correct expected valuues to animation blending test Change 3856237 by Matt.Hoffman UESEQ-336 - Sequencer Track Reordering Adds the ability to re-order Master Tracks, Folders and Object Bindings within sequencer hierarchies (including UMG). Adds the ability to do a one-off sorting of the content under the old sorting behavior if the user wants to reset their layout to how it was under legacy behavior. Modifies SequencerTrackNodes, SequencerFolderNodes and SequencerObjectBindingNodes to handle CanDrop/OnDrop for above, below and ontop of. Fixes a Slate Issue that forcibly expanded a TreeviewRow if an item handled OnDrop. Slate will now only forcibly expand the row if the item says the drop happened ontop of the item, and not above or below it like it previously did. Change 3856503 by andrew.porter EngineTest: Adding automation test for using animation blueprint with blend multi node in sequencer Change 3857875 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. #jira UE-54462 Change 3858344 by Max.Chen Sequencer: Prevent Goto and Transform boxes from overlapping by allowing them to be visible at the same time in an autosized horizontal box. Also, added close button to the goto box. PR #4425: Prevent Goto and Transform boxes from overlapping in Sequencer ... (Contributed by projectgheist) #jira UE-54210 Change 3860566 by andrew.porter MediaFrameworkTest: Set the option to index 0 for the audio and video track list by default Change 3860654 by andrew.porter EngineTest: Enabling Camera Cut + FOV test Change 3860981 by andrew.porter EngineTest: Updating skeletal mesh tests with a delay after set playback position Change 3861256 by Max.Chen Sequencer: Add all bindings if none selected. #jira-54440 Change 3862154 by Andrew.Rodham Added TimeManagement module Change 3862424 by andrew.porter EngineTest: Turned on the test Bone Positions with Blend Multi Node Change 3862573 by andrew.porter EngineTest: Adding test to compare bone positions in a sequence that is blending an animation that is using an AnimBP Change 3865117 by Max.Chen Sequencer: Stop auto scroll on mouse release of movement. #jira UE-31212 Change 3865303 by Max.Chen Sequencer: Add drag and drop transactions #jira UE-54662 Change 3865304 by Max.Chen Sequencer: Fix crash when an actor factory is not found. Change 3865361 by Max.Chen Sequencer: Don't change the camera/shot lock button when popping out of a sequence. #jira UE-54665 Change 3865412 by Max.Chen Sequencer: Determine whether a transform track is for a camera by using the spawned object or template #jira UE-54666 Change 3865685 by Max.Chen Sequencer: Clear autoscrub offset when stopping autoscroll #jira UE-31212 Change 3865886 by Max.Chen Sequence Recorder: Log an error if the number of frames changes while recording. This can happen if the skeleton changes while recording. #jira UE-48715 Change 3866925 by Andrew.Porter MediaFrameworkTest: Changing the current PNG test video image sequence to 1024 x 576 Change 3867705 by andrew.porter QAGame: Adding Audio Sort Sequence to dev folder Change 3867890 by andrew.porter QAGame: Adding a sequence for testing a sorting crash to my dev folder Change 3872628 by Max.Chen Movie Scene Capture: Split delay before warmup into split delay before shot warmup so that there's separate controls for when the movie scene capture warmups up vs. shot boundaries. Change 3873131 by Matt.Hoffman UE-54732 - Crash reordering a folder with a track. This was caused by folders being the only type of track to check if someone was putting a parent track into a child track. Object Binding tracks and Tracks now check as well so that you can't use the above/below drop targets to add parents as children. This also fixed a typo in the localization keys. #jira UE-54732 Change 3873301 by Mike.Zyracki Added ability to support continous euler angle changes when changing rotations, in particularly with the rotation gizmo's. To do this we effectively added a form an of 'euler filter'(https://en.wikipedia.org/wiki/Euler_filter) to find the closest euler angle to the current euler angle. Three functions were added to FRotator to make this possible, one to get the euler angle that's has the same rotation as it, one to get the difference between two euler angles via Manhattan distance and a third using the previous two to choose a Rotator value that's closest to it. We then use these functions before calling UComponent::SetRelativeRotation to make sure we use the correct Euler after the Quat conversion. We also no longer limit(bound) the euler angles to -180,180, which is obviously necessary to avoid flips. I also changed how we caluclate yaw and roll when pitch is -90 or 90 to make it the standard approach of zeroing out roll and just setting yaw. Main reasons are the previous implementation had precision issues so things like 180, 90, -180 would show up due to numbers being nearly zero but negative,(this would break any smooth interpolations), and this facilitates having a 'gimbal' rotation mode (like Maya, Blender etc..) if we ever want that also. If needed we could keep the previous implementation but would need to add some FMath::IsNearlyZero checks, with less performance. Note we only do this special filtering when applying delta's to actors or components in the editors, which then call UComponent::SetRelativeRotationExact, which is a new function to foces the RelativeRotation to be equal to the new rotation. This allows us to store un-nomalized Rotators at the cost that the RotationCache may be broken. We didn't change any of the other UComponent functions that set rotations (via Quats or Transforms) so they will still be bounded and unwound. In SetInternalWorldLocationAndRotation we only set the rotation if the rotation has changed, which fixes the rotation getting changed and re-normalized if just translate happens. In TransformTrackEditor, we correclty use the bUndwing flag and in MovieScene3DTransformSection there was an un-needed winding check there, it will be unwound earlier if needed, which happens if Sequence Recording is happening. Max we should talk about what to do about this . Note the euler angle drag via the widget is still bound to 0-360. I think we should just unbound that now since the rotations value are now unbound. This review now includes fixes suggested by Zak. #jira UE-UE-22228 Change 3873483 by Matt.Hoffman Sequencer Tracks can now be inserted above the spacer at the bottom of the tree. #jira UE-54706 Change 3873899 by Max.Chen Sequencer: Add section selection throbbing Change 3873908 by Max.Chen Movie Scene Capture: Added logging per frame Change 3873924 by Matt.Hoffman Adds the ability to store Sequence Recorder setups into profiles that stay with the map and can be re-loaded later. Profiles store the Actor Recordings so the settings for each actor should carry with them. #jira UESEQ-339 Change 3874726 by Matt.Hoffman Disable drag-and-drop targets on spacers that come between rows in Sequencer. This prevents extra drag/drop targets showing up between each row. #jira UE-54706 Change 3874862 by Matt.Hoffman Audio Track no longer gets reordered when adding sub-audio tracks, as sub-tracks are no longer counted towards the sorting order index when normalizing indexes. #jira UE-54727 Change 3875905 by Matt.Hoffman Disable Fade Track UI if a fade track already exists in the sequence. #jira UESEQ-393 Change 3876163 by Max.Chen Sequencer: Swap the camera object to the camera component's owner if it's not the same. #jira UE-54874 Change 3876971 by Andrew.Porter EngineTest: Moved Media Player Seek test to new folder. Also enabled the test with new ground truth image. Change 3877040 by Max.Chen Cine Camera: Split camera properties to two groups, "Camera Options" and "Camera Settings". The cine camera now hides properties in the "Camera Settings" group so that properties like bConstrainAspectRatio (in the "Camera Options" group) can be visible. #jira UE-54192 Change 3877763 by Max.Chen Curve Editor: Fix curve changed on end drag so that only curves that had keys/tangents that were changed receive notification, otherwise all loaded curves were getting notified that they were changed. #jira UE-54951 Change 3878234 by Matt.Hoffman Disable "Drop Below" targets for Sequencer Tree nodes to prevent a confusing UX issue where dropping underneath a Object Binding Node puts it after the object binding node but the UI looks like it's inserting it inside the Object Binding node. #jira UE-54743 Change 3879359 by Mike.Zyracki If a track is inactive we dim it a bit which seems to be the UE4 way to show inactive or disabled state. We changed the active logic so that all subtracks need to be inactive for the track to also be inactive(instead of all active for active). This conforms to how the active state actually works, e.g if you have two sections and only one is active the track is still active above it. #jira UESEQ-388 Change 3879462 by Max.Chen Sequencer: Allow dragging onto a particular row which would move out any overlapping sections to make space for the newly created section. Newly created sections are now selected and throbbed to draw attention to themselves. #jira UE-54664 Change 3879464 by Max.Chen Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field. - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field. - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges. #jira UE-54922 Change 3879590 by Matt.Hoffman Items that are now added to the Sequencer via the "+Track" menu will be selected after being added. Items can now be added inside of folders instead of just to the root level. #jira UE-27397 Change 3879612 by Mike.Zyracki Display Nodes with no children are always active. #jira UESEQ-388 Change 3879730 by Matt.Hoffman Sequence Recorder's actor recording groups now remove items from the group when removed via the UI. #jira UESEQ-339 Change 3880256 by Mike.Zyracki Fix issue with inactive display with folders and other track nodes. #jira UESEQ-388 Change 3883491 by Max.Chen Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes. Copy from Release-4.19 #jira UE-51323 Change 3883603 by Max.Chen Movie Scene Capture: Add option toggle disable screen percentage. By default this is on (no change in current behavior). #jira UE-51898 Change 3885074 by Max.Preussner MediaCompositing: Resetting media texture & freeing resource on section end; removed dead code Change 3887220 by Max.Preussner MediaCompositing: Defaulted media section duration to 1 sec (since we do not know the actual duration in most cases) Change 3887478 by Matt.Hoffman Sequences now show [Inactive] in their title bars when they're disabled. This helps communicate why a sequence isn't being evaluated. #jira UE-51469 Change 3888985 by Max.Chen Movie Scene Capture: Clamp HDR Compression Quality between 0 and 1. #jira UE-55136 Change 3893519 by Max.Chen Sequence Recorder: Clarified tooltip for bRecordNearbySpawnedActors - spawned actors will still be recorded if they match the ActorFilter. #jira UE-55238 Change 3893546 by Max.Chen Sequence Recorder: If a selected actor already has a recording, add a blank recording. #jira UE-55239 Change 3894044 by Max.Preussner MediaCompositing: Added support for seeking into a media section Change 3894310 by andrew.porter MediaFrameworkTest: Adding Img media sources for 1080 and 2160 ravent test content Change 3894426 by Max.Preussner MediaAssets: Letting media textures with AutoClear retain their clear color when player is reset Change 3895717 by Max.Chen Sequencer: Null checks to prevent crash when saving the default state of a spawnable #jira UE-55304 Change 3897388 by Max.Chen Sequencer: Don't update current time to be within the view range when stepping into a sequence. #jira UE-55322 Change 3897452 by Max.Chen Audio: Fix crash when trying to record audio without any active capture devices. Log warning if the number of input channels is not 1 or 2. #jira UE-55223 Change 3897619 by Max.Preussner MediaCompositing: Removed commented out code Change 3898072 by Max.Chen Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated. #jira UE-55328 Change 3898272 by Max.Preussner MediaPlayerEditor: Made slate brush constants static Change 3898704 by Max.Chen Sequencer: Skip if the binding id's sequence can't be found. #jira UE-55337 Change 3899855 by Max.Preussner MediaCompositingEditor: Added cache state visualization to media track Change 3900300 by Max.Preussner MediaCompositingEditor: Added loop indicators to media sections Change 3900694 by Max.Preussner ImfMedia: Looping cache only when player is looping Change 3900892 by Max.Preussner Stats: Added stats category for media framework Change 3900954 by Max.Preussner MediaCompositing: Don't evaluate at the end of media section Change 3901348 by Max.Preussner Core: Replaced TLruCache autos for better readability Change 3901655 by Max.Preussner ImgMedia: Added more perf stats to EXR reader Change 3901972 by Max.Preussner MediaAssets: Added getter for media player in media sound components Change 3902233 by Max.Preussner MediaAssets: Enabling media textures to receive samples right after player is assigned Change 3902238 by Max.Preussner MediaCompositing: Working around init/shutdown idiosyncracies in sequencer Change 3904045 by Max.Chen Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register. #jira UE-55314 Change 3905605 by Max.Chen Sequencer: Restrict spawnables from being created if they have a ClassWithin that UMovieScene is not a child of. #jira UE-55429 Change 3906550 by Max.Chen Sequencer: Add media track icon #jira UE-55480 Change 3907101 by Max.Chen Sequence Recorder: Fix bugs related to not recording a level sequence. There were certain assumptions that creating a level sequence meant that sequence recording was in progress. This is not always the case - the recorders can record animation assets and not create a level sequence. Changed the notion of IsRecording() to having at least one actor recording that is recording. Countdown timer, recording displays, etc should function if IsRecording() and not based on whether a level sequence is created. #jira UE-55485 Change 3907247 by Max.Chen Sequence Recorder: Fix crash not removing PrepareToCleanseEditorObject delegate. Repros when opening sequence recorder, closing it, and then opening or creating a level. Change 3910343 by Max.Preussner Core: Added async helper for executing functions on a given thread pool Change 3910346 by Max.Preussner ImgMedia: Added separate thread pools for loading/decoding and deleting image frames Change 3910829 by Max.Preussner Profiler: Increased visible range of profiler graph Change 3910841 by Max.Preussner MediaCompositing: Displaying asset name instead of full media source path in media section Change 3910870 by Max.Preussner ImgMedia: Using deallocation thread pool only in debug builds Change 3919642 by Max.Chen Sequence Recorder: Clarify active tooltip #jira UE-55661 Change 3919660 by Max.Chen Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified - The following sequence of events exposes this issue: - Create a master sequence with a single shot that spawns a cube - Add this sequence to a level and set it to auto-play - Save everything and restart - Resave just the inner shot asset without opening it - PIE - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template. #jira UE-55626 #jira UE-55490 Change 3921825 by Max.Chen Sequencer: "Run Construction Script in Sequencer" is off by default for blueprints but on for Sequencer. This allows the content author to switch it on for specific blueprints and sequencer will be default, run those with construction scripts enabled. Change 3922232 by Max.Chen Sequence Recorder: Reset countdelay on stop. #jira UE-55755 Change 3922306 by Max.Chen Sequence Recorder: Don't automatically mark transforms to be recorded by sequence recorder. Instead, log a warning if the user toggled it off to warn that the resulting animation might not match gameplay. #jira UE-55758 Change 3922912 by Max.Chen Sequence Recorder: Fix refresh next sequence name #jira UE-55757 Change 3927654 by Max.Chen Movie Scene Capture: Added format mapping for the name of the current camera #jira UE-55769 PR #4537 Change 3927658 by Max.Chen Sequencer: Added fbx property mapping for "FocusDistance" to "FocusSettings.ManualFocusDistance" #jira UE-55782 Change 3932022 by Max.Chen Sequencer: Add import animation track section to next available row index. #jira UE-55892 Change 3933919 by Max.Chen Sequencer: Jump to playback start frame and not 0 to start playback for recording. #jira UE-55933 Change 3934307 by Andrew.Rodham Sequencer: Add template signature that is re-generated every time the base template is regenerated, which invalidates evaluation fields This fixes an issue where the same sequence is instantiated multiple times in a sequence. If the source sequence was saved, its template would be wiped, which would invalidate the template ID When an instance tries to evaluate the master template, it would only invalidate a range in the evaluation field that was the hull of any invalid sub sequences overlapping the current time, potentially leaving invalid data in the evaluation field at positions later (or earlier) on in the sequence When the sub template was re-generated, it receives the same SequenceSignature as it had before (because the sequence hasn't actually changed), which causes the stale evaluation field data to fail the IsDirty check (because the sequence is the same as it thought, but the *template* has changed) This has been addressed be adding a signature to templates themselves, and checking both the template signature and sequence signature as a part of the IsDirty check. This ensures that we regenerate if either the template, or the sequence have changed. #jira UE-55934 Change 3936327 by Andrew.Rodham Sequencer: Removed increment when trimming right UMovieSceneSection::TrimSection already explicity assigns an exclusive bound to the time passed in. The new behavior means we can trim a section to the right, and insert another section without changing the time to create adjacent sections. #jira UE-42652 Change 3936328 by Andrew.Rodham Fixed KeyFrameManipulator assignment operators and copy/move constructors - These types are potentially self-referential so cannot use default constructors/assignment Change 3936330 by Andrew.Rodham Converted UMGSequencePlayer to use frames internally #jira UE-54878 Change 3936726 by Max.Chen Sequencer: Set track node as the parent of the key area node. The key area switcher needs the object binding id from the parent object binding node. Without this, the binding to the external value fails. #jira UE-55931 Change 3936775 by Max.Chen Sequencer: Should stop or loop should compare DurationFrames with Current Time from StartTime. The bug is that if you set 30 warmup frames in movie rendering for a range of 0-100, the FrameRange will be starting at -30 and have a duration of 130. Without this fix, the playback will continue until frame 130, rather than 100. #jira UE-55933 Change 3936935 by Matt.Hoffman Easing Curves are now represented in Play Rate resolution instead of internal resolution. #jira UE-55937 Change 3937069 by Matt.Hoffman Users can toggle if the is infinite on each side, limited by which tracks support infinite ranges. #jira UE-55891 Change 3937516 by Max.Preussner ImgMedia: Added support for single-threaded platforms #jira UE-55986 Change 3937826 by Max.Preussner MediaAssets: Disabling media sound components on HTML5 if AudioMixer is not enabled Change 3937997 by Max.Chen Curve Editor: Add Zoom to Fit Curves so that selected curves from Sequencer can be focused on. Tested that undo doesn't re-zoom. #jira UE-55935 Change 3938000 by Max.Chen Sequencer: Stop all sounds before generating audio waveforms. #jira UE-55951 Change 3938376 by Max.Preussner XGEController: Disabled XGE Controller in single-threaded apps to prevent crash Change 3938444 by Max.Preussner Core: Added async support for single-threaded applications Change 3938445 by Max.Preussner Networking: Added support for single-threaded applications in UDP socket sender/receiver Change 3938447 by Max.Preussner Messaging: Added support for single-threaded applications Change 3939432 by Max.Chen Sequence Recorder: Append command list to global level editor actions so that shortcuts are accessible in level editor. #jira UE-55798 Change 3940229 by Andrew.Rodham Added prospective display rate upgrade to UMovieScene::PostLoad - There was previously some very odd behaviour that would assign the fixed frame interval only when a sub sequence was focused in SSequencer. This meant that many sequences could have a frame interval of 0 set in the data. - Under the old method of snap interval display this would have fallen back to getting the display interval from the sequencer settings, but we no longer look at these. - The USequencerSettings properties have been removed and in their place, a prospective data upgrade for sequences that have a fixed frame interval old 0fps that sets the play rate to the previous defaults based off the old USequencerSettings defaults. - This could end up 'changing' the display rate for sequences where the user has changed the snap interval in the settings for a particular sequence editor, but there's not much we can do about that given we don't have access to the USequencerSettings classes in UMovieScene #jira UE-55919 Change 3940277 by Andrew.Rodham Sequencer: Added ability to default frame resolutions and play rates for newly created actor sequences Change 3940378 by Andrew.Rodham Sequencer: Post move import dialog now defaults to the playback framerate of the sequence, and floors to frame numbers Change 3940559 by Andrew.Rodham Reinstated primed or recording sequence color Change 3940642 by Max.Preussner ImagePlate: Removed image plate media playback functionality Change 3940843 by Max.Preussner Core: Made TCircularQueue actually thread-safe; improved code comments Change 3940860 by Max.Chen Sequencer: Changed StructNameToKey to StructPathToKey Previously, keying a PropertyPath of [RenderTransform][Shear][X] would get trimmed to X, which doesn't map to a channel name as considered by Sequencer2dTransformTrackEditor. Instead, trim the resulting property path to [Shear][X] so that track editors can determine the desired struct path and channels to key. #jira UE-52966 Change 3941292 by Mike.Zyracki Fix for trajectories out of range not showing up. 1) If we had no key data we would pop the time, so wouldn't get the section ranges. 2) Calculating of upper bound was wrong, checking against -1 and not key == num of keys when doing algo::lower_bound. 3) No need to do the Bck-- for the bakward iterators since we fixed #2. We start now from the upper bound correctly. 4) If we had no keys (at section start,end) we would incorrectly say we were any key type, so since we draw constant keys as dashed we would do so incorrectly around section end points. #jira UE-55929 Change 3941424 by Max.Chen Curve Editor: Change Zoom to Fit to use TArrayView Change 3941498 by Max.Preussner Core: Added FMath::DivideAndRoundNearest function Change 3942097 by Matt.Hoffman Drop Frame Timecode Support for NTSC rates. Change 3942104 by Matt.Hoffman Sequence Recorder Group is no longer visible inside the World Outliner after using one. #jira 55266 Change 3942107 by Max.Chen Sequencer: Resurrect logic to find or extend an existing section when adding keys. Change 3942330 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942339 by Max.Chen Sequence Recorder: Better tooltip for default animation settings. #jira UE-55636 Change 3942507 by Andrew.Rodham Sequencer: We no longer pad the time overlap threshold with a small number that is not scaled by the current zoom level - The presence of this pad was causing keys that were far apart to be grouped when zoomed in a long way Change 3942509 by Andrew.Rodham Sequencer: Only pad total view range, rather than section range as well when retrieving keys to render - This stops us from rendering keys that are within the view range, but outside the section range Change 3942512 by Andrew.Rodham Added transactions to some sequencer details customizations Change 3942513 by Andrew.Rodham Sequencer: Reinstated validation checks to UMovieSceneSection::SetStartFrame and SetEndFrame, changed erroneous uses to use SetRange Change 3942560 by Andrew.Rodham Pass by rvalue reference to appease error C2719 on Win32 ('InChannels': formal parameter with requested alignment of 8 won't be aligned) Change 3942697 by Andrew.Rodham Newly Created Level Sequences and Actor Sequences now default to 24000 fps frame resolution (+/- ~24hrs range, supporting all integer rates + 23.976) Change 3942700 by Andrew.Rodham Sequencer: Added legacy out-of-bounds errors for times that are not supported by the current legacy upgrade frame resolution Change 3942989 by Max.Preussner Core: Fixed circular queue count calculation Change 3943538 by Max.Preussner MediaAssets: Reverted workaround for procedural audio log spam in HTML5 (Actor component initialization cannot be skipped if the component is used in a level) Change 3944071 by Max.Preussner QAGame: Fixed Media Texture keeps last frame of Media when PIE ends #jira UE-53360 Change 3944292 by Max.Chen Sequencer: Added extra flags to ensure that asset initialization does not occur on template actor sequences #jira UE-56113 Change 3944364 by Max.Chen Sequencer: Prevent circular shot/master tracks. Tested adding master -> child -> master as drag and drop cinematic shot tracks and sub tracks as well as through the + button. #jira UE-56091 Change 3944422 by Max.Chen Sequence Recorder: Disable transform recording if off. #jira UE-56061 Change 3944745 by Andrew.Rodham Sequencer: Key rendering fixes - Fixed assert that occured when keys happened to reside on some times due to KeyTime + TimeOverlapThreshold - KeyTime being slightly larger TimeOverlapThreshold - Fixed keys sometimes being clipped when zoomed right in due to lack of half-frame offset - Added missing documentation to MovieSceneTimeHelpers.h #jira UE-56107 Change 3945231 by Andrew.Rodham Sequencer: Reconstruct channel proxy on Serialize to catch all cases of undo/redo, PostLoad and duplication #jira UE-56089 Change 3945301 by Andrew.Rodham Sequencer: Added safety checks during initial sequence recording to guard against applying negative or 0-sized sequence ranges #jira UE-56125 Change 3946627 by Max.Preussner Fortnite: Fixed game crashes closing editor while in PIE - Pure virtual function being called #jira UE-56144 [CL 3946896 by Max Chen in Main branch]
2018-03-14 22:09:33 -04:00
}
/* FMessageRouter callbacks
*****************************************************************************/
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
void FMessageRouter::HandleAddInterceptor(TSharedRef<IMessageInterceptor, ESPMode::ThreadSafe> Interceptor, FTopLevelAssetPath MessageType)
{
UE_LOG(LogMessaging, Verbose, TEXT("Adding %s as intereceptor for %s messages"), *Interceptor->GetDebugName().ToString(), *MessageType.ToString());
ActiveInterceptors.FindOrAdd(MessageType).AddUnique(Interceptor);
Tracer->TraceAddedInterceptor(Interceptor, MessageType);
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
void FMessageRouter::HandleAddRecipient(FMessageAddress Address, TWeakPtr<IMessageReceiver, ESPMode::ThreadSafe> RecipientPtr)
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
auto Recipient = RecipientPtr.Pin();
if (Recipient.IsValid())
{
UE_LOG(LogMessaging, Verbose, TEXT("Adding %s on %s as recipient"), *Recipient->GetDebugName().ToString(), *Address.ToString());
ActiveRecipients.FindOrAdd(Address) = Recipient;
Tracer->TraceAddedRecipient(Address, Recipient.ToSharedRef());
NotifyRegistration(Address, EMessageBusNotification::Registered);
}
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
void FMessageRouter::HandleAddSubscriber(TSharedRef<IMessageSubscription, ESPMode::ThreadSafe> Subscription)
{
auto Subscriber = Subscription->GetSubscriber().Pin();
if (Subscriber.IsValid())
{
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UE_LOG(LogMessaging, Verbose, TEXT("Adding %s as a subscriber for %s messages"), *Subscriber->GetDebugName().ToString(), *Subscription->GetMessageTypePathName().ToString());
}
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
ActiveSubscriptions.FindOrAdd(Subscription->GetMessageTypePathName()).AddUnique(Subscription);
Tracer->TraceAddedSubscription(Subscription);
}
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
void FMessageRouter::HandleRemoveInterceptor(TSharedRef<IMessageInterceptor, ESPMode::ThreadSafe> Interceptor, FTopLevelAssetPath MessageType)
{
UE_LOG(LogMessaging, Verbose, TEXT("Removing %s as intereceptor for %s messages"), *Interceptor->GetDebugName().ToString(), *MessageType.ToString());
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
if (MessageType == IMessageBus::PATHNAME_All)
{
for (auto& InterceptorsPair : ActiveInterceptors)
{
InterceptorsPair.Value.Remove(Interceptor);
}
}
else
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
auto& Interceptors = ActiveInterceptors.FindOrAdd(MessageType);
Interceptors.Remove(Interceptor);
}
Tracer->TraceRemovedInterceptor(Interceptor, MessageType);
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
void FMessageRouter::HandleRemoveRecipient(FMessageAddress Address)
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
auto Recipient = ActiveRecipients.FindRef(Address).Pin();
if (Recipient.IsValid())
{
UE_LOG(LogMessaging, Verbose, TEXT("Removing %s on %s as recipient"), *Recipient->GetDebugName().ToString(), *Address.ToString());
ActiveRecipients.Remove(Address);
Tracer->TraceRemovedRecipient(Address);
NotifyRegistration(Address, EMessageBusNotification::Unregistered);
}
}
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
void FMessageRouter::HandleRemoveSubscriber(TWeakPtr<IMessageReceiver, ESPMode::ThreadSafe> SubscriberPtr, FTopLevelAssetPath MessageType)
{
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
auto Subscriber = SubscriberPtr.Pin();
if (!Subscriber.IsValid())
{
return;
}
for (auto& SubscriptionsPair : ActiveSubscriptions)
{
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
if ((MessageType != IMessageBus::PATHNAME_All) && (MessageType != SubscriptionsPair.Key))
{
continue;
}
Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3149443 on 2016/10/03 by Max.Preussner MediaAssets: Better parameter names for MediaPlayer BP functions Change 3149756 on 2016/10/03 by Max.Chen Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity) #jira UE-35233 Change 3149795 on 2016/10/03 by Max.Chen Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic. #jira UE-36734 Change 3150378 on 2016/10/04 by Max.Preussner PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807) #jira UE-36807 Change 3151414 on 2016/10/05 by Max.Chen Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null. #jira UE-35285 Change 3152038 on 2016/10/05 by Max.Preussner UdpMessaging: Code & documentation modernization pass Change 3152471 on 2016/10/05 by Max.Chen Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a bug where the cine camera actor won't tick if you hook in event tick. #jira UE-36625 Change 3152692 on 2016/10/05 by Max.Preussner Messaging: API code & documentation modernization pass Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity. Change 3153824 on 2016/10/06 by Max.Preussner Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more. Change 3153826 on 2016/10/06 by Max.Preussner Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies Change 3153857 on 2016/10/06 by Max.Chen Sequencer: Set snap time to dragged key on by default. Change 3153980 on 2016/10/06 by Max.Preussner SessionServices: Removed typedefs; code and documentation modernization pass Change 3154313 on 2016/10/06 by Max.Chen Sequencer: Set the paste keys time to the current time, rather than the mouse time. Change 3154332 on 2016/10/06 by Max.Chen Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu. Change 3154377 on 2016/10/07 by Max.Chen Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and . Change 3154788 on 2016/10/07 by Max.Chen Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all sections except for any that aren't being moved. #jira UE-29152 Change 3159274 on 2016/10/11 by Max.Preussner Core: Documentation fixes Change 3159275 on 2016/10/11 by Max.Preussner UdpMessaging: Added missing header Change 3160746 on 2016/10/12 by Max.Preussner MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances #jira UE-37241 Change 3160975 on 2016/10/12 by Max.Preussner PS4Media: Better logging for SetRate failures Change 3160995 on 2016/10/12 by Max.Preussner MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248) #jira UE-37248 Change 3161066 on 2016/10/12 by Max.Preussner PS4Media: Enforcing minimum 8 byte alignment for media allocations Change 3161069 on 2016/10/12 by Max.Preussner PS4Media: Fixed log spam when setting play rate to current rate Change 3162567 on 2016/10/13 by Max.Preussner PS4Media: Made track switching code more readable Change 3163447 on 2016/10/14 by Max.Preussner PS4Media: Fixed array out of bounds assertions Change 3163772 on 2016/10/14 by Max.Preussner MfMedia: Fixed a number of timing related issues Change 3163980 on 2016/10/15 by Max.Chen Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level. Change 3164581 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure global pre-animated state is restored in reverse order Change 3164582 on 2016/10/17 by Andrew.Rodham Sequencer: Ensure pre animated state is restored for all actor components before saving default state Change 3164583 on 2016/10/17 by Andrew.Rodham Sequencer: Re-enabled support for pre and post roll Change 3165464 on 2016/10/17 by Max.Chen Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user. Copy from Release-4.14 #jira UE-37416 Change 3165483 on 2016/10/17 by Max.Chen Sequencer: Enable restore state for attach section completion Change 3165771 on 2016/10/18 by Andrew.Rodham Sequencer: Force evaluate when rendering thumbnails #jira UE-37321 Change 3166057 on 2016/10/18 by Andrew.Rodham Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed #jira UE-37285 Change 3166218 on 2016/10/18 by Max.Preussner MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470) #jira UE-37470 Change 3166247 on 2016/10/18 by Max.Preussner WmfMedia: Showing progress bar while media is being resolved Change 3166289 on 2016/10/18 by Max.Preussner MfMedia: Showing progress bar while media is being resolved Change 3166993 on 2016/10/18 by Max.Preussner MfMedia: Fixed info string not reset on media close. Change 3166999 on 2016/10/19 by Max.Preussner Media: Fixed NV12 and NV21 support Change 3167008 on 2016/10/19 by Max.Preussner Media: Removed vertical NV12 alignment Change 3167029 on 2016/10/19 by Max.Preussner WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505) #jira UE-37505 Change 3168593 on 2016/10/19 by Max.Chen Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence. Change 3168626 on 2016/10/19 by Max.Chen Sequencer: Clamp to view bounds should snap to frame if frame snapping is on. Change 3168627 on 2016/10/19 by Max.Chen Sequencer: Initialize working and view range to be 10% larger than playback range. Change 3168760 on 2016/10/20 by Max.Preussner Media: Revamped media texture buffer management to support padded frames Added support for Windows bitmap buffers. Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia. Not all shaders have been updated yet. Change 3169640 on 2016/10/20 by Max.Chen Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance. #jira UE-37407 Change 3170677 on 2016/10/21 by Max.Chen Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability. #jira UE-36560 Change 3170710 on 2016/10/21 by Max.Preussner Media: Optimized handling of RGB input Change 3170712 on 2016/10/21 by Max.Preussner Media: Fixed NV21 conversion shader scaling Change 3170923 on 2016/10/21 by Max.Preussner UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868 Change 3171494 on 2016/10/23 by Max.Chen Sequencer: Fix fbx export from master sequence not finding bound objects. #jira UE-35752 Change 3171506 on 2016/10/23 by Max.Chen Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative. #jira UE-35473 Change 3171743 on 2016/10/24 by Andrew.Rodham Editor: Added support for detail customizations on root structs - Also added the ability to add external struct data onto a detail category builder, and property type customization. Change 3171752 on 2016/10/24 by Andrew.Rodham Sequencer: Fixed spawnable ownership - Spawnables are no longer destroyed when the cursor leaves the master playback range. - Spawnable ownership now operates as it previously did before the evaluation rework. - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence. - FMovieSceneSequenceID is now a struct so that it can be used in array properties - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so we don't have to calculate that at runtime. Change 3171756 on 2016/10/24 by Andrew.Rodham Sequencer: Added ability to trigger events with parameters - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted. - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation. - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner. Change 3172935 on 2016/10/24 by Max.Preussner MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it Change 3173947 on 2016/10/25 by Max.Preussner SlateRemote: Disabled plug-in, but enabled server by default Change 3174510 on 2016/10/26 by Max.Chen Sequencer: Fix slomo track crash #jira UE-37802 Change 3174698 on 2016/10/26 by Andrew.Rodham UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself #jira UE-37775 Change 3174780 on 2016/10/26 by Max.Preussner MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers Change 3174789 on 2016/10/26 by Max.Preussner MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded Change 3174817 on 2016/10/26 by Max.Preussner WmfMedia: Added support for Motion JPEG (MJPG) Change 3174825 on 2016/10/26 by Max.Preussner WmfMedia: Added support for non-RGB32 uncompressed formats Change 3174834 on 2016/10/26 by Max.Preussner MediaPlayerAssets: Allow pausing while buffering media Change 3174886 on 2016/10/26 by Andrew.Rodham Core: Fixed range test that was testing incorrect behavior Change 3174889 on 2016/10/26 by Andrew.Rodham Sequencer: Fixed AssignActor behavior - Also ensure that cached object state is invalidated when playback context changes #jira UE-37798 Change 3174905 on 2016/10/26 by Andrew.Rodham Sequencer: Changed assert when failing to create an audio component to a log message - Audio no longer plays when GEngine->UseSound() is false #jira UE-37772 Change 3174980 on 2016/10/26 by Andrew.Rodham Sequencer: Remove warning when event endpoint could not be found for a given context #jira UE-37824 Change 3175001 on 2016/10/26 by Andrew.Rodham Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause. - Also protect Pause() against reentrancy when being called from an event Change 3175012 on 2016/10/26 by Max.Chen Sequence Recorder: Fixes an empty working and view range after recording. On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty. Added SetViewRange and SetWorkingRange. #jira UE-34191 Change 3177760 on 2016/10/28 by Max.Chen Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings. #jira UE-37808 Change 3178529 on 2016/10/28 by Max.Chen Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter #jira UE-37328 #2864 [CL 3178562 by Max Chen in Main branch]
2016-10-28 15:04:38 -04:00
TArray<TSharedPtr<IMessageSubscription, ESPMode::ThreadSafe>>& Subscriptions = SubscriptionsPair.Value;
for (int32 SubscriptionIndex = 0; SubscriptionIndex < Subscriptions.Num(); ++SubscriptionIndex)
{
const auto Subscription = Subscriptions[SubscriptionIndex];
if (Subscription->GetSubscriber().Pin() == Subscriber)
{
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UE_LOG(LogMessaging, Verbose, TEXT("Removing %s as a subscriber for %s messages"), *Subscriber->GetDebugName().ToString(), *Subscription->GetMessageTypePathName().ToString());
Subscriptions.RemoveAtSwap(SubscriptionIndex);
Tracer->TraceRemovedSubscription(Subscription.ToSharedRef(), MessageType);
break;
}
}
}
}
Copying //UE4/Dev-Sequencer to //UE4/Main (Source: //UE4/Dev-Sequencer @ 3617642) #lockdown nick.penwarden #rb none Change 3235667 on 2016/12/14 by Max.Preussner Media: Moved enums into separate header file, so they can be shared Change 3259266 on 2017/01/16 by Max.Preussner Core: Added timespan ratio Change 3267229 on 2017/01/21 by Max.Preussner Editor: Fixed texture samplers in materials not getting notified when sRGB mode changed Change 3274773 on 2017/01/27 by Max.Preussner Core: Added TLruCache template Change 3281579 on 2017/02/01 by Max.Preussner Core: Added scalar division to FTimespan Change 3289522 on 2017/02/07 by Max.Preussner MediaAssets: Added looping for play lists Change 3290664 on 2017/02/07 by Max.Preussner Engine: Moved UTexture material notification code into separate function, so it can be used by derived classes. Change 3290688 on 2017/02/07 by Max.Preussner MediaAssets: Notifying materials when media texture properties changed. Change 3291171 on 2017/02/07 by Max.Preussner MediaAssets: Filtering unused UTexture properties Change 3291229 on 2017/02/07 by Max.Preussner ImgMedia: Use displayWindow instead of dataWindow due to bug in OpenEXR with data window min < 0 Change 3298520 on 2017/02/11 by Max.Preussner Sequencer: Fixed skylight and reflection components off by one frame in PIE Change 3298778 on 2017/02/12 by Max.Preussner MediaUtils: Experimenting with dynamic pitch adjustment Change 3298987 on 2017/02/13 by Max.Chen Editor: Add matrix and transform properties to property editor test object Change 3298997 on 2017/02/13 by Max.Chen Editor: It's now possible to specify Units and ForceUnits meta-data on struct properties - Doing so will cause any child numeric and struct properties to use these units by default (unless another unit was specified) - Added percentage unit type - Multiplier unit types can now be converted between Change 3298998 on 2017/02/13 by Max.Chen Editor: Conversion between multiplier (1.5x) and percentage (150%) units is now possible Change 3348678 on 2017/03/15 by Max.Preussner Media: Added Buffering media event Change 3355268 on 2017/03/20 by Max.Preussner Core: TQueue documentation updates Change 3359055 on 2017/03/22 by Max.Preussner Portal: Removed dependency to Messaging.h Change 3359060 on 2017/03/22 by Max.Preussner Messaging: Modernization pass - added missing includes & forward declarations - include what you use - deprecated shared pointer typedefs - replaced some delegates with callback interfaces - documentation fixes Change 3359189 on 2017/03/22 by Max.Preussner Automation: Modernization pass - include what you use - removed molothic header - documentation fixes #upgradenotes: IAutomationWorkerModule.h is now in the module's public root directory Change 3359718 on 2017/03/22 by Max.Preussner Messaging: Moved common helper classes into MessagingCommon module #upgradenotes: If you use the common helper classes, replace "Messaging" with "MessagingCommon" in your Build.cs files and remove the "Helpers/" subdirectory from your include statements (unless you actually include header files from "Messaging", in which case you need to keep "Messaging" and add "MessagingCommon"). Change 3359793 on 2017/03/23 by Max.Preussner TargetDeviceServices: Modernization pass - include what you use - removed boilerplate header - deprecated selected shared pointer typedefs - reorganized files - documentation fixes Change 3361028 on 2017/03/23 by Max.Preussner DeviceManager: Modernization pass - include what you use - reduced shared pointer typedef usage - documentation fixes Change 3361197 on 2017/03/23 by Max.Preussner Messaging: Waking up message router thread on shutdown Change 3361246 on 2017/03/23 by Max.Preussner AutomationWindow: Removed boilerplate header #upgradenotes: Replace includes of AutomationWindow.h with IAutomationWindowModule.h Change 3361428 on 2017/03/23 by Max.Preussner AutomationController: Removed boilerplate header #upgradenotes: Instead of AutomationController.h, include the individual interface headers that you actually use. Remove the "Interfaces/" subdirectory from existing interface inclusions. Change 3363206 on 2017/03/24 by Max.Preussner ProfileLauncher: Modernization pass - include what you use (selected files) - reduced shared pointer typedef usages - removed dead code - cleaned up file organization - documentation fixes Change 3363290 on 2017/03/24 by Max.Preussner LauncherServices: Removed boilerplate header #upgradenotes: Instead of including LauncherServices.h, include the ILauncherXXX.h files that you actually use. Remove the "Interfaces/" subdirectory from existing ILauncherXXX.h includes Change 3363305 on 2017/03/24 by Max.Preussner LauncherCheck: Removed boilerplate header #upgradenotes: Include ILauncherCheckModule.h instead of LauncherCheck.h. Remove "Interfaces/" subdirectory from existing ILauncherCheckModule.h inclusions Change 3363708 on 2017/03/24 by Max.Preussner ImageWrapper: Removed boilerplate header #upgradenotes: Instead of including ImageWrapper.h, include the actual IImageWrapperXXX.h files that you use. Remove the "Interfaces/" subdirectory from existing IImageWrapperXXX.h includes Change 3363966 on 2017/03/24 by Max.Preussner ImageWrapper: Modernization pass - include what you use - reorganized internal files - documentation fixes Change 3364579 on 2017/03/24 by Max.Preussner ImageWrapper: Deprecated shared pointer typedef and removed usages #upgradenotes: Please use TSharedPtr<IImageWrapper> instead of IImageWrapperPtr Change 3364582 on 2017/03/24 by Max.Preussner NetworkFileSystem: Removed monolithic boilerplate header #upgradenotes: Instead of including NetworkFileServer.h, include the INetworkFileXXX.h headers that you actually use. Remove the "Interfaces/" subdirectory from existing INetworkFileXXX.h includes Change 3381440 on 2017/04/05 by Max.Preussner Oculus: Removed illegal pragmas Change 3391731 on 2017/04/12 by Max.Preussner ImgMedia: Added support for BMP, JPG and PNG image sequences Change 3401146 on 2017/04/19 by Max.Preussner Core: Cleanup pass for FTimespan usages; updated documentation When initializing time span values from single components, consider using the FromHours, FromMinutes, FromSeconds, Zero, MinValue and related methods instead of calling the overloaded constructors as they will make your code easier to read and understand. Change 3401504 on 2017/04/20 by Max.Preussner MCP: Fixed incorrect FTimespan usage of GetMilliseconds instead of GetTotalMilliseconds Change 3401833 on 2017/04/20 by Max.Preussner Core: Various improvements to FTimespan - added proper serialization - updated documentation - access fractions as milli-, micro- or nanoseconds - removed the following string formatters as they were not useful: %D %H %M %S %F - updated documentation #upgradenotes: The %D string formatter (previously total number of days) is now the zero-padded days component of the time span. Time spans are now always exported and stringified with a leading plus or minus sign. #jira UE-43990 #jira UE-44163 Change 3437543 on 2017/05/12 by Max.Preussner PS4Media: Added audio error codes conversion Change 3446564 on 2017/05/18 by Max.Preussner Networking: Fixed nullpointer crash if socket initialization fails Change 3459978 on 2017/05/25 by Max.Preussner ImgMedia: Renamed frame cache to frame loader Change 3463311 on 2017/05/26 by Max.Preussner Core: Added iterators & predicate based methods to LRU Cache Change 3464452 on 2017/05/29 by Max.Preussner ImgMedia: Added video sample output Change 3464468 on 2017/05/29 by Max.Preussner Media: Added separate cache visualization for loaded and cached samples Change 3464592 on 2017/05/29 by Max.Preussner Core: Added TLruCache::FindAndTouch Change 3464607 on 2017/05/29 by Max.Preussner Core: Added TRange::Inclusive / ::Exclusive Change 3464608 on 2017/05/29 by Max.Preussner Media: Fixed incorrect upper bound in support play rates of various players Change 3466732 on 2017/05/30 by Max.Preussner ImgMedia: Added image compression type to info string Change 3466871 on 2017/05/31 by Max.Preussner WmfMedia: Fixed session capabilities not showing up; added initialization logging Change 3467785 on 2017/05/31 by Max.Preussner MfMedia: Fixed sample stride calculated from media input instead of output Change 3467963 on 2017/05/31 by Max.Preussner WmfMedia: Reordered media sub-type string conversion to fix some tracks being reported incorrectly Change 3468110 on 2017/05/31 by Max.Preussner WmfMedia: Added MPEG-2 media sub types to utils Change 3468516 on 2017/05/31 by Max.Preussner AndroidMedia: Allow mediaplayer audio to be disable on Android (UE-45570) Change 3468554 on 2017/05/31 by Max.Preussner MediaAssets: Added AutoClear option to automatically clear media texture when media is unloaded Change 3468627 on 2017/05/31 by Max.Preussner ImgMedia: Allowing for auto-selection of EXR decoder thread count Change 3468648 on 2017/05/31 by Max.Preussner ImgMedia: Reorganized OpenExrWrapper files Change 3471789 on 2017/06/02 by Max.Preussner WmfMedia: Fixed potential concurrency issue in session state management Change 3472918 on 2017/06/03 by Max.Preussner Core: Allowing zero sized LRU cache; added default constructor Change 3472919 on 2017/06/03 by Max.Preussner Media: Added pre-Slate tick stage; renamed some functions; continued to implement sample caching Change 3473704 on 2017/06/05 by Max.Preussner AndroidMedia: Added settings class Change 3474407 on 2017/06/05 by Max.Preussner AndroidMedia: Implemented video sample processing Change 3474934 on 2017/06/05 by Max.Preussner ImgMedia: Fixed crash due to deleting loader work items twice (UE-45705) #jira UE-45705 Change 3476925 on 2017/06/06 by Max.Preussner Media: Added return values to media view interface; documentation fixes Change 3477158 on 2017/06/06 by Max.Preussner SwitchMedia: Implemented sample pooling Change 3477201 on 2017/06/07 by Max.Preussner PS4Media: Implemented video sample pooling Change 3481470 on 2017/06/08 by Max.Preussner Media: Fixed time stamps not set in recycled texture samples Change 3481472 on 2017/06/08 by Max.Preussner MediaAssets: Fixed no video samples fetched while player is in buffering state Change 3481473 on 2017/06/08 by Max.Preussner MediaUtils: Added default constructor to MediaSampleQueue Change 3481584 on 2017/06/08 by Max.Preussner MediaUtils: Paused state is considered forward for sample lookup as this is the common case. Change 3481588 on 2017/06/08 by Max.Preussner PS4Media: Redesigned the PS4 media player to support async file loading & track switching Change 3481627 on 2017/06/08 by Max.Preussner PS4Media: Opening media sources in thread pool if not precaching Change 3481666 on 2017/06/08 by Max.Preussner ImgMedia: Fixed SequencePath property file picker always opening default path Change 3481669 on 2017/06/08 by Max.Preussner ImgMedia: Fixed crash when quering cache state of empty image sequence Change 3481685 on 2017/06/08 by Max.Preussner ImgMedia: Fixed EXR reader failing to play slow loading sequences (UE-45719) #jira UE-45719 Change 3483623 on 2017/06/10 by Max.Preussner Media: Added getters for 360 view settings; added support for relative view updates Change 3483624 on 2017/06/10 by Max.Preussner Media: Added Blueprint support for 360 videos Change 3483626 on 2017/06/10 by Max.Preussner MediaPlayerEditor: Added 360 video mouse controls; broke out viewport widget into separate class. Change 3483627 on 2017/06/10 by Max.Preussner Core: Using system start time instead of current time for renamed log file names Change 3483630 on 2017/06/10 by Max.Preussner Core: Grouping log files by log name and processing each group separately when deleting old log files Change 3483816 on 2017/06/10 by Max.Preussner WmfMedia: Detecting audio device availability to prevent lockup of audio tracks Change 3483939 on 2017/06/11 by Max.Preussner AvfMedia: Finished Media Framework 3.0 upgrade - overhauled track switching - removed render thread flushes - reduced nesting - code cleanup pass Change 3483940 on 2017/06/11 by Max.Preussner Media: Consistent track switching behavior across platforms Change 3484172 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Removed obsolete asset type actions Change 3484180 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Fixed media player info overlays not visible during mouse capture Change 3484248 on 2017/06/11 by Max.Preussner MediaAssets: Media players now always have a playlist Change 3484249 on 2017/06/11 by Max.Preussner MediaPlayerEditor: Added UI controls to Playlist tab Change 3484250 on 2017/06/11 by Max.Preussner Media: Implemented overlay sample caching Change 3484252 on 2017/06/11 by Max.Preussner WmfMedia: Enabled support for .smi and .sami subtitle files Change 3485433 on 2017/06/12 by Max.Preussner ImgMedia: Enabled plug-in on all platforms; enabled EXR only on platforms that support it Change 3485720 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Added ability to save playlists Change 3485828 on 2017/06/12 by Max.Preussner AvfMedia: Thread-safe ticking of video sampler; ticking audio processing on high frequency thread Change 3485926 on 2017/06/12 by Max.Preussner MediaUtils: Draining all unconsumed samples at the end of a frame Change 3486043 on 2017/06/12 by Max.Preussner Media: Consistent behavior for playlist navigation (UE-45964) #jira UE-45964 Change 3486104 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Implemented simple overlay text positioning Change 3486145 on 2017/06/12 by Max.Preussner AndroidMediaPlayer: Moved video sample handling into render thread Change 3486147 on 2017/06/12 by Max.Preussner MediaPlayerEditor: Moved overlay texts into separate layer Change 3486188 on 2017/06/12 by Max.Preussner Media: Enabling media factory modules in Editor for all players Change 3486223 on 2017/06/12 by Max.Preussner Media: Defaulting players to select first audio and video tracks by default Change 3486473 on 2017/06/13 by Max.Preussner Media: Buffering is no longer a media player state, but handled separately (for players that can buffer while playing) Change 3486475 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing busy bar when buffering or preparing Change 3487237 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed video sample not getting processed on render thread Change 3487507 on 2017/06/13 by Michael.Trepka AvfMedia - small cleanup of the code for passing video frame rate to the video sampler Change 3487719 on 2017/06/13 by Michael.Trepka Disable shared PCH in OpenExrWrapper to solve a problem with bUseRTTI mismatch between the module and the PCH Change 3487842 on 2017/06/13 by Max.Preussner AndroidMedia: Fixed texture swizzle disabled on non-Engine builds Change 3488006 on 2017/06/13 by Michael.Trepka AvfMedia - Moved some logic from FAvfMediaPlayer::TickTickable() to FAvfMediaTracks::ProcessAudio() to make it thread safe, plus fixed a bug with the player not setting the current status to Stopped after opening a file Change 3488308 on 2017/06/13 by Chris.Babcock AndroidMedia: Fixed flicker issue #jira UE-45736 Change 3488335 on 2017/06/13 by Max.Preussner MediaAssets: Made UFileMediaSource::GetFullPath public Change 3488338 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Fixed "Show file in Explorer" not working for file media sources Change 3488339 on 2017/06/13 by Max.Preussner MediaPlayerEditor: Showing a throbber when buffering player Change 3488768 on 2017/06/14 by Max.Preussner Core: Inlined FTimespan static functions hange 3490203 on 2017/06/14 by Max.Preussner Core: Force inlined TComPtr operators Change 3494083 on 2017/06/15 by Chris.Babcock AndroidMedia: Fix playlist looping (send PlaybackEndReached event) #jira UE-46086 Change 3497017 on 2017/06/16 by Max.Preussner MediaAssets: Playlists now auto advance with PlayOnOpen off Change 3497075 on 2017/06/17 by Chris.Babcock MediaPlayer Sampler node and external texture support for Android MediaPlayer - enable with USE_EXTERNALTEXTURE in AndroidMediaPlayer.cpp (disabled in this CL) - supports MediaSample node in material editor with scale/bias handled if above flag enabled - fixed looping problems, including eventual crashes - track switching fixed (lockups and missing video) - corrected resource leaks and crash switching maps #jira UE-46055 #jira UE-45744 #jira UE-46086 Change 3497163 on 2017/06/17 by Max.Preussner MediaUtils: Processing media events immediately if on game thread Change 3497170 on 2017/06/17 by Max.Preussner Media: All Media Framework interfaces are pure virtual Change 3498603 on 2017/06/19 by Ben.Marsh UBT: Prevent plugins which list modules multiple times from adding them twice. Change 3500870 on 2017/06/20 by Max.Preussner WmfMedia: Rewrote WMF state machine; now with track switching #jira UE-20209 #jira UE-35385 #jira UE-38337 #jira UE-45676 Change 3502181 on 2017/06/20 by Chris.Babcock MediaSampler node updates - fixed issue with ExternalTexture singleton for DLL compatiblity - now works for all players (registers texture samples with ExternalTexture by player GUID) - enabled OES in AndroidMediaPlayer now that materials can universally use the MediaSampler Change 3503182 on 2017/06/21 by Max.Preussner Media: Refactored status flags into an enum; exposed connecting status Change 3503724 on 2017/06/21 by Chris.Babcock Improvement in MediaPlayer Sampler node - RGB, R, G, B, A output pins like normal texture sampler - allow preview in material editor - fix OES detection for Android Change 3509088 on 2017/06/26 by Max.Preussner MediaAssets: Added AddFile and AddUrl to UMediaPlaylist Change 3510256 on 2017/06/26 by Max.Preussner WmfMedia: Fixed play rate not set to zero when end reached Change 3510273 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Removed obsolete Slate culling rectangle code Change 3510413 on 2017/06/26 by Max.Preussner MediaPlayerEditor: Showing frame rate if available Change 3510533 on 2017/06/26 by Max.Preussner MediaUtils: Preventing media cache filling up when scrubbing Change 3510859 on 2017/06/26 by Max.Preussner PS4Media: Fixed track switching crashes (UE-45960) #jira UE-45960 Change 3514173 on 2017/06/28 by Max.Preussner WmfMedia: Optimized player capabilities check Change 3514174 on 2017/06/28 by Max.Preussner WmfMedia: Moved media source resolver code into utility class Change 3514714 on 2017/06/28 by Max.Preussner Core: Added TComPointer.IsValid; code cleanup pass Change 3517912 on 2017/06/30 by Max.Preussner MediaUtils: Added GetVideoAspectRatio to player facade Change 3524957 on 2017/07/06 by Max.Preussner ImgMedia: Decoding image frames only when video track is selected Change 3525252 on 2017/07/06 by Max.Preussner ImgMedia: Async image sequence initialization Change 3525266 on 2017/07/06 by Max.Preussner ImgMedia: Enabled reverse playback Change 3525722 on 2017/07/06 by Max.Preussner WmfMedia: Workaround for occasional WMF internal deadlock in IMFRateSupport Change 3525800 on 2017/07/07 by Max.Preussner WmfMedia: Fixed another WMF deadlock issue & some rate change glitches; improved logging. Change 3525801 on 2017/07/07 by Max.Preussner MediaPlayerEditor: Made scrubbing more responsive Change 3526500 on 2017/07/07 by Max.Preussner WmfMedia: Using NULL for Windows pointers Change 3527323 on 2017/07/07 by Max.Preussner WmfMedia: Added support for audio and video capture media sources Change 3530197 on 2017/07/10 by Max.Preussner WmfMedia: Added utility functions for enumerating audio and video capture devices Change 3533465 on 2017/07/12 by Max.Preussner Media: Added media capture device support API & implementation for WMF Change 3533469 on 2017/07/12 by Max.Preussner MediaPlayerEditor: Added source selection menu w/ capture device menu to navigation bar Change 3533540 on 2017/07/12 by Max.Preussner MediaAssets: Blueprint support for media capture device discovery Change 3533574 on 2017/07/12 by Max.Preussner WmfMedia: Using cached supported play rates; more strict pausing support check Change 3533924 on 2017/07/12 by Max.Preussner WmfMedia: Added global LowLatency setting (UEVR-859) Note that this setting is only supported when compiling for Windows 8 or newer. Change 3534027 on 2017/07/12 by Max.Preussner WmfMedia: Compile time support for low latency session attribute on < Windows8 #jira UEVR-859 Change 3538744 on 2017/07/14 by Max.Preussner MediaUtils: Renamed FDefaultMediaTimeSource to FAppMediaTimeSource Change 3542818 on 2017/07/18 by Max.Preussner WmfMedia: Fixed race condition on session shutdown Change 3543082 on 2017/07/18 by Max.Preussner WmfMedia: Fixed track selection in media that doesn't support seeking Change 3543092 on 2017/07/18 by Max.Preussner Media: Implemented media track format API Enables multiple formats per media track. By default, the first usable format is selected. This feature is currently only implemented for WmfMedia. All other players assume a single format per track. Change 3543794 on 2017/07/19 by Max.Preussner WmfMedia: Added string conversion for null GUIDs Change 3543796 on 2017/07/19 by Max.Preussner MfMedia: Copied GUID string conversion updates from WmfMedia Change 3543797 on 2017/07/19 by Max.Preussner WmfMedia: Preventing duplicate track formats in capture devices with legacy DirectX support Change 3544390 on 2017/07/19 by Max.Preussner Media: Allowing INDEX_NONE as 'current selection' index in track format related functions Change 3545368 on 2017/07/19 by Max.Preussner WmfMedia: Fixed session error with some media sources when attempting to seek to current position without ever starting Change 3545388 on 2017/07/19 by Max.Preussner MediaAssets: Fixed RGB input sources rendered upside down Change 3545430 on 2017/07/19 by Max.Preussner MediaAssets: Fixed incorrect sRGB conversion on BMP inputs Change 3547362 on 2017/07/20 by Max.Preussner Core: Added IsGraph and IsPrint to TCHAR utilities Change 3547376 on 2017/07/20 by Max.Preussner WmfMedia: Better log messages for non-standard video types (UE-47533) #jira UE-47533 Change 3547404 on 2017/07/20 by Max.Preussner QAGame: Enabled PlayOnOpen and Looping on MediaPlayerSwitch BP (UE-47542) #jira UE-47542 Change 3547466 on 2017/07/20 by Max.Preussner WmfMedia: Fixed edge case for detecting whether pause is available Change 3548742 on 2017/07/21 by Max.Preussner Media: Added API for changing the input frame rate Change 3548743 on 2017/07/21 by Max.Preussner WmfMedia: Implemented ability to change input frame rate Change 3554411 on 2017/07/25 by Max.Preussner AudioMixer: Broke out SynthComponent initialization code; added bIsUISound property Change 3554818 on 2017/07/25 by Max.Preussner Media: Added per track-type cache queries Change 3557284 on 2017/07/26 by Max.Preussner WmfMedia: Added buffer size check in texture sample as well Change 3560530 on 2017/07/27 by Max.Preussner WmfMedia: Made COM object destructors private and added assertions Change 3560580 on 2017/07/27 by Max.Preussner MediaUtils: Added method for querying number of objects in pool Change 3562572 on 2017/07/28 by Max.Preussner WmfMedia: Properly handling topology status errors when opening media Change 3576710 on 2017/08/08 by Chris.Babcock bug fixes for mediaplayer - rare cases in Android media tracks - make FMediaCaptureDevice members available in blueprints Change 3577736 on 2017/08/08 by Chris.Babcock Extend ExternalTexture to support 2x3 transform (scale/rotation + offset) Change 3578831 on 2017/08/09 by Max.Preussner MediaAssets: Made media sound component BP spawnable Change 3579210 on 2017/08/09 by Max.Preussner UdpMessaging: Not showing warning message if tunnel settings left empty to use defaults Change 3579547 on 2017/08/09 by Chris.Babcock Better support for Android external texture detection Change 3579567 on 2017/08/09 by Chris.Babcock Android camera plugin #jira UEMOB-215 Change 3580035 on 2017/08/10 by Andrew.Rodham Media Texture: External textures are now fully supported and enforced when attempting to sample external texture types in materials. - Textures can now dynamically provide an external texture GUID at runtime, which is queried by the uniform expression. Statically defined GUIDs remain supported. - Added necessary ExternalTexture(Parameter) methods to the material compiler and HLSL translator - Made UTexture::GetMaterialType const-correct #tests Test map that contains TextureObject, TextureObjectParameter, TextureSample and TextureSampleParameter nodes with media textures works on both a Nexus 10 (non-image-external), and a Pixel (image-external), and on desktop PC. Change 3581552 on 2017/08/10 by Chris.Babcock Use bilinear sampling instead of point for external texture (Android media and camera) Change 3581628 on 2017/08/10 by Max.Preussner Core: Fixed FTimespan import/export/copypaste (UE-43990) #jira UE-43990 #jira UE-44163 Change 3581909 on 2017/08/11 by Andrew.Rodham Media: Only cache material proxy pointers if they have been initialized (and thus, will be removed from the cache on release) - This prevents destroyed proxies from remaining in the texture registry #jira UE-48307 Change 3582451 on 2017/08/11 by Max.Preussner AudioMixer: Fixed initialization order of synth components This ensures that the Synth is initialized before OnRegister in the super class initializes and activates the AudioComponents. Previously, the AudioComponent would fail to activate, because Synth was nullptr. #jira UE-48055 Change 3582453 on 2017/08/11 by Max.Preussner MediaAssets: Enabling ticking in media sound component (UE-48055) #jira UE-48055 Change 3583101 on 2017/08/11 by Chris.Babcock Android camera improvements - return correct capture device type (webcamfront/rear) - remove seek (not supported) - support track formats - better framerate selection Change 3590109 on 2017/08/16 by Chris.Babcock Move external texture coordinate update to improve accuracy and save a uniform in final shader Change 3590530 on 2017/08/16 by Max.Preussner MediaAssets: Changed capture device enumeration BP function signatures to allow filter bit masks #jira UE-48166 Change 3590547 on 2017/08/16 by Max.Preussner MediaPlayerEditor: Ticking sound component directly Change 3590628 on 2017/08/16 by Max.Preussner Switch: Fixed media decoder asserting when attempting to pause without having started Change 3591816 on 2017/08/16 by Aaron.McLeran #jira UE-48470 Disabling async processing for procedural sound waves on mac. Change 3592266 on 2017/08/16 by Max.Preussner Media: Replaced media cache with the new sample processing pipeline; continued to implement MfMedia This change fixes stuttering issues with audio and video. However, proper pipeline flushing is not fully implemented yet, so the playback will break after the first playthrough, which might result in freeze frames or out of memory assertions depending on the platform. This will be addressed in an upcoming change. #jira UE-48474 #jira UE-45677 Change 3592355 on 2017/08/17 by Max.Preussner MediaUtils: Added sample sink collection to remove code duplication Change 3592739 on 2017/08/17 by Max.Preussner ImgMedia: Fetching only one video sample per frame Change 3592741 on 2017/08/17 by Max.Preussner MediaUtils: Better sample fetching when paused Change 3592761 on 2017/08/17 by Max.Preussner MediaUtils: Fixed overflow detection in sample sinks Change 3592762 on 2017/08/17 by Max.Preussner ImgMedia: Sending end reached event when looping Change 3592885 on 2017/08/17 by Max.Preussner ImgMedia: Fixed reverse play Change 3592887 on 2017/08/17 by Max.Preussner MediaUtils: Better sample range calculation for audio samples Change 3593010 on 2017/08/17 by Max.Preussner ImgMedia: Fixed async loading of non-EXR image sequences Change 3593193 on 2017/08/17 by Max.Preussner AndroidMedia: Fixed typo Change 3593230 on 2017/08/17 by Max.Preussner Media: Implemented flushing for player sample queues Change 3593346 on 2017/08/17 by Max.Preussner Media: Proper sample processing for reverse playback Change 3593482 on 2017/08/17 by Max.Preussner Switch: Fixed sample range check for reverse playback Change 3594428 on 2017/08/17 by Max.Preussner PS4Media: Fixed video not playing/crashing #jira UE-48547 #jira UE-48549 Change 3595404 on 2017/08/17 by Max.Preussner MediaAssets: Not requesting audio samples if not playing #jira UE-48557 Change 3595624 on 2017/08/17 by Max.Preussner PS4Media: Fixed no looping after track switching #jira UE-46524 #jira UE-48557 Change 3595704 on 2017/08/17 by Max.Preussner MediaUtils: Improved sample queue flushing Eventually this needs to be event-driven. #jira UE-48557 Change 3595706 on 2017/08/17 by Max.Preussner PS4Media: Flushing queues when track switching #jira UE-48557 Change 3595909 on 2017/08/17 by Max.Preussner Matinee: Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) https://github.com/EpicGames/UnrealEngine/pull/3382 #jira UE-42906 #rn Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382) Change 3597480 on 2017/08/18 by Max.Preussner ImgMediaPlayer: Fixed presentation time calculation for very large delta times Change 3597669 on 2017/08/18 by Max.Preussner ImgMedia: Setting player stopped instead of paused when end reached Change 3597709 on 2017/08/18 by Max.Preussner SwitchMedia: Fixed audio sample duration calculation Change 3598479 on 2017/08/18 by Max.Preussner ImgMedia: Ensuring that first/last frame is played when starting playback forward/reverse; improved state checking; user logging Change 3598629 on 2017/08/18 by Max.Preussner MediaUtils: Properly handling pending flushes when peeking sample queues Change 3598633 on 2017/08/18 by Max.Preussner WmfMedia: Fixed occasional WMF deadlock when scrubbing Change 3598653 on 2017/08/18 by Max.Preussner MediaUtils: Fixed audio resampling in reverse playback Change 3598659 on 2017/08/18 by Max.Preussner MediaPlayerEditor: Creating sound output only if audio device available Change 3598688 on 2017/08/18 by Max.Preussner MediaUtils: Flushing sample queues on direction change regardless of paused state Change 3599444 on 2017/08/20 by Max.Preussner WmfMedia: Added missing check for rate control when quering supported rates Change 3603661 on 2017/08/22 by Max.Preussner WmfMedia: Fixed NV12 output Change 3604345 on 2017/08/23 by Max.Preussner MediaUtils: Added subtitle samples to media sample collection; fixed documentation Change 3604987 on 2017/08/23 by Max.Preussner PS4Media: Setting correct track format types Change 3605117 on 2017/08/23 by Joe.Barnes Fix issue where presentation time was being treated as milliseconds instead of microseconds. Change 3605128 on 2017/08/23 by Joe.Barnes Fix potential issue calculating total (looped) play time after seek or reset. Track last video presentation time Change 3605139 on 2017/08/23 by Joe.Barnes Support audio type DType_Setup. Fix issue with procedural sounds popping. Consume more samples if necessary. #jira ue-48544 Change 3605197 on 2017/08/23 by Max.Preussner Media: Fixed track display name formatting (UE-48767) #jira UE-48767 Change 3605817 on 2017/08/23 by Max.Chen Auto set sampler type on drop on actor. #jira UE-48769 Change 3605999 on 2017/08/23 by Max.Preussner MfMedia: Restarting source reader when switching tracks #jira UE-48766 Change 3606416 on 2017/08/23 by Max.Preussner PS4Media: Various player improvements #jira UE-48586 Change 3607656 on 2017/08/24 by Max.Preussner WmfMedia: Improved logging for Seek and SetRate Change 3607855 on 2017/08/24 by Max.Preussner MfMedia: Better verbose logging; validating seeks; reduced nesting; fixed track switching\ #jira UE-48766 Change 3608029 on 2017/08/24 by Max.Preussner PS4Media: Fixed streaming media not playing; improved result checks & logging #jira UE-48610 Change 3608473 on 2017/08/24 by Max.Preussner MfMedia: Fixed audio sample duration calculation #jira UE-48756 Change 3609316 on 2017/08/24 by Chris.Babcock Provide external texture RotationScale and Offset from sample Change 3610067 on 2017/08/25 by Richard.Wallis Mac: Editor locks up when Track switching and Mac: Media Audio continues to play after closing player. - Fix for creating extra OS AV media playback objects so audio playback not stopping due to over retained objects. - Trying to access OS AV Media Playback object (esp. the currentTime value) across mutliple threads at once seems to cause deadlock in the Apple libraries - moved location of currentTime acess point to Media Ticker - this sets the current time and is then just returned in the getter when on game main. - Trying to playback audio via OS media playback and through the engine at the same time when enabling the selected audio track. Engine version via sample buffers via AVAssetReaderTrackOutput doesn't seem to be working as intended with the new audio frame work audio sinks - so reverting to OS AV media playback for Mac at the moment until better fix for this can be put in. #jira UE-48590, UE-48604 Change 3610267 on 2017/08/25 by Max.Preussner PS4Media: Added missing track selection validation #jira UE-48765 Change 3610399 on 2017/08/25 by Max.Preussner PS4Media: Fixed infinite player re-initialization loop if track selection failed Change 3610809 on 2017/08/25 by Chris.Babcock Fixes for Android media player and camera player - buffer samples copy proper bytecount - realloc sets new buffer ptr - refcount of Java buffers fixed Change 3610953 on 2017/08/25 by Chris.Babcock Fix audio disable before play on Android media player Change 3611405 on 2017/08/25 by Max.Preussner WmfMedia: Resetting supported rates if RateSupport unavailable Change 3611406 on 2017/08/25 by Max.Preussner MfMedia: Resetting supported rates if RateSupport unavailable Change 3611453 on 2017/08/25 by Chris.Babcock Android external texture extension updates for compatibility Change 3611719 on 2017/08/26 by Max.Preussner Media: Added media event for completed seek operations; flushing sinks on seek Change 3611764 on 2017/08/26 by Max.Preussner AvfMedia: Setting player to preparing state prior to initializing tracks asynchronously Change 3611802 on 2017/08/26 by Max.Preussner Media: Exposed error state in media player Change 3611803 on 2017/08/26 by Max.Preussner MediaPlayerEditor: Showing error state in UI Change 3611887 on 2017/08/26 by Max.Preussner MediaUtils: Corrected media sample sink overflow check Change 3611892 on 2017/08/27 by Max.Preussner WmfMedia: Leaving session in error state after error Change 3611929 on 2017/08/27 by Max.Preussner MediaPlayerEditor: Fixed sound stopping on looping Change 3611930 on 2017/08/27 by Max.Preussner MfMedia: Rewrote async sample processing to fix various playback issues Change 3611942 on 2017/08/27 by Max.Preussner Media: Sending suspension event when playback ended Change 3611957 on 2017/08/27 by Max.Preussner UnrealEd: Allowed transient assets to be resaved to disk Change 3611981 on 2017/08/27 by Max.Preussner PS4Media: Rewrote sample processing to fix various playback issues #jira UE-48596 #jira UE-48793 Change 3612035 on 2017/08/27 by Max.Preussner UnrealEd: Picking standard default names when resaving transient packages Change 3612045 on 2017/08/27 by Max.Preussner Media: Fixed playlists not getting saved correctly from Editor (UE-35382) #jira UE-35382 Change 3612212 on 2017/08/28 by Richard.Wallis Fix for Multitrack Video samples continue to Play on Open after Play on Open is toggled off. Current Rate was not getting reset back to 0.0 on media close. #jira UE-47602 Change 3613531 on 2017/08/28 by Max.Preussner MediaAssets: Fixed external texture related crash on shutdown (UE-48918) Also no longer creating clock sink for media player CDO #jira UE-48918 Change 3613677 on 2017/08/28 by Andrew.Porter Fixed crash at exit in Mac editor caused by double release of AVPlayerItem object #jira UE-48937 Change 3615917 on 2017/08/29 by Max.Preussner MfMedia: Added compile options for DXVA and falling back to synchronous sample reading [CL 3617655 by Max Chen in Main branch]
2017-08-30 09:37:09 -04:00
void FMessageRouter::HandleRouteMessage(TSharedRef<IMessageContext, ESPMode::ThreadSafe> Context)
{
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UE_LOG(LogMessaging, Verbose, TEXT("Routing %s message from %s"), *Context->GetMessageTypePathName().ToString(), *Context->GetSender().ToString());
Tracer->TraceRoutedMessage(Context);
// intercept routing
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
auto& Interceptors = ActiveInterceptors.FindOrAdd(Context->GetMessageTypePathName());
for (auto& Interceptor : Interceptors)
{
if (Interceptor->InterceptMessage(Context))
{
UE_LOG(LogMessaging, Verbose, TEXT("Message was intercepted by %s"), *Interceptor->GetDebugName().ToString());
Tracer->TraceInterceptedMessage(Context, Interceptor.ToSharedRef());
return;
}
}
// dispatch the message
if (bAllowDelayedMessaging && (Context->GetTimeSent() > CurrentTime))
{
UE_LOG(LogMessaging, Verbose, TEXT("Queued message for dispatch"));
DelayedMessages.HeapPush(FDelayedMessage(Context, ++DelayedMessagesSequence));
}
else
{
DispatchMessage(Context);
}
}
void FMessageRouter::HandleAddListener(TWeakPtr<IBusListener, ESPMode::ThreadSafe> ListenerPtr)
{
ActiveRegistrationListeners.AddUnique(ListenerPtr);
}
void FMessageRouter::HandleRemoveListener(TWeakPtr<IBusListener, ESPMode::ThreadSafe> ListenerPtr)
{
ActiveRegistrationListeners.Remove(ListenerPtr);
}
void FMessageRouter::NotifyRegistration(const FMessageAddress& Address, EMessageBusNotification Notification)
{
for (auto It = ActiveRegistrationListeners.CreateIterator(); It; ++It)
{
auto Listener = It->Pin();
if (Listener.IsValid())
{
ENamedThreads::Type ListenerThread = Listener->GetListenerThread();
if (ListenerThread == ENamedThreads::AnyThread)
{
Listener->NotifyRegistration(Address, Notification);
}
else
{
TGraphTask<FBusNotificationDispatchTask>::CreateTask().ConstructAndDispatchWhenReady(ListenerThread, Listener, Address, Notification);
}
}
else
{
It.RemoveCurrent();
}
}
}