Files
UnrealEngineUWP/Engine/Source/Runtime/GameplayTasks/Private/Tasks/GameplayTask_ClaimResource.cpp

59 lines
2.1 KiB
C++
Raw Normal View History

// Copyright Epic Games, Inc. All Rights Reserved.
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3028454) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3028439 on 2016/06/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 28 @ CL 3028090 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3028437 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3027952 on 2016/06/26 by Jurre.deBaare - Integrating code fixes/changes from Simplygon for Normals issue on Simplygon Swarm + landscape culling - Readded landscape/volume culling for in-engine static mesh merging path - Fixed issue with r.HLOD force -1 (now stops forcing hlods) - Marked hlodcullingvolume as experimental - Added Landscape culling flag + precision level #codereview Michael.Noland #rb Michael.Noland #tests build clusters locally/cloud + landscape culling tests Change 3027702 on 2016/06/25 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3027698 #RB:none #Tests:none Change 3027312 on 2016/06/24 by Daniel.Lamb Changed the way reentry data is stored in the cooker, reduce work load by main thread, also fix issue with reentry data being used from incorrect packages. #rb Peter.Sauerbrei #test QA game launch on and cook by the book + cook on the fly paragon Change 3027165 on 2016/06/24 by Daniel.Lamb Fix compiler warnings from cvars changes. #rb none #test cook paragon Change 3026900 on 2016/06/24 by Daniel.Lamb Change the way low quality lightmap shaders are enabled / disabled as the engine can't be used in the should cache function. #rb Marcus.Wasmer #test Cook on the fly paragon #codereview Rolando.Caloca Change 3026874 on 2016/06/24 by Olaf.Piesche #jira OR-18363 fix distortion in particle macro UVs with camera movement #rb frank.fella #tests PC Editor/Game Change 3026494 on 2016/06/24 by jason.bestimt #ORION_MAIN - Merge 28 @ CL 3026460 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3026476 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3026381 on 2016/06/24 by Graeme.Thornton Strip particle modules, emitters and lodlevels from cooked server data. Saves ~10mb of runtime memory on Paragon #rb simon.tovey #codereview dmitry.rekman #tests pc cooked client/server, golden path Change 3025760 on 2016/06/23 by jason.bestimt #ORION_MAIN - Merge 28 @ CL 3025687 #RB:none #tests:none #ROBOMERGE-SOURCE: CL 3025709 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Sword/Meshes/sword.uasset - can't integrate exclusive file already opened //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Sword/Meshes/sword_Skeleton.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3025661 on 2016/06/23 by Mieszko.Zielinski Added a feature to PathfollowingComponent allowing it to identify when it starts following a navigation link #UE4 #rb Lukasz.Furman #test golden path Change 3025359 on 2016/06/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani #online,externalui,ps4 - expose access to reset cookies before invoking embedded web browser - fixed not capturing resulting Url when PS4 browser is closed #rb none #tests ps4 #ROBOMERGE-SOURCE: CL 3025356 in //Orion/Release-28/... via CL 3025358 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3025184 on 2016/06/23 by Lina.Halper Fix crash with morphtargets #jira: OR-24257 #rb: Rolando.Caloca #tests: switching mesh with different morphtargets in editor Change 3024714 on 2016/06/23 by Lukasz.Furman added vlog extension to visual debugger tool, added object whitelist to vlog to include selected minion data in games started with -LogBotGame param #rb Mieszko.Zielinski #tests server game with and without LogBotGame cmdline Change 3024709 on 2016/06/23 by Daniel.Lamb Added support for async save when saving seperate bulk data file. Added mb saved to cooking package stats. #rb Andrew.Grant,Wes.Hunt #test Cook Paragon Change 3024674 on 2016/06/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani Merging //Orion/Release-28 to Main (//Orion/Main) #online,identity,ps4 - add psplus flag to online account after privilege check #rb none #tests ps4 login flow #ROBOMERGE-SOURCE: CL 3024672 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3024510 on 2016/06/23 by Graeme.Thornton Added more info to the dumpparticlesystems exec command output #rb simon.tovey #tests cooked pc client, golden path Change 3024504 on 2016/06/23 by Graeme.Thornton Asset registry memory optimisation - make sure all dependency node link arrays are sized exactly as they need to be (saves ~1mb) #rb robert.manuszewski #tests windows cooked client, golden path Change 3024213 on 2016/06/22 by Ryan.Gerleve Handle a rare case in replays where the spectator controller is null but we still find a valid NetGUID for it. Added an ensure before a check that would fail in this case so we'll know if it happens again. #tests replays #rb john.pollard Change 3024127 on 2016/06/22 by John.Pollard Bulk merge using Dev-Networking_->_Dev-General_(Orion) 3002989 Add ability to skip missing/changed properties in FFastArraySerializer 3003072 Fix crash related to new replay backwards compatibility changes 3008097 Renaming CompatibleReplayout to NetFieldExportGroup preparing to unify ability to use FNetFieldExportGroup for both RepLayout and FClassNetCache 3009684 Added ability to use FNetFieldExportGroups for FClassNetCache as well as FRepLayout * Adds ability to track missing/changed custom delta properties names * Adds ability to track missing/changed RPC's 3013455 Add ability to skip over RPC parameters that have changes/missing in replays for backwards compatibility * We now mark FClassNetCache properties as bIncompatible so we don't spam forever when they are out of date * No longer factor in parameters when building checksum for RPC's * Save FNetFieldExport handle for FClassNetCache fields * Use WriteIntWrapped when saving FClassNetCache fields FNetFieldExport handles (and use NetFieldExportGroup->NetFieldExports.Num() to determine max value) * Lots of cleanup and sanity checking improvements 3018078 Optimize replay checkpoints * Share work that was already done during normal replication, and re-use this data to remove the need to compare any checkpoint properties * When saving a checkpoint, we no longer create a new connection and new channels, instead we re-use the existing channels, and added the ability to make this a transient operation * To make custom delta serialize properties work, we compare against the CDO state instead of current state when saving out a checkpoint 3021196 Fix issue with Fast tarray exporting package map info during checkpoints * Add ability to save and restore package map ack status * Save package map ack status before saving checkpoint, and then restore it back afterwards, this will then allow the stream that writes afterward to re-export anything that was new in the checkpoint * No longer queue up reliable bunches on ack list for internal ack connections 3024033 Prune the cached change list before using when saving out checkpoints * Fixes issues when saving checkpoint, and the live properties change array size, which throws everything off when it comes time to use the LifetimeChangelist 3024034 Don't close channels when saving checkpoints, fixes issue where it creates a bunch with bOpen/bClose (because we're forcing all SendBunches to re-open channels), which throws off the stream #rb RyanG #tests Replays Change 3024021 on 2016/06/22 by Dmitry.Rekman Fix PS4 build. #rb Michael.Noland #tests none #codereview Michael.Noland, Dan.Youhon, Sammy.James Change 3023734 on 2016/06/22 by Lukasz.Furman added replication for input events and tool state for both gameplay debugger categories and extensions #ue4 #rb Mieszko.Zielinski #tests PIE, server game Change 3023708 on 2016/06/22 by Dmitry.Rekman Add a separate macro for a poison malloc proxy usage. #rb Michael.Noland #codereview Michael.Noland, Gil.Gribb #tests Compiled OrionServer-Linux-Debug, ran it Change 3023670 on 2016/06/22 by Nick.Darnell Home screen - Fixing safezones on the homescreen. Adding a scale option to the XP_Fill widget. Adding better animations to the tiles. Showing subtitles again. Hero XP summary widget now takes you to that hero. #rb none #tests PIE Change 3023632 on 2016/06/22 by Dmitry.Rekman Fix incorrect matching condition in comments. #rb none #tests Compiled OrionServer-Linux-Debug #codereview Michael.Noland Change 3023475 on 2016/06/22 by Rolando.Caloca O - Back out changelist 3022847 as it broke SSS on PC #rb none #tests re-run editor on PC Change 3023178 on 2016/06/22 by Michael.Noland Engine: Added system memory and % of time spent hitching to analytics #rb bob.tellez #tests Tested a match in Paragon Change 3022963 on 2016/06/22 by Mieszko.Zielinski Fixed a subtle navigation repathing bug #UE4 While repathing to a location, rather than an actor, the navigation query used path's end while it should be using the original query's EndLocation. #rb Lukasz.Furman #test golden path Change 3022865 on 2016/06/22 by David.Ratti gameplay cue editor: remove "GameplayCue_" prefix from default GameplayCueNotify filename in default ability system projects #rb none #tests ability system sample project Change 3022847 on 2016/06/22 by Rolando.Caloca O - Remove checkerboard SSS rendering and recombine post process pass when SSS not enabled #rb Marcus.Wassmer #codereview Marcus.Wassmer, Brian.Karis #tests Load Agora_P, check perf, toggle r.SSS.Quality 1/0, check characters with skin Change 3022804 on 2016/06/22 by Mieszko.Zielinski Fixed AIController clearing out CachedGameplayTasksComponent on UnPosses, even if Pawn was not the CachedGameplayTasksComponent's owner #UE4 Also, made running BT not clearing info in BB if AI's current BB is compatible with the one required by BT #rb Lukasz.Furman #test golden path Change 3022674 on 2016/06/22 by Robert.Manuszewski Reimplementing CL #2993969 (Dev-Blueprints) by Maciej.Mroz: UE-30729 Crash in Native Orion when selecting Sword or Tomahawk Clear AsyncLoading in subobjects. #jira OR-23997 #rb me #tests Golden path in editor build, selecting Venus Change 3022405 on 2016/06/21 by Ryan.Gerleve Fix for OR-23948, crash with death cam enabled. Use a weak pointer to store the viewer on the DemoNetDriver and update it when the game player controller is received. #rb john.pollard #tests bug repro Change 3022387 on 2016/06/21 by Ryan.Gerleve Added the ability to disable ticking of individual worlds. #tests golden path #rb john.pollard #codereview marc.audy Change 3022312 on 2016/06/21 by Nick.Darnell Home Screen - Adding a max aspect ratio lock to SBox, may need some more fine tuning math may still be a bit pants in some cases. The XP ovewview panels now have a basic support for account and hero progression. Hero one shows the last hero you played, widget is invisibile until you play your first game. The tiles now use the Max Aspect Ratio to prevent stretching forever on 21:9 monitors causing them to just look crazy. Weekly quests now show the weekly quests screen when clicked. OrionUserWidgetBase no longer prevents blueprints from running code in reponse to mouse down/up actions if the userwidget consumes input - it always calls the blueprint code first, and always returns handled if it consumes input. #rb none #tests PIE Change 3022207 on 2016/06/21 by Wes.Hunt Fix Analytics provider to retain passed in AppVersion string instead of using default %VERSION%. #rb none #tests run windows server with one bot connecting and checking analytics version is what is expected. Change 3021808 on 2016/06/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - call GetTotalMicroseconds instead of GetTotalMilliseconds * 1000 #rb none #tests compile run ps4 #ROBOMERGE-SOURCE: CL 3021805 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3021663 on 2016/06/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - CancelFindSessions() didn't null out search result - future FindSession() calls would fail with "search in progress" #rb joe.wilcox #tests UT matchmaking #ROBOMERGE-SOURCE: CL 3021655 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3021508 on 2016/06/21 by Marcus.Wassmer Remove anti-ghosting AA for now. Causes dithered transparency to be very wrong (Dekker shoulders) And also a border around all characters of 'noisy fuzz' even when they are not moving #rb none #test PC/PS4 #codereview Brian.Karis,Jordan.Walker Change 3021475 on 2016/06/21 by Marcus.Wassmer Duplicate fix for subsurface spec in prep for PS4 optimization. (DevRendering 3018664) unified some code for easier maintainance, fixed missing multiply from former change #rb none #test PS4/PC agora Change 3021468 on 2016/06/21 by Michael.Noland Physics: Added more information when convex cooking partially succeeds (fails initially but succeeds with inflation) indicating the full path of the mesh that failed #rb ori.cohen #tests Compiled changes, will provide more information when issue reoccurs in build machine cooks #jira OR-24082 Change 3021460 on 2016/06/21 by Michael.Noland Engine: Added time spent in each hitch bucket to FPS chart .log output and analytics output #rb bob.tellez #tests Tested a match in Paragon #codereview dmitry.rekman Change 3021368 on 2016/06/21 by Marcus.Wassmer Create Tonemapper configuration with no ColorFringe to save .15ms on PS4 when colorfringe is not used. #rb rolando.caloca #test agora with/wo new config #codereview brian.karis Change 3021119 on 2016/06/21 by David.Ratti Make -notimeouts work during initial connecting phase #codereview John.Pollard #rb none #tests pie agora Change 3021048 on 2016/06/21 by David.Ratti minor tweaks to gameplay cues: -Descriptions of engine GC notify classes -Added 'auto attach to owner' flag on actor notify class. #rb none #test ability system sample project Change 3020694 on 2016/06/20 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3020301 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3020674 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #CodeReview: cody.haskell Change 3020624 on 2016/06/20 by Michael.Noland Engine: Pushing more fps chart analytics up to engine level code from Paragon Engine: Pushing benchmark config vars up to engine level code from Paragon, and added records of individual sub-steps of benchmarks #rb Bob.Tellez #tests Golden path Solo VS AI in Paragon and forced a match #codereview bob.tellez, peter.knepley Change 3020181 on 2016/06/20 by Dmitry.Rekman Re-do allowing allocations in NullRHI (OR-24029). - Originally CL 2990582 by MarcusW, stomped during merge by CL 3006926. #rb none #codereview Marcus.Wassmer, Andrew.Grant #tests none Change 3020139 on 2016/06/20 by Ryan.Gerleve Added ability to pause replay recording while keeping the current replay open. #rb john.pollard #tests paused deathcam recording while disabled Change 3019817 on 2016/06/20 by Dmitry.Rekman Poison allocated/freed memory in Debug and Development (non-editor) configs. - With this Paragon client may be more likely to crash on start. #rb Steve.Robb #codereview Robert.Manuszewski, Michael.Noland, Andrew.Grant, Gil.Gribb, Steve.Robb #tests Built Linux server and Windows client, ran them, also built Windows Orion editor. Change 3019599 on 2016/06/20 by Rolando.Caloca O - Fix flickering on heroes with morph targets #rb Marcus.Wassmer #tests Load Agora_P #jira OR-23866 Change 3019581 on 2016/06/20 by Wes.Hunt Fix crash reporter client analytics for internal builds. (Pushing critical fix immediately from //UE4/Orion-Staging) #rb Chris.Wood #tests none Change 3019524 on 2016/06/20 by David.Ratti call APawn::OnRep_Controller when ClientRetryClientRestart sets the pawn directly #rb none #tests golden path Change 3019406 on 2016/06/20 by Marcus.Wassmer Duplicate 3014956 from Dev-Rendering Fixed HLOD and mesh LODs getting hit by Lightmass ray traces that didn't originate from a mesh Volume lighting samples and precomputed visibility cells are now only placed on LOD0 (of both mesh LODs and HLOD) #rb none #test none #codereview Jordan.Walker Change 3019371 on 2016/06/20 by Graeme.Thornton Optimize cooked asset registry dependency node data structures. Saves ~10mb on Paragon. #rb robert.manuszewski #tests tested with cooked pc client + server Change 3018492 on 2016/06/17 by Laurent.Delayen FBoneReferenceCustomization: support editing properties in AnimBP defaults. #rb none #tests: Sword. Change 3017974 on 2016/06/17 by Ryan.Gerleve Add an option to toggle deathcam in the gameplay settings UI if the OrionRuntimeOption for deathcam is enabled. #rb cody.haskell #tests settings menu, enabled and disabled deathcam Change 3017913 on 2016/06/17 by Robert.Manuszewski Fixing leaked log archive. #rb Steve.Robb #tests Cooked Win64 client + server Change 3017873 on 2016/06/17 by Daniel.Lamb Fix warning in diff cooked build. #test none #rb none Change 3017676 on 2016/06/17 by Sam.Zamani #online,identity,mcp fix for uninitialized variable #rb dmitry.rekman #tests none Change 3017671 on 2016/06/17 by Robert.Manuszewski Fxied and improved log message when cluster assumptions are violated. #rb Steve.Robb #tests Win64 client + server (cooked) golden path Change 3017358 on 2016/06/16 by Nick.Atamas Checking in Darnell's change that adds correct geometry to widgets inside retainer widgets. #rb none #test PIE Change 3017242 on 2016/06/16 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3017179 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3017233 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/UI/Tooltips/Hero/AbilityTooltip.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3017237 on 2016/06/16 by Dmitry.Rekman Fix accessing uninitialized field (kills valgrind warnings). #rb none #codereview Michael.Noland, Andrew.Grant, Ori.Cohen #tests Compiled and ran Linux server. Change 3017236 on 2016/06/16 by Dmitry.Rekman Initialize missed field (kills valgrind warnings). #rb none #codereview Michael.Noland, Andrew.Grant #tests Compiled and ran Linux server. Change 3017186 on 2016/06/16 by Dmitry.Rekman Linux: Add hooks for libcrypto memory functions. - Libcurl uses OpenSSL, which allocates memory using libcrypto's CRYPTO_malloc() and apparently on purpose does not initialize it. - This change a) redirects these allocations to use UE's malloc b) initializes it with zeros, avoiding valgrind's warnings. - This behavior is not used on Shipping configurations because the impact on entropy is not understood (TBD later). #rb Michael.Noland, Rob.Cannaday (original version) #codereview Michael.Noland, Rob.Cannaday, Alex.Fennel, Chris.Babcock, Sam.Zamani #tests Compiled Linux server and ran it. Change 3017037 on 2016/06/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.grant Merging content fix for driver crash from Release-27 #ROBOMERGE-SOURCE: CL 3017036 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3016838 on 2016/06/16 by Alexis.Matte #jira UE-31901 fix to export all blueprint component to obj #rb uriel.doyon #codereview matt.kuhlenschmidt #test export a blueprint containing multiple staticmesh component to obj Change 3016629 on 2016/06/16 by Dmitry.Rekman Make Binned default on Linux non-editor builds. #codereview Andrew.Grant #rb none #tests none Change 3016615 on 2016/06/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.grant Temporarily disabling jemalloc for Linux #rb #tests none [CodeReviewed] Dmitry.Rekman #ROBOMERGE-SOURCE: CL 3016612 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3016566 on 2016/06/16 by Michael.Noland Engine: Fixed a regression that broke safe zone debugging features in Windows by reintroducing code from CL# 2861030 that was accidentally deleted in a merge #codereview andrew.grant #rb dan.hertzka #tests Tested r.DebugSafeZone.Mode 1 with r.DebugSafeZone.TitleRatio 0.9 in PIE and confirmed that SSafeZone obeyed it and the red overlay appeared Change 3016521 on 2016/06/16 by Ryan.Gerleve Client recoreded replay fixes and optimizations from Dev-Networking (and one from //UE4/Main), for deathcam. Includes the following CLs from Dev-Networking: 2997908 2998001 2998832 2999054 2999057 2999749 3000051 3001361 3001365 3004958 3009972 3009973 And this CL from //UE4/Main: 3015528 #tests golden path, replays #rb john.pollard Change 3016503 on 2016/06/16 by Brian.Karis Fixed uninitialized variables on particle lights. Fixes hair shading. #rb none #tests editor Change 3016429 on 2016/06/16 by Max.Chen Sequencer: Fix StartTime when clamping start offset 0. Follow up to CL #3009386. #jira UE-29167 #tests Load up AnnounceMaster and adjust leading edge of animation clips #rb Frank.Fella Change 3016356 on 2016/06/16 by Lina.Halper - Fix crash on rampage morphtarget Merging using //UE4/Dev-Framework_to_//Orion/Dev-General - this is dupe change from Dev-Framework #jira: https://jira.ol.epicgames.net/browse/OR-23194 #rb: Ori.Cohen #tests: editor/pie spawn as rampage's alt skin Change 3015696 on 2016/06/15 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3015646 This re-unifies our build pipeline. Fingers crossed. (only 6 files are actually different) #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3015672 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3015642 on 2016/06/15 by Mieszko.Zielinski Fixes to multiple reasons AI bots were getting stuck #Orion #rb Lukasz.Furman #test golden path Change 3015622 on 2016/06/15 by Mieszko.Zielinski fixed FMetaNavMeshPath doing navmesh path update without checking nav agent if pathfinding should be postponed #UE4 #rb Lukasz.Furman #test golden path Change 3015514 on 2016/06/15 by Uriel.Doyon Fixed GlobalMipBias not affecting max texture resolution. This fix is implemented differently in Dev-Rendering in CL 301498. #jira OR-23511 #rb marcus.wassmer #test played game with different quality settings Change 3015258 on 2016/06/15 by Lina.Halper Fix crash with recursive reference between two assets #rb: Ori.Cohen #tests: Sword Change 3014988 on 2016/06/15 by Wes.Hunt Fix Cook Analytics to correctly use the Legacy provider since it sends to a local data collector. #rb daniel.lamb #tests compile Orion Change 3014962 on 2016/06/15 by Olaf.Piesche Replicating CL 3013696 from Dev-Rendering; making quality level spawn rate scale work for GPU emitters. #rb simon.tovey #tests PC editor game Change 3014958 on 2016/06/15 by Laurent.Delayen Added SkeletalMeshComponent::bIncludeComponentLocationIntoBounds to help in cases where SMU_OnlyTickPoseWhenRendered is set, and an animation pushed the mesh beyond the capsule. This ensures that when the capsule is in view, the mesh will remain updated. #rb Michael.Noland #test Sword ultimate from another player's view. Change 3014833 on 2016/06/15 by Laurent.Delayen Fix for Base Heroes having their locomotion blendspace broken. #rb Thomas.Sarkanen #codereview Thomas.Sarkanen #tests Gadget networked PIE Change 3014688 on 2016/06/15 by Nick.Darnell UMG - Fixing IsHovered on UUserWidgets. SObjectWidget did not properly call the super for MouseEnter/MouseLeave allowing SWidget's implementation to set and unset the bool. #rb none #tests PIE Change 3014325 on 2016/06/15 by Marcus.Wassmer Duplicate 3012706: Scalability CVAR for ContactShadows #rb john.billon #test flip cvar in editor. Change 3014230 on 2016/06/15 by Robert.Manuszewski Fix potentially missing log output when serializing text of length equal to the async log writer buffer size. #rb Steve.Robb #tests Tested in editor build (client + server) Change 3013913 on 2016/06/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Updating from DMM (updated from 27.1MM) #RB:none #Tests:compiled #ROBOMERGE-SOURCE: CL 3013912 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3013437 on 2016/06/14 by Simon.Tovey Speculative fix for OR-23158 Couldnt' repro NANs but did see it reading garbage. Reinstated the check that direct accesses for particles in a zero size emitter will return null. Altered selection code to reselect when partilce is dead or returns null and to not allow new selection on zero size emitters. #tests GoldenPath, No broken fx and no more reading garbage. #rb Olaf.Piesche Change 3013063 on 2016/06/14 by Jason.Bestimt #ORION_DG - Unclog robomerge from DMM Merge #RB:none #tests:none Change 3012936 on 2016/06/14 by Rob.Cannaday Fix for multiple account login not kicking previous logins Client was not parsing response from backend. Client was expecting content-type to be "application/json" (using FString::Equals). Backend was returning "application/json;charset=UTF-8". Changed usage from FString::Equals to FString::StartsWith #jira FORT-25452 #rb sam.zamani #tests multiple account login, frontend only Merge from FN CL 3011647, plus fixing one other location expecting "application/json" Change 3012696 on 2016/06/14 by Max.Chen Sequencer: Select actors for corresponding selected keys or sections. Copy from Dev-Sequencer #jira UE-30727 #tests Load up AnnounceMaster and select keyframes #rb none Change 3012691 on 2016/06/14 by Max.Chen Sequencer: Fix dragging the leading edge of a skeletal animation section so that it adjusts the start offset of the animation clip. Copy from Dev-Sequencer #jira UE-29167 #tests Load up AnnounceMaster and adjust leading edge of animation clips #rb Frank.Fella Change 3012690 on 2016/06/14 by Andrew.Grant Removed Linux work-around for memory stomp alignment #rb none #tests compiled Change 3012687 on 2016/06/14 by Max.Chen Sequencer: Fix lower bound when doing post render tick so that the start of a shot doesn't render with the previous shot's time. Copy from Dev-Sequencer #rb none #tests Load up AnnounceMaster and played through sequence Change 3012627 on 2016/06/14 by Mieszko.Zielinski Added logging of current MoveID to PathfollowingComponent's vlog snapshot #UE4 #rb none #test golden path Change 3012615 on 2016/06/14 by Mieszko.Zielinski Improved fix to BTDecorator_Blackboard's latent tasks aborting #UE4 #rb Lukasz.Furman #test golden path Change 3012572 on 2016/06/14 by Dmitry.Rekman Fix realloc with non-default alignment in jemalloc (OR-23541). - Removed obsolete check(), the code was already there since CL 1834526. #rb none #codereview Andrew.Grant, Robert.Manuszewski #tests none Change 3012481 on 2016/06/14 by David.Ratti ability system #include fixups and move orion attribute capture marcros into base engine ability system execution class #rb none #tests ability system sample project Change 3012457 on 2016/06/14 by Andrew.Grant Un-fix misaligned memory-stomp fix for Linux #rb none #tests compiled Change 3012320 on 2016/06/14 by Graeme.Thornton Fixes for MemoryAnalyser2 solution - Upgraded to VS 2015 - Clean up solution configurations. Only leave "Any CPU" - Switch project to build with "Any CPU" rather than "x64". Reimplementation of CL 3012221 from Dev-Core #rb robert.manuszewski #tests opened the main window form correctly in visual studio Change 3012316 on 2016/06/14 by Thomas.Sarkanen Fix copying non-POD structs in the fast path Prevents double-deletions of TArrays etc. #jira UE-31394 - Fix problems with non-POD UStructs using the anim BP fast-path #tests Played PIE & died as Sword in OrionEntry, Exited PIE. #rb Martin.Wilson Change 3012187 on 2016/06/14 by Graeme.Thornton Corrected error message when not specifying linux server device command line correctly in UAT #rb Dmitry.Rekman #tests Checked error message was useful when wrong command line was specified Change 3012026 on 2016/06/13 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3011936 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3011996 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/oriongame/Content/Characters/Heroes/Hammer/Abilities/Subjugate/FX/P_SubjugateSwirls.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3011969 on 2016/06/13 by Brian.Karis Tweaks for hair Change 3011638 on 2016/06/13 by Andrew.Grant Fixed issue where RepLayout could use unaligned memoryfor property construction if allocator did not use a suitable default (fixes crash when running with MemStomp). Also added sanity check in UScriptStruct::InitializeStruct that memory is correctly aligned before calling constructor #codereview Dave.Ratti, John.Pollard #rb none #tests Ran with/without memstomp Change 3011575 on 2016/06/13 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3011414 NOTE - Card data was altered. Shame shame shame. Not authoritative in DUI #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith, sammy.james, matt.kuhlenschmidt #ROBOMERGE-SOURCE: CL 3011552 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3011462 on 2016/06/13 by Alexis.Matte #jira UE-31901 The outputdevice is adding 2 uninitialize character at the end of any log, this is cause by the terminator logic. The fix is to not add those characters when no terminator should be add. #rb nick.darnell #codereview Robert.Manuszewski #test export a obj file and verify all object are exported in maya or max Change 3011424 on 2016/06/13 by Martin.Wilson Hack out fastpath anim bp code until heap corruption issue can be fixed. #rb Laurent.Delayen #tests Persona + PIE Change 3011191 on 2016/06/13 by Mieszko.Zielinski Added missing initialization of PathFollowingComponent::CurrentMoveInput #UE4 #rb none #test golden path Change 3011138 on 2016/06/13 by Mieszko.Zielinski Switched bots over from travel mode to sprinting #Orion #rb Lukasz.Furman #test golden path Change 3011075 on 2016/06/13 by David.Ratti Default GameplayAbility instancing policy to InstancePerExecution #rb BenZ #tests compile Change 3011051 on 2016/06/13 by David.Ratti Add missing include so GameplayAbilitySet.h can be included on its own. #rb none #tests compile Change 3010968 on 2016/06/13 by Mieszko.Zielinski Fixed console variables crashing on "" string #UE4 #rb Lukasz.Furman #codereview Martin.Mittring #test PIE Change 3010888 on 2016/06/13 by Alexis.Matte #jira OR-23301 Close the OS handle when closing the FAsyncWriter. #rb Robert.Manuszewski #codereview Robert.Manuszewski #test try to export a obj file Change 3010239 on 2016/06/11 by Michael.Noland UMG - Adding back the logic to use the normal WidgetTree when the DesignerWidgetTree is not defined. [duplicated fix from CL# 2998267] #jira UE-31570 #tests Compiled some blueprints #rb none Change 3009870 on 2016/06/10 by Wes.Hunt Remove logging of analytics payloads from dedicated servers #jira UE-31858 #codereview:dmitry.rekman #rb none #tests All testing was done in Dev-Framework. This change was redone in this branch to get it here faster. Change 3009599 on 2016/06/10 by Michael.Noland Rendering: Corrected a misleading help comment on r.StaticMeshLODDistanceScale, explaining how it affects LOD calculations (it multiplies the effective distance, so larger numbers make transitions happen sooner) #tests Verified in the output of the help command #rb none #rn Change 3009559 on 2016/06/10 by Marcus.Wassmer Fix 11/11/10 SceneColorFormat option, enable AntiGhosting on TemporalAA, ensure TemporalAA output is the correct format for accumulating results. Set SceneColorFormat to 2 on PS4 and lowspec PC. All in all saves .3-.5ms on PS4 and improves temporalAA ghosting. #rb Brian.Karis #test Agora PS4 / PC Change 3009525 on 2016/06/10 by David.Ratti Fix case where ObjectLIbrary would not be able to find classes when searching "/Game" path. #rb none #tests object libraries in paragon Change 3009228 on 2016/06/10 by David.Ratti remove world check. Can be triggered in editor with PIE #rb none #tests pie Change 3009050 on 2016/06/10 by Dmitry.Rekman Fix LinuxClient platform not being built on Windows, and not instantiating a target platform instance. - Fixes by BenM. #rb none #codereview Ben.Marsh #tests Compiled OrionEditor on Linux. Change 3008973 on 2016/06/10 by Marcus.Wassmer Fix Windualshock on VS2015 #rb Rolando.Caloca #test PS4 controller on VS2015 build Change 3008970 on 2016/06/10 by David.Ratti Fix warning about minimal replication tag count -Made bit count a config setting. Bumped to 5 -Minor optimization to UAbilitySystemGlobals::Get() #rb none #tests goldne path, pie Change 3008478 on 2016/06/09 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3008469 #RB:none #Tests:none Change 3008416 on 2016/06/09 by Andrew.Grant Adding 'config' as an option to set both clientconfig / serverconfig when using BuildCookRun #review-3008417 Ben.Marsh, Justin.Sargent #rb none #tests BuildCookRun with config Change 3008286 on 2016/06/09 by Dmitry.Rekman Add LinuxClient target platform. #rb none #tests Compile OrionEditor on Linux. #codereview Brad.Angelcyk, Ben.Marsh Change 3007978 on 2016/06/09 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3007507 #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith #ROBOMERGE-SOURCE: CL 3007968 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3007771 on 2016/06/09 by Laurent.Delayen Fixed GetIntFromComp breaking with INDEX_NONE. Fixes crash in OrientationWarping node. #rb martin.wilson #codereview martin.wilson #tests Sword Leap. Change 3007436 on 2016/06/09 by David.Ratti change designer facing parameter name #rb none #test compile Change 3007408 on 2016/06/09 by David.Ratti WaitGameplayEffectBlockedImmunity - ability task for listening to immunity events #rb danY #tests pie Change 3007250 on 2016/06/09 by bruce.nesbit Banner impact location fix. (OR-23179) #rb none #tests Game+PIE Change 3007228 on 2016/06/09 by Ben.Marsh BuildGraph: Rename -SkipNodesWithoutTickets parameter to -SkipTargetsWithoutTickets, to reflect that it's filtering the list of targets rather than the full graph. #rb none #tests none Change 3007225 on 2016/06/09 by Ben.Marsh EC: Set the -TicketSignature=... parameter for all BuildGraph jobs started by EC to the URL of the current job. Change 3006985 on 2016/06/08 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3006936 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3006978 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3006926 on 2016/06/08 by Andrew.Grant Merging //UE4/Main @ 300872 via //UE4/Orion-Staging #rb none #tests engine QA, orion qa smoke Change 3006444 on 2016/06/08 by Ben.Marsh BuildGraph: Add mechanism to specify that nodes can only be built once for a given changelist. Nodes can have an associated ticket file, and they are only permitted to build if the ticket is assigned to the current job. Tickets are created if they don't exist, and written with a signature specific to the job specified via the -TicketSignature="..." parameter. By default, builds will fail if a ticket has been already granted to another job, but the -SkipNodesWithoutTickets parameter instructs the graph to skip affected nodes instead. #rb none #tests none Change 3006389 on 2016/06/08 by Daniel.Lamb Delay the processing of packages which aren't ready till the end of the cook. This allows other packages to be processed sooner. #rb Peter.Sauerbrei #test cook orion. Change 3006306 on 2016/06/08 by Michael.Noland Rendering: Added FreezeRendering to the console autocomplete list #rn Change 3006305 on 2016/06/08 by Michael.Noland HLOD: Added a way to control how far down the HLOD hierarchy to allow showing (can be used to limit quality loss and streaming texture memory usage on high scalability settings for example) Controlled by the new cvar r.HLOD.MaximumLevel, which can be set to the following values: -1: No maximum level (default) 0: Prevent ever showing a HLOD cluster instead of individual meshes 1: Allow only the first level of HLOD clusters to be shown 2+: Allow up to the Nth level of HLOD clusters to be shown Note: This does not affect the memory used by the HLOD meshes itself or their always loaded low mip levels, it will only save the memory associated with streaming in the higher mip levels HLOD: Allowed r.HLOD console command to be used in Test configurations HLOD: Removed some dead code in ALODActor and scene view / scene proxy relating to a different way to force visualization that has no trigger HLOD: Fixed an uninitialized memory bug in the static mesh scene proxy HLODcoloration visualization code #rn #codereview jurre.debaare #rb marc.audy #tests Tested with various settings in Paragon and tried creating some new clusters in the editor Change 3006304 on 2016/06/08 by Michael.Noland Engine: Changed the code in AActor::IncrementalRegisterComponents to obey bAutoRegister for the root component rather than asserting that it is true. Note: If children components have bAutoRegister=true, they will still pull the root component into the fray and cause it to be registered first #rb marc.audy #tests Tested with code that registers or unregisters HLOD clusters at varying levels in Paragon Change 3006041 on 2016/06/08 by Andrew.Grant Added buildidoverride to shipping whitelist #rb none #tests compiled and used param in shipping Change 3005678 on 2016/06/08 by Ben.Marsh Back out changelist 3004395 #rb none #tests none Change 3005265 on 2016/06/07 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3005120 #RB: none #Tests: none #ROBOMERGE-SOURCE: CL 3005250 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3005081 on 2016/06/07 by Daniel.Lamb Reworked the way packages which are renamed on load are added to the cooked package list. Cooker now has options for MaxMemoryAllowance as a percentage and also MinFreeMemory (which takes into account used system memory not just total system memory). #rb Andrew.Grant, Marcus.Wasmer #test cook orion Change 3004752 on 2016/06/07 by Daniel.Lamb Requeue packages to the next package on the list instead of to the end of the list. #rb Andrew.Grant #test cook orion Change 3004560 on 2016/06/07 by David.Ratti Kill timelines, latent actions, timer when recycling gameplay cues #rb danY #tests pie Change 3004559 on 2016/06/07 by David.Ratti Object Library: -Added bool bIncludeOnlyOnDiskAssets that can be set by owner. Passed on to the AR filter when gathering assets. GameplayCue Editor: -Fix issue with new notifies not showing up after being created through the GC Editor (until restart). -Fix issue for new projects, that don't have gameplayclue tags defined, not being able to add gameplay cue tags through the editor without restarting once. #rb none #tests editor Change 3004395 on 2016/06/07 by Ben.Marsh BuildGraph: Add a script function to ensure exclusive access to a given resource. The AcquireLockFile() function takes two arguments; a path to a text file, and the name of an owner. The file is created and the owner name written to it if it doesn't already exist, otherwise the contents of it are compared against the given owner string. The operation happens transactionally, and the function returns true if file contains the given owner string on exit. Logical and/or conditions are now also short-circuited, so the result of the AcquireLockFile() function can be used to control derived property definitions within an executing job. #rb none #tests none Change 3004164 on 2016/06/07 by David.Ratti Ability system: use player controller netmode over avatar actor when possible. Fixes issue if torn off, authority, client side actor tries to activate an ability. #rb danY #tests multi pie Change 3003837 on 2016/06/07 by David.Ratti Ability system engine work -Default to /Game as search path for gameplay cues, if no explicit paths are set in the config. #rb none #tests ability sample project Change 3002800 on 2016/06/06 by Marcus.Wassmer Fix shader crash in PIE #rb none #test PIE Change 3002657 on 2016/06/06 by Dmitry.Rekman Do not copy to clipboard on crash if headless or on the wrong thread. - Could result in crash handler crashing itself in some circumstances. #rb none #codereveiw Brad.Angelcyk #tests Compiled Linux dedicated server and CrashReportClient. Change 3002546 on 2016/06/06 by Daniel.Lamb Improve cooking performance. Allow cooker to save other packages opportunistically if main package is compiling shaders. Allow cooker to load more packages if there aren't many packages to save. #rb Josh.Adams #test cook orion Change 3002369 on 2016/06/06 by Marcus.Wassmer Project setting for optional rendering features to reduce shader compile times. # of shaders per material is reduced by ~30-40% depending on material #rb Daniel.Wright #test Editor with/without all options, cooked ps4. Change 3002142 on 2016/06/06 by David.Ratti Ability system engine level: -Fix crash when gameplay cue editor starts if there are no gameplay cue paths specified -Fix crash when GameplayCue tag is not specified #rb none #tests sample ability system project, paragon Change 3002106 on 2016/06/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani #orion - add support for code tokens which can be shared/redeemed - refactor of existing friend founder's pack codes to be displayed in a generic way using code token info - added CodeToken.FounderFriendInviteT0 for new paragon tier 0 code which grants access to game without also giving a Founder's pack - added CodeToken.FounderFriendInviteT1 to replace existing CodeToken.FriendPC and CodeToken.FriendPS4 Founder's pack codes. Existing codes aliased to the new CodeToken.FounderFriendInviteT1 code - No longer differentiation between PC/PS4 friend codes - "Share Friend Code" button will now process all available codes that can be issued instead of just 1 - updated Orion service Mcp call for getUnredeemedCodes() to ignore the code template id and return all available codes. Each returned code will also include the type [CodeReviewed]: david.nikdel, jason.bestimt #rb david.nikdel #tests PC PIE using localhost and profile proxy for granting codes, also existing account with legacy codes #ROBOMERGE-SOURCE: CL 3002104 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3001218 on 2016/06/05 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3001162 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3001200 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 2999508 on 2016/06/03 by jason.bestimt #ORION_MAIN - Merge 27 @ CL 2999463 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2999498 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Audio/ClassesAndMixes/Classes/Master.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 2999465 on 2016/06/03 by Robert.Manuszewski Whitelisting more DLLs for injection. #rb none #tests none Change 2999455 on 2016/06/03 by Lukasz.Furman disabled path invalidation events for minions #orion #rb Mieszko.Zielinski #tests PIE with additional debug logging Change 2998488 on 2016/06/02 by Michael.Noland Engine: Prevent forced drawing of spline components in Test configuration #codereview james.golding #tests Ran a cooked Test build on a map with splines in it #rb david.ratti #robomerge: main Change 2997954 on 2016/06/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: jon.lietz OR-22425 no longer try to updat the tag map and modifiers when the gameplay effect that is being removed was not active. #RB Dave.Ratti #Tests golden path #ROBOMERGE-SOURCE: CL 2997940 in //Orion/Release-0.27/... via CL 2997943 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2997750 on 2016/06/02 by Graeme.Thornton Add FPakFile::Check() that attempts to open and read the data out of every file in a pak, to check for corruption Added -checkpak option for force a check of every mounted pak file #rb robert.manuszewski #tests tested against cooked pc client. made sure my data succeeded. made sure corrupted data throws an error. [CL 3031715 by Andrew Grant in Main branch]
2016-06-28 17:59:42 -04:00
#include "Tasks/GameplayTask_ClaimResource.h"
UGameplayTask_ClaimResource::UGameplayTask_ClaimResource(const FObjectInitializer& ObjectInitializer)
: Super(ObjectInitializer)
{
}
UGameplayTask_ClaimResource* UGameplayTask_ClaimResource::ClaimResource(TScriptInterface<IGameplayTaskOwnerInterface> InTaskOwner, TSubclassOf<UGameplayTaskResource> ResourceClass, const uint8 Priority, const FName TaskInstanceName)
{
return InTaskOwner.GetInterface() ? ClaimResource(*InTaskOwner, ResourceClass, Priority, TaskInstanceName) : nullptr;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465) #lockdown Nick.Penwarden Change 3110660 on 2016/9/1 by Andrew.Grant Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress. HLOD warning is updated every 20 secs to deal with streaing levels. Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon). #rb Michael.Noland #tests verified we see our unbuilt HLOD warning in v31 :( Change 3106649 on 2016/08/30 by Cody.Haskell #Orion - Input Axis Work #rb DanH #tests PIE Change 3106299 on 2016/08/30 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 31.2 @ CL 3105865 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3106213 on 2016/08/30 by Ben.Marsh BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file. #rb none #tests preflight Change 3105994 on 2016/08/30 by Martin.Wilson Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input) #jira UE-35289 #rb Thomas.Sarkanen #tests Tested UI in editor Change 3105331 on 2016/08/29 by Uriel.Doyon Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget. #rb marcus.wassmer #tests launched editor and played game #jira OR-25814 Change 3105143 on 2016/08/29 by Josh.Markiewicz #UE4 - added assert when histogram input parameters don't match #rb none #tests launched/ran/won game golden path #codereview dmitry.rekman, michael.noland, bart.bressler Change 3104976 on 2016/08/29 by Jon.Lietz pickup refector - fixed a big that would allow mixed replication to call a gameplay cue's added twice. - All pickups now use the pick up manager, consolidated all pick up code into the manager. - added to the XP set so we can define the CXP bounty for targets. #RB Dave.Ratti #tests Bot match, test maps, spawning coins and pickups. Change 3103480 on 2016/08/26 by Josh.Markiewicz #UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession #rb none #tests golden path matchmaking #codereview paul.moore, eric.newman Change 3103410 on 2016/08/26 by Max.Chen Movie Capture: Fix commandline burnin option. #rb none #tests Render movie with commandline -UseBurnIn=yes option. Change 3102134 on 2016/08/25 by Brian.Karis Fix for HDR output exposure. Added 1000nit output option. #rb marcus #tests agora Change 3101276 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_31 - Merging CL 3100347 (head revision of 2 files :o ) #RB:none #Tests:none [CodeReviewed]: matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3101267 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_DUI - Integrating Media changes from 4.13 (head revision) #RB:none #Tests:none /Engine/Plugins/Media /Engine/Source/Runtime/Media /Engine/Source/Runtime/MediaAssets [CodeReviewed] matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100378 on 2016/08/24 by John.Pollard Fix a crash that can occur when scrubbing in replays #codereview David.Ratti #tests Replays #rb DavidR This is the output: [2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage Change 3100375 on 2016/08/24 by Laurent.Delayen Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket). #rb none #codereview lina.halper #tests Tacticia's RMB Targeting Change 3100278 on 2016/08/24 by Laurent.Delayen Fix for fast path struct copy being broken for FVectors. #rb lina.halper #codereview thomas.sarkanen #tests Chains' hook, Tacticia's LaserBeam and OrientationWarping Change 3100161 on 2016/08/24 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix issue with refresh viewer command failing due to backend congestion #rb RyanG #tests Replays Change 3100114 on 2016/08/24 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3098849 #RB:none #Tests:none #CodeReview: kerrington.smith, matt.schembari #R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100015 on 2016/08/24 by Michael.Noland Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node #jira UE-34998 #rb Aaron.McLeran [re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13] #tests Compiled and ran a golden path match with headphones on Change 3100012 on 2016/08/24 by Michael.Noland UE-34951 - Zero-volume vorbis decoded sounds are too expensive -Adding an audio settings parameter to disable zero-volume playback globally -Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume #rb marc.audy [re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran] #tests Compiled and ran a golden path match with headphones on Change 3099889 on 2016/08/24 by Max.Chen Sequencer: Added command line option to enable burnin #rb none #tests Render movie from command line wtih -UseBurnIn=yes Change 3099801 on 2016/08/24 by Lina.Halper Removed unnecessary comment #rb: none #code review: Benn.Gallagher #tests: compile Change 3099787 on 2016/08/24 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #http - fix for cancelled requests that have not been started never triggering a completion delegate - fixes soft lock when handling disconnects during login OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting #rb josh.markiewicz, alex.fennell #tests none #R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3099252 on 2016/08/24 by Lina.Halper Fixed menu text #rb: none #code review: Thomas.Sarkanen #tests: open editor and create child montage and replaced the animation Change 3099251 on 2016/08/24 by Lina.Halper Deterministic cooking of skeleton - abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked #jira: UE-34834 #rb: Martin.Wilson #tests: cooking orion and make sure it works Change 3098504 on 2016/08/23 by Bart.Bressler Add server time between sending packets monitoring histogram #rb dmitry.rekman #tests ran server locally and made sure analytics events were sent Change 3098494 on 2016/08/23 by Michael.Noland Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements - Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer) - Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected #tests Tested by calling while stat dumphitches was active and confirmed that the interval changed #codereview ben.salem, gil.gribb #rb none Change 3098491 on 2016/08/23 by Mieszko.Zielinski Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4 #rb Lukasz.Furman #test golden path Change 3098070 on 2016/08/23 by Lina.Halper Fix crash with UI update reconstructing - will have to come up with a better solution than this. #rb: Martin.Wilson #tests: child anim montage Change 3097914 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel Merging CL #3097879 from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/... to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/... #Analytics #OSS: Adjusted cohort selection algorithm and test cases [CodeReviewed]: Philip.Buuck #TESTS: unit tests #RB: none #R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097745 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Megre 30.2/31 @ CL 3096895 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097722 on 2016/08/23 by Chris.Bunner Update texture expression properties before triggering parent material recompile. #rb John.Billon #tests Editor replace references, Golden path #jira OR-27531 Change 3097694 on 2016/08/23 by Lina.Halper #Child Anim Montage - Duplicate from parent of the information it cares to get - Currently it is selective on copying what data - Modified GetAllAnimationSequencesReferred to get a partial data - Added ParentAsset/AssetMappingTable in AnimationAsset - Sequence Browser opening would also add to history - AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on #code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti #rb:Martin.Wilson #tests: creating child montage, editing, lots of UI functionality, notifies placement Change 3097513 on 2016/08/23 by Thomas.Sarkanen Non-POD structs can now be copied using the fast path We now always use CPP struct ops to perform copies when dealing with struct properties. #jira UE-34571 - Support struct member access on AnimBP fast path #rb Laurent.Delayen #tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games. Change 3096729 on 2016/08/22 by Mieszko.Zielinski Fixes to EQS scoring function preview #UE4 #rb Lukasz.Furman #test golden path Change 3096596 on 2016/08/22 by Jason.Bestimt #ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970) #RB:none #Tests:none #CodeReview: matt.schembari, max.preussner #R@BOMERGE: MAIN Change 3096550 on 2016/08/22 by Jurre.deBaare Fix for HLOD dirty clusters PIE warning message #tests Simulated Origin with built HLOD clusters, and with one dirty cluster #rb none Change 3096532 on 2016/08/22 by Mieszko.Zielinski Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4 As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized #codereview Lukasz.Furman #rb none #test golden path Change 3096455 on 2016/08/22 by Jason.Bestimt #R@BOMERGE-AUTHOR: keli.hlodversson #CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases #RB David.Nikdel #TESTS none #R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3096316 on 2016/08/22 by Sammy.James Resave to fix log warnings. BPC changes to ensure type saves. #rb #tests editor Change 3096040 on 2016/08/22 by bruce.nesbit Revised fix for landscape crash #rb GarethM #tests Game #codereview Bart.Bressler Change 3096015 on 2016/08/22 by bruce.nesbit Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server #rb none #tests game #codereview Bart.Bressler Change 3095578 on 2016/08/19 by Mieszko.Zielinski Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4 This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor #rb none #test golden path #codereview Lukasz.Furman Change 3095397 on 2016/08/19 by Lina.Halper Fix issue with crash when deleting all segment #rb: Laurent.Delayen #tests: delete segment and make sure it doesn't crash #jira: UE-34830 Change 3095060 on 2016/08/19 by Bart.Bressler Don't load ULandscapeComponent objects on dedicated servers to save memory. #tests cooked server data and played a Solo vs. AI game #rb gareth.martin #codereview james.golding Change 3095037 on 2016/08/19 by Lina.Halper Potential fix with montage trigger ensure on marker sync group #jira: OR-27685 #rb: Benn.Gallagher #code review: Martin.Wilson #tests: attack primhelilx with knock up Change 3094962 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort #RB: None #TESTS: test suite in source [CodeReviewed]: Philip.Buuck #R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094950 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merge #UE4 - Made FMD5 const-correct #RB: none #TEST: none #R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094619 on 2016/08/19 by Lina.Halper #DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID. - assumed the name is all set by now #rb: Benn.Gallagher #jira : UE-34886 #tests: cooking infiltrator that showed same issue and run game. Change 3094532 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3094498 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3093260 on 2016/08/18 by Josh.Markiewicz #UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel) - removed unnecessary cast #rb bart.bressler #codereview bart.bressler, rob.cannaday #tests launched game, some basic party testing Change 3093224 on 2016/08/18 by Josh.Markiewicz #UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games #rb paul.moore #codereview anthony.carter #tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining Change 3092597 on 2016/08/17 by Daniel.Lamb Added Ben Crocker to the rebuild lighting emails. #rb Trivial #Test none Change 3092063 on 2016/08/17 by andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb #tests none Change 3091081 on 2016/08/16 by Jurre.deBaare Fixing non-Editor build errors #fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty) #tests Build Editor + Game #rb none Change 3091009 on 2016/08/16 by Mieszko.Zielinski Added a way to configure a map to not spawn AISystem instance at all #UE4 #rb none #test golden path Change 3090932 on 2016/08/16 by Michael.Noland Vixen: Added indication to the analytics and FPS charts #rb marcus.wassmer #tests Compiled for the platform Change 3090844 on 2016/08/16 by Laurent.Delayen Replicated CL 3090734 from Fortnite. --- Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage Here's the issue in the version of the code prior to this checkin: - UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped - When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value - So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick - It also means if we were playing a montage, and then stop, we'll start ticking - Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing #codereview john.abercrombie #rb none #tests golden path Change 3090832 on 2016/08/16 by Michael.Noland Windows: Fixed a whitespace issue #rb none #tests Compiled for windows Change 3090688 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb none #tests built #R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3090547 on 2016/08/16 by Jurre.deBaare Need a warning message similar to lighting unbuilt when HLOD cluster is not built #fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour #jira UE-34335 #rb none #codereview Michael.Noland #tests pie Agora with and without dirty HLOD clusters Change 3090285 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3090267 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3089413 on 2016/08/15 by paul.mader Agora 2.0 assets Change 3089266 on 2016/08/15 by Max.Chen Sequencer: Add Convert to Possessable Copy from Dev-Sequencer #jira UE-32139 #rb none #tests Convert steel to possessable in Gameplay_PS4 map. Change 3089136 on 2016/08/15 by Mieszko.Zielinski Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4 #rb Lukasz.Furman #codereview Dan.Youhon #test golden path Change 3089118 on 2016/08/15 by Mieszko.Zielinski Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4 #rb none #test golden path Change 3088976 on 2016/08/15 by Andrew.Grant Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules. Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting. Removed superflous /Os from VC debugg settings #rb none #tests verified module built with 'Never' on PS4/Win is built without optimizations. #codereview Marcus.Wassmer, Ben.Marsh Change 3088830 on 2016/08/15 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3088807 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3088597 on 2016/08/14 by Jason.Bestimt #ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG) #RB:none #Tests:none #CodeReview: andrew.grant, david.ratti, matt.schembari Change 3087827 on 2016/08/12 by Bart.Bressler Updates to skeletal mesh memory saving on dedicated server #rb lina.halper #tests Cooked server data, played a game for a while in Solo vs. AI Change 3087351 on 2016/08/12 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) #jira OR-27406 #rb RyanG #tests Replays Change 3087118 on 2016/08/12 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3086747 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3086176 on 2016/08/11 by Marcus.Wassmer Fix PS4 ShaderPipelines not matching pixel/vertex shader properly. #rb Rolando.Caloca #tests Broken PS4 content before/after Change 3085992 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Unclog R@BOMERGE #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3085911 on 2016/08/11 by Laurent.Delayen Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex #rb none #tests Orientation Warping Change 3085614 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3085547 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3084507 on 2016/08/10 by Marcus.Wassmer Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen. #rb none #tests paragon ps4/vixen #codereview Olaf.Piesche Change 3084136 on 2016/08/10 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3083799 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083424 on 2016/08/09 by Max.Chen Sequence Recorder: Fix crash when actor class to record is null. #tests Use sequence recorder to record a skeletal mesh actor #rb none Change 3083134 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #online,store,ps4 - creating one offer entry per entitlement #rb david.nikdel, ian.fox #tests MTX purhcase on PS4 #lockdown: andrew.grant #R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083069 on 2016/08/09 by Marcus.Wassmer Vixen scalability changes #rb Michael.Noland #tests vixen/ps4 #codereview jordan.walker Change 3083063 on 2016/08/09 by Marcus.Wassmer Most games will probably run out of memory if setup to do auto-4k. Make this a setting that's off by default. #rb Michael.Noland #codereview Luke.Thatcher, Lee.Clark #tests vixen on 4k. Change 3082778 on 2016/08/09 by Marcus.Wassmer Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087) #rb none #tests Agora on vixen. Change 3082772 on 2016/08/09 by Marcus.Wassmer Duplicate fix for detail mode reregistration (3065543) #rb none #tests Toggled detail mode, observe proper items spawning Change 3082765 on 2016/08/09 by Marcus.Wassmer Don't crash when trying to use windowed vsync on vixen #rb Michael.Noland #test ran paragon on vixen #codereview Luke.Thatcher,Lee.Clark Change 3082764 on 2016/08/09 by Marcus.Wassmer fix HLOD distance scale not working properly when components are re-registered. #rb michael.noland #codereview jurre.debarre #tests setting multiple times, setting on boot via deviceprofile Change 3082429 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani Merging //Orion/Release-30.1 to Main (//Orion/Main) Change: 3082419 #online,store,PS4 OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen - added config option for toggling store on PS4 [OnlineSubsystemPS4] bStoreEnabled=true - can also override via title specific json values in <titleid>\title.json allow_mtx=true [CodeReviewed]: andrew.grant, phillip.buck, ian.fox #lockdown: andrew.grant #rb none #tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support) #R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3082194 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3082105 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080984 on 2016/08/08 by Lina.Halper Issue with not being able to set static animation data via BP - artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP - also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called. #rb: Martin.Wilson #tests: Sword Beauty map Change 3080665 on 2016/08/08 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3080081 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080565 on 2016/08/08 by Laurent.Delayen Fix for curve values during URO interpolation. Fixes flashing of materials and Twinblast's ult weapon. https://jira.ol.epicgames.net/browse/OR-27107 https://jira.ol.epicgames.net/browse/OR-24358 #rb lina.halper, martin.wilson #tests Twinblast's ult and Coil's primary. Change 3079832 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: marcus.wassmer Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline #rb none [CodeReviewed] Chris.Wood #tests checked crashcontext on PC/PS4 #lockdown Andrew.Grant #R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3079045 on 2016/08/05 by Lina.Halper Adding more log to figure out why ActivePlayers.Count becomes inconsistent. #rb: Martin.Wilson #tests: PIE with bots Change 3078944 on 2016/08/05 by Rolando.Caloca O - Update blacklisted driver #jira OR-27051 #rb Marcus.Wassmer #tests Run with AMD card Change 3078735 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3078670 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3078122 on 2016/08/04 by Dmitry.Rekman Linux: treat abort() / SIGABRT as crash. - Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler. - Rewrote RequestExit() because it used abort() itself. - Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason. #rb Mark.Satterthwaite #codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant #review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant #tests Ran Linux server, crashed using different methods. Change 3077887 on 2016/08/04 by Dmitry.Rekman Initialize StackCount to 0 (kills valgrind warning). #rb David.Ratti #codereview David.Ratti #tests Ran Linux server. Change 3077257 on 2016/08/04 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3077193 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3077242 on 2016/08/04 by Dmitry.Rekman Linux: stop heartbeat thread before handling the crash. #rb Robert.Manuszewski #codereview Robert.Manuszewski, Andrew.Grant #tests Compiled and ran Linux server, crashed it. Change 3076676 on 2016/08/03 by Dmitry.Rekman Linux: print details about memory access (read or write). - Also print all the 16 digits of the pointer. - Read/write detection only implemented for x86_64. #rb Andrew.Grant #codereview Andrew.Grant #tests Compiled (natively) and ran Linux server. Change 3076675 on 2016/08/03 by Dmitry.Rekman Print a bit more info about the array in assert. #rb Andrew.Grant #codereview Andrew.Grant #test Compiled and ran Linux server. Change 3076010 on 2016/08/03 by Laurent.Delayen Moved OrionAnimNode_LegIK from Paragon to Engine. #codereview lina.halper #rb none #tests Grim.exe + Iggy & Scorch Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt Reimplemented 3070766 for Orion: Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash) #rb none #tests none Change 3075446 on 2016/08/03 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3075422 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3075394 on 2016/08/03 by HaarmPieter.Duiker Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in. #rb marcus.wassmer #tests post process color correction Change 3074314 on 2016/08/02 by Dmitry.Rekman Linux: change optimization from -O2 to -O1 (temporarily?). - The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier. - Also adds a line to UBT output during compilation to draw attention. #rb Michael.Noland #codereview Michael.Noland, Andrew.Grant, Bart.Bressler #tests Compiled and ran Linux server. Change 3073553 on 2016/08/02 by jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3073360 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) #R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3073505 on 2016/08/02 by Daniel.Lamb Added cook modification delegate stats to cooker stats. #rb Wes.Hunt #test cook paragon. Change 3072440 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries. #rb none #tests SHIPPING Change 3072259 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback. #rb Michael.Noland #tests PIE Change 3071908 on 2016/08/01 by John.Pollard Fix null reference crash #rb DavidR #tests Live game + replays Change 3071876 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player #rb none #tests FN + Paragon live game + replays #codereview Andrew.Grant Change 3071875 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Finalize replay version system * No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions) * Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore. * Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions) #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071874 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix gameplay tags to work better with backwards compatibility in replays * We use the net field export group system in the package map to export tag names as a packed index * This will allow us to see the names of tags that no longer exists on the remote side #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071776 on 2016/08/01 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3071738 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3071258 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together. - Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now. #rb none #tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues. Change 3071099 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads. #rb none #tests ran paragon with change and noticed no change in audio quality Change 3070916 on 2016/07/29 by Andrew.Grant Missed file! #rb #tests na Change 3070915 on 2016/07/29 by Andrew.Grant Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging #rb none #tests Engine QA, Orion QA smoke Change 3070576 on 2016/07/29 by Uriel.Doyon Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize. #review-3070386 @marcus.wassmer #jira OR-25941 #rb marcus.wassmer #tests Run Game on PS4, and in editor Change 3070086 on 2016/07/29 by Martin.Wilson Fixed ensure triggering during sequencer playback due to double update. #jira UE-33938 #rb Thomas.Sarkanen #tests opened affected asset and verified problem no longer occured Change 3070016 on 2016/07/29 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30 @ CL 3069935 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3069435 on 2016/07/28 by Ian.Fox #Orion, #Mcp - Check if Price Engine is configured before attempting query #rb Sam.Zamani #tests none #codereview Sam.Zamani Change 3069381 on 2016/07/28 by Michael.Noland Animation: Demoted a check() in anim sync group code to an ensure() to unblock others #rb nick.penwarden #tests Loaded Paragon cine asset that was crashing #codereview lina.halper, martin.wilson Change 3069203 on 2016/07/28 by Dmitry.Rekman Headless client: do not draw windows. - Disables a bunch of code, including reaching into font cache to estimate width. - Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets). #rb Nick.Atamas #review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem #codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem #tests Compiled and ran Orion Linux client. Change 3069181 on 2016/07/28 by Lina.Halper Fix struct redirector for Orion anim node moving to engine #rb: Maciej.Mroz #code review:Laurent.Delayen #tests: editor loading the anim BP that caused the name conversion Change 3069092 on 2016/07/28 by Aaron.McLeran OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves - Not all active sounds have sound classes, was causing a crash #codereview marc.audy #rb zabir.hoque #tests Run game with stat soundcues and not crash Change 3068969 on 2016/07/28 by David.Ratti Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too. #rb none #tests compile Change 3068902 on 2016/07/28 by David.Ratti Code for tracking down UGameplayCueManager::GetInstancedCueActor crash. #rb none #tests compile Change 3068831 on 2016/07/28 by Aaron.McLeran OR-26417 Reverb is too loud in-game in Dev-General - Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set. #rb Jeff.Campeau #tests run a map with no reverb audio volume and reverb is not super wet Change 3068529 on 2016/07/28 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config) #RB: none #TESTS: none #R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3068399 on 2016/07/28 by Andrew.Rodham Sequencer: Changed animation tracks to allow more animation types (such as anim montages) - APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility #jira OR-25769 #tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly. #rb Benn.Gallagher Change 3068138 on 2016/07/28 by Marcus.Wassmer Disable mallocleak testing by default #rb none #test none Change 3068121 on 2016/07/28 by Marcus.Wassmer Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled. Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also. #rb Robert.Manuszewski #tests stack tracing / symbolication with mallocleak on windows. Change 3068119 on 2016/07/28 by Marcus.Wassmer Fix MallocLeakProxy deadlock #rb Robert.Manuszewski #tests mallocleak start/stop/dump on windows Change 3067752 on 2016/07/27 by Michael.Noland Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands - IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer - The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class. - The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered - Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code Upgrade Notes: - DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly - In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands) - HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name) - Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future) Paragon: - Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event - Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it. #rb dmitry.rekman #codereview bob.tellez, peter.knepley, andrew.grant, john.mauney #review-3067607 @Dmitry.Rekman, @Bob.Tellez #tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI Change 3067654 on 2016/07/27 by Michael.Noland FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path. #rb steve.robb #jira UE-31959 [duplicating CL# 3039827] #tests Tried moving a folder in the editor Change 3067644 on 2016/07/27 by Aaron.McLeran OR-24537 Looping audio sometimes persists in Agora Adding stopping sounds if audio component is destroyed while playing a looping sound #rb jeff.campeau #tests audio component stops looping sound if audio component is destroyed prematurely Change 3067560 on 2016/07/27 by Aaron.McLeran OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters - Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call - using xaudio2 operation sets to ensure that voice and effect params are executing in sequence - only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands - Don't call EnsureCompletion on pending async tasks on teardown #rb Jeff.Campeau #tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions Change 3067420 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge 29.2/30 @ CL 3067312 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067316 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3065602 #RB:none #Tests:none [CodeReviewed]: matt.schembari #R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067025 on 2016/07/27 by Michael.Noland Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes #rb none #tests Compiled Change 3067020 on 2016/07/27 by Michael.Noland Core: Various improvements to FHistogram and split it out into separate files - Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate) - Added O(1) getters for total sample counts and sum of all measurements - Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex - Added support for specifying explicit histogram bucket thresholds #rb dmitry.rekman #tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage Change 3066681 on 2016/07/27 by Frank.Gigliotti Camera anim field of view fix; * The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value. * Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees. #RB None #CodeReview Jeff.Farris #Tests Multiple camera animations in PIE Change 3066508 on 2016/07/27 by Lina.Halper Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name. #code review:Martin.Wilson, Benn.Gallagher #rb: Martin.Wilson #tests: cooked test map, run test map, PIE, saving content, loading standalone game Change 3066246 on 2016/07/27 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Fix for non-unity error #rb none #tests compiled #R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3066167 on 2016/07/27 by Benn.Gallagher Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding. #rb Ori.Cohen #tests Editor, PIE, Applying clothing to characters. Change 3065868 on 2016/07/27 by Michael.Noland Blueprints: Fixing non-editor build (missing WITH_EDITOR) #rb none #tests Compiled PS4 Change 3065749 on 2016/07/26 by Michael.Noland Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead) #codereview mike.beach, marc.audy #tests Loaded and recovered a corrupted Blueprint on Cameron's machine #rb Phillip.Kavan Change 3065706 on 2016/07/26 by Josh.Markiewicz #UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons - fixed non shipping cmd line override to be correct #rb none #codereview andrew.grant, paul.moore #tests none Change 3065359 on 2016/07/26 by Rob.Cannaday Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit. Break up calls in batches of 100 ids. #jira OR-20674 #rb ian.fox #tests login to front end with PC, PS4. forced tests to simulate > 100 requests. Change 3065197 on 2016/07/26 by Bart.Bressler Change how PS4 sessions work: - We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions. - Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable - Added comments, other misc. code cleanup. #rb josh.markiewicz, sam.zamani, rob.cannaday #tests created cross play parties with multiple pc + ps4 players #jira OR-20332 Change 3065158 on 2016/07/26 by Lina.Halper Fix the guid keep generated by adding to the database. - This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible #rb: Martin.Wilson #jira: UE-33772, UE-33454 #tests: cooked AI_Test map, editor rename curves Change 3064735 on 2016/07/26 by Dmitry.Rekman Linux: added WebRTC libs. - Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc). #rb none #tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform. (Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064727 on 2016/07/26 by Dmitry.Rekman Fix crash on cooker exit (UE-33583). - Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it. #rb none #tests Compiled and ran Linux server and Linux client. (Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064725 on 2016/07/26 by Dmitry.Rekman Linux: use libc++ instead of libstdc++. - Needed to solve problems with third-party C++ libraries (e.g. WebRTC). - Bundled libc++ 3.8.1 (TPS cleared). - Turned off ICU compilation (needs recompile against libc++). - Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix. #rb none #tests Built and ran a number of Linux targets. (Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064572 on 2016/07/26 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 29.2 @ CL 3064545 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3064523 on 2016/07/26 by Jon.Lietz Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements. #RB none #tests BP compiles and stays not dirty #codereview dave.ratti@epicgames.com [CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
UGameplayTask_ClaimResource* UGameplayTask_ClaimResource::ClaimResources(TScriptInterface<IGameplayTaskOwnerInterface> InTaskOwner, TArray<TSubclassOf<UGameplayTaskResource> > ResourceClasses, const uint8 Priority, const FName TaskInstanceName)
{
return InTaskOwner.GetInterface() ? ClaimResources(*InTaskOwner, ResourceClasses, Priority, TaskInstanceName) : nullptr;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3028454) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3028439 on 2016/06/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 28 @ CL 3028090 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3028437 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3027952 on 2016/06/26 by Jurre.deBaare - Integrating code fixes/changes from Simplygon for Normals issue on Simplygon Swarm + landscape culling - Readded landscape/volume culling for in-engine static mesh merging path - Fixed issue with r.HLOD force -1 (now stops forcing hlods) - Marked hlodcullingvolume as experimental - Added Landscape culling flag + precision level #codereview Michael.Noland #rb Michael.Noland #tests build clusters locally/cloud + landscape culling tests Change 3027702 on 2016/06/25 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3027698 #RB:none #Tests:none Change 3027312 on 2016/06/24 by Daniel.Lamb Changed the way reentry data is stored in the cooker, reduce work load by main thread, also fix issue with reentry data being used from incorrect packages. #rb Peter.Sauerbrei #test QA game launch on and cook by the book + cook on the fly paragon Change 3027165 on 2016/06/24 by Daniel.Lamb Fix compiler warnings from cvars changes. #rb none #test cook paragon Change 3026900 on 2016/06/24 by Daniel.Lamb Change the way low quality lightmap shaders are enabled / disabled as the engine can't be used in the should cache function. #rb Marcus.Wasmer #test Cook on the fly paragon #codereview Rolando.Caloca Change 3026874 on 2016/06/24 by Olaf.Piesche #jira OR-18363 fix distortion in particle macro UVs with camera movement #rb frank.fella #tests PC Editor/Game Change 3026494 on 2016/06/24 by jason.bestimt #ORION_MAIN - Merge 28 @ CL 3026460 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3026476 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3026381 on 2016/06/24 by Graeme.Thornton Strip particle modules, emitters and lodlevels from cooked server data. Saves ~10mb of runtime memory on Paragon #rb simon.tovey #codereview dmitry.rekman #tests pc cooked client/server, golden path Change 3025760 on 2016/06/23 by jason.bestimt #ORION_MAIN - Merge 28 @ CL 3025687 #RB:none #tests:none #ROBOMERGE-SOURCE: CL 3025709 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Sword/Meshes/sword.uasset - can't integrate exclusive file already opened //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Sword/Meshes/sword_Skeleton.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3025661 on 2016/06/23 by Mieszko.Zielinski Added a feature to PathfollowingComponent allowing it to identify when it starts following a navigation link #UE4 #rb Lukasz.Furman #test golden path Change 3025359 on 2016/06/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani #online,externalui,ps4 - expose access to reset cookies before invoking embedded web browser - fixed not capturing resulting Url when PS4 browser is closed #rb none #tests ps4 #ROBOMERGE-SOURCE: CL 3025356 in //Orion/Release-28/... via CL 3025358 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3025184 on 2016/06/23 by Lina.Halper Fix crash with morphtargets #jira: OR-24257 #rb: Rolando.Caloca #tests: switching mesh with different morphtargets in editor Change 3024714 on 2016/06/23 by Lukasz.Furman added vlog extension to visual debugger tool, added object whitelist to vlog to include selected minion data in games started with -LogBotGame param #rb Mieszko.Zielinski #tests server game with and without LogBotGame cmdline Change 3024709 on 2016/06/23 by Daniel.Lamb Added support for async save when saving seperate bulk data file. Added mb saved to cooking package stats. #rb Andrew.Grant,Wes.Hunt #test Cook Paragon Change 3024674 on 2016/06/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani Merging //Orion/Release-28 to Main (//Orion/Main) #online,identity,ps4 - add psplus flag to online account after privilege check #rb none #tests ps4 login flow #ROBOMERGE-SOURCE: CL 3024672 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3024510 on 2016/06/23 by Graeme.Thornton Added more info to the dumpparticlesystems exec command output #rb simon.tovey #tests cooked pc client, golden path Change 3024504 on 2016/06/23 by Graeme.Thornton Asset registry memory optimisation - make sure all dependency node link arrays are sized exactly as they need to be (saves ~1mb) #rb robert.manuszewski #tests windows cooked client, golden path Change 3024213 on 2016/06/22 by Ryan.Gerleve Handle a rare case in replays where the spectator controller is null but we still find a valid NetGUID for it. Added an ensure before a check that would fail in this case so we'll know if it happens again. #tests replays #rb john.pollard Change 3024127 on 2016/06/22 by John.Pollard Bulk merge using Dev-Networking_->_Dev-General_(Orion) 3002989 Add ability to skip missing/changed properties in FFastArraySerializer 3003072 Fix crash related to new replay backwards compatibility changes 3008097 Renaming CompatibleReplayout to NetFieldExportGroup preparing to unify ability to use FNetFieldExportGroup for both RepLayout and FClassNetCache 3009684 Added ability to use FNetFieldExportGroups for FClassNetCache as well as FRepLayout * Adds ability to track missing/changed custom delta properties names * Adds ability to track missing/changed RPC's 3013455 Add ability to skip over RPC parameters that have changes/missing in replays for backwards compatibility * We now mark FClassNetCache properties as bIncompatible so we don't spam forever when they are out of date * No longer factor in parameters when building checksum for RPC's * Save FNetFieldExport handle for FClassNetCache fields * Use WriteIntWrapped when saving FClassNetCache fields FNetFieldExport handles (and use NetFieldExportGroup->NetFieldExports.Num() to determine max value) * Lots of cleanup and sanity checking improvements 3018078 Optimize replay checkpoints * Share work that was already done during normal replication, and re-use this data to remove the need to compare any checkpoint properties * When saving a checkpoint, we no longer create a new connection and new channels, instead we re-use the existing channels, and added the ability to make this a transient operation * To make custom delta serialize properties work, we compare against the CDO state instead of current state when saving out a checkpoint 3021196 Fix issue with Fast tarray exporting package map info during checkpoints * Add ability to save and restore package map ack status * Save package map ack status before saving checkpoint, and then restore it back afterwards, this will then allow the stream that writes afterward to re-export anything that was new in the checkpoint * No longer queue up reliable bunches on ack list for internal ack connections 3024033 Prune the cached change list before using when saving out checkpoints * Fixes issues when saving checkpoint, and the live properties change array size, which throws everything off when it comes time to use the LifetimeChangelist 3024034 Don't close channels when saving checkpoints, fixes issue where it creates a bunch with bOpen/bClose (because we're forcing all SendBunches to re-open channels), which throws off the stream #rb RyanG #tests Replays Change 3024021 on 2016/06/22 by Dmitry.Rekman Fix PS4 build. #rb Michael.Noland #tests none #codereview Michael.Noland, Dan.Youhon, Sammy.James Change 3023734 on 2016/06/22 by Lukasz.Furman added replication for input events and tool state for both gameplay debugger categories and extensions #ue4 #rb Mieszko.Zielinski #tests PIE, server game Change 3023708 on 2016/06/22 by Dmitry.Rekman Add a separate macro for a poison malloc proxy usage. #rb Michael.Noland #codereview Michael.Noland, Gil.Gribb #tests Compiled OrionServer-Linux-Debug, ran it Change 3023670 on 2016/06/22 by Nick.Darnell Home screen - Fixing safezones on the homescreen. Adding a scale option to the XP_Fill widget. Adding better animations to the tiles. Showing subtitles again. Hero XP summary widget now takes you to that hero. #rb none #tests PIE Change 3023632 on 2016/06/22 by Dmitry.Rekman Fix incorrect matching condition in comments. #rb none #tests Compiled OrionServer-Linux-Debug #codereview Michael.Noland Change 3023475 on 2016/06/22 by Rolando.Caloca O - Back out changelist 3022847 as it broke SSS on PC #rb none #tests re-run editor on PC Change 3023178 on 2016/06/22 by Michael.Noland Engine: Added system memory and % of time spent hitching to analytics #rb bob.tellez #tests Tested a match in Paragon Change 3022963 on 2016/06/22 by Mieszko.Zielinski Fixed a subtle navigation repathing bug #UE4 While repathing to a location, rather than an actor, the navigation query used path's end while it should be using the original query's EndLocation. #rb Lukasz.Furman #test golden path Change 3022865 on 2016/06/22 by David.Ratti gameplay cue editor: remove "GameplayCue_" prefix from default GameplayCueNotify filename in default ability system projects #rb none #tests ability system sample project Change 3022847 on 2016/06/22 by Rolando.Caloca O - Remove checkerboard SSS rendering and recombine post process pass when SSS not enabled #rb Marcus.Wassmer #codereview Marcus.Wassmer, Brian.Karis #tests Load Agora_P, check perf, toggle r.SSS.Quality 1/0, check characters with skin Change 3022804 on 2016/06/22 by Mieszko.Zielinski Fixed AIController clearing out CachedGameplayTasksComponent on UnPosses, even if Pawn was not the CachedGameplayTasksComponent's owner #UE4 Also, made running BT not clearing info in BB if AI's current BB is compatible with the one required by BT #rb Lukasz.Furman #test golden path Change 3022674 on 2016/06/22 by Robert.Manuszewski Reimplementing CL #2993969 (Dev-Blueprints) by Maciej.Mroz: UE-30729 Crash in Native Orion when selecting Sword or Tomahawk Clear AsyncLoading in subobjects. #jira OR-23997 #rb me #tests Golden path in editor build, selecting Venus Change 3022405 on 2016/06/21 by Ryan.Gerleve Fix for OR-23948, crash with death cam enabled. Use a weak pointer to store the viewer on the DemoNetDriver and update it when the game player controller is received. #rb john.pollard #tests bug repro Change 3022387 on 2016/06/21 by Ryan.Gerleve Added the ability to disable ticking of individual worlds. #tests golden path #rb john.pollard #codereview marc.audy Change 3022312 on 2016/06/21 by Nick.Darnell Home Screen - Adding a max aspect ratio lock to SBox, may need some more fine tuning math may still be a bit pants in some cases. The XP ovewview panels now have a basic support for account and hero progression. Hero one shows the last hero you played, widget is invisibile until you play your first game. The tiles now use the Max Aspect Ratio to prevent stretching forever on 21:9 monitors causing them to just look crazy. Weekly quests now show the weekly quests screen when clicked. OrionUserWidgetBase no longer prevents blueprints from running code in reponse to mouse down/up actions if the userwidget consumes input - it always calls the blueprint code first, and always returns handled if it consumes input. #rb none #tests PIE Change 3022207 on 2016/06/21 by Wes.Hunt Fix Analytics provider to retain passed in AppVersion string instead of using default %VERSION%. #rb none #tests run windows server with one bot connecting and checking analytics version is what is expected. Change 3021808 on 2016/06/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - call GetTotalMicroseconds instead of GetTotalMilliseconds * 1000 #rb none #tests compile run ps4 #ROBOMERGE-SOURCE: CL 3021805 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3021663 on 2016/06/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - CancelFindSessions() didn't null out search result - future FindSession() calls would fail with "search in progress" #rb joe.wilcox #tests UT matchmaking #ROBOMERGE-SOURCE: CL 3021655 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3021508 on 2016/06/21 by Marcus.Wassmer Remove anti-ghosting AA for now. Causes dithered transparency to be very wrong (Dekker shoulders) And also a border around all characters of 'noisy fuzz' even when they are not moving #rb none #test PC/PS4 #codereview Brian.Karis,Jordan.Walker Change 3021475 on 2016/06/21 by Marcus.Wassmer Duplicate fix for subsurface spec in prep for PS4 optimization. (DevRendering 3018664) unified some code for easier maintainance, fixed missing multiply from former change #rb none #test PS4/PC agora Change 3021468 on 2016/06/21 by Michael.Noland Physics: Added more information when convex cooking partially succeeds (fails initially but succeeds with inflation) indicating the full path of the mesh that failed #rb ori.cohen #tests Compiled changes, will provide more information when issue reoccurs in build machine cooks #jira OR-24082 Change 3021460 on 2016/06/21 by Michael.Noland Engine: Added time spent in each hitch bucket to FPS chart .log output and analytics output #rb bob.tellez #tests Tested a match in Paragon #codereview dmitry.rekman Change 3021368 on 2016/06/21 by Marcus.Wassmer Create Tonemapper configuration with no ColorFringe to save .15ms on PS4 when colorfringe is not used. #rb rolando.caloca #test agora with/wo new config #codereview brian.karis Change 3021119 on 2016/06/21 by David.Ratti Make -notimeouts work during initial connecting phase #codereview John.Pollard #rb none #tests pie agora Change 3021048 on 2016/06/21 by David.Ratti minor tweaks to gameplay cues: -Descriptions of engine GC notify classes -Added 'auto attach to owner' flag on actor notify class. #rb none #test ability system sample project Change 3020694 on 2016/06/20 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3020301 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3020674 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #CodeReview: cody.haskell Change 3020624 on 2016/06/20 by Michael.Noland Engine: Pushing more fps chart analytics up to engine level code from Paragon Engine: Pushing benchmark config vars up to engine level code from Paragon, and added records of individual sub-steps of benchmarks #rb Bob.Tellez #tests Golden path Solo VS AI in Paragon and forced a match #codereview bob.tellez, peter.knepley Change 3020181 on 2016/06/20 by Dmitry.Rekman Re-do allowing allocations in NullRHI (OR-24029). - Originally CL 2990582 by MarcusW, stomped during merge by CL 3006926. #rb none #codereview Marcus.Wassmer, Andrew.Grant #tests none Change 3020139 on 2016/06/20 by Ryan.Gerleve Added ability to pause replay recording while keeping the current replay open. #rb john.pollard #tests paused deathcam recording while disabled Change 3019817 on 2016/06/20 by Dmitry.Rekman Poison allocated/freed memory in Debug and Development (non-editor) configs. - With this Paragon client may be more likely to crash on start. #rb Steve.Robb #codereview Robert.Manuszewski, Michael.Noland, Andrew.Grant, Gil.Gribb, Steve.Robb #tests Built Linux server and Windows client, ran them, also built Windows Orion editor. Change 3019599 on 2016/06/20 by Rolando.Caloca O - Fix flickering on heroes with morph targets #rb Marcus.Wassmer #tests Load Agora_P #jira OR-23866 Change 3019581 on 2016/06/20 by Wes.Hunt Fix crash reporter client analytics for internal builds. (Pushing critical fix immediately from //UE4/Orion-Staging) #rb Chris.Wood #tests none Change 3019524 on 2016/06/20 by David.Ratti call APawn::OnRep_Controller when ClientRetryClientRestart sets the pawn directly #rb none #tests golden path Change 3019406 on 2016/06/20 by Marcus.Wassmer Duplicate 3014956 from Dev-Rendering Fixed HLOD and mesh LODs getting hit by Lightmass ray traces that didn't originate from a mesh Volume lighting samples and precomputed visibility cells are now only placed on LOD0 (of both mesh LODs and HLOD) #rb none #test none #codereview Jordan.Walker Change 3019371 on 2016/06/20 by Graeme.Thornton Optimize cooked asset registry dependency node data structures. Saves ~10mb on Paragon. #rb robert.manuszewski #tests tested with cooked pc client + server Change 3018492 on 2016/06/17 by Laurent.Delayen FBoneReferenceCustomization: support editing properties in AnimBP defaults. #rb none #tests: Sword. Change 3017974 on 2016/06/17 by Ryan.Gerleve Add an option to toggle deathcam in the gameplay settings UI if the OrionRuntimeOption for deathcam is enabled. #rb cody.haskell #tests settings menu, enabled and disabled deathcam Change 3017913 on 2016/06/17 by Robert.Manuszewski Fixing leaked log archive. #rb Steve.Robb #tests Cooked Win64 client + server Change 3017873 on 2016/06/17 by Daniel.Lamb Fix warning in diff cooked build. #test none #rb none Change 3017676 on 2016/06/17 by Sam.Zamani #online,identity,mcp fix for uninitialized variable #rb dmitry.rekman #tests none Change 3017671 on 2016/06/17 by Robert.Manuszewski Fxied and improved log message when cluster assumptions are violated. #rb Steve.Robb #tests Win64 client + server (cooked) golden path Change 3017358 on 2016/06/16 by Nick.Atamas Checking in Darnell's change that adds correct geometry to widgets inside retainer widgets. #rb none #test PIE Change 3017242 on 2016/06/16 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3017179 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3017233 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/UI/Tooltips/Hero/AbilityTooltip.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3017237 on 2016/06/16 by Dmitry.Rekman Fix accessing uninitialized field (kills valgrind warnings). #rb none #codereview Michael.Noland, Andrew.Grant, Ori.Cohen #tests Compiled and ran Linux server. Change 3017236 on 2016/06/16 by Dmitry.Rekman Initialize missed field (kills valgrind warnings). #rb none #codereview Michael.Noland, Andrew.Grant #tests Compiled and ran Linux server. Change 3017186 on 2016/06/16 by Dmitry.Rekman Linux: Add hooks for libcrypto memory functions. - Libcurl uses OpenSSL, which allocates memory using libcrypto's CRYPTO_malloc() and apparently on purpose does not initialize it. - This change a) redirects these allocations to use UE's malloc b) initializes it with zeros, avoiding valgrind's warnings. - This behavior is not used on Shipping configurations because the impact on entropy is not understood (TBD later). #rb Michael.Noland, Rob.Cannaday (original version) #codereview Michael.Noland, Rob.Cannaday, Alex.Fennel, Chris.Babcock, Sam.Zamani #tests Compiled Linux server and ran it. Change 3017037 on 2016/06/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.grant Merging content fix for driver crash from Release-27 #ROBOMERGE-SOURCE: CL 3017036 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3016838 on 2016/06/16 by Alexis.Matte #jira UE-31901 fix to export all blueprint component to obj #rb uriel.doyon #codereview matt.kuhlenschmidt #test export a blueprint containing multiple staticmesh component to obj Change 3016629 on 2016/06/16 by Dmitry.Rekman Make Binned default on Linux non-editor builds. #codereview Andrew.Grant #rb none #tests none Change 3016615 on 2016/06/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.grant Temporarily disabling jemalloc for Linux #rb #tests none [CodeReviewed] Dmitry.Rekman #ROBOMERGE-SOURCE: CL 3016612 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3016566 on 2016/06/16 by Michael.Noland Engine: Fixed a regression that broke safe zone debugging features in Windows by reintroducing code from CL# 2861030 that was accidentally deleted in a merge #codereview andrew.grant #rb dan.hertzka #tests Tested r.DebugSafeZone.Mode 1 with r.DebugSafeZone.TitleRatio 0.9 in PIE and confirmed that SSafeZone obeyed it and the red overlay appeared Change 3016521 on 2016/06/16 by Ryan.Gerleve Client recoreded replay fixes and optimizations from Dev-Networking (and one from //UE4/Main), for deathcam. Includes the following CLs from Dev-Networking: 2997908 2998001 2998832 2999054 2999057 2999749 3000051 3001361 3001365 3004958 3009972 3009973 And this CL from //UE4/Main: 3015528 #tests golden path, replays #rb john.pollard Change 3016503 on 2016/06/16 by Brian.Karis Fixed uninitialized variables on particle lights. Fixes hair shading. #rb none #tests editor Change 3016429 on 2016/06/16 by Max.Chen Sequencer: Fix StartTime when clamping start offset 0. Follow up to CL #3009386. #jira UE-29167 #tests Load up AnnounceMaster and adjust leading edge of animation clips #rb Frank.Fella Change 3016356 on 2016/06/16 by Lina.Halper - Fix crash on rampage morphtarget Merging using //UE4/Dev-Framework_to_//Orion/Dev-General - this is dupe change from Dev-Framework #jira: https://jira.ol.epicgames.net/browse/OR-23194 #rb: Ori.Cohen #tests: editor/pie spawn as rampage's alt skin Change 3015696 on 2016/06/15 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3015646 This re-unifies our build pipeline. Fingers crossed. (only 6 files are actually different) #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3015672 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3015642 on 2016/06/15 by Mieszko.Zielinski Fixes to multiple reasons AI bots were getting stuck #Orion #rb Lukasz.Furman #test golden path Change 3015622 on 2016/06/15 by Mieszko.Zielinski fixed FMetaNavMeshPath doing navmesh path update without checking nav agent if pathfinding should be postponed #UE4 #rb Lukasz.Furman #test golden path Change 3015514 on 2016/06/15 by Uriel.Doyon Fixed GlobalMipBias not affecting max texture resolution. This fix is implemented differently in Dev-Rendering in CL 301498. #jira OR-23511 #rb marcus.wassmer #test played game with different quality settings Change 3015258 on 2016/06/15 by Lina.Halper Fix crash with recursive reference between two assets #rb: Ori.Cohen #tests: Sword Change 3014988 on 2016/06/15 by Wes.Hunt Fix Cook Analytics to correctly use the Legacy provider since it sends to a local data collector. #rb daniel.lamb #tests compile Orion Change 3014962 on 2016/06/15 by Olaf.Piesche Replicating CL 3013696 from Dev-Rendering; making quality level spawn rate scale work for GPU emitters. #rb simon.tovey #tests PC editor game Change 3014958 on 2016/06/15 by Laurent.Delayen Added SkeletalMeshComponent::bIncludeComponentLocationIntoBounds to help in cases where SMU_OnlyTickPoseWhenRendered is set, and an animation pushed the mesh beyond the capsule. This ensures that when the capsule is in view, the mesh will remain updated. #rb Michael.Noland #test Sword ultimate from another player's view. Change 3014833 on 2016/06/15 by Laurent.Delayen Fix for Base Heroes having their locomotion blendspace broken. #rb Thomas.Sarkanen #codereview Thomas.Sarkanen #tests Gadget networked PIE Change 3014688 on 2016/06/15 by Nick.Darnell UMG - Fixing IsHovered on UUserWidgets. SObjectWidget did not properly call the super for MouseEnter/MouseLeave allowing SWidget's implementation to set and unset the bool. #rb none #tests PIE Change 3014325 on 2016/06/15 by Marcus.Wassmer Duplicate 3012706: Scalability CVAR for ContactShadows #rb john.billon #test flip cvar in editor. Change 3014230 on 2016/06/15 by Robert.Manuszewski Fix potentially missing log output when serializing text of length equal to the async log writer buffer size. #rb Steve.Robb #tests Tested in editor build (client + server) Change 3013913 on 2016/06/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Updating from DMM (updated from 27.1MM) #RB:none #Tests:compiled #ROBOMERGE-SOURCE: CL 3013912 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3013437 on 2016/06/14 by Simon.Tovey Speculative fix for OR-23158 Couldnt' repro NANs but did see it reading garbage. Reinstated the check that direct accesses for particles in a zero size emitter will return null. Altered selection code to reselect when partilce is dead or returns null and to not allow new selection on zero size emitters. #tests GoldenPath, No broken fx and no more reading garbage. #rb Olaf.Piesche Change 3013063 on 2016/06/14 by Jason.Bestimt #ORION_DG - Unclog robomerge from DMM Merge #RB:none #tests:none Change 3012936 on 2016/06/14 by Rob.Cannaday Fix for multiple account login not kicking previous logins Client was not parsing response from backend. Client was expecting content-type to be "application/json" (using FString::Equals). Backend was returning "application/json;charset=UTF-8". Changed usage from FString::Equals to FString::StartsWith #jira FORT-25452 #rb sam.zamani #tests multiple account login, frontend only Merge from FN CL 3011647, plus fixing one other location expecting "application/json" Change 3012696 on 2016/06/14 by Max.Chen Sequencer: Select actors for corresponding selected keys or sections. Copy from Dev-Sequencer #jira UE-30727 #tests Load up AnnounceMaster and select keyframes #rb none Change 3012691 on 2016/06/14 by Max.Chen Sequencer: Fix dragging the leading edge of a skeletal animation section so that it adjusts the start offset of the animation clip. Copy from Dev-Sequencer #jira UE-29167 #tests Load up AnnounceMaster and adjust leading edge of animation clips #rb Frank.Fella Change 3012690 on 2016/06/14 by Andrew.Grant Removed Linux work-around for memory stomp alignment #rb none #tests compiled Change 3012687 on 2016/06/14 by Max.Chen Sequencer: Fix lower bound when doing post render tick so that the start of a shot doesn't render with the previous shot's time. Copy from Dev-Sequencer #rb none #tests Load up AnnounceMaster and played through sequence Change 3012627 on 2016/06/14 by Mieszko.Zielinski Added logging of current MoveID to PathfollowingComponent's vlog snapshot #UE4 #rb none #test golden path Change 3012615 on 2016/06/14 by Mieszko.Zielinski Improved fix to BTDecorator_Blackboard's latent tasks aborting #UE4 #rb Lukasz.Furman #test golden path Change 3012572 on 2016/06/14 by Dmitry.Rekman Fix realloc with non-default alignment in jemalloc (OR-23541). - Removed obsolete check(), the code was already there since CL 1834526. #rb none #codereview Andrew.Grant, Robert.Manuszewski #tests none Change 3012481 on 2016/06/14 by David.Ratti ability system #include fixups and move orion attribute capture marcros into base engine ability system execution class #rb none #tests ability system sample project Change 3012457 on 2016/06/14 by Andrew.Grant Un-fix misaligned memory-stomp fix for Linux #rb none #tests compiled Change 3012320 on 2016/06/14 by Graeme.Thornton Fixes for MemoryAnalyser2 solution - Upgraded to VS 2015 - Clean up solution configurations. Only leave "Any CPU" - Switch project to build with "Any CPU" rather than "x64". Reimplementation of CL 3012221 from Dev-Core #rb robert.manuszewski #tests opened the main window form correctly in visual studio Change 3012316 on 2016/06/14 by Thomas.Sarkanen Fix copying non-POD structs in the fast path Prevents double-deletions of TArrays etc. #jira UE-31394 - Fix problems with non-POD UStructs using the anim BP fast-path #tests Played PIE & died as Sword in OrionEntry, Exited PIE. #rb Martin.Wilson Change 3012187 on 2016/06/14 by Graeme.Thornton Corrected error message when not specifying linux server device command line correctly in UAT #rb Dmitry.Rekman #tests Checked error message was useful when wrong command line was specified Change 3012026 on 2016/06/13 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3011936 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3011996 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/oriongame/Content/Characters/Heroes/Hammer/Abilities/Subjugate/FX/P_SubjugateSwirls.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3011969 on 2016/06/13 by Brian.Karis Tweaks for hair Change 3011638 on 2016/06/13 by Andrew.Grant Fixed issue where RepLayout could use unaligned memoryfor property construction if allocator did not use a suitable default (fixes crash when running with MemStomp). Also added sanity check in UScriptStruct::InitializeStruct that memory is correctly aligned before calling constructor #codereview Dave.Ratti, John.Pollard #rb none #tests Ran with/without memstomp Change 3011575 on 2016/06/13 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3011414 NOTE - Card data was altered. Shame shame shame. Not authoritative in DUI #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith, sammy.james, matt.kuhlenschmidt #ROBOMERGE-SOURCE: CL 3011552 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3011462 on 2016/06/13 by Alexis.Matte #jira UE-31901 The outputdevice is adding 2 uninitialize character at the end of any log, this is cause by the terminator logic. The fix is to not add those characters when no terminator should be add. #rb nick.darnell #codereview Robert.Manuszewski #test export a obj file and verify all object are exported in maya or max Change 3011424 on 2016/06/13 by Martin.Wilson Hack out fastpath anim bp code until heap corruption issue can be fixed. #rb Laurent.Delayen #tests Persona + PIE Change 3011191 on 2016/06/13 by Mieszko.Zielinski Added missing initialization of PathFollowingComponent::CurrentMoveInput #UE4 #rb none #test golden path Change 3011138 on 2016/06/13 by Mieszko.Zielinski Switched bots over from travel mode to sprinting #Orion #rb Lukasz.Furman #test golden path Change 3011075 on 2016/06/13 by David.Ratti Default GameplayAbility instancing policy to InstancePerExecution #rb BenZ #tests compile Change 3011051 on 2016/06/13 by David.Ratti Add missing include so GameplayAbilitySet.h can be included on its own. #rb none #tests compile Change 3010968 on 2016/06/13 by Mieszko.Zielinski Fixed console variables crashing on "" string #UE4 #rb Lukasz.Furman #codereview Martin.Mittring #test PIE Change 3010888 on 2016/06/13 by Alexis.Matte #jira OR-23301 Close the OS handle when closing the FAsyncWriter. #rb Robert.Manuszewski #codereview Robert.Manuszewski #test try to export a obj file Change 3010239 on 2016/06/11 by Michael.Noland UMG - Adding back the logic to use the normal WidgetTree when the DesignerWidgetTree is not defined. [duplicated fix from CL# 2998267] #jira UE-31570 #tests Compiled some blueprints #rb none Change 3009870 on 2016/06/10 by Wes.Hunt Remove logging of analytics payloads from dedicated servers #jira UE-31858 #codereview:dmitry.rekman #rb none #tests All testing was done in Dev-Framework. This change was redone in this branch to get it here faster. Change 3009599 on 2016/06/10 by Michael.Noland Rendering: Corrected a misleading help comment on r.StaticMeshLODDistanceScale, explaining how it affects LOD calculations (it multiplies the effective distance, so larger numbers make transitions happen sooner) #tests Verified in the output of the help command #rb none #rn Change 3009559 on 2016/06/10 by Marcus.Wassmer Fix 11/11/10 SceneColorFormat option, enable AntiGhosting on TemporalAA, ensure TemporalAA output is the correct format for accumulating results. Set SceneColorFormat to 2 on PS4 and lowspec PC. All in all saves .3-.5ms on PS4 and improves temporalAA ghosting. #rb Brian.Karis #test Agora PS4 / PC Change 3009525 on 2016/06/10 by David.Ratti Fix case where ObjectLIbrary would not be able to find classes when searching "/Game" path. #rb none #tests object libraries in paragon Change 3009228 on 2016/06/10 by David.Ratti remove world check. Can be triggered in editor with PIE #rb none #tests pie Change 3009050 on 2016/06/10 by Dmitry.Rekman Fix LinuxClient platform not being built on Windows, and not instantiating a target platform instance. - Fixes by BenM. #rb none #codereview Ben.Marsh #tests Compiled OrionEditor on Linux. Change 3008973 on 2016/06/10 by Marcus.Wassmer Fix Windualshock on VS2015 #rb Rolando.Caloca #test PS4 controller on VS2015 build Change 3008970 on 2016/06/10 by David.Ratti Fix warning about minimal replication tag count -Made bit count a config setting. Bumped to 5 -Minor optimization to UAbilitySystemGlobals::Get() #rb none #tests goldne path, pie Change 3008478 on 2016/06/09 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3008469 #RB:none #Tests:none Change 3008416 on 2016/06/09 by Andrew.Grant Adding 'config' as an option to set both clientconfig / serverconfig when using BuildCookRun #review-3008417 Ben.Marsh, Justin.Sargent #rb none #tests BuildCookRun with config Change 3008286 on 2016/06/09 by Dmitry.Rekman Add LinuxClient target platform. #rb none #tests Compile OrionEditor on Linux. #codereview Brad.Angelcyk, Ben.Marsh Change 3007978 on 2016/06/09 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3007507 #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith #ROBOMERGE-SOURCE: CL 3007968 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3007771 on 2016/06/09 by Laurent.Delayen Fixed GetIntFromComp breaking with INDEX_NONE. Fixes crash in OrientationWarping node. #rb martin.wilson #codereview martin.wilson #tests Sword Leap. Change 3007436 on 2016/06/09 by David.Ratti change designer facing parameter name #rb none #test compile Change 3007408 on 2016/06/09 by David.Ratti WaitGameplayEffectBlockedImmunity - ability task for listening to immunity events #rb danY #tests pie Change 3007250 on 2016/06/09 by bruce.nesbit Banner impact location fix. (OR-23179) #rb none #tests Game+PIE Change 3007228 on 2016/06/09 by Ben.Marsh BuildGraph: Rename -SkipNodesWithoutTickets parameter to -SkipTargetsWithoutTickets, to reflect that it's filtering the list of targets rather than the full graph. #rb none #tests none Change 3007225 on 2016/06/09 by Ben.Marsh EC: Set the -TicketSignature=... parameter for all BuildGraph jobs started by EC to the URL of the current job. Change 3006985 on 2016/06/08 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3006936 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3006978 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3006926 on 2016/06/08 by Andrew.Grant Merging //UE4/Main @ 300872 via //UE4/Orion-Staging #rb none #tests engine QA, orion qa smoke Change 3006444 on 2016/06/08 by Ben.Marsh BuildGraph: Add mechanism to specify that nodes can only be built once for a given changelist. Nodes can have an associated ticket file, and they are only permitted to build if the ticket is assigned to the current job. Tickets are created if they don't exist, and written with a signature specific to the job specified via the -TicketSignature="..." parameter. By default, builds will fail if a ticket has been already granted to another job, but the -SkipNodesWithoutTickets parameter instructs the graph to skip affected nodes instead. #rb none #tests none Change 3006389 on 2016/06/08 by Daniel.Lamb Delay the processing of packages which aren't ready till the end of the cook. This allows other packages to be processed sooner. #rb Peter.Sauerbrei #test cook orion. Change 3006306 on 2016/06/08 by Michael.Noland Rendering: Added FreezeRendering to the console autocomplete list #rn Change 3006305 on 2016/06/08 by Michael.Noland HLOD: Added a way to control how far down the HLOD hierarchy to allow showing (can be used to limit quality loss and streaming texture memory usage on high scalability settings for example) Controlled by the new cvar r.HLOD.MaximumLevel, which can be set to the following values: -1: No maximum level (default) 0: Prevent ever showing a HLOD cluster instead of individual meshes 1: Allow only the first level of HLOD clusters to be shown 2+: Allow up to the Nth level of HLOD clusters to be shown Note: This does not affect the memory used by the HLOD meshes itself or their always loaded low mip levels, it will only save the memory associated with streaming in the higher mip levels HLOD: Allowed r.HLOD console command to be used in Test configurations HLOD: Removed some dead code in ALODActor and scene view / scene proxy relating to a different way to force visualization that has no trigger HLOD: Fixed an uninitialized memory bug in the static mesh scene proxy HLODcoloration visualization code #rn #codereview jurre.debaare #rb marc.audy #tests Tested with various settings in Paragon and tried creating some new clusters in the editor Change 3006304 on 2016/06/08 by Michael.Noland Engine: Changed the code in AActor::IncrementalRegisterComponents to obey bAutoRegister for the root component rather than asserting that it is true. Note: If children components have bAutoRegister=true, they will still pull the root component into the fray and cause it to be registered first #rb marc.audy #tests Tested with code that registers or unregisters HLOD clusters at varying levels in Paragon Change 3006041 on 2016/06/08 by Andrew.Grant Added buildidoverride to shipping whitelist #rb none #tests compiled and used param in shipping Change 3005678 on 2016/06/08 by Ben.Marsh Back out changelist 3004395 #rb none #tests none Change 3005265 on 2016/06/07 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3005120 #RB: none #Tests: none #ROBOMERGE-SOURCE: CL 3005250 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3005081 on 2016/06/07 by Daniel.Lamb Reworked the way packages which are renamed on load are added to the cooked package list. Cooker now has options for MaxMemoryAllowance as a percentage and also MinFreeMemory (which takes into account used system memory not just total system memory). #rb Andrew.Grant, Marcus.Wasmer #test cook orion Change 3004752 on 2016/06/07 by Daniel.Lamb Requeue packages to the next package on the list instead of to the end of the list. #rb Andrew.Grant #test cook orion Change 3004560 on 2016/06/07 by David.Ratti Kill timelines, latent actions, timer when recycling gameplay cues #rb danY #tests pie Change 3004559 on 2016/06/07 by David.Ratti Object Library: -Added bool bIncludeOnlyOnDiskAssets that can be set by owner. Passed on to the AR filter when gathering assets. GameplayCue Editor: -Fix issue with new notifies not showing up after being created through the GC Editor (until restart). -Fix issue for new projects, that don't have gameplayclue tags defined, not being able to add gameplay cue tags through the editor without restarting once. #rb none #tests editor Change 3004395 on 2016/06/07 by Ben.Marsh BuildGraph: Add a script function to ensure exclusive access to a given resource. The AcquireLockFile() function takes two arguments; a path to a text file, and the name of an owner. The file is created and the owner name written to it if it doesn't already exist, otherwise the contents of it are compared against the given owner string. The operation happens transactionally, and the function returns true if file contains the given owner string on exit. Logical and/or conditions are now also short-circuited, so the result of the AcquireLockFile() function can be used to control derived property definitions within an executing job. #rb none #tests none Change 3004164 on 2016/06/07 by David.Ratti Ability system: use player controller netmode over avatar actor when possible. Fixes issue if torn off, authority, client side actor tries to activate an ability. #rb danY #tests multi pie Change 3003837 on 2016/06/07 by David.Ratti Ability system engine work -Default to /Game as search path for gameplay cues, if no explicit paths are set in the config. #rb none #tests ability sample project Change 3002800 on 2016/06/06 by Marcus.Wassmer Fix shader crash in PIE #rb none #test PIE Change 3002657 on 2016/06/06 by Dmitry.Rekman Do not copy to clipboard on crash if headless or on the wrong thread. - Could result in crash handler crashing itself in some circumstances. #rb none #codereveiw Brad.Angelcyk #tests Compiled Linux dedicated server and CrashReportClient. Change 3002546 on 2016/06/06 by Daniel.Lamb Improve cooking performance. Allow cooker to save other packages opportunistically if main package is compiling shaders. Allow cooker to load more packages if there aren't many packages to save. #rb Josh.Adams #test cook orion Change 3002369 on 2016/06/06 by Marcus.Wassmer Project setting for optional rendering features to reduce shader compile times. # of shaders per material is reduced by ~30-40% depending on material #rb Daniel.Wright #test Editor with/without all options, cooked ps4. Change 3002142 on 2016/06/06 by David.Ratti Ability system engine level: -Fix crash when gameplay cue editor starts if there are no gameplay cue paths specified -Fix crash when GameplayCue tag is not specified #rb none #tests sample ability system project, paragon Change 3002106 on 2016/06/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani #orion - add support for code tokens which can be shared/redeemed - refactor of existing friend founder's pack codes to be displayed in a generic way using code token info - added CodeToken.FounderFriendInviteT0 for new paragon tier 0 code which grants access to game without also giving a Founder's pack - added CodeToken.FounderFriendInviteT1 to replace existing CodeToken.FriendPC and CodeToken.FriendPS4 Founder's pack codes. Existing codes aliased to the new CodeToken.FounderFriendInviteT1 code - No longer differentiation between PC/PS4 friend codes - "Share Friend Code" button will now process all available codes that can be issued instead of just 1 - updated Orion service Mcp call for getUnredeemedCodes() to ignore the code template id and return all available codes. Each returned code will also include the type [CodeReviewed]: david.nikdel, jason.bestimt #rb david.nikdel #tests PC PIE using localhost and profile proxy for granting codes, also existing account with legacy codes #ROBOMERGE-SOURCE: CL 3002104 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3001218 on 2016/06/05 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3001162 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3001200 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 2999508 on 2016/06/03 by jason.bestimt #ORION_MAIN - Merge 27 @ CL 2999463 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2999498 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Audio/ClassesAndMixes/Classes/Master.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 2999465 on 2016/06/03 by Robert.Manuszewski Whitelisting more DLLs for injection. #rb none #tests none Change 2999455 on 2016/06/03 by Lukasz.Furman disabled path invalidation events for minions #orion #rb Mieszko.Zielinski #tests PIE with additional debug logging Change 2998488 on 2016/06/02 by Michael.Noland Engine: Prevent forced drawing of spline components in Test configuration #codereview james.golding #tests Ran a cooked Test build on a map with splines in it #rb david.ratti #robomerge: main Change 2997954 on 2016/06/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: jon.lietz OR-22425 no longer try to updat the tag map and modifiers when the gameplay effect that is being removed was not active. #RB Dave.Ratti #Tests golden path #ROBOMERGE-SOURCE: CL 2997940 in //Orion/Release-0.27/... via CL 2997943 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2997750 on 2016/06/02 by Graeme.Thornton Add FPakFile::Check() that attempts to open and read the data out of every file in a pak, to check for corruption Added -checkpak option for force a check of every mounted pak file #rb robert.manuszewski #tests tested against cooked pc client. made sure my data succeeded. made sure corrupted data throws an error. [CL 3031715 by Andrew Grant in Main branch]
2016-06-28 17:59:42 -04:00
UGameplayTask_ClaimResource* UGameplayTask_ClaimResource::ClaimResource(IGameplayTaskOwnerInterface& InTaskOwner, const TSubclassOf<UGameplayTaskResource> ResourceClass, const uint8 Priority, const FName TaskInstanceName)
{
if (!ResourceClass)
{
return nullptr;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465) #lockdown Nick.Penwarden Change 3110660 on 2016/9/1 by Andrew.Grant Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress. HLOD warning is updated every 20 secs to deal with streaing levels. Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon). #rb Michael.Noland #tests verified we see our unbuilt HLOD warning in v31 :( Change 3106649 on 2016/08/30 by Cody.Haskell #Orion - Input Axis Work #rb DanH #tests PIE Change 3106299 on 2016/08/30 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 31.2 @ CL 3105865 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3106213 on 2016/08/30 by Ben.Marsh BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file. #rb none #tests preflight Change 3105994 on 2016/08/30 by Martin.Wilson Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input) #jira UE-35289 #rb Thomas.Sarkanen #tests Tested UI in editor Change 3105331 on 2016/08/29 by Uriel.Doyon Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget. #rb marcus.wassmer #tests launched editor and played game #jira OR-25814 Change 3105143 on 2016/08/29 by Josh.Markiewicz #UE4 - added assert when histogram input parameters don't match #rb none #tests launched/ran/won game golden path #codereview dmitry.rekman, michael.noland, bart.bressler Change 3104976 on 2016/08/29 by Jon.Lietz pickup refector - fixed a big that would allow mixed replication to call a gameplay cue's added twice. - All pickups now use the pick up manager, consolidated all pick up code into the manager. - added to the XP set so we can define the CXP bounty for targets. #RB Dave.Ratti #tests Bot match, test maps, spawning coins and pickups. Change 3103480 on 2016/08/26 by Josh.Markiewicz #UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession #rb none #tests golden path matchmaking #codereview paul.moore, eric.newman Change 3103410 on 2016/08/26 by Max.Chen Movie Capture: Fix commandline burnin option. #rb none #tests Render movie with commandline -UseBurnIn=yes option. Change 3102134 on 2016/08/25 by Brian.Karis Fix for HDR output exposure. Added 1000nit output option. #rb marcus #tests agora Change 3101276 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_31 - Merging CL 3100347 (head revision of 2 files :o ) #RB:none #Tests:none [CodeReviewed]: matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3101267 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_DUI - Integrating Media changes from 4.13 (head revision) #RB:none #Tests:none /Engine/Plugins/Media /Engine/Source/Runtime/Media /Engine/Source/Runtime/MediaAssets [CodeReviewed] matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100378 on 2016/08/24 by John.Pollard Fix a crash that can occur when scrubbing in replays #codereview David.Ratti #tests Replays #rb DavidR This is the output: [2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage Change 3100375 on 2016/08/24 by Laurent.Delayen Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket). #rb none #codereview lina.halper #tests Tacticia's RMB Targeting Change 3100278 on 2016/08/24 by Laurent.Delayen Fix for fast path struct copy being broken for FVectors. #rb lina.halper #codereview thomas.sarkanen #tests Chains' hook, Tacticia's LaserBeam and OrientationWarping Change 3100161 on 2016/08/24 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix issue with refresh viewer command failing due to backend congestion #rb RyanG #tests Replays Change 3100114 on 2016/08/24 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3098849 #RB:none #Tests:none #CodeReview: kerrington.smith, matt.schembari #R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100015 on 2016/08/24 by Michael.Noland Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node #jira UE-34998 #rb Aaron.McLeran [re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13] #tests Compiled and ran a golden path match with headphones on Change 3100012 on 2016/08/24 by Michael.Noland UE-34951 - Zero-volume vorbis decoded sounds are too expensive -Adding an audio settings parameter to disable zero-volume playback globally -Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume #rb marc.audy [re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran] #tests Compiled and ran a golden path match with headphones on Change 3099889 on 2016/08/24 by Max.Chen Sequencer: Added command line option to enable burnin #rb none #tests Render movie from command line wtih -UseBurnIn=yes Change 3099801 on 2016/08/24 by Lina.Halper Removed unnecessary comment #rb: none #code review: Benn.Gallagher #tests: compile Change 3099787 on 2016/08/24 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #http - fix for cancelled requests that have not been started never triggering a completion delegate - fixes soft lock when handling disconnects during login OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting #rb josh.markiewicz, alex.fennell #tests none #R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3099252 on 2016/08/24 by Lina.Halper Fixed menu text #rb: none #code review: Thomas.Sarkanen #tests: open editor and create child montage and replaced the animation Change 3099251 on 2016/08/24 by Lina.Halper Deterministic cooking of skeleton - abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked #jira: UE-34834 #rb: Martin.Wilson #tests: cooking orion and make sure it works Change 3098504 on 2016/08/23 by Bart.Bressler Add server time between sending packets monitoring histogram #rb dmitry.rekman #tests ran server locally and made sure analytics events were sent Change 3098494 on 2016/08/23 by Michael.Noland Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements - Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer) - Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected #tests Tested by calling while stat dumphitches was active and confirmed that the interval changed #codereview ben.salem, gil.gribb #rb none Change 3098491 on 2016/08/23 by Mieszko.Zielinski Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4 #rb Lukasz.Furman #test golden path Change 3098070 on 2016/08/23 by Lina.Halper Fix crash with UI update reconstructing - will have to come up with a better solution than this. #rb: Martin.Wilson #tests: child anim montage Change 3097914 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel Merging CL #3097879 from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/... to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/... #Analytics #OSS: Adjusted cohort selection algorithm and test cases [CodeReviewed]: Philip.Buuck #TESTS: unit tests #RB: none #R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097745 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Megre 30.2/31 @ CL 3096895 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097722 on 2016/08/23 by Chris.Bunner Update texture expression properties before triggering parent material recompile. #rb John.Billon #tests Editor replace references, Golden path #jira OR-27531 Change 3097694 on 2016/08/23 by Lina.Halper #Child Anim Montage - Duplicate from parent of the information it cares to get - Currently it is selective on copying what data - Modified GetAllAnimationSequencesReferred to get a partial data - Added ParentAsset/AssetMappingTable in AnimationAsset - Sequence Browser opening would also add to history - AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on #code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti #rb:Martin.Wilson #tests: creating child montage, editing, lots of UI functionality, notifies placement Change 3097513 on 2016/08/23 by Thomas.Sarkanen Non-POD structs can now be copied using the fast path We now always use CPP struct ops to perform copies when dealing with struct properties. #jira UE-34571 - Support struct member access on AnimBP fast path #rb Laurent.Delayen #tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games. Change 3096729 on 2016/08/22 by Mieszko.Zielinski Fixes to EQS scoring function preview #UE4 #rb Lukasz.Furman #test golden path Change 3096596 on 2016/08/22 by Jason.Bestimt #ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970) #RB:none #Tests:none #CodeReview: matt.schembari, max.preussner #R@BOMERGE: MAIN Change 3096550 on 2016/08/22 by Jurre.deBaare Fix for HLOD dirty clusters PIE warning message #tests Simulated Origin with built HLOD clusters, and with one dirty cluster #rb none Change 3096532 on 2016/08/22 by Mieszko.Zielinski Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4 As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized #codereview Lukasz.Furman #rb none #test golden path Change 3096455 on 2016/08/22 by Jason.Bestimt #R@BOMERGE-AUTHOR: keli.hlodversson #CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases #RB David.Nikdel #TESTS none #R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3096316 on 2016/08/22 by Sammy.James Resave to fix log warnings. BPC changes to ensure type saves. #rb #tests editor Change 3096040 on 2016/08/22 by bruce.nesbit Revised fix for landscape crash #rb GarethM #tests Game #codereview Bart.Bressler Change 3096015 on 2016/08/22 by bruce.nesbit Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server #rb none #tests game #codereview Bart.Bressler Change 3095578 on 2016/08/19 by Mieszko.Zielinski Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4 This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor #rb none #test golden path #codereview Lukasz.Furman Change 3095397 on 2016/08/19 by Lina.Halper Fix issue with crash when deleting all segment #rb: Laurent.Delayen #tests: delete segment and make sure it doesn't crash #jira: UE-34830 Change 3095060 on 2016/08/19 by Bart.Bressler Don't load ULandscapeComponent objects on dedicated servers to save memory. #tests cooked server data and played a Solo vs. AI game #rb gareth.martin #codereview james.golding Change 3095037 on 2016/08/19 by Lina.Halper Potential fix with montage trigger ensure on marker sync group #jira: OR-27685 #rb: Benn.Gallagher #code review: Martin.Wilson #tests: attack primhelilx with knock up Change 3094962 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort #RB: None #TESTS: test suite in source [CodeReviewed]: Philip.Buuck #R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094950 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merge #UE4 - Made FMD5 const-correct #RB: none #TEST: none #R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094619 on 2016/08/19 by Lina.Halper #DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID. - assumed the name is all set by now #rb: Benn.Gallagher #jira : UE-34886 #tests: cooking infiltrator that showed same issue and run game. Change 3094532 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3094498 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3093260 on 2016/08/18 by Josh.Markiewicz #UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel) - removed unnecessary cast #rb bart.bressler #codereview bart.bressler, rob.cannaday #tests launched game, some basic party testing Change 3093224 on 2016/08/18 by Josh.Markiewicz #UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games #rb paul.moore #codereview anthony.carter #tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining Change 3092597 on 2016/08/17 by Daniel.Lamb Added Ben Crocker to the rebuild lighting emails. #rb Trivial #Test none Change 3092063 on 2016/08/17 by andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb #tests none Change 3091081 on 2016/08/16 by Jurre.deBaare Fixing non-Editor build errors #fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty) #tests Build Editor + Game #rb none Change 3091009 on 2016/08/16 by Mieszko.Zielinski Added a way to configure a map to not spawn AISystem instance at all #UE4 #rb none #test golden path Change 3090932 on 2016/08/16 by Michael.Noland Vixen: Added indication to the analytics and FPS charts #rb marcus.wassmer #tests Compiled for the platform Change 3090844 on 2016/08/16 by Laurent.Delayen Replicated CL 3090734 from Fortnite. --- Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage Here's the issue in the version of the code prior to this checkin: - UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped - When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value - So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick - It also means if we were playing a montage, and then stop, we'll start ticking - Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing #codereview john.abercrombie #rb none #tests golden path Change 3090832 on 2016/08/16 by Michael.Noland Windows: Fixed a whitespace issue #rb none #tests Compiled for windows Change 3090688 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb none #tests built #R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3090547 on 2016/08/16 by Jurre.deBaare Need a warning message similar to lighting unbuilt when HLOD cluster is not built #fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour #jira UE-34335 #rb none #codereview Michael.Noland #tests pie Agora with and without dirty HLOD clusters Change 3090285 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3090267 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3089413 on 2016/08/15 by paul.mader Agora 2.0 assets Change 3089266 on 2016/08/15 by Max.Chen Sequencer: Add Convert to Possessable Copy from Dev-Sequencer #jira UE-32139 #rb none #tests Convert steel to possessable in Gameplay_PS4 map. Change 3089136 on 2016/08/15 by Mieszko.Zielinski Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4 #rb Lukasz.Furman #codereview Dan.Youhon #test golden path Change 3089118 on 2016/08/15 by Mieszko.Zielinski Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4 #rb none #test golden path Change 3088976 on 2016/08/15 by Andrew.Grant Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules. Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting. Removed superflous /Os from VC debugg settings #rb none #tests verified module built with 'Never' on PS4/Win is built without optimizations. #codereview Marcus.Wassmer, Ben.Marsh Change 3088830 on 2016/08/15 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3088807 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3088597 on 2016/08/14 by Jason.Bestimt #ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG) #RB:none #Tests:none #CodeReview: andrew.grant, david.ratti, matt.schembari Change 3087827 on 2016/08/12 by Bart.Bressler Updates to skeletal mesh memory saving on dedicated server #rb lina.halper #tests Cooked server data, played a game for a while in Solo vs. AI Change 3087351 on 2016/08/12 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) #jira OR-27406 #rb RyanG #tests Replays Change 3087118 on 2016/08/12 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3086747 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3086176 on 2016/08/11 by Marcus.Wassmer Fix PS4 ShaderPipelines not matching pixel/vertex shader properly. #rb Rolando.Caloca #tests Broken PS4 content before/after Change 3085992 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Unclog R@BOMERGE #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3085911 on 2016/08/11 by Laurent.Delayen Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex #rb none #tests Orientation Warping Change 3085614 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3085547 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3084507 on 2016/08/10 by Marcus.Wassmer Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen. #rb none #tests paragon ps4/vixen #codereview Olaf.Piesche Change 3084136 on 2016/08/10 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3083799 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083424 on 2016/08/09 by Max.Chen Sequence Recorder: Fix crash when actor class to record is null. #tests Use sequence recorder to record a skeletal mesh actor #rb none Change 3083134 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #online,store,ps4 - creating one offer entry per entitlement #rb david.nikdel, ian.fox #tests MTX purhcase on PS4 #lockdown: andrew.grant #R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083069 on 2016/08/09 by Marcus.Wassmer Vixen scalability changes #rb Michael.Noland #tests vixen/ps4 #codereview jordan.walker Change 3083063 on 2016/08/09 by Marcus.Wassmer Most games will probably run out of memory if setup to do auto-4k. Make this a setting that's off by default. #rb Michael.Noland #codereview Luke.Thatcher, Lee.Clark #tests vixen on 4k. Change 3082778 on 2016/08/09 by Marcus.Wassmer Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087) #rb none #tests Agora on vixen. Change 3082772 on 2016/08/09 by Marcus.Wassmer Duplicate fix for detail mode reregistration (3065543) #rb none #tests Toggled detail mode, observe proper items spawning Change 3082765 on 2016/08/09 by Marcus.Wassmer Don't crash when trying to use windowed vsync on vixen #rb Michael.Noland #test ran paragon on vixen #codereview Luke.Thatcher,Lee.Clark Change 3082764 on 2016/08/09 by Marcus.Wassmer fix HLOD distance scale not working properly when components are re-registered. #rb michael.noland #codereview jurre.debarre #tests setting multiple times, setting on boot via deviceprofile Change 3082429 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani Merging //Orion/Release-30.1 to Main (//Orion/Main) Change: 3082419 #online,store,PS4 OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen - added config option for toggling store on PS4 [OnlineSubsystemPS4] bStoreEnabled=true - can also override via title specific json values in <titleid>\title.json allow_mtx=true [CodeReviewed]: andrew.grant, phillip.buck, ian.fox #lockdown: andrew.grant #rb none #tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support) #R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3082194 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3082105 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080984 on 2016/08/08 by Lina.Halper Issue with not being able to set static animation data via BP - artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP - also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called. #rb: Martin.Wilson #tests: Sword Beauty map Change 3080665 on 2016/08/08 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3080081 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080565 on 2016/08/08 by Laurent.Delayen Fix for curve values during URO interpolation. Fixes flashing of materials and Twinblast's ult weapon. https://jira.ol.epicgames.net/browse/OR-27107 https://jira.ol.epicgames.net/browse/OR-24358 #rb lina.halper, martin.wilson #tests Twinblast's ult and Coil's primary. Change 3079832 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: marcus.wassmer Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline #rb none [CodeReviewed] Chris.Wood #tests checked crashcontext on PC/PS4 #lockdown Andrew.Grant #R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3079045 on 2016/08/05 by Lina.Halper Adding more log to figure out why ActivePlayers.Count becomes inconsistent. #rb: Martin.Wilson #tests: PIE with bots Change 3078944 on 2016/08/05 by Rolando.Caloca O - Update blacklisted driver #jira OR-27051 #rb Marcus.Wassmer #tests Run with AMD card Change 3078735 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3078670 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3078122 on 2016/08/04 by Dmitry.Rekman Linux: treat abort() / SIGABRT as crash. - Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler. - Rewrote RequestExit() because it used abort() itself. - Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason. #rb Mark.Satterthwaite #codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant #review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant #tests Ran Linux server, crashed using different methods. Change 3077887 on 2016/08/04 by Dmitry.Rekman Initialize StackCount to 0 (kills valgrind warning). #rb David.Ratti #codereview David.Ratti #tests Ran Linux server. Change 3077257 on 2016/08/04 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3077193 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3077242 on 2016/08/04 by Dmitry.Rekman Linux: stop heartbeat thread before handling the crash. #rb Robert.Manuszewski #codereview Robert.Manuszewski, Andrew.Grant #tests Compiled and ran Linux server, crashed it. Change 3076676 on 2016/08/03 by Dmitry.Rekman Linux: print details about memory access (read or write). - Also print all the 16 digits of the pointer. - Read/write detection only implemented for x86_64. #rb Andrew.Grant #codereview Andrew.Grant #tests Compiled (natively) and ran Linux server. Change 3076675 on 2016/08/03 by Dmitry.Rekman Print a bit more info about the array in assert. #rb Andrew.Grant #codereview Andrew.Grant #test Compiled and ran Linux server. Change 3076010 on 2016/08/03 by Laurent.Delayen Moved OrionAnimNode_LegIK from Paragon to Engine. #codereview lina.halper #rb none #tests Grim.exe + Iggy & Scorch Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt Reimplemented 3070766 for Orion: Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash) #rb none #tests none Change 3075446 on 2016/08/03 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3075422 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3075394 on 2016/08/03 by HaarmPieter.Duiker Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in. #rb marcus.wassmer #tests post process color correction Change 3074314 on 2016/08/02 by Dmitry.Rekman Linux: change optimization from -O2 to -O1 (temporarily?). - The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier. - Also adds a line to UBT output during compilation to draw attention. #rb Michael.Noland #codereview Michael.Noland, Andrew.Grant, Bart.Bressler #tests Compiled and ran Linux server. Change 3073553 on 2016/08/02 by jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3073360 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) #R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3073505 on 2016/08/02 by Daniel.Lamb Added cook modification delegate stats to cooker stats. #rb Wes.Hunt #test cook paragon. Change 3072440 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries. #rb none #tests SHIPPING Change 3072259 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback. #rb Michael.Noland #tests PIE Change 3071908 on 2016/08/01 by John.Pollard Fix null reference crash #rb DavidR #tests Live game + replays Change 3071876 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player #rb none #tests FN + Paragon live game + replays #codereview Andrew.Grant Change 3071875 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Finalize replay version system * No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions) * Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore. * Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions) #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071874 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix gameplay tags to work better with backwards compatibility in replays * We use the net field export group system in the package map to export tag names as a packed index * This will allow us to see the names of tags that no longer exists on the remote side #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071776 on 2016/08/01 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3071738 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3071258 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together. - Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now. #rb none #tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues. Change 3071099 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads. #rb none #tests ran paragon with change and noticed no change in audio quality Change 3070916 on 2016/07/29 by Andrew.Grant Missed file! #rb #tests na Change 3070915 on 2016/07/29 by Andrew.Grant Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging #rb none #tests Engine QA, Orion QA smoke Change 3070576 on 2016/07/29 by Uriel.Doyon Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize. #review-3070386 @marcus.wassmer #jira OR-25941 #rb marcus.wassmer #tests Run Game on PS4, and in editor Change 3070086 on 2016/07/29 by Martin.Wilson Fixed ensure triggering during sequencer playback due to double update. #jira UE-33938 #rb Thomas.Sarkanen #tests opened affected asset and verified problem no longer occured Change 3070016 on 2016/07/29 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30 @ CL 3069935 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3069435 on 2016/07/28 by Ian.Fox #Orion, #Mcp - Check if Price Engine is configured before attempting query #rb Sam.Zamani #tests none #codereview Sam.Zamani Change 3069381 on 2016/07/28 by Michael.Noland Animation: Demoted a check() in anim sync group code to an ensure() to unblock others #rb nick.penwarden #tests Loaded Paragon cine asset that was crashing #codereview lina.halper, martin.wilson Change 3069203 on 2016/07/28 by Dmitry.Rekman Headless client: do not draw windows. - Disables a bunch of code, including reaching into font cache to estimate width. - Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets). #rb Nick.Atamas #review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem #codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem #tests Compiled and ran Orion Linux client. Change 3069181 on 2016/07/28 by Lina.Halper Fix struct redirector for Orion anim node moving to engine #rb: Maciej.Mroz #code review:Laurent.Delayen #tests: editor loading the anim BP that caused the name conversion Change 3069092 on 2016/07/28 by Aaron.McLeran OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves - Not all active sounds have sound classes, was causing a crash #codereview marc.audy #rb zabir.hoque #tests Run game with stat soundcues and not crash Change 3068969 on 2016/07/28 by David.Ratti Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too. #rb none #tests compile Change 3068902 on 2016/07/28 by David.Ratti Code for tracking down UGameplayCueManager::GetInstancedCueActor crash. #rb none #tests compile Change 3068831 on 2016/07/28 by Aaron.McLeran OR-26417 Reverb is too loud in-game in Dev-General - Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set. #rb Jeff.Campeau #tests run a map with no reverb audio volume and reverb is not super wet Change 3068529 on 2016/07/28 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config) #RB: none #TESTS: none #R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3068399 on 2016/07/28 by Andrew.Rodham Sequencer: Changed animation tracks to allow more animation types (such as anim montages) - APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility #jira OR-25769 #tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly. #rb Benn.Gallagher Change 3068138 on 2016/07/28 by Marcus.Wassmer Disable mallocleak testing by default #rb none #test none Change 3068121 on 2016/07/28 by Marcus.Wassmer Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled. Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also. #rb Robert.Manuszewski #tests stack tracing / symbolication with mallocleak on windows. Change 3068119 on 2016/07/28 by Marcus.Wassmer Fix MallocLeakProxy deadlock #rb Robert.Manuszewski #tests mallocleak start/stop/dump on windows Change 3067752 on 2016/07/27 by Michael.Noland Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands - IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer - The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class. - The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered - Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code Upgrade Notes: - DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly - In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands) - HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name) - Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future) Paragon: - Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event - Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it. #rb dmitry.rekman #codereview bob.tellez, peter.knepley, andrew.grant, john.mauney #review-3067607 @Dmitry.Rekman, @Bob.Tellez #tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI Change 3067654 on 2016/07/27 by Michael.Noland FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path. #rb steve.robb #jira UE-31959 [duplicating CL# 3039827] #tests Tried moving a folder in the editor Change 3067644 on 2016/07/27 by Aaron.McLeran OR-24537 Looping audio sometimes persists in Agora Adding stopping sounds if audio component is destroyed while playing a looping sound #rb jeff.campeau #tests audio component stops looping sound if audio component is destroyed prematurely Change 3067560 on 2016/07/27 by Aaron.McLeran OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters - Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call - using xaudio2 operation sets to ensure that voice and effect params are executing in sequence - only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands - Don't call EnsureCompletion on pending async tasks on teardown #rb Jeff.Campeau #tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions Change 3067420 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge 29.2/30 @ CL 3067312 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067316 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3065602 #RB:none #Tests:none [CodeReviewed]: matt.schembari #R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067025 on 2016/07/27 by Michael.Noland Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes #rb none #tests Compiled Change 3067020 on 2016/07/27 by Michael.Noland Core: Various improvements to FHistogram and split it out into separate files - Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate) - Added O(1) getters for total sample counts and sum of all measurements - Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex - Added support for specifying explicit histogram bucket thresholds #rb dmitry.rekman #tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage Change 3066681 on 2016/07/27 by Frank.Gigliotti Camera anim field of view fix; * The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value. * Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees. #RB None #CodeReview Jeff.Farris #Tests Multiple camera animations in PIE Change 3066508 on 2016/07/27 by Lina.Halper Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name. #code review:Martin.Wilson, Benn.Gallagher #rb: Martin.Wilson #tests: cooked test map, run test map, PIE, saving content, loading standalone game Change 3066246 on 2016/07/27 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Fix for non-unity error #rb none #tests compiled #R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3066167 on 2016/07/27 by Benn.Gallagher Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding. #rb Ori.Cohen #tests Editor, PIE, Applying clothing to characters. Change 3065868 on 2016/07/27 by Michael.Noland Blueprints: Fixing non-editor build (missing WITH_EDITOR) #rb none #tests Compiled PS4 Change 3065749 on 2016/07/26 by Michael.Noland Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead) #codereview mike.beach, marc.audy #tests Loaded and recovered a corrupted Blueprint on Cameron's machine #rb Phillip.Kavan Change 3065706 on 2016/07/26 by Josh.Markiewicz #UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons - fixed non shipping cmd line override to be correct #rb none #codereview andrew.grant, paul.moore #tests none Change 3065359 on 2016/07/26 by Rob.Cannaday Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit. Break up calls in batches of 100 ids. #jira OR-20674 #rb ian.fox #tests login to front end with PC, PS4. forced tests to simulate > 100 requests. Change 3065197 on 2016/07/26 by Bart.Bressler Change how PS4 sessions work: - We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions. - Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable - Added comments, other misc. code cleanup. #rb josh.markiewicz, sam.zamani, rob.cannaday #tests created cross play parties with multiple pc + ps4 players #jira OR-20332 Change 3065158 on 2016/07/26 by Lina.Halper Fix the guid keep generated by adding to the database. - This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible #rb: Martin.Wilson #jira: UE-33772, UE-33454 #tests: cooked AI_Test map, editor rename curves Change 3064735 on 2016/07/26 by Dmitry.Rekman Linux: added WebRTC libs. - Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc). #rb none #tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform. (Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064727 on 2016/07/26 by Dmitry.Rekman Fix crash on cooker exit (UE-33583). - Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it. #rb none #tests Compiled and ran Linux server and Linux client. (Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064725 on 2016/07/26 by Dmitry.Rekman Linux: use libc++ instead of libstdc++. - Needed to solve problems with third-party C++ libraries (e.g. WebRTC). - Bundled libc++ 3.8.1 (TPS cleared). - Turned off ICU compilation (needs recompile against libc++). - Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix. #rb none #tests Built and ran a number of Linux targets. (Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064572 on 2016/07/26 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 29.2 @ CL 3064545 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3064523 on 2016/07/26 by Jon.Lietz Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements. #RB none #tests BP compiles and stays not dirty #codereview dave.ratti@epicgames.com [CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
UGameplayTask_ClaimResource* MyTask = NewTaskUninitialized<UGameplayTask_ClaimResource>();
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3028454) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3028439 on 2016/06/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 28 @ CL 3028090 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3028437 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3027952 on 2016/06/26 by Jurre.deBaare - Integrating code fixes/changes from Simplygon for Normals issue on Simplygon Swarm + landscape culling - Readded landscape/volume culling for in-engine static mesh merging path - Fixed issue with r.HLOD force -1 (now stops forcing hlods) - Marked hlodcullingvolume as experimental - Added Landscape culling flag + precision level #codereview Michael.Noland #rb Michael.Noland #tests build clusters locally/cloud + landscape culling tests Change 3027702 on 2016/06/25 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3027698 #RB:none #Tests:none Change 3027312 on 2016/06/24 by Daniel.Lamb Changed the way reentry data is stored in the cooker, reduce work load by main thread, also fix issue with reentry data being used from incorrect packages. #rb Peter.Sauerbrei #test QA game launch on and cook by the book + cook on the fly paragon Change 3027165 on 2016/06/24 by Daniel.Lamb Fix compiler warnings from cvars changes. #rb none #test cook paragon Change 3026900 on 2016/06/24 by Daniel.Lamb Change the way low quality lightmap shaders are enabled / disabled as the engine can't be used in the should cache function. #rb Marcus.Wasmer #test Cook on the fly paragon #codereview Rolando.Caloca Change 3026874 on 2016/06/24 by Olaf.Piesche #jira OR-18363 fix distortion in particle macro UVs with camera movement #rb frank.fella #tests PC Editor/Game Change 3026494 on 2016/06/24 by jason.bestimt #ORION_MAIN - Merge 28 @ CL 3026460 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3026476 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3026381 on 2016/06/24 by Graeme.Thornton Strip particle modules, emitters and lodlevels from cooked server data. Saves ~10mb of runtime memory on Paragon #rb simon.tovey #codereview dmitry.rekman #tests pc cooked client/server, golden path Change 3025760 on 2016/06/23 by jason.bestimt #ORION_MAIN - Merge 28 @ CL 3025687 #RB:none #tests:none #ROBOMERGE-SOURCE: CL 3025709 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Sword/Meshes/sword.uasset - can't integrate exclusive file already opened //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Sword/Meshes/sword_Skeleton.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3025661 on 2016/06/23 by Mieszko.Zielinski Added a feature to PathfollowingComponent allowing it to identify when it starts following a navigation link #UE4 #rb Lukasz.Furman #test golden path Change 3025359 on 2016/06/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani #online,externalui,ps4 - expose access to reset cookies before invoking embedded web browser - fixed not capturing resulting Url when PS4 browser is closed #rb none #tests ps4 #ROBOMERGE-SOURCE: CL 3025356 in //Orion/Release-28/... via CL 3025358 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3025184 on 2016/06/23 by Lina.Halper Fix crash with morphtargets #jira: OR-24257 #rb: Rolando.Caloca #tests: switching mesh with different morphtargets in editor Change 3024714 on 2016/06/23 by Lukasz.Furman added vlog extension to visual debugger tool, added object whitelist to vlog to include selected minion data in games started with -LogBotGame param #rb Mieszko.Zielinski #tests server game with and without LogBotGame cmdline Change 3024709 on 2016/06/23 by Daniel.Lamb Added support for async save when saving seperate bulk data file. Added mb saved to cooking package stats. #rb Andrew.Grant,Wes.Hunt #test Cook Paragon Change 3024674 on 2016/06/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani Merging //Orion/Release-28 to Main (//Orion/Main) #online,identity,ps4 - add psplus flag to online account after privilege check #rb none #tests ps4 login flow #ROBOMERGE-SOURCE: CL 3024672 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3024510 on 2016/06/23 by Graeme.Thornton Added more info to the dumpparticlesystems exec command output #rb simon.tovey #tests cooked pc client, golden path Change 3024504 on 2016/06/23 by Graeme.Thornton Asset registry memory optimisation - make sure all dependency node link arrays are sized exactly as they need to be (saves ~1mb) #rb robert.manuszewski #tests windows cooked client, golden path Change 3024213 on 2016/06/22 by Ryan.Gerleve Handle a rare case in replays where the spectator controller is null but we still find a valid NetGUID for it. Added an ensure before a check that would fail in this case so we'll know if it happens again. #tests replays #rb john.pollard Change 3024127 on 2016/06/22 by John.Pollard Bulk merge using Dev-Networking_->_Dev-General_(Orion) 3002989 Add ability to skip missing/changed properties in FFastArraySerializer 3003072 Fix crash related to new replay backwards compatibility changes 3008097 Renaming CompatibleReplayout to NetFieldExportGroup preparing to unify ability to use FNetFieldExportGroup for both RepLayout and FClassNetCache 3009684 Added ability to use FNetFieldExportGroups for FClassNetCache as well as FRepLayout * Adds ability to track missing/changed custom delta properties names * Adds ability to track missing/changed RPC's 3013455 Add ability to skip over RPC parameters that have changes/missing in replays for backwards compatibility * We now mark FClassNetCache properties as bIncompatible so we don't spam forever when they are out of date * No longer factor in parameters when building checksum for RPC's * Save FNetFieldExport handle for FClassNetCache fields * Use WriteIntWrapped when saving FClassNetCache fields FNetFieldExport handles (and use NetFieldExportGroup->NetFieldExports.Num() to determine max value) * Lots of cleanup and sanity checking improvements 3018078 Optimize replay checkpoints * Share work that was already done during normal replication, and re-use this data to remove the need to compare any checkpoint properties * When saving a checkpoint, we no longer create a new connection and new channels, instead we re-use the existing channels, and added the ability to make this a transient operation * To make custom delta serialize properties work, we compare against the CDO state instead of current state when saving out a checkpoint 3021196 Fix issue with Fast tarray exporting package map info during checkpoints * Add ability to save and restore package map ack status * Save package map ack status before saving checkpoint, and then restore it back afterwards, this will then allow the stream that writes afterward to re-export anything that was new in the checkpoint * No longer queue up reliable bunches on ack list for internal ack connections 3024033 Prune the cached change list before using when saving out checkpoints * Fixes issues when saving checkpoint, and the live properties change array size, which throws everything off when it comes time to use the LifetimeChangelist 3024034 Don't close channels when saving checkpoints, fixes issue where it creates a bunch with bOpen/bClose (because we're forcing all SendBunches to re-open channels), which throws off the stream #rb RyanG #tests Replays Change 3024021 on 2016/06/22 by Dmitry.Rekman Fix PS4 build. #rb Michael.Noland #tests none #codereview Michael.Noland, Dan.Youhon, Sammy.James Change 3023734 on 2016/06/22 by Lukasz.Furman added replication for input events and tool state for both gameplay debugger categories and extensions #ue4 #rb Mieszko.Zielinski #tests PIE, server game Change 3023708 on 2016/06/22 by Dmitry.Rekman Add a separate macro for a poison malloc proxy usage. #rb Michael.Noland #codereview Michael.Noland, Gil.Gribb #tests Compiled OrionServer-Linux-Debug, ran it Change 3023670 on 2016/06/22 by Nick.Darnell Home screen - Fixing safezones on the homescreen. Adding a scale option to the XP_Fill widget. Adding better animations to the tiles. Showing subtitles again. Hero XP summary widget now takes you to that hero. #rb none #tests PIE Change 3023632 on 2016/06/22 by Dmitry.Rekman Fix incorrect matching condition in comments. #rb none #tests Compiled OrionServer-Linux-Debug #codereview Michael.Noland Change 3023475 on 2016/06/22 by Rolando.Caloca O - Back out changelist 3022847 as it broke SSS on PC #rb none #tests re-run editor on PC Change 3023178 on 2016/06/22 by Michael.Noland Engine: Added system memory and % of time spent hitching to analytics #rb bob.tellez #tests Tested a match in Paragon Change 3022963 on 2016/06/22 by Mieszko.Zielinski Fixed a subtle navigation repathing bug #UE4 While repathing to a location, rather than an actor, the navigation query used path's end while it should be using the original query's EndLocation. #rb Lukasz.Furman #test golden path Change 3022865 on 2016/06/22 by David.Ratti gameplay cue editor: remove "GameplayCue_" prefix from default GameplayCueNotify filename in default ability system projects #rb none #tests ability system sample project Change 3022847 on 2016/06/22 by Rolando.Caloca O - Remove checkerboard SSS rendering and recombine post process pass when SSS not enabled #rb Marcus.Wassmer #codereview Marcus.Wassmer, Brian.Karis #tests Load Agora_P, check perf, toggle r.SSS.Quality 1/0, check characters with skin Change 3022804 on 2016/06/22 by Mieszko.Zielinski Fixed AIController clearing out CachedGameplayTasksComponent on UnPosses, even if Pawn was not the CachedGameplayTasksComponent's owner #UE4 Also, made running BT not clearing info in BB if AI's current BB is compatible with the one required by BT #rb Lukasz.Furman #test golden path Change 3022674 on 2016/06/22 by Robert.Manuszewski Reimplementing CL #2993969 (Dev-Blueprints) by Maciej.Mroz: UE-30729 Crash in Native Orion when selecting Sword or Tomahawk Clear AsyncLoading in subobjects. #jira OR-23997 #rb me #tests Golden path in editor build, selecting Venus Change 3022405 on 2016/06/21 by Ryan.Gerleve Fix for OR-23948, crash with death cam enabled. Use a weak pointer to store the viewer on the DemoNetDriver and update it when the game player controller is received. #rb john.pollard #tests bug repro Change 3022387 on 2016/06/21 by Ryan.Gerleve Added the ability to disable ticking of individual worlds. #tests golden path #rb john.pollard #codereview marc.audy Change 3022312 on 2016/06/21 by Nick.Darnell Home Screen - Adding a max aspect ratio lock to SBox, may need some more fine tuning math may still be a bit pants in some cases. The XP ovewview panels now have a basic support for account and hero progression. Hero one shows the last hero you played, widget is invisibile until you play your first game. The tiles now use the Max Aspect Ratio to prevent stretching forever on 21:9 monitors causing them to just look crazy. Weekly quests now show the weekly quests screen when clicked. OrionUserWidgetBase no longer prevents blueprints from running code in reponse to mouse down/up actions if the userwidget consumes input - it always calls the blueprint code first, and always returns handled if it consumes input. #rb none #tests PIE Change 3022207 on 2016/06/21 by Wes.Hunt Fix Analytics provider to retain passed in AppVersion string instead of using default %VERSION%. #rb none #tests run windows server with one bot connecting and checking analytics version is what is expected. Change 3021808 on 2016/06/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - call GetTotalMicroseconds instead of GetTotalMilliseconds * 1000 #rb none #tests compile run ps4 #ROBOMERGE-SOURCE: CL 3021805 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3021663 on 2016/06/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - CancelFindSessions() didn't null out search result - future FindSession() calls would fail with "search in progress" #rb joe.wilcox #tests UT matchmaking #ROBOMERGE-SOURCE: CL 3021655 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3021508 on 2016/06/21 by Marcus.Wassmer Remove anti-ghosting AA for now. Causes dithered transparency to be very wrong (Dekker shoulders) And also a border around all characters of 'noisy fuzz' even when they are not moving #rb none #test PC/PS4 #codereview Brian.Karis,Jordan.Walker Change 3021475 on 2016/06/21 by Marcus.Wassmer Duplicate fix for subsurface spec in prep for PS4 optimization. (DevRendering 3018664) unified some code for easier maintainance, fixed missing multiply from former change #rb none #test PS4/PC agora Change 3021468 on 2016/06/21 by Michael.Noland Physics: Added more information when convex cooking partially succeeds (fails initially but succeeds with inflation) indicating the full path of the mesh that failed #rb ori.cohen #tests Compiled changes, will provide more information when issue reoccurs in build machine cooks #jira OR-24082 Change 3021460 on 2016/06/21 by Michael.Noland Engine: Added time spent in each hitch bucket to FPS chart .log output and analytics output #rb bob.tellez #tests Tested a match in Paragon #codereview dmitry.rekman Change 3021368 on 2016/06/21 by Marcus.Wassmer Create Tonemapper configuration with no ColorFringe to save .15ms on PS4 when colorfringe is not used. #rb rolando.caloca #test agora with/wo new config #codereview brian.karis Change 3021119 on 2016/06/21 by David.Ratti Make -notimeouts work during initial connecting phase #codereview John.Pollard #rb none #tests pie agora Change 3021048 on 2016/06/21 by David.Ratti minor tweaks to gameplay cues: -Descriptions of engine GC notify classes -Added 'auto attach to owner' flag on actor notify class. #rb none #test ability system sample project Change 3020694 on 2016/06/20 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3020301 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3020674 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #CodeReview: cody.haskell Change 3020624 on 2016/06/20 by Michael.Noland Engine: Pushing more fps chart analytics up to engine level code from Paragon Engine: Pushing benchmark config vars up to engine level code from Paragon, and added records of individual sub-steps of benchmarks #rb Bob.Tellez #tests Golden path Solo VS AI in Paragon and forced a match #codereview bob.tellez, peter.knepley Change 3020181 on 2016/06/20 by Dmitry.Rekman Re-do allowing allocations in NullRHI (OR-24029). - Originally CL 2990582 by MarcusW, stomped during merge by CL 3006926. #rb none #codereview Marcus.Wassmer, Andrew.Grant #tests none Change 3020139 on 2016/06/20 by Ryan.Gerleve Added ability to pause replay recording while keeping the current replay open. #rb john.pollard #tests paused deathcam recording while disabled Change 3019817 on 2016/06/20 by Dmitry.Rekman Poison allocated/freed memory in Debug and Development (non-editor) configs. - With this Paragon client may be more likely to crash on start. #rb Steve.Robb #codereview Robert.Manuszewski, Michael.Noland, Andrew.Grant, Gil.Gribb, Steve.Robb #tests Built Linux server and Windows client, ran them, also built Windows Orion editor. Change 3019599 on 2016/06/20 by Rolando.Caloca O - Fix flickering on heroes with morph targets #rb Marcus.Wassmer #tests Load Agora_P #jira OR-23866 Change 3019581 on 2016/06/20 by Wes.Hunt Fix crash reporter client analytics for internal builds. (Pushing critical fix immediately from //UE4/Orion-Staging) #rb Chris.Wood #tests none Change 3019524 on 2016/06/20 by David.Ratti call APawn::OnRep_Controller when ClientRetryClientRestart sets the pawn directly #rb none #tests golden path Change 3019406 on 2016/06/20 by Marcus.Wassmer Duplicate 3014956 from Dev-Rendering Fixed HLOD and mesh LODs getting hit by Lightmass ray traces that didn't originate from a mesh Volume lighting samples and precomputed visibility cells are now only placed on LOD0 (of both mesh LODs and HLOD) #rb none #test none #codereview Jordan.Walker Change 3019371 on 2016/06/20 by Graeme.Thornton Optimize cooked asset registry dependency node data structures. Saves ~10mb on Paragon. #rb robert.manuszewski #tests tested with cooked pc client + server Change 3018492 on 2016/06/17 by Laurent.Delayen FBoneReferenceCustomization: support editing properties in AnimBP defaults. #rb none #tests: Sword. Change 3017974 on 2016/06/17 by Ryan.Gerleve Add an option to toggle deathcam in the gameplay settings UI if the OrionRuntimeOption for deathcam is enabled. #rb cody.haskell #tests settings menu, enabled and disabled deathcam Change 3017913 on 2016/06/17 by Robert.Manuszewski Fixing leaked log archive. #rb Steve.Robb #tests Cooked Win64 client + server Change 3017873 on 2016/06/17 by Daniel.Lamb Fix warning in diff cooked build. #test none #rb none Change 3017676 on 2016/06/17 by Sam.Zamani #online,identity,mcp fix for uninitialized variable #rb dmitry.rekman #tests none Change 3017671 on 2016/06/17 by Robert.Manuszewski Fxied and improved log message when cluster assumptions are violated. #rb Steve.Robb #tests Win64 client + server (cooked) golden path Change 3017358 on 2016/06/16 by Nick.Atamas Checking in Darnell's change that adds correct geometry to widgets inside retainer widgets. #rb none #test PIE Change 3017242 on 2016/06/16 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3017179 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3017233 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/UI/Tooltips/Hero/AbilityTooltip.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3017237 on 2016/06/16 by Dmitry.Rekman Fix accessing uninitialized field (kills valgrind warnings). #rb none #codereview Michael.Noland, Andrew.Grant, Ori.Cohen #tests Compiled and ran Linux server. Change 3017236 on 2016/06/16 by Dmitry.Rekman Initialize missed field (kills valgrind warnings). #rb none #codereview Michael.Noland, Andrew.Grant #tests Compiled and ran Linux server. Change 3017186 on 2016/06/16 by Dmitry.Rekman Linux: Add hooks for libcrypto memory functions. - Libcurl uses OpenSSL, which allocates memory using libcrypto's CRYPTO_malloc() and apparently on purpose does not initialize it. - This change a) redirects these allocations to use UE's malloc b) initializes it with zeros, avoiding valgrind's warnings. - This behavior is not used on Shipping configurations because the impact on entropy is not understood (TBD later). #rb Michael.Noland, Rob.Cannaday (original version) #codereview Michael.Noland, Rob.Cannaday, Alex.Fennel, Chris.Babcock, Sam.Zamani #tests Compiled Linux server and ran it. Change 3017037 on 2016/06/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.grant Merging content fix for driver crash from Release-27 #ROBOMERGE-SOURCE: CL 3017036 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3016838 on 2016/06/16 by Alexis.Matte #jira UE-31901 fix to export all blueprint component to obj #rb uriel.doyon #codereview matt.kuhlenschmidt #test export a blueprint containing multiple staticmesh component to obj Change 3016629 on 2016/06/16 by Dmitry.Rekman Make Binned default on Linux non-editor builds. #codereview Andrew.Grant #rb none #tests none Change 3016615 on 2016/06/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.grant Temporarily disabling jemalloc for Linux #rb #tests none [CodeReviewed] Dmitry.Rekman #ROBOMERGE-SOURCE: CL 3016612 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3016566 on 2016/06/16 by Michael.Noland Engine: Fixed a regression that broke safe zone debugging features in Windows by reintroducing code from CL# 2861030 that was accidentally deleted in a merge #codereview andrew.grant #rb dan.hertzka #tests Tested r.DebugSafeZone.Mode 1 with r.DebugSafeZone.TitleRatio 0.9 in PIE and confirmed that SSafeZone obeyed it and the red overlay appeared Change 3016521 on 2016/06/16 by Ryan.Gerleve Client recoreded replay fixes and optimizations from Dev-Networking (and one from //UE4/Main), for deathcam. Includes the following CLs from Dev-Networking: 2997908 2998001 2998832 2999054 2999057 2999749 3000051 3001361 3001365 3004958 3009972 3009973 And this CL from //UE4/Main: 3015528 #tests golden path, replays #rb john.pollard Change 3016503 on 2016/06/16 by Brian.Karis Fixed uninitialized variables on particle lights. Fixes hair shading. #rb none #tests editor Change 3016429 on 2016/06/16 by Max.Chen Sequencer: Fix StartTime when clamping start offset 0. Follow up to CL #3009386. #jira UE-29167 #tests Load up AnnounceMaster and adjust leading edge of animation clips #rb Frank.Fella Change 3016356 on 2016/06/16 by Lina.Halper - Fix crash on rampage morphtarget Merging using //UE4/Dev-Framework_to_//Orion/Dev-General - this is dupe change from Dev-Framework #jira: https://jira.ol.epicgames.net/browse/OR-23194 #rb: Ori.Cohen #tests: editor/pie spawn as rampage's alt skin Change 3015696 on 2016/06/15 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3015646 This re-unifies our build pipeline. Fingers crossed. (only 6 files are actually different) #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3015672 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3015642 on 2016/06/15 by Mieszko.Zielinski Fixes to multiple reasons AI bots were getting stuck #Orion #rb Lukasz.Furman #test golden path Change 3015622 on 2016/06/15 by Mieszko.Zielinski fixed FMetaNavMeshPath doing navmesh path update without checking nav agent if pathfinding should be postponed #UE4 #rb Lukasz.Furman #test golden path Change 3015514 on 2016/06/15 by Uriel.Doyon Fixed GlobalMipBias not affecting max texture resolution. This fix is implemented differently in Dev-Rendering in CL 301498. #jira OR-23511 #rb marcus.wassmer #test played game with different quality settings Change 3015258 on 2016/06/15 by Lina.Halper Fix crash with recursive reference between two assets #rb: Ori.Cohen #tests: Sword Change 3014988 on 2016/06/15 by Wes.Hunt Fix Cook Analytics to correctly use the Legacy provider since it sends to a local data collector. #rb daniel.lamb #tests compile Orion Change 3014962 on 2016/06/15 by Olaf.Piesche Replicating CL 3013696 from Dev-Rendering; making quality level spawn rate scale work for GPU emitters. #rb simon.tovey #tests PC editor game Change 3014958 on 2016/06/15 by Laurent.Delayen Added SkeletalMeshComponent::bIncludeComponentLocationIntoBounds to help in cases where SMU_OnlyTickPoseWhenRendered is set, and an animation pushed the mesh beyond the capsule. This ensures that when the capsule is in view, the mesh will remain updated. #rb Michael.Noland #test Sword ultimate from another player's view. Change 3014833 on 2016/06/15 by Laurent.Delayen Fix for Base Heroes having their locomotion blendspace broken. #rb Thomas.Sarkanen #codereview Thomas.Sarkanen #tests Gadget networked PIE Change 3014688 on 2016/06/15 by Nick.Darnell UMG - Fixing IsHovered on UUserWidgets. SObjectWidget did not properly call the super for MouseEnter/MouseLeave allowing SWidget's implementation to set and unset the bool. #rb none #tests PIE Change 3014325 on 2016/06/15 by Marcus.Wassmer Duplicate 3012706: Scalability CVAR for ContactShadows #rb john.billon #test flip cvar in editor. Change 3014230 on 2016/06/15 by Robert.Manuszewski Fix potentially missing log output when serializing text of length equal to the async log writer buffer size. #rb Steve.Robb #tests Tested in editor build (client + server) Change 3013913 on 2016/06/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Updating from DMM (updated from 27.1MM) #RB:none #Tests:compiled #ROBOMERGE-SOURCE: CL 3013912 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3013437 on 2016/06/14 by Simon.Tovey Speculative fix for OR-23158 Couldnt' repro NANs but did see it reading garbage. Reinstated the check that direct accesses for particles in a zero size emitter will return null. Altered selection code to reselect when partilce is dead or returns null and to not allow new selection on zero size emitters. #tests GoldenPath, No broken fx and no more reading garbage. #rb Olaf.Piesche Change 3013063 on 2016/06/14 by Jason.Bestimt #ORION_DG - Unclog robomerge from DMM Merge #RB:none #tests:none Change 3012936 on 2016/06/14 by Rob.Cannaday Fix for multiple account login not kicking previous logins Client was not parsing response from backend. Client was expecting content-type to be "application/json" (using FString::Equals). Backend was returning "application/json;charset=UTF-8". Changed usage from FString::Equals to FString::StartsWith #jira FORT-25452 #rb sam.zamani #tests multiple account login, frontend only Merge from FN CL 3011647, plus fixing one other location expecting "application/json" Change 3012696 on 2016/06/14 by Max.Chen Sequencer: Select actors for corresponding selected keys or sections. Copy from Dev-Sequencer #jira UE-30727 #tests Load up AnnounceMaster and select keyframes #rb none Change 3012691 on 2016/06/14 by Max.Chen Sequencer: Fix dragging the leading edge of a skeletal animation section so that it adjusts the start offset of the animation clip. Copy from Dev-Sequencer #jira UE-29167 #tests Load up AnnounceMaster and adjust leading edge of animation clips #rb Frank.Fella Change 3012690 on 2016/06/14 by Andrew.Grant Removed Linux work-around for memory stomp alignment #rb none #tests compiled Change 3012687 on 2016/06/14 by Max.Chen Sequencer: Fix lower bound when doing post render tick so that the start of a shot doesn't render with the previous shot's time. Copy from Dev-Sequencer #rb none #tests Load up AnnounceMaster and played through sequence Change 3012627 on 2016/06/14 by Mieszko.Zielinski Added logging of current MoveID to PathfollowingComponent's vlog snapshot #UE4 #rb none #test golden path Change 3012615 on 2016/06/14 by Mieszko.Zielinski Improved fix to BTDecorator_Blackboard's latent tasks aborting #UE4 #rb Lukasz.Furman #test golden path Change 3012572 on 2016/06/14 by Dmitry.Rekman Fix realloc with non-default alignment in jemalloc (OR-23541). - Removed obsolete check(), the code was already there since CL 1834526. #rb none #codereview Andrew.Grant, Robert.Manuszewski #tests none Change 3012481 on 2016/06/14 by David.Ratti ability system #include fixups and move orion attribute capture marcros into base engine ability system execution class #rb none #tests ability system sample project Change 3012457 on 2016/06/14 by Andrew.Grant Un-fix misaligned memory-stomp fix for Linux #rb none #tests compiled Change 3012320 on 2016/06/14 by Graeme.Thornton Fixes for MemoryAnalyser2 solution - Upgraded to VS 2015 - Clean up solution configurations. Only leave "Any CPU" - Switch project to build with "Any CPU" rather than "x64". Reimplementation of CL 3012221 from Dev-Core #rb robert.manuszewski #tests opened the main window form correctly in visual studio Change 3012316 on 2016/06/14 by Thomas.Sarkanen Fix copying non-POD structs in the fast path Prevents double-deletions of TArrays etc. #jira UE-31394 - Fix problems with non-POD UStructs using the anim BP fast-path #tests Played PIE & died as Sword in OrionEntry, Exited PIE. #rb Martin.Wilson Change 3012187 on 2016/06/14 by Graeme.Thornton Corrected error message when not specifying linux server device command line correctly in UAT #rb Dmitry.Rekman #tests Checked error message was useful when wrong command line was specified Change 3012026 on 2016/06/13 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3011936 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3011996 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/oriongame/Content/Characters/Heroes/Hammer/Abilities/Subjugate/FX/P_SubjugateSwirls.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3011969 on 2016/06/13 by Brian.Karis Tweaks for hair Change 3011638 on 2016/06/13 by Andrew.Grant Fixed issue where RepLayout could use unaligned memoryfor property construction if allocator did not use a suitable default (fixes crash when running with MemStomp). Also added sanity check in UScriptStruct::InitializeStruct that memory is correctly aligned before calling constructor #codereview Dave.Ratti, John.Pollard #rb none #tests Ran with/without memstomp Change 3011575 on 2016/06/13 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3011414 NOTE - Card data was altered. Shame shame shame. Not authoritative in DUI #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith, sammy.james, matt.kuhlenschmidt #ROBOMERGE-SOURCE: CL 3011552 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3011462 on 2016/06/13 by Alexis.Matte #jira UE-31901 The outputdevice is adding 2 uninitialize character at the end of any log, this is cause by the terminator logic. The fix is to not add those characters when no terminator should be add. #rb nick.darnell #codereview Robert.Manuszewski #test export a obj file and verify all object are exported in maya or max Change 3011424 on 2016/06/13 by Martin.Wilson Hack out fastpath anim bp code until heap corruption issue can be fixed. #rb Laurent.Delayen #tests Persona + PIE Change 3011191 on 2016/06/13 by Mieszko.Zielinski Added missing initialization of PathFollowingComponent::CurrentMoveInput #UE4 #rb none #test golden path Change 3011138 on 2016/06/13 by Mieszko.Zielinski Switched bots over from travel mode to sprinting #Orion #rb Lukasz.Furman #test golden path Change 3011075 on 2016/06/13 by David.Ratti Default GameplayAbility instancing policy to InstancePerExecution #rb BenZ #tests compile Change 3011051 on 2016/06/13 by David.Ratti Add missing include so GameplayAbilitySet.h can be included on its own. #rb none #tests compile Change 3010968 on 2016/06/13 by Mieszko.Zielinski Fixed console variables crashing on "" string #UE4 #rb Lukasz.Furman #codereview Martin.Mittring #test PIE Change 3010888 on 2016/06/13 by Alexis.Matte #jira OR-23301 Close the OS handle when closing the FAsyncWriter. #rb Robert.Manuszewski #codereview Robert.Manuszewski #test try to export a obj file Change 3010239 on 2016/06/11 by Michael.Noland UMG - Adding back the logic to use the normal WidgetTree when the DesignerWidgetTree is not defined. [duplicated fix from CL# 2998267] #jira UE-31570 #tests Compiled some blueprints #rb none Change 3009870 on 2016/06/10 by Wes.Hunt Remove logging of analytics payloads from dedicated servers #jira UE-31858 #codereview:dmitry.rekman #rb none #tests All testing was done in Dev-Framework. This change was redone in this branch to get it here faster. Change 3009599 on 2016/06/10 by Michael.Noland Rendering: Corrected a misleading help comment on r.StaticMeshLODDistanceScale, explaining how it affects LOD calculations (it multiplies the effective distance, so larger numbers make transitions happen sooner) #tests Verified in the output of the help command #rb none #rn Change 3009559 on 2016/06/10 by Marcus.Wassmer Fix 11/11/10 SceneColorFormat option, enable AntiGhosting on TemporalAA, ensure TemporalAA output is the correct format for accumulating results. Set SceneColorFormat to 2 on PS4 and lowspec PC. All in all saves .3-.5ms on PS4 and improves temporalAA ghosting. #rb Brian.Karis #test Agora PS4 / PC Change 3009525 on 2016/06/10 by David.Ratti Fix case where ObjectLIbrary would not be able to find classes when searching "/Game" path. #rb none #tests object libraries in paragon Change 3009228 on 2016/06/10 by David.Ratti remove world check. Can be triggered in editor with PIE #rb none #tests pie Change 3009050 on 2016/06/10 by Dmitry.Rekman Fix LinuxClient platform not being built on Windows, and not instantiating a target platform instance. - Fixes by BenM. #rb none #codereview Ben.Marsh #tests Compiled OrionEditor on Linux. Change 3008973 on 2016/06/10 by Marcus.Wassmer Fix Windualshock on VS2015 #rb Rolando.Caloca #test PS4 controller on VS2015 build Change 3008970 on 2016/06/10 by David.Ratti Fix warning about minimal replication tag count -Made bit count a config setting. Bumped to 5 -Minor optimization to UAbilitySystemGlobals::Get() #rb none #tests goldne path, pie Change 3008478 on 2016/06/09 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3008469 #RB:none #Tests:none Change 3008416 on 2016/06/09 by Andrew.Grant Adding 'config' as an option to set both clientconfig / serverconfig when using BuildCookRun #review-3008417 Ben.Marsh, Justin.Sargent #rb none #tests BuildCookRun with config Change 3008286 on 2016/06/09 by Dmitry.Rekman Add LinuxClient target platform. #rb none #tests Compile OrionEditor on Linux. #codereview Brad.Angelcyk, Ben.Marsh Change 3007978 on 2016/06/09 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3007507 #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith #ROBOMERGE-SOURCE: CL 3007968 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3007771 on 2016/06/09 by Laurent.Delayen Fixed GetIntFromComp breaking with INDEX_NONE. Fixes crash in OrientationWarping node. #rb martin.wilson #codereview martin.wilson #tests Sword Leap. Change 3007436 on 2016/06/09 by David.Ratti change designer facing parameter name #rb none #test compile Change 3007408 on 2016/06/09 by David.Ratti WaitGameplayEffectBlockedImmunity - ability task for listening to immunity events #rb danY #tests pie Change 3007250 on 2016/06/09 by bruce.nesbit Banner impact location fix. (OR-23179) #rb none #tests Game+PIE Change 3007228 on 2016/06/09 by Ben.Marsh BuildGraph: Rename -SkipNodesWithoutTickets parameter to -SkipTargetsWithoutTickets, to reflect that it's filtering the list of targets rather than the full graph. #rb none #tests none Change 3007225 on 2016/06/09 by Ben.Marsh EC: Set the -TicketSignature=... parameter for all BuildGraph jobs started by EC to the URL of the current job. Change 3006985 on 2016/06/08 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3006936 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3006978 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3006926 on 2016/06/08 by Andrew.Grant Merging //UE4/Main @ 300872 via //UE4/Orion-Staging #rb none #tests engine QA, orion qa smoke Change 3006444 on 2016/06/08 by Ben.Marsh BuildGraph: Add mechanism to specify that nodes can only be built once for a given changelist. Nodes can have an associated ticket file, and they are only permitted to build if the ticket is assigned to the current job. Tickets are created if they don't exist, and written with a signature specific to the job specified via the -TicketSignature="..." parameter. By default, builds will fail if a ticket has been already granted to another job, but the -SkipNodesWithoutTickets parameter instructs the graph to skip affected nodes instead. #rb none #tests none Change 3006389 on 2016/06/08 by Daniel.Lamb Delay the processing of packages which aren't ready till the end of the cook. This allows other packages to be processed sooner. #rb Peter.Sauerbrei #test cook orion. Change 3006306 on 2016/06/08 by Michael.Noland Rendering: Added FreezeRendering to the console autocomplete list #rn Change 3006305 on 2016/06/08 by Michael.Noland HLOD: Added a way to control how far down the HLOD hierarchy to allow showing (can be used to limit quality loss and streaming texture memory usage on high scalability settings for example) Controlled by the new cvar r.HLOD.MaximumLevel, which can be set to the following values: -1: No maximum level (default) 0: Prevent ever showing a HLOD cluster instead of individual meshes 1: Allow only the first level of HLOD clusters to be shown 2+: Allow up to the Nth level of HLOD clusters to be shown Note: This does not affect the memory used by the HLOD meshes itself or their always loaded low mip levels, it will only save the memory associated with streaming in the higher mip levels HLOD: Allowed r.HLOD console command to be used in Test configurations HLOD: Removed some dead code in ALODActor and scene view / scene proxy relating to a different way to force visualization that has no trigger HLOD: Fixed an uninitialized memory bug in the static mesh scene proxy HLODcoloration visualization code #rn #codereview jurre.debaare #rb marc.audy #tests Tested with various settings in Paragon and tried creating some new clusters in the editor Change 3006304 on 2016/06/08 by Michael.Noland Engine: Changed the code in AActor::IncrementalRegisterComponents to obey bAutoRegister for the root component rather than asserting that it is true. Note: If children components have bAutoRegister=true, they will still pull the root component into the fray and cause it to be registered first #rb marc.audy #tests Tested with code that registers or unregisters HLOD clusters at varying levels in Paragon Change 3006041 on 2016/06/08 by Andrew.Grant Added buildidoverride to shipping whitelist #rb none #tests compiled and used param in shipping Change 3005678 on 2016/06/08 by Ben.Marsh Back out changelist 3004395 #rb none #tests none Change 3005265 on 2016/06/07 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3005120 #RB: none #Tests: none #ROBOMERGE-SOURCE: CL 3005250 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 3005081 on 2016/06/07 by Daniel.Lamb Reworked the way packages which are renamed on load are added to the cooked package list. Cooker now has options for MaxMemoryAllowance as a percentage and also MinFreeMemory (which takes into account used system memory not just total system memory). #rb Andrew.Grant, Marcus.Wasmer #test cook orion Change 3004752 on 2016/06/07 by Daniel.Lamb Requeue packages to the next package on the list instead of to the end of the list. #rb Andrew.Grant #test cook orion Change 3004560 on 2016/06/07 by David.Ratti Kill timelines, latent actions, timer when recycling gameplay cues #rb danY #tests pie Change 3004559 on 2016/06/07 by David.Ratti Object Library: -Added bool bIncludeOnlyOnDiskAssets that can be set by owner. Passed on to the AR filter when gathering assets. GameplayCue Editor: -Fix issue with new notifies not showing up after being created through the GC Editor (until restart). -Fix issue for new projects, that don't have gameplayclue tags defined, not being able to add gameplay cue tags through the editor without restarting once. #rb none #tests editor Change 3004395 on 2016/06/07 by Ben.Marsh BuildGraph: Add a script function to ensure exclusive access to a given resource. The AcquireLockFile() function takes two arguments; a path to a text file, and the name of an owner. The file is created and the owner name written to it if it doesn't already exist, otherwise the contents of it are compared against the given owner string. The operation happens transactionally, and the function returns true if file contains the given owner string on exit. Logical and/or conditions are now also short-circuited, so the result of the AcquireLockFile() function can be used to control derived property definitions within an executing job. #rb none #tests none Change 3004164 on 2016/06/07 by David.Ratti Ability system: use player controller netmode over avatar actor when possible. Fixes issue if torn off, authority, client side actor tries to activate an ability. #rb danY #tests multi pie Change 3003837 on 2016/06/07 by David.Ratti Ability system engine work -Default to /Game as search path for gameplay cues, if no explicit paths are set in the config. #rb none #tests ability sample project Change 3002800 on 2016/06/06 by Marcus.Wassmer Fix shader crash in PIE #rb none #test PIE Change 3002657 on 2016/06/06 by Dmitry.Rekman Do not copy to clipboard on crash if headless or on the wrong thread. - Could result in crash handler crashing itself in some circumstances. #rb none #codereveiw Brad.Angelcyk #tests Compiled Linux dedicated server and CrashReportClient. Change 3002546 on 2016/06/06 by Daniel.Lamb Improve cooking performance. Allow cooker to save other packages opportunistically if main package is compiling shaders. Allow cooker to load more packages if there aren't many packages to save. #rb Josh.Adams #test cook orion Change 3002369 on 2016/06/06 by Marcus.Wassmer Project setting for optional rendering features to reduce shader compile times. # of shaders per material is reduced by ~30-40% depending on material #rb Daniel.Wright #test Editor with/without all options, cooked ps4. Change 3002142 on 2016/06/06 by David.Ratti Ability system engine level: -Fix crash when gameplay cue editor starts if there are no gameplay cue paths specified -Fix crash when GameplayCue tag is not specified #rb none #tests sample ability system project, paragon Change 3002106 on 2016/06/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani #orion - add support for code tokens which can be shared/redeemed - refactor of existing friend founder's pack codes to be displayed in a generic way using code token info - added CodeToken.FounderFriendInviteT0 for new paragon tier 0 code which grants access to game without also giving a Founder's pack - added CodeToken.FounderFriendInviteT1 to replace existing CodeToken.FriendPC and CodeToken.FriendPS4 Founder's pack codes. Existing codes aliased to the new CodeToken.FounderFriendInviteT1 code - No longer differentiation between PC/PS4 friend codes - "Share Friend Code" button will now process all available codes that can be issued instead of just 1 - updated Orion service Mcp call for getUnredeemedCodes() to ignore the code template id and return all available codes. Each returned code will also include the type [CodeReviewed]: david.nikdel, jason.bestimt #rb david.nikdel #tests PC PIE using localhost and profile proxy for granting codes, also existing account with legacy codes #ROBOMERGE-SOURCE: CL 3002104 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3001218 on 2016/06/05 by jason.bestimt #ORION_MAIN - Merge 27.2 @ CL 3001162 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3001200 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: jason.bestimt Change 2999508 on 2016/06/03 by jason.bestimt #ORION_MAIN - Merge 27 @ CL 2999463 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2999498 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Audio/ClassesAndMixes/Classes/Master.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 2999465 on 2016/06/03 by Robert.Manuszewski Whitelisting more DLLs for injection. #rb none #tests none Change 2999455 on 2016/06/03 by Lukasz.Furman disabled path invalidation events for minions #orion #rb Mieszko.Zielinski #tests PIE with additional debug logging Change 2998488 on 2016/06/02 by Michael.Noland Engine: Prevent forced drawing of spline components in Test configuration #codereview james.golding #tests Ran a cooked Test build on a map with splines in it #rb david.ratti #robomerge: main Change 2997954 on 2016/06/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: jon.lietz OR-22425 no longer try to updat the tag map and modifiers when the gameplay effect that is being removed was not active. #RB Dave.Ratti #Tests golden path #ROBOMERGE-SOURCE: CL 2997940 in //Orion/Release-0.27/... via CL 2997943 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2997750 on 2016/06/02 by Graeme.Thornton Add FPakFile::Check() that attempts to open and read the data out of every file in a pak, to check for corruption Added -checkpak option for force a check of every mounted pak file #rb robert.manuszewski #tests tested against cooked pc client. made sure my data succeeded. made sure corrupted data throws an error. [CL 3031715 by Andrew Grant in Main branch]
2016-06-28 17:59:42 -04:00
if (MyTask)
{
MyTask->InitTask(InTaskOwner, Priority);
MyTask->InstanceName = TaskInstanceName;
MyTask->AddClaimedResource(ResourceClass);
}
return MyTask;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465) #lockdown Nick.Penwarden Change 3110660 on 2016/9/1 by Andrew.Grant Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress. HLOD warning is updated every 20 secs to deal with streaing levels. Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon). #rb Michael.Noland #tests verified we see our unbuilt HLOD warning in v31 :( Change 3106649 on 2016/08/30 by Cody.Haskell #Orion - Input Axis Work #rb DanH #tests PIE Change 3106299 on 2016/08/30 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 31.2 @ CL 3105865 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3106213 on 2016/08/30 by Ben.Marsh BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file. #rb none #tests preflight Change 3105994 on 2016/08/30 by Martin.Wilson Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input) #jira UE-35289 #rb Thomas.Sarkanen #tests Tested UI in editor Change 3105331 on 2016/08/29 by Uriel.Doyon Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget. #rb marcus.wassmer #tests launched editor and played game #jira OR-25814 Change 3105143 on 2016/08/29 by Josh.Markiewicz #UE4 - added assert when histogram input parameters don't match #rb none #tests launched/ran/won game golden path #codereview dmitry.rekman, michael.noland, bart.bressler Change 3104976 on 2016/08/29 by Jon.Lietz pickup refector - fixed a big that would allow mixed replication to call a gameplay cue's added twice. - All pickups now use the pick up manager, consolidated all pick up code into the manager. - added to the XP set so we can define the CXP bounty for targets. #RB Dave.Ratti #tests Bot match, test maps, spawning coins and pickups. Change 3103480 on 2016/08/26 by Josh.Markiewicz #UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession #rb none #tests golden path matchmaking #codereview paul.moore, eric.newman Change 3103410 on 2016/08/26 by Max.Chen Movie Capture: Fix commandline burnin option. #rb none #tests Render movie with commandline -UseBurnIn=yes option. Change 3102134 on 2016/08/25 by Brian.Karis Fix for HDR output exposure. Added 1000nit output option. #rb marcus #tests agora Change 3101276 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_31 - Merging CL 3100347 (head revision of 2 files :o ) #RB:none #Tests:none [CodeReviewed]: matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3101267 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_DUI - Integrating Media changes from 4.13 (head revision) #RB:none #Tests:none /Engine/Plugins/Media /Engine/Source/Runtime/Media /Engine/Source/Runtime/MediaAssets [CodeReviewed] matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100378 on 2016/08/24 by John.Pollard Fix a crash that can occur when scrubbing in replays #codereview David.Ratti #tests Replays #rb DavidR This is the output: [2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage Change 3100375 on 2016/08/24 by Laurent.Delayen Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket). #rb none #codereview lina.halper #tests Tacticia's RMB Targeting Change 3100278 on 2016/08/24 by Laurent.Delayen Fix for fast path struct copy being broken for FVectors. #rb lina.halper #codereview thomas.sarkanen #tests Chains' hook, Tacticia's LaserBeam and OrientationWarping Change 3100161 on 2016/08/24 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix issue with refresh viewer command failing due to backend congestion #rb RyanG #tests Replays Change 3100114 on 2016/08/24 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3098849 #RB:none #Tests:none #CodeReview: kerrington.smith, matt.schembari #R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100015 on 2016/08/24 by Michael.Noland Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node #jira UE-34998 #rb Aaron.McLeran [re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13] #tests Compiled and ran a golden path match with headphones on Change 3100012 on 2016/08/24 by Michael.Noland UE-34951 - Zero-volume vorbis decoded sounds are too expensive -Adding an audio settings parameter to disable zero-volume playback globally -Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume #rb marc.audy [re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran] #tests Compiled and ran a golden path match with headphones on Change 3099889 on 2016/08/24 by Max.Chen Sequencer: Added command line option to enable burnin #rb none #tests Render movie from command line wtih -UseBurnIn=yes Change 3099801 on 2016/08/24 by Lina.Halper Removed unnecessary comment #rb: none #code review: Benn.Gallagher #tests: compile Change 3099787 on 2016/08/24 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #http - fix for cancelled requests that have not been started never triggering a completion delegate - fixes soft lock when handling disconnects during login OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting #rb josh.markiewicz, alex.fennell #tests none #R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3099252 on 2016/08/24 by Lina.Halper Fixed menu text #rb: none #code review: Thomas.Sarkanen #tests: open editor and create child montage and replaced the animation Change 3099251 on 2016/08/24 by Lina.Halper Deterministic cooking of skeleton - abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked #jira: UE-34834 #rb: Martin.Wilson #tests: cooking orion and make sure it works Change 3098504 on 2016/08/23 by Bart.Bressler Add server time between sending packets monitoring histogram #rb dmitry.rekman #tests ran server locally and made sure analytics events were sent Change 3098494 on 2016/08/23 by Michael.Noland Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements - Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer) - Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected #tests Tested by calling while stat dumphitches was active and confirmed that the interval changed #codereview ben.salem, gil.gribb #rb none Change 3098491 on 2016/08/23 by Mieszko.Zielinski Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4 #rb Lukasz.Furman #test golden path Change 3098070 on 2016/08/23 by Lina.Halper Fix crash with UI update reconstructing - will have to come up with a better solution than this. #rb: Martin.Wilson #tests: child anim montage Change 3097914 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel Merging CL #3097879 from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/... to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/... #Analytics #OSS: Adjusted cohort selection algorithm and test cases [CodeReviewed]: Philip.Buuck #TESTS: unit tests #RB: none #R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097745 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Megre 30.2/31 @ CL 3096895 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097722 on 2016/08/23 by Chris.Bunner Update texture expression properties before triggering parent material recompile. #rb John.Billon #tests Editor replace references, Golden path #jira OR-27531 Change 3097694 on 2016/08/23 by Lina.Halper #Child Anim Montage - Duplicate from parent of the information it cares to get - Currently it is selective on copying what data - Modified GetAllAnimationSequencesReferred to get a partial data - Added ParentAsset/AssetMappingTable in AnimationAsset - Sequence Browser opening would also add to history - AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on #code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti #rb:Martin.Wilson #tests: creating child montage, editing, lots of UI functionality, notifies placement Change 3097513 on 2016/08/23 by Thomas.Sarkanen Non-POD structs can now be copied using the fast path We now always use CPP struct ops to perform copies when dealing with struct properties. #jira UE-34571 - Support struct member access on AnimBP fast path #rb Laurent.Delayen #tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games. Change 3096729 on 2016/08/22 by Mieszko.Zielinski Fixes to EQS scoring function preview #UE4 #rb Lukasz.Furman #test golden path Change 3096596 on 2016/08/22 by Jason.Bestimt #ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970) #RB:none #Tests:none #CodeReview: matt.schembari, max.preussner #R@BOMERGE: MAIN Change 3096550 on 2016/08/22 by Jurre.deBaare Fix for HLOD dirty clusters PIE warning message #tests Simulated Origin with built HLOD clusters, and with one dirty cluster #rb none Change 3096532 on 2016/08/22 by Mieszko.Zielinski Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4 As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized #codereview Lukasz.Furman #rb none #test golden path Change 3096455 on 2016/08/22 by Jason.Bestimt #R@BOMERGE-AUTHOR: keli.hlodversson #CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases #RB David.Nikdel #TESTS none #R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3096316 on 2016/08/22 by Sammy.James Resave to fix log warnings. BPC changes to ensure type saves. #rb #tests editor Change 3096040 on 2016/08/22 by bruce.nesbit Revised fix for landscape crash #rb GarethM #tests Game #codereview Bart.Bressler Change 3096015 on 2016/08/22 by bruce.nesbit Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server #rb none #tests game #codereview Bart.Bressler Change 3095578 on 2016/08/19 by Mieszko.Zielinski Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4 This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor #rb none #test golden path #codereview Lukasz.Furman Change 3095397 on 2016/08/19 by Lina.Halper Fix issue with crash when deleting all segment #rb: Laurent.Delayen #tests: delete segment and make sure it doesn't crash #jira: UE-34830 Change 3095060 on 2016/08/19 by Bart.Bressler Don't load ULandscapeComponent objects on dedicated servers to save memory. #tests cooked server data and played a Solo vs. AI game #rb gareth.martin #codereview james.golding Change 3095037 on 2016/08/19 by Lina.Halper Potential fix with montage trigger ensure on marker sync group #jira: OR-27685 #rb: Benn.Gallagher #code review: Martin.Wilson #tests: attack primhelilx with knock up Change 3094962 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort #RB: None #TESTS: test suite in source [CodeReviewed]: Philip.Buuck #R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094950 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merge #UE4 - Made FMD5 const-correct #RB: none #TEST: none #R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094619 on 2016/08/19 by Lina.Halper #DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID. - assumed the name is all set by now #rb: Benn.Gallagher #jira : UE-34886 #tests: cooking infiltrator that showed same issue and run game. Change 3094532 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3094498 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3093260 on 2016/08/18 by Josh.Markiewicz #UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel) - removed unnecessary cast #rb bart.bressler #codereview bart.bressler, rob.cannaday #tests launched game, some basic party testing Change 3093224 on 2016/08/18 by Josh.Markiewicz #UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games #rb paul.moore #codereview anthony.carter #tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining Change 3092597 on 2016/08/17 by Daniel.Lamb Added Ben Crocker to the rebuild lighting emails. #rb Trivial #Test none Change 3092063 on 2016/08/17 by andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb #tests none Change 3091081 on 2016/08/16 by Jurre.deBaare Fixing non-Editor build errors #fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty) #tests Build Editor + Game #rb none Change 3091009 on 2016/08/16 by Mieszko.Zielinski Added a way to configure a map to not spawn AISystem instance at all #UE4 #rb none #test golden path Change 3090932 on 2016/08/16 by Michael.Noland Vixen: Added indication to the analytics and FPS charts #rb marcus.wassmer #tests Compiled for the platform Change 3090844 on 2016/08/16 by Laurent.Delayen Replicated CL 3090734 from Fortnite. --- Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage Here's the issue in the version of the code prior to this checkin: - UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped - When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value - So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick - It also means if we were playing a montage, and then stop, we'll start ticking - Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing #codereview john.abercrombie #rb none #tests golden path Change 3090832 on 2016/08/16 by Michael.Noland Windows: Fixed a whitespace issue #rb none #tests Compiled for windows Change 3090688 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb none #tests built #R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3090547 on 2016/08/16 by Jurre.deBaare Need a warning message similar to lighting unbuilt when HLOD cluster is not built #fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour #jira UE-34335 #rb none #codereview Michael.Noland #tests pie Agora with and without dirty HLOD clusters Change 3090285 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3090267 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3089413 on 2016/08/15 by paul.mader Agora 2.0 assets Change 3089266 on 2016/08/15 by Max.Chen Sequencer: Add Convert to Possessable Copy from Dev-Sequencer #jira UE-32139 #rb none #tests Convert steel to possessable in Gameplay_PS4 map. Change 3089136 on 2016/08/15 by Mieszko.Zielinski Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4 #rb Lukasz.Furman #codereview Dan.Youhon #test golden path Change 3089118 on 2016/08/15 by Mieszko.Zielinski Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4 #rb none #test golden path Change 3088976 on 2016/08/15 by Andrew.Grant Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules. Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting. Removed superflous /Os from VC debugg settings #rb none #tests verified module built with 'Never' on PS4/Win is built without optimizations. #codereview Marcus.Wassmer, Ben.Marsh Change 3088830 on 2016/08/15 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3088807 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3088597 on 2016/08/14 by Jason.Bestimt #ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG) #RB:none #Tests:none #CodeReview: andrew.grant, david.ratti, matt.schembari Change 3087827 on 2016/08/12 by Bart.Bressler Updates to skeletal mesh memory saving on dedicated server #rb lina.halper #tests Cooked server data, played a game for a while in Solo vs. AI Change 3087351 on 2016/08/12 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) #jira OR-27406 #rb RyanG #tests Replays Change 3087118 on 2016/08/12 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3086747 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3086176 on 2016/08/11 by Marcus.Wassmer Fix PS4 ShaderPipelines not matching pixel/vertex shader properly. #rb Rolando.Caloca #tests Broken PS4 content before/after Change 3085992 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Unclog R@BOMERGE #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3085911 on 2016/08/11 by Laurent.Delayen Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex #rb none #tests Orientation Warping Change 3085614 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3085547 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3084507 on 2016/08/10 by Marcus.Wassmer Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen. #rb none #tests paragon ps4/vixen #codereview Olaf.Piesche Change 3084136 on 2016/08/10 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3083799 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083424 on 2016/08/09 by Max.Chen Sequence Recorder: Fix crash when actor class to record is null. #tests Use sequence recorder to record a skeletal mesh actor #rb none Change 3083134 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #online,store,ps4 - creating one offer entry per entitlement #rb david.nikdel, ian.fox #tests MTX purhcase on PS4 #lockdown: andrew.grant #R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083069 on 2016/08/09 by Marcus.Wassmer Vixen scalability changes #rb Michael.Noland #tests vixen/ps4 #codereview jordan.walker Change 3083063 on 2016/08/09 by Marcus.Wassmer Most games will probably run out of memory if setup to do auto-4k. Make this a setting that's off by default. #rb Michael.Noland #codereview Luke.Thatcher, Lee.Clark #tests vixen on 4k. Change 3082778 on 2016/08/09 by Marcus.Wassmer Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087) #rb none #tests Agora on vixen. Change 3082772 on 2016/08/09 by Marcus.Wassmer Duplicate fix for detail mode reregistration (3065543) #rb none #tests Toggled detail mode, observe proper items spawning Change 3082765 on 2016/08/09 by Marcus.Wassmer Don't crash when trying to use windowed vsync on vixen #rb Michael.Noland #test ran paragon on vixen #codereview Luke.Thatcher,Lee.Clark Change 3082764 on 2016/08/09 by Marcus.Wassmer fix HLOD distance scale not working properly when components are re-registered. #rb michael.noland #codereview jurre.debarre #tests setting multiple times, setting on boot via deviceprofile Change 3082429 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani Merging //Orion/Release-30.1 to Main (//Orion/Main) Change: 3082419 #online,store,PS4 OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen - added config option for toggling store on PS4 [OnlineSubsystemPS4] bStoreEnabled=true - can also override via title specific json values in <titleid>\title.json allow_mtx=true [CodeReviewed]: andrew.grant, phillip.buck, ian.fox #lockdown: andrew.grant #rb none #tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support) #R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3082194 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3082105 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080984 on 2016/08/08 by Lina.Halper Issue with not being able to set static animation data via BP - artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP - also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called. #rb: Martin.Wilson #tests: Sword Beauty map Change 3080665 on 2016/08/08 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3080081 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080565 on 2016/08/08 by Laurent.Delayen Fix for curve values during URO interpolation. Fixes flashing of materials and Twinblast's ult weapon. https://jira.ol.epicgames.net/browse/OR-27107 https://jira.ol.epicgames.net/browse/OR-24358 #rb lina.halper, martin.wilson #tests Twinblast's ult and Coil's primary. Change 3079832 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: marcus.wassmer Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline #rb none [CodeReviewed] Chris.Wood #tests checked crashcontext on PC/PS4 #lockdown Andrew.Grant #R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3079045 on 2016/08/05 by Lina.Halper Adding more log to figure out why ActivePlayers.Count becomes inconsistent. #rb: Martin.Wilson #tests: PIE with bots Change 3078944 on 2016/08/05 by Rolando.Caloca O - Update blacklisted driver #jira OR-27051 #rb Marcus.Wassmer #tests Run with AMD card Change 3078735 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3078670 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3078122 on 2016/08/04 by Dmitry.Rekman Linux: treat abort() / SIGABRT as crash. - Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler. - Rewrote RequestExit() because it used abort() itself. - Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason. #rb Mark.Satterthwaite #codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant #review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant #tests Ran Linux server, crashed using different methods. Change 3077887 on 2016/08/04 by Dmitry.Rekman Initialize StackCount to 0 (kills valgrind warning). #rb David.Ratti #codereview David.Ratti #tests Ran Linux server. Change 3077257 on 2016/08/04 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3077193 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3077242 on 2016/08/04 by Dmitry.Rekman Linux: stop heartbeat thread before handling the crash. #rb Robert.Manuszewski #codereview Robert.Manuszewski, Andrew.Grant #tests Compiled and ran Linux server, crashed it. Change 3076676 on 2016/08/03 by Dmitry.Rekman Linux: print details about memory access (read or write). - Also print all the 16 digits of the pointer. - Read/write detection only implemented for x86_64. #rb Andrew.Grant #codereview Andrew.Grant #tests Compiled (natively) and ran Linux server. Change 3076675 on 2016/08/03 by Dmitry.Rekman Print a bit more info about the array in assert. #rb Andrew.Grant #codereview Andrew.Grant #test Compiled and ran Linux server. Change 3076010 on 2016/08/03 by Laurent.Delayen Moved OrionAnimNode_LegIK from Paragon to Engine. #codereview lina.halper #rb none #tests Grim.exe + Iggy & Scorch Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt Reimplemented 3070766 for Orion: Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash) #rb none #tests none Change 3075446 on 2016/08/03 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3075422 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3075394 on 2016/08/03 by HaarmPieter.Duiker Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in. #rb marcus.wassmer #tests post process color correction Change 3074314 on 2016/08/02 by Dmitry.Rekman Linux: change optimization from -O2 to -O1 (temporarily?). - The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier. - Also adds a line to UBT output during compilation to draw attention. #rb Michael.Noland #codereview Michael.Noland, Andrew.Grant, Bart.Bressler #tests Compiled and ran Linux server. Change 3073553 on 2016/08/02 by jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3073360 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) #R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3073505 on 2016/08/02 by Daniel.Lamb Added cook modification delegate stats to cooker stats. #rb Wes.Hunt #test cook paragon. Change 3072440 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries. #rb none #tests SHIPPING Change 3072259 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback. #rb Michael.Noland #tests PIE Change 3071908 on 2016/08/01 by John.Pollard Fix null reference crash #rb DavidR #tests Live game + replays Change 3071876 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player #rb none #tests FN + Paragon live game + replays #codereview Andrew.Grant Change 3071875 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Finalize replay version system * No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions) * Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore. * Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions) #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071874 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix gameplay tags to work better with backwards compatibility in replays * We use the net field export group system in the package map to export tag names as a packed index * This will allow us to see the names of tags that no longer exists on the remote side #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071776 on 2016/08/01 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3071738 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3071258 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together. - Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now. #rb none #tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues. Change 3071099 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads. #rb none #tests ran paragon with change and noticed no change in audio quality Change 3070916 on 2016/07/29 by Andrew.Grant Missed file! #rb #tests na Change 3070915 on 2016/07/29 by Andrew.Grant Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging #rb none #tests Engine QA, Orion QA smoke Change 3070576 on 2016/07/29 by Uriel.Doyon Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize. #review-3070386 @marcus.wassmer #jira OR-25941 #rb marcus.wassmer #tests Run Game on PS4, and in editor Change 3070086 on 2016/07/29 by Martin.Wilson Fixed ensure triggering during sequencer playback due to double update. #jira UE-33938 #rb Thomas.Sarkanen #tests opened affected asset and verified problem no longer occured Change 3070016 on 2016/07/29 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30 @ CL 3069935 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3069435 on 2016/07/28 by Ian.Fox #Orion, #Mcp - Check if Price Engine is configured before attempting query #rb Sam.Zamani #tests none #codereview Sam.Zamani Change 3069381 on 2016/07/28 by Michael.Noland Animation: Demoted a check() in anim sync group code to an ensure() to unblock others #rb nick.penwarden #tests Loaded Paragon cine asset that was crashing #codereview lina.halper, martin.wilson Change 3069203 on 2016/07/28 by Dmitry.Rekman Headless client: do not draw windows. - Disables a bunch of code, including reaching into font cache to estimate width. - Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets). #rb Nick.Atamas #review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem #codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem #tests Compiled and ran Orion Linux client. Change 3069181 on 2016/07/28 by Lina.Halper Fix struct redirector for Orion anim node moving to engine #rb: Maciej.Mroz #code review:Laurent.Delayen #tests: editor loading the anim BP that caused the name conversion Change 3069092 on 2016/07/28 by Aaron.McLeran OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves - Not all active sounds have sound classes, was causing a crash #codereview marc.audy #rb zabir.hoque #tests Run game with stat soundcues and not crash Change 3068969 on 2016/07/28 by David.Ratti Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too. #rb none #tests compile Change 3068902 on 2016/07/28 by David.Ratti Code for tracking down UGameplayCueManager::GetInstancedCueActor crash. #rb none #tests compile Change 3068831 on 2016/07/28 by Aaron.McLeran OR-26417 Reverb is too loud in-game in Dev-General - Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set. #rb Jeff.Campeau #tests run a map with no reverb audio volume and reverb is not super wet Change 3068529 on 2016/07/28 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config) #RB: none #TESTS: none #R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3068399 on 2016/07/28 by Andrew.Rodham Sequencer: Changed animation tracks to allow more animation types (such as anim montages) - APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility #jira OR-25769 #tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly. #rb Benn.Gallagher Change 3068138 on 2016/07/28 by Marcus.Wassmer Disable mallocleak testing by default #rb none #test none Change 3068121 on 2016/07/28 by Marcus.Wassmer Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled. Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also. #rb Robert.Manuszewski #tests stack tracing / symbolication with mallocleak on windows. Change 3068119 on 2016/07/28 by Marcus.Wassmer Fix MallocLeakProxy deadlock #rb Robert.Manuszewski #tests mallocleak start/stop/dump on windows Change 3067752 on 2016/07/27 by Michael.Noland Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands - IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer - The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class. - The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered - Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code Upgrade Notes: - DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly - In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands) - HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name) - Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future) Paragon: - Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event - Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it. #rb dmitry.rekman #codereview bob.tellez, peter.knepley, andrew.grant, john.mauney #review-3067607 @Dmitry.Rekman, @Bob.Tellez #tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI Change 3067654 on 2016/07/27 by Michael.Noland FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path. #rb steve.robb #jira UE-31959 [duplicating CL# 3039827] #tests Tried moving a folder in the editor Change 3067644 on 2016/07/27 by Aaron.McLeran OR-24537 Looping audio sometimes persists in Agora Adding stopping sounds if audio component is destroyed while playing a looping sound #rb jeff.campeau #tests audio component stops looping sound if audio component is destroyed prematurely Change 3067560 on 2016/07/27 by Aaron.McLeran OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters - Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call - using xaudio2 operation sets to ensure that voice and effect params are executing in sequence - only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands - Don't call EnsureCompletion on pending async tasks on teardown #rb Jeff.Campeau #tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions Change 3067420 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge 29.2/30 @ CL 3067312 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067316 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3065602 #RB:none #Tests:none [CodeReviewed]: matt.schembari #R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067025 on 2016/07/27 by Michael.Noland Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes #rb none #tests Compiled Change 3067020 on 2016/07/27 by Michael.Noland Core: Various improvements to FHistogram and split it out into separate files - Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate) - Added O(1) getters for total sample counts and sum of all measurements - Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex - Added support for specifying explicit histogram bucket thresholds #rb dmitry.rekman #tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage Change 3066681 on 2016/07/27 by Frank.Gigliotti Camera anim field of view fix; * The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value. * Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees. #RB None #CodeReview Jeff.Farris #Tests Multiple camera animations in PIE Change 3066508 on 2016/07/27 by Lina.Halper Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name. #code review:Martin.Wilson, Benn.Gallagher #rb: Martin.Wilson #tests: cooked test map, run test map, PIE, saving content, loading standalone game Change 3066246 on 2016/07/27 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Fix for non-unity error #rb none #tests compiled #R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3066167 on 2016/07/27 by Benn.Gallagher Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding. #rb Ori.Cohen #tests Editor, PIE, Applying clothing to characters. Change 3065868 on 2016/07/27 by Michael.Noland Blueprints: Fixing non-editor build (missing WITH_EDITOR) #rb none #tests Compiled PS4 Change 3065749 on 2016/07/26 by Michael.Noland Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead) #codereview mike.beach, marc.audy #tests Loaded and recovered a corrupted Blueprint on Cameron's machine #rb Phillip.Kavan Change 3065706 on 2016/07/26 by Josh.Markiewicz #UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons - fixed non shipping cmd line override to be correct #rb none #codereview andrew.grant, paul.moore #tests none Change 3065359 on 2016/07/26 by Rob.Cannaday Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit. Break up calls in batches of 100 ids. #jira OR-20674 #rb ian.fox #tests login to front end with PC, PS4. forced tests to simulate > 100 requests. Change 3065197 on 2016/07/26 by Bart.Bressler Change how PS4 sessions work: - We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions. - Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable - Added comments, other misc. code cleanup. #rb josh.markiewicz, sam.zamani, rob.cannaday #tests created cross play parties with multiple pc + ps4 players #jira OR-20332 Change 3065158 on 2016/07/26 by Lina.Halper Fix the guid keep generated by adding to the database. - This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible #rb: Martin.Wilson #jira: UE-33772, UE-33454 #tests: cooked AI_Test map, editor rename curves Change 3064735 on 2016/07/26 by Dmitry.Rekman Linux: added WebRTC libs. - Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc). #rb none #tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform. (Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064727 on 2016/07/26 by Dmitry.Rekman Fix crash on cooker exit (UE-33583). - Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it. #rb none #tests Compiled and ran Linux server and Linux client. (Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064725 on 2016/07/26 by Dmitry.Rekman Linux: use libc++ instead of libstdc++. - Needed to solve problems with third-party C++ libraries (e.g. WebRTC). - Bundled libc++ 3.8.1 (TPS cleared). - Turned off ICU compilation (needs recompile against libc++). - Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix. #rb none #tests Built and ran a number of Linux targets. (Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064572 on 2016/07/26 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 29.2 @ CL 3064545 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3064523 on 2016/07/26 by Jon.Lietz Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements. #RB none #tests BP compiles and stays not dirty #codereview dave.ratti@epicgames.com [CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
UGameplayTask_ClaimResource* UGameplayTask_ClaimResource::ClaimResources(IGameplayTaskOwnerInterface& InTaskOwner, const TArray<TSubclassOf<UGameplayTaskResource> >& ResourceClasses, const uint8 Priority, const FName TaskInstanceName)
{
if (ResourceClasses.Num() == 0)
{
return nullptr;
}
UGameplayTask_ClaimResource* MyTask = NewTaskUninitialized<UGameplayTask_ClaimResource>();
if (MyTask)
{
MyTask->InitTask(InTaskOwner, Priority);
MyTask->InstanceName = TaskInstanceName;
for (const TSubclassOf<UGameplayTaskResource>& ResourceClass : ResourceClasses)
{
MyTask->AddClaimedResource(ResourceClass);
}
}
return MyTask;
}