Files
UnrealEngineUWP/Engine/Source/Runtime/AIModule/Private/BehaviorTree/BehaviorTreeManager.cpp

529 lines
17 KiB
C++
Raw Normal View History

// Copyright Epic Games, Inc. All Rights Reserved.
#include "BehaviorTree/BehaviorTreeManager.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "UObject/UObjectHash.h"
#include "UObject/Class.h"
#include "UObject/UObjectIterator.h"
#include "EngineGlobals.h"
#include "Engine/Engine.h"
#include "AISystem.h"
#include "BehaviorTree/BehaviorTreeTypes.h"
#include "BehaviorTree/BTNode.h"
#include "BehaviorTree/BTTaskNode.h"
#include "BehaviorTree/BTDecorator.h"
#include "BehaviorTree/BTService.h"
#include "BehaviorTree/BTCompositeNode.h"
#include "BehaviorTree/BehaviorTree.h"
#include "BehaviorTree/Tasks/BTTask_RunBehavior.h"
#if WITH_EDITOR
#include "Kismet2/KismetEditorUtilities.h"
#endif // WITH_EDITOR
DEFINE_STAT(STAT_AI_BehaviorTree_Tick);
DEFINE_STAT(STAT_AI_BehaviorTree_LoadTime);
DEFINE_STAT(STAT_AI_BehaviorTree_SearchTime);
DEFINE_STAT(STAT_AI_BehaviorTree_ExecutionTime);
DEFINE_STAT(STAT_AI_BehaviorTree_AuxUpdateTime);
DEFINE_STAT(STAT_AI_BehaviorTree_Cleanup);
DEFINE_STAT(STAT_AI_BehaviorTree_StopTree);
DEFINE_STAT(STAT_AI_BehaviorTree_NumTemplates);
DEFINE_STAT(STAT_AI_BehaviorTree_NumInstances);
DEFINE_STAT(STAT_AI_BehaviorTree_InstanceMemory);
UBehaviorTreeManager::UBehaviorTreeManager(const FObjectInitializer& ObjectInitializer) : Super(ObjectInitializer)
{
MaxDebuggerSteps = 100;
}
void UBehaviorTreeManager::FinishDestroy()
{
SET_DWORD_STAT(STAT_AI_BehaviorTree_NumTemplates, 0);
for (int32 Idx = 0; Idx < ActiveComponents.Num(); Idx++)
{
if (ActiveComponents[Idx] && !ActiveComponents[Idx]->HasAnyFlags(RF_BeginDestroyed))
{
ActiveComponents[Idx]->Cleanup();
}
}
ActiveComponents.Reset();
Super::FinishDestroy();
}
int32 UBehaviorTreeManager::GetAlignedDataSize(int32 Size)
{
// round to 4 bytes
return ((Size + 3) & ~3);
}
struct FNodeInitializationData
{
UBTNode* Node;
UBTCompositeNode* ParentNode;
uint16 ExecutionIndex;
uint16 DataSize;
uint16 SpecialDataSize;
uint8 TreeDepth;
FNodeInitializationData() {}
FNodeInitializationData(UBTNode* InNode, UBTCompositeNode* InParentNode,
uint16 InExecutionIndex, uint8 InTreeDepth, uint16 NodeMemory, uint16 SpecialNodeMemory = 0)
: Node(InNode), ParentNode(InParentNode), ExecutionIndex(InExecutionIndex), TreeDepth(InTreeDepth)
{
SpecialDataSize = UBehaviorTreeManager::GetAlignedDataSize(SpecialNodeMemory);
const uint16 NodeMemorySize = NodeMemory + SpecialDataSize;
DataSize = (NodeMemorySize <= 2) ? NodeMemorySize : UBehaviorTreeManager::GetAlignedDataSize(NodeMemorySize);
}
struct FMemorySort
{
FORCEINLINE bool operator()(const FNodeInitializationData& A, const FNodeInitializationData& B) const
{
return A.DataSize > B.DataSize;
}
};
};
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3058661) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3038116 on 2016/07/05 by James.Golding Resave QA-Promotion with new heightfield GUID to fix crash on load (broken DDC in Guildford) Change 3038271 on 2016/07/05 by Lukasz.Furman fixed bug with instanced behavior tree nodes writing over memory of other nodes #jira UE-32789 Change 3038295 on 2016/07/05 by Lukasz.Furman changed behavior tree node injection to modify shared template instead of switching nodes to instanced fixes GC reference chain between AI using the same behavior tree Change 3038504 on 2016/07/05 by Zak.Middleton #ue4 - Fix typo in comment (debugging arrow). github #2352 #jira 30255 Change 3039151 on 2016/07/06 by James.Golding UE-30046 Add bAllowCPUAccess flag to UStaticMesh Change 3039281 on 2016/07/06 by Ori.Cohen Fix attached partially simulating ragdolls not moving with actor. #JIRA UE-32830 Change 3039286 on 2016/07/06 by Benn.Gallagher Fixed crash with large clothing simulation meshes. Extended max verts from ~16k to ~65k and made it so you can no longer force import clothing above the maximum threshold that the vertex buffer is allowed to hold. Change 3039313 on 2016/07/06 by Benn.Gallagher Enabled override of angular joint bias on AnimDynamics Change 3039335 on 2016/07/06 by Ori.Cohen Fixed skeletal mesh components with non simulated root bodies incorrectly detaching from component hierarchy. #JIRA UE-32833 Change 3039412 on 2016/07/06 by Ori.Cohen PR #2382: Bug when setting constraint orientation using axes parameters (Contributed by DaveC79) #JIRA UE-30725 Change 3039799 on 2016/07/06 by Tom.Looman - Renamed SuggestProjectileVelocity_MediumArc to _CustomArc and added support for high/low arcs using float param. (Migrated from Odin) - Fixed bug in override gravity for the suggest projectile velocity functions. Change 3039903 on 2016/07/06 by Ori.Cohen Ensure that skeletal mesh components do NOT teleport unless explicitly asked to. Change 3039932 on 2016/07/06 by Lina.Halper Merging using //Orion/Dev-General_to_//UE4/Dev-Framework serialize crash is always bad, so dupe checkin. Change 3040059 on 2016/07/06 by Ori.Cohen Fix bug where FixedFramerate was only clamping delta times that were above (very slow delta time was not getting changed to the fixed framerate) #JIRA UE-32730 Change 3040203 on 2016/07/06 by Jon.Nabozny Fix scaling multiple selected Actors by changing scale-base translation calculations to local space. #jira UE-32357 Change 3040211 on 2016/07/06 by Ori.Cohen Fix constraints being unselectable in phat when a render mesh is on top #JIRA UE-32479 Change 3040273 on 2016/07/06 by Ori.Cohen Fix vehicle drag adding instead of removing energy when in reverse. #JIRA UE-28957 Change 3040293 on 2016/07/06 by Zak.Middleton #ue4 - Add FMath::ClosestPointOnInfiniteLine() to distinguish it from the (poorly named) ClosestPointOnLine() that actually works on segments. Change 3040325 on 2016/07/06 by Zak.Middleton #ue4 - Avoid checking for "client only" builds when recording demos. It could be a demo recording in standalone. Minor impact to previous optimization. #udn https://udn.unrealengine.com/questions/301595/412-413-regression-in-actorgetnetmode.html Change 3040950 on 2016/07/07 by Thomas.Sarkanen Removed GWorld from FTimerManager Switched LastAssignedHandle to a static member. #jira UE-31485 - Remove GWorld from FTimerManager Change 3041054 on 2016/07/07 by Jon.Nabozny Fix warning about negation operator on FRotator introduced in CL 3040203. Change 3041214 on 2016/07/07 by Ori.Cohen Fix hit events on skeletal mesh component not respecting the AND between skeletal mesh component and the ragdoll bodies #JIRA UE-29538 Change 3041319 on 2016/07/07 by James.Golding UE-29771 - Rename LocalAtoms to BoneSpaceTransforms - Rename SpaceBases to ComponentSpaceTransforms Change 3041432 on 2016/07/07 by James.Golding UE-30937 Add FindCollisionUV util to GameplayStatics, but only works if you set new bSupportUVFromHitResults flag in PhysicsSettings, as we need to store UV info in the BodySetup. This is kept with the cooked mesh data in the DDC. Also remove PhysicsSettings.h from PhysicalMaterial.h Change 3041434 on 2016/07/07 by James.Golding Improve comment on UStaticMesh::bAllowCPUAccess Change 3041701 on 2016/07/07 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3041498 Change 3041760 on 2016/07/07 by Ori.Cohen Fix bug where turning collision off and on for a welded root body would not re-weld child bodies. #JIRA UE-32438 Change 3041771 on 2016/07/07 by Marc.Audy Add GetParentActor convience accessor Change 3041798 on 2016/07/07 by Marc.Audy Don't double call BeginPlay on ChildActors when loading sublevels (4.12) #jira UE-32772 Change 3041857 on 2016/07/07 by Jon.Nabozny Allow modifying and reading EnableGravity flags on individual bones within a SkeletalMeshComponent via BoneName. #jira UE-32272 Change 3041914 on 2016/07/07 by Marc.Audy Fix mismatch function prototype Change 3042041 on 2016/07/07 by Jon.Nabozny Fix CIS issue introduced by CL 3041857 Change 3042402 on 2016/07/08 by James.Golding Fix CIS after no longer globally including PhysicsSettings.h Change 3042517 on 2016/07/08 by Martin.Wilson Fix root motion when actor and component transforms do not match #jira UE-32944 Change 3043021 on 2016/07/08 by mason.seay Assets for testing poses Change 3043246 on 2016/07/08 by Marc.Audy Eliminate USoundWave::CompressionName Add USoundWave::HasCompressedFormat #jira UE-32546 Change 3044376 on 2016/07/11 by James.Golding - UE-32907 : Change UStaticMesh::GetPhysicsTriMeshData to only return required verts (ie will not return verts of sections with collision disabled) - Add UVInfo mem usage to UBodySetup::GetResourceSize - Remove BodySetup.h from EnginePrivate.h - Remove outdated comment in PhysUtils.cpp Change 3044464 on 2016/07/11 by Ori.Cohen Fix CIS #JIRA UE-33005 Change 3044519 on 2016/07/11 by Ori.Cohen PR #2379: Option to Generate Overlaps for Actor during Level Streaming (Contributed by error454) #JIRA UE-30712 Change 3044774 on 2016/07/11 by Zak.Middleton #ue4 - Fix typos in comments. Change 3044854 on 2016/07/11 by Mieszko.Zielinski Made AI sight's default trace channel configurable and set it to ECC_Visibility #UE4 #jira UE-32013 Change 3044855 on 2016/07/11 by Mieszko.Zielinski Fixed BB key selectors not being resolved properly in BP implemented nodes #UE4 #jira UE-32458 Change 3044887 on 2016/07/11 by Zak.Middleton #ue4 - Added new Blueprint library math/vector functions: FindClosestPointOnSegment, FindClosestPointOnLine, GetPointDistanceToSegment, GetPointDistanceToLine. - Fixed comments on FindNearestPointsOnLineSegments. - Fixed comments on FMath::PointDistToLine, and renamed "Line" parameter to "Direction". Merge CL 3036162. Change 3044910 on 2016/07/11 by Mieszko.Zielinski Fixed AISense_Sight not reporting any hits on ECC_Visibility channel #UE4 Change 3045144 on 2016/07/11 by Lukasz.Furman exposed pathfollowing's reach test modifier: goal radius as parameter of move request Change 3045174 on 2016/07/11 by Marc.Audy Remove incorrect SetMobility reference from comment #jira UE-30492 Change 3045233 on 2016/07/11 by Marc.Audy Correct function name in warning Change 3045284 on 2016/07/11 by mason.seay Test Assets for pose blending Change 3045342 on 2016/07/11 by Michael.Noland PR #2284: Added PAPER2D_API to FSpriteDrawCallRecord (Contributed by grisevg) #jira UE-29522 Change 3045343 on 2016/07/11 by Michael.Noland PR #2533: Fixed bug that caused the tabs in the Flipbook, Sprite, and CodeProject editors to show the editor name rather than the asset name (Contributed by DevVancouver) #jira UE-32403 Change 3045344 on 2016/07/11 by Michael.Noland Paper2D: Fixed BP-created tile map components being incapable of having collision generated for them (still requires calling SetLayerCollision with rebuild=true or RebuildCollision) Paper2D: Exposed the ability to directly rebuild collision on a UPaperTileMap #jira UE-31632 Change 3045382 on 2016/07/11 by Ori.Cohen Expose mobility filtering query params. Allows users to filter out static mobility for example from scene queries. #JIRA UE-29937 Change 3045529 on 2016/07/11 by Zak.Middleton #ue4 - Improve comment about FFindFloorResult.bBlockingHit, explaining it is a valid blocking hit that was not in penetration. Other conditions can be determined from the HitResult itself. Change 3045601 on 2016/07/11 by Michael.Noland Paper2D: Expose UPaperTileMap and UPaperTileSet as BlueprintType #jira UE-20962 Change 3046039 on 2016/07/12 by Jurre.deBaare Instanced HLOD materials to reduce permutations + compilation time Change 3046147 on 2016/07/12 by Ori.Cohen PR #1615: Traceworldforposition should trace async scene too #JIRA UE-21728 Change 3046180 on 2016/07/12 by Ori.Cohen Introduce a shape complexity project setting #JIRA UE-31159 Change 3046280 on 2016/07/12 by Ori.Cohen Change physics blend weights to only affect rendering data. For effects that require updating physx we recommend using the new physical animation component. #JIRA UE-31525, UE-19252 Change 3046282 on 2016/07/12 by Benn.Gallagher Fix for crash or notify corruption when reverting the "Event" struct in montage notify editor. - Made default slot 0, as a montage should always have at least one slot - Made it impossible to revert the "Event" struct as it contains stuff that shouldn't be reverted. Can still revert its members though #jira UE-32626 Change 3046284 on 2016/07/12 by Benn.Gallagher Fix for crash or notify corruption when reverting the "Event" struct in montage notify editor. - Made default slot 0, as a montage should always have at least one slot - Made it impossible to revert the "Event" struct as it contains stuff that shouldn't be reverted. Can still revert its members though (2nd CL, missed file) #jira UE-32626 Change 3046416 on 2016/07/12 by Jon.Nabozny PR #2512: Change InstancedStaticMesh allow transform update to teleport (Contributed by joelmcginnis) #jira UE32123 Change 3046428 on 2016/07/12 by Michael.Noland Paper2D: Fixed inconsistent lighting on lit grouped sprites (caused by bad normals on any grouped sprites that were rotated away from (0,0,0)) #jira UE-33055 Change 3046429 on 2016/07/12 by Michael.Noland Paper2D: Fixed inconsistent lighting on lit tilemaps in standalone or cooked builds (caused by trying to use the canonical Paper2D tangent basis before it has been initialized) #jira UE-25994 Change 3046475 on 2016/07/12 by Ori.Cohen Added strength multiplyer for physical animation #JIRA UE-33075 Change 3046518 on 2016/07/12 by Ori.Cohen Make sure to refresh contact points when turning simulation on for bodies. #JIRA UE-31286 Change 3046658 on 2016/07/12 by Ori.Cohen Fix the case where setting body blend weight doesn't turn off blend override. Change 3046720 on 2016/07/12 by Ori.Cohen Added option to allow skeletal mesh simulation to NOT affect component transform. #JIRA UE-33089 Change 3046908 on 2016/07/12 by Ori.Cohen Fix welded body not properly unwelding when in a chain of welded bodies #JIRA UE-32531 Change 3047015 on 2016/07/12 by Lukasz.Furman fixed nested repath requests Change 3047102 on 2016/07/12 by Ori.Cohen Added physics component to content example Change 3047848 on 2016/07/13 by Ori.Cohen Expose transform update mode to phat #JIRA UE-33227 Change 3047853 on 2016/07/13 by Ori.Cohen Update physical animation level and content. Was missing some blueprints Change 3047897 on 2016/07/13 by Ori.Cohen PR #2066: PhysX: Remove copy-paste code from LoadPhysXModules (Contributed by bozaro) #JIRA UE-27102 Change 3048026 on 2016/07/13 by Benn.Gallagher Altered reference gathering for retargetting to consider nodes in the Ubergraph. This catches refrerences as variables in the event graph and default values on event graph pins. #jira UE-23823 Change 3048592 on 2016/07/13 by Marc.Audy Change check when physics state exists but not registered to ensure and add additional logging information. #jira UE-32935 Change 3048790 on 2016/07/13 by Ori.Cohen Fix CIS for shipping physx builds. #JIRA UE-33246 Change 3048801 on 2016/07/13 by Ori.Cohen Update RootBodyTransform when ref skeleton has offset Change 3048891 on 2016/07/13 by Marc.Audy Fix copy paste bug with AudioComponent::SetPitchMultiplier Change 3049549 on 2016/07/14 by Thomas.Sarkanen Prevented stale anim asset references from persisting in wired pins Made sure to clear out the old asset in asset players when pins are made/destroyed. This requires a temporary string reference to the asset in UAnimGraphNode_AssetPlayerBase. Fixed up anim getters to properly use pin-default assets (previously they used the internal asset ptr that was not guaranteed to be in sync). Also fixe dup error messaging to be a bit more helpful when editing transition rules. Fixed up the various animation asset players to correctly display names when the asset is not set internally. Also correctly report compilation errors when pins are connected. Moved FA3NodeOptionalPinManager to new file ane renamed to FAnimBlueprintNodeOptionalPinManager to avoid circular includes. #jira UE-31015 - Asset Pins Keep Reference To Old 'Static' Asset Change 3049576 on 2016/07/14 by Thomas.Sarkanen Fix CIS linker errors Change 3049611 on 2016/07/14 by Benn.Gallagher Fixed "Isolate" checkbox in Persona mesh details not working on sections with clothing assigned (previously disabled drawing for all sections) Fixed "Highlight" checkbox in Persona mesh details not working after Section/Chunk refactor #jira UE-31016 #jira UE-33061 Change 3049663 on 2016/07/14 by Benn.Gallagher CIS fix after Persona render fixes Change 3049794 on 2016/07/14 by Marc.Audy Some cleanup and ensuring ActiveSound adds references to all of its used assets Change 3049823 on 2016/07/14 by Tom.Looman Added Player Connect and Disconnect Multicast Events to GameMode PR #2398: Player Connect and Disconnect Multicast Events (for Plugins) (Contributed by dreckard) Change 3049896 on 2016/07/14 by Ori.Cohen Fix cases where updating welded bodies is causing physx body to ignore the kinematic flag. #JIRA UE-31660 Change 3049921 on 2016/07/14 by Benn.Gallagher PR #2294: Reduce PhysX simulate() memory churn (Contributed by roberttroughton) - Modifications: Per PxScene buffers, 16 byte alignment required for simulate call, skip clothing scenes (unused, we simulate per-actor) #jira UE-29573 Change 3049929 on 2016/07/14 by Zak.Middleton #ue4 - Make GetDefault<T>(UClass*) assert that the class is castable to T. Change 3049956 on 2016/07/14 by Zak.Middleton #ue4 - Back out changelist 3049929 until I fix CastChecked<> compile issue. Change 3049992 on 2016/07/14 by Jon.Nabozny Fix infite jumps when JumpMaxHoldTime is set. Also, allow multi-jumping out of the box. #JIRA: UE-31601 Change 3050017 on 2016/07/14 by James.Golding PR #2412: Make CalcSceneView and GetProjectionData in ULocalPlayer virtual (Contributed by yehaike) Change 3050061 on 2016/07/14 by Zak.Middleton #ue4 - Make GetDefault<T>(UClass*) assert that the class is castable to T. Change 3050254 on 2016/07/14 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614 Change 3050416 on 2016/07/14 by mason.seay Test map and asset for slicing proc meshes Change 3050881 on 2016/07/14 by Zak.Middleton #ue4 - Make FSavedMove_Character::CanCombineWith easier to debug. Consolidate duplicate code to one block. github #2047 Change 3051401 on 2016/07/15 by Thomas.Sarkanen Prevented animation from restarting each time a new section is selected/inspected in the montage editor Preserved playback state when changing section. Added SetWeight function to montage instance as when switching between sections the montage would blend from ref-pose while paused. #jira UE-31014 - Moving Montage Event Unpauses Playback #jira UE-25101 - Improve Montage Replay Usability issue Change 3051717 on 2016/07/15 by Benn.Gallagher Removed call to set sleepVelocityFrameDecayConstant on destructible shapes after advice from Nvidia and investigation by some licensees. Feature was used in the past to better settle piles but now PhysX can handle it fine and by setting it we were causing a hit in island generation. #jira UE-18558 Change 3051729 on 2016/07/15 by Benn.Gallagher Changed enum combo boxes so that they use rich tooltips instead of text tooltips. - They look the same when there isn't a documentation entry for them (Just the enum name) - Enum docs stored in /Shared/Enums/{EnumType} and the excerpt names are just the enum name Change 3051825 on 2016/07/15 by Marc.Audy Display HiddenInGame for SceneComponents except when part of flattened properties in an Actor such as StaticMeshActor #jira UE-29435 Change 3051850 on 2016/07/15 by Marc.Audy Reduce priority of audio thread Add a frame sync to avoid audio thread drifiting behind Change 3051920 on 2016/07/15 by Tom.Looman Added ActorComponent Activate/Deactivate events #JIRA UE-31077 Change 3051923 on 2016/07/15 by Tom.Looman PR #2370: Exposing "OverrideWith" and "CopyProperties" in PlayerState to Blueprint Children (Contributed by eXifreXi) Change 3052038 on 2016/07/15 by Martin.Wilson Possible fix for fortnite crash + ensure incase the situation occurs again #jira UE-33258 Change 3052042 on 2016/07/15 by Jurre.deBaare Copying //Tasks/Framework/DEV-UEFW-21-AlembicImporter to Dev-Framework (//UE4/Dev-Framework) Change 3052171 on 2016/07/15 by Ori.Cohen Improve UI for constraint profiles. Polish UI for physical animation profile. #JIRA UEFW-101, UE-33290 Change 3052243 on 2016/07/15 by Martin.Wilson Pose watching: Ability to draw bones of pose at any point in the anim graph. #jira UE-12181 (originally Epic Friday project) Change 3053202 on 2016/07/18 by Thomas.Sarkanen FAnimInstanceProxy::EvaulateAnimation is now split into two for easier extensibility #jira UE-30107 - Split out part of FAnimInstanceProxy::EvaulateAnimation to allow users to use node evaluate without code duplication Change 3053203 on 2016/07/18 by Thomas.Sarkanen Fixed properties that are fed to skeletal mesh components via construction script not updating when edited Forced skeletal mesh components to re-init their anim instance on reregister when in an editor world (a previous optimization was preventing this). Switched order of RerunConstructionScripts and ReregisterAllComponentsto be in-line with the undo/redo case to prevent edits being a frame out of date. #jira UE-31890 - Variables cast from the Construction Script do not update in AnimBP AnimGraph Change 3053241 on 2016/07/18 by Martin.Wilson Add parent bone space to GetSocketTransform #jira UE-29814 Change 3053270 on 2016/07/18 by Jurre.deBaare PR #2105: Disable creation of array modifiers (Contributed by projectgheist) Change 3053273 on 2016/07/18 by Jurre.deBaare Default ini for asset viewer and HDR images #jira UE-32903 Change 3053527 on 2016/07/18 by Ori.Cohen Fix CIS #JIRA UE-33375 Change 3053620 on 2016/07/18 by Thomas.Sarkanen Socket chooser now has a search box Uses new FTextFilterExpressionEvaluator to filter bones & sockets by name. Search box has focus when the menu appears. #jira UE-23698 - Need a way to search through the Choose Socket or Bone: UI when attaching to a skeletal mesh Change 3053626 on 2016/07/18 by Martin.Wilson Fix crash caused by skeletalmeshcomponent being destroyed during a notify #jira UE-33258 Change 3053761 on 2016/07/18 by Martin.Wilson Mac build compile fix Change 3053858 on 2016/07/18 by Lina.Halper Merging using //UE4/Dev-Framework/_to_//Fortnite/Main/ Fix on crashing recursive asset Change 3053864 on 2016/07/18 by Ori.Cohen Make sure phat UI changes when picking different constraint profiles Change 3053866 on 2016/07/18 by Ori.Cohen Submit content example for constraint profiles Change 3053915 on 2016/07/18 by Lina.Halper The cached animinstance won't refresh until animation is replaced if you open while anim bp is opened This is the fix for that. #jira: UE-32927 Change 3053969 on 2016/07/18 by James.Golding PR #2571: Added a SimEventCallbackFactory (Contributed by NaturalMotionTechnology) Change 3054004 on 2016/07/18 by Ori.Cohen Fix crash in welding when children have no owner component and ensure query only does not get welded by mistake. #jira UE-33333 Change 3054410 on 2016/07/18 by Lina.Halper Fixed issue with moving translation not working with mirrored parent due to inverse position. Changed to Transform. #jira: UE-31521 Change 3054659 on 2016/07/18 by Lina.Halper Fix for retargeting of pose asset - Moved animsequence::retarget to be out to AnimationRuntime - PoseAsset is now using that function to retarget correctly #code review: Martin.Wilson, Ori.Cohen Change 3054777 on 2016/07/18 by Jurre.deBaare Fixing integration blocker, had this fix locally already #jira UE-33427 Change 3056619 on 2016/07/19 by Ori.Cohen Temporarily turn off audio threading due to heap corruption. #JIRA UE-33320 Change 3057770 on 2016/07/20 by Aaron.McLeran Doing sync trace for occlusion if audio thread is enabled #jira UE-33494 Change 3057778 on 2016/07/20 by Aaron.McLeran #jira UE-33494 Fix async line traces from audio thread causing crash (re-enable threaded audio) Change 3057788 on 2016/07/20 by Aaron.McLeran #jira UE-33494 Fix async line traces from audio thread causing crash (re-enable threaded audio) Enabling audio thread (with a capital T for True) Change 3057850 on 2016/07/20 by Ori.Cohen Temporarily turn off audio threading as the feature is still experimental Change 3057876 on 2016/07/20 by Martin.Wilson Fix Graph Linked External Object issue when saving recompressed animations #jira UE-33567 Change 3058371 on 2016/07/20 by Ori.Cohen Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) [CL 3058682 by Ori Cohen in Main branch]
2016-07-20 18:23:54 -04:00
static void MergeDecoratorOpsHelper(TArray<FBTDecoratorLogic>& LinkOps, const TArray<FBTDecoratorLogic>& InjectedOps, const int32 NumOriginalDecorators, const int32 NumInjectedDecorators)
{
if (LinkOps.Num() == 0 && InjectedOps.Num() == 0)
{
return;
}
const int32 NumOriginalOps = LinkOps.Num();
if (NumOriginalDecorators > 0)
{
// and operator for two groups of composites: original and new one
FBTDecoratorLogic MasterAndOp(EBTDecoratorLogic::And, LinkOps.Num() ? 2 : (NumOriginalDecorators + 1));
LinkOps.Insert(MasterAndOp, 0);
if (NumOriginalOps == 0)
{
// add Test operations, original link didn't have composite operators
for (int32 Idx = 0; Idx < NumOriginalDecorators; Idx++)
{
FBTDecoratorLogic TestOp(EBTDecoratorLogic::Test, Idx);
LinkOps.Add(TestOp);
}
}
}
// add injected operators
if (InjectedOps.Num() == 0)
{
FBTDecoratorLogic InjectedAndOp(EBTDecoratorLogic::And, NumInjectedDecorators);
LinkOps.Add(InjectedAndOp);
for (int32 Idx = 0; Idx < NumInjectedDecorators; Idx++)
{
FBTDecoratorLogic TestOp(EBTDecoratorLogic::Test, NumOriginalDecorators + Idx);
LinkOps.Add(TestOp);
}
}
else
{
for (int32 Idx = 0; Idx < InjectedOps.Num(); Idx++)
{
FBTDecoratorLogic InjectedOpCopy = InjectedOps[Idx];
if (InjectedOpCopy.Operation == EBTDecoratorLogic::Test)
{
InjectedOpCopy.Number += NumOriginalDecorators;
}
LinkOps.Add(InjectedOpCopy);
}
}
}
static void InitializeNodeHelper(UBTCompositeNode* ParentNode, UBTNode* NodeOb,
uint8 TreeDepth, uint16& ExecutionIndex, TArray<FNodeInitializationData>& InitList,
UBehaviorTree& TreeAsset, UObject* NodeOuter)
{
InitList.Add(FNodeInitializationData(NodeOb, ParentNode, ExecutionIndex, TreeDepth, NodeOb->GetInstanceMemorySize(), NodeOb->GetSpecialMemorySize()));
{
FScopedBTLoggingContext LogContext(NodeOb);
NodeOb->InitializeFromAsset(TreeAsset);
}
ExecutionIndex++;
UBTCompositeNode* CompositeOb = Cast<UBTCompositeNode>(NodeOb);
if (CompositeOb)
{
for (int32 ServiceIndex = 0; ServiceIndex < CompositeOb->Services.Num(); ServiceIndex++)
{
if (CompositeOb->Services[ServiceIndex] == NULL)
{
UE_LOG(LogBehaviorTree, Warning, TEXT("%s has missing service node! (parent: %s)"),
*TreeAsset.GetName(), *UBehaviorTreeTypes::DescribeNodeHelper(CompositeOb));
CompositeOb->Services.RemoveAt(ServiceIndex, 1, false);
ServiceIndex--;
continue;
}
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720537 on 2015/10/07 by Aaron.McLeran Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick Change 2746582 on 2015/10/29 by Aaron.McLeran Implementing single ray-cast sound occlusion - Fixing/Implementing sound occlusion using one ray cast - Update rate of the ray cast is conifgurable by the user - User can enabled/disable occlusion and set various properties of the occlusion at the audio component level - Occlusion ray-casts are made at a slower rate than the audio engine is updated - The following properties are supported: * LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded) * OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded) * OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions) - Fixed how low-pass filter frequency is applied on platforms that support it. * Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter * Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering) * Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params. * At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used * Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied. * XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing. #rb zak.middleton Change 2765174 on 2015/11/12 by Aaron.McLeran UE-23091 More fixage for NaN audio log spam Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense. To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h. - Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread. - Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe. - I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate #codereview Zak.Middleton #rb Zak.Middleton Change 2765467 on 2015/11/13 by James.Golding - Allow -ms option to work with 'stat dumphitches' for controlling min time logged #rb gil.gribb Change 2765746 on 2015/11/13 by Benn.Gallagher Added buckets for update rate shift tags (for staggering anim updates) #jira UE-23213 #rb Bruce.Nesbit Change 2765747 on 2015/11/13 by Benn.Gallagher Fixes for bone length calculation in anim dynamics chains. #rb Bruce.Nesbit Change 2765749 on 2015/11/13 by Benn.Gallagher Removed allocations from local CS blends for skeletal controls. #rb Bruce.Nesbit Change 2765752 on 2015/11/13 by Benn.Gallagher Lod mapping support for URO customization #jira UE-23211 #rb Bruce.Nesbit Change 2765965 on 2015/11/13 by Marc.Audy Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE #jira UE-21181 #rb Josh.Markiewicz Change 2766071 on 2015/11/13 by Mieszko.Zielinski Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4 the 'bTickDuringGame == bTickDuringGame' thing #rb John.Abercrombie Change 2766086 on 2015/11/13 by Mieszko.Zielinski Exposing NavModifierComponent to ENGINE_API #UE4 #codereview Lukasz.Furman Change 2766345 on 2015/11/13 by Mieszko.Zielinski No longer compiling AISystem's creation out from client builds #UE4 Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable Change 2766346 on 2015/11/13 by Mieszko.Zielinski Improvements to EQS test scoring function preview #UE4 #rb Lukasz.Furman Change 2766528 on 2015/11/13 by Stan.Melax multiple materials/chunks on a single cloth sim mesh This supposedly used to work in 4.7 but broke for 4.8 It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts. Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration. jira: #UE-23300 https://jira.ol.epicgames.net/browse/UE-23300 https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674 #rb Benn.Gallagher Change 2766546 on 2015/11/13 by Marc.Audy Throw warning for orphaned looping sounds caused by a looping sound node Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping #rb Aaron.McLeran Change 2766917 on 2015/11/14 by Jurre.deBaare Fix UE4-23349 Simplygon doens't support sub 64 pixel textures Change 2767742 on 2015/11/16 by Marc.Audy Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton. Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls #rb Zak.Middleton, Rob.Manuszewski Change 2767827 on 2015/11/16 by Zak.Middleton #ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached. - New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received. - Also fixes trying to smooth rotation towards identity rotation before receiving network updates. - Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now). #rb Dan.Youhon Change 2768070 on 2015/11/16 by Marc.Audy Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues) Fixup usages to avoid unnecessary string -> char* -> name conversions Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version #rb Gil.Gribb Change 2768121 on 2015/11/16 by Marc.Audy Forceinline GetFName Change 2768161 on 2015/11/16 by Aaron.McLeran Checking occlusion back in - Bug was due to improper interpolation of LPFFrequency values in audio volumes. Change 2769428 on 2015/11/17 by Thomas.Sarkanen Fixed backwards-compatibility issues with FExposedValueCopyRecord Added PostSerialize function to patch up older data to the new format (copies properties->property FNames). Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation. UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter()) #rb James.Golding #codereview Mike.Beach,Bob.Tellez Change 2769488 on 2015/11/17 by Benn.Gallagher DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona #rb Martin.Wilson Change 2769545 on 2015/11/17 by Benn.Gallagher Added space conversion options to copy bone node. #jira OR-9430 #rb Martin.Wilson Change 2770228 on 2015/11/17 by Marc.Audy Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false #rb Ori.Cohen #jira UE-23366 Change 2770489 on 2015/11/17 by Marc.Audy Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise Change 2770761 on 2015/11/17 by Aaron.McLeran Removing optimization disablement - Forgot to remove these lines before checking in/testing. Change 2771375 on 2015/11/18 by Thomas.Sarkanen Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines #rb Benn.Gallagher Change 2771697 on 2015/11/18 by Jeff.Farris Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake #rb marc.audy Change 2771755 on 2015/11/18 by Marc.Audy Put back in the recursion block for destroy actor #rb James.Golding Change 2772217 on 2015/11/18 by Marc.Audy Update axis inversion to work the same way as sensitivity instead of old problematic way Also change to use Reset instead of Empty(Array.Num()) #rb Jeff.Farris Change 2772686 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization coordinate bug. Don't need to convert to xaudio2 coordinates for HRTF spatialization #rb chad.taylor Change 2772766 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization with xaudio2 voice pools - Issue was caused by 2 issues: - effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices) - Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool. #rb chad.taylor Change 2773027 on 2015/11/19 by Thomas.Sarkanen PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts) #rb Thomas.Sarkanen Change 2773142 on 2015/11/19 by Benn.Gallagher Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose. - Only iterating beyond the index of the first bone transform, cutting off all bones before - No longer using a bone mask the size of the skeleton, just an array of interesting nodes - No longer attempting to convert a transform if it isn't necessary (which was happening a lot) #rb Laurent.Delayen Change 2773212 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Removing ugly comment. Not going to remove the node itself for backward compatibility. Change 2773351 on 2015/11/19 by Zak.Middleton #orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates. #rb Dan.Youhon Change 2773599 on 2015/11/19 by Marc.Audy Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang #codereview Aaron.McLeran Change 2773661 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Following up by deprecating the CastToPlayerController function for 4.11. Change 2774707 on 2015/11/19 by Stan.Melax FCollisionQueryParams constructor API pitfall Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName. So this line of code: FCollisionQueryParams Param(FName(TEXT("DragDropTrace"))); will invoke: FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...) But this line of code: FCollisionQueryParams Param(TEXT("DragDropTrace")); invokes: FCollisionQueryParams::FCollisionQueryParams(bool) Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended. It looks like this interface was introduced in CL 1792949 back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach. Making an API change would break things for existing projects. If it had been a more recent change we could have probably just gone down to a single constructor right away. Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters. see also https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html #codereview ori.cohen [CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
UBTService* Service = Cast<UBTService>(StaticDuplicateObject(CompositeOb->Services[ServiceIndex], NodeOuter));;
CompositeOb->Services[ServiceIndex] = Service;
InitList.Add(FNodeInitializationData(Service, CompositeOb, ExecutionIndex, TreeDepth,
Service->GetInstanceMemorySize(), Service->GetSpecialMemorySize()));
FScopedBTLoggingContext LogContext(Service);
Service->InitializeFromAsset(TreeAsset);
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
// don't initialize parent link for services on composite node
ExecutionIndex++;
}
for (int32 ChildIndex = 0; ChildIndex < CompositeOb->Children.Num(); ChildIndex++)
{
FBTCompositeChild& ChildInfo = CompositeOb->Children[ChildIndex];
for (int32 DecoratorIndex = 0; DecoratorIndex < ChildInfo.Decorators.Num(); DecoratorIndex++)
{
if (ChildInfo.Decorators[DecoratorIndex] == NULL)
{
UE_LOG(LogBehaviorTree, Warning, TEXT("%s has missing decorator node! (parent: %s, branch: %d)"),
*TreeAsset.GetName(), *UBehaviorTreeTypes::DescribeNodeHelper(CompositeOb), ChildIndex);
ChildInfo.Decorators.RemoveAt(DecoratorIndex, 1, false);
DecoratorIndex--;
continue;
}
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720537 on 2015/10/07 by Aaron.McLeran Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick Change 2746582 on 2015/10/29 by Aaron.McLeran Implementing single ray-cast sound occlusion - Fixing/Implementing sound occlusion using one ray cast - Update rate of the ray cast is conifgurable by the user - User can enabled/disable occlusion and set various properties of the occlusion at the audio component level - Occlusion ray-casts are made at a slower rate than the audio engine is updated - The following properties are supported: * LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded) * OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded) * OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions) - Fixed how low-pass filter frequency is applied on platforms that support it. * Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter * Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering) * Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params. * At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used * Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied. * XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing. #rb zak.middleton Change 2765174 on 2015/11/12 by Aaron.McLeran UE-23091 More fixage for NaN audio log spam Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense. To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h. - Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread. - Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe. - I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate #codereview Zak.Middleton #rb Zak.Middleton Change 2765467 on 2015/11/13 by James.Golding - Allow -ms option to work with 'stat dumphitches' for controlling min time logged #rb gil.gribb Change 2765746 on 2015/11/13 by Benn.Gallagher Added buckets for update rate shift tags (for staggering anim updates) #jira UE-23213 #rb Bruce.Nesbit Change 2765747 on 2015/11/13 by Benn.Gallagher Fixes for bone length calculation in anim dynamics chains. #rb Bruce.Nesbit Change 2765749 on 2015/11/13 by Benn.Gallagher Removed allocations from local CS blends for skeletal controls. #rb Bruce.Nesbit Change 2765752 on 2015/11/13 by Benn.Gallagher Lod mapping support for URO customization #jira UE-23211 #rb Bruce.Nesbit Change 2765965 on 2015/11/13 by Marc.Audy Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE #jira UE-21181 #rb Josh.Markiewicz Change 2766071 on 2015/11/13 by Mieszko.Zielinski Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4 the 'bTickDuringGame == bTickDuringGame' thing #rb John.Abercrombie Change 2766086 on 2015/11/13 by Mieszko.Zielinski Exposing NavModifierComponent to ENGINE_API #UE4 #codereview Lukasz.Furman Change 2766345 on 2015/11/13 by Mieszko.Zielinski No longer compiling AISystem's creation out from client builds #UE4 Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable Change 2766346 on 2015/11/13 by Mieszko.Zielinski Improvements to EQS test scoring function preview #UE4 #rb Lukasz.Furman Change 2766528 on 2015/11/13 by Stan.Melax multiple materials/chunks on a single cloth sim mesh This supposedly used to work in 4.7 but broke for 4.8 It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts. Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration. jira: #UE-23300 https://jira.ol.epicgames.net/browse/UE-23300 https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674 #rb Benn.Gallagher Change 2766546 on 2015/11/13 by Marc.Audy Throw warning for orphaned looping sounds caused by a looping sound node Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping #rb Aaron.McLeran Change 2766917 on 2015/11/14 by Jurre.deBaare Fix UE4-23349 Simplygon doens't support sub 64 pixel textures Change 2767742 on 2015/11/16 by Marc.Audy Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton. Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls #rb Zak.Middleton, Rob.Manuszewski Change 2767827 on 2015/11/16 by Zak.Middleton #ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached. - New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received. - Also fixes trying to smooth rotation towards identity rotation before receiving network updates. - Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now). #rb Dan.Youhon Change 2768070 on 2015/11/16 by Marc.Audy Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues) Fixup usages to avoid unnecessary string -> char* -> name conversions Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version #rb Gil.Gribb Change 2768121 on 2015/11/16 by Marc.Audy Forceinline GetFName Change 2768161 on 2015/11/16 by Aaron.McLeran Checking occlusion back in - Bug was due to improper interpolation of LPFFrequency values in audio volumes. Change 2769428 on 2015/11/17 by Thomas.Sarkanen Fixed backwards-compatibility issues with FExposedValueCopyRecord Added PostSerialize function to patch up older data to the new format (copies properties->property FNames). Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation. UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter()) #rb James.Golding #codereview Mike.Beach,Bob.Tellez Change 2769488 on 2015/11/17 by Benn.Gallagher DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona #rb Martin.Wilson Change 2769545 on 2015/11/17 by Benn.Gallagher Added space conversion options to copy bone node. #jira OR-9430 #rb Martin.Wilson Change 2770228 on 2015/11/17 by Marc.Audy Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false #rb Ori.Cohen #jira UE-23366 Change 2770489 on 2015/11/17 by Marc.Audy Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise Change 2770761 on 2015/11/17 by Aaron.McLeran Removing optimization disablement - Forgot to remove these lines before checking in/testing. Change 2771375 on 2015/11/18 by Thomas.Sarkanen Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines #rb Benn.Gallagher Change 2771697 on 2015/11/18 by Jeff.Farris Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake #rb marc.audy Change 2771755 on 2015/11/18 by Marc.Audy Put back in the recursion block for destroy actor #rb James.Golding Change 2772217 on 2015/11/18 by Marc.Audy Update axis inversion to work the same way as sensitivity instead of old problematic way Also change to use Reset instead of Empty(Array.Num()) #rb Jeff.Farris Change 2772686 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization coordinate bug. Don't need to convert to xaudio2 coordinates for HRTF spatialization #rb chad.taylor Change 2772766 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization with xaudio2 voice pools - Issue was caused by 2 issues: - effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices) - Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool. #rb chad.taylor Change 2773027 on 2015/11/19 by Thomas.Sarkanen PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts) #rb Thomas.Sarkanen Change 2773142 on 2015/11/19 by Benn.Gallagher Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose. - Only iterating beyond the index of the first bone transform, cutting off all bones before - No longer using a bone mask the size of the skeleton, just an array of interesting nodes - No longer attempting to convert a transform if it isn't necessary (which was happening a lot) #rb Laurent.Delayen Change 2773212 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Removing ugly comment. Not going to remove the node itself for backward compatibility. Change 2773351 on 2015/11/19 by Zak.Middleton #orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates. #rb Dan.Youhon Change 2773599 on 2015/11/19 by Marc.Audy Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang #codereview Aaron.McLeran Change 2773661 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Following up by deprecating the CastToPlayerController function for 4.11. Change 2774707 on 2015/11/19 by Stan.Melax FCollisionQueryParams constructor API pitfall Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName. So this line of code: FCollisionQueryParams Param(FName(TEXT("DragDropTrace"))); will invoke: FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...) But this line of code: FCollisionQueryParams Param(TEXT("DragDropTrace")); invokes: FCollisionQueryParams::FCollisionQueryParams(bool) Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended. It looks like this interface was introduced in CL 1792949 back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach. Making an API change would break things for existing projects. If it had been a more recent change we could have probably just gone down to a single constructor right away. Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters. see also https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html #codereview ori.cohen [CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
UBTDecorator* Decorator = Cast<UBTDecorator>(StaticDuplicateObject(ChildInfo.Decorators[DecoratorIndex], NodeOuter));
ChildInfo.Decorators[DecoratorIndex] = Decorator;
InitList.Add(FNodeInitializationData(Decorator, CompositeOb, ExecutionIndex, TreeDepth,
Decorator->GetInstanceMemorySize(), Decorator->GetSpecialMemorySize()));
FScopedBTLoggingContext LogContext(Decorator);
Decorator->InitializeFromAsset(TreeAsset);
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
Decorator->InitializeParentLink(ChildIndex);
ExecutionIndex++;
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3058661) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3038116 on 2016/07/05 by James.Golding Resave QA-Promotion with new heightfield GUID to fix crash on load (broken DDC in Guildford) Change 3038271 on 2016/07/05 by Lukasz.Furman fixed bug with instanced behavior tree nodes writing over memory of other nodes #jira UE-32789 Change 3038295 on 2016/07/05 by Lukasz.Furman changed behavior tree node injection to modify shared template instead of switching nodes to instanced fixes GC reference chain between AI using the same behavior tree Change 3038504 on 2016/07/05 by Zak.Middleton #ue4 - Fix typo in comment (debugging arrow). github #2352 #jira 30255 Change 3039151 on 2016/07/06 by James.Golding UE-30046 Add bAllowCPUAccess flag to UStaticMesh Change 3039281 on 2016/07/06 by Ori.Cohen Fix attached partially simulating ragdolls not moving with actor. #JIRA UE-32830 Change 3039286 on 2016/07/06 by Benn.Gallagher Fixed crash with large clothing simulation meshes. Extended max verts from ~16k to ~65k and made it so you can no longer force import clothing above the maximum threshold that the vertex buffer is allowed to hold. Change 3039313 on 2016/07/06 by Benn.Gallagher Enabled override of angular joint bias on AnimDynamics Change 3039335 on 2016/07/06 by Ori.Cohen Fixed skeletal mesh components with non simulated root bodies incorrectly detaching from component hierarchy. #JIRA UE-32833 Change 3039412 on 2016/07/06 by Ori.Cohen PR #2382: Bug when setting constraint orientation using axes parameters (Contributed by DaveC79) #JIRA UE-30725 Change 3039799 on 2016/07/06 by Tom.Looman - Renamed SuggestProjectileVelocity_MediumArc to _CustomArc and added support for high/low arcs using float param. (Migrated from Odin) - Fixed bug in override gravity for the suggest projectile velocity functions. Change 3039903 on 2016/07/06 by Ori.Cohen Ensure that skeletal mesh components do NOT teleport unless explicitly asked to. Change 3039932 on 2016/07/06 by Lina.Halper Merging using //Orion/Dev-General_to_//UE4/Dev-Framework serialize crash is always bad, so dupe checkin. Change 3040059 on 2016/07/06 by Ori.Cohen Fix bug where FixedFramerate was only clamping delta times that were above (very slow delta time was not getting changed to the fixed framerate) #JIRA UE-32730 Change 3040203 on 2016/07/06 by Jon.Nabozny Fix scaling multiple selected Actors by changing scale-base translation calculations to local space. #jira UE-32357 Change 3040211 on 2016/07/06 by Ori.Cohen Fix constraints being unselectable in phat when a render mesh is on top #JIRA UE-32479 Change 3040273 on 2016/07/06 by Ori.Cohen Fix vehicle drag adding instead of removing energy when in reverse. #JIRA UE-28957 Change 3040293 on 2016/07/06 by Zak.Middleton #ue4 - Add FMath::ClosestPointOnInfiniteLine() to distinguish it from the (poorly named) ClosestPointOnLine() that actually works on segments. Change 3040325 on 2016/07/06 by Zak.Middleton #ue4 - Avoid checking for "client only" builds when recording demos. It could be a demo recording in standalone. Minor impact to previous optimization. #udn https://udn.unrealengine.com/questions/301595/412-413-regression-in-actorgetnetmode.html Change 3040950 on 2016/07/07 by Thomas.Sarkanen Removed GWorld from FTimerManager Switched LastAssignedHandle to a static member. #jira UE-31485 - Remove GWorld from FTimerManager Change 3041054 on 2016/07/07 by Jon.Nabozny Fix warning about negation operator on FRotator introduced in CL 3040203. Change 3041214 on 2016/07/07 by Ori.Cohen Fix hit events on skeletal mesh component not respecting the AND between skeletal mesh component and the ragdoll bodies #JIRA UE-29538 Change 3041319 on 2016/07/07 by James.Golding UE-29771 - Rename LocalAtoms to BoneSpaceTransforms - Rename SpaceBases to ComponentSpaceTransforms Change 3041432 on 2016/07/07 by James.Golding UE-30937 Add FindCollisionUV util to GameplayStatics, but only works if you set new bSupportUVFromHitResults flag in PhysicsSettings, as we need to store UV info in the BodySetup. This is kept with the cooked mesh data in the DDC. Also remove PhysicsSettings.h from PhysicalMaterial.h Change 3041434 on 2016/07/07 by James.Golding Improve comment on UStaticMesh::bAllowCPUAccess Change 3041701 on 2016/07/07 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3041498 Change 3041760 on 2016/07/07 by Ori.Cohen Fix bug where turning collision off and on for a welded root body would not re-weld child bodies. #JIRA UE-32438 Change 3041771 on 2016/07/07 by Marc.Audy Add GetParentActor convience accessor Change 3041798 on 2016/07/07 by Marc.Audy Don't double call BeginPlay on ChildActors when loading sublevels (4.12) #jira UE-32772 Change 3041857 on 2016/07/07 by Jon.Nabozny Allow modifying and reading EnableGravity flags on individual bones within a SkeletalMeshComponent via BoneName. #jira UE-32272 Change 3041914 on 2016/07/07 by Marc.Audy Fix mismatch function prototype Change 3042041 on 2016/07/07 by Jon.Nabozny Fix CIS issue introduced by CL 3041857 Change 3042402 on 2016/07/08 by James.Golding Fix CIS after no longer globally including PhysicsSettings.h Change 3042517 on 2016/07/08 by Martin.Wilson Fix root motion when actor and component transforms do not match #jira UE-32944 Change 3043021 on 2016/07/08 by mason.seay Assets for testing poses Change 3043246 on 2016/07/08 by Marc.Audy Eliminate USoundWave::CompressionName Add USoundWave::HasCompressedFormat #jira UE-32546 Change 3044376 on 2016/07/11 by James.Golding - UE-32907 : Change UStaticMesh::GetPhysicsTriMeshData to only return required verts (ie will not return verts of sections with collision disabled) - Add UVInfo mem usage to UBodySetup::GetResourceSize - Remove BodySetup.h from EnginePrivate.h - Remove outdated comment in PhysUtils.cpp Change 3044464 on 2016/07/11 by Ori.Cohen Fix CIS #JIRA UE-33005 Change 3044519 on 2016/07/11 by Ori.Cohen PR #2379: Option to Generate Overlaps for Actor during Level Streaming (Contributed by error454) #JIRA UE-30712 Change 3044774 on 2016/07/11 by Zak.Middleton #ue4 - Fix typos in comments. Change 3044854 on 2016/07/11 by Mieszko.Zielinski Made AI sight's default trace channel configurable and set it to ECC_Visibility #UE4 #jira UE-32013 Change 3044855 on 2016/07/11 by Mieszko.Zielinski Fixed BB key selectors not being resolved properly in BP implemented nodes #UE4 #jira UE-32458 Change 3044887 on 2016/07/11 by Zak.Middleton #ue4 - Added new Blueprint library math/vector functions: FindClosestPointOnSegment, FindClosestPointOnLine, GetPointDistanceToSegment, GetPointDistanceToLine. - Fixed comments on FindNearestPointsOnLineSegments. - Fixed comments on FMath::PointDistToLine, and renamed "Line" parameter to "Direction". Merge CL 3036162. Change 3044910 on 2016/07/11 by Mieszko.Zielinski Fixed AISense_Sight not reporting any hits on ECC_Visibility channel #UE4 Change 3045144 on 2016/07/11 by Lukasz.Furman exposed pathfollowing's reach test modifier: goal radius as parameter of move request Change 3045174 on 2016/07/11 by Marc.Audy Remove incorrect SetMobility reference from comment #jira UE-30492 Change 3045233 on 2016/07/11 by Marc.Audy Correct function name in warning Change 3045284 on 2016/07/11 by mason.seay Test Assets for pose blending Change 3045342 on 2016/07/11 by Michael.Noland PR #2284: Added PAPER2D_API to FSpriteDrawCallRecord (Contributed by grisevg) #jira UE-29522 Change 3045343 on 2016/07/11 by Michael.Noland PR #2533: Fixed bug that caused the tabs in the Flipbook, Sprite, and CodeProject editors to show the editor name rather than the asset name (Contributed by DevVancouver) #jira UE-32403 Change 3045344 on 2016/07/11 by Michael.Noland Paper2D: Fixed BP-created tile map components being incapable of having collision generated for them (still requires calling SetLayerCollision with rebuild=true or RebuildCollision) Paper2D: Exposed the ability to directly rebuild collision on a UPaperTileMap #jira UE-31632 Change 3045382 on 2016/07/11 by Ori.Cohen Expose mobility filtering query params. Allows users to filter out static mobility for example from scene queries. #JIRA UE-29937 Change 3045529 on 2016/07/11 by Zak.Middleton #ue4 - Improve comment about FFindFloorResult.bBlockingHit, explaining it is a valid blocking hit that was not in penetration. Other conditions can be determined from the HitResult itself. Change 3045601 on 2016/07/11 by Michael.Noland Paper2D: Expose UPaperTileMap and UPaperTileSet as BlueprintType #jira UE-20962 Change 3046039 on 2016/07/12 by Jurre.deBaare Instanced HLOD materials to reduce permutations + compilation time Change 3046147 on 2016/07/12 by Ori.Cohen PR #1615: Traceworldforposition should trace async scene too #JIRA UE-21728 Change 3046180 on 2016/07/12 by Ori.Cohen Introduce a shape complexity project setting #JIRA UE-31159 Change 3046280 on 2016/07/12 by Ori.Cohen Change physics blend weights to only affect rendering data. For effects that require updating physx we recommend using the new physical animation component. #JIRA UE-31525, UE-19252 Change 3046282 on 2016/07/12 by Benn.Gallagher Fix for crash or notify corruption when reverting the "Event" struct in montage notify editor. - Made default slot 0, as a montage should always have at least one slot - Made it impossible to revert the "Event" struct as it contains stuff that shouldn't be reverted. Can still revert its members though #jira UE-32626 Change 3046284 on 2016/07/12 by Benn.Gallagher Fix for crash or notify corruption when reverting the "Event" struct in montage notify editor. - Made default slot 0, as a montage should always have at least one slot - Made it impossible to revert the "Event" struct as it contains stuff that shouldn't be reverted. Can still revert its members though (2nd CL, missed file) #jira UE-32626 Change 3046416 on 2016/07/12 by Jon.Nabozny PR #2512: Change InstancedStaticMesh allow transform update to teleport (Contributed by joelmcginnis) #jira UE32123 Change 3046428 on 2016/07/12 by Michael.Noland Paper2D: Fixed inconsistent lighting on lit grouped sprites (caused by bad normals on any grouped sprites that were rotated away from (0,0,0)) #jira UE-33055 Change 3046429 on 2016/07/12 by Michael.Noland Paper2D: Fixed inconsistent lighting on lit tilemaps in standalone or cooked builds (caused by trying to use the canonical Paper2D tangent basis before it has been initialized) #jira UE-25994 Change 3046475 on 2016/07/12 by Ori.Cohen Added strength multiplyer for physical animation #JIRA UE-33075 Change 3046518 on 2016/07/12 by Ori.Cohen Make sure to refresh contact points when turning simulation on for bodies. #JIRA UE-31286 Change 3046658 on 2016/07/12 by Ori.Cohen Fix the case where setting body blend weight doesn't turn off blend override. Change 3046720 on 2016/07/12 by Ori.Cohen Added option to allow skeletal mesh simulation to NOT affect component transform. #JIRA UE-33089 Change 3046908 on 2016/07/12 by Ori.Cohen Fix welded body not properly unwelding when in a chain of welded bodies #JIRA UE-32531 Change 3047015 on 2016/07/12 by Lukasz.Furman fixed nested repath requests Change 3047102 on 2016/07/12 by Ori.Cohen Added physics component to content example Change 3047848 on 2016/07/13 by Ori.Cohen Expose transform update mode to phat #JIRA UE-33227 Change 3047853 on 2016/07/13 by Ori.Cohen Update physical animation level and content. Was missing some blueprints Change 3047897 on 2016/07/13 by Ori.Cohen PR #2066: PhysX: Remove copy-paste code from LoadPhysXModules (Contributed by bozaro) #JIRA UE-27102 Change 3048026 on 2016/07/13 by Benn.Gallagher Altered reference gathering for retargetting to consider nodes in the Ubergraph. This catches refrerences as variables in the event graph and default values on event graph pins. #jira UE-23823 Change 3048592 on 2016/07/13 by Marc.Audy Change check when physics state exists but not registered to ensure and add additional logging information. #jira UE-32935 Change 3048790 on 2016/07/13 by Ori.Cohen Fix CIS for shipping physx builds. #JIRA UE-33246 Change 3048801 on 2016/07/13 by Ori.Cohen Update RootBodyTransform when ref skeleton has offset Change 3048891 on 2016/07/13 by Marc.Audy Fix copy paste bug with AudioComponent::SetPitchMultiplier Change 3049549 on 2016/07/14 by Thomas.Sarkanen Prevented stale anim asset references from persisting in wired pins Made sure to clear out the old asset in asset players when pins are made/destroyed. This requires a temporary string reference to the asset in UAnimGraphNode_AssetPlayerBase. Fixed up anim getters to properly use pin-default assets (previously they used the internal asset ptr that was not guaranteed to be in sync). Also fixe dup error messaging to be a bit more helpful when editing transition rules. Fixed up the various animation asset players to correctly display names when the asset is not set internally. Also correctly report compilation errors when pins are connected. Moved FA3NodeOptionalPinManager to new file ane renamed to FAnimBlueprintNodeOptionalPinManager to avoid circular includes. #jira UE-31015 - Asset Pins Keep Reference To Old 'Static' Asset Change 3049576 on 2016/07/14 by Thomas.Sarkanen Fix CIS linker errors Change 3049611 on 2016/07/14 by Benn.Gallagher Fixed "Isolate" checkbox in Persona mesh details not working on sections with clothing assigned (previously disabled drawing for all sections) Fixed "Highlight" checkbox in Persona mesh details not working after Section/Chunk refactor #jira UE-31016 #jira UE-33061 Change 3049663 on 2016/07/14 by Benn.Gallagher CIS fix after Persona render fixes Change 3049794 on 2016/07/14 by Marc.Audy Some cleanup and ensuring ActiveSound adds references to all of its used assets Change 3049823 on 2016/07/14 by Tom.Looman Added Player Connect and Disconnect Multicast Events to GameMode PR #2398: Player Connect and Disconnect Multicast Events (for Plugins) (Contributed by dreckard) Change 3049896 on 2016/07/14 by Ori.Cohen Fix cases where updating welded bodies is causing physx body to ignore the kinematic flag. #JIRA UE-31660 Change 3049921 on 2016/07/14 by Benn.Gallagher PR #2294: Reduce PhysX simulate() memory churn (Contributed by roberttroughton) - Modifications: Per PxScene buffers, 16 byte alignment required for simulate call, skip clothing scenes (unused, we simulate per-actor) #jira UE-29573 Change 3049929 on 2016/07/14 by Zak.Middleton #ue4 - Make GetDefault<T>(UClass*) assert that the class is castable to T. Change 3049956 on 2016/07/14 by Zak.Middleton #ue4 - Back out changelist 3049929 until I fix CastChecked<> compile issue. Change 3049992 on 2016/07/14 by Jon.Nabozny Fix infite jumps when JumpMaxHoldTime is set. Also, allow multi-jumping out of the box. #JIRA: UE-31601 Change 3050017 on 2016/07/14 by James.Golding PR #2412: Make CalcSceneView and GetProjectionData in ULocalPlayer virtual (Contributed by yehaike) Change 3050061 on 2016/07/14 by Zak.Middleton #ue4 - Make GetDefault<T>(UClass*) assert that the class is castable to T. Change 3050254 on 2016/07/14 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614 Change 3050416 on 2016/07/14 by mason.seay Test map and asset for slicing proc meshes Change 3050881 on 2016/07/14 by Zak.Middleton #ue4 - Make FSavedMove_Character::CanCombineWith easier to debug. Consolidate duplicate code to one block. github #2047 Change 3051401 on 2016/07/15 by Thomas.Sarkanen Prevented animation from restarting each time a new section is selected/inspected in the montage editor Preserved playback state when changing section. Added SetWeight function to montage instance as when switching between sections the montage would blend from ref-pose while paused. #jira UE-31014 - Moving Montage Event Unpauses Playback #jira UE-25101 - Improve Montage Replay Usability issue Change 3051717 on 2016/07/15 by Benn.Gallagher Removed call to set sleepVelocityFrameDecayConstant on destructible shapes after advice from Nvidia and investigation by some licensees. Feature was used in the past to better settle piles but now PhysX can handle it fine and by setting it we were causing a hit in island generation. #jira UE-18558 Change 3051729 on 2016/07/15 by Benn.Gallagher Changed enum combo boxes so that they use rich tooltips instead of text tooltips. - They look the same when there isn't a documentation entry for them (Just the enum name) - Enum docs stored in /Shared/Enums/{EnumType} and the excerpt names are just the enum name Change 3051825 on 2016/07/15 by Marc.Audy Display HiddenInGame for SceneComponents except when part of flattened properties in an Actor such as StaticMeshActor #jira UE-29435 Change 3051850 on 2016/07/15 by Marc.Audy Reduce priority of audio thread Add a frame sync to avoid audio thread drifiting behind Change 3051920 on 2016/07/15 by Tom.Looman Added ActorComponent Activate/Deactivate events #JIRA UE-31077 Change 3051923 on 2016/07/15 by Tom.Looman PR #2370: Exposing "OverrideWith" and "CopyProperties" in PlayerState to Blueprint Children (Contributed by eXifreXi) Change 3052038 on 2016/07/15 by Martin.Wilson Possible fix for fortnite crash + ensure incase the situation occurs again #jira UE-33258 Change 3052042 on 2016/07/15 by Jurre.deBaare Copying //Tasks/Framework/DEV-UEFW-21-AlembicImporter to Dev-Framework (//UE4/Dev-Framework) Change 3052171 on 2016/07/15 by Ori.Cohen Improve UI for constraint profiles. Polish UI for physical animation profile. #JIRA UEFW-101, UE-33290 Change 3052243 on 2016/07/15 by Martin.Wilson Pose watching: Ability to draw bones of pose at any point in the anim graph. #jira UE-12181 (originally Epic Friday project) Change 3053202 on 2016/07/18 by Thomas.Sarkanen FAnimInstanceProxy::EvaulateAnimation is now split into two for easier extensibility #jira UE-30107 - Split out part of FAnimInstanceProxy::EvaulateAnimation to allow users to use node evaluate without code duplication Change 3053203 on 2016/07/18 by Thomas.Sarkanen Fixed properties that are fed to skeletal mesh components via construction script not updating when edited Forced skeletal mesh components to re-init their anim instance on reregister when in an editor world (a previous optimization was preventing this). Switched order of RerunConstructionScripts and ReregisterAllComponentsto be in-line with the undo/redo case to prevent edits being a frame out of date. #jira UE-31890 - Variables cast from the Construction Script do not update in AnimBP AnimGraph Change 3053241 on 2016/07/18 by Martin.Wilson Add parent bone space to GetSocketTransform #jira UE-29814 Change 3053270 on 2016/07/18 by Jurre.deBaare PR #2105: Disable creation of array modifiers (Contributed by projectgheist) Change 3053273 on 2016/07/18 by Jurre.deBaare Default ini for asset viewer and HDR images #jira UE-32903 Change 3053527 on 2016/07/18 by Ori.Cohen Fix CIS #JIRA UE-33375 Change 3053620 on 2016/07/18 by Thomas.Sarkanen Socket chooser now has a search box Uses new FTextFilterExpressionEvaluator to filter bones & sockets by name. Search box has focus when the menu appears. #jira UE-23698 - Need a way to search through the Choose Socket or Bone: UI when attaching to a skeletal mesh Change 3053626 on 2016/07/18 by Martin.Wilson Fix crash caused by skeletalmeshcomponent being destroyed during a notify #jira UE-33258 Change 3053761 on 2016/07/18 by Martin.Wilson Mac build compile fix Change 3053858 on 2016/07/18 by Lina.Halper Merging using //UE4/Dev-Framework/_to_//Fortnite/Main/ Fix on crashing recursive asset Change 3053864 on 2016/07/18 by Ori.Cohen Make sure phat UI changes when picking different constraint profiles Change 3053866 on 2016/07/18 by Ori.Cohen Submit content example for constraint profiles Change 3053915 on 2016/07/18 by Lina.Halper The cached animinstance won't refresh until animation is replaced if you open while anim bp is opened This is the fix for that. #jira: UE-32927 Change 3053969 on 2016/07/18 by James.Golding PR #2571: Added a SimEventCallbackFactory (Contributed by NaturalMotionTechnology) Change 3054004 on 2016/07/18 by Ori.Cohen Fix crash in welding when children have no owner component and ensure query only does not get welded by mistake. #jira UE-33333 Change 3054410 on 2016/07/18 by Lina.Halper Fixed issue with moving translation not working with mirrored parent due to inverse position. Changed to Transform. #jira: UE-31521 Change 3054659 on 2016/07/18 by Lina.Halper Fix for retargeting of pose asset - Moved animsequence::retarget to be out to AnimationRuntime - PoseAsset is now using that function to retarget correctly #code review: Martin.Wilson, Ori.Cohen Change 3054777 on 2016/07/18 by Jurre.deBaare Fixing integration blocker, had this fix locally already #jira UE-33427 Change 3056619 on 2016/07/19 by Ori.Cohen Temporarily turn off audio threading due to heap corruption. #JIRA UE-33320 Change 3057770 on 2016/07/20 by Aaron.McLeran Doing sync trace for occlusion if audio thread is enabled #jira UE-33494 Change 3057778 on 2016/07/20 by Aaron.McLeran #jira UE-33494 Fix async line traces from audio thread causing crash (re-enable threaded audio) Change 3057788 on 2016/07/20 by Aaron.McLeran #jira UE-33494 Fix async line traces from audio thread causing crash (re-enable threaded audio) Enabling audio thread (with a capital T for True) Change 3057850 on 2016/07/20 by Ori.Cohen Temporarily turn off audio threading as the feature is still experimental Change 3057876 on 2016/07/20 by Martin.Wilson Fix Graph Linked External Object issue when saving recompressed animations #jira UE-33567 Change 3058371 on 2016/07/20 by Ori.Cohen Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) [CL 3058682 by Ori Cohen in Main branch]
2016-07-20 18:23:54 -04:00
// inject root level decorators from subtree task
UBTTask_RunBehavior* SubtreeTask = Cast<UBTTask_RunBehavior>(ChildInfo.ChildTask);
if (SubtreeTask && SubtreeTask->GetSubtreeAsset() && SubtreeTask->GetSubtreeAsset()->RootDecorators.Num())
{
UBehaviorTree& SubtreeAsset = *SubtreeTask->GetSubtreeAsset();
const int32 NumOrgDecorators = ChildInfo.Decorators.Num();
for (int32 DecoratorIndex = 0; DecoratorIndex < SubtreeAsset.RootDecorators.Num(); DecoratorIndex++)
{
if (SubtreeAsset.RootDecorators[DecoratorIndex] == NULL)
{
UE_LOG(LogBehaviorTree, Warning, TEXT("%s can't inject decorator from %s! (parent: %s, branch: %d)"),
*TreeAsset.GetName(), *SubtreeAsset.GetName(),
*UBehaviorTreeTypes::DescribeNodeHelper(CompositeOb), ChildIndex);
continue;
}
UBTDecorator* Decorator = Cast<UBTDecorator>(StaticDuplicateObject(SubtreeAsset.RootDecorators[DecoratorIndex], NodeOuter));
ChildInfo.Decorators.Add(Decorator);
InitList.Add(FNodeInitializationData(Decorator, CompositeOb, ExecutionIndex, TreeDepth,
Decorator->GetInstanceMemorySize(), Decorator->GetSpecialMemorySize()));
// initialize with parent tree
Decorator->MarkInjectedNode();
FScopedBTLoggingContext LogContext(Decorator);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3058661) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3038116 on 2016/07/05 by James.Golding Resave QA-Promotion with new heightfield GUID to fix crash on load (broken DDC in Guildford) Change 3038271 on 2016/07/05 by Lukasz.Furman fixed bug with instanced behavior tree nodes writing over memory of other nodes #jira UE-32789 Change 3038295 on 2016/07/05 by Lukasz.Furman changed behavior tree node injection to modify shared template instead of switching nodes to instanced fixes GC reference chain between AI using the same behavior tree Change 3038504 on 2016/07/05 by Zak.Middleton #ue4 - Fix typo in comment (debugging arrow). github #2352 #jira 30255 Change 3039151 on 2016/07/06 by James.Golding UE-30046 Add bAllowCPUAccess flag to UStaticMesh Change 3039281 on 2016/07/06 by Ori.Cohen Fix attached partially simulating ragdolls not moving with actor. #JIRA UE-32830 Change 3039286 on 2016/07/06 by Benn.Gallagher Fixed crash with large clothing simulation meshes. Extended max verts from ~16k to ~65k and made it so you can no longer force import clothing above the maximum threshold that the vertex buffer is allowed to hold. Change 3039313 on 2016/07/06 by Benn.Gallagher Enabled override of angular joint bias on AnimDynamics Change 3039335 on 2016/07/06 by Ori.Cohen Fixed skeletal mesh components with non simulated root bodies incorrectly detaching from component hierarchy. #JIRA UE-32833 Change 3039412 on 2016/07/06 by Ori.Cohen PR #2382: Bug when setting constraint orientation using axes parameters (Contributed by DaveC79) #JIRA UE-30725 Change 3039799 on 2016/07/06 by Tom.Looman - Renamed SuggestProjectileVelocity_MediumArc to _CustomArc and added support for high/low arcs using float param. (Migrated from Odin) - Fixed bug in override gravity for the suggest projectile velocity functions. Change 3039903 on 2016/07/06 by Ori.Cohen Ensure that skeletal mesh components do NOT teleport unless explicitly asked to. Change 3039932 on 2016/07/06 by Lina.Halper Merging using //Orion/Dev-General_to_//UE4/Dev-Framework serialize crash is always bad, so dupe checkin. Change 3040059 on 2016/07/06 by Ori.Cohen Fix bug where FixedFramerate was only clamping delta times that were above (very slow delta time was not getting changed to the fixed framerate) #JIRA UE-32730 Change 3040203 on 2016/07/06 by Jon.Nabozny Fix scaling multiple selected Actors by changing scale-base translation calculations to local space. #jira UE-32357 Change 3040211 on 2016/07/06 by Ori.Cohen Fix constraints being unselectable in phat when a render mesh is on top #JIRA UE-32479 Change 3040273 on 2016/07/06 by Ori.Cohen Fix vehicle drag adding instead of removing energy when in reverse. #JIRA UE-28957 Change 3040293 on 2016/07/06 by Zak.Middleton #ue4 - Add FMath::ClosestPointOnInfiniteLine() to distinguish it from the (poorly named) ClosestPointOnLine() that actually works on segments. Change 3040325 on 2016/07/06 by Zak.Middleton #ue4 - Avoid checking for "client only" builds when recording demos. It could be a demo recording in standalone. Minor impact to previous optimization. #udn https://udn.unrealengine.com/questions/301595/412-413-regression-in-actorgetnetmode.html Change 3040950 on 2016/07/07 by Thomas.Sarkanen Removed GWorld from FTimerManager Switched LastAssignedHandle to a static member. #jira UE-31485 - Remove GWorld from FTimerManager Change 3041054 on 2016/07/07 by Jon.Nabozny Fix warning about negation operator on FRotator introduced in CL 3040203. Change 3041214 on 2016/07/07 by Ori.Cohen Fix hit events on skeletal mesh component not respecting the AND between skeletal mesh component and the ragdoll bodies #JIRA UE-29538 Change 3041319 on 2016/07/07 by James.Golding UE-29771 - Rename LocalAtoms to BoneSpaceTransforms - Rename SpaceBases to ComponentSpaceTransforms Change 3041432 on 2016/07/07 by James.Golding UE-30937 Add FindCollisionUV util to GameplayStatics, but only works if you set new bSupportUVFromHitResults flag in PhysicsSettings, as we need to store UV info in the BodySetup. This is kept with the cooked mesh data in the DDC. Also remove PhysicsSettings.h from PhysicalMaterial.h Change 3041434 on 2016/07/07 by James.Golding Improve comment on UStaticMesh::bAllowCPUAccess Change 3041701 on 2016/07/07 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3041498 Change 3041760 on 2016/07/07 by Ori.Cohen Fix bug where turning collision off and on for a welded root body would not re-weld child bodies. #JIRA UE-32438 Change 3041771 on 2016/07/07 by Marc.Audy Add GetParentActor convience accessor Change 3041798 on 2016/07/07 by Marc.Audy Don't double call BeginPlay on ChildActors when loading sublevels (4.12) #jira UE-32772 Change 3041857 on 2016/07/07 by Jon.Nabozny Allow modifying and reading EnableGravity flags on individual bones within a SkeletalMeshComponent via BoneName. #jira UE-32272 Change 3041914 on 2016/07/07 by Marc.Audy Fix mismatch function prototype Change 3042041 on 2016/07/07 by Jon.Nabozny Fix CIS issue introduced by CL 3041857 Change 3042402 on 2016/07/08 by James.Golding Fix CIS after no longer globally including PhysicsSettings.h Change 3042517 on 2016/07/08 by Martin.Wilson Fix root motion when actor and component transforms do not match #jira UE-32944 Change 3043021 on 2016/07/08 by mason.seay Assets for testing poses Change 3043246 on 2016/07/08 by Marc.Audy Eliminate USoundWave::CompressionName Add USoundWave::HasCompressedFormat #jira UE-32546 Change 3044376 on 2016/07/11 by James.Golding - UE-32907 : Change UStaticMesh::GetPhysicsTriMeshData to only return required verts (ie will not return verts of sections with collision disabled) - Add UVInfo mem usage to UBodySetup::GetResourceSize - Remove BodySetup.h from EnginePrivate.h - Remove outdated comment in PhysUtils.cpp Change 3044464 on 2016/07/11 by Ori.Cohen Fix CIS #JIRA UE-33005 Change 3044519 on 2016/07/11 by Ori.Cohen PR #2379: Option to Generate Overlaps for Actor during Level Streaming (Contributed by error454) #JIRA UE-30712 Change 3044774 on 2016/07/11 by Zak.Middleton #ue4 - Fix typos in comments. Change 3044854 on 2016/07/11 by Mieszko.Zielinski Made AI sight's default trace channel configurable and set it to ECC_Visibility #UE4 #jira UE-32013 Change 3044855 on 2016/07/11 by Mieszko.Zielinski Fixed BB key selectors not being resolved properly in BP implemented nodes #UE4 #jira UE-32458 Change 3044887 on 2016/07/11 by Zak.Middleton #ue4 - Added new Blueprint library math/vector functions: FindClosestPointOnSegment, FindClosestPointOnLine, GetPointDistanceToSegment, GetPointDistanceToLine. - Fixed comments on FindNearestPointsOnLineSegments. - Fixed comments on FMath::PointDistToLine, and renamed "Line" parameter to "Direction". Merge CL 3036162. Change 3044910 on 2016/07/11 by Mieszko.Zielinski Fixed AISense_Sight not reporting any hits on ECC_Visibility channel #UE4 Change 3045144 on 2016/07/11 by Lukasz.Furman exposed pathfollowing's reach test modifier: goal radius as parameter of move request Change 3045174 on 2016/07/11 by Marc.Audy Remove incorrect SetMobility reference from comment #jira UE-30492 Change 3045233 on 2016/07/11 by Marc.Audy Correct function name in warning Change 3045284 on 2016/07/11 by mason.seay Test Assets for pose blending Change 3045342 on 2016/07/11 by Michael.Noland PR #2284: Added PAPER2D_API to FSpriteDrawCallRecord (Contributed by grisevg) #jira UE-29522 Change 3045343 on 2016/07/11 by Michael.Noland PR #2533: Fixed bug that caused the tabs in the Flipbook, Sprite, and CodeProject editors to show the editor name rather than the asset name (Contributed by DevVancouver) #jira UE-32403 Change 3045344 on 2016/07/11 by Michael.Noland Paper2D: Fixed BP-created tile map components being incapable of having collision generated for them (still requires calling SetLayerCollision with rebuild=true or RebuildCollision) Paper2D: Exposed the ability to directly rebuild collision on a UPaperTileMap #jira UE-31632 Change 3045382 on 2016/07/11 by Ori.Cohen Expose mobility filtering query params. Allows users to filter out static mobility for example from scene queries. #JIRA UE-29937 Change 3045529 on 2016/07/11 by Zak.Middleton #ue4 - Improve comment about FFindFloorResult.bBlockingHit, explaining it is a valid blocking hit that was not in penetration. Other conditions can be determined from the HitResult itself. Change 3045601 on 2016/07/11 by Michael.Noland Paper2D: Expose UPaperTileMap and UPaperTileSet as BlueprintType #jira UE-20962 Change 3046039 on 2016/07/12 by Jurre.deBaare Instanced HLOD materials to reduce permutations + compilation time Change 3046147 on 2016/07/12 by Ori.Cohen PR #1615: Traceworldforposition should trace async scene too #JIRA UE-21728 Change 3046180 on 2016/07/12 by Ori.Cohen Introduce a shape complexity project setting #JIRA UE-31159 Change 3046280 on 2016/07/12 by Ori.Cohen Change physics blend weights to only affect rendering data. For effects that require updating physx we recommend using the new physical animation component. #JIRA UE-31525, UE-19252 Change 3046282 on 2016/07/12 by Benn.Gallagher Fix for crash or notify corruption when reverting the "Event" struct in montage notify editor. - Made default slot 0, as a montage should always have at least one slot - Made it impossible to revert the "Event" struct as it contains stuff that shouldn't be reverted. Can still revert its members though #jira UE-32626 Change 3046284 on 2016/07/12 by Benn.Gallagher Fix for crash or notify corruption when reverting the "Event" struct in montage notify editor. - Made default slot 0, as a montage should always have at least one slot - Made it impossible to revert the "Event" struct as it contains stuff that shouldn't be reverted. Can still revert its members though (2nd CL, missed file) #jira UE-32626 Change 3046416 on 2016/07/12 by Jon.Nabozny PR #2512: Change InstancedStaticMesh allow transform update to teleport (Contributed by joelmcginnis) #jira UE32123 Change 3046428 on 2016/07/12 by Michael.Noland Paper2D: Fixed inconsistent lighting on lit grouped sprites (caused by bad normals on any grouped sprites that were rotated away from (0,0,0)) #jira UE-33055 Change 3046429 on 2016/07/12 by Michael.Noland Paper2D: Fixed inconsistent lighting on lit tilemaps in standalone or cooked builds (caused by trying to use the canonical Paper2D tangent basis before it has been initialized) #jira UE-25994 Change 3046475 on 2016/07/12 by Ori.Cohen Added strength multiplyer for physical animation #JIRA UE-33075 Change 3046518 on 2016/07/12 by Ori.Cohen Make sure to refresh contact points when turning simulation on for bodies. #JIRA UE-31286 Change 3046658 on 2016/07/12 by Ori.Cohen Fix the case where setting body blend weight doesn't turn off blend override. Change 3046720 on 2016/07/12 by Ori.Cohen Added option to allow skeletal mesh simulation to NOT affect component transform. #JIRA UE-33089 Change 3046908 on 2016/07/12 by Ori.Cohen Fix welded body not properly unwelding when in a chain of welded bodies #JIRA UE-32531 Change 3047015 on 2016/07/12 by Lukasz.Furman fixed nested repath requests Change 3047102 on 2016/07/12 by Ori.Cohen Added physics component to content example Change 3047848 on 2016/07/13 by Ori.Cohen Expose transform update mode to phat #JIRA UE-33227 Change 3047853 on 2016/07/13 by Ori.Cohen Update physical animation level and content. Was missing some blueprints Change 3047897 on 2016/07/13 by Ori.Cohen PR #2066: PhysX: Remove copy-paste code from LoadPhysXModules (Contributed by bozaro) #JIRA UE-27102 Change 3048026 on 2016/07/13 by Benn.Gallagher Altered reference gathering for retargetting to consider nodes in the Ubergraph. This catches refrerences as variables in the event graph and default values on event graph pins. #jira UE-23823 Change 3048592 on 2016/07/13 by Marc.Audy Change check when physics state exists but not registered to ensure and add additional logging information. #jira UE-32935 Change 3048790 on 2016/07/13 by Ori.Cohen Fix CIS for shipping physx builds. #JIRA UE-33246 Change 3048801 on 2016/07/13 by Ori.Cohen Update RootBodyTransform when ref skeleton has offset Change 3048891 on 2016/07/13 by Marc.Audy Fix copy paste bug with AudioComponent::SetPitchMultiplier Change 3049549 on 2016/07/14 by Thomas.Sarkanen Prevented stale anim asset references from persisting in wired pins Made sure to clear out the old asset in asset players when pins are made/destroyed. This requires a temporary string reference to the asset in UAnimGraphNode_AssetPlayerBase. Fixed up anim getters to properly use pin-default assets (previously they used the internal asset ptr that was not guaranteed to be in sync). Also fixe dup error messaging to be a bit more helpful when editing transition rules. Fixed up the various animation asset players to correctly display names when the asset is not set internally. Also correctly report compilation errors when pins are connected. Moved FA3NodeOptionalPinManager to new file ane renamed to FAnimBlueprintNodeOptionalPinManager to avoid circular includes. #jira UE-31015 - Asset Pins Keep Reference To Old 'Static' Asset Change 3049576 on 2016/07/14 by Thomas.Sarkanen Fix CIS linker errors Change 3049611 on 2016/07/14 by Benn.Gallagher Fixed "Isolate" checkbox in Persona mesh details not working on sections with clothing assigned (previously disabled drawing for all sections) Fixed "Highlight" checkbox in Persona mesh details not working after Section/Chunk refactor #jira UE-31016 #jira UE-33061 Change 3049663 on 2016/07/14 by Benn.Gallagher CIS fix after Persona render fixes Change 3049794 on 2016/07/14 by Marc.Audy Some cleanup and ensuring ActiveSound adds references to all of its used assets Change 3049823 on 2016/07/14 by Tom.Looman Added Player Connect and Disconnect Multicast Events to GameMode PR #2398: Player Connect and Disconnect Multicast Events (for Plugins) (Contributed by dreckard) Change 3049896 on 2016/07/14 by Ori.Cohen Fix cases where updating welded bodies is causing physx body to ignore the kinematic flag. #JIRA UE-31660 Change 3049921 on 2016/07/14 by Benn.Gallagher PR #2294: Reduce PhysX simulate() memory churn (Contributed by roberttroughton) - Modifications: Per PxScene buffers, 16 byte alignment required for simulate call, skip clothing scenes (unused, we simulate per-actor) #jira UE-29573 Change 3049929 on 2016/07/14 by Zak.Middleton #ue4 - Make GetDefault<T>(UClass*) assert that the class is castable to T. Change 3049956 on 2016/07/14 by Zak.Middleton #ue4 - Back out changelist 3049929 until I fix CastChecked<> compile issue. Change 3049992 on 2016/07/14 by Jon.Nabozny Fix infite jumps when JumpMaxHoldTime is set. Also, allow multi-jumping out of the box. #JIRA: UE-31601 Change 3050017 on 2016/07/14 by James.Golding PR #2412: Make CalcSceneView and GetProjectionData in ULocalPlayer virtual (Contributed by yehaike) Change 3050061 on 2016/07/14 by Zak.Middleton #ue4 - Make GetDefault<T>(UClass*) assert that the class is castable to T. Change 3050254 on 2016/07/14 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614 Change 3050416 on 2016/07/14 by mason.seay Test map and asset for slicing proc meshes Change 3050881 on 2016/07/14 by Zak.Middleton #ue4 - Make FSavedMove_Character::CanCombineWith easier to debug. Consolidate duplicate code to one block. github #2047 Change 3051401 on 2016/07/15 by Thomas.Sarkanen Prevented animation from restarting each time a new section is selected/inspected in the montage editor Preserved playback state when changing section. Added SetWeight function to montage instance as when switching between sections the montage would blend from ref-pose while paused. #jira UE-31014 - Moving Montage Event Unpauses Playback #jira UE-25101 - Improve Montage Replay Usability issue Change 3051717 on 2016/07/15 by Benn.Gallagher Removed call to set sleepVelocityFrameDecayConstant on destructible shapes after advice from Nvidia and investigation by some licensees. Feature was used in the past to better settle piles but now PhysX can handle it fine and by setting it we were causing a hit in island generation. #jira UE-18558 Change 3051729 on 2016/07/15 by Benn.Gallagher Changed enum combo boxes so that they use rich tooltips instead of text tooltips. - They look the same when there isn't a documentation entry for them (Just the enum name) - Enum docs stored in /Shared/Enums/{EnumType} and the excerpt names are just the enum name Change 3051825 on 2016/07/15 by Marc.Audy Display HiddenInGame for SceneComponents except when part of flattened properties in an Actor such as StaticMeshActor #jira UE-29435 Change 3051850 on 2016/07/15 by Marc.Audy Reduce priority of audio thread Add a frame sync to avoid audio thread drifiting behind Change 3051920 on 2016/07/15 by Tom.Looman Added ActorComponent Activate/Deactivate events #JIRA UE-31077 Change 3051923 on 2016/07/15 by Tom.Looman PR #2370: Exposing "OverrideWith" and "CopyProperties" in PlayerState to Blueprint Children (Contributed by eXifreXi) Change 3052038 on 2016/07/15 by Martin.Wilson Possible fix for fortnite crash + ensure incase the situation occurs again #jira UE-33258 Change 3052042 on 2016/07/15 by Jurre.deBaare Copying //Tasks/Framework/DEV-UEFW-21-AlembicImporter to Dev-Framework (//UE4/Dev-Framework) Change 3052171 on 2016/07/15 by Ori.Cohen Improve UI for constraint profiles. Polish UI for physical animation profile. #JIRA UEFW-101, UE-33290 Change 3052243 on 2016/07/15 by Martin.Wilson Pose watching: Ability to draw bones of pose at any point in the anim graph. #jira UE-12181 (originally Epic Friday project) Change 3053202 on 2016/07/18 by Thomas.Sarkanen FAnimInstanceProxy::EvaulateAnimation is now split into two for easier extensibility #jira UE-30107 - Split out part of FAnimInstanceProxy::EvaulateAnimation to allow users to use node evaluate without code duplication Change 3053203 on 2016/07/18 by Thomas.Sarkanen Fixed properties that are fed to skeletal mesh components via construction script not updating when edited Forced skeletal mesh components to re-init their anim instance on reregister when in an editor world (a previous optimization was preventing this). Switched order of RerunConstructionScripts and ReregisterAllComponentsto be in-line with the undo/redo case to prevent edits being a frame out of date. #jira UE-31890 - Variables cast from the Construction Script do not update in AnimBP AnimGraph Change 3053241 on 2016/07/18 by Martin.Wilson Add parent bone space to GetSocketTransform #jira UE-29814 Change 3053270 on 2016/07/18 by Jurre.deBaare PR #2105: Disable creation of array modifiers (Contributed by projectgheist) Change 3053273 on 2016/07/18 by Jurre.deBaare Default ini for asset viewer and HDR images #jira UE-32903 Change 3053527 on 2016/07/18 by Ori.Cohen Fix CIS #JIRA UE-33375 Change 3053620 on 2016/07/18 by Thomas.Sarkanen Socket chooser now has a search box Uses new FTextFilterExpressionEvaluator to filter bones & sockets by name. Search box has focus when the menu appears. #jira UE-23698 - Need a way to search through the Choose Socket or Bone: UI when attaching to a skeletal mesh Change 3053626 on 2016/07/18 by Martin.Wilson Fix crash caused by skeletalmeshcomponent being destroyed during a notify #jira UE-33258 Change 3053761 on 2016/07/18 by Martin.Wilson Mac build compile fix Change 3053858 on 2016/07/18 by Lina.Halper Merging using //UE4/Dev-Framework/_to_//Fortnite/Main/ Fix on crashing recursive asset Change 3053864 on 2016/07/18 by Ori.Cohen Make sure phat UI changes when picking different constraint profiles Change 3053866 on 2016/07/18 by Ori.Cohen Submit content example for constraint profiles Change 3053915 on 2016/07/18 by Lina.Halper The cached animinstance won't refresh until animation is replaced if you open while anim bp is opened This is the fix for that. #jira: UE-32927 Change 3053969 on 2016/07/18 by James.Golding PR #2571: Added a SimEventCallbackFactory (Contributed by NaturalMotionTechnology) Change 3054004 on 2016/07/18 by Ori.Cohen Fix crash in welding when children have no owner component and ensure query only does not get welded by mistake. #jira UE-33333 Change 3054410 on 2016/07/18 by Lina.Halper Fixed issue with moving translation not working with mirrored parent due to inverse position. Changed to Transform. #jira: UE-31521 Change 3054659 on 2016/07/18 by Lina.Halper Fix for retargeting of pose asset - Moved animsequence::retarget to be out to AnimationRuntime - PoseAsset is now using that function to retarget correctly #code review: Martin.Wilson, Ori.Cohen Change 3054777 on 2016/07/18 by Jurre.deBaare Fixing integration blocker, had this fix locally already #jira UE-33427 Change 3056619 on 2016/07/19 by Ori.Cohen Temporarily turn off audio threading due to heap corruption. #JIRA UE-33320 Change 3057770 on 2016/07/20 by Aaron.McLeran Doing sync trace for occlusion if audio thread is enabled #jira UE-33494 Change 3057778 on 2016/07/20 by Aaron.McLeran #jira UE-33494 Fix async line traces from audio thread causing crash (re-enable threaded audio) Change 3057788 on 2016/07/20 by Aaron.McLeran #jira UE-33494 Fix async line traces from audio thread causing crash (re-enable threaded audio) Enabling audio thread (with a capital T for True) Change 3057850 on 2016/07/20 by Ori.Cohen Temporarily turn off audio threading as the feature is still experimental Change 3057876 on 2016/07/20 by Martin.Wilson Fix Graph Linked External Object issue when saving recompressed animations #jira UE-33567 Change 3058371 on 2016/07/20 by Ori.Cohen Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) [CL 3058682 by Ori Cohen in Main branch]
2016-07-20 18:23:54 -04:00
Decorator->InitializeFromAsset(TreeAsset);
Decorator->InitializeParentLink(ChildIndex);
ExecutionIndex++;
}
const int32 NumInjectedDecorators = ChildInfo.Decorators.Num() - NumOrgDecorators;
MergeDecoratorOpsHelper(ChildInfo.DecoratorOps, SubtreeAsset.RootDecoratorOps, NumOrgDecorators, NumInjectedDecorators);
}
UBTNode* ChildNode = NULL;
if (ChildInfo.ChildComposite)
{
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720537 on 2015/10/07 by Aaron.McLeran Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick Change 2746582 on 2015/10/29 by Aaron.McLeran Implementing single ray-cast sound occlusion - Fixing/Implementing sound occlusion using one ray cast - Update rate of the ray cast is conifgurable by the user - User can enabled/disable occlusion and set various properties of the occlusion at the audio component level - Occlusion ray-casts are made at a slower rate than the audio engine is updated - The following properties are supported: * LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded) * OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded) * OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions) - Fixed how low-pass filter frequency is applied on platforms that support it. * Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter * Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering) * Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params. * At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used * Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied. * XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing. #rb zak.middleton Change 2765174 on 2015/11/12 by Aaron.McLeran UE-23091 More fixage for NaN audio log spam Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense. To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h. - Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread. - Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe. - I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate #codereview Zak.Middleton #rb Zak.Middleton Change 2765467 on 2015/11/13 by James.Golding - Allow -ms option to work with 'stat dumphitches' for controlling min time logged #rb gil.gribb Change 2765746 on 2015/11/13 by Benn.Gallagher Added buckets for update rate shift tags (for staggering anim updates) #jira UE-23213 #rb Bruce.Nesbit Change 2765747 on 2015/11/13 by Benn.Gallagher Fixes for bone length calculation in anim dynamics chains. #rb Bruce.Nesbit Change 2765749 on 2015/11/13 by Benn.Gallagher Removed allocations from local CS blends for skeletal controls. #rb Bruce.Nesbit Change 2765752 on 2015/11/13 by Benn.Gallagher Lod mapping support for URO customization #jira UE-23211 #rb Bruce.Nesbit Change 2765965 on 2015/11/13 by Marc.Audy Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE #jira UE-21181 #rb Josh.Markiewicz Change 2766071 on 2015/11/13 by Mieszko.Zielinski Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4 the 'bTickDuringGame == bTickDuringGame' thing #rb John.Abercrombie Change 2766086 on 2015/11/13 by Mieszko.Zielinski Exposing NavModifierComponent to ENGINE_API #UE4 #codereview Lukasz.Furman Change 2766345 on 2015/11/13 by Mieszko.Zielinski No longer compiling AISystem's creation out from client builds #UE4 Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable Change 2766346 on 2015/11/13 by Mieszko.Zielinski Improvements to EQS test scoring function preview #UE4 #rb Lukasz.Furman Change 2766528 on 2015/11/13 by Stan.Melax multiple materials/chunks on a single cloth sim mesh This supposedly used to work in 4.7 but broke for 4.8 It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts. Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration. jira: #UE-23300 https://jira.ol.epicgames.net/browse/UE-23300 https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674 #rb Benn.Gallagher Change 2766546 on 2015/11/13 by Marc.Audy Throw warning for orphaned looping sounds caused by a looping sound node Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping #rb Aaron.McLeran Change 2766917 on 2015/11/14 by Jurre.deBaare Fix UE4-23349 Simplygon doens't support sub 64 pixel textures Change 2767742 on 2015/11/16 by Marc.Audy Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton. Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls #rb Zak.Middleton, Rob.Manuszewski Change 2767827 on 2015/11/16 by Zak.Middleton #ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached. - New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received. - Also fixes trying to smooth rotation towards identity rotation before receiving network updates. - Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now). #rb Dan.Youhon Change 2768070 on 2015/11/16 by Marc.Audy Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues) Fixup usages to avoid unnecessary string -> char* -> name conversions Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version #rb Gil.Gribb Change 2768121 on 2015/11/16 by Marc.Audy Forceinline GetFName Change 2768161 on 2015/11/16 by Aaron.McLeran Checking occlusion back in - Bug was due to improper interpolation of LPFFrequency values in audio volumes. Change 2769428 on 2015/11/17 by Thomas.Sarkanen Fixed backwards-compatibility issues with FExposedValueCopyRecord Added PostSerialize function to patch up older data to the new format (copies properties->property FNames). Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation. UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter()) #rb James.Golding #codereview Mike.Beach,Bob.Tellez Change 2769488 on 2015/11/17 by Benn.Gallagher DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona #rb Martin.Wilson Change 2769545 on 2015/11/17 by Benn.Gallagher Added space conversion options to copy bone node. #jira OR-9430 #rb Martin.Wilson Change 2770228 on 2015/11/17 by Marc.Audy Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false #rb Ori.Cohen #jira UE-23366 Change 2770489 on 2015/11/17 by Marc.Audy Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise Change 2770761 on 2015/11/17 by Aaron.McLeran Removing optimization disablement - Forgot to remove these lines before checking in/testing. Change 2771375 on 2015/11/18 by Thomas.Sarkanen Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines #rb Benn.Gallagher Change 2771697 on 2015/11/18 by Jeff.Farris Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake #rb marc.audy Change 2771755 on 2015/11/18 by Marc.Audy Put back in the recursion block for destroy actor #rb James.Golding Change 2772217 on 2015/11/18 by Marc.Audy Update axis inversion to work the same way as sensitivity instead of old problematic way Also change to use Reset instead of Empty(Array.Num()) #rb Jeff.Farris Change 2772686 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization coordinate bug. Don't need to convert to xaudio2 coordinates for HRTF spatialization #rb chad.taylor Change 2772766 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization with xaudio2 voice pools - Issue was caused by 2 issues: - effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices) - Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool. #rb chad.taylor Change 2773027 on 2015/11/19 by Thomas.Sarkanen PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts) #rb Thomas.Sarkanen Change 2773142 on 2015/11/19 by Benn.Gallagher Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose. - Only iterating beyond the index of the first bone transform, cutting off all bones before - No longer using a bone mask the size of the skeleton, just an array of interesting nodes - No longer attempting to convert a transform if it isn't necessary (which was happening a lot) #rb Laurent.Delayen Change 2773212 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Removing ugly comment. Not going to remove the node itself for backward compatibility. Change 2773351 on 2015/11/19 by Zak.Middleton #orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates. #rb Dan.Youhon Change 2773599 on 2015/11/19 by Marc.Audy Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang #codereview Aaron.McLeran Change 2773661 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Following up by deprecating the CastToPlayerController function for 4.11. Change 2774707 on 2015/11/19 by Stan.Melax FCollisionQueryParams constructor API pitfall Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName. So this line of code: FCollisionQueryParams Param(FName(TEXT("DragDropTrace"))); will invoke: FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...) But this line of code: FCollisionQueryParams Param(TEXT("DragDropTrace")); invokes: FCollisionQueryParams::FCollisionQueryParams(bool) Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended. It looks like this interface was introduced in CL 1792949 back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach. Making an API change would break things for existing projects. If it had been a more recent change we could have probably just gone down to a single constructor right away. Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters. see also https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html #codereview ori.cohen [CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
ChildInfo.ChildComposite = Cast<UBTCompositeNode>(StaticDuplicateObject(ChildInfo.ChildComposite, NodeOuter));
ChildNode = ChildInfo.ChildComposite;
}
else if (ChildInfo.ChildTask)
{
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720537 on 2015/10/07 by Aaron.McLeran Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick Change 2746582 on 2015/10/29 by Aaron.McLeran Implementing single ray-cast sound occlusion - Fixing/Implementing sound occlusion using one ray cast - Update rate of the ray cast is conifgurable by the user - User can enabled/disable occlusion and set various properties of the occlusion at the audio component level - Occlusion ray-casts are made at a slower rate than the audio engine is updated - The following properties are supported: * LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded) * OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded) * OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions) - Fixed how low-pass filter frequency is applied on platforms that support it. * Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter * Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering) * Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params. * At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used * Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied. * XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing. #rb zak.middleton Change 2765174 on 2015/11/12 by Aaron.McLeran UE-23091 More fixage for NaN audio log spam Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense. To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h. - Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread. - Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe. - I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate #codereview Zak.Middleton #rb Zak.Middleton Change 2765467 on 2015/11/13 by James.Golding - Allow -ms option to work with 'stat dumphitches' for controlling min time logged #rb gil.gribb Change 2765746 on 2015/11/13 by Benn.Gallagher Added buckets for update rate shift tags (for staggering anim updates) #jira UE-23213 #rb Bruce.Nesbit Change 2765747 on 2015/11/13 by Benn.Gallagher Fixes for bone length calculation in anim dynamics chains. #rb Bruce.Nesbit Change 2765749 on 2015/11/13 by Benn.Gallagher Removed allocations from local CS blends for skeletal controls. #rb Bruce.Nesbit Change 2765752 on 2015/11/13 by Benn.Gallagher Lod mapping support for URO customization #jira UE-23211 #rb Bruce.Nesbit Change 2765965 on 2015/11/13 by Marc.Audy Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE #jira UE-21181 #rb Josh.Markiewicz Change 2766071 on 2015/11/13 by Mieszko.Zielinski Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4 the 'bTickDuringGame == bTickDuringGame' thing #rb John.Abercrombie Change 2766086 on 2015/11/13 by Mieszko.Zielinski Exposing NavModifierComponent to ENGINE_API #UE4 #codereview Lukasz.Furman Change 2766345 on 2015/11/13 by Mieszko.Zielinski No longer compiling AISystem's creation out from client builds #UE4 Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable Change 2766346 on 2015/11/13 by Mieszko.Zielinski Improvements to EQS test scoring function preview #UE4 #rb Lukasz.Furman Change 2766528 on 2015/11/13 by Stan.Melax multiple materials/chunks on a single cloth sim mesh This supposedly used to work in 4.7 but broke for 4.8 It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts. Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration. jira: #UE-23300 https://jira.ol.epicgames.net/browse/UE-23300 https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674 #rb Benn.Gallagher Change 2766546 on 2015/11/13 by Marc.Audy Throw warning for orphaned looping sounds caused by a looping sound node Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping #rb Aaron.McLeran Change 2766917 on 2015/11/14 by Jurre.deBaare Fix UE4-23349 Simplygon doens't support sub 64 pixel textures Change 2767742 on 2015/11/16 by Marc.Audy Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton. Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls #rb Zak.Middleton, Rob.Manuszewski Change 2767827 on 2015/11/16 by Zak.Middleton #ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached. - New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received. - Also fixes trying to smooth rotation towards identity rotation before receiving network updates. - Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now). #rb Dan.Youhon Change 2768070 on 2015/11/16 by Marc.Audy Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues) Fixup usages to avoid unnecessary string -> char* -> name conversions Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version #rb Gil.Gribb Change 2768121 on 2015/11/16 by Marc.Audy Forceinline GetFName Change 2768161 on 2015/11/16 by Aaron.McLeran Checking occlusion back in - Bug was due to improper interpolation of LPFFrequency values in audio volumes. Change 2769428 on 2015/11/17 by Thomas.Sarkanen Fixed backwards-compatibility issues with FExposedValueCopyRecord Added PostSerialize function to patch up older data to the new format (copies properties->property FNames). Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation. UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter()) #rb James.Golding #codereview Mike.Beach,Bob.Tellez Change 2769488 on 2015/11/17 by Benn.Gallagher DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona #rb Martin.Wilson Change 2769545 on 2015/11/17 by Benn.Gallagher Added space conversion options to copy bone node. #jira OR-9430 #rb Martin.Wilson Change 2770228 on 2015/11/17 by Marc.Audy Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false #rb Ori.Cohen #jira UE-23366 Change 2770489 on 2015/11/17 by Marc.Audy Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise Change 2770761 on 2015/11/17 by Aaron.McLeran Removing optimization disablement - Forgot to remove these lines before checking in/testing. Change 2771375 on 2015/11/18 by Thomas.Sarkanen Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines #rb Benn.Gallagher Change 2771697 on 2015/11/18 by Jeff.Farris Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake #rb marc.audy Change 2771755 on 2015/11/18 by Marc.Audy Put back in the recursion block for destroy actor #rb James.Golding Change 2772217 on 2015/11/18 by Marc.Audy Update axis inversion to work the same way as sensitivity instead of old problematic way Also change to use Reset instead of Empty(Array.Num()) #rb Jeff.Farris Change 2772686 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization coordinate bug. Don't need to convert to xaudio2 coordinates for HRTF spatialization #rb chad.taylor Change 2772766 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization with xaudio2 voice pools - Issue was caused by 2 issues: - effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices) - Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool. #rb chad.taylor Change 2773027 on 2015/11/19 by Thomas.Sarkanen PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts) #rb Thomas.Sarkanen Change 2773142 on 2015/11/19 by Benn.Gallagher Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose. - Only iterating beyond the index of the first bone transform, cutting off all bones before - No longer using a bone mask the size of the skeleton, just an array of interesting nodes - No longer attempting to convert a transform if it isn't necessary (which was happening a lot) #rb Laurent.Delayen Change 2773212 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Removing ugly comment. Not going to remove the node itself for backward compatibility. Change 2773351 on 2015/11/19 by Zak.Middleton #orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates. #rb Dan.Youhon Change 2773599 on 2015/11/19 by Marc.Audy Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang #codereview Aaron.McLeran Change 2773661 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Following up by deprecating the CastToPlayerController function for 4.11. Change 2774707 on 2015/11/19 by Stan.Melax FCollisionQueryParams constructor API pitfall Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName. So this line of code: FCollisionQueryParams Param(FName(TEXT("DragDropTrace"))); will invoke: FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...) But this line of code: FCollisionQueryParams Param(TEXT("DragDropTrace")); invokes: FCollisionQueryParams::FCollisionQueryParams(bool) Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended. It looks like this interface was introduced in CL 1792949 back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach. Making an API change would break things for existing projects. If it had been a more recent change we could have probably just gone down to a single constructor right away. Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters. see also https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html #codereview ori.cohen [CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
ChildInfo.ChildTask = Cast<UBTTaskNode>(StaticDuplicateObject(ChildInfo.ChildTask, NodeOuter));
ChildNode = ChildInfo.ChildTask;
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
for (int32 ServiceIndex = 0; ServiceIndex < ChildInfo.ChildTask->Services.Num(); ServiceIndex++)
{
if (ChildInfo.ChildTask->Services[ServiceIndex] == NULL)
{
UE_LOG(LogBehaviorTree, Warning, TEXT("%s has missing service node! (parent: %s)"),
*TreeAsset.GetName(), *UBehaviorTreeTypes::DescribeNodeHelper(ChildInfo.ChildTask));
ChildInfo.ChildTask->Services.RemoveAt(ServiceIndex, 1, false);
ServiceIndex--;
continue;
}
UBTService* Service = Cast<UBTService>(StaticDuplicateObject(ChildInfo.ChildTask->Services[ServiceIndex], NodeOuter));
ChildInfo.ChildTask->Services[ServiceIndex] = Service;
InitList.Add(FNodeInitializationData(Service, CompositeOb, ExecutionIndex, TreeDepth,
Service->GetInstanceMemorySize(), Service->GetSpecialMemorySize()));
FScopedBTLoggingContext LogContext(Service);
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
Service->InitializeFromAsset(TreeAsset);
Service->InitializeParentLink(ChildIndex);
ExecutionIndex++;
}
}
if (ChildNode)
{
InitializeNodeHelper(CompositeOb, ChildNode, TreeDepth + 1, ExecutionIndex, InitList, TreeAsset, NodeOuter);
}
}
CompositeOb->InitializeComposite(ExecutionIndex - 1);
}
}
bool UBehaviorTreeManager::LoadTree(UBehaviorTree& Asset, UBTCompositeNode*& Root, uint16& InstanceMemorySize)
{
SCOPE_CYCLE_COUNTER(STAT_AI_BehaviorTree_LoadTime);
for (int32 TemplateIndex = 0; TemplateIndex < LoadedTemplates.Num(); TemplateIndex++)
{
FBehaviorTreeTemplateInfo& TemplateInfo = LoadedTemplates[TemplateIndex];
if (TemplateInfo.Asset == &Asset)
{
Root = TemplateInfo.Template;
InstanceMemorySize = TemplateInfo.InstanceMemorySize;
return true;
}
}
if (Asset.RootNode)
{
FBehaviorTreeTemplateInfo TemplateInfo;
TemplateInfo.Asset = &Asset;
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720537 on 2015/10/07 by Aaron.McLeran Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick Change 2746582 on 2015/10/29 by Aaron.McLeran Implementing single ray-cast sound occlusion - Fixing/Implementing sound occlusion using one ray cast - Update rate of the ray cast is conifgurable by the user - User can enabled/disable occlusion and set various properties of the occlusion at the audio component level - Occlusion ray-casts are made at a slower rate than the audio engine is updated - The following properties are supported: * LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded) * OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded) * OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions) - Fixed how low-pass filter frequency is applied on platforms that support it. * Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter * Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering) * Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params. * At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used * Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied. * XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing. #rb zak.middleton Change 2765174 on 2015/11/12 by Aaron.McLeran UE-23091 More fixage for NaN audio log spam Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense. To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h. - Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread. - Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe. - I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate #codereview Zak.Middleton #rb Zak.Middleton Change 2765467 on 2015/11/13 by James.Golding - Allow -ms option to work with 'stat dumphitches' for controlling min time logged #rb gil.gribb Change 2765746 on 2015/11/13 by Benn.Gallagher Added buckets for update rate shift tags (for staggering anim updates) #jira UE-23213 #rb Bruce.Nesbit Change 2765747 on 2015/11/13 by Benn.Gallagher Fixes for bone length calculation in anim dynamics chains. #rb Bruce.Nesbit Change 2765749 on 2015/11/13 by Benn.Gallagher Removed allocations from local CS blends for skeletal controls. #rb Bruce.Nesbit Change 2765752 on 2015/11/13 by Benn.Gallagher Lod mapping support for URO customization #jira UE-23211 #rb Bruce.Nesbit Change 2765965 on 2015/11/13 by Marc.Audy Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE #jira UE-21181 #rb Josh.Markiewicz Change 2766071 on 2015/11/13 by Mieszko.Zielinski Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4 the 'bTickDuringGame == bTickDuringGame' thing #rb John.Abercrombie Change 2766086 on 2015/11/13 by Mieszko.Zielinski Exposing NavModifierComponent to ENGINE_API #UE4 #codereview Lukasz.Furman Change 2766345 on 2015/11/13 by Mieszko.Zielinski No longer compiling AISystem's creation out from client builds #UE4 Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable Change 2766346 on 2015/11/13 by Mieszko.Zielinski Improvements to EQS test scoring function preview #UE4 #rb Lukasz.Furman Change 2766528 on 2015/11/13 by Stan.Melax multiple materials/chunks on a single cloth sim mesh This supposedly used to work in 4.7 but broke for 4.8 It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts. Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration. jira: #UE-23300 https://jira.ol.epicgames.net/browse/UE-23300 https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674 #rb Benn.Gallagher Change 2766546 on 2015/11/13 by Marc.Audy Throw warning for orphaned looping sounds caused by a looping sound node Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping #rb Aaron.McLeran Change 2766917 on 2015/11/14 by Jurre.deBaare Fix UE4-23349 Simplygon doens't support sub 64 pixel textures Change 2767742 on 2015/11/16 by Marc.Audy Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton. Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls #rb Zak.Middleton, Rob.Manuszewski Change 2767827 on 2015/11/16 by Zak.Middleton #ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached. - New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received. - Also fixes trying to smooth rotation towards identity rotation before receiving network updates. - Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now). #rb Dan.Youhon Change 2768070 on 2015/11/16 by Marc.Audy Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues) Fixup usages to avoid unnecessary string -> char* -> name conversions Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version #rb Gil.Gribb Change 2768121 on 2015/11/16 by Marc.Audy Forceinline GetFName Change 2768161 on 2015/11/16 by Aaron.McLeran Checking occlusion back in - Bug was due to improper interpolation of LPFFrequency values in audio volumes. Change 2769428 on 2015/11/17 by Thomas.Sarkanen Fixed backwards-compatibility issues with FExposedValueCopyRecord Added PostSerialize function to patch up older data to the new format (copies properties->property FNames). Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation. UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter()) #rb James.Golding #codereview Mike.Beach,Bob.Tellez Change 2769488 on 2015/11/17 by Benn.Gallagher DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona #rb Martin.Wilson Change 2769545 on 2015/11/17 by Benn.Gallagher Added space conversion options to copy bone node. #jira OR-9430 #rb Martin.Wilson Change 2770228 on 2015/11/17 by Marc.Audy Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false #rb Ori.Cohen #jira UE-23366 Change 2770489 on 2015/11/17 by Marc.Audy Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise Change 2770761 on 2015/11/17 by Aaron.McLeran Removing optimization disablement - Forgot to remove these lines before checking in/testing. Change 2771375 on 2015/11/18 by Thomas.Sarkanen Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines #rb Benn.Gallagher Change 2771697 on 2015/11/18 by Jeff.Farris Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake #rb marc.audy Change 2771755 on 2015/11/18 by Marc.Audy Put back in the recursion block for destroy actor #rb James.Golding Change 2772217 on 2015/11/18 by Marc.Audy Update axis inversion to work the same way as sensitivity instead of old problematic way Also change to use Reset instead of Empty(Array.Num()) #rb Jeff.Farris Change 2772686 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization coordinate bug. Don't need to convert to xaudio2 coordinates for HRTF spatialization #rb chad.taylor Change 2772766 on 2015/11/18 by Aaron.McLeran Fixing HRTF spatialization with xaudio2 voice pools - Issue was caused by 2 issues: - effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices) - Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool. #rb chad.taylor Change 2773027 on 2015/11/19 by Thomas.Sarkanen PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts) #rb Thomas.Sarkanen Change 2773142 on 2015/11/19 by Benn.Gallagher Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose. - Only iterating beyond the index of the first bone transform, cutting off all bones before - No longer using a bone mask the size of the skeleton, just an array of interesting nodes - No longer attempting to convert a transform if it isn't necessary (which was happening a lot) #rb Laurent.Delayen Change 2773212 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Removing ugly comment. Not going to remove the node itself for backward compatibility. Change 2773351 on 2015/11/19 by Zak.Middleton #orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates. #rb Dan.Youhon Change 2773599 on 2015/11/19 by Marc.Audy Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang #codereview Aaron.McLeran Change 2773661 on 2015/11/19 by Richard.Hinckley #jira UEDOC-2685 Following up by deprecating the CastToPlayerController function for 4.11. Change 2774707 on 2015/11/19 by Stan.Melax FCollisionQueryParams constructor API pitfall Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName. So this line of code: FCollisionQueryParams Param(FName(TEXT("DragDropTrace"))); will invoke: FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...) But this line of code: FCollisionQueryParams Param(TEXT("DragDropTrace")); invokes: FCollisionQueryParams::FCollisionQueryParams(bool) Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended. It looks like this interface was introduced in CL 1792949 back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach. Making an API change would break things for existing projects. If it had been a more recent change we could have probably just gone down to a single constructor right away. Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters. see also https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html #codereview ori.cohen [CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
TemplateInfo.Template = Cast<UBTCompositeNode>(StaticDuplicateObject(Asset.RootNode, this));
TArray<FNodeInitializationData> InitList;
uint16 ExecutionIndex = 0;
InitializeNodeHelper(NULL, TemplateInfo.Template, 0, ExecutionIndex, InitList, Asset, this);
#if USE_BEHAVIORTREE_DEBUGGER
// fill in information about next nodes in execution index, before sorting memory offsets
for (int32 Index = 0; Index < InitList.Num() - 1; Index++)
{
InitList[Index].Node->InitializeExecutionOrder(InitList[Index + 1].Node);
}
#endif
// sort nodes by memory size, so they can be packed better
// it still won't protect against structures, that are internally misaligned (-> uint8, uint32)
// but since all Engine level nodes are good...
InitList.Sort(FNodeInitializationData::FMemorySort());
uint16 MemoryOffset = 0;
for (int32 Index = 0; Index < InitList.Num(); Index++)
{
InitList[Index].Node->InitializeNode(InitList[Index].ParentNode, InitList[Index].ExecutionIndex, InitList[Index].SpecialDataSize + MemoryOffset, InitList[Index].TreeDepth);
MemoryOffset += InitList[Index].DataSize;
}
TemplateInfo.InstanceMemorySize = MemoryOffset;
INC_DWORD_STAT(STAT_AI_BehaviorTree_NumTemplates);
LoadedTemplates.Add(TemplateInfo);
Root = TemplateInfo.Template;
InstanceMemorySize = TemplateInfo.InstanceMemorySize;
return true;
}
return false;
}
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720406 on 2015/10/07 by Aaron.McLeran Audio optimization Don't search for nearest listener if there's only 1 listener. Change 2720411 on 2015/10/07 by Aaron.McLeran Fixing HRTF spatialization code with recent changes to stereo spatialization. HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates. Change 2723829 on 2015/10/09 by Mieszko.Zielinski Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4 UE-21880 Change 2723873 on 2015/10/09 by Mieszko.Zielinski Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4 UE-21977 Change 2724834 on 2015/10/12 by Ori.Cohen PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk) Change 2724850 on 2015/10/12 by Marc.Audy Fix sound not restarting in matinee preview when jumping back along timeline after reaching end #codereview Nick.Darnell Change 2726499 on 2015/10/13 by Ori.Cohen Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1 Change 2726689 on 2015/10/13 by Marc.Audy Make UPackage::PackageFlags private Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor #codereview Mike.Fricker Change 2726862 on 2015/10/13 by Lukasz.Furman removed unused code from DetourNavMeshQuery #ue4 UE-21988 Change 2726888 on 2015/10/13 by Lukasz.Furman fixed observer abort: both mode in behavior tree's cone check decorator #ue4 UE-19375 Change 2726913 on 2015/10/13 by Lukasz.Furman navmesh raycast will use nearest poly containing ray origin instead of just closest one #ue4 UE-19334 Change 2726920 on 2015/10/13 by Marc.Audy Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName #codereview Dmitriy.Dyomin, Bob.Tellez Change 2726931 on 2015/10/13 by Lukasz.Furman fixed missing Tick event in aborting behavior tree tasks from abandoned subtree #ue4 UE-21777 Change 2728093 on 2015/10/14 by Ori.Cohen Fix edge case of sphyl scale take two. The previous approach did double scaling Change 2728577 on 2015/10/14 by Mieszko.Zielinski Improved navmesh labeling condition #UE4 Change suggested by github user #rb Lukasz.Furman Change 2728587 on 2015/10/14 by Lukasz.Furman fixed crowd simulation for auto possessed pawns placed on level #ue4 #rb Mieszko.Zielinski Change 2728629 on 2015/10/14 by Lukasz.Furman fixed influence of navmesh edges on crowd simulation near end of path #ue4 UE-21380 #rb Mieszko.Zielinski Change 2728678 on 2015/10/14 by Lukasz.Furman added Z check to detour's crowd avoidance segment gathering #ue4 UE-20889 #rb Mieszko.Zielinski Change 2728745 on 2015/10/14 by Lukasz.Furman fixed copy&paste operation in behavior tree's composite decorators subgraphs #ue4 UE-18740 Change 2729276 on 2015/10/14 by Stan.Melax ensure all actors get recreated with new collision shape specification. this wasn't being done for a couple of editing methods. todo: this should be merged into 4.10 #UE-20961 #rb ori.cohen Change 2730709 on 2015/10/15 by Marc.Audy Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions #rb Lina.Halper Change 2733590 on 2015/10/19 by Benn.Gallagher Fixed various crashes when using undo and redo while manipulating state machines UE 22088 Change 2735143 on 2015/10/20 by Lukasz.Furman clearing behavior tree debugger's state when displayed subtree becomes inactive #ue4 #rb Mieszko.Zielinski Change 2735144 on 2015/10/20 by Lukasz.Furman rebuilding behavior tree graph node order when node is being moved #ue4 #rb Mieszko.Zielinski Change 2735403 on 2015/10/20 by sebastian.kowalczyk Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform). Change 2736406 on 2015/10/21 by sebastian.kowalczyk Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon. Change 2736436 on 2015/10/21 by sebastian.kowalczyk Fixed crash in gameplay debugger with player set as debug target. Change 2736437 on 2015/10/21 by sebastian.kowalczyk Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet). Change 2736489 on 2015/10/21 by sebastian.kowalczyk Hide internal and debug hud classes from drop down lists. Change 2736504 on 2015/10/21 by sebastian.kowalczyk Fix for UE-18548 "EnableGDT does not work correctly in PIE". Change 2736529 on 2015/10/21 by sebastian.kowalczyk Fixed UE-18548 "EnableGDT does not work correctly in PIE" Change 2736588 on 2015/10/21 by sebastian.kowalczyk Removed old log visualizer classes. Change 2736700 on 2015/10/21 by sebastian.kowalczyk Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module. Change 2737180 on 2015/10/21 by Zak.Middleton #ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits. #rb Aaron.Mcleran #jira UE-22436 Change 2738084 on 2015/10/22 by sebastian.kowalczyk Better indication of selected pawn for Gameplay Debugger. Change 2738413 on 2015/10/22 by Marc.Audy Disable duplication of worlds/maps via the content browser #jira UE-22200 #rb James.Golding Change 2739743 on 2015/10/23 by bruce.nesbit UE-18707 - Issue with drawing material triangle on canvas #1387 Added DrawTriangleUsingVertexColor Change 2739751 on 2015/10/23 by bruce.nesbit Revised bShowDebugForReticleTarget should not be static #1539 Change 2739788 on 2015/10/23 by bruce.nesbit Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor Fixed compile error Change 2739870 on 2015/10/23 by Marc.Audy Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself. #jira UE-22362 #rb Zak.Middleton Change 2739882 on 2015/10/23 by sebastian.kowalczyk Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue. Change 2740140 on 2015/10/23 by Marc.Audy Ensure that components reregister tick functions after seamless travel #jira UE-20892 #rb Zak.Middleton Change 2740614 on 2015/10/23 by Ori.Cohen Fix linker issues for people wanting to use physics lock lambdas Change 2740674 on 2015/10/23 by Aaron.McLeran Sound Focus Feature Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener - Define the min/max azimuth angle to establish in-focus and non-focus regions - Can scale the priority of a sound based on focus angle - Can attenuate the volume of a sound based on focus angle - Can scale the listener-emitter distance based on focus angle - Distance scale is applied when determining max audible distance for USoundBase - Can opt-out of focus effects for a sound at the USoundBase level #rb Ryan.Vance Change 2741542 on 2015/10/26 by Lukasz.Furman lowered min value clamping in navigation filter properties #ue4 #rb Mieszko.Zielinski Change 2743227 on 2015/10/27 by Marc.Audy Make ASceneCaptureCube subclassable outside of Engine module #jira UE-22609 Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module #jira UE-22610 #rb Jeff.Farris Change 2743255 on 2015/10/27 by Marc.Audy Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor #rb Jeff.Farris Change 2743729 on 2015/10/27 by Ori.Cohen Fix case where we spawn and adjust location which gives us implicit velocity. #codereview Stan.Melax Change 2746135 on 2015/10/29 by sebastian.kowalczyk Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work." Change 2746437 on 2015/10/29 by Lukasz.Furman pass on verifying behavior tree stack before accessing its elements #ue4 #rb Mieszko.Zielinski Change 2748028 on 2015/10/30 by sebastian.kowalczyk Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ. Change 2748184 on 2015/10/30 by Aaron.McLeran UE-22693 Fix for streaming bug - 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio. - Wasn't able to repro the 'cannot read chunk' part of the bug #rb ryan.vance Change 2749255 on 2015/10/31 by sebastian.kowalczyk Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD. Change 2749276 on 2015/10/31 by sebastian.kowalczyk Added switch to toggle highlight of selected actor to GameplayDebugger. Change 2749318 on 2015/10/31 by sebastian.kowalczyk New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project). Change 2749337 on 2015/10/31 by sebastian.kowalczyk Fixed GameplayDebugger compilation in shipping/test builds. Change 2749376 on 2015/10/31 by sebastian.kowalczyk Small clean-up in gameplay debugger class for BT. Change 2749931 on 2015/11/02 by James.Golding Add stats to ProcMeshComp Change 2749932 on 2015/11/02 by James.Golding Remove PhysicsThrusterComponent.h from Engine.h Change 2749960 on 2015/11/02 by James.Golding - Fix PS4 compile errors in ActiveSound.cpp - Constructor order of FActiveSound - Shadowed AudioComponent var in CheckOcclusion #RB thomas.sarkanen #codereview aaron.mcleran Change 2749961 on 2015/11/02 by James.Golding Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp - Shadowed DefaultContext function param, now just Context, which matches declaration #RB thomas.sarkanen #codereview sebastian.kowalczyk Change 2750026 on 2015/11/02 by Thomas.Sarkanen Anim Multithreading: thread-safety refactor Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways: - Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal. - Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access. - Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily). Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc. Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays). Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand. Many changes are due to substituting accessor functions for direct variable access. Removed 'service' tick group as we no longer need to segregate the running of our parallel update. Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this. Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private). #rb Martin.Wilson,Lina.Halper #codereview Michael.Noland Change 2750077 on 2015/11/02 by Marc.Audy Expose UInputComponent::BindAction that supports WithKey delegate signature Change 2751767 on 2015/11/03 by Thomas.Sarkanen Added extra support to Anim Blueprint 'fast-path' Added support for negated bools (value gets negated during copy). Added support for copying from struct members (via break struct) and split struct pins. Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often. #rb Martin.Wilson Change 2752158 on 2015/11/03 by Jeff.Farris Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns. #rb marc.audy Change 2752159 on 2015/11/03 by Jeff.Farris Improvements to camera lens effects to (EmitterCameraLensEffectBase) - can now specify a transform to align the emitter with the camera - exposed several key parameters to Blueprints - ENGINE_API now applies to the entire class #rb marc.audy Change 2753454 on 2015/11/04 by Thomas.Sarkanen Fixup deprecation warnings fallout from multithreaded update changes. Fixed up use of AnimInstance in Vicon plugin. Fixed up use of AnimInstance in slope warping node. Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right'). Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction. #rb Martin.Wilson Change 2754099 on 2015/11/04 by Ori.Cohen Fix for task threads dropping stats (from Gil) #rb Gil.Gribb Change 2754449 on 2015/11/04 by Marc.Audy Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks #jira UE-20853 Reorganize some booleans to get better bit packing #rb Jeff.Farris #codereview Mieszko.Zielinski Change 2754573 on 2015/11/04 by Aaron.McLeran Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f Change 2755345 on 2015/11/05 by Thomas.Sarkanen Added deprecated constructors for various animation contexts Allows existing code to compile if it creates its own contexts from UAnimInstance. #rb James.Golding Change 2755348 on 2015/11/05 by James.Golding Add BP-exposed SetBoundsScale function to PrimitiveComponent #RB thomas.sarkanen Change 2755437 on 2015/11/05 by Marc.Audy Fix compile errors #codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran Change 2755982 on 2015/11/05 by Marc.Audy Move HeaderParse changes for deprecation macro from Core Fix world settings warning Change 2756028 on 2015/11/05 by Marc.Audy Fix shadow variable issue Change 2756090 on 2015/11/05 by Ori.Cohen Improve budget tool so that task threads are computed automatically. #rb Gil.Gribb Change 2756120 on 2015/11/05 by Mieszko.Zielinski Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4 #rb Lukasz.Furman Change 2756243 on 2015/11/05 by Mieszko.Zielinski Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4 The old way was resulting in false positives when for example observer teleported somewhere far #rb Lukasz.Furman #codereview John.Abercrombie Change 2756280 on 2015/11/05 by Mieszko.Zielinski Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4 #rb Lukasz.Furman Change 2756500 on 2015/11/05 by Mieszko.Zielinski Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4 Also, refactored its parameters into references over pointers. #rb Lukasz.Furman Change 2757041 on 2015/11/06 by Thomas.Sarkanen Removed check() in UAnimInstance::GetProxyOnAnyThread() The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway. #rb James.Golding Change 2757207 on 2015/11/06 by Ori.Cohen Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation #rb Lina.Halper Change 2757238 on 2015/11/06 by Marc.Audy Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled. #rb Mike.Fricker Change 2757284 on 2015/11/06 by Stan.Melax tapered capsule drawing cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres. (this was already code reviewed before, but missed the check-in window before streamtime) #rb ori.cohen Change 2757743 on 2015/11/06 by Lukasz.Furman fixed node memory allocations for injected behavior tree decorators #ue4 UE-22783 #rb Mieszko.Zielinski Change 2757772 on 2015/11/06 by Lukasz.Furman added setters for crowd avoidance #ue4 UE-22785 #rb Mieszko.Zielinski Change 2758422 on 2015/11/07 by Lina.Halper Potential fix for invalid root bone index input #jira :/UE-23086 #code review: Ori.Cohen Change 2758429 on 2015/11/07 by Mieszko.Zielinski Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4 #jira UE-23089 Change 2758571 on 2015/11/08 by Mieszko.Zielinski Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4 #jira UE-23080 Change 2758821 on 2015/11/09 by Thomas.Sarkanen Fixed animations no longer playing when using a dedicated server. Uses correct logic to determine whether we are running as a server or not. #rb Martin.Wilson Change 2758920 on 2015/11/09 by Marc.Audy Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize #rb Lina.Halper Change 2758944 on 2015/11/09 by Ori.Cohen Fix crash when stats are only on one thread and budget mode is used Change 2758967 on 2015/11/09 by Benn.Gallagher Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence. #jira UE-22963 Change 2758973 on 2015/11/09 by Benn.Gallagher Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating. #rb Bruce.Nesbit Change 2759219 on 2015/11/09 by Ori.Cohen Character perf test is now looking at stats directly and sending to analytics #RB Ben.Salem Change 2759398 on 2015/11/09 by Lina.Halper Fix issue where placed montages are not playing. - the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage #code review: Thomas.Sarkanen #RB: Marc.Audy Change 2759491 on 2015/11/09 by Lina.Halper #Anim: Fix not getting input correctly for Copy Pose node #RB: Marc.Audy Change 2759602 on 2015/11/09 by Marc.Audy Fix imporperly named struct Change 2759795 on 2015/11/09 by Aaron.McLeran UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing. #rb zak.middleton Change 2760081 on 2015/11/09 by Aaron.McLeran UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio. OmniDirectional Math Explanation: For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0. So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map. If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity). The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF. Note: I do not think we need to square the OmniRadius in: Emitter.InnerRadius = OmniRadius*OmniRadius; But I am keeping it t here because of legacy content which depends on that behavior. #rb zak.middleton hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework Re-instated deleted protected functions in UAnimInstance. Fixed access of UAnimInstance in FAnimNode_StateMachine. #rb Martin.Wilson Change 2760407 on 2015/11/10 by Jurre.deBaare Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals) Change 2760468 on 2015/11/10 by Benn.Gallagher Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits. #rb Graeme.Thornton Change 2760613 on 2015/11/10 by Jeff.Farris Fixed async collision completion delegate potentially firing repeatedly. (UE-23149) #cr marc.audy #codereview lina.halper Change 2760795 on 2015/11/10 by Marc.Audy Don't compile in pointless AddReferencedObjects when with editoronly data not defined Minor coding standard cleanup (NULL and auto) Change 2760848 on 2015/11/10 by Benn.Gallagher Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code. #jira UE-23164 #rb Martin.Wilson Change 2760866 on 2015/11/10 by Marc.Audy Manage transient visualization components for camera component in the same way that sprite component for other actor components are #rb Mike.Beach Change 2760963 on 2015/11/10 by Marc.Audy Since construction script can cause actors to be spawned don't use a ranged for to iterate #jira UE-22639 #rb Jeff.Farris #codereview Dmitriy.Dyomin Change 2762297 on 2015/11/11 by James.Golding UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created) #rb martin.wilson #codereview ori.cohen, lina.halper Change 2763566 on 2015/11/11 by Lina.Halper FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint. #RB: Laurent.Delayen Change 2763926 on 2015/11/12 by Thomas.Sarkanen Fix anim notifies not firing from single anim instances UE-23248 - Anim Notifies are not working for Animation Sequences UE-23249 - Anim Notifies using Sound Cues do not work #rb James.Golding Change 2764039 on 2015/11/12 by Jurre.deBaare Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper Change 2764307 on 2015/11/12 by Jurre.deBaare VS2015 SSF library Change 2764314 on 2015/11/12 by Stan.Melax crashfix was putting bad bodies to sleep at start Fatal error! Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000 UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875] On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies. Added check to ensure physx body exists before trying to force it to sleep. not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road". #codereview ori.cohen Change 2764343 on 2015/11/12 by Jurre.deBaare - Fixed crash when building a LOD with SubActors.Num < 2 - Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build - LODActor tree view item now scrolls into view if selected in the world - Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default - Added 7zip files - Fixed issue with WinINet complaining about http-request without 'http://' prefix - Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions) - Override texture sizes and automatic texture bias - Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data. - Now incorporate static meshes with opague materials into HLOD merging - Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled - Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component) - Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD) - Added ENUM for texture scaling/resizing type that has to be applied while merging the materials - Added detail customization class for FMaterialProxySettings #rb James.Golding [CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
void UBehaviorTreeManager::InitializeMemoryHelper(const TArray<UBTDecorator*>& Nodes, TArray<uint16>& MemoryOffsets, int32& MemorySize, bool bForceInstancing)
{
TArray<FNodeInitializationData> InitList;
for (int32 NodeIndex = 0; NodeIndex < Nodes.Num(); NodeIndex++)
{
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720406 on 2015/10/07 by Aaron.McLeran Audio optimization Don't search for nearest listener if there's only 1 listener. Change 2720411 on 2015/10/07 by Aaron.McLeran Fixing HRTF spatialization code with recent changes to stereo spatialization. HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates. Change 2723829 on 2015/10/09 by Mieszko.Zielinski Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4 UE-21880 Change 2723873 on 2015/10/09 by Mieszko.Zielinski Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4 UE-21977 Change 2724834 on 2015/10/12 by Ori.Cohen PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk) Change 2724850 on 2015/10/12 by Marc.Audy Fix sound not restarting in matinee preview when jumping back along timeline after reaching end #codereview Nick.Darnell Change 2726499 on 2015/10/13 by Ori.Cohen Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1 Change 2726689 on 2015/10/13 by Marc.Audy Make UPackage::PackageFlags private Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor #codereview Mike.Fricker Change 2726862 on 2015/10/13 by Lukasz.Furman removed unused code from DetourNavMeshQuery #ue4 UE-21988 Change 2726888 on 2015/10/13 by Lukasz.Furman fixed observer abort: both mode in behavior tree's cone check decorator #ue4 UE-19375 Change 2726913 on 2015/10/13 by Lukasz.Furman navmesh raycast will use nearest poly containing ray origin instead of just closest one #ue4 UE-19334 Change 2726920 on 2015/10/13 by Marc.Audy Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName #codereview Dmitriy.Dyomin, Bob.Tellez Change 2726931 on 2015/10/13 by Lukasz.Furman fixed missing Tick event in aborting behavior tree tasks from abandoned subtree #ue4 UE-21777 Change 2728093 on 2015/10/14 by Ori.Cohen Fix edge case of sphyl scale take two. The previous approach did double scaling Change 2728577 on 2015/10/14 by Mieszko.Zielinski Improved navmesh labeling condition #UE4 Change suggested by github user #rb Lukasz.Furman Change 2728587 on 2015/10/14 by Lukasz.Furman fixed crowd simulation for auto possessed pawns placed on level #ue4 #rb Mieszko.Zielinski Change 2728629 on 2015/10/14 by Lukasz.Furman fixed influence of navmesh edges on crowd simulation near end of path #ue4 UE-21380 #rb Mieszko.Zielinski Change 2728678 on 2015/10/14 by Lukasz.Furman added Z check to detour's crowd avoidance segment gathering #ue4 UE-20889 #rb Mieszko.Zielinski Change 2728745 on 2015/10/14 by Lukasz.Furman fixed copy&paste operation in behavior tree's composite decorators subgraphs #ue4 UE-18740 Change 2729276 on 2015/10/14 by Stan.Melax ensure all actors get recreated with new collision shape specification. this wasn't being done for a couple of editing methods. todo: this should be merged into 4.10 #UE-20961 #rb ori.cohen Change 2730709 on 2015/10/15 by Marc.Audy Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions #rb Lina.Halper Change 2733590 on 2015/10/19 by Benn.Gallagher Fixed various crashes when using undo and redo while manipulating state machines UE 22088 Change 2735143 on 2015/10/20 by Lukasz.Furman clearing behavior tree debugger's state when displayed subtree becomes inactive #ue4 #rb Mieszko.Zielinski Change 2735144 on 2015/10/20 by Lukasz.Furman rebuilding behavior tree graph node order when node is being moved #ue4 #rb Mieszko.Zielinski Change 2735403 on 2015/10/20 by sebastian.kowalczyk Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform). Change 2736406 on 2015/10/21 by sebastian.kowalczyk Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon. Change 2736436 on 2015/10/21 by sebastian.kowalczyk Fixed crash in gameplay debugger with player set as debug target. Change 2736437 on 2015/10/21 by sebastian.kowalczyk Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet). Change 2736489 on 2015/10/21 by sebastian.kowalczyk Hide internal and debug hud classes from drop down lists. Change 2736504 on 2015/10/21 by sebastian.kowalczyk Fix for UE-18548 "EnableGDT does not work correctly in PIE". Change 2736529 on 2015/10/21 by sebastian.kowalczyk Fixed UE-18548 "EnableGDT does not work correctly in PIE" Change 2736588 on 2015/10/21 by sebastian.kowalczyk Removed old log visualizer classes. Change 2736700 on 2015/10/21 by sebastian.kowalczyk Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module. Change 2737180 on 2015/10/21 by Zak.Middleton #ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits. #rb Aaron.Mcleran #jira UE-22436 Change 2738084 on 2015/10/22 by sebastian.kowalczyk Better indication of selected pawn for Gameplay Debugger. Change 2738413 on 2015/10/22 by Marc.Audy Disable duplication of worlds/maps via the content browser #jira UE-22200 #rb James.Golding Change 2739743 on 2015/10/23 by bruce.nesbit UE-18707 - Issue with drawing material triangle on canvas #1387 Added DrawTriangleUsingVertexColor Change 2739751 on 2015/10/23 by bruce.nesbit Revised bShowDebugForReticleTarget should not be static #1539 Change 2739788 on 2015/10/23 by bruce.nesbit Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor Fixed compile error Change 2739870 on 2015/10/23 by Marc.Audy Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself. #jira UE-22362 #rb Zak.Middleton Change 2739882 on 2015/10/23 by sebastian.kowalczyk Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue. Change 2740140 on 2015/10/23 by Marc.Audy Ensure that components reregister tick functions after seamless travel #jira UE-20892 #rb Zak.Middleton Change 2740614 on 2015/10/23 by Ori.Cohen Fix linker issues for people wanting to use physics lock lambdas Change 2740674 on 2015/10/23 by Aaron.McLeran Sound Focus Feature Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener - Define the min/max azimuth angle to establish in-focus and non-focus regions - Can scale the priority of a sound based on focus angle - Can attenuate the volume of a sound based on focus angle - Can scale the listener-emitter distance based on focus angle - Distance scale is applied when determining max audible distance for USoundBase - Can opt-out of focus effects for a sound at the USoundBase level #rb Ryan.Vance Change 2741542 on 2015/10/26 by Lukasz.Furman lowered min value clamping in navigation filter properties #ue4 #rb Mieszko.Zielinski Change 2743227 on 2015/10/27 by Marc.Audy Make ASceneCaptureCube subclassable outside of Engine module #jira UE-22609 Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module #jira UE-22610 #rb Jeff.Farris Change 2743255 on 2015/10/27 by Marc.Audy Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor #rb Jeff.Farris Change 2743729 on 2015/10/27 by Ori.Cohen Fix case where we spawn and adjust location which gives us implicit velocity. #codereview Stan.Melax Change 2746135 on 2015/10/29 by sebastian.kowalczyk Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work." Change 2746437 on 2015/10/29 by Lukasz.Furman pass on verifying behavior tree stack before accessing its elements #ue4 #rb Mieszko.Zielinski Change 2748028 on 2015/10/30 by sebastian.kowalczyk Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ. Change 2748184 on 2015/10/30 by Aaron.McLeran UE-22693 Fix for streaming bug - 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio. - Wasn't able to repro the 'cannot read chunk' part of the bug #rb ryan.vance Change 2749255 on 2015/10/31 by sebastian.kowalczyk Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD. Change 2749276 on 2015/10/31 by sebastian.kowalczyk Added switch to toggle highlight of selected actor to GameplayDebugger. Change 2749318 on 2015/10/31 by sebastian.kowalczyk New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project). Change 2749337 on 2015/10/31 by sebastian.kowalczyk Fixed GameplayDebugger compilation in shipping/test builds. Change 2749376 on 2015/10/31 by sebastian.kowalczyk Small clean-up in gameplay debugger class for BT. Change 2749931 on 2015/11/02 by James.Golding Add stats to ProcMeshComp Change 2749932 on 2015/11/02 by James.Golding Remove PhysicsThrusterComponent.h from Engine.h Change 2749960 on 2015/11/02 by James.Golding - Fix PS4 compile errors in ActiveSound.cpp - Constructor order of FActiveSound - Shadowed AudioComponent var in CheckOcclusion #RB thomas.sarkanen #codereview aaron.mcleran Change 2749961 on 2015/11/02 by James.Golding Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp - Shadowed DefaultContext function param, now just Context, which matches declaration #RB thomas.sarkanen #codereview sebastian.kowalczyk Change 2750026 on 2015/11/02 by Thomas.Sarkanen Anim Multithreading: thread-safety refactor Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways: - Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal. - Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access. - Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily). Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc. Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays). Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand. Many changes are due to substituting accessor functions for direct variable access. Removed 'service' tick group as we no longer need to segregate the running of our parallel update. Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this. Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private). #rb Martin.Wilson,Lina.Halper #codereview Michael.Noland Change 2750077 on 2015/11/02 by Marc.Audy Expose UInputComponent::BindAction that supports WithKey delegate signature Change 2751767 on 2015/11/03 by Thomas.Sarkanen Added extra support to Anim Blueprint 'fast-path' Added support for negated bools (value gets negated during copy). Added support for copying from struct members (via break struct) and split struct pins. Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often. #rb Martin.Wilson Change 2752158 on 2015/11/03 by Jeff.Farris Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns. #rb marc.audy Change 2752159 on 2015/11/03 by Jeff.Farris Improvements to camera lens effects to (EmitterCameraLensEffectBase) - can now specify a transform to align the emitter with the camera - exposed several key parameters to Blueprints - ENGINE_API now applies to the entire class #rb marc.audy Change 2753454 on 2015/11/04 by Thomas.Sarkanen Fixup deprecation warnings fallout from multithreaded update changes. Fixed up use of AnimInstance in Vicon plugin. Fixed up use of AnimInstance in slope warping node. Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right'). Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction. #rb Martin.Wilson Change 2754099 on 2015/11/04 by Ori.Cohen Fix for task threads dropping stats (from Gil) #rb Gil.Gribb Change 2754449 on 2015/11/04 by Marc.Audy Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks #jira UE-20853 Reorganize some booleans to get better bit packing #rb Jeff.Farris #codereview Mieszko.Zielinski Change 2754573 on 2015/11/04 by Aaron.McLeran Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f Change 2755345 on 2015/11/05 by Thomas.Sarkanen Added deprecated constructors for various animation contexts Allows existing code to compile if it creates its own contexts from UAnimInstance. #rb James.Golding Change 2755348 on 2015/11/05 by James.Golding Add BP-exposed SetBoundsScale function to PrimitiveComponent #RB thomas.sarkanen Change 2755437 on 2015/11/05 by Marc.Audy Fix compile errors #codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran Change 2755982 on 2015/11/05 by Marc.Audy Move HeaderParse changes for deprecation macro from Core Fix world settings warning Change 2756028 on 2015/11/05 by Marc.Audy Fix shadow variable issue Change 2756090 on 2015/11/05 by Ori.Cohen Improve budget tool so that task threads are computed automatically. #rb Gil.Gribb Change 2756120 on 2015/11/05 by Mieszko.Zielinski Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4 #rb Lukasz.Furman Change 2756243 on 2015/11/05 by Mieszko.Zielinski Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4 The old way was resulting in false positives when for example observer teleported somewhere far #rb Lukasz.Furman #codereview John.Abercrombie Change 2756280 on 2015/11/05 by Mieszko.Zielinski Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4 #rb Lukasz.Furman Change 2756500 on 2015/11/05 by Mieszko.Zielinski Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4 Also, refactored its parameters into references over pointers. #rb Lukasz.Furman Change 2757041 on 2015/11/06 by Thomas.Sarkanen Removed check() in UAnimInstance::GetProxyOnAnyThread() The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway. #rb James.Golding Change 2757207 on 2015/11/06 by Ori.Cohen Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation #rb Lina.Halper Change 2757238 on 2015/11/06 by Marc.Audy Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled. #rb Mike.Fricker Change 2757284 on 2015/11/06 by Stan.Melax tapered capsule drawing cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres. (this was already code reviewed before, but missed the check-in window before streamtime) #rb ori.cohen Change 2757743 on 2015/11/06 by Lukasz.Furman fixed node memory allocations for injected behavior tree decorators #ue4 UE-22783 #rb Mieszko.Zielinski Change 2757772 on 2015/11/06 by Lukasz.Furman added setters for crowd avoidance #ue4 UE-22785 #rb Mieszko.Zielinski Change 2758422 on 2015/11/07 by Lina.Halper Potential fix for invalid root bone index input #jira :/UE-23086 #code review: Ori.Cohen Change 2758429 on 2015/11/07 by Mieszko.Zielinski Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4 #jira UE-23089 Change 2758571 on 2015/11/08 by Mieszko.Zielinski Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4 #jira UE-23080 Change 2758821 on 2015/11/09 by Thomas.Sarkanen Fixed animations no longer playing when using a dedicated server. Uses correct logic to determine whether we are running as a server or not. #rb Martin.Wilson Change 2758920 on 2015/11/09 by Marc.Audy Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize #rb Lina.Halper Change 2758944 on 2015/11/09 by Ori.Cohen Fix crash when stats are only on one thread and budget mode is used Change 2758967 on 2015/11/09 by Benn.Gallagher Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence. #jira UE-22963 Change 2758973 on 2015/11/09 by Benn.Gallagher Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating. #rb Bruce.Nesbit Change 2759219 on 2015/11/09 by Ori.Cohen Character perf test is now looking at stats directly and sending to analytics #RB Ben.Salem Change 2759398 on 2015/11/09 by Lina.Halper Fix issue where placed montages are not playing. - the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage #code review: Thomas.Sarkanen #RB: Marc.Audy Change 2759491 on 2015/11/09 by Lina.Halper #Anim: Fix not getting input correctly for Copy Pose node #RB: Marc.Audy Change 2759602 on 2015/11/09 by Marc.Audy Fix imporperly named struct Change 2759795 on 2015/11/09 by Aaron.McLeran UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing. #rb zak.middleton Change 2760081 on 2015/11/09 by Aaron.McLeran UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio. OmniDirectional Math Explanation: For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0. So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map. If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity). The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF. Note: I do not think we need to square the OmniRadius in: Emitter.InnerRadius = OmniRadius*OmniRadius; But I am keeping it t here because of legacy content which depends on that behavior. #rb zak.middleton hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework Re-instated deleted protected functions in UAnimInstance. Fixed access of UAnimInstance in FAnimNode_StateMachine. #rb Martin.Wilson Change 2760407 on 2015/11/10 by Jurre.deBaare Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals) Change 2760468 on 2015/11/10 by Benn.Gallagher Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits. #rb Graeme.Thornton Change 2760613 on 2015/11/10 by Jeff.Farris Fixed async collision completion delegate potentially firing repeatedly. (UE-23149) #cr marc.audy #codereview lina.halper Change 2760795 on 2015/11/10 by Marc.Audy Don't compile in pointless AddReferencedObjects when with editoronly data not defined Minor coding standard cleanup (NULL and auto) Change 2760848 on 2015/11/10 by Benn.Gallagher Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code. #jira UE-23164 #rb Martin.Wilson Change 2760866 on 2015/11/10 by Marc.Audy Manage transient visualization components for camera component in the same way that sprite component for other actor components are #rb Mike.Beach Change 2760963 on 2015/11/10 by Marc.Audy Since construction script can cause actors to be spawned don't use a ranged for to iterate #jira UE-22639 #rb Jeff.Farris #codereview Dmitriy.Dyomin Change 2762297 on 2015/11/11 by James.Golding UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created) #rb martin.wilson #codereview ori.cohen, lina.halper Change 2763566 on 2015/11/11 by Lina.Halper FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint. #RB: Laurent.Delayen Change 2763926 on 2015/11/12 by Thomas.Sarkanen Fix anim notifies not firing from single anim instances UE-23248 - Anim Notifies are not working for Animation Sequences UE-23249 - Anim Notifies using Sound Cues do not work #rb James.Golding Change 2764039 on 2015/11/12 by Jurre.deBaare Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper Change 2764307 on 2015/11/12 by Jurre.deBaare VS2015 SSF library Change 2764314 on 2015/11/12 by Stan.Melax crashfix was putting bad bodies to sleep at start Fatal error! Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000 UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875] On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies. Added check to ensure physx body exists before trying to force it to sleep. not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road". #codereview ori.cohen Change 2764343 on 2015/11/12 by Jurre.deBaare - Fixed crash when building a LOD with SubActors.Num < 2 - Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build - LODActor tree view item now scrolls into view if selected in the world - Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default - Added 7zip files - Fixed issue with WinINet complaining about http-request without 'http://' prefix - Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions) - Override texture sizes and automatic texture bias - Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data. - Now incorporate static meshes with opague materials into HLOD merging - Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled - Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component) - Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD) - Added ENUM for texture scaling/resizing type that has to be applied while merging the materials - Added detail customization class for FMaterialProxySettings #rb James.Golding [CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
UBTNode* Node = Nodes[NodeIndex];
const bool bUsesInstancing = Node->HasInstance();
if (bForceInstancing)
{
Node->ForceInstancing(true);
}
InitList.Add(FNodeInitializationData(Nodes[NodeIndex], NULL, 0, 0, Nodes[NodeIndex]->GetInstanceMemorySize(), Nodes[NodeIndex]->GetSpecialMemorySize()));
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2720406 on 2015/10/07 by Aaron.McLeran Audio optimization Don't search for nearest listener if there's only 1 listener. Change 2720411 on 2015/10/07 by Aaron.McLeran Fixing HRTF spatialization code with recent changes to stereo spatialization. HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates. Change 2723829 on 2015/10/09 by Mieszko.Zielinski Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4 UE-21880 Change 2723873 on 2015/10/09 by Mieszko.Zielinski Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4 UE-21977 Change 2724834 on 2015/10/12 by Ori.Cohen PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk) Change 2724850 on 2015/10/12 by Marc.Audy Fix sound not restarting in matinee preview when jumping back along timeline after reaching end #codereview Nick.Darnell Change 2726499 on 2015/10/13 by Ori.Cohen Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1 Change 2726689 on 2015/10/13 by Marc.Audy Make UPackage::PackageFlags private Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor #codereview Mike.Fricker Change 2726862 on 2015/10/13 by Lukasz.Furman removed unused code from DetourNavMeshQuery #ue4 UE-21988 Change 2726888 on 2015/10/13 by Lukasz.Furman fixed observer abort: both mode in behavior tree's cone check decorator #ue4 UE-19375 Change 2726913 on 2015/10/13 by Lukasz.Furman navmesh raycast will use nearest poly containing ray origin instead of just closest one #ue4 UE-19334 Change 2726920 on 2015/10/13 by Marc.Audy Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName #codereview Dmitriy.Dyomin, Bob.Tellez Change 2726931 on 2015/10/13 by Lukasz.Furman fixed missing Tick event in aborting behavior tree tasks from abandoned subtree #ue4 UE-21777 Change 2728093 on 2015/10/14 by Ori.Cohen Fix edge case of sphyl scale take two. The previous approach did double scaling Change 2728577 on 2015/10/14 by Mieszko.Zielinski Improved navmesh labeling condition #UE4 Change suggested by github user #rb Lukasz.Furman Change 2728587 on 2015/10/14 by Lukasz.Furman fixed crowd simulation for auto possessed pawns placed on level #ue4 #rb Mieszko.Zielinski Change 2728629 on 2015/10/14 by Lukasz.Furman fixed influence of navmesh edges on crowd simulation near end of path #ue4 UE-21380 #rb Mieszko.Zielinski Change 2728678 on 2015/10/14 by Lukasz.Furman added Z check to detour's crowd avoidance segment gathering #ue4 UE-20889 #rb Mieszko.Zielinski Change 2728745 on 2015/10/14 by Lukasz.Furman fixed copy&paste operation in behavior tree's composite decorators subgraphs #ue4 UE-18740 Change 2729276 on 2015/10/14 by Stan.Melax ensure all actors get recreated with new collision shape specification. this wasn't being done for a couple of editing methods. todo: this should be merged into 4.10 #UE-20961 #rb ori.cohen Change 2730709 on 2015/10/15 by Marc.Audy Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions #rb Lina.Halper Change 2733590 on 2015/10/19 by Benn.Gallagher Fixed various crashes when using undo and redo while manipulating state machines UE 22088 Change 2735143 on 2015/10/20 by Lukasz.Furman clearing behavior tree debugger's state when displayed subtree becomes inactive #ue4 #rb Mieszko.Zielinski Change 2735144 on 2015/10/20 by Lukasz.Furman rebuilding behavior tree graph node order when node is being moved #ue4 #rb Mieszko.Zielinski Change 2735403 on 2015/10/20 by sebastian.kowalczyk Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform). Change 2736406 on 2015/10/21 by sebastian.kowalczyk Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon. Change 2736436 on 2015/10/21 by sebastian.kowalczyk Fixed crash in gameplay debugger with player set as debug target. Change 2736437 on 2015/10/21 by sebastian.kowalczyk Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet). Change 2736489 on 2015/10/21 by sebastian.kowalczyk Hide internal and debug hud classes from drop down lists. Change 2736504 on 2015/10/21 by sebastian.kowalczyk Fix for UE-18548 "EnableGDT does not work correctly in PIE". Change 2736529 on 2015/10/21 by sebastian.kowalczyk Fixed UE-18548 "EnableGDT does not work correctly in PIE" Change 2736588 on 2015/10/21 by sebastian.kowalczyk Removed old log visualizer classes. Change 2736700 on 2015/10/21 by sebastian.kowalczyk Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module. Change 2737180 on 2015/10/21 by Zak.Middleton #ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits. #rb Aaron.Mcleran #jira UE-22436 Change 2738084 on 2015/10/22 by sebastian.kowalczyk Better indication of selected pawn for Gameplay Debugger. Change 2738413 on 2015/10/22 by Marc.Audy Disable duplication of worlds/maps via the content browser #jira UE-22200 #rb James.Golding Change 2739743 on 2015/10/23 by bruce.nesbit UE-18707 - Issue with drawing material triangle on canvas #1387 Added DrawTriangleUsingVertexColor Change 2739751 on 2015/10/23 by bruce.nesbit Revised bShowDebugForReticleTarget should not be static #1539 Change 2739788 on 2015/10/23 by bruce.nesbit Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor Fixed compile error Change 2739870 on 2015/10/23 by Marc.Audy Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself. #jira UE-22362 #rb Zak.Middleton Change 2739882 on 2015/10/23 by sebastian.kowalczyk Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue. Change 2740140 on 2015/10/23 by Marc.Audy Ensure that components reregister tick functions after seamless travel #jira UE-20892 #rb Zak.Middleton Change 2740614 on 2015/10/23 by Ori.Cohen Fix linker issues for people wanting to use physics lock lambdas Change 2740674 on 2015/10/23 by Aaron.McLeran Sound Focus Feature Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener - Define the min/max azimuth angle to establish in-focus and non-focus regions - Can scale the priority of a sound based on focus angle - Can attenuate the volume of a sound based on focus angle - Can scale the listener-emitter distance based on focus angle - Distance scale is applied when determining max audible distance for USoundBase - Can opt-out of focus effects for a sound at the USoundBase level #rb Ryan.Vance Change 2741542 on 2015/10/26 by Lukasz.Furman lowered min value clamping in navigation filter properties #ue4 #rb Mieszko.Zielinski Change 2743227 on 2015/10/27 by Marc.Audy Make ASceneCaptureCube subclassable outside of Engine module #jira UE-22609 Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module #jira UE-22610 #rb Jeff.Farris Change 2743255 on 2015/10/27 by Marc.Audy Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor #rb Jeff.Farris Change 2743729 on 2015/10/27 by Ori.Cohen Fix case where we spawn and adjust location which gives us implicit velocity. #codereview Stan.Melax Change 2746135 on 2015/10/29 by sebastian.kowalczyk Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work." Change 2746437 on 2015/10/29 by Lukasz.Furman pass on verifying behavior tree stack before accessing its elements #ue4 #rb Mieszko.Zielinski Change 2748028 on 2015/10/30 by sebastian.kowalczyk Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ. Change 2748184 on 2015/10/30 by Aaron.McLeran UE-22693 Fix for streaming bug - 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio. - Wasn't able to repro the 'cannot read chunk' part of the bug #rb ryan.vance Change 2749255 on 2015/10/31 by sebastian.kowalczyk Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD. Change 2749276 on 2015/10/31 by sebastian.kowalczyk Added switch to toggle highlight of selected actor to GameplayDebugger. Change 2749318 on 2015/10/31 by sebastian.kowalczyk New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project). Change 2749337 on 2015/10/31 by sebastian.kowalczyk Fixed GameplayDebugger compilation in shipping/test builds. Change 2749376 on 2015/10/31 by sebastian.kowalczyk Small clean-up in gameplay debugger class for BT. Change 2749931 on 2015/11/02 by James.Golding Add stats to ProcMeshComp Change 2749932 on 2015/11/02 by James.Golding Remove PhysicsThrusterComponent.h from Engine.h Change 2749960 on 2015/11/02 by James.Golding - Fix PS4 compile errors in ActiveSound.cpp - Constructor order of FActiveSound - Shadowed AudioComponent var in CheckOcclusion #RB thomas.sarkanen #codereview aaron.mcleran Change 2749961 on 2015/11/02 by James.Golding Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp - Shadowed DefaultContext function param, now just Context, which matches declaration #RB thomas.sarkanen #codereview sebastian.kowalczyk Change 2750026 on 2015/11/02 by Thomas.Sarkanen Anim Multithreading: thread-safety refactor Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways: - Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal. - Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access. - Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily). Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc. Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays). Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand. Many changes are due to substituting accessor functions for direct variable access. Removed 'service' tick group as we no longer need to segregate the running of our parallel update. Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this. Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private). #rb Martin.Wilson,Lina.Halper #codereview Michael.Noland Change 2750077 on 2015/11/02 by Marc.Audy Expose UInputComponent::BindAction that supports WithKey delegate signature Change 2751767 on 2015/11/03 by Thomas.Sarkanen Added extra support to Anim Blueprint 'fast-path' Added support for negated bools (value gets negated during copy). Added support for copying from struct members (via break struct) and split struct pins. Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often. #rb Martin.Wilson Change 2752158 on 2015/11/03 by Jeff.Farris Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns. #rb marc.audy Change 2752159 on 2015/11/03 by Jeff.Farris Improvements to camera lens effects to (EmitterCameraLensEffectBase) - can now specify a transform to align the emitter with the camera - exposed several key parameters to Blueprints - ENGINE_API now applies to the entire class #rb marc.audy Change 2753454 on 2015/11/04 by Thomas.Sarkanen Fixup deprecation warnings fallout from multithreaded update changes. Fixed up use of AnimInstance in Vicon plugin. Fixed up use of AnimInstance in slope warping node. Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right'). Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction. #rb Martin.Wilson Change 2754099 on 2015/11/04 by Ori.Cohen Fix for task threads dropping stats (from Gil) #rb Gil.Gribb Change 2754449 on 2015/11/04 by Marc.Audy Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks #jira UE-20853 Reorganize some booleans to get better bit packing #rb Jeff.Farris #codereview Mieszko.Zielinski Change 2754573 on 2015/11/04 by Aaron.McLeran Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f Change 2755345 on 2015/11/05 by Thomas.Sarkanen Added deprecated constructors for various animation contexts Allows existing code to compile if it creates its own contexts from UAnimInstance. #rb James.Golding Change 2755348 on 2015/11/05 by James.Golding Add BP-exposed SetBoundsScale function to PrimitiveComponent #RB thomas.sarkanen Change 2755437 on 2015/11/05 by Marc.Audy Fix compile errors #codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran Change 2755982 on 2015/11/05 by Marc.Audy Move HeaderParse changes for deprecation macro from Core Fix world settings warning Change 2756028 on 2015/11/05 by Marc.Audy Fix shadow variable issue Change 2756090 on 2015/11/05 by Ori.Cohen Improve budget tool so that task threads are computed automatically. #rb Gil.Gribb Change 2756120 on 2015/11/05 by Mieszko.Zielinski Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4 #rb Lukasz.Furman Change 2756243 on 2015/11/05 by Mieszko.Zielinski Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4 The old way was resulting in false positives when for example observer teleported somewhere far #rb Lukasz.Furman #codereview John.Abercrombie Change 2756280 on 2015/11/05 by Mieszko.Zielinski Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4 #rb Lukasz.Furman Change 2756500 on 2015/11/05 by Mieszko.Zielinski Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4 Also, refactored its parameters into references over pointers. #rb Lukasz.Furman Change 2757041 on 2015/11/06 by Thomas.Sarkanen Removed check() in UAnimInstance::GetProxyOnAnyThread() The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway. #rb James.Golding Change 2757207 on 2015/11/06 by Ori.Cohen Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation #rb Lina.Halper Change 2757238 on 2015/11/06 by Marc.Audy Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled. #rb Mike.Fricker Change 2757284 on 2015/11/06 by Stan.Melax tapered capsule drawing cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres. (this was already code reviewed before, but missed the check-in window before streamtime) #rb ori.cohen Change 2757743 on 2015/11/06 by Lukasz.Furman fixed node memory allocations for injected behavior tree decorators #ue4 UE-22783 #rb Mieszko.Zielinski Change 2757772 on 2015/11/06 by Lukasz.Furman added setters for crowd avoidance #ue4 UE-22785 #rb Mieszko.Zielinski Change 2758422 on 2015/11/07 by Lina.Halper Potential fix for invalid root bone index input #jira :/UE-23086 #code review: Ori.Cohen Change 2758429 on 2015/11/07 by Mieszko.Zielinski Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4 #jira UE-23089 Change 2758571 on 2015/11/08 by Mieszko.Zielinski Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4 #jira UE-23080 Change 2758821 on 2015/11/09 by Thomas.Sarkanen Fixed animations no longer playing when using a dedicated server. Uses correct logic to determine whether we are running as a server or not. #rb Martin.Wilson Change 2758920 on 2015/11/09 by Marc.Audy Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize #rb Lina.Halper Change 2758944 on 2015/11/09 by Ori.Cohen Fix crash when stats are only on one thread and budget mode is used Change 2758967 on 2015/11/09 by Benn.Gallagher Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence. #jira UE-22963 Change 2758973 on 2015/11/09 by Benn.Gallagher Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating. #rb Bruce.Nesbit Change 2759219 on 2015/11/09 by Ori.Cohen Character perf test is now looking at stats directly and sending to analytics #RB Ben.Salem Change 2759398 on 2015/11/09 by Lina.Halper Fix issue where placed montages are not playing. - the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage #code review: Thomas.Sarkanen #RB: Marc.Audy Change 2759491 on 2015/11/09 by Lina.Halper #Anim: Fix not getting input correctly for Copy Pose node #RB: Marc.Audy Change 2759602 on 2015/11/09 by Marc.Audy Fix imporperly named struct Change 2759795 on 2015/11/09 by Aaron.McLeran UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing. #rb zak.middleton Change 2760081 on 2015/11/09 by Aaron.McLeran UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio. OmniDirectional Math Explanation: For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0. So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map. If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity). The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF. Note: I do not think we need to square the OmniRadius in: Emitter.InnerRadius = OmniRadius*OmniRadius; But I am keeping it t here because of legacy content which depends on that behavior. #rb zak.middleton hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework Re-instated deleted protected functions in UAnimInstance. Fixed access of UAnimInstance in FAnimNode_StateMachine. #rb Martin.Wilson Change 2760407 on 2015/11/10 by Jurre.deBaare Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals) Change 2760468 on 2015/11/10 by Benn.Gallagher Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits. #rb Graeme.Thornton Change 2760613 on 2015/11/10 by Jeff.Farris Fixed async collision completion delegate potentially firing repeatedly. (UE-23149) #cr marc.audy #codereview lina.halper Change 2760795 on 2015/11/10 by Marc.Audy Don't compile in pointless AddReferencedObjects when with editoronly data not defined Minor coding standard cleanup (NULL and auto) Change 2760848 on 2015/11/10 by Benn.Gallagher Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code. #jira UE-23164 #rb Martin.Wilson Change 2760866 on 2015/11/10 by Marc.Audy Manage transient visualization components for camera component in the same way that sprite component for other actor components are #rb Mike.Beach Change 2760963 on 2015/11/10 by Marc.Audy Since construction script can cause actors to be spawned don't use a ranged for to iterate #jira UE-22639 #rb Jeff.Farris #codereview Dmitriy.Dyomin Change 2762297 on 2015/11/11 by James.Golding UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created) #rb martin.wilson #codereview ori.cohen, lina.halper Change 2763566 on 2015/11/11 by Lina.Halper FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint. #RB: Laurent.Delayen Change 2763926 on 2015/11/12 by Thomas.Sarkanen Fix anim notifies not firing from single anim instances UE-23248 - Anim Notifies are not working for Animation Sequences UE-23249 - Anim Notifies using Sound Cues do not work #rb James.Golding Change 2764039 on 2015/11/12 by Jurre.deBaare Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper Change 2764307 on 2015/11/12 by Jurre.deBaare VS2015 SSF library Change 2764314 on 2015/11/12 by Stan.Melax crashfix was putting bad bodies to sleep at start Fatal error! Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000 UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875] On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies. Added check to ensure physx body exists before trying to force it to sleep. not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road". #codereview ori.cohen Change 2764343 on 2015/11/12 by Jurre.deBaare - Fixed crash when building a LOD with SubActors.Num < 2 - Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build - LODActor tree view item now scrolls into view if selected in the world - Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default - Added 7zip files - Fixed issue with WinINet complaining about http-request without 'http://' prefix - Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions) - Override texture sizes and automatic texture bias - Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data. - Now incorporate static meshes with opague materials into HLOD merging - Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled - Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component) - Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD) - Added ENUM for texture scaling/resizing type that has to be applied while merging the materials - Added detail customization class for FMaterialProxySettings #rb James.Golding [CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
if (bForceInstancing && !bUsesInstancing)
{
Node->ForceInstancing(false);
}
}
InitList.Sort(FNodeInitializationData::FMemorySort());
uint16 MemoryOffset = 0;
MemoryOffsets.AddZeroed(Nodes.Num());
for (int32 Index = 0; Index < InitList.Num(); Index++)
{
MemoryOffsets[Index] = InitList[Index].SpecialDataSize + MemoryOffset;
MemoryOffset += InitList[Index].DataSize;
}
MemorySize = MemoryOffset;
}
//----------------------------------------------------------------------//
// stats dumping
//----------------------------------------------------------------------//
struct FNodeClassCounter
{
TMap<UClass*, uint32> NodeClassUsage;
FNodeClassCounter()
{}
void Declare(UClass* NodeClass)
{
NodeClassUsage.FindOrAdd(NodeClass);
}
void CountNode(UBTNode* Node)
{
uint32& Count = NodeClassUsage.FindOrAdd(Node->GetClass());
++Count;
}
void Append(const FNodeClassCounter& Other)
{
for (auto Iterator : Other.NodeClassUsage)
{
uint32& Count = NodeClassUsage.FindOrAdd(Iterator.Key);
Count += Iterator.Value;
}
}
void Print(const TCHAR* Separator=TEXT(" "))
{
for (auto Iterator : NodeClassUsage)
{
UE_LOG(LogBehaviorTree, Display, TEXT("%s%s%s(%s)%s%d")
, Separator
, *Iterator.Key->GetName()
, Separator
, Iterator.Key->HasAnyClassFlags(CLASS_CompiledFromBlueprint) ? TEXT("BP") : TEXT("C++")
, Separator
, Iterator.Value);
}
}
};
void StatNodeUsage(UBTNode* Node, FNodeClassCounter& NodeCounter)
{
NodeCounter.CountNode(Node);
UBTCompositeNode* CompositeOb = Cast<UBTCompositeNode>(Node);
if (CompositeOb)
{
for (int32 ServiceIndex = 0; ServiceIndex < CompositeOb->Services.Num(); ServiceIndex++)
{
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
if (CompositeOb->Services[ServiceIndex])
{
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
NodeCounter.CountNode(CompositeOb->Services[ServiceIndex]);
}
}
for (int32 ChildIndex = 0; ChildIndex < CompositeOb->Children.Num(); ChildIndex++)
{
FBTCompositeChild& ChildInfo = CompositeOb->Children[ChildIndex];
for (int32 DecoratorIndex = 0; DecoratorIndex < ChildInfo.Decorators.Num(); DecoratorIndex++)
{
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
if (ChildInfo.Decorators[DecoratorIndex])
{
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
NodeCounter.CountNode(ChildInfo.Decorators[DecoratorIndex]);
}
}
UBTNode* ChildNode = NULL;
if (ChildInfo.ChildComposite)
{
StatNodeUsage(ChildInfo.ChildComposite, NodeCounter);
}
else if (ChildInfo.ChildTask)
{
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main) @ 2926658 #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2821607 on 2016/01/08 by Mieszko.Zielinski Added a way to limit amount of information logged by vlog by discarding logs from classes from outside of class whitelist #UE4 This feature was followed by refactoring of functions taking FVisualLogEntry pointers to use references instead. #rb Lukasz.Furman #codereview John.Abercrombie Change 2828384 on 2016/01/14 by Mieszko.Zielinski Back out of visual log refactor done as part of CL#2821607 #UE4 Change 2910454 on 2016/03/15 by Zak.Middleton #ue4 - Properly exclude zero-distance MTD results in ComponentEncroachesBlockingGeometry_WithAdjustment() in the presense of multiple overlaps. #rb Jeff.Farris #jira UE-24327 UDN: https://udn.unrealengine.com/questions/270574/jeff-farris-hack-for-physx-mtd.html Change 2910548 on 2016/03/15 by Zak.Middleton #ue4 - Handle MTD computation returning NaN direction when there is a "contact" with zero distance. Change 2912311 on 2016/03/16 by Marc.Audy Properly handle overlaps in C++ in documentation code and UE4 to Unity doc #rb Martin.Wilson Change 2913086 on 2016/03/17 by Marc.Audy Adding ability to have 9 parameters to a dynamic delegate Change 2913101 on 2016/03/17 by Marc.Audy Fix some of the loctext error messages Change 2913102 on 2016/03/17 by Thomas.Sarkanen Console usability improvements Display console autocompletion commands from the lexicographically first element up to either the total number of commands or MAX_AUTOCOMPLETION_LINES, whichever is least. The previous behaviour started the list "in the middle" and hid the first elements if there were too many matches. Thus "[ab ac ad]" with "aa" hidden now becomes "[aa ab ac]" with "ad" hidden. To make scrolling work as expected, the input handling of the up and down arrow keys has been reversed so that the cursor iterates forward starting from the top with the down arrow key, and goes back up with the up arrow key. Command history is still accessed with the up arrow key. This commit also undoes one of the most evil uses of operator overloading I've ever seen, on par with "#define true false" but more subtle Color console autocomplete entries to denote their type: command, CVar or other (manual autocompletion entries). CVars are further divided into writeable and read-only variables. Assume that manual console autocompletion entries are commands. This makes the autocompletion list colors more consistent and less noisy Automatically select (but don't complete) a command on console character input. To prevent the autocomplete from becoming too trigger happy, no longer automatically complete commands for arbitrary key inputs that we happen to have a match for Allow cycling through console commands with the tab key Discriminate between first time and repeated tab presses and only scroll through autocomplete entries on the latter Fix off-by-one error in console: "x more matches" line was being shown when the number of autocomplete elements was equal to MAX_AUTOCOMPLETION_LINES Fix an off-by-one error that was causing the topmost console command to not be shown if there was an autocomplete scroll region Show the currently selected autocomplete entry faded out behind the user's typed input Slightly increase brightness of the normal input text colour to better distinguish between the typed and autocompleted parts of the input line Left-justify command descriptions in the console autocompletion box Detect overflow of console autocomplete lines on low resolutions and decrease the space used for description justification to compensate Make the console input, history and autocomplete colours user configurable Add console background transparency. Configurable, set to 15% by default Add missing closing quote to the console dump HTML template #github #2061: Console usability improvements from Mattiwatti Change 2913104 on 2016/03/17 by Thomas.Sarkanen Added indicator displayed on animation nodes when they use the 'fast path' Added checkbox that can be used to audit Blueprint fast-path usage. Switched almost all animation node widgets to derive from new SAnimationGraphNode. This creates the overlay widget that indicates whether this node is using a more optimal path. #doc Also added documentation tooltips and UDN doc files/images for the fast path systems. #jira UE-24698 - Add icon to pins in anim graph to indicate 'fast mode' access #rb Martin.Wilson Change 2913306 on 2016/03/17 by Marc.Audy Cleaning up GetResourceSize - Made many call Super::GetResourceSize - Removed trivial implementations - Fixed HierarchicalInstanceStaticMeshComponent double counting an array Change 2913535 on 2016/03/17 by Lukasz.Furman fixed broken behavior tree graph data after subnode undo #ue4 UE-28198 Change 2913608 on 2016/03/17 by Lukasz.Furman fixed behavior tree execution indices after undoing move in editor #ue4 UE-26705 Change 2913847 on 2016/03/17 by Lukasz.Furman added new automation test for UE-28309 #ue4 Change 2913849 on 2016/03/17 by Lukasz.Furman fixed behavior tree skipping over branch when restart request comes during AbortCurrentTask call #ue4 UE-28309 Change 2913895 on 2016/03/17 by Marc.Audy Added 'self' argument to Actor and PrimitiveComponent delegates that didn't already supply one Fixed up all C++ uses of these delegates #jira UE-23122 #rb Zak.Middleton Change 2914743 on 2016/03/18 by Thomas.Sarkanen Editing of primitive data in PhAT [CL 2926677 by Marc Audy in Main branch]
2016-03-29 16:33:59 -04:00
for (int32 ServiceIndex = 0; ServiceIndex < ChildInfo.ChildTask->Services.Num(); ServiceIndex++)
{
if (ChildInfo.ChildTask->Services[ServiceIndex])
{
NodeCounter.CountNode(ChildInfo.ChildTask->Services[ServiceIndex]);
}
}
NodeCounter.CountNode(ChildInfo.ChildTask);
}
}
}
}
void UBehaviorTreeManager::DumpUsageStats() const
{
FNodeClassCounter AllNodesCounter;
for (TObjectIterator<UClass> It; It; ++It)
{
if (It->IsChildOf(UBTNode::StaticClass()) && It->HasAnyClassFlags(CLASS_Abstract) == false
#if WITH_EDITOR
&& !(FKismetEditorUtilities::IsClassABlueprintSkeleton(*It)
|| It->HasAnyClassFlags(CLASS_NewerVersionExists))
#endif
)
{
AllNodesCounter.Declare(*It);
}
}
UE_LOG(LogBehaviorTree, Display, TEXT("----------------------UBehaviorTreeManager::DumpUsageStats----------------------\nBehavior Trees:"));
// get all BTNode classes
for (TObjectIterator<UBehaviorTree> It; It; ++It)
{
FNodeClassCounter TreeNodeCounter;
UE_LOG(LogBehaviorTree, Display, TEXT("--- %s ---"), *(It->GetName()));
StatNodeUsage(It->RootNode, TreeNodeCounter);
TreeNodeCounter.Print();
AllNodesCounter.Append(TreeNodeCounter);
}
UE_LOG(LogBehaviorTree, Display, TEXT("--- Total Nodes usage:"));
AllNodesCounter.Print(TEXT(","));
}
void UBehaviorTreeManager::AddActiveComponent(UBehaviorTreeComponent& Component)
{
ActiveComponents.AddUnique(&Component);
}
void UBehaviorTreeManager::RemoveActiveComponent(UBehaviorTreeComponent& Component)
{
ActiveComponents.Remove(&Component);
}
UBehaviorTreeManager* UBehaviorTreeManager::GetCurrent(UWorld* World)
{
UAISystem* AISys = UAISystem::GetCurrentSafe(World);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040) #lockdown Nick.Penwarden ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3459524 by Marc.Audy Get/Set of properties that were previously BPRW/BPRO should error when used #jira UE-20993 Change 3460004 by Phillip.Kavan #jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value. Change summary: - Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation. Change 3461210 by Phillip.Kavan #jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry. Change summary: - Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database. - Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached. - Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid. - Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid. - Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals. - Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick. Notes: - Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor. Change 3461373 by Lukasz.Furman fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad #jira UE-44231 Change 3461409 by Lukasz.Furman fixed reenabling automatic navmesh generation in Editor Preferences #ue4 Change 3461550 by Ben.Zeigler #jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors Change 3462625 by Zak.Middleton #ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come). github PR #3620 Change 3462796 by Dan.Oconnor Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame #jira UE-45434 Change 3462995 by Ben.Zeigler #jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin Change 3463099 by Ben.Zeigler #jira UE-45471 Allow abstract base classes for primary assets Change 3464809 by Marc.Audy Expose FVector2D / FVector2D to blueprints #jira UE-45427 Change 3467254 by Mieszko.Zielinski Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4 Change 3467644 by Dan.Oconnor Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing. #jira UE-45443, UE-45444 Change 3468176 by Dan.Oconnor Fix dependent blueprints being marked dirty when a blueprint is compiled Change 3468353 by Michael.Noland UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game Change 3470532 by Dan.Oconnor Re-enable compilation manager Change 3470572 by Dan.Oconnor Fix for pin paramters resetting when an archetype was reinstanced #jira UE-45619 #rnx Change 3471949 by Mason.Seay Adding Primary Assets for testing Change 3472074 by Ben.Zeigler #jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache. Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking Change 3472079 by Ben.Zeigler With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here Change 3473429 by Lukasz.Furman changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh) #jira UE-41884 Change 3473476 by Lukasz.Furman changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh) #jira UE-41884 Change 3473663 by Ben.Zeigler Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added Change 3473679 by Mason.Seay Slight cleanup of test map and added ability to teleport across level for easy navigation Change 3473712 by Marc.Audy Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value Change 3474055 by Marc.Audy When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with. #jira UE-41828 Change 3474119 by mason.seay Tweaked Force Feedback test Change 3474156 by Marc.Audy Actually enable orphan pin retention Change 3474382 by Ben.Zeigler Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing Change 3474386 by Ben.Zeigler Close popup window when adding asset class to audit window Change 3474491 by Ben.Zeigler Remove ability for Worlds to not be saved as assets, this has been the default since 2014. Change 3475363 by Marc.Audy Alt-click now works with orphaned pins #jira UE-45699 Change 3475523 by Marc.Audy Fixup Fortnite and Paragon content for orphaned pin errors and warnings Change 3475623 by Phillip.Kavan #jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor. Change summary: - Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value. Change 3476008 by Dan.Oconnor Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value. #jira UE-18765 Change 3476115 by Dan.Oconnor Fix missing category information for inherited functions when using compilation manager #jira UE-45660 #rnx Change 3476577 by Lukasz.Furman added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms) #ue4 Change 3476587 by Phillip.Kavan #jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions. Change summary: - Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up. - Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree). Notes: - The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398. #rnx Change 3476723 by Dan.Oconnor Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager #jira UE-45468 #rnx Change 3476948 by Michael.Noland Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing Change 3476970 by Ben.Zeigler Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly Change 3477536 by Marc.Audy Don't display default value box on linked orphaned input pins Change 3477835 by Marc.Audy Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected #jira UE-45754 Change 3478027 by Marc.Audy Minor performance optimization #rnx Change 3478198 by Phillip.Kavan #jira UE-42431 - Remove an unnecessary ensure() when pasting an event node. Change summary: - Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node. Change 3478485 by Marc.Audy Eliminate extraneous error messages about orphaned pins on get/set nodes #jira UE-45749 #rnx Change 3478756 by Marc.Audy Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums #jira UE-45721 #rnx Change 3478926 by Marc.Audy Non-blueprint type structs can no longer be made/broken Non-blueprint visible properties in structs will no longer have pins created for them #jira UE-43122 Change 3478988 by Marc.Audy DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function. #jira UE-45524 Change 3479818 by Marc.Audy Allow ctrl-drag off of orphan pins #jira UE-45803 Change 3480214 by Marc.Audy Modifications to user defined enumerations are now transacted #jira UE-43866 Change 3480579 by Marc.Audy Maintain all pin properties through transactions. #rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle. Change 3481043 by Marc.Audy Make/Break of structs does not depend on having blueprint exposed properties. Splitting of a struct pin still requires blueprint exposed properties. #jira UE-45840 #jira UE-45831 Change 3481271 by Ben.Zeigler Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0 Clean up ChunkDependencyInfo and make it properly public Move ShouldSetManager to be WITH_EDITOR Ported from WEX branch #RB peter.sauerbrei Change 3481373 by Dan.Oconnor Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes #jira UE-45704 Change 3481380 by Ben.Zeigler Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful Change 3482362 by Marc.Audy Fix properties not exposed to blueprint warnings for input properties on function graphs. #jira UE-45824 Change 3482406 by Ben.Zeigler #jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map Change 3482498 by Ben.Zeigler Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class Change 3482517 by Lukasz.Furman fixed smart navlink update functions removing important flag #jira UE-45875 Change 3482538 by Marc.Audy When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float #jira UE-45846 Change 3482773 by Marc.Audy Don't show default value or pass by reference for exec pins #jira UE-45868 Change 3482791 by Ben.Zeigler #jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function Change 3483131 by Zak.Middleton #ue4 - InterpToMovementComponent: - Fix velocity not zeroed when interpolation stops. - Various fixes when calculating velocity and time when substepping is enabled. - Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact). #jira UE-45690 Change 3483146 by Phillip.Kavan #jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints. Change summary: - Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP. - Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling. - Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature. Change 3483340 by Ben.Zeigler Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets Change 3483548 by Michael.Noland Epic Friday: Playing around with some prototype traps Change 3483700 by Phillip.Kavan Fix CIS cook crash introduced by last submit. #rnx Change 3485217 by Ben.Zeigler #jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function Change 3485367 by Dan.Oconnor Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager #jira UE-45756 Change 3485565 by Ben.Zeigler #jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable Change 3485566 by Marc.Audy Fix crashes caused by undo/redo of user defined struct changes #jira UE-45775 #jira UE-45781 Change 3485805 by Michael.Noland PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev) #jira UE-43747 Change 3485807 by Michael.Noland PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers) #jira UE-44041 Change 3485811 by Michael.Noland Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level) Change 3485829 by Michael.Noland Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded Change 3485830 by Michael.Noland PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift) #jira UE-45002 Change 3486039 by Michael.Noland PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist) - Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding - Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible - Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible #jira UE-44014 Change 3486093 by Michael.Noland PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040) #jira UE-42903 Change 3486139 by Michael.Noland Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page #rn Change 3486154 by Michael.Noland Framework: Speculative fix for CIS error about FStructOnScope #rnx Change 3486180 by Dan.Oconnor Better match old logic for determining when to skip data only compile #jira UE-45830 Change 3487276 by Marc.Audy Fix crash when using Setter with a locally scoped variable #rnx Change 3487278 by Marc.Audy Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected Change 3487658 by Marc.Audy Ensure that child actor template is created for subclasses #jira UE-45985 Change 3487699 by Marc.Audy Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase Change 3487813 by Dan.Oconnor Asset demonstrating a crash Change 3488101 by Marc.Audy Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins. Correctly orphan pins when a node goes to 0 pins. Change 3488337 by Marc.Audy Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job #jira UE-46020 Change 3488512 by Dan.Oconnor ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it #jira UE-45830, UE-45965 #rnx Change 3488631 by Michael.Noland Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level #jira UE-45630 Change 3488665 by Michael.Noland Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set - The category, raw name, and tooltip of the property are now included as part of the filter text as well - The property tooltip is now displayed when hovering over the property name - Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate Change 3489324 by Marc.Audy Fix recursion causing stack crash #jira UE-46038 #rnx Change 3489326 by Marc.Audy Fix cooking crash #jira UE-46031 #rnx Change 3489687 by mason.seay Assets for testing orphan pins Change 3489701 by Marc.Audy Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin. #jira UE-46051 #jira UE-46052 #rnx Change 3490352 by Dan.Oconnor Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint #jira UE-46062 Change 3490814 by Marc.Audy Make callfunction/macro instances save all pins in orphan state more similar to previous behavior #rnx Change 3491022 by Dan.Oconnor Properly clean up 'Key' property when we fail to create a value property #jira UE-45279 Change 3491071 by Ben.Zeigler #jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory. Change 3491244 by Michael.Noland Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors) #jira UE-32948 Change 3491276 by Michael.Noland Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable) - Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places - Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item #jira UE-43372 Change 3491562 by Marc.Audy Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it #jira UE-46020 #rnx Change 3491658 by Marc.Audy Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert #rnx Change 3491946 by Marc.Audy ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented) RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible) DestroyImpl now prunes out SubPins that had already been trashed #rnx Change 3492040 by Marc.Audy Discard exec/then pins from a callfunction that has been converted to a pure node #rnx Change 3492200 by Zak.Middleton #ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size. Fixes possible regression from CL 3359561 that removed the Reset(...) entirely. #jira UE-46012 Change 3492290 by Ben.Zeigler #jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed Change 3492311 by Marc.Audy Don't clear the pin type if what you're connecting to's pin type is wildcard #rnx Change 3492680 by Dan.Oconnor Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset Change 3492826 by Marc.Audy Don't do pin connection list change notifications from DestroyPins while regenerating on load #jira UE-46112 #rnx Change 3492851 by Michael.Noland Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters Change 3492852 by Michael.Noland Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class Change 3492934 by Marc.Audy Fix ensure and crash delete macro containing orphaned pin #rnx Change 3493079 by Dan.Oconnor Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..) #rnx Change 3493346 by Phillip.Kavan #jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs. Change summary: - Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values. - Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future. Change 3493938 by Michael.Noland Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable) #jira UE-45780 Change 3493945 by Michael.Noland Blueprints: Fixed GetDelegatePoperty typos #rnx Change 3493997 by Michael.Noland Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes #jira UE-45760 Change 3493998 by Dan.Oconnor Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days Change 3494025 by Michael.Noland Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES) #rnx Change 3494026 by Michael.Noland Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer - Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc... - Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed #rnx Change 3496382 by Ben.Zeigler Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress Change 3496688 by Marc.Audy Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up #jira UE-46073 Change 3496830 by Michael.Noland Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata #rnx Change 3496840 by Michael.Noland Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work) Change 3497038 by Michael.Noland Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds) - You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts) - You can also specify a set of items to grant to your local inventory when it is created Change 3497204 by Marc.Audy Fix AbilitySystemComponent not being blueprint readable. #rnx Change 3497668 by Mieszko.Zielinski Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4 #jira UE-43659 Change 3497677 by Mieszko.Zielinski Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4 Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry #jira UE-41293 Change 3497678 by Mieszko.Zielinski Marked AbstractNavData class as transient #UE4 We never want to save it to levels Change 3497679 by Mieszko.Zielinski Made NavModifierVolume responsive to editor-time property changes #UE4 #jira UE-32831 Change 3497900 by Dan.Oconnor Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level #rnx Change 3497904 by Dan.Oconnor Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct #jira UE-46153 #rnx Change 3497907 by Dan.Oconnor Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class #rnx #jira UE-46186 Change 3498218 by mason.seay Updates to pin testing BP's Change 3498323 by Mieszko.Zielinski Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4 Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers #jira UE-44891 Change 3499007 by Marc.Audy Allow systems to hook Pre and PostCompile to do custom behaviors Change 3499013 by Mieszko.Zielinski Made AbstractNavData class non-transient again #UE4 Implemented AbstractNavData instances' transientness in a different manner. #jira UE-46194 Change 3499204 by Mieszko.Zielinski Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation. #jira UE-43799 Change 3499321 by mason.seay Updated bp for struct testing Change 3499388 by Marc.Audy Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed). Change 3499390 by Marc.Audy Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted. #rnx Change 3499420 by Michael.Noland Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want: - ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully - LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully - Assert: Asserts, the calling code is not expecting to handle a failure gracefully - Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern - Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert - Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked) - Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread The typical recommended call pattern is to use something like: if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull)) { ... Do something with World } Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr. #jira UE-42458 Change 3499429 by Michael.Noland Engine: Removed a bogus TODO (the problematic code had already been reworked) #rnx Change 3499470 by Michael.Noland Core: Improved and corrected the comment for ensure() - It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?) - It now only fires once per ensure() by default, added a note about ensureAlways() #rnx Change 3499643 by Marc.Audy Use TGuardValue instead of manually managing it #rnx Change 3499874 by Marc.Audy Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log Change 3499875 by Marc.Audy When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites) #jira UE-46224 Change 3499927 by Dan.Oconnor UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker #jira UE-43458 Change 3499953 by Michael.Noland Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage) - These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions Change 3499957 by Michael.Noland Animation: Added runtime errors for nullptr ControlRigs passed into BP methods #rnx Change 3499958 by Michael.Noland Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error #rnx Change 3499959 by Michael.Noland Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints Change 3499960 by Michael.Noland AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object Change 3499968 by Michael.Noland Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues #rnx Change 3499969 by Michael.Noland Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack #rnx Change 3499973 by Michael.Noland Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject - Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget Change 3499979 by Michael.Noland Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material Change 3499984 by Michael.Noland Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected Change 3499993 by Michael.Noland Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters - This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in' - These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>) - Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS Change 3500009 by Michael.Noland Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM) #rnx Change 3500011 by Michael.Noland Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms Change 3500012 by Michael.Noland Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset Change 3500014 by Michael.Noland Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that) Change 3500019 by Michael.Noland Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters - It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments Change 3500020 by Michael.Noland Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world) Change 3501062 by Marc.Audy MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function Fix inability to undo/redo pin additions to sequence node Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used #jira UE-46164 #jira UE-46270 Change 3501330 by Michael.Noland AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place) #jira UE-46271 Change 3501356 by Marc.Audy Fix crash when multi-editing actor blueprints #jira UE-46248 Change 3501408 by Michael.Noland Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack) Change 3501457 by Phillip.Kavan #jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node. Change summary: - Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass. - Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl). - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects. Change 3502741 by Phillip.Kavan #jira UE-45782 - Fix undo for index pin type changes. Change summary: - Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed. Change 3502939 by Michael.Noland Back out changelist 3499927 Change 3503087 by Marc.Audy Re-fixed ocean content as editor had also changed so had to take theirs and redo #rnx Change 3503266 by Ben.Zeigler #jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory Change 3503325 by mason.seay updated Anim BP to prep for pin testing Change 3503445 by Marc.Audy Fix crash caused by OldPins being destroyed before rewiring #rnx Change 3505024 by Marc.Audy Fix NodeEffectsPanel blueprint as it was using pins that no longer existed #rnx Change 3505254 by Marc.Audy Don't include orphan pins when gather source property names If a property doesn't exist for a source property name just skip the property rather than crashing #jira UE-46345 #rnx Change 3506125 by Ben.Zeigler #jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place Change 3506334 by Dan.Oconnor Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints #jira UE-46411 Change 3506439 by Dan.Oconnor Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo #jira UE-46308 Change 3506468 by Dan.Oconnor Return to pre 3488512 behavior, as it causes bad default values #jira UE-46414 #rnx Change 3506733 by Marc.Audy Use the most up to date class to determine whether a property still exists when adding pins during reconstruction #jira UE-45965 #author Dan.OConnor #rnx Change 3507531 by Ben.Zeigler #jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays Change 3507924 by mason.seay Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues Change 3507962 by Marc.Audy Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958 #rnx Change 3509131 by Dan.Oconnor Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table #jira UE-46311 Change 3509345 by Marc.Audy CVar to disable orphan pins if necessary #rnx Change 3509959 by Marc.Audy Protect against crashing due to large values in Timespan From functions #jira UE-43840 Change 3510040 by Marc.Audy Remove all the old unneeded ShooterGame test maps #rnx [CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
return AISys ? AISys->GetBehaviorTreeManager() : nullptr;
}
UBehaviorTreeManager* UBehaviorTreeManager::GetCurrent(UObject* WorldContextObject)
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040) #lockdown Nick.Penwarden ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3459524 by Marc.Audy Get/Set of properties that were previously BPRW/BPRO should error when used #jira UE-20993 Change 3460004 by Phillip.Kavan #jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value. Change summary: - Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation. Change 3461210 by Phillip.Kavan #jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry. Change summary: - Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database. - Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached. - Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid. - Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid. - Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals. - Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick. Notes: - Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor. Change 3461373 by Lukasz.Furman fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad #jira UE-44231 Change 3461409 by Lukasz.Furman fixed reenabling automatic navmesh generation in Editor Preferences #ue4 Change 3461550 by Ben.Zeigler #jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors Change 3462625 by Zak.Middleton #ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come). github PR #3620 Change 3462796 by Dan.Oconnor Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame #jira UE-45434 Change 3462995 by Ben.Zeigler #jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin Change 3463099 by Ben.Zeigler #jira UE-45471 Allow abstract base classes for primary assets Change 3464809 by Marc.Audy Expose FVector2D / FVector2D to blueprints #jira UE-45427 Change 3467254 by Mieszko.Zielinski Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4 Change 3467644 by Dan.Oconnor Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing. #jira UE-45443, UE-45444 Change 3468176 by Dan.Oconnor Fix dependent blueprints being marked dirty when a blueprint is compiled Change 3468353 by Michael.Noland UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game Change 3470532 by Dan.Oconnor Re-enable compilation manager Change 3470572 by Dan.Oconnor Fix for pin paramters resetting when an archetype was reinstanced #jira UE-45619 #rnx Change 3471949 by Mason.Seay Adding Primary Assets for testing Change 3472074 by Ben.Zeigler #jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache. Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking Change 3472079 by Ben.Zeigler With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here Change 3473429 by Lukasz.Furman changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh) #jira UE-41884 Change 3473476 by Lukasz.Furman changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh) #jira UE-41884 Change 3473663 by Ben.Zeigler Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added Change 3473679 by Mason.Seay Slight cleanup of test map and added ability to teleport across level for easy navigation Change 3473712 by Marc.Audy Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value Change 3474055 by Marc.Audy When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with. #jira UE-41828 Change 3474119 by mason.seay Tweaked Force Feedback test Change 3474156 by Marc.Audy Actually enable orphan pin retention Change 3474382 by Ben.Zeigler Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing Change 3474386 by Ben.Zeigler Close popup window when adding asset class to audit window Change 3474491 by Ben.Zeigler Remove ability for Worlds to not be saved as assets, this has been the default since 2014. Change 3475363 by Marc.Audy Alt-click now works with orphaned pins #jira UE-45699 Change 3475523 by Marc.Audy Fixup Fortnite and Paragon content for orphaned pin errors and warnings Change 3475623 by Phillip.Kavan #jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor. Change summary: - Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value. Change 3476008 by Dan.Oconnor Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value. #jira UE-18765 Change 3476115 by Dan.Oconnor Fix missing category information for inherited functions when using compilation manager #jira UE-45660 #rnx Change 3476577 by Lukasz.Furman added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms) #ue4 Change 3476587 by Phillip.Kavan #jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions. Change summary: - Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up. - Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree). Notes: - The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398. #rnx Change 3476723 by Dan.Oconnor Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager #jira UE-45468 #rnx Change 3476948 by Michael.Noland Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing Change 3476970 by Ben.Zeigler Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly Change 3477536 by Marc.Audy Don't display default value box on linked orphaned input pins Change 3477835 by Marc.Audy Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected #jira UE-45754 Change 3478027 by Marc.Audy Minor performance optimization #rnx Change 3478198 by Phillip.Kavan #jira UE-42431 - Remove an unnecessary ensure() when pasting an event node. Change summary: - Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node. Change 3478485 by Marc.Audy Eliminate extraneous error messages about orphaned pins on get/set nodes #jira UE-45749 #rnx Change 3478756 by Marc.Audy Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums #jira UE-45721 #rnx Change 3478926 by Marc.Audy Non-blueprint type structs can no longer be made/broken Non-blueprint visible properties in structs will no longer have pins created for them #jira UE-43122 Change 3478988 by Marc.Audy DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function. #jira UE-45524 Change 3479818 by Marc.Audy Allow ctrl-drag off of orphan pins #jira UE-45803 Change 3480214 by Marc.Audy Modifications to user defined enumerations are now transacted #jira UE-43866 Change 3480579 by Marc.Audy Maintain all pin properties through transactions. #rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle. Change 3481043 by Marc.Audy Make/Break of structs does not depend on having blueprint exposed properties. Splitting of a struct pin still requires blueprint exposed properties. #jira UE-45840 #jira UE-45831 Change 3481271 by Ben.Zeigler Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0 Clean up ChunkDependencyInfo and make it properly public Move ShouldSetManager to be WITH_EDITOR Ported from WEX branch #RB peter.sauerbrei Change 3481373 by Dan.Oconnor Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes #jira UE-45704 Change 3481380 by Ben.Zeigler Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful Change 3482362 by Marc.Audy Fix properties not exposed to blueprint warnings for input properties on function graphs. #jira UE-45824 Change 3482406 by Ben.Zeigler #jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map Change 3482498 by Ben.Zeigler Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class Change 3482517 by Lukasz.Furman fixed smart navlink update functions removing important flag #jira UE-45875 Change 3482538 by Marc.Audy When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float #jira UE-45846 Change 3482773 by Marc.Audy Don't show default value or pass by reference for exec pins #jira UE-45868 Change 3482791 by Ben.Zeigler #jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function Change 3483131 by Zak.Middleton #ue4 - InterpToMovementComponent: - Fix velocity not zeroed when interpolation stops. - Various fixes when calculating velocity and time when substepping is enabled. - Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact). #jira UE-45690 Change 3483146 by Phillip.Kavan #jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints. Change summary: - Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP. - Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling. - Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature. Change 3483340 by Ben.Zeigler Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets Change 3483548 by Michael.Noland Epic Friday: Playing around with some prototype traps Change 3483700 by Phillip.Kavan Fix CIS cook crash introduced by last submit. #rnx Change 3485217 by Ben.Zeigler #jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function Change 3485367 by Dan.Oconnor Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager #jira UE-45756 Change 3485565 by Ben.Zeigler #jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable Change 3485566 by Marc.Audy Fix crashes caused by undo/redo of user defined struct changes #jira UE-45775 #jira UE-45781 Change 3485805 by Michael.Noland PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev) #jira UE-43747 Change 3485807 by Michael.Noland PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers) #jira UE-44041 Change 3485811 by Michael.Noland Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level) Change 3485829 by Michael.Noland Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded Change 3485830 by Michael.Noland PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift) #jira UE-45002 Change 3486039 by Michael.Noland PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist) - Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding - Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible - Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible #jira UE-44014 Change 3486093 by Michael.Noland PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040) #jira UE-42903 Change 3486139 by Michael.Noland Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page #rn Change 3486154 by Michael.Noland Framework: Speculative fix for CIS error about FStructOnScope #rnx Change 3486180 by Dan.Oconnor Better match old logic for determining when to skip data only compile #jira UE-45830 Change 3487276 by Marc.Audy Fix crash when using Setter with a locally scoped variable #rnx Change 3487278 by Marc.Audy Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected Change 3487658 by Marc.Audy Ensure that child actor template is created for subclasses #jira UE-45985 Change 3487699 by Marc.Audy Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase Change 3487813 by Dan.Oconnor Asset demonstrating a crash Change 3488101 by Marc.Audy Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins. Correctly orphan pins when a node goes to 0 pins. Change 3488337 by Marc.Audy Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job #jira UE-46020 Change 3488512 by Dan.Oconnor ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it #jira UE-45830, UE-45965 #rnx Change 3488631 by Michael.Noland Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level #jira UE-45630 Change 3488665 by Michael.Noland Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set - The category, raw name, and tooltip of the property are now included as part of the filter text as well - The property tooltip is now displayed when hovering over the property name - Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate Change 3489324 by Marc.Audy Fix recursion causing stack crash #jira UE-46038 #rnx Change 3489326 by Marc.Audy Fix cooking crash #jira UE-46031 #rnx Change 3489687 by mason.seay Assets for testing orphan pins Change 3489701 by Marc.Audy Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin. #jira UE-46051 #jira UE-46052 #rnx Change 3490352 by Dan.Oconnor Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint #jira UE-46062 Change 3490814 by Marc.Audy Make callfunction/macro instances save all pins in orphan state more similar to previous behavior #rnx Change 3491022 by Dan.Oconnor Properly clean up 'Key' property when we fail to create a value property #jira UE-45279 Change 3491071 by Ben.Zeigler #jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory. Change 3491244 by Michael.Noland Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors) #jira UE-32948 Change 3491276 by Michael.Noland Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable) - Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places - Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item #jira UE-43372 Change 3491562 by Marc.Audy Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it #jira UE-46020 #rnx Change 3491658 by Marc.Audy Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert #rnx Change 3491946 by Marc.Audy ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented) RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible) DestroyImpl now prunes out SubPins that had already been trashed #rnx Change 3492040 by Marc.Audy Discard exec/then pins from a callfunction that has been converted to a pure node #rnx Change 3492200 by Zak.Middleton #ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size. Fixes possible regression from CL 3359561 that removed the Reset(...) entirely. #jira UE-46012 Change 3492290 by Ben.Zeigler #jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed Change 3492311 by Marc.Audy Don't clear the pin type if what you're connecting to's pin type is wildcard #rnx Change 3492680 by Dan.Oconnor Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset Change 3492826 by Marc.Audy Don't do pin connection list change notifications from DestroyPins while regenerating on load #jira UE-46112 #rnx Change 3492851 by Michael.Noland Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters Change 3492852 by Michael.Noland Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class Change 3492934 by Marc.Audy Fix ensure and crash delete macro containing orphaned pin #rnx Change 3493079 by Dan.Oconnor Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..) #rnx Change 3493346 by Phillip.Kavan #jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs. Change summary: - Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values. - Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future. Change 3493938 by Michael.Noland Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable) #jira UE-45780 Change 3493945 by Michael.Noland Blueprints: Fixed GetDelegatePoperty typos #rnx Change 3493997 by Michael.Noland Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes #jira UE-45760 Change 3493998 by Dan.Oconnor Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days Change 3494025 by Michael.Noland Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES) #rnx Change 3494026 by Michael.Noland Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer - Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc... - Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed #rnx Change 3496382 by Ben.Zeigler Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress Change 3496688 by Marc.Audy Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up #jira UE-46073 Change 3496830 by Michael.Noland Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata #rnx Change 3496840 by Michael.Noland Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work) Change 3497038 by Michael.Noland Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds) - You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts) - You can also specify a set of items to grant to your local inventory when it is created Change 3497204 by Marc.Audy Fix AbilitySystemComponent not being blueprint readable. #rnx Change 3497668 by Mieszko.Zielinski Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4 #jira UE-43659 Change 3497677 by Mieszko.Zielinski Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4 Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry #jira UE-41293 Change 3497678 by Mieszko.Zielinski Marked AbstractNavData class as transient #UE4 We never want to save it to levels Change 3497679 by Mieszko.Zielinski Made NavModifierVolume responsive to editor-time property changes #UE4 #jira UE-32831 Change 3497900 by Dan.Oconnor Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level #rnx Change 3497904 by Dan.Oconnor Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct #jira UE-46153 #rnx Change 3497907 by Dan.Oconnor Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class #rnx #jira UE-46186 Change 3498218 by mason.seay Updates to pin testing BP's Change 3498323 by Mieszko.Zielinski Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4 Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers #jira UE-44891 Change 3499007 by Marc.Audy Allow systems to hook Pre and PostCompile to do custom behaviors Change 3499013 by Mieszko.Zielinski Made AbstractNavData class non-transient again #UE4 Implemented AbstractNavData instances' transientness in a different manner. #jira UE-46194 Change 3499204 by Mieszko.Zielinski Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation. #jira UE-43799 Change 3499321 by mason.seay Updated bp for struct testing Change 3499388 by Marc.Audy Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed). Change 3499390 by Marc.Audy Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted. #rnx Change 3499420 by Michael.Noland Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want: - ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully - LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully - Assert: Asserts, the calling code is not expecting to handle a failure gracefully - Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern - Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert - Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked) - Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread The typical recommended call pattern is to use something like: if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull)) { ... Do something with World } Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr. #jira UE-42458 Change 3499429 by Michael.Noland Engine: Removed a bogus TODO (the problematic code had already been reworked) #rnx Change 3499470 by Michael.Noland Core: Improved and corrected the comment for ensure() - It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?) - It now only fires once per ensure() by default, added a note about ensureAlways() #rnx Change 3499643 by Marc.Audy Use TGuardValue instead of manually managing it #rnx Change 3499874 by Marc.Audy Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log Change 3499875 by Marc.Audy When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites) #jira UE-46224 Change 3499927 by Dan.Oconnor UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker #jira UE-43458 Change 3499953 by Michael.Noland Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage) - These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions Change 3499957 by Michael.Noland Animation: Added runtime errors for nullptr ControlRigs passed into BP methods #rnx Change 3499958 by Michael.Noland Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error #rnx Change 3499959 by Michael.Noland Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints Change 3499960 by Michael.Noland AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object Change 3499968 by Michael.Noland Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues #rnx Change 3499969 by Michael.Noland Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack #rnx Change 3499973 by Michael.Noland Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject - Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget Change 3499979 by Michael.Noland Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material Change 3499984 by Michael.Noland Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected Change 3499993 by Michael.Noland Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters - This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in' - These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>) - Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS Change 3500009 by Michael.Noland Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM) #rnx Change 3500011 by Michael.Noland Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms Change 3500012 by Michael.Noland Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset Change 3500014 by Michael.Noland Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that) Change 3500019 by Michael.Noland Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters - It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments Change 3500020 by Michael.Noland Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world) Change 3501062 by Marc.Audy MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function Fix inability to undo/redo pin additions to sequence node Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used #jira UE-46164 #jira UE-46270 Change 3501330 by Michael.Noland AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place) #jira UE-46271 Change 3501356 by Marc.Audy Fix crash when multi-editing actor blueprints #jira UE-46248 Change 3501408 by Michael.Noland Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack) Change 3501457 by Phillip.Kavan #jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node. Change summary: - Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass. - Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl). - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects. Change 3502741 by Phillip.Kavan #jira UE-45782 - Fix undo for index pin type changes. Change summary: - Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed. Change 3502939 by Michael.Noland Back out changelist 3499927 Change 3503087 by Marc.Audy Re-fixed ocean content as editor had also changed so had to take theirs and redo #rnx Change 3503266 by Ben.Zeigler #jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory Change 3503325 by mason.seay updated Anim BP to prep for pin testing Change 3503445 by Marc.Audy Fix crash caused by OldPins being destroyed before rewiring #rnx Change 3505024 by Marc.Audy Fix NodeEffectsPanel blueprint as it was using pins that no longer existed #rnx Change 3505254 by Marc.Audy Don't include orphan pins when gather source property names If a property doesn't exist for a source property name just skip the property rather than crashing #jira UE-46345 #rnx Change 3506125 by Ben.Zeigler #jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place Change 3506334 by Dan.Oconnor Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints #jira UE-46411 Change 3506439 by Dan.Oconnor Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo #jira UE-46308 Change 3506468 by Dan.Oconnor Return to pre 3488512 behavior, as it causes bad default values #jira UE-46414 #rnx Change 3506733 by Marc.Audy Use the most up to date class to determine whether a property still exists when adding pins during reconstruction #jira UE-45965 #author Dan.OConnor #rnx Change 3507531 by Ben.Zeigler #jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays Change 3507924 by mason.seay Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues Change 3507962 by Marc.Audy Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958 #rnx Change 3509131 by Dan.Oconnor Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table #jira UE-46311 Change 3509345 by Marc.Audy CVar to disable orphan pins if necessary #rnx Change 3509959 by Marc.Audy Protect against crashing due to large values in Timespan From functions #jira UE-43840 Change 3510040 by Marc.Audy Remove all the old unneeded ShooterGame test maps #rnx [CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::ReturnNull);
UAISystem* AISys = UAISystem::GetCurrentSafe(World);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040) #lockdown Nick.Penwarden ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3459524 by Marc.Audy Get/Set of properties that were previously BPRW/BPRO should error when used #jira UE-20993 Change 3460004 by Phillip.Kavan #jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value. Change summary: - Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation. Change 3461210 by Phillip.Kavan #jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry. Change summary: - Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database. - Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached. - Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid. - Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid. - Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals. - Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick. Notes: - Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor. Change 3461373 by Lukasz.Furman fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad #jira UE-44231 Change 3461409 by Lukasz.Furman fixed reenabling automatic navmesh generation in Editor Preferences #ue4 Change 3461550 by Ben.Zeigler #jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors Change 3462625 by Zak.Middleton #ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come). github PR #3620 Change 3462796 by Dan.Oconnor Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame #jira UE-45434 Change 3462995 by Ben.Zeigler #jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin Change 3463099 by Ben.Zeigler #jira UE-45471 Allow abstract base classes for primary assets Change 3464809 by Marc.Audy Expose FVector2D / FVector2D to blueprints #jira UE-45427 Change 3467254 by Mieszko.Zielinski Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4 Change 3467644 by Dan.Oconnor Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing. #jira UE-45443, UE-45444 Change 3468176 by Dan.Oconnor Fix dependent blueprints being marked dirty when a blueprint is compiled Change 3468353 by Michael.Noland UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game Change 3470532 by Dan.Oconnor Re-enable compilation manager Change 3470572 by Dan.Oconnor Fix for pin paramters resetting when an archetype was reinstanced #jira UE-45619 #rnx Change 3471949 by Mason.Seay Adding Primary Assets for testing Change 3472074 by Ben.Zeigler #jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache. Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking Change 3472079 by Ben.Zeigler With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here Change 3473429 by Lukasz.Furman changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh) #jira UE-41884 Change 3473476 by Lukasz.Furman changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh) #jira UE-41884 Change 3473663 by Ben.Zeigler Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added Change 3473679 by Mason.Seay Slight cleanup of test map and added ability to teleport across level for easy navigation Change 3473712 by Marc.Audy Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value Change 3474055 by Marc.Audy When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with. #jira UE-41828 Change 3474119 by mason.seay Tweaked Force Feedback test Change 3474156 by Marc.Audy Actually enable orphan pin retention Change 3474382 by Ben.Zeigler Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing Change 3474386 by Ben.Zeigler Close popup window when adding asset class to audit window Change 3474491 by Ben.Zeigler Remove ability for Worlds to not be saved as assets, this has been the default since 2014. Change 3475363 by Marc.Audy Alt-click now works with orphaned pins #jira UE-45699 Change 3475523 by Marc.Audy Fixup Fortnite and Paragon content for orphaned pin errors and warnings Change 3475623 by Phillip.Kavan #jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor. Change summary: - Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value. Change 3476008 by Dan.Oconnor Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value. #jira UE-18765 Change 3476115 by Dan.Oconnor Fix missing category information for inherited functions when using compilation manager #jira UE-45660 #rnx Change 3476577 by Lukasz.Furman added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms) #ue4 Change 3476587 by Phillip.Kavan #jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions. Change summary: - Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up. - Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree). Notes: - The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398. #rnx Change 3476723 by Dan.Oconnor Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager #jira UE-45468 #rnx Change 3476948 by Michael.Noland Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing Change 3476970 by Ben.Zeigler Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly Change 3477536 by Marc.Audy Don't display default value box on linked orphaned input pins Change 3477835 by Marc.Audy Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected #jira UE-45754 Change 3478027 by Marc.Audy Minor performance optimization #rnx Change 3478198 by Phillip.Kavan #jira UE-42431 - Remove an unnecessary ensure() when pasting an event node. Change summary: - Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node. Change 3478485 by Marc.Audy Eliminate extraneous error messages about orphaned pins on get/set nodes #jira UE-45749 #rnx Change 3478756 by Marc.Audy Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums #jira UE-45721 #rnx Change 3478926 by Marc.Audy Non-blueprint type structs can no longer be made/broken Non-blueprint visible properties in structs will no longer have pins created for them #jira UE-43122 Change 3478988 by Marc.Audy DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function. #jira UE-45524 Change 3479818 by Marc.Audy Allow ctrl-drag off of orphan pins #jira UE-45803 Change 3480214 by Marc.Audy Modifications to user defined enumerations are now transacted #jira UE-43866 Change 3480579 by Marc.Audy Maintain all pin properties through transactions. #rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle. Change 3481043 by Marc.Audy Make/Break of structs does not depend on having blueprint exposed properties. Splitting of a struct pin still requires blueprint exposed properties. #jira UE-45840 #jira UE-45831 Change 3481271 by Ben.Zeigler Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0 Clean up ChunkDependencyInfo and make it properly public Move ShouldSetManager to be WITH_EDITOR Ported from WEX branch #RB peter.sauerbrei Change 3481373 by Dan.Oconnor Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes #jira UE-45704 Change 3481380 by Ben.Zeigler Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful Change 3482362 by Marc.Audy Fix properties not exposed to blueprint warnings for input properties on function graphs. #jira UE-45824 Change 3482406 by Ben.Zeigler #jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map Change 3482498 by Ben.Zeigler Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class Change 3482517 by Lukasz.Furman fixed smart navlink update functions removing important flag #jira UE-45875 Change 3482538 by Marc.Audy When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float #jira UE-45846 Change 3482773 by Marc.Audy Don't show default value or pass by reference for exec pins #jira UE-45868 Change 3482791 by Ben.Zeigler #jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function Change 3483131 by Zak.Middleton #ue4 - InterpToMovementComponent: - Fix velocity not zeroed when interpolation stops. - Various fixes when calculating velocity and time when substepping is enabled. - Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact). #jira UE-45690 Change 3483146 by Phillip.Kavan #jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints. Change summary: - Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP. - Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling. - Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature. Change 3483340 by Ben.Zeigler Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets Change 3483548 by Michael.Noland Epic Friday: Playing around with some prototype traps Change 3483700 by Phillip.Kavan Fix CIS cook crash introduced by last submit. #rnx Change 3485217 by Ben.Zeigler #jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function Change 3485367 by Dan.Oconnor Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager #jira UE-45756 Change 3485565 by Ben.Zeigler #jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable Change 3485566 by Marc.Audy Fix crashes caused by undo/redo of user defined struct changes #jira UE-45775 #jira UE-45781 Change 3485805 by Michael.Noland PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev) #jira UE-43747 Change 3485807 by Michael.Noland PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers) #jira UE-44041 Change 3485811 by Michael.Noland Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level) Change 3485829 by Michael.Noland Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded Change 3485830 by Michael.Noland PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift) #jira UE-45002 Change 3486039 by Michael.Noland PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist) - Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding - Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible - Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible #jira UE-44014 Change 3486093 by Michael.Noland PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040) #jira UE-42903 Change 3486139 by Michael.Noland Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page #rn Change 3486154 by Michael.Noland Framework: Speculative fix for CIS error about FStructOnScope #rnx Change 3486180 by Dan.Oconnor Better match old logic for determining when to skip data only compile #jira UE-45830 Change 3487276 by Marc.Audy Fix crash when using Setter with a locally scoped variable #rnx Change 3487278 by Marc.Audy Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected Change 3487658 by Marc.Audy Ensure that child actor template is created for subclasses #jira UE-45985 Change 3487699 by Marc.Audy Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase Change 3487813 by Dan.Oconnor Asset demonstrating a crash Change 3488101 by Marc.Audy Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins. Correctly orphan pins when a node goes to 0 pins. Change 3488337 by Marc.Audy Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job #jira UE-46020 Change 3488512 by Dan.Oconnor ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it #jira UE-45830, UE-45965 #rnx Change 3488631 by Michael.Noland Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level #jira UE-45630 Change 3488665 by Michael.Noland Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set - The category, raw name, and tooltip of the property are now included as part of the filter text as well - The property tooltip is now displayed when hovering over the property name - Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate Change 3489324 by Marc.Audy Fix recursion causing stack crash #jira UE-46038 #rnx Change 3489326 by Marc.Audy Fix cooking crash #jira UE-46031 #rnx Change 3489687 by mason.seay Assets for testing orphan pins Change 3489701 by Marc.Audy Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin. #jira UE-46051 #jira UE-46052 #rnx Change 3490352 by Dan.Oconnor Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint #jira UE-46062 Change 3490814 by Marc.Audy Make callfunction/macro instances save all pins in orphan state more similar to previous behavior #rnx Change 3491022 by Dan.Oconnor Properly clean up 'Key' property when we fail to create a value property #jira UE-45279 Change 3491071 by Ben.Zeigler #jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory. Change 3491244 by Michael.Noland Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors) #jira UE-32948 Change 3491276 by Michael.Noland Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable) - Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places - Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item #jira UE-43372 Change 3491562 by Marc.Audy Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it #jira UE-46020 #rnx Change 3491658 by Marc.Audy Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert #rnx Change 3491946 by Marc.Audy ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented) RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible) DestroyImpl now prunes out SubPins that had already been trashed #rnx Change 3492040 by Marc.Audy Discard exec/then pins from a callfunction that has been converted to a pure node #rnx Change 3492200 by Zak.Middleton #ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size. Fixes possible regression from CL 3359561 that removed the Reset(...) entirely. #jira UE-46012 Change 3492290 by Ben.Zeigler #jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed Change 3492311 by Marc.Audy Don't clear the pin type if what you're connecting to's pin type is wildcard #rnx Change 3492680 by Dan.Oconnor Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset Change 3492826 by Marc.Audy Don't do pin connection list change notifications from DestroyPins while regenerating on load #jira UE-46112 #rnx Change 3492851 by Michael.Noland Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters Change 3492852 by Michael.Noland Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class Change 3492934 by Marc.Audy Fix ensure and crash delete macro containing orphaned pin #rnx Change 3493079 by Dan.Oconnor Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..) #rnx Change 3493346 by Phillip.Kavan #jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs. Change summary: - Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values. - Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future. Change 3493938 by Michael.Noland Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable) #jira UE-45780 Change 3493945 by Michael.Noland Blueprints: Fixed GetDelegatePoperty typos #rnx Change 3493997 by Michael.Noland Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes #jira UE-45760 Change 3493998 by Dan.Oconnor Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days Change 3494025 by Michael.Noland Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES) #rnx Change 3494026 by Michael.Noland Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer - Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc... - Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed #rnx Change 3496382 by Ben.Zeigler Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress Change 3496688 by Marc.Audy Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up #jira UE-46073 Change 3496830 by Michael.Noland Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata #rnx Change 3496840 by Michael.Noland Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work) Change 3497038 by Michael.Noland Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds) - You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts) - You can also specify a set of items to grant to your local inventory when it is created Change 3497204 by Marc.Audy Fix AbilitySystemComponent not being blueprint readable. #rnx Change 3497668 by Mieszko.Zielinski Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4 #jira UE-43659 Change 3497677 by Mieszko.Zielinski Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4 Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry #jira UE-41293 Change 3497678 by Mieszko.Zielinski Marked AbstractNavData class as transient #UE4 We never want to save it to levels Change 3497679 by Mieszko.Zielinski Made NavModifierVolume responsive to editor-time property changes #UE4 #jira UE-32831 Change 3497900 by Dan.Oconnor Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level #rnx Change 3497904 by Dan.Oconnor Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct #jira UE-46153 #rnx Change 3497907 by Dan.Oconnor Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class #rnx #jira UE-46186 Change 3498218 by mason.seay Updates to pin testing BP's Change 3498323 by Mieszko.Zielinski Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4 Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers #jira UE-44891 Change 3499007 by Marc.Audy Allow systems to hook Pre and PostCompile to do custom behaviors Change 3499013 by Mieszko.Zielinski Made AbstractNavData class non-transient again #UE4 Implemented AbstractNavData instances' transientness in a different manner. #jira UE-46194 Change 3499204 by Mieszko.Zielinski Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation. #jira UE-43799 Change 3499321 by mason.seay Updated bp for struct testing Change 3499388 by Marc.Audy Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed). Change 3499390 by Marc.Audy Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted. #rnx Change 3499420 by Michael.Noland Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want: - ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully - LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully - Assert: Asserts, the calling code is not expecting to handle a failure gracefully - Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern - Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert - Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked) - Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread The typical recommended call pattern is to use something like: if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull)) { ... Do something with World } Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr. #jira UE-42458 Change 3499429 by Michael.Noland Engine: Removed a bogus TODO (the problematic code had already been reworked) #rnx Change 3499470 by Michael.Noland Core: Improved and corrected the comment for ensure() - It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?) - It now only fires once per ensure() by default, added a note about ensureAlways() #rnx Change 3499643 by Marc.Audy Use TGuardValue instead of manually managing it #rnx Change 3499874 by Marc.Audy Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log Change 3499875 by Marc.Audy When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites) #jira UE-46224 Change 3499927 by Dan.Oconnor UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker #jira UE-43458 Change 3499953 by Michael.Noland Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage) - These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions Change 3499957 by Michael.Noland Animation: Added runtime errors for nullptr ControlRigs passed into BP methods #rnx Change 3499958 by Michael.Noland Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error #rnx Change 3499959 by Michael.Noland Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints Change 3499960 by Michael.Noland AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object Change 3499968 by Michael.Noland Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues #rnx Change 3499969 by Michael.Noland Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack #rnx Change 3499973 by Michael.Noland Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject - Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget Change 3499979 by Michael.Noland Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material Change 3499984 by Michael.Noland Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected Change 3499993 by Michael.Noland Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters - This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in' - These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>) - Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS Change 3500009 by Michael.Noland Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM) #rnx Change 3500011 by Michael.Noland Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms Change 3500012 by Michael.Noland Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset Change 3500014 by Michael.Noland Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that) Change 3500019 by Michael.Noland Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters - It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments Change 3500020 by Michael.Noland Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world) Change 3501062 by Marc.Audy MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function Fix inability to undo/redo pin additions to sequence node Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used #jira UE-46164 #jira UE-46270 Change 3501330 by Michael.Noland AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place) #jira UE-46271 Change 3501356 by Marc.Audy Fix crash when multi-editing actor blueprints #jira UE-46248 Change 3501408 by Michael.Noland Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack) Change 3501457 by Phillip.Kavan #jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node. Change summary: - Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass. - Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl). - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects. Change 3502741 by Phillip.Kavan #jira UE-45782 - Fix undo for index pin type changes. Change summary: - Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed. Change 3502939 by Michael.Noland Back out changelist 3499927 Change 3503087 by Marc.Audy Re-fixed ocean content as editor had also changed so had to take theirs and redo #rnx Change 3503266 by Ben.Zeigler #jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory Change 3503325 by mason.seay updated Anim BP to prep for pin testing Change 3503445 by Marc.Audy Fix crash caused by OldPins being destroyed before rewiring #rnx Change 3505024 by Marc.Audy Fix NodeEffectsPanel blueprint as it was using pins that no longer existed #rnx Change 3505254 by Marc.Audy Don't include orphan pins when gather source property names If a property doesn't exist for a source property name just skip the property rather than crashing #jira UE-46345 #rnx Change 3506125 by Ben.Zeigler #jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place Change 3506334 by Dan.Oconnor Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints #jira UE-46411 Change 3506439 by Dan.Oconnor Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo #jira UE-46308 Change 3506468 by Dan.Oconnor Return to pre 3488512 behavior, as it causes bad default values #jira UE-46414 #rnx Change 3506733 by Marc.Audy Use the most up to date class to determine whether a property still exists when adding pins during reconstruction #jira UE-45965 #author Dan.OConnor #rnx Change 3507531 by Ben.Zeigler #jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays Change 3507924 by mason.seay Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues Change 3507962 by Marc.Audy Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958 #rnx Change 3509131 by Dan.Oconnor Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table #jira UE-46311 Change 3509345 by Marc.Audy CVar to disable orphan pins if necessary #rnx Change 3509959 by Marc.Audy Protect against crashing due to large values in Timespan From functions #jira UE-43840 Change 3510040 by Marc.Audy Remove all the old unneeded ShooterGame test maps #rnx [CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
return AISys ? AISys->GetBehaviorTreeManager() : nullptr;
}