2019-12-26 15:33:43 -05:00
|
|
|
// Copyright Epic Games, Inc. All Rights Reserved.
|
2014-03-14 14:13:41 -04:00
|
|
|
|
|
|
|
|
|
|
|
|
|
#include "DebugToolExec.h"
|
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
|
|
|
#include "Modules/ModuleManager.h"
|
|
|
|
|
#include "UObject/ObjectMacros.h"
|
|
|
|
|
#include "UObject/Object.h"
|
|
|
|
|
#include "UObject/Class.h"
|
|
|
|
|
#include "UObject/UObjectIterator.h"
|
|
|
|
|
#include "Widgets/DeclarativeSyntaxSupport.h"
|
|
|
|
|
#include "Widgets/SBoxPanel.h"
|
|
|
|
|
#include "Widgets/SWindow.h"
|
|
|
|
|
#include "Framework/Application/SlateApplication.h"
|
|
|
|
|
#include "Widgets/Layout/SBorder.h"
|
2022-05-09 13:12:28 -04:00
|
|
|
#include "Styling/AppStyle.h"
|
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
|
|
|
#include "Engine/EngineTypes.h"
|
|
|
|
|
#include "GameFramework/Actor.h"
|
|
|
|
|
#include "CollisionQueryParams.h"
|
2014-11-04 06:12:25 -05:00
|
|
|
#include "Engine/GameEngine.h"
|
2014-11-12 04:43:54 -05:00
|
|
|
#include "GameFramework/PlayerController.h"
|
|
|
|
|
#include "EngineUtils.h"
|
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
|
|
|
#include "EngineGlobals.h"
|
|
|
|
|
#include "PropertyEditorModule.h"
|
|
|
|
|
#include "IDetailsView.h"
|
2014-03-14 14:13:41 -04:00
|
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Brings up a property window to edit the passed in object.
|
|
|
|
|
*
|
|
|
|
|
* @param Object property to edit
|
|
|
|
|
* @param bShouldShowNonEditable whether to show properties that are normally not editable under "None"
|
|
|
|
|
*/
|
|
|
|
|
void FDebugToolExec::EditObject(UObject* Object, bool bShouldShowNonEditable)
|
|
|
|
|
{
|
|
|
|
|
#if UE_BUILD_SHIPPING || UE_BUILD_TEST
|
|
|
|
|
// the effects of this cannot be easily reversed, so prevent the user from playing network games without restarting to avoid potential exploits
|
|
|
|
|
GDisallowNetworkTravel = true;
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
struct Local
|
|
|
|
|
{
|
|
|
|
|
/** Delegate to show all properties */
|
2014-06-24 13:07:20 -04:00
|
|
|
static bool IsPropertyVisible( const FPropertyAndParent& PropertyAndParent, bool bInShouldShowNonEditable )
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
return bInShouldShowNonEditable;
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
FDetailsViewArgs Args;
|
|
|
|
|
Args.bHideSelectionTip = true;
|
|
|
|
|
|
|
|
|
|
FPropertyEditorModule& PropertyModule = FModuleManager::LoadModuleChecked<FPropertyEditorModule>("PropertyEditor");
|
|
|
|
|
TSharedPtr<IDetailsView> DetailsView = PropertyModule.CreateDetailView(Args);
|
|
|
|
|
DetailsView->SetIsPropertyVisibleDelegate(FIsPropertyVisible::CreateStatic(&Local::IsPropertyVisible, bShouldShowNonEditable));
|
|
|
|
|
DetailsView->SetObject(Object);
|
|
|
|
|
|
|
|
|
|
// create Slate property window
|
|
|
|
|
FSlateApplication::Get().AddWindow
|
|
|
|
|
(
|
|
|
|
|
SNew(SWindow)
|
|
|
|
|
.ClientSize(FVector2D(400,600))
|
|
|
|
|
.Title( FText::FromString( Object->GetName() ) )
|
|
|
|
|
[
|
|
|
|
|
SNew(SBorder)
|
2022-05-09 13:12:28 -04:00
|
|
|
.BorderImage(FAppStyle::GetBrush("ToolPanel.GroupBorder"))
|
2014-03-14 14:13:41 -04:00
|
|
|
[
|
|
|
|
|
SNew(SVerticalBox)
|
|
|
|
|
+SVerticalBox::Slot()
|
|
|
|
|
.FillHeight(1)
|
|
|
|
|
[
|
|
|
|
|
DetailsView.ToSharedRef()
|
|
|
|
|
]
|
|
|
|
|
]
|
|
|
|
|
]
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Exec handler, parsing the passed in command
|
|
|
|
|
*
|
|
|
|
|
* @param InWorld World Context
|
|
|
|
|
* @param Cmd Command to parse
|
|
|
|
|
* @param Ar output device used for logging
|
|
|
|
|
*/
|
|
|
|
|
bool FDebugToolExec::Exec( UWorld* InWorld, const TCHAR* Cmd, FOutputDevice& Ar )
|
|
|
|
|
{
|
|
|
|
|
// these commands are only allowed in standalone games
|
|
|
|
|
#if UE_BUILD_SHIPPING || UE_BUILD_TEST
|
2014-04-02 18:09:23 -04:00
|
|
|
if (GEngine->GetNetMode(InWorld) != NM_Standalone || (GEngine->GetWorldContextFromWorldChecked(InWorld).PendingNetGame != NULL))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
// Edits the class defaults.
|
|
|
|
|
else
|
|
|
|
|
#endif
|
|
|
|
|
if( FParse::Command(&Cmd,TEXT("EDITDEFAULT")) )
|
|
|
|
|
{
|
|
|
|
|
// not allowed in the editor as this command can have far reaching effects such as impacting serialization
|
|
|
|
|
if (!GIsEditor)
|
|
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
UClass* Class = nullptr;
|
|
|
|
|
FString ClassName;
|
|
|
|
|
if (FParse::Value(Cmd, TEXT("CLASS="), ClassName))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
Class = FindFirstObject<UClass>(*ClassName, EFindFirstObjectOptions::None, ELogVerbosity::Warning, TEXT("parsing FDebugToolExec class"));
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
else if (FParse::Token(Cmd, ClassName, true))
|
|
|
|
|
{
|
|
|
|
|
Class = FindFirstObject<UClass>(*ClassName, EFindFirstObjectOptions::None, ELogVerbosity::Warning, TEXT("parsing FDebugToolExec class"));
|
|
|
|
|
}
|
2014-03-14 14:13:41 -04:00
|
|
|
|
|
|
|
|
if (Class)
|
|
|
|
|
{
|
|
|
|
|
EditObject(Class->GetDefaultObject(), true);
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
Ar.Logf( TEXT("Missing class") );
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return 1;
|
|
|
|
|
}
|
|
|
|
|
else if (FParse::Command(&Cmd,TEXT("EDITOBJECT")))
|
|
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
UClass* SearchClass = nullptr;
|
|
|
|
|
UObject* FoundObj = nullptr;
|
|
|
|
|
FString ClassName;
|
2014-03-14 14:13:41 -04:00
|
|
|
// Search by class.
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
if (FParse::Value(Cmd, TEXT("CLASS="), ClassName))
|
|
|
|
|
{
|
|
|
|
|
SearchClass = FindFirstObject<UClass>(*ClassName, EFindFirstObjectOptions::None, ELogVerbosity::Warning, TEXT("parsing FDebugToolExec class"));
|
|
|
|
|
}
|
|
|
|
|
if (SearchClass)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
// pick the first valid object
|
2021-01-21 16:22:06 -04:00
|
|
|
for (FThreadSafeObjectIterator It(SearchClass); It && FoundObj == NULL; ++It)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
2021-09-08 16:42:26 -04:00
|
|
|
if (IsValid(*It) && !It->IsTemplate())
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
2021-01-21 16:22:06 -04:00
|
|
|
FoundObj = *It;
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Search by name.
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
FName searchName;
|
|
|
|
|
FString SearchPathName;
|
|
|
|
|
if ( FParse::Value(Cmd, TEXT("NAME="), searchName) )
|
|
|
|
|
{
|
|
|
|
|
// Look for actor by name.
|
2021-01-21 16:22:06 -04:00
|
|
|
for( TObjectIterator<UObject> It; It && FoundObj == NULL; ++It )
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
if (It->GetFName() == searchName)
|
|
|
|
|
{
|
2021-01-21 16:22:06 -04:00
|
|
|
FoundObj = *It;
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
else if ( FParse::Token(Cmd,SearchPathName, true) )
|
|
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
FoundObj = FindFirstObject<UObject>(*SearchPathName, EFindFirstObjectOptions::None, ELogVerbosity::Warning, TEXT("parsing FDebugToolExec object"));
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Bring up an property editing window for the found object.
|
2021-01-21 16:22:06 -04:00
|
|
|
if (FoundObj != NULL)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
// not allowed in the editor unless it is a PIE object as this command can have far reaching effects such as impacting serialization
|
2021-01-21 16:22:06 -04:00
|
|
|
if (!GIsEditor || (!FoundObj->IsTemplate() && FoundObj->GetOutermost()->HasAnyPackageFlags(PKG_PlayInEditor)))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
2021-01-21 16:22:06 -04:00
|
|
|
EditObject(FoundObj, true);
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
Ar.Logf(TEXT("Target not found"));
|
|
|
|
|
}
|
|
|
|
|
return 1;
|
|
|
|
|
}
|
|
|
|
|
else if (FParse::Command(&Cmd,TEXT("EDITARCHETYPE")))
|
|
|
|
|
{
|
|
|
|
|
UObject* foundObj = NULL;
|
|
|
|
|
// require fully qualified path name
|
|
|
|
|
FString SearchPathName;
|
|
|
|
|
if (FParse::Token(Cmd, SearchPathName, true))
|
|
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
foundObj = FindFirstObject<UObject>(*SearchPathName, EFindFirstObjectOptions::None, ELogVerbosity::Warning, TEXT("EDITARCHETYPE"));
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Bring up an property editing window for the found object.
|
|
|
|
|
if (foundObj != NULL)
|
|
|
|
|
{
|
|
|
|
|
// not allowed in the editor unless it is a PIE object as this command can have far reaching effects such as impacting serialization
|
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
|
|
|
if (!GIsEditor || (!foundObj->IsTemplate() && foundObj->GetOutermost()->HasAnyPackageFlags(PKG_PlayInEditor)))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
EditObject(foundObj, false);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
Ar.Logf(TEXT("Target not found"));
|
|
|
|
|
}
|
|
|
|
|
return 1;
|
|
|
|
|
}
|
|
|
|
|
// Edits an objects properties or copies them to the clipboard.
|
|
|
|
|
else if( FParse::Command(&Cmd,TEXT("EDITACTOR")) )
|
|
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
UClass* Class = nullptr;
|
|
|
|
|
AActor* Found = nullptr;
|
|
|
|
|
FString ClassName;
|
2014-03-14 14:13:41 -04:00
|
|
|
|
|
|
|
|
if (FParse::Command(&Cmd, TEXT("TRACE")))
|
|
|
|
|
{
|
2015-09-11 14:49:47 -04:00
|
|
|
APlayerController* PlayerController = InWorld->GetGameInstance() ? InWorld->GetGameInstance()->GetFirstLocalPlayerController() : nullptr;
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
if (PlayerController != nullptr)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
// Do a trace in the player's facing direction and edit anything that's hit.
|
|
|
|
|
FVector PlayerLocation;
|
|
|
|
|
FRotator PlayerRotation;
|
|
|
|
|
PlayerController->GetPlayerViewPoint(PlayerLocation, PlayerRotation);
|
|
|
|
|
FHitResult Hit(1.0f);
|
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3436999)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3354003 on 2017/03/20 by Thomas.Sarkanen
Back out changelist 3353914
Change 3355932 on 2017/03/21 by Thomas.Sarkanen
Back out changelist 3354003
Reinstating merge from Main:
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839
Change 3385512 on 2017/04/07 by Aaron.McLeran
Bringing changes over from FN that fix audio streaming on PC/Mac/XboxOne/PS4
CL#3318457 - Fix crash when recycling PS4 sound sources.
CL#3313213 - Allowing XboxOne to cook streaming audio
CL#3313719 - GetWaveFormat now returns OPUS for streaming audio waves
CL#3320066 - Added libopus for XboxOne
CL#3320070 - libopus is now properly linked in XboxOne
CL#3313219 - Allowing Mac to cook streaming audio
CL#3315332 - Fixed audio streaming on Mac
CL#3315335 - (additional file missed in previous CL)
CL#3313207 - Sounds now register themselves with the audio streaming manager even if they are loaded before the audio device manager is created.
CL#3313294 - Removed some accidental debugging code that was mistakenly added in CL#3313207
CL#3318530 - Fix threading issues in FAudioStreamingManager
CL#3340718 - Fix for crash with audio streaming
CL#3340844 - Fix for more thread safety in audio streaming manager
CL#3343794 - Added a check in destructor of loaded chunk
CL#3343794 - Removing check in stopping a source
CL#3355393 - Moving audio streaming callbacks to use indices rather than ptrs to elements in dynamic array
CL#3369020 - bumping up size of compressed chunks for AT9 files when doing stream chunk compression
CL#3369131 - bumping up AT9 version number to get new AT9 cooks for larger chunks
CL#3373626 - Fixing ps4 streaming
CL#3375110 - Reverting some changes from 3373626
CL#3382078 - Making audio streaming decoding async to audio thread for xaudio2
CL#3383214 - Fixing buffer order issue for audio streaming
Change 3386321 on 2017/04/10 by Lina.Halper
#ANIM : preview
- Attache preview mesh to use copy mesh pose
#jira: UE-43114, UEAP-186
#rb: Thomas.Sarkanen
Change 3386415 on 2017/04/10 by Ori.Cohen
Improve the cost of UpdateKinematicBodies - added the ability to defer non simulating bodies.
#JIRA UEAP-79
Change 3386418 on 2017/04/10 by Ori.Cohen
Fix physx memory leak when a commandlet loads many assets without ticking scene
#JIRA UE-43378
Change 3386569 on 2017/04/10 by dan.reynolds
Updated dummy platform generated by standalone AEOverview tests to distinguish floor materials between the platform and the test zone.
Change 3386714 on 2017/04/10 by Ori.Cohen
Improve stats extensibility and expose it to the automation framework.
Change 3386805 on 2017/04/10 by Lina.Halper
Fix build error for editor
#rb: none
Change 3386854 on 2017/04/10 by Lina.Halper
build fix for clang
#rb:none
Change 3387198 on 2017/04/10 by Aaron.McLeran
#jira UE-43699 Deleting unused velocity variable.
OpenAL's velocity is not supported in WebAudio.
Removing dead code in AndroidAudioSource.cpp
Change 3387346 on 2017/04/10 by Ori.Cohen
Added performance regression map for physics (update kinematic bones and postBroadPhase)
#JIRA UEAP-79
Change 3387409 on 2017/04/10 by Ori.Cohen
Fix build, forgot to update this code
Change 3387536 on 2017/04/10 by Lina.Halper
Merging using AnimPhys-Fortnite-Main
- fix preview mesh selection/animation
#code review: Thomas.Sarkanen
#rb: none
#i_need_autocorrect
Change 3387995 on 2017/04/11 by Martin.Wilson
Live link updates
- Refactor of provider api (separate update of hierarchy and transforms)
- multi connection streaming from provider
- provider maintains internal state so that new connections can be updated without interaction with streaming source.
- Lifetime changes (connection timeout)
Change 3388241 on 2017/04/11 by Lina.Halper
Merging using AnimPhys-Fortnite-Main
- merge CL of 3388238
#rb: Thomas.Sarkanen
Change 3388294 on 2017/04/11 by Lina.Halper
build fix
#rb: none
Change 3388341 on 2017/04/11 by Ori.Cohen
Turn off vs2013 for physx
Change 3389115 on 2017/04/11 by Ori.Cohen
Forgot missing blueprint for perf test
Change 3389224 on 2017/04/11 by Ori.Cohen
Added sweep multi tests to perf regression
#JIRA UEAP-79
Change 3389984 on 2017/04/12 by Martin.Wilson
CIS Fix
Change 3390315 on 2017/04/12 by Lina.Halper
- fix on crash of component array when shutting down anim blueprint
#jira: UE-43868
#rb: Thomas.Sarkanen
Change 3390402 on 2017/04/12 by Martin.Wilson
Fix update not being called on post process instances when the main anim instance does not do a parallel update
#jira UE-43906
Change 3390772 on 2017/04/12 by Lina.Halper
Fix crash on importing LOD with lesser # of joints
#rb: Benn.Gallagher
Change 3394850 on 2017/04/14 by Aaron.McLeran
Adjusting how wavetable generation works for custom wavetables.
- Changed wavetable creation to use a TSharedPtr vs a raw ptr.
Change 3394853 on 2017/04/14 by Aaron.McLeran
Bringing from Odin the ability to set the lowpass filter frequency on an audio component from BP
Change 3395684 on 2017/04/17 by Ori.Cohen
Make debugdraw for line traces const correct.
Change 3396680 on 2017/04/17 by Ori.Cohen
Added a total scene query stat and the ability to trace all scene queries
Change 3397564 on 2017/04/18 by Benn.Gallagher
Added clothing functional and performance test map + assets.
Change 3397769 on 2017/04/18 by Thomas.Sarkanen
CIS fix
Fixup incorrect AudioStreaming.cpp merge when bringing Main into Dev-AnimPhys
Change 3398518 on 2017/04/18 by Lina.Halper
Mirroring fix on set world rotation
#rb: Zak.Middleton
#jira: UE-43830
Change 3400400 on 2017/04/19 by Chad.Garyet
adding switch physx build to anim-phys
Change 3400416 on 2017/04/19 by Chad.Garyet
updated email targets to include switch
Change 3402005 on 2017/04/20 by Ori.Cohen
Pass stats into scene queries. Not all call sites are updated yet, waiting on Jon for uber search/replace script.
Change 3402264 on 2017/04/20 by Ori.Cohen
CIS fix
Change 3402344 on 2017/04/20 by Ori.Cohen
Turn off find unknown (was on by mistake)
Change 3403311 on 2017/04/21 by Benn.Gallagher
Clothing changes from Dev-General. Fixed LOD pops, mesh swap crashes and convex collision locations
Change 3403399 on 2017/04/21 by Benn.Gallagher
Lighting build, content cleanup and reorganization for clothing test map
Change 3403401 on 2017/04/21 by Benn.Gallagher
Clothing test ground truth updates after lighting build.
Change 3403813 on 2017/04/21 by danny.bouimad
Adding everything needed for our multiplat map TM-AnimPhys
Change 3403900 on 2017/04/21 by mason.seay
Added WIP text to tests that need fixup
Change 3405383 on 2017/04/24 by Ori.Cohen
Fix typo where complex flag was not being passed in to constructor.
#JIRA UE-44278, UE-44279
Change 3405389 on 2017/04/24 by Martin.Wilson
Live link:
- Added support for sending curve data across live link and applying it via the Live Link node
- Added pose snapshots which are built in the live link clients tick and read by the rest of the engine, save reading live data.
Change 3405569 on 2017/04/24 by Martin.Wilson
Missed file from CL 3405389
Change 3405810 on 2017/04/24 by Chad.Garyet
fixing busted target for dev-animphys stream
Change 3406566 on 2017/04/24 by Aaron.McLeran
#jira UE-44272 Fixing granular synth with packaged builds
- Changed the way granular synth component and wave table component get PCM data from USoundWave assets. No duplication, just precache directly.
Change 3406694 on 2017/04/24 by Aaron.McLeran
Update to phonon/steam audio plugin from valve
Change 3407794 on 2017/04/25 by Aaron.McLeran
#jira UE-44357 Fix for attenuation settings in sequencer
Change 3407848 on 2017/04/25 by Jon.Nabozny
Add stats to FCollisionQueryParams (continued from CL-3402005).
Change 3407857 on 2017/04/25 by Jon.Nabozny
Disable FIND_UNKNOWN_SCENE_QUERIES.
Change 3407915 on 2017/04/25 by Lina.Halper
Animation Automation Test for curve and simple notify
Change 3408164 on 2017/04/25 by Ori.Cohen
Expose the physx tree rebuild rate.
Change 3408174 on 2017/04/25 by Lina.Halper
- Changed 1, 2, 3, 4 for ordering of timing
- Made sure the notify test takes more time between shots.
Change 3408359 on 2017/04/25 by Jon.Nabozny
Fix FConfigFile::Write for arrays of different sizes.
(Looks like it is still broke for arrays of the same same, with different values).
Change 3408633 on 2017/04/25 by Aaron.McLeran
#jira UE-44297 Fix for animating sound cue graph when editor "non-realtime" button is checked
- Fix is to explicitely register an active timer lambda that queries the preview audio component while the sound cue is playing
Change 3408768 on 2017/04/25 by Aaron.McLeran
Fixing UHT crash
Change 3409225 on 2017/04/26 by Lina.Halper
Increase tolerance for the shot test. It's very sensitive otherwise.
Change 3409313 on 2017/04/26 by Benn.Gallagher
Refactor of clothing paint tool framework to create a more extensible editor and get rid of some GDC techdebt
Change 3409478 on 2017/04/26 by danny.bouimad
Moved Text Actor forwards as it was causing zFighting
Change 3409572 on 2017/04/26 by Benn.Gallagher
CIS fix after cloth painter changes
Change 3409585 on 2017/04/26 by danny.bouimad
Updated Tm-AnimPhys to utilize the AEOverview maps, also found a crash with viewing shader complexity that only occurs on this map.
Change 3410948 on 2017/04/27 by Martin.Wilson
Live Link:
- Add subject clearing support to client / message bus protocol
- Update ref skeleton when subject changes.
- Remove old classes
Change 3413305 on 2017/04/28 by Danny.Bouimad
Disabled audio tests on AnimPhys Testmap to hopefuly stop the lighting crashes during launch on (content problem)
Change 3413408 on 2017/04/28 by mason.seay
Resaving to clear empty engine version warnings
Change 3413418 on 2017/04/28 by Benn.Gallagher
CIS fix, #pragma once in wrong place (after an include)
Change 3413737 on 2017/04/28 by Martin.Wilson
Rename Live Link Message Bus messages to contain the word message to avoid future name clashes
Change 3414121 on 2017/04/28 by Ori.Cohen
Added task batching for physx tasks. Set fortnite to 8 as we already have a lot of thread contention during that time and it's best to just do it all in a single task.
Change 3417833 on 2017/05/02 by Thomas.Sarkanen
Fix bad merge in SynthComponentGranulator.cpp
Change 3418174 on 2017/05/02 by Jon.Nabozny
Fix memory leak in UDestructibleComponent::SetSkeletalMesh
Change 3418907 on 2017/05/02 by Aaron.McLeran
#jira UE-44599 Fixing active sound un-pause issue.
- While paused, active sounds were updating their active playbacktime.
Change 3419001 on 2017/05/02 by Ori.Cohen
Added GetNumSimulatedAndAwake so that we can easily test for jitter.
Change 3419079 on 2017/05/02 by Ori.Cohen
Added a jitter automated test.
Change 3419213 on 2017/05/02 by mason.seay
Reaving content to remove empty engine version warnings
Change 3419351 on 2017/05/02 by Ori.Cohen
Added automated test for raycasting against landscape from underneath (JIRA UE-39819)
It looks like this is currently broken
Change 3419356 on 2017/05/02 by Ori.Cohen
Updated test with associated JIRA where we first saw this
Change 3419478 on 2017/05/02 by Ori.Cohen
Added automated test for origin shift regression crash when using aggregates.
Change 3420736 on 2017/05/03 by Ori.Cohen
Added automated test for moving objects during an overlap callback for UE-41450
#rnx
Change 3420803 on 2017/05/03 by Ori.Cohen
Added automated test for JIRA UE-18019
#rnx
Change 3420835 on 2017/05/03 by Jurre.deBaare
Anim modifier BP for release notes
Change 3421185 on 2017/05/03 by Ori.Cohen
Missing file
Change 3422673 on 2017/05/04 by danny.bouimad
Fixed the cooked/uncooked lighting issue with AEO_StageFloor. The lights should no longer repeatidly spawn when loading in as sub levels.
Change 3422898 on 2017/05/04 by Danny.Bouimad
Updating QA Audio Content
Change 3422908 on 2017/05/04 by Danny.Bouimad
Fixing Automation CIS error 'Can't find file for asset. /Game/Tests/Physics/ISMCStaticSweep_BuiltData'
Change 3423508 on 2017/05/04 by Danny.Bouimad
Replacing ground truth and adding build data for nonissue Automation CIS failure OverlapCallback
Change 3423634 on 2017/05/04 by danny.bouimad
Made updates to TM-AnimPhys testmap
Change 3423870 on 2017/05/04 by Ori.Cohen
Fix wheels separating from vehicle due to world kinematic refactor. Added temp variable for now
#jira UE-44624
Change 3423917 on 2017/05/04 by Ori.Cohen
Assert_Equal for int returns a bool
Change 3425267 on 2017/05/05 by Martin.Wilson
Live Link
- Add interpolation to subjects
- Add connection settings that can be modified in client panel. All subjects modified by a connection use its connection settings
- Give live link sources their client Guid so that they can send it with subject data
Change 3425303 on 2017/05/05 by Martin.Wilson
Missed file from CL 3425267
Change 3430351 on 2017/05/09 by Martin.Wilson
Crash fix for live link interpolation
Change 3430601 on 2017/05/09 by Benn.Gallagher
Disabled clothing perf test temporarily due to stats issues
Change 3432669 on 2017/05/10 by Ori.Cohen
Temporarily turn off line trace under heightfield test. This is a known bug which won't be fixed until 4.17
Change 3432679 on 2017/05/10 by Ori.Cohen
Temporarily turn off check during TLS release on Switch.
Change 3434960 on 2017/05/11 by danny.bouimad
Disabled content on TM-AnimPhys that was casuing a out of memory when drawing debug lines on switch.
Change 3436639 on 2017/05/12 by Danny.Bouimad
Updating ground truths and map for OverlapCallBack to fix CIS error.
[CL 3437043 by Thomas Sarkanen in Main branch]
2017-05-12 11:21:11 -04:00
|
|
|
PlayerController->GetWorld()->LineTraceSingleByChannel(Hit, PlayerLocation, PlayerLocation + PlayerRotation.Vector() * 10000.f, ECC_Pawn, FCollisionQueryParams(NAME_None, FCollisionQueryParams::GetUnknownStatId(), true, PlayerController->GetPawn()));
|
2020-09-22 15:55:19 -04:00
|
|
|
Found = Hit.GetHitObjectHandle().FetchActor();
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Search by class.
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
else if (FParse::Value(Cmd, TEXT("CLASS="), ClassName))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
Class = FindFirstObject<UClass>(*ClassName, EFindFirstObjectOptions::None, ELogVerbosity::Warning, TEXT("parsing FDebugToolExec class"));
|
|
|
|
|
if (Class)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
UGameEngine* GameEngine = Cast<UGameEngine>(GEngine);
|
2014-03-14 14:13:41 -04:00
|
|
|
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
// Look for the closest actor of this class to the player.
|
|
|
|
|
FVector PlayerLocation(0.0f);
|
|
|
|
|
APlayerController* PlayerController = InWorld->GetGameInstance() ? InWorld->GetGameInstance()->GetFirstLocalPlayerController() : nullptr;
|
|
|
|
|
if (PlayerController != NULL)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
FRotator DummyRotation;
|
|
|
|
|
PlayerController->GetPlayerViewPoint(PlayerLocation, DummyRotation);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
float MinDist = FLT_MAX;
|
|
|
|
|
for (TActorIterator<AActor> It(InWorld, Class); It; ++It)
|
|
|
|
|
{
|
|
|
|
|
if (IsValid(*It))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
Deprecating ANY_PACKAGE.
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
|
|
|
float const Dist = (PlayerController && It->GetRootComponent()) ? FVector::Dist(It->GetActorLocation(), PlayerLocation) : 0.f;
|
|
|
|
|
if (Dist < MinDist)
|
|
|
|
|
{
|
|
|
|
|
MinDist = Dist;
|
|
|
|
|
Found = *It;
|
|
|
|
|
}
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Search by name.
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
FName ActorName;
|
|
|
|
|
if( FParse::Value( Cmd, TEXT("NAME="), ActorName ) )
|
|
|
|
|
{
|
|
|
|
|
// Look for actor by name.
|
|
|
|
|
for( FActorIterator It(InWorld); It; ++It )
|
|
|
|
|
{
|
|
|
|
|
if( It->GetFName() == ActorName )
|
|
|
|
|
{
|
|
|
|
|
Found = *It;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Bring up an property editing window for the found object.
|
|
|
|
|
if( Found )
|
|
|
|
|
{
|
|
|
|
|
// not allowed in the editor unless it is a PIE object as this command can have far reaching effects such as impacting serialization
|
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
|
|
|
if (!GIsEditor || (!Found->IsTemplate() && Found->GetOutermost()->HasAnyPackageFlags(PKG_PlayInEditor)))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
EditObject(Found, true);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
Ar.Logf( TEXT("Target not found") );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
}
|