izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity
Files
3c2010d281269994deefcc86297a79247a9aeb34
UnrealEngineUWP/Engine/Source/Editor/UnrealEd/Private/AssetThumbnail.cpp

1615 lines
51 KiB
C++
Raw Normal View History

Updating copyright for Engine Editor. #rnx #rb none #ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904 #ROBOMERGE-BOT: (v613-10869866) [CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
// Copyright Epic Games, Inc. All Rights Reserved.
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
#include "AssetThumbnail.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "Engine/Blueprint.h"
#include "GameFramework/Actor.h"
#include "Layout/Margin.h"
#include "Widgets/DeclarativeSyntaxSupport.h"
#include "Widgets/SOverlay.h"
#include "Engine/GameViewportClient.h"
Make sure skeletalmesh thumbnail do not render async skeletalmesh, the flags must be removed before the thumbnail can be updated. #rb danny.couture #jira UEENT-3936 [CL 14788599 by Alexis Matte in ue5-main branch]
2020-11-19 14:36:38 -04:00
#include "Interfaces/Interface_AsyncCompilation.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "Modules/ModuleManager.h"
#include "Animation/CurveHandle.h"
#include "Animation/CurveSequence.h"
#include "Textures/SlateTextureData.h"
#include "Fonts/SlateFontInfo.h"
#include "Application/ThrottleManager.h"
#include "Widgets/SCompoundWidget.h"
#include "Widgets/Layout/SBorder.h"
#include "Widgets/Images/SImage.h"
#include "Widgets/Text/STextBlock.h"
#include "Widgets/SViewport.h"
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
#include "Styling/AppStyle.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "RenderingThread.h"
#include "Settings/ContentBrowserSettings.h"
#include "RenderUtils.h"
#include "Editor/UnrealEdEngine.h"
#include "ThumbnailRendering/ThumbnailManager.h"
#include "Editor.h"
#include "UnrealEdGlobals.h"
#include "Slate/SlateTextures.h"
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
#include "ObjectTools.h"
AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers. #rb Zousar.Shaker #rnx #preflight 6270509a220f89f0ad573030 [CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
#include "AssetRegistry/AssetRegistryModule.h"
#include "AssetRegistry/IAssetRegistry.h"
Async Static Mesh Compilation / Loading - Add protection against async property accessed during async build and postload. - Split PostLoad into 3 steps with the most part now being made async. - Make Build/BatchBuild API async when the feature is activated. - Add a new StaticMesh compilation manager. (This will be refactory later to reduce duplicated code with texture compiler). - Skip RenderState creation for any static mesh component still being built so they only show up when ready. - Fixed DistanceField and MeshCard computation that might trigger too soon if fixups are required to RenderData during PostLoad. - Dynamic priorisation for building and updating static meshes nearest to the viewport. - Implement different PIE modes, current default is to stall only for mesh that might affect nagivation/collision for players/bots. - Add a new generic interface for assets being built (still a WIP). - Add ability in FrontEnd filters to skip serialization of asset being async compiled and refresh when compilation finishes. - Prevent auto-save while textures and static meshes are being built (same as shaders) - Logic has been reordered in some Fortnite Building Component to avoid unnecessarily touching static mesh properties. General Optimizations - Use cached thumbnails until shaders/textures/static meshes are ready to improve performance and avoid rendering incomplete thumbnails. DEBUGGING - Can be forcibly enabled/disabled through command-line via -asyncstaticmeshcompilation=[off, on, paused] - Can pause staticmesh compilation using Editor.AsyncStaticMeshCompilation = 2 or -asyncstaticmeshcompilation=paused - Can manually resume a specified amount of paused compilation using Editor.AsyncStaticMeshCompilationResume [Num] - Can forcibly wait on all compilation using Editor.AsyncStaticMeshCompilationFlushAll BENCHMARKS - 2m19s to 17.9s for Loading FortGPUTestbed's LumenTest with an empty local only DDC - 2h45m to 5mxxs for Loading Reverb's P_World with an empty local only DDC - 17m29 to 10m27s for Loading Apollo_Terrain_Edit with an empty local only DDC TESTS - Loading maps from Reverb, Fortnite, ShooterGame, QAGame, FortGPUTestbed - Content browser interactions while still under heavy compilation - Importing with Datasmith / Dataprep - Working with the new Mesh Modeling Tool - Shutting down the editor while loading - Most of EngineTest Test Suite REFERENCES - Design https://docs.google.com/document/d/1O4GI1G9AtQN6l0SaGFfXw0DyNhlLunLoEqne5INvxIQ - Documentation https://docs.google.com/document/d/1KCdFEMhhcsGwfgOisTVwlOwtsmEd7qbB0V6Tc39Gb10 #rb Francis.Hurteau [CL 14688146 by danny couture in ue5-main branch]
2020-11-09 07:50:34 -04:00
#include "ShaderCompiler.h"
#include "AssetCompilingManager.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "IAssetTools.h"
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main #lockdown Nick.Penwarden #rb none Change 3720210 on 2017/10/25 by Olaf.Piesche Fixing dynamic material params for ribbons #!codereview scott.kennedy #!rb none #!tests scott's test ribbon Change 3720073 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: frank.fella Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it. #!Tests Minion automated tests no longer crash randomly. #!rb SimonT #!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3719233 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: philip.buuck [OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead). #!rb Matt.Schembari #!tests PIE [QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death #!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3718474 on 2017/10/25 by Yannick.Lange Niagara: Only show isolate menu items on track context menu if it is a system. Rename "Isolate toggle" to "Isolated". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718095 on 2017/10/25 by Yannick.Lange Niagara: Fix crash when not having dynamic parameter in material. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718069 on 2017/10/25 by Yannick.Lange Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3717545 on 2017/10/24 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Removed read / write locks from PipelineStateCache. #!rb Andrew.Grant, Gil.Gribb #!test paragon ps4. #!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3716928 on 2017/10/24 by Shaun.Kime The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime. #!rb olaf.piesche, simon.tovey #!fyi olaf.piesche, simon.tovey, frank.fella #!tests am now able to run Test_minionWave on PS4 Change 3715712 on 2017/10/24 by Yannick.Lange Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3715430 on 2017/10/23 by Shaun.Kime Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it. #!rb none #!fyi simon.tovey #!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime Change 3715368 on 2017/10/23 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main) #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3715226 on 2017/10/23 by Shaun.Kime Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's. #!rb none #!fyi simon.tovey, olaf.piesche, frank.fella #!tests ran in PIE Change 3714645 on 2017/10/23 by Yannick.Lange Niagara: Add ability to create particle system from this emitter in content browser. #!rb Shaun.Kime #!tests n/a Change 3714200 on 2017/10/23 by Olaf.Piesche Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target #!codereview simon #!rb none #!tests Orion Niagara assets Change 3713341 on 2017/10/23 by Yannick.Lange Niagara: Fix NiagaraNodeIF output pins cannot be deleted. Fix NiagaraNodeIF output pins cannot be renamed. #!jira UE-50193 #!jira UE-50193 #!rb Shaun.Kime #!tests n/a Change 3713133 on 2017/10/23 by Yannick.Lange Niagara: Isolate emitters in sequencer UI. - Added being able to extend the sequencer track context menu with a delegate. - Added entry in track context menu to toggle the selected emitters isolation state. - Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters. #!rb Shaun.Kime #!tests n/a Change 3712445 on 2017/10/22 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime UVScale, UniformAorBFloat, and LinearColorAlongVector added. #!rb none #!tests new autotest added #!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3712420 on 2017/10/21 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1. #!rb none [CODEREVIEW] frank.fella [FYI] simon.tovey, olaf.piesche, wyeth.johnson #!tests created an emitter, disabled Acceleration Force.. still compiled. #!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711602 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like: LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData #!jira UE-51511 #!rb Simon.Tovey #!tests n/a #!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711288 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: eric.ketchum [Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work #!rb: None #!tests: PIE [CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime #!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711197 on 2017/10/20 by Olaf.Piesche Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly #!rb none #!tests minion projectile ribbon trail Change 3710634 on 2017/10/20 by Mic.Rooney Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing. #!RB: none #!Test: tested/built locally ran preflight Editor/Monolithics build. #!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3709686 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Added some more timerguards for slow timer manager tick objects. Commented out for now. #!rb Trivial #!test Paragon Cooked ps4. #!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708958 on 2017/10/19 by Shaun.Kime Back out changelist 3708456 .. this was an unintentional change #!rb none #!tests n/a Change 3708839 on 2017/10/19 by Shaun.Kime Merging CL 3708835 Fixing Scott's common crash with adding an emitter with autocompile off #!rb frank.fella #!tests n/a Change 3708784 on 2017/10/19 by Shaun.Kime Merging CL 3708782 //Orion/Main/... to //Orion/DevGeneral/... #!rb none #!tests n/a Change 3708600 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion #!rb none #!test golden path #!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708473 on 2017/10/19 by Shaun.Kime Merging Frank's changes for team color support from Main to Dev-General #!rb Frank.Fella #!tests test_minionwave worked Change 3708456 on 2017/10/19 by Shaun.Kime Particles.Random set to 0.0 #!rb none #!tests n/a Change 3708455 on 2017/10/19 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests passed minion fx autotest Change 3707648 on 2017/10/19 by Shaun.Kime Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made. Defer deletion of dataset to RT. Ensure resets don't mess with data inflight RT commands are using. Checkin on behalf of Simon Tovey #!jira OR-45423 #!rb Simon.Tovey #!tests ran through the LaneMinionFXTests successfully on PC Change 3707096 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago. #!rb none #!tests automated tests pass #!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3706726 on 2017/10/19 by Rob.Cannaday Merge XMPP resource version to use version 2 instead of version 3 #!rb trivial #!tests compile #!ROBOMERGE: Main, 44, Tencent Change 3706349 on 2017/10/19 by Josh.Markiewicz #!UE4 - Cross Voice code review feedback - fixed up broken stack vs queue - fixed GetRoomId returning int32 instead of uint64 - fixed switch room logic - more/better logging - more comments #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday #!rb none #!tests local cheat codes Change 3705453 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: arne.schober Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array) #!RB Daniel.Wright #!Tests LaunchOnPs4 #!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3705399 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: scott.kennedy Default Niagara emitter changed color property to better default value. Updated basic glow emitter Added energy bubble base emitter put a little more polish into siege minion impact FX. #!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3704426 on 2017/10/18 by Shaun.Kime Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423 #!rb simon.tovey #!fyi hunter.kent #!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure Change 3703288 on 2017/10/18 by Olaf.Piesche Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash #!rb olaf.piesche, simon.tovey #!tests minion test map PC and PS4 Change 3701373 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader. #!rb Olaf.Piesche #!tests test_minionwave runs #!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3701108 on 2017/10/17 by Hunter.Kent Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily. #!RNX #!Test PS4 #!rb @tim.elek #!review-3701110 @andrew.grant, @daniel.lamb Change 3701044 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: jon.lietz - white space fixes - added in more detail to logging - fixed dragon GC to not hide when the mesh is hidden #!rb none #!tests complies and logging is updated [FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen #!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3700900 on 2017/10/17 by Shaun.Kime Integrating possible crash fix from Dev-Niagara to Dev-Gen #!rb none #!tests n/a #!fyi Olaf.Piesche Change 3700492 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests done in branch Change 3700217 on 2017/10/17 by Olaf.Piesche Fix for potential crash in sprite renderer #!rb none #!tests minion test map Change 3700216 on 2017/10/17 by Benn.Gallagher Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master. #!rb Lina.Halper #!jira OR-45226 #!tests PIE + Standalone games hitting Rampage with Ghosts E Change 3699660 on 2017/10/17 by Jason.Bestimt #!ORION_DG - Fixes to UnrealHitchParser edge cases #!RB:none #!Tests: Ran on Logs from QA #!CodeReview: ben.salem Change 3699462 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!tests preflight ok #!rb none Change 3699010 on 2017/10/17 by Jeff.Williams Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920 #!rb none #!tests none Change 3698519 on 2017/10/16 by Olaf.Piesche Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts #!rb none #!tests minion wave test map Change 3698380 on 2017/10/16 by Shaun.Kime Updating logic to now support the autoattachment #!rb none #!tests autotests pass.. Change 3698263 on 2017/10/16 by Olaf.Piesche Assume degrees for sprite rotation #!rb none #!codereview shaun.kime #!tests test sprite emitter Change 3697652 on 2017/10/16 by Olaf.Piesche Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion #!rb none #!tests minion test map Change 3696906 on 2017/10/15 by Shaun.Kime Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers. #!rb none #!tests now no longer generates invalid errors #!fyi frank.fella, olaf.piesche, simon.tovey Change 3695456 on 2017/10/13 by Olaf.Piesche Fix for potential ribbon crash and end-of-ribbon rendering artifacts #!rb none #!codereview scott.kennedy #!tests minion wave test map Change 3694545 on 2017/10/13 by Andrew.Grant Fix for low frequency async loading crash (OR-42535) #!rb gil.gribb #!tests comppiled Change 3694176 on 2017/10/13 by Jeff.Williams Plugin manifest name changed to DLCFile name #!rb none #!tests compile, stage Change 3693582 on 2017/10/12 by Don.Eubanks Fixing PS4 Compile warning (constructor init order not matching member define order) #!rb none #!tests Compile Shipping Client PS4 #!fyi olaf.piesche Change 3693516 on 2017/10/12 by Olaf.Piesche Niagara: Remove mesh renderer assert, replace with early out #!rb none #!tests niagara mesh test asset Merging //Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp Change 3693051 on 2017/10/12 by Ben.Salem Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log. #!rb Clayton.Langford #!tests Parsed a 5mb log with dumphitches down to 23k of hitch data. Change 3692912 on 2017/10/12 by Olaf.Piesche Merging: Niagara ribbon tiling distance #!rb none #!tests ribbon test asset Change 3692835 on 2017/10/12 by Shaun.Kime Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags. #!rb none #!fyi scott.kennedy, wyeth.johnson #!tests n/a Change 3692751 on 2017/10/12 by Shaun.Kime Removing script that shouldn't have come over. #!rb none #!tests n/a Change 3692746 on 2017/10/12 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests opened test level and created new emitter/system Change 3692616 on 2017/10/12 by Don.Eubanks OR-45131 Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking. #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE #!codereview nick.darnell Change 3691912 on 2017/10/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none #!tests compile, editor #!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3690944 on 2017/10/11 by Jeff.Williams Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC. #!rb Daniel.Lamb #!tests Compile, build Change 3688989 on 2017/10/10 by Lina.Halper LOD sync of attached/parent #!rb: Laurent.Delayen #!tests: price with shotgun skin/PIE/editor Change 3687592 on 2017/10/09 by Ben.Salem Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test. #!rb clayton.langford #!tests Ran sparrow shallow tests. Change 3686560 on 2017/10/09 by Shaun.Kime Flipping the min/max values to be standard #!rb none #!tests n/a Change 3686046 on 2017/10/09 by Shaun.Kime Merging latest from Dev-Niagara in preparation for Effects team work on Monday #!rb none #!tests successful preflight #!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek Change 3685613 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: simon.tovey Implementing vector field matrix inverse fix from CL3675167 to 43.3. #!rb none #!tests none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685603 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross RotationalContent Improvements - Fixed potential bug where tags could be updated when not intended on RotationalContentManager - Fix for PIE assert - Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option. - Removing config tag from RotationalContentOverrides in OrionGlobals. New Halloween Gauntlet Test - Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box. #!rb none #!tests local builds / editor / PIE #!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685408 on 2017/10/07 by ben.salem Fixing robomerge error in DevGen #!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. ben.salem, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml -------------------------------------- Merging using DevGen->Release43.3 Repairing mailer for nightly Perf tests, fixing email headers. #!tests run in devgen #!rb none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685073 on 2017/10/06 by Andrew.Grant Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General) #!tests #!rb na Change 3684717 on 2017/10/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where GT & RT times in profile info were reversed :( #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3684512 on 2017/10/06 by Laurent.Delayen Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code. #!rb lina.halper #!tests minion AnimBP nativization Change 3684059 on 2017/10/06 by Max.Preussner Orion: Fixed ability videos not loading on PS4 and/or not looping #!fyi stephan.jiang #!jira OR-44682 #!rb none #!rnx #!tests none Change 3683538 on 2017/10/06 by David.Ratti batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions. -Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players. -Fixes case where killing minions with badass was not displaying pops (prediction key issue) #!rb none #!tests editor, pie #!review-3683539 @Matt.Schembari Change 3683364 on 2017/10/06 by Andrew.Grant Changed warning to info #!tests #!rb na Change 3681999 on 2017/10/05 by Bart.Hawthorne Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion. #!rb cody.haskell #!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore #!jira OR-44111 #!tests Golden path, live spectated numerous matches. Change 3681403 on 2017/10/04 by Josh.Markiewicz #!UE4 - base pass for Tencent Cross SDK - basic testing done with enter/exit/switch room - basic testing of ShowUI - checked in disabled #!rb duck #!tests see above #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday Change 3680623 on 2017/10/04 by David.Ratti Rework for how max movement speed is calculated. The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow. Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored. Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow. GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc). Suggested methods for inspection: AbilitySystem debug hud (Home/End) p.VisualizeMovement (displays final calculated movement speed) Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar) Technical information: 1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool. 2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows. 3. Added a notification for attribute sets when an aggregator is created for one of their attributes. 4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod) 5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension. #!tests pie #!rb FrankG #!codereview Fred.Kimberley, Billy.Bramer #!fyi colin.fogle #!QAReview #!RN #!designchange Change 3680580 on 2017/10/04 by Ben.Salem Repair email titles for various reports. #!rb none #!tests Reran tests. Change 3680438 on 2017/10/04 by Dan.Hertzka GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect - Fixes the HUD status effect feed not showing sources for a lot of itemization abilities Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip #!rb Dave.Ratti #!tests OrionEntry PIE - equipped Sand Speeder #!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on Change 3680344 on 2017/10/04 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Speculative disable of defragging on volumetric lightmap textures. #!rb andrew.grant #!test monolith2 ps4 #!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3680302 on 2017/10/04 by Shaun.Kime Integration from DevNiagara. Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array. #!rb none #!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek #!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass. Change 3679946 on 2017/10/04 by Laurent.Delayen Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches. #!rb lina.halper #!FYI andrew.grant #!tests monolith2 old minions Change 3679938 on 2017/10/04 by Daniel.Lamb Allowed foliage cullall option to be modified by scalability options. #!rb Trivial #!test Compile paragon editor Change 3679563 on 2017/10/04 by Jon.Lietz OR-43599 - added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it. #!rb Dave.Ratti #!review-3679564 @John.Nielson #!tests added these waits to hot pursuit and they worked as expected Change 3679006 on 2017/10/03 by Ben.Salem Try to fix broken nightly mailer issues for FX tests. #!rb none #!tests Preflighted a shallow fx pass successfully in EC. Change 3677845 on 2017/10/03 by Andrew.Grant Added an ensure to guard against OR-44826 while further investigations occur #!tests compiled #!rb none Change 3677443 on 2017/10/03 by John.Nielson Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase. Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify). #!RB: None #!Test: Pie, Uncooked #!review-3677445: @David.Ratti Change 3676748 on 2017/10/02 by Laurent.Delayen Minions: split body layer is now done in mesh space, to maintain upper body orientation. #!FYI ray.arnett, lina.halper #!rb none #!test lane minion test map Change 3675950 on 2017/10/02 by Don.Eubanks Added several new supported tags / status effects to the Floating Status Effect Text system. Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player. Added ScaleOverDistance curve support for floating numbers / text. Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out. #!rb matt.schembari #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 Change 3675186 on 2017/10/02 by Mic.Rooney Support for other anim curve driving audio types (right now specifically DialogueWave) #!RB: none #!Test: compiled editor/monolithics/withoutunity and tested locally. #!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3675167 on 2017/10/02 by Shaun.Kime Changed unsafe InverseFast() to an Inverse() #!jira OR-44671 #!rb Simon.Tovey #!tests n/a Change 3674888 on 2017/10/02 by David.Ratti GGP V2 * Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration. Item System: * Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords. * Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup). Ability System: * SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE) #!rb none #!tests editor pie cooked #!review-3674889 @Jon.Lietz Change 3674170 on 2017/09/30 by Mieszko.Zielinski Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load. #!rb none #!test golden path #!OR-44738 Change 3672937 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files #!tests 3compiled #!rb none #!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672867 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored previous behaviour of integer numbers being formatted as "1" and not "1.00" #!tests ran game, checked playlist analytic #!rb nikdel #!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672575 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Remove warning that can happens normally with backwards compat replays #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672548 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Andrew.Grant #!test Editor building hlods #!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672542 on 2017/09/29 by Andrew.Grant Merging #!rb #!tests na Change 3672390 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed memreport settings for frontend tests #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672385 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Reworked and pretty much final PipelineState cache code - various comments incorporated - namespaced functions - removed redundant class and replaced with ref pointer #!tests soaked a lot [at daniel.lamb,] [at arne.schober] #!rb none #!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672281 on 2017/09/29 by Rob.Cannaday Add user ID to OnNetworkCheatDetected #!jira TEN-272 #!jira TEN-273 #!jira TEN-274 #!rb rob.cannaday #!tests Win64 AI match, simulate cheat detected by cheat command #!review-3672282 @ian.fox @sam.zamani Change 3671688 on 2017/09/29 by Frank.Gigliotti Added ability to set developer comment when adding native tags. #!RB David.Ratti #!Tests None Change 3670409 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for dump type made while doing cleanup #!tests compiled Win64, PS4, ran PS4 #!rb none #!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3670399 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed race condition in pipeline state cache Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon (Couple of extra tweaks planned, but this should be GTG for a v43 release) #!rb codereviewed #!tests soaked locally, lots #!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669802 on 2017/09/28 by Andrew.Grant From Dev-Framework #!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed #!rb michael.noland #!codereview andrew.grant #!tests na Change 3669709 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669177 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Reflection Captures support Lighting Scenarios without recapturing * Reflection Captures are now part of the Map Build * Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message) * Reflection Capture build data moved to the BuildData package * Building lighting / reflection captures no longer dirties ULevels * Sky lights which capture the scene now work correctly with Lighting Scenarios * Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded) #!rb Marcus.Wassmer #!TESTS Paragon editor Monolith02 #!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669124 on 2017/09/28 by Daniel.Lamb Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush Fix cook in devgeneral Bumped shader version to invalidate stale uniform buffer name. #!rb none #!TESTS none #!fyi Daniel.Wright Change 3667906 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667899 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Remove unused SM4 reflection capture cubemap #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667894 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] SM4 fallback for reflection captures. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667859 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] Removed old rasterized deferred reflection env path. Removed reflection compute shader. Replaced with PS. Small perf gain. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667852 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed missing include #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667807 on 2017/09/27 by Daniel.Lamb Tencent DLC can now remap the plugin content to the game root directory. #!rb Ben.Marsh #!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test Change 3667753 on 2017/09/27 by Clayton.Langford Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer. #!RB Ben.Salem, Adric.Worley #!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat Change 3667408 on 2017/09/27 by Jordan.Walker Optimization to bakedNormal layer blend on Low end material quality -uses simple multiply and add normal map blend Change 3667388 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times. #!rb none #!TESTS QAGame on console #!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667383 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667265 on 2017/09/27 by Daniel.Lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Uriel.Doyon #!test Editor building hlods Change 3667159 on 2017/09/27 by Mieszko.Zielinski Added simple logging to BT loading allowing us to identify missing BB keys #!Orion #!test golden path #!rb Lukasz.Furman Change 3665944 on 2017/09/26 by Dan.Hertzka Fix PS4 compile #!rb none #!tests compile PS4 Change 3665590 on 2017/09/26 by Daniel.Lamb Fix for DLC cooking everything when it should only cook the DLC. #!rb None #!test None Change 3665569 on 2017/09/26 by Dan.Hertzka New status effect feed for the new HUD: - Now placed in the mid-upper-left side of the HUD - Biggest difference from before is that there are now names associated with each effect - If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet. Cleaning: - Deleted all of the old buff widget classes & codepaths - Removed redundant properties from StatusEffectDisplayInfo - Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData Also: - Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events - Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed) @todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.) #!rb Don.Eubanks #!tests OrionEntry PIE with some cards and hero abilities #!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial. #!lockdown Billy.Rivers Change 3665555 on 2017/09/26 by Daniel.Lamb AudioStreaming mpsc queue fix up. #!rb Andrew.Grant #!test Compile paragon client / editor. Change 3665517 on 2017/09/26 by Daniel.Lamb Suspect fix for OR-44619 #!jira OR-44619 #!test Paragon editor compile #!rb Trivial Change 3664346 on 2017/09/26 by Jon.Lietz - making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out. - Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired. - Updated all GC's data to use the new decal class - removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent #!rb Dave.Ratti #!reivew Dave.Ratti #!tests used characters that had decal comps in the GC and they recylce as expected. #!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed. Change 3664099 on 2017/09/26 by Jon.Lietz OR-44510 - bringing over engine fixes for the Enum Redirector from Dev-Framework #!rb none #!tests compiles and warnings are gone Change 3663019 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Gil: fixed race condition in the PipelineStateCache #!rb Daniel.Lamb #!test paragon ps4 with higher repro modified build #!lockdown Andrew.Grant #!jira OR-44441 #!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663014 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready. #!tests ran locally #!rb [at daniel.lamb] [at arne.schober] #!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663004 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed dev check for extra commandline args from /data to /temp0 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662999 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Fixed DateTime used for folders not being set #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662255 on 2017/09/25 by Sam.Zamani #!tencent - fix for link error due to missing define of static OnNetworkCheatDetected delegate #!rb none #!tests none Change 3662073 on 2017/09/25 by Sam.Zamani #!tencent Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server Possible options #!jira TEN-275 TSS detect and expose punish user callbacks KickClient - User should be booted from the current game session via disconnect KickMatch - User received info about being punished (eg. ban type etc) PunishInfo - User received info about being punished (eg. ban type etc) #!rb rob.cannaday #!tests none Change 3659487 on 2017/09/22 by Josh.Markiewicz #!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin #!review-3659190 john.barrett, ryan.gerleve Change 3659485 on 2017/09/22 by Josh.Markiewicz #!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins #!fyi john.barrett, ryan.gerleve Change 3659184 on 2017/09/22 by Josh.Markiewicz #!UE4 - delete EpicSurvey module #!fyi justin.sargent, nick.darnell #!rb none Change 3658697 on 2017/09/22 by Ryan.Gerleve Fixes for server-side Tencent anti-cheat library integration: -Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows -Add getter for the TssSdkAntiInterf object -Enable server anti-cheat in editor builds #!codereview sam.zamani #!rb none #!tests enabled Tencent OSS, built & ran server Change 3658200 on 2017/09/22 by Graeme.Thornton Manual copy of CL 3587584 from Dev-Core Logging improvements for pak signature check failures - Added "PakCorrupt" console command which corrupts the master signature table - Added some extra log information about which block failed - Re-hash the master signature table and to make sure that it hasn't changed since startup - Moved the ensure around so that some extra logging messages can make it out before the ensure is hit - Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again #!rb none #!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General Change 3657970 on 2017/09/22 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition. We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game, [at marcus.wassmer,] [at arne.schober] #!rb none #!tests cycled 6-7 levels of Paragon #!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657914 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing... #!tests stepped through in non-pkg build #!rb none #!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657906 on 2017/09/21 by Andrew.Grant Improved some logging #!tests used locally #!rb none Change 3657891 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing Fixed issue with -dev mode on PS4 not updating symbols #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657867 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Re-locked network CL to 3652780 #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657857 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444 #!RB:arciel.rekman #!Tests:Compiled [CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf #!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657852 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for case-insensitivity causing title.json not to be staged #!rb daniel.lamb, bob.tellez #!tests ran packaging script, verified contents match v42 #!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657831 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors We can worry about a more permanent solution after we get this live. #!RB:none #!Tests: Compiled [CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer #!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657824 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb -------------------------------------- Built new UnrealCEFSubprocess client Changed OrionBuild.xml to build the shipping version of the above. The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this. [at justin.sargent,[at benjamin.crocker,[at wes.fudala]]] #!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657488 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: anton.migulko LIGHTING AND assets update #!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3656388 on 2017/09/21 by Laurent.Delayen Added default GetAxisVector static function to EAxisOption #!rb none #!FYI thomas.sarkanen #!tests lane minions test map Change 3656387 on 2017/09/21 by Laurent.Delayen Initialize FAnimInstanceProxy with default constructor. #!rb none #!fyi lina.halper, thomas.sarkanen #!tests lane minion test map Change 3656003 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3650578 for patching benjamin.crocker #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654403 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Merge DevCore -> Orion Release-43 CL 3641450 UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers. #!rb Daniel.Lamb #!test Compile #!lockdown Andrew.Grant #!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654356 on 2017/09/20 by Andrew.Grant Merging 3653658 from Dev-Rendering #!tests compiled, ran editor #!rb marcus.wassmer Change 3653914 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access). #!rb none #!tests ran locally #!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3652495 on 2017/09/19 by Andrew.Grant Editgration of VR fix in 3643776 from Release-4.17 #!tests #!rb na Change 3652244 on 2017/09/19 by Sam.Zamani #!tencent Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher Added "-q" to whitelist of command line params for shipping builds Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher #!rb rob.cannaday #!tests none Change 3651493 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651490 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651489 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651445 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag #!RB:none #!Tests:none [CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant #!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651059 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed code to archive load-order during tests #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651043 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed error parsing from tests to put cause ahead of file info #!tests ran self-test #!rb none #!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649683 on 2017/09/18 by Andrew.Grant Bulk-merge of oustanding changes in Main to DG #!tests #!rb na Change 3649345 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Integrate fix for eidtor crash when switching between low and high scaleability options. #!rb Olaf.Piesche #!test Paragon editor #!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649335 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - OR-44257 - Fix for hair not working It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion. #!RB:daniel.lamb #!Tests:Re-tested in cooked build [CODEREVIEW] daniel.lamb #!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649231 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM #!RB:none #!Tests:none [CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy #!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649211 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix 'lowest' shadow settings (simple forward rendering) #!rb arne.schober [FYI] Daniel.Wright #!tests monolith #!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649141 on 2017/09/18 by Stephan.Jiang Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source. -- These are hacks for ability videos to work before we have the new Sequencer updates -- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748 #!fyi Andrew.Grant, Max.Preussner #!rb none #!test compile Change 3649087 on 2017/09/18 by Thomas.Ross Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General #!rb none #!tests none #!fyi Andrew.Grant,Jeff.Williams,dan.oconnor Change 3649066 on 2017/09/18 by Max.Preussner WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources #!rb stephan.jiang #!rnx #!tests none Change 3649049 on 2017/09/18 by Max.Preussner Media: Changed audio sample rate warning to verbose log #!fyi stephan.jiang #!rb none #!rnx #!tests none Change 3648752 on 2017/09/18 by Max.Preussner WmfMedia: Fixed race condition in media sound wave #!rb none #!rnx #!tests none Change 3648748 on 2017/09/18 by Max.Preussner WmfMedia: Hack for preventing flicker between media source switching Do not merge to Dev-Main! #!rb stephan.jiang #!rnx #!tests none Change 3648596 on 2017/09/18 by Bart.Hawthorne More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough. Change 3648575 on 2017/09/18 by Sam.Zamani #!tencent Fix for missing library calls when initializing TSS anti cheat SDK #!rb none #!tests compiles win64 server Change 3648556 on 2017/09/18 by Jeff.Williams Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084 Clearing up robomerge #!rb none #!tests none Change 3648533 on 2017/09/18 by clayton.langford Unblocking RM. #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly. #!RB Adric.Worley #!tests none #!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3648219 on 2017/09/18 by Sam.Zamani #!tencent fixed Tencent module thirdparty dll runtime dependency paths fixed DLLHandle not being set #!rb none #!tests none Change 3647998 on 2017/09/18 by Clayton.Langford Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763. #!tests compiled #!rb Adric.Worley Change 3647817 on 2017/09/18 by James.Golding Mirror fix from 4.18 release stream (CL 3647799) to Dev-General Fix out-of-bounds access of cloth mapping data during CPU skinning #!rb benn.gallagher #!jira UE-49628 #!fyi benn.gallagher #!tests convert RiftMage to static mesh Change 3647749 on 2017/09/18 by Benn.Gallagher Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope. This caused matrix transposition to fail after the data was copied in using memcpy BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #!rb none #!tests Editor reimport of clothing assets Change 3646242 on 2017/09/15 by Tyler.Cole Revert shared engine LocalMCP scripts. Change 3646153 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds #!RB:daniel.lamb #!Tests: Ran cooked Client [CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy #!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3646125 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: arne.schober OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews. #!RB Marcus.Wassmer #!tests automated performance tests #!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3645861 on 2017/09/15 by clayton.langford #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW. Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added. To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated. #!tests ran local client/server, preflighted #!rb Ben.Salem #!rnx [FYI] Sean.Tobin, Hunter.Kent, Edward.King #!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3644062 on 2017/09/14 by Aaron.McLeran #!jira OR-44171 Some looping sounds are extremely loud #!rb Ethan.Geller #!tests run paragon, run near water river, don't observe looping sound being very loud Change 3643901 on 2017/09/14 by Laurent.Delayen Integrated CL #!3604725 to fix bug with opening state machines from anim graph. #!rb none #!tests fixes bug #!FYI lina.halper Change 3643641 on 2017/09/14 by Rob.Cannaday Fix unreachable code detected #!rb rob.cannaday #!tests Win64 compile Change 3643326 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TerSafe.dll loading until staging issues can be resolved #!rb none #!tests none Change 3643039 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TSS on servers due to linux build issues #!rb none #!tests none Change 3642438 on 2017/09/13 by Rob.Cannaday Handle new analytics param types (number, string, etc) Stub implementation of FAnalyticsProviderETTencent DefaultAttrs #!rb rob.cannaday #!tests Win64 vs AI match Change 3641655 on 2017/09/13 by Sam.Zamani #!tencent WIP added tss_sdk.dll (server) and TerSafe.dll (client) JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers #!rb none #!tests PC run with RegionCN.pak enabling tencent mode Change 3641559 on 2017/09/13 by Bart.Hawthorne Fix up oodle dictionary generation scripts #!rb none #!jira none Change 3641550 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3641393 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev. Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled - Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false) - Added PGOInput option to TargetRules and passed through to compile environment - Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for - Updated PS4 toolchain to use both LTO and PGO depending on what was set #!tests soaked locally, preflighted #!rb codereviewed FWIW here are before/after results for LTCG. Orion Performance report from 3 games and 1441.51 seconds MVP: 2.83 (Min: 2.05, Max: 3.22) HPM: 4.29 (Min: 4.24, Max: 4.37) AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms) GT: 12.88ms (Min: 12.68ms, Max: 13.25ms) RT: 13.71ms (Min: 13.48ms, Max: 14.08ms) GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms) Orion Performance report from 3 games and 1440.49 seconds MVP: 1.42 (Min: 1.02, Max: 1.94) HPM: 3.25 (Min: 2.75, Max: 3.62) AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms) GT: 11.93ms (Min: 11.64ms, Max: 12.47ms) RT: 12.80ms (Min: 12.54ms, Max: 13.24ms) GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms) #!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640885 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Limited warning to once every 10 secs. #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640875 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed shipping config issue #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640870 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Fixing CIS builds #!Orion The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors. [CODEREVIEW] John.Nielson #!rb none #!test compilation #!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640783 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson More temporary logging for finding the missing FX issue. #!rb: none #!Test: Pie #!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639910 on 2017/09/12 by Rob.Cannaday Build fix for AnalyticsETTencent #!rb rob.cannaday #!tests compile Win64 DebugGame Editor Change 3639565 on 2017/09/12 by Laurent.Delayen SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0. #!rb lina.halper #!FYI lina.halper #!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime. Change 3639228 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Tools - Added ability to postmortem a PS4 devkit for last crash #!rb run locally #!tests none #!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639075 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Specifically requesting 'all' configuration, to avoid missing manifest in jar. #!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639022 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka Remove dependency on the editor style set in the WidgetReflector - Fixes a crash when trying to use the reflector in a client cooked build - Also updated Focusable column name to shared var #!rb none #!tests Widget Reflected in a cooked build #!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638984 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638696 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Swapped problematic ensure to LogError, made draft obey notimeouts. #!tests compiled #!rb none [at daniel.lamb] #!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638644 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Third time's the charm #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638628 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure in a PS4 friendly way #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638583 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure to get a cook #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638545 on 2017/09/12 by Bart.Hawthorne Add analytics for oodle compression percentages #!rb ryan.gerleve, wes.hunt #!tests ran a 2 person game with dedicated server and verified analytics were reported #!jira OR-26386 Change 3638172 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Duplicate 3620803 Partial Fix for Dither Opacity Mask #!rb none #!tests PC monolith #!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637643 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Fixing version stream to Main #!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637524 on 2017/09/11 by Andrew.Grant Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests build Win64 editor, ran tests locally #!rb none Change 3637402 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Restored logging of runoptions when not verbose #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637357 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Made 'none' test specify Attended #!rb Daniel.Lamb #!tests compiled #!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637305 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added temporary debug logging cmd line option for finding Jira OrionOR-43600 #!RB: none #!Test: Pie [at David.Ratti] #!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636549 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues #!RB:none #!Tests:none [CODEREVIEW] uriel.doyon #!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636507 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka [OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG. Also: - Added distance formatting type for simple ability description values (will automatically append u to the value) - SimpleAbility description values can now go up to two decimal places Engine: - Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName #!rb Matt.Schembari #!tests PIE OrionEntry & FrontEndScene - various bug repros #!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636372 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Implement fast particle pool memory. Default is 2mb, automatically cleans up oldest used pool slots. Estimated 1/4 time for STAT_PARTALLOC. #!rb Jason.Bestimt #!test paragon ps4 cooked #!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636319 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue with fatal error message not being shown in reports. Fixed issue where some cancelled tests reported as succeeded #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636264 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance #!RB:none #!Tests: Ran client cooked build [CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon [QAREVIEW] #!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635288 on 2017/09/10 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices Fixed missing - in SoloSmoke args that were causing trailing params to be lost #!tests preflighted, ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635145 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to pick up SDK change for patch packages #!rb none #!tests none #!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635097 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added cleardevices option to Gauntlet that removes all devices after running. Added to Orion build scripts #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634985 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Cleaned up some logging around device failures Attempt to handle "Too Many Connections" error at a lower level Added removeall command to PS4DevkitUtil (not yet used) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634897 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Checking in change to timeouts to test theory #!tests ran test locally #!rb none #!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634765 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Scrape another .05ms out of GPU particle simulation. #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634422 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for Gauntlet shutdown issue on builders Fix for BP editing crash from Dev-Framework #!tests ran locally #!rb none! #!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634139 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running #!tests ran locally with single and file-based devices #!rb none #!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633799 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only. #!rb none #!tests monolith02 turrets [CODEREVIEW] lina.halper #!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633647 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Possible fix for OR-43926 from Arne #!tests ran locally, observed no ensures or negative side-effects in UI or HUD #!rb none #!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633637 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Upped timeout for editorbased tests #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632565 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed some test code... #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632385 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device handling. Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems. #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632177 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43 #!rb none #!test local commandlet #!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632131 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix a bug with new local vector-field only project setting #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632034 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where problem devices were reset each attempt #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631812 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device management in Gauntlet #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631787 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes. #!rb none [CODEREVIEW] martin.wilson #!test bot game #!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631251 on 2017/09/07 by Andrew.Grant Additional device selection improvements #!tests #!rb na Change 3630861 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3630620 on 2017/09/07 by Laurent.Delayen RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions. #!rb Ori.Cohen #!codereview benn.gallagher #!tests lane minions test map Change 3629990 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fix for gpu hang on ps4. #!rb Marcus.Wassmer #!test Paragon cooked ps4 #!jira OR-43835 #!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629980 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Moved some missed code to FDebug::HasAsserted() #!tests na #!rb none #!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629975 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Project optimization to only support local vector fields. separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost. #!rb olaf.piesche #!tests monolith ps4/pc #!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629917 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix for sizebyspeed on ps4 #!rb Simon.Tovey #!tests pc #!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629620 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629554 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored screenshot support to gauntlet (now driven externally) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629495 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: don.eubanks Stat panel will only show stat changes or improvements that come from Item sources (cards / gems) #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE [RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base! #!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629468 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring() Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread. #!tests ran locally #!rb none [at marcus.wassmer] #!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629410 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs -------------------------------------- Fix for generating project files #!tests GPF #!rb none #!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629369 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests) #!rb none #!tests verified signing is disabled and game gets to main menu with -fileopenlog [at graeme.thornton] #!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629254 on 2017/09/06 by Laurent.Delayen URO: ensure we don't skip more frames than desired when switching LODs. #!rb lina.halper #!codereview martin.wilson, benn.gallagher #!test lane minions test map Change 3629191 on 2017/09/06 by Laurent.Delayen Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions. #!rb lina.halper #!codereview martin.wilson #!test lane minions test map Change 3629130 on 2017/09/06 by Laurent.Delayen AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug. #!rb none #!tests lane minion test map Change 3628300 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed exception that could occur during tests if all devices were in use #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627915 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Undoing Oodle check for the time being #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627875 on 2017/09/06 by Jason.Bestimt #!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables) #!RB:none #!Tests:none #!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker #!ROBOMERGE: MAIN, 43 Change 3627694 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Improved warnings #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627642 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: david.ratti More logging for OR-43892 and OR-43779 #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627247 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed check that turns out to be bogus #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627240 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures #!tests compiled OrionClient [at daniel.lamb] #!rb none #!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627211 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added ensure for OR-43777 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626839 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added wait to PS4DevkitUtil before trying to postmortem crashdump #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626755 on 2017/09/05 by Rob.Cannaday Merge //Orion/Release-Tencent to //Orion/Dev-General Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded #!rb sam.zamani #!lockdown andrew.grant #!tests Win64 vs AI match, QA smoke test #!fyi sam.zamani Change 3626285 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed BaseDir argument not being correctly applied in tests Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626221 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame. Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement #!rb none #!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz [at Laurent.Delayen] [FYI] [at Andrew.Grant] #!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3625925 on 2017/09/05 by Laurent.Delayen If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want. #!rb benn.gallagher #!codereview martin.wilson, lina.halper #!tests lane minion map Change 3624051 on 2017/09/02 by Andrew.Grant Fixed issue with test params not being set. Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability. #!tests preflighted #!rb none #!review-3624052 @ben.salem Change 3623907 on 2017/09/02 by Andrew.Grant Fixed usesyncedbuild option being broken in Gauntlet #!codereview @daniel.lamb #!tests compiled #!rb none Change 3623906 on 2017/09/02 by David.Ratti Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides #!rb none #!test future wukong pie Change 3623766 on 2017/09/01 by Daniel.Wright [Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box #!rb none #!Tests PC QAGame Change 3623518 on 2017/09/01 by Don.Eubanks Fix for Shipping Client PS4 #!rb none #!tests Compile Shipping Client PS4 #!fyi daniel.lamb andrew.grant Change 3623515 on 2017/09/01 by Daniel.Wright [Copy] Volume materials applied to static meshes operate on the object's bounding sphere #!rb none #!TESTS QAGame PC Change 3623503 on 2017/09/01 by Daniel.Wright [Copy] Fixed ObjectRadius in Volume domain materials #!rb none #!TESTS none Change 3623102 on 2017/09/01 by Marcus.Wassmer Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand #!rb none #!tests monolith on PS4 #!fyi olaf.piesche,tim.elek Change 3623096 on 2017/09/01 by Marcus.Wassmer checkslow -> check to find issues with ILC #!rb none #!tests ran monolith on ps4 Change 3622744 on 2017/09/01 by Laurent.Delayen RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now). Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies. Take gravity from movement component if present, to inherit custom gravity scaling. Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used. If LOD enables new bodies, they are now initialized during simulation. Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default. Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change. Added AnimStats for PreUpdate, Update and Eval. #!rb ori.cohen #!codereview ori.cohen, lina.halper, benn.ghallager #!tests lane minion test map Change 3622743 on 2017/09/01 by Laurent.Delayen Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes. #!rb lina.halper #!tests lane minion test map Change 3622742 on 2017/09/01 by Laurent.Delayen 'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings. Renamed DisplayDebugCustom to DisplayDebugInstance. #!rb lina.halper #!tests lane minion test map Change 3622738 on 2017/09/01 by Laurent.Delayen Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams #!rb lina.halper #!tests lane minion test map Change 3622666 on 2017/09/01 by Jian.Ru Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements #!jira UE-48972, OR-43455 #!rb Chris.Bunner #!tests editor Change 3622579 on 2017/09/01 by Andrew.Grant Fixed shutdown issues with some tests being detected as errors Simplied and cleanup some things in state management of tests. #!tests ShortSOloGame test locally #!rb none Change 3622322 on 2017/09/01 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-40366 from v43 #!tests compiled #!rb Aaron.McLeran #!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3621054 on 2017/08/31 by Andrew.Grant Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests preflighted #!rb none Change 3620755 on 2017/08/31 by Daniel.Lamb Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations. #!rb Jason.Bestimt #!test Cooked paragon ps4 Change 3620541 on 2017/08/31 by Ben.Salem Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting. #!rb none #!tests compiled. Change 3620443 on 2017/08/31 by Mieszko.Zielinski Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4 #!rb none #!test golden path Change 3620428 on 2017/08/31 by Aaron.McLeran #!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General #!rb Ethan.Geller #!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports. Change 3620411 on 2017/08/31 by Mieszko.Zielinski Fix to removal of simuli sources from the AISense_Sight #!UE4 Made sure given source gets removed from ObservedTargets. #!rb none #!test golden path Change 3620343 on 2017/08/31 by Ben.Salem Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on. #!rb clayton.langford #!tests ran shallow and normal FX tests, generated hitches to display. Change 3620050 on 2017/08/31 by Luke.Thatcher [ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/... - USE_DEFRAG_ALLOCATOR was not always defined in all cases. #!rb Daniel.Lamb #!tests none Change 3619836 on 2017/08/31 by Andrew.Grant Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team) #!tests preflighted, ran locally #!rb none Change 3618597 on 2017/08/30 by Dan.Hertzka Fixed Additive UI materials not being affected by the widget opacity - We needed to multiply the sampled color by the alpha of the vertex color Also added fade in anim for scoreboard when showing after the endgame cinematic #!rb Nick.Darnell #!tests Widget alpha affects additive materials Change 3618441 on 2017/08/30 by Laurent.Delayen Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display. #!rb lina.halper #!tests lane minions Change 3618404 on 2017/08/30 by Paul.Moore - Update to new MMS client API from Fortnite. - Add MMS API plugin. #!rb none #!tests matchmaking, v2 MMS matchmaking, draft lobby. #!lockdown andrew.grant Change 3618167 on 2017/08/30 by Marcus.Wassmer Fix fog on PS4, also volume texture clears. #!rb luke.thatcher #!fyi Jordan.Walker #!tests ran monolith on ps4 Change 3617911 on 2017/08/30 by Andrew.Grant Fix for OR-43401, lighting remaining unbuilt #!tests ran cook, verified that lighting for bp components is now correctly found. #!rb marc.audy Change 3617765 on 2017/08/30 by Andrew.Grant Fix for lighting always being unbuilt on some blueprints #!tests cooked data and verified BP components have the correct transform and receive cached lighting data #!rb marc.audy, bp-team Change 3617757 on 2017/08/30 by Laurent.Delayen clang fix #!rb none #!tests none Change 3617700 on 2017/08/30 by Laurent.Delayen Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated. #!rb lina.halper #!tests lane minions map Change 3617695 on 2017/08/30 by Laurent.Delayen Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays. #!rb lina.halper #!tests test lane minions map Change 3616757 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-43459 from Laurent #!tests na #!rb Lina.Halper, Andrew.Grant #!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616745 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3609966 in anticipation of patch #!rb #!tests na #!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616551 on 2017/08/29 by Daniel.Lamb Fix memory leak in paragon. #!rb Andrew.Grant #!test Paragon ps4 Change 3613700 on 2017/08/28 by Andrew.Grant Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion Renabled r.Cache.UpdatePrimsTaskEnabled #!tests ran locally #!rb none Change 3613694 on 2017/08/28 by Andrew.Grant Added -teamsize argument to Orion none test. #!tests ran None test :) #!rb none Change 3613638 on 2017/08/28 by Ben.Salem Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created. #!rb clayton.langford #!tests Ran shallow and deep test for multiple characters. Change 3612731 on 2017/08/28 by Chris.Bunner [DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook. #!rb #!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb #!tests Cooking/running simple scene with grass foliage #!jira UE-48698, OR-42612 Change 3612695 on 2017/08/28 by Andrew.Grant Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things. #!tests ran NoneTest with -nomcp #!rb none Change 3612002 on 2017/08/27 by Andrew.Grant Fix for crash seen during nightly tests #!tests baseline perf didn't crast 3/3 #!rb none Change 3611980 on 2017/08/27 by Andrew.Grant PS4DevkitUtil post-mortem improvements to logging #!tests run ShortSoloGame #!rb none Change 3611758 on 2017/08/26 by Andrew.Grant Fix for warning #!tests #!rb na Change 3611737 on 2017/08/26 by Andrew.Grant Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering 3517039 - GitHub #!2655: Optimization for shadow map resolution selection for spot lights * Use the radius of the inscribed sphere at the cone end as the spot light's screen radius Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly 3545241 - Fixed spotlight whole scene shadows using a radius 2x too long 3545347 - Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame. #!rb none #!tests compiled Change 3611718 on 2017/08/26 by andrew.grant #!CodeReview: andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs -------------------------------------- Improved parsing of callstacks and errors in test logs Added unit test for error parsing #!tests ran locally, unit tests #!rb none #!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611704 on 2017/08/26 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Test fixes - addresses issue with memory report failing #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611683 on 2017/08/26 by Andrew.Grant Upgraded PS4 SDK to 4.508.111 #!tests SoloGames locally #!rb none Change 3611466 on 2017/08/25 by Andrew.Grant Changed none test to use monolith02 by default #!tests compiled #!rb none Change 3611167 on 2017/08/25 by Laurent.Delayen Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated. #!rb none #!tests lane minions #!codereview martin.wilson Change 3610850 on 2017/08/25 by dan.hertzka Unclog Robomerge #!rb none #!tests none Change 3610325 on 2017/08/25 by Andrew.Grant Compile fix for PS4 #!tests compiled #!rb none Change 3610018 on 2017/08/25 by Laurent.Delayen UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later. #!rb lina.halper #!tests venus ult on minion lane test map Change 3609967 on 2017/08/25 by Daniel.Lamb Merging using //Fortnite/Main/->//Orion/Dev-General/ Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4. CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping. - The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out. - Added an extra flag to reset mip bias values when texture memory budget is increased. #!rb Uriel.Doyon #!jira FORT-45385 #!jira FORT-47739 CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4. - Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled. - Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted. - Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps. #!jira FORT-45229 #!rb Ben.Woodhouse CL 3564368 LLM Changes Summary: LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead. Changes where LLM hooks into the various allocation functions and pools. Added more LLM tracking scopes. Changed the way LLM gets its internal memory. Writing stats out to csv Fixed a few bugs with the tracker code Details: * re-enabled LLM by default in Dev builds for XB1 and PS4 * Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update) * track allocations made from the defrag pool (PS4) * track non-drfrag pool garlic allocations (PS4) * track allocations made from PS4 malloc * combined the RHI and Malloc trackers into the Default tracker * changed stat groups to LLM, LLMPlatform and LLMOverhead * OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set * XMemAlloc now uses AllocationType if no LLM scope has been set * renamed VirtualMap to LLMMap * added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled. * support for tracking allocations that move in memory (for the PS4 defrag allocator) * support for tracking explicit memory without pausing the tracker * LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg * fixed check in FNameToTag. It was checking the wrong value when verifying the name index * show a warning on screen if LLM has been enabled without debug memory enabled (on consoles) * fixed program size tracking * fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope. * optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times) * fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them. * fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled * changed default alloc size for LLMMap to 16K * Added lots more LLM scopes renamed some of the existing ones * made FMemBlock::Allocators private and added accessor functions, which include LLM tracking. * fixed LLM alignment tracking in CustomVirtualAlloc * implemented LLM on XB1 so that it properly tracks D3D12Allocations * added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator * tracking of render targets * fixed LLM pool total column value. #!rb luke.thatcher CL 3565905 [ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/... 3458941 - Initial submission of new PS4 memory allocator. 3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible. 3498440 - Flexible and framebuffer memory fallbacks 3515704 - Add stats to new PS4 memory system. UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly. #!rb Ben.Woodhouse CL 3580934 [FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo. - Neo has 512 MB more direct memory than a base kit. - Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB. #!rb Marcus.Wassmer #!jira FORT-50206 CL 3590180 [FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted. - Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB. - Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool. - Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails. #!jira FORT-49700 #!rb Aaron.McLeran CL 3593920 [FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system. - Incorrect bitmask usage was truncating the available memory value to 32 bits. - Also includes some minor refactoring to make parts more readable. - Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile. #!rb Jonathan.Fitzpatrick #!jira FORT-50918 CL 3597577 [FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU. - Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack. - With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is. #!rb Stewart.Lynch #!jira FORT-50825 #!jira FORT-49688 #!jira FORT-49695 #!jira FORT-50054 CL 3601951 [FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system - Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0. - Added garlic, onion and defrag stats to the platform memory stats struct. - Added fixed pool sizes to platform memory stats. - Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools. #!rb Stewart.Lynch #!jira FORT-52910 #!test preflight with baseline performance memory report tests, local tests on neo #!rb Luke.Thatcher Change 3608480 on 2017/08/24 by Uriel.Doyon Instanced static mesh lightmaps are now updated correctly after lighting scenario changes #!jira UE-48522 #!tests Build lighting, loaded maps #!rb michel.dupuis Change 3608407 on 2017/08/24 by Andrew.Grant Reintegrated ROlando's cloth optimizations #!tests #!rb none Change 3608349 on 2017/08/24 by Rolando.Caloca O - Cloth vertex buffers no longer generate dummy vertices #!rb Lina.Halper #!fyi James.Golding #!tests Check obj list memory with multiple characters, tested animations Change 3607815 on 2017/08/24 by Laurent.Delayen Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha. https://jira.it.epicgames.net/browse/OR-43186 #!rb none #!tests Price hand two bone IK #!codereview lina.halper, thomas.sarkanen Change 3607770 on 2017/08/24 by Andrew.Grant Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong #!tests ran locally, updated parser test #!rb none Change 3607546 on 2017/08/24 by Jian.Ru Add more control to chromatic aberration effect #!jira UE-47138 #!rb Brian.Karis #!tests editor Change 3607270 on 2017/08/24 by Andrew.Grant Mirroring 3605735 from FN to address bug with MIC deduplication #!tests compiled #!rb none Change 3607082 on 2017/08/24 by Laurent.Delayen Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands. List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph). Current debug Target is highlighted in a green bounding box. Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player. Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors. Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation. #!rb dave.ratti #!tests lane minion test map, debugging individual minions #!codereview jon.lietz Change 3606772 on 2017/08/24 by David.Ratti Spot edigrate CL 3606417 for accurate CurveTable memory tracking #!rb none #!tests none [CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
#include "AssetTypeActions_Base.h"
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
#include "AssetToolsModule.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "Styling/SlateIconFinder.h"
AssetThumbnail - Add a header file to fix the non-unity builds. [CL 2221211 by Frank Fella in Main branch]
2014-07-16 16:09:42 -04:00
#include "ClassIconFinder.h"
Merging //UE4/Private-Geometry to Dev-VREditor (//UE4/Dev-VREditor) 3339870 #rb Mike.Fricker [CL 3340396 by Lauren Ridge in Dev-VREditor branch]
2017-03-09 16:53:09 -05:00
#include "IVREditorModule.h"
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
#include "Framework/Application/SlateApplication.h"
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
FName FAssetThumbnailPool::CustomThumbnailTagName = "CustomThumbnail";
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
class SAssetThumbnail : public SCompoundWidget
{
public:
SLATE_BEGIN_ARGS( SAssetThumbnail )
: _Style("AssetThumbnail")
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
, _ThumbnailPool(nullptr)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
, _AllowFadeIn(false)
, _ForceGenericThumbnail(false)
, _AllowHintText(true)
[INTEGRATE] Change 2416912 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/23 11:17:07 Added the ability for asset type actions to provide an extra overlay layer for their asset thumbnails UE-7970 - Add small 'play' button to EditorTutorial asset thumbnail Also cleaned up FAssetThumbnail::MakeThumbnailWidget so that it took a config struct (FAssetThumbnailConfig) rather than 7 or 8 defaulted parameters. [CL 2419655 by Ben Marsh in Main branch]
2015-01-26 19:57:37 -05:00
, _AllowAssetSpecificThumbnailOverlay(false)
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
, _AllowRealTimeOnHovered(true)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
, _Label(EThumbnailLabel::ClassName)
A bit more clang fixes. [CL 2084975 by Dmitry Rekman in Main branch]
2014-05-29 17:00:27 -04:00
, _HighlightedText(FText::GetEmpty())
, _HintColorAndOpacity(FLinearColor(0.0f, 0.0f, 0.0f, 0.0f))
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
, _ClassThumbnailBrushOverride(NAME_None)
[INTEGRATE] Change 2427078 by Matt.Kuhlenschmidt@matt_kuhlenschmidt_main on 2015/01/31 12:24:27 Updated asset icons for basic shapes [CL 2435293 by Matthew Griffin in Main branch]
2015-02-06 09:06:21 -05:00
, _AssetTypeColorOverride()
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
, _Padding(0)
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
, _GenericThumbnailSize(64)
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
, _ColorStripOrientation(EThumbnailColorStripOrientation::HorizontalBottomEdge)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{}
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
SLATE_ARGUMENT(FName, Style)
SLATE_ARGUMENT(TSharedPtr<FAssetThumbnail>, AssetThumbnail)
SLATE_ARGUMENT(TSharedPtr<FAssetThumbnailPool>, ThumbnailPool)
SLATE_ARGUMENT(bool, AllowFadeIn)
SLATE_ARGUMENT(bool, ForceGenericThumbnail)
SLATE_ARGUMENT(bool, AllowHintText)
SLATE_ARGUMENT(bool, AllowAssetSpecificThumbnailOverlay)
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
SLATE_ARGUMENT(bool, AllowRealTimeOnHovered)
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
SLATE_ARGUMENT(EThumbnailLabel::Type, Label)
SLATE_ATTRIBUTE(FText, HighlightedText)
SLATE_ATTRIBUTE(FLinearColor, HintColorAndOpacity)
SLATE_ARGUMENT(FName, ClassThumbnailBrushOverride)
SLATE_ARGUMENT(TOptional<FLinearColor>, AssetTypeColorOverride)
SLATE_ARGUMENT(FMargin, Padding)
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
SLATE_ATTRIBUTE(int32, GenericThumbnailSize)
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
SLATE_ARGUMENT(EThumbnailColorStripOrientation, ColorStripOrientation)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
SLATE_END_ARGS()
/** Constructs this widget with InArgs */
void Construct( const FArguments& InArgs )
{
Style = InArgs._Style;
HighlightedText = InArgs._HighlightedText;
Label = InArgs._Label;
HintColorAndOpacity = InArgs._HintColorAndOpacity;
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
bAllowHintText = InArgs._AllowHintText;
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
bAllowRealTimeOnHovered = InArgs._AllowRealTimeOnHovered;
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
ThumbnailBrush = nullptr;
ClassIconBrush = nullptr;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
AssetThumbnail = InArgs._AssetThumbnail;
bHasRenderedThumbnail = false;
WidthLastFrame = 0;
Refined text rendering on content browser thumbnails and reverted back to full-width sizing method. Tiny text is now using a lighter font with a better hinting algorithm, and is centrally justified. We want to minimise waste of horizontal space, so content browser thumbnails now fill the width of the content browser once again. [CL 2299335 by Andrew Rodham in Main branch]
2014-09-16 07:01:27 -04:00
GenericThumbnailBorderPadding = 2.f;
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
GenericThumbnailSize = InArgs._GenericThumbnailSize;
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
ColorStripOrientation = InArgs._ColorStripOrientation;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
AssetThumbnail->OnAssetDataChanged().AddSP(this, &SAssetThumbnail::OnAssetDataChanged);
const FAssetData& AssetData = AssetThumbnail->GetAssetData();
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UClass* Class = FindObjectSafe<UClass>(AssetData.AssetClassPath);
Content browser optimization, call load module once #rb none [CL 4555014 by Rex Hill in Dev-Editor branch]
2018-11-09 09:30:01 -05:00
static FAssetToolsModule& AssetToolsModule = FModuleManager::LoadModuleChecked<FAssetToolsModule>(TEXT("AssetTools"));
[INTEGRATE] Change 2416912 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/23 11:17:07 Added the ability for asset type actions to provide an extra overlay layer for their asset thumbnails UE-7970 - Add small 'play' button to EditorTutorial asset thumbnail Also cleaned up FAssetThumbnail::MakeThumbnailWidget so that it took a config struct (FAssetThumbnailConfig) rather than 7 or 8 defaulted parameters. [CL 2419655 by Ben Marsh in Main branch]
2015-01-26 19:57:37 -05:00
TSharedPtr<IAssetTypeActions> AssetTypeActions;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
if ( Class != NULL )
{
[INTEGRATE] Change 2416912 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/23 11:17:07 Added the ability for asset type actions to provide an extra overlay layer for their asset thumbnails UE-7970 - Add small 'play' button to EditorTutorial asset thumbnail Also cleaned up FAssetThumbnail::MakeThumbnailWidget so that it took a config struct (FAssetThumbnailConfig) rather than 7 or 8 defaulted parameters. [CL 2419655 by Ben Marsh in Main branch]
2015-01-26 19:57:37 -05:00
AssetTypeActions = AssetToolsModule.Get().GetAssetTypeActionsForClass(Class).Pin();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main) #rnx [CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
AssetTypeColorOverride = InArgs._AssetTypeColorOverride;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
AssetColor = FLinearColor::White;
Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main) #rnx [CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
if( AssetTypeColorOverride.IsSet() )
[INTEGRATE] Change 2427078 by Matt.Kuhlenschmidt@matt_kuhlenschmidt_main on 2015/01/31 12:24:27 Updated asset icons for basic shapes [CL 2435293 by Matthew Griffin in Main branch]
2015-02-06 09:06:21 -05:00
{
Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main) #rnx [CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
AssetColor = AssetTypeColorOverride.GetValue();
[INTEGRATE] Change 2427078 by Matt.Kuhlenschmidt@matt_kuhlenschmidt_main on 2015/01/31 12:24:27 Updated asset icons for basic shapes [CL 2435293 by Matthew Griffin in Main branch]
2015-02-06 09:06:21 -05:00
}
else if ( AssetTypeActions.IsValid() )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
[INTEGRATE] Change 2416912 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/23 11:17:07 Added the ability for asset type actions to provide an extra overlay layer for their asset thumbnails UE-7970 - Add small 'play' button to EditorTutorial asset thumbnail Also cleaned up FAssetThumbnail::MakeThumbnailWidget so that it took a config struct (FAssetThumbnailConfig) rather than 7 or 8 defaulted parameters. [CL 2419655 by Ben Marsh in Main branch]
2015-01-26 19:57:37 -05:00
AssetColor = AssetTypeActions->GetTypeColor();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
TSharedRef<SOverlay> OverlayWidget = SNew(SOverlay);
Fixed unloaded Blueprint components having the wrong icon UE-9331 - Missing icons for BP component classes when restarting editor Moved the code to work out the correct class icon for a Blueprint or asset data into FClassIconFinder so that it can be shared between the asset thumbnails and the components context menu. Added an extra IconClass member to FComponentClassComboEntry so that unloaded Blueprints can set this appropriately despite having a null ComponentClass. [CL 2451813 by Jamie Dale in Main branch]
2015-02-19 12:15:18 -05:00
UpdateThumbnailClass();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
AssetThumbnail - Get the class thumbnail from the ClassIconFinder so that it works with alternate styles. I'm not sure how much this class is actually used in the UI, but it does a lot of redundant work every frame in several different callback methods. If it's used a lot, it should probably get an optimization pass. TTP# 334639 [CL 2220983 by Frank Fella in Main branch]
2014-07-16 13:29:40 -04:00
ClassThumbnailBrushOverride = InArgs._ClassThumbnailBrushOverride;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
AssetBackgroundBrushName = *(Style.ToString() + TEXT(".AssetBackground"));
ClassBackgroundBrushName = *(Style.ToString() + TEXT(".ClassBackground"));
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
// The generic representation of the thumbnail, for use before the rendered version, if it exists
OverlayWidget->AddSlot()
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
.Padding(InArgs._Padding)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
[
Copying //UE4/Dev-Enterprise@4705006 to Dev-Main (//UE4/Dev-Main) #rb none #lockdown Nick.Penwarden [CL 4705151 by Francis Hurteau in Main branch]
2019-01-10 17:26:53 -05:00
SAssignNew(AssetBackgroundWidget, SBorder)
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
.BorderImage(GetAssetBackgroundBrush())
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
.Padding(GenericThumbnailBorderPadding)
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
.VAlign(VAlign_Center)
.HAlign(HAlign_Center)
.Visibility(this, &SAssetThumbnail::GetGenericThumbnailVisibility)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
[
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
SNew(SOverlay)
+SOverlay::Slot()
[
SAssignNew(GenericLabelTextBlock, STextBlock)
.Text(GetLabelText())
.Font(GetTextFont())
.Justification(ETextJustify::Center)
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
.ColorAndOpacity(FAppStyle::GetColor(Style, ".ColorAndOpacity"))
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
.HighlightText(HighlightedText)
]
+SOverlay::Slot()
[
SAssignNew(GenericThumbnailImage, SImage)
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
.DesiredSizeOverride(this, &SAssetThumbnail::GetGenericThumbnailDesiredSize)
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
.Image(this, &SAssetThumbnail::GetClassThumbnailBrush)
]
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
]
];
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
if ( InArgs._ThumbnailPool.IsValid() && !InArgs._ForceGenericThumbnail )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
ViewportFadeAnimation = FCurveSequence();
ViewportFadeCurve = ViewportFadeAnimation.AddCurve(0.f, 0.25f, ECurveEaseFunction::QuadOut);
TSharedPtr<SViewport> Viewport =
SNew( SViewport )
Usability improvements to foliage edit mode UI - Tools multibox laid out vertically to keep spacing constant and match the style of the Placement Mode UI - Formatting matches details panel - Added thumbnail view in addition to the tree - Can activate/deactivate types via double-click - Can collapse the details area - Selection modes have buttons for selection on ALL instances - Tooltips for filters are mode-specific - Activation toggle applies to all selected types when checked/unchecked #codereview Jack.Porter, Dmitriy.Dyomin [CL 2521566 by Dan Hertzka in Main branch]
2015-04-22 15:35:19 -04:00
.EnableGammaCorrection(false)
Merging //UE4/Private-Geometry to Dev-VREditor (//UE4/Dev-VREditor) 3339870 #rb Mike.Fricker [CL 3340396 by Lauren Ridge in Dev-VREditor branch]
2017-03-09 16:53:09 -05:00
// In VR editor every widget is in the world and gamma corrected by the scene renderer. Thumbnails will have already been gamma
// corrected and so they need to be reversed
.ReverseGammaCorrection(IVREditorModule::Get().IsVREditorModeActive())
SAssetThumbnail: Create the viewport for the thumbnail with the desired dimensions to fix problems with using SAssetThumbnail in a ListViewRow where the thumbnail desired height remained at 240 (=the default), stretching the row height in the process. #jira none #review-19847858 #preflight 6261550fdd47b4ad21aaffdf [CL 19899376 by wouter burgers in ue5-main branch]
2022-04-25 04:41:34 -04:00
.EnableBlending(true)
.ViewportSize(AssetThumbnail->GetSize());
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
Viewport->SetViewportInterface( AssetThumbnail.ToSharedRef() );
Usability improvements to foliage edit mode UI - Tools multibox laid out vertically to keep spacing constant and match the style of the Placement Mode UI - Formatting matches details panel - Added thumbnail view in addition to the tree - Can activate/deactivate types via double-click - Can collapse the details area - Selection modes have buttons for selection on ALL instances - Tooltips for filters are mode-specific - Activation toggle applies to all selected types when checked/unchecked #codereview Jack.Porter, Dmitriy.Dyomin [CL 2521566 by Dan Hertzka in Main branch]
2015-04-22 15:35:19 -04:00
AssetThumbnail->GetViewportRenderTargetTexture(); // Access the render texture to push it on the stack if it isn't already rendered
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
InArgs._ThumbnailPool->OnThumbnailRendered().AddSP(this, &SAssetThumbnail::OnThumbnailRendered);
InArgs._ThumbnailPool->OnThumbnailRenderFailed().AddSP(this, &SAssetThumbnail::OnThumbnailRenderFailed);
Fix for thumbnail rendering producing black or incorrect thumbnails #codereview Bob.Tellez [CL 2222597 by Martin Wilson in Main branch]
2014-07-17 16:05:37 -04:00
if ( ShouldRender() && (!InArgs._AllowFadeIn || InArgs._ThumbnailPool->IsRendered(AssetThumbnail)) )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
bHasRenderedThumbnail = true;
ViewportFadeAnimation.JumpToEnd();
}
// The viewport for the rendered thumbnail, if it exists
OverlayWidget->AddSlot()
[
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
SAssignNew(RenderedThumbnailWidget, SBorder)
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
.Padding(InArgs._Padding)
.BorderImage(FStyleDefaults::GetNoBrush())
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
.ColorAndOpacity(this, &SAssetThumbnail::GetViewportColorAndOpacity)
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
.HAlign(HAlign_Center)
.VAlign(VAlign_Center)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
[
Viewport.ToSharedRef()
]
];
}
[INTEGRATE] Change 2415497 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 13:33:05 Stopped derived types from UBlueprint being processed as if they were a BP class UE-7184 - Show game c++ classes and engine c++ classes in the content browser Also renamed "ClassAssetClass" to "ThumbnailClass" to better reflect its purpose. [CL 2419545 by Ben Marsh in Main branch]
2015-01-26 19:07:07 -05:00
if( ThumbnailClass.Get() && bIsClassType )
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
{
OverlayWidget->AddSlot()
.VAlign(VAlign_Bottom)
.HAlign(HAlign_Right)
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
.Padding(GetClassIconPadding())
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
[
SAssignNew(ClassIconWidget, SBorder)
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
.BorderImage(FAppStyle::GetNoBrush())
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
[
SNew(SImage)
.Image(this, &SAssetThumbnail::GetClassIconBrush)
]
];
}
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
if( bAllowHintText )
{
OverlayWidget->AddSlot()
.HAlign(HAlign_Center)
.VAlign(VAlign_Top)
.Padding(FMargin(2, 2, 2, 2))
[
SNew(SBorder)
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
.BorderImage(FAppStyle::GetBrush(Style, ".HintBackground"))
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
.BorderBackgroundColor(this, &SAssetThumbnail::GetHintBackgroundColor) //Adjust the opacity of the border itself
.ColorAndOpacity(HintColorAndOpacity) //adjusts the opacity of the contents of the border
.Visibility(this, &SAssetThumbnail::GetHintTextVisibility)
.Padding(0)
[
SAssignNew(HintTextBlock, STextBlock)
.Text(GetLabelText())
.Font(GetHintTextFont())
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
.ColorAndOpacity(FAppStyle::GetColor(Style, ".HintColorAndOpacity"))
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
.HighlightText(HighlightedText)
]
];
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
// The asset color strip
Asset labels in the content browser can now fill beyond the width of the thumbnails. The font has also been reduced in size to reduce the amount of wrapping on asset labels at small sizes. Also polished the asset borders and shadows. This addresses TTP 345457 and 345452. [CL 2297910 by Andrew Rodham in Main branch]
2014-09-15 05:59:46 -04:00
OverlayWidget->AddSlot()
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
.HAlign(ColorStripOrientation == EThumbnailColorStripOrientation::HorizontalBottomEdge ? HAlign_Fill : HAlign_Right)
.VAlign(ColorStripOrientation == EThumbnailColorStripOrientation::HorizontalBottomEdge ? VAlign_Bottom : VAlign_Fill)
Asset labels in the content browser can now fill beyond the width of the thumbnails. The font has also been reduced in size to reduce the amount of wrapping on asset labels at small sizes. Also polished the asset borders and shadows. This addresses TTP 345457 and 345452. [CL 2297910 by Andrew Rodham in Main branch]
2014-09-15 05:59:46 -04:00
[
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
SAssignNew(AssetColorStripWidget, SBorder)
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
.BorderImage(FAppStyle::GetBrush("WhiteBrush"))
Asset labels in the content browser can now fill beyond the width of the thumbnails. The font has also been reduced in size to reduce the amount of wrapping on asset labels at small sizes. Also polished the asset borders and shadows. This addresses TTP 345457 and 345452. [CL 2297910 by Andrew Rodham in Main branch]
2014-09-15 05:59:46 -04:00
.BorderBackgroundColor(AssetColor)
.Padding(this, &SAssetThumbnail::GetAssetColorStripPadding)
];
fixed check() triggering #code_review: jamie.dale [CL 2421258 by Martin Mittring in Main branch]
2015-01-27 18:15:48 -05:00
if( InArgs._AllowAssetSpecificThumbnailOverlay && AssetTypeActions.IsValid() )
[INTEGRATE] Change 2416912 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/23 11:17:07 Added the ability for asset type actions to provide an extra overlay layer for their asset thumbnails UE-7970 - Add small 'play' button to EditorTutorial asset thumbnail Also cleaned up FAssetThumbnail::MakeThumbnailWidget so that it took a config struct (FAssetThumbnailConfig) rather than 7 or 8 defaulted parameters. [CL 2419655 by Ben Marsh in Main branch]
2015-01-26 19:57:37 -05:00
{
// Does the asset provide an additional thumbnail overlay?
TSharedPtr<SWidget> AssetSpecificThumbnailOverlay = AssetTypeActions->GetThumbnailOverlay(AssetData);
if( AssetSpecificThumbnailOverlay.IsValid() )
{
OverlayWidget->AddSlot()
[
AssetSpecificThumbnailOverlay.ToSharedRef()
];
}
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
ChildSlot
[
OverlayWidget
];
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
UpdateThumbnailVisibilities();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Fixed unloaded Blueprint components having the wrong icon UE-9331 - Missing icons for BP component classes when restarting editor Moved the code to work out the correct class icon for a Blueprint or asset data into FClassIconFinder so that it can be shared between the asset thumbnails and the components context menu. Added an extra IconClass member to FComponentClassComboEntry so that unloaded Blueprints can set this appropriately despite having a null ComponentClass. [CL 2451813 by Jamie Dale in Main branch]
2015-02-19 12:15:18 -05:00
void UpdateThumbnailClass()
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
{
Fixed unloaded Blueprint components having the wrong icon UE-9331 - Missing icons for BP component classes when restarting editor Moved the code to work out the correct class icon for a Blueprint or asset data into FClassIconFinder so that it can be shared between the asset thumbnails and the components context menu. Added an extra IconClass member to FComponentClassComboEntry so that unloaded Blueprints can set this appropriately despite having a null ComponentClass. [CL 2451813 by Jamie Dale in Main branch]
2015-02-19 12:15:18 -05:00
const FAssetData& AssetData = AssetThumbnail->GetAssetData();
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3805092) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3623004 by Ben.Marsh Fix RemoteExecutor not taking the remote machine specs into account. Change 3623172 by Ben.Marsh UGS: Fix "More Info..." button not using P4 server override. Change 3628820 by Ben.Marsh PR #3979: Get working directory from task element, not tool node (Contributed by nullbus) Change 3630424 by Graeme.Thornton Make the AES key parameter const in FAES::EncryptData() Change 3632786 by Steve.Robb FString constructor fixed to not take an ignored void* parameter, which can be misleading. Change 3639534 by Ben.Marsh Remove old P4.NET library. Doesn't seem to be used by anything. Change 3640536 by Steve.Robb GitHub #4007 : Delete unnecessary specialization of MakeArrayView #jira UE-49617 Change 3641155 by Gil.Gribb UE4 - Speculative fix for problem with summary reading in FAsyncArchive2. Change 3643932 by Ben.Marsh Add an example build script for updating the version number, then compiling and staging the editor and tools to an output directory. Optionally submits at the end (requires -Submit argument). Change 3644825 by Ben.Marsh Use VSWHERE to find the location of MsBuild.exe, if available. https://github.com/EpicGames/UnrealEngine/pull/3879#issuecomment-329688645 Change 3647395 by Ben.Marsh Allow compiling of monolithic binaries from BuildEditorAndTools.xml, using the -set:GameTarget=FooGame -set:TargetPlatforms=Win32;Win64 options. Change 3650300 by Ben.Marsh UAT: Remove code that deletes cooked data on a failed cook. The engine should write packages out transactionally now (by writing to a temporary file and moving into place), and deleting the cooked data just prevents post-mortem analysis. Change 3650856 by Robert.Manuszewski Adding checks to prevent FlushAsyncLoading and LoadObject/LoadPackage from being called from any threads other than the game thread Change 3651022 by Gil.Gribb UE4 - Possible fix for mysterious ensure indicating problematic recursion in the pak precacher. Change 3658331 by Steve.Robb Fix for the parsing of large integer values. Change 3661958 by Gil.Gribb UE4 - Fixed rare hang in task graph. Change 3664021 by Robert.Manuszewski Fix for a potential GC crash caused by stale pointer in AnimInstanceProxy See https://udn.unrealengine.com/questions/392432/gc-issue-uaniminstancemontageinstances-empty-but-u.html Change 3664254 by Steve.Robb Use ANSI allocator when thread sanitizer is enabled. This allows the generation of more accurate and meaningful reports. Change 3664436 by Steve.Robb Use TUniquePtr instead of a thread-unsafe TSharedPtr to move data between threads. Change 3666461 by Graeme.Thornton Improvements to signing/encryption key embedding and runtime access - Changed method of embedding key into the executable to make it more secure - Added FAESKey class to wrap a 32 byte key Change 3666462 by Graeme.Thornton Cut ShooterGame AES key down to 32 characters Change 3677560 by Ben.Marsh PR #4074: UBT: Add include and library-related fields to module JSON output (Contributed by adamrehn) Change 3683534 by Steve.Robb Refactoring of enum/struct lookup during hot reload. Change 3683754 by Steve.Robb Alignment fixes to allow int64 on 32-bit platforms Support for integral types in IsAligned. Static asserts so that alignment functions will no longer be called with non-intergal, non-pointer types. Some fixes to existing code. Change 3686670 by Steve.Robb Fix for thread-unsafe modification of static array in FString::ParseIntoArrayWS. Change 3687540 by Ben.Marsh Fix all UBT/UAT output going to stderr rather than stdout. Change 3688931 by Gil.Gribb UE4 - Critical fix for a rare race condition in the pak file async IO layer. Change 3690000 by Graeme.Thornton Manual copy of 4.18 CL 3687869 Make UBT include the destination INI file for a given hierarchy if it exists Renamed VSCode enum value to VisualStudioCode, so it matches the source accessor plugin name Change 3690030 by Graeme.Thornton VSCode fixes - Source Code Accessor plugin changes. Add new interface method to open a solution at a given path - GameProjectUtils now uses the source navigation API to open solutions rather than hardcoding which solution file types to look for - Various fixes for vscode project file generation #jira UE-50554 Change 3690885 by Steve.Robb Atomic reads in FReferenceControllerOps<ESPMode::ThreadSafe>. Change 3691052 by Steve.Robb Free stats thread on shutdown. Change 3695138 by Steve.Robb AsConst helper function added. Change 3696627 by James.Hopkin Changed player controller iterator typedefs to use TWeakObjectPtr rather than the deprecated TAutoWeakObjectPtr (review-3606695) Change 3697099 by Steve.Robb GitHub #4105 : Removed redundant class access modifier Change 3697154 by Steve.Robb Removal of deprecated functions in delegates. Mutable lambdas to can now be bound to delegates. Change 3697180 by Steve.Robb GitHub #4115 : Incorrect CPPMacroType used for USoftClassProperty Change 3697239 by Steve.Robb Allow TArray::Insert to take an array with any allocator type. Change 3697269 by Steve.Robb RelocateConstructItems instead of MoveConstructItems. Change 3697558 by Steve.Robb New _GetRef functions for TArray, which return a reference to the newly-added element. Unit tests for these functions. Change 3699776 by Steve.Robb TSAN warning suppression around IAsyncReadRequest::bCompleteAndCallbackCalled. Change 3702397 by Steve.Robb TIsTrivial type trait. Change 3702569 by Steve.Robb Allow a TGuardValue to be assigned to a different type from the one being guarded. Change 3706644 by Robert.Manuszewski Different stack ingore count for development builds for FArchiveStackTrace Change 3709272 by Steve.Robb Removal of redundant UpdateVertices, which causes a race condition on the renderer thread. Change 3709452 by Robert.Manuszewski Fixed a bug where with async time limit set to a low value the async loading could hang because the linker would keep reloading the preload dependencies Change 3709454 by Robert.Manuszewski Added command line option -NOEDL to disable EDL Change 3709487 by Steve.Robb Remove use of PLATFORM_HAS_64BIT_ATOMICS, which is always 1. Change 3709645 by Ben.Marsh Fix race condition between multiple instances of UBT trying to write out the XML config cache. Change 3711193 by Ben.Marsh Add an editor setting for the shared DDC location to use. #jira UE-51487 Change 3713811 by Steve.Robb Update .modules files after a hot reload. Don't check for directory timestamp changes as a way of detecting new files if hot reloading with a makefile, as this is already done during makefile invalidation checks. Pass hotreload flags around in UBT instead of relying on global state. This fixes the hot reload iteration speed regression without also regressing the fix to UE-42205. #jira UE-51472 Change 3715654 by Steve.Robb GitHub #4156 : Fixed not compiling template function Algo::UpperBoundBy. Change 3718782 by Steve.Robb TSharedPtr, TSharedRef and TWeakPtr assignment are now implemented as copy-and-swap to avoid an invalid smart pointer state being visible to any destructors being called. Change 3720830 by Steve.Robb Initial import of TAtomic object wrapper, which guarantees atomic access to an object. Change 3720881 by Steve.Robb FCompression ThreadSanitizer data race fixes. Change 3722640 by Graeme.Thornton Guard network platform file heartbeat function with the socket critical section. Stop heartbeat from causing a crash when firing during async loading. #jira UE-51463 Change 3722655 by Steve.Robb Don't null name table because it's already zeroed at startup. Some tidy-ups. Change 3722754 by Steve.Robb Thread sanitizer fix. Small typo fix. Change 3722849 by Graeme.Thornton Improve "caching file" message in networkplatformfile so it says "Requesting file..." and is only output when we actually request the file from the server Change 3723081 by Steve.Robb TAtomic is now aligned to the underlying integer type. TAtomic will now static assert with a better error message when given an unsupported type. Define added for the maximum platform-supported atomic type, and used instead of a (wrong) hardcoded number. Misc renames. Change 3723270 by Ben.Marsh Include /d2cgsummary argument when running UBT with -Timing. Change 3723683 by Ben.Marsh Do not include documentation in the generated project files by default. Suspect that the 30,000 UDN files that get added to the solution take up memory and degrate performance. Change 3725422 by Robert.Manuszewski When serializing compressed archive with multithreaded compression enabled, wait for the oldest async task instead of spinning. Change 3725735 by Robert.Manuszewski Making all CheckDefaultSubobjects related functions const Change 3726167 by Steve.Robb FMinimalName::IsNone added. Change 3726458 by Steve.Robb TAtomic will no longer instantiate for types which are not exactly a size supported by the platform layer. Change 3726542 by Ben.Marsh UGS: Always include the project filename in the editor build command. The project may not be in one of the .uprojectdirs paths. Change 3726595 by Ben.Marsh Allow building multiple game targets in the example BuildEditorAndTools.xml script. Change 3726724 by Ben.Marsh Fix ambiguities in calculating root directory. (GitHub #4172) Change 3726959 by Ben.Marsh Make sure that AutomationTool uses the same list of preprocessor definitions when compiling *.target.cs files as UnrealBuildTool does. Change 3728437 by Steve.Robb VisitTupleElements now supports invocation of a functor taking arguments from multiple tuples in parallel. Some improved documentation. NOTE: This is a backward-incompatible change to VisitTupleElements. Any existing calls will need their arguments swapping. Change 3732262 by Gil.Gribb UE4 - Fixed rare hangs in the task graph. Change 3732755 by Steve.Robb Stats TSAN fixes. Optimizations to FCycleCounter::Start() to only read the stat name once. Change 3735000 by Robert.Manuszewski Always preload the AssetRegistry module on startup. even if EDL is disabled. Even without EDL, if the async loading thread is enabled the AssetRegistryModule will otherwise be loaded from the ASL thread and that will assert. Change 3735292 by Robert.Manuszewski Made sure component visualizer is removed from VisualizersForSelection when UnregisterComponentVisualizer() is called otherwise it may cause crashes when the engine terminates. Change 3735332 by Steve.Robb Refactoring of UDelegateProperty::Identical() to clarify logic. Fixed UMulticastDelegateProperty::Identical() to compare the bound function names. PPF_DeltaComparison removed, as it doesn't seem useful. Change 3737960 by Graeme.Thornton VSCode - Add launch task for generating project files for the given folder Change 3738398 by Graeme.Thornton Make Visual Studio source code accessor's module hotreload handler pass the 'save all files' message to the current accesor, rather than direct to the visual studio accessor #jira UE-51451 Change 3738405 by Graeme.Thornton VSCode: Format c/cpp settings strings using comment path formatting function Change 3738928 by Steve.Robb Fix for lack of null conditional operators in some older Monos. (replicated from CL# 3729574 in Release-4.18) #jira UE-51842 Change 3739135 by Ben.Marsh Fix being unable to package projects in a folder called "Wolf". This is only a restricted folder for Epic's Perforce history. #jira UE-51855 Change 3739360 by Ben.Marsh UAT: Fix issue with P4PORT setting not being parsed correctly. Change 3745959 by James.Hopkin #core Added ImplicitConv for safe upcasts to a specific required type, e.g. deduced delegate payload types Change 3746125 by Steve.Robb FName ThreadSanitizer fixes. Change 3747274 by Steve.Robb TSAN fix for FMediaTicker::Stopping. Change 3747618 by Steve.Robb ThreadSanitizer data race fix for FShaderCompileThreadRunnableBase::bForceFinish. Change 3747720 by Steve.Robb ThreadSanitizer fix for FMessageRouter::Stopping. Change 3749207 by Graeme.Thornton First pass of CryptoKeys plugin. Allows creation/editing/cycling of AES/RSA keys. Change 3749323 by Graeme.Thornton Fix UAT crash when only -targetplatform is specifiied Change 3749349 by Steve.Robb TSAN_SAFE guards around LockFreeList to silence ThreadSanitizer. Change 3749617 by Steve.Robb Logf static_assert for formatting string enabled. Change 3749897 by Steve.Robb FDebug::LogAssertFailedMessage static assert for formatting string enabled. Change 3754011 by Steve.Robb Static asserts that the allocator supports move. Move-enabled our allocators which don't support move. Change 3754227 by Ben.Marsh Fix build command line in generated projects missing a space before the compiler version override. #jira UE-52226 Change 3754562 by Ben.Marsh PR #4206: Replace deprecated wsprintf with secure swprintf for Bootstrap executable (Contributed by jessicafalk) Change 3755616 by Graeme.Thornton Runtime code for using the new crypto ini files to define signing/encryption keys #jira UE-46580 Change 3755666 by James.Hopkin Used ImplicitConv to remove Casts being used for up-casts #review-3745965 Change 3755671 by Graeme.Thornton Add log message in unrealpak to say which config file system it is using for crypto keys Change 3755672 by Graeme.Thornton Updating ShooterGame with new CryptoKeys based security setup Change 3756778 by Ben.Marsh Add support for running multiple jobs simultaneously on a single builder. When running job or agent setup, the --num-slots=X parameter defines the number of steps that can run simultaneously (EC procedures pass in the resource step limit). A lock file is created under the workspace root (D:\Build) and a reservation file is created for the first slot that can be allocated (slot-1, slot-2, etc...). The slot number is used to define the workspace name that should be used. Change 3758498 by Ben.Marsh Re-throw exceptions when a file cannot be deleted when cleaning a target. Change 3758921 by Steve.Robb ThreadSanitizer fix to FThreadSafeStaticStatBase::HighPerformanceEnable to do a relaxed atomic load on access. DoSetup() now returns the newly-allocated pointer, instead of reloading it from memory. Change 3760599 by Graeme.Thornton Added missing epic header comment to some new source files Change 3760642 by Steve.Robb ThreadSanitizer fix for concurrent access to GMainThreadBlockedOnRenderThread. Change 3760669 by Graeme.Thornton Improvement to OpenSSL based signing key generator. Generate a full RSA key then steal the primes from it, rather than generating the primes manually. Added a test mode to the cryptokeys commandlet to test signing key generation Change 3760711 by Steve.Robb ThreadSanitizer fixes to GIsRenderingThreadSuspended. Change 3760739 by Steve.Robb ThreadSanitizer fix for FQueuedThread::TimeToDie. Change 3760763 by Steve.Robb ThreadSanitizer fix for GRunRenderingThreadHeartbeat. Removal of unnecessary/dangerous initializer for GMainThreadBlockedOnRenderThread. Change 3760793 by Steve.Robb Some simple refactoring to remove some volatile reads of BufferStartPos and BufferEndPos. Change 3760817 by Steve.Robb ThreadSanitizer fixes for FAsyncWriter::BufferStartPos and BufferEndPos. Change 3761331 by Josh.Engebretson UnrealBuildTool enforcement of Development and Debug configurations in existing .csproj #jira UE-52416 Change 3761521 by Steve.Robb ThreadSanitizer fixes for FEvent::EventStartCycles and EventUniqueId. Change 3763117 by Graeme.Thornton PR #3722: Optimising FPaths::IsRelative() (Contributed by jovisgCL) Change 3763358 by Graeme.Thornton Ensure that all branches within FGenericPlatformMisc::RootDir() produce an absolute path with no duplicate slashes Remove relative->abs conversion of root dir from FPaths::MakeStandardFilename(), now that we know RootDir() always returns an absolute path Derived from the content of this PR: PR #3742: Treat RootDirectory the same way as Standardized (Contributed by TroutZhang) Change 3764058 by Graeme.Thornton Generate a .code-workspace file for the current workspace. Allows foreign projects to "mount" the UE4 folder so that the engine tasks are avaible, and all engine source is visible to VSCode for searching purposes #jira UE-52359 Change 3764705 by Steve.Robb Better handling of whitespace in ImportText_Internal() for set and map properties. Containers are now emptied upon import failure, to avoid leaving bad container states (unhashed, partial data). Fix to USetProperty's temp buffer size to avoid buffer overruns. Duplicate map keys are now skipped during import, same as USetProperty's behavior. Change 3764731 by Steve.Robb Don't re-run UHT if only source files have changed in the same folder as headers. This was already done for hot reload, but there's no reason why it should be limited to that. Change 3765923 by Graeme.Thornton VSCode - "taskName" -> "label" for C# build tasks Change 3766018 by Steve.Robb constexpr constructor for TAtomic. Change 3766037 by Steve.Robb Misc tidyings in HotReload.cpp. Change 3766046 by Steve.Robb ThreadSanitizer fixes to ENamedThreads::RenderThread and ENamedThreads::ENamedThreads_Local. Change 3766288 by Steve.Robb Improved efficiency of adding/removing elements to UGCObjectReferencer::ReferencedObjects. Change 3766374 by Josh.Engebretson Fix issue with ini quoted value comparison #jira UE-52066 Change 3766532 by Josh.Engebretson PR #3680: Added NetSerialize to FDateTime fixing UE-22533 (Contributed by druhasu) #jira UE-46156 Change 3766740 by Steve.Robb TMultiMap::Append added. Change 3767523 by Steve.Robb ThreadSanitizer fix for UE4Delegates_Private::GNextID. Change 3767601 by Steve.Robb ThreadSanitizer fix for FStats::GameThreadStatsFrame. Change 3770567 by Ben.Marsh Add a FAnnotatedArchiveFormatter interface which allows querying structural type information that may not be in binary archives. Change 3770826 by Ben.Marsh Move StructuredArchive implementation into Core, so primitive types can implement serialization overloads for it. Change 3770875 by Steve.Robb Redundant UScriptStruct::PostLoad removed, which was causing a race condition in async loading. This was re-establishing the CppStructOps, but that is unnecessary because native classes cannot change as a result of a load - only BP structs can, and they don't have CppStructOps. Change 3772167 by Ben.Marsh Add a context-free binary formatter that can serialize tagged data. This functions as a lower-overhead binary intermediate format for JSON data. Change 3772248 by Steve.Robb ThreadSanitizer fixes to FMalloc call counters. Change 3772383 by Ben.Marsh Separate archive metadata from FArchive into FArchiveContext, so it can be safely exposed to consumers of FStructuredArchive. Change 3772906 by Graeme.Thornton TextAssetCommandlet - Utility commandlet for testing/converting to text asset format Change 3772932 by Ben.Marsh Fix "String:" prefix not being stripped from escaped string values. Change 3772942 by Graeme.Thornton Add experimental setting to enable in-editor text asset format functionality Add "export to text" option into the content browser asset actions context menu Change 3772955 by Ben.Marsh Add a new "stream" compound type to FStructuredArchive, which allows serializing a sequence of elements similarly to an array, but without serializing an explicit size. Allows passing through data to an underlying binary archive without breaking compatibility. Change 3772963 by Ben.Marsh Allow querying record keys and stream lengths from annotated archive formatters, since these archives have markup for field boundaries. Change 3773010 by Graeme.Thornton Added CORE_API to FArchiveFromStructuredArchive Gave text asset format experimental option a slightly less random tooltip comment Change 3773057 by Ben.Marsh Add a flag to FArchive to determine whether the archive is text (IsTextFormat()). Add support for seeking within FArchiveFromStructuredArchive. For text formats, data is serialized to an in-memory buffer, with names and objects serialized as indices into an array. For non-text formats, data is serialized directly to the underlying archive. Also rename FStructuredArchive::TryEnterSlot() to TryEnterField(). Change 3773118 by Steve.Robb TSignedIntType and TUnsignedIntType type traits for getting an integer type of a given size. Change 3773122 by Steve.Robb TAtomic fixes for pointer arithmetic. TSignedIntType used instead of reimplementing its own trait. Change 3773123 by Steve.Robb Unit tests for TAtomic. Change 3773138 by Steve.Robb Run numeric tests on integer types instead of basic tests. Fix for compiler warnings when subtracting from unsigned atomics. Change 3773166 by Steve.Robb Refactoring of arithmetic operations into its own class, then basing the pointer and integral versions on that. Change 3774216 by Gil.Gribb UE4 - Fix rare crash in the pak precacher immediately after unmounting a pak file. Change 3774426 by Ben.Marsh Copy all C# tools to a staging directory before compiling them. This prevents access violations when compiling tools like iPhonePackager that reference DotNETCommon, and ensures we strip NotForLicensees folders out of them all. See: https://answers.unrealengine.com/questions/726010/418-will-not-build-from-source.html Change 3774658 by Ben.Marsh Improve error reporting while generating intellisense for project files. Include the name of the target being compiled, and allow project file generation to continue without it. Change 3775141 by Ben.Marsh Always output HTML5 diagnostics at "information" verbosity, to avoid every line being prefixed with "WARNING:" and screwing up the EC postprocessor. Change 3775459 by Ben.Marsh Removing .NET Framework Perforce DLL as runtime dependency of engine third party library. The actual library is linked statically. Change 3775522 by Ben.Marsh UGS: Treat .uproject and .uplugin files as code changes. Change 3775597 by Ben.Marsh Fix post-build steps for plugins not being executed. #jira UE-52754 Change 3777895 by Graeme.Thornton StructuredArchiveFromArchive - An adapter class for wrapping an existing FArchive with a structured archive Change 3777931 by Graeme.Thornton Refactored FArchiveUObjects serialization code into some static helpers Added FArchiveUObjectFromStructuredArchive which allows the adaption of a structured archive into an FArchive that supports the extra UObect serialization functions for weak/soft pointers Change 3777942 by Graeme.Thornton Added missing CORE_API to FStructuredArchive::FStream Added FStructuredArchive::FSlot insertion operator for char Added specialization of TArray<uint8> serializer for structured archives which serializes the contents as one value Change 3778084 by Graeme.Thornton Adding FPackageName::GetTextAssetPackageExtension() to access the file extension we use for text asset files Change 3778096 by Graeme.Thornton Add a constructor to FArchiveUObjectFromStructuredArchive that takes a slot and passes it to the base class Change 3778389 by Josh.Engebretson Fix an optimization issue with CPU benchmarking Add better support for debugging/testing local rocket builds UDN Link: https://udn.unrealengine.com/questions/400909/command-scalability-auto-gives-inaccurate-cpu-benc.html #jira UE-52192 Change 3778701 by Josh.Engebretson Ensure plugin content folders are mounted consistently. Fixes TryConvertFilenameToLongPackageName failing to work on plugin assets UDN Link: https://udn.unrealengine.com/questions/276386/tryconvertfilenametolongpackagename-fails-for-plug.html #jira UE-40317 Change 3778832 by Chad.Garyet Adding enterprise path support for PCB's for UGS Change 3780258 by Graeme.Thornton TextAssetCommandlet - Accumulate timings for loading packages and saving packages Change 3780463 by Graeme.Thornton CryptoKeys improvements - Enable CryptoKeys plugin by default - Attempt to inherit settings from the old system by default - Hide ini/index encryption settings from packaging settings and just inherit previous values into new system Minor UBT change to remove a trailing comma from the end of encryption/signing key binary strings Change 3780557 by Ben.Marsh Fix LoginFlow module not being precompiled for the binary release. Change 3780846 by Josh.Engebretson Improve filename to long package name resolution when provided a relative path Change 3780863 by Ben.Marsh UAT: Add a better error message when a C# project has an invalid reference. Change 3780911 by Ben.Marsh Update the BuildEditorAndTools.xml script to allow submitting archived binaries to Perforce. The "Submit To Perforce For UGS" node creates a zip of all the binaries that have been built, and submits it to the stream specified by the 'ArchiveStream' argument. Change 3780956 by Josh.Engebretson Add support for ! (RemoveKey) config command to UBT UDN Link: https://udn.unrealengine.com/questions/397267/index.html #jira UE-52033 Change 3782957 by Robert.Manuszewski UE4 - Fixed a linear search in EDL that caused performance problems for very large maps. Change 3784503 by Ben.Marsh Optimizations for FStructuredArchive: * Store the depth explicitly in element objects, to avoid having to loop through the scope stack to find it. * Prevent shrinking of arrays when removing elements. * Add an inline allocator to the scope and container stacks. Change 3784700 by Ben.Marsh Remove the inline allocator from FStructuredArchive; checking whether the inline or backup allocator is being used is slower than just allocating up-front. Change 3784989 by Ben.Marsh Compile out all the FStructuredArchive validation code when WITH_TEXT_ARCHIVE_SUPPORT = 0. Change 3786860 by Gil.Gribb UE4 - Remove no buffering flag from windows async IO because it disabled the disk cache entirely. Change 3787159 by Ben.Marsh Guard against UE4.0 backwards compatibility path when determining if an engine is a source distribution. Change 3787493 by Josh.Engebretson Parallel pak generation now uses MaxDegreeOfParallelism option which is now set to the number of CPU cores Moved cryptography settings parsing out of threaded CreatePak method to avoid concurrency issue in ConfigCache.TryReadFile Fix for multiple threads parsing ini keys (PR 3995) #PR 3995 #jira 52913 #jira 49503 Change 3787773 by Steve.Robb Fix for missing final values from FOREACH_ENUM_ macros. Change 3788287 by Ben.Marsh TBA: Add checks in debug builds that key names in maps and records for FStructuredArchive are unique. Change 3788678 by Ben.Marsh Fix compile error due to inability to instantiate TArray<> of forward declared struct. Convert set of key names to an array to avoid including Set.h in public header for FStructuredArchive. Change 3789353 by Graeme.Thornton Removed unused/rotten modes from TextAsset commandlet. Used existing "-iterations=n" switch to control a global iteration over the given command. Useful for performance testing. Change 3789396 by Ben.Marsh Move code to validate container keys/sizes into DO_GUARD_SLOW checks, and allocate container metadata instances dynamically to fix problems with references to things not declared in headers that can't be included from StructuredArchive.h Change 3789772 by Ben.Marsh Always strip trailing slashes from the end of paths specified by .build.cs files; they can cause quoted paths to be escaped on the command line. Change 3790003 by Ben.Marsh TBA: Rename FStructuredArchive::EElementType::Object to FStructuredArchive::EElementType::Record. Change 3790051 by Steve.Robb PIE is disabled during a hot reload. Hot reload in editor is disabled during PIE. Hot reload from IDE is deferred until after PIE is exited. Compiling multiple times before a hot reload (e.g. compiling multiple times in PIE) will now load the most recent change. #jira UE-20357 #jira UE-52137 Change 3790709 by Steve.Robb Better move support for TVariant. EVariantTypes switched over to using an enum class to aid debugger visualization. Change 3791422 by Ben.Marsh TBA: Return the type of a field from an annotated archive formatter at the point that we enter it, rather than querying all the time. Change 3791489 by Graeme.Thornton TBA: Change StructuredArchiveFromArchive adapter to use the archive.Open() result directly, now that it's a slot and not a record Change 3792344 by Ben.Marsh Improvements to base64 encoding library. * Now supports encoding and decoding with ANSICHAR and WIDECHAR implementations. * Added support for decoding base-64 blobs without padding marks. * Added support for decoding into pre-allocated buffer. * Added constexpr functions for determining the encoded and maximum decoded size of an input buffer. * Prevent writes past the end of allocated buffer (no longer need to manually remove padding bytes). Change 3792949 by Ben.Marsh TBA: Rename FAnnotatedArchiveFormatter to FAnnotatedStructuredArchiveFormatter. Change 3794078 by Robert.Manuszewski Fixing a crash that could happen when FGCObjects were constructed and destructed when shutting down the engine #jira UE-52392 Change 3794413 by Ben.Marsh TBA: Remove the element type parameter to SetScope(). It isn't really needed; we can just assume the element ID correctly identifies the item on the stack. Change 3794731 by Ben.Marsh TBA: Optimize creation of stack elements for empty slots in FStructuredArchive. This saves a lot of bookkeeping when serializing a large number of individual fields. Since only one slot can be active at a time (and it only exists temporarily, until we write into it), we can just store the element ID assigned to it in a member variable. Change 3795081 by Ben.Marsh UBT: Move LinuxCommon.cs into Platform/Linux folder. Change 3795137 by Ben.Marsh UBT: Allow modules to specify private compiler definitions from the build.cs file, only visible within that module (via the "PrivateDefinitions" property). Change 3795247 by Ben.Marsh Fix missing header when creating a new interface from the editor new code wizard. #jira UE-53174 Change 3796025 by Graeme.Thornton Fixed some deprecated "Definitions" warnings in OpenCV build files Change 3796103 by Graeme.Thornton Disable experimental text asset option - it does nothing useful yet. Change 3796157 by Graeme.Thornton Fix path type mismatch in visual studio source code accessor meaning that the DTE comms wouldn't identify a running instance of VS as having the current solution open. #jira UE-53206 Change 3796315 by Ben.Marsh Move Formatter to the correct position for initializer. #jira UE-53208 Change 3797082 by Ben.Marsh UAT: Work around for exception thrown by launching cook with "-platform=Android_ETC1 -targetplatform=Android -cookflavor=ETC1". Anrdoid_ETC1 is not a valid platform (it's a cook platform), and can't be parsed by UAT. #jira UE-53232 Change 3799050 by Ben.Marsh Make UnrealPak.version files writable for Mac and Linux. Change 3801012 by Graeme.Thornton VSCode - Update source accessor to use code workspace as it's target, rather than just the project directory Change 3801214 by Gil.Gribb UE4 - Remove assert to work around minor problem with lock free lists. #jira UE-49600 Change 3801219 by Steve.Robb WeakObjectPtrs now warn when casting away const. Change 3801299 by Graeme.Thornton Fix quote issue with foreign project build tasks on PC Change 3803292 by Graeme.Thornton Fix crash on startup when using cook-on-the-side. Force a flush of the asset registry background scanning when creating the cook-on-the-side platform registries Change 3803559 by Steve.Robb TSAN fix for FMalloc::MaxSingleAlloc. Change 3803735 by Graeme.Thornton Last set of cryptokeys changes - Added some comments for editor exposed settings - Split "encrypt assets" option into "encrypt uassets" and "encrypt all assets" Change 3803929 by Ben.Marsh UGS: Show an in-place error panel when a project fails to open, allowing the user to retry and have their tabs saved instead of creating a modal dialog. Change 3624590 by Steve.Robb AddReferencedObjects now generates a compile error with containers of UObject*s where the UObjectType is forward-declared, as these which won't be added to the reference collector. Tidy-up of existing calls to AddReferencedObjects. Change 3629473 by Ben.Marsh Build: Rename the option for embedding source server information in PDB files for installed engine builds. Change 3632894 by Steve.Robb VARARG* macros deprecated and usage replaced with variadic templates. Change 3640704 by Steve.Robb MakeWeakObjectPtr added, which deduces a TWeakObjectPtr type from a raw pointer type. Fix to TWeakObjectPtr's constructor which implicitly removed const. Fixes to everything which didn't compile as a result. Change 3650813 by Graeme.Thornton Removed FStartupPackages and associated code Change 3651000 by Ben.Marsh Return the stack size from FPlatformStackWalk::CaptureStackBacktrace() rather than checking for the first null pointer, to prevent truncated callstacks if parts of the stack are zeroed out. #jira UE-49980 Change 3690842 by Steve.Robb FPlatformAtomics::AtomicRead added - needs optimizing. AtomicRead() used in FThreadSafeCounter::GetValue(). Change 3699416 by Steve.Robb Fix to debugger visualization of TArray with a TInlineAllocator or TFixedAllocator. Improved readability of TSparseArray visualization. Change 3720812 by Steve.Robb Atomic functions for 8-bit and 16-bit. Android, Linux and Switch implementations now just use the Clang implementation. AtomicRead64 deprecated in favor of the int64* AtomicRead overload. Change 3722698 by Steve.Robb VS debugger visualizers for TAtomic. Change 3732270 by Steve.Robb Relaxed stores and loads. Change 3749315 by Graeme.Thornton If UAT is invoked with platforms in both the -platform and -targetplatform command line switches, build using all of them rather than just the ones in -targetplatform #jira UE-52034 Change 3750657 by Josh.Engebretson Fixed issue when debugging editor cook/package and project launch operations #jira UE-52207 Change 3758514 by Steve.Robb Fixes to FString::Printf having non-literals being passed as its formatting string. Change 3763356 by Steve.Robb ENamedThreads::RenderThread and ENamedThreads::RenderThread_Local encapsulated by getters and setters. Change 3770549 by Steve.Robb Removal of obsolete PLATFORM_COMPILER_HAS_DEFAULTED_FUNCTIONS and PLATFORM_COMPILER_HAS_AUTO_RETURN_TYPES. Tidy up of existing code which uses it. Change 3770553 by Ben.Marsh Adding structured serialization API to Core/CoreUObject for use with text-based assets. * FStructuredArchive abstracts an archive which is made up of compound types (records, arrays, and maps). Values are stored in slots within these types. * Records are string -> value dictionaries where the key names can be compiled out in non-editor builds or when WITH_TEXT_ARCHIVE_SUPPORT = 0. * Maps are string -> value dictionaries where the key names are present regardless of the build type. * Proxy objects are defined to express the context for serialization (FStructuredArchive::FRecord, FStructuredArchive::FArray, FStructuredArchive::FMap, FStructuredArchive::FSlot) which allows basic validation through static typing. These objects act as lightweight handles, and can be cheaply constructed and passed around on the stack. Most serialization to and from the archive is done through these objects. * Runtime checks perform additional validation to ensure that serialized data is well formed and written in a forward-only manner, regardless of the underlying archive type. * The actual input/output format is determined by a separate interface (FArchiveFormatter). Context validation (always causing matching LeaveArray for every EnterArray, etc...) is done by FStructuredArchive, so implementing these classes is fairly trivial. FArchiveFormatter can be de-virtualized in non-editor builds, where WITH_TEXT_ARCHIVE_SUPPORT = 0. * Includes implementations of FArchiveFormatter for binary and JSON formats. Change 3771105 by Steve.Robb Deprecation warnings for PLATFORM_COMPILER_HAS_AUTO_RETURN_TYPES and PLATFORM_COMPILER_HAS_DEFAULTED_FUNCTIONS. Fix for incorrect warning formatting on Clang platforms. Change 3771520 by Steve.Robb Start moving Clang-using platforms' pre-setup stuff into a Clang-specific header. Change 3771564 by Steve.Robb More common macros moved to the Clang pre-setup header. Change 3771613 by Steve.Robb EMIT_CUSTOM_WARNING_AT_LINE moved to ClangPlatformCompilerPreSetup.h. Change 3772881 by Ben.Marsh Add support for serializing FName and UObject through FStructuredArchive. In order to allow custom linker behavior when serializing objects: * The constructor to JSON input formatter now takes a delegate to convert a string object name into a UObject pointer. * The constructor to tagged binary formatter takes a delegate to serialize a UObject pointer into any form it chooses (likely an integer index into the import table) Object and name types are stored as strings in JSON, using an "Object:" or "Name:" prefix to differentiate them from regular strings. Any strings that already contain one of these prefixes are prepended with a "String:" prefix (as is any string that already has a "String:" prefix). Change 3772941 by Graeme.Thornton Make build work when including StructuredArchive.h from core container types Added standard header to new files Add structured archive serializer for TArray Fix bug in structured archive where containers weren't being popped from the scope stack Change 3772972 by Ben.Marsh Add an adapter which presents a legacy FArchive interface to a FStructuredArchive slot. Data is serialized into this slot as a stream of elements; raw data is buffered up into fixed size chunks, names and objects are serialized separately. When used with FBinaryArchiveFormatter, this should result in all data being passed through to the underlying archive in a backwards compatible way, wiith no additional bookkeeping fields. Change 3773006 by Ben.Marsh Rename FStructuredArchive::FRecord::EnterSlot() to EnterField(). Change 3773013 by Steve.Robb bUseInlining target rule added to UnrealBuildTool, which defaults to true, to allow inlining to be disabled for debugging purposes. Change 3774499 by Ben.Marsh Minor fixes for FStructuredArchive related classes: * Text-based archive formats are now compiled out when WITH_TEXT_ARCHIVE_SUPPORT = 0. * Fixed issue with FTaggedBinaryArchiveFormatter state becoming corrupted when looking ahead at field types. * FArchiveFieldName constructor is now explicit, to fix cases where strings were being passed directly to serialize functions. Change 3774600 by Ben.Marsh Add CopyFormattedData() function, which can copy data from one formatter to another. Add a test case to SerializationAPI that converts from data -> JSON -> binary -> JSON -> data. This function can be used to implement a generic visitor pattern, by implementing a FArchiveFormatter which receives the deserialized data. Change 3789721 by Ben.Marsh TBA: Split FTaggedBinaryArchiveFormatter into separate classes for reading and writing. Change 3789920 by Ben.Marsh TBA: Support automatic coercion between any numeric types in tagged binary archives. Also report the smallest type that can contain a value, rather than just in32/double. #jira UECORE-364 Change 3789982 by Ben.Marsh TBA: Change FStructuredArchive::Open() to return a slot, rather than a record, to make it easier to implement a raw FArchive adapter. Change 3792466 by Ben.Marsh TBA: Better handling of raw data in text based assets. Short sequences of binary data are Base64 encoded as a single string. Longer sequences are stored as an array of Base64 encoded lines, push a SHA1 hash to detect cases where the data was merged incorrectly. In order to allow inference of the correct type for a field, other fields called "Base64" will be escaped to "_Base64", and any field beginning with "_" will have an additional underscore inserted. Reading files back in reverses these transformations. Change 3792935 by Ben.Marsh TBA: Rename FArchiveFormatter to FStructuredArchiveFormatter for consistency with FStructuredArchive. Change 3795100 by Ben.Marsh UBT: Rename the ModuleRules Definitions property to PublicDefinitions, to make its semantics clearer. Change 3795106 by Ben.Marsh Replace all internal usages of ModuleRules.Definitions, and replace it with ModuleRules.PublicDefinitions. Change 3796275 by Ben.Marsh Fix paths to Version.h includes from resource files. Change 3800683 by Josh.Engebretson Remove WER from Mac and Linux crash reports in favor of unified runtime-xml format #jira UE-50073 Change 3803545 by Steve.Robb TWeakObjPtr const-dropping assignment fix. Fixes to change. [CL 3805231 by Ben Marsh in Main branch]
2017-12-12 18:32:45 -05:00
ThumbnailClass = MakeWeakObjectPtr(const_cast<UClass*>(FClassIconFinder::GetIconClassForAssetData(AssetData, &bIsClassType)));
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
// For non-class types, use the default based upon the actual asset class
// This has the side effect of not showing a class icon for assets that don't have a proper thumbnail image available
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
const FName DefaultThumbnail = (bIsClassType) ? NAME_None : FName(*FString::Printf(TEXT("ClassThumbnail.%s"), *AssetThumbnail->GetAssetData().AssetClassPath.GetAssetName().ToString()));
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
ThumbnailBrush = FClassIconFinder::FindThumbnailForClass(ThumbnailClass.Get(), DefaultThumbnail);
ClassIconBrush = FSlateIconFinder::FindIconBrushForClass(ThumbnailClass.Get());
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
FSlateColor GetHintBackgroundColor() const
{
const FLinearColor Color = HintColorAndOpacity.Get();
return FSlateColor( FLinearColor( Color.R, Color.G, Color.B, FMath::Lerp( 0.0f, 0.5f, Color.A ) ) );
}
UE4 Refactoring. Changed OVERRIDE and FINAL macros to keywords override and final. [CL 2104397 by Jaroslaw Palczynski in Main branch]
2014-06-13 06:14:46 -04:00
virtual void OnMouseEnter( const FGeometry& MyGeometry, const FPointerEvent& MouseEvent ) override
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
SCompoundWidget::OnMouseEnter( MyGeometry, MouseEvent );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
if ( bAllowRealTimeOnHovered )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
AssetThumbnail->SetRealTime( true );
}
}
virtual void OnMouseLeave( const FPointerEvent& MouseEvent ) override
{
SCompoundWidget::OnMouseLeave( MouseEvent );
if ( bAllowRealTimeOnHovered )
{
AssetThumbnail->SetRealTime( false );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
UE4 Refactoring. Changed OVERRIDE and FINAL macros to keywords override and final. [CL 2104397 by Jaroslaw Palczynski in Main branch]
2014-06-13 06:14:46 -04:00
virtual void Tick( const FGeometry& AllottedGeometry, const double InCurrentTime, const float InDeltaTime ) override
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
if ( WidthLastFrame != AllottedGeometry.Size.X )
{
WidthLastFrame = AllottedGeometry.Size.X;
// The width changed, update the font
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
if ( GenericLabelTextBlock.IsValid() )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
GenericLabelTextBlock->SetFont( GetTextFont() );
GenericLabelTextBlock->SetWrapTextAt( GetTextWrapWidth() );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
if ( HintTextBlock.IsValid() )
{
HintTextBlock->SetFont( GetHintTextFont() );
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
HintTextBlock->SetWrapTextAt( GetTextWrapWidth() );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
}
private:
void OnAssetDataChanged()
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
if ( GenericLabelTextBlock.IsValid() )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
GenericLabelTextBlock->SetText( GetLabelText() );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
if ( HintTextBlock.IsValid() )
{
HintTextBlock->SetText( GetLabelText() );
}
// Check if the asset has a thumbnail.
const FObjectThumbnail* ObjectThumbnail = NULL;
FThumbnailMap ThumbnailMap;
if( AssetThumbnail->GetAsset() )
{
FName FullAssetName = FName( *(AssetThumbnail->GetAssetData().GetFullName()) );
TArray<FName> ObjectNames;
ObjectNames.Add( FullAssetName );
ThumbnailTools::ConditionallyLoadThumbnailsForObjects(ObjectNames, ThumbnailMap);
ObjectThumbnail = ThumbnailMap.Find( FullAssetName );
}
bHasRenderedThumbnail = ObjectThumbnail && !ObjectThumbnail->IsEmpty();
ViewportFadeAnimation.JumpToEnd();
AssetThumbnail->GetViewportRenderTargetTexture(); // Access the render texture to push it on the stack if it isnt already rendered
const FAssetData& AssetData = AssetThumbnail->GetAssetData();
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UClass* Class = FindObject<UClass>(AssetData.AssetClassPath);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
FAssetToolsModule& AssetToolsModule = FModuleManager::LoadModuleChecked<FAssetToolsModule>(TEXT("AssetTools"));
TWeakPtr<IAssetTypeActions> AssetTypeActions;
if ( Class != NULL )
{
AssetTypeActions = AssetToolsModule.Get().GetAssetTypeActionsForClass(Class);
}
Fixed unloaded Blueprint components having the wrong icon UE-9331 - Missing icons for BP component classes when restarting editor Moved the code to work out the correct class icon for a Blueprint or asset data into FClassIconFinder so that it can be shared between the asset thumbnails and the components context menu. Added an extra IconClass member to FComponentClassComboEntry so that unloaded Blueprints can set this appropriately despite having a null ComponentClass. [CL 2451813 by Jamie Dale in Main branch]
2015-02-19 12:15:18 -05:00
UpdateThumbnailClass();
AssetThumbnail - Get the class thumbnail from the ClassIconFinder so that it works with alternate styles. I'm not sure how much this class is actually used in the UI, but it does a lot of redundant work every frame in several different callback methods. If it's used a lot, it should probably get an optimization pass. TTP# 334639 [CL 2220983 by Frank Fella in Main branch]
2014-07-16 13:29:40 -04:00
Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main) #rnx [CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
AssetColor = FLinearColor::White;
if( AssetTypeColorOverride.IsSet() )
{
AssetColor = AssetTypeColorOverride.GetValue();
}
else if ( AssetTypeActions.IsValid() )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
AssetColor = AssetTypeActions.Pin()->GetTypeColor();
}
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
Content browser reskin reworks Changed the look of folders Changed the look of filters Changed the look of the text for asset tiles [CL 13963307 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-29 10:50:26 -04:00
//AssetBackgroundWidget->SetBorderBackgroundColor(AssetColor.CopyWithNewOpacity(0.3f));
Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main) #rnx [CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
AssetColorStripWidget->SetBorderBackgroundColor(AssetColor);
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
UpdateThumbnailVisibilities();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
FSlateFontInfo GetTextFont() const
{
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
return FAppStyle::GetFontStyle( WidthLastFrame <= 64 ? FAppStyle::Join(Style, ".FontSmall") : FAppStyle::Join(Style, ".Font") );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
FSlateFontInfo GetHintTextFont() const
{
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
return FAppStyle::GetFontStyle( WidthLastFrame <= 64 ? FAppStyle::Join(Style, ".HintFontSmall") : FAppStyle::Join(Style, ".HintFont") );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
float GetTextWrapWidth() const
{
Refined text rendering on content browser thumbnails and reverted back to full-width sizing method. Tiny text is now using a lighter font with a better hinting algorithm, and is centrally justified. We want to minimise waste of horizontal space, so content browser thumbnails now fill the width of the content browser once again. [CL 2299335 by Andrew Rodham in Main branch]
2014-09-16 07:01:27 -04:00
return WidthLastFrame - GenericThumbnailBorderPadding * 2.f;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
const FSlateBrush* GetAssetBackgroundBrush() const
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
return FAppStyle::GetBrush(AssetBackgroundBrushName);
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
const FSlateBrush* GetClassBackgroundBrush() const
{
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
Replacing legacy EditorStyle calls with AppStyle #preflight 6272a74d2f6d177be3c6fdda #rb Matt.Kuhlenschmidt #ROBOMERGE-OWNER: Lauren.Barnes #ROBOMERGE-AUTHOR: lauren.barnes #ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690) #ROBOMERGE-CONFLICT from-shelf [CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
return FAppStyle::GetBrush(ClassBackgroundBrushName);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
FLinearColor GetViewportColorAndOpacity() const
{
return FLinearColor(1, 1, 1, ViewportFadeCurve.GetLerp());
}
EVisibility GetViewportVisibility() const
{
return bHasRenderedThumbnail ? EVisibility::Visible : EVisibility::Collapsed;
}
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
/** The height of the color strip (if it's oriented along the bottom edge) or its width (if it's oriented along the right edge) */
float GetAssetColorStripThickness() const
Asset labels in the content browser can now fill beyond the width of the thumbnails. The font has also been reduced in size to reduce the amount of wrapping on asset labels at small sizes. Also polished the asset borders and shadows. This addresses TTP 345457 and 345452. [CL 2297910 by Andrew Rodham in Main branch]
2014-09-15 05:59:46 -04:00
{
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
return 2.0f;
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
}
FMargin GetAssetColorStripPadding() const
{
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
if (ColorStripOrientation == EThumbnailColorStripOrientation::HorizontalBottomEdge)
{
const float Height = GetAssetColorStripThickness();
return FMargin(0, Height, 0, 0);
}
else
{
const float Width = GetAssetColorStripThickness();
return FMargin(Width, 0, 0, 0);
}
Asset labels in the content browser can now fill beyond the width of the thumbnails. The font has also been reduced in size to reduce the amount of wrapping on asset labels at small sizes. Also polished the asset borders and shadows. This addresses TTP 345457 and 345452. [CL 2297910 by Andrew Rodham in Main branch]
2014-09-15 05:59:46 -04:00
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
const FSlateBrush* GetClassThumbnailBrush() const
{
AssetThumbnail - Get the class thumbnail from the ClassIconFinder so that it works with alternate styles. I'm not sure how much this class is actually used in the UI, but it does a lot of redundant work every frame in several different callback methods. If it's used a lot, it should probably get an optimization pass. TTP# 334639 [CL 2220983 by Frank Fella in Main branch]
2014-07-16 13:29:40 -04:00
if (ClassThumbnailBrushOverride.IsNone())
{
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
return ThumbnailBrush;
AssetThumbnail - Get the class thumbnail from the ClassIconFinder so that it works with alternate styles. I'm not sure how much this class is actually used in the UI, but it does a lot of redundant work every frame in several different callback methods. If it's used a lot, it should probably get an optimization pass. TTP# 334639 [CL 2220983 by Frank Fella in Main branch]
2014-07-16 13:29:40 -04:00
}
else
{
// Instead of getting the override thumbnail directly from the editor style here get it from the
// ClassIconFinder since it may have additional styles registered which can be searched by passing
// it as a default with no class to search for.
return FClassIconFinder::FindThumbnailForClass(nullptr, ClassThumbnailBrushOverride);
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
EVisibility GetClassThumbnailVisibility() const
{
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
if(!bHasRenderedThumbnail)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
const FSlateBrush* ClassThumbnailBrush = GetClassThumbnailBrush();
[INTEGRATE] Change 2415497 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 13:33:05 Stopped derived types from UBlueprint being processed as if they were a BP class UE-7184 - Show game c++ classes and engine c++ classes in the content browser Also renamed "ClassAssetClass" to "ThumbnailClass" to better reflect its purpose. [CL 2419545 by Ben Marsh in Main branch]
2015-01-26 19:07:07 -05:00
if( ClassThumbnailBrush && ThumbnailClass.Get() )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
return EVisibility::Visible;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
return EVisibility::Collapsed;
}
EVisibility GetGenericThumbnailVisibility() const
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
return (bHasRenderedThumbnail && ViewportFadeAnimation.IsAtEnd()) ? EVisibility::Collapsed : EVisibility::Visible;
}
const FSlateBrush* GetClassIconBrush() const
{
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
return ClassIconBrush;
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
}
FMargin GetClassIconPadding() const
{
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
if (ColorStripOrientation == EThumbnailColorStripOrientation::HorizontalBottomEdge)
{
const float Height = GetAssetColorStripThickness();
return FMargin(0, 0, 0, Height);
}
else
{
const float Width = GetAssetColorStripThickness();
return FMargin(0, 0, Width, 0);
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
EVisibility GetHintTextVisibility() const
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
if ( bAllowHintText && ( bHasRenderedThumbnail || !GenericLabelTextBlock.IsValid() ) && HintColorAndOpacity.Get().A > 0 )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
return EVisibility::Visible;
}
return EVisibility::Collapsed;
}
void OnThumbnailRendered(const FAssetData& AssetData)
{
if ( !bHasRenderedThumbnail && AssetData == AssetThumbnail->GetAssetData() && ShouldRender() )
{
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
OnRenderedThumbnailChanged( true );
---- Merging with SlateDev branch ---- Introduces the concept of "Active Ticking" to allow Slate to go to sleep when there is no need to update the UI. While asleep, Slate will skip the Tick & Paint pass for that frame entirely. - There are TWO ways to "wake" Slate and cause a Tick/Paint pass: 1. Provide some sort of input (mouse movement, clicks, and key presses). Slate will always tick when the user is active. - Therefore, if the logic in a given widget's Tick is only relevant in response to user action, there is no need to register an active tick. 2. Register an Active Tick. Currently this is an all-or-nothing situation, so if a single active tick needs to execute, all of Slate will be ticked. - The purpose of an Active Tick is to allow a widget to "drive" Slate and guarantee a Tick/Paint pass in the absence of any user action. - Examples include animation, async operations that update periodically, progress updates, loading bars, etc. - An empty active tick is registered for viewports when they are real-time, so game project widgets are unaffected by this change and should continue to work as before. - An Active Tick is registered by creating an FWidgetActiveTickDelegate and passing it to SWidget::RegisterActiveTick() - There are THREE ways to unregister an active tick: 1. Return EActiveTickReturnType::StopTicking from the active tick function 2. Pass the FActiveTickHandle returned by RegisterActiveTick() to SWidget::UnregisterActiveTick() 3. Destroy the widget responsible for the active tick - Sleeping is currently disabled, can be enabled with Slate.AllowSlateToSleep cvar - There is currently a little buffer time during which Slate continues to tick following any input. Long-term, this is planned to be removed. - The duration of the buffer can be adjusted using Slate.SleepBufferPostInput cvar (defaults to 1.0f) - The FCurveSequence API has been updated to work with the active tick system - Playing a curve sequence now requires that you pass the widget being animated by the sequence - The active tick will automatically be registered on behalf of the widget and unregister when the sequence is complete - GetLerpLooping() has been removed. Instead, pass true as the second param to Play() to indicate that the animation will loop. This causes the active tick to be registered indefinitely until paused or jumped to the start/end. [CL 2391669 by Dan Hertzka in Main branch]
2014-12-17 16:07:57 -05:00
ViewportFadeAnimation.Play( this->AsShared() );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
void OnThumbnailRenderFailed(const FAssetData& AssetData)
{
if ( bHasRenderedThumbnail && AssetData == AssetThumbnail->GetAssetData() )
{
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
OnRenderedThumbnailChanged( false );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
bool ShouldRender() const
{
const FAssetData& AssetData = AssetThumbnail->GetAssetData();
// Never render a thumbnail for an invalid asset
if ( !AssetData.IsValid() )
{
return false;
}
if( AssetData.IsAssetLoaded() )
{
// Loaded asset, return true if there is a rendering info for it
UObject* Asset = AssetData.GetAsset();
FThumbnailRenderingInfo* RenderInfo = GUnrealEd->GetThumbnailManager()->GetRenderingInfo( Asset );
if ( RenderInfo != NULL && RenderInfo->Renderer != NULL )
{
return true;
}
}
const FObjectThumbnail* CachedThumbnail = ThumbnailTools::FindCachedThumbnail(*AssetData.GetFullName());
if ( CachedThumbnail != NULL )
{
// There is a cached thumbnail for this asset, we should render it
return !CachedThumbnail->IsEmpty();
}
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
if ( AssetData.AssetClassPath != UBlueprint::StaticClass()->GetClassPathName() )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
// If we are not a blueprint, see if the CDO of the asset's class has a rendering info
// Blueprints can't do this because the rendering info is based on the generated class
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
UClass* AssetClass = FindObject<UClass>(AssetData.AssetClassPath);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
if ( AssetClass )
{
FThumbnailRenderingInfo* RenderInfo = GUnrealEd->GetThumbnailManager()->GetRenderingInfo( AssetClass->GetDefaultObject() );
if ( RenderInfo != NULL && RenderInfo->Renderer != NULL )
{
return true;
}
}
}
// Unloaded blueprint or asset that may have a custom thumbnail, check to see if there is a thumbnail in the package to render
FString PackageFilename;
Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971 [CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
if ( FPackageName::DoesPackageExist(AssetData.PackageName.ToString(), &PackageFilename) )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
TSet<FName> ObjectFullNames;
FThumbnailMap ThumbnailMap;
FName ObjectFullName = FName(*AssetData.GetFullName());
ObjectFullNames.Add(ObjectFullName);
ThumbnailTools::LoadThumbnailsFromPackage(PackageFilename, ObjectFullNames, ThumbnailMap);
const FObjectThumbnail* ThumbnailPtr = ThumbnailMap.Find(ObjectFullName);
if (ThumbnailPtr)
{
const FObjectThumbnail& ObjectThumbnail = *ThumbnailPtr;
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
return ObjectThumbnail.GetImageWidth() > 0 && ObjectThumbnail.GetImageHeight() > 0 && ObjectThumbnail.GetCompressedDataSize() > 0;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
Update Release-Engine-Test from Release-Engine-Staging @ 16264272 [CL 16264458 by Marc Audy in ue5-release-engine-test branch]
2021-05-11 01:10:20 -04:00
// Always render thumbnails with custom thumbnails
FString CustomThumbnailTagValue;
if (AssetData.GetTagValue(FAssetThumbnailPool::CustomThumbnailTagName, CustomThumbnailTagValue))
{
return true;
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
return false;
}
Fixed code relying on SLATE_TEXT_ATTRIBUTE for STextBlock. UETOOL-213 - Minimize Slate FString -> FText conversion (remove SLATE_TEXT_ATTRIBUTE) This fixes any editor/engine specific code that was passing text to Slate as FString rather than FText. [CL 2399803 by Jamie Dale in Main branch]
2015-01-07 09:52:40 -05:00
FText GetLabelText() const
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Branch snapshot for CL 2889817 [CL 2889817 in Dev-VREditor branch]
2016-03-11 17:29:00 -05:00
if( Label != EThumbnailLabel::NoLabel )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Branch snapshot for CL 2889817 [CL 2889817 in Dev-VREditor branch]
2016-03-11 17:29:00 -05:00
if ( Label == EThumbnailLabel::ClassName )
{
return GetAssetClassDisplayName();
}
else if ( Label == EThumbnailLabel::AssetName )
{
return GetAssetDisplayName();
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Fixed code relying on SLATE_TEXT_ATTRIBUTE for STextBlock. UETOOL-213 - Minimize Slate FString -> FText conversion (remove SLATE_TEXT_ATTRIBUTE) This fixes any editor/engine specific code that was passing text to Slate as FString rather than FText. [CL 2399803 by Jamie Dale in Main branch]
2015-01-07 09:52:40 -05:00
return FText::GetEmpty();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main #lockdown Nick.Penwarden #rb none Change 3720210 on 2017/10/25 by Olaf.Piesche Fixing dynamic material params for ribbons #!codereview scott.kennedy #!rb none #!tests scott's test ribbon Change 3720073 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: frank.fella Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it. #!Tests Minion automated tests no longer crash randomly. #!rb SimonT #!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3719233 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: philip.buuck [OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead). #!rb Matt.Schembari #!tests PIE [QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death #!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3718474 on 2017/10/25 by Yannick.Lange Niagara: Only show isolate menu items on track context menu if it is a system. Rename "Isolate toggle" to "Isolated". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718095 on 2017/10/25 by Yannick.Lange Niagara: Fix crash when not having dynamic parameter in material. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718069 on 2017/10/25 by Yannick.Lange Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3717545 on 2017/10/24 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Removed read / write locks from PipelineStateCache. #!rb Andrew.Grant, Gil.Gribb #!test paragon ps4. #!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3716928 on 2017/10/24 by Shaun.Kime The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime. #!rb olaf.piesche, simon.tovey #!fyi olaf.piesche, simon.tovey, frank.fella #!tests am now able to run Test_minionWave on PS4 Change 3715712 on 2017/10/24 by Yannick.Lange Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3715430 on 2017/10/23 by Shaun.Kime Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it. #!rb none #!fyi simon.tovey #!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime Change 3715368 on 2017/10/23 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main) #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3715226 on 2017/10/23 by Shaun.Kime Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's. #!rb none #!fyi simon.tovey, olaf.piesche, frank.fella #!tests ran in PIE Change 3714645 on 2017/10/23 by Yannick.Lange Niagara: Add ability to create particle system from this emitter in content browser. #!rb Shaun.Kime #!tests n/a Change 3714200 on 2017/10/23 by Olaf.Piesche Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target #!codereview simon #!rb none #!tests Orion Niagara assets Change 3713341 on 2017/10/23 by Yannick.Lange Niagara: Fix NiagaraNodeIF output pins cannot be deleted. Fix NiagaraNodeIF output pins cannot be renamed. #!jira UE-50193 #!jira UE-50193 #!rb Shaun.Kime #!tests n/a Change 3713133 on 2017/10/23 by Yannick.Lange Niagara: Isolate emitters in sequencer UI. - Added being able to extend the sequencer track context menu with a delegate. - Added entry in track context menu to toggle the selected emitters isolation state. - Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters. #!rb Shaun.Kime #!tests n/a Change 3712445 on 2017/10/22 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime UVScale, UniformAorBFloat, and LinearColorAlongVector added. #!rb none #!tests new autotest added #!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3712420 on 2017/10/21 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1. #!rb none [CODEREVIEW] frank.fella [FYI] simon.tovey, olaf.piesche, wyeth.johnson #!tests created an emitter, disabled Acceleration Force.. still compiled. #!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711602 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like: LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData #!jira UE-51511 #!rb Simon.Tovey #!tests n/a #!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711288 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: eric.ketchum [Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work #!rb: None #!tests: PIE [CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime #!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711197 on 2017/10/20 by Olaf.Piesche Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly #!rb none #!tests minion projectile ribbon trail Change 3710634 on 2017/10/20 by Mic.Rooney Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing. #!RB: none #!Test: tested/built locally ran preflight Editor/Monolithics build. #!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3709686 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Added some more timerguards for slow timer manager tick objects. Commented out for now. #!rb Trivial #!test Paragon Cooked ps4. #!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708958 on 2017/10/19 by Shaun.Kime Back out changelist 3708456 .. this was an unintentional change #!rb none #!tests n/a Change 3708839 on 2017/10/19 by Shaun.Kime Merging CL 3708835 Fixing Scott's common crash with adding an emitter with autocompile off #!rb frank.fella #!tests n/a Change 3708784 on 2017/10/19 by Shaun.Kime Merging CL 3708782 //Orion/Main/... to //Orion/DevGeneral/... #!rb none #!tests n/a Change 3708600 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion #!rb none #!test golden path #!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708473 on 2017/10/19 by Shaun.Kime Merging Frank's changes for team color support from Main to Dev-General #!rb Frank.Fella #!tests test_minionwave worked Change 3708456 on 2017/10/19 by Shaun.Kime Particles.Random set to 0.0 #!rb none #!tests n/a Change 3708455 on 2017/10/19 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests passed minion fx autotest Change 3707648 on 2017/10/19 by Shaun.Kime Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made. Defer deletion of dataset to RT. Ensure resets don't mess with data inflight RT commands are using. Checkin on behalf of Simon Tovey #!jira OR-45423 #!rb Simon.Tovey #!tests ran through the LaneMinionFXTests successfully on PC Change 3707096 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago. #!rb none #!tests automated tests pass #!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3706726 on 2017/10/19 by Rob.Cannaday Merge XMPP resource version to use version 2 instead of version 3 #!rb trivial #!tests compile #!ROBOMERGE: Main, 44, Tencent Change 3706349 on 2017/10/19 by Josh.Markiewicz #!UE4 - Cross Voice code review feedback - fixed up broken stack vs queue - fixed GetRoomId returning int32 instead of uint64 - fixed switch room logic - more/better logging - more comments #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday #!rb none #!tests local cheat codes Change 3705453 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: arne.schober Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array) #!RB Daniel.Wright #!Tests LaunchOnPs4 #!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3705399 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: scott.kennedy Default Niagara emitter changed color property to better default value. Updated basic glow emitter Added energy bubble base emitter put a little more polish into siege minion impact FX. #!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3704426 on 2017/10/18 by Shaun.Kime Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423 #!rb simon.tovey #!fyi hunter.kent #!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure Change 3703288 on 2017/10/18 by Olaf.Piesche Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash #!rb olaf.piesche, simon.tovey #!tests minion test map PC and PS4 Change 3701373 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader. #!rb Olaf.Piesche #!tests test_minionwave runs #!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3701108 on 2017/10/17 by Hunter.Kent Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily. #!RNX #!Test PS4 #!rb @tim.elek #!review-3701110 @andrew.grant, @daniel.lamb Change 3701044 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: jon.lietz - white space fixes - added in more detail to logging - fixed dragon GC to not hide when the mesh is hidden #!rb none #!tests complies and logging is updated [FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen #!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3700900 on 2017/10/17 by Shaun.Kime Integrating possible crash fix from Dev-Niagara to Dev-Gen #!rb none #!tests n/a #!fyi Olaf.Piesche Change 3700492 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests done in branch Change 3700217 on 2017/10/17 by Olaf.Piesche Fix for potential crash in sprite renderer #!rb none #!tests minion test map Change 3700216 on 2017/10/17 by Benn.Gallagher Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master. #!rb Lina.Halper #!jira OR-45226 #!tests PIE + Standalone games hitting Rampage with Ghosts E Change 3699660 on 2017/10/17 by Jason.Bestimt #!ORION_DG - Fixes to UnrealHitchParser edge cases #!RB:none #!Tests: Ran on Logs from QA #!CodeReview: ben.salem Change 3699462 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!tests preflight ok #!rb none Change 3699010 on 2017/10/17 by Jeff.Williams Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920 #!rb none #!tests none Change 3698519 on 2017/10/16 by Olaf.Piesche Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts #!rb none #!tests minion wave test map Change 3698380 on 2017/10/16 by Shaun.Kime Updating logic to now support the autoattachment #!rb none #!tests autotests pass.. Change 3698263 on 2017/10/16 by Olaf.Piesche Assume degrees for sprite rotation #!rb none #!codereview shaun.kime #!tests test sprite emitter Change 3697652 on 2017/10/16 by Olaf.Piesche Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion #!rb none #!tests minion test map Change 3696906 on 2017/10/15 by Shaun.Kime Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers. #!rb none #!tests now no longer generates invalid errors #!fyi frank.fella, olaf.piesche, simon.tovey Change 3695456 on 2017/10/13 by Olaf.Piesche Fix for potential ribbon crash and end-of-ribbon rendering artifacts #!rb none #!codereview scott.kennedy #!tests minion wave test map Change 3694545 on 2017/10/13 by Andrew.Grant Fix for low frequency async loading crash (OR-42535) #!rb gil.gribb #!tests comppiled Change 3694176 on 2017/10/13 by Jeff.Williams Plugin manifest name changed to DLCFile name #!rb none #!tests compile, stage Change 3693582 on 2017/10/12 by Don.Eubanks Fixing PS4 Compile warning (constructor init order not matching member define order) #!rb none #!tests Compile Shipping Client PS4 #!fyi olaf.piesche Change 3693516 on 2017/10/12 by Olaf.Piesche Niagara: Remove mesh renderer assert, replace with early out #!rb none #!tests niagara mesh test asset Merging //Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp Change 3693051 on 2017/10/12 by Ben.Salem Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log. #!rb Clayton.Langford #!tests Parsed a 5mb log with dumphitches down to 23k of hitch data. Change 3692912 on 2017/10/12 by Olaf.Piesche Merging: Niagara ribbon tiling distance #!rb none #!tests ribbon test asset Change 3692835 on 2017/10/12 by Shaun.Kime Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags. #!rb none #!fyi scott.kennedy, wyeth.johnson #!tests n/a Change 3692751 on 2017/10/12 by Shaun.Kime Removing script that shouldn't have come over. #!rb none #!tests n/a Change 3692746 on 2017/10/12 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests opened test level and created new emitter/system Change 3692616 on 2017/10/12 by Don.Eubanks OR-45131 Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking. #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE #!codereview nick.darnell Change 3691912 on 2017/10/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none #!tests compile, editor #!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3690944 on 2017/10/11 by Jeff.Williams Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC. #!rb Daniel.Lamb #!tests Compile, build Change 3688989 on 2017/10/10 by Lina.Halper LOD sync of attached/parent #!rb: Laurent.Delayen #!tests: price with shotgun skin/PIE/editor Change 3687592 on 2017/10/09 by Ben.Salem Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test. #!rb clayton.langford #!tests Ran sparrow shallow tests. Change 3686560 on 2017/10/09 by Shaun.Kime Flipping the min/max values to be standard #!rb none #!tests n/a Change 3686046 on 2017/10/09 by Shaun.Kime Merging latest from Dev-Niagara in preparation for Effects team work on Monday #!rb none #!tests successful preflight #!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek Change 3685613 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: simon.tovey Implementing vector field matrix inverse fix from CL3675167 to 43.3. #!rb none #!tests none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685603 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross RotationalContent Improvements - Fixed potential bug where tags could be updated when not intended on RotationalContentManager - Fix for PIE assert - Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option. - Removing config tag from RotationalContentOverrides in OrionGlobals. New Halloween Gauntlet Test - Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box. #!rb none #!tests local builds / editor / PIE #!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685408 on 2017/10/07 by ben.salem Fixing robomerge error in DevGen #!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. ben.salem, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml -------------------------------------- Merging using DevGen->Release43.3 Repairing mailer for nightly Perf tests, fixing email headers. #!tests run in devgen #!rb none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685073 on 2017/10/06 by Andrew.Grant Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General) #!tests #!rb na Change 3684717 on 2017/10/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where GT & RT times in profile info were reversed :( #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3684512 on 2017/10/06 by Laurent.Delayen Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code. #!rb lina.halper #!tests minion AnimBP nativization Change 3684059 on 2017/10/06 by Max.Preussner Orion: Fixed ability videos not loading on PS4 and/or not looping #!fyi stephan.jiang #!jira OR-44682 #!rb none #!rnx #!tests none Change 3683538 on 2017/10/06 by David.Ratti batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions. -Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players. -Fixes case where killing minions with badass was not displaying pops (prediction key issue) #!rb none #!tests editor, pie #!review-3683539 @Matt.Schembari Change 3683364 on 2017/10/06 by Andrew.Grant Changed warning to info #!tests #!rb na Change 3681999 on 2017/10/05 by Bart.Hawthorne Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion. #!rb cody.haskell #!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore #!jira OR-44111 #!tests Golden path, live spectated numerous matches. Change 3681403 on 2017/10/04 by Josh.Markiewicz #!UE4 - base pass for Tencent Cross SDK - basic testing done with enter/exit/switch room - basic testing of ShowUI - checked in disabled #!rb duck #!tests see above #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday Change 3680623 on 2017/10/04 by David.Ratti Rework for how max movement speed is calculated. The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow. Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored. Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow. GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc). Suggested methods for inspection: AbilitySystem debug hud (Home/End) p.VisualizeMovement (displays final calculated movement speed) Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar) Technical information: 1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool. 2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows. 3. Added a notification for attribute sets when an aggregator is created for one of their attributes. 4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod) 5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension. #!tests pie #!rb FrankG #!codereview Fred.Kimberley, Billy.Bramer #!fyi colin.fogle #!QAReview #!RN #!designchange Change 3680580 on 2017/10/04 by Ben.Salem Repair email titles for various reports. #!rb none #!tests Reran tests. Change 3680438 on 2017/10/04 by Dan.Hertzka GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect - Fixes the HUD status effect feed not showing sources for a lot of itemization abilities Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip #!rb Dave.Ratti #!tests OrionEntry PIE - equipped Sand Speeder #!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on Change 3680344 on 2017/10/04 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Speculative disable of defragging on volumetric lightmap textures. #!rb andrew.grant #!test monolith2 ps4 #!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3680302 on 2017/10/04 by Shaun.Kime Integration from DevNiagara. Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array. #!rb none #!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek #!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass. Change 3679946 on 2017/10/04 by Laurent.Delayen Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches. #!rb lina.halper #!FYI andrew.grant #!tests monolith2 old minions Change 3679938 on 2017/10/04 by Daniel.Lamb Allowed foliage cullall option to be modified by scalability options. #!rb Trivial #!test Compile paragon editor Change 3679563 on 2017/10/04 by Jon.Lietz OR-43599 - added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it. #!rb Dave.Ratti #!review-3679564 @John.Nielson #!tests added these waits to hot pursuit and they worked as expected Change 3679006 on 2017/10/03 by Ben.Salem Try to fix broken nightly mailer issues for FX tests. #!rb none #!tests Preflighted a shallow fx pass successfully in EC. Change 3677845 on 2017/10/03 by Andrew.Grant Added an ensure to guard against OR-44826 while further investigations occur #!tests compiled #!rb none Change 3677443 on 2017/10/03 by John.Nielson Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase. Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify). #!RB: None #!Test: Pie, Uncooked #!review-3677445: @David.Ratti Change 3676748 on 2017/10/02 by Laurent.Delayen Minions: split body layer is now done in mesh space, to maintain upper body orientation. #!FYI ray.arnett, lina.halper #!rb none #!test lane minion test map Change 3675950 on 2017/10/02 by Don.Eubanks Added several new supported tags / status effects to the Floating Status Effect Text system. Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player. Added ScaleOverDistance curve support for floating numbers / text. Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out. #!rb matt.schembari #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 Change 3675186 on 2017/10/02 by Mic.Rooney Support for other anim curve driving audio types (right now specifically DialogueWave) #!RB: none #!Test: compiled editor/monolithics/withoutunity and tested locally. #!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3675167 on 2017/10/02 by Shaun.Kime Changed unsafe InverseFast() to an Inverse() #!jira OR-44671 #!rb Simon.Tovey #!tests n/a Change 3674888 on 2017/10/02 by David.Ratti GGP V2 * Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration. Item System: * Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords. * Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup). Ability System: * SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE) #!rb none #!tests editor pie cooked #!review-3674889 @Jon.Lietz Change 3674170 on 2017/09/30 by Mieszko.Zielinski Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load. #!rb none #!test golden path #!OR-44738 Change 3672937 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files #!tests 3compiled #!rb none #!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672867 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored previous behaviour of integer numbers being formatted as "1" and not "1.00" #!tests ran game, checked playlist analytic #!rb nikdel #!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672575 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Remove warning that can happens normally with backwards compat replays #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672548 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Andrew.Grant #!test Editor building hlods #!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672542 on 2017/09/29 by Andrew.Grant Merging #!rb #!tests na Change 3672390 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed memreport settings for frontend tests #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672385 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Reworked and pretty much final PipelineState cache code - various comments incorporated - namespaced functions - removed redundant class and replaced with ref pointer #!tests soaked a lot [at daniel.lamb,] [at arne.schober] #!rb none #!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672281 on 2017/09/29 by Rob.Cannaday Add user ID to OnNetworkCheatDetected #!jira TEN-272 #!jira TEN-273 #!jira TEN-274 #!rb rob.cannaday #!tests Win64 AI match, simulate cheat detected by cheat command #!review-3672282 @ian.fox @sam.zamani Change 3671688 on 2017/09/29 by Frank.Gigliotti Added ability to set developer comment when adding native tags. #!RB David.Ratti #!Tests None Change 3670409 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for dump type made while doing cleanup #!tests compiled Win64, PS4, ran PS4 #!rb none #!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3670399 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed race condition in pipeline state cache Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon (Couple of extra tweaks planned, but this should be GTG for a v43 release) #!rb codereviewed #!tests soaked locally, lots #!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669802 on 2017/09/28 by Andrew.Grant From Dev-Framework #!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed #!rb michael.noland #!codereview andrew.grant #!tests na Change 3669709 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669177 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Reflection Captures support Lighting Scenarios without recapturing * Reflection Captures are now part of the Map Build * Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message) * Reflection Capture build data moved to the BuildData package * Building lighting / reflection captures no longer dirties ULevels * Sky lights which capture the scene now work correctly with Lighting Scenarios * Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded) #!rb Marcus.Wassmer #!TESTS Paragon editor Monolith02 #!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669124 on 2017/09/28 by Daniel.Lamb Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush Fix cook in devgeneral Bumped shader version to invalidate stale uniform buffer name. #!rb none #!TESTS none #!fyi Daniel.Wright Change 3667906 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667899 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Remove unused SM4 reflection capture cubemap #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667894 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] SM4 fallback for reflection captures. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667859 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] Removed old rasterized deferred reflection env path. Removed reflection compute shader. Replaced with PS. Small perf gain. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667852 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed missing include #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667807 on 2017/09/27 by Daniel.Lamb Tencent DLC can now remap the plugin content to the game root directory. #!rb Ben.Marsh #!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test Change 3667753 on 2017/09/27 by Clayton.Langford Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer. #!RB Ben.Salem, Adric.Worley #!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat Change 3667408 on 2017/09/27 by Jordan.Walker Optimization to bakedNormal layer blend on Low end material quality -uses simple multiply and add normal map blend Change 3667388 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times. #!rb none #!TESTS QAGame on console #!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667383 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667265 on 2017/09/27 by Daniel.Lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Uriel.Doyon #!test Editor building hlods Change 3667159 on 2017/09/27 by Mieszko.Zielinski Added simple logging to BT loading allowing us to identify missing BB keys #!Orion #!test golden path #!rb Lukasz.Furman Change 3665944 on 2017/09/26 by Dan.Hertzka Fix PS4 compile #!rb none #!tests compile PS4 Change 3665590 on 2017/09/26 by Daniel.Lamb Fix for DLC cooking everything when it should only cook the DLC. #!rb None #!test None Change 3665569 on 2017/09/26 by Dan.Hertzka New status effect feed for the new HUD: - Now placed in the mid-upper-left side of the HUD - Biggest difference from before is that there are now names associated with each effect - If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet. Cleaning: - Deleted all of the old buff widget classes & codepaths - Removed redundant properties from StatusEffectDisplayInfo - Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData Also: - Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events - Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed) @todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.) #!rb Don.Eubanks #!tests OrionEntry PIE with some cards and hero abilities #!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial. #!lockdown Billy.Rivers Change 3665555 on 2017/09/26 by Daniel.Lamb AudioStreaming mpsc queue fix up. #!rb Andrew.Grant #!test Compile paragon client / editor. Change 3665517 on 2017/09/26 by Daniel.Lamb Suspect fix for OR-44619 #!jira OR-44619 #!test Paragon editor compile #!rb Trivial Change 3664346 on 2017/09/26 by Jon.Lietz - making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out. - Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired. - Updated all GC's data to use the new decal class - removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent #!rb Dave.Ratti #!reivew Dave.Ratti #!tests used characters that had decal comps in the GC and they recylce as expected. #!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed. Change 3664099 on 2017/09/26 by Jon.Lietz OR-44510 - bringing over engine fixes for the Enum Redirector from Dev-Framework #!rb none #!tests compiles and warnings are gone Change 3663019 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Gil: fixed race condition in the PipelineStateCache #!rb Daniel.Lamb #!test paragon ps4 with higher repro modified build #!lockdown Andrew.Grant #!jira OR-44441 #!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663014 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready. #!tests ran locally #!rb [at daniel.lamb] [at arne.schober] #!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663004 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed dev check for extra commandline args from /data to /temp0 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662999 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Fixed DateTime used for folders not being set #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662255 on 2017/09/25 by Sam.Zamani #!tencent - fix for link error due to missing define of static OnNetworkCheatDetected delegate #!rb none #!tests none Change 3662073 on 2017/09/25 by Sam.Zamani #!tencent Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server Possible options #!jira TEN-275 TSS detect and expose punish user callbacks KickClient - User should be booted from the current game session via disconnect KickMatch - User received info about being punished (eg. ban type etc) PunishInfo - User received info about being punished (eg. ban type etc) #!rb rob.cannaday #!tests none Change 3659487 on 2017/09/22 by Josh.Markiewicz #!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin #!review-3659190 john.barrett, ryan.gerleve Change 3659485 on 2017/09/22 by Josh.Markiewicz #!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins #!fyi john.barrett, ryan.gerleve Change 3659184 on 2017/09/22 by Josh.Markiewicz #!UE4 - delete EpicSurvey module #!fyi justin.sargent, nick.darnell #!rb none Change 3658697 on 2017/09/22 by Ryan.Gerleve Fixes for server-side Tencent anti-cheat library integration: -Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows -Add getter for the TssSdkAntiInterf object -Enable server anti-cheat in editor builds #!codereview sam.zamani #!rb none #!tests enabled Tencent OSS, built & ran server Change 3658200 on 2017/09/22 by Graeme.Thornton Manual copy of CL 3587584 from Dev-Core Logging improvements for pak signature check failures - Added "PakCorrupt" console command which corrupts the master signature table - Added some extra log information about which block failed - Re-hash the master signature table and to make sure that it hasn't changed since startup - Moved the ensure around so that some extra logging messages can make it out before the ensure is hit - Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again #!rb none #!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General Change 3657970 on 2017/09/22 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition. We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game, [at marcus.wassmer,] [at arne.schober] #!rb none #!tests cycled 6-7 levels of Paragon #!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657914 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing... #!tests stepped through in non-pkg build #!rb none #!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657906 on 2017/09/21 by Andrew.Grant Improved some logging #!tests used locally #!rb none Change 3657891 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing Fixed issue with -dev mode on PS4 not updating symbols #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657867 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Re-locked network CL to 3652780 #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657857 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444 #!RB:arciel.rekman #!Tests:Compiled [CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf #!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657852 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for case-insensitivity causing title.json not to be staged #!rb daniel.lamb, bob.tellez #!tests ran packaging script, verified contents match v42 #!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657831 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors We can worry about a more permanent solution after we get this live. #!RB:none #!Tests: Compiled [CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer #!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657824 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb -------------------------------------- Built new UnrealCEFSubprocess client Changed OrionBuild.xml to build the shipping version of the above. The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this. [at justin.sargent,[at benjamin.crocker,[at wes.fudala]]] #!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657488 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: anton.migulko LIGHTING AND assets update #!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3656388 on 2017/09/21 by Laurent.Delayen Added default GetAxisVector static function to EAxisOption #!rb none #!FYI thomas.sarkanen #!tests lane minions test map Change 3656387 on 2017/09/21 by Laurent.Delayen Initialize FAnimInstanceProxy with default constructor. #!rb none #!fyi lina.halper, thomas.sarkanen #!tests lane minion test map Change 3656003 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3650578 for patching benjamin.crocker #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654403 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Merge DevCore -> Orion Release-43 CL 3641450 UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers. #!rb Daniel.Lamb #!test Compile #!lockdown Andrew.Grant #!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654356 on 2017/09/20 by Andrew.Grant Merging 3653658 from Dev-Rendering #!tests compiled, ran editor #!rb marcus.wassmer Change 3653914 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access). #!rb none #!tests ran locally #!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3652495 on 2017/09/19 by Andrew.Grant Editgration of VR fix in 3643776 from Release-4.17 #!tests #!rb na Change 3652244 on 2017/09/19 by Sam.Zamani #!tencent Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher Added "-q" to whitelist of command line params for shipping builds Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher #!rb rob.cannaday #!tests none Change 3651493 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651490 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651489 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651445 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag #!RB:none #!Tests:none [CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant #!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651059 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed code to archive load-order during tests #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651043 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed error parsing from tests to put cause ahead of file info #!tests ran self-test #!rb none #!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649683 on 2017/09/18 by Andrew.Grant Bulk-merge of oustanding changes in Main to DG #!tests #!rb na Change 3649345 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Integrate fix for eidtor crash when switching between low and high scaleability options. #!rb Olaf.Piesche #!test Paragon editor #!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649335 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - OR-44257 - Fix for hair not working It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion. #!RB:daniel.lamb #!Tests:Re-tested in cooked build [CODEREVIEW] daniel.lamb #!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649231 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM #!RB:none #!Tests:none [CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy #!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649211 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix 'lowest' shadow settings (simple forward rendering) #!rb arne.schober [FYI] Daniel.Wright #!tests monolith #!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649141 on 2017/09/18 by Stephan.Jiang Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source. -- These are hacks for ability videos to work before we have the new Sequencer updates -- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748 #!fyi Andrew.Grant, Max.Preussner #!rb none #!test compile Change 3649087 on 2017/09/18 by Thomas.Ross Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General #!rb none #!tests none #!fyi Andrew.Grant,Jeff.Williams,dan.oconnor Change 3649066 on 2017/09/18 by Max.Preussner WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources #!rb stephan.jiang #!rnx #!tests none Change 3649049 on 2017/09/18 by Max.Preussner Media: Changed audio sample rate warning to verbose log #!fyi stephan.jiang #!rb none #!rnx #!tests none Change 3648752 on 2017/09/18 by Max.Preussner WmfMedia: Fixed race condition in media sound wave #!rb none #!rnx #!tests none Change 3648748 on 2017/09/18 by Max.Preussner WmfMedia: Hack for preventing flicker between media source switching Do not merge to Dev-Main! #!rb stephan.jiang #!rnx #!tests none Change 3648596 on 2017/09/18 by Bart.Hawthorne More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough. Change 3648575 on 2017/09/18 by Sam.Zamani #!tencent Fix for missing library calls when initializing TSS anti cheat SDK #!rb none #!tests compiles win64 server Change 3648556 on 2017/09/18 by Jeff.Williams Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084 Clearing up robomerge #!rb none #!tests none Change 3648533 on 2017/09/18 by clayton.langford Unblocking RM. #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly. #!RB Adric.Worley #!tests none #!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3648219 on 2017/09/18 by Sam.Zamani #!tencent fixed Tencent module thirdparty dll runtime dependency paths fixed DLLHandle not being set #!rb none #!tests none Change 3647998 on 2017/09/18 by Clayton.Langford Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763. #!tests compiled #!rb Adric.Worley Change 3647817 on 2017/09/18 by James.Golding Mirror fix from 4.18 release stream (CL 3647799) to Dev-General Fix out-of-bounds access of cloth mapping data during CPU skinning #!rb benn.gallagher #!jira UE-49628 #!fyi benn.gallagher #!tests convert RiftMage to static mesh Change 3647749 on 2017/09/18 by Benn.Gallagher Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope. This caused matrix transposition to fail after the data was copied in using memcpy BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #!rb none #!tests Editor reimport of clothing assets Change 3646242 on 2017/09/15 by Tyler.Cole Revert shared engine LocalMCP scripts. Change 3646153 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds #!RB:daniel.lamb #!Tests: Ran cooked Client [CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy #!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3646125 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: arne.schober OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews. #!RB Marcus.Wassmer #!tests automated performance tests #!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3645861 on 2017/09/15 by clayton.langford #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW. Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added. To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated. #!tests ran local client/server, preflighted #!rb Ben.Salem #!rnx [FYI] Sean.Tobin, Hunter.Kent, Edward.King #!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3644062 on 2017/09/14 by Aaron.McLeran #!jira OR-44171 Some looping sounds are extremely loud #!rb Ethan.Geller #!tests run paragon, run near water river, don't observe looping sound being very loud Change 3643901 on 2017/09/14 by Laurent.Delayen Integrated CL #!3604725 to fix bug with opening state machines from anim graph. #!rb none #!tests fixes bug #!FYI lina.halper Change 3643641 on 2017/09/14 by Rob.Cannaday Fix unreachable code detected #!rb rob.cannaday #!tests Win64 compile Change 3643326 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TerSafe.dll loading until staging issues can be resolved #!rb none #!tests none Change 3643039 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TSS on servers due to linux build issues #!rb none #!tests none Change 3642438 on 2017/09/13 by Rob.Cannaday Handle new analytics param types (number, string, etc) Stub implementation of FAnalyticsProviderETTencent DefaultAttrs #!rb rob.cannaday #!tests Win64 vs AI match Change 3641655 on 2017/09/13 by Sam.Zamani #!tencent WIP added tss_sdk.dll (server) and TerSafe.dll (client) JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers #!rb none #!tests PC run with RegionCN.pak enabling tencent mode Change 3641559 on 2017/09/13 by Bart.Hawthorne Fix up oodle dictionary generation scripts #!rb none #!jira none Change 3641550 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3641393 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev. Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled - Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false) - Added PGOInput option to TargetRules and passed through to compile environment - Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for - Updated PS4 toolchain to use both LTO and PGO depending on what was set #!tests soaked locally, preflighted #!rb codereviewed FWIW here are before/after results for LTCG. Orion Performance report from 3 games and 1441.51 seconds MVP: 2.83 (Min: 2.05, Max: 3.22) HPM: 4.29 (Min: 4.24, Max: 4.37) AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms) GT: 12.88ms (Min: 12.68ms, Max: 13.25ms) RT: 13.71ms (Min: 13.48ms, Max: 14.08ms) GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms) Orion Performance report from 3 games and 1440.49 seconds MVP: 1.42 (Min: 1.02, Max: 1.94) HPM: 3.25 (Min: 2.75, Max: 3.62) AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms) GT: 11.93ms (Min: 11.64ms, Max: 12.47ms) RT: 12.80ms (Min: 12.54ms, Max: 13.24ms) GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms) #!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640885 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Limited warning to once every 10 secs. #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640875 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed shipping config issue #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640870 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Fixing CIS builds #!Orion The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors. [CODEREVIEW] John.Nielson #!rb none #!test compilation #!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640783 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson More temporary logging for finding the missing FX issue. #!rb: none #!Test: Pie #!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639910 on 2017/09/12 by Rob.Cannaday Build fix for AnalyticsETTencent #!rb rob.cannaday #!tests compile Win64 DebugGame Editor Change 3639565 on 2017/09/12 by Laurent.Delayen SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0. #!rb lina.halper #!FYI lina.halper #!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime. Change 3639228 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Tools - Added ability to postmortem a PS4 devkit for last crash #!rb run locally #!tests none #!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639075 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Specifically requesting 'all' configuration, to avoid missing manifest in jar. #!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639022 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka Remove dependency on the editor style set in the WidgetReflector - Fixes a crash when trying to use the reflector in a client cooked build - Also updated Focusable column name to shared var #!rb none #!tests Widget Reflected in a cooked build #!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638984 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638696 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Swapped problematic ensure to LogError, made draft obey notimeouts. #!tests compiled #!rb none [at daniel.lamb] #!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638644 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Third time's the charm #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638628 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure in a PS4 friendly way #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638583 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure to get a cook #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638545 on 2017/09/12 by Bart.Hawthorne Add analytics for oodle compression percentages #!rb ryan.gerleve, wes.hunt #!tests ran a 2 person game with dedicated server and verified analytics were reported #!jira OR-26386 Change 3638172 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Duplicate 3620803 Partial Fix for Dither Opacity Mask #!rb none #!tests PC monolith #!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637643 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Fixing version stream to Main #!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637524 on 2017/09/11 by Andrew.Grant Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests build Win64 editor, ran tests locally #!rb none Change 3637402 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Restored logging of runoptions when not verbose #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637357 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Made 'none' test specify Attended #!rb Daniel.Lamb #!tests compiled #!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637305 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added temporary debug logging cmd line option for finding Jira OrionOR-43600 #!RB: none #!Test: Pie [at David.Ratti] #!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636549 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues #!RB:none #!Tests:none [CODEREVIEW] uriel.doyon #!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636507 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka [OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG. Also: - Added distance formatting type for simple ability description values (will automatically append u to the value) - SimpleAbility description values can now go up to two decimal places Engine: - Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName #!rb Matt.Schembari #!tests PIE OrionEntry & FrontEndScene - various bug repros #!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636372 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Implement fast particle pool memory. Default is 2mb, automatically cleans up oldest used pool slots. Estimated 1/4 time for STAT_PARTALLOC. #!rb Jason.Bestimt #!test paragon ps4 cooked #!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636319 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue with fatal error message not being shown in reports. Fixed issue where some cancelled tests reported as succeeded #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636264 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance #!RB:none #!Tests: Ran client cooked build [CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon [QAREVIEW] #!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635288 on 2017/09/10 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices Fixed missing - in SoloSmoke args that were causing trailing params to be lost #!tests preflighted, ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635145 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to pick up SDK change for patch packages #!rb none #!tests none #!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635097 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added cleardevices option to Gauntlet that removes all devices after running. Added to Orion build scripts #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634985 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Cleaned up some logging around device failures Attempt to handle "Too Many Connections" error at a lower level Added removeall command to PS4DevkitUtil (not yet used) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634897 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Checking in change to timeouts to test theory #!tests ran test locally #!rb none #!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634765 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Scrape another .05ms out of GPU particle simulation. #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634422 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for Gauntlet shutdown issue on builders Fix for BP editing crash from Dev-Framework #!tests ran locally #!rb none! #!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634139 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running #!tests ran locally with single and file-based devices #!rb none #!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633799 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only. #!rb none #!tests monolith02 turrets [CODEREVIEW] lina.halper #!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633647 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Possible fix for OR-43926 from Arne #!tests ran locally, observed no ensures or negative side-effects in UI or HUD #!rb none #!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633637 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Upped timeout for editorbased tests #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632565 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed some test code... #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632385 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device handling. Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems. #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632177 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43 #!rb none #!test local commandlet #!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632131 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix a bug with new local vector-field only project setting #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632034 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where problem devices were reset each attempt #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631812 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device management in Gauntlet #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631787 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes. #!rb none [CODEREVIEW] martin.wilson #!test bot game #!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631251 on 2017/09/07 by Andrew.Grant Additional device selection improvements #!tests #!rb na Change 3630861 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3630620 on 2017/09/07 by Laurent.Delayen RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions. #!rb Ori.Cohen #!codereview benn.gallagher #!tests lane minions test map Change 3629990 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fix for gpu hang on ps4. #!rb Marcus.Wassmer #!test Paragon cooked ps4 #!jira OR-43835 #!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629980 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Moved some missed code to FDebug::HasAsserted() #!tests na #!rb none #!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629975 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Project optimization to only support local vector fields. separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost. #!rb olaf.piesche #!tests monolith ps4/pc #!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629917 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix for sizebyspeed on ps4 #!rb Simon.Tovey #!tests pc #!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629620 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629554 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored screenshot support to gauntlet (now driven externally) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629495 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: don.eubanks Stat panel will only show stat changes or improvements that come from Item sources (cards / gems) #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE [RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base! #!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629468 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring() Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread. #!tests ran locally #!rb none [at marcus.wassmer] #!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629410 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs -------------------------------------- Fix for generating project files #!tests GPF #!rb none #!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629369 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests) #!rb none #!tests verified signing is disabled and game gets to main menu with -fileopenlog [at graeme.thornton] #!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629254 on 2017/09/06 by Laurent.Delayen URO: ensure we don't skip more frames than desired when switching LODs. #!rb lina.halper #!codereview martin.wilson, benn.gallagher #!test lane minions test map Change 3629191 on 2017/09/06 by Laurent.Delayen Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions. #!rb lina.halper #!codereview martin.wilson #!test lane minions test map Change 3629130 on 2017/09/06 by Laurent.Delayen AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug. #!rb none #!tests lane minion test map Change 3628300 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed exception that could occur during tests if all devices were in use #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627915 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Undoing Oodle check for the time being #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627875 on 2017/09/06 by Jason.Bestimt #!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables) #!RB:none #!Tests:none #!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker #!ROBOMERGE: MAIN, 43 Change 3627694 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Improved warnings #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627642 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: david.ratti More logging for OR-43892 and OR-43779 #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627247 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed check that turns out to be bogus #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627240 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures #!tests compiled OrionClient [at daniel.lamb] #!rb none #!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627211 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added ensure for OR-43777 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626839 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added wait to PS4DevkitUtil before trying to postmortem crashdump #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626755 on 2017/09/05 by Rob.Cannaday Merge //Orion/Release-Tencent to //Orion/Dev-General Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded #!rb sam.zamani #!lockdown andrew.grant #!tests Win64 vs AI match, QA smoke test #!fyi sam.zamani Change 3626285 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed BaseDir argument not being correctly applied in tests Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626221 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame. Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement #!rb none #!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz [at Laurent.Delayen] [FYI] [at Andrew.Grant] #!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3625925 on 2017/09/05 by Laurent.Delayen If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want. #!rb benn.gallagher #!codereview martin.wilson, lina.halper #!tests lane minion map Change 3624051 on 2017/09/02 by Andrew.Grant Fixed issue with test params not being set. Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability. #!tests preflighted #!rb none #!review-3624052 @ben.salem Change 3623907 on 2017/09/02 by Andrew.Grant Fixed usesyncedbuild option being broken in Gauntlet #!codereview @daniel.lamb #!tests compiled #!rb none Change 3623906 on 2017/09/02 by David.Ratti Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides #!rb none #!test future wukong pie Change 3623766 on 2017/09/01 by Daniel.Wright [Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box #!rb none #!Tests PC QAGame Change 3623518 on 2017/09/01 by Don.Eubanks Fix for Shipping Client PS4 #!rb none #!tests Compile Shipping Client PS4 #!fyi daniel.lamb andrew.grant Change 3623515 on 2017/09/01 by Daniel.Wright [Copy] Volume materials applied to static meshes operate on the object's bounding sphere #!rb none #!TESTS QAGame PC Change 3623503 on 2017/09/01 by Daniel.Wright [Copy] Fixed ObjectRadius in Volume domain materials #!rb none #!TESTS none Change 3623102 on 2017/09/01 by Marcus.Wassmer Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand #!rb none #!tests monolith on PS4 #!fyi olaf.piesche,tim.elek Change 3623096 on 2017/09/01 by Marcus.Wassmer checkslow -> check to find issues with ILC #!rb none #!tests ran monolith on ps4 Change 3622744 on 2017/09/01 by Laurent.Delayen RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now). Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies. Take gravity from movement component if present, to inherit custom gravity scaling. Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used. If LOD enables new bodies, they are now initialized during simulation. Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default. Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change. Added AnimStats for PreUpdate, Update and Eval. #!rb ori.cohen #!codereview ori.cohen, lina.halper, benn.ghallager #!tests lane minion test map Change 3622743 on 2017/09/01 by Laurent.Delayen Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes. #!rb lina.halper #!tests lane minion test map Change 3622742 on 2017/09/01 by Laurent.Delayen 'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings. Renamed DisplayDebugCustom to DisplayDebugInstance. #!rb lina.halper #!tests lane minion test map Change 3622738 on 2017/09/01 by Laurent.Delayen Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams #!rb lina.halper #!tests lane minion test map Change 3622666 on 2017/09/01 by Jian.Ru Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements #!jira UE-48972, OR-43455 #!rb Chris.Bunner #!tests editor Change 3622579 on 2017/09/01 by Andrew.Grant Fixed shutdown issues with some tests being detected as errors Simplied and cleanup some things in state management of tests. #!tests ShortSOloGame test locally #!rb none Change 3622322 on 2017/09/01 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-40366 from v43 #!tests compiled #!rb Aaron.McLeran #!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3621054 on 2017/08/31 by Andrew.Grant Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests preflighted #!rb none Change 3620755 on 2017/08/31 by Daniel.Lamb Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations. #!rb Jason.Bestimt #!test Cooked paragon ps4 Change 3620541 on 2017/08/31 by Ben.Salem Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting. #!rb none #!tests compiled. Change 3620443 on 2017/08/31 by Mieszko.Zielinski Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4 #!rb none #!test golden path Change 3620428 on 2017/08/31 by Aaron.McLeran #!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General #!rb Ethan.Geller #!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports. Change 3620411 on 2017/08/31 by Mieszko.Zielinski Fix to removal of simuli sources from the AISense_Sight #!UE4 Made sure given source gets removed from ObservedTargets. #!rb none #!test golden path Change 3620343 on 2017/08/31 by Ben.Salem Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on. #!rb clayton.langford #!tests ran shallow and normal FX tests, generated hitches to display. Change 3620050 on 2017/08/31 by Luke.Thatcher [ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/... - USE_DEFRAG_ALLOCATOR was not always defined in all cases. #!rb Daniel.Lamb #!tests none Change 3619836 on 2017/08/31 by Andrew.Grant Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team) #!tests preflighted, ran locally #!rb none Change 3618597 on 2017/08/30 by Dan.Hertzka Fixed Additive UI materials not being affected by the widget opacity - We needed to multiply the sampled color by the alpha of the vertex color Also added fade in anim for scoreboard when showing after the endgame cinematic #!rb Nick.Darnell #!tests Widget alpha affects additive materials Change 3618441 on 2017/08/30 by Laurent.Delayen Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display. #!rb lina.halper #!tests lane minions Change 3618404 on 2017/08/30 by Paul.Moore - Update to new MMS client API from Fortnite. - Add MMS API plugin. #!rb none #!tests matchmaking, v2 MMS matchmaking, draft lobby. #!lockdown andrew.grant Change 3618167 on 2017/08/30 by Marcus.Wassmer Fix fog on PS4, also volume texture clears. #!rb luke.thatcher #!fyi Jordan.Walker #!tests ran monolith on ps4 Change 3617911 on 2017/08/30 by Andrew.Grant Fix for OR-43401, lighting remaining unbuilt #!tests ran cook, verified that lighting for bp components is now correctly found. #!rb marc.audy Change 3617765 on 2017/08/30 by Andrew.Grant Fix for lighting always being unbuilt on some blueprints #!tests cooked data and verified BP components have the correct transform and receive cached lighting data #!rb marc.audy, bp-team Change 3617757 on 2017/08/30 by Laurent.Delayen clang fix #!rb none #!tests none Change 3617700 on 2017/08/30 by Laurent.Delayen Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated. #!rb lina.halper #!tests lane minions map Change 3617695 on 2017/08/30 by Laurent.Delayen Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays. #!rb lina.halper #!tests test lane minions map Change 3616757 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-43459 from Laurent #!tests na #!rb Lina.Halper, Andrew.Grant #!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616745 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3609966 in anticipation of patch #!rb #!tests na #!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616551 on 2017/08/29 by Daniel.Lamb Fix memory leak in paragon. #!rb Andrew.Grant #!test Paragon ps4 Change 3613700 on 2017/08/28 by Andrew.Grant Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion Renabled r.Cache.UpdatePrimsTaskEnabled #!tests ran locally #!rb none Change 3613694 on 2017/08/28 by Andrew.Grant Added -teamsize argument to Orion none test. #!tests ran None test :) #!rb none Change 3613638 on 2017/08/28 by Ben.Salem Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created. #!rb clayton.langford #!tests Ran shallow and deep test for multiple characters. Change 3612731 on 2017/08/28 by Chris.Bunner [DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook. #!rb #!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb #!tests Cooking/running simple scene with grass foliage #!jira UE-48698, OR-42612 Change 3612695 on 2017/08/28 by Andrew.Grant Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things. #!tests ran NoneTest with -nomcp #!rb none Change 3612002 on 2017/08/27 by Andrew.Grant Fix for crash seen during nightly tests #!tests baseline perf didn't crast 3/3 #!rb none Change 3611980 on 2017/08/27 by Andrew.Grant PS4DevkitUtil post-mortem improvements to logging #!tests run ShortSoloGame #!rb none Change 3611758 on 2017/08/26 by Andrew.Grant Fix for warning #!tests #!rb na Change 3611737 on 2017/08/26 by Andrew.Grant Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering 3517039 - GitHub #!2655: Optimization for shadow map resolution selection for spot lights * Use the radius of the inscribed sphere at the cone end as the spot light's screen radius Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly 3545241 - Fixed spotlight whole scene shadows using a radius 2x too long 3545347 - Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame. #!rb none #!tests compiled Change 3611718 on 2017/08/26 by andrew.grant #!CodeReview: andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs -------------------------------------- Improved parsing of callstacks and errors in test logs Added unit test for error parsing #!tests ran locally, unit tests #!rb none #!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611704 on 2017/08/26 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Test fixes - addresses issue with memory report failing #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611683 on 2017/08/26 by Andrew.Grant Upgraded PS4 SDK to 4.508.111 #!tests SoloGames locally #!rb none Change 3611466 on 2017/08/25 by Andrew.Grant Changed none test to use monolith02 by default #!tests compiled #!rb none Change 3611167 on 2017/08/25 by Laurent.Delayen Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated. #!rb none #!tests lane minions #!codereview martin.wilson Change 3610850 on 2017/08/25 by dan.hertzka Unclog Robomerge #!rb none #!tests none Change 3610325 on 2017/08/25 by Andrew.Grant Compile fix for PS4 #!tests compiled #!rb none Change 3610018 on 2017/08/25 by Laurent.Delayen UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later. #!rb lina.halper #!tests venus ult on minion lane test map Change 3609967 on 2017/08/25 by Daniel.Lamb Merging using //Fortnite/Main/->//Orion/Dev-General/ Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4. CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping. - The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out. - Added an extra flag to reset mip bias values when texture memory budget is increased. #!rb Uriel.Doyon #!jira FORT-45385 #!jira FORT-47739 CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4. - Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled. - Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted. - Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps. #!jira FORT-45229 #!rb Ben.Woodhouse CL 3564368 LLM Changes Summary: LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead. Changes where LLM hooks into the various allocation functions and pools. Added more LLM tracking scopes. Changed the way LLM gets its internal memory. Writing stats out to csv Fixed a few bugs with the tracker code Details: * re-enabled LLM by default in Dev builds for XB1 and PS4 * Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update) * track allocations made from the defrag pool (PS4) * track non-drfrag pool garlic allocations (PS4) * track allocations made from PS4 malloc * combined the RHI and Malloc trackers into the Default tracker * changed stat groups to LLM, LLMPlatform and LLMOverhead * OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set * XMemAlloc now uses AllocationType if no LLM scope has been set * renamed VirtualMap to LLMMap * added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled. * support for tracking allocations that move in memory (for the PS4 defrag allocator) * support for tracking explicit memory without pausing the tracker * LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg * fixed check in FNameToTag. It was checking the wrong value when verifying the name index * show a warning on screen if LLM has been enabled without debug memory enabled (on consoles) * fixed program size tracking * fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope. * optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times) * fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them. * fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled * changed default alloc size for LLMMap to 16K * Added lots more LLM scopes renamed some of the existing ones * made FMemBlock::Allocators private and added accessor functions, which include LLM tracking. * fixed LLM alignment tracking in CustomVirtualAlloc * implemented LLM on XB1 so that it properly tracks D3D12Allocations * added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator * tracking of render targets * fixed LLM pool total column value. #!rb luke.thatcher CL 3565905 [ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/... 3458941 - Initial submission of new PS4 memory allocator. 3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible. 3498440 - Flexible and framebuffer memory fallbacks 3515704 - Add stats to new PS4 memory system. UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly. #!rb Ben.Woodhouse CL 3580934 [FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo. - Neo has 512 MB more direct memory than a base kit. - Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB. #!rb Marcus.Wassmer #!jira FORT-50206 CL 3590180 [FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted. - Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB. - Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool. - Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails. #!jira FORT-49700 #!rb Aaron.McLeran CL 3593920 [FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system. - Incorrect bitmask usage was truncating the available memory value to 32 bits. - Also includes some minor refactoring to make parts more readable. - Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile. #!rb Jonathan.Fitzpatrick #!jira FORT-50918 CL 3597577 [FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU. - Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack. - With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is. #!rb Stewart.Lynch #!jira FORT-50825 #!jira FORT-49688 #!jira FORT-49695 #!jira FORT-50054 CL 3601951 [FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system - Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0. - Added garlic, onion and defrag stats to the platform memory stats struct. - Added fixed pool sizes to platform memory stats. - Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools. #!rb Stewart.Lynch #!jira FORT-52910 #!test preflight with baseline performance memory report tests, local tests on neo #!rb Luke.Thatcher Change 3608480 on 2017/08/24 by Uriel.Doyon Instanced static mesh lightmaps are now updated correctly after lighting scenario changes #!jira UE-48522 #!tests Build lighting, loaded maps #!rb michel.dupuis Change 3608407 on 2017/08/24 by Andrew.Grant Reintegrated ROlando's cloth optimizations #!tests #!rb none Change 3608349 on 2017/08/24 by Rolando.Caloca O - Cloth vertex buffers no longer generate dummy vertices #!rb Lina.Halper #!fyi James.Golding #!tests Check obj list memory with multiple characters, tested animations Change 3607815 on 2017/08/24 by Laurent.Delayen Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha. https://jira.it.epicgames.net/browse/OR-43186 #!rb none #!tests Price hand two bone IK #!codereview lina.halper, thomas.sarkanen Change 3607770 on 2017/08/24 by Andrew.Grant Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong #!tests ran locally, updated parser test #!rb none Change 3607546 on 2017/08/24 by Jian.Ru Add more control to chromatic aberration effect #!jira UE-47138 #!rb Brian.Karis #!tests editor Change 3607270 on 2017/08/24 by Andrew.Grant Mirroring 3605735 from FN to address bug with MIC deduplication #!tests compiled #!rb none Change 3607082 on 2017/08/24 by Laurent.Delayen Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands. List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph). Current debug Target is highlighted in a green bounding box. Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player. Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors. Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation. #!rb dave.ratti #!tests lane minion test map, debugging individual minions #!codereview jon.lietz Change 3606772 on 2017/08/24 by David.Ratti Spot edigrate CL 3606417 for accurate CurveTable memory tracking #!rb none #!tests none [CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
FText GetDisplayNameForClass( UClass* Class, const FAssetData* AssetData = nullptr) const
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
FText ClassDisplayName;
if ( Class )
{
FAssetToolsModule& AssetToolsModule = FModuleManager::LoadModuleChecked<FAssetToolsModule>("AssetTools");
TWeakPtr<IAssetTypeActions> AssetTypeActions = AssetToolsModule.Get().GetAssetTypeActionsForClass(Class);
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main #lockdown Nick.Penwarden #rb none Change 3720210 on 2017/10/25 by Olaf.Piesche Fixing dynamic material params for ribbons #!codereview scott.kennedy #!rb none #!tests scott's test ribbon Change 3720073 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: frank.fella Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it. #!Tests Minion automated tests no longer crash randomly. #!rb SimonT #!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3719233 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: philip.buuck [OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead). #!rb Matt.Schembari #!tests PIE [QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death #!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3718474 on 2017/10/25 by Yannick.Lange Niagara: Only show isolate menu items on track context menu if it is a system. Rename "Isolate toggle" to "Isolated". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718095 on 2017/10/25 by Yannick.Lange Niagara: Fix crash when not having dynamic parameter in material. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718069 on 2017/10/25 by Yannick.Lange Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3717545 on 2017/10/24 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Removed read / write locks from PipelineStateCache. #!rb Andrew.Grant, Gil.Gribb #!test paragon ps4. #!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3716928 on 2017/10/24 by Shaun.Kime The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime. #!rb olaf.piesche, simon.tovey #!fyi olaf.piesche, simon.tovey, frank.fella #!tests am now able to run Test_minionWave on PS4 Change 3715712 on 2017/10/24 by Yannick.Lange Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3715430 on 2017/10/23 by Shaun.Kime Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it. #!rb none #!fyi simon.tovey #!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime Change 3715368 on 2017/10/23 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main) #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3715226 on 2017/10/23 by Shaun.Kime Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's. #!rb none #!fyi simon.tovey, olaf.piesche, frank.fella #!tests ran in PIE Change 3714645 on 2017/10/23 by Yannick.Lange Niagara: Add ability to create particle system from this emitter in content browser. #!rb Shaun.Kime #!tests n/a Change 3714200 on 2017/10/23 by Olaf.Piesche Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target #!codereview simon #!rb none #!tests Orion Niagara assets Change 3713341 on 2017/10/23 by Yannick.Lange Niagara: Fix NiagaraNodeIF output pins cannot be deleted. Fix NiagaraNodeIF output pins cannot be renamed. #!jira UE-50193 #!jira UE-50193 #!rb Shaun.Kime #!tests n/a Change 3713133 on 2017/10/23 by Yannick.Lange Niagara: Isolate emitters in sequencer UI. - Added being able to extend the sequencer track context menu with a delegate. - Added entry in track context menu to toggle the selected emitters isolation state. - Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters. #!rb Shaun.Kime #!tests n/a Change 3712445 on 2017/10/22 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime UVScale, UniformAorBFloat, and LinearColorAlongVector added. #!rb none #!tests new autotest added #!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3712420 on 2017/10/21 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1. #!rb none [CODEREVIEW] frank.fella [FYI] simon.tovey, olaf.piesche, wyeth.johnson #!tests created an emitter, disabled Acceleration Force.. still compiled. #!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711602 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like: LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData #!jira UE-51511 #!rb Simon.Tovey #!tests n/a #!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711288 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: eric.ketchum [Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work #!rb: None #!tests: PIE [CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime #!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711197 on 2017/10/20 by Olaf.Piesche Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly #!rb none #!tests minion projectile ribbon trail Change 3710634 on 2017/10/20 by Mic.Rooney Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing. #!RB: none #!Test: tested/built locally ran preflight Editor/Monolithics build. #!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3709686 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Added some more timerguards for slow timer manager tick objects. Commented out for now. #!rb Trivial #!test Paragon Cooked ps4. #!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708958 on 2017/10/19 by Shaun.Kime Back out changelist 3708456 .. this was an unintentional change #!rb none #!tests n/a Change 3708839 on 2017/10/19 by Shaun.Kime Merging CL 3708835 Fixing Scott's common crash with adding an emitter with autocompile off #!rb frank.fella #!tests n/a Change 3708784 on 2017/10/19 by Shaun.Kime Merging CL 3708782 //Orion/Main/... to //Orion/DevGeneral/... #!rb none #!tests n/a Change 3708600 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion #!rb none #!test golden path #!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708473 on 2017/10/19 by Shaun.Kime Merging Frank's changes for team color support from Main to Dev-General #!rb Frank.Fella #!tests test_minionwave worked Change 3708456 on 2017/10/19 by Shaun.Kime Particles.Random set to 0.0 #!rb none #!tests n/a Change 3708455 on 2017/10/19 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests passed minion fx autotest Change 3707648 on 2017/10/19 by Shaun.Kime Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made. Defer deletion of dataset to RT. Ensure resets don't mess with data inflight RT commands are using. Checkin on behalf of Simon Tovey #!jira OR-45423 #!rb Simon.Tovey #!tests ran through the LaneMinionFXTests successfully on PC Change 3707096 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago. #!rb none #!tests automated tests pass #!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3706726 on 2017/10/19 by Rob.Cannaday Merge XMPP resource version to use version 2 instead of version 3 #!rb trivial #!tests compile #!ROBOMERGE: Main, 44, Tencent Change 3706349 on 2017/10/19 by Josh.Markiewicz #!UE4 - Cross Voice code review feedback - fixed up broken stack vs queue - fixed GetRoomId returning int32 instead of uint64 - fixed switch room logic - more/better logging - more comments #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday #!rb none #!tests local cheat codes Change 3705453 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: arne.schober Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array) #!RB Daniel.Wright #!Tests LaunchOnPs4 #!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3705399 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: scott.kennedy Default Niagara emitter changed color property to better default value. Updated basic glow emitter Added energy bubble base emitter put a little more polish into siege minion impact FX. #!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3704426 on 2017/10/18 by Shaun.Kime Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423 #!rb simon.tovey #!fyi hunter.kent #!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure Change 3703288 on 2017/10/18 by Olaf.Piesche Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash #!rb olaf.piesche, simon.tovey #!tests minion test map PC and PS4 Change 3701373 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader. #!rb Olaf.Piesche #!tests test_minionwave runs #!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3701108 on 2017/10/17 by Hunter.Kent Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily. #!RNX #!Test PS4 #!rb @tim.elek #!review-3701110 @andrew.grant, @daniel.lamb Change 3701044 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: jon.lietz - white space fixes - added in more detail to logging - fixed dragon GC to not hide when the mesh is hidden #!rb none #!tests complies and logging is updated [FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen #!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3700900 on 2017/10/17 by Shaun.Kime Integrating possible crash fix from Dev-Niagara to Dev-Gen #!rb none #!tests n/a #!fyi Olaf.Piesche Change 3700492 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests done in branch Change 3700217 on 2017/10/17 by Olaf.Piesche Fix for potential crash in sprite renderer #!rb none #!tests minion test map Change 3700216 on 2017/10/17 by Benn.Gallagher Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master. #!rb Lina.Halper #!jira OR-45226 #!tests PIE + Standalone games hitting Rampage with Ghosts E Change 3699660 on 2017/10/17 by Jason.Bestimt #!ORION_DG - Fixes to UnrealHitchParser edge cases #!RB:none #!Tests: Ran on Logs from QA #!CodeReview: ben.salem Change 3699462 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!tests preflight ok #!rb none Change 3699010 on 2017/10/17 by Jeff.Williams Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920 #!rb none #!tests none Change 3698519 on 2017/10/16 by Olaf.Piesche Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts #!rb none #!tests minion wave test map Change 3698380 on 2017/10/16 by Shaun.Kime Updating logic to now support the autoattachment #!rb none #!tests autotests pass.. Change 3698263 on 2017/10/16 by Olaf.Piesche Assume degrees for sprite rotation #!rb none #!codereview shaun.kime #!tests test sprite emitter Change 3697652 on 2017/10/16 by Olaf.Piesche Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion #!rb none #!tests minion test map Change 3696906 on 2017/10/15 by Shaun.Kime Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers. #!rb none #!tests now no longer generates invalid errors #!fyi frank.fella, olaf.piesche, simon.tovey Change 3695456 on 2017/10/13 by Olaf.Piesche Fix for potential ribbon crash and end-of-ribbon rendering artifacts #!rb none #!codereview scott.kennedy #!tests minion wave test map Change 3694545 on 2017/10/13 by Andrew.Grant Fix for low frequency async loading crash (OR-42535) #!rb gil.gribb #!tests comppiled Change 3694176 on 2017/10/13 by Jeff.Williams Plugin manifest name changed to DLCFile name #!rb none #!tests compile, stage Change 3693582 on 2017/10/12 by Don.Eubanks Fixing PS4 Compile warning (constructor init order not matching member define order) #!rb none #!tests Compile Shipping Client PS4 #!fyi olaf.piesche Change 3693516 on 2017/10/12 by Olaf.Piesche Niagara: Remove mesh renderer assert, replace with early out #!rb none #!tests niagara mesh test asset Merging //Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp Change 3693051 on 2017/10/12 by Ben.Salem Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log. #!rb Clayton.Langford #!tests Parsed a 5mb log with dumphitches down to 23k of hitch data. Change 3692912 on 2017/10/12 by Olaf.Piesche Merging: Niagara ribbon tiling distance #!rb none #!tests ribbon test asset Change 3692835 on 2017/10/12 by Shaun.Kime Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags. #!rb none #!fyi scott.kennedy, wyeth.johnson #!tests n/a Change 3692751 on 2017/10/12 by Shaun.Kime Removing script that shouldn't have come over. #!rb none #!tests n/a Change 3692746 on 2017/10/12 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests opened test level and created new emitter/system Change 3692616 on 2017/10/12 by Don.Eubanks OR-45131 Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking. #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE #!codereview nick.darnell Change 3691912 on 2017/10/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none #!tests compile, editor #!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3690944 on 2017/10/11 by Jeff.Williams Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC. #!rb Daniel.Lamb #!tests Compile, build Change 3688989 on 2017/10/10 by Lina.Halper LOD sync of attached/parent #!rb: Laurent.Delayen #!tests: price with shotgun skin/PIE/editor Change 3687592 on 2017/10/09 by Ben.Salem Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test. #!rb clayton.langford #!tests Ran sparrow shallow tests. Change 3686560 on 2017/10/09 by Shaun.Kime Flipping the min/max values to be standard #!rb none #!tests n/a Change 3686046 on 2017/10/09 by Shaun.Kime Merging latest from Dev-Niagara in preparation for Effects team work on Monday #!rb none #!tests successful preflight #!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek Change 3685613 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: simon.tovey Implementing vector field matrix inverse fix from CL3675167 to 43.3. #!rb none #!tests none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685603 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross RotationalContent Improvements - Fixed potential bug where tags could be updated when not intended on RotationalContentManager - Fix for PIE assert - Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option. - Removing config tag from RotationalContentOverrides in OrionGlobals. New Halloween Gauntlet Test - Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box. #!rb none #!tests local builds / editor / PIE #!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685408 on 2017/10/07 by ben.salem Fixing robomerge error in DevGen #!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. ben.salem, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml -------------------------------------- Merging using DevGen->Release43.3 Repairing mailer for nightly Perf tests, fixing email headers. #!tests run in devgen #!rb none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685073 on 2017/10/06 by Andrew.Grant Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General) #!tests #!rb na Change 3684717 on 2017/10/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where GT & RT times in profile info were reversed :( #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3684512 on 2017/10/06 by Laurent.Delayen Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code. #!rb lina.halper #!tests minion AnimBP nativization Change 3684059 on 2017/10/06 by Max.Preussner Orion: Fixed ability videos not loading on PS4 and/or not looping #!fyi stephan.jiang #!jira OR-44682 #!rb none #!rnx #!tests none Change 3683538 on 2017/10/06 by David.Ratti batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions. -Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players. -Fixes case where killing minions with badass was not displaying pops (prediction key issue) #!rb none #!tests editor, pie #!review-3683539 @Matt.Schembari Change 3683364 on 2017/10/06 by Andrew.Grant Changed warning to info #!tests #!rb na Change 3681999 on 2017/10/05 by Bart.Hawthorne Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion. #!rb cody.haskell #!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore #!jira OR-44111 #!tests Golden path, live spectated numerous matches. Change 3681403 on 2017/10/04 by Josh.Markiewicz #!UE4 - base pass for Tencent Cross SDK - basic testing done with enter/exit/switch room - basic testing of ShowUI - checked in disabled #!rb duck #!tests see above #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday Change 3680623 on 2017/10/04 by David.Ratti Rework for how max movement speed is calculated. The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow. Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored. Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow. GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc). Suggested methods for inspection: AbilitySystem debug hud (Home/End) p.VisualizeMovement (displays final calculated movement speed) Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar) Technical information: 1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool. 2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows. 3. Added a notification for attribute sets when an aggregator is created for one of their attributes. 4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod) 5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension. #!tests pie #!rb FrankG #!codereview Fred.Kimberley, Billy.Bramer #!fyi colin.fogle #!QAReview #!RN #!designchange Change 3680580 on 2017/10/04 by Ben.Salem Repair email titles for various reports. #!rb none #!tests Reran tests. Change 3680438 on 2017/10/04 by Dan.Hertzka GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect - Fixes the HUD status effect feed not showing sources for a lot of itemization abilities Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip #!rb Dave.Ratti #!tests OrionEntry PIE - equipped Sand Speeder #!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on Change 3680344 on 2017/10/04 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Speculative disable of defragging on volumetric lightmap textures. #!rb andrew.grant #!test monolith2 ps4 #!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3680302 on 2017/10/04 by Shaun.Kime Integration from DevNiagara. Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array. #!rb none #!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek #!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass. Change 3679946 on 2017/10/04 by Laurent.Delayen Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches. #!rb lina.halper #!FYI andrew.grant #!tests monolith2 old minions Change 3679938 on 2017/10/04 by Daniel.Lamb Allowed foliage cullall option to be modified by scalability options. #!rb Trivial #!test Compile paragon editor Change 3679563 on 2017/10/04 by Jon.Lietz OR-43599 - added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it. #!rb Dave.Ratti #!review-3679564 @John.Nielson #!tests added these waits to hot pursuit and they worked as expected Change 3679006 on 2017/10/03 by Ben.Salem Try to fix broken nightly mailer issues for FX tests. #!rb none #!tests Preflighted a shallow fx pass successfully in EC. Change 3677845 on 2017/10/03 by Andrew.Grant Added an ensure to guard against OR-44826 while further investigations occur #!tests compiled #!rb none Change 3677443 on 2017/10/03 by John.Nielson Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase. Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify). #!RB: None #!Test: Pie, Uncooked #!review-3677445: @David.Ratti Change 3676748 on 2017/10/02 by Laurent.Delayen Minions: split body layer is now done in mesh space, to maintain upper body orientation. #!FYI ray.arnett, lina.halper #!rb none #!test lane minion test map Change 3675950 on 2017/10/02 by Don.Eubanks Added several new supported tags / status effects to the Floating Status Effect Text system. Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player. Added ScaleOverDistance curve support for floating numbers / text. Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out. #!rb matt.schembari #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 Change 3675186 on 2017/10/02 by Mic.Rooney Support for other anim curve driving audio types (right now specifically DialogueWave) #!RB: none #!Test: compiled editor/monolithics/withoutunity and tested locally. #!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3675167 on 2017/10/02 by Shaun.Kime Changed unsafe InverseFast() to an Inverse() #!jira OR-44671 #!rb Simon.Tovey #!tests n/a Change 3674888 on 2017/10/02 by David.Ratti GGP V2 * Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration. Item System: * Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords. * Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup). Ability System: * SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE) #!rb none #!tests editor pie cooked #!review-3674889 @Jon.Lietz Change 3674170 on 2017/09/30 by Mieszko.Zielinski Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load. #!rb none #!test golden path #!OR-44738 Change 3672937 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files #!tests 3compiled #!rb none #!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672867 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored previous behaviour of integer numbers being formatted as "1" and not "1.00" #!tests ran game, checked playlist analytic #!rb nikdel #!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672575 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Remove warning that can happens normally with backwards compat replays #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672548 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Andrew.Grant #!test Editor building hlods #!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672542 on 2017/09/29 by Andrew.Grant Merging #!rb #!tests na Change 3672390 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed memreport settings for frontend tests #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672385 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Reworked and pretty much final PipelineState cache code - various comments incorporated - namespaced functions - removed redundant class and replaced with ref pointer #!tests soaked a lot [at daniel.lamb,] [at arne.schober] #!rb none #!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672281 on 2017/09/29 by Rob.Cannaday Add user ID to OnNetworkCheatDetected #!jira TEN-272 #!jira TEN-273 #!jira TEN-274 #!rb rob.cannaday #!tests Win64 AI match, simulate cheat detected by cheat command #!review-3672282 @ian.fox @sam.zamani Change 3671688 on 2017/09/29 by Frank.Gigliotti Added ability to set developer comment when adding native tags. #!RB David.Ratti #!Tests None Change 3670409 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for dump type made while doing cleanup #!tests compiled Win64, PS4, ran PS4 #!rb none #!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3670399 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed race condition in pipeline state cache Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon (Couple of extra tweaks planned, but this should be GTG for a v43 release) #!rb codereviewed #!tests soaked locally, lots #!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669802 on 2017/09/28 by Andrew.Grant From Dev-Framework #!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed #!rb michael.noland #!codereview andrew.grant #!tests na Change 3669709 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669177 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Reflection Captures support Lighting Scenarios without recapturing * Reflection Captures are now part of the Map Build * Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message) * Reflection Capture build data moved to the BuildData package * Building lighting / reflection captures no longer dirties ULevels * Sky lights which capture the scene now work correctly with Lighting Scenarios * Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded) #!rb Marcus.Wassmer #!TESTS Paragon editor Monolith02 #!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669124 on 2017/09/28 by Daniel.Lamb Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush Fix cook in devgeneral Bumped shader version to invalidate stale uniform buffer name. #!rb none #!TESTS none #!fyi Daniel.Wright Change 3667906 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667899 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Remove unused SM4 reflection capture cubemap #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667894 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] SM4 fallback for reflection captures. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667859 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] Removed old rasterized deferred reflection env path. Removed reflection compute shader. Replaced with PS. Small perf gain. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667852 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed missing include #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667807 on 2017/09/27 by Daniel.Lamb Tencent DLC can now remap the plugin content to the game root directory. #!rb Ben.Marsh #!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test Change 3667753 on 2017/09/27 by Clayton.Langford Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer. #!RB Ben.Salem, Adric.Worley #!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat Change 3667408 on 2017/09/27 by Jordan.Walker Optimization to bakedNormal layer blend on Low end material quality -uses simple multiply and add normal map blend Change 3667388 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times. #!rb none #!TESTS QAGame on console #!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667383 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667265 on 2017/09/27 by Daniel.Lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Uriel.Doyon #!test Editor building hlods Change 3667159 on 2017/09/27 by Mieszko.Zielinski Added simple logging to BT loading allowing us to identify missing BB keys #!Orion #!test golden path #!rb Lukasz.Furman Change 3665944 on 2017/09/26 by Dan.Hertzka Fix PS4 compile #!rb none #!tests compile PS4 Change 3665590 on 2017/09/26 by Daniel.Lamb Fix for DLC cooking everything when it should only cook the DLC. #!rb None #!test None Change 3665569 on 2017/09/26 by Dan.Hertzka New status effect feed for the new HUD: - Now placed in the mid-upper-left side of the HUD - Biggest difference from before is that there are now names associated with each effect - If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet. Cleaning: - Deleted all of the old buff widget classes & codepaths - Removed redundant properties from StatusEffectDisplayInfo - Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData Also: - Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events - Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed) @todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.) #!rb Don.Eubanks #!tests OrionEntry PIE with some cards and hero abilities #!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial. #!lockdown Billy.Rivers Change 3665555 on 2017/09/26 by Daniel.Lamb AudioStreaming mpsc queue fix up. #!rb Andrew.Grant #!test Compile paragon client / editor. Change 3665517 on 2017/09/26 by Daniel.Lamb Suspect fix for OR-44619 #!jira OR-44619 #!test Paragon editor compile #!rb Trivial Change 3664346 on 2017/09/26 by Jon.Lietz - making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out. - Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired. - Updated all GC's data to use the new decal class - removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent #!rb Dave.Ratti #!reivew Dave.Ratti #!tests used characters that had decal comps in the GC and they recylce as expected. #!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed. Change 3664099 on 2017/09/26 by Jon.Lietz OR-44510 - bringing over engine fixes for the Enum Redirector from Dev-Framework #!rb none #!tests compiles and warnings are gone Change 3663019 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Gil: fixed race condition in the PipelineStateCache #!rb Daniel.Lamb #!test paragon ps4 with higher repro modified build #!lockdown Andrew.Grant #!jira OR-44441 #!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663014 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready. #!tests ran locally #!rb [at daniel.lamb] [at arne.schober] #!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663004 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed dev check for extra commandline args from /data to /temp0 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662999 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Fixed DateTime used for folders not being set #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662255 on 2017/09/25 by Sam.Zamani #!tencent - fix for link error due to missing define of static OnNetworkCheatDetected delegate #!rb none #!tests none Change 3662073 on 2017/09/25 by Sam.Zamani #!tencent Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server Possible options #!jira TEN-275 TSS detect and expose punish user callbacks KickClient - User should be booted from the current game session via disconnect KickMatch - User received info about being punished (eg. ban type etc) PunishInfo - User received info about being punished (eg. ban type etc) #!rb rob.cannaday #!tests none Change 3659487 on 2017/09/22 by Josh.Markiewicz #!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin #!review-3659190 john.barrett, ryan.gerleve Change 3659485 on 2017/09/22 by Josh.Markiewicz #!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins #!fyi john.barrett, ryan.gerleve Change 3659184 on 2017/09/22 by Josh.Markiewicz #!UE4 - delete EpicSurvey module #!fyi justin.sargent, nick.darnell #!rb none Change 3658697 on 2017/09/22 by Ryan.Gerleve Fixes for server-side Tencent anti-cheat library integration: -Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows -Add getter for the TssSdkAntiInterf object -Enable server anti-cheat in editor builds #!codereview sam.zamani #!rb none #!tests enabled Tencent OSS, built & ran server Change 3658200 on 2017/09/22 by Graeme.Thornton Manual copy of CL 3587584 from Dev-Core Logging improvements for pak signature check failures - Added "PakCorrupt" console command which corrupts the master signature table - Added some extra log information about which block failed - Re-hash the master signature table and to make sure that it hasn't changed since startup - Moved the ensure around so that some extra logging messages can make it out before the ensure is hit - Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again #!rb none #!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General Change 3657970 on 2017/09/22 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition. We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game, [at marcus.wassmer,] [at arne.schober] #!rb none #!tests cycled 6-7 levels of Paragon #!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657914 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing... #!tests stepped through in non-pkg build #!rb none #!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657906 on 2017/09/21 by Andrew.Grant Improved some logging #!tests used locally #!rb none Change 3657891 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing Fixed issue with -dev mode on PS4 not updating symbols #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657867 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Re-locked network CL to 3652780 #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657857 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444 #!RB:arciel.rekman #!Tests:Compiled [CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf #!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657852 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for case-insensitivity causing title.json not to be staged #!rb daniel.lamb, bob.tellez #!tests ran packaging script, verified contents match v42 #!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657831 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors We can worry about a more permanent solution after we get this live. #!RB:none #!Tests: Compiled [CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer #!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657824 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb -------------------------------------- Built new UnrealCEFSubprocess client Changed OrionBuild.xml to build the shipping version of the above. The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this. [at justin.sargent,[at benjamin.crocker,[at wes.fudala]]] #!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657488 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: anton.migulko LIGHTING AND assets update #!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3656388 on 2017/09/21 by Laurent.Delayen Added default GetAxisVector static function to EAxisOption #!rb none #!FYI thomas.sarkanen #!tests lane minions test map Change 3656387 on 2017/09/21 by Laurent.Delayen Initialize FAnimInstanceProxy with default constructor. #!rb none #!fyi lina.halper, thomas.sarkanen #!tests lane minion test map Change 3656003 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3650578 for patching benjamin.crocker #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654403 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Merge DevCore -> Orion Release-43 CL 3641450 UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers. #!rb Daniel.Lamb #!test Compile #!lockdown Andrew.Grant #!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654356 on 2017/09/20 by Andrew.Grant Merging 3653658 from Dev-Rendering #!tests compiled, ran editor #!rb marcus.wassmer Change 3653914 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access). #!rb none #!tests ran locally #!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3652495 on 2017/09/19 by Andrew.Grant Editgration of VR fix in 3643776 from Release-4.17 #!tests #!rb na Change 3652244 on 2017/09/19 by Sam.Zamani #!tencent Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher Added "-q" to whitelist of command line params for shipping builds Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher #!rb rob.cannaday #!tests none Change 3651493 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651490 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651489 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651445 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag #!RB:none #!Tests:none [CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant #!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651059 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed code to archive load-order during tests #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651043 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed error parsing from tests to put cause ahead of file info #!tests ran self-test #!rb none #!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649683 on 2017/09/18 by Andrew.Grant Bulk-merge of oustanding changes in Main to DG #!tests #!rb na Change 3649345 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Integrate fix for eidtor crash when switching between low and high scaleability options. #!rb Olaf.Piesche #!test Paragon editor #!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649335 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - OR-44257 - Fix for hair not working It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion. #!RB:daniel.lamb #!Tests:Re-tested in cooked build [CODEREVIEW] daniel.lamb #!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649231 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM #!RB:none #!Tests:none [CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy #!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649211 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix 'lowest' shadow settings (simple forward rendering) #!rb arne.schober [FYI] Daniel.Wright #!tests monolith #!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649141 on 2017/09/18 by Stephan.Jiang Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source. -- These are hacks for ability videos to work before we have the new Sequencer updates -- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748 #!fyi Andrew.Grant, Max.Preussner #!rb none #!test compile Change 3649087 on 2017/09/18 by Thomas.Ross Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General #!rb none #!tests none #!fyi Andrew.Grant,Jeff.Williams,dan.oconnor Change 3649066 on 2017/09/18 by Max.Preussner WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources #!rb stephan.jiang #!rnx #!tests none Change 3649049 on 2017/09/18 by Max.Preussner Media: Changed audio sample rate warning to verbose log #!fyi stephan.jiang #!rb none #!rnx #!tests none Change 3648752 on 2017/09/18 by Max.Preussner WmfMedia: Fixed race condition in media sound wave #!rb none #!rnx #!tests none Change 3648748 on 2017/09/18 by Max.Preussner WmfMedia: Hack for preventing flicker between media source switching Do not merge to Dev-Main! #!rb stephan.jiang #!rnx #!tests none Change 3648596 on 2017/09/18 by Bart.Hawthorne More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough. Change 3648575 on 2017/09/18 by Sam.Zamani #!tencent Fix for missing library calls when initializing TSS anti cheat SDK #!rb none #!tests compiles win64 server Change 3648556 on 2017/09/18 by Jeff.Williams Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084 Clearing up robomerge #!rb none #!tests none Change 3648533 on 2017/09/18 by clayton.langford Unblocking RM. #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly. #!RB Adric.Worley #!tests none #!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3648219 on 2017/09/18 by Sam.Zamani #!tencent fixed Tencent module thirdparty dll runtime dependency paths fixed DLLHandle not being set #!rb none #!tests none Change 3647998 on 2017/09/18 by Clayton.Langford Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763. #!tests compiled #!rb Adric.Worley Change 3647817 on 2017/09/18 by James.Golding Mirror fix from 4.18 release stream (CL 3647799) to Dev-General Fix out-of-bounds access of cloth mapping data during CPU skinning #!rb benn.gallagher #!jira UE-49628 #!fyi benn.gallagher #!tests convert RiftMage to static mesh Change 3647749 on 2017/09/18 by Benn.Gallagher Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope. This caused matrix transposition to fail after the data was copied in using memcpy BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #!rb none #!tests Editor reimport of clothing assets Change 3646242 on 2017/09/15 by Tyler.Cole Revert shared engine LocalMCP scripts. Change 3646153 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds #!RB:daniel.lamb #!Tests: Ran cooked Client [CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy #!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3646125 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: arne.schober OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews. #!RB Marcus.Wassmer #!tests automated performance tests #!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3645861 on 2017/09/15 by clayton.langford #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW. Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added. To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated. #!tests ran local client/server, preflighted #!rb Ben.Salem #!rnx [FYI] Sean.Tobin, Hunter.Kent, Edward.King #!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3644062 on 2017/09/14 by Aaron.McLeran #!jira OR-44171 Some looping sounds are extremely loud #!rb Ethan.Geller #!tests run paragon, run near water river, don't observe looping sound being very loud Change 3643901 on 2017/09/14 by Laurent.Delayen Integrated CL #!3604725 to fix bug with opening state machines from anim graph. #!rb none #!tests fixes bug #!FYI lina.halper Change 3643641 on 2017/09/14 by Rob.Cannaday Fix unreachable code detected #!rb rob.cannaday #!tests Win64 compile Change 3643326 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TerSafe.dll loading until staging issues can be resolved #!rb none #!tests none Change 3643039 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TSS on servers due to linux build issues #!rb none #!tests none Change 3642438 on 2017/09/13 by Rob.Cannaday Handle new analytics param types (number, string, etc) Stub implementation of FAnalyticsProviderETTencent DefaultAttrs #!rb rob.cannaday #!tests Win64 vs AI match Change 3641655 on 2017/09/13 by Sam.Zamani #!tencent WIP added tss_sdk.dll (server) and TerSafe.dll (client) JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers #!rb none #!tests PC run with RegionCN.pak enabling tencent mode Change 3641559 on 2017/09/13 by Bart.Hawthorne Fix up oodle dictionary generation scripts #!rb none #!jira none Change 3641550 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3641393 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev. Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled - Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false) - Added PGOInput option to TargetRules and passed through to compile environment - Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for - Updated PS4 toolchain to use both LTO and PGO depending on what was set #!tests soaked locally, preflighted #!rb codereviewed FWIW here are before/after results for LTCG. Orion Performance report from 3 games and 1441.51 seconds MVP: 2.83 (Min: 2.05, Max: 3.22) HPM: 4.29 (Min: 4.24, Max: 4.37) AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms) GT: 12.88ms (Min: 12.68ms, Max: 13.25ms) RT: 13.71ms (Min: 13.48ms, Max: 14.08ms) GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms) Orion Performance report from 3 games and 1440.49 seconds MVP: 1.42 (Min: 1.02, Max: 1.94) HPM: 3.25 (Min: 2.75, Max: 3.62) AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms) GT: 11.93ms (Min: 11.64ms, Max: 12.47ms) RT: 12.80ms (Min: 12.54ms, Max: 13.24ms) GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms) #!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640885 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Limited warning to once every 10 secs. #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640875 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed shipping config issue #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640870 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Fixing CIS builds #!Orion The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors. [CODEREVIEW] John.Nielson #!rb none #!test compilation #!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640783 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson More temporary logging for finding the missing FX issue. #!rb: none #!Test: Pie #!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639910 on 2017/09/12 by Rob.Cannaday Build fix for AnalyticsETTencent #!rb rob.cannaday #!tests compile Win64 DebugGame Editor Change 3639565 on 2017/09/12 by Laurent.Delayen SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0. #!rb lina.halper #!FYI lina.halper #!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime. Change 3639228 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Tools - Added ability to postmortem a PS4 devkit for last crash #!rb run locally #!tests none #!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639075 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Specifically requesting 'all' configuration, to avoid missing manifest in jar. #!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639022 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka Remove dependency on the editor style set in the WidgetReflector - Fixes a crash when trying to use the reflector in a client cooked build - Also updated Focusable column name to shared var #!rb none #!tests Widget Reflected in a cooked build #!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638984 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638696 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Swapped problematic ensure to LogError, made draft obey notimeouts. #!tests compiled #!rb none [at daniel.lamb] #!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638644 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Third time's the charm #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638628 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure in a PS4 friendly way #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638583 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure to get a cook #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638545 on 2017/09/12 by Bart.Hawthorne Add analytics for oodle compression percentages #!rb ryan.gerleve, wes.hunt #!tests ran a 2 person game with dedicated server and verified analytics were reported #!jira OR-26386 Change 3638172 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Duplicate 3620803 Partial Fix for Dither Opacity Mask #!rb none #!tests PC monolith #!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637643 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Fixing version stream to Main #!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637524 on 2017/09/11 by Andrew.Grant Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests build Win64 editor, ran tests locally #!rb none Change 3637402 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Restored logging of runoptions when not verbose #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637357 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Made 'none' test specify Attended #!rb Daniel.Lamb #!tests compiled #!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637305 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added temporary debug logging cmd line option for finding Jira OrionOR-43600 #!RB: none #!Test: Pie [at David.Ratti] #!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636549 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues #!RB:none #!Tests:none [CODEREVIEW] uriel.doyon #!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636507 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka [OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG. Also: - Added distance formatting type for simple ability description values (will automatically append u to the value) - SimpleAbility description values can now go up to two decimal places Engine: - Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName #!rb Matt.Schembari #!tests PIE OrionEntry & FrontEndScene - various bug repros #!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636372 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Implement fast particle pool memory. Default is 2mb, automatically cleans up oldest used pool slots. Estimated 1/4 time for STAT_PARTALLOC. #!rb Jason.Bestimt #!test paragon ps4 cooked #!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636319 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue with fatal error message not being shown in reports. Fixed issue where some cancelled tests reported as succeeded #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636264 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance #!RB:none #!Tests: Ran client cooked build [CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon [QAREVIEW] #!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635288 on 2017/09/10 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices Fixed missing - in SoloSmoke args that were causing trailing params to be lost #!tests preflighted, ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635145 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to pick up SDK change for patch packages #!rb none #!tests none #!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635097 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added cleardevices option to Gauntlet that removes all devices after running. Added to Orion build scripts #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634985 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Cleaned up some logging around device failures Attempt to handle "Too Many Connections" error at a lower level Added removeall command to PS4DevkitUtil (not yet used) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634897 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Checking in change to timeouts to test theory #!tests ran test locally #!rb none #!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634765 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Scrape another .05ms out of GPU particle simulation. #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634422 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for Gauntlet shutdown issue on builders Fix for BP editing crash from Dev-Framework #!tests ran locally #!rb none! #!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634139 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running #!tests ran locally with single and file-based devices #!rb none #!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633799 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only. #!rb none #!tests monolith02 turrets [CODEREVIEW] lina.halper #!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633647 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Possible fix for OR-43926 from Arne #!tests ran locally, observed no ensures or negative side-effects in UI or HUD #!rb none #!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633637 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Upped timeout for editorbased tests #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632565 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed some test code... #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632385 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device handling. Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems. #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632177 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43 #!rb none #!test local commandlet #!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632131 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix a bug with new local vector-field only project setting #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632034 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where problem devices were reset each attempt #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631812 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device management in Gauntlet #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631787 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes. #!rb none [CODEREVIEW] martin.wilson #!test bot game #!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631251 on 2017/09/07 by Andrew.Grant Additional device selection improvements #!tests #!rb na Change 3630861 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3630620 on 2017/09/07 by Laurent.Delayen RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions. #!rb Ori.Cohen #!codereview benn.gallagher #!tests lane minions test map Change 3629990 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fix for gpu hang on ps4. #!rb Marcus.Wassmer #!test Paragon cooked ps4 #!jira OR-43835 #!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629980 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Moved some missed code to FDebug::HasAsserted() #!tests na #!rb none #!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629975 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Project optimization to only support local vector fields. separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost. #!rb olaf.piesche #!tests monolith ps4/pc #!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629917 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix for sizebyspeed on ps4 #!rb Simon.Tovey #!tests pc #!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629620 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629554 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored screenshot support to gauntlet (now driven externally) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629495 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: don.eubanks Stat panel will only show stat changes or improvements that come from Item sources (cards / gems) #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE [RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base! #!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629468 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring() Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread. #!tests ran locally #!rb none [at marcus.wassmer] #!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629410 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs -------------------------------------- Fix for generating project files #!tests GPF #!rb none #!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629369 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests) #!rb none #!tests verified signing is disabled and game gets to main menu with -fileopenlog [at graeme.thornton] #!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629254 on 2017/09/06 by Laurent.Delayen URO: ensure we don't skip more frames than desired when switching LODs. #!rb lina.halper #!codereview martin.wilson, benn.gallagher #!test lane minions test map Change 3629191 on 2017/09/06 by Laurent.Delayen Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions. #!rb lina.halper #!codereview martin.wilson #!test lane minions test map Change 3629130 on 2017/09/06 by Laurent.Delayen AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug. #!rb none #!tests lane minion test map Change 3628300 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed exception that could occur during tests if all devices were in use #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627915 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Undoing Oodle check for the time being #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627875 on 2017/09/06 by Jason.Bestimt #!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables) #!RB:none #!Tests:none #!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker #!ROBOMERGE: MAIN, 43 Change 3627694 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Improved warnings #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627642 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: david.ratti More logging for OR-43892 and OR-43779 #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627247 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed check that turns out to be bogus #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627240 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures #!tests compiled OrionClient [at daniel.lamb] #!rb none #!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627211 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added ensure for OR-43777 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626839 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added wait to PS4DevkitUtil before trying to postmortem crashdump #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626755 on 2017/09/05 by Rob.Cannaday Merge //Orion/Release-Tencent to //Orion/Dev-General Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded #!rb sam.zamani #!lockdown andrew.grant #!tests Win64 vs AI match, QA smoke test #!fyi sam.zamani Change 3626285 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed BaseDir argument not being correctly applied in tests Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626221 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame. Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement #!rb none #!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz [at Laurent.Delayen] [FYI] [at Andrew.Grant] #!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3625925 on 2017/09/05 by Laurent.Delayen If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want. #!rb benn.gallagher #!codereview martin.wilson, lina.halper #!tests lane minion map Change 3624051 on 2017/09/02 by Andrew.Grant Fixed issue with test params not being set. Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability. #!tests preflighted #!rb none #!review-3624052 @ben.salem Change 3623907 on 2017/09/02 by Andrew.Grant Fixed usesyncedbuild option being broken in Gauntlet #!codereview @daniel.lamb #!tests compiled #!rb none Change 3623906 on 2017/09/02 by David.Ratti Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides #!rb none #!test future wukong pie Change 3623766 on 2017/09/01 by Daniel.Wright [Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box #!rb none #!Tests PC QAGame Change 3623518 on 2017/09/01 by Don.Eubanks Fix for Shipping Client PS4 #!rb none #!tests Compile Shipping Client PS4 #!fyi daniel.lamb andrew.grant Change 3623515 on 2017/09/01 by Daniel.Wright [Copy] Volume materials applied to static meshes operate on the object's bounding sphere #!rb none #!TESTS QAGame PC Change 3623503 on 2017/09/01 by Daniel.Wright [Copy] Fixed ObjectRadius in Volume domain materials #!rb none #!TESTS none Change 3623102 on 2017/09/01 by Marcus.Wassmer Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand #!rb none #!tests monolith on PS4 #!fyi olaf.piesche,tim.elek Change 3623096 on 2017/09/01 by Marcus.Wassmer checkslow -> check to find issues with ILC #!rb none #!tests ran monolith on ps4 Change 3622744 on 2017/09/01 by Laurent.Delayen RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now). Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies. Take gravity from movement component if present, to inherit custom gravity scaling. Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used. If LOD enables new bodies, they are now initialized during simulation. Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default. Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change. Added AnimStats for PreUpdate, Update and Eval. #!rb ori.cohen #!codereview ori.cohen, lina.halper, benn.ghallager #!tests lane minion test map Change 3622743 on 2017/09/01 by Laurent.Delayen Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes. #!rb lina.halper #!tests lane minion test map Change 3622742 on 2017/09/01 by Laurent.Delayen 'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings. Renamed DisplayDebugCustom to DisplayDebugInstance. #!rb lina.halper #!tests lane minion test map Change 3622738 on 2017/09/01 by Laurent.Delayen Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams #!rb lina.halper #!tests lane minion test map Change 3622666 on 2017/09/01 by Jian.Ru Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements #!jira UE-48972, OR-43455 #!rb Chris.Bunner #!tests editor Change 3622579 on 2017/09/01 by Andrew.Grant Fixed shutdown issues with some tests being detected as errors Simplied and cleanup some things in state management of tests. #!tests ShortSOloGame test locally #!rb none Change 3622322 on 2017/09/01 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-40366 from v43 #!tests compiled #!rb Aaron.McLeran #!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3621054 on 2017/08/31 by Andrew.Grant Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests preflighted #!rb none Change 3620755 on 2017/08/31 by Daniel.Lamb Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations. #!rb Jason.Bestimt #!test Cooked paragon ps4 Change 3620541 on 2017/08/31 by Ben.Salem Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting. #!rb none #!tests compiled. Change 3620443 on 2017/08/31 by Mieszko.Zielinski Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4 #!rb none #!test golden path Change 3620428 on 2017/08/31 by Aaron.McLeran #!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General #!rb Ethan.Geller #!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports. Change 3620411 on 2017/08/31 by Mieszko.Zielinski Fix to removal of simuli sources from the AISense_Sight #!UE4 Made sure given source gets removed from ObservedTargets. #!rb none #!test golden path Change 3620343 on 2017/08/31 by Ben.Salem Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on. #!rb clayton.langford #!tests ran shallow and normal FX tests, generated hitches to display. Change 3620050 on 2017/08/31 by Luke.Thatcher [ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/... - USE_DEFRAG_ALLOCATOR was not always defined in all cases. #!rb Daniel.Lamb #!tests none Change 3619836 on 2017/08/31 by Andrew.Grant Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team) #!tests preflighted, ran locally #!rb none Change 3618597 on 2017/08/30 by Dan.Hertzka Fixed Additive UI materials not being affected by the widget opacity - We needed to multiply the sampled color by the alpha of the vertex color Also added fade in anim for scoreboard when showing after the endgame cinematic #!rb Nick.Darnell #!tests Widget alpha affects additive materials Change 3618441 on 2017/08/30 by Laurent.Delayen Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display. #!rb lina.halper #!tests lane minions Change 3618404 on 2017/08/30 by Paul.Moore - Update to new MMS client API from Fortnite. - Add MMS API plugin. #!rb none #!tests matchmaking, v2 MMS matchmaking, draft lobby. #!lockdown andrew.grant Change 3618167 on 2017/08/30 by Marcus.Wassmer Fix fog on PS4, also volume texture clears. #!rb luke.thatcher #!fyi Jordan.Walker #!tests ran monolith on ps4 Change 3617911 on 2017/08/30 by Andrew.Grant Fix for OR-43401, lighting remaining unbuilt #!tests ran cook, verified that lighting for bp components is now correctly found. #!rb marc.audy Change 3617765 on 2017/08/30 by Andrew.Grant Fix for lighting always being unbuilt on some blueprints #!tests cooked data and verified BP components have the correct transform and receive cached lighting data #!rb marc.audy, bp-team Change 3617757 on 2017/08/30 by Laurent.Delayen clang fix #!rb none #!tests none Change 3617700 on 2017/08/30 by Laurent.Delayen Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated. #!rb lina.halper #!tests lane minions map Change 3617695 on 2017/08/30 by Laurent.Delayen Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays. #!rb lina.halper #!tests test lane minions map Change 3616757 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-43459 from Laurent #!tests na #!rb Lina.Halper, Andrew.Grant #!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616745 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3609966 in anticipation of patch #!rb #!tests na #!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616551 on 2017/08/29 by Daniel.Lamb Fix memory leak in paragon. #!rb Andrew.Grant #!test Paragon ps4 Change 3613700 on 2017/08/28 by Andrew.Grant Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion Renabled r.Cache.UpdatePrimsTaskEnabled #!tests ran locally #!rb none Change 3613694 on 2017/08/28 by Andrew.Grant Added -teamsize argument to Orion none test. #!tests ran None test :) #!rb none Change 3613638 on 2017/08/28 by Ben.Salem Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created. #!rb clayton.langford #!tests Ran shallow and deep test for multiple characters. Change 3612731 on 2017/08/28 by Chris.Bunner [DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook. #!rb #!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb #!tests Cooking/running simple scene with grass foliage #!jira UE-48698, OR-42612 Change 3612695 on 2017/08/28 by Andrew.Grant Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things. #!tests ran NoneTest with -nomcp #!rb none Change 3612002 on 2017/08/27 by Andrew.Grant Fix for crash seen during nightly tests #!tests baseline perf didn't crast 3/3 #!rb none Change 3611980 on 2017/08/27 by Andrew.Grant PS4DevkitUtil post-mortem improvements to logging #!tests run ShortSoloGame #!rb none Change 3611758 on 2017/08/26 by Andrew.Grant Fix for warning #!tests #!rb na Change 3611737 on 2017/08/26 by Andrew.Grant Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering 3517039 - GitHub #!2655: Optimization for shadow map resolution selection for spot lights * Use the radius of the inscribed sphere at the cone end as the spot light's screen radius Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly 3545241 - Fixed spotlight whole scene shadows using a radius 2x too long 3545347 - Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame. #!rb none #!tests compiled Change 3611718 on 2017/08/26 by andrew.grant #!CodeReview: andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs -------------------------------------- Improved parsing of callstacks and errors in test logs Added unit test for error parsing #!tests ran locally, unit tests #!rb none #!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611704 on 2017/08/26 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Test fixes - addresses issue with memory report failing #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611683 on 2017/08/26 by Andrew.Grant Upgraded PS4 SDK to 4.508.111 #!tests SoloGames locally #!rb none Change 3611466 on 2017/08/25 by Andrew.Grant Changed none test to use monolith02 by default #!tests compiled #!rb none Change 3611167 on 2017/08/25 by Laurent.Delayen Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated. #!rb none #!tests lane minions #!codereview martin.wilson Change 3610850 on 2017/08/25 by dan.hertzka Unclog Robomerge #!rb none #!tests none Change 3610325 on 2017/08/25 by Andrew.Grant Compile fix for PS4 #!tests compiled #!rb none Change 3610018 on 2017/08/25 by Laurent.Delayen UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later. #!rb lina.halper #!tests venus ult on minion lane test map Change 3609967 on 2017/08/25 by Daniel.Lamb Merging using //Fortnite/Main/->//Orion/Dev-General/ Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4. CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping. - The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out. - Added an extra flag to reset mip bias values when texture memory budget is increased. #!rb Uriel.Doyon #!jira FORT-45385 #!jira FORT-47739 CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4. - Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled. - Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted. - Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps. #!jira FORT-45229 #!rb Ben.Woodhouse CL 3564368 LLM Changes Summary: LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead. Changes where LLM hooks into the various allocation functions and pools. Added more LLM tracking scopes. Changed the way LLM gets its internal memory. Writing stats out to csv Fixed a few bugs with the tracker code Details: * re-enabled LLM by default in Dev builds for XB1 and PS4 * Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update) * track allocations made from the defrag pool (PS4) * track non-drfrag pool garlic allocations (PS4) * track allocations made from PS4 malloc * combined the RHI and Malloc trackers into the Default tracker * changed stat groups to LLM, LLMPlatform and LLMOverhead * OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set * XMemAlloc now uses AllocationType if no LLM scope has been set * renamed VirtualMap to LLMMap * added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled. * support for tracking allocations that move in memory (for the PS4 defrag allocator) * support for tracking explicit memory without pausing the tracker * LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg * fixed check in FNameToTag. It was checking the wrong value when verifying the name index * show a warning on screen if LLM has been enabled without debug memory enabled (on consoles) * fixed program size tracking * fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope. * optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times) * fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them. * fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled * changed default alloc size for LLMMap to 16K * Added lots more LLM scopes renamed some of the existing ones * made FMemBlock::Allocators private and added accessor functions, which include LLM tracking. * fixed LLM alignment tracking in CustomVirtualAlloc * implemented LLM on XB1 so that it properly tracks D3D12Allocations * added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator * tracking of render targets * fixed LLM pool total column value. #!rb luke.thatcher CL 3565905 [ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/... 3458941 - Initial submission of new PS4 memory allocator. 3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible. 3498440 - Flexible and framebuffer memory fallbacks 3515704 - Add stats to new PS4 memory system. UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly. #!rb Ben.Woodhouse CL 3580934 [FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo. - Neo has 512 MB more direct memory than a base kit. - Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB. #!rb Marcus.Wassmer #!jira FORT-50206 CL 3590180 [FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted. - Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB. - Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool. - Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails. #!jira FORT-49700 #!rb Aaron.McLeran CL 3593920 [FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system. - Incorrect bitmask usage was truncating the available memory value to 32 bits. - Also includes some minor refactoring to make parts more readable. - Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile. #!rb Jonathan.Fitzpatrick #!jira FORT-50918 CL 3597577 [FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU. - Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack. - With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is. #!rb Stewart.Lynch #!jira FORT-50825 #!jira FORT-49688 #!jira FORT-49695 #!jira FORT-50054 CL 3601951 [FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system - Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0. - Added garlic, onion and defrag stats to the platform memory stats struct. - Added fixed pool sizes to platform memory stats. - Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools. #!rb Stewart.Lynch #!jira FORT-52910 #!test preflight with baseline performance memory report tests, local tests on neo #!rb Luke.Thatcher Change 3608480 on 2017/08/24 by Uriel.Doyon Instanced static mesh lightmaps are now updated correctly after lighting scenario changes #!jira UE-48522 #!tests Build lighting, loaded maps #!rb michel.dupuis Change 3608407 on 2017/08/24 by Andrew.Grant Reintegrated ROlando's cloth optimizations #!tests #!rb none Change 3608349 on 2017/08/24 by Rolando.Caloca O - Cloth vertex buffers no longer generate dummy vertices #!rb Lina.Halper #!fyi James.Golding #!tests Check obj list memory with multiple characters, tested animations Change 3607815 on 2017/08/24 by Laurent.Delayen Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha. https://jira.it.epicgames.net/browse/OR-43186 #!rb none #!tests Price hand two bone IK #!codereview lina.halper, thomas.sarkanen Change 3607770 on 2017/08/24 by Andrew.Grant Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong #!tests ran locally, updated parser test #!rb none Change 3607546 on 2017/08/24 by Jian.Ru Add more control to chromatic aberration effect #!jira UE-47138 #!rb Brian.Karis #!tests editor Change 3607270 on 2017/08/24 by Andrew.Grant Mirroring 3605735 from FN to address bug with MIC deduplication #!tests compiled #!rb none Change 3607082 on 2017/08/24 by Laurent.Delayen Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands. List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph). Current debug Target is highlighted in a green bounding box. Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player. Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors. Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation. #!rb dave.ratti #!tests lane minion test map, debugging individual minions #!codereview jon.lietz Change 3606772 on 2017/08/24 by David.Ratti Spot edigrate CL 3606417 for accurate CurveTable memory tracking #!rb none #!tests none [CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
if ( AssetTypeActions.IsValid() )
{
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main #lockdown Nick.Penwarden #rb none Change 3720210 on 2017/10/25 by Olaf.Piesche Fixing dynamic material params for ribbons #!codereview scott.kennedy #!rb none #!tests scott's test ribbon Change 3720073 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: frank.fella Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it. #!Tests Minion automated tests no longer crash randomly. #!rb SimonT #!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3719233 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: philip.buuck [OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead). #!rb Matt.Schembari #!tests PIE [QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death #!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3718474 on 2017/10/25 by Yannick.Lange Niagara: Only show isolate menu items on track context menu if it is a system. Rename "Isolate toggle" to "Isolated". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718095 on 2017/10/25 by Yannick.Lange Niagara: Fix crash when not having dynamic parameter in material. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718069 on 2017/10/25 by Yannick.Lange Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3717545 on 2017/10/24 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Removed read / write locks from PipelineStateCache. #!rb Andrew.Grant, Gil.Gribb #!test paragon ps4. #!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3716928 on 2017/10/24 by Shaun.Kime The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime. #!rb olaf.piesche, simon.tovey #!fyi olaf.piesche, simon.tovey, frank.fella #!tests am now able to run Test_minionWave on PS4 Change 3715712 on 2017/10/24 by Yannick.Lange Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3715430 on 2017/10/23 by Shaun.Kime Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it. #!rb none #!fyi simon.tovey #!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime Change 3715368 on 2017/10/23 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main) #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3715226 on 2017/10/23 by Shaun.Kime Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's. #!rb none #!fyi simon.tovey, olaf.piesche, frank.fella #!tests ran in PIE Change 3714645 on 2017/10/23 by Yannick.Lange Niagara: Add ability to create particle system from this emitter in content browser. #!rb Shaun.Kime #!tests n/a Change 3714200 on 2017/10/23 by Olaf.Piesche Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target #!codereview simon #!rb none #!tests Orion Niagara assets Change 3713341 on 2017/10/23 by Yannick.Lange Niagara: Fix NiagaraNodeIF output pins cannot be deleted. Fix NiagaraNodeIF output pins cannot be renamed. #!jira UE-50193 #!jira UE-50193 #!rb Shaun.Kime #!tests n/a Change 3713133 on 2017/10/23 by Yannick.Lange Niagara: Isolate emitters in sequencer UI. - Added being able to extend the sequencer track context menu with a delegate. - Added entry in track context menu to toggle the selected emitters isolation state. - Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters. #!rb Shaun.Kime #!tests n/a Change 3712445 on 2017/10/22 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime UVScale, UniformAorBFloat, and LinearColorAlongVector added. #!rb none #!tests new autotest added #!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3712420 on 2017/10/21 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1. #!rb none [CODEREVIEW] frank.fella [FYI] simon.tovey, olaf.piesche, wyeth.johnson #!tests created an emitter, disabled Acceleration Force.. still compiled. #!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711602 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like: LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData #!jira UE-51511 #!rb Simon.Tovey #!tests n/a #!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711288 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: eric.ketchum [Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work #!rb: None #!tests: PIE [CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime #!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711197 on 2017/10/20 by Olaf.Piesche Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly #!rb none #!tests minion projectile ribbon trail Change 3710634 on 2017/10/20 by Mic.Rooney Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing. #!RB: none #!Test: tested/built locally ran preflight Editor/Monolithics build. #!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3709686 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Added some more timerguards for slow timer manager tick objects. Commented out for now. #!rb Trivial #!test Paragon Cooked ps4. #!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708958 on 2017/10/19 by Shaun.Kime Back out changelist 3708456 .. this was an unintentional change #!rb none #!tests n/a Change 3708839 on 2017/10/19 by Shaun.Kime Merging CL 3708835 Fixing Scott's common crash with adding an emitter with autocompile off #!rb frank.fella #!tests n/a Change 3708784 on 2017/10/19 by Shaun.Kime Merging CL 3708782 //Orion/Main/... to //Orion/DevGeneral/... #!rb none #!tests n/a Change 3708600 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion #!rb none #!test golden path #!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708473 on 2017/10/19 by Shaun.Kime Merging Frank's changes for team color support from Main to Dev-General #!rb Frank.Fella #!tests test_minionwave worked Change 3708456 on 2017/10/19 by Shaun.Kime Particles.Random set to 0.0 #!rb none #!tests n/a Change 3708455 on 2017/10/19 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests passed minion fx autotest Change 3707648 on 2017/10/19 by Shaun.Kime Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made. Defer deletion of dataset to RT. Ensure resets don't mess with data inflight RT commands are using. Checkin on behalf of Simon Tovey #!jira OR-45423 #!rb Simon.Tovey #!tests ran through the LaneMinionFXTests successfully on PC Change 3707096 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago. #!rb none #!tests automated tests pass #!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3706726 on 2017/10/19 by Rob.Cannaday Merge XMPP resource version to use version 2 instead of version 3 #!rb trivial #!tests compile #!ROBOMERGE: Main, 44, Tencent Change 3706349 on 2017/10/19 by Josh.Markiewicz #!UE4 - Cross Voice code review feedback - fixed up broken stack vs queue - fixed GetRoomId returning int32 instead of uint64 - fixed switch room logic - more/better logging - more comments #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday #!rb none #!tests local cheat codes Change 3705453 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: arne.schober Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array) #!RB Daniel.Wright #!Tests LaunchOnPs4 #!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3705399 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: scott.kennedy Default Niagara emitter changed color property to better default value. Updated basic glow emitter Added energy bubble base emitter put a little more polish into siege minion impact FX. #!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3704426 on 2017/10/18 by Shaun.Kime Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423 #!rb simon.tovey #!fyi hunter.kent #!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure Change 3703288 on 2017/10/18 by Olaf.Piesche Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash #!rb olaf.piesche, simon.tovey #!tests minion test map PC and PS4 Change 3701373 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader. #!rb Olaf.Piesche #!tests test_minionwave runs #!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3701108 on 2017/10/17 by Hunter.Kent Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily. #!RNX #!Test PS4 #!rb @tim.elek #!review-3701110 @andrew.grant, @daniel.lamb Change 3701044 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: jon.lietz - white space fixes - added in more detail to logging - fixed dragon GC to not hide when the mesh is hidden #!rb none #!tests complies and logging is updated [FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen #!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3700900 on 2017/10/17 by Shaun.Kime Integrating possible crash fix from Dev-Niagara to Dev-Gen #!rb none #!tests n/a #!fyi Olaf.Piesche Change 3700492 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests done in branch Change 3700217 on 2017/10/17 by Olaf.Piesche Fix for potential crash in sprite renderer #!rb none #!tests minion test map Change 3700216 on 2017/10/17 by Benn.Gallagher Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master. #!rb Lina.Halper #!jira OR-45226 #!tests PIE + Standalone games hitting Rampage with Ghosts E Change 3699660 on 2017/10/17 by Jason.Bestimt #!ORION_DG - Fixes to UnrealHitchParser edge cases #!RB:none #!Tests: Ran on Logs from QA #!CodeReview: ben.salem Change 3699462 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!tests preflight ok #!rb none Change 3699010 on 2017/10/17 by Jeff.Williams Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920 #!rb none #!tests none Change 3698519 on 2017/10/16 by Olaf.Piesche Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts #!rb none #!tests minion wave test map Change 3698380 on 2017/10/16 by Shaun.Kime Updating logic to now support the autoattachment #!rb none #!tests autotests pass.. Change 3698263 on 2017/10/16 by Olaf.Piesche Assume degrees for sprite rotation #!rb none #!codereview shaun.kime #!tests test sprite emitter Change 3697652 on 2017/10/16 by Olaf.Piesche Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion #!rb none #!tests minion test map Change 3696906 on 2017/10/15 by Shaun.Kime Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers. #!rb none #!tests now no longer generates invalid errors #!fyi frank.fella, olaf.piesche, simon.tovey Change 3695456 on 2017/10/13 by Olaf.Piesche Fix for potential ribbon crash and end-of-ribbon rendering artifacts #!rb none #!codereview scott.kennedy #!tests minion wave test map Change 3694545 on 2017/10/13 by Andrew.Grant Fix for low frequency async loading crash (OR-42535) #!rb gil.gribb #!tests comppiled Change 3694176 on 2017/10/13 by Jeff.Williams Plugin manifest name changed to DLCFile name #!rb none #!tests compile, stage Change 3693582 on 2017/10/12 by Don.Eubanks Fixing PS4 Compile warning (constructor init order not matching member define order) #!rb none #!tests Compile Shipping Client PS4 #!fyi olaf.piesche Change 3693516 on 2017/10/12 by Olaf.Piesche Niagara: Remove mesh renderer assert, replace with early out #!rb none #!tests niagara mesh test asset Merging //Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp Change 3693051 on 2017/10/12 by Ben.Salem Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log. #!rb Clayton.Langford #!tests Parsed a 5mb log with dumphitches down to 23k of hitch data. Change 3692912 on 2017/10/12 by Olaf.Piesche Merging: Niagara ribbon tiling distance #!rb none #!tests ribbon test asset Change 3692835 on 2017/10/12 by Shaun.Kime Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags. #!rb none #!fyi scott.kennedy, wyeth.johnson #!tests n/a Change 3692751 on 2017/10/12 by Shaun.Kime Removing script that shouldn't have come over. #!rb none #!tests n/a Change 3692746 on 2017/10/12 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests opened test level and created new emitter/system Change 3692616 on 2017/10/12 by Don.Eubanks OR-45131 Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking. #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE #!codereview nick.darnell Change 3691912 on 2017/10/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none #!tests compile, editor #!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3690944 on 2017/10/11 by Jeff.Williams Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC. #!rb Daniel.Lamb #!tests Compile, build Change 3688989 on 2017/10/10 by Lina.Halper LOD sync of attached/parent #!rb: Laurent.Delayen #!tests: price with shotgun skin/PIE/editor Change 3687592 on 2017/10/09 by Ben.Salem Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test. #!rb clayton.langford #!tests Ran sparrow shallow tests. Change 3686560 on 2017/10/09 by Shaun.Kime Flipping the min/max values to be standard #!rb none #!tests n/a Change 3686046 on 2017/10/09 by Shaun.Kime Merging latest from Dev-Niagara in preparation for Effects team work on Monday #!rb none #!tests successful preflight #!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek Change 3685613 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: simon.tovey Implementing vector field matrix inverse fix from CL3675167 to 43.3. #!rb none #!tests none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685603 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross RotationalContent Improvements - Fixed potential bug where tags could be updated when not intended on RotationalContentManager - Fix for PIE assert - Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option. - Removing config tag from RotationalContentOverrides in OrionGlobals. New Halloween Gauntlet Test - Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box. #!rb none #!tests local builds / editor / PIE #!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685408 on 2017/10/07 by ben.salem Fixing robomerge error in DevGen #!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. ben.salem, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml -------------------------------------- Merging using DevGen->Release43.3 Repairing mailer for nightly Perf tests, fixing email headers. #!tests run in devgen #!rb none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685073 on 2017/10/06 by Andrew.Grant Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General) #!tests #!rb na Change 3684717 on 2017/10/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where GT & RT times in profile info were reversed :( #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3684512 on 2017/10/06 by Laurent.Delayen Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code. #!rb lina.halper #!tests minion AnimBP nativization Change 3684059 on 2017/10/06 by Max.Preussner Orion: Fixed ability videos not loading on PS4 and/or not looping #!fyi stephan.jiang #!jira OR-44682 #!rb none #!rnx #!tests none Change 3683538 on 2017/10/06 by David.Ratti batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions. -Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players. -Fixes case where killing minions with badass was not displaying pops (prediction key issue) #!rb none #!tests editor, pie #!review-3683539 @Matt.Schembari Change 3683364 on 2017/10/06 by Andrew.Grant Changed warning to info #!tests #!rb na Change 3681999 on 2017/10/05 by Bart.Hawthorne Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion. #!rb cody.haskell #!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore #!jira OR-44111 #!tests Golden path, live spectated numerous matches. Change 3681403 on 2017/10/04 by Josh.Markiewicz #!UE4 - base pass for Tencent Cross SDK - basic testing done with enter/exit/switch room - basic testing of ShowUI - checked in disabled #!rb duck #!tests see above #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday Change 3680623 on 2017/10/04 by David.Ratti Rework for how max movement speed is calculated. The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow. Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored. Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow. GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc). Suggested methods for inspection: AbilitySystem debug hud (Home/End) p.VisualizeMovement (displays final calculated movement speed) Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar) Technical information: 1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool. 2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows. 3. Added a notification for attribute sets when an aggregator is created for one of their attributes. 4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod) 5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension. #!tests pie #!rb FrankG #!codereview Fred.Kimberley, Billy.Bramer #!fyi colin.fogle #!QAReview #!RN #!designchange Change 3680580 on 2017/10/04 by Ben.Salem Repair email titles for various reports. #!rb none #!tests Reran tests. Change 3680438 on 2017/10/04 by Dan.Hertzka GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect - Fixes the HUD status effect feed not showing sources for a lot of itemization abilities Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip #!rb Dave.Ratti #!tests OrionEntry PIE - equipped Sand Speeder #!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on Change 3680344 on 2017/10/04 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Speculative disable of defragging on volumetric lightmap textures. #!rb andrew.grant #!test monolith2 ps4 #!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3680302 on 2017/10/04 by Shaun.Kime Integration from DevNiagara. Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array. #!rb none #!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek #!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass. Change 3679946 on 2017/10/04 by Laurent.Delayen Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches. #!rb lina.halper #!FYI andrew.grant #!tests monolith2 old minions Change 3679938 on 2017/10/04 by Daniel.Lamb Allowed foliage cullall option to be modified by scalability options. #!rb Trivial #!test Compile paragon editor Change 3679563 on 2017/10/04 by Jon.Lietz OR-43599 - added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it. #!rb Dave.Ratti #!review-3679564 @John.Nielson #!tests added these waits to hot pursuit and they worked as expected Change 3679006 on 2017/10/03 by Ben.Salem Try to fix broken nightly mailer issues for FX tests. #!rb none #!tests Preflighted a shallow fx pass successfully in EC. Change 3677845 on 2017/10/03 by Andrew.Grant Added an ensure to guard against OR-44826 while further investigations occur #!tests compiled #!rb none Change 3677443 on 2017/10/03 by John.Nielson Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase. Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify). #!RB: None #!Test: Pie, Uncooked #!review-3677445: @David.Ratti Change 3676748 on 2017/10/02 by Laurent.Delayen Minions: split body layer is now done in mesh space, to maintain upper body orientation. #!FYI ray.arnett, lina.halper #!rb none #!test lane minion test map Change 3675950 on 2017/10/02 by Don.Eubanks Added several new supported tags / status effects to the Floating Status Effect Text system. Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player. Added ScaleOverDistance curve support for floating numbers / text. Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out. #!rb matt.schembari #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 Change 3675186 on 2017/10/02 by Mic.Rooney Support for other anim curve driving audio types (right now specifically DialogueWave) #!RB: none #!Test: compiled editor/monolithics/withoutunity and tested locally. #!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3675167 on 2017/10/02 by Shaun.Kime Changed unsafe InverseFast() to an Inverse() #!jira OR-44671 #!rb Simon.Tovey #!tests n/a Change 3674888 on 2017/10/02 by David.Ratti GGP V2 * Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration. Item System: * Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords. * Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup). Ability System: * SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE) #!rb none #!tests editor pie cooked #!review-3674889 @Jon.Lietz Change 3674170 on 2017/09/30 by Mieszko.Zielinski Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load. #!rb none #!test golden path #!OR-44738 Change 3672937 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files #!tests 3compiled #!rb none #!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672867 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored previous behaviour of integer numbers being formatted as "1" and not "1.00" #!tests ran game, checked playlist analytic #!rb nikdel #!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672575 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Remove warning that can happens normally with backwards compat replays #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672548 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Andrew.Grant #!test Editor building hlods #!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672542 on 2017/09/29 by Andrew.Grant Merging #!rb #!tests na Change 3672390 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed memreport settings for frontend tests #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672385 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Reworked and pretty much final PipelineState cache code - various comments incorporated - namespaced functions - removed redundant class and replaced with ref pointer #!tests soaked a lot [at daniel.lamb,] [at arne.schober] #!rb none #!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672281 on 2017/09/29 by Rob.Cannaday Add user ID to OnNetworkCheatDetected #!jira TEN-272 #!jira TEN-273 #!jira TEN-274 #!rb rob.cannaday #!tests Win64 AI match, simulate cheat detected by cheat command #!review-3672282 @ian.fox @sam.zamani Change 3671688 on 2017/09/29 by Frank.Gigliotti Added ability to set developer comment when adding native tags. #!RB David.Ratti #!Tests None Change 3670409 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for dump type made while doing cleanup #!tests compiled Win64, PS4, ran PS4 #!rb none #!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3670399 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed race condition in pipeline state cache Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon (Couple of extra tweaks planned, but this should be GTG for a v43 release) #!rb codereviewed #!tests soaked locally, lots #!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669802 on 2017/09/28 by Andrew.Grant From Dev-Framework #!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed #!rb michael.noland #!codereview andrew.grant #!tests na Change 3669709 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669177 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Reflection Captures support Lighting Scenarios without recapturing * Reflection Captures are now part of the Map Build * Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message) * Reflection Capture build data moved to the BuildData package * Building lighting / reflection captures no longer dirties ULevels * Sky lights which capture the scene now work correctly with Lighting Scenarios * Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded) #!rb Marcus.Wassmer #!TESTS Paragon editor Monolith02 #!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669124 on 2017/09/28 by Daniel.Lamb Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush Fix cook in devgeneral Bumped shader version to invalidate stale uniform buffer name. #!rb none #!TESTS none #!fyi Daniel.Wright Change 3667906 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667899 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Remove unused SM4 reflection capture cubemap #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667894 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] SM4 fallback for reflection captures. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667859 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] Removed old rasterized deferred reflection env path. Removed reflection compute shader. Replaced with PS. Small perf gain. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667852 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed missing include #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667807 on 2017/09/27 by Daniel.Lamb Tencent DLC can now remap the plugin content to the game root directory. #!rb Ben.Marsh #!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test Change 3667753 on 2017/09/27 by Clayton.Langford Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer. #!RB Ben.Salem, Adric.Worley #!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat Change 3667408 on 2017/09/27 by Jordan.Walker Optimization to bakedNormal layer blend on Low end material quality -uses simple multiply and add normal map blend Change 3667388 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times. #!rb none #!TESTS QAGame on console #!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667383 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667265 on 2017/09/27 by Daniel.Lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Uriel.Doyon #!test Editor building hlods Change 3667159 on 2017/09/27 by Mieszko.Zielinski Added simple logging to BT loading allowing us to identify missing BB keys #!Orion #!test golden path #!rb Lukasz.Furman Change 3665944 on 2017/09/26 by Dan.Hertzka Fix PS4 compile #!rb none #!tests compile PS4 Change 3665590 on 2017/09/26 by Daniel.Lamb Fix for DLC cooking everything when it should only cook the DLC. #!rb None #!test None Change 3665569 on 2017/09/26 by Dan.Hertzka New status effect feed for the new HUD: - Now placed in the mid-upper-left side of the HUD - Biggest difference from before is that there are now names associated with each effect - If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet. Cleaning: - Deleted all of the old buff widget classes & codepaths - Removed redundant properties from StatusEffectDisplayInfo - Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData Also: - Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events - Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed) @todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.) #!rb Don.Eubanks #!tests OrionEntry PIE with some cards and hero abilities #!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial. #!lockdown Billy.Rivers Change 3665555 on 2017/09/26 by Daniel.Lamb AudioStreaming mpsc queue fix up. #!rb Andrew.Grant #!test Compile paragon client / editor. Change 3665517 on 2017/09/26 by Daniel.Lamb Suspect fix for OR-44619 #!jira OR-44619 #!test Paragon editor compile #!rb Trivial Change 3664346 on 2017/09/26 by Jon.Lietz - making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out. - Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired. - Updated all GC's data to use the new decal class - removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent #!rb Dave.Ratti #!reivew Dave.Ratti #!tests used characters that had decal comps in the GC and they recylce as expected. #!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed. Change 3664099 on 2017/09/26 by Jon.Lietz OR-44510 - bringing over engine fixes for the Enum Redirector from Dev-Framework #!rb none #!tests compiles and warnings are gone Change 3663019 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Gil: fixed race condition in the PipelineStateCache #!rb Daniel.Lamb #!test paragon ps4 with higher repro modified build #!lockdown Andrew.Grant #!jira OR-44441 #!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663014 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready. #!tests ran locally #!rb [at daniel.lamb] [at arne.schober] #!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663004 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed dev check for extra commandline args from /data to /temp0 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662999 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Fixed DateTime used for folders not being set #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662255 on 2017/09/25 by Sam.Zamani #!tencent - fix for link error due to missing define of static OnNetworkCheatDetected delegate #!rb none #!tests none Change 3662073 on 2017/09/25 by Sam.Zamani #!tencent Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server Possible options #!jira TEN-275 TSS detect and expose punish user callbacks KickClient - User should be booted from the current game session via disconnect KickMatch - User received info about being punished (eg. ban type etc) PunishInfo - User received info about being punished (eg. ban type etc) #!rb rob.cannaday #!tests none Change 3659487 on 2017/09/22 by Josh.Markiewicz #!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin #!review-3659190 john.barrett, ryan.gerleve Change 3659485 on 2017/09/22 by Josh.Markiewicz #!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins #!fyi john.barrett, ryan.gerleve Change 3659184 on 2017/09/22 by Josh.Markiewicz #!UE4 - delete EpicSurvey module #!fyi justin.sargent, nick.darnell #!rb none Change 3658697 on 2017/09/22 by Ryan.Gerleve Fixes for server-side Tencent anti-cheat library integration: -Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows -Add getter for the TssSdkAntiInterf object -Enable server anti-cheat in editor builds #!codereview sam.zamani #!rb none #!tests enabled Tencent OSS, built & ran server Change 3658200 on 2017/09/22 by Graeme.Thornton Manual copy of CL 3587584 from Dev-Core Logging improvements for pak signature check failures - Added "PakCorrupt" console command which corrupts the master signature table - Added some extra log information about which block failed - Re-hash the master signature table and to make sure that it hasn't changed since startup - Moved the ensure around so that some extra logging messages can make it out before the ensure is hit - Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again #!rb none #!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General Change 3657970 on 2017/09/22 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition. We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game, [at marcus.wassmer,] [at arne.schober] #!rb none #!tests cycled 6-7 levels of Paragon #!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657914 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing... #!tests stepped through in non-pkg build #!rb none #!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657906 on 2017/09/21 by Andrew.Grant Improved some logging #!tests used locally #!rb none Change 3657891 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing Fixed issue with -dev mode on PS4 not updating symbols #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657867 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Re-locked network CL to 3652780 #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657857 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444 #!RB:arciel.rekman #!Tests:Compiled [CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf #!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657852 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for case-insensitivity causing title.json not to be staged #!rb daniel.lamb, bob.tellez #!tests ran packaging script, verified contents match v42 #!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657831 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors We can worry about a more permanent solution after we get this live. #!RB:none #!Tests: Compiled [CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer #!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657824 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb -------------------------------------- Built new UnrealCEFSubprocess client Changed OrionBuild.xml to build the shipping version of the above. The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this. [at justin.sargent,[at benjamin.crocker,[at wes.fudala]]] #!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657488 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: anton.migulko LIGHTING AND assets update #!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3656388 on 2017/09/21 by Laurent.Delayen Added default GetAxisVector static function to EAxisOption #!rb none #!FYI thomas.sarkanen #!tests lane minions test map Change 3656387 on 2017/09/21 by Laurent.Delayen Initialize FAnimInstanceProxy with default constructor. #!rb none #!fyi lina.halper, thomas.sarkanen #!tests lane minion test map Change 3656003 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3650578 for patching benjamin.crocker #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654403 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Merge DevCore -> Orion Release-43 CL 3641450 UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers. #!rb Daniel.Lamb #!test Compile #!lockdown Andrew.Grant #!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654356 on 2017/09/20 by Andrew.Grant Merging 3653658 from Dev-Rendering #!tests compiled, ran editor #!rb marcus.wassmer Change 3653914 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access). #!rb none #!tests ran locally #!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3652495 on 2017/09/19 by Andrew.Grant Editgration of VR fix in 3643776 from Release-4.17 #!tests #!rb na Change 3652244 on 2017/09/19 by Sam.Zamani #!tencent Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher Added "-q" to whitelist of command line params for shipping builds Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher #!rb rob.cannaday #!tests none Change 3651493 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651490 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651489 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651445 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag #!RB:none #!Tests:none [CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant #!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651059 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed code to archive load-order during tests #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651043 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed error parsing from tests to put cause ahead of file info #!tests ran self-test #!rb none #!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649683 on 2017/09/18 by Andrew.Grant Bulk-merge of oustanding changes in Main to DG #!tests #!rb na Change 3649345 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Integrate fix for eidtor crash when switching between low and high scaleability options. #!rb Olaf.Piesche #!test Paragon editor #!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649335 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - OR-44257 - Fix for hair not working It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion. #!RB:daniel.lamb #!Tests:Re-tested in cooked build [CODEREVIEW] daniel.lamb #!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649231 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM #!RB:none #!Tests:none [CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy #!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649211 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix 'lowest' shadow settings (simple forward rendering) #!rb arne.schober [FYI] Daniel.Wright #!tests monolith #!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649141 on 2017/09/18 by Stephan.Jiang Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source. -- These are hacks for ability videos to work before we have the new Sequencer updates -- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748 #!fyi Andrew.Grant, Max.Preussner #!rb none #!test compile Change 3649087 on 2017/09/18 by Thomas.Ross Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General #!rb none #!tests none #!fyi Andrew.Grant,Jeff.Williams,dan.oconnor Change 3649066 on 2017/09/18 by Max.Preussner WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources #!rb stephan.jiang #!rnx #!tests none Change 3649049 on 2017/09/18 by Max.Preussner Media: Changed audio sample rate warning to verbose log #!fyi stephan.jiang #!rb none #!rnx #!tests none Change 3648752 on 2017/09/18 by Max.Preussner WmfMedia: Fixed race condition in media sound wave #!rb none #!rnx #!tests none Change 3648748 on 2017/09/18 by Max.Preussner WmfMedia: Hack for preventing flicker between media source switching Do not merge to Dev-Main! #!rb stephan.jiang #!rnx #!tests none Change 3648596 on 2017/09/18 by Bart.Hawthorne More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough. Change 3648575 on 2017/09/18 by Sam.Zamani #!tencent Fix for missing library calls when initializing TSS anti cheat SDK #!rb none #!tests compiles win64 server Change 3648556 on 2017/09/18 by Jeff.Williams Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084 Clearing up robomerge #!rb none #!tests none Change 3648533 on 2017/09/18 by clayton.langford Unblocking RM. #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly. #!RB Adric.Worley #!tests none #!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3648219 on 2017/09/18 by Sam.Zamani #!tencent fixed Tencent module thirdparty dll runtime dependency paths fixed DLLHandle not being set #!rb none #!tests none Change 3647998 on 2017/09/18 by Clayton.Langford Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763. #!tests compiled #!rb Adric.Worley Change 3647817 on 2017/09/18 by James.Golding Mirror fix from 4.18 release stream (CL 3647799) to Dev-General Fix out-of-bounds access of cloth mapping data during CPU skinning #!rb benn.gallagher #!jira UE-49628 #!fyi benn.gallagher #!tests convert RiftMage to static mesh Change 3647749 on 2017/09/18 by Benn.Gallagher Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope. This caused matrix transposition to fail after the data was copied in using memcpy BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #!rb none #!tests Editor reimport of clothing assets Change 3646242 on 2017/09/15 by Tyler.Cole Revert shared engine LocalMCP scripts. Change 3646153 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds #!RB:daniel.lamb #!Tests: Ran cooked Client [CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy #!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3646125 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: arne.schober OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews. #!RB Marcus.Wassmer #!tests automated performance tests #!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3645861 on 2017/09/15 by clayton.langford #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW. Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added. To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated. #!tests ran local client/server, preflighted #!rb Ben.Salem #!rnx [FYI] Sean.Tobin, Hunter.Kent, Edward.King #!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3644062 on 2017/09/14 by Aaron.McLeran #!jira OR-44171 Some looping sounds are extremely loud #!rb Ethan.Geller #!tests run paragon, run near water river, don't observe looping sound being very loud Change 3643901 on 2017/09/14 by Laurent.Delayen Integrated CL #!3604725 to fix bug with opening state machines from anim graph. #!rb none #!tests fixes bug #!FYI lina.halper Change 3643641 on 2017/09/14 by Rob.Cannaday Fix unreachable code detected #!rb rob.cannaday #!tests Win64 compile Change 3643326 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TerSafe.dll loading until staging issues can be resolved #!rb none #!tests none Change 3643039 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TSS on servers due to linux build issues #!rb none #!tests none Change 3642438 on 2017/09/13 by Rob.Cannaday Handle new analytics param types (number, string, etc) Stub implementation of FAnalyticsProviderETTencent DefaultAttrs #!rb rob.cannaday #!tests Win64 vs AI match Change 3641655 on 2017/09/13 by Sam.Zamani #!tencent WIP added tss_sdk.dll (server) and TerSafe.dll (client) JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers #!rb none #!tests PC run with RegionCN.pak enabling tencent mode Change 3641559 on 2017/09/13 by Bart.Hawthorne Fix up oodle dictionary generation scripts #!rb none #!jira none Change 3641550 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3641393 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev. Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled - Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false) - Added PGOInput option to TargetRules and passed through to compile environment - Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for - Updated PS4 toolchain to use both LTO and PGO depending on what was set #!tests soaked locally, preflighted #!rb codereviewed FWIW here are before/after results for LTCG. Orion Performance report from 3 games and 1441.51 seconds MVP: 2.83 (Min: 2.05, Max: 3.22) HPM: 4.29 (Min: 4.24, Max: 4.37) AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms) GT: 12.88ms (Min: 12.68ms, Max: 13.25ms) RT: 13.71ms (Min: 13.48ms, Max: 14.08ms) GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms) Orion Performance report from 3 games and 1440.49 seconds MVP: 1.42 (Min: 1.02, Max: 1.94) HPM: 3.25 (Min: 2.75, Max: 3.62) AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms) GT: 11.93ms (Min: 11.64ms, Max: 12.47ms) RT: 12.80ms (Min: 12.54ms, Max: 13.24ms) GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms) #!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640885 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Limited warning to once every 10 secs. #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640875 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed shipping config issue #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640870 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Fixing CIS builds #!Orion The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors. [CODEREVIEW] John.Nielson #!rb none #!test compilation #!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640783 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson More temporary logging for finding the missing FX issue. #!rb: none #!Test: Pie #!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639910 on 2017/09/12 by Rob.Cannaday Build fix for AnalyticsETTencent #!rb rob.cannaday #!tests compile Win64 DebugGame Editor Change 3639565 on 2017/09/12 by Laurent.Delayen SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0. #!rb lina.halper #!FYI lina.halper #!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime. Change 3639228 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Tools - Added ability to postmortem a PS4 devkit for last crash #!rb run locally #!tests none #!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639075 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Specifically requesting 'all' configuration, to avoid missing manifest in jar. #!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639022 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka Remove dependency on the editor style set in the WidgetReflector - Fixes a crash when trying to use the reflector in a client cooked build - Also updated Focusable column name to shared var #!rb none #!tests Widget Reflected in a cooked build #!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638984 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638696 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Swapped problematic ensure to LogError, made draft obey notimeouts. #!tests compiled #!rb none [at daniel.lamb] #!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638644 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Third time's the charm #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638628 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure in a PS4 friendly way #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638583 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure to get a cook #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638545 on 2017/09/12 by Bart.Hawthorne Add analytics for oodle compression percentages #!rb ryan.gerleve, wes.hunt #!tests ran a 2 person game with dedicated server and verified analytics were reported #!jira OR-26386 Change 3638172 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Duplicate 3620803 Partial Fix for Dither Opacity Mask #!rb none #!tests PC monolith #!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637643 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Fixing version stream to Main #!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637524 on 2017/09/11 by Andrew.Grant Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests build Win64 editor, ran tests locally #!rb none Change 3637402 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Restored logging of runoptions when not verbose #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637357 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Made 'none' test specify Attended #!rb Daniel.Lamb #!tests compiled #!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637305 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added temporary debug logging cmd line option for finding Jira OrionOR-43600 #!RB: none #!Test: Pie [at David.Ratti] #!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636549 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues #!RB:none #!Tests:none [CODEREVIEW] uriel.doyon #!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636507 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka [OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG. Also: - Added distance formatting type for simple ability description values (will automatically append u to the value) - SimpleAbility description values can now go up to two decimal places Engine: - Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName #!rb Matt.Schembari #!tests PIE OrionEntry & FrontEndScene - various bug repros #!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636372 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Implement fast particle pool memory. Default is 2mb, automatically cleans up oldest used pool slots. Estimated 1/4 time for STAT_PARTALLOC. #!rb Jason.Bestimt #!test paragon ps4 cooked #!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636319 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue with fatal error message not being shown in reports. Fixed issue where some cancelled tests reported as succeeded #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636264 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance #!RB:none #!Tests: Ran client cooked build [CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon [QAREVIEW] #!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635288 on 2017/09/10 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices Fixed missing - in SoloSmoke args that were causing trailing params to be lost #!tests preflighted, ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635145 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to pick up SDK change for patch packages #!rb none #!tests none #!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635097 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added cleardevices option to Gauntlet that removes all devices after running. Added to Orion build scripts #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634985 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Cleaned up some logging around device failures Attempt to handle "Too Many Connections" error at a lower level Added removeall command to PS4DevkitUtil (not yet used) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634897 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Checking in change to timeouts to test theory #!tests ran test locally #!rb none #!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634765 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Scrape another .05ms out of GPU particle simulation. #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634422 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for Gauntlet shutdown issue on builders Fix for BP editing crash from Dev-Framework #!tests ran locally #!rb none! #!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634139 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running #!tests ran locally with single and file-based devices #!rb none #!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633799 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only. #!rb none #!tests monolith02 turrets [CODEREVIEW] lina.halper #!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633647 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Possible fix for OR-43926 from Arne #!tests ran locally, observed no ensures or negative side-effects in UI or HUD #!rb none #!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633637 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Upped timeout for editorbased tests #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632565 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed some test code... #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632385 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device handling. Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems. #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632177 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43 #!rb none #!test local commandlet #!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632131 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix a bug with new local vector-field only project setting #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632034 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where problem devices were reset each attempt #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631812 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device management in Gauntlet #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631787 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes. #!rb none [CODEREVIEW] martin.wilson #!test bot game #!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631251 on 2017/09/07 by Andrew.Grant Additional device selection improvements #!tests #!rb na Change 3630861 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3630620 on 2017/09/07 by Laurent.Delayen RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions. #!rb Ori.Cohen #!codereview benn.gallagher #!tests lane minions test map Change 3629990 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fix for gpu hang on ps4. #!rb Marcus.Wassmer #!test Paragon cooked ps4 #!jira OR-43835 #!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629980 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Moved some missed code to FDebug::HasAsserted() #!tests na #!rb none #!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629975 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Project optimization to only support local vector fields. separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost. #!rb olaf.piesche #!tests monolith ps4/pc #!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629917 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix for sizebyspeed on ps4 #!rb Simon.Tovey #!tests pc #!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629620 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629554 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored screenshot support to gauntlet (now driven externally) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629495 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: don.eubanks Stat panel will only show stat changes or improvements that come from Item sources (cards / gems) #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE [RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base! #!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629468 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring() Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread. #!tests ran locally #!rb none [at marcus.wassmer] #!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629410 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs -------------------------------------- Fix for generating project files #!tests GPF #!rb none #!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629369 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests) #!rb none #!tests verified signing is disabled and game gets to main menu with -fileopenlog [at graeme.thornton] #!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629254 on 2017/09/06 by Laurent.Delayen URO: ensure we don't skip more frames than desired when switching LODs. #!rb lina.halper #!codereview martin.wilson, benn.gallagher #!test lane minions test map Change 3629191 on 2017/09/06 by Laurent.Delayen Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions. #!rb lina.halper #!codereview martin.wilson #!test lane minions test map Change 3629130 on 2017/09/06 by Laurent.Delayen AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug. #!rb none #!tests lane minion test map Change 3628300 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed exception that could occur during tests if all devices were in use #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627915 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Undoing Oodle check for the time being #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627875 on 2017/09/06 by Jason.Bestimt #!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables) #!RB:none #!Tests:none #!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker #!ROBOMERGE: MAIN, 43 Change 3627694 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Improved warnings #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627642 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: david.ratti More logging for OR-43892 and OR-43779 #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627247 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed check that turns out to be bogus #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627240 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures #!tests compiled OrionClient [at daniel.lamb] #!rb none #!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627211 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added ensure for OR-43777 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626839 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added wait to PS4DevkitUtil before trying to postmortem crashdump #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626755 on 2017/09/05 by Rob.Cannaday Merge //Orion/Release-Tencent to //Orion/Dev-General Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded #!rb sam.zamani #!lockdown andrew.grant #!tests Win64 vs AI match, QA smoke test #!fyi sam.zamani Change 3626285 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed BaseDir argument not being correctly applied in tests Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626221 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame. Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement #!rb none #!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz [at Laurent.Delayen] [FYI] [at Andrew.Grant] #!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3625925 on 2017/09/05 by Laurent.Delayen If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want. #!rb benn.gallagher #!codereview martin.wilson, lina.halper #!tests lane minion map Change 3624051 on 2017/09/02 by Andrew.Grant Fixed issue with test params not being set. Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability. #!tests preflighted #!rb none #!review-3624052 @ben.salem Change 3623907 on 2017/09/02 by Andrew.Grant Fixed usesyncedbuild option being broken in Gauntlet #!codereview @daniel.lamb #!tests compiled #!rb none Change 3623906 on 2017/09/02 by David.Ratti Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides #!rb none #!test future wukong pie Change 3623766 on 2017/09/01 by Daniel.Wright [Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box #!rb none #!Tests PC QAGame Change 3623518 on 2017/09/01 by Don.Eubanks Fix for Shipping Client PS4 #!rb none #!tests Compile Shipping Client PS4 #!fyi daniel.lamb andrew.grant Change 3623515 on 2017/09/01 by Daniel.Wright [Copy] Volume materials applied to static meshes operate on the object's bounding sphere #!rb none #!TESTS QAGame PC Change 3623503 on 2017/09/01 by Daniel.Wright [Copy] Fixed ObjectRadius in Volume domain materials #!rb none #!TESTS none Change 3623102 on 2017/09/01 by Marcus.Wassmer Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand #!rb none #!tests monolith on PS4 #!fyi olaf.piesche,tim.elek Change 3623096 on 2017/09/01 by Marcus.Wassmer checkslow -> check to find issues with ILC #!rb none #!tests ran monolith on ps4 Change 3622744 on 2017/09/01 by Laurent.Delayen RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now). Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies. Take gravity from movement component if present, to inherit custom gravity scaling. Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used. If LOD enables new bodies, they are now initialized during simulation. Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default. Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change. Added AnimStats for PreUpdate, Update and Eval. #!rb ori.cohen #!codereview ori.cohen, lina.halper, benn.ghallager #!tests lane minion test map Change 3622743 on 2017/09/01 by Laurent.Delayen Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes. #!rb lina.halper #!tests lane minion test map Change 3622742 on 2017/09/01 by Laurent.Delayen 'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings. Renamed DisplayDebugCustom to DisplayDebugInstance. #!rb lina.halper #!tests lane minion test map Change 3622738 on 2017/09/01 by Laurent.Delayen Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams #!rb lina.halper #!tests lane minion test map Change 3622666 on 2017/09/01 by Jian.Ru Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements #!jira UE-48972, OR-43455 #!rb Chris.Bunner #!tests editor Change 3622579 on 2017/09/01 by Andrew.Grant Fixed shutdown issues with some tests being detected as errors Simplied and cleanup some things in state management of tests. #!tests ShortSOloGame test locally #!rb none Change 3622322 on 2017/09/01 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-40366 from v43 #!tests compiled #!rb Aaron.McLeran #!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3621054 on 2017/08/31 by Andrew.Grant Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests preflighted #!rb none Change 3620755 on 2017/08/31 by Daniel.Lamb Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations. #!rb Jason.Bestimt #!test Cooked paragon ps4 Change 3620541 on 2017/08/31 by Ben.Salem Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting. #!rb none #!tests compiled. Change 3620443 on 2017/08/31 by Mieszko.Zielinski Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4 #!rb none #!test golden path Change 3620428 on 2017/08/31 by Aaron.McLeran #!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General #!rb Ethan.Geller #!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports. Change 3620411 on 2017/08/31 by Mieszko.Zielinski Fix to removal of simuli sources from the AISense_Sight #!UE4 Made sure given source gets removed from ObservedTargets. #!rb none #!test golden path Change 3620343 on 2017/08/31 by Ben.Salem Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on. #!rb clayton.langford #!tests ran shallow and normal FX tests, generated hitches to display. Change 3620050 on 2017/08/31 by Luke.Thatcher [ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/... - USE_DEFRAG_ALLOCATOR was not always defined in all cases. #!rb Daniel.Lamb #!tests none Change 3619836 on 2017/08/31 by Andrew.Grant Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team) #!tests preflighted, ran locally #!rb none Change 3618597 on 2017/08/30 by Dan.Hertzka Fixed Additive UI materials not being affected by the widget opacity - We needed to multiply the sampled color by the alpha of the vertex color Also added fade in anim for scoreboard when showing after the endgame cinematic #!rb Nick.Darnell #!tests Widget alpha affects additive materials Change 3618441 on 2017/08/30 by Laurent.Delayen Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display. #!rb lina.halper #!tests lane minions Change 3618404 on 2017/08/30 by Paul.Moore - Update to new MMS client API from Fortnite. - Add MMS API plugin. #!rb none #!tests matchmaking, v2 MMS matchmaking, draft lobby. #!lockdown andrew.grant Change 3618167 on 2017/08/30 by Marcus.Wassmer Fix fog on PS4, also volume texture clears. #!rb luke.thatcher #!fyi Jordan.Walker #!tests ran monolith on ps4 Change 3617911 on 2017/08/30 by Andrew.Grant Fix for OR-43401, lighting remaining unbuilt #!tests ran cook, verified that lighting for bp components is now correctly found. #!rb marc.audy Change 3617765 on 2017/08/30 by Andrew.Grant Fix for lighting always being unbuilt on some blueprints #!tests cooked data and verified BP components have the correct transform and receive cached lighting data #!rb marc.audy, bp-team Change 3617757 on 2017/08/30 by Laurent.Delayen clang fix #!rb none #!tests none Change 3617700 on 2017/08/30 by Laurent.Delayen Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated. #!rb lina.halper #!tests lane minions map Change 3617695 on 2017/08/30 by Laurent.Delayen Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays. #!rb lina.halper #!tests test lane minions map Change 3616757 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-43459 from Laurent #!tests na #!rb Lina.Halper, Andrew.Grant #!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616745 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3609966 in anticipation of patch #!rb #!tests na #!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616551 on 2017/08/29 by Daniel.Lamb Fix memory leak in paragon. #!rb Andrew.Grant #!test Paragon ps4 Change 3613700 on 2017/08/28 by Andrew.Grant Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion Renabled r.Cache.UpdatePrimsTaskEnabled #!tests ran locally #!rb none Change 3613694 on 2017/08/28 by Andrew.Grant Added -teamsize argument to Orion none test. #!tests ran None test :) #!rb none Change 3613638 on 2017/08/28 by Ben.Salem Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created. #!rb clayton.langford #!tests Ran shallow and deep test for multiple characters. Change 3612731 on 2017/08/28 by Chris.Bunner [DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook. #!rb #!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb #!tests Cooking/running simple scene with grass foliage #!jira UE-48698, OR-42612 Change 3612695 on 2017/08/28 by Andrew.Grant Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things. #!tests ran NoneTest with -nomcp #!rb none Change 3612002 on 2017/08/27 by Andrew.Grant Fix for crash seen during nightly tests #!tests baseline perf didn't crast 3/3 #!rb none Change 3611980 on 2017/08/27 by Andrew.Grant PS4DevkitUtil post-mortem improvements to logging #!tests run ShortSoloGame #!rb none Change 3611758 on 2017/08/26 by Andrew.Grant Fix for warning #!tests #!rb na Change 3611737 on 2017/08/26 by Andrew.Grant Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering 3517039 - GitHub #!2655: Optimization for shadow map resolution selection for spot lights * Use the radius of the inscribed sphere at the cone end as the spot light's screen radius Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly 3545241 - Fixed spotlight whole scene shadows using a radius 2x too long 3545347 - Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame. #!rb none #!tests compiled Change 3611718 on 2017/08/26 by andrew.grant #!CodeReview: andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs -------------------------------------- Improved parsing of callstacks and errors in test logs Added unit test for error parsing #!tests ran locally, unit tests #!rb none #!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611704 on 2017/08/26 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Test fixes - addresses issue with memory report failing #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611683 on 2017/08/26 by Andrew.Grant Upgraded PS4 SDK to 4.508.111 #!tests SoloGames locally #!rb none Change 3611466 on 2017/08/25 by Andrew.Grant Changed none test to use monolith02 by default #!tests compiled #!rb none Change 3611167 on 2017/08/25 by Laurent.Delayen Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated. #!rb none #!tests lane minions #!codereview martin.wilson Change 3610850 on 2017/08/25 by dan.hertzka Unclog Robomerge #!rb none #!tests none Change 3610325 on 2017/08/25 by Andrew.Grant Compile fix for PS4 #!tests compiled #!rb none Change 3610018 on 2017/08/25 by Laurent.Delayen UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later. #!rb lina.halper #!tests venus ult on minion lane test map Change 3609967 on 2017/08/25 by Daniel.Lamb Merging using //Fortnite/Main/->//Orion/Dev-General/ Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4. CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping. - The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out. - Added an extra flag to reset mip bias values when texture memory budget is increased. #!rb Uriel.Doyon #!jira FORT-45385 #!jira FORT-47739 CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4. - Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled. - Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted. - Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps. #!jira FORT-45229 #!rb Ben.Woodhouse CL 3564368 LLM Changes Summary: LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead. Changes where LLM hooks into the various allocation functions and pools. Added more LLM tracking scopes. Changed the way LLM gets its internal memory. Writing stats out to csv Fixed a few bugs with the tracker code Details: * re-enabled LLM by default in Dev builds for XB1 and PS4 * Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update) * track allocations made from the defrag pool (PS4) * track non-drfrag pool garlic allocations (PS4) * track allocations made from PS4 malloc * combined the RHI and Malloc trackers into the Default tracker * changed stat groups to LLM, LLMPlatform and LLMOverhead * OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set * XMemAlloc now uses AllocationType if no LLM scope has been set * renamed VirtualMap to LLMMap * added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled. * support for tracking allocations that move in memory (for the PS4 defrag allocator) * support for tracking explicit memory without pausing the tracker * LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg * fixed check in FNameToTag. It was checking the wrong value when verifying the name index * show a warning on screen if LLM has been enabled without debug memory enabled (on consoles) * fixed program size tracking * fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope. * optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times) * fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them. * fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled * changed default alloc size for LLMMap to 16K * Added lots more LLM scopes renamed some of the existing ones * made FMemBlock::Allocators private and added accessor functions, which include LLM tracking. * fixed LLM alignment tracking in CustomVirtualAlloc * implemented LLM on XB1 so that it properly tracks D3D12Allocations * added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator * tracking of render targets * fixed LLM pool total column value. #!rb luke.thatcher CL 3565905 [ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/... 3458941 - Initial submission of new PS4 memory allocator. 3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible. 3498440 - Flexible and framebuffer memory fallbacks 3515704 - Add stats to new PS4 memory system. UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly. #!rb Ben.Woodhouse CL 3580934 [FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo. - Neo has 512 MB more direct memory than a base kit. - Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB. #!rb Marcus.Wassmer #!jira FORT-50206 CL 3590180 [FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted. - Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB. - Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool. - Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails. #!jira FORT-49700 #!rb Aaron.McLeran CL 3593920 [FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system. - Incorrect bitmask usage was truncating the available memory value to 32 bits. - Also includes some minor refactoring to make parts more readable. - Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile. #!rb Jonathan.Fitzpatrick #!jira FORT-50918 CL 3597577 [FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU. - Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack. - With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is. #!rb Stewart.Lynch #!jira FORT-50825 #!jira FORT-49688 #!jira FORT-49695 #!jira FORT-50054 CL 3601951 [FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system - Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0. - Added garlic, onion and defrag stats to the platform memory stats struct. - Added fixed pool sizes to platform memory stats. - Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools. #!rb Stewart.Lynch #!jira FORT-52910 #!test preflight with baseline performance memory report tests, local tests on neo #!rb Luke.Thatcher Change 3608480 on 2017/08/24 by Uriel.Doyon Instanced static mesh lightmaps are now updated correctly after lighting scenario changes #!jira UE-48522 #!tests Build lighting, loaded maps #!rb michel.dupuis Change 3608407 on 2017/08/24 by Andrew.Grant Reintegrated ROlando's cloth optimizations #!tests #!rb none Change 3608349 on 2017/08/24 by Rolando.Caloca O - Cloth vertex buffers no longer generate dummy vertices #!rb Lina.Halper #!fyi James.Golding #!tests Check obj list memory with multiple characters, tested animations Change 3607815 on 2017/08/24 by Laurent.Delayen Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha. https://jira.it.epicgames.net/browse/OR-43186 #!rb none #!tests Price hand two bone IK #!codereview lina.halper, thomas.sarkanen Change 3607770 on 2017/08/24 by Andrew.Grant Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong #!tests ran locally, updated parser test #!rb none Change 3607546 on 2017/08/24 by Jian.Ru Add more control to chromatic aberration effect #!jira UE-47138 #!rb Brian.Karis #!tests editor Change 3607270 on 2017/08/24 by Andrew.Grant Mirroring 3605735 from FN to address bug with MIC deduplication #!tests compiled #!rb none Change 3607082 on 2017/08/24 by Laurent.Delayen Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands. List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph). Current debug Target is highlighted in a green bounding box. Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player. Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors. Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation. #!rb dave.ratti #!tests lane minion test map, debugging individual minions #!codereview jon.lietz Change 3606772 on 2017/08/24 by David.Ratti Spot edigrate CL 3606417 for accurate CurveTable memory tracking #!rb none #!tests none [CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
if (AssetData != nullptr)
{
PR #6761: Fix for unsafe cast of IAssetTypeActions* to FAssetTypeActions_Base* (Contributed by IGood) #jira UE-90292 #rb rex.hill #robomerge[RELEASE] 4.25 #ROBOMERGE-SOURCE: CL 12069288 via CL 12069307 via CL 12069321 #ROBOMERGE-BOT: (v657-12064184) [CL 12072296 by rex hill in Main branch]
2020-03-09 12:42:34 -04:00
ClassDisplayName = AssetTypeActions.Pin()->GetDisplayNameFromAssetData(*AssetData);
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main #lockdown Nick.Penwarden #rb none Change 3720210 on 2017/10/25 by Olaf.Piesche Fixing dynamic material params for ribbons #!codereview scott.kennedy #!rb none #!tests scott's test ribbon Change 3720073 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: frank.fella Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it. #!Tests Minion automated tests no longer crash randomly. #!rb SimonT #!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3719233 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: philip.buuck [OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead). #!rb Matt.Schembari #!tests PIE [QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death #!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3718474 on 2017/10/25 by Yannick.Lange Niagara: Only show isolate menu items on track context menu if it is a system. Rename "Isolate toggle" to "Isolated". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718095 on 2017/10/25 by Yannick.Lange Niagara: Fix crash when not having dynamic parameter in material. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718069 on 2017/10/25 by Yannick.Lange Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3717545 on 2017/10/24 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Removed read / write locks from PipelineStateCache. #!rb Andrew.Grant, Gil.Gribb #!test paragon ps4. #!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3716928 on 2017/10/24 by Shaun.Kime The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime. #!rb olaf.piesche, simon.tovey #!fyi olaf.piesche, simon.tovey, frank.fella #!tests am now able to run Test_minionWave on PS4 Change 3715712 on 2017/10/24 by Yannick.Lange Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3715430 on 2017/10/23 by Shaun.Kime Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it. #!rb none #!fyi simon.tovey #!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime Change 3715368 on 2017/10/23 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main) #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3715226 on 2017/10/23 by Shaun.Kime Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's. #!rb none #!fyi simon.tovey, olaf.piesche, frank.fella #!tests ran in PIE Change 3714645 on 2017/10/23 by Yannick.Lange Niagara: Add ability to create particle system from this emitter in content browser. #!rb Shaun.Kime #!tests n/a Change 3714200 on 2017/10/23 by Olaf.Piesche Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target #!codereview simon #!rb none #!tests Orion Niagara assets Change 3713341 on 2017/10/23 by Yannick.Lange Niagara: Fix NiagaraNodeIF output pins cannot be deleted. Fix NiagaraNodeIF output pins cannot be renamed. #!jira UE-50193 #!jira UE-50193 #!rb Shaun.Kime #!tests n/a Change 3713133 on 2017/10/23 by Yannick.Lange Niagara: Isolate emitters in sequencer UI. - Added being able to extend the sequencer track context menu with a delegate. - Added entry in track context menu to toggle the selected emitters isolation state. - Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters. #!rb Shaun.Kime #!tests n/a Change 3712445 on 2017/10/22 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime UVScale, UniformAorBFloat, and LinearColorAlongVector added. #!rb none #!tests new autotest added #!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3712420 on 2017/10/21 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1. #!rb none [CODEREVIEW] frank.fella [FYI] simon.tovey, olaf.piesche, wyeth.johnson #!tests created an emitter, disabled Acceleration Force.. still compiled. #!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711602 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like: LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData #!jira UE-51511 #!rb Simon.Tovey #!tests n/a #!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711288 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: eric.ketchum [Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work #!rb: None #!tests: PIE [CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime #!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711197 on 2017/10/20 by Olaf.Piesche Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly #!rb none #!tests minion projectile ribbon trail Change 3710634 on 2017/10/20 by Mic.Rooney Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing. #!RB: none #!Test: tested/built locally ran preflight Editor/Monolithics build. #!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3709686 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Added some more timerguards for slow timer manager tick objects. Commented out for now. #!rb Trivial #!test Paragon Cooked ps4. #!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708958 on 2017/10/19 by Shaun.Kime Back out changelist 3708456 .. this was an unintentional change #!rb none #!tests n/a Change 3708839 on 2017/10/19 by Shaun.Kime Merging CL 3708835 Fixing Scott's common crash with adding an emitter with autocompile off #!rb frank.fella #!tests n/a Change 3708784 on 2017/10/19 by Shaun.Kime Merging CL 3708782 //Orion/Main/... to //Orion/DevGeneral/... #!rb none #!tests n/a Change 3708600 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion #!rb none #!test golden path #!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708473 on 2017/10/19 by Shaun.Kime Merging Frank's changes for team color support from Main to Dev-General #!rb Frank.Fella #!tests test_minionwave worked Change 3708456 on 2017/10/19 by Shaun.Kime Particles.Random set to 0.0 #!rb none #!tests n/a Change 3708455 on 2017/10/19 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests passed minion fx autotest Change 3707648 on 2017/10/19 by Shaun.Kime Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made. Defer deletion of dataset to RT. Ensure resets don't mess with data inflight RT commands are using. Checkin on behalf of Simon Tovey #!jira OR-45423 #!rb Simon.Tovey #!tests ran through the LaneMinionFXTests successfully on PC Change 3707096 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago. #!rb none #!tests automated tests pass #!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3706726 on 2017/10/19 by Rob.Cannaday Merge XMPP resource version to use version 2 instead of version 3 #!rb trivial #!tests compile #!ROBOMERGE: Main, 44, Tencent Change 3706349 on 2017/10/19 by Josh.Markiewicz #!UE4 - Cross Voice code review feedback - fixed up broken stack vs queue - fixed GetRoomId returning int32 instead of uint64 - fixed switch room logic - more/better logging - more comments #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday #!rb none #!tests local cheat codes Change 3705453 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: arne.schober Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array) #!RB Daniel.Wright #!Tests LaunchOnPs4 #!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3705399 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: scott.kennedy Default Niagara emitter changed color property to better default value. Updated basic glow emitter Added energy bubble base emitter put a little more polish into siege minion impact FX. #!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3704426 on 2017/10/18 by Shaun.Kime Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423 #!rb simon.tovey #!fyi hunter.kent #!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure Change 3703288 on 2017/10/18 by Olaf.Piesche Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash #!rb olaf.piesche, simon.tovey #!tests minion test map PC and PS4 Change 3701373 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader. #!rb Olaf.Piesche #!tests test_minionwave runs #!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3701108 on 2017/10/17 by Hunter.Kent Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily. #!RNX #!Test PS4 #!rb @tim.elek #!review-3701110 @andrew.grant, @daniel.lamb Change 3701044 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: jon.lietz - white space fixes - added in more detail to logging - fixed dragon GC to not hide when the mesh is hidden #!rb none #!tests complies and logging is updated [FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen #!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3700900 on 2017/10/17 by Shaun.Kime Integrating possible crash fix from Dev-Niagara to Dev-Gen #!rb none #!tests n/a #!fyi Olaf.Piesche Change 3700492 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests done in branch Change 3700217 on 2017/10/17 by Olaf.Piesche Fix for potential crash in sprite renderer #!rb none #!tests minion test map Change 3700216 on 2017/10/17 by Benn.Gallagher Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master. #!rb Lina.Halper #!jira OR-45226 #!tests PIE + Standalone games hitting Rampage with Ghosts E Change 3699660 on 2017/10/17 by Jason.Bestimt #!ORION_DG - Fixes to UnrealHitchParser edge cases #!RB:none #!Tests: Ran on Logs from QA #!CodeReview: ben.salem Change 3699462 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!tests preflight ok #!rb none Change 3699010 on 2017/10/17 by Jeff.Williams Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920 #!rb none #!tests none Change 3698519 on 2017/10/16 by Olaf.Piesche Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts #!rb none #!tests minion wave test map Change 3698380 on 2017/10/16 by Shaun.Kime Updating logic to now support the autoattachment #!rb none #!tests autotests pass.. Change 3698263 on 2017/10/16 by Olaf.Piesche Assume degrees for sprite rotation #!rb none #!codereview shaun.kime #!tests test sprite emitter Change 3697652 on 2017/10/16 by Olaf.Piesche Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion #!rb none #!tests minion test map Change 3696906 on 2017/10/15 by Shaun.Kime Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers. #!rb none #!tests now no longer generates invalid errors #!fyi frank.fella, olaf.piesche, simon.tovey Change 3695456 on 2017/10/13 by Olaf.Piesche Fix for potential ribbon crash and end-of-ribbon rendering artifacts #!rb none #!codereview scott.kennedy #!tests minion wave test map Change 3694545 on 2017/10/13 by Andrew.Grant Fix for low frequency async loading crash (OR-42535) #!rb gil.gribb #!tests comppiled Change 3694176 on 2017/10/13 by Jeff.Williams Plugin manifest name changed to DLCFile name #!rb none #!tests compile, stage Change 3693582 on 2017/10/12 by Don.Eubanks Fixing PS4 Compile warning (constructor init order not matching member define order) #!rb none #!tests Compile Shipping Client PS4 #!fyi olaf.piesche Change 3693516 on 2017/10/12 by Olaf.Piesche Niagara: Remove mesh renderer assert, replace with early out #!rb none #!tests niagara mesh test asset Merging //Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp Change 3693051 on 2017/10/12 by Ben.Salem Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log. #!rb Clayton.Langford #!tests Parsed a 5mb log with dumphitches down to 23k of hitch data. Change 3692912 on 2017/10/12 by Olaf.Piesche Merging: Niagara ribbon tiling distance #!rb none #!tests ribbon test asset Change 3692835 on 2017/10/12 by Shaun.Kime Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags. #!rb none #!fyi scott.kennedy, wyeth.johnson #!tests n/a Change 3692751 on 2017/10/12 by Shaun.Kime Removing script that shouldn't have come over. #!rb none #!tests n/a Change 3692746 on 2017/10/12 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests opened test level and created new emitter/system Change 3692616 on 2017/10/12 by Don.Eubanks OR-45131 Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking. #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE #!codereview nick.darnell Change 3691912 on 2017/10/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none #!tests compile, editor #!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3690944 on 2017/10/11 by Jeff.Williams Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC. #!rb Daniel.Lamb #!tests Compile, build Change 3688989 on 2017/10/10 by Lina.Halper LOD sync of attached/parent #!rb: Laurent.Delayen #!tests: price with shotgun skin/PIE/editor Change 3687592 on 2017/10/09 by Ben.Salem Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test. #!rb clayton.langford #!tests Ran sparrow shallow tests. Change 3686560 on 2017/10/09 by Shaun.Kime Flipping the min/max values to be standard #!rb none #!tests n/a Change 3686046 on 2017/10/09 by Shaun.Kime Merging latest from Dev-Niagara in preparation for Effects team work on Monday #!rb none #!tests successful preflight #!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek Change 3685613 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: simon.tovey Implementing vector field matrix inverse fix from CL3675167 to 43.3. #!rb none #!tests none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685603 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross RotationalContent Improvements - Fixed potential bug where tags could be updated when not intended on RotationalContentManager - Fix for PIE assert - Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option. - Removing config tag from RotationalContentOverrides in OrionGlobals. New Halloween Gauntlet Test - Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box. #!rb none #!tests local builds / editor / PIE #!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685408 on 2017/10/07 by ben.salem Fixing robomerge error in DevGen #!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. ben.salem, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml -------------------------------------- Merging using DevGen->Release43.3 Repairing mailer for nightly Perf tests, fixing email headers. #!tests run in devgen #!rb none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685073 on 2017/10/06 by Andrew.Grant Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General) #!tests #!rb na Change 3684717 on 2017/10/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where GT & RT times in profile info were reversed :( #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3684512 on 2017/10/06 by Laurent.Delayen Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code. #!rb lina.halper #!tests minion AnimBP nativization Change 3684059 on 2017/10/06 by Max.Preussner Orion: Fixed ability videos not loading on PS4 and/or not looping #!fyi stephan.jiang #!jira OR-44682 #!rb none #!rnx #!tests none Change 3683538 on 2017/10/06 by David.Ratti batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions. -Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players. -Fixes case where killing minions with badass was not displaying pops (prediction key issue) #!rb none #!tests editor, pie #!review-3683539 @Matt.Schembari Change 3683364 on 2017/10/06 by Andrew.Grant Changed warning to info #!tests #!rb na Change 3681999 on 2017/10/05 by Bart.Hawthorne Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion. #!rb cody.haskell #!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore #!jira OR-44111 #!tests Golden path, live spectated numerous matches. Change 3681403 on 2017/10/04 by Josh.Markiewicz #!UE4 - base pass for Tencent Cross SDK - basic testing done with enter/exit/switch room - basic testing of ShowUI - checked in disabled #!rb duck #!tests see above #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday Change 3680623 on 2017/10/04 by David.Ratti Rework for how max movement speed is calculated. The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow. Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored. Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow. GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc). Suggested methods for inspection: AbilitySystem debug hud (Home/End) p.VisualizeMovement (displays final calculated movement speed) Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar) Technical information: 1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool. 2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows. 3. Added a notification for attribute sets when an aggregator is created for one of their attributes. 4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod) 5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension. #!tests pie #!rb FrankG #!codereview Fred.Kimberley, Billy.Bramer #!fyi colin.fogle #!QAReview #!RN #!designchange Change 3680580 on 2017/10/04 by Ben.Salem Repair email titles for various reports. #!rb none #!tests Reran tests. Change 3680438 on 2017/10/04 by Dan.Hertzka GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect - Fixes the HUD status effect feed not showing sources for a lot of itemization abilities Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip #!rb Dave.Ratti #!tests OrionEntry PIE - equipped Sand Speeder #!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on Change 3680344 on 2017/10/04 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Speculative disable of defragging on volumetric lightmap textures. #!rb andrew.grant #!test monolith2 ps4 #!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3680302 on 2017/10/04 by Shaun.Kime Integration from DevNiagara. Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array. #!rb none #!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek #!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass. Change 3679946 on 2017/10/04 by Laurent.Delayen Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches. #!rb lina.halper #!FYI andrew.grant #!tests monolith2 old minions Change 3679938 on 2017/10/04 by Daniel.Lamb Allowed foliage cullall option to be modified by scalability options. #!rb Trivial #!test Compile paragon editor Change 3679563 on 2017/10/04 by Jon.Lietz OR-43599 - added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it. #!rb Dave.Ratti #!review-3679564 @John.Nielson #!tests added these waits to hot pursuit and they worked as expected Change 3679006 on 2017/10/03 by Ben.Salem Try to fix broken nightly mailer issues for FX tests. #!rb none #!tests Preflighted a shallow fx pass successfully in EC. Change 3677845 on 2017/10/03 by Andrew.Grant Added an ensure to guard against OR-44826 while further investigations occur #!tests compiled #!rb none Change 3677443 on 2017/10/03 by John.Nielson Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase. Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify). #!RB: None #!Test: Pie, Uncooked #!review-3677445: @David.Ratti Change 3676748 on 2017/10/02 by Laurent.Delayen Minions: split body layer is now done in mesh space, to maintain upper body orientation. #!FYI ray.arnett, lina.halper #!rb none #!test lane minion test map Change 3675950 on 2017/10/02 by Don.Eubanks Added several new supported tags / status effects to the Floating Status Effect Text system. Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player. Added ScaleOverDistance curve support for floating numbers / text. Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out. #!rb matt.schembari #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 Change 3675186 on 2017/10/02 by Mic.Rooney Support for other anim curve driving audio types (right now specifically DialogueWave) #!RB: none #!Test: compiled editor/monolithics/withoutunity and tested locally. #!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3675167 on 2017/10/02 by Shaun.Kime Changed unsafe InverseFast() to an Inverse() #!jira OR-44671 #!rb Simon.Tovey #!tests n/a Change 3674888 on 2017/10/02 by David.Ratti GGP V2 * Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration. Item System: * Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords. * Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup). Ability System: * SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE) #!rb none #!tests editor pie cooked #!review-3674889 @Jon.Lietz Change 3674170 on 2017/09/30 by Mieszko.Zielinski Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load. #!rb none #!test golden path #!OR-44738 Change 3672937 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files #!tests 3compiled #!rb none #!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672867 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored previous behaviour of integer numbers being formatted as "1" and not "1.00" #!tests ran game, checked playlist analytic #!rb nikdel #!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672575 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Remove warning that can happens normally with backwards compat replays #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672548 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Andrew.Grant #!test Editor building hlods #!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672542 on 2017/09/29 by Andrew.Grant Merging #!rb #!tests na Change 3672390 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed memreport settings for frontend tests #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672385 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Reworked and pretty much final PipelineState cache code - various comments incorporated - namespaced functions - removed redundant class and replaced with ref pointer #!tests soaked a lot [at daniel.lamb,] [at arne.schober] #!rb none #!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672281 on 2017/09/29 by Rob.Cannaday Add user ID to OnNetworkCheatDetected #!jira TEN-272 #!jira TEN-273 #!jira TEN-274 #!rb rob.cannaday #!tests Win64 AI match, simulate cheat detected by cheat command #!review-3672282 @ian.fox @sam.zamani Change 3671688 on 2017/09/29 by Frank.Gigliotti Added ability to set developer comment when adding native tags. #!RB David.Ratti #!Tests None Change 3670409 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for dump type made while doing cleanup #!tests compiled Win64, PS4, ran PS4 #!rb none #!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3670399 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed race condition in pipeline state cache Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon (Couple of extra tweaks planned, but this should be GTG for a v43 release) #!rb codereviewed #!tests soaked locally, lots #!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669802 on 2017/09/28 by Andrew.Grant From Dev-Framework #!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed #!rb michael.noland #!codereview andrew.grant #!tests na Change 3669709 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669177 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Reflection Captures support Lighting Scenarios without recapturing * Reflection Captures are now part of the Map Build * Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message) * Reflection Capture build data moved to the BuildData package * Building lighting / reflection captures no longer dirties ULevels * Sky lights which capture the scene now work correctly with Lighting Scenarios * Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded) #!rb Marcus.Wassmer #!TESTS Paragon editor Monolith02 #!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669124 on 2017/09/28 by Daniel.Lamb Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush Fix cook in devgeneral Bumped shader version to invalidate stale uniform buffer name. #!rb none #!TESTS none #!fyi Daniel.Wright Change 3667906 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667899 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Remove unused SM4 reflection capture cubemap #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667894 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] SM4 fallback for reflection captures. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667859 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] Removed old rasterized deferred reflection env path. Removed reflection compute shader. Replaced with PS. Small perf gain. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667852 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed missing include #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667807 on 2017/09/27 by Daniel.Lamb Tencent DLC can now remap the plugin content to the game root directory. #!rb Ben.Marsh #!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test Change 3667753 on 2017/09/27 by Clayton.Langford Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer. #!RB Ben.Salem, Adric.Worley #!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat Change 3667408 on 2017/09/27 by Jordan.Walker Optimization to bakedNormal layer blend on Low end material quality -uses simple multiply and add normal map blend Change 3667388 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times. #!rb none #!TESTS QAGame on console #!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667383 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667265 on 2017/09/27 by Daniel.Lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Uriel.Doyon #!test Editor building hlods Change 3667159 on 2017/09/27 by Mieszko.Zielinski Added simple logging to BT loading allowing us to identify missing BB keys #!Orion #!test golden path #!rb Lukasz.Furman Change 3665944 on 2017/09/26 by Dan.Hertzka Fix PS4 compile #!rb none #!tests compile PS4 Change 3665590 on 2017/09/26 by Daniel.Lamb Fix for DLC cooking everything when it should only cook the DLC. #!rb None #!test None Change 3665569 on 2017/09/26 by Dan.Hertzka New status effect feed for the new HUD: - Now placed in the mid-upper-left side of the HUD - Biggest difference from before is that there are now names associated with each effect - If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet. Cleaning: - Deleted all of the old buff widget classes & codepaths - Removed redundant properties from StatusEffectDisplayInfo - Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData Also: - Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events - Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed) @todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.) #!rb Don.Eubanks #!tests OrionEntry PIE with some cards and hero abilities #!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial. #!lockdown Billy.Rivers Change 3665555 on 2017/09/26 by Daniel.Lamb AudioStreaming mpsc queue fix up. #!rb Andrew.Grant #!test Compile paragon client / editor. Change 3665517 on 2017/09/26 by Daniel.Lamb Suspect fix for OR-44619 #!jira OR-44619 #!test Paragon editor compile #!rb Trivial Change 3664346 on 2017/09/26 by Jon.Lietz - making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out. - Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired. - Updated all GC's data to use the new decal class - removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent #!rb Dave.Ratti #!reivew Dave.Ratti #!tests used characters that had decal comps in the GC and they recylce as expected. #!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed. Change 3664099 on 2017/09/26 by Jon.Lietz OR-44510 - bringing over engine fixes for the Enum Redirector from Dev-Framework #!rb none #!tests compiles and warnings are gone Change 3663019 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Gil: fixed race condition in the PipelineStateCache #!rb Daniel.Lamb #!test paragon ps4 with higher repro modified build #!lockdown Andrew.Grant #!jira OR-44441 #!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663014 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready. #!tests ran locally #!rb [at daniel.lamb] [at arne.schober] #!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663004 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed dev check for extra commandline args from /data to /temp0 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662999 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Fixed DateTime used for folders not being set #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662255 on 2017/09/25 by Sam.Zamani #!tencent - fix for link error due to missing define of static OnNetworkCheatDetected delegate #!rb none #!tests none Change 3662073 on 2017/09/25 by Sam.Zamani #!tencent Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server Possible options #!jira TEN-275 TSS detect and expose punish user callbacks KickClient - User should be booted from the current game session via disconnect KickMatch - User received info about being punished (eg. ban type etc) PunishInfo - User received info about being punished (eg. ban type etc) #!rb rob.cannaday #!tests none Change 3659487 on 2017/09/22 by Josh.Markiewicz #!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin #!review-3659190 john.barrett, ryan.gerleve Change 3659485 on 2017/09/22 by Josh.Markiewicz #!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins #!fyi john.barrett, ryan.gerleve Change 3659184 on 2017/09/22 by Josh.Markiewicz #!UE4 - delete EpicSurvey module #!fyi justin.sargent, nick.darnell #!rb none Change 3658697 on 2017/09/22 by Ryan.Gerleve Fixes for server-side Tencent anti-cheat library integration: -Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows -Add getter for the TssSdkAntiInterf object -Enable server anti-cheat in editor builds #!codereview sam.zamani #!rb none #!tests enabled Tencent OSS, built & ran server Change 3658200 on 2017/09/22 by Graeme.Thornton Manual copy of CL 3587584 from Dev-Core Logging improvements for pak signature check failures - Added "PakCorrupt" console command which corrupts the master signature table - Added some extra log information about which block failed - Re-hash the master signature table and to make sure that it hasn't changed since startup - Moved the ensure around so that some extra logging messages can make it out before the ensure is hit - Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again #!rb none #!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General Change 3657970 on 2017/09/22 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition. We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game, [at marcus.wassmer,] [at arne.schober] #!rb none #!tests cycled 6-7 levels of Paragon #!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657914 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing... #!tests stepped through in non-pkg build #!rb none #!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657906 on 2017/09/21 by Andrew.Grant Improved some logging #!tests used locally #!rb none Change 3657891 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing Fixed issue with -dev mode on PS4 not updating symbols #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657867 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Re-locked network CL to 3652780 #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657857 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444 #!RB:arciel.rekman #!Tests:Compiled [CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf #!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657852 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for case-insensitivity causing title.json not to be staged #!rb daniel.lamb, bob.tellez #!tests ran packaging script, verified contents match v42 #!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657831 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors We can worry about a more permanent solution after we get this live. #!RB:none #!Tests: Compiled [CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer #!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657824 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb -------------------------------------- Built new UnrealCEFSubprocess client Changed OrionBuild.xml to build the shipping version of the above. The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this. [at justin.sargent,[at benjamin.crocker,[at wes.fudala]]] #!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657488 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: anton.migulko LIGHTING AND assets update #!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3656388 on 2017/09/21 by Laurent.Delayen Added default GetAxisVector static function to EAxisOption #!rb none #!FYI thomas.sarkanen #!tests lane minions test map Change 3656387 on 2017/09/21 by Laurent.Delayen Initialize FAnimInstanceProxy with default constructor. #!rb none #!fyi lina.halper, thomas.sarkanen #!tests lane minion test map Change 3656003 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3650578 for patching benjamin.crocker #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654403 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Merge DevCore -> Orion Release-43 CL 3641450 UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers. #!rb Daniel.Lamb #!test Compile #!lockdown Andrew.Grant #!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654356 on 2017/09/20 by Andrew.Grant Merging 3653658 from Dev-Rendering #!tests compiled, ran editor #!rb marcus.wassmer Change 3653914 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access). #!rb none #!tests ran locally #!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3652495 on 2017/09/19 by Andrew.Grant Editgration of VR fix in 3643776 from Release-4.17 #!tests #!rb na Change 3652244 on 2017/09/19 by Sam.Zamani #!tencent Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher Added "-q" to whitelist of command line params for shipping builds Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher #!rb rob.cannaday #!tests none Change 3651493 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651490 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651489 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651445 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag #!RB:none #!Tests:none [CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant #!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651059 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed code to archive load-order during tests #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651043 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed error parsing from tests to put cause ahead of file info #!tests ran self-test #!rb none #!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649683 on 2017/09/18 by Andrew.Grant Bulk-merge of oustanding changes in Main to DG #!tests #!rb na Change 3649345 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Integrate fix for eidtor crash when switching between low and high scaleability options. #!rb Olaf.Piesche #!test Paragon editor #!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649335 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - OR-44257 - Fix for hair not working It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion. #!RB:daniel.lamb #!Tests:Re-tested in cooked build [CODEREVIEW] daniel.lamb #!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649231 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM #!RB:none #!Tests:none [CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy #!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649211 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix 'lowest' shadow settings (simple forward rendering) #!rb arne.schober [FYI] Daniel.Wright #!tests monolith #!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649141 on 2017/09/18 by Stephan.Jiang Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source. -- These are hacks for ability videos to work before we have the new Sequencer updates -- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748 #!fyi Andrew.Grant, Max.Preussner #!rb none #!test compile Change 3649087 on 2017/09/18 by Thomas.Ross Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General #!rb none #!tests none #!fyi Andrew.Grant,Jeff.Williams,dan.oconnor Change 3649066 on 2017/09/18 by Max.Preussner WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources #!rb stephan.jiang #!rnx #!tests none Change 3649049 on 2017/09/18 by Max.Preussner Media: Changed audio sample rate warning to verbose log #!fyi stephan.jiang #!rb none #!rnx #!tests none Change 3648752 on 2017/09/18 by Max.Preussner WmfMedia: Fixed race condition in media sound wave #!rb none #!rnx #!tests none Change 3648748 on 2017/09/18 by Max.Preussner WmfMedia: Hack for preventing flicker between media source switching Do not merge to Dev-Main! #!rb stephan.jiang #!rnx #!tests none Change 3648596 on 2017/09/18 by Bart.Hawthorne More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough. Change 3648575 on 2017/09/18 by Sam.Zamani #!tencent Fix for missing library calls when initializing TSS anti cheat SDK #!rb none #!tests compiles win64 server Change 3648556 on 2017/09/18 by Jeff.Williams Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084 Clearing up robomerge #!rb none #!tests none Change 3648533 on 2017/09/18 by clayton.langford Unblocking RM. #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly. #!RB Adric.Worley #!tests none #!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3648219 on 2017/09/18 by Sam.Zamani #!tencent fixed Tencent module thirdparty dll runtime dependency paths fixed DLLHandle not being set #!rb none #!tests none Change 3647998 on 2017/09/18 by Clayton.Langford Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763. #!tests compiled #!rb Adric.Worley Change 3647817 on 2017/09/18 by James.Golding Mirror fix from 4.18 release stream (CL 3647799) to Dev-General Fix out-of-bounds access of cloth mapping data during CPU skinning #!rb benn.gallagher #!jira UE-49628 #!fyi benn.gallagher #!tests convert RiftMage to static mesh Change 3647749 on 2017/09/18 by Benn.Gallagher Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope. This caused matrix transposition to fail after the data was copied in using memcpy BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #!rb none #!tests Editor reimport of clothing assets Change 3646242 on 2017/09/15 by Tyler.Cole Revert shared engine LocalMCP scripts. Change 3646153 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds #!RB:daniel.lamb #!Tests: Ran cooked Client [CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy #!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3646125 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: arne.schober OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews. #!RB Marcus.Wassmer #!tests automated performance tests #!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3645861 on 2017/09/15 by clayton.langford #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW. Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added. To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated. #!tests ran local client/server, preflighted #!rb Ben.Salem #!rnx [FYI] Sean.Tobin, Hunter.Kent, Edward.King #!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3644062 on 2017/09/14 by Aaron.McLeran #!jira OR-44171 Some looping sounds are extremely loud #!rb Ethan.Geller #!tests run paragon, run near water river, don't observe looping sound being very loud Change 3643901 on 2017/09/14 by Laurent.Delayen Integrated CL #!3604725 to fix bug with opening state machines from anim graph. #!rb none #!tests fixes bug #!FYI lina.halper Change 3643641 on 2017/09/14 by Rob.Cannaday Fix unreachable code detected #!rb rob.cannaday #!tests Win64 compile Change 3643326 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TerSafe.dll loading until staging issues can be resolved #!rb none #!tests none Change 3643039 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TSS on servers due to linux build issues #!rb none #!tests none Change 3642438 on 2017/09/13 by Rob.Cannaday Handle new analytics param types (number, string, etc) Stub implementation of FAnalyticsProviderETTencent DefaultAttrs #!rb rob.cannaday #!tests Win64 vs AI match Change 3641655 on 2017/09/13 by Sam.Zamani #!tencent WIP added tss_sdk.dll (server) and TerSafe.dll (client) JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers #!rb none #!tests PC run with RegionCN.pak enabling tencent mode Change 3641559 on 2017/09/13 by Bart.Hawthorne Fix up oodle dictionary generation scripts #!rb none #!jira none Change 3641550 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3641393 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev. Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled - Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false) - Added PGOInput option to TargetRules and passed through to compile environment - Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for - Updated PS4 toolchain to use both LTO and PGO depending on what was set #!tests soaked locally, preflighted #!rb codereviewed FWIW here are before/after results for LTCG. Orion Performance report from 3 games and 1441.51 seconds MVP: 2.83 (Min: 2.05, Max: 3.22) HPM: 4.29 (Min: 4.24, Max: 4.37) AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms) GT: 12.88ms (Min: 12.68ms, Max: 13.25ms) RT: 13.71ms (Min: 13.48ms, Max: 14.08ms) GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms) Orion Performance report from 3 games and 1440.49 seconds MVP: 1.42 (Min: 1.02, Max: 1.94) HPM: 3.25 (Min: 2.75, Max: 3.62) AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms) GT: 11.93ms (Min: 11.64ms, Max: 12.47ms) RT: 12.80ms (Min: 12.54ms, Max: 13.24ms) GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms) #!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640885 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Limited warning to once every 10 secs. #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640875 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed shipping config issue #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640870 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Fixing CIS builds #!Orion The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors. [CODEREVIEW] John.Nielson #!rb none #!test compilation #!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640783 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson More temporary logging for finding the missing FX issue. #!rb: none #!Test: Pie #!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639910 on 2017/09/12 by Rob.Cannaday Build fix for AnalyticsETTencent #!rb rob.cannaday #!tests compile Win64 DebugGame Editor Change 3639565 on 2017/09/12 by Laurent.Delayen SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0. #!rb lina.halper #!FYI lina.halper #!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime. Change 3639228 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Tools - Added ability to postmortem a PS4 devkit for last crash #!rb run locally #!tests none #!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639075 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Specifically requesting 'all' configuration, to avoid missing manifest in jar. #!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639022 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka Remove dependency on the editor style set in the WidgetReflector - Fixes a crash when trying to use the reflector in a client cooked build - Also updated Focusable column name to shared var #!rb none #!tests Widget Reflected in a cooked build #!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638984 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638696 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Swapped problematic ensure to LogError, made draft obey notimeouts. #!tests compiled #!rb none [at daniel.lamb] #!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638644 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Third time's the charm #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638628 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure in a PS4 friendly way #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638583 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure to get a cook #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638545 on 2017/09/12 by Bart.Hawthorne Add analytics for oodle compression percentages #!rb ryan.gerleve, wes.hunt #!tests ran a 2 person game with dedicated server and verified analytics were reported #!jira OR-26386 Change 3638172 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Duplicate 3620803 Partial Fix for Dither Opacity Mask #!rb none #!tests PC monolith #!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637643 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Fixing version stream to Main #!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637524 on 2017/09/11 by Andrew.Grant Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests build Win64 editor, ran tests locally #!rb none Change 3637402 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Restored logging of runoptions when not verbose #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637357 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Made 'none' test specify Attended #!rb Daniel.Lamb #!tests compiled #!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637305 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added temporary debug logging cmd line option for finding Jira OrionOR-43600 #!RB: none #!Test: Pie [at David.Ratti] #!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636549 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues #!RB:none #!Tests:none [CODEREVIEW] uriel.doyon #!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636507 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka [OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG. Also: - Added distance formatting type for simple ability description values (will automatically append u to the value) - SimpleAbility description values can now go up to two decimal places Engine: - Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName #!rb Matt.Schembari #!tests PIE OrionEntry & FrontEndScene - various bug repros #!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636372 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Implement fast particle pool memory. Default is 2mb, automatically cleans up oldest used pool slots. Estimated 1/4 time for STAT_PARTALLOC. #!rb Jason.Bestimt #!test paragon ps4 cooked #!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636319 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue with fatal error message not being shown in reports. Fixed issue where some cancelled tests reported as succeeded #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636264 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance #!RB:none #!Tests: Ran client cooked build [CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon [QAREVIEW] #!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635288 on 2017/09/10 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices Fixed missing - in SoloSmoke args that were causing trailing params to be lost #!tests preflighted, ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635145 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to pick up SDK change for patch packages #!rb none #!tests none #!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635097 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added cleardevices option to Gauntlet that removes all devices after running. Added to Orion build scripts #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634985 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Cleaned up some logging around device failures Attempt to handle "Too Many Connections" error at a lower level Added removeall command to PS4DevkitUtil (not yet used) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634897 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Checking in change to timeouts to test theory #!tests ran test locally #!rb none #!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634765 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Scrape another .05ms out of GPU particle simulation. #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634422 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for Gauntlet shutdown issue on builders Fix for BP editing crash from Dev-Framework #!tests ran locally #!rb none! #!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634139 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running #!tests ran locally with single and file-based devices #!rb none #!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633799 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only. #!rb none #!tests monolith02 turrets [CODEREVIEW] lina.halper #!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633647 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Possible fix for OR-43926 from Arne #!tests ran locally, observed no ensures or negative side-effects in UI or HUD #!rb none #!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633637 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Upped timeout for editorbased tests #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632565 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed some test code... #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632385 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device handling. Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems. #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632177 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43 #!rb none #!test local commandlet #!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632131 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix a bug with new local vector-field only project setting #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632034 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where problem devices were reset each attempt #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631812 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device management in Gauntlet #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631787 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes. #!rb none [CODEREVIEW] martin.wilson #!test bot game #!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631251 on 2017/09/07 by Andrew.Grant Additional device selection improvements #!tests #!rb na Change 3630861 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3630620 on 2017/09/07 by Laurent.Delayen RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions. #!rb Ori.Cohen #!codereview benn.gallagher #!tests lane minions test map Change 3629990 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fix for gpu hang on ps4. #!rb Marcus.Wassmer #!test Paragon cooked ps4 #!jira OR-43835 #!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629980 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Moved some missed code to FDebug::HasAsserted() #!tests na #!rb none #!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629975 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Project optimization to only support local vector fields. separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost. #!rb olaf.piesche #!tests monolith ps4/pc #!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629917 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix for sizebyspeed on ps4 #!rb Simon.Tovey #!tests pc #!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629620 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629554 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored screenshot support to gauntlet (now driven externally) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629495 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: don.eubanks Stat panel will only show stat changes or improvements that come from Item sources (cards / gems) #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE [RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base! #!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629468 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring() Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread. #!tests ran locally #!rb none [at marcus.wassmer] #!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629410 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs -------------------------------------- Fix for generating project files #!tests GPF #!rb none #!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629369 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests) #!rb none #!tests verified signing is disabled and game gets to main menu with -fileopenlog [at graeme.thornton] #!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629254 on 2017/09/06 by Laurent.Delayen URO: ensure we don't skip more frames than desired when switching LODs. #!rb lina.halper #!codereview martin.wilson, benn.gallagher #!test lane minions test map Change 3629191 on 2017/09/06 by Laurent.Delayen Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions. #!rb lina.halper #!codereview martin.wilson #!test lane minions test map Change 3629130 on 2017/09/06 by Laurent.Delayen AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug. #!rb none #!tests lane minion test map Change 3628300 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed exception that could occur during tests if all devices were in use #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627915 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Undoing Oodle check for the time being #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627875 on 2017/09/06 by Jason.Bestimt #!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables) #!RB:none #!Tests:none #!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker #!ROBOMERGE: MAIN, 43 Change 3627694 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Improved warnings #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627642 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: david.ratti More logging for OR-43892 and OR-43779 #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627247 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed check that turns out to be bogus #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627240 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures #!tests compiled OrionClient [at daniel.lamb] #!rb none #!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627211 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added ensure for OR-43777 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626839 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added wait to PS4DevkitUtil before trying to postmortem crashdump #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626755 on 2017/09/05 by Rob.Cannaday Merge //Orion/Release-Tencent to //Orion/Dev-General Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded #!rb sam.zamani #!lockdown andrew.grant #!tests Win64 vs AI match, QA smoke test #!fyi sam.zamani Change 3626285 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed BaseDir argument not being correctly applied in tests Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626221 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame. Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement #!rb none #!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz [at Laurent.Delayen] [FYI] [at Andrew.Grant] #!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3625925 on 2017/09/05 by Laurent.Delayen If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want. #!rb benn.gallagher #!codereview martin.wilson, lina.halper #!tests lane minion map Change 3624051 on 2017/09/02 by Andrew.Grant Fixed issue with test params not being set. Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability. #!tests preflighted #!rb none #!review-3624052 @ben.salem Change 3623907 on 2017/09/02 by Andrew.Grant Fixed usesyncedbuild option being broken in Gauntlet #!codereview @daniel.lamb #!tests compiled #!rb none Change 3623906 on 2017/09/02 by David.Ratti Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides #!rb none #!test future wukong pie Change 3623766 on 2017/09/01 by Daniel.Wright [Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box #!rb none #!Tests PC QAGame Change 3623518 on 2017/09/01 by Don.Eubanks Fix for Shipping Client PS4 #!rb none #!tests Compile Shipping Client PS4 #!fyi daniel.lamb andrew.grant Change 3623515 on 2017/09/01 by Daniel.Wright [Copy] Volume materials applied to static meshes operate on the object's bounding sphere #!rb none #!TESTS QAGame PC Change 3623503 on 2017/09/01 by Daniel.Wright [Copy] Fixed ObjectRadius in Volume domain materials #!rb none #!TESTS none Change 3623102 on 2017/09/01 by Marcus.Wassmer Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand #!rb none #!tests monolith on PS4 #!fyi olaf.piesche,tim.elek Change 3623096 on 2017/09/01 by Marcus.Wassmer checkslow -> check to find issues with ILC #!rb none #!tests ran monolith on ps4 Change 3622744 on 2017/09/01 by Laurent.Delayen RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now). Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies. Take gravity from movement component if present, to inherit custom gravity scaling. Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used. If LOD enables new bodies, they are now initialized during simulation. Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default. Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change. Added AnimStats for PreUpdate, Update and Eval. #!rb ori.cohen #!codereview ori.cohen, lina.halper, benn.ghallager #!tests lane minion test map Change 3622743 on 2017/09/01 by Laurent.Delayen Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes. #!rb lina.halper #!tests lane minion test map Change 3622742 on 2017/09/01 by Laurent.Delayen 'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings. Renamed DisplayDebugCustom to DisplayDebugInstance. #!rb lina.halper #!tests lane minion test map Change 3622738 on 2017/09/01 by Laurent.Delayen Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams #!rb lina.halper #!tests lane minion test map Change 3622666 on 2017/09/01 by Jian.Ru Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements #!jira UE-48972, OR-43455 #!rb Chris.Bunner #!tests editor Change 3622579 on 2017/09/01 by Andrew.Grant Fixed shutdown issues with some tests being detected as errors Simplied and cleanup some things in state management of tests. #!tests ShortSOloGame test locally #!rb none Change 3622322 on 2017/09/01 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-40366 from v43 #!tests compiled #!rb Aaron.McLeran #!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3621054 on 2017/08/31 by Andrew.Grant Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests preflighted #!rb none Change 3620755 on 2017/08/31 by Daniel.Lamb Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations. #!rb Jason.Bestimt #!test Cooked paragon ps4 Change 3620541 on 2017/08/31 by Ben.Salem Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting. #!rb none #!tests compiled. Change 3620443 on 2017/08/31 by Mieszko.Zielinski Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4 #!rb none #!test golden path Change 3620428 on 2017/08/31 by Aaron.McLeran #!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General #!rb Ethan.Geller #!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports. Change 3620411 on 2017/08/31 by Mieszko.Zielinski Fix to removal of simuli sources from the AISense_Sight #!UE4 Made sure given source gets removed from ObservedTargets. #!rb none #!test golden path Change 3620343 on 2017/08/31 by Ben.Salem Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on. #!rb clayton.langford #!tests ran shallow and normal FX tests, generated hitches to display. Change 3620050 on 2017/08/31 by Luke.Thatcher [ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/... - USE_DEFRAG_ALLOCATOR was not always defined in all cases. #!rb Daniel.Lamb #!tests none Change 3619836 on 2017/08/31 by Andrew.Grant Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team) #!tests preflighted, ran locally #!rb none Change 3618597 on 2017/08/30 by Dan.Hertzka Fixed Additive UI materials not being affected by the widget opacity - We needed to multiply the sampled color by the alpha of the vertex color Also added fade in anim for scoreboard when showing after the endgame cinematic #!rb Nick.Darnell #!tests Widget alpha affects additive materials Change 3618441 on 2017/08/30 by Laurent.Delayen Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display. #!rb lina.halper #!tests lane minions Change 3618404 on 2017/08/30 by Paul.Moore - Update to new MMS client API from Fortnite. - Add MMS API plugin. #!rb none #!tests matchmaking, v2 MMS matchmaking, draft lobby. #!lockdown andrew.grant Change 3618167 on 2017/08/30 by Marcus.Wassmer Fix fog on PS4, also volume texture clears. #!rb luke.thatcher #!fyi Jordan.Walker #!tests ran monolith on ps4 Change 3617911 on 2017/08/30 by Andrew.Grant Fix for OR-43401, lighting remaining unbuilt #!tests ran cook, verified that lighting for bp components is now correctly found. #!rb marc.audy Change 3617765 on 2017/08/30 by Andrew.Grant Fix for lighting always being unbuilt on some blueprints #!tests cooked data and verified BP components have the correct transform and receive cached lighting data #!rb marc.audy, bp-team Change 3617757 on 2017/08/30 by Laurent.Delayen clang fix #!rb none #!tests none Change 3617700 on 2017/08/30 by Laurent.Delayen Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated. #!rb lina.halper #!tests lane minions map Change 3617695 on 2017/08/30 by Laurent.Delayen Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays. #!rb lina.halper #!tests test lane minions map Change 3616757 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-43459 from Laurent #!tests na #!rb Lina.Halper, Andrew.Grant #!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616745 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3609966 in anticipation of patch #!rb #!tests na #!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616551 on 2017/08/29 by Daniel.Lamb Fix memory leak in paragon. #!rb Andrew.Grant #!test Paragon ps4 Change 3613700 on 2017/08/28 by Andrew.Grant Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion Renabled r.Cache.UpdatePrimsTaskEnabled #!tests ran locally #!rb none Change 3613694 on 2017/08/28 by Andrew.Grant Added -teamsize argument to Orion none test. #!tests ran None test :) #!rb none Change 3613638 on 2017/08/28 by Ben.Salem Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created. #!rb clayton.langford #!tests Ran shallow and deep test for multiple characters. Change 3612731 on 2017/08/28 by Chris.Bunner [DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook. #!rb #!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb #!tests Cooking/running simple scene with grass foliage #!jira UE-48698, OR-42612 Change 3612695 on 2017/08/28 by Andrew.Grant Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things. #!tests ran NoneTest with -nomcp #!rb none Change 3612002 on 2017/08/27 by Andrew.Grant Fix for crash seen during nightly tests #!tests baseline perf didn't crast 3/3 #!rb none Change 3611980 on 2017/08/27 by Andrew.Grant PS4DevkitUtil post-mortem improvements to logging #!tests run ShortSoloGame #!rb none Change 3611758 on 2017/08/26 by Andrew.Grant Fix for warning #!tests #!rb na Change 3611737 on 2017/08/26 by Andrew.Grant Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering 3517039 - GitHub #!2655: Optimization for shadow map resolution selection for spot lights * Use the radius of the inscribed sphere at the cone end as the spot light's screen radius Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly 3545241 - Fixed spotlight whole scene shadows using a radius 2x too long 3545347 - Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame. #!rb none #!tests compiled Change 3611718 on 2017/08/26 by andrew.grant #!CodeReview: andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs -------------------------------------- Improved parsing of callstacks and errors in test logs Added unit test for error parsing #!tests ran locally, unit tests #!rb none #!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611704 on 2017/08/26 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Test fixes - addresses issue with memory report failing #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611683 on 2017/08/26 by Andrew.Grant Upgraded PS4 SDK to 4.508.111 #!tests SoloGames locally #!rb none Change 3611466 on 2017/08/25 by Andrew.Grant Changed none test to use monolith02 by default #!tests compiled #!rb none Change 3611167 on 2017/08/25 by Laurent.Delayen Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated. #!rb none #!tests lane minions #!codereview martin.wilson Change 3610850 on 2017/08/25 by dan.hertzka Unclog Robomerge #!rb none #!tests none Change 3610325 on 2017/08/25 by Andrew.Grant Compile fix for PS4 #!tests compiled #!rb none Change 3610018 on 2017/08/25 by Laurent.Delayen UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later. #!rb lina.halper #!tests venus ult on minion lane test map Change 3609967 on 2017/08/25 by Daniel.Lamb Merging using //Fortnite/Main/->//Orion/Dev-General/ Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4. CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping. - The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out. - Added an extra flag to reset mip bias values when texture memory budget is increased. #!rb Uriel.Doyon #!jira FORT-45385 #!jira FORT-47739 CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4. - Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled. - Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted. - Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps. #!jira FORT-45229 #!rb Ben.Woodhouse CL 3564368 LLM Changes Summary: LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead. Changes where LLM hooks into the various allocation functions and pools. Added more LLM tracking scopes. Changed the way LLM gets its internal memory. Writing stats out to csv Fixed a few bugs with the tracker code Details: * re-enabled LLM by default in Dev builds for XB1 and PS4 * Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update) * track allocations made from the defrag pool (PS4) * track non-drfrag pool garlic allocations (PS4) * track allocations made from PS4 malloc * combined the RHI and Malloc trackers into the Default tracker * changed stat groups to LLM, LLMPlatform and LLMOverhead * OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set * XMemAlloc now uses AllocationType if no LLM scope has been set * renamed VirtualMap to LLMMap * added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled. * support for tracking allocations that move in memory (for the PS4 defrag allocator) * support for tracking explicit memory without pausing the tracker * LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg * fixed check in FNameToTag. It was checking the wrong value when verifying the name index * show a warning on screen if LLM has been enabled without debug memory enabled (on consoles) * fixed program size tracking * fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope. * optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times) * fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them. * fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled * changed default alloc size for LLMMap to 16K * Added lots more LLM scopes renamed some of the existing ones * made FMemBlock::Allocators private and added accessor functions, which include LLM tracking. * fixed LLM alignment tracking in CustomVirtualAlloc * implemented LLM on XB1 so that it properly tracks D3D12Allocations * added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator * tracking of render targets * fixed LLM pool total column value. #!rb luke.thatcher CL 3565905 [ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/... 3458941 - Initial submission of new PS4 memory allocator. 3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible. 3498440 - Flexible and framebuffer memory fallbacks 3515704 - Add stats to new PS4 memory system. UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly. #!rb Ben.Woodhouse CL 3580934 [FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo. - Neo has 512 MB more direct memory than a base kit. - Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB. #!rb Marcus.Wassmer #!jira FORT-50206 CL 3590180 [FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted. - Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB. - Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool. - Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails. #!jira FORT-49700 #!rb Aaron.McLeran CL 3593920 [FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system. - Incorrect bitmask usage was truncating the available memory value to 32 bits. - Also includes some minor refactoring to make parts more readable. - Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile. #!rb Jonathan.Fitzpatrick #!jira FORT-50918 CL 3597577 [FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU. - Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack. - With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is. #!rb Stewart.Lynch #!jira FORT-50825 #!jira FORT-49688 #!jira FORT-49695 #!jira FORT-50054 CL 3601951 [FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system - Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0. - Added garlic, onion and defrag stats to the platform memory stats struct. - Added fixed pool sizes to platform memory stats. - Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools. #!rb Stewart.Lynch #!jira FORT-52910 #!test preflight with baseline performance memory report tests, local tests on neo #!rb Luke.Thatcher Change 3608480 on 2017/08/24 by Uriel.Doyon Instanced static mesh lightmaps are now updated correctly after lighting scenario changes #!jira UE-48522 #!tests Build lighting, loaded maps #!rb michel.dupuis Change 3608407 on 2017/08/24 by Andrew.Grant Reintegrated ROlando's cloth optimizations #!tests #!rb none Change 3608349 on 2017/08/24 by Rolando.Caloca O - Cloth vertex buffers no longer generate dummy vertices #!rb Lina.Halper #!fyi James.Golding #!tests Check obj list memory with multiple characters, tested animations Change 3607815 on 2017/08/24 by Laurent.Delayen Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha. https://jira.it.epicgames.net/browse/OR-43186 #!rb none #!tests Price hand two bone IK #!codereview lina.halper, thomas.sarkanen Change 3607770 on 2017/08/24 by Andrew.Grant Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong #!tests ran locally, updated parser test #!rb none Change 3607546 on 2017/08/24 by Jian.Ru Add more control to chromatic aberration effect #!jira UE-47138 #!rb Brian.Karis #!tests editor Change 3607270 on 2017/08/24 by Andrew.Grant Mirroring 3605735 from FN to address bug with MIC deduplication #!tests compiled #!rb none Change 3607082 on 2017/08/24 by Laurent.Delayen Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands. List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph). Current debug Target is highlighted in a green bounding box. Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player. Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors. Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation. #!rb dave.ratti #!tests lane minion test map, debugging individual minions #!codereview jon.lietz Change 3606772 on 2017/08/24 by David.Ratti Spot edigrate CL 3606417 for accurate CurveTable memory tracking #!rb none #!tests none [CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
}
if (ClassDisplayName.IsEmpty())
{
ClassDisplayName = AssetTypeActions.Pin()->GetName();
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
if ( ClassDisplayName.IsEmpty() )
{
Copying //UE4/Dev-Editor to Dev-Tools-Staging (//UE4/Dev-Tools-Staging) @11123875 #rb none #jira none [CL 11123880 by Max Chen in Dev-Tools-Staging branch]
2020-01-27 20:11:15 -05:00
ClassDisplayName = Class->GetDisplayNameText();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
Fixed code relying on SLATE_TEXT_ATTRIBUTE for STextBlock. UETOOL-213 - Minimize Slate FString -> FText conversion (remove SLATE_TEXT_ATTRIBUTE) This fixes any editor/engine specific code that was passing text to Slate as FString rather than FText. [CL 2399803 by Jamie Dale in Main branch]
2015-01-07 09:52:40 -05:00
return ClassDisplayName;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Fixed code relying on SLATE_TEXT_ATTRIBUTE for STextBlock. UETOOL-213 - Minimize Slate FString -> FText conversion (remove SLATE_TEXT_ATTRIBUTE) This fixes any editor/engine specific code that was passing text to Slate as FString rather than FText. [CL 2399803 by Jamie Dale in Main branch]
2015-01-07 09:52:40 -05:00
FText GetAssetClassDisplayName() const
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
const FAssetData& AssetData = AssetThumbnail->GetAssetData();
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
FTopLevelAssetPath AssetClass = AssetData.AssetClassPath;
UClass* Class = FindObjectSafe<UClass>(AssetClass);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
if ( Class )
{
Copying Orion-Staging @ 3748653 (Orion/Dev-General @ 3722124) to //UE4/Main #lockdown Nick.Penwarden #rb none Change 3720210 on 2017/10/25 by Olaf.Piesche Fixing dynamic material params for ribbons #!codereview scott.kennedy #!rb none #!tests scott's test ribbon Change 3720073 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: frank.fella Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it. #!Tests Minion automated tests no longer crash randomly. #!rb SimonT #!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3719233 on 2017/10/25 by robomerge #!ROBOMERGE-AUTHOR: philip.buuck [OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead). #!rb Matt.Schembari #!tests PIE [QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death #!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3718474 on 2017/10/25 by Yannick.Lange Niagara: Only show isolate menu items on track context menu if it is a system. Rename "Isolate toggle" to "Isolated". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718095 on 2017/10/25 by Yannick.Lange Niagara: Fix crash when not having dynamic parameter in material. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3718069 on 2017/10/25 by Yannick.Lange Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression. #!rb none #!codereview Shaun.Kime #!tests n/a Change 3717545 on 2017/10/24 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Removed read / write locks from PipelineStateCache. #!rb Andrew.Grant, Gil.Gribb #!test paragon ps4. #!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3716928 on 2017/10/24 by Shaun.Kime The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime. #!rb olaf.piesche, simon.tovey #!fyi olaf.piesche, simon.tovey, frank.fella #!tests am now able to run Test_minionWave on PS4 Change 3715712 on 2017/10/24 by Yannick.Lange Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf". #!rb none #!codereview Shaun.Kime #!tests n/a Change 3715430 on 2017/10/23 by Shaun.Kime Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it. #!rb none #!fyi simon.tovey #!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime Change 3715368 on 2017/10/23 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main) #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3715226 on 2017/10/23 by Shaun.Kime Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's. #!rb none #!fyi simon.tovey, olaf.piesche, frank.fella #!tests ran in PIE Change 3714645 on 2017/10/23 by Yannick.Lange Niagara: Add ability to create particle system from this emitter in content browser. #!rb Shaun.Kime #!tests n/a Change 3714200 on 2017/10/23 by Olaf.Piesche Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target #!codereview simon #!rb none #!tests Orion Niagara assets Change 3713341 on 2017/10/23 by Yannick.Lange Niagara: Fix NiagaraNodeIF output pins cannot be deleted. Fix NiagaraNodeIF output pins cannot be renamed. #!jira UE-50193 #!jira UE-50193 #!rb Shaun.Kime #!tests n/a Change 3713133 on 2017/10/23 by Yannick.Lange Niagara: Isolate emitters in sequencer UI. - Added being able to extend the sequencer track context menu with a delegate. - Added entry in track context menu to toggle the selected emitters isolation state. - Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters. #!rb Shaun.Kime #!tests n/a Change 3712445 on 2017/10/22 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime UVScale, UniformAorBFloat, and LinearColorAlongVector added. #!rb none #!tests new autotest added #!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3712420 on 2017/10/21 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1. #!rb none [CODEREVIEW] frank.fella [FYI] simon.tovey, olaf.piesche, wyeth.johnson #!tests created an emitter, disabled Acceleration Force.. still compiled. #!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711602 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like: LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData #!jira UE-51511 #!rb Simon.Tovey #!tests n/a #!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711288 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: eric.ketchum [Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work #!rb: None #!tests: PIE [CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime #!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3711197 on 2017/10/20 by Olaf.Piesche Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly #!rb none #!tests minion projectile ribbon trail Change 3710634 on 2017/10/20 by Mic.Rooney Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing. #!RB: none #!Test: tested/built locally ran preflight Editor/Monolithics build. #!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3709686 on 2017/10/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Added some more timerguards for slow timer manager tick objects. Commented out for now. #!rb Trivial #!test Paragon Cooked ps4. #!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708958 on 2017/10/19 by Shaun.Kime Back out changelist 3708456 .. this was an unintentional change #!rb none #!tests n/a Change 3708839 on 2017/10/19 by Shaun.Kime Merging CL 3708835 Fixing Scott's common crash with adding an emitter with autocompile off #!rb frank.fella #!tests n/a Change 3708784 on 2017/10/19 by Shaun.Kime Merging CL 3708782 //Orion/Main/... to //Orion/DevGeneral/... #!rb none #!tests n/a Change 3708600 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion #!rb none #!test golden path #!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3708473 on 2017/10/19 by Shaun.Kime Merging Frank's changes for team color support from Main to Dev-General #!rb Frank.Fella #!tests test_minionwave worked Change 3708456 on 2017/10/19 by Shaun.Kime Particles.Random set to 0.0 #!rb none #!tests n/a Change 3708455 on 2017/10/19 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests passed minion fx autotest Change 3707648 on 2017/10/19 by Shaun.Kime Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made. Defer deletion of dataset to RT. Ensure resets don't mess with data inflight RT commands are using. Checkin on behalf of Simon Tovey #!jira OR-45423 #!rb Simon.Tovey #!tests ran through the LaneMinionFXTests successfully on PC Change 3707096 on 2017/10/19 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago. #!rb none #!tests automated tests pass #!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3706726 on 2017/10/19 by Rob.Cannaday Merge XMPP resource version to use version 2 instead of version 3 #!rb trivial #!tests compile #!ROBOMERGE: Main, 44, Tencent Change 3706349 on 2017/10/19 by Josh.Markiewicz #!UE4 - Cross Voice code review feedback - fixed up broken stack vs queue - fixed GetRoomId returning int32 instead of uint64 - fixed switch room logic - more/better logging - more comments #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday #!rb none #!tests local cheat codes Change 3705453 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: arne.schober Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array) #!RB Daniel.Wright #!Tests LaunchOnPs4 #!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3705399 on 2017/10/18 by robomerge #!ROBOMERGE-AUTHOR: scott.kennedy Default Niagara emitter changed color property to better default value. Updated basic glow emitter Added energy bubble base emitter put a little more polish into siege minion impact FX. #!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3704426 on 2017/10/18 by Shaun.Kime Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423 #!rb simon.tovey #!fyi hunter.kent #!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure Change 3703288 on 2017/10/18 by Olaf.Piesche Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash #!rb olaf.piesche, simon.tovey #!tests minion test map PC and PS4 Change 3701373 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: shaun.kime Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader. #!rb Olaf.Piesche #!tests test_minionwave runs #!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3701108 on 2017/10/17 by Hunter.Kent Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily. #!RNX #!Test PS4 #!rb @tim.elek #!review-3701110 @andrew.grant, @daniel.lamb Change 3701044 on 2017/10/17 by robomerge #!ROBOMERGE-AUTHOR: jon.lietz - white space fixes - added in more detail to logging - fixed dragon GC to not hide when the mesh is hidden #!rb none #!tests complies and logging is updated [FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen #!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3700900 on 2017/10/17 by Shaun.Kime Integrating possible crash fix from Dev-Niagara to Dev-Gen #!rb none #!tests n/a #!fyi Olaf.Piesche Change 3700492 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests done in branch Change 3700217 on 2017/10/17 by Olaf.Piesche Fix for potential crash in sprite renderer #!rb none #!tests minion test map Change 3700216 on 2017/10/17 by Benn.Gallagher Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master. #!rb Lina.Halper #!jira OR-45226 #!tests PIE + Standalone games hitting Rampage with Ghosts E Change 3699660 on 2017/10/17 by Jason.Bestimt #!ORION_DG - Fixes to UnrealHitchParser edge cases #!RB:none #!Tests: Ran on Logs from QA #!CodeReview: ben.salem Change 3699462 on 2017/10/17 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!tests preflight ok #!rb none Change 3699010 on 2017/10/17 by Jeff.Williams Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920 #!rb none #!tests none Change 3698519 on 2017/10/16 by Olaf.Piesche Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts #!rb none #!tests minion wave test map Change 3698380 on 2017/10/16 by Shaun.Kime Updating logic to now support the autoattachment #!rb none #!tests autotests pass.. Change 3698263 on 2017/10/16 by Olaf.Piesche Assume degrees for sprite rotation #!rb none #!codereview shaun.kime #!tests test sprite emitter Change 3697652 on 2017/10/16 by Olaf.Piesche Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion #!rb none #!tests minion test map Change 3696906 on 2017/10/15 by Shaun.Kime Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers. #!rb none #!tests now no longer generates invalid errors #!fyi frank.fella, olaf.piesche, simon.tovey Change 3695456 on 2017/10/13 by Olaf.Piesche Fix for potential ribbon crash and end-of-ribbon rendering artifacts #!rb none #!codereview scott.kennedy #!tests minion wave test map Change 3694545 on 2017/10/13 by Andrew.Grant Fix for low frequency async loading crash (OR-42535) #!rb gil.gribb #!tests comppiled Change 3694176 on 2017/10/13 by Jeff.Williams Plugin manifest name changed to DLCFile name #!rb none #!tests compile, stage Change 3693582 on 2017/10/12 by Don.Eubanks Fixing PS4 Compile warning (constructor init order not matching member define order) #!rb none #!tests Compile Shipping Client PS4 #!fyi olaf.piesche Change 3693516 on 2017/10/12 by Olaf.Piesche Niagara: Remove mesh renderer assert, replace with early out #!rb none #!tests niagara mesh test asset Merging //Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp Change 3693051 on 2017/10/12 by Ben.Salem Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log. #!rb Clayton.Langford #!tests Parsed a 5mb log with dumphitches down to 23k of hitch data. Change 3692912 on 2017/10/12 by Olaf.Piesche Merging: Niagara ribbon tiling distance #!rb none #!tests ribbon test asset Change 3692835 on 2017/10/12 by Shaun.Kime Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags. #!rb none #!fyi scott.kennedy, wyeth.johnson #!tests n/a Change 3692751 on 2017/10/12 by Shaun.Kime Removing script that shouldn't have come over. #!rb none #!tests n/a Change 3692746 on 2017/10/12 by Shaun.Kime Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara #!rb none #!tests opened test level and created new emitter/system Change 3692616 on 2017/10/12 by Don.Eubanks OR-45131 Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking. #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE #!codereview nick.darnell Change 3691912 on 2017/10/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none #!tests compile, editor #!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3690944 on 2017/10/11 by Jeff.Williams Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC. #!rb Daniel.Lamb #!tests Compile, build Change 3688989 on 2017/10/10 by Lina.Halper LOD sync of attached/parent #!rb: Laurent.Delayen #!tests: price with shotgun skin/PIE/editor Change 3687592 on 2017/10/09 by Ben.Salem Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test. #!rb clayton.langford #!tests Ran sparrow shallow tests. Change 3686560 on 2017/10/09 by Shaun.Kime Flipping the min/max values to be standard #!rb none #!tests n/a Change 3686046 on 2017/10/09 by Shaun.Kime Merging latest from Dev-Niagara in preparation for Effects team work on Monday #!rb none #!tests successful preflight #!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek Change 3685613 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: simon.tovey Implementing vector field matrix inverse fix from CL3675167 to 43.3. #!rb none #!tests none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685603 on 2017/10/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross RotationalContent Improvements - Fixed potential bug where tags could be updated when not intended on RotationalContentManager - Fix for PIE assert - Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option. - Removing config tag from RotationalContentOverrides in OrionGlobals. New Halloween Gauntlet Test - Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box. #!rb none #!tests local builds / editor / PIE #!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685408 on 2017/10/07 by ben.salem Fixing robomerge error in DevGen #!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. ben.salem, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml -------------------------------------- Merging using DevGen->Release43.3 Repairing mailer for nightly Perf tests, fixing email headers. #!tests run in devgen #!rb none #!lockdown andrew.grant #!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3685073 on 2017/10/06 by Andrew.Grant Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General) #!tests #!rb na Change 3684717 on 2017/10/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where GT & RT times in profile info were reversed :( #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3684512 on 2017/10/06 by Laurent.Delayen Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code. #!rb lina.halper #!tests minion AnimBP nativization Change 3684059 on 2017/10/06 by Max.Preussner Orion: Fixed ability videos not loading on PS4 and/or not looping #!fyi stephan.jiang #!jira OR-44682 #!rb none #!rnx #!tests none Change 3683538 on 2017/10/06 by David.Ratti batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions. -Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players. -Fixes case where killing minions with badass was not displaying pops (prediction key issue) #!rb none #!tests editor, pie #!review-3683539 @Matt.Schembari Change 3683364 on 2017/10/06 by Andrew.Grant Changed warning to info #!tests #!rb na Change 3681999 on 2017/10/05 by Bart.Hawthorne Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion. #!rb cody.haskell #!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore #!jira OR-44111 #!tests Golden path, live spectated numerous matches. Change 3681403 on 2017/10/04 by Josh.Markiewicz #!UE4 - base pass for Tencent Cross SDK - basic testing done with enter/exit/switch room - basic testing of ShowUI - checked in disabled #!rb duck #!tests see above #!jira TEN-301 #!review-3681404 @sam.zamani, @rob.cannaday Change 3680623 on 2017/10/04 by David.Ratti Rework for how max movement speed is calculated. The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow. Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored. Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow. GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc). Suggested methods for inspection: AbilitySystem debug hud (Home/End) p.VisualizeMovement (displays final calculated movement speed) Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar) Technical information: 1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool. 2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows. 3. Added a notification for attribute sets when an aggregator is created for one of their attributes. 4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod) 5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension. #!tests pie #!rb FrankG #!codereview Fred.Kimberley, Billy.Bramer #!fyi colin.fogle #!QAReview #!RN #!designchange Change 3680580 on 2017/10/04 by Ben.Salem Repair email titles for various reports. #!rb none #!tests Reran tests. Change 3680438 on 2017/10/04 by Dan.Hertzka GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect - Fixes the HUD status effect feed not showing sources for a lot of itemization abilities Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip #!rb Dave.Ratti #!tests OrionEntry PIE - equipped Sand Speeder #!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on Change 3680344 on 2017/10/04 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Speculative disable of defragging on volumetric lightmap textures. #!rb andrew.grant #!test monolith2 ps4 #!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3680302 on 2017/10/04 by Shaun.Kime Integration from DevNiagara. Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array. #!rb none #!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek #!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass. Change 3679946 on 2017/10/04 by Laurent.Delayen Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches. #!rb lina.halper #!FYI andrew.grant #!tests monolith2 old minions Change 3679938 on 2017/10/04 by Daniel.Lamb Allowed foliage cullall option to be modified by scalability options. #!rb Trivial #!test Compile paragon editor Change 3679563 on 2017/10/04 by Jon.Lietz OR-43599 - added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it. #!rb Dave.Ratti #!review-3679564 @John.Nielson #!tests added these waits to hot pursuit and they worked as expected Change 3679006 on 2017/10/03 by Ben.Salem Try to fix broken nightly mailer issues for FX tests. #!rb none #!tests Preflighted a shallow fx pass successfully in EC. Change 3677845 on 2017/10/03 by Andrew.Grant Added an ensure to guard against OR-44826 while further investigations occur #!tests compiled #!rb none Change 3677443 on 2017/10/03 by John.Nielson Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase. Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify). #!RB: None #!Test: Pie, Uncooked #!review-3677445: @David.Ratti Change 3676748 on 2017/10/02 by Laurent.Delayen Minions: split body layer is now done in mesh space, to maintain upper body orientation. #!FYI ray.arnett, lina.halper #!rb none #!test lane minion test map Change 3675950 on 2017/10/02 by Don.Eubanks Added several new supported tags / status effects to the Floating Status Effect Text system. Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player. Added ScaleOverDistance curve support for floating numbers / text. Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out. #!rb matt.schembari #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 Change 3675186 on 2017/10/02 by Mic.Rooney Support for other anim curve driving audio types (right now specifically DialogueWave) #!RB: none #!Test: compiled editor/monolithics/withoutunity and tested locally. #!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen Change 3675167 on 2017/10/02 by Shaun.Kime Changed unsafe InverseFast() to an Inverse() #!jira OR-44671 #!rb Simon.Tovey #!tests n/a Change 3674888 on 2017/10/02 by David.Ratti GGP V2 * Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration. Item System: * Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords. * Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup). Ability System: * SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE) #!rb none #!tests editor pie cooked #!review-3674889 @Jon.Lietz Change 3674170 on 2017/09/30 by Mieszko.Zielinski Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load. #!rb none #!test golden path #!OR-44738 Change 3672937 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files #!tests 3compiled #!rb none #!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672867 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored previous behaviour of integer numbers being formatted as "1" and not "1.00" #!tests ran game, checked playlist analytic #!rb nikdel #!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672575 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Remove warning that can happens normally with backwards compat replays #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672548 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Andrew.Grant #!test Editor building hlods #!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672542 on 2017/09/29 by Andrew.Grant Merging #!rb #!tests na Change 3672390 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed memreport settings for frontend tests #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672385 on 2017/09/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Reworked and pretty much final PipelineState cache code - various comments incorporated - namespaced functions - removed redundant class and replaced with ref pointer #!tests soaked a lot [at daniel.lamb,] [at arne.schober] #!rb none #!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3672281 on 2017/09/29 by Rob.Cannaday Add user ID to OnNetworkCheatDetected #!jira TEN-272 #!jira TEN-273 #!jira TEN-274 #!rb rob.cannaday #!tests Win64 AI match, simulate cheat detected by cheat command #!review-3672282 @ian.fox @sam.zamani Change 3671688 on 2017/09/29 by Frank.Gigliotti Added ability to set developer comment when adding native tags. #!RB David.Ratti #!Tests None Change 3670409 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for dump type made while doing cleanup #!tests compiled Win64, PS4, ran PS4 #!rb none #!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3670399 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed race condition in pipeline state cache Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon (Couple of extra tweaks planned, but this should be GTG for a v43 release) #!rb codereviewed #!tests soaked locally, lots #!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669802 on 2017/09/28 by Andrew.Grant From Dev-Framework #!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed #!rb michael.noland #!codereview andrew.grant #!tests na Change 3669709 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669177 on 2017/09/28 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Reflection Captures support Lighting Scenarios without recapturing * Reflection Captures are now part of the Map Build * Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message) * Reflection Capture build data moved to the BuildData package * Building lighting / reflection captures no longer dirties ULevels * Sky lights which capture the scene now work correctly with Lighting Scenarios * Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded) #!rb Marcus.Wassmer #!TESTS Paragon editor Monolith02 #!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3669124 on 2017/09/28 by Daniel.Lamb Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush Fix cook in devgeneral Bumped shader version to invalidate stale uniform buffer name. #!rb none #!TESTS none #!fyi Daniel.Wright Change 3667906 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667899 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Remove unused SM4 reflection capture cubemap #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667894 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] SM4 fallback for reflection captures. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667859 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy from Brian] Removed old rasterized deferred reflection env path. Removed reflection compute shader. Replaced with PS. Small perf gain. #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667852 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Fixed missing include #!rb none #!TESTS none #!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667807 on 2017/09/27 by Daniel.Lamb Tencent DLC can now remap the plugin content to the game root directory. #!rb Ben.Marsh #!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test Change 3667753 on 2017/09/27 by Clayton.Langford Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer. #!RB Ben.Salem, Adric.Worley #!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat Change 3667408 on 2017/09/27 by Jordan.Walker Optimization to bakedNormal layer blend on Low end material quality -uses simple multiply and add normal map blend Change 3667388 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times. #!rb none #!TESTS QAGame on console #!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667383 on 2017/09/27 by robomerge #!ROBOMERGE-AUTHOR: daniel.wright [Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame. #!rb none #!TESTS QAGame #!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3667265 on 2017/09/27 by Daniel.Lamb Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned. #!rb Uriel.Doyon #!test Editor building hlods Change 3667159 on 2017/09/27 by Mieszko.Zielinski Added simple logging to BT loading allowing us to identify missing BB keys #!Orion #!test golden path #!rb Lukasz.Furman Change 3665944 on 2017/09/26 by Dan.Hertzka Fix PS4 compile #!rb none #!tests compile PS4 Change 3665590 on 2017/09/26 by Daniel.Lamb Fix for DLC cooking everything when it should only cook the DLC. #!rb None #!test None Change 3665569 on 2017/09/26 by Dan.Hertzka New status effect feed for the new HUD: - Now placed in the mid-upper-left side of the HUD - Biggest difference from before is that there are now names associated with each effect - If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet. Cleaning: - Deleted all of the old buff widget classes & codepaths - Removed redundant properties from StatusEffectDisplayInfo - Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData Also: - Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events - Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed) @todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.) #!rb Don.Eubanks #!tests OrionEntry PIE with some cards and hero abilities #!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial. #!lockdown Billy.Rivers Change 3665555 on 2017/09/26 by Daniel.Lamb AudioStreaming mpsc queue fix up. #!rb Andrew.Grant #!test Compile paragon client / editor. Change 3665517 on 2017/09/26 by Daniel.Lamb Suspect fix for OR-44619 #!jira OR-44619 #!test Paragon editor compile #!rb Trivial Change 3664346 on 2017/09/26 by Jon.Lietz - making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out. - Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired. - Updated all GC's data to use the new decal class - removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent #!rb Dave.Ratti #!reivew Dave.Ratti #!tests used characters that had decal comps in the GC and they recylce as expected. #!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed. Change 3664099 on 2017/09/26 by Jon.Lietz OR-44510 - bringing over engine fixes for the Enum Redirector from Dev-Framework #!rb none #!tests compiles and warnings are gone Change 3663019 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Gil: fixed race condition in the PipelineStateCache #!rb Daniel.Lamb #!test paragon ps4 with higher repro modified build #!lockdown Andrew.Grant #!jira OR-44441 #!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663014 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready. #!tests ran locally #!rb [at daniel.lamb] [at arne.schober] #!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3663004 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed dev check for extra commandline args from /data to /temp0 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662999 on 2017/09/25 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Fixed DateTime used for folders not being set #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3662255 on 2017/09/25 by Sam.Zamani #!tencent - fix for link error due to missing define of static OnNetworkCheatDetected delegate #!rb none #!tests none Change 3662073 on 2017/09/25 by Sam.Zamani #!tencent Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server Possible options #!jira TEN-275 TSS detect and expose punish user callbacks KickClient - User should be booted from the current game session via disconnect KickMatch - User received info about being punished (eg. ban type etc) PunishInfo - User received info about being punished (eg. ban type etc) #!rb rob.cannaday #!tests none Change 3659487 on 2017/09/22 by Josh.Markiewicz #!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin #!review-3659190 john.barrett, ryan.gerleve Change 3659485 on 2017/09/22 by Josh.Markiewicz #!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins #!fyi john.barrett, ryan.gerleve Change 3659184 on 2017/09/22 by Josh.Markiewicz #!UE4 - delete EpicSurvey module #!fyi justin.sargent, nick.darnell #!rb none Change 3658697 on 2017/09/22 by Ryan.Gerleve Fixes for server-side Tencent anti-cheat library integration: -Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows -Add getter for the TssSdkAntiInterf object -Enable server anti-cheat in editor builds #!codereview sam.zamani #!rb none #!tests enabled Tencent OSS, built & ran server Change 3658200 on 2017/09/22 by Graeme.Thornton Manual copy of CL 3587584 from Dev-Core Logging improvements for pak signature check failures - Added "PakCorrupt" console command which corrupts the master signature table - Added some extra log information about which block failed - Re-hash the master signature table and to make sure that it hasn't changed since startup - Moved the ensure around so that some extra logging messages can make it out before the ensure is hit - Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again #!rb none #!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General Change 3657970 on 2017/09/22 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition. We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game, [at marcus.wassmer,] [at arne.schober] #!rb none #!tests cycled 6-7 levels of Paragon #!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657914 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing... #!tests stepped through in non-pkg build #!rb none #!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657906 on 2017/09/21 by Andrew.Grant Improved some logging #!tests used locally #!rb none Change 3657891 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing Fixed issue with -dev mode on PS4 not updating symbols #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657867 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Re-locked network CL to 3652780 #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657857 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444 #!RB:arciel.rekman #!Tests:Compiled [CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf #!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657852 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for case-insensitivity causing title.json not to be staged #!rb daniel.lamb, bob.tellez #!tests ran packaging script, verified contents match v42 #!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657831 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors We can worry about a more permanent solution after we get this live. #!RB:none #!Tests: Compiled [CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer #!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657824 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe //ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb -------------------------------------- Built new UnrealCEFSubprocess client Changed OrionBuild.xml to build the shipping version of the above. The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this. [at justin.sargent,[at benjamin.crocker,[at wes.fudala]]] #!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3657488 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: anton.migulko LIGHTING AND assets update #!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3656388 on 2017/09/21 by Laurent.Delayen Added default GetAxisVector static function to EAxisOption #!rb none #!FYI thomas.sarkanen #!tests lane minions test map Change 3656387 on 2017/09/21 by Laurent.Delayen Initialize FAnimInstanceProxy with default constructor. #!rb none #!fyi lina.halper, thomas.sarkanen #!tests lane minion test map Change 3656003 on 2017/09/21 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3650578 for patching benjamin.crocker #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654403 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Merge DevCore -> Orion Release-43 CL 3641450 UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers. #!rb Daniel.Lamb #!test Compile #!lockdown Andrew.Grant #!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3654356 on 2017/09/20 by Andrew.Grant Merging 3653658 from Dev-Rendering #!tests compiled, ran editor #!rb marcus.wassmer Change 3653914 on 2017/09/20 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access). #!rb none #!tests ran locally #!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3652495 on 2017/09/19 by Andrew.Grant Editgration of VR fix in 3643776 from Release-4.17 #!tests #!rb na Change 3652244 on 2017/09/19 by Sam.Zamani #!tencent Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher Added "-q" to whitelist of command line params for shipping builds Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher #!rb rob.cannaday #!tests none Change 3651493 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651490 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651489 on 2017/09/19 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs. #!rb none #!lockdown Nick.Penwarden #!tests none Change 3651445 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag #!RB:none #!Tests:none [CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant #!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651059 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed code to archive load-order during tests #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3651043 on 2017/09/19 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Changed error parsing from tests to put cause ahead of file info #!tests ran self-test #!rb none #!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649683 on 2017/09/18 by Andrew.Grant Bulk-merge of oustanding changes in Main to DG #!tests #!rb na Change 3649345 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Integrate fix for eidtor crash when switching between low and high scaleability options. #!rb Olaf.Piesche #!test Paragon editor #!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649335 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - OR-44257 - Fix for hair not working It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion. #!RB:daniel.lamb #!Tests:Re-tested in cooked build [CODEREVIEW] daniel.lamb #!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649231 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM #!RB:none #!Tests:none [CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy #!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649211 on 2017/09/18 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix 'lowest' shadow settings (simple forward rendering) #!rb arne.schober [FYI] Daniel.Wright #!tests monolith #!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3649141 on 2017/09/18 by Stephan.Jiang Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source. -- These are hacks for ability videos to work before we have the new Sequencer updates -- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748 #!fyi Andrew.Grant, Max.Preussner #!rb none #!test compile Change 3649087 on 2017/09/18 by Thomas.Ross Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General #!rb none #!tests none #!fyi Andrew.Grant,Jeff.Williams,dan.oconnor Change 3649066 on 2017/09/18 by Max.Preussner WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources #!rb stephan.jiang #!rnx #!tests none Change 3649049 on 2017/09/18 by Max.Preussner Media: Changed audio sample rate warning to verbose log #!fyi stephan.jiang #!rb none #!rnx #!tests none Change 3648752 on 2017/09/18 by Max.Preussner WmfMedia: Fixed race condition in media sound wave #!rb none #!rnx #!tests none Change 3648748 on 2017/09/18 by Max.Preussner WmfMedia: Hack for preventing flicker between media source switching Do not merge to Dev-Main! #!rb stephan.jiang #!rnx #!tests none Change 3648596 on 2017/09/18 by Bart.Hawthorne More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough. Change 3648575 on 2017/09/18 by Sam.Zamani #!tencent Fix for missing library calls when initializing TSS anti cheat SDK #!rb none #!tests compiles win64 server Change 3648556 on 2017/09/18 by Jeff.Williams Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084 Clearing up robomerge #!rb none #!tests none Change 3648533 on 2017/09/18 by clayton.langford Unblocking RM. #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly. #!RB Adric.Worley #!tests none #!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3648219 on 2017/09/18 by Sam.Zamani #!tencent fixed Tencent module thirdparty dll runtime dependency paths fixed DLLHandle not being set #!rb none #!tests none Change 3647998 on 2017/09/18 by Clayton.Langford Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763. #!tests compiled #!rb Adric.Worley Change 3647817 on 2017/09/18 by James.Golding Mirror fix from 4.18 release stream (CL 3647799) to Dev-General Fix out-of-bounds access of cloth mapping data during CPU skinning #!rb benn.gallagher #!jira UE-49628 #!fyi benn.gallagher #!tests convert RiftMage to static mesh Change 3647749 on 2017/09/18 by Benn.Gallagher Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope. This caused matrix transposition to fail after the data was copied in using memcpy BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #!rb none #!tests Editor reimport of clothing assets Change 3646242 on 2017/09/15 by Tyler.Cole Revert shared engine LocalMCP scripts. Change 3646153 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds #!RB:daniel.lamb #!Tests: Ran cooked Client [CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy #!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3646125 on 2017/09/15 by robomerge #!ROBOMERGE-AUTHOR: arne.schober OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews. #!RB Marcus.Wassmer #!tests automated performance tests #!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3645861 on 2017/09/15 by clayton.langford #!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW. Unresolved conflicts. clayton.langford, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj -------------------------------------- Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added. To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated. #!tests ran local client/server, preflighted #!rb Ben.Salem #!rnx [FYI] Sean.Tobin, Hunter.Kent, Edward.King #!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3644062 on 2017/09/14 by Aaron.McLeran #!jira OR-44171 Some looping sounds are extremely loud #!rb Ethan.Geller #!tests run paragon, run near water river, don't observe looping sound being very loud Change 3643901 on 2017/09/14 by Laurent.Delayen Integrated CL #!3604725 to fix bug with opening state machines from anim graph. #!rb none #!tests fixes bug #!FYI lina.halper Change 3643641 on 2017/09/14 by Rob.Cannaday Fix unreachable code detected #!rb rob.cannaday #!tests Win64 compile Change 3643326 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TerSafe.dll loading until staging issues can be resolved #!rb none #!tests none Change 3643039 on 2017/09/14 by Sam.Zamani #!tencent - temp disabled TSS on servers due to linux build issues #!rb none #!tests none Change 3642438 on 2017/09/13 by Rob.Cannaday Handle new analytics param types (number, string, etc) Stub implementation of FAnalyticsProviderETTencent DefaultAttrs #!rb rob.cannaday #!tests Win64 vs AI match Change 3641655 on 2017/09/13 by Sam.Zamani #!tencent WIP added tss_sdk.dll (server) and TerSafe.dll (client) JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers #!rb none #!tests PC run with RegionCN.pak enabling tencent mode Change 3641559 on 2017/09/13 by Bart.Hawthorne Fix up oodle dictionary generation scripts #!rb none #!jira none Change 3641550 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3641393 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev. Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled - Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false) - Added PGOInput option to TargetRules and passed through to compile environment - Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for - Updated PS4 toolchain to use both LTO and PGO depending on what was set #!tests soaked locally, preflighted #!rb codereviewed FWIW here are before/after results for LTCG. Orion Performance report from 3 games and 1441.51 seconds MVP: 2.83 (Min: 2.05, Max: 3.22) HPM: 4.29 (Min: 4.24, Max: 4.37) AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms) GT: 12.88ms (Min: 12.68ms, Max: 13.25ms) RT: 13.71ms (Min: 13.48ms, Max: 14.08ms) GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms) Orion Performance report from 3 games and 1440.49 seconds MVP: 1.42 (Min: 1.02, Max: 1.94) HPM: 3.25 (Min: 2.75, Max: 3.62) AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms) GT: 11.93ms (Min: 11.64ms, Max: 12.47ms) RT: 12.80ms (Min: 12.54ms, Max: 13.24ms) GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms) #!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640885 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Limited warning to once every 10 secs. #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640875 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed shipping config issue #!tests #!rb na #!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640870 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: mieszko.zielinski Fixing CIS builds #!Orion The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors. [CODEREVIEW] John.Nielson #!rb none #!test compilation #!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3640783 on 2017/09/13 by robomerge #!ROBOMERGE-AUTHOR: john.nielson More temporary logging for finding the missing FX issue. #!rb: none #!Test: Pie #!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639910 on 2017/09/12 by Rob.Cannaday Build fix for AnalyticsETTencent #!rb rob.cannaday #!tests compile Win64 DebugGame Editor Change 3639565 on 2017/09/12 by Laurent.Delayen SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0. #!rb lina.halper #!FYI lina.halper #!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime. Change 3639228 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Tools - Added ability to postmortem a PS4 devkit for last crash #!rb run locally #!tests none #!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639075 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Specifically requesting 'all' configuration, to avoid missing manifest in jar. #!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3639022 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka Remove dependency on the editor style set in the WidgetReflector - Fixes a crash when trying to use the reflector in a client cooked build - Also updated Focusable column name to shared var #!rb none #!tests Widget Reflected in a cooked build #!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638984 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43 #!rb: none #!test: Pie #!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638696 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Swapped problematic ensure to LogError, made draft obey notimeouts. #!tests compiled #!rb none [at daniel.lamb] #!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638644 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Third time's the charm #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638628 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure in a PS4 friendly way #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638583 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed ensure to get a cook #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3638545 on 2017/09/12 by Bart.Hawthorne Add analytics for oodle compression percentages #!rb ryan.gerleve, wes.hunt #!tests ran a 2 person game with dedicated server and verified analytics were reported #!jira OR-26386 Change 3638172 on 2017/09/12 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Duplicate 3620803 Partial Fix for Dither Opacity Mask #!rb none #!tests PC monolith #!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637643 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jeff.williams Fixing version stream to Main #!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637524 on 2017/09/11 by Andrew.Grant Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests build Win64 editor, ran tests locally #!rb none Change 3637402 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - Restored logging of runoptions when not verbose #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637357 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Made 'none' test specify Attended #!rb Daniel.Lamb #!tests compiled #!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3637305 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: john.nielson Added temporary debug logging cmd line option for finding Jira OrionOR-43600 #!RB: none #!Test: Pie [at David.Ratti] #!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636549 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues #!RB:none #!Tests:none [CODEREVIEW] uriel.doyon #!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636507 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: dan.hertzka [OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG. Also: - Added distance formatting type for simple ability description values (will automatically append u to the value) - SimpleAbility description values can now go up to two decimal places Engine: - Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName #!rb Matt.Schembari #!tests PIE OrionEntry & FrontEndScene - various bug repros #!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636372 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Implement fast particle pool memory. Default is 2mb, automatically cleans up oldest used pool slots. Estimated 1/4 time for STAT_PARTALLOC. #!rb Jason.Bestimt #!test paragon ps4 cooked #!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636319 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue with fatal error message not being shown in reports. Fixed issue where some cancelled tests reported as succeeded #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3636264 on 2017/09/11 by robomerge #!ROBOMERGE-AUTHOR: jason.bestimt #!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance #!RB:none #!Tests: Ran client cooked build [CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon [QAREVIEW] #!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635288 on 2017/09/10 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices Fixed missing - in SoloSmoke args that were causing trailing params to be lost #!tests preflighted, ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635145 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Bumped script version to pick up SDK change for patch packages #!rb none #!tests none #!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3635097 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added cleardevices option to Gauntlet that removes all devices after running. Added to Orion build scripts #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634985 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Cleaned up some logging around device failures Attempt to handle "Too Many Connections" error at a lower level Added removeall command to PS4DevkitUtil (not yet used) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634897 on 2017/09/09 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Checking in change to timeouts to test theory #!tests ran test locally #!rb none #!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634765 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Scrape another .05ms out of GPU particle simulation. #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634422 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for Gauntlet shutdown issue on builders Fix for BP editing crash from Dev-Framework #!tests ran locally #!rb none! #!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3634139 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running #!tests ran locally with single and file-based devices #!rb none #!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633799 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only. #!rb none #!tests monolith02 turrets [CODEREVIEW] lina.halper #!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633647 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Possible fix for OR-43926 from Arne #!tests ran locally, observed no ensures or negative side-effects in UI or HUD #!rb none #!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3633637 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Upped timeout for editorbased tests #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632565 on 2017/09/08 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed some test code... #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632385 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device handling. Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems. #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632177 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: thomas.ross Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43 #!rb none #!test local commandlet #!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632131 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix a bug with new local vector-field only project setting #!rb none #!tests ps4 monolith #!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3632034 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed issue where problem devices were reset each attempt #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631812 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant More improvements to device management in Gauntlet #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631787 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: laurent.delayen Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes. #!rb none [CODEREVIEW] martin.wilson #!test bot game #!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3631251 on 2017/09/07 by Andrew.Grant Additional device selection improvements #!tests #!rb na Change 3630861 on 2017/09/07 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3630620 on 2017/09/07 by Laurent.Delayen RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions. #!rb Ori.Cohen #!codereview benn.gallagher #!tests lane minions test map Change 3629990 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: daniel.lamb Fix for gpu hang on ps4. #!rb Marcus.Wassmer #!test Paragon cooked ps4 #!jira OR-43835 #!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629980 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Moved some missed code to FDebug::HasAsserted() #!tests na #!rb none #!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629975 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Project optimization to only support local vector fields. separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost. #!rb olaf.piesche #!tests monolith ps4/pc #!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629917 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: marcus.wassmer Fix for sizebyspeed on ps4 #!rb Simon.Tovey #!tests pc #!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629620 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629554 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Restored screenshot support to gauntlet (now driven externally) #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629495 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: don.eubanks Stat panel will only show stat changes or improvements that come from Item sources (cards / gems) #!rb dan.hertzka #!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE [RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base! #!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629468 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring() Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread. #!tests ran locally #!rb none [at marcus.wassmer] #!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629410 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs -------------------------------------- Fix for generating project files #!tests GPF #!rb none #!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629369 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests) #!rb none #!tests verified signing is disabled and game gets to main menu with -fileopenlog [at graeme.thornton] #!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3629254 on 2017/09/06 by Laurent.Delayen URO: ensure we don't skip more frames than desired when switching LODs. #!rb lina.halper #!codereview martin.wilson, benn.gallagher #!test lane minions test map Change 3629191 on 2017/09/06 by Laurent.Delayen Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions. #!rb lina.halper #!codereview martin.wilson #!test lane minions test map Change 3629130 on 2017/09/06 by Laurent.Delayen AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug. #!rb none #!tests lane minion test map Change 3628300 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed exception that could occur during tests if all devices were in use #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627915 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Undoing Oodle check for the time being #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627875 on 2017/09/06 by Jason.Bestimt #!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables) #!RB:none #!Tests:none #!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker #!ROBOMERGE: MAIN, 43 Change 3627694 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Improved warnings #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627642 on 2017/09/06 by robomerge #!ROBOMERGE-AUTHOR: david.ratti More logging for OR-43892 and OR-43779 #!rb none #!tests compile #!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627247 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Removed check that turns out to be bogus #!tests #!rb none #!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627240 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures #!tests compiled OrionClient [at daniel.lamb] #!rb none #!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3627211 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added ensure for OR-43777 #!tests compiled #!rb none #!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626839 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Added wait to PS4DevkitUtil before trying to postmortem crashdump #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626755 on 2017/09/05 by Rob.Cannaday Merge //Orion/Release-Tencent to //Orion/Dev-General Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded #!rb sam.zamani #!lockdown andrew.grant #!tests Win64 vs AI match, QA smoke test #!fyi sam.zamani Change 3626285 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fixed BaseDir argument not being correctly applied in tests Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3626221 on 2017/09/05 by robomerge #!ROBOMERGE-AUTHOR: david.ratti Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame. Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement #!rb none #!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz [at Laurent.Delayen] [FYI] [at Andrew.Grant] #!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3625925 on 2017/09/05 by Laurent.Delayen If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want. #!rb benn.gallagher #!codereview martin.wilson, lina.halper #!tests lane minion map Change 3624051 on 2017/09/02 by Andrew.Grant Fixed issue with test params not being set. Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability. #!tests preflighted #!rb none #!review-3624052 @ben.salem Change 3623907 on 2017/09/02 by Andrew.Grant Fixed usesyncedbuild option being broken in Gauntlet #!codereview @daniel.lamb #!tests compiled #!rb none Change 3623906 on 2017/09/02 by David.Ratti Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides #!rb none #!test future wukong pie Change 3623766 on 2017/09/01 by Daniel.Wright [Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box #!rb none #!Tests PC QAGame Change 3623518 on 2017/09/01 by Don.Eubanks Fix for Shipping Client PS4 #!rb none #!tests Compile Shipping Client PS4 #!fyi daniel.lamb andrew.grant Change 3623515 on 2017/09/01 by Daniel.Wright [Copy] Volume materials applied to static meshes operate on the object's bounding sphere #!rb none #!TESTS QAGame PC Change 3623503 on 2017/09/01 by Daniel.Wright [Copy] Fixed ObjectRadius in Volume domain materials #!rb none #!TESTS none Change 3623102 on 2017/09/01 by Marcus.Wassmer Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand #!rb none #!tests monolith on PS4 #!fyi olaf.piesche,tim.elek Change 3623096 on 2017/09/01 by Marcus.Wassmer checkslow -> check to find issues with ILC #!rb none #!tests ran monolith on ps4 Change 3622744 on 2017/09/01 by Laurent.Delayen RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now). Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies. Take gravity from movement component if present, to inherit custom gravity scaling. Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used. If LOD enables new bodies, they are now initialized during simulation. Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default. Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change. Added AnimStats for PreUpdate, Update and Eval. #!rb ori.cohen #!codereview ori.cohen, lina.halper, benn.ghallager #!tests lane minion test map Change 3622743 on 2017/09/01 by Laurent.Delayen Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes. #!rb lina.halper #!tests lane minion test map Change 3622742 on 2017/09/01 by Laurent.Delayen 'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings. Renamed DisplayDebugCustom to DisplayDebugInstance. #!rb lina.halper #!tests lane minion test map Change 3622738 on 2017/09/01 by Laurent.Delayen Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams #!rb lina.halper #!tests lane minion test map Change 3622666 on 2017/09/01 by Jian.Ru Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements #!jira UE-48972, OR-43455 #!rb Chris.Bunner #!tests editor Change 3622579 on 2017/09/01 by Andrew.Grant Fixed shutdown issues with some tests being detected as errors Simplied and cleanup some things in state management of tests. #!tests ShortSOloGame test locally #!rb none Change 3622322 on 2017/09/01 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-40366 from v43 #!tests compiled #!rb Aaron.McLeran #!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3621054 on 2017/08/31 by Andrew.Grant Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating #!tests preflighted #!rb none Change 3620755 on 2017/08/31 by Daniel.Lamb Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations. #!rb Jason.Bestimt #!test Cooked paragon ps4 Change 3620541 on 2017/08/31 by Ben.Salem Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting. #!rb none #!tests compiled. Change 3620443 on 2017/08/31 by Mieszko.Zielinski Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4 #!rb none #!test golden path Change 3620428 on 2017/08/31 by Aaron.McLeran #!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General #!rb Ethan.Geller #!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports. Change 3620411 on 2017/08/31 by Mieszko.Zielinski Fix to removal of simuli sources from the AISense_Sight #!UE4 Made sure given source gets removed from ObservedTargets. #!rb none #!test golden path Change 3620343 on 2017/08/31 by Ben.Salem Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on. #!rb clayton.langford #!tests ran shallow and normal FX tests, generated hitches to display. Change 3620050 on 2017/08/31 by Luke.Thatcher [ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/... - USE_DEFRAG_ALLOCATOR was not always defined in all cases. #!rb Daniel.Lamb #!tests none Change 3619836 on 2017/08/31 by Andrew.Grant Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team) #!tests preflighted, ran locally #!rb none Change 3618597 on 2017/08/30 by Dan.Hertzka Fixed Additive UI materials not being affected by the widget opacity - We needed to multiply the sampled color by the alpha of the vertex color Also added fade in anim for scoreboard when showing after the endgame cinematic #!rb Nick.Darnell #!tests Widget alpha affects additive materials Change 3618441 on 2017/08/30 by Laurent.Delayen Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display. #!rb lina.halper #!tests lane minions Change 3618404 on 2017/08/30 by Paul.Moore - Update to new MMS client API from Fortnite. - Add MMS API plugin. #!rb none #!tests matchmaking, v2 MMS matchmaking, draft lobby. #!lockdown andrew.grant Change 3618167 on 2017/08/30 by Marcus.Wassmer Fix fog on PS4, also volume texture clears. #!rb luke.thatcher #!fyi Jordan.Walker #!tests ran monolith on ps4 Change 3617911 on 2017/08/30 by Andrew.Grant Fix for OR-43401, lighting remaining unbuilt #!tests ran cook, verified that lighting for bp components is now correctly found. #!rb marc.audy Change 3617765 on 2017/08/30 by Andrew.Grant Fix for lighting always being unbuilt on some blueprints #!tests cooked data and verified BP components have the correct transform and receive cached lighting data #!rb marc.audy, bp-team Change 3617757 on 2017/08/30 by Laurent.Delayen clang fix #!rb none #!tests none Change 3617700 on 2017/08/30 by Laurent.Delayen Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated. #!rb lina.halper #!tests lane minions map Change 3617695 on 2017/08/30 by Laurent.Delayen Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays. #!rb lina.halper #!tests test lane minions map Change 3616757 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Fix for OR-43459 from Laurent #!tests na #!rb Lina.Halper, Andrew.Grant #!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616745 on 2017/08/29 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Locked net version to 3609966 in anticipation of patch #!rb #!tests na #!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3616551 on 2017/08/29 by Daniel.Lamb Fix memory leak in paragon. #!rb Andrew.Grant #!test Paragon ps4 Change 3613700 on 2017/08/28 by Andrew.Grant Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion Renabled r.Cache.UpdatePrimsTaskEnabled #!tests ran locally #!rb none Change 3613694 on 2017/08/28 by Andrew.Grant Added -teamsize argument to Orion none test. #!tests ran None test :) #!rb none Change 3613638 on 2017/08/28 by Ben.Salem Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created. #!rb clayton.langford #!tests Ran shallow and deep test for multiple characters. Change 3612731 on 2017/08/28 by Chris.Bunner [DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook. #!rb #!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb #!tests Cooking/running simple scene with grass foliage #!jira UE-48698, OR-42612 Change 3612695 on 2017/08/28 by Andrew.Grant Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things. #!tests ran NoneTest with -nomcp #!rb none Change 3612002 on 2017/08/27 by Andrew.Grant Fix for crash seen during nightly tests #!tests baseline perf didn't crast 3/3 #!rb none Change 3611980 on 2017/08/27 by Andrew.Grant PS4DevkitUtil post-mortem improvements to logging #!tests run ShortSoloGame #!rb none Change 3611758 on 2017/08/26 by Andrew.Grant Fix for warning #!tests #!rb na Change 3611737 on 2017/08/26 by Andrew.Grant Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering 3517039 - GitHub #!2655: Optimization for shadow map resolution selection for spot lights * Use the radius of the inscribed sphere at the cone end as the spot light's screen radius Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly 3545241 - Fixed spotlight whole scene shadows using a radius 2x too long 3545347 - Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame. #!rb none #!tests compiled Change 3611718 on 2017/08/26 by andrew.grant #!CodeReview: andrew.grant, jason.bestimt, jeff.williams Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs -------------------------------------- Improved parsing of callstacks and errors in test logs Added unit test for error parsing #!tests ran locally, unit tests #!rb none #!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611704 on 2017/08/26 by robomerge #!ROBOMERGE-AUTHOR: andrew.grant Test fixes - addresses issue with memory report failing #!tests ran locally #!rb none #!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3611683 on 2017/08/26 by Andrew.Grant Upgraded PS4 SDK to 4.508.111 #!tests SoloGames locally #!rb none Change 3611466 on 2017/08/25 by Andrew.Grant Changed none test to use monolith02 by default #!tests compiled #!rb none Change 3611167 on 2017/08/25 by Laurent.Delayen Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated. #!rb none #!tests lane minions #!codereview martin.wilson Change 3610850 on 2017/08/25 by dan.hertzka Unclog Robomerge #!rb none #!tests none Change 3610325 on 2017/08/25 by Andrew.Grant Compile fix for PS4 #!tests compiled #!rb none Change 3610018 on 2017/08/25 by Laurent.Delayen UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later. #!rb lina.halper #!tests venus ult on minion lane test map Change 3609967 on 2017/08/25 by Daniel.Lamb Merging using //Fortnite/Main/->//Orion/Dev-General/ Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4. CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping. - The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out. - Added an extra flag to reset mip bias values when texture memory budget is increased. #!rb Uriel.Doyon #!jira FORT-45385 #!jira FORT-47739 CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4. - Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled. - Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted. - Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps. #!jira FORT-45229 #!rb Ben.Woodhouse CL 3564368 LLM Changes Summary: LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead. Changes where LLM hooks into the various allocation functions and pools. Added more LLM tracking scopes. Changed the way LLM gets its internal memory. Writing stats out to csv Fixed a few bugs with the tracker code Details: * re-enabled LLM by default in Dev builds for XB1 and PS4 * Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update) * track allocations made from the defrag pool (PS4) * track non-drfrag pool garlic allocations (PS4) * track allocations made from PS4 malloc * combined the RHI and Malloc trackers into the Default tracker * changed stat groups to LLM, LLMPlatform and LLMOverhead * OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set * XMemAlloc now uses AllocationType if no LLM scope has been set * renamed VirtualMap to LLMMap * added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled. * support for tracking allocations that move in memory (for the PS4 defrag allocator) * support for tracking explicit memory without pausing the tracker * LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg * fixed check in FNameToTag. It was checking the wrong value when verifying the name index * show a warning on screen if LLM has been enabled without debug memory enabled (on consoles) * fixed program size tracking * fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope. * optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times) * fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them. * fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled * changed default alloc size for LLMMap to 16K * Added lots more LLM scopes renamed some of the existing ones * made FMemBlock::Allocators private and added accessor functions, which include LLM tracking. * fixed LLM alignment tracking in CustomVirtualAlloc * implemented LLM on XB1 so that it properly tracks D3D12Allocations * added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator * tracking of render targets * fixed LLM pool total column value. #!rb luke.thatcher CL 3565905 [ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/... 3458941 - Initial submission of new PS4 memory allocator. 3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible. 3498440 - Flexible and framebuffer memory fallbacks 3515704 - Add stats to new PS4 memory system. UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly. #!rb Ben.Woodhouse CL 3580934 [FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo. - Neo has 512 MB more direct memory than a base kit. - Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB. #!rb Marcus.Wassmer #!jira FORT-50206 CL 3590180 [FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted. - Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB. - Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool. - Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails. #!jira FORT-49700 #!rb Aaron.McLeran CL 3593920 [FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system. - Incorrect bitmask usage was truncating the available memory value to 32 bits. - Also includes some minor refactoring to make parts more readable. - Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile. #!rb Jonathan.Fitzpatrick #!jira FORT-50918 CL 3597577 [FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU. - Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack. - With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is. #!rb Stewart.Lynch #!jira FORT-50825 #!jira FORT-49688 #!jira FORT-49695 #!jira FORT-50054 CL 3601951 [FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system - Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0. - Added garlic, onion and defrag stats to the platform memory stats struct. - Added fixed pool sizes to platform memory stats. - Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools. #!rb Stewart.Lynch #!jira FORT-52910 #!test preflight with baseline performance memory report tests, local tests on neo #!rb Luke.Thatcher Change 3608480 on 2017/08/24 by Uriel.Doyon Instanced static mesh lightmaps are now updated correctly after lighting scenario changes #!jira UE-48522 #!tests Build lighting, loaded maps #!rb michel.dupuis Change 3608407 on 2017/08/24 by Andrew.Grant Reintegrated ROlando's cloth optimizations #!tests #!rb none Change 3608349 on 2017/08/24 by Rolando.Caloca O - Cloth vertex buffers no longer generate dummy vertices #!rb Lina.Halper #!fyi James.Golding #!tests Check obj list memory with multiple characters, tested animations Change 3607815 on 2017/08/24 by Laurent.Delayen Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha. https://jira.it.epicgames.net/browse/OR-43186 #!rb none #!tests Price hand two bone IK #!codereview lina.halper, thomas.sarkanen Change 3607770 on 2017/08/24 by Andrew.Grant Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong #!tests ran locally, updated parser test #!rb none Change 3607546 on 2017/08/24 by Jian.Ru Add more control to chromatic aberration effect #!jira UE-47138 #!rb Brian.Karis #!tests editor Change 3607270 on 2017/08/24 by Andrew.Grant Mirroring 3605735 from FN to address bug with MIC deduplication #!tests compiled #!rb none Change 3607082 on 2017/08/24 by Laurent.Delayen Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands. List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph). Current debug Target is highlighted in a green bounding box. Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player. Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors. Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation. #!rb dave.ratti #!tests lane minion test map, debugging individual minions #!codereview jon.lietz Change 3606772 on 2017/08/24 by David.Ratti Spot edigrate CL 3606417 for accurate CurveTable memory tracking #!rb none #!tests none [CL 3748735 by Andrew Grant in Main branch]
2017-11-09 18:22:55 -05:00
return GetDisplayNameForClass( Class, &AssetData );
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Deprecating ANY_PACKAGE. This change consists of multiple changes: Core: - Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject) - Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter - Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses - Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names - Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed. - Added static UClass::TryConvertShortNameToPathName utility function - Added static UClass::TryFixShortClassNameExportPath utility function - Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass') - All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath - Added a new startup test that checks for short type names in UClass/FProperty MetaData values AssetRegistry: - Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath - Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names - This also applies to a few other modules' APIs to match AssetRegistry changes Everything else: - Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input) - Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName() - Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names #jira UE-99463 #rb many.people [FYI] Marcus.Wassmer #preflight 629248ec2256738f75de9b32 #codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786 #ROBOMERGE-OWNER: robert.manuszewski #ROBOMERGE-AUTHOR: robert.manuszewski #ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
return FText::FromString(AssetClass.ToString());
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Fixed code relying on SLATE_TEXT_ATTRIBUTE for STextBlock. UETOOL-213 - Minimize Slate FString -> FText conversion (remove SLATE_TEXT_ATTRIBUTE) This fixes any editor/engine specific code that was passing text to Slate as FString rather than FText. [CL 2399803 by Jamie Dale in Main branch]
2015-01-07 09:52:40 -05:00
FText GetAssetDisplayName() const
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
const FAssetData& AssetData = AssetThumbnail->GetAssetData();
if ( AssetData.GetClass() == UClass::StaticClass() )
{
UClass* Class = Cast<UClass>( AssetData.GetAsset() );
return GetDisplayNameForClass( Class );
}
Fixed code relying on SLATE_TEXT_ATTRIBUTE for STextBlock. UETOOL-213 - Minimize Slate FString -> FText conversion (remove SLATE_TEXT_ATTRIBUTE) This fixes any editor/engine specific code that was passing text to Slate as FString rather than FText. [CL 2399803 by Jamie Dale in Main branch]
2015-01-07 09:52:40 -05:00
return FText::FromName(AssetData.AssetName);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
void OnRenderedThumbnailChanged( bool bInHasRenderedThumbnail )
{
bHasRenderedThumbnail = bInHasRenderedThumbnail;
UpdateThumbnailVisibilities();
}
void UpdateThumbnailVisibilities()
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
// Either the generic label or thumbnail should be shown, but not both at once
const EVisibility ClassThumbnailVisibility = GetClassThumbnailVisibility();
if( GenericThumbnailImage.IsValid() )
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
GenericThumbnailImage->SetVisibility( ClassThumbnailVisibility );
}
if( GenericLabelTextBlock.IsValid() )
{
GenericLabelTextBlock->SetVisibility( (ClassThumbnailVisibility == EVisibility::Visible) ? EVisibility::Collapsed : EVisibility::Visible );
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
}
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
const EVisibility ViewportVisibility = GetViewportVisibility();
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
if( RenderedThumbnailWidget.IsValid() )
{
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
RenderedThumbnailWidget->SetVisibility( ViewportVisibility );
if( ClassIconWidget.IsValid() )
{
ClassIconWidget->SetVisibility( ViewportVisibility );
}
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
}
}
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
TOptional<FVector2D> GetGenericThumbnailDesiredSize() const
{
const int32 Size = GenericThumbnailSize.Get();
return FVector2D(Size, Size);
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
private:
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
TSharedPtr<STextBlock> GenericLabelTextBlock;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
TSharedPtr<STextBlock> HintTextBlock;
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
TSharedPtr<SImage> GenericThumbnailImage;
TSharedPtr<SBorder> ClassIconWidget;
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
TSharedPtr<SBorder> RenderedThumbnailWidget;
Copying //UE4/Dev-Enterprise@4705006 to Dev-Main (//UE4/Dev-Main) #rb none #lockdown Nick.Penwarden [CL 4705151 by Francis Hurteau in Main branch]
2019-01-10 17:26:53 -05:00
TSharedPtr<SBorder> AssetBackgroundWidget;
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
TSharedPtr<SBorder> AssetColorStripWidget;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
TSharedPtr<FAssetThumbnail> AssetThumbnail;
FCurveSequence ViewportFadeAnimation;
FCurveHandle ViewportFadeCurve;
FLinearColor AssetColor;
Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main) #rnx [CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
TOptional<FLinearColor> AssetTypeColorOverride;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
float WidthLastFrame;
Refined text rendering on content browser thumbnails and reverted back to full-width sizing method. Tiny text is now using a lighter font with a better hinting algorithm, and is centrally justified. We want to minimise waste of horizontal space, so content browser thumbnails now fill the width of the content browser once again. [CL 2299335 by Andrew Rodham in Main branch]
2014-09-16 07:01:27 -04:00
float GenericThumbnailBorderPadding;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
bool bHasRenderedThumbnail;
FName Style;
TAttribute< FText > HighlightedText;
EThumbnailLabel::Type Label;
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
TAttribute< FLinearColor > HintColorAndOpacity;
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
TAttribute<int32> GenericThumbnailSize;
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
EThumbnailColorStripOrientation ColorStripOrientation;
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
bool bAllowHintText;
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
bool bAllowRealTimeOnHovered;
Performance fixes for content browser thumbnails - Removed several of the border widgets from always being created if they are not used - Added caching of expensive visibility attributes - Cached WrapTextAt values for asset labels to all STextBlock to cache the data - Removed several delegates from asset border colors [CL 2376338 by Matt Kuhlenschmidt in Main branch]
2014-12-04 15:45:23 -05:00
AssetThumbnail - Get the class thumbnail from the ClassIconFinder so that it works with alternate styles. I'm not sure how much this class is actually used in the UI, but it does a lot of redundant work every frame in several different callback methods. If it's used a lot, it should probably get an optimization pass. TTP# 334639 [CL 2220983 by Frank Fella in Main branch]
2014-07-16 13:29:40 -04:00
/** The name of the thumbnail which should be used instead of the class thumbnail. */
FName ClassThumbnailBrushOverride;
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
FName AssetBackgroundBrushName;
FName ClassBackgroundBrushName;
const FSlateBrush* ThumbnailBrush;
const FSlateBrush* ClassIconBrush;
[INTEGRATE] Change 2415497 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 13:33:05 Stopped derived types from UBlueprint being processed as if they were a BP class UE-7184 - Show game c++ classes and engine c++ classes in the content browser Also renamed "ClassAssetClass" to "ThumbnailClass" to better reflect its purpose. [CL 2419545 by Ben Marsh in Main branch]
2015-01-26 19:07:07 -05:00
/** The class to use when finding the thumbnail. */
TWeakObjectPtr<UClass> ThumbnailClass;
[INTEGRATE] Change 2415268 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/22 09:10:34 Improvements to the way thumbnails are shown in the Content Browser UE-7184 - Show game c++ classes and engine c++ classes in the content browser C++ classes and Blueprints now both show you either a live-thumbnail (for asset types), or a class thumbnail for their class type. If showing a live-thumbnail, they also show a mini class icon at the bottom right of the thumbnail. This iconography change has been applied to all asset types, and they now show you their asset type icon on the colored overlay, rather than show you the asset type text. They will still fallback to using the asset type text if there is no icon available for the asset type. [CL 2419540 by Ben Marsh in Main branch]
2015-01-26 19:05:27 -05:00
/** Are we showing a class type? (UClass, UBlueprint) */
bool bIsClassType;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
};
FAssetThumbnail::FAssetThumbnail( UObject* InAsset, uint32 InWidth, uint32 InHeight, const TSharedPtr<class FAssetThumbnailPool>& InThumbnailPool )
A bit more clang fixes. [CL 2084975 by Dmitry Rekman in Main branch]
2014-05-29 17:00:27 -04:00
: ThumbnailPool(InThumbnailPool)
, AssetData(InAsset ? FAssetData(InAsset) : FAssetData())
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
, Width( InWidth )
, Height( InHeight )
{
if ( InThumbnailPool.IsValid() )
{
InThumbnailPool->AddReferencer(*this);
}
}
FAssetThumbnail::FAssetThumbnail( const FAssetData& InAssetData , uint32 InWidth, uint32 InHeight, const TSharedPtr<class FAssetThumbnailPool>& InThumbnailPool )
Fixing Linux Editor build issues, mostly order of initialization. [CL 2119200 by Matthew Griffin in Main branch]
2014-06-27 04:25:06 -04:00
: ThumbnailPool( InThumbnailPool )
, AssetData ( InAssetData )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
, Width( InWidth )
, Height( InHeight )
{
if ( InThumbnailPool.IsValid() )
{
InThumbnailPool->AddReferencer(*this);
}
}
FAssetThumbnail::~FAssetThumbnail()
{
if ( ThumbnailPool.IsValid() )
{
ThumbnailPool.Pin()->RemoveReferencer(*this);
}
}
FIntPoint FAssetThumbnail::GetSize() const
{
return FIntPoint( Width, Height );
}
FSlateShaderResource* FAssetThumbnail::GetViewportRenderTargetTexture() const
{
FSlateTexture2DRHIRef* Texture = NULL;
if ( ThumbnailPool.IsValid() )
{
Texture = ThumbnailPool.Pin()->AccessTexture( AssetData, Width, Height );
}
if( !Texture || !Texture->IsValid() )
{
return NULL;
}
return Texture;
}
UObject* FAssetThumbnail::GetAsset() const
{
if ( AssetData.ObjectPath != NAME_None )
{
return FindObject<UObject>(NULL, *AssetData.ObjectPath.ToString());
}
else
{
return NULL;
}
}
const FAssetData& FAssetThumbnail::GetAssetData() const
{
return AssetData;
}
void FAssetThumbnail::SetAsset( const UObject* InAsset )
{
SetAsset( FAssetData(InAsset) );
}
void FAssetThumbnail::SetAsset( const FAssetData& InAssetData )
{
if ( ThumbnailPool.IsValid() )
{
ThumbnailPool.Pin()->RemoveReferencer(*this);
}
if ( InAssetData.IsValid() )
{
AssetData = InAssetData;
if ( ThumbnailPool.IsValid() )
{
ThumbnailPool.Pin()->AddReferencer(*this);
}
}
else
{
AssetData = FAssetData();
}
AssetDataChangedEvent.Broadcast();
}
[INTEGRATE] Change 2416912 by Jamie.Dale@Pitbull_JDaleReleases on 2015/01/23 11:17:07 Added the ability for asset type actions to provide an extra overlay layer for their asset thumbnails UE-7970 - Add small 'play' button to EditorTutorial asset thumbnail Also cleaned up FAssetThumbnail::MakeThumbnailWidget so that it took a config struct (FAssetThumbnailConfig) rather than 7 or 8 defaulted parameters. [CL 2419655 by Ben Marsh in Main branch]
2015-01-26 19:57:37 -05:00
TSharedRef<SWidget> FAssetThumbnail::MakeThumbnailWidget( const FAssetThumbnailConfig& InConfig )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
return
SNew(SAssetThumbnail)
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
.AssetThumbnail(SharedThis(this))
.ThumbnailPool(ThumbnailPool.Pin())
.AllowFadeIn(InConfig.bAllowFadeIn)
.ForceGenericThumbnail(InConfig.bForceGenericThumbnail)
.Label(InConfig.ThumbnailLabel)
.HighlightedText(InConfig.HighlightedText)
.HintColorAndOpacity(InConfig.HintColorAndOpacity)
.AllowHintText(InConfig.bAllowHintText)
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
.AllowRealTimeOnHovered(InConfig.bAllowRealTimeOnHovered)
Initial pass on content browser reskin [CL 13949190 by Matt Kuhlenschmidt in ue5-main branch]
2020-07-27 16:11:54 -04:00
.ClassThumbnailBrushOverride(InConfig.ClassThumbnailBrushOverride)
.AllowAssetSpecificThumbnailOverlay(InConfig.bAllowAssetSpecificThumbnailOverlay)
.AssetTypeColorOverride(InConfig.AssetTypeColorOverride)
Fix generic thumbnail images for content browser assets not scaling based on user thumbnail size #jira UE-112761 #ROBOMERGE-SOURCE: CL 15918539 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533) [CL 15920961 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 14:56:18 -04:00
.Padding(InConfig.Padding)
Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485 [CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
.GenericThumbnailSize(InConfig.GenericThumbnailSize)
.ColorStripOrientation(InConfig.ColorStripOrientation);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
void FAssetThumbnail::RefreshThumbnail()
{
if ( ThumbnailPool.IsValid() && AssetData.IsValid() )
{
ThumbnailPool.Pin()->RefreshThumbnail( SharedThis(this) );
}
}
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
void FAssetThumbnail::SetRealTime(bool bRealTime)
{
if (ThumbnailPool.IsValid() && AssetData.IsValid())
{
ThumbnailPool.Pin()->SetRealTimeThumbnail( SharedThis(this), bRealTime );
}
}
FAssetThumbnailPool::FAssetThumbnailPool( uint32 InNumInPool, double InMaxFrameTimeAllowance, uint32 InMaxRealTimeThumbnailsPerFrame )
: NumInPool( InNumInPool )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
, MaxRealTimeThumbnailsPerFrame( InMaxRealTimeThumbnailsPerFrame )
Fixing Linux Editor build issues, mostly order of initialization. [CL 2119200 by Matthew Griffin in Main branch]
2014-06-27 04:25:06 -04:00
, MaxFrameTimeAllowance( InMaxFrameTimeAllowance )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Move references to UObjects from FCoreDelegates to FCoreUObjectDelegates TTP #343071 CORE: FCoreDelegates should not have references to UObjects. #codereview Robert.Manuszewski [CL 2317144 by Mikolaj Sieluzycki in Main branch]
2014-10-02 06:13:35 -04:00
FCoreUObjectDelegates::OnObjectPropertyChanged.AddRaw(this, &FAssetThumbnailPool::OnObjectPropertyChanged);
FCoreUObjectDelegates::OnAssetLoaded.AddRaw(this, &FAssetThumbnailPool::OnAssetLoaded);
UE4: World asset thumbnails are now updated when moving actors. [CL 2124066 by Bob Tellez in Main branch]
2014-07-01 19:51:44 -04:00
if ( GEditor )
{
GEditor->OnActorMoved().AddRaw( this, &FAssetThumbnailPool::OnActorPostEditMove );
}
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
// Add the custom thumbnail tag to the list of tags that the asset registry can parse
TSet<FName>& MetaDataTagsForAssetRegistry = UObject::GetMetaDataTagsForAssetRegistry();
MetaDataTagsForAssetRegistry.Add(CustomThumbnailTagName);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
FAssetThumbnailPool::~FAssetThumbnailPool()
{
Move references to UObjects from FCoreDelegates to FCoreUObjectDelegates TTP #343071 CORE: FCoreDelegates should not have references to UObjects. #codereview Robert.Manuszewski [CL 2317144 by Mikolaj Sieluzycki in Main branch]
2014-10-02 06:13:35 -04:00
FCoreUObjectDelegates::OnObjectPropertyChanged.RemoveAll(this);
FCoreUObjectDelegates::OnAssetLoaded.RemoveAll(this);
UE4: World asset thumbnails are now updated when moving actors. [CL 2124066 by Bob Tellez in Main branch]
2014-07-01 19:51:44 -04:00
if ( GEditor )
{
GEditor->OnActorMoved().RemoveAll(this);
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
// Release all the texture resources
ReleaseResources();
}
FAssetThumbnailPool::FThumbnailInfo::~FThumbnailInfo()
{
if( ThumbnailTexture )
{
delete ThumbnailTexture;
ThumbnailTexture = NULL;
}
if( ThumbnailRenderTarget )
{
delete ThumbnailRenderTarget;
ThumbnailRenderTarget = NULL;
}
}
void FAssetThumbnailPool::ReleaseResources()
{
// Clear all pending render requests
ThumbnailsToRenderStack.Empty();
RealTimeThumbnails.Empty();
RealTimeThumbnailsToRender.Empty();
TArray< TSharedRef<FThumbnailInfo> > ThumbnailsToRelease;
for( auto ThumbIt = ThumbnailToTextureMap.CreateConstIterator(); ThumbIt; ++ThumbIt )
{
ThumbnailsToRelease.Add(ThumbIt.Value());
}
ThumbnailToTextureMap.Empty();
for( auto ThumbIt = FreeThumbnails.CreateConstIterator(); ThumbIt; ++ThumbIt )
{
ThumbnailsToRelease.Add(*ThumbIt);
}
FreeThumbnails.Empty();
for ( auto ThumbIt = ThumbnailsToRelease.CreateConstIterator(); ThumbIt; ++ThumbIt )
{
const TSharedRef<FThumbnailInfo>& Thumb = *ThumbIt;
// Release rendering resources
UE4.22 - Replace most of ENQUEUE_UNIQUE_RENDER_COMMAND_ONEPARAMETER #rb none #jira #rnx #ROBOMERGE-SOURCE: CL 5063456 in //UE4/Release-4.22/... #ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main) [CL 5063458 by rolando caloca in Main branch]
2019-02-19 11:47:36 -05:00
FThumbnailInfo_RenderThread ThumbInfo = Thumb.Get();
ENQUEUE_RENDER_COMMAND(ReleaseThumbnailResources)(
[ThumbInfo](FRHICommandListImmediate& RHICmdList)
{
ThumbInfo.ThumbnailTexture->ClearTextureData();
ThumbInfo.ThumbnailTexture->ReleaseResource();
ThumbInfo.ThumbnailRenderTarget->ReleaseResource();
});
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
// Wait for all resources to be released
FlushRenderingCommands();
// Make sure there are no more references to any of our thumbnails now that rendering commands have been flushed
for ( auto ThumbIt = ThumbnailsToRelease.CreateConstIterator(); ThumbIt; ++ThumbIt )
{
const TSharedRef<FThumbnailInfo>& Thumb = *ThumbIt;
if ( !Thumb.IsUnique() )
{
ensureMsgf(0, TEXT("Thumbnail info for '%s' is still referenced by '%d' other objects"), *Thumb->AssetData.ObjectPath.ToString(), Thumb.GetSharedReferenceCount());
}
}
}
---- Merging with SlateDev branch ---- Introduces the concept of "Active Ticking" to allow Slate to go to sleep when there is no need to update the UI. While asleep, Slate will skip the Tick & Paint pass for that frame entirely. - There are TWO ways to "wake" Slate and cause a Tick/Paint pass: 1. Provide some sort of input (mouse movement, clicks, and key presses). Slate will always tick when the user is active. - Therefore, if the logic in a given widget's Tick is only relevant in response to user action, there is no need to register an active tick. 2. Register an Active Tick. Currently this is an all-or-nothing situation, so if a single active tick needs to execute, all of Slate will be ticked. - The purpose of an Active Tick is to allow a widget to "drive" Slate and guarantee a Tick/Paint pass in the absence of any user action. - Examples include animation, async operations that update periodically, progress updates, loading bars, etc. - An empty active tick is registered for viewports when they are real-time, so game project widgets are unaffected by this change and should continue to work as before. - An Active Tick is registered by creating an FWidgetActiveTickDelegate and passing it to SWidget::RegisterActiveTick() - There are THREE ways to unregister an active tick: 1. Return EActiveTickReturnType::StopTicking from the active tick function 2. Pass the FActiveTickHandle returned by RegisterActiveTick() to SWidget::UnregisterActiveTick() 3. Destroy the widget responsible for the active tick - Sleeping is currently disabled, can be enabled with Slate.AllowSlateToSleep cvar - There is currently a little buffer time during which Slate continues to tick following any input. Long-term, this is planned to be removed. - The duration of the buffer can be adjusted using Slate.SleepBufferPostInput cvar (defaults to 1.0f) - The FCurveSequence API has been updated to work with the active tick system - Playing a curve sequence now requires that you pass the widget being animated by the sequence - The active tick will automatically be registered on behalf of the widget and unregister when the sequence is complete - GetLerpLooping() has been removed. Instead, pass true as the second param to Play() to indicate that the animation will loop. This causes the active tick to be registered indefinitely until paused or jumped to the start/end. [CL 2391669 by Dan Hertzka in Main branch]
2014-12-17 16:07:57 -05:00
TStatId FAssetThumbnailPool::GetStatId() const
{
RETURN_QUICK_DECLARE_CYCLE_STAT( FAssetThumbnailPool, STATGROUP_Tickables );
}
bool FAssetThumbnailPool::IsTickable() const
{
Fix thumbnails not showing up or refreshing properly when shaders are finished compiling - This bug is a combination of CL 14673948 and 14688146 that were tested separately #rb Matt.Kuhlenschmidt #robomerge Release-5.0-EarlyAccess [CL 15851219 by danny couture in ue5-main branch]
2021-03-29 10:59:19 -04:00
return RecentlyLoadedAssets.Num() > 0 || ThumbnailsToRenderStack.Num() > 0 || RealTimeThumbnails.Num() > 0 || bWereShadersCompilingLastFrame || (GShaderCompilingManager && GShaderCompilingManager->IsCompiling());
---- Merging with SlateDev branch ---- Introduces the concept of "Active Ticking" to allow Slate to go to sleep when there is no need to update the UI. While asleep, Slate will skip the Tick & Paint pass for that frame entirely. - There are TWO ways to "wake" Slate and cause a Tick/Paint pass: 1. Provide some sort of input (mouse movement, clicks, and key presses). Slate will always tick when the user is active. - Therefore, if the logic in a given widget's Tick is only relevant in response to user action, there is no need to register an active tick. 2. Register an Active Tick. Currently this is an all-or-nothing situation, so if a single active tick needs to execute, all of Slate will be ticked. - The purpose of an Active Tick is to allow a widget to "drive" Slate and guarantee a Tick/Paint pass in the absence of any user action. - Examples include animation, async operations that update periodically, progress updates, loading bars, etc. - An empty active tick is registered for viewports when they are real-time, so game project widgets are unaffected by this change and should continue to work as before. - An Active Tick is registered by creating an FWidgetActiveTickDelegate and passing it to SWidget::RegisterActiveTick() - There are THREE ways to unregister an active tick: 1. Return EActiveTickReturnType::StopTicking from the active tick function 2. Pass the FActiveTickHandle returned by RegisterActiveTick() to SWidget::UnregisterActiveTick() 3. Destroy the widget responsible for the active tick - Sleeping is currently disabled, can be enabled with Slate.AllowSlateToSleep cvar - There is currently a little buffer time during which Slate continues to tick following any input. Long-term, this is planned to be removed. - The duration of the buffer can be adjusted using Slate.SleepBufferPostInput cvar (defaults to 1.0f) - The FCurveSequence API has been updated to work with the active tick system - Playing a curve sequence now requires that you pass the widget being animated by the sequence - The active tick will automatically be registered on behalf of the widget and unregister when the sequence is complete - GetLerpLooping() has been removed. Instead, pass true as the second param to Play() to indicate that the animation will loop. This causes the active tick to be registered indefinitely until paused or jumped to the start/end. [CL 2391669 by Dan Hertzka in Main branch]
2014-12-17 16:07:57 -05:00
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
void FAssetThumbnailPool::Tick( float DeltaTime )
{
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
// If throttling do not tick unless drag dropping which could have a thumbnail as the cursor decorator
Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166 #rb #rnx [CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
if (FSlateApplication::IsInitialized() && !FSlateApplication::Get().IsDragDropping() && !FSlateThrottleManager::Get().IsAllowingExpensiveTasks() && !FSlateApplication::Get().AnyMenusVisible())
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
{
return;
}
Fix thumbnails not showing up or refreshing properly when shaders are finished compiling - This bug is a combination of CL 14673948 and 14688146 that were tested separately #rb Matt.Kuhlenschmidt #robomerge Release-5.0-EarlyAccess [CL 15851219 by danny couture in ue5-main branch]
2021-03-29 10:59:19 -04:00
const bool bAreShadersCompiling = (GShaderCompilingManager && GShaderCompilingManager->IsCompiling());
if (bWereShadersCompilingLastFrame && !bAreShadersCompiling)
{
ThumbnailsToRenderStack.Reset();
// Reschedule visible thumbnails to be rerendered now that shaders are finished compiling
for (auto ThumbIt = ThumbnailToTextureMap.CreateIterator(); ThumbIt; ++ThumbIt)
{
ThumbnailsToRenderStack.Push(ThumbIt.Value());
}
}
bWereShadersCompilingLastFrame = bAreShadersCompiling;
Async Static Mesh Compilation / Loading - Add protection against async property accessed during async build and postload. - Split PostLoad into 3 steps with the most part now being made async. - Make Build/BatchBuild API async when the feature is activated. - Add a new StaticMesh compilation manager. (This will be refactory later to reduce duplicated code with texture compiler). - Skip RenderState creation for any static mesh component still being built so they only show up when ready. - Fixed DistanceField and MeshCard computation that might trigger too soon if fixups are required to RenderData during PostLoad. - Dynamic priorisation for building and updating static meshes nearest to the viewport. - Implement different PIE modes, current default is to stall only for mesh that might affect nagivation/collision for players/bots. - Add a new generic interface for assets being built (still a WIP). - Add ability in FrontEnd filters to skip serialization of asset being async compiled and refresh when compilation finishes. - Prevent auto-save while textures and static meshes are being built (same as shaders) - Logic has been reordered in some Fortnite Building Component to avoid unnecessarily touching static mesh properties. General Optimizations - Use cached thumbnails until shaders/textures/static meshes are ready to improve performance and avoid rendering incomplete thumbnails. DEBUGGING - Can be forcibly enabled/disabled through command-line via -asyncstaticmeshcompilation=[off, on, paused] - Can pause staticmesh compilation using Editor.AsyncStaticMeshCompilation = 2 or -asyncstaticmeshcompilation=paused - Can manually resume a specified amount of paused compilation using Editor.AsyncStaticMeshCompilationResume [Num] - Can forcibly wait on all compilation using Editor.AsyncStaticMeshCompilationFlushAll BENCHMARKS - 2m19s to 17.9s for Loading FortGPUTestbed's LumenTest with an empty local only DDC - 2h45m to 5mxxs for Loading Reverb's P_World with an empty local only DDC - 17m29 to 10m27s for Loading Apollo_Terrain_Edit with an empty local only DDC TESTS - Loading maps from Reverb, Fortnite, ShooterGame, QAGame, FortGPUTestbed - Content browser interactions while still under heavy compilation - Importing with Datasmith / Dataprep - Working with the new Mesh Modeling Tool - Shutting down the editor while loading - Most of EngineTest Test Suite REFERENCES - Design https://docs.google.com/document/d/1O4GI1G9AtQN6l0SaGFfXw0DyNhlLunLoEqne5INvxIQ - Documentation https://docs.google.com/document/d/1KCdFEMhhcsGwfgOisTVwlOwtsmEd7qbB0V6Tc39Gb10 #rb Francis.Hurteau [CL 14688146 by danny couture in ue5-main branch]
2020-11-09 07:50:34 -04:00
TRACE_CPUPROFILER_EVENT_SCOPE(FAssetThumbnailPool::Tick);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
// If there were any assets loaded since last frame that we are currently displaying thumbnails for, push them on the render stack now.
if ( RecentlyLoadedAssets.Num() > 0 )
{
for ( int32 LoadedAssetIdx = 0; LoadedAssetIdx < RecentlyLoadedAssets.Num(); ++LoadedAssetIdx )
{
RefreshThumbnailsFor(RecentlyLoadedAssets[LoadedAssetIdx]);
}
RecentlyLoadedAssets.Empty();
}
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
// If we have dynamic thumbnails and we are done rendering the last batch of dynamic thumbnails, start a new batch as long as real-time thumbnails are enabled
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
const bool bIsInPIEOrSimulate = GEditor->PlayWorld != NULL || GEditor->bIsSimulatingInEditor;
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
const bool bShouldUseRealtimeThumbnails = GetDefault<UContentBrowserSettings>()->RealTimeThumbnails && !bIsInPIEOrSimulate;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
if ( bShouldUseRealtimeThumbnails && RealTimeThumbnails.Num() > 0 && RealTimeThumbnailsToRender.Num() == 0 )
{
double CurrentTime = FPlatformTime::Seconds();
for ( int32 ThumbIdx = RealTimeThumbnails.Num() - 1; ThumbIdx >= 0; --ThumbIdx )
{
const TSharedRef<FThumbnailInfo>& Thumb = RealTimeThumbnails[ThumbIdx];
if ( Thumb->AssetData.IsAssetLoaded() )
{
// Only render thumbnails that have been requested recently
if ( (CurrentTime - Thumb->LastAccessTime) < 1.f )
{
RealTimeThumbnailsToRender.Add(Thumb);
}
}
else
{
RealTimeThumbnails.RemoveAt(ThumbIdx);
}
}
}
uint32 NumRealTimeThumbnailsRenderedThisFrame = 0;
// If there are any thumbnails to render, pop one off the stack and render it.
if( ThumbnailsToRenderStack.Num() + RealTimeThumbnailsToRender.Num() > 0 )
{
double FrameStartTime = FPlatformTime::Seconds();
// Render as many thumbnails as we are allowed to
while( ThumbnailsToRenderStack.Num() + RealTimeThumbnailsToRender.Num() > 0 && FPlatformTime::Seconds() - FrameStartTime < MaxFrameTimeAllowance )
{
TSharedPtr<FThumbnailInfo> Info;
if ( ThumbnailsToRenderStack.Num() > 0 )
{
Info = ThumbnailsToRenderStack.Pop();
}
Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main) @ 4395008 #rb #rnx #lockdown Nick.Penwarden [CL 4395058 by Marc Audy in Main branch]
2018-09-25 10:11:35 -04:00
else if (RealTimeThumbnailsToRender.Num() > 0 && NumRealTimeThumbnailsRenderedThisFrame < MaxRealTimeThumbnailsPerFrame )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Info = RealTimeThumbnailsToRender.Pop();
NumRealTimeThumbnailsRenderedThisFrame++;
}
else
{
// No thumbnails left to render or we don't want to render any more
break;
}
if( Info.IsValid() )
{
Fix thumbnails not showing up or refreshing properly when shaders are finished compiling - This bug is a combination of CL 14673948 and 14688146 that were tested separately #rb Matt.Kuhlenschmidt #robomerge Release-5.0-EarlyAccess [CL 15851219 by danny couture in ue5-main branch]
2021-03-29 10:59:19 -04:00
bool bIsAssetStillCompiling = false;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
TSharedRef<FThumbnailInfo> InfoRef = Info.ToSharedRef();
if ( InfoRef->AssetData.IsValid() )
{
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
FAssetData CustomThumbnailAsset;
// Check if a different asset should be used to generate the thumbnail for this asset
FString CustomThumbnailTagValue;
if (InfoRef->AssetData.GetTagValue(CustomThumbnailTagName, CustomThumbnailTagValue))
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
if (FPackageName::IsValidObjectPath(CustomThumbnailTagValue))
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
CustomThumbnailAsset = FModuleManager::LoadModuleChecked<FAssetRegistryModule>(AssetRegistryConstants::ModuleName).Get().GetAssetByObjectPath(*CustomThumbnailTagValue);
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
Fix thumbnails not showing up or refreshing properly when shaders are finished compiling - This bug is a combination of CL 14673948 and 14688146 that were tested separately #rb Matt.Kuhlenschmidt #robomerge Release-5.0-EarlyAccess [CL 15851219 by danny couture in ue5-main branch]
2021-03-29 10:59:19 -04:00
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
bool bLoadedThumbnail = LoadThumbnail(InfoRef, bIsAssetStillCompiling, CustomThumbnailAsset);
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
// If we failed to load a custom thumbnail, then load the custom thumbnail's asset and try again
if (!bLoadedThumbnail && CustomThumbnailAsset.IsValid())
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
// Only load the custom thumbnail if the original asset is also loaded
//if (InfoRef->AssetData.IsAssetLoaded())
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Fixing crash in AssetThumbnail.cpp due to unchecked pointer to an unloaded asset. [REVIEW] [at]josh.andersen, [at]Aaron.eady, [at]Robert.Manuszewski #ROBOMERGE-AUTHOR: mic.rooney #ROBOMERGE-SOURCE: CL 20441202 via CL 20441261 via CL 20441384 via CL 20441412 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246) [CL 20449482 by mic rooney in ue5-main branch]
2022-06-01 04:23:35 -04:00
if (UObject* CustomThumbnail = CustomThumbnailAsset.GetAsset())
{
bLoadedThumbnail = LoadThumbnail(InfoRef, bIsAssetStillCompiling, CustomThumbnailAsset);
CustomThumbnail->ClearFlags(RF_Standalone);
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
}
if ( bLoadedThumbnail )
{
Fix for thumbnail rendering producing black or incorrect thumbnails #codereview Bob.Tellez [CL 2222597 by Martin Wilson in Main branch]
2014-07-17 16:05:37 -04:00
// Mark it as updated
InfoRef->LastUpdateTime = FPlatformTime::Seconds();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
// Notify listeners that a thumbnail has been rendered
ThumbnailRenderedEvent.Broadcast(InfoRef->AssetData);
}
Fix thumbnails not showing up or refreshing properly when shaders are finished compiling - This bug is a combination of CL 14673948 and 14688146 that were tested separately #rb Matt.Kuhlenschmidt #robomerge Release-5.0-EarlyAccess [CL 15851219 by danny couture in ue5-main branch]
2021-03-29 10:59:19 -04:00
// Do not send a failure event for this asset yet if shaders are still compiling or the asset itself is compiling.
// The failure event will disable the rendering of this asset for good and we need to have a chance to
// rerender it when everything settles down.
else if (!bAreShadersCompiling && !bIsAssetStillCompiling)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
Fix thumbnails not showing up or refreshing properly when shaders are finished compiling - This bug is a combination of CL 14673948 and 14688146 that were tested separately #rb Matt.Kuhlenschmidt #robomerge Release-5.0-EarlyAccess [CL 15851219 by danny couture in ue5-main branch]
2021-03-29 10:59:19 -04:00
// Notify listeners that a thumbnail render has failed
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
ThumbnailRenderFailedEvent.Broadcast(InfoRef->AssetData);
}
}
}
}
}
}
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
bool FAssetThumbnailPool::LoadThumbnail(TSharedRef<FThumbnailInfo> ThumbnailInfo, bool &bIsAssetStillCompiling, const FAssetData& CustomAssetToRender)
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
{
const FAssetData& AssetData = CustomAssetToRender.IsValid() ? CustomAssetToRender : ThumbnailInfo->AssetData;
UObject* Asset = AssetData.IsAssetLoaded() ? AssetData.GetAsset() : nullptr;
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
const bool bAreShadersCompiling = (GShaderCompilingManager && GShaderCompilingManager->IsCompiling());
if (Asset && !bAreShadersCompiling)
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
{
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
//Avoid rendering the thumbnail of an asset that is currently edited asynchronously
const IInterface_AsyncCompilation* Interface_AsyncCompilation = Cast<IInterface_AsyncCompilation>(Asset);
bIsAssetStillCompiling = Interface_AsyncCompilation && Interface_AsyncCompilation->IsCompiling();
if (!bIsAssetStillCompiling)
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
{
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
FThumbnailRenderingInfo* RenderInfo = GUnrealEd->GetThumbnailManager()->GetRenderingInfo(Asset);
if (RenderInfo != nullptr && RenderInfo->Renderer != nullptr)
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
{
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
FThumbnailInfo_RenderThread ThumbInfo = ThumbnailInfo.Get();
ENQUEUE_RENDER_COMMAND(SyncSlateTextureCommand)(
[ThumbInfo](FRHICommandListImmediate& RHICmdList)
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
{
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
if (ThumbInfo.ThumbnailTexture->GetTypedResource() != ThumbInfo.ThumbnailRenderTarget->GetTextureRHI())
{
ThumbInfo.ThumbnailTexture->ClearTextureData();
ThumbInfo.ThumbnailTexture->ReleaseDynamicRHI();
ThumbInfo.ThumbnailTexture->SetRHIRef(ThumbInfo.ThumbnailRenderTarget->GetTextureRHI(), ThumbInfo.Width, ThumbInfo.Height);
}
});
if (ThumbnailInfo->LastUpdateTime <= 0.0f || RenderInfo->Renderer->AllowsRealtimeThumbnails(Asset))
{
//@todo: this should be done on the GPU only but it is not supported by thumbnail tools yet
ThumbnailTools::RenderThumbnail(
Asset,
ThumbnailInfo->Width,
ThumbnailInfo->Height,
ThumbnailTools::EThumbnailTextureFlushMode::NeverFlush,
ThumbnailInfo->ThumbnailRenderTarget
);
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
}
Fix bad merge that remove the async validation before rendering a thumbnail. #jira none #rb danny.couture #preflight 60bfa53ab68c7000016a39dd #ROBOMERGE-SOURCE: CL 16591330 in //UE5/Main/... #ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559) [CL 16591336 by alexis matte in ue5-release-engine-test branch]
2021-06-08 15:33:09 -04:00
return true;
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
}
}
}
FThumbnailMap ThumbnailMap;
// If we could not render a fresh thumbnail, see if we already have a cached one to load
const FObjectThumbnail* FoundThumbnail = ThumbnailTools::FindCachedThumbnail(AssetData.GetFullName());
if (!FoundThumbnail)
{
// If we don't have a cached thumbnail, try to find it on disk
FString PackageFilename;
Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971 [CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
if (FPackageName::DoesPackageExist(AssetData.PackageName.ToString(), &PackageFilename))
Merge UE5/RES @ 16162155 to UE5/Main This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156 [CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
{
TSet<FName> ObjectFullNames;
FName ObjectFullName = FName(*AssetData.GetFullName());
ObjectFullNames.Add(ObjectFullName);
ThumbnailTools::LoadThumbnailsFromPackage(PackageFilename, ObjectFullNames, ThumbnailMap);
FoundThumbnail = ThumbnailMap.Find(ObjectFullName);
}
}
if (FoundThumbnail)
{
if (FoundThumbnail->GetImageWidth() > 0 && FoundThumbnail->GetImageHeight() > 0 && FoundThumbnail->GetUncompressedImageData().Num() > 0)
{
// Make bulk data for updating the texture memory later
FSlateTextureData* BulkData = new FSlateTextureData(FoundThumbnail->GetImageWidth(), FoundThumbnail->GetImageHeight(), GPixelFormats[PF_B8G8R8A8].BlockBytes, FoundThumbnail->AccessImageData());
// Update the texture RHI
FThumbnailInfo_RenderThread ThumbInfo = ThumbnailInfo.Get();
ENQUEUE_RENDER_COMMAND(ClearSlateTextureCommand)(
[ThumbInfo, BulkData](FRHICommandListImmediate& RHICmdList)
{
if (ThumbInfo.ThumbnailTexture->GetTypedResource() == ThumbInfo.ThumbnailRenderTarget->GetTextureRHI())
{
ThumbInfo.ThumbnailTexture->SetRHIRef(NULL, ThumbInfo.Width, ThumbInfo.Height);
}
ThumbInfo.ThumbnailTexture->SetTextureData(MakeShareable(BulkData));
ThumbInfo.ThumbnailTexture->UpdateRHI();
});
return true;
}
}
return false;
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
FSlateTexture2DRHIRef* FAssetThumbnailPool::AccessTexture( const FAssetData& AssetData, uint32 Width, uint32 Height )
{
if(AssetData.ObjectPath == NAME_None || Width == 0 || Height == 0)
{
return NULL;
}
else
{
FThumbId ThumbId( AssetData.ObjectPath, Width, Height ) ;
// Check to see if a thumbnail for this asset exists. If so we don't need to render it
const TSharedRef<FThumbnailInfo>* ThumbnailInfoPtr = ThumbnailToTextureMap.Find( ThumbId );
TSharedPtr<FThumbnailInfo> ThumbnailInfo;
if( ThumbnailInfoPtr )
{
ThumbnailInfo = *ThumbnailInfoPtr;
}
else
{
// If a the max number of thumbnails allowed by the pool exists then reuse its rendering resource for the new thumbnail
if( FreeThumbnails.Num() == 0 && ThumbnailToTextureMap.Num() == NumInPool )
{
Fix for thumbnail rendering producing black or incorrect thumbnails #codereview Bob.Tellez [CL 2222597 by Martin Wilson in Main branch]
2014-07-17 16:05:37 -04:00
// Find the thumbnail which was accessed last and use it for the new thumbnail
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
float LastAccessTime = FLT_MAX;
const FThumbId* AssetToRemove = NULL;
for( TMap< FThumbId, TSharedRef<FThumbnailInfo> >::TConstIterator It(ThumbnailToTextureMap); It; ++It )
{
if( It.Value()->LastAccessTime < LastAccessTime )
{
LastAccessTime = It.Value()->LastAccessTime;
AssetToRemove = &It.Key();
}
}
check( AssetToRemove );
// Remove the old mapping
ThumbnailInfo = ThumbnailToTextureMap.FindAndRemoveChecked( *AssetToRemove );
}
else if( FreeThumbnails.Num() > 0 )
{
ThumbnailInfo = FreeThumbnails.Pop();
Unshelved from pending changelist '4932645': #CodeReview: rolando.caloca,ben.marsh,cristina.riveron,nick.bullard,nick.penwarden Merge conflict. rolando.caloca, please merge this change by hand. More info at https://robomerge.epicgames.net#RELEASE /src/ROBOMERGE_RELEASE_Main/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraEmitterInstanceBatcher.cpp - merging //UE4/Release-4.22/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraEmitterInstanceBatcher.cpp#2 -------------------------------------- UE4.22 - Deprecate ENQUEUE_UNIQUE_RENDER_COMMAND_THREEPARAMETER #rb none #jira #ROBOMERGE-SOURCE: CL 4932643 in //UE4/Release-4.22/... #ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main) [CL 4932685 by Rolando Caloca in Main branch]
2019-02-07 10:35:08 -05:00
FSlateTextureRenderTarget2DResource* ThumbnailRenderTarget = ThumbnailInfo->ThumbnailRenderTarget;
ENQUEUE_RENDER_COMMAND(SlateUpdateThumbSizeCommand)(
[ThumbnailRenderTarget, Width, Height](FRHICommandListImmediate& RHICmdList)
{
ThumbnailRenderTarget->SetSize(Width, Height);
});
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
else
{
// There are no free thumbnail resources
check( (uint32)ThumbnailToTextureMap.Num() <= NumInPool );
check( !ThumbnailInfo.IsValid() );
// The pool isn't used up so just make a new texture
// Make new thumbnail info if it doesn't exist
// This happens when the pool is not yet full
ThumbnailInfo = MakeShareable( new FThumbnailInfo );
// Set the thumbnail and asset on the info. It is NOT safe to change or NULL these pointers until ReleaseResources.
ThumbnailInfo->ThumbnailTexture = new FSlateTexture2DRHIRef( Width, Height, PF_B8G8R8A8, NULL, TexCreate_Dynamic );
ThumbnailInfo->ThumbnailRenderTarget = new FSlateTextureRenderTarget2DResource(FLinearColor::Black, Width, Height, PF_B8G8R8A8, SF_Point, TA_Wrap, TA_Wrap, 0.0f);
BeginInitResource( ThumbnailInfo->ThumbnailTexture );
BeginInitResource( ThumbnailInfo->ThumbnailRenderTarget );
}
check( ThumbnailInfo.IsValid() );
TSharedRef<FThumbnailInfo> ThumbnailRef = ThumbnailInfo.ToSharedRef();
// Map the object to its thumbnail info
ThumbnailToTextureMap.Add( ThumbId, ThumbnailRef );
ThumbnailInfo->AssetData = AssetData;
ThumbnailInfo->Width = Width;
ThumbnailInfo->Height = Height;
Fix for thumbnail rendering producing black or incorrect thumbnails #codereview Bob.Tellez [CL 2222597 by Martin Wilson in Main branch]
2014-07-17 16:05:37 -04:00
// Mark this thumbnail as needing to be updated
ThumbnailInfo->LastUpdateTime = -1.f;
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
// Request that the thumbnail be rendered as soon as possible
ThumbnailsToRenderStack.Push( ThumbnailRef );
}
// This thumbnail was accessed, update its last time to the current time
// We'll use LastAccessTime to determine the order to recycle thumbnails if the pool is full
ThumbnailInfo->LastAccessTime = FPlatformTime::Seconds();
return ThumbnailInfo->ThumbnailTexture;
}
}
void FAssetThumbnailPool::AddReferencer( const FAssetThumbnail& AssetThumbnail )
{
FIntPoint Size = AssetThumbnail.GetSize();
if ( AssetThumbnail.GetAssetData().ObjectPath == NAME_None || Size.X == 0 || Size.Y == 0 )
{
// Invalid referencer
return;
}
// Generate a key and look up the number of references in the RefCountMap
FThumbId ThumbId( AssetThumbnail.GetAssetData().ObjectPath, Size.X, Size.Y ) ;
int32* RefCountPtr = RefCountMap.Find(ThumbId);
if ( RefCountPtr )
{
// Already in the map, increment a reference
(*RefCountPtr)++;
}
else
{
// New referencer, add it to the map with a RefCount of 1
RefCountMap.Add(ThumbId, 1);
}
}
void FAssetThumbnailPool::RemoveReferencer( const FAssetThumbnail& AssetThumbnail )
{
FIntPoint Size = AssetThumbnail.GetSize();
const FName ObjectPath = AssetThumbnail.GetAssetData().ObjectPath;
if ( ObjectPath == NAME_None || Size.X == 0 || Size.Y == 0 )
{
// Invalid referencer
return;
}
// Generate a key and look up the number of references in the RefCountMap
FThumbId ThumbId( ObjectPath, Size.X, Size.Y ) ;
int32* RefCountPtr = RefCountMap.Find(ThumbId);
// This should complement an AddReferencer so this entry should be in the map
if ( RefCountPtr )
{
// Decrement the RefCount
(*RefCountPtr)--;
// If we reached zero, free the thumbnail and remove it from the map.
if ( (*RefCountPtr) <= 0 )
{
RefCountMap.Remove(ThumbId);
FreeThumbnail(ObjectPath, Size.X, Size.Y);
}
}
else
{
// This FAssetThumbnail did not reference anything or was deleted after the pool was deleted.
}
}
bool FAssetThumbnailPool::IsInRenderStack( const TSharedPtr<FAssetThumbnail>& Thumbnail ) const
{
const FAssetData& AssetData = Thumbnail->GetAssetData();
const uint32 Width = Thumbnail->GetSize().X;
const uint32 Height = Thumbnail->GetSize().Y;
if ( ensure(AssetData.ObjectPath != NAME_None) && ensure(Width > 0) && ensure(Height > 0) )
{
FThumbId ThumbId( AssetData.ObjectPath, Width, Height ) ;
const TSharedRef<FThumbnailInfo>* ThumbnailInfoPtr = ThumbnailToTextureMap.Find( ThumbId );
if ( ThumbnailInfoPtr )
{
return ThumbnailsToRenderStack.Contains(*ThumbnailInfoPtr);
}
}
return false;
}
Fix for thumbnail rendering producing black or incorrect thumbnails #codereview Bob.Tellez [CL 2222597 by Martin Wilson in Main branch]
2014-07-17 16:05:37 -04:00
bool FAssetThumbnailPool::IsRendered(const TSharedPtr<FAssetThumbnail>& Thumbnail) const
{
const FAssetData& AssetData = Thumbnail->GetAssetData();
const uint32 Width = Thumbnail->GetSize().X;
const uint32 Height = Thumbnail->GetSize().Y;
if (ensure(AssetData.ObjectPath != NAME_None) && ensure(Width > 0) && ensure(Height > 0))
{
FThumbId ThumbId(AssetData.ObjectPath, Width, Height);
const TSharedRef<FThumbnailInfo>* ThumbnailInfoPtr = ThumbnailToTextureMap.Find(ThumbId);
if (ThumbnailInfoPtr)
{
return (*ThumbnailInfoPtr).Get().LastUpdateTime >= 0.f;
}
}
return false;
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
void FAssetThumbnailPool::PrioritizeThumbnails( const TArray< TSharedPtr<FAssetThumbnail> >& ThumbnailsToPrioritize, uint32 Width, uint32 Height )
{
if ( ensure(Width > 0) && ensure(Height > 0) )
{
TSet<FName> ObjectPathList;
for ( int32 ThumbIdx = 0; ThumbIdx < ThumbnailsToPrioritize.Num(); ++ThumbIdx )
{
ObjectPathList.Add(ThumbnailsToPrioritize[ThumbIdx]->GetAssetData().ObjectPath);
}
TArray< TSharedRef<FThumbnailInfo> > FoundThumbnails;
for ( int32 ThumbIdx = ThumbnailsToRenderStack.Num() - 1; ThumbIdx >= 0; --ThumbIdx )
{
const TSharedRef<FThumbnailInfo>& ThumbnailInfo = ThumbnailsToRenderStack[ThumbIdx];
if ( ThumbnailInfo->Width == Width && ThumbnailInfo->Height == Height && ObjectPathList.Contains(ThumbnailInfo->AssetData.ObjectPath) )
{
FoundThumbnails.Add(ThumbnailInfo);
ThumbnailsToRenderStack.RemoveAt(ThumbIdx);
}
}
for ( int32 ThumbIdx = 0; ThumbIdx < FoundThumbnails.Num(); ++ThumbIdx )
{
ThumbnailsToRenderStack.Push(FoundThumbnails[ThumbIdx]);
}
}
}
void FAssetThumbnailPool::RefreshThumbnail( const TSharedPtr<FAssetThumbnail>& ThumbnailToRefresh )
{
const FAssetData& AssetData = ThumbnailToRefresh->GetAssetData();
const uint32 Width = ThumbnailToRefresh->GetSize().X;
const uint32 Height = ThumbnailToRefresh->GetSize().Y;
Change to using ensure() for verifying thumbnail dimensions. I misunderstood the difference when I changed these to ensureAlways a while back. #rb trivial #ROBOMERGE-SOURCE: CL 15571667 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668) [CL 15571676 by geoff evans in ue5-main branch]
2021-03-02 14:24:52 -04:00
if ( ensure(AssetData.ObjectPath != NAME_None) && ensure(Width > 0) && ensure(Height > 0) )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
FThumbId ThumbId( AssetData.ObjectPath, Width, Height ) ;
const TSharedRef<FThumbnailInfo>* ThumbnailInfoPtr = ThumbnailToTextureMap.Find( ThumbId );
if ( ThumbnailInfoPtr )
{
ThumbnailsToRenderStack.AddUnique(*ThumbnailInfoPtr);
}
}
}
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
void FAssetThumbnailPool::SetRealTimeThumbnail( const TSharedPtr<FAssetThumbnail>& Thumbnail, bool bRealTimeThumbnail )
{
const FAssetData& AssetData = Thumbnail->GetAssetData();
const uint32 Width = Thumbnail->GetSize().X;
const uint32 Height = Thumbnail->GetSize().Y;
Change to using ensure() for verifying thumbnail dimensions. I misunderstood the difference when I changed these to ensureAlways a while back. #rb trivial #ROBOMERGE-SOURCE: CL 15571667 in //UE5/Release-5.0-EarlyAccess/... #ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668) [CL 15571676 by geoff evans in ue5-main branch]
2021-03-02 14:24:52 -04:00
if (ensure(AssetData.ObjectPath != NAME_None) && ensure(Width > 0) && ensure(Height > 0) )
Redefine Content Browser's "RealTime Thumbnails" to be only the item the cursor is hovering over instead of every thumbnail in an SAssetView. This change removes the use of boolean attribute AreRealTimeThumbnailsAllowed. This attribute is less than ideal, design-wise, since it uses the thumbnail pool to drive the behavior of the thumbnails. Instead we build in default hover behavior to the thumbnail slate widgets, and implement plumbing for custom pathways to enable/disable real time behavior per thumbnail. -> Add default OnMouseEnter/OnMouseLeave events on SAssetThumbnail for default hover behavior (over the actual thumbnail image), which supports detail panel, customizations, and things like FoliageEditor and Niagara Stack Overview thumbnail strip. -> Add thumbnail initialize pathway support for disabling default hover behavior for use cases where the logical asset is more than just the thumbnail image (border elements, text elements with the asset name, etc). -> Add custom OnMouseEnter/OnMouseLeave handlers on SAssetTileItem, SAssetListItem to perform real time behavior on entire logical asset item in Content Browser and Asset Picker. #rb francis.hurteau #fyi matt.kuhlenschmidt #jira UETOOL-2363 [CL 14673948 by geoff evans in ue5-main branch]
2020-11-05 21:41:33 -04:00
{
FThumbId ThumbId( AssetData.ObjectPath, Width, Height );
const TSharedRef<FThumbnailInfo>* ThumbnailInfoPtr = ThumbnailToTextureMap.Find( ThumbId );
if ( ThumbnailInfoPtr )
{
if ( bRealTimeThumbnail )
{
RealTimeThumbnails.AddUnique(*ThumbnailInfoPtr);
}
else
{
RealTimeThumbnails.Remove(*ThumbnailInfoPtr);
}
}
}
}
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
void FAssetThumbnailPool::FreeThumbnail( const FName& ObjectPath, uint32 Width, uint32 Height )
{
if(ObjectPath != NAME_None && Width != 0 && Height != 0)
{
FThumbId ThumbId( ObjectPath, Width, Height ) ;
const TSharedRef<FThumbnailInfo>* ThumbnailInfoPtr = ThumbnailToTextureMap.Find(ThumbId);
if( ThumbnailInfoPtr )
{
TSharedRef<FThumbnailInfo> ThumbnailInfo = *ThumbnailInfoPtr;
ThumbnailToTextureMap.Remove(ThumbId);
ThumbnailsToRenderStack.Remove(ThumbnailInfo);
RealTimeThumbnails.Remove(ThumbnailInfo);
RealTimeThumbnailsToRender.Remove(ThumbnailInfo);
UE4.22 - Replace most of ENQUEUE_UNIQUE_RENDER_COMMAND_ONEPARAMETER #rb none #jira #rnx #ROBOMERGE-SOURCE: CL 5063456 in //UE4/Release-4.22/... #ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main) [CL 5063458 by rolando caloca in Main branch]
2019-02-19 11:47:36 -05:00
FSlateTexture2DRHIRef* ThumbnailTexture = ThumbnailInfo->ThumbnailTexture;
ENQUEUE_RENDER_COMMAND(ReleaseThumbnailTextureData)(
[ThumbnailTexture](FRHICommandListImmediate& RHICmdList)
{
ThumbnailTexture->ClearTextureData();
});
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
FreeThumbnails.Add( ThumbnailInfo );
}
}
}
void FAssetThumbnailPool::RefreshThumbnailsFor( FName ObjectPath )
{
for ( auto ThumbIt = ThumbnailToTextureMap.CreateIterator(); ThumbIt; ++ThumbIt)
{
if ( ThumbIt.Key().ObjectPath == ObjectPath )
{
ThumbnailsToRenderStack.Push( ThumbIt.Value() );
}
}
}
void FAssetThumbnailPool::OnAssetLoaded( UObject* Asset )
{
if ( Asset != NULL )
{
RecentlyLoadedAssets.Add( FName(*Asset->GetPathName()) );
}
}
UE4: World asset thumbnails are now updated when moving actors. [CL 2124066 by Bob Tellez in Main branch]
2014-07-01 19:51:44 -04:00
void FAssetThumbnailPool::OnActorPostEditMove( AActor* Actor )
{
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
DirtyThumbnailForObject(Actor);
UE4: World asset thumbnails are now updated when moving actors. [CL 2124066 by Bob Tellez in Main branch]
2014-07-01 19:51:44 -04:00
}
Core: Change FCoreDelegates::OnObjectPropertyChanged to take the property change event as an additional parameter [CL 2066450 by Michael Noland in Main branch]
2014-05-07 22:17:44 -04:00
void FAssetThumbnailPool::OnObjectPropertyChanged( UObject* ObjectBeingModified, FPropertyChangedEvent& PropertyChangedEvent )
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
DirtyThumbnailForObject(ObjectBeingModified);
}
void FAssetThumbnailPool::DirtyThumbnailForObject(UObject* ObjectBeingModified)
{
if (!ObjectBeingModified)
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
{
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
return;
}
if (ObjectBeingModified->HasAnyFlags(RF_ClassDefaultObject))
{
Fixed warning "DoesPackageExist called on PackageName that will always return false" in PIE #jira UE-145653 #rb patrick.enfedaque, jeanfrancois.dube #preflight 622f1ffb0a342dea04dee251 #lockdown simon.tourangeau #ROBOMERGE-AUTHOR: sebastien.lussier #ROBOMERGE-SOURCE: CL 19371966 in //UE5/Release-5.0/... via CL 19372335 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884) [CL 19374620 by sebastien lussier in ue5-main branch]
2022-03-14 13:23:31 -04:00
if (ObjectBeingModified->GetClass()->ClassGeneratedBy != nullptr)
UE4: Added a thumbnail renderer for world assets. This is slightly different than the level thumbnail renderer in that it needs more features for arbitrary levels and renders streaming levels in the same world as well. [CL 2124053 by Bob Tellez in Main branch]
2014-07-01 19:16:36 -04:00
{
// This is a blueprint modification. Check to see if this thumbnail is the blueprint of the modified CDO
ObjectBeingModified = ObjectBeingModified->GetClass()->ClassGeneratedBy;
}
}
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
else if (AActor* ActorBeingModified = Cast<AActor>(ObjectBeingModified))
UE4: Added a thumbnail renderer for world assets. This is slightly different than the level thumbnail renderer in that it needs more features for arbitrary levels and renders streaming levels in the same world as well. [CL 2124053 by Bob Tellez in Main branch]
2014-07-01 19:16:36 -04:00
{
// This is a non CDO actor getting modified. Update the actor's world's thumbnail.
ObjectBeingModified = ActorBeingModified->GetWorld();
Engine source (Main branch up to CL 2026164)
2014-03-14 14:13:41 -04:00
}
Fix thumbnail refresh for generated textures (non-asset). #rb trivial #rnx #jira none #ROBOMERGE-AUTHOR: lonnie.li #ROBOMERGE-SOURCE: CL 17804120 in //UE5/Release-5.0/... via CL 17805307 #ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v881-17767770) #ROBOMERGE[STARSHIP]: UE5-Main [CL 17805378 by lonnie li in ue5-release-engine-test branch]
2021-10-13 16:30:43 -04:00
if (ObjectBeingModified)
UE4: Added a thumbnail renderer for world assets. This is slightly different than the level thumbnail renderer in that it needs more features for arbitrary levels and renders streaming levels in the same world as well. [CL 2124053 by Bob Tellez in Main branch]
2014-07-01 19:16:36 -04:00
{
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
// An object in memory was modified. We'll mark it's thumbnail as dirty so that it'll be
// regenerated on demand later. (Before being displayed in the browser, or package saves, etc.)
FObjectThumbnail* Thumbnail = ThumbnailTools::GetThumbnailForObject(ObjectBeingModified);
Fixed warning "DoesPackageExist called on PackageName that will always return false" in PIE #jira UE-145653 #rb patrick.enfedaque, jeanfrancois.dube #preflight 622f1ffb0a342dea04dee251 #lockdown simon.tourangeau #ROBOMERGE-AUTHOR: sebastien.lussier #ROBOMERGE-SOURCE: CL 19371966 in //UE5/Release-5.0/... via CL 19372335 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884) [CL 19374620 by sebastien lussier in ue5-main branch]
2022-03-14 13:23:31 -04:00
// If we don't yet have a thumbnail map, load one from disk if possible
if (Thumbnail == nullptr)
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
{
Fixed warning "DoesPackageExist called on PackageName that will always return false" in PIE #jira UE-145653 #rb patrick.enfedaque, jeanfrancois.dube #preflight 622f1ffb0a342dea04dee251 #lockdown simon.tourangeau #ROBOMERGE-AUTHOR: sebastien.lussier #ROBOMERGE-SOURCE: CL 19371966 in //UE5/Release-5.0/... via CL 19372335 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884) [CL 19374620 by sebastien lussier in ue5-main branch]
2022-03-14 13:23:31 -04:00
UPackage* ObjectPackage = ObjectBeingModified->GetOutermost();
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
Fixed warning "DoesPackageExist called on PackageName that will always return false" in PIE #jira UE-145653 #rb patrick.enfedaque, jeanfrancois.dube #preflight 622f1ffb0a342dea04dee251 #lockdown simon.tourangeau #ROBOMERGE-AUTHOR: sebastien.lussier #ROBOMERGE-SOURCE: CL 19371966 in //UE5/Release-5.0/... via CL 19372335 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884) [CL 19374620 by sebastien lussier in ue5-main branch]
2022-03-14 13:23:31 -04:00
const bool bMemoryPackage = FPackageName::IsMemoryPackage(ObjectBeingModified->GetPathName()); // Don't try to load from disk if the package is a memory package
const bool bUnsavedPackage = ObjectPackage->HasAnyPackageFlags(PKG_NewlyCreated); // Don't try loading thumbnails for package that have never been saved
const bool bIsGarbageCollecting = IsGarbageCollecting(); // Don't attempt to do this while garbage collecting since loading or finding objects during GC is illegal
const bool bTryLoadThumbnailFromDisk = !bIsGarbageCollecting && !bMemoryPackage && !bUnsavedPackage;
if (bTryLoadThumbnailFromDisk)
{
FName ObjectFullName = FName(*ObjectBeingModified->GetFullName());
FThumbnailMap LoadedThumbnails;
if (ThumbnailTools::ConditionallyLoadThumbnailsForObjects({ ObjectFullName }, LoadedThumbnails))
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
{
Fixed warning "DoesPackageExist called on PackageName that will always return false" in PIE #jira UE-145653 #rb patrick.enfedaque, jeanfrancois.dube #preflight 622f1ffb0a342dea04dee251 #lockdown simon.tourangeau #ROBOMERGE-AUTHOR: sebastien.lussier #ROBOMERGE-SOURCE: CL 19371966 in //UE5/Release-5.0/... via CL 19372335 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884) [CL 19374620 by sebastien lussier in ue5-main branch]
2022-03-14 13:23:31 -04:00
Thumbnail = LoadedThumbnails.Find(ObjectFullName);
if (Thumbnail != nullptr)
{
Thumbnail = ThumbnailTools::CacheThumbnail(ObjectBeingModified->GetFullName(), Thumbnail, ObjectPackage);
}
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
}
}
}
Fixed warning "DoesPackageExist called on PackageName that will always return false" in PIE #jira UE-145653 #rb patrick.enfedaque, jeanfrancois.dube #preflight 622f1ffb0a342dea04dee251 #lockdown simon.tourangeau #ROBOMERGE-AUTHOR: sebastien.lussier #ROBOMERGE-SOURCE: CL 19371966 in //UE5/Release-5.0/... via CL 19372335 #ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884) [CL 19374620 by sebastien lussier in ue5-main branch]
2022-03-14 13:23:31 -04:00
if (Thumbnail != nullptr)
[AUTOMERGE] #UE4 Moved asset thumbnail dirtying code out of ContentBrowserSingleton and into AssetThumbnail.cpp. Updating thumbnails is not the responsibility of the Content Browser since many systems use thumbnails now. -------- Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2226322 by Bob.Tellez on 2014/07/21 21:37:47. [CL 2227552 by Bob Tellez in Main branch]
2014-07-22 16:59:10 -04:00
{
// Mark the thumbnail as dirty
Thumbnail->MarkAsDirty();
}
UE4: Added a thumbnail renderer for world assets. This is slightly different than the level thumbnail renderer in that it needs more features for arbitrary levels and renders streaming levels in the same world as well. [CL 2124053 by Bob Tellez in Main branch]
2014-07-01 19:16:36 -04:00
RefreshThumbnailsFor( FName(*ObjectBeingModified->GetPathName()) );
}
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
}
Reference in New Issue Copy Permalink