Files
UnrealEngineUWP/Engine/Source/Editor/PhysicsAssetEditor/Private/PhysicsAssetEditorEditMode.cpp

1036 lines
37 KiB
C++
Raw Normal View History

// Copyright Epic Games, Inc. All Rights Reserved.
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
#include "PhysicsAssetEditorEditMode.h"
#include "PhysicsAssetEditorSkeletalMeshComponent.h"
#include "CanvasItem.h"
#include "CanvasTypes.h"
#include "AssetEditorModeManager.h"
#include "EngineUtils.h"
#include "PhysicsAssetEditorSharedData.h"
#include "PhysicsEngine/PhysicsAsset.h"
#include "PhysicsEngine/PhysicsConstraintTemplate.h"
#include "PhysicsEngine/PhysicsSettings.h"
#include "Preferences/PhysicsAssetEditorOptions.h"
#include "IPersonaPreviewScene.h"
#include "PhysicsAssetEditor.h"
#include "PhysicsAssetEditorHitProxies.h"
#include "PhysicsAssetEditorPhysicsHandleComponent.h"
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
#include "DrawDebugHelpers.h"
#include "SEditorViewport.h"
#include "IPersonaToolkit.h"
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3847469) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3805828 by Gil.Gribb UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works. Change 3806784 by Ben.Marsh UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT. Change 3807549 by Graeme.Thornton Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it. Change 3807727 by Graeme.Thornton Unhide the text asset format experimental editor option Change 3807746 by Josh.Engebretson Remove WER from iOS platform Change 3807928 by Robert.Manuszewski When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet Change 3808221 by Steve.Robb GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule() ^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway. Change 3809233 by Graeme.Thornton TBA: Misc changes to text asset commandlet - Rename mode to "loadsave" - Add -outputFormat option which can be assigned "text" or "binary" - When saving binary, use a differentiated filename so that source assets aren't overwritten Change 3809518 by Ben.Marsh Remove the outdated UnrealSync automation script. Change 3809643 by Steve.Robb GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value #jira UE-53037 Change 3809862 by Steve.Robb GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately #jira UE-42593 Change 3811190 by Graeme.Thornton Add support for writing specific log channels to their own files Change 3811197 by Graeme.Thornton Minor updates to output formatting and timing for the text asset commandlet Change 3811257 by Robert.Manuszewski Cluster creation will now be time-sliced Change 3811565 by Steve.Robb Define out non-monolithic module functions. Change 3812561 by Steve.Robb GitHub #3886 : Enable Brace-Initialization for Declaring Variables Incorrect semi-colon search removed after discussion with author. Test added. #jira UE-48242 Change 3812864 by Steve.Robb Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins. See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html #jira UE-53089 Change 3820358 by Ben.Marsh PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist) Change 3822594 by Ben.Marsh UAT: Improvements to log file handling. - Always create log files in the final location, rather than writing to a temp directory and copying in later. - Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX. - Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is. - Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location. Change 3823695 by Ben.Marsh UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk). Now always queries changes up to the last change for which zipped binaries are available. Change 3823845 by Ben.Marsh UBT: Exclude C# projects for unsupported platforms when generating project files. Change 3824180 by Ben.Marsh UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes). #jira Change 3825777 by Steve.Robb Fix to return value of StringToBytes. Change 3825810 by Ben.Marsh UBT: Reduce length of include paths for MSVC toolchain. Change 3825822 by Robert.Manuszewski Optimized PIE lazy pointer fixup. Should be up to 8x faster now. Change 3826734 by Ben.Marsh Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency. Change 3827730 by Steve.Robb Try to avoid decltype(auto) if it's not supported. See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html Change 3827745 by Steve.Robb Initializer list support for TMap. Change 3827770 by Steve.Robb GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType() #jira UE-53813 Change 3829189 by Ben.Marsh UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off. Change 3830444 by Steve.Robb BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library. This should be revisited when Core has its own JSON library. Change 3830718 by Ben.Marsh Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups. The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip. For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it. When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk. #jira UE-53845 Change 3831064 by Ben.Marsh Fix log file contention when spawning UBT recursively. Change 3832654 by Ben.Marsh UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it. Change 3832680 by Ben.Marsh UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade. Change 3832695 by Ben.Marsh UGS: Invert the options in the 'Show Changes' submenu for simplicity. Change 3833528 by Ben.Marsh UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write]. Change 3833543 by Ben.Marsh UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules. Change 3834354 by Robert.Manuszewski Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks. #jira UE-52035 Change 3834400 by Robert.Manuszewski Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup. #jira UE-52035 Change 3834947 by Steve.Robb USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal. Change 3835004 by Ben.Marsh Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL. Change 3835340 by Ben.Marsh Fix errors making installed build from directories with spaces in the name. Change 3835972 by Ben.Marsh UBT: Improved diagnostic message for targets which don't need a version file. Change 3836019 by Ben.Marsh UBT: Fix warnings caused by defining linkage macros for third party libraries. Change 3836269 by Ben.Marsh Fix message box larger than the screen height being created when a large number of modules are incompatible on startup. Change 3836543 by Ben.Marsh Enable SoundMod plugin on Linux, since it's already supported through the editor. Change 3836546 by Ben.Marsh PR #4412: fix type mismatch (Contributed by nakapon) Change 3836805 by Ben.Marsh Fix commandlet to compile marketplace plugins. Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3837036 by Ben.Marsh UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds. Change 3837037 by Ben.Marsh UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro). Change 3837040 by Ben.Marsh UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed. Change 3837247 by Ben.Marsh UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files). Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor. Change 3837262 by Ben.Marsh UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module. Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets. Change 3837343 by Ben.Marsh UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead. Change 3837356 by Ben.Marsh Fix invalid character encodings. Change 3837727 by Graeme.Thornton UnrealPak: KeyGenerator: Only generate prime table when required, not all the time Change 3837823 by Ben.Marsh UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window. Change 3837831 by Graeme.Thornton UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives Change 3837857 by Robert.Manuszewski PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch) Change 3837943 by Robert.Manuszewski PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch) Change 3838451 by Ben.Marsh UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread. #jira UE-53996 Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 3843790 by Graeme.Thornton UnrealPak: Log the size of all encrypted data Change 3844258 by Ben.Marsh Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace. Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure. #jira UE-54157 Change 3845796 by Ben.Marsh Workaround for slow performance of String.EndsWith() on Mono. Change 3845823 by Ben.Marsh Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun. #jira UE-54123 Change 3845901 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). (Edigrating 3819174 to Dev-Core) Change 3846439 by Ben.Marsh Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates. Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main. Change 3816608 by Ben.Marsh UBT: Use DirectoryReference objects for all include paths. Change 3816954 by Ben.Marsh UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere. Change 3816986 by Ben.Marsh UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly. Change 3816991 by Ben.Marsh UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules. Change 3823090 by Ben.Marsh UAT: Improve logging for child UAT instances. - Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder. - Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway. - Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read. - Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output. Change 3826082 by Ben.Marsh UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target. Change 3827025 by Ben.Marsh UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling. Change 3829927 by James.Hopkin Made HTTP interface const correct Change 3833533 by Ben.Marsh Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules. Change 3835826 by Ben.Marsh UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced. Change 3835969 by Ben.Marsh UBT: Fix cases where text is being written directly to the console rather than via logging functions. Change 3837777 by Steve.Robb Format string type checking added to FOutputDevice::Logf. Fixes for those. Change 3838569 by Steve.Robb Algo moved up a folder. [CL 3847482 by Ben Marsh in Main branch]
2018-01-20 11:19:29 -05:00
#include "Framework/MultiBox/MultiBoxBuilder.h"
#include "Framework/Application/SlateApplication.h"
#include "Engine/Font.h"
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
#define LOCTEXT_NAMESPACE "PhysicsAssetEditorEditMode"
FName FPhysicsAssetEditorEditMode::ModeName("PhysicsAssetEditor");
FPhysicsAssetEditorEditMode::FPhysicsAssetEditorEditMode()
: MinPrimSize(0.5f)
, PhysicsAssetEditor_TranslateSpeed(0.25f)
, PhysicsAssetEditor_RotateSpeed(1.0f * (PI / 180.0f))
, PhysicsAssetEditor_LightRotSpeed(0.22f)
, SimHoldDistanceChangeDelta(20.0f)
, SimMinHoldDistance(10.0f)
, SimGrabMoveSpeed(1.0f)
{
// Disable grid drawing for this mode as the viewport handles this
bDrawGrid = false;
PhysicsAssetEditorFont = GEngine->GetSmallFont();
check(PhysicsAssetEditorFont);
}
bool FPhysicsAssetEditorEditMode::GetCameraTarget(FSphere& OutTarget) const
{
bool bHandled = false;
float NumSelected = 0.0f;
FBox Bounds(ForceInit);
for (int32 BodyIndex = 0; BodyIndex < SharedData->SelectedBodies.Num(); ++BodyIndex)
{
FPhysicsAssetEditorSharedData::FSelection& SelectedObject = SharedData->SelectedBodies[BodyIndex];
int32 BoneIndex = SharedData->EditorSkelComp->GetBoneIndex(SharedData->PhysicsAsset->SkeletalBodySetups[SelectedObject.Index]->BoneName);
UBodySetup* BodySetup = SharedData->PhysicsAsset->SkeletalBodySetups[SelectedObject.Index];
const FKAggregateGeom& AggGeom = BodySetup->AggGeom;
FTransform BoneTM = SharedData->EditorSkelComp->GetBoneTransform(BoneIndex);
const float Scale = BoneTM.GetScale3D().GetAbsMax();
BoneTM.RemoveScaling();
if (SelectedObject.PrimitiveType == EAggCollisionShape::Sphere)
{
Bounds += AggGeom.SphereElems[SelectedObject.PrimitiveIndex].CalcAABB(BoneTM, Scale);
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::Box)
{
Bounds += AggGeom.BoxElems[SelectedObject.PrimitiveIndex].CalcAABB(BoneTM, Scale);
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::Sphyl)
{
Bounds += AggGeom.SphylElems[SelectedObject.PrimitiveIndex].CalcAABB(BoneTM, Scale);
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::Convex)
{
Bounds += AggGeom.ConvexElems[SelectedObject.PrimitiveIndex].CalcAABB(BoneTM, BoneTM.GetScale3D());
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::TaperedCapsule)
{
Bounds += AggGeom.TaperedCapsuleElems[SelectedObject.PrimitiveIndex].CalcAABB(BoneTM, Scale);
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
bHandled = true;
}
for (int32 ConstraintIndex = 0; ConstraintIndex < SharedData->SelectedConstraints.Num(); ++ConstraintIndex)
{
FPhysicsAssetEditorSharedData::FSelection& SelectedObject = SharedData->SelectedConstraints[ConstraintIndex];
Bounds += SharedData->GetConstraintWorldTM(&SelectedObject, EConstraintFrame::Frame2).GetLocation();
bHandled = true;
}
OutTarget.Center = Bounds.GetCenter();
OutTarget.W = Bounds.GetExtent().Size(); // @TODO: calculate correct bounds
return bHandled;
}
IPersonaPreviewScene& FPhysicsAssetEditorEditMode::GetAnimPreviewScene() const
{
return *static_cast<IPersonaPreviewScene*>(static_cast<FAssetEditorModeManager*>(Owner)->GetPreviewScene());
}
void FPhysicsAssetEditorEditMode::GetOnScreenDebugInfo(TArray<FText>& OutDebugInfo) const
{
}
bool FPhysicsAssetEditorEditMode::StartTracking(FEditorViewportClient* InViewportClient, FViewport* InViewport)
{
const EAxisList::Type CurrentAxis = InViewportClient->GetCurrentWidgetAxis();
if(!SharedData->bRunningSimulation && !SharedData->bManipulating && CurrentAxis != EAxisList::None)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
if(SharedData->GetSelectedBody() || SharedData->GetSelectedConstraint())
{
if(SharedData->GetSelectedBody())
{
GEditor->BeginTransaction(NSLOCTEXT("UnrealEd", "MoveElement", "Move Element"));
}
else
{
GEditor->BeginTransaction(NSLOCTEXT("UnrealEd", "MoveConstraint", "Move Constraint"));
}
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
if (SharedData->GetSelectedBody())
{
for (int32 i = 0; i<SharedData->SelectedBodies.Num(); ++i)
{
SharedData->PhysicsAsset->SkeletalBodySetups[SharedData->SelectedBodies[i].Index]->Modify();
SharedData->SelectedBodies[i].ManipulateTM = FTransform::Identity;
}
SharedData->bManipulating = true;
}
if (SharedData->GetSelectedConstraint())
{
const int32 Count = SharedData->SelectedConstraints.Num();
StartManRelConTM.SetNumUninitialized(Count);
StartManParentConTM.SetNumUninitialized(Count);
StartManChildConTM.SetNumUninitialized(Count);
for (int32 i = 0; i < SharedData->SelectedConstraints.Num(); ++i)
{
FPhysicsAssetEditorSharedData::FSelection& Constraint = SharedData->SelectedConstraints[i];
SharedData->PhysicsAsset->ConstraintSetup[Constraint.Index]->Modify();
Constraint.ManipulateTM = FTransform::Identity;
const FTransform WParentFrame = SharedData->GetConstraintWorldTM(&Constraint, EConstraintFrame::Frame2);
const FTransform WChildFrame = SharedData->GetConstraintWorldTM(&Constraint, EConstraintFrame::Frame1);
const UPhysicsConstraintTemplate* Setup = SharedData->PhysicsAsset->ConstraintSetup[Constraint.Index];
StartManRelConTM[i] = WChildFrame * WParentFrame.Inverse();
StartManParentConTM[i] = Setup->DefaultInstance.GetRefFrame(EConstraintFrame::Frame2);
StartManChildConTM[i] = Setup->DefaultInstance.GetRefFrame(EConstraintFrame::Frame1);
}
SharedData->bManipulating = true;
}
}
return SharedData->bManipulating;
}
bool FPhysicsAssetEditorEditMode::EndTracking(FEditorViewportClient* InViewportClient, FViewport* InViewport)
{
if (SharedData->bManipulating)
{
SharedData->bManipulating = false;
for (int32 i = 0; i<SharedData->SelectedBodies.Num(); ++i)
{
FPhysicsAssetEditorSharedData::FSelection & SelectedObject = SharedData->SelectedBodies[i];
UBodySetup* BodySetup = SharedData->PhysicsAsset->SkeletalBodySetups[SelectedObject.Index];
FKAggregateGeom* AggGeom = &BodySetup->AggGeom;
if (SelectedObject.PrimitiveType == EAggCollisionShape::Convex)
{
FKConvexElem& Convex = AggGeom->ConvexElems[SelectedObject.PrimitiveIndex];
Convex.SetTransform(SelectedObject.ManipulateTM * Convex.GetTransform());
BodySetup->InvalidatePhysicsData();
BodySetup->CreatePhysicsMeshes();
}
}
GEditor->EndTransaction();
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
SharedData->RefreshPhysicsAssetChange(SharedData->PhysicsAsset, false);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
InViewport->Invalidate();
return true;
}
return false;
}
bool FPhysicsAssetEditorEditMode::InputKey(FEditorViewportClient* InViewportClient, FViewport* InViewport, FKey Key, EInputEvent Event)
{
int32 HitX = InViewport->GetMouseX();
int32 HitY = InViewport->GetMouseY();
bool bCtrlDown = InViewport->KeyState(EKeys::LeftControl) || InViewport->KeyState(EKeys::RightControl);
bool bShiftDown = InViewport->KeyState(EKeys::LeftShift) || InViewport->KeyState(EKeys::RightShift);
bool bHandled = false;
if (SharedData->bRunningSimulation)
{
if (Key == EKeys::RightMouseButton || Key == EKeys::LeftMouseButton)
{
if (Event == IE_Pressed)
{
bHandled = SimMousePress(InViewportClient, Key);
}
else if (Event == IE_Released)
{
bHandled = SimMouseRelease();
}
else
{
// Handle repeats/double clicks etc. so we dont fall through
bHandled = true;
}
}
else if (Key == EKeys::MouseScrollUp)
{
bHandled = SimMouseWheelUp(InViewportClient);
}
else if (Key == EKeys::MouseScrollDown)
{
bHandled = SimMouseWheelDown(InViewportClient);
}
else if (InViewportClient->IsFlightCameraActive())
{
// If the flight camera is active (user is looking or moving around the scene)
// consume the event so hotkeys don't fire.
bHandled = true;
}
}
if (!bHandled)
{
bHandled = IPersonaEditMode::InputKey(InViewportClient, InViewport, Key, Event);
}
if (bHandled)
{
InViewportClient->Invalidate();
}
return bHandled;
}
bool FPhysicsAssetEditorEditMode::InputAxis(FEditorViewportClient* InViewportClient, FViewport* InViewport, int32 ControllerId, FKey Key, float Delta, float DeltaTime)
{
bool bHandled = false;
// If we are 'manipulating' don't move the camera but do something else with mouse input.
if (SharedData->bManipulating)
{
bool bCtrlDown = InViewport->KeyState(EKeys::LeftControl) || InViewport->KeyState(EKeys::RightControl);
if (SharedData->bRunningSimulation)
{
if (Key == EKeys::MouseX)
{
SimMouseMove(InViewportClient, Delta, 0.0f);
}
else if (Key == EKeys::MouseY)
{
SimMouseMove(InViewportClient, 0.0f, Delta);
}
bHandled = true;
}
}
if (!bHandled)
{
bHandled = IPersonaEditMode::InputAxis(InViewportClient, InViewport, ControllerId, Key, Delta, DeltaTime);
}
InViewportClient->Invalidate();
return bHandled;
}
bool FPhysicsAssetEditorEditMode::InputDelta(FEditorViewportClient* InViewportClient, FViewport* InViewport, FVector& InDrag, FRotator& InRot, FVector& InScale)
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 4062005) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4005617 by Danny.Bouimad Fixing TM-AnimPhys lighting so it works on all platforms #jira UEENGQA-19924 Change 4014898 by Aaron.McLeran Adding simple delay feature Change 4025071 by Lina.Halper Fix and more potential fix for invalid bone index issue http://crashreporter/Buggs/Show/2052839 http://crashreporter/Crashes/Show/46656562 #jira: UE-51931 Change 4042493 by Lina.Halper Fix issue with sequence evaluator to handle properly when jumps from end to front or front to end #jira: UE-58429 Change 4042892 by Lina.Halper Fix issue with being able to drag/drop montage onto anim track in sequencer #jira: UE-57863 Change 4043553 by Ethan.Geller #jira UE-58340 Handle calls to FVoiceCaptureWindows::GetVoiceData outside of existing data calls. #rb none Change 4043613 by Lina.Halper Fix issue with incorrect usage of staticclass #jira: UE-54413 Change 4044069 by James.Golding PR #4455: Add FAnimNode_StateMachine subclassing support. (Contributed by redfeatherplusplus) #jira UE-54599 Change 4044070 by James.Golding PR #4349: Final points on a line test were broken, changed Plane.PlaneDot to FM. (Contributed by DSDambuster) #jira UE-53554 Change 4044072 by James.Golding Add ENGINE_API to UPhysicsHandleComponent so it can be subclassed #jira UE-56397 Change 4044073 by James.Golding PR #4611: Expose a few API's so it's possible to make custom anim graph nodes using these objects. (Contributed by ill) #jira UE-57004 Change 4044075 by James.Golding PR #4618: Bugfix: typo in path for CustomMeshComponent (case error) (Contributed by malavon) #jira UE-57077 Change 4044077 by James.Golding Add ClassGroup to some components #jira UE-57587, UE-57609 Change 4044080 by James.Golding PR #4515: Adding API export macro to ACableActor (Contributed by maxtunel) #jira UE-55515 Change 4044082 by James.Golding Remove unused CopySkinnedModelData function #jira UE-57623 Change 4044083 by James.Golding Fix per-poly collision for skel meshes. Make sure to call UpdateKinematicBonesToAnim if bEnablePerPolyCollision is set, even if no bodies Integration of CL 3971421 from Release-4.19 stream #jira UE-56405 Change 4044084 by James.Golding Add option to preview 'fixed bounds' in SkelMesh editors. Change 4044086 by James.Golding Remove unused RigidInfluenceIndex from CPU skinning code Change 4044310 by James.Golding Roll back changes to make PhysX cool fails a log instead of warning (CL 3995372, UE-56466), now that content is fixed Change 4044416 by Lina.Halper Provide BP interface to get curve list of names #jira: UE-52623 Change 4044419 by Lina.Halper added notification for updating pose asset #jira: UE-56233 Change 4046929 by Ethan.Geller #jira none add my developer folder to QAGame. #fyi dan.reynolds Change 4047064 by Ethan.Geller [Dev-AnimPhys] #jira UE-57890 add additional binaries for Steam Audio to LibPhonon.Build.cs. #rb none Change 4047564 by Lina.Halper Fix issue of not regenerating when reimport mesh #jira: UE-58284 Change 4047630 by Ethan.Geller Fix syntax error in libPhonon. #jira none #rb none Change 4048050 by Thomas.Sarkanen Allowed "Follow Bone" to be popped out of the menu into the viewport This allows for quick re-selection of the bone to follow, avoiding multiple clicks Tweaks and extends the "pinned command list" system to allow dynamic text in labels and labels to be hidden. #jira UE-53070 - Follow bone - Follow selected bone Change 4048064 by Thomas.Sarkanen Validate any bone references during compilation Bone references that are set to something other than NAME_None will be verified against the skeleton. Updated various anim nodes to call the base class ValidateAnimNodeDuringCompilation #jira UE-55680 - Anim graph nodes that use FBoneReference all need validation in ValidateAnimNodeDuringCompilation Change 4048468 by James.Golding PR #4319: Allow UAnimNotify_PlayMontageNotify to be inherited by other dlls (Contributed by DSDambuster) #jira UE-53390 Change 4048470 by James.Golding Implement ApplyWorldOffset to CableComponent, to handle origin shifting #jira UE-53560 Change 4048471 by James.Golding PR #4396: fix cachebones for subclasses of FAnimNode_SkeletalControlBase (Contributed by tmiv) #jira UE-53799 Change 4048474 by James.Golding PR #4423: Rename confusing argument in LineBoxIntersection (Contributed by Hybrid0) #jira UE-54145 Change 4048485 by James.Golding Fix compile error display from PoseDriver node #jira UE-58306 Change 4048489 by James.Golding Finish support for ProceduralMeshComponent supporting multiple UV channels #jira UE-54049 Change 4048678 by Thomas.Sarkanen Allowing blend space samples to be optionally moved off-grid Grid samples are now each optionally snapped. #jira UE-56116 - Allow blend spaces to optionally use off-grid sample points Change 4048773 by Lina.Halper Support pose factory with name input #jira: UE-55859 Change 4048844 by David.Hill Material Proxy Settings Updating the max on the material proxy texture size - old value could cause int32 overflow. #jira: UE-55441 Change 4049464 by Lina.Halper update curve is expensive, and we're doing multiple times with same curve sets. I'm changing it so that it only updates main, and copy from main instance to sub/post. #jira: UE-58459 Change 4050939 by Aaron.McLeran PR #4649: Activated reverbs will now take priority when world settings are used (i.e. no volume proxy is in use) (Contributed by Brandon-Wilson) #jira UE-57546 Change 4050954 by Aaron.McLeran PR #4594: Added class type to allow inherited versions of UAudioComponents to be created (Contributed by korypostma) #jira UE-56454 Change 4050960 by Aaron.McLeran Attempt to fix linux build. Change 4051247 by James.Golding Fix ProcMeshComp UpdateSection not copying all UV sets Add test case for ProcMeshComp with multiple UVs #jira UE-54049 Change 4051250 by James.Golding Add bUseHighPrecisionTangentBasis option to SkeletalMesh Change SkeletalMesh source data to store tangents at higher precision #jira UE-58525 Change 4051616 by Thomas.Sarkanen Mass scale is no longer incorrectly clamped This now allows mass scales below 0.01 and above 100. #jira UE-49572 - MassScale has some edge cases for skeletal mesh component and small numbers Change 4051619 by Thomas.Sarkanen Fixed notify drag/drop on high DPI displays #jira UE-55690 - Animation Notifies Do Not Move Past the Center of Timeline On a High DPI Display Change 4051626 by Thomas.Sarkanen Fix anim dynamics debug rendering #jira UE-53902 - Anim Dynamics node is missing wireframe simulation box in preview #jira UE-57983 - GitHub 4674 : UE-57910 Fix the angular limits display issue while selecting the AnimDynamics node Change 4051628 by Thomas.Sarkanen Constraints and bodies now rotate in their own local space in the physics asset editor When local coordinate system is applied #jira UE-50345 - rotating constraints or bodies in Phat with local axis Change 4051634 by Thomas.Sarkanen Automatic rules for state transitions are now shown in tooltips #jira UE-57689 - Animation State Machine Transitions that use bAutomaticRuleBasedOnSequencePlayerInState, should indicate that in the transition Change 4051636 by Thomas.Sarkanen NotifyTriggerChance is now hidden for nodify states as it has no effect #jira UE-55351 - NotifyTriggerChance should be grayed out for UAnimNotifyState Change 4051669 by Thomas.Sarkanen Fixed accidental operation of pinned commands when closing them #jira UE-54051 - Unpinning settings will toggle the next setting Change 4051671 by Thomas.Sarkanen Fix crash importing skeletal mesh with no vertices Not a fix for the jira, but found while investigating #jira UE-56330 - FBX Files Do Not Import After Using the Facial Anim Importer Unless Project is Reopened Change 4051684 by James.Golding Fix high precision tangents when CPU skinning and mesh merging Remember bExistingUseHighPrecisionTangentBasis when re-importing SkelMesh #jira UE-58525 Change 4051686 by James.Golding PR #4297: Output animation name with ensure() - useful when debugging (Contributed by DSDambuster) #jira UE-53259 Change 4051801 by Jurre.deBaare A BlendSpace that puts the same asset on samples can stop its own animation on Switch #fix Ensure that we don't cause divide-by-zero situations when sampling blendspace data #jira UE-54030 Change 4051806 by Jurre.deBaare Fix geometry cache reimport + serialization issues Change 4051807 by Jurre.deBaare Currently, it's not possible to assigned a material to a Geometry Cache .uasset #fix EditAnywhere rather than VisibleAnywhere #jira UE-58212 Change 4051809 by Jurre.deBaare GeomCache: Crash/Bug: When importing file #fix Ensure that we have a valid first frame when trying to import a sequence, if not error-out #jira UE-58285 Change 4051813 by Jurre.deBaare GeomCache: Bug: Normals Broken #jira UE-58287 GeomCache - Normals are Bad on Import #jira UE-58283 #fix ensure that we triangulate mesh attributes when necessary #misc per-attribute indices check Change 4051816 by Jurre.deBaare Alembic QOL - Fix issue with reimport object flags not being applied - Now also store sampling data as part of Alembic asset import data Change 4051817 by Jurre.deBaare PR #4550: Fixes bug where "Merge Actors" or HLOD proxies result in too many mesh sections (Contributed by trond) #fix Integrated pull-request in different form #jira UE-55976 Change 4051818 by Jurre.deBaare Emissive isn't baked correctly in TM-MeshbakeMap #fix ensure that we OR and Max the material flags and emissive scale #jira UE-54889 Change 4051819 by Jurre.deBaare Crash on project load when GeometryCache plugin is disabled #fix No longer force-load the geometry cache module as it was moved to be a plugin #jira UE-57875 Change 4051820 by Jurre.deBaare CLONE - Editor crash when Propagating Vertex Colors to Asset's source mesh #fix IsValidIndex check #jira UE-57127 Vertex painting Change 4051828 by Jurre.deBaare Merging negative-scaled actors breaks materials #fix Make sure we also reverse the section indices when a static mesh has a mirrored transform #jira UE-56953 Change 4051834 by Jurre.deBaare Unclear warnings when generating clusters in persistent level when sublevels have HLOD disabled #fix improved warning text + added uobject link to level in content browser #jira UE-55734 Change 4051993 by Jurre.deBaare Update Alembic automated test ground truth #jira none Change 4052937 by James.Golding Remove now-unused version (merged change to skel source data from Main instead) Change 4053291 by Aaron.McLeran Fix for CIS #jira none Change 4053375 by Aaron.McLeran #jira UE-58716 Allow ability to bypass volume-weighting with using sound wave priority Change 4057170 by Thomas.Sarkanen Fix shadow variable warning #jira UE-58806 - Linux: Shadow Variable Warnings building Editor - PhysicsAssetEditorEditMode.cpp Change 4057653 by Lina.Halper Fix the issue with showing same item multiple times when opening control rig blueprint many times #jira: UE-58107 Change 4057701 by Jurre.deBaare //UE4/Dev-AnimPhys - Step 'Run Automated Tests' has completed with 13 Errors #fix reupdate alembic ground truths, little bit of a weird state #jira UE-58818 Change 4057710 by Ethan.Geller [Dev-AnimPhys] #jira UE-58004 Early exit if finish was called before StartSubmixRecording. #rb Aaron.McLeran Change 4059295 by Ethan.Geller #jira UE-58004 Reduce logs from fatal to error, fix serialize crash. #rb aaron.mcleran Change 4061061 by Aaron.McLeran Fixing animphys build from recent merge from main. #jira UE-58909 Change 4053154 by Aaron.McLeran #jira UE-58708 Fix to mic component to reduce clicks/pops on mic input. Fix was to simplify the way audio is copied from mic input. This change was used on the GDC demo floor for a number of features. [CL 4062611 by Aaron McLeran in Main branch]
2018-05-09 18:45:58 -04:00
auto GetLocalRotation = [this](FEditorViewportClient* InLocalViewportClient, const FRotator& InRotation, const FTransform& InWidgetTM)
{
FRotator Rotation = InRotation;
if(InLocalViewportClient->GetWidgetCoordSystemSpace() == COORD_Local)
{
// When using local coords, we should rotate in EACH objects local space, not the space of the first selected.
// We receive deltas in the local coord space, so we need to transform back
FMatrix CoordSpace;
GetCustomInputCoordinateSystem(CoordSpace, nullptr);
FMatrix WidgetDeltaRotation = CoordSpace * FRotationMatrix(Rotation) * CoordSpace.Inverse();
// Now transform into this object's local space
FMatrix ObjectMatrix = InWidgetTM.ToMatrixNoScale().RemoveTranslation();
Rotation = (ObjectMatrix.Inverse() * WidgetDeltaRotation * ObjectMatrix).Rotator();
}
return Rotation;
};
auto GetLocalTranslation = [this](FEditorViewportClient* InLocalViewportClient, const FVector& InDrag, const FTransform& InWidgetTM)
{
FVector Translation = InDrag;
if (InLocalViewportClient->GetWidgetCoordSystemSpace() == COORD_Local)
{
// When using local coords, we should translate in EACH objects local space, not the space of the first selected.
// We receive deltas in the local coord space, so we need to transform back
FMatrix CoordSpace;
GetCustomInputCoordinateSystem(CoordSpace, nullptr);
// Now transform into this object's local space
FMatrix ObjectMatrix = InWidgetTM.ToMatrixNoScale().RemoveTranslation();
Translation = ObjectMatrix.TransformVector(CoordSpace.Inverse().TransformVector(InDrag));
}
return Translation;
};
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
bool bHandled = false;
const EAxisList::Type CurrentAxis = InViewportClient->GetCurrentWidgetAxis();
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
if (!SharedData->bRunningSimulation && SharedData->bManipulating && CurrentAxis != EAxisList::None)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
for (int32 i = 0; i< SharedData->SelectedBodies.Num(); ++i)
{
FPhysicsAssetEditorSharedData::FSelection & SelectedObject = SharedData->SelectedBodies[i];
if (SharedData->bManipulating)
{
float BoneScale = 1.f;
int32 BoneIndex = SharedData->EditorSkelComp->GetBoneIndex(SharedData->PhysicsAsset->SkeletalBodySetups[SelectedObject.Index]->BoneName);
FTransform BoneTM = SharedData->EditorSkelComp->GetBoneTransform(BoneIndex);
BoneScale = BoneTM.GetScale3D().GetAbsMax();
BoneTM.RemoveScaling();
SelectedObject.WidgetTM = SharedData->EditorSkelComp->GetPrimitiveTransform(BoneTM, SelectedObject.Index, SelectedObject.PrimitiveType, SelectedObject.PrimitiveIndex, BoneScale);
if(InViewportClient->GetWidgetMode() == UE::Widget::WM_Translate || InViewportClient->GetWidgetMode() == UE::Widget::WM_Rotate)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
if (InViewportClient->GetWidgetMode() == UE::Widget::WM_Translate)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
FVector DragToUse = GetLocalTranslation(InViewportClient, InDrag, SelectedObject.WidgetTM);
FVector Dir = SelectedObject.WidgetTM.InverseTransformVector(DragToUse.GetSafeNormal());
FVector DragVec = Dir * DragToUse.Size() / BoneScale;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
SelectedObject.ManipulateTM.AddToTranslation(DragVec);
}
else if (InViewportClient->GetWidgetMode() == UE::Widget::WM_Rotate)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 4062005) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4005617 by Danny.Bouimad Fixing TM-AnimPhys lighting so it works on all platforms #jira UEENGQA-19924 Change 4014898 by Aaron.McLeran Adding simple delay feature Change 4025071 by Lina.Halper Fix and more potential fix for invalid bone index issue http://crashreporter/Buggs/Show/2052839 http://crashreporter/Crashes/Show/46656562 #jira: UE-51931 Change 4042493 by Lina.Halper Fix issue with sequence evaluator to handle properly when jumps from end to front or front to end #jira: UE-58429 Change 4042892 by Lina.Halper Fix issue with being able to drag/drop montage onto anim track in sequencer #jira: UE-57863 Change 4043553 by Ethan.Geller #jira UE-58340 Handle calls to FVoiceCaptureWindows::GetVoiceData outside of existing data calls. #rb none Change 4043613 by Lina.Halper Fix issue with incorrect usage of staticclass #jira: UE-54413 Change 4044069 by James.Golding PR #4455: Add FAnimNode_StateMachine subclassing support. (Contributed by redfeatherplusplus) #jira UE-54599 Change 4044070 by James.Golding PR #4349: Final points on a line test were broken, changed Plane.PlaneDot to FM. (Contributed by DSDambuster) #jira UE-53554 Change 4044072 by James.Golding Add ENGINE_API to UPhysicsHandleComponent so it can be subclassed #jira UE-56397 Change 4044073 by James.Golding PR #4611: Expose a few API's so it's possible to make custom anim graph nodes using these objects. (Contributed by ill) #jira UE-57004 Change 4044075 by James.Golding PR #4618: Bugfix: typo in path for CustomMeshComponent (case error) (Contributed by malavon) #jira UE-57077 Change 4044077 by James.Golding Add ClassGroup to some components #jira UE-57587, UE-57609 Change 4044080 by James.Golding PR #4515: Adding API export macro to ACableActor (Contributed by maxtunel) #jira UE-55515 Change 4044082 by James.Golding Remove unused CopySkinnedModelData function #jira UE-57623 Change 4044083 by James.Golding Fix per-poly collision for skel meshes. Make sure to call UpdateKinematicBonesToAnim if bEnablePerPolyCollision is set, even if no bodies Integration of CL 3971421 from Release-4.19 stream #jira UE-56405 Change 4044084 by James.Golding Add option to preview 'fixed bounds' in SkelMesh editors. Change 4044086 by James.Golding Remove unused RigidInfluenceIndex from CPU skinning code Change 4044310 by James.Golding Roll back changes to make PhysX cool fails a log instead of warning (CL 3995372, UE-56466), now that content is fixed Change 4044416 by Lina.Halper Provide BP interface to get curve list of names #jira: UE-52623 Change 4044419 by Lina.Halper added notification for updating pose asset #jira: UE-56233 Change 4046929 by Ethan.Geller #jira none add my developer folder to QAGame. #fyi dan.reynolds Change 4047064 by Ethan.Geller [Dev-AnimPhys] #jira UE-57890 add additional binaries for Steam Audio to LibPhonon.Build.cs. #rb none Change 4047564 by Lina.Halper Fix issue of not regenerating when reimport mesh #jira: UE-58284 Change 4047630 by Ethan.Geller Fix syntax error in libPhonon. #jira none #rb none Change 4048050 by Thomas.Sarkanen Allowed "Follow Bone" to be popped out of the menu into the viewport This allows for quick re-selection of the bone to follow, avoiding multiple clicks Tweaks and extends the "pinned command list" system to allow dynamic text in labels and labels to be hidden. #jira UE-53070 - Follow bone - Follow selected bone Change 4048064 by Thomas.Sarkanen Validate any bone references during compilation Bone references that are set to something other than NAME_None will be verified against the skeleton. Updated various anim nodes to call the base class ValidateAnimNodeDuringCompilation #jira UE-55680 - Anim graph nodes that use FBoneReference all need validation in ValidateAnimNodeDuringCompilation Change 4048468 by James.Golding PR #4319: Allow UAnimNotify_PlayMontageNotify to be inherited by other dlls (Contributed by DSDambuster) #jira UE-53390 Change 4048470 by James.Golding Implement ApplyWorldOffset to CableComponent, to handle origin shifting #jira UE-53560 Change 4048471 by James.Golding PR #4396: fix cachebones for subclasses of FAnimNode_SkeletalControlBase (Contributed by tmiv) #jira UE-53799 Change 4048474 by James.Golding PR #4423: Rename confusing argument in LineBoxIntersection (Contributed by Hybrid0) #jira UE-54145 Change 4048485 by James.Golding Fix compile error display from PoseDriver node #jira UE-58306 Change 4048489 by James.Golding Finish support for ProceduralMeshComponent supporting multiple UV channels #jira UE-54049 Change 4048678 by Thomas.Sarkanen Allowing blend space samples to be optionally moved off-grid Grid samples are now each optionally snapped. #jira UE-56116 - Allow blend spaces to optionally use off-grid sample points Change 4048773 by Lina.Halper Support pose factory with name input #jira: UE-55859 Change 4048844 by David.Hill Material Proxy Settings Updating the max on the material proxy texture size - old value could cause int32 overflow. #jira: UE-55441 Change 4049464 by Lina.Halper update curve is expensive, and we're doing multiple times with same curve sets. I'm changing it so that it only updates main, and copy from main instance to sub/post. #jira: UE-58459 Change 4050939 by Aaron.McLeran PR #4649: Activated reverbs will now take priority when world settings are used (i.e. no volume proxy is in use) (Contributed by Brandon-Wilson) #jira UE-57546 Change 4050954 by Aaron.McLeran PR #4594: Added class type to allow inherited versions of UAudioComponents to be created (Contributed by korypostma) #jira UE-56454 Change 4050960 by Aaron.McLeran Attempt to fix linux build. Change 4051247 by James.Golding Fix ProcMeshComp UpdateSection not copying all UV sets Add test case for ProcMeshComp with multiple UVs #jira UE-54049 Change 4051250 by James.Golding Add bUseHighPrecisionTangentBasis option to SkeletalMesh Change SkeletalMesh source data to store tangents at higher precision #jira UE-58525 Change 4051616 by Thomas.Sarkanen Mass scale is no longer incorrectly clamped This now allows mass scales below 0.01 and above 100. #jira UE-49572 - MassScale has some edge cases for skeletal mesh component and small numbers Change 4051619 by Thomas.Sarkanen Fixed notify drag/drop on high DPI displays #jira UE-55690 - Animation Notifies Do Not Move Past the Center of Timeline On a High DPI Display Change 4051626 by Thomas.Sarkanen Fix anim dynamics debug rendering #jira UE-53902 - Anim Dynamics node is missing wireframe simulation box in preview #jira UE-57983 - GitHub 4674 : UE-57910 Fix the angular limits display issue while selecting the AnimDynamics node Change 4051628 by Thomas.Sarkanen Constraints and bodies now rotate in their own local space in the physics asset editor When local coordinate system is applied #jira UE-50345 - rotating constraints or bodies in Phat with local axis Change 4051634 by Thomas.Sarkanen Automatic rules for state transitions are now shown in tooltips #jira UE-57689 - Animation State Machine Transitions that use bAutomaticRuleBasedOnSequencePlayerInState, should indicate that in the transition Change 4051636 by Thomas.Sarkanen NotifyTriggerChance is now hidden for nodify states as it has no effect #jira UE-55351 - NotifyTriggerChance should be grayed out for UAnimNotifyState Change 4051669 by Thomas.Sarkanen Fixed accidental operation of pinned commands when closing them #jira UE-54051 - Unpinning settings will toggle the next setting Change 4051671 by Thomas.Sarkanen Fix crash importing skeletal mesh with no vertices Not a fix for the jira, but found while investigating #jira UE-56330 - FBX Files Do Not Import After Using the Facial Anim Importer Unless Project is Reopened Change 4051684 by James.Golding Fix high precision tangents when CPU skinning and mesh merging Remember bExistingUseHighPrecisionTangentBasis when re-importing SkelMesh #jira UE-58525 Change 4051686 by James.Golding PR #4297: Output animation name with ensure() - useful when debugging (Contributed by DSDambuster) #jira UE-53259 Change 4051801 by Jurre.deBaare A BlendSpace that puts the same asset on samples can stop its own animation on Switch #fix Ensure that we don't cause divide-by-zero situations when sampling blendspace data #jira UE-54030 Change 4051806 by Jurre.deBaare Fix geometry cache reimport + serialization issues Change 4051807 by Jurre.deBaare Currently, it's not possible to assigned a material to a Geometry Cache .uasset #fix EditAnywhere rather than VisibleAnywhere #jira UE-58212 Change 4051809 by Jurre.deBaare GeomCache: Crash/Bug: When importing file #fix Ensure that we have a valid first frame when trying to import a sequence, if not error-out #jira UE-58285 Change 4051813 by Jurre.deBaare GeomCache: Bug: Normals Broken #jira UE-58287 GeomCache - Normals are Bad on Import #jira UE-58283 #fix ensure that we triangulate mesh attributes when necessary #misc per-attribute indices check Change 4051816 by Jurre.deBaare Alembic QOL - Fix issue with reimport object flags not being applied - Now also store sampling data as part of Alembic asset import data Change 4051817 by Jurre.deBaare PR #4550: Fixes bug where "Merge Actors" or HLOD proxies result in too many mesh sections (Contributed by trond) #fix Integrated pull-request in different form #jira UE-55976 Change 4051818 by Jurre.deBaare Emissive isn't baked correctly in TM-MeshbakeMap #fix ensure that we OR and Max the material flags and emissive scale #jira UE-54889 Change 4051819 by Jurre.deBaare Crash on project load when GeometryCache plugin is disabled #fix No longer force-load the geometry cache module as it was moved to be a plugin #jira UE-57875 Change 4051820 by Jurre.deBaare CLONE - Editor crash when Propagating Vertex Colors to Asset's source mesh #fix IsValidIndex check #jira UE-57127 Vertex painting Change 4051828 by Jurre.deBaare Merging negative-scaled actors breaks materials #fix Make sure we also reverse the section indices when a static mesh has a mirrored transform #jira UE-56953 Change 4051834 by Jurre.deBaare Unclear warnings when generating clusters in persistent level when sublevels have HLOD disabled #fix improved warning text + added uobject link to level in content browser #jira UE-55734 Change 4051993 by Jurre.deBaare Update Alembic automated test ground truth #jira none Change 4052937 by James.Golding Remove now-unused version (merged change to skel source data from Main instead) Change 4053291 by Aaron.McLeran Fix for CIS #jira none Change 4053375 by Aaron.McLeran #jira UE-58716 Allow ability to bypass volume-weighting with using sound wave priority Change 4057170 by Thomas.Sarkanen Fix shadow variable warning #jira UE-58806 - Linux: Shadow Variable Warnings building Editor - PhysicsAssetEditorEditMode.cpp Change 4057653 by Lina.Halper Fix the issue with showing same item multiple times when opening control rig blueprint many times #jira: UE-58107 Change 4057701 by Jurre.deBaare //UE4/Dev-AnimPhys - Step 'Run Automated Tests' has completed with 13 Errors #fix reupdate alembic ground truths, little bit of a weird state #jira UE-58818 Change 4057710 by Ethan.Geller [Dev-AnimPhys] #jira UE-58004 Early exit if finish was called before StartSubmixRecording. #rb Aaron.McLeran Change 4059295 by Ethan.Geller #jira UE-58004 Reduce logs from fatal to error, fix serialize crash. #rb aaron.mcleran Change 4061061 by Aaron.McLeran Fixing animphys build from recent merge from main. #jira UE-58909 Change 4053154 by Aaron.McLeran #jira UE-58708 Fix to mic component to reduce clicks/pops on mic input. Fix was to simplify the way audio is copied from mic input. This change was used on the GDC demo floor for a number of features. [CL 4062611 by Aaron McLeran in Main branch]
2018-05-09 18:45:58 -04:00
FRotator RotatorToUse = GetLocalRotation(InViewportClient, InRot, SelectedObject.WidgetTM);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
FVector Axis;
float Angle;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 4062005) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4005617 by Danny.Bouimad Fixing TM-AnimPhys lighting so it works on all platforms #jira UEENGQA-19924 Change 4014898 by Aaron.McLeran Adding simple delay feature Change 4025071 by Lina.Halper Fix and more potential fix for invalid bone index issue http://crashreporter/Buggs/Show/2052839 http://crashreporter/Crashes/Show/46656562 #jira: UE-51931 Change 4042493 by Lina.Halper Fix issue with sequence evaluator to handle properly when jumps from end to front or front to end #jira: UE-58429 Change 4042892 by Lina.Halper Fix issue with being able to drag/drop montage onto anim track in sequencer #jira: UE-57863 Change 4043553 by Ethan.Geller #jira UE-58340 Handle calls to FVoiceCaptureWindows::GetVoiceData outside of existing data calls. #rb none Change 4043613 by Lina.Halper Fix issue with incorrect usage of staticclass #jira: UE-54413 Change 4044069 by James.Golding PR #4455: Add FAnimNode_StateMachine subclassing support. (Contributed by redfeatherplusplus) #jira UE-54599 Change 4044070 by James.Golding PR #4349: Final points on a line test were broken, changed Plane.PlaneDot to FM. (Contributed by DSDambuster) #jira UE-53554 Change 4044072 by James.Golding Add ENGINE_API to UPhysicsHandleComponent so it can be subclassed #jira UE-56397 Change 4044073 by James.Golding PR #4611: Expose a few API's so it's possible to make custom anim graph nodes using these objects. (Contributed by ill) #jira UE-57004 Change 4044075 by James.Golding PR #4618: Bugfix: typo in path for CustomMeshComponent (case error) (Contributed by malavon) #jira UE-57077 Change 4044077 by James.Golding Add ClassGroup to some components #jira UE-57587, UE-57609 Change 4044080 by James.Golding PR #4515: Adding API export macro to ACableActor (Contributed by maxtunel) #jira UE-55515 Change 4044082 by James.Golding Remove unused CopySkinnedModelData function #jira UE-57623 Change 4044083 by James.Golding Fix per-poly collision for skel meshes. Make sure to call UpdateKinematicBonesToAnim if bEnablePerPolyCollision is set, even if no bodies Integration of CL 3971421 from Release-4.19 stream #jira UE-56405 Change 4044084 by James.Golding Add option to preview 'fixed bounds' in SkelMesh editors. Change 4044086 by James.Golding Remove unused RigidInfluenceIndex from CPU skinning code Change 4044310 by James.Golding Roll back changes to make PhysX cool fails a log instead of warning (CL 3995372, UE-56466), now that content is fixed Change 4044416 by Lina.Halper Provide BP interface to get curve list of names #jira: UE-52623 Change 4044419 by Lina.Halper added notification for updating pose asset #jira: UE-56233 Change 4046929 by Ethan.Geller #jira none add my developer folder to QAGame. #fyi dan.reynolds Change 4047064 by Ethan.Geller [Dev-AnimPhys] #jira UE-57890 add additional binaries for Steam Audio to LibPhonon.Build.cs. #rb none Change 4047564 by Lina.Halper Fix issue of not regenerating when reimport mesh #jira: UE-58284 Change 4047630 by Ethan.Geller Fix syntax error in libPhonon. #jira none #rb none Change 4048050 by Thomas.Sarkanen Allowed "Follow Bone" to be popped out of the menu into the viewport This allows for quick re-selection of the bone to follow, avoiding multiple clicks Tweaks and extends the "pinned command list" system to allow dynamic text in labels and labels to be hidden. #jira UE-53070 - Follow bone - Follow selected bone Change 4048064 by Thomas.Sarkanen Validate any bone references during compilation Bone references that are set to something other than NAME_None will be verified against the skeleton. Updated various anim nodes to call the base class ValidateAnimNodeDuringCompilation #jira UE-55680 - Anim graph nodes that use FBoneReference all need validation in ValidateAnimNodeDuringCompilation Change 4048468 by James.Golding PR #4319: Allow UAnimNotify_PlayMontageNotify to be inherited by other dlls (Contributed by DSDambuster) #jira UE-53390 Change 4048470 by James.Golding Implement ApplyWorldOffset to CableComponent, to handle origin shifting #jira UE-53560 Change 4048471 by James.Golding PR #4396: fix cachebones for subclasses of FAnimNode_SkeletalControlBase (Contributed by tmiv) #jira UE-53799 Change 4048474 by James.Golding PR #4423: Rename confusing argument in LineBoxIntersection (Contributed by Hybrid0) #jira UE-54145 Change 4048485 by James.Golding Fix compile error display from PoseDriver node #jira UE-58306 Change 4048489 by James.Golding Finish support for ProceduralMeshComponent supporting multiple UV channels #jira UE-54049 Change 4048678 by Thomas.Sarkanen Allowing blend space samples to be optionally moved off-grid Grid samples are now each optionally snapped. #jira UE-56116 - Allow blend spaces to optionally use off-grid sample points Change 4048773 by Lina.Halper Support pose factory with name input #jira: UE-55859 Change 4048844 by David.Hill Material Proxy Settings Updating the max on the material proxy texture size - old value could cause int32 overflow. #jira: UE-55441 Change 4049464 by Lina.Halper update curve is expensive, and we're doing multiple times with same curve sets. I'm changing it so that it only updates main, and copy from main instance to sub/post. #jira: UE-58459 Change 4050939 by Aaron.McLeran PR #4649: Activated reverbs will now take priority when world settings are used (i.e. no volume proxy is in use) (Contributed by Brandon-Wilson) #jira UE-57546 Change 4050954 by Aaron.McLeran PR #4594: Added class type to allow inherited versions of UAudioComponents to be created (Contributed by korypostma) #jira UE-56454 Change 4050960 by Aaron.McLeran Attempt to fix linux build. Change 4051247 by James.Golding Fix ProcMeshComp UpdateSection not copying all UV sets Add test case for ProcMeshComp with multiple UVs #jira UE-54049 Change 4051250 by James.Golding Add bUseHighPrecisionTangentBasis option to SkeletalMesh Change SkeletalMesh source data to store tangents at higher precision #jira UE-58525 Change 4051616 by Thomas.Sarkanen Mass scale is no longer incorrectly clamped This now allows mass scales below 0.01 and above 100. #jira UE-49572 - MassScale has some edge cases for skeletal mesh component and small numbers Change 4051619 by Thomas.Sarkanen Fixed notify drag/drop on high DPI displays #jira UE-55690 - Animation Notifies Do Not Move Past the Center of Timeline On a High DPI Display Change 4051626 by Thomas.Sarkanen Fix anim dynamics debug rendering #jira UE-53902 - Anim Dynamics node is missing wireframe simulation box in preview #jira UE-57983 - GitHub 4674 : UE-57910 Fix the angular limits display issue while selecting the AnimDynamics node Change 4051628 by Thomas.Sarkanen Constraints and bodies now rotate in their own local space in the physics asset editor When local coordinate system is applied #jira UE-50345 - rotating constraints or bodies in Phat with local axis Change 4051634 by Thomas.Sarkanen Automatic rules for state transitions are now shown in tooltips #jira UE-57689 - Animation State Machine Transitions that use bAutomaticRuleBasedOnSequencePlayerInState, should indicate that in the transition Change 4051636 by Thomas.Sarkanen NotifyTriggerChance is now hidden for nodify states as it has no effect #jira UE-55351 - NotifyTriggerChance should be grayed out for UAnimNotifyState Change 4051669 by Thomas.Sarkanen Fixed accidental operation of pinned commands when closing them #jira UE-54051 - Unpinning settings will toggle the next setting Change 4051671 by Thomas.Sarkanen Fix crash importing skeletal mesh with no vertices Not a fix for the jira, but found while investigating #jira UE-56330 - FBX Files Do Not Import After Using the Facial Anim Importer Unless Project is Reopened Change 4051684 by James.Golding Fix high precision tangents when CPU skinning and mesh merging Remember bExistingUseHighPrecisionTangentBasis when re-importing SkelMesh #jira UE-58525 Change 4051686 by James.Golding PR #4297: Output animation name with ensure() - useful when debugging (Contributed by DSDambuster) #jira UE-53259 Change 4051801 by Jurre.deBaare A BlendSpace that puts the same asset on samples can stop its own animation on Switch #fix Ensure that we don't cause divide-by-zero situations when sampling blendspace data #jira UE-54030 Change 4051806 by Jurre.deBaare Fix geometry cache reimport + serialization issues Change 4051807 by Jurre.deBaare Currently, it's not possible to assigned a material to a Geometry Cache .uasset #fix EditAnywhere rather than VisibleAnywhere #jira UE-58212 Change 4051809 by Jurre.deBaare GeomCache: Crash/Bug: When importing file #fix Ensure that we have a valid first frame when trying to import a sequence, if not error-out #jira UE-58285 Change 4051813 by Jurre.deBaare GeomCache: Bug: Normals Broken #jira UE-58287 GeomCache - Normals are Bad on Import #jira UE-58283 #fix ensure that we triangulate mesh attributes when necessary #misc per-attribute indices check Change 4051816 by Jurre.deBaare Alembic QOL - Fix issue with reimport object flags not being applied - Now also store sampling data as part of Alembic asset import data Change 4051817 by Jurre.deBaare PR #4550: Fixes bug where "Merge Actors" or HLOD proxies result in too many mesh sections (Contributed by trond) #fix Integrated pull-request in different form #jira UE-55976 Change 4051818 by Jurre.deBaare Emissive isn't baked correctly in TM-MeshbakeMap #fix ensure that we OR and Max the material flags and emissive scale #jira UE-54889 Change 4051819 by Jurre.deBaare Crash on project load when GeometryCache plugin is disabled #fix No longer force-load the geometry cache module as it was moved to be a plugin #jira UE-57875 Change 4051820 by Jurre.deBaare CLONE - Editor crash when Propagating Vertex Colors to Asset's source mesh #fix IsValidIndex check #jira UE-57127 Vertex painting Change 4051828 by Jurre.deBaare Merging negative-scaled actors breaks materials #fix Make sure we also reverse the section indices when a static mesh has a mirrored transform #jira UE-56953 Change 4051834 by Jurre.deBaare Unclear warnings when generating clusters in persistent level when sublevels have HLOD disabled #fix improved warning text + added uobject link to level in content browser #jira UE-55734 Change 4051993 by Jurre.deBaare Update Alembic automated test ground truth #jira none Change 4052937 by James.Golding Remove now-unused version (merged change to skel source data from Main instead) Change 4053291 by Aaron.McLeran Fix for CIS #jira none Change 4053375 by Aaron.McLeran #jira UE-58716 Allow ability to bypass volume-weighting with using sound wave priority Change 4057170 by Thomas.Sarkanen Fix shadow variable warning #jira UE-58806 - Linux: Shadow Variable Warnings building Editor - PhysicsAssetEditorEditMode.cpp Change 4057653 by Lina.Halper Fix the issue with showing same item multiple times when opening control rig blueprint many times #jira: UE-58107 Change 4057701 by Jurre.deBaare //UE4/Dev-AnimPhys - Step 'Run Automated Tests' has completed with 13 Errors #fix reupdate alembic ground truths, little bit of a weird state #jira UE-58818 Change 4057710 by Ethan.Geller [Dev-AnimPhys] #jira UE-58004 Early exit if finish was called before StartSubmixRecording. #rb Aaron.McLeran Change 4059295 by Ethan.Geller #jira UE-58004 Reduce logs from fatal to error, fix serialize crash. #rb aaron.mcleran Change 4061061 by Aaron.McLeran Fixing animphys build from recent merge from main. #jira UE-58909 Change 4053154 by Aaron.McLeran #jira UE-58708 Fix to mic component to reduce clicks/pops on mic input. Fix was to simplify the way audio is copied from mic input. This change was used on the GDC demo floor for a number of features. [CL 4062611 by Aaron McLeran in Main branch]
2018-05-09 18:45:58 -04:00
RotatorToUse.Quaternion().ToAxisAndAngle(Axis, Angle);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
Axis = SelectedObject.WidgetTM.InverseTransformVectorNoScale(Axis);
const FQuat Start = SelectedObject.ManipulateTM.GetRotation();
const FQuat Delta = FQuat(Axis, Angle);
const FQuat Result = Delta * Start;
SelectedObject.ManipulateTM = FTransform(Result);
}
UBodySetup* BodySetup = SharedData->PhysicsAsset->SkeletalBodySetups[SelectedObject.Index];
FKAggregateGeom* AggGeom = &BodySetup->AggGeom;
// for all but convex shapes, we apply straight away
if (SelectedObject.PrimitiveType == EAggCollisionShape::Sphere)
{
AggGeom->SphereElems[SelectedObject.PrimitiveIndex].Center = (SelectedObject.ManipulateTM * AggGeom->SphereElems[SelectedObject.PrimitiveIndex].GetTransform()).GetLocation();
SelectedObject.ManipulateTM.SetIdentity();
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::Box)
{
AggGeom->BoxElems[SelectedObject.PrimitiveIndex].SetTransform(SelectedObject.ManipulateTM * AggGeom->BoxElems[SelectedObject.PrimitiveIndex].GetTransform());
SelectedObject.ManipulateTM.SetIdentity();
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::Sphyl)
{
AggGeom->SphylElems[SelectedObject.PrimitiveIndex].SetTransform(SelectedObject.ManipulateTM * AggGeom->SphylElems[SelectedObject.PrimitiveIndex].GetTransform());
SelectedObject.ManipulateTM.SetIdentity();
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::TaperedCapsule)
{
AggGeom->TaperedCapsuleElems[SelectedObject.PrimitiveIndex].SetTransform(SelectedObject.ManipulateTM * AggGeom->TaperedCapsuleElems[SelectedObject.PrimitiveIndex].GetTransform());
SelectedObject.ManipulateTM.SetIdentity();
}
else if (SelectedObject.PrimitiveType == EAggCollisionShape::LevelSet)
{
AggGeom->LevelSetElems[SelectedObject.PrimitiveIndex].SetTransform(SelectedObject.ManipulateTM * AggGeom->LevelSetElems[SelectedObject.PrimitiveIndex].GetTransform());
SelectedObject.ManipulateTM.SetIdentity();
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
else if (InViewportClient->GetWidgetMode() == UE::Widget::WM_Scale)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
ModifyPrimitiveSize(SelectedObject.Index, SelectedObject.PrimitiveType, SelectedObject.PrimitiveIndex, InScale);
}
bHandled = true;
}
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
if(bHandled)
{
SharedData->UpdateClothPhysics();
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
for (int32 i = 0; i<SharedData->SelectedConstraints.Num(); ++i)
{
FPhysicsAssetEditorSharedData::FSelection & SelectedObject = SharedData->SelectedConstraints[i];
if (SharedData->bManipulating)
{
float BoneScale = 1.f;
SelectedObject.WidgetTM = SharedData->GetConstraintMatrix(SelectedObject.Index, EConstraintFrame::Frame2, 1.f);
if (InViewportClient->GetWidgetMode() == UE::Widget::WM_Translate)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
FVector DragToUse = GetLocalTranslation(InViewportClient, InDrag, SelectedObject.WidgetTM);
FVector Dir = SelectedObject.WidgetTM.InverseTransformVector(DragToUse.GetSafeNormal());
FVector DragVec = Dir * DragToUse.Size() / BoneScale;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
SelectedObject.ManipulateTM.AddToTranslation(DragVec);
}
else if (InViewportClient->GetWidgetMode() == UE::Widget::WM_Rotate)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 4062005) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4005617 by Danny.Bouimad Fixing TM-AnimPhys lighting so it works on all platforms #jira UEENGQA-19924 Change 4014898 by Aaron.McLeran Adding simple delay feature Change 4025071 by Lina.Halper Fix and more potential fix for invalid bone index issue http://crashreporter/Buggs/Show/2052839 http://crashreporter/Crashes/Show/46656562 #jira: UE-51931 Change 4042493 by Lina.Halper Fix issue with sequence evaluator to handle properly when jumps from end to front or front to end #jira: UE-58429 Change 4042892 by Lina.Halper Fix issue with being able to drag/drop montage onto anim track in sequencer #jira: UE-57863 Change 4043553 by Ethan.Geller #jira UE-58340 Handle calls to FVoiceCaptureWindows::GetVoiceData outside of existing data calls. #rb none Change 4043613 by Lina.Halper Fix issue with incorrect usage of staticclass #jira: UE-54413 Change 4044069 by James.Golding PR #4455: Add FAnimNode_StateMachine subclassing support. (Contributed by redfeatherplusplus) #jira UE-54599 Change 4044070 by James.Golding PR #4349: Final points on a line test were broken, changed Plane.PlaneDot to FM. (Contributed by DSDambuster) #jira UE-53554 Change 4044072 by James.Golding Add ENGINE_API to UPhysicsHandleComponent so it can be subclassed #jira UE-56397 Change 4044073 by James.Golding PR #4611: Expose a few API's so it's possible to make custom anim graph nodes using these objects. (Contributed by ill) #jira UE-57004 Change 4044075 by James.Golding PR #4618: Bugfix: typo in path for CustomMeshComponent (case error) (Contributed by malavon) #jira UE-57077 Change 4044077 by James.Golding Add ClassGroup to some components #jira UE-57587, UE-57609 Change 4044080 by James.Golding PR #4515: Adding API export macro to ACableActor (Contributed by maxtunel) #jira UE-55515 Change 4044082 by James.Golding Remove unused CopySkinnedModelData function #jira UE-57623 Change 4044083 by James.Golding Fix per-poly collision for skel meshes. Make sure to call UpdateKinematicBonesToAnim if bEnablePerPolyCollision is set, even if no bodies Integration of CL 3971421 from Release-4.19 stream #jira UE-56405 Change 4044084 by James.Golding Add option to preview 'fixed bounds' in SkelMesh editors. Change 4044086 by James.Golding Remove unused RigidInfluenceIndex from CPU skinning code Change 4044310 by James.Golding Roll back changes to make PhysX cool fails a log instead of warning (CL 3995372, UE-56466), now that content is fixed Change 4044416 by Lina.Halper Provide BP interface to get curve list of names #jira: UE-52623 Change 4044419 by Lina.Halper added notification for updating pose asset #jira: UE-56233 Change 4046929 by Ethan.Geller #jira none add my developer folder to QAGame. #fyi dan.reynolds Change 4047064 by Ethan.Geller [Dev-AnimPhys] #jira UE-57890 add additional binaries for Steam Audio to LibPhonon.Build.cs. #rb none Change 4047564 by Lina.Halper Fix issue of not regenerating when reimport mesh #jira: UE-58284 Change 4047630 by Ethan.Geller Fix syntax error in libPhonon. #jira none #rb none Change 4048050 by Thomas.Sarkanen Allowed "Follow Bone" to be popped out of the menu into the viewport This allows for quick re-selection of the bone to follow, avoiding multiple clicks Tweaks and extends the "pinned command list" system to allow dynamic text in labels and labels to be hidden. #jira UE-53070 - Follow bone - Follow selected bone Change 4048064 by Thomas.Sarkanen Validate any bone references during compilation Bone references that are set to something other than NAME_None will be verified against the skeleton. Updated various anim nodes to call the base class ValidateAnimNodeDuringCompilation #jira UE-55680 - Anim graph nodes that use FBoneReference all need validation in ValidateAnimNodeDuringCompilation Change 4048468 by James.Golding PR #4319: Allow UAnimNotify_PlayMontageNotify to be inherited by other dlls (Contributed by DSDambuster) #jira UE-53390 Change 4048470 by James.Golding Implement ApplyWorldOffset to CableComponent, to handle origin shifting #jira UE-53560 Change 4048471 by James.Golding PR #4396: fix cachebones for subclasses of FAnimNode_SkeletalControlBase (Contributed by tmiv) #jira UE-53799 Change 4048474 by James.Golding PR #4423: Rename confusing argument in LineBoxIntersection (Contributed by Hybrid0) #jira UE-54145 Change 4048485 by James.Golding Fix compile error display from PoseDriver node #jira UE-58306 Change 4048489 by James.Golding Finish support for ProceduralMeshComponent supporting multiple UV channels #jira UE-54049 Change 4048678 by Thomas.Sarkanen Allowing blend space samples to be optionally moved off-grid Grid samples are now each optionally snapped. #jira UE-56116 - Allow blend spaces to optionally use off-grid sample points Change 4048773 by Lina.Halper Support pose factory with name input #jira: UE-55859 Change 4048844 by David.Hill Material Proxy Settings Updating the max on the material proxy texture size - old value could cause int32 overflow. #jira: UE-55441 Change 4049464 by Lina.Halper update curve is expensive, and we're doing multiple times with same curve sets. I'm changing it so that it only updates main, and copy from main instance to sub/post. #jira: UE-58459 Change 4050939 by Aaron.McLeran PR #4649: Activated reverbs will now take priority when world settings are used (i.e. no volume proxy is in use) (Contributed by Brandon-Wilson) #jira UE-57546 Change 4050954 by Aaron.McLeran PR #4594: Added class type to allow inherited versions of UAudioComponents to be created (Contributed by korypostma) #jira UE-56454 Change 4050960 by Aaron.McLeran Attempt to fix linux build. Change 4051247 by James.Golding Fix ProcMeshComp UpdateSection not copying all UV sets Add test case for ProcMeshComp with multiple UVs #jira UE-54049 Change 4051250 by James.Golding Add bUseHighPrecisionTangentBasis option to SkeletalMesh Change SkeletalMesh source data to store tangents at higher precision #jira UE-58525 Change 4051616 by Thomas.Sarkanen Mass scale is no longer incorrectly clamped This now allows mass scales below 0.01 and above 100. #jira UE-49572 - MassScale has some edge cases for skeletal mesh component and small numbers Change 4051619 by Thomas.Sarkanen Fixed notify drag/drop on high DPI displays #jira UE-55690 - Animation Notifies Do Not Move Past the Center of Timeline On a High DPI Display Change 4051626 by Thomas.Sarkanen Fix anim dynamics debug rendering #jira UE-53902 - Anim Dynamics node is missing wireframe simulation box in preview #jira UE-57983 - GitHub 4674 : UE-57910 Fix the angular limits display issue while selecting the AnimDynamics node Change 4051628 by Thomas.Sarkanen Constraints and bodies now rotate in their own local space in the physics asset editor When local coordinate system is applied #jira UE-50345 - rotating constraints or bodies in Phat with local axis Change 4051634 by Thomas.Sarkanen Automatic rules for state transitions are now shown in tooltips #jira UE-57689 - Animation State Machine Transitions that use bAutomaticRuleBasedOnSequencePlayerInState, should indicate that in the transition Change 4051636 by Thomas.Sarkanen NotifyTriggerChance is now hidden for nodify states as it has no effect #jira UE-55351 - NotifyTriggerChance should be grayed out for UAnimNotifyState Change 4051669 by Thomas.Sarkanen Fixed accidental operation of pinned commands when closing them #jira UE-54051 - Unpinning settings will toggle the next setting Change 4051671 by Thomas.Sarkanen Fix crash importing skeletal mesh with no vertices Not a fix for the jira, but found while investigating #jira UE-56330 - FBX Files Do Not Import After Using the Facial Anim Importer Unless Project is Reopened Change 4051684 by James.Golding Fix high precision tangents when CPU skinning and mesh merging Remember bExistingUseHighPrecisionTangentBasis when re-importing SkelMesh #jira UE-58525 Change 4051686 by James.Golding PR #4297: Output animation name with ensure() - useful when debugging (Contributed by DSDambuster) #jira UE-53259 Change 4051801 by Jurre.deBaare A BlendSpace that puts the same asset on samples can stop its own animation on Switch #fix Ensure that we don't cause divide-by-zero situations when sampling blendspace data #jira UE-54030 Change 4051806 by Jurre.deBaare Fix geometry cache reimport + serialization issues Change 4051807 by Jurre.deBaare Currently, it's not possible to assigned a material to a Geometry Cache .uasset #fix EditAnywhere rather than VisibleAnywhere #jira UE-58212 Change 4051809 by Jurre.deBaare GeomCache: Crash/Bug: When importing file #fix Ensure that we have a valid first frame when trying to import a sequence, if not error-out #jira UE-58285 Change 4051813 by Jurre.deBaare GeomCache: Bug: Normals Broken #jira UE-58287 GeomCache - Normals are Bad on Import #jira UE-58283 #fix ensure that we triangulate mesh attributes when necessary #misc per-attribute indices check Change 4051816 by Jurre.deBaare Alembic QOL - Fix issue with reimport object flags not being applied - Now also store sampling data as part of Alembic asset import data Change 4051817 by Jurre.deBaare PR #4550: Fixes bug where "Merge Actors" or HLOD proxies result in too many mesh sections (Contributed by trond) #fix Integrated pull-request in different form #jira UE-55976 Change 4051818 by Jurre.deBaare Emissive isn't baked correctly in TM-MeshbakeMap #fix ensure that we OR and Max the material flags and emissive scale #jira UE-54889 Change 4051819 by Jurre.deBaare Crash on project load when GeometryCache plugin is disabled #fix No longer force-load the geometry cache module as it was moved to be a plugin #jira UE-57875 Change 4051820 by Jurre.deBaare CLONE - Editor crash when Propagating Vertex Colors to Asset's source mesh #fix IsValidIndex check #jira UE-57127 Vertex painting Change 4051828 by Jurre.deBaare Merging negative-scaled actors breaks materials #fix Make sure we also reverse the section indices when a static mesh has a mirrored transform #jira UE-56953 Change 4051834 by Jurre.deBaare Unclear warnings when generating clusters in persistent level when sublevels have HLOD disabled #fix improved warning text + added uobject link to level in content browser #jira UE-55734 Change 4051993 by Jurre.deBaare Update Alembic automated test ground truth #jira none Change 4052937 by James.Golding Remove now-unused version (merged change to skel source data from Main instead) Change 4053291 by Aaron.McLeran Fix for CIS #jira none Change 4053375 by Aaron.McLeran #jira UE-58716 Allow ability to bypass volume-weighting with using sound wave priority Change 4057170 by Thomas.Sarkanen Fix shadow variable warning #jira UE-58806 - Linux: Shadow Variable Warnings building Editor - PhysicsAssetEditorEditMode.cpp Change 4057653 by Lina.Halper Fix the issue with showing same item multiple times when opening control rig blueprint many times #jira: UE-58107 Change 4057701 by Jurre.deBaare //UE4/Dev-AnimPhys - Step 'Run Automated Tests' has completed with 13 Errors #fix reupdate alembic ground truths, little bit of a weird state #jira UE-58818 Change 4057710 by Ethan.Geller [Dev-AnimPhys] #jira UE-58004 Early exit if finish was called before StartSubmixRecording. #rb Aaron.McLeran Change 4059295 by Ethan.Geller #jira UE-58004 Reduce logs from fatal to error, fix serialize crash. #rb aaron.mcleran Change 4061061 by Aaron.McLeran Fixing animphys build from recent merge from main. #jira UE-58909 Change 4053154 by Aaron.McLeran #jira UE-58708 Fix to mic component to reduce clicks/pops on mic input. Fix was to simplify the way audio is copied from mic input. This change was used on the GDC demo floor for a number of features. [CL 4062611 by Aaron McLeran in Main branch]
2018-05-09 18:45:58 -04:00
FRotator RotatorToUse = GetLocalRotation(InViewportClient, InRot, SelectedObject.WidgetTM);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
FVector Axis;
float Angle;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 4062005) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4005617 by Danny.Bouimad Fixing TM-AnimPhys lighting so it works on all platforms #jira UEENGQA-19924 Change 4014898 by Aaron.McLeran Adding simple delay feature Change 4025071 by Lina.Halper Fix and more potential fix for invalid bone index issue http://crashreporter/Buggs/Show/2052839 http://crashreporter/Crashes/Show/46656562 #jira: UE-51931 Change 4042493 by Lina.Halper Fix issue with sequence evaluator to handle properly when jumps from end to front or front to end #jira: UE-58429 Change 4042892 by Lina.Halper Fix issue with being able to drag/drop montage onto anim track in sequencer #jira: UE-57863 Change 4043553 by Ethan.Geller #jira UE-58340 Handle calls to FVoiceCaptureWindows::GetVoiceData outside of existing data calls. #rb none Change 4043613 by Lina.Halper Fix issue with incorrect usage of staticclass #jira: UE-54413 Change 4044069 by James.Golding PR #4455: Add FAnimNode_StateMachine subclassing support. (Contributed by redfeatherplusplus) #jira UE-54599 Change 4044070 by James.Golding PR #4349: Final points on a line test were broken, changed Plane.PlaneDot to FM. (Contributed by DSDambuster) #jira UE-53554 Change 4044072 by James.Golding Add ENGINE_API to UPhysicsHandleComponent so it can be subclassed #jira UE-56397 Change 4044073 by James.Golding PR #4611: Expose a few API's so it's possible to make custom anim graph nodes using these objects. (Contributed by ill) #jira UE-57004 Change 4044075 by James.Golding PR #4618: Bugfix: typo in path for CustomMeshComponent (case error) (Contributed by malavon) #jira UE-57077 Change 4044077 by James.Golding Add ClassGroup to some components #jira UE-57587, UE-57609 Change 4044080 by James.Golding PR #4515: Adding API export macro to ACableActor (Contributed by maxtunel) #jira UE-55515 Change 4044082 by James.Golding Remove unused CopySkinnedModelData function #jira UE-57623 Change 4044083 by James.Golding Fix per-poly collision for skel meshes. Make sure to call UpdateKinematicBonesToAnim if bEnablePerPolyCollision is set, even if no bodies Integration of CL 3971421 from Release-4.19 stream #jira UE-56405 Change 4044084 by James.Golding Add option to preview 'fixed bounds' in SkelMesh editors. Change 4044086 by James.Golding Remove unused RigidInfluenceIndex from CPU skinning code Change 4044310 by James.Golding Roll back changes to make PhysX cool fails a log instead of warning (CL 3995372, UE-56466), now that content is fixed Change 4044416 by Lina.Halper Provide BP interface to get curve list of names #jira: UE-52623 Change 4044419 by Lina.Halper added notification for updating pose asset #jira: UE-56233 Change 4046929 by Ethan.Geller #jira none add my developer folder to QAGame. #fyi dan.reynolds Change 4047064 by Ethan.Geller [Dev-AnimPhys] #jira UE-57890 add additional binaries for Steam Audio to LibPhonon.Build.cs. #rb none Change 4047564 by Lina.Halper Fix issue of not regenerating when reimport mesh #jira: UE-58284 Change 4047630 by Ethan.Geller Fix syntax error in libPhonon. #jira none #rb none Change 4048050 by Thomas.Sarkanen Allowed "Follow Bone" to be popped out of the menu into the viewport This allows for quick re-selection of the bone to follow, avoiding multiple clicks Tweaks and extends the "pinned command list" system to allow dynamic text in labels and labels to be hidden. #jira UE-53070 - Follow bone - Follow selected bone Change 4048064 by Thomas.Sarkanen Validate any bone references during compilation Bone references that are set to something other than NAME_None will be verified against the skeleton. Updated various anim nodes to call the base class ValidateAnimNodeDuringCompilation #jira UE-55680 - Anim graph nodes that use FBoneReference all need validation in ValidateAnimNodeDuringCompilation Change 4048468 by James.Golding PR #4319: Allow UAnimNotify_PlayMontageNotify to be inherited by other dlls (Contributed by DSDambuster) #jira UE-53390 Change 4048470 by James.Golding Implement ApplyWorldOffset to CableComponent, to handle origin shifting #jira UE-53560 Change 4048471 by James.Golding PR #4396: fix cachebones for subclasses of FAnimNode_SkeletalControlBase (Contributed by tmiv) #jira UE-53799 Change 4048474 by James.Golding PR #4423: Rename confusing argument in LineBoxIntersection (Contributed by Hybrid0) #jira UE-54145 Change 4048485 by James.Golding Fix compile error display from PoseDriver node #jira UE-58306 Change 4048489 by James.Golding Finish support for ProceduralMeshComponent supporting multiple UV channels #jira UE-54049 Change 4048678 by Thomas.Sarkanen Allowing blend space samples to be optionally moved off-grid Grid samples are now each optionally snapped. #jira UE-56116 - Allow blend spaces to optionally use off-grid sample points Change 4048773 by Lina.Halper Support pose factory with name input #jira: UE-55859 Change 4048844 by David.Hill Material Proxy Settings Updating the max on the material proxy texture size - old value could cause int32 overflow. #jira: UE-55441 Change 4049464 by Lina.Halper update curve is expensive, and we're doing multiple times with same curve sets. I'm changing it so that it only updates main, and copy from main instance to sub/post. #jira: UE-58459 Change 4050939 by Aaron.McLeran PR #4649: Activated reverbs will now take priority when world settings are used (i.e. no volume proxy is in use) (Contributed by Brandon-Wilson) #jira UE-57546 Change 4050954 by Aaron.McLeran PR #4594: Added class type to allow inherited versions of UAudioComponents to be created (Contributed by korypostma) #jira UE-56454 Change 4050960 by Aaron.McLeran Attempt to fix linux build. Change 4051247 by James.Golding Fix ProcMeshComp UpdateSection not copying all UV sets Add test case for ProcMeshComp with multiple UVs #jira UE-54049 Change 4051250 by James.Golding Add bUseHighPrecisionTangentBasis option to SkeletalMesh Change SkeletalMesh source data to store tangents at higher precision #jira UE-58525 Change 4051616 by Thomas.Sarkanen Mass scale is no longer incorrectly clamped This now allows mass scales below 0.01 and above 100. #jira UE-49572 - MassScale has some edge cases for skeletal mesh component and small numbers Change 4051619 by Thomas.Sarkanen Fixed notify drag/drop on high DPI displays #jira UE-55690 - Animation Notifies Do Not Move Past the Center of Timeline On a High DPI Display Change 4051626 by Thomas.Sarkanen Fix anim dynamics debug rendering #jira UE-53902 - Anim Dynamics node is missing wireframe simulation box in preview #jira UE-57983 - GitHub 4674 : UE-57910 Fix the angular limits display issue while selecting the AnimDynamics node Change 4051628 by Thomas.Sarkanen Constraints and bodies now rotate in their own local space in the physics asset editor When local coordinate system is applied #jira UE-50345 - rotating constraints or bodies in Phat with local axis Change 4051634 by Thomas.Sarkanen Automatic rules for state transitions are now shown in tooltips #jira UE-57689 - Animation State Machine Transitions that use bAutomaticRuleBasedOnSequencePlayerInState, should indicate that in the transition Change 4051636 by Thomas.Sarkanen NotifyTriggerChance is now hidden for nodify states as it has no effect #jira UE-55351 - NotifyTriggerChance should be grayed out for UAnimNotifyState Change 4051669 by Thomas.Sarkanen Fixed accidental operation of pinned commands when closing them #jira UE-54051 - Unpinning settings will toggle the next setting Change 4051671 by Thomas.Sarkanen Fix crash importing skeletal mesh with no vertices Not a fix for the jira, but found while investigating #jira UE-56330 - FBX Files Do Not Import After Using the Facial Anim Importer Unless Project is Reopened Change 4051684 by James.Golding Fix high precision tangents when CPU skinning and mesh merging Remember bExistingUseHighPrecisionTangentBasis when re-importing SkelMesh #jira UE-58525 Change 4051686 by James.Golding PR #4297: Output animation name with ensure() - useful when debugging (Contributed by DSDambuster) #jira UE-53259 Change 4051801 by Jurre.deBaare A BlendSpace that puts the same asset on samples can stop its own animation on Switch #fix Ensure that we don't cause divide-by-zero situations when sampling blendspace data #jira UE-54030 Change 4051806 by Jurre.deBaare Fix geometry cache reimport + serialization issues Change 4051807 by Jurre.deBaare Currently, it's not possible to assigned a material to a Geometry Cache .uasset #fix EditAnywhere rather than VisibleAnywhere #jira UE-58212 Change 4051809 by Jurre.deBaare GeomCache: Crash/Bug: When importing file #fix Ensure that we have a valid first frame when trying to import a sequence, if not error-out #jira UE-58285 Change 4051813 by Jurre.deBaare GeomCache: Bug: Normals Broken #jira UE-58287 GeomCache - Normals are Bad on Import #jira UE-58283 #fix ensure that we triangulate mesh attributes when necessary #misc per-attribute indices check Change 4051816 by Jurre.deBaare Alembic QOL - Fix issue with reimport object flags not being applied - Now also store sampling data as part of Alembic asset import data Change 4051817 by Jurre.deBaare PR #4550: Fixes bug where "Merge Actors" or HLOD proxies result in too many mesh sections (Contributed by trond) #fix Integrated pull-request in different form #jira UE-55976 Change 4051818 by Jurre.deBaare Emissive isn't baked correctly in TM-MeshbakeMap #fix ensure that we OR and Max the material flags and emissive scale #jira UE-54889 Change 4051819 by Jurre.deBaare Crash on project load when GeometryCache plugin is disabled #fix No longer force-load the geometry cache module as it was moved to be a plugin #jira UE-57875 Change 4051820 by Jurre.deBaare CLONE - Editor crash when Propagating Vertex Colors to Asset's source mesh #fix IsValidIndex check #jira UE-57127 Vertex painting Change 4051828 by Jurre.deBaare Merging negative-scaled actors breaks materials #fix Make sure we also reverse the section indices when a static mesh has a mirrored transform #jira UE-56953 Change 4051834 by Jurre.deBaare Unclear warnings when generating clusters in persistent level when sublevels have HLOD disabled #fix improved warning text + added uobject link to level in content browser #jira UE-55734 Change 4051993 by Jurre.deBaare Update Alembic automated test ground truth #jira none Change 4052937 by James.Golding Remove now-unused version (merged change to skel source data from Main instead) Change 4053291 by Aaron.McLeran Fix for CIS #jira none Change 4053375 by Aaron.McLeran #jira UE-58716 Allow ability to bypass volume-weighting with using sound wave priority Change 4057170 by Thomas.Sarkanen Fix shadow variable warning #jira UE-58806 - Linux: Shadow Variable Warnings building Editor - PhysicsAssetEditorEditMode.cpp Change 4057653 by Lina.Halper Fix the issue with showing same item multiple times when opening control rig blueprint many times #jira: UE-58107 Change 4057701 by Jurre.deBaare //UE4/Dev-AnimPhys - Step 'Run Automated Tests' has completed with 13 Errors #fix reupdate alembic ground truths, little bit of a weird state #jira UE-58818 Change 4057710 by Ethan.Geller [Dev-AnimPhys] #jira UE-58004 Early exit if finish was called before StartSubmixRecording. #rb Aaron.McLeran Change 4059295 by Ethan.Geller #jira UE-58004 Reduce logs from fatal to error, fix serialize crash. #rb aaron.mcleran Change 4061061 by Aaron.McLeran Fixing animphys build from recent merge from main. #jira UE-58909 Change 4053154 by Aaron.McLeran #jira UE-58708 Fix to mic component to reduce clicks/pops on mic input. Fix was to simplify the way audio is copied from mic input. This change was used on the GDC demo floor for a number of features. [CL 4062611 by Aaron McLeran in Main branch]
2018-05-09 18:45:58 -04:00
RotatorToUse.Quaternion().ToAxisAndAngle(Axis, Angle);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
Axis = SelectedObject.WidgetTM.InverseTransformVectorNoScale(Axis);
const FQuat Start = SelectedObject.ManipulateTM.GetRotation();
const FQuat Delta = FQuat(Axis, Angle);
const FQuat Result = Delta * Start;
SelectedObject.ManipulateTM = FTransform(Result);
}
UPhysicsConstraintTemplate* ConstraintSetup = SharedData->PhysicsAsset->ConstraintSetup[SelectedObject.Index];
ConstraintSetup->DefaultInstance.SetRefFrame(EConstraintFrame::Frame2, SelectedObject.ManipulateTM * StartManParentConTM[i]);
// Alt + Move will split frames and rotate or move them separately
bool bMultiFrame = !InViewportClient->IsAltPressed();
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
if (bMultiFrame)
{
SharedData->SetConstraintRelTM(&SelectedObject, StartManRelConTM[i]);
}
else
{
ConstraintSetup->DefaultInstance.SetRefFrame(EConstraintFrame::Frame1, FTransform(StartManChildConTM[i]));
}
bHandled = true;
}
}
}
return bHandled;
}
void FPhysicsAssetEditorEditMode::Tick(FEditorViewportClient* ViewportClient, float DeltaTime)
{
if (SharedData->bRunningSimulation)
{
// check if PIE disabled the realtime viewport and quit sim if so
if (!ViewportClient->IsRealtime())
{
SharedData->ToggleSimulation();
ViewportClient->Invalidate();
}
UWorld* World = SharedData->PreviewScene.Pin()->GetWorld();
AWorldSettings* Setting = World->GetWorldSettings();
Setting->WorldGravityZ = SharedData->bNoGravitySimulation ? 0.0f : (SharedData->EditorOptions->bUseGravityOverride ? SharedData->EditorOptions->GravityOverrideZ : (UPhysicsSettings::Get()->DefaultGravityZ * SharedData->EditorOptions->GravScale));
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
Setting->bWorldGravitySet = true;
// We back up the transforms array now
SharedData->EditorSkelComp->AnimationSpaceBases = SharedData->EditorSkelComp->GetComponentSpaceTransforms();
// When using the World solver, we must specify how much of the solver output gets blended into the animated mesh pose
// When using other solvers in PhAT, we don't want SetPhysicsBlendWeight function to re-enale the main solver physics
if (SharedData->PhysicsAsset->SolverType == EPhysicsAssetSolverType::World)
{
SharedData->EditorSkelComp->SetPhysicsBlendWeight(SharedData->EditorOptions->PhysicsBlend);
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
SharedData->EditorSkelComp->bUpdateJointsFromAnimation = SharedData->EditorOptions->bUpdateJointsFromAnimation;
SharedData->EditorSkelComp->PhysicsTransformUpdateMode = SharedData->EditorOptions->PhysicsUpdateMode;
static FPhysicalAnimationData EmptyProfile;
SharedData->PhysicalAnimationComponent->ApplyPhysicalAnimationProfileBelow(NAME_None, SharedData->PhysicsAsset->CurrentPhysicalAnimationProfileName, /*Include Self=*/true, /*Clear Not Found=*/true);
}
}
void FPhysicsAssetEditorEditMode::Render(const FSceneView* View, FViewport* Viewport, FPrimitiveDrawInterface* PDI)
{
EPhysicsAssetEditorMeshViewMode MeshViewMode = SharedData->GetCurrentMeshViewMode(SharedData->bRunningSimulation);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
if (MeshViewMode != EPhysicsAssetEditorMeshViewMode::None)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
SharedData->EditorSkelComp->SetVisibility(true);
if (MeshViewMode == EPhysicsAssetEditorMeshViewMode::Wireframe)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
SharedData->EditorSkelComp->SetForceWireframe(true);
}
else
{
SharedData->EditorSkelComp->SetForceWireframe(false);
}
}
else
{
SharedData->EditorSkelComp->SetVisibility(false);
}
// Draw phat skeletal component.
SharedData->EditorSkelComp->DebugDraw(View, PDI);
}
void FPhysicsAssetEditorEditMode::DrawHUD(FEditorViewportClient* ViewportClient, FViewport* Viewport, const FSceneView* View, FCanvas* Canvas)
{
float W, H;
PhysicsAssetEditorFont->GetCharSize(TEXT('L'), W, H);
const float XOffset = 5.0f;
const float YOffset = 48.0f;
FCanvasTextItem TextItem(FVector2D::ZeroVector, FText::GetEmpty(), PhysicsAssetEditorFont, FLinearColor::White);
TextItem.Text = FText::GetEmpty();
if (SharedData->bRunningSimulation)
{
#if PLATFORM_MAC
TextItem.Text = LOCTEXT("Sim_Mac", "Command+RightMouse to interact with bodies");
#else
TextItem.Text = LOCTEXT("Sim", "Ctrl+RightMouse to interact with bodies");
#endif
}
else if(SharedData->GetSelectedConstraint() != nullptr)
{
if (ViewportClient->GetWidgetMode() == UE::Widget::WM_Translate)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
TextItem.Text = LOCTEXT("SingleMove", "Hold ALT to move a single reference frame");
}
else if (ViewportClient->GetWidgetMode() == UE::Widget::WM_Rotate)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
TextItem.Text = LOCTEXT("SingleRotate", "Hold ALT to rotate single reference frame");
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
}
Canvas->DrawItem(TextItem, XOffset, Viewport->GetSizeXY().Y - (3 + H));
// Draw current physics weight
if (SharedData->bRunningSimulation)
{
FString PhysWeightString = FString::Printf(TEXT("Phys Blend: %3.0f pct"), SharedData->EditorOptions->PhysicsBlend * 100.f);
int32 PWLW, PWLH;
StringSize(PhysicsAssetEditorFont, PWLW, PWLH, *PhysWeightString);
TextItem.Text = FText::FromString(PhysWeightString);
Canvas->DrawItem(TextItem, Viewport->GetSizeXY().X - (3 + PWLW + 2 * W), Viewport->GetSizeXY().Y - (3 + H));
}
int32 HalfX = (Viewport->GetSizeXY().X - XOffset) / 2;
int32 HalfY = Viewport->GetSizeXY().Y / 2;
// If showing center-of-mass, and physics is started up..
if (SharedData->bShowCOM)
{
// iterate over each bone
for (int32 i = 0; i <SharedData->EditorSkelComp->Bodies.Num(); ++i)
{
FBodyInstance* BodyInst = SharedData->EditorSkelComp->Bodies[i];
check(BodyInst);
FVector BodyCOMPos = BodyInst->GetCOMPosition();
float BodyMass = BodyInst->GetBodyMass();
FPlane Projection = View->Project(BodyCOMPos);
if (Projection.W > 0.f) // This avoids drawing bone names that are behind us.
{
int32 XPos = HalfX + (HalfX * Projection.X);
int32 YPos = HalfY + (HalfY * (Projection.Y * -1));
FString COMString = FString::Printf(TEXT("%3.3f"), BodyMass);
TextItem.Text = FText::FromString(COMString);
TextItem.SetColor(SharedData->COMRenderColor);
Canvas->DrawItem(TextItem, XPos, YPos);
}
}
}
}
bool FPhysicsAssetEditorEditMode::AllowWidgetMove()
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
return ShouldDrawWidget();
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
bool FPhysicsAssetEditorEditMode::ShouldDrawWidget() const
{
return !SharedData->bRunningSimulation && (SharedData->GetSelectedBody() || SharedData->GetSelectedConstraint());
}
bool FPhysicsAssetEditorEditMode::UsesTransformWidget() const
{
return ShouldDrawWidget();
}
bool FPhysicsAssetEditorEditMode::UsesTransformWidget(UE::Widget::EWidgetMode CheckMode) const
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
if (SharedData->GetSelectedConstraint() && CheckMode == UE::Widget::WM_Scale)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
return false;
}
return ShouldDrawWidget() && (CheckMode == UE::Widget::WM_Scale || CheckMode == UE::Widget::WM_Translate || CheckMode == UE::Widget::WM_Rotate || CheckMode == UE::Widget::WM_None);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
bool FPhysicsAssetEditorEditMode::GetCustomDrawingCoordinateSystem(FMatrix& InMatrix, void* InData)
{
// Don't draw widget if nothing selected.
if (SharedData->GetSelectedBody())
{
int32 BoneIndex = SharedData->EditorSkelComp->GetBoneIndex(SharedData->PhysicsAsset->SkeletalBodySetups[SharedData->GetSelectedBody()->Index]->BoneName);
if(BoneIndex != INDEX_NONE)
{
FTransform BoneTM = SharedData->EditorSkelComp->GetBoneTransform(BoneIndex);
BoneTM.RemoveScaling();
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
InMatrix = SharedData->EditorSkelComp->GetPrimitiveTransform(BoneTM, SharedData->GetSelectedBody()->Index, SharedData->GetSelectedBody()->PrimitiveType, SharedData->GetSelectedBody()->PrimitiveIndex, 1.f).ToMatrixNoScale().RemoveTranslation();
return true;
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
else if (SharedData->GetSelectedConstraint())
{
InMatrix = SharedData->GetConstraintMatrix(SharedData->GetSelectedConstraint()->Index, EConstraintFrame::Frame2, 1.f).ToMatrixNoScale().RemoveTranslation();
return true;
}
return false;
}
bool FPhysicsAssetEditorEditMode::GetCustomInputCoordinateSystem(FMatrix& InMatrix, void* InData)
{
return GetCustomDrawingCoordinateSystem(InMatrix, InData);
}
FVector FPhysicsAssetEditorEditMode::GetWidgetLocation() const
{
// Don't draw widget if nothing selected.
if (SharedData->GetSelectedBody())
{
int32 BoneIndex = SharedData->EditorSkelComp->GetBoneIndex(SharedData->PhysicsAsset->SkeletalBodySetups[SharedData->GetSelectedBody()->Index]->BoneName);
if(BoneIndex != INDEX_NONE)
{
FTransform BoneTM = SharedData->EditorSkelComp->GetBoneTransform(BoneIndex);
const float Scale = BoneTM.GetScale3D().GetAbsMax();
BoneTM.RemoveScaling();
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
return SharedData->EditorSkelComp->GetPrimitiveTransform(BoneTM, SharedData->GetSelectedBody()->Index, SharedData->GetSelectedBody()->PrimitiveType, SharedData->GetSelectedBody()->PrimitiveIndex, Scale).GetTranslation();
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
else if (SharedData->GetSelectedConstraint())
{
return SharedData->GetConstraintMatrix(SharedData->GetSelectedConstraint()->Index, EConstraintFrame::Frame2, 1.f).GetTranslation();
}
return FVector::ZeroVector;
}
bool FPhysicsAssetEditorEditMode::HandleClick(FEditorViewportClient* InViewportClient, HHitProxy *HitProxy, const FViewportClick &Click)
{
if (!SharedData->bRunningSimulation)
{
if (Click.GetKey() == EKeys::LeftMouseButton)
{
if (HitProxy && HitProxy->IsA(HPhysicsAssetEditorEdBoneProxy::StaticGetType()))
{
HPhysicsAssetEditorEdBoneProxy* BoneProxy = (HPhysicsAssetEditorEdBoneProxy*)HitProxy;
SharedData->HitBone(BoneProxy->BodyIndex, BoneProxy->PrimType, BoneProxy->PrimIndex, InViewportClient->IsCtrlPressed() || InViewportClient->IsShiftPressed());
return true;
}
else if (HitProxy && HitProxy->IsA(HPhysicsAssetEditorEdConstraintProxy::StaticGetType()))
{
HPhysicsAssetEditorEdConstraintProxy* ConstraintProxy = (HPhysicsAssetEditorEdConstraintProxy*)HitProxy;
SharedData->HitConstraint(ConstraintProxy->ConstraintIndex, InViewportClient->IsCtrlPressed() || InViewportClient->IsShiftPressed());
return true;
}
else
{
HitNothing(InViewportClient);
}
}
else if (Click.GetKey() == EKeys::RightMouseButton)
{
if (HitProxy && HitProxy->IsA(HPhysicsAssetEditorEdBoneProxy::StaticGetType()))
{
HPhysicsAssetEditorEdBoneProxy* BoneProxy = (HPhysicsAssetEditorEdBoneProxy*)HitProxy;
// Select body under cursor if not already selected (if ctrl is held down we only add, not remove)
FPhysicsAssetEditorSharedData::FSelection Selection(BoneProxy->BodyIndex, BoneProxy->PrimType, BoneProxy->PrimIndex);
if (!SharedData->IsBodySelected(Selection))
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3683440) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3624599 by Thomas.Sarkanen Added the ability to rename shapes in the Physics Asset Editor Added "CanRenameItem" to skeleton tree item API so we are not limited to hard-coded bones/sockets Tweaked physics shape item widget to use editable text in the same vein as virtual bones etc. #jira UEAP-341 - Ability to name collision shapes Change 3624765 by Benn.Gallagher Fixed bad blend profile references #jira UE-46227 Change 3624773 by Danny.Bouimad Content fix for #Jira UE-49191 Change 3625007 by Thomas.Sarkanen Fixed monolithinc game builds Moved new Name member to WITH_EDITORONLY_DATA, as the generated code still picks it up using WITH_EDITOR Change 3625659 by Ori.Cohen Make sure that components being unwelded are always unwelded even if they are about to be deleted. This is needed for fixing dangling pointers. Change 3625850 by Thomas.Sarkanen Fix for crash in physics asset editor after garbage collection Move bone proxies from rooting to FGCObject Change 3625966 by Lina.Halper Instead of PinShownByDefault, changed to PinHiddenByDefault https://github.com/EpicGames/UnrealEngine/pull/3964 #3964 #jira: UE-49168 Change 3626020 by Martin.Wilson Protect against checkSlow when using post process instance without a main instance #jira UE-49275 Change 3627178 by Aaron.McLeran #jira UE-49322 Fixing background muting and preview sound Change 3627179 by Aaron.McLeran Optimizing active sound by not processing active sounds if they are out of range. Allowing virtualized sounds to be exempt. Licensee says they saw a 6x improvement on active sound calculations in audio thread with this change. Change 3627187 by Aaron.McLeran Allowing overriding the sample rate of synth components in C++. Useful for cases where synth component is being used to output media auido or VOIP. Change 3627563 by Thomas.Sarkanen Tweaked tooltip so it isnt the same as other menus #jira UE-47817 - Two Viewport tooltips are the same in Physics Asset Editor Change 3627580 by James.Golding PR #3974: UE-49200: Fixed typo in Physics Handle (Contributed by carloshellin) #jira UE-49264 Change 3627581 by James.Golding Reduce output verbosity during cooking #jira UE-47126 Change 3627584 by James.Golding PR #3954: Upgrade to V-HACD version 2.3 (Contributed by jratcliff63367) Auto-convex generation now exposes more useful 'max hulls' instead of 'accuracy' Auto-generation of convex collision is now done async in StaticMesh Editor #jira UE-49027 Change 3627599 by Martin.Wilson Make sure raw data debug bone rendering in the animation editors actually shows raw data in the case of additive track layers (used to show source instead) Change 3627605 by James.Golding Forgot to remove Box2D from TargetRules.cs (see CL 3555437) Change 3627627 by Martin.Wilson Change raw data evaluation so that virtual bone positions are built before interpolation is carried out #jira UE-42659 Change 3627663 by Martin.Wilson Fix typo Change 3627730 by Martin.Wilson Allow notifies to be trigger on follower animations in a sync group #jira UE-46770 Change 3627852 by Thomas.Sarkanen Add warning to "Use Async Scene" property when shown in the physics asset editor, if the project doesn't currently use an async scene. #jira UE-47964 User is not told to Enable Async Scene in Project Settings when enabling it on a physics asset Change 3627864 by Lina.Halper Fix issue where "reset to default" on search box for bone doesn't work #jira: UE-48874 Change 3627946 by Thomas.Sarkanen Prevent undo/redo breaking when moving both a constraint and a body at the same time #jira UE-49344 - Physics Asset Editor: Moving both a body and a constraint causes undo.redo to break for the whole editor Change 3628091 by Thomas.Sarkanen Fix dangling lines, poor search focus and graph not refreshing when making new constraints Found by Nick D in Main. #jira UE-47812 - Physics Asset Graph wires sometimes get stuck to the window not attached to a node Change 3628107 by Lina.Halper Fixed issue where Blendspace 1D can't scale due to the property not exposed https://udn.unrealengine.com/questions/389958/input-interpolationaxis-to-scale-in-1d-blendspace.html Change 3628108 by Arciel.Rekman Update Linux VHACD. - Also removed arm 32-bit version (the library is editor-only). Change 3628437 by Michael.Trepka Updated Mac VHACD libraries and Xcode project Change 3628667 by Lina.Halper - Fixed issue of showing combo box multiple times - Fixed issue of inconsistent combo box width - Fixed text of pick bone to "select" for more general instruction - Fixed issue with struct displaying children when pin is enabled #jira: UE-49295, UE-46496, UE-47427 Change 3629744 by Aaron.McLeran #jira UE-49383 Fix for source bus loading in sound waves and playing without audio mixer Change 3629846 by Aaron.McLeran #jira UE-49390 Required API change to spatialization interface for google Change 3630322 by Thomas.Sarkanen Fix right-click not displaying context menu for constraints correctly Selection logic was lightly broken #jira UE-49399 - Physics Asset Editor: Right-clicking constraints in the viewport does not bring up the context menu Change 3630463 by Martin.Wilson Remove accidently submitted debug code Change 3630523 by Jurre.deBaare Paint threshold and fill value and can be set to negative numbers #fix Added metadata and default values for cloth fill tool #jira UE-48352 Change 3632009 by Aaron.McLeran #jira UE-49470 Fix for iOS master volume not getting set Recent changes to master volume resulted in platforms which don't have a headroom value defined will not get their master volume updated. IOS doesn't have a headroom value set so the master volume is never set and the fade in is never triggered. Change 3632699 by Thomas.Sarkanen Fix crash undo-ing primitive regeneration while simullation is in progress & stopping simulation #jira UE-49283 - Editor crashes if you regenerate and manipulate a phys body, simulate, undo and then exit simulation Change 3633336 by James.Golding PR #3978: effect is the noun. affect is the verb (Contributed by cdietschrun) #jira UE-49324 Change 3634665 by Aaron.McLeran #jira UE-49538 Fixing param interpolation Change 3634922 by James.Golding Static analysis fix (PhysXCookHelper.cpp) Change 3634926 by James.Golding Fix HTML5 build (which builds with PhysX, but without APEX) Change 3636005 by Thomas.Sarkanen Constraint setup shortcuts are now undo-able Also fixed body-body collision as you couldnt undo this either. Added transaction and calls to Modify(). #jira UE-49484 - Shortcut for Swing1Motion (2, and 3) do not change physics asset state dirty. Change 3636018 by Thomas.Sarkanen Added back constraint shortcut to PhAT toolbar #jira UE-48859 - Constraint quick set buttons are missing in the new Physics Asset tool Change 3636086 by Martin.Wilson Fix for enabling Live Link plugin in Orion Change 3638367 by Thomas.Sarkanen Connection reporting is now more user-freindly in the physics asset editor graph view Expanded UEdGraphSchema API to allow for more specific feedback when dragging over a graph. Implemented node & pin feedback for physics asset graphs. Also fixed alignment of icon for drag feedback as it stretches with multi-line text. #jira UE-47984 - No node created when dragging off of Constraint node in Physics Asset Graph Change 3640144 by Aaron.McLeran #jira UE-49409 Attenuation focus audio tests on TM-AnimPhys on Cooked mac doesn't play any audio Fixing the recent optimization to not play active sounds in range. Code attempts to check if there's any possibility for a sound to have it's distance affected before trying to prune by max distance. Change 3640276 by Aaron.McLeran #jira UE-49606 Project does not cook with actors containing ModularSynth component Change 3640313 by Aaron.McLeran #jira UE-49675 Fixing shutdown of audio mixer - Final queued commands aren't getting pumped during audio mixer shutdown, added a new interface to get a final shutdown callback back to audio mixer device. We can do any cleanup or final shutdown tasks in this callback. Added a call to pump the source manager one last time. For cases of audio mixer running without audio plugins, this won't have much of an effect, but is a good thing to do anyway. For the case of audio plugins, who are depending on paired init and release calls, this is valueable to avoid memory leaks between subsequent PIE sessions. Change 3640941 by Martin.Wilson Add editor only animation loading debug data in the hope of diagnosing rare loading crash #jira UE-49335 Change 3641976 by Ethan.Geller #jira UE-49675 ensure that we pump both command queues Change 3642613 by James.Golding Add NoPhysX sample, for CIS testing compilation without PhysX Change 3644001 by Aaron.McLeran #jira UE-49805 looping sounds are, in rare cases, extremely loud Change 3644124 by Aaron.McLeran #jira UE-49787 [CrashReport] Mac crash - UE4Editor-AudioEditor.dylib!FSoundCueEditor::DeleteInput() Adding ensure on returned ptr to avoid crash but keep getting some logging. Change 3644157 by Aaron.McLeran Fixing build error Change 3644163 by Aaron.McLeran Fixing build error (for real) Change 3650331 by Aaron.McLeran #jira UE-49994 SoundMix Fade Time not fading audio properly Making sure we properly set passive mix modifier states. Change 3652648 by Aaron.McLeran #jira UE-49994 SoundMix Fade Time not fading audio properly Change 3652995 by Aaron.McLeran #jira UE-50053 Reduce log level of audio mixer debug category Turning down the log spam level of the underrun category by switching to debug category and reducing level of the debug category. Change 3653461 by James.Golding V-HACD updates from JohnR @ NVIDIA (adding new functions for future use) Change 3654056 by Aaron.McLeran Fixing an issue with caching node states for editor builds and adding optimization to cache if we should apply interior volumes. Change 3654579 by Aaron.McLeran Allow sound submixes and sound classes to be a blueprint type Made all properties of sound classes BlueprintReadOnly. Change 3662519 by James.Golding Merge CL 3575543 from //Fortnite/Main to Dev-AnimPhys Don't call into UpdateKinematicBones if there are no physx bodies Change 3664976 by Aaron.McLeran #jira UE-50175 New Tap Delay Submix Pan parameter does not work in Surround Sound Change 3665751 by Aaron.McLeran Adding a simple panner effect Change 3665851 by Aaron.McLeran Fixing naming convention for new panner source effect Change 3666894 by Thomas.Sarkanen Bone modifications via transform type-in can now be undone Added RF_Transactional & called Modify() #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3666919 by Lina.Halper Fixed equal operator for bonereference to work when not initialized Change 3668850 by Thomas.Sarkanen Skeleton tree now no longer allows selection of filtered items This fixes an issue where filtered-out constraints were being deselected after a select all operation because the tree thought it had no selection (all constraints were filtered). #jira UE-50200 - Constraint Details do not populate in the Details Panel if the Skeleton tree does not include Constraints Change 3669028 by James.Golding Fix CIS error after merge-down Change 3669053 by James.Golding Fix bad merge in SynthComponent.cpp Change 3669273 by Lina.Halper - delete all tracks option - allow to opt out on bone track importing - fixed pose preview for fullbody to select weights that has pose from asset. Change 3671396 by James.Golding Fix FSkelMeshComponentLODInfo cleaning up all override resources when it should only have been cleaning up one of them Change 3671701 by Martin.Wilson Maya Live Link plugin - Added UI to Maya - Display currently streamed subjects - Allow add and removal of streamed subjects - Display connection status to editor - Stream active camera as EditorActiveCamera - Refactored entire plugin so that streaming has a manager and streaming objects / interfaces - Reworked editor update hook so that streaming is more robust and facial rigs / leaf bones now correctly update. Change 3672170 by Lina.Halper Remove track support for Animation Blueprint Library Change 3675921 by Ethan.Geller Rollback invalidated check from copy down Change 3677606 by Martin.Wilson Add live link driven component - allows an actor to take its rotation and translation from a live link subject Change 3678594 by Lina.Halper Changed API name for clarification Change 3680913 by Ethan.Geller #jira UE-50750 fix stuttering on AudioMixer on MacOS Change 3681127 by Ethan.Geller #jira UE-50720 Fix invalidated audio clock time when audio device is unplugged on legacy audio engine Change 3682729 by Ethan.Geller #jira UE-50832 Fix for null concurrency settings when removing active sounds from a concurrency group. [Dev-AnimPhys] Change 3633185 by James.Golding Fix engine not compiling when WITH_PHYSX == 0 PR #3691: 4.16_WITH_PHYSX_optional (Contributed by JacobNelsonGames) PR #3695: 4.16_PhysXVehicles_WITH_PHYSX_optional (Contributed by JacobNelsonGames) Change 3637031 by Ethan.Geller #jira UE-49605 Platform Headroom fix for non-float devices. Change 3642598 by James.Golding Change bCompileNvCloth to use same pattern as bCompileAPEX (on by default, disabled on some platforms). This allows game projects to disable it. Change 3645224 by Martin.Wilson Fix for rare notify crash. For speed purposes Notify Queue caches a pointer to the notify, this is memory that is owned by the animation and if it gets garbage collected we have a pointer to invalid memory. This change caches a pointer to the owner of the notify memory to so we can track its validity. #jira UE-44869 Change 3668926 by James.Golding Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3668712 Change 3674824 by James.Golding Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3674368 [CL 3683447 by Thomas Sarkanen in Main branch]
2017-10-06 04:43:18 -04:00
if(!InViewportClient->IsCtrlPressed())
{
SharedData->ClearSelectedBody();
SharedData->ClearSelectedConstraints();
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
SharedData->SetSelectedBody(Selection, true);
}
// Pop up menu, if we have a body selected.
if (SharedData->GetSelectedBody())
{
OpenBodyMenu(InViewportClient);
}
return true;
}
else if (HitProxy && HitProxy->IsA(HPhysicsAssetEditorEdConstraintProxy::StaticGetType()))
{
HPhysicsAssetEditorEdConstraintProxy* ConstraintProxy = (HPhysicsAssetEditorEdConstraintProxy*)HitProxy;
// Select constraint under cursor if not already selected (if ctrl is held down we only add, not remove)
if (!SharedData->IsConstraintSelected(ConstraintProxy->ConstraintIndex))
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3683440) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3624599 by Thomas.Sarkanen Added the ability to rename shapes in the Physics Asset Editor Added "CanRenameItem" to skeleton tree item API so we are not limited to hard-coded bones/sockets Tweaked physics shape item widget to use editable text in the same vein as virtual bones etc. #jira UEAP-341 - Ability to name collision shapes Change 3624765 by Benn.Gallagher Fixed bad blend profile references #jira UE-46227 Change 3624773 by Danny.Bouimad Content fix for #Jira UE-49191 Change 3625007 by Thomas.Sarkanen Fixed monolithinc game builds Moved new Name member to WITH_EDITORONLY_DATA, as the generated code still picks it up using WITH_EDITOR Change 3625659 by Ori.Cohen Make sure that components being unwelded are always unwelded even if they are about to be deleted. This is needed for fixing dangling pointers. Change 3625850 by Thomas.Sarkanen Fix for crash in physics asset editor after garbage collection Move bone proxies from rooting to FGCObject Change 3625966 by Lina.Halper Instead of PinShownByDefault, changed to PinHiddenByDefault https://github.com/EpicGames/UnrealEngine/pull/3964 #3964 #jira: UE-49168 Change 3626020 by Martin.Wilson Protect against checkSlow when using post process instance without a main instance #jira UE-49275 Change 3627178 by Aaron.McLeran #jira UE-49322 Fixing background muting and preview sound Change 3627179 by Aaron.McLeran Optimizing active sound by not processing active sounds if they are out of range. Allowing virtualized sounds to be exempt. Licensee says they saw a 6x improvement on active sound calculations in audio thread with this change. Change 3627187 by Aaron.McLeran Allowing overriding the sample rate of synth components in C++. Useful for cases where synth component is being used to output media auido or VOIP. Change 3627563 by Thomas.Sarkanen Tweaked tooltip so it isnt the same as other menus #jira UE-47817 - Two Viewport tooltips are the same in Physics Asset Editor Change 3627580 by James.Golding PR #3974: UE-49200: Fixed typo in Physics Handle (Contributed by carloshellin) #jira UE-49264 Change 3627581 by James.Golding Reduce output verbosity during cooking #jira UE-47126 Change 3627584 by James.Golding PR #3954: Upgrade to V-HACD version 2.3 (Contributed by jratcliff63367) Auto-convex generation now exposes more useful 'max hulls' instead of 'accuracy' Auto-generation of convex collision is now done async in StaticMesh Editor #jira UE-49027 Change 3627599 by Martin.Wilson Make sure raw data debug bone rendering in the animation editors actually shows raw data in the case of additive track layers (used to show source instead) Change 3627605 by James.Golding Forgot to remove Box2D from TargetRules.cs (see CL 3555437) Change 3627627 by Martin.Wilson Change raw data evaluation so that virtual bone positions are built before interpolation is carried out #jira UE-42659 Change 3627663 by Martin.Wilson Fix typo Change 3627730 by Martin.Wilson Allow notifies to be trigger on follower animations in a sync group #jira UE-46770 Change 3627852 by Thomas.Sarkanen Add warning to "Use Async Scene" property when shown in the physics asset editor, if the project doesn't currently use an async scene. #jira UE-47964 User is not told to Enable Async Scene in Project Settings when enabling it on a physics asset Change 3627864 by Lina.Halper Fix issue where "reset to default" on search box for bone doesn't work #jira: UE-48874 Change 3627946 by Thomas.Sarkanen Prevent undo/redo breaking when moving both a constraint and a body at the same time #jira UE-49344 - Physics Asset Editor: Moving both a body and a constraint causes undo.redo to break for the whole editor Change 3628091 by Thomas.Sarkanen Fix dangling lines, poor search focus and graph not refreshing when making new constraints Found by Nick D in Main. #jira UE-47812 - Physics Asset Graph wires sometimes get stuck to the window not attached to a node Change 3628107 by Lina.Halper Fixed issue where Blendspace 1D can't scale due to the property not exposed https://udn.unrealengine.com/questions/389958/input-interpolationaxis-to-scale-in-1d-blendspace.html Change 3628108 by Arciel.Rekman Update Linux VHACD. - Also removed arm 32-bit version (the library is editor-only). Change 3628437 by Michael.Trepka Updated Mac VHACD libraries and Xcode project Change 3628667 by Lina.Halper - Fixed issue of showing combo box multiple times - Fixed issue of inconsistent combo box width - Fixed text of pick bone to "select" for more general instruction - Fixed issue with struct displaying children when pin is enabled #jira: UE-49295, UE-46496, UE-47427 Change 3629744 by Aaron.McLeran #jira UE-49383 Fix for source bus loading in sound waves and playing without audio mixer Change 3629846 by Aaron.McLeran #jira UE-49390 Required API change to spatialization interface for google Change 3630322 by Thomas.Sarkanen Fix right-click not displaying context menu for constraints correctly Selection logic was lightly broken #jira UE-49399 - Physics Asset Editor: Right-clicking constraints in the viewport does not bring up the context menu Change 3630463 by Martin.Wilson Remove accidently submitted debug code Change 3630523 by Jurre.deBaare Paint threshold and fill value and can be set to negative numbers #fix Added metadata and default values for cloth fill tool #jira UE-48352 Change 3632009 by Aaron.McLeran #jira UE-49470 Fix for iOS master volume not getting set Recent changes to master volume resulted in platforms which don't have a headroom value defined will not get their master volume updated. IOS doesn't have a headroom value set so the master volume is never set and the fade in is never triggered. Change 3632699 by Thomas.Sarkanen Fix crash undo-ing primitive regeneration while simullation is in progress & stopping simulation #jira UE-49283 - Editor crashes if you regenerate and manipulate a phys body, simulate, undo and then exit simulation Change 3633336 by James.Golding PR #3978: effect is the noun. affect is the verb (Contributed by cdietschrun) #jira UE-49324 Change 3634665 by Aaron.McLeran #jira UE-49538 Fixing param interpolation Change 3634922 by James.Golding Static analysis fix (PhysXCookHelper.cpp) Change 3634926 by James.Golding Fix HTML5 build (which builds with PhysX, but without APEX) Change 3636005 by Thomas.Sarkanen Constraint setup shortcuts are now undo-able Also fixed body-body collision as you couldnt undo this either. Added transaction and calls to Modify(). #jira UE-49484 - Shortcut for Swing1Motion (2, and 3) do not change physics asset state dirty. Change 3636018 by Thomas.Sarkanen Added back constraint shortcut to PhAT toolbar #jira UE-48859 - Constraint quick set buttons are missing in the new Physics Asset tool Change 3636086 by Martin.Wilson Fix for enabling Live Link plugin in Orion Change 3638367 by Thomas.Sarkanen Connection reporting is now more user-freindly in the physics asset editor graph view Expanded UEdGraphSchema API to allow for more specific feedback when dragging over a graph. Implemented node & pin feedback for physics asset graphs. Also fixed alignment of icon for drag feedback as it stretches with multi-line text. #jira UE-47984 - No node created when dragging off of Constraint node in Physics Asset Graph Change 3640144 by Aaron.McLeran #jira UE-49409 Attenuation focus audio tests on TM-AnimPhys on Cooked mac doesn't play any audio Fixing the recent optimization to not play active sounds in range. Code attempts to check if there's any possibility for a sound to have it's distance affected before trying to prune by max distance. Change 3640276 by Aaron.McLeran #jira UE-49606 Project does not cook with actors containing ModularSynth component Change 3640313 by Aaron.McLeran #jira UE-49675 Fixing shutdown of audio mixer - Final queued commands aren't getting pumped during audio mixer shutdown, added a new interface to get a final shutdown callback back to audio mixer device. We can do any cleanup or final shutdown tasks in this callback. Added a call to pump the source manager one last time. For cases of audio mixer running without audio plugins, this won't have much of an effect, but is a good thing to do anyway. For the case of audio plugins, who are depending on paired init and release calls, this is valueable to avoid memory leaks between subsequent PIE sessions. Change 3640941 by Martin.Wilson Add editor only animation loading debug data in the hope of diagnosing rare loading crash #jira UE-49335 Change 3641976 by Ethan.Geller #jira UE-49675 ensure that we pump both command queues Change 3642613 by James.Golding Add NoPhysX sample, for CIS testing compilation without PhysX Change 3644001 by Aaron.McLeran #jira UE-49805 looping sounds are, in rare cases, extremely loud Change 3644124 by Aaron.McLeran #jira UE-49787 [CrashReport] Mac crash - UE4Editor-AudioEditor.dylib!FSoundCueEditor::DeleteInput() Adding ensure on returned ptr to avoid crash but keep getting some logging. Change 3644157 by Aaron.McLeran Fixing build error Change 3644163 by Aaron.McLeran Fixing build error (for real) Change 3650331 by Aaron.McLeran #jira UE-49994 SoundMix Fade Time not fading audio properly Making sure we properly set passive mix modifier states. Change 3652648 by Aaron.McLeran #jira UE-49994 SoundMix Fade Time not fading audio properly Change 3652995 by Aaron.McLeran #jira UE-50053 Reduce log level of audio mixer debug category Turning down the log spam level of the underrun category by switching to debug category and reducing level of the debug category. Change 3653461 by James.Golding V-HACD updates from JohnR @ NVIDIA (adding new functions for future use) Change 3654056 by Aaron.McLeran Fixing an issue with caching node states for editor builds and adding optimization to cache if we should apply interior volumes. Change 3654579 by Aaron.McLeran Allow sound submixes and sound classes to be a blueprint type Made all properties of sound classes BlueprintReadOnly. Change 3662519 by James.Golding Merge CL 3575543 from //Fortnite/Main to Dev-AnimPhys Don't call into UpdateKinematicBones if there are no physx bodies Change 3664976 by Aaron.McLeran #jira UE-50175 New Tap Delay Submix Pan parameter does not work in Surround Sound Change 3665751 by Aaron.McLeran Adding a simple panner effect Change 3665851 by Aaron.McLeran Fixing naming convention for new panner source effect Change 3666894 by Thomas.Sarkanen Bone modifications via transform type-in can now be undone Added RF_Transactional & called Modify() #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3666919 by Lina.Halper Fixed equal operator for bonereference to work when not initialized Change 3668850 by Thomas.Sarkanen Skeleton tree now no longer allows selection of filtered items This fixes an issue where filtered-out constraints were being deselected after a select all operation because the tree thought it had no selection (all constraints were filtered). #jira UE-50200 - Constraint Details do not populate in the Details Panel if the Skeleton tree does not include Constraints Change 3669028 by James.Golding Fix CIS error after merge-down Change 3669053 by James.Golding Fix bad merge in SynthComponent.cpp Change 3669273 by Lina.Halper - delete all tracks option - allow to opt out on bone track importing - fixed pose preview for fullbody to select weights that has pose from asset. Change 3671396 by James.Golding Fix FSkelMeshComponentLODInfo cleaning up all override resources when it should only have been cleaning up one of them Change 3671701 by Martin.Wilson Maya Live Link plugin - Added UI to Maya - Display currently streamed subjects - Allow add and removal of streamed subjects - Display connection status to editor - Stream active camera as EditorActiveCamera - Refactored entire plugin so that streaming has a manager and streaming objects / interfaces - Reworked editor update hook so that streaming is more robust and facial rigs / leaf bones now correctly update. Change 3672170 by Lina.Halper Remove track support for Animation Blueprint Library Change 3675921 by Ethan.Geller Rollback invalidated check from copy down Change 3677606 by Martin.Wilson Add live link driven component - allows an actor to take its rotation and translation from a live link subject Change 3678594 by Lina.Halper Changed API name for clarification Change 3680913 by Ethan.Geller #jira UE-50750 fix stuttering on AudioMixer on MacOS Change 3681127 by Ethan.Geller #jira UE-50720 Fix invalidated audio clock time when audio device is unplugged on legacy audio engine Change 3682729 by Ethan.Geller #jira UE-50832 Fix for null concurrency settings when removing active sounds from a concurrency group. [Dev-AnimPhys] Change 3633185 by James.Golding Fix engine not compiling when WITH_PHYSX == 0 PR #3691: 4.16_WITH_PHYSX_optional (Contributed by JacobNelsonGames) PR #3695: 4.16_PhysXVehicles_WITH_PHYSX_optional (Contributed by JacobNelsonGames) Change 3637031 by Ethan.Geller #jira UE-49605 Platform Headroom fix for non-float devices. Change 3642598 by James.Golding Change bCompileNvCloth to use same pattern as bCompileAPEX (on by default, disabled on some platforms). This allows game projects to disable it. Change 3645224 by Martin.Wilson Fix for rare notify crash. For speed purposes Notify Queue caches a pointer to the notify, this is memory that is owned by the animation and if it gets garbage collected we have a pointer to invalid memory. This change caches a pointer to the owner of the notify memory to so we can track its validity. #jira UE-44869 Change 3668926 by James.Golding Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3668712 Change 3674824 by James.Golding Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3674368 [CL 3683447 by Thomas Sarkanen in Main branch]
2017-10-06 04:43:18 -04:00
if(!InViewportClient->IsCtrlPressed())
{
SharedData->ClearSelectedBody();
SharedData->ClearSelectedConstraints();
}
SharedData->SetSelectedConstraint(ConstraintProxy->ConstraintIndex, true);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
// Pop up menu, if we have a constraint selected.
if (SharedData->GetSelectedConstraint())
{
OpenConstraintMenu(InViewportClient);
}
return true;
}
else
{
OpenSelectionMenu(InViewportClient);
return true;
}
}
}
return false;
}
/** Helper function to open a viewport context menu */
static void OpenContextMenu(const TSharedRef<FPhysicsAssetEditor>& PhysicsAssetEditor, FEditorViewportClient* InViewportClient, TFunctionRef<void(FMenuBuilder&)> InBuildMenu)
{
FMenuBuilder MenuBuilder(true, PhysicsAssetEditor->GetToolkitCommands());
InBuildMenu(MenuBuilder);
TSharedPtr<SWidget> MenuWidget = MenuBuilder.MakeWidget();
TSharedPtr<SWidget> ParentWidget = InViewportClient->GetEditorViewportWidget();
if (MenuWidget.IsValid() && ParentWidget.IsValid())
{
const FVector2D MouseCursorLocation = FSlateApplication::Get().GetCursorPos();
FSlateApplication::Get().PushMenu(
ParentWidget.ToSharedRef(),
FWidgetPath(),
MenuWidget.ToSharedRef(),
MouseCursorLocation,
FPopupTransitionEffect(FPopupTransitionEffect::ContextMenu)
);
}
}
void FPhysicsAssetEditorEditMode::OpenBodyMenu(FEditorViewportClient* InViewportClient)
{
OpenContextMenu(PhysicsAssetEditorPtr.Pin().ToSharedRef(), InViewportClient,
[this](FMenuBuilder& InMenuBuilder)
{
PhysicsAssetEditorPtr.Pin()->BuildMenuWidgetBody(InMenuBuilder);
PhysicsAssetEditorPtr.Pin()->BuildMenuWidgetSelection(InMenuBuilder);
});
}
void FPhysicsAssetEditorEditMode::OpenConstraintMenu(FEditorViewportClient* InViewportClient)
{
OpenContextMenu(PhysicsAssetEditorPtr.Pin().ToSharedRef(), InViewportClient,
[this](FMenuBuilder& InMenuBuilder)
{
PhysicsAssetEditorPtr.Pin()->BuildMenuWidgetConstraint(InMenuBuilder);
PhysicsAssetEditorPtr.Pin()->BuildMenuWidgetSelection(InMenuBuilder);
});
}
void FPhysicsAssetEditorEditMode::OpenSelectionMenu(FEditorViewportClient* InViewportClient)
{
OpenContextMenu(PhysicsAssetEditorPtr.Pin().ToSharedRef(), InViewportClient,
[this](FMenuBuilder& InMenuBuilder)
{
PhysicsAssetEditorPtr.Pin()->BuildMenuWidgetSelection(InMenuBuilder);
});
}
bool FPhysicsAssetEditorEditMode::SimMousePress(FEditorViewportClient* InViewportClient, FKey Key)
{
FViewport* Viewport = InViewportClient->Viewport;
bool bCtrlDown = Viewport->KeyState(EKeys::LeftControl) || Viewport->KeyState(EKeys::RightControl);
bool bShiftDown = Viewport->KeyState(EKeys::LeftShift) || Viewport->KeyState(EKeys::RightShift);
FSceneViewFamilyContext ViewFamily(FSceneViewFamily::ConstructionValues(Viewport, InViewportClient->GetScene(), InViewportClient->EngineShowFlags));
FSceneView* View = InViewportClient->CalcSceneView(&ViewFamily);
const FViewportClick Click(View, InViewportClient, EKeys::Invalid, IE_Released, Viewport->GetMouseX(), Viewport->GetMouseY());
FHitResult Result(1.f);
bool bHit = SharedData->EditorSkelComp->LineTraceComponent(Result, Click.GetOrigin(), Click.GetOrigin() + Click.GetDirection() * SharedData->EditorOptions->InteractionDistance, FCollisionQueryParams(NAME_None, true));
SharedData->LastClickPos = Click.GetClickPos();
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
SharedData->LastClickOrigin = Click.GetOrigin();
SharedData->LastClickDirection = Click.GetDirection();
SharedData->bLastClickHit = bHit;
if (bHit)
{
SharedData->LastClickHitPos = Result.Location;
SharedData->LastClickHitNormal = Result.Normal;
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
if (bHit)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
check(Result.Item != INDEX_NONE);
FName BoneName = SharedData->PhysicsAsset->SkeletalBodySetups[Result.Item]->BoneName;
UE_LOG(LogPhysics, Log, TEXT("Physics Asset Editor Click Hit Bone (%s)"), *BoneName.ToString());
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
if(bCtrlDown || bShiftDown)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
{
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
// Right mouse is for dragging things around
if (Key == EKeys::RightMouseButton)
{
SharedData->bManipulating = true;
DragX = 0.0f;
DragY = 0.0f;
SimGrabPush = 0.0f;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
// Update mouse force properties from sim options.
SharedData->MouseHandle->LinearDamping = SharedData->EditorOptions->HandleLinearDamping;
SharedData->MouseHandle->LinearStiffness = SharedData->EditorOptions->HandleLinearStiffness;
SharedData->MouseHandle->AngularDamping = SharedData->EditorOptions->HandleAngularDamping;
SharedData->MouseHandle->AngularStiffness = SharedData->EditorOptions->HandleAngularStiffness;
SharedData->MouseHandle->InterpolationSpeed = SharedData->EditorOptions->InterpolationSpeed;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
// Create handle to object.
SharedData->MouseHandle->GrabComponentAtLocationWithRotation(SharedData->EditorSkelComp, BoneName, Result.Location, FRotator::ZeroRotator);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
FMatrix InvViewMatrix = View->ViewMatrices.GetInvViewMatrix();
SimGrabMinPush = SimMinHoldDistance - (Result.Time * SharedData->EditorOptions->InteractionDistance);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3759273) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3722141 by Aaron.McLeran #jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager. - Will allow for sequencer recorder to record multiple audio streams, one for each actor Change 3726096 by Ori.Cohen Fixed welded bodies with negative scale not using the mirrored convex hull #jira UE-51647 Change 3726233 by Ori.Cohen Make sure RT doesn't try to create a physics mesh when debug drawing #jira UE-51721 Change 3726254 by Aaron.McLeran Fixing typo in GetCustomSpatializationSettingsClass interface Change 3728295 by Ori.Cohen Fix incorrect lock upgrading Change 3728516 by Benn.Gallagher Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints. #jira UE-51414 Change 3728522 by Benn.Gallagher Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes. #jira UE-50087 Change 3728853 by Benn.Gallagher [NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat. Change 3729031 by Ethan.Geller #jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation. Change 3729910 by Benn.Gallagher Fix for crashes editing destructible meshes caused by stale render data Change 3729921 by James.Golding - Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead - Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets - Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well - Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors - Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors - Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh - Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport #jira UEAP-167 Change 3730054 by Martin.Wilson Live Link: Add ability for sources to define their own settings Change 3730134 by Jurre.deBaare Editor crashes when opening animcompression setting on an alembic file #jira UE-51840 #fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import #misc cleaned up comment Change 3730428 by Thomas.Sarkanen Fix copy/paste in the physics asset editor When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations. Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling. Also allow multi-paste of constraints/bodies. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730464 by Thomas.Sarkanen Fixed copy/paste not working when the skeleton tree has focus The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected. #jira UE-51803 - Copy/paste doesn't work correctly in PhAT Change 3730511 by Jurre.deBaare Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313] #jira UE-48988 Change 3730685 by Benn.Gallagher Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered. #jira UE-51508 Change 3731560 by Aaron.McLeran Removing gaurd on spatialization plugin settings and renaming enumerations Change 3731714 by Ori.Cohen Added the ability to profile scene query hitches. Change 3731725 by Ori.Cohen Change scene query hitch threshold to 50us by default Change 3731770 by Ethan.Geller Fix signed/unsigned comparison. Change 3731777 by Ethan.Geller Suppress static analysis warning. Change 3732145 by Thomas.Sarkanen [Duplicated from 4.18.1] Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB Also fixed a selection issue that was exposed when this crash was fixed, #jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate Change 3732176 by Thomas.Sarkanen Fixed hang when selecting all bodies or constraints in a physics asset Implements a better fix for CL 3721129 #jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset Change 3732177 by Thomas.Sarkanen Fix crash when pasting properties in Physics Asset Editor Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range. #jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies Change 3732492 by Martin.Wilson Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging #Jira UE-51794 Change 3732672 by Thomas.Sarkanen Refactor view menus in animation editors Moves show menu and buffer visualizations into a new CommonMenuExtensions module. Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name. All character-specific stuff is now in a "Character" menu. Original changes by Jonathan.Poncelet #jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports Change 3732860 by Thomas.Sarkanen Fix CIS errors/warnings Change 3732877 by Thomas.Sarkanen Fix missing Physics menu Merge error on my part Change 3733113 by Ori.Cohen Fix CIS Change 3734859 by Thomas.Sarkanen Fix crash when opening a physics asset that uses a preview mesh with no skeleton #jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81] Change 3736693 by Ethan.Geller Added ability for submixes to define their own channel format. Written by aaron.mcleran Change 3737943 by James.Golding Fix crash when right-clicking during section selection in skel mesh tools #jira UE-51873 Change 3738337 by Benn.Gallagher Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices. #jira UE-51921 Change 3738404 by Lina.Halper Add comment for bImportBoneTrack option in FBX importer Change 3738816 by Benn.Gallagher Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren) Change 3738960 by Ethan.Geller Fix Linux compiler errors for implicit enum casting Change 3739214 by Lina.Halper - Removed unnecessary Initialize - Make sure invalidate the other part if not used (socket->bone or bone->socket) #jira: UE-51931 Change 3739215 by Lina.Halper compile error - added one more ) when pasted to the other line Change 3739442 by Lina.Halper pose asset crash when skeleton changes #jira: UE-52036 Change 3739795 by Ethan.Geller fix linux build with implicit enum class casts, pt 2 Change 3740553 by James.Golding Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint #jira UE-47566 Change 3740560 by James.Golding - Don't rebuild render data on SkeletalMesh interactive property changes - Remove unnecessary render resource release in SkeletalMesh PreEditChange #jira UE-51652 Change 3740562 by James.Golding Extensibility improvements to PhysicsAssets (from NVIDIA) Change 3740563 by James.Golding PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster) #jira UE-50546 Change 3740564 by James.Golding PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc) #jira UE-51761 Change 3740587 by Benn.Gallagher CIS fixes for non-cloth platforms and initialization order fix Change 3740658 by Thomas.Sarkanen Update cloth appropriately in the physics asset editor When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation. Reset simulation when making more 'major' potential changes (adding/removing collision etc.) Optionally reset cloth when simulation starts/stops in the physics asset editor #jira UE-50949 - Phat Editor with cloth collisions #jira UE-48779 - Ability to reset clothing during physics simulation #jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth Change 3743354 by Benn.Gallagher CIS Fix Change 3743419 by Thomas.Sarkanen Preview buttons are now present where applicable Preview mesh button reordered to be consistent with other anim editors. Preview animation re-instated where applicable. Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout #jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons Change 3743529 by Thomas.Sarkanen Moved constraint and physical anim profile indicators to the top of the details panel Indicators now show assignment status. #jira UE-50895 - Constraint Profiles requests Change 3743604 by Jurre.deBaare Duplicating from 4.18.1: [CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951] #fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well #jira UE-51917 Change 3743757 by Lina.Halper Adding more ensure to detect NaN Change 3743791 by Ori.Cohen Fix CIS and stack size issues Change 3744008 by Benn.Gallagher Gravity override support for clothing interactor. #jira UE-51014 Change 3744439 by Michael.Karambelas Updating and investigating CableActor automation tests Change 3744566 by Martin.Wilson Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded. #jira UE-49335 Change 3745963 by Martin.Wilson Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time #Jira UE-52044 Change 3748585 by Aaron.McLeran Fixing crash when loading editor with synth components. Change 3749071 by Aaron.McLeran Fixing ambisonics submix format Change 3749969 by Danny.Bouimad Updating TM-AnimPhys to be more performant on Switch Change 3750103 by Danny.Bouimad Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052) Change 3754465 by Ethan.Geller Fixing panning in audio mixer after submix format feature Change 3755637 by Lina.Halper Back out changelist 3739214 - still add back invalidation #jira: UE-52159 Change 3756385 by Lina.Halper - Adding ground truth for the cable component test map - Disabled first test as it has BP none access warning #jira: UE-52370 Change 3756707 by Ethan.Geller fix potential mem leak in mixer source Change 3757148 by Aaron.McLeran Fixing surround sound bugs due to recent changes to submix format. Change 3757583 by Aaron.McLeran Fix cook with synth component Change 3758477 by Danny.Bouimad Fixing Disabled cable actor test, checking in screenshots for a disabled test. Change 3758873 by Ethan.Geller #jira UE-52389 Remove assert on getting a hash for a unique net id. [CL 3759284 by Marc Audy in Main branch]
2017-11-15 16:13:28 -05:00
SimGrabLocation = Result.Location;
SimGrabX = InvViewMatrix.GetUnitAxis(EAxis::X);
SimGrabY = InvViewMatrix.GetUnitAxis(EAxis::Y);
SimGrabZ = InvViewMatrix.GetUnitAxis(EAxis::Z);
}
// Left mouse is for poking things
else if (Key == EKeys::LeftMouseButton)
{
SharedData->EditorSkelComp->AddImpulseAtLocation(Click.GetDirection() * SharedData->EditorOptions->PokeStrength, Result.Location, BoneName);
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
}
// @todo(ccaulfield): really this should return false if we don't have Ctrl or Shift help down. This would allow the mouse-fly
// behaviour to work even when clicking on a space occupied by a body. However we don't want to change this until we have a way
// to enable/disable the fly and orbit camera behaviours.
return bHit;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
void FPhysicsAssetEditorEditMode::SimMouseMove(FEditorViewportClient* InViewportClient, float DeltaX, float DeltaY)
{
DragX = InViewportClient->Viewport->GetMouseX() - SharedData->LastClickPos.X;
DragY = InViewportClient->Viewport->GetMouseY() - SharedData->LastClickPos.Y;
if (!SharedData->MouseHandle->GrabbedComponent)
{
return;
}
//We need to convert Pixel Delta into Screen position (deal with different viewport sizes)
FSceneViewFamilyContext ViewFamily(FSceneViewFamily::ConstructionValues(InViewportClient->Viewport, SharedData->PreviewScene.Pin()->GetScene(), InViewportClient->EngineShowFlags));
FSceneView* View = InViewportClient->CalcSceneView(&ViewFamily);
FVector4 ScreenOldPos = View->PixelToScreen(SharedData->LastClickPos.X, SharedData->LastClickPos.Y, 1.f);
FVector4 ScreenNewPos = View->PixelToScreen(DragX + SharedData->LastClickPos.X, DragY + SharedData->LastClickPos.Y, 1.f);
FVector4 ScreenDelta = ScreenNewPos - ScreenOldPos;
FVector4 ProjectedDelta = View->ScreenToWorld(ScreenDelta);
FVector4 WorldDelta;
//Now we project new ScreenPos to xy-plane of SimGrabLocation
FVector LocalOffset = View->ViewMatrices.GetViewMatrix().TransformPosition(SimGrabLocation + SimGrabZ * SimGrabPush);
float ZDistance = InViewportClient->GetViewportType() == ELevelViewportType::LVT_Perspective ? FMath::Abs(LocalOffset.Z) : 1.f; //in the ortho case we don't need to do any fixup because there is no perspective
WorldDelta = ProjectedDelta * ZDistance;
//Now we convert back into WorldPos
FVector WorldPos = SimGrabLocation + WorldDelta + SimGrabZ * SimGrabPush;
FVector NewLocation = WorldPos;
float QuickRadius = 5 - SimGrabPush / SimHoldDistanceChangeDelta;
QuickRadius = QuickRadius < 2 ? 2 : QuickRadius;
DrawDebugPoint(GetWorld(), NewLocation, QuickRadius, FColorList::Red, false, 0.3);
SharedData->MouseHandle->SetTargetLocation(NewLocation);
SharedData->MouseHandle->GrabbedComponent->WakeRigidBody(SharedData->MouseHandle->GrabbedBoneName);
}
bool FPhysicsAssetEditorEditMode::SimMouseRelease()
{
SharedData->bManipulating = false;
if (!SharedData->MouseHandle->GrabbedComponent)
{
return false;
}
SharedData->MouseHandle->GrabbedComponent->WakeRigidBody(SharedData->MouseHandle->GrabbedBoneName);
SharedData->MouseHandle->ReleaseComponent();
return true;
}
bool FPhysicsAssetEditorEditMode::SimMouseWheelUp(FEditorViewportClient* InViewportClient)
{
if (!SharedData->MouseHandle->GrabbedComponent)
{
return false;
}
SimGrabPush += SimHoldDistanceChangeDelta;
SimMouseMove(InViewportClient, 0.0f, 0.0f);
return true;
}
bool FPhysicsAssetEditorEditMode::SimMouseWheelDown(FEditorViewportClient* InViewportClient)
{
if (!SharedData->MouseHandle->GrabbedComponent)
{
return false;
}
SimGrabPush -= SimHoldDistanceChangeDelta;
SimGrabPush = FMath::Max(SimGrabMinPush, SimGrabPush);
SimMouseMove(InViewportClient, 0.0f, 0.0f);
return true;
}
void FPhysicsAssetEditorEditMode::ModifyPrimitiveSize(int32 BodyIndex, EAggCollisionShape::Type PrimType, int32 PrimIndex, FVector DeltaSize)
{
check(SharedData->GetSelectedBody());
FKAggregateGeom* AggGeom = &SharedData->PhysicsAsset->SkeletalBodySetups[BodyIndex]->AggGeom;
if (PrimType == EAggCollisionShape::Sphere)
{
check(AggGeom->SphereElems.IsValidIndex(PrimIndex));
AggGeom->SphereElems[PrimIndex].ScaleElem(DeltaSize, MinPrimSize);
}
else if (PrimType == EAggCollisionShape::Box)
{
check(AggGeom->BoxElems.IsValidIndex(PrimIndex));
AggGeom->BoxElems[PrimIndex].ScaleElem(DeltaSize, MinPrimSize);
}
else if (PrimType == EAggCollisionShape::Sphyl)
{
check(AggGeom->SphylElems.IsValidIndex(PrimIndex));
AggGeom->SphylElems[PrimIndex].ScaleElem(DeltaSize, MinPrimSize);
}
else if (PrimType == EAggCollisionShape::Convex)
{
check(AggGeom->ConvexElems.IsValidIndex(PrimIndex));
FVector ModifiedSize = DeltaSize;
if (GEditor->UsePercentageBasedScaling())
{
ModifiedSize = DeltaSize * ((GEditor->GetScaleGridSize() / 100.0f) / GEditor->GetGridSize());
}
AggGeom->ConvexElems[PrimIndex].ScaleElem(ModifiedSize, MinPrimSize);
}
else if (PrimType == EAggCollisionShape::TaperedCapsule)
{
check(AggGeom->TaperedCapsuleElems.IsValidIndex(PrimIndex));
AggGeom->TaperedCapsuleElems[PrimIndex].ScaleElem(DeltaSize, MinPrimSize);
}
else if (PrimType == EAggCollisionShape::LevelSet)
{
check(AggGeom->LevelSetElems.IsValidIndex(PrimIndex));
AggGeom->LevelSetElems[PrimIndex].ScaleElem(DeltaSize, MinPrimSize);
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3624379) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3536809 by Ben.Marsh Fixing case of files in "iOS" directory, pt 1. Change 3536814 by Ben.Marsh Fixing case of files in "iOS" directory, pt 2. Change 3596207 by Thomas.Sarkanen Copying //Tasks/UE4/Dev-UEAP-29-PhATUpgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3590250 PhAT Upgrade #jira UEAP-29 - New PhysicsAsset editor Changelists from task stream: Change 3380649 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Initial pass at allowing viewports to be extended more easily, still plenty TOD, but just unearthing this old shelf and getting it working. This gets the Persona skeleton tree and viewport into PhAT, without any PhAT functionality added. Change 3380685 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renaming PhAT files to PhysicsAssetEditor Change 3380749 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rename PhAT -> PhysicsAssetEditor Change 3380832 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up PhAT to Physics Asset Editor Change 3380884 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Reverted some over-zealous renaming Change 3380970 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked ISkeletonTreeBuilder interface to make way for actually making a derived class of it Added the ability to hide filter menus to skeleton tree Change 3381017 on 2017/04/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added new physics asset skeleton tree builder Change 3384407 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree extensions to support physics assets Only started this work - still much to do Change 3384460 on 2017/04/07 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged persona viewport menus Change 3392222 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed body/constraint modes. Added graph editor Added edit mode - moved viewport client code over Got PhAT skel mesh rendering in viewport Change 3392268 on 2017/04/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Increased hit proxy priority to improve selection Change 3401648 on 2017/04/20 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Skeleton tree gets bodies & shapes back. Selection works in graph, now displaying the correct constraint in the detials panel. Still need to add selection from viewport. Added multi-select to bone proxy customization Re-tweaked editor layout Change 3403701 on 2017/04/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection sync work. Customization of anim viewport menus. Context menus for physics asset items, as well as masking of various context menu items via settings. Change 3405246 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Started more work on viewport menu extensions, but need to refactor the toolbar system to use actual multiboxes. Up next! Change 3405274 on 2017/04/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen More viewport menu fixups (plus deleting duplicate functionality). Change 3409155 on 2017/04/26 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Got simulation working again - as we switched to the debug skel mesh comp, the normal tick path didnt work for post-blend physics (it tried to flip the buffer too early). Also tweaked debug skel mesh comp root motion consumption code to not reset transfor every frame if we are not using root motion. Cleaned up unused files & code Change 3410814 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Allow extensibility of viewport menu bars Slate changes: Allow menu bars to optionally specify an icon to use. This is intended to allow us to move viewport tool/menu bars over to use multibox, with all the attendant features and extension points. Allow menu bars to optionally invert-on-hover. Allow styling of menus to affect closed appearance of menu header. Previously only NoBorder was used. Adjusted core styling of menu bar elements. Other changes: Adjusted padding for various UI elements to preserve previoud behavior. Adjusted SAnimViewportToolbar to use the new menu bar builder. Exposed SEditorViewportViewMenu so that it can be used in a standard menu bar. Change 3410816 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added extension point to viewport menu bar Change 3410818 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Getting sim working again Moved over to using preview instance so we share functionality with Persona editors. Added time dilation options to persona preview scene. Removed PhAT specific recording functionality (it is in the viewport now). Change 3410840 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Recreate physics state on edit, not sim start This allows velocity to be inherited when simulation is started Change 3410863 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moving viewport to continually-invalidated one like animation editors Fixed crash in non-extended viewport toolbars Change 3410936 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bodies start off non-expanded Selection now synced between viewport and graph Constraint selection in graph not works on the first try Change 3410943 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added missing icon Change 3410966 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed shape listing from graph nodes Change 3411013 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Double click on body node recenters graph Fixed graph disappearing on right-click Change 3411111 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented cursor getting swallowed in sim mode Change 3411126 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed overlapping text Change 3411213 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Node layout now takes dimensions into account Change 3411320 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash opening Persona editors Renamed file Change 3411327 on 2017/04/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to profiles menu Change 3420822 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Profiles can now be edited in their own details panel Existing customizations folded into the new panel Tweaks to toolbar Added the ability for the persona details panel to have extra top/bottom content added Change 3420832 on 2017/05/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Add profile control to context menus Also delete old unused code Change 3422651 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Toolbar trimmed down & re-ordered Body/constraint ops moved to context menus Apply physmat now a context-menu option with an asset picker Change 3422654 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed extra warning dialog when auto-creating bodies Changed title of new asset dialog to "auto-create bodies" Change 3422680 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix "simulate selected" As we dont re-init the physics state each time we start simulating, our tweaked physics type was never applied. We now manually do this in the editor. Change 3422937 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Replaced EKCollisionPrimitiveType with EAggCollisionShape::Type Fixed up selection so body selection works & tree seleciton is properly synced with viewport Added recursion guard to selection delegate handlers. Removed vestigial instance property editing support (no longer needed). Removed unused old tree support code Change 3423034 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added constraints to tree Change 3423318 on 2017/05/04 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix bone proxiies stopping updating after initial viewport selection Change 3424993 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up selection issues when creating new bodies Added constraint context menu Change 3424998 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved icons to central location Change 3425445 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Customized filtering of the skeleton tree Hide constraints by defualt Added option to hide parents when filtering (so the vertical space is nto wasted, but some idea of hierarchy is preserved). BREAKING CHANGE: changed skeleton tree filtering API to add args & removed bWillFilter bool. Change 3425488 on 2017/05/05 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3425303 Change 3427886 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved physics sim options to viewport menu (so seleciton changing is not required to change them) Moved physics-related rendering options to show menu We no longer switch to sim options when nothing is selected. During simulation we now disable the details panel Constraint scaling now works correctly (rather than just scaling the screen size limit that axes only are rendered) Change 3428040 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Small fixes based on feedback: Exposed Mirror tool to menus Exposed constraint quick actions to menus Added edit condition to Position & Velocity strength for physical animation Fixed up some tooltips & display names Change 3428143 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Defaulted to constraints as points Change 3428216 on 2017/05/08 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Request from Nick D: Update in-level primitive transforms immediately, rather than on mouse up. We only do this for non-convex primitives however, to avoid re-cooking meshes. Change 3430326 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaks to rendering of constraints and shapes to allow for better seleciton & interaction with editor widgets. Slightly increased point-constraint rendering size and added crosshair cursor to constraints Change 3430327 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed object-reuse issue in skeleton tree items with sanem names (use a GUID instead) Change 3430391 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed duplicate time dilation (can just use viewport menu!) Change 3430419 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge Prevent crash by attaching to root component in the correct place Add IWYU include for TArrayView Remove more unused code Change 3430443 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix constraint/body selection one final time Move constraint drawing to SDPG_World (apart from point mode) Remove depth offset in material Change 3430495 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enabling/disabling collision between bodies is now clearer Menu items are now enabled and disabled correctly depending on collision state Tooltip reflects what actually gets done when the operation is enacted Also corrected a few functions that still reference constraint & body mode Change 3430553 on 2017/05/09 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added enable/disable collision with all Change 3432386 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code graph items based on current profile Change 3432401 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Color code tree items too Change 3432418 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Bone selection & manipulation now possible - allows for pose setup before simulation Item expansion now expands leaf nodes when selecting - helps with constraint selection etc. Change 3432427 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix compile error Color code according to simulated/kinematic status Change 3432428 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen File i missed Change 3432540 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added physics asset factory so physics assets can be created form the "new asset" menu. Skeletal mesh is picked then a defualt asset is generated Change 3432556 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Improve interactions with bones & bodies Clear bone selection when selecting bodies/constraints Always hide gizmo in simulate Change 3432703 on 2017/05/10 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused selection lock feature Fixed selection working incorrectly with details panel closed Change 3434710 on 2017/05/11 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selection improvements Multiselect in tree now only selects non-collapsed tree elements Selection API revamped in shared data, so multiselect of constraints can work correctly (they appear more than once in the tree, so the preivous single-point-of-access API was insufficent). Change 3489030 on 2017/06/14 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3488994 Change 3491459 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup post-merge issues Change 3491486 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Simulation now works in a simlar way to the level editor Only on 'simulate' button, which controls repeating the last simulation (be it selected or not). Options are on a dropdown. Change 3491529 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed selection color of wireframe drawing (this broke ages ago!) Fixed initialized environment color/intensity Change 3491537 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked materials so they dont repend on seperate translucency (which is optional, and disabled currently) Change 3491791 on 2017/06/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when simulating selected new bodies Make sure we recreate physics state appropriately (it used to be done on simulation start, so wasnt needed each time) Change 3494359 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Select all is now a menu option Context menu pops when right-clicking nothing now too Menu no longer grows enormous when multiple types of objects are selected Change 3494373 on 2017/06/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Enlarged constraint rendering size Show constraints (rather than points) by default Change 3511708 on 2017/06/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Assets now appear in the asset family shortcut bar Physics Assets now render thumbnails Skeleton tree can now work in 'picker' mode Constraints can now be created manually in the graph, tree and viewport Fixed double-click and mousewheel not working right sometimes Change 3513121 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed clicks incorrectly selecting bones in simulate mode Change 3513160 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics Asset config is now loaded/saved Fixed antoher corner case with viewport clicks in sim Change 3513540 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved body creation params over to a details panel & settings object Moved initial creation dialog over to use the new system too Change 3513591 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Renamed shapes and constraints in the tree view Change 3513752 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Constraints are now not filtered by default Change 3513797 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Selecting constraints now shows them (and the bodies involved) in the graph Change 3513859 on 2017/06/28 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed "Show Kinematic Bodies" We now always show kinematic status in simulate mode Change 3515732 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen PhAT rendering settings are now persisted across sessions. Access to sim/edit settings is now not gated on state of the editor. Sim/edit settings are always both available. Added editable opacity to collision rendering. Change 3515735 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen New materials with opacity parameter Change 3515757 on 2017/06/29 by thomas.sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Re-saved materials Change 3515759 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added ability to only show selected bodies as solid Change 3515812 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix focus 'F' shortcut sometimes not working Change 3515984 on 2017/06/29 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix a bunch of selection issues with the graph not keeping in sync Change 3517456 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3516853 Change 3517514 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed disappearing convex meshes on simulate Also fixes crash in thumbnail rendering Change 3517556 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled selection on mesh. Fixes selection issues. Also made the hit proxy use a crosshair when over bodies, for easier selection Change 3517642 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added body/body collision buttons back to the main toolbar Fixed solid body drawing using the wrong material when no bodies are selected Change 3517828 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix delete shortcut not working when tree is focused Change 3517927 on 2017/06/30 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Integrated per-bone primitive generation with the new tab method Removed context menu item for bones (fixes duplicate popup) Fixed undo/redo not working for regenerating all bodies Change 3519931 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled body regeneration when simulation is running Fixed up tab icons Change 3519978 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Preview mesh is now set like every other Persona editor (via toolbar picker of via preview scene settings) Animation picker removed from toolbar (we use the preview scene settings for this now) Fixed profiles tab icon Change 3519982 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Show attached assets in tree Change 3519995 on 2017/07/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix broken multi-selection of bone proxies Change 3532799 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed code that prevented parts of the UI (like simulation) from working in PIE Removed graph overlays & added "PHYSICS" label Change 3532837 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed arrows from graph Fixed dragging off constraints/input pins/bodies in constraint-created graphs Constraint names now include both bodies Change 3532880 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched from colors to icons in the skeleton tree Removed bold fonts Change 3532907 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Layout fixes Added border around generate button in tools panel Removed skeleton tree header in contexts where it is not needed Change 3532932 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added slow task dialog for body generation Change 3532992 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged context menus to be not so huge Change 3533134 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Rearranged menus some more Change 3533135 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Colorized details customization of swing/twist items Change 3533174 on 2017/07/12 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Auto-open assets when creating from skeletal mesh Tweaked tooltip on suggestion from Nick D Change 3535652 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed mirroring changes not showing up straight away Change 3535731 on 2017/07/13 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved over to Persona-style floor adjustment Change 3539689 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Tweaked tooltips for filtering items Change 3539693 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added "deselect all" option (Esc) Change 3539731 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Graph selection tweaks Selected bodies in the viewport/tree are now also selected in the graph. Selection outline is now matched to the graph outline instead of using default outline. Pin allocation no longer happens twice Change 3539750 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Switched simulate shortcut to Alt+Enter Avoids conflict with clobal PIS/SIE shortcuts Change 3539933 on 2017/07/17 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Minor body regeneration refactor Label for tools tab button is dynamic depending on selection context Generation setttings are now re-used by creation dialog too Added in per-bone and per-body regeneration menu items. Bone regeneration now deletes the old body(s) instead of aborting Change 3543884 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Resetting animation to default now correctly applies the animation Change 3544101 on 2017/07/19 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed up physics asset editor's use of debug skel mesh component This broke post-merge from Dev-AnimPhys. Kinda hacky, but we need to double-flip the buffers in this case as we want to force non-threaded work AND also wait on the physics tick group to complete (to blend in physics). This also requires making ShouldBlendPhysicsBones protected, otherwise the buffers are never flipped in the non=simulating case (before simulation is enabled in the physics asset editor). Change 3547893 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Moved code to add/remove/assign/unassign profiles to details customization Also allowed dupication again (via the menu) Allows correct naming of new profiles as before (as this is handled in PostEdit) #jira UE-47448 - Deleting profiles in Physics Asset Editor does not update the current profile #jira UE-47514 - Unable to duplicate profiles in Physics Asset Editor #jira UE-47384 - New profiles in Physics Asset Editor are all named the same #jira UE-47375 - Physics Asset Editor 'None' current profile Delete option is available #jira UE-47378 - Current Profile name boxes in Physics Asset Editor are size limited and overlap buttons if too long #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3547925 on 2017/07/21 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevented ctrl+selection of constraints from re-selecting Avoided defered broadcast of seleciton event from the graph #jira UE-47515 - Ctrl + click and Shift + click does not remove constraints from skeleton tree in Physics Asset Editor Change 3550332 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed bodies incorrectly simulating outside of 'simulate' mode Forced all bodies to be non-simulated when simulation is disabled. Also removed non-functioning motor menu options & disabled more menu options when simulating #jira UE-47579 - Entire mesh rotates uncontrollably after rotating a simulated body in Physics Asset Editor Change 3550355 on 2017/07/24 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when failing to create a physics asset with multi convex hull #jira UE-47590 - Crash when New Physics Asset window is closed with no asset being created Change 3558007 on 2017/07/27 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed typo that disabled editability of profile names incorrectly #jira UE-47374 - Physics Asset Editor 'None' current profile text box is editable but doesn't save Change 3566157 on 2017/08/01 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed crash when opening a physics asset with a deleted preview skeletal mesh Now assigns default mesh as before If the mesh is then reset, the asset editor must be re-opened as the skeleton will have changed underneath it. #jira UE-47918 - Crash when opening certain Physics Assets Change 3568327 on 2017/08/02 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Prevent "set bodies below" from improperly enabling simulation on bodies #jira UE-47752 - Set all bodies below to simulated causes the viewport to simulate those bodies immediately in Physics Asset Editor Change 3570436 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics assets with simulated bodies no longer simulate when first opened #jira UE-48000 - Physics assets with simulated bodies begin simulating when first opened Change 3570470 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix excessive gravity crash when actors pop out of the world Also restrict gravity to non NaN-causing levels. #jira UE-48002 - Crash when mesh falls out of world due to high gravity simulation in Physics Asset Editor Change 3570717 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3570581 Change 3570781 on 2017/08/03 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix merge issues Change 3587760 on 2017/08/15 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed delegate for skeleton tree context menu extension, now uses an empty section Change 3589915 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Added comments to bone proxy & physics asset editor shared data Removed unused variables Change 3589976 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixed constraint 'all positions' rendering Removed empty override of unregister tab spawners Change 3589983 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fix crash when setting skeletal mesh Toast is not displayed when the skeleton is changed as well as the skeletal mesh. Toolkit was getting invalidated as setting the preview mesh to a different skeleton ends up restarting the sub-editor #jira UE-48196 - Crash when changing preview mesh of Physics Asset and applying Change 3589990 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Physics asset selection color now uses editor settings Change 3589994 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused functions Change 3589997 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Commented SetBodiesBelowPhysicsType as per code review Change 3590007 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Disabled physical material menu in simulate Change 3590130 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Removed unused code Commented a few functions Re-instated preview mesh selection Removed delegate allowing viewport client class creation Change 3590154 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Remove unused code Change 3590197 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Merge-Thomas.Sarkanen Merging //UE4/Dev-AnimPhys to Dev-UEAP-29-PhATUpgrade (//Tasks/UE4/Dev-UEAP-29-PhATUpgrade) @ CL 3589965 Change 3590250 on 2017/08/16 by Thomas.Sarkanen@Dev-UEAP-29-PhATUpgrade-Thomas.Sarkanen Fixup merge errors Change 3596227 by Jonathan.Poncelet Fixed physics substepping interpolation using the wrong starting value. #jira UE-48150 Physics Substepping doesn't have the same effect from 4.15 to 4.16 Change 3596241 by Jonathan.Poncelet Fixed cloth not being drawn correctly in the editor, due to bounds not being computed accurately. #jira UE-48243 Clothing disappears during cloth paint mode once you navigate to a section far from the origin Change 3596247 by Thomas.Sarkanen Fixup CIS errors post PhAT Upgrade merge Change 3596250 by Thomas.Sarkanen More CIS fixes Change 3596255 by Benn.Gallagher Fixed compilation errors when nativizing animation blueprints that use subinstances #jira UE-46522 Change 3596256 by Benn.Gallagher Fixed orphaned sub anim instance pins hanging around #jira UE-46545 Change 3596257 by Benn.Gallagher Fixed skel surf particles being misplaced when clothing was active. And fixed particles spawning on disabled cloth proxy sections. #jira UE-48045 Change 3596258 by Benn.Gallagher Hide mass override when selecting skeletal meshes. Mass overrides are taken from physics asset and will be ignored on the component so it makes no sense to have this visible #jira UE-47755 Change 3596259 by Benn.Gallagher Fixed mismatch between paint values and view values for clothing tools #jira UE-48110 Change 3596260 by Benn.Gallagher Stopped property context menus killing the whole window stack when an item is clicked #jira UE-48158 Change 3596261 by Thomas.Sarkanen One last Mac CIS fix (hopefully) Change 3596308 by Benn.Gallagher Removed outdated references to APEX in clothing example map. Change 3596360 by Martin.Wilson Fixing inconsistent animation entries in blueprint context menu (displaying differently depending on whether the asset is loaded) + Cache correct tooltip when asset isn't loaded #jira UE-48452 Change 3596459 by Benn.Gallagher Fixed anim curves not correctly being updated to post process instances. Change made to curve update in Dev-General fixed main and sub instances but missed post process instances. #jira UE-47567 Change 3596967 by Aaron.McLeran Adding setting default reverb send level in audio settings. Change 3596974 by Ethan.Geller Merge in fix from Christopher Oliver Change 3597243 by Aaron.McLeran Checking in missing files. Change 3597686 by Ethan.Geller Fix warnings/errors from CL 3597452 Change 3597846 by Ethan.Geller Fix errors, take 2 Change 3598290 by Ethan.Geller Panning Angle Issue Change 3598412 by Ethan.Geller Change Core.h header to CoreMinimal.h, fix warnings Change 3599797 by Jurre.deBaare LODs from Merge Actor tool have bad normals #jira UE-47129 #fix normals weren't wrong but user was complaining about the lightmap resolution behaviour, so added a new feature that calculates the lightmap resolution according to: 1) Summing all lightmap pixel counts for each mesh component being merged 2) Calculating fitting texture dimension by taking square root of the total pixels Change 3599863 by Lina.Halper PR #3919: rename flag 'DEPERCATED_PHYSBLEND_UPDATES_PHYSX' to 'DEPRECATED_PHYSBLEND_UPDATES_PHYSX' to fix the typo (Contributed by aziot) Change 3599883 by Jurre.deBaare HLOD: update outliner tooltip when UE docs arrive #jira UE-20352 Change 3599944 by Martin.Wilson Smart name refactor - Remove guids entirely - Remove automatic fix up - Simplify smart name mapping container - Make animations deterministic for cooking #jira UEAP-264 Change 3600133 by Benn.Gallagher Fixed crash shutting down editor with active cloth paint tab, as mode manager was being used unsafely. #jira UE-48612 Change 3600166 by Benn.Gallagher Fixed cloth paint gradient allowing invalid values #jira UE-48114 Change 3600719 by Lina.Halper PR #3894: PlayMontage node bug Fix (Contributed by ArCorvus) Change 3601668 by Jurre.deBaare Improve BlendSpace preview pin dragging controls #fix Click and drag now also works for the preview pin which should allign it with other pins on the grid and makes the preview functionality more discoverable #misc Also added tooltips on the grid to make the functionality more discoverable #jira UE-43011 Change 3601669 by Jurre.deBaare No easy way to tell which Blend Sample in the blend graph matches up to which Blend Sample in the Asset Details panel #fix I've added the SampleIndex to the names to make it easier recognizing which one is which #jira UE-46892 Change 3601731 by Benn.Gallagher Fixed cloth paint falloff to actually calculate falloff, and take brush strength into account. #jira UE-48329 Change 3601897 by Lina.Halper fixing issue with sequencer reinitialization #jira: UE-48556 Change 3602339 by Benn.Gallagher Fixed comment/tooltip typo Change 3602502 by Benn.Gallagher Fixed clothing gradient tool renderer not showing selected points when camera was moving #jira UE-48331 Change 3602664 by Ethan.Geller Unshelved fixes from Dev-VR Change 3602726 by Lina.Halper Back out revision 3 from //UE4/Dev-AnimPhys/QAGame/QAGame.uproject #jira: UE-48700 Change 3603011 by Lina.Halper Fix build error Change 3604139 by Benn.Gallagher Restricted painter processing to no longer attempt painting while in simulation previews in cloth paint mode. #jira UE-47960 Change 3604284 by Benn.Gallagher Fixed crashes in physics asset editor and skeletal mesh editor when the preview scene clears out the preview mesh while clothing is running #jira UE-48687 Change 3604612 by Lina.Halper Fix curve issue from automation test - It was actual bug. Change 3604614 by Lina.Halper - Fix crash with macro anim notify - Make sure macro anim notify doesn't show up in the menu #jira: UE-45036 Change 3604725 by Lina.Halper fixed issue with opening state machine from anim graph #jira: UE-48726 Change 3604971 by Aaron.McLeran #jira UE-48738 Launching Oculus Rift without -VR plays audio in the oculus rift. Bringing fix from 4.17 to Dev-AnimPhys Change 3605787 by Aaron.McLeran Adding ability to pass in an optional owner in PlaySound2D and PlaySoundAtLocation BP calls - This is necessary in order to use the sound concurrency "limit by owner" feature Change 3606851 by Jurre.deBaare UE4Editor Static Analysis Win64 - Warning fix Change 3607022 by Lina.Halper Fix static analysis warning Change 3607229 by Jurre.deBaare RemoveAllCurveData should not allow removing data from the Skeleton #jira UE-48107 Change 3607660 by Martin.Wilson Live link client can run in cooked builds too #jira UEAP-306 Change 3607668 by Ethan.Geller #jira UE-48792 fix null dereference case in audiodevice.cpp Change 3607734 by Lina.Halper LOD linking to curve - consolidated to one param - curve eval option - for long time, looking at why morphtarget wasn't working on LOD 1, later realized it was due to simplified :( - fixed to make sure param to clear is always checking with default value - this is correct behavior and it's not too bad for perf because internally the default value is also in the TMap - flipped meaning to align with bAllowCurveEvaluation - also fixed issue with orion cooking - where transform curves are added as normal curves #jira: UE-37996, UE-48782 Change 3607859 by Martin.Wilson Missed files from live link editor checkin Change 3607958 by Martin.Wilson Redo Jurre's changes from CL 3607229 (were removed by CL 3607734) Change 3608566 by Ethan.Geller change include to avoid header conflicts on Linux Change 3609074 by Ethan.Geller Take 2: Fix capitalization on include, fix Linux build. Change 3610024 by Lina.Halper Fix issue with material editor crashing due to missing load module of AdvancedPreviewScene - we used to load advanced preview setting by persona module - this has been moved to persona tool kit, and now all other modules are crashing - If we want to do it for tool kit, we have to make sure all other editor's loading should change also. #jira: UE-48809 Change 3610081 by Jurre.deBaare Animations can't be set on blend samples from the dropdown #fix Skeleton asset registry tag now includes 'AssetTypeName' PathToAsset, so replacing compare with contains #jira UE-48746 Change 3610088 by Jurre.deBaare Editor crashes if you CtrlZ several times after adding animations to a 1D blendspace #fix removed the hacky OnObjectPropertyChanged and tied the refresh into propertyhandles instead #misc found out of sync widget values due to incorrect encapsulation inside of lambdas #jira UE-48741 Change 3610862 by Ethan.Geller Fix submix effects for situations where number of input channels does not equal output channels Change 3611346 by Aaron.McLeran Using audio thread platform affinity mask for audio render thread. Change 3613297 by Ethan.Geller Simple delay submix Change 3614435 by Martin.Wilson CIS fix Change 3614482 by Martin.Wilson Store root motion on anim instance instead of proxy to avoid thread safety stalls #jira UE-46896 Change 3614483 by Martin.Wilson Evaluate curves in anim offsets #jira UE-47119 Change 3614495 by Jurre.deBaare Reimport alembic file with new source option does not automatically tick any tracks #fix If no tracks are set to import, reset them all to do so (we're assuming here the user is importing something completely different, and we wouldn't want her to import an empty animation either) #jira UE-46141 Change 3614645 by Thomas.Sarkanen Fixed physics assets not simulating when BlockAll was globally overridden Persona viewport was overriding the collision profile back to BlockAll, which projects can override. Setting to the internal PhysicsActor profile prevents this, as it used to in PhAT #jira UE-48591 - Physics assets not simulating correctly in Orion Change 3614683 by Lina.Halper Fixed crash when modifying default physicsasset #jira: UE-48844 Change 3614721 by Jurre.deBaare Vertex painting on skeletal meshes bound by physics asset #fix Now try and find intersecting triangle if we do hit the mesh bounds, but not any physics bodies #jira UE-48004 Change 3614730 by Thomas.Sarkanen Fixed crash when regenerating multi convex hulls from zero-vert bones We handled this in the single convex hull case, but multi did not. #jira UE-48780 - Editor crashes if you regenerate a box body to a complex hull body Change 3614763 by Jurre.deBaare Moving over: HLOD crash when dragging and dropping actors into their own cluster in the HLOD outliner - ALODActor #jira UE-48249 #fix ensure that we nullptr check the static mesh as a LODActor can be reset to have a null static mesh Change 3615029 by Lina.Halper Fix issue with highlight #jira: UE-48855 Change 3617593 by Thomas.Sarkanen Fixed crash when regenerating large amounts of bodies We were overflowing the PhysX shape limit for aggregates - this refers to shapes, not bodies, it seems #jira UE-48606 - Crash when adding new multi convex hull body to bone on skeleton that already has multi convex hull bodies Change 3617609 by Jonathan.Poncelet Fixed crash that could occur when opening a physics asset and deleting bones. #jira UE-48971 Editor crashes if you clear a preview mesh on a physics asset and delete the bones when reopening it Change 3617723 by Thomas.Sarkanen Prevented actors & components of anim preview scenes (and the preview scenes themselves) from persisting after editors are shut down Fixed up 2 locations where the persona toolkit was being held onto by a strong ptr (cloth paint and new PhAT). This should stop the preview scene from persisting. Moved AddToRoot pattern used for anim preview scene to FGCObject #jira UE-47227 - [CrashReport] UE4Editor_Persona!TSharedPtr<IEditableSkeleton,0>::ToSharedRef() [sharedpointer.h:794] #jira UE-47717 - SkelMesh Editor creates preview World, but it never gets destroyed Change 3617818 by Benn.Gallagher Final v1 UX changes for clothing tool, and removed experimental flag Change 3617937 by Jurre.deBaare Default bounds for Alembic skel-mesh are too large #fix bounds was initialised to zero and +-ed which meant that it would always include (0,0,0) and enlarge the bounds #jira UE-47139 Change 3618187 by Ethan.Geller Implement Audiomixer in HTML5 Change 3618188 by Lina.Halper Fix issue with highlight in persona #jira: UE-49020 Change 3618229 by Lina.Halper Fix crash on exit when modify is causing it to serialize again in the middle of tear down #jira: UE-48025 Change 3618248 by Lina.Halper fix issue by workaround where clamp is not happening with allowspin is false #jira: UE-47001 Change 3618289 by Aaron.McLeran Removing audio format types we're not using for simplicity Change 3618291 by Martin.Wilson Fix duplicate of curve name appearing in list when renaming #jira UE-49041 Change 3618390 by Aaron.McLeran Removing a case for DTYPE_Xenon since this is never used. Change 3618425 by Martin.Wilson Keep notify UI up to data across multiple editors when adding notifies to an animation #jira UE-48104 Change 3619023 by Aaron.McLeran Removing DTYPE_Xenon from XAudio2Buffer.cpp since it's not used Change 3619129 by Aaron.McLeran Source bus feature. - New architectural feature for audio mixer that allows audio sources to route to other audio sources. - Buses can be routed to each other - Buses have a duration which can be set in bus asset - Buses can choose between mono and stereo channels - Sources can send to buses and also toggle to *only* output to buses (and bypass submixing) - Will allow persistent source effects on different source audio, while also maintaining 3d spatialization capabilities. Lots of future features will build on this change: 3d audio-volume-based submixing, sidechaining, environment reflections, diagetic microphones, etc. - Some engine changes and optimizations: - Format conversion to float is done in async workers for decode vs the render callback - Procedural sound waves can opt to output only float vs int16 PCM data (avoids a format conversion in audio mixer) - Apply master attenuation at the final output vs per-source - Fixed code that performs fade in/fade out for smooth startup and shutdown. - Moved FSourceParam to FParam into DSP utility so others can use it. - Some engine fixes: - Audio spat plugins that are external sends will not send audio to default/base submix. But will also allow their audio to be panned and sent to submix sends (e.g. reverb) so external HRTF rendering can also get reverb effects, etc. - Fixed an issue with pause - Fixed an issue with the final source buffer in a source voice not getting properly rendered and causing discontinuties - Fixed an issue with WorldID not getting set for listeners TODO: - fill out source bus details panel customization to hide USoundBase params which aren't relevant to source buses Change 3619159 by Ethan.Geller #jira UE-48950 fix steam audio crash on editor exit Change 3619555 by Jonathan.Poncelet Fixed constraint debug drawing arrows in the physics asset editor being too large. #jira UE-48863 Limited constraints and free constraints are much larger on screen Change 3619574 by Thomas.Sarkanen Fixed debug link for animation blueprints not persisting when changing preview mesh Anim instance is no longer re-created all the time when setting skeletal mesh, so we need to re-init the preview instance and re-set the linked skeletal mesh component manually when the mesh changes. #jira UE-46642 - Switching Preview mesh when you've selected an AnimBP breaks the link between the AnimBP and PIE session Change 3619586 by Thomas.Sarkanen Fixed physics asset shortcut not working correctly in certain circumstances FBox was using uninitialized memory #jira UE-49034 - Pressing F to focus on a physics body focuses on the area in between the root and the physics body and not the selected body Change 3619640 by Thomas.Sarkanen Assets with no preview mesh now no longer allow access to other skeleton's physics assets in their shortcut bars Unified the skeleton/mesh search code between FPersonaAssetFamily and FPersonaToolkit, so they bot *look* for a compatible skeletal mesh if one was not found on the asset (but still dont set it automatically). #jira UE-49038 - If you open a skeleton or an animation it won't open persona with the correct physics asset in the quick switch bar Change 3619644 by James.Golding Change FBodyInstance::InstanceBodyIndex back to int32 (need to support ISMC with many instances) #jira UE-47652 Change 3619654 by Martin.Wilson Fix removing a curve when it isn't used on any animations #jira UE-49048 Change 3619771 by Thomas.Sarkanen Make sure the physics asset editor floor has collision, regardless of what BlockAll does #jira UE-49088 - PhysicsAsset Editor Floor should not depend on BlockAll config Change 3619803 by Jonathan.Poncelet Fixed localization warnings caused by duplicate keys. #jira UE-48580 //UE4/Main: Step "Build Engine Localization" has completed with 4 Warnings Change 3619813 by Jurre.deBaare Baked bones using a pose animation are rotated in the wrong direction #fix root bone transform wasn't being taken into account while generating final bone transforms #misc added debug logging for future work #jira UE-47362 Change 3619830 by Jurre.deBaare Biased Texture Size option is not functioning when Merging Actors #fix Fixed up material baking setup after refactoring, now sets correct texture sizes again according to texture sizing type, this will be removed in the long term anyhow #misc Found a bug in material rendering if previous render size < current render size it would not set the viewport size/projection matrix correctly which broke the material bake #jira UE-48108 Change 3619859 by Thomas.Sarkanen Fixed HLOD selection sphere persisting on undo/redo Removed HLOD selection actors when the outliner is refreshed #jira UE-47032 - HLOD Cluster radius sphere remains in level if you move an actor in a cluster and then undo the movement. Change 3619871 by Martin.Wilson Calculate root motion over the correct segment times, not the track times #jira UE-43719 Change 3619898 by Thomas.Sarkanen Improve UI feedback around bounds/in-game bounds in animation editor viewports Tooltip for in-game bounds is now more detailed In-game bounds cannot be selected if bounds is not also selected #jira UE-47958 - Bound vs In-game Bound in Viewport Show menu in Physics Asset Editor is confusing Change 3619908 by Thomas.Sarkanen Fixed tooltip for PhysicsType #jira UE-48421 - Incorrect tooltip for Physics Type Change 3620014 by Jurre.deBaare Only the first mesh bake material property in the array can be set to diffuse, diffuse cannot be selected on the other array elements #fix Changed the way the restriction is setup and retrieve the UMaterialOptions from the details view instead of GetDefault<> #misc Also added more delegates to ensure the restriction is up to date #jira UE-46980 Change 3620104 by Jurre.deBaare HLOD doesn't support renaming in levels #fix ensure that during renaming of UWorld we also rename the HLOD assets into their respective new HLOD package outer #jira UE-48072 Change 3620151 by Thomas.Sarkanen Undo/redo now correctly affects animation preview scene settings Preview scene desc is now transactional & state is correctly set up on undo/redo according to the current preview scene desc #jira UE-47816 - Undoing setting the animation mode to Refrence pose doesn't update the UI Change 3620152 by Thomas.Sarkanen Exposed LOD menu in PhAT This allows auto LOD to be optionaly selected. It was hidden and we forced to LOD 0 before. We still default to forcing LOD 0 to preserve the old behavior. #jira UE-47970 - LODs not working in Physics Asset Editor Change 3620177 by Benn.Gallagher PR #3696: Fix for USkinnedMeshComponent::GetCPUSkinnedVertices() (Contributed by Koderz) Change 3620250 by Jurre.deBaare HLOD assets left in HLOD folder when clusters are deleted #fix some added lifetime management for HLOD assets, keeping list of 'stale' HLOD assets which if not Undo-ed will either be deleted when LODActor is saved, or marked PendingKill when LODActor is destroyed #jira UE-47450 Change 3620273 by James.Golding PR #3908: Removing duplicated forward declation (Contributed by celsodantas) #jira UE-48530 Change 3620274 by James.Golding PR #3909: Removing unnecessary conditional (Contributed by celsodantas) #jira UE-48531 Change 3620275 by James.Golding Add icon for destruction plugin Change 3620401 by Ethan.Geller #jira UE-47684 Remove SDL dependencies from Win64 Change 3620586 by Jurre.deBaare Linux CIS fix Change 3620660 by Martin.Wilson Fixes for state machines getting reinitialized in situations that users don't want them to. -Added option to state machine to allow it to skip reinitialization when it becomes relevant -Added option to slot nodes to keep source pose relevant while montage slot is playing. #jira UE-43578 Change 3620665 by Aaron.McLeran Making source buses only show relevant source bus data. - hiding sound wave categories that aren't relevant to source buses Change 3621087 by Ethan.Geller #jira UE-49000 implement device change listener to ensure we are properly handling when audio is disabled. Change 3621144 by Aaron.McLeran #jira UE-49147 #jira UE-49145 Fixing concurrency and volume stats Change 3621148 by Aaron.McLeran Fixing typo Change 3621180 by Ethan.Geller #jira UE-49151 Fix for browser preview on bus only sounds Change 3621421 by Ethan.Geller #jira UE-49165 Fix real time audio slider. Change 3621604 by Ethan.Geller #jira UE-44847 fix iOS panning algorithm on non-audio mixer Change 3621626 by Lina.Halper Fix issue with anim montage displaying when selecting animation #jira: UE-48749 Change 3621813 by Thomas.Sarkanen Fixing undo/redo of bone modifications in Physics Asset Editor (and others) Bone proxy objects now get recycled (instead of the pool constantly growing) as their names are stable and unique. Fixed broken skeleton tree RTTI (so selection persistance now works correctly on undo/redo again) We no longer force a re-selection on phyiscs asset changes (the tree takes care of that anyway). #jira UE-47862 - Undoing Bone transformations in Physics Asset Editor does not work Change 3621831 by Jurre.deBaare Crash fix for Material baking when trying to analyse a MP_MAX material property #jira UE-49172 Change 3621936 by Thomas.Sarkanen Fixed CIS error from merge Change 3621937 by Thomas.Sarkanen Fix merge issue with API change in USynthComponent Change 3622173 by Thomas.Sarkanen Fixed ortho viewports being bright white in sub-editors Preview scenes in general are responsible by default for the background color. Advanced preview scenes now use background color from settings. Previously only te animation editors did this. #jira UE-48841 - The background of the orthographic viewports is bright white Change 3622730 by Ethan.Geller #jira UE-49182 UE-49198 UE-49201 Fix for channel mismatch in procedural sound waves, remove singleton behavior for MMNotificationClient. CL by Aaron.McLeran Change 3622759 by Ethan.Geller #jira 49170 reduce static analysis warnings for audiodevice.cpp Change 3622901 by Benn.Gallagher Bumped PhysX DDC key after change in Orion caused verify failures Change 3623458 by Aaron.McLeran #jira UE-49204 Delores monologue cut short in Odin elevator Change 3623667 by Aaron.McLeran #jira UE-49204 UE-49243 Delores monologue cut short in Odin elevator Change 3623752 by Aaron.McLeran #jira UE-49247 Sound Source Bus Properties Are Inappropriate Fixing issues with new source bus uobject so properties show up appropriately. Change 3624058 by Ben.Marsh Fix stale module being enumerated when running UE4Editor-Cmd.exe, causing warning when running incremental automated tests. Module and version manifest filenames are derived from the executable filename, so when running the executable compiled for the console subsystem, we need to strip the -Cmd suffix from the executable name to find the correct path. Change 3624193 by Ethan.Geller #jira UE-49170 Static analysis fix, take 2 Change 3354003 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3477632 by Jurre.deBaare Automated test content and ground truths for Actor Merging and Material baking functionality Change 3491464 by Jurre.deBaare Updated automation content for MergeActor behaviour Change 3587878 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3587489 Change 3597452 by Ethan.Geller #jira UEAP-304, UEAP-280, UEAP-281: Major structural refactor of Audio Plugin interfaces, Oculus Audio plugin, Steam Audio Plugin. Introduction of Sony Audio3D plugin. Change 3602935 by Lina.Halper Allow curve evaluation to be controlled by users #jira: UE-46446 Change 3606120 by Ethan.Geller Move Tap Delay Submix to Synthesis library, modify tap delay API Change 3621830 by Thomas.Sarkanen Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3621691 Change 3622807 by Ethan.Geller #jira UE-49201 Fixing volume issues Issue is that these platforms weren't using the proper public function and an audio mixer refactor changed how volume is calculated to seperate out distance attenuation vs other volume gains. [CL 3624383 by Thomas Sarkanen in Main branch]
2017-09-04 04:17:46 -04:00
}
void FPhysicsAssetEditorEditMode::HitNothing(FEditorViewportClient* InViewportClient)
{
if (InViewportClient->IsCtrlPressed() == false) //we only want to deselect if Ctrl is not used
{
SharedData->ClearSelectedBody();
SharedData->ClearSelectedConstraints();
}
InViewportClient->Invalidate();
PhysicsAssetEditorPtr.Pin()->RefreshHierachyTree();
}
#undef LOCTEXT_NAMESPACE